git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
   2
   3         (modest_wizard_dialog_force_title_update):
   4         * src/maemo/easysetup/modest-wizard-dialog.h:
   5         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
   6         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
   7         can update the title when appropriate. Otherwise the title is wrong if the
   8         pages are added after adding the notebook to the dialog.
   9         This must be a problem in HildonWizardDialog too.
  10         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
  11
  12         * src/maemo/easysetup/modest-easysetup-wizard.c:
  13         (create_subsequent_customsetup_pages),
  14         (create_subsequent_easysetup_pages):
  15         Call modest_wizard_dialog_force_title_update() so that the title is
  16         correct even with GTK+ < 2.10.
  17         This fixes projects.maemo.org bug NB#56145 .
  18
  19 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  20
  21         * src/maemo/modest-platform.c:
  22         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
  23         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
  24         from being shown.
  25
  26 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  27
  28         * src/widgets/modest-window.h:
  29         * src/widgets/modest-window.c: Added a save_state_func vfunc,
  30         and modest_window_save_state(), which invokes it.
  31
  32         * src/widgets/modest-window-mgr.h:
  33         * src/widgets/modest-window-mgr.c:
  34         Added modest_window_mgr_save_state_for_all_windows(), which calls
  35         the save_state vfunc on all registered windows, if implemented.
  36
  37         * src/gnome/modest-msg-edit-window.c:
  38         * src/gnome/modest-msg-view-window.c:
  39         * src/maemo/modest-msg-edit-window.c:
  40         * src/maemo/modest-msg-view-window.c:
  41         * src/maemo/modest-main-window.c:
  42         Specify the existing save_settings functions as implementations of
  43         ModestWindow::save_state_func().
  44
  45         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
  46         Call modest_window_mgr_save_state_for_all_windows(). This happens before
  47         enabling hibernation, for instance.
  48
  49         We may need to do the same thing for restoring settings.
  50
  51
  52 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  53
  54         * src/widgets/modest-window-mgr.c:
  55         * src/widgets/modest-window-mgr.h:
  56         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
  57         modest_window_mgr_get_hibernation_is_prevented().
  58
  59         * src/maemo/modest-main-window.c:
  60         (on_hildon_program_is_topmost_notify): Prevent hibernation
  61         (possible when the application goes to the background in the WM),
  62         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
  63
  64         * src/maemo/easysetup/modest-easysetup-wizard.c:
  65         (modest_easysetup_wizard_dialog_init):
  66         * src/maemo/modest-account-settings-dialog.c:
  67         (modest_account_settings_dialog_init):
  68         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  69         (modest_connection_specific_smtp_edit_window_init):
  70         * src/maemo/modest-connection-specific-smtp-window.c:
  71         (modest_connection_specific_smtp_window_init):
  72         * src/maemo/modest-signature-editor-dialog.c:
  73         (modest_signature_editor_dialog_init):
  74         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
  75         prevent hibernation while any of these account settings dialogs are open.
  76
  77 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
  78
  79         * src/maemo/Makefile.am:
  80         * src/maemo/modest-osso-state-saving.c:
  81         * src/maemo/modest-osso-state-saving.h: Added
  82         modest_osso_load_state() and modest_osso_save_state() though they do
  83         nothing now. They should iterate through all the open windows and load/save
  84         their state.
  85         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
  86         save state when closing.
  87
  88         * src/maemo/modest-main-window.c:
  89         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
  90         Add a notification handler for the HildonProgram::is-topmost property,
  91         so we can allow hibernation when the application goes into the background.
  92         But we still need to detect when the accounts setup windows are open so
  93         we can stop hibernation when they are open.
  94         To do this, I also added the main window the HildonProgram. This might have
  95         other side-effects/benefits, and should maybe be done for other windows.
  96
  97         * src/maemo/modest-osso-autosave-callbacks.h:
  98         * src/maemo/modest-osso-autosave-callbacks.c:
  99         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 100         though it does not do anything yet, and we might never need this to do
 101         anything. For instance, we already save drafts.
 102
 103         * src/maemo/modest-platform.c: (modest_platform_init):
 104         Specify the libosso auto-save callback.
 105
 106 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 107
 108         * src/maemo/modest-platform.c:
 109         (modest_platform_set_update_interval):
 110         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 111         aparently stays valid between application instances, so we can use this
 112         to remove and reset it later. According to a maemo-developers email from
 113         David Weinehall.
 114
 115 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 116
 117         * configure.ac: Depend on libalarm for Maemo.
 118
 119         * src/dbus_api/modest-dbus-api.h:
 120         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 121         (on_send_receive), (modest_dbus_req_handler):
 122         Handle a SEND_RECEIVE D-Bus method.
 123
 124         * libmodest-dbus-client/libmodest-dbus-client.c:
 125         (libmodest_dbus_client_send_and_receive):
 126         * libmodest-dbus-client/libmodest-dbus-client.h:
 127         Add C convenience functions for calling the new D-Bus method.
 128
 129         * src/modest-platform.h:
 130         * src/gnome/modest-platform.c:
 131         * src/maemo/modest-platform.c:
 132         Added modest_platform_set_update_interval(), which uses the
 133         alarmd API on Maemo.
 134         (modest_platform_init),
 135         Call modest_platform_set_update_interval(), using a hard-coded
 136         interval for now (until the global settings dialog is implemented),
 137         though I am not sure that this makes sense yet.
 138
 139 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 140
 141         * src/dbus_api/modest-dbus-callbacks.c:
 142         (modest_osso_cb_hw_state_handler):
 143         * src/dbus_api/modest-dbus-callbacks.h:
 144         * src/maemo/modest-platform.c: (modest_platform_init):
 145         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 146         in case this has some effect on the ability for Maemo to ping the
 147         application.
 148
 149 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 150
 151         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 152         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 153         warning. It is probably a logic error, but I need to fix the build.
 154
 155 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 156
 157         * src/modest-account-mgr.h:
 158         * src/modest-account-mgr.c:
 159         (modest_account_mgr_account_names): Add a gboolean enabled_only
 160         parameter, so we can get lists of onlt the enabled accounts.
 161
 162         (modest_account_mgr_add_account),,
 163         (modest_account_mgr_account_with_display_name_exists):
 164         * src/maemo/modest-msg-edit-window.c: (get_transports):
 165         * src/modest-account-mgr-helpers.c:
 166         (modest_account_mgr_set_first_account_as_default):
 167         * src/modest-init.c: (init_default_account_maybe):
 168         * src/modest-tny-account-store.c: (get_accounts):
 169         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 170         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 171         * tests/check_account-mgr.c: (START_TEST):
 172         Provide the extra parameter, as appropriate.
 173
 174         * src/widgets/modest-account-view.c: (update_account_view):
 175         Do not show disabled accounts (meaning that there is no way to
 176         enable/disable accounts in the UI (the feature is not in our UI
 177         specification), so we can use this internally only to mark unfinished
 178         or temporary account data.
 179
 180         * src/maemo/easysetup/modest-easysetup-wizard.c:
 181         (create_account): Add boolean enable parameter, so we can specify FALSE
 182         to create the temporary account.
 183         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 184         (on_before_next): When finishing, when there is a temporary account, just
 185         set it as enabled.
 186         Also, use a timeout to delay the showing of the dialog until gconf is likely
 187         to return correct information, due to a maemo gconf bug that is fixed in
 188         osso 1.1, but not yet in Bora.
 189         However, the dialog stays on screen after it is destroyed.
 190
 191         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 192         for invalid data when cancelling. Use a hildon note instead of a dialog
 193         to complain about invalid data. Do not show the account-saved note if the
 194         account is disabled (a temporary account that will not really be saved for use
 195         until later.)
 196
 197 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 198
 199         * src/modest-account-mgr-helpers.h:
 200         * src/modest-account-mgr-helpers.c:
 201         Added modest_account_mgr_unset_default_account(),
 202         Added modest_account_mgr_set_first_account_as_default().
 203
 204         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 205         If it was the default account, unset the default account name.
 206
 207         * src/maemo/modest-account-view-window.c:
 208         (on_delete_button_clicked): If it was the default account,
 209         set the first remaining account as the default instead.
 210
 211         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 212         a NULL account or a NULL default account, to prevent a crash. This should
 213         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 214
 215
 216 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 217
 218         * src/widgets/modest-recpt-editor.c:
 219         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 220         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 221         TODO comment for this. This fixes the build.
 222
 223         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 224         be the best place for it. This will in future update all auto-update accounts,
 225         rather than just the current/default account, when that gconf key exists.
 226         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 227         if there are no accounts, before calling do_send_receive().
 228         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 229
 230         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 231         * src/maemo/modest-main-window-ui.h:
 232         * src/maemo/modest-main-window.c: (on_connection_changed),
 233         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 234         directly, becaue the signal handler does more.
 235
 236 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 237
 238         * src/modest-account-mgr-helpers.c:
 239         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 240         for the case that the account does not exist.
 241
 242         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 243         (equivalent to the modest account name) rather than the tinymail account name
 244         (equivalent to the modest account title - human readable) to get the account data.
 245         Check for null account data to prevent the crash, and add a TODO comment saying that
 246         this needs fixing because it is using the server account name instead of the account name.
 247
 248 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 249
 250         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 251         * src/maemo/modest-account-settings-dialog.c: (show_error),
 252         (show_ok):
 253         Use hildon_note_new_information() for informative and error messages,
 254         which seems to be expected for Maemo applications (no documentation that I know of
 255         says this). I am surprised that there is no distinction between info and error
 256         dialogs.
 257
 258 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 259
 260         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 261         it is easy to find where this is used.
 262
 263         * src/maemo/easysetup/modest-easysetup-wizard.c:
 264         (create_page_welcome), (create_page_account_details),
 265         (create_page_user_details), (create_page_complete_easysetup),
 266         (create_page_custom_incoming), (create_page_custom_outgoing),
 267         (create_page_complete_custom):
 268         * src/maemo/modest-account-settings-dialog.c:
 269         (create_page_account_details), (create_page_user_details),
 270         (create_page_incoming), (create_page_outgoing):
 271         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 272         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 273         (modest_connection_specific_smtp_edit_window_init):
 274         * src/maemo/modest-connection-specific-smtp-window.c:
 275         (modest_connection_specific_smtp_window_init):
 276         * src/maemo/modest-signature-editor-dialog.c:
 277         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 278         and scrolling policy as per the Email Application Layout Guide, if I have
 279         understood it.
 280
 281 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 282
 283         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 284         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 285         which were empty, because these vfuncs have been removed from TnyAccountStore.
 286         This fixes the build.
 287
 288 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 289
 290         * src/maemo/modest-main-window.c:
 291         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 292         showing/hiding it. Added TODO because it probably should not be NULL.
 293         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 294         because unnecessary g_warnings() make degugging difficult.
 295
 296 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 297
 298         * src/maemo/modest-msg-edit-window.c:
 299         (modest_msg_edit_window_select_color),
 300         (modest_msg_edit_window_select_background_color): 2 const corrections and
 301         moving 2 #endifs before closing brackets, to fix the build.
 302
 303 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 304
 305         * src/maemo/easysetup/modest-easysetup-wizard.h:
 306         * src/maemo/easysetup/modest-easysetup-wizard.c:
 307         (modest_easysetup_wizard_dialog_finalize),
 308         (on_button_edit_advanced_settings), (create_page_complete_custom),
 309         (on_response), (create_account):
 310         Implement the Advanced Settings edit button, by saving the account information,
 311         for the Advanded Settings dialog to use directly from gconf, and removing it
 312         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 313         Bug #5533 in the projects.maemo.org bugzilla.
 314
 315 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 316
 317         * src/maemo/modest-msg-view-window.c:
 318         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 319         when opening a message window.
 320
 321 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 322
 323         * src/maemo/easysetup/modest-easysetup-wizard.c:
 324         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 325         match the UI spec.
 326
 327         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 328         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 329         gconf settings. I probably added more checks than necessary, but that is safer.
 330
 331         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 332         variable to fix the build, but this seems to be used when it is still NULL.
 333
 334 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 335
 336         * src/modest-platform.h:
 337         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 338         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 339         * src/modest-main.c: Implement this function so we can avoid using
 340         maemo-specific API from cross-platform code.
 341         (main):
 342         * src/modest-tny-account-store.c:
 343         (get_smtp_specific_transport_account_for_open_connection):
 344         * src/modest-ui-actions.c: (check_for_connection),
 345         (modest_ui_actions_on_item_not_found):
 346         Use modest_platform_connect_and_wait() and put #idefs around other
 347         maemo-specific code, because only maemo currently has a way to
 348         identify connection names.
 349
 350 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 351
 352         * src/modest-tny-account-store.h:
 353         * src/modest-tny-account-store.c:
 354         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 355         the connection-specific SMTP server settings in the configuration.
 356
 357         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 358         (on_idle_mail_to):
 359         * src/maemo/modest-main-window.c: (on_connection_changed),
 360         (connect_signals):
 361         * src/modest-main.c: (main), (start_ui), (send_mail):
 362         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 363         that is what is intended.
 364
 365         * src/modest-ui-actions.c: (action_send), (action_receive),
 366         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 367         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 368         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 369         SMTP server is used when it is specified.
 370
 371         (modest_ui_actions_on_send_receive):
 372         Check that a connection is open before proceeding.
 373         Receive and then send, instead of vice-versa, as per the specification.
 374
 375 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 376
 377         * src/modest-mail-operation.c:
 378         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 379         though I guess it should be something other than NULL.
 380
 381 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 382
 383         * src/maemo/easysetup/modest-easysetup-wizard.c:
 384         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 385         combo twice, to avoid an g_warning and to make it visible again.
 386         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 387         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 388         (already intended) dereference when detaching, because we then recreate the menu.
 389         But I am not sure why the warning was happening, and it is possible that this is a memory
 390         leak.
 391
 392 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 393
 394         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 395         and uri_parse_mailto() utility functions.
 396         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 397         the mailto URI.
 398         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 399
 400 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 401
 402         * src/dbus_api/modest-dbus-api.h:
 403         * src/dbus_api/modest-dbus-callbacks.c:
 404         Use an idle callback to execute the modest code in the application's own thread.
 405         Remove the helloworld example method.
 406         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 407         parsed, and the open-message method is not implemented because this is not yet implemented in
 408         modest itself.
 409         * libmodest-dbus-client/libmodest-dbus-client.c:
 410         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 411         (libmodest_dbus_client_open_message):
 412         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 413
 414         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 415         body without crashing.
 416
 417         * tests/dbus_api/Makefile.am:
 418         * tests/dbus_api/test_mail_to.c:
 419         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 420
 421 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 422
 423         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 424         Added file to fix the build. Sorry.
 425
 426         * src/dbus_api/Makefile.am:
 427         * src/dbus_api/modest-dbus-api.h:
 428         * src/dbus_api/modest-dbus-callbacks.h:
 429         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 430         (modest_dbus_req_handler):
 431         Put constants in a separate header so it can be reused by the
 432         client library, without duplication
 433
 434         * libmodest-dbus-client/Makefile.am:
 435         * libmodest-dbus-client/libmodest-dbus-client.c:
 436         (libmodest_dbus_client_call_helloworld),
 437         (libmodfest_dbus_client_send_mail),
 438         (libmodfest_dbus_client_mailto),
 439         (libmodfest_dbus_client_open_message):
 440         * libmodest-dbus-client/libmodest-dbus-client.h:
 441         (Partly) Implement a send_mail D-Bus method.
 442
 443         * tests/dbus_api/Makefile.am:
 444         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 445         the send_email D-Bus method.
 446
 447 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 448
 449         * Makefile.am:
 450         * configure.ac:
 451         * libmodest-dbus-client/Makefile.am:
 452         * libmodest-dbus-client/libmodest-dbus-client.c:
 453         * libmodest-dbus-client/libmodest-dbus-client.h:
 454         * tests/dbus_api/Makefile.am:
 455         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 456         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 457
 458 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 459
 460         * src/maemo/easysetup/modest-easysetup-wizard.c:
 461         (create_page_account_details):
 462         * src/maemo/modest-account-settings-dialog.c:
 463         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 464         widgets, because this might not be the default in future versions of the Maemo GTK+.
 465         However, I can not not get capitalization to work even in a simple test case.
 466
 467 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 468
 469         * src/maemo/easysetup/modest-easysetup-wizard.c:
 470         (create_page_custom_incoming), (create_page_custom_outgoing):
 471         * src/maemo/modest-account-settings-dialog.c:
 472         (create_page_account_details), (create_page_incoming),
 473         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 474         instead of using gtk_check_button_with_label(), so they are aligned like the other
 475         widgets, as per the UI spec.
 476
 477 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 478
 479         * src/maemo/easysetup/modest-easysetup-wizard.c:
 480         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 481         * src/widgets/modest-validating-entry.c:
 482         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 483         Modest prefix instead of an EasySetup prefix.
 484
 485 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 486
 487         * src/widgets/modest-validating-entry.h:
 488         * src/widgets/modest-validating-entry.c: (on_insert_text),
 489         Added easysetup_validating_entry_set_max_func(), used to set a callback
 490         to call when the max number of characters is reached. GtkEntry has a max-length
 491         already but is silent about it.
 492
 493         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 494         (create_page_account_details), (create_page_user_details),
 495         (create_account):
 496         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 497         (create_page_account_details), (create_page_user_details),
 498         (create_page_outgoing):
 499         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 500         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 501         the UI spec, when the user tries to enter more than the max number of characters.
 502
 503 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 504
 505         * src/maemo/easysetup/modest-easysetup-wizard.c:
 506         (create_page_user_details), (create_page_custom_incoming),
 507         (create_page_custom_outgoing):
 508         * src/maemo/modest-account-settings-dialog.c:
 509         (create_page_user_details), (create_page_incoming),
 510         (create_page_outgoing):
 511         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 512         (modest_connection_specific_smtp_edit_window_init):
 513         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 514         not appropriate. Bad Maemo-specific defaults!.
 515
 516 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 517
 518         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 519         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 520         (modest_signature_editor_dialog_set_settings):
 521         Disable the label and textview when the checkbox is disabled, and use the
 522         specified (UI spec) default signature text.
 523
 524 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 525
 526         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 527         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 528
 529         * src/modest-defs.h:
 530         * src/modest-account-mgr-helpers.h:
 531         * src/modest-account-mgr-helpers.c:
 532         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 533
 534         * src/maemo/Makefile.am:
 535         * src/maemo/modest-signature-editor-dialog.c:
 536         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 537         as per the UI spec.
 538
 539         * src/maemo/modest-account-settings-dialog.h:
 540         * src/maemo/modest-account-settings-dialog.c:
 541         (modest_account_settings_dialog_finalize), (on_button_signature),
 542         (save_configuration): Use the new dialog when the Edit button is pressed, and
 543         save the changes if necessary, as per the UI spec.
 544
 545 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 546
 547         * src/maemo/Makefile.am:
 548         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 549         based on maemo-develoers email from Dirk.
 550
 551         * src/maemo/easysetup/modest-easysetup-wizard.c:
 552         (create_page_welcome), (create_page_account_details),
 553         (create_page_user_details), (create_page_complete_easysetup),
 554         (create_page_custom_incoming), (create_page_custom_outgoing),
 555         (create_page_complete_custom),
 556         (modest_easysetup_wizard_dialog_init):
 557         * src/maemo/modest-account-settings-dialog.c:
 558         (create_page_account_details), (create_page_user_details),
 559         (create_page_incoming), (create_page_outgoing),
 560         (modest_account_settings_dialog_init):
 561         * src/maemo/modest-connection-specific-smtp-window.c:
 562         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 563
 564 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 565
 566         * src/maemo/easysetup/modest-easysetup-wizard.c:
 567         (create_page_account_details), (create_page_custom_outgoing),
 568         (create_page_complete_custom):
 569         * src/maemo/modest-account-settings-dialog.c:
 570         (create_page_user_details), (create_page_incoming),
 571         (create_page_outgoing):
 572         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 573         (modest_connection_specific_smtp_edit_window_init):
 574         Use the correct (UI spec) port min/max, and use horizontal separators,
 575         as per the UI spec.
 576
 577 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 578
 579         * src/maemo/easysetup/modest-easysetup-wizard.c:
 580         (set_default_custom_servernames):
 581         * src/maemo/modest-account-settings-dialog.c:
 582         (create_page_incoming), (on_combo_outgoing_security_changed),
 583         (on_combo_incoming_security_changed), (create_page_outgoing),
 584         (modest_account_settings_dialog_set_account_name),
 585         (save_configuration):
 586         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 587         (on_combo_security_changed),
 588         (modest_connection_specific_smtp_edit_window_init),
 589         (modest_connection_specific_smtp_edit_window_set_connection),
 590         (modest_connection_specific_smtp_edit_window_get_settings):
 591         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 592         as per the UI spec.
 593
 594 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 595
 596         * po/en_GB.po:
 597         * src/maemo/easysetup/modest-easysetup-wizard.c:
 598         (create_page_custom_outgoing), (create_page_complete_custom):
 599         * src/maemo/modest-account-settings-dialog.c:
 600         (create_page_user_details), (create_page_outgoing):
 601         * src/maemo/modest-account-view-window.c: (button_box_new):
 602         Use changed logical IDs as per the most recent UI spec:
 603         mcen_bd_emailsetup_edit -> mcen_bd_edit
 604         mcen_bd_emailsetup_delete -> mcen_bd_delete
 605         mcen_bd_emailsetup_close -> mcen_bd_close
 606
 607 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 608
 609         * configure.ac:
 610         * src/Makefile.am:
 611         * src/dbus_api/Makefile.am:
 612         * src/dbus_api/modest-dbus-callbacks.c:
 613         * src/dbus_api/modest-dbus-callbacks.h:
 614         * src/maemo/modest-platform.c: (modest_platform_init):
 615         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 616         method.
 617         * tests/Makefile.am:
 618         * tests/dbus_api/Makefile.am:
 619         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 620
 621 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 622
 623         * src/maemo/modest-account-settings-dialog.c:
 624         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 625         Removed unnecessary includes.
 626
 627 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 628
 629         * src/maemo/easysetup/modest-easysetup-wizard.c:
 630         * src/maemo/modest-account-settings-dialog.c:
 631         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 632         * src/widgets/Makefile.am:
 633         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 634         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 635         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 636         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 637         * src/widgets/modest-secureauth-combo-box.c:
 638         * src/widgets/modest-secureauth-combo-box.h:
 639         * src/widgets/modest-serversecurity-combo-box.c:
 640         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 641         made the GObject names more consistent with the rest of the Modest code.
 642
 643 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 644
 645         * src/maemo/easysetup/Makefile.am:
 646         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 647         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 648         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 649         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 650         * src/maemo/easysetup/modest-easysetup-wizard.c:
 651         * src/maemo/easysetup/modest-validating-entry.c:
 652         * src/maemo/easysetup/modest-validating-entry.h:
 653         * src/maemo/modest-account-settings-dialog.c:
 654         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 655         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 656         widgets/ because they are used outside of easysetup too. After checking in,
 657         svn will allow me to rename them too.
 658
 659 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 660
 661         * src/gnome/modest-msg-edit-window.c:
 662         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 663         linker error, to fix the build on the GNOME platform.
 664         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 665         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 666         ifdefed out to avoid a warning.
 667
 668 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 669
 670         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 671         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 672         some alternative for GTK+ 2.6.
 673
 674 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 675
 676         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 677
 678         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 679         specified for EmailAccountsDialog in UI spec.
 680
 681         * src/maemo/easysetup/modest-easysetup-wizard.c:
 682         * src/maemo/easysetup/modest-easysetup-wizard.h:
 683         * src/maemo/modest-account-settings-dialog.c:
 684         * src/maemo/modest-account-settings-dialog.h:
 685         Reuse a member window widget for the connection-specific SMTP server accounts,
 686         so we can tell it to create/save the accounts only if we actually save changes.
 687
 688         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 689         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 690         (modest_connection_specific_smtp_edit_window_get_settings):
 691         Return a struct instance for temporarily remembering the entered data.
 692
 693         * src/maemo/modest-connection-specific-smtp-window.h:
 694         * src/maemo/modest-connection-specific-smtp-window.c:
 695         (modest_connection_specific_smtp_window_finalize),
 696         (modest_connection_specific_smtp_window_fill_with_connections),
 697         (on_button_edit),
 698         (modest_connection_specific_smtp_window_save_server_accounts),
 699         (update_model_server_names): Do not actually save data until asked,
 700         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 701
 702         (on_selection_changed),
 703         (modest_connection_specific_smtp_window_init): Disable the edit
 704         button when nothing is selected.
 705
 706         * src/modest-account-mgr-helpers.c:
 707         * src/modest-account-mgr-helpers.h:
 708         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 709         elsewhere.
 710
 711 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 712
 713         * src/modest-account-mgr-helpers.h:
 714         * src/modest-account-mgr-helpers.c:
 715         (modest_account_mgr_get_unused_account_name),
 716         (modest_account_mgr_get_unused_account_display_name): Added these
 717         utility functions, to avoid code duplication.
 718
 719         * src/maemo/easysetup/modest-easysetup-wizard.c:
 720         (create_page_account_details), (create_account):
 721         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 722         (on_combo_security_changed),
 723         (modest_connection_specific_smtp_edit_window_init),
 724         (modest_connection_specific_smtp_edit_window_save_settings):
 725         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 726         * src/maemo/modest-connection-specific-smtp-window.c:
 727         (modest_connection_specific_smtp_window_finalize),
 728         (modest_connection_specific_smtp_window_fill_with_connections),
 729         (on_button_edit), (modest_connection_specific_smtp_window_init):
 730         * src/maemo/modest-connection-specific-smtp-window.h:
 731         Implementing saving of connection-specific server accounts.
 732
 733         But I need to refactor this so we can save the data for each
 734         possible connection-specific account and only actually create the server accounts
 735         when the easysetup finished, or the OK button is pressed on the account settings
 736         dialog.
 737
 738 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 739
 740         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 741         (on_combo_security_changed):
 742         (modest_connection_specific_smtp_edit_window_init):
 743         Auto-fill the port number as in the account settings.
 744
 745         (modest_connection_specific_smtp_edit_window_set_connection):
 746         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 747         * src/maemo/modest-connection-specific-smtp-window.c:
 748         (fill_with_connections), (on_button_edit),
 749         (modest_connection_specific_smtp_window_init):
 750         Turn the edit window into a dialog to simplify the code, and
 751         set a WM hint as in a GtkDialog, because only a popup can be on top of
 752         another window in Maemo, and popups usually have no WM decoration.
 753
 754         * src/modest-defs.h:
 755         * src/modest-account-mgr-helpers.c:
 756         (modest_account_mgr_set_connection_specific_smtp),
 757         (modest_account_mgr_remove_connection_specific_smtp),
 758         (modest_account_mgr_get_connection_specific_smtp):
 759         * src/modest-account-mgr-helpers.h: Some functions to write the
 760         connection-specific SMTP server information. Not yet used.
 761
 762
 763         * src/widgets/modest-folder-view.c: (text_cell_data):
 764         Fix a warning about an uninitialized variable.
 765         (on_configuration_key_changed): Put an #ifdef around the use
 766         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 767
 768 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 769
 770         * src/maemo/modest-account-settings-dialog.h:
 771         * src/maemo/modest-account-settings-dialog.c:
 772         Added connect_for_modified() utility function to mark the new modified boolean.
 773
 774         (create_page_account_details), (create_page_user_details),
 775         (create_page_incoming), (create_page_outgoing), (on_response),
 776         (modest_account_settings_dialog_init),
 777         (modest_account_settings_dialog_set_account_name):
 778         Only warn about unsaved changes when there are actually unsaved changes.
 779
 780         * src/modest-account-mgr-helpers.c:
 781         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 782         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 783         to get the data from there in future.
 784
 785 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 786
 787         * src/modest-defs.h:
 788
 789         * src/modest-account-mgr-helpers.h:
 790         * src/modest-account-mgr-helpers.c:
 791         Store the security account setting in a single conf key instead of using
 792         the options list, so that the list is left for just the to-be-removed camel hack,
 793         and because gconf_client_set_list() is failing for some reason.
 794
 795         * src/modest-account-mgr.c:
 796         (modest_account_mgr_add_server_account):
 797         * src/maemo/modest-account-settings-dialog.c:
 798         (modest_account_settings_dialog_set_account_name),
 799         (save_configuration): Use the renamed functions.
 800
 801
 802 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 803
 804         * src/widgets/Makefile.am:
 805         * src/widgets/modest-limit-retrieve-combo-box.c:
 806         * src/widgets/modest-limit-retrieve-combo-box.h:
 807         * src/widgets/modest-retrieve-combo-box.c:
 808         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 809         the account settings dialog.
 810
 811         * src/modest-defs.h:
 812         * src/modest-account-mgr-helpers.h:
 813         * src/modest-account-mgr-helpers.c:
 814         (modest_server_account_get_option_secure_auth),
 815         (modest_server_account_set_option_secure_auth):
 816         * src/modest-account-mgr.c:
 817         (modest_account_mgr_add_server_account):
 818         Use the existing AUTH_MECH conf key for the secure-auth setting,
 819         instead of putting it in the list options, because this was actually used already.
 820
 821         * src/maemo/modest-account-settings-dialog.c:
 822         (create_page_account_details),
 823         (modest_account_settings_dialog_set_account_name),
 824         (save_configuration):
 825         * src/maemo/modest-account-settings-dialog.h:
 826         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 827         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 828
 829 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 830
 831         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 832         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 833         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 834
 835         * src/modest-defs.h:
 836         * src/maemo/modest-account-settings-dialog.c:
 837         (create_page_incoming), (on_combo_outgoing_security_changed),
 838         (on_combo_incoming_security_changed), (create_page_outgoing),
 839         (modest_account_settings_dialog_set_account_name),
 840         (save_configuration): Load/Save the port number, and change it when the
 841         security combo changes, to suitable defaults.
 842
 843 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 844
 845         * src/modest-account-mgr.c:
 846         (modest_account_mgr_add_server_account): Set the security and secure-auth
 847         options, and add a comment saying that the other camel-specific options should be
 848         removed in future.
 849
 850 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 851
 852         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 853         found by valgrind.
 854         * src/modest-tny-account-store.c: (account_list_free),
 855         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 856         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 857         easy to fix.
 858
 859 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 860
 861         * src/modest-protocol-info.c:
 862         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 863         is required by our UI spec. Maybe something in our implementation will use this eventually.
 864         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 865         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 866         instead of the previous 0 placeholder.
 867
 868         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 869         secure-auth settings.
 870         * src/modest-account-mgr-helpers.h:
 871         * src/modest-account-mgr-helpers.c:
 872         (modest_server_account_data_get_option_secure_auth),
 873         (modest_server_account_set_option_secure_auth),
 874         (modest_server_account_data_get_option_security),
 875         (modest_server_account_set_option_security): Added this API for getting and setting the security
 876         and secure-auth settings.
 877
 878         * src/maemo/modest-account-settings-dialog.h:
 879         * src/maemo/modest-account-settings-dialog.c:
 880         (modest_account_settings_dialog_finalize), (check_data),
 881         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 882         about changing titles.
 883         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 884         (save_configuration): Save the security and secure-auth settings.
 885
 886         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 887         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 888
 889 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 890
 891         * src/modest-defs.h:
 892         * src/modest-account-mgr.c:
 893         (modest_account_mgr_add_server_account):
 894         Added and used defines for the options key and value pair strings,
 895         that are used so far, though they do not seem to correspond to anything in our
 896         UI specs or ModestProtocol enum.
 897
 898         * src/modest-account-mgr-helpers.h:
 899         * src/modest-account-mgr-helpers.c:
 900         (compare_option_strings_for_name),
 901         (modest_server_account_data_get_option_value),
 902         (modest_server_account_data_get_option_bool),
 903         (modest_account_mgr_get_server_account_option):
 904         Added helper functions for parsing the options GSList.
 905
 906 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 907
 908         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 909         display name is based on the supplied account name.
 910         * src/modest-account-mgr.c:
 911         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 912         with an inefficient, but good-enough, implementation.
 913
 914         * src/maemo/easysetup/modest-easysetup-wizard.c:
 915         (create_page_account_details), (on_before_next), (create_account):
 916         Check for existing display names rather than (non-user-visible) account names, and just
 917         create and set a unique account name at the end.
 918
 919         * src/maemo/modest-account-settings-dialog.c:
 920         (modest_account_settings_dialog_init),
 921         (modest_account_settings_dialog_set_account_name),
 922         (create_page_incoming): Show the display name, instead of the account name.
 923         (on_response): Do some (not all) extra checks, as in the UI spec.
 924         (save_configuration): Save the display name if it was changed.
 925
 926 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 927
 928         * po/en_GB.po: Added needed logical ID and translation.
 929         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 930         (init_view): Made the is-default column clicking work.
 931
 932 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 933
 934         * configure.ac:
 935         * src/maemo/easysetup/Makefile.am:
 936         * src/maemo/easysetup/modest-easysetup-wizard.c:
 937         (modest_easysetup_wizard_dialog_init):
 938         * src/maemo/easysetup/provider-data-test.keyfile:
 939         * src/maemo/easysetup/provider-data.keyfile:
 940         Moved the provider data file to the new modest-providers-data package and used it from there.
 941
 942 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 943
 944         * src/modest-local-folder-info.c:
 945         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 946         N_() was already used on the static strings, but this just marks it for translation without
 947         using the translation.
 948
 949 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 950
 951         * src/maemo/modest-account-settings-dialog.c:
 952         (create_page_incoming),
 953         (modest_account_settings_dialog_set_account_name):
 954         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 955         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 956         I will do this if nobody else gets there first.
 957
 958 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 959
 960         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 961         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 962         save the security stuff.
 963
 964 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 965
 966         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 967         Set the email address and user fullname, which I now see must be
 968         done separately.
 969
 970         * src/maemo/modest-account-settings-dialog.h:
 971         * src/maemo/modest-account-settings-dialog.c:
 972          (on_response),
 973         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 974         leave-on-server and authentication.
 975         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 976         how to do the rest.
 977
 978 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 979
 980
 981         * src/maemo/modest-account-settings-dialog.c:
 982         * src/maemo/modest-account-settings-dialog.h:
 983         Most (but not all) of the widgets are now present as specified by the UI spec.
 984         No changes are yet saved, and some details are not properly shown yet.
 985
 986         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 987
 988 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 989
 990         * src/maemo/Makefile.am:
 991         * src/maemo/modest-account-settings-dialog.c:
 992         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 993         an existing account. Doesn't do much yet.
 994
 995         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 996         Open the accounts settings dialog when Edit is clicked.
 997
 998 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 999
1000         * src/maemo/easysetup/Makefile.am:
1001         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1002         (load_from_file):
1003         * src/maemo/easysetup/modest-easysetup-wizard.c:
1004         (modest_easysetup_wizard_dialog_init):
1005         Try to get the source directory from the build system,
1006         instead of hard-coding "./" into the source code, when opening our local
1007         copies of the configuration files.
1008         But this still fails when opening the wizard from the Accounts window,
1009         maybe because the working directory seems to change at runtime.
1010         So the wizard will fail the second time unless you copy the files into their
1011         proper locations - see the stdout warnings for the paths.
1012
1013         (create_page_account_details),(on_before_next):
1014         Check for existing non-server accounts instead of server accounts,
1015         so the default account name is useful again, and to prevent trying to
1016         recreate accounts.
1017
1018         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1019         Show the wizard when New is clicked.
1020
1021         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1022         (init_view): Show the column headers, and show the columns that are
1023         specified in the UI specs. However, something in Maemo's GTK+ prevents
1024         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1025         change the default account. This is despite unsetting the special properties.
1026
1027 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1028
1029         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1030         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1031         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1032         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1033         to make that clearer.
1034         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1035
1036 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1037
1038         * src/maemo/modest-account-view-window.c:
1039         (modest_account_view_window_init),
1040         (modest_account_view_window_new):
1041         Use the same buttons as specified in the
1042         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1043         the existing widgets, which never had a chance of working.
1044         Put the ModestAccountView treeview in a scrolled window.
1045         Do not repeat the initialization in both _init() and _new().
1046
1047         * src/widgets/modest-account-view.c: (update_account_view):
1048         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1049         this widget and window shows no accounts.
1050
1051         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1052
1053 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1054
1055         * src/maemo/easysetup/modest-easysetup-wizard.c:
1056         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1057         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1058         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1059         which seems wrong.
1060
1061         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1062         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1063         accounts exist yet, as in the UI spec.
1064
1065         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1066
1067 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1068
1069         * src/maemo/Makefile.am:
1070         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1071         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1072         New window for editing connection-specific smtp details.
1073         Not fully implemented.
1074
1075         * src/maemo/modest-connection-specific-smtp-window.c:
1076         (modest_connection_specific_smtp_window_finalize) :
1077         unref the tree model.
1078         (on_button_edit): Show the edit window.
1079
1080 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1081
1082         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1083         error for me.
1084
1085         * src/maemo/Makefile.am:
1086         * src/maemo/modest-connection-specific-smtp-window.c:
1087         * src/maemo/modest-connection-specific-smtp-window.h:
1088         New window for showing the list of connections, for connection-specific
1089         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1090         * src/maemo/easysetup/modest-easysetup-wizard.c:
1091         (create_page_custom_outgoing): Show the new window when the button is clicked.
1092
1093 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1094
1095         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1096         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1097         * src/maemo/modest-msg-edit-window.c:
1098         (modest_msg_edit_window_insert_image):
1099         * src/modest-conf.c: (modest_conf_key_escape):
1100         * src/modest-mail-operation.c:
1101         (modest_mail_operation_send_new_mail):
1102         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1103         (modest_ui_actions_on_new_account):
1104         * src/widgets/modest-attachment-view.c: (update_filename_request):
1105         * src/widgets/modest-mail-header-view.c:
1106         Corrected warnings that were breaking the build, by commenting out unused variables,
1107         and a function, and by including a header.
1108
1109 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1110
1111         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1112         so we can #ifdef around platform-specific code when necessary.
1113         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1114         to allow this to build for the GNOME platform too.
1115
1116 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1117
1118         * src/maemo/easysetup/modest-easysetup-wizard.c:
1119         Added util_increment_name() and used it in create_page_account_details()
1120         to make sure that the default account name is always a new name.
1121
1122         (modest_easysetup_wizard_dialog_init),
1123         (set_default_custom_servernames): Some minor memory management fixes.
1124
1125 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1126
1127         * Makefile.am:
1128         * configure.ac:
1129         * src/modest-runtime.c: (init_i18n): Restored the translation
1130         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1131         are defined in config.h, and the translations are installed.
1132
1133         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1134         is defined for translation.
1135
1136 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1137
1138         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1139         (load_from_file):
1140         * src/maemo/easysetup/modest-easysetup-wizard.c:
1141         (modest_easysetup_wizard_dialog_init):
1142         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1143         Use realistic paths (though they should use $prefix generically) to the
1144         mcc_mapping and provider-data.keyfile files which might work when they
1145         are installed by the future version of the operator-wizard package,
1146         and then fallback to paths in our source code, with an explanatory
1147         warning.
1148
1149 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1150
1151         * configure.ac:
1152         * src/Makefile.am:
1153         * src/maemo/Makefile.am:
1154         * src/maemo/easysetup/: Added files from the previously-exernal
1155         osso-modest-easysetup.
1156         * src/maemo/modest-main-window-ui.h:
1157         * src/modest-ui-actions.c:
1158         * src/modest-ui-actions.h:
1159         Added modest_ui_actions_on_new_account() as a signal handler for the
1160         New Account menu item. It shows the easysetup wizard.
1161         * po/en_GB.po: Added additional needed logical IDs and translations.
1162
1163 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1164 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1165