1 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3 * src/gnome/modest-msg-edit-window.c:
4 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
5 linker error, to fix the build on the GNOME platform.
6 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
7 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
8 ifdefed out to avoid a warning.
10 2007-04-20 Murray Cumming <murrayc@murrayc.com>
12 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
13 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
14 some alternative for GTK+ 2.6.
16 2007-04-19 Murray Cumming <murrayc@murrayc.com>
18 * src/maemo/modest-address-book.c: Added include to avoid a warning.
20 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
21 specified for EmailAccountsDialog in UI spec.
23 * src/maemo/easysetup/modest-easysetup-wizard.c:
24 * src/maemo/easysetup/modest-easysetup-wizard.h:
25 * src/maemo/modest-account-settings-dialog.c:
26 * src/maemo/modest-account-settings-dialog.h:
27 Reuse a member window widget for the connection-specific SMTP server accounts,
28 so we can tell it to create/save the accounts only if we actually save changes.
30 * src/maemo/modest-connection-specific-smtp-edit-window.h:
31 * src/maemo/modest-connection-specific-smtp-edit-window.c:
32 (modest_connection_specific_smtp_edit_window_get_settings):
33 Return a struct instance for temporarily remembering the entered data.
35 * src/maemo/modest-connection-specific-smtp-window.h:
36 * src/maemo/modest-connection-specific-smtp-window.c:
37 (modest_connection_specific_smtp_window_finalize),
38 (modest_connection_specific_smtp_window_fill_with_connections),
40 (modest_connection_specific_smtp_window_save_server_accounts),
41 (update_model_server_names): Do not actually save data until asked,
42 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
44 (on_selection_changed),
45 (modest_connection_specific_smtp_window_init): Disable the edit
46 button when nothing is selected.
48 * src/modest-account-mgr-helpers.c:
49 * src/modest-account-mgr-helpers.h:
50 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
53 2007-04-19 Murray Cumming <murrayc@murrayc.com>
55 * src/modest-account-mgr-helpers.h:
56 * src/modest-account-mgr-helpers.c:
57 (modest_account_mgr_get_unused_account_name),
58 (modest_account_mgr_get_unused_account_display_name): Added these
59 utility functions, to avoid code duplication.
61 * src/maemo/easysetup/modest-easysetup-wizard.c:
62 (create_page_account_details), (create_account):
63 * src/maemo/modest-connection-specific-smtp-edit-window.c:
64 (on_combo_security_changed),
65 (modest_connection_specific_smtp_edit_window_init),
66 (modest_connection_specific_smtp_edit_window_save_settings):
67 * src/maemo/modest-connection-specific-smtp-edit-window.h:
68 * src/maemo/modest-connection-specific-smtp-window.c:
69 (modest_connection_specific_smtp_window_finalize),
70 (modest_connection_specific_smtp_window_fill_with_connections),
71 (on_button_edit), (modest_connection_specific_smtp_window_init):
72 * src/maemo/modest-connection-specific-smtp-window.h:
73 Implementing saving of connection-specific server accounts.
75 But I need to refactor this so we can save the data for each
76 possible connection-specific account and only actually create the server accounts
77 when the easysetup finished, or the OK button is pressed on the account settings
80 2007-04-18 Murray Cumming <murrayc@murrayc.com>
82 * src/maemo/modest-connection-specific-smtp-edit-window.c:
83 (on_combo_security_changed):
84 (modest_connection_specific_smtp_edit_window_init):
85 Auto-fill the port number as in the account settings.
87 (modest_connection_specific_smtp_edit_window_set_connection):
88 * src/maemo/modest-connection-specific-smtp-edit-window.h:
89 * src/maemo/modest-connection-specific-smtp-window.c:
90 (fill_with_connections), (on_button_edit),
91 (modest_connection_specific_smtp_window_init):
92 Turn the edit window into a dialog to simplify the code, and
93 set a WM hint as in a GtkDialog, because only a popup can be on top of
94 another window in Maemo, and popups usually have no WM decoration.
97 * src/modest-account-mgr-helpers.c:
98 (modest_account_mgr_set_connection_specific_smtp),
99 (modest_account_mgr_remove_connection_specific_smtp),
100 (modest_account_mgr_get_connection_specific_smtp):
101 * src/modest-account-mgr-helpers.h: Some functions to write the
102 connection-specific SMTP server information. Not yet used.
105 * src/widgets/modest-folder-view.c: (text_cell_data):
106 Fix a warning about an uninitialized variable.
107 (on_configuration_key_changed): Put an #ifdef around the use
108 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
110 2007-04-18 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/modest-account-settings-dialog.h:
113 * src/maemo/modest-account-settings-dialog.c:
114 Added connect_for_modified() utility function to mark the new modified boolean.
116 (create_page_account_details), (create_page_user_details),
117 (create_page_incoming), (create_page_outgoing), (on_response),
118 (modest_account_settings_dialog_init),
119 (modest_account_settings_dialog_set_account_name):
120 Only warn about unsaved changes when there are actually unsaved changes.
122 * src/modest-account-mgr-helpers.c:
123 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
124 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
125 to get the data from there in future.
127 2007-04-18 Murray Cumming <murrayc@murrayc.com>
131 * src/modest-account-mgr-helpers.h:
132 * src/modest-account-mgr-helpers.c:
133 Store the security account setting in a single conf key instead of using
134 the options list, so that the list is left for just the to-be-removed camel hack,
135 and because gconf_client_set_list() is failing for some reason.
137 * src/modest-account-mgr.c:
138 (modest_account_mgr_add_server_account):
139 * src/maemo/modest-account-settings-dialog.c:
140 (modest_account_settings_dialog_set_account_name),
141 (save_configuration): Use the renamed functions.
144 2007-04-18 Murray Cumming <murrayc@murrayc.com>
146 * src/widgets/Makefile.am:
147 * src/widgets/modest-limit-retrieve-combo-box.c:
148 * src/widgets/modest-limit-retrieve-combo-box.h:
149 * src/widgets/modest-retrieve-combo-box.c:
150 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
151 the account settings dialog.
154 * src/modest-account-mgr-helpers.h:
155 * src/modest-account-mgr-helpers.c:
156 (modest_server_account_get_option_secure_auth),
157 (modest_server_account_set_option_secure_auth):
158 * src/modest-account-mgr.c:
159 (modest_account_mgr_add_server_account):
160 Use the existing AUTH_MECH conf key for the secure-auth setting,
161 instead of putting it in the list options, because this was actually used already.
163 * src/maemo/modest-account-settings-dialog.c:
164 (create_page_account_details),
165 (modest_account_settings_dialog_set_account_name),
166 (save_configuration):
167 * src/maemo/modest-account-settings-dialog.h:
168 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
169 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
171 2007-04-18 Murray Cumming <murrayc@murrayc.com>
173 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
174 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
175 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
178 * src/maemo/modest-account-settings-dialog.c:
179 (create_page_incoming), (on_combo_outgoing_security_changed),
180 (on_combo_incoming_security_changed), (create_page_outgoing),
181 (modest_account_settings_dialog_set_account_name),
182 (save_configuration): Load/Save the port number, and change it when the
183 security combo changes, to suitable defaults.
185 2007-04-17 Murray Cumming <murrayc@murrayc.com>
187 * src/modest-account-mgr.c:
188 (modest_account_mgr_add_server_account): Set the security and secure-auth
189 options, and add a comment saying that the other camel-specific options should be
192 2007-04-17 Murray Cumming <murrayc@murrayc.com>
194 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
196 * src/modest-tny-account-store.c: (account_list_free),
197 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
198 cursor->data after unreffing it. But there is some strange stuff there so it might not be
201 2007-04-17 Murray Cumming <murrayc@murrayc.com>
203 * src/modest-protocol-info.c:
204 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
205 is required by our UI spec. Maybe something in our implementation will use this eventually.
206 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
207 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
208 instead of the previous 0 placeholder.
210 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
211 secure-auth settings.
212 * src/modest-account-mgr-helpers.h:
213 * src/modest-account-mgr-helpers.c:
214 (modest_server_account_data_get_option_secure_auth),
215 (modest_server_account_set_option_secure_auth),
216 (modest_server_account_data_get_option_security),
217 (modest_server_account_set_option_security): Added this API for getting and setting the security
218 and secure-auth settings.
220 * src/maemo/modest-account-settings-dialog.h:
221 * src/maemo/modest-account-settings-dialog.c:
222 (modest_account_settings_dialog_finalize), (check_data),
223 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
224 about changing titles.
225 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
226 (save_configuration): Save the security and secure-auth settings.
228 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
229 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
231 2007-04-17 Murray Cumming <murrayc@murrayc.com>
234 * src/modest-account-mgr.c:
235 (modest_account_mgr_add_server_account):
236 Added and used defines for the options key and value pair strings,
237 that are used so far, though they do not seem to correspond to anything in our
238 UI specs or ModestProtocol enum.
240 * src/modest-account-mgr-helpers.h:
241 * src/modest-account-mgr-helpers.c:
242 (compare_option_strings_for_name),
243 (modest_server_account_data_get_option_value),
244 (modest_server_account_data_get_option_bool),
245 (modest_account_mgr_get_server_account_option):
246 Added helper functions for parsing the options GSList.
248 2007-04-16 Murray Cumming <murrayc@murrayc.com>
250 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
251 display name is based on the supplied account name.
252 * src/modest-account-mgr.c:
253 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
254 with an inefficient, but good-enough, implementation.
256 * src/maemo/easysetup/modest-easysetup-wizard.c:
257 (create_page_account_details), (on_before_next), (create_account):
258 Check for existing display names rather than (non-user-visible) account names, and just
259 create and set a unique account name at the end.
261 * src/maemo/modest-account-settings-dialog.c:
262 (modest_account_settings_dialog_init),
263 (modest_account_settings_dialog_set_account_name),
264 (create_page_incoming): Show the display name, instead of the account name.
265 (on_response): Do some (not all) extra checks, as in the UI spec.
266 (save_configuration): Save the display name if it was changed.
268 2007-04-16 Murray Cumming <murrayc@murrayc.com>
270 * po/en_GB.po: Added needed logical ID and translation.
271 * src/widgets/modest-account-view.c: (on_account_default_toggled),
272 (init_view): Made the is-default column clicking work.
274 2007-04-16 Murray Cumming <murrayc@murrayc.com>
277 * src/maemo/easysetup/Makefile.am:
278 * src/maemo/easysetup/modest-easysetup-wizard.c:
279 (modest_easysetup_wizard_dialog_init):
280 * src/maemo/easysetup/provider-data-test.keyfile:
281 * src/maemo/easysetup/provider-data.keyfile:
282 Moved the provider data file to the new modest-providers-data package and used it from there.
284 2007-04-16 Murray Cumming <murrayc@murrayc.com>
286 * src/modest-local-folder-info.c:
287 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
288 N_() was already used on the static strings, but this just marks it for translation without
289 using the translation.
291 2007-04-06 Murray Cumming <murrayc@murrayc.com>
293 * src/maemo/modest-account-settings-dialog.c:
294 (create_page_incoming),
295 (modest_account_settings_dialog_set_account_name):
296 Added comments about the need for new API in ModestAccountMgr to handle the authentication
297 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
298 I will do this if nobody else gets there first.
300 2007-04-06 Murray Cumming <murrayc@murrayc.com>
302 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
303 Saved much of the incoming and outgoing data too, though I cannot yet see how to
304 save the security stuff.
306 2007-04-06 Murray Cumming <murrayc@murrayc.com>
308 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
309 Set the email address and user fullname, which I now see must be
312 * src/maemo/modest-account-settings-dialog.h:
313 * src/maemo/modest-account-settings-dialog.c:
315 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
316 leave-on-server and authentication.
317 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
320 2007-04-06 Murray Cumming <murrayc@murrayc.com>
323 * src/maemo/modest-account-settings-dialog.c:
324 * src/maemo/modest-account-settings-dialog.h:
325 Most (but not all) of the widgets are now present as specified by the UI spec.
326 No changes are yet saved, and some details are not properly shown yet.
328 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
330 2007-04-06 Murray Cumming <murrayc@murrayc.com>
332 * src/maemo/Makefile.am:
333 * src/maemo/modest-account-settings-dialog.c:
334 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
335 an existing account. Doesn't do much yet.
337 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
338 Open the accounts settings dialog when Edit is clicked.
340 2007-04-05 Murray Cumming <murrayc@murrayc.com>
342 * src/maemo/easysetup/Makefile.am:
343 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
345 * src/maemo/easysetup/modest-easysetup-wizard.c:
346 (modest_easysetup_wizard_dialog_init):
347 Try to get the source directory from the build system,
348 instead of hard-coding "./" into the source code, when opening our local
349 copies of the configuration files.
350 But this still fails when opening the wizard from the Accounts window,
351 maybe because the working directory seems to change at runtime.
352 So the wizard will fail the second time unless you copy the files into their
353 proper locations - see the stdout warnings for the paths.
355 (create_page_account_details),(on_before_next):
356 Check for existing non-server accounts instead of server accounts,
357 so the default account name is useful again, and to prevent trying to
360 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
361 Show the wizard when New is clicked.
363 * src/widgets/modest-account-view.c: (on_account_default_toggled),
364 (init_view): Show the column headers, and show the columns that are
365 specified in the UI specs. However, something in Maemo's GTK+ prevents
366 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
367 change the default account. This is despite unsetting the special properties.
369 2007-04-05 Murray Cumming <murrayc@murrayc.com>
371 * docs/reference/modest-design.sgml: Corrected spelling mistake.
372 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
373 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
374 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
375 to make that clearer.
376 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
378 2007-04-05 Murray Cumming <murrayc@murrayc.com>
380 * src/maemo/modest-account-view-window.c:
381 (modest_account_view_window_init),
382 (modest_account_view_window_new):
383 Use the same buttons as specified in the
384 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
385 the existing widgets, which never had a chance of working.
386 Put the ModestAccountView treeview in a scrolled window.
387 Do not repeat the initialization in both _init() and _new().
389 * src/widgets/modest-account-view.c: (update_account_view):
390 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
391 this widget and window shows no accounts.
393 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
395 2007-04-05 Murray Cumming <murrayc@murrayc.com>
397 * src/maemo/easysetup/modest-easysetup-wizard.c:
398 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
399 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
400 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
403 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
404 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
405 accounts exist yet, as in the UI spec.
407 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
409 2007-04-05 Murray Cumming <murrayc@murrayc.com>
411 * src/maemo/Makefile.am:
412 * src/maemo/modest-connection-specific-smtp-edit-window.c:
413 * src/maemo/modest-connection-specific-smtp-edit-window.h:
414 New window for editing connection-specific smtp details.
415 Not fully implemented.
417 * src/maemo/modest-connection-specific-smtp-window.c:
418 (modest_connection_specific_smtp_window_finalize) :
419 unref the tree model.
420 (on_button_edit): Show the edit window.
422 2007-04-05 Murray Cumming <murrayc@murrayc.com>
424 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
427 * src/maemo/Makefile.am:
428 * src/maemo/modest-connection-specific-smtp-window.c:
429 * src/maemo/modest-connection-specific-smtp-window.h:
430 New window for showing the list of connections, for connection-specific
431 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
432 * src/maemo/easysetup/modest-easysetup-wizard.c:
433 (create_page_custom_outgoing): Show the new window when the button is clicked.
435 2007-04-04 Murray Cumming <murrayc@murrayc.com>
437 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
438 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
439 * src/maemo/modest-msg-edit-window.c:
440 (modest_msg_edit_window_insert_image):
441 * src/modest-conf.c: (modest_conf_key_escape):
442 * src/modest-mail-operation.c:
443 (modest_mail_operation_send_new_mail):
444 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
445 (modest_ui_actions_on_new_account):
446 * src/widgets/modest-attachment-view.c: (update_filename_request):
447 * src/widgets/modest-mail-header-view.c:
448 Corrected warnings that were breaking the build, by commenting out unused variables,
449 and a function, and by including a header.
451 2007-04-04 Murray Cumming <murrayc@murrayc.com>
453 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
454 so we can #ifdef around platform-specific code when necessary.
455 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
456 to allow this to build for the GNOME platform too.
458 2007-04-04 Murray Cumming <murrayc@murrayc.com>
460 * src/maemo/easysetup/modest-easysetup-wizard.c:
461 Added util_increment_name() and used it in create_page_account_details()
462 to make sure that the default account name is always a new name.
464 (modest_easysetup_wizard_dialog_init),
465 (set_default_custom_servernames): Some minor memory management fixes.
467 2007-04-04 Murray Cumming <murrayc@murrayc.com>
471 * src/modest-runtime.c: (init_i18n): Restored the translation
472 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
473 are defined in config.h, and the translations are installed.
475 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
476 is defined for translation.
478 2007-04-03 Murray Cumming <murrayc@murrayc.com>
480 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
482 * src/maemo/easysetup/modest-easysetup-wizard.c:
483 (modest_easysetup_wizard_dialog_init):
484 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
485 Use realistic paths (though they should use $prefix generically) to the
486 mcc_mapping and provider-data.keyfile files which might work when they
487 are installed by the future version of the operator-wizard package,
488 and then fallback to paths in our source code, with an explanatory
491 2007-04-03 Murray Cumming <murrayc@murrayc.com>
495 * src/maemo/Makefile.am:
496 * src/maemo/easysetup/: Added files from the previously-exernal
497 osso-modest-easysetup.
498 * src/maemo/modest-main-window-ui.h:
499 * src/modest-ui-actions.c:
500 * src/modest-ui-actions.h:
501 Added modest_ui_actions_on_new_account() as a signal handler for the
502 New Account menu item. It shows the easysetup wizard.
503 * po/en_GB.po: Added additional needed logical IDs and translations.
505 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
506 Apparently ChangeLog is not used for some vague Nokia legal reasons.