1 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/widgets/modest-folder-view.c:
4 Don't check for MERGE type anymore as we use the correct type
6 NOTE: For the last two changes you need to update your tinymail copy
7 because of API changes!
9 2007-07-04 Johanens Schmid <johannes.schmid@openismus.com>
11 * src/modest-tny-local-folders-account.c:
12 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
13 (see projects.maemo.org NB#61580)
15 2007-07-04 Murray Cumming <murrayc@murrayc.com>
17 * src/modest-tny-account.c: (on_connection_status_changed):
18 Commented out the call to modest_platform_connect_and_wait() because this
19 seems to always hang, and I would like to know if this is the only thing
20 that causes a hang when showing the connection dialog.
21 It is not very useful anyway.
23 2007-07-04 Murray Cumming <murrayc@murrayc.com>
25 * src/maemo/modest-msg-view-window.c:
26 (modest_msg_view_window_select_next_message):
28 * src/modest-platform.h:
29 * src/maemo/modest-platform.c:
30 Added modest_platform_connect_and_wait(), which calls
31 tny_maemo_conic_device_connect() always in the main thread, by calling it
32 in an idle handler and waiting for the idle handler to run. It should be
33 in the main thread because it uses GTK+ UI code. It just returns TRUE
34 if the device is already online.
36 There is some nasty code to ensure that subsequent calls to
37 modest_platform_connect_and_wait() just wait for the first one to finish,
38 by checking repeatedly in another idle handler. This is necessary,
39 because other threads (or even the main thread, via another idle handler)
40 can call modest_platform_connect_and_wait() while
41 modest_platform_connect_and_wait() is running.
43 (modest_platform_connect_and_wait_if_network_account),
44 (modest_platform_connect_and_wait_if_network_folderstore):
45 Convenience functions that calls modest_platform_connect_and_wait() if
46 the account or folder might want network access.
48 * src/modest-mail-operation.c:
49 (modest_mail_operation_update_account):
50 * src/modest-ui-actions.c: (download_uncached_messages),
51 (modest_ui_actions_on_rename_folder), (delete_folder),
52 (modest_ui_actions_on_main_window_move_to),
53 (modest_ui_actions_on_msg_view_window_move_to):
54 * src/widgets/modest-folder-view.c:
55 (drag_and_drop_from_folder_view):
56 Offer a connection if we are offline.
58 * src/modest-tny-account.c: (on_connection_status_changed):
59 Document this as only handling errors during network operations in progress,
60 and replace the idle code with a simple call to
61 modest_platform_connect_and_wait(), which does this instead.
63 2007-07-03 Murray Cumming <murrayc@murrayc.com>
65 * src/modest-tny-account.c:
66 (modest_tny_account_get_special_folder): (util_on_idle),
67 Handle the GError so we can see when tny_folder_store_get_folders()
68 fails, as it currently does while something else is connecting.
70 Added util_run_in_main_thread_and_wait()
71 which uses an idlen handler and mainloop to ensure that the function
72 is called in the main thread.
73 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
74 to make sure that we call attempt the connection in the mainloop only,
75 which might solve some hangs.
77 2007-07-03 Murray Cumming <murrayc@murrayc.com>
79 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
80 be found by their display name. This is never useful.
81 * src/modest-tny-account-store.c: (on_account_removed): Find the account
82 by its ID, instead of trying to use its ID as its display name.
84 * src/modest-tny-account-store.h:
85 * src/modest-tny-account.c:
86 (modest_tny_account_get_special_folder): Add a g_warning() when
87 tny_folder_store_get_folders() returns an empty list for the maildir.
89 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
90 Add a g_warning() when this returns NULL, because that it not allowed
93 2007-07-02 Armin Burgmeier <armin@openismus.com>
95 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
96 note when trying to cancel the wizard. This fixes projects.maemo.org
99 2007-07-02 Murray Cumming <murrayc@murrayc.com>
101 * src/modest-tny-account.h:
102 * src/modest-tny-account.c:
103 (modest_tny_account_new_from_server_account),
104 (modest_tny_account_new_from_server_account_name),
105 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
106 because this must now be set before setting the proto. This is usd in
107 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
108 warning in camel_session_get_service() caused by
109 tny_camel_transport_account_prepare().
111 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
114 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
116 * src/maemo/modest-connection-specific-smtp-edit-window.c:
118 (modest_connection_specific_smtp_edit_window_init):
120 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
123 2007-06-29 Murray Cumming <murrayc@murrayc.com>
125 * src/modest-tny-account.c:
126 (modest_tny_account_new_from_server_account):
127 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
128 now uses to request a connection when it needs one, and which it uses
129 to tell us that something is wrong with the connection, so we can force
130 the accounts offline to prevent further problems.
133 * src/modest-init.c: (init_default_settings):
134 * src/modest-mail-operation.c:
135 (modest_mail_operation_update_account):
136 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
137 This should not be necessary anymore. Do not set the conf key that
138 determined this (it was always TRUE and not set anywhere else).
140 * src/modest-ui-actions.h: Remove unused and unimplemented
141 modest_ui_actions_on_online_toggle_toggled().
143 2007-06-29 Murray Cumming <murrayc@murrayc.com
145 * src/maemo/modest-main-window.c: (connect_signals):
146 Don't connect to delete_event twice. Maybe this was harmless.
148 2007-06-29 Murray Cumming <murrayc@murrayc.com
150 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
151 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
152 Debug output to give some more clue when a folder move is not allowed.
154 2007-06-28 Murray Cumming <murrayc@murrayc.com
156 * src/modest-tny-account.c: (on_modest_file_system_info),
157 (modest_tny_account_get_mmc_account_name):
158 Always call the callback, without checking whether the name has changed.
159 * src/widgets/modest-folder-view.c: (strings_are_equal),
160 (on_model_foreach_set_name), (on_get_mmc_account_name),
161 (text_cell_data): Compare the name here, and use the name from
162 the account rather than from the
163 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
164 if the name was changed after the account was added to the model.
165 That's a tinymail bug but not one that I want to fix now.
167 This finally fixes projects.maemo.org bug NB#59301.
169 2007-06-27 Armin Burgmeier <armin@openismus.com>
171 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
174 2007-06-27 Murray Cumming <murrayc@murrayc.com
176 * src/modest-tny-account.h:
177 * src/modest-tny-account.c:
178 Added modest_tny_account_get_mmc_account_name(), to set the memory
179 card name asynchronously for the given account and then notify.
180 (modest_tny_account_new_for_local_folders): Use this new function instead
181 of using hildon_file_system_info_async_new() directly.
183 * src/widgets/modest-folder-view.c: (text_cell_data):
184 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
185 gtk_tree_model_row_changed() when it is available.
187 This should fix projects.maemo.org bug NB#59301.
189 2007-06-27 Murray Cumming <murrayc@murrayc.com
191 * src/modest-mail-operation.c: (update_account_thread),
192 (get_msgs_full_thread): Fix typo failures in the revert
195 2007-06-27 Murray Cumming <murrayc@murrayc.com
197 * src/maemo/modest-maemo-global-settings-dialog.c:
198 (idle_select_default_focus):
199 * src/modest-mail-operation.c: (idle_notify_progress),
200 (idle_notify_progress_once), (set_last_updated_idle),
201 (update_account_thread), (get_msgs_full_thread):
202 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
203 * src/widgets/modest-header-view.c:
204 (idle_notify_headers_count_changed_destroy),
205 (idle_notify_headers_count_changed):
206 Reverted the additions of gdk_threads_enter/leave(), in case this
207 helps with a startup hang on the device.
209 2007-06-26 Armin Burgmeier <armin@openismus.com>
211 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
212 for supported secure authentication methods from server by
213 gtk_dialog_run(), saving CPU time and a potential race condition.
215 2007-06-26 Armin Burgmeier <armin@openismus.com>
217 * src/maemo/modest-maemo-utils.h:
218 * src/maemo/modest-maemo-utils.c: Added a
219 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
220 only error code to tell the calling code when the user canceled the
223 * src/maemo/modest-account-settings-dialog.h:
224 * src/maemo/modest-account-settings-dialog.c:
225 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
226 message if the retrieval of secure authentication methods was canceled
227 by the user. Perform the check before saving anything to configuration
228 to not end up with half-committed configuration changes, do not show
229 a "Saving to configuration failed" note when authentication methods
230 could not be retrieved.
232 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
235 2007-06-26 Murray Cumming <murrayc@murrayc.com>
237 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
238 Only return the first level of folders under accounts, because the
239 osso-global-search UI spec doesn't want the rest.
240 This fixed projects.maemo.org bug NB#61811.
242 2007-06-26 Murray Cumming <murrayc@murrayc.com>
244 * src/modest-tny-account-store.c:
245 * src/modest-tny-account-store.h:
246 Added modest_tny_account_is_memory_card_account().
247 * src/maemo/modest-main-window.c: (create_details_widget):
248 Show the same information items for the memory card as we show for the
249 local-folders, to fix projects.maemo.org bug NB#59307.
251 2007-06-26 Murray Cumming <murrayc@murrayc.com>
253 * src/modest-tny-account-store.c: (get_password):
254 Added some checks for NULL to maybe prevent crashes, though I think
255 it was Philip's last commit that actually prevented the crash here
256 when creating a first new account.
257 But the new account is still not usable (no messages are shown)
258 until a restart of the application.
260 2007-06-26 Murray Cumming <murrayc@murrayc.com>
262 * src/maemo/modest-maemo-global-settings-dialog.c:
263 (idle_select_default_focus):
264 * src/modest-mail-operation.c: (idle_notify_progress),
265 (idle_notify_progress_once), (idle_notify_update_account_queue),
266 (set_last_updated_idle), (update_account_thread),
267 (notify_get_msgs_full), (get_msgs_full_destroyer),
268 (get_msgs_full_thread):
269 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
270 * src/widgets/modest-header-view.c:
271 (idle_notify_headers_count_changed_destroy),
272 (idle_notify_headers_count_changed):
273 Use gdk_threads_enter() and gdk_threads_enter_leave() in
274 all idle handlers, because some other thread could be blocking
275 the GDK lock, so that it can do GUI stuff.
277 2007-06-26 Murray Cumming <murrayc@murrayc.com>
279 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
280 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
281 (on_idle_send_receive), (on_idle_open_default_inbox):
282 * src/maemo/modest-msg-edit-window.c:
283 (modest_msg_edit_window_attach_file_noninteractive):
284 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
285 to prevent a hang. I don't quite understand why these are necessary,
286 beause we should already be in the main loop. I guess something outside
287 of the main loop is taking the lock.
289 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
290 we are really using URIs, and use files that are more likely to exist.
292 2007-06-26 Murray Cumming <murrayc@murrayc.com>
294 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
295 necessary because configure.ac now defines different variables.
297 2007-06-26 Murray Cumming <murrayc@murrayc.com>
299 * libmodest-dbus-client/libmodest-dbus-client.c:
300 * libmodest-dbus-client/libmodest-dbus-client.h:
301 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
302 libmodest_dbus_client_compose_mail() is what things actually use.
304 * src/dbus_api/modest-dbus-api.h:
305 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
306 * tests/dbus_api/Makefile.am:
307 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
310 2007-06-26 Murray Cumming <murrayc@murrayc.com>
312 * src/modest-init.c: (modest_init_local_folders):
313 For memory-card (or other non local-folders) maildir accounts,
314 always create an Archive folder, so that there is somewhere to put
315 messages. This should be less confusing, because the user does not need
316 to guess that the need to create a folder.
318 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
320 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
321 Fixed icon size by using (50, 50) which is the same as defined by
324 2007-06-25 Armin Burgmeier <armin@openismus.com>
326 * src/widgets/modest-window-mgr.c:
328 * configure.ac: Correctly recognize hildon-notify presence and fixed
329 the build without it being installed.
331 2007-06-25 Murray Cumming <murrayc@murrayc.com>
333 * libmodest-dbus-client/libmodest-dbus-client.c:
334 (libmodest_dbus_client_search): Fix the build. Sorry.
335 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
336 (reply_forward_cb): Initialize variables to fix the build.
338 * src/modest-tny-account-store.c:
339 (modest_tny_account_store_get_tny_account_by): Fix the account URI
340 comparison (a silly typo) so that email search results can be opened
341 when there are more than one account.
343 2007-06-25 Murray Cumming <murrayc@murrayc.com>
345 * libmodest-dbus-client/libmodest-dbus-client.c:
346 (libmodest_dbus_client_search),
347 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
348 instead of 1 second, because the search gets folders and messages from
349 the server, which can take a long time. When it times out,
350 osso-global-search will report no results.
352 We need to specify whether we should search only cached information
353 (maybe with a user preference), and the osso-email-search-plugin
354 API should really be improved to allow that option, and to allow results
355 to be delivered asynchronously in batches.
357 2007-06-25 Murray Cumming <murrayc@murrayc.com>
359 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
360 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
361 GTK_ICON_SIZE_DIALOG is probably the wrong size.
363 2007-06-25 Murray Cumming <murrayc@murrayc.com>
365 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
366 that is an empty string. D-Bus seems to give us these instead of NULL.
368 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
370 * src/dbus_api/modest-dbus-callbacks.c:
371 * src/maemo/easysetup/modest-easysetup-wizard.h:
372 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
373 * src/maemo/modest-connection-specific-smtp-edit-window.c:
374 (modest_connection_specific_smtp_edit_window_init):
375 * src/maemo/modest-maemo-global-settings-dialog.c:
377 * src/maemo/modest-maemo-utils.c:
378 (modest_maemo_utils_setup_images_filechooser):
379 * src/maemo/modest-main-window.c: (create_details_widget):
380 * src/maemo/modest-msg-edit-window.c:
381 (modest_msg_edit_window_attach_file_noninteractive),
382 (modest_msg_edit_window_color_button_change),
383 (modest_msg_edit_window_set_zoom):
384 * src/modest-mail-operation.c: (update_account_thread):
385 * src/modest-tny-account-store.c:
386 * src/modest-tny-account.c:
387 * src/widgets/modest-global-settings-dialog.c:
388 * src/widgets/modest-window.h:
392 2007-06-25 Murray Cumming <murrayc@murrayc.com>
394 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
395 * src/modest-search.c: (modest_search_folder),
396 (modest_search_all_accounts): Actually search only in the specified folder,
397 doing a simple match on the folder ID.
398 * src/modest-search.h: Added a folder field to the ModestSearch struct,
399 and added some documentation.
401 2007-06-22 Armin Burgmeier <armin@openismus.com>
403 * src/maemo/modest-maemo-utils.h:
404 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
405 modest_maemo_utils_get_supported_secure_authentication_methods.
407 * src/maemo/easysetup/modest-easysetup-wizard.c:
408 * src/maemo/modest-account-settings-dialog.c: Show correct error if
409 one occured, not just "Server does not support secure authentication".
411 2007-06-22 Murray Cumming <murrayc@murrayc.com>
413 * src/modest-tny-account-store.c: (get_password):
414 Restored the call to tny_account_set_user() because Philip seems to have
415 stopped this from crashing (by not using the freed string). It still does
416 not work, but now we can test it.
418 2007-06-22 Murray Cumming <murrayc@murrayc.com>
420 * src/maemo/modest-msg-edit-window.c: (init_window):
421 Comment out use of an uninitialzed GtkScrolledWindow variable,
422 to fix the build and stop a crash. Yet again.
424 2007-06-22 Murray Cumming <murrayc@murrayc.com>
426 * src/modest-tny-account-store.c: (get_password):
427 Remove the call to tny_account_set_user() because this actually crashes.
428 As mentioned in the last commit, it is known to not work anyway.
430 2007-06-22 Murray Cumming <murrayc@murrayc.com>
432 * src/modest-tny-account-store.c: (get_password):
433 Use tny_account_set_username() to tell tinymail that the username might
434 have changed too. But tinymail ignores this: see projects.maemo.org
436 * src/modest-ui-actions.c:
437 (modest_ui_actions_on_password_requested): Remove the useless attempt to
438 reset the connection when changing the username, and improve the comments.
439 Save the changed username to gconf at least, so it is used when Modest is
442 2007-06-21 Murray Cumming <murrayc@murrayc.com>
444 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
445 Do not use a query, so that we get all folders, including for POP and
446 local-folders. They work as search criteria too.
447 This fixes projects.maemo.org bug NB#57740.
449 2007-06-21 Murray Cumming <murrayc@murrayc.com>
451 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
452 Comment out the use of hildon_notification_set_sound() because it is
453 not declared, to fix the build. Warnings are serious, people.
455 2007-06-21 Armin Burgmeier <armin@openismus.com>
457 * src/maemo/modest-maemo-utils.h:
458 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
459 modest_maemo_utils_get_supported_secure_authentication_methods()
460 to query authentication methods for a specific user. This should fix
461 projects.maemo.org bug NB#61369.
463 * src/maemo/easysetup/modest-easysetup-wizard.c:
464 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
467 2007-06-21 Murray Cumming <murrayc@murrayc.com>
469 * libmodest-dbus-client/libmodest-dbus-client.h:
470 * libmodest-dbus-client/libmodest-dbus-client.c:
471 (modest_dbus_message_iter_get_search_hit),
472 (libmodest_dbus_client_search):
473 Reorganised and commented this.
474 Removed modest_search_hit_free() from the public API because it
477 Added libmodest_dbus_client_get_folders() and
478 modest_folder_result_list_free().
480 * src/dbus_api/modest-dbus-api.h:
481 * src/dbus_api/modest-dbus-callbacks.c:
482 (modest_dbus_req_filter): Commented. Moved most code to
483 on_dbus_method_search() and added on_dbus_method_get_folders().
485 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
486 of the extra D-Bus handler.
488 * tests/dbus_api/Makefile.am:
489 * tests/dbus_api/test_get_folders.c: New test for
490 libmodest_dbus_client_get_folders(). This seems to return an empty list
491 at the moment. That could be the same error that causes the message list
492 to be empty sometimes.
493 This should help with projects.maemo.org bug NB#57740.
495 2007-06-21 Armin Burgmeier <armin@openismus.com>
497 * src/modest-mail-operation.c: Do not call
498 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
499 notify the operation's end after having set the status to CANCELED for
500 the operation queue to listen on. This fixes a deadlock when there
501 were mail operations in the queue during its finalization.
503 * src/modest-singletons.c: Reordered uninitialization of the account
504 manager to happen after the mail operation queue was uninitialized
505 because the mail operation's in the queue might still try to access
506 the account manager (see modest_mail_operation_notify_end()). This
507 fixes a potential crash when terminating the application.
509 2007-06-21 Murray Cumming <murrayc@murrayc.com>
511 * src/modest-search.c:
512 (search_mime_part_and_child_parts): Moved some code here so we
513 can search recursively in child folders.
514 (modest_search_folder): Search in the message as a mime part, instead
515 of just its child mime parts.
516 (read_chunk), (search_mime_part_ogs):
517 Check how many bytes were read, to prevent an endless loop.
518 Searching in message bodies now works. This finishes the fix for
519 projects.maemo.org bug NB#61007.
521 2007-06-20 Murray Cumming <murrayc@murrayc.com>
523 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
524 Add a g_warning when the item is not a folder.
526 * src/modest-ui-dimming-rules.c:
527 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
528 when selected item is not a folder (for instance, an account), because
529 the UI spec only talks about folders.
530 I am not sure what the UI spec wants, so this might not totally fix
531 projects.maemo.org bug NB#60794.
533 2007-06-20 Murray Cumming <murrayc@murrayc.com>
535 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
536 (load_from_file): Sort the list. The unsorted list would be more noticeable
537 in non-English locales.
539 * src/maemo/modest-msg-edit-window.c:
540 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
541 warning and fix the build.
543 * src/maemo/modest-progress-bar-widget.c:
544 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
545 avoid a g_warning, and probably to avoid a crash.
547 2007-06-20 Murray Cumming <murrayc@murrayc.com>
549 * src/modest-search.c: (modest_search_folder): Check for a GError
550 when calling tny_folder_get_headers(), to show that this is not the cause
553 2007-06-20 Murray Cumming <murrayc@murrayc.com>
555 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
556 Actually set the body query instead of the subject query.
558 * src/modest-search.c: (search_mime_part_ogs),
559 (search_mime_part_strcmp): Remove extra space from the text/* regex,
560 which would probably cause it to fail if we got this far.
562 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
563 to simplify the code.
564 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
565 be causing search-in-body to fail.
567 2007-06-20 Murray Cumming <murrayc@murrayc.com>
569 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
571 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
572 Better debug message when the folder cannot be found.
573 This should help with fixing projects.maemo.org bug #61287.
574 * src/modest-search.c: (add_hit): Do not leak the furl string.
576 2007-06-20 Murray Cumming <murrayc@murrayc.com>
578 * src/modest-ui-actions.c:
579 (modest_ui_actions_on_folder_selection_changed):
580 Do not special-case TNY_MERGE_FOLDER here, because
581 modest_tny_folder_get_account() already does that. This fixes
582 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
583 shown when the Outbox was selected).
585 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
587 * libmodest-dbus-client/libmodest-dbus-client.c:
588 (_dbus_iter_get_string_or_null): Initialize the string variable in
589 case this helps with Dirk's crash.
591 2007-06-19 Murray Cumming <murrayc@murrayc.com>
593 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
594 though it is not implemented yet (this function is maybe not even used),
595 to avoid breaking ABI in future.
596 * libmodest-dbus-client/libmodest-dbus-client.c:
597 (get_attachments_string): Moved some code into this generic function.
598 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
599 sends email. It is maybe not used.
600 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
601 (on_send_mail): Use attachments.
603 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
604 * src/maemo/modest-msg-edit-window.c:
605 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
606 a filename before using it, to fix projects.maemo.org bug NB#58233.
608 2007-06-19 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
611 Initialize the continue_download variable to fix the build, and probably
612 to fix randome behaviour.
614 2007-06-18 Armin Burgmeier <armin@openismus.com>
616 * src/modest-tny-send-queue.h:
617 * src/modest-tny-send-queue.c: Keep track of the status of messages in
618 the queue so we can later show it in the UI. Replaced
619 modest_tny_send_queue_msg_is_being_sent() by
620 modest_tny_send_queue_get_msg_status().
622 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
624 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
625 gpointer. This probably was not harmful, but just to be sure.
627 2007-06-18 Murray Cumming <murrayc@murrayc.com>
629 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
630 Fix the build, but leave the function broken on Bora, because
631 hildon_uri_action_get_service() does not exist.
632 osso_uri_action_get_service() does not exist either, it seems.
634 2007-06-18 Murray Cumming <murrayc@murrayc.com>
636 * src/modest-tny-account.c:
637 (modest_tny_account_new_from_server_account):
638 Uncommented the url debug output again, because it is useful for
639 debugging, as I said in the comment.
641 2007-06-18 Murray Cumming <murrayc@murrayc.com>
643 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
645 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
646 for Mameo Bora, to fix the build.
648 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
651 Fixed build with hildon < 0.99
653 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
654 Check if the selected account is busy instead of checking all accounts
656 * src/modest-account-mgr-priv.h:
657 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
658 (modest_account_mgr_init), (compare_account_name),
659 (modest_account_mgr_set_account_busy),
660 (modest_account_mgr_account_is_busy):
661 * src/modest-account-mgr.h:
662 Added busy information to the account manager. It possible to
663 set an account to busy or not busy now.
665 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
666 (modest_mail_operation_update_account),
667 (modest_mail_operation_notify_end):
668 Set the account to busy/not busy depending on the operation state.
670 * src/widgets/modest-account-view.c:
671 (modest_account_view_finalize), (get_last_updated_string),
672 (update_account_view), (on_account_busy_changed), (init_view):
673 Show string "Refreshing..." if the account is currently busy.
675 All this fixes projects.maemo.org bug NB#59711
677 2007-06-14 Armin Burgmeier <armin@openismus.com>
679 * src/widgets/modest-attachments-view.h:
680 * src/widgets/modest-attachments-view.c: Added
681 modest_attachments_view_has_attachments() and fixed coordinate
682 transformation in get_att_view_at_coords(). This fixes attachment
685 * src/widgets/modest-msg-view.c: Make use of
686 modest_attachments_view_has_attachments() to decide whether to show
687 attachments in the header.
689 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
691 * src/maemo/modest-connection-specific-smtp-edit-window.c:
692 (on_change), (on_combo_security_changed),
693 (modest_connection_specific_smtp_edit_window_init),
694 (modest_connection_specific_smtp_edit_window_set_connection),
695 (modest_connection_specific_smtp_edit_window_is_dirty):
696 * src/maemo/modest-connection-specific-smtp-edit-window.h:
697 * src/maemo/modest-connection-specific-smtp-window.c:
700 Show an comfirmation dialog for the smpt-edit-window if there are
701 unsaved changes and the user hits cancel.
702 (projects.maemo.org bug NB#60479)
704 2007-06-14 Armin Burgmeier <armin@openismus.com>
706 * src/maemo/easysetup/modest-easysetup-wizard.c:
707 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
708 address" info in banner instead of node, and select all the text as
709 per UI spec. This fixes projects.maemo.org bug NB#60550.
711 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
713 reviewed by: <delete if not using a buddy>
715 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
716 * src/modest-ui-actions.c: (folder_refreshed_cb):
718 2007-06-14 Murray Cumming <murrayc@murrayc.com>
720 * src/widgets/modest-folder-view.c: (filter_row):
721 Explictly filter out the per-account outbox accounts. I don't know why
722 these only sometimes show up, but now they should never show up in the UI.
723 This should fix projects.maemo.org bug NB#60160.
725 2007-06-14 Murray Cumming <murrayc@murrayc.com>
727 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
728 when the toolbar does not exist yet.
729 * src/modest-widget-memory.c: (save_settings_header_view):
730 Added g_warnings() to help us to discover when we are trying to set
731 an empty columns list in gconf.
733 2007-06-14 Murray Cumming <murrayc@murrayc.com>
737 Added modest_init_get_default_header_view_column_ids().
739 * src/modest-widget-memory.c: (restore_settings_header_view):
740 Use the new function to get defaults, if the gconf key is empty,
741 instead of not creating any columns. This seems to fix the
742 empty right-hand pane problems.
744 * src/widgets/modest-header-view.h: Improved documentation.
746 2007-06-13 Murray Cumming <murrayc@murrayc.com>
748 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
749 Revert the use of the display name as the account name, because this
750 is generally wrong and would break the code that follows.
752 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
754 * src/maemo/easysetup/modest-easysetup-wizard.c:
755 (check_for_supported_auth_methods), (on_before_next),
758 More correct fix for projects.maemo.org bug NB# 58991
759 Do not longer accept AUTH_PASSWORD as secure method and choose
760 correct method when creating the account.
762 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
764 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
765 Fixed projects.maemo.org bug NB# 58991
767 2007-06-13 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-init.c: (modest_init_init_core),
770 (modest_init_local_folders): Fixed compilation errors.
772 2007-06-13 Murray Cumming <murrayc@murrayc.com>
774 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
775 Remove unnecessary lib/include, though it is good in principle when needed.
777 * src/modest-init.c: (modest_init_one_local_folder),
778 (modest_init_local_folders):
779 * src/modest-init.h: Initialize the .modest library for memory cards,
780 instead of just doing nothing for them. This should allow us to create
781 folders there, fixing projects.maemo.org bug NB#59297.
783 2007-06-13 Murray Cumming <murrayc@murrayc.com>
785 * libmodest-dbus-client/libmodest-dbus-client.c:
786 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
787 (libmodest_dbus_client_compose_mail),
788 (libmodest_dbus_client_open_message),
789 (libmodest_dbus_client_send_and_receive),
790 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
792 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
793 (on_idle_open_message), (modest_dbus_req_handler),
794 (search_result_to_message), (modest_dbus_req_filter):
795 * src/modest-search.c: (add_hit), (modest_search_folder),
796 (modest_search_all_accounts): Improved debug messages.
798 * tests/dbus_api/test_open_message.c: (main): Improved comments.
800 * src/modest-tny-account-store.c:
801 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
804 2007-06-13 Murray Cumming <murrayc@murrayc.com>
807 2007-06-12 Murray Cumming <murrayc@murrayc.com>
809 * src/modest-tny-account-store.c: (get_server_accounts):
810 Call modest_tny_local_folders_account_add_merged_outbox_folders()
811 even when there are no accounts, so that the Outbox folder is always
812 visible. This fixes projects.maemo.org bug NB#60158.
814 2007-06-12 Murray Cumming <murrayc@murrayc.com>
816 * src/maemo/modest-main-window.c: (create_details_widget):
817 Use the mcen_va_never logical ID.
819 2007-06-12 Murray Cumming <murrayc@murrayc.com>
821 * src/dbus_api/modest-dbus-api.h:
822 * src/dbus_api/modest-dbus-callbacks.c:
823 (on_idle_open_default_inbox), (on_open_default_inbox),
824 (modest_dbus_req_handler):
825 Added a new OpenDefaultInbox method.
827 * libmodest-dbus-client/libmodest-dbus-client.h:
828 * libmodest-dbus-client/libmodest-dbus-client.c:
829 Added libmodest_dbus_client_open_default_inbox() to call the new
830 dbus method. This should be useful to projects.maemo.org bug NB#57214,
831 though it should maybe be used by a new osso-email-interface function.
833 * tests/dbus_api/Makefile.am:
834 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
837 2007-06-12 Murray Cumming <murrayc@murrayc.com>
839 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
840 NULL, so that the signals get all the keys. This should not actually
841 change any behaviour because we currently update everything when anything
844 2007-06-12 Murray Cumming <murrayc@murrayc.com>
846 * src/widgets/modest-folder-view.c: (text_cell_data),
847 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
848 (find_inbox_iter): If tinymail tells us that the folder is
849 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
850 This causes the inbox to be selected at startup, fixing part of
851 projects.maemo.org bug NB#56305.
853 * src/modest-ui-dimming-rules.c:
854 (modest_ui_dimming_rules_on_tools_smtp_servers):
855 * src/modest-ui-dimming-rules.h: Added a callback function to dim
856 the SMTP servers menu item.
857 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
858 that the SMTP Servers menu item is dimmed when there are no accounts,
859 as a future version of the UI spec will require. This fixes
860 projects.maemo.org bug NB#56305.
862 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
864 * src/maemo/modest-maemo-utils.c:
865 (modest_maemo_utils_get_supported_secure_authentication_methods):
866 Added label to dialog instead of unreadable title
868 * src/maemo/modest-main-window.c: (sync_accounts_cb),
869 (modest_main_window_new):
870 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
873 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
874 * src/modest-account-mgr.h:
875 Added method to avoid code duplication
877 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
878 (modest_ui_actions_on_send_receive):
879 Use modest_account_mgr_has_accounts
881 2007-06-11 Murray Cumming <murrayc@murrayc.com>
883 * src/maemo/easysetup/modest-presets.c:
884 (modest_presets_get_info_server_security): Do not report secure auth
886 * src/modest-protocol-info.c: Use the defines for the gconf key names
887 for secure authentication. This was not working because we were writing
888 Password and reading password, and the check was case sensitive.
889 With this, gmail now works for receiving and sending when created via
892 2007-06-11 Murray Cumming <murrayc@murrayc.com>
894 * src/maemo/easysetup/modest-presets.c:
895 (modest_presets_get_info_server_security): Correct the key name for
896 SecureSmtp, because it seems to be case-sensitive.
897 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
898 Do not try to get the 0th notebook page if there are 0 pages, to
901 2007-06-11 Murray Cumming <murrayc@murrayc.com>
903 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
904 Prevent use of the new notification feature for now, because it currently
905 shows one dialog for each new email, which is annoying.
907 2007-06-11 Murray Cumming <murrayc@murrayc.com>
909 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
910 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
911 when no country was selected, so that we show the global ones.
912 * src/maemo/easysetup/modest-presets.c:
913 (modest_presets_get_providers): Return only the global providers, not
914 all providers when mmc=0 was requested.
916 2007-06-11 Murray Cumming <murrayc@murrayc.com>
918 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
919 (easysetup_provider_combo_box_fill): Remove debug code that showed the
920 provider ID in the combo.
922 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
923 Do not show the page numbers, because it would be confusing when we add
924 the 2 extra pages for the custom setup, when the user chooses the "Other"
925 provider. This fixes projects.maemo.org bug NB#59028
927 * src/modest-init.c: (modest_init_init_core),
928 (modest_init_local_folders):
930 * src/modest-tny-account.c:
931 (modest_tny_account_new_for_local_folders): Do not create default folders
932 for the memory card. This should fix projects.maemo.org bug NB#59328.
934 2007-06-11 Murray Cumming <murrayc@murrayc.com>
936 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
937 Free the changed_conf_keys string items. They are already freed in the
938 idle handler if that runs first.
940 2007-06-11 Murray Cumming <murrayc@murrayc.com>
942 * src/modest-ui-actions.c:
943 (modest_ui_actions_on_password_requested): Check that the server name
944 is not NULL, because I just saw a password dialog with (null) as the
947 * src/modest-tny-folder.[h|c]: Added
948 modest_tny_folder_is_memory_card_folder().
949 * src/modest-ui-dimming-rules.c:
950 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
951 menu item for memory cards, as per the UI spec (section 7.4). This should
952 fix projects.maemo.org bug NB#59297.
954 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
956 * src/maemo/modest-main-window.c: (sync_accounts_cb):
957 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
958 is another problem with the code, see Murray's comment at line 772)
960 2007-06-08 Murray Cumming <murrayc@murrayc.com>
962 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
963 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
964 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
965 (load_from_file), (easysetup_country_combo_box_init),
966 (easysetup_country_combo_box_get_active_country_ids),
967 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
968 instead of just one ID, to avoid duplicate country names in the UI.
970 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
971 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
972 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
973 a single ID, avoiding duplicate providers.
974 * src/maemo/easysetup/modest-easysetup-wizard.c:
975 (on_combo_account_country): Adapt to use a list.
977 2007-06-08 Murray Cumming <murrayc@murrayc.com>
979 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
980 keys changed in the last X seconds.
982 * src/modest-account-mgr.h:
983 * src/modest-account-mgr.c: (on_timeout_notify_changes),
984 (on_key_change), (modest_account_mgr_class_init),
985 (modest_account_mgr_init), (modest_account_mgr_finalize):
986 As the keys are changed, save them in a GSList* and signal that GSList*
987 further every X seconds, to batch changes, to allow us to do just one
988 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
989 bug NB#56941 and other (UI-blocking) delays when changing account settings.
991 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
992 changed signal signature.
994 * src/modest-conf.c: (modest_conf_set_list),
995 (modest_conf_on_change): Reenable notification.
997 (modest_conf_maemo_fake_on_change): Comment out the hack that
998 notified immediately instead of asynchronously.
1000 * src/widgets/modest-account-view.h:
1001 * src/widgets/modest-account-view.c:
1002 (update_account_view): Select the previously-selected account ID,
1003 if possible. This fixes projects.maemo.org bug NB#56933.
1005 (on_account_changed), (on_account_removed),
1006 (modest_account_view_select_account):
1008 Remove the block/unblock functions
1009 because they were not useful.
1011 * src/maemo/modest-account-view-window.c:
1012 (on_delete_button_clicked), (on_edit_button_clicked),
1013 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1015 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1017 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1018 Improve the error dialog to show Incorrect Account Settings, which seems
1019 clearer, and say that the internal error message (to be removed from the
1020 dialog later) is often misleading.
1021 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1023 * src/modest-tny-account.c:
1024 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1025 URL because this is so useful for debugging on the device.
1027 * src/widgets/modest-serversecurity-combo-box.c:
1028 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1030 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1032 * src/modest-mail-operation.c:
1033 (modest_mail_operation_send_new_mail):
1034 Added a comment about a nasty but apparently harmless message. Details
1035 added to the wiki g_warnings() page.
1037 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1039 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1040 (modest_tny_send_queue_class_init):
1041 Do not use the priv struct because it is empty, to avoid g_warnings
1042 about a non-existant priv struct.
1044 * src/modest-tny-account-store.c:
1045 (modest_tny_account_store_get_server_account),
1046 (modest_tny_account_store_get_transport_account_for_open_connection
1047 ): Do not try to get transport server accounts for local folders,
1048 because they don't have any. This avoids a g_warning().
1050 * src/maemo/modest-main-window.c:
1051 (modest_main_window_notify_send_receive_initied),
1052 (on_configuration_key_changed):
1053 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1054 * src/modest-defs.h:
1055 * src/modest-mail-operation.c:
1056 (modest_mail_operation_update_account):
1057 * src/modest-tny-account-store.h:
1058 * src/modest-tny-account.c:
1059 (modest_tny_account_get_special_folder),
1060 (modest_tny_account_new_for_local_folders),
1061 (modest_tny_account_new_for_per_account_local_outbox_folder):
1062 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1063 * src/modest-tny-local-folders-account.c:
1064 (add_account_folders_to_merged_folder):
1065 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1066 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1067 (modest_ui_actions_on_send):
1068 * src/widgets/modest-folder-view.c: (update_model):
1069 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1070 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1071 modest_tny_account_store_get_tny_account_by_account() to
1072 modest_tny_account_store_get_server_account() to make the code clearer.
1074 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1076 * src/dbus_api/modest-dbus-api.h:
1077 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1078 * src/maemo/modest-msg-edit-window.c:
1079 (modest_msg_edit_window_attach_file_noninteractive):
1080 added g_warning in case the file to be attached does not exist
1081 * tests/dbus_api/test_compose_mail.c: (main):
1082 removed obsolete comment, added generic files as test case
1084 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1086 * src/modest-tny-account-store.c: (get_server_accounts):
1087 Create the local folders account only once, not once for each outbox, and
1088 not only when there are some outboxes.
1090 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1092 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1093 code that is causing a crash at startup. Sergio says that he is fixing this.
1095 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1097 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1098 * src/maemo/modest-account-settings-dialog.c:
1099 (create_page_outgoing),
1100 (modest_account_settings_dialog_set_account_name),
1101 (save_configuration):
1102 - Fixed handling of the "Use secure authentication" toggle to comply with
1103 the ui specification. See also projects.maemo.org bug NB#58400
1105 - Restore the Secure connection setting combo correctly when loading
1108 * src/maemo/modest-maemo-utils.c:
1109 (on_camel_account_get_supported_secure_authentication),
1110 (modest_maemo_utils_get_supported_secure_authentication_methods):
1111 Fixed a crasher if operation is canceled
1113 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1114 (modest_protocol_info_auth_is_secure):
1115 * src/modest-protocol-info.h:
1117 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1118 the sense of the "Use secure authentication" toggle.
1120 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1122 * src/modest-tny-account-store.h:
1123 * src/modest-tny-account-store.c:
1124 Added modest_tny_account_store_get_local_folders_account().
1126 * src/modest-tny-folder.h:
1127 * src/modest-tny-folder.c:
1128 (modest_tny_folder_get_account):
1129 Added this replacement for tny_folder_get_account() which returns
1130 the local-folders account for TnyMergeFolders, to avoid the
1131 warning about the unimplemented get_account_func() vfunc().
1133 (modest_tny_folder_get_rules),
1134 * src/modest-ui-actions.c:
1135 (modest_ui_actions_on_folder_selection_changed):
1136 * src/modest-mail-operation.c:
1137 (modest_mail_operation_remove_folder),
1138 (modest_mail_operation_xfer_folder),
1139 (modest_mail_operation_rename_folder),
1140 (modest_mail_operation_get_msg),
1141 (modest_mail_operation_get_msgs_full),
1142 (modest_mail_operation_remove_msg),
1143 (modest_mail_operation_xfer_msgs),
1144 (modest_mail_operation_refresh_folder):
1145 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1147 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1149 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1150 (modest_server_account_set_security):
1151 * src/modest-defs.h: Add comments explaining that our
1152 UI spec means TLS when it says Normal, so these do not look like errors.
1154 * src/modest-tny-account.c:
1155 (modest_tny_account_new_from_server_account): Use the new tinymail
1156 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1157 for TLS. This should fix projects.maemo.org bug NB#58460.
1159 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1161 * src/maemo/easysetup/modest-easysetup-wizard.c:
1162 (create_account): Correct the position of the gconf sanity check warning.
1163 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1164 of using the g_idle_add() hack, because this does not seem to be necessary
1165 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1166 caused by something other than maemo's gconf.
1167 This fixes projects.maemo.org bug #59022.
1169 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1171 * src/modest-account-mgr-helpers.c:
1172 (modest_account_mgr_get_default_account): Do not check that the account
1173 exists if there is no default account (NULL), to fix a runtime warning.
1175 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1177 * src/widgets/modest-folder-view.c: (update_model):
1178 Do not unref the treemodel before we have finished with it.
1179 This prevents a valgrind warning and an occasional crash at startup.
1181 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1183 * libmodest-dbus-client/libmodest-dbus-client.h:
1184 added libmodest_dbus_client_compose_mail()
1185 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1187 added functions needed for SendAsMail() functionality
1188 * src/maemo/modest-msg-edit-window.c:
1189 (modest_msg_edit_window_attach_file_noninteractive):
1190 non interactively attaching files to message edit window
1191 * src/widgets/modest-msg-edit-window.h:
1192 * tests/dbus_api/Makefile.am:
1193 added test_compose_mail.c
1194 * tests/dbus_api/test_compose_mail.c: (main):
1196 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1198 * src/modest-account-view.c:
1199 Fixed bug projects.maemo.org bug NB#59307
1201 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1203 * src/maemo/easysetup/modest-easysetup-wizard.c:
1204 (get_serverport_incoming), (on_before_next), (create_account):
1205 * src/maemo/modest-account-settings-dialog.c:
1206 (modest_account_settings_dialog_set_account_name):
1207 * src/maemo/modest-maemo-utils.c:
1208 (on_camel_account_get_supported_secure_authentication_status),
1209 (on_camel_account_get_supported_secure_authentication),
1210 (on_secure_auth_cancel),
1211 (modest_maemo_utils_get_supported_secure_authentication_methods):
1213 Implemented security authentication for settings and easysetup.
1215 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1217 * src/maemo/modest-main-window.c: (create_details_widget):
1218 Show the total size for memory card accounts too, instead of showing
1219 the name again. Fixes bug projects.maemo.org bug NB#59307.
1221 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1224 * src/modest-tny-simple-folder-store.c:
1225 * src/modest-tny-simple-folder-store.h: Removed.
1227 * src/modest-tny-local-folders-account.h
1228 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1229 for the local-folders maildir, with an extra TnyMergedFolder containing
1230 the folders of the per-account outbox store accounts.
1231 * src/modest-tny-account-store.c: (get_server_accounts):
1232 Add the outboxes to the special local folders account after creating it.
1234 * src/modest-tny-account.c:
1235 (modest_tny_account_new_for_local_folders): Create the derived
1236 account when creating the main local-folders account.
1238 * src/maemo/modest-main-window.c: (create_details_widget),
1239 (modest_main_window_set_contents_style):
1240 Adapted to the use of the derived account instead of the folder store.
1242 * src/modest-ui-actions.c:
1243 (modest_ui_actions_on_folder_selection_changed):
1244 * src/modest-ui-dimming-rules.c:
1245 (modest_ui_dimming_rules_on_new_folder):
1246 * src/widgets/modest-folder-view.c: (text_cell_data),
1247 (icon_cell_data), (filter_row), (update_model),
1248 (get_cmp_rows_type_pos):
1251 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1252 Do not get the priv struct, because no priv struct has been set,
1253 to avoid a runtime warning.
1255 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1256 #ifelse with #else, to fix a warning, to fix the build.
1259 2007-06-05 Christian Kellner <ckellner@openismus.com>
1261 * libmodest-dbus-client/libmodest-dbus-client.c:
1262 Fix small typo in doc (why do you always see them
1263 AFTER committing stuff?)
1266 2007-06-05 Christian Kellner <ckellner@openismus.com>
1268 * libmodest-dbus-client/libmodest-dbus-client.c:
1269 (libmodest_dbus_client_search):
1270 Initialize hit list with NULL. Also set folder list
1271 to "" if NULL was supplied.
1274 2007-06-03 Christian Kellner <ckellner@openismus.com>
1276 * libmodest-dbus-client/libmodest-dbus-client.c:
1277 (modest_search_hit_list_free):
1278 Make it save to call it with NULL.
1280 * src/dbus_api/modest-dbus-callbacks.c:
1281 * src/modest-search.c:
1282 Return full ModestSearchHits as the search result list not TnyHeader
1283 since can't be around withouth the correspoding TnyFolder.
1285 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1287 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1288 Added currently commented code to check for secure auth
1290 * src/maemo/modest-account-settings-dialog.c: (on_response),
1291 (save_configuration), (show_ok):
1292 Fixed projects.maemo.org bugs NB #59248 and #59251
1294 * src/maemo/modest-maemo-utils.c:
1295 (on_camel_account_get_supported_secure_authentication_status),
1296 (on_camel_account_get_supported_secure_authentication),
1297 (modest_maemo_utils_get_supported_secure_authentication_methods):
1298 * src/maemo/modest-maemo-utils.h:
1299 Moved get_supported_secure_authentication() method here to be able
1300 to use it from easysetup wizard.
1302 * src/modest-pair.c: (on_pair_compare_as_string):
1303 Should compare string with first part of pair and not
1304 strcmp pairs which will crash.
1306 * src/modest-protocol-info.c:
1307 (modest_protocol_info_protocol_is_store):
1308 * src/modest-protocol-info.h:
1309 Added modest_protocol_info_get_auth_protocol_name()
1311 2007-06-03 Armin Burgmeier <armin@openismus.com>
1313 * src/modest-mail-operation.c:
1314 (modest_mail_operation_get_msgs_full): Set priv->account also when
1315 only retrieving a single message. This avoids a crash when canceling
1318 (modest_mail_operation_notify_end): Do not explicitely remove the
1319 operation from the queue but only emit the progress_changed signal.
1320 The queue itself listens to that signal to remove the operation when
1321 it is finished. This reduces coupling and removes a potential deadlock
1322 when modest_mail_operation_notify_end() is called from the queue
1323 itself. If that is a problem performance-wise, I would suggest to
1324 implement a status-changed signal or something.
1326 * src/modest-mail-operation-queue.c: Make sure to never call a
1327 function from another file while the queue is locked. This (hopefully)
1328 fixes another deadlock when exiting the application while retrieving
1331 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1333 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1334 Fixed build if libogs is not available
1336 2007-06-03 Christian Kellner <ckellner@openismus.com>
1338 * libmodest-dbus-client/libmodest-dbus-client.h:
1339 * libmodest-dbus-client/libmodest-dbus-client.c:
1340 (libmodest_dbus_client_delete_message):
1341 Implement deletion of messages (Client side).
1343 (modest_search_hit_free),
1344 (modest_search_hit_list_free):
1345 Utility functions to free the result hits.
1347 * src/dbus_api/modest-dbus-api.h:
1348 * src/dbus_api/modest-dbus-callbacks.c:
1349 (on_delete_message),
1350 (modest_dbus_req_handler):
1351 Implement deletion of messages (Server side).
1353 * tests/dbus_api/test_search.c: (main):
1356 * tests/dbus_api/Makefile.am:
1357 * tests/dbus_api/test_delete_message:
1358 Add little test for the message deletion logic
1360 2007-06-03 Armin Burgmeier <armin@openismus.com>
1362 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1363 when the operation queue was not empty. projects.maemo.org bug
1366 2007-06-03 Armin Burgmeier <armin@openismus.com>
1368 * src/widgets/modest-account-view.c
1369 (on_account_default_toggled): Toggle default account column
1370 explicitely instead of waiting for gconf notification (which is
1371 currently ignored). This should fix projects.maemo.org bug NB#56910
1372 for now. It should probably be removed when gconf notifications are
1375 2007-06-03 Christian Kellner <ckellner@openismus.com>
1377 * libmodest-dbus-client/libmodest-dbus-client.c:
1378 Removed debugging spew.
1380 * src/dbus_api/modest-dbus-callbacks.c:
1381 Added debugging info.
1383 * src/modest-search.c:
1384 (modest_search_all_accounts):
1385 Use tny_account_store_get_accounts () on the account store
1386 to get all accounts which is the way to get all accounts.
1388 * tests/dbus_api/test_search.c: (main):
1389 Make it possible to supply the search term on the command line.
1391 2007-06-03 Christian Kellner <ckellner@openismus.com>
1393 * libmodest-dbus-client/libmodest-dbus-client.c:
1394 * libmodest-dbus-client/libmodest-dbus-client.h:
1395 Implement searching for mesages over raw dbus. (Client side)
1397 * src/dbus_api/Makefile.am:
1398 * src/dbus_api/modest-dbus-api.h:
1399 * src/dbus_api/modest-dbus-callbacks.c:
1400 * src/dbus_api/modest-dbus-callbacks.h:
1401 Search framework (Server side). Also implement on_idle_open_message().
1403 * src/maemo/modest-platform.c: (modest_platform_init):
1404 Prepare for raw dbus/osso rpc interaction.
1406 * src/modest-search.h:
1407 Changed minsize from unspecific guint to guint32.
1409 * src/modest-search.c:
1411 Added strange hack which magically made tnymail work.
1413 (modest_search_folder),
1414 (modest_search_account),
1415 (modest_search_all_accounts):
1416 Implement helper functions to search all accounts, specific account
1419 * tests/dbus_api/Makefile.am:
1420 * tests/dbus_api/test_open_message.c:
1421 Read url to open from commandline.
1423 * tests/dbus_api/test_search.c:
1424 Implement small test for dbus search stuff
1426 2007-06-02 Armin Burgmeier <armin@openismus.com>
1428 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1429 include account type and account title. This fixes projects.maemo.org
1432 * src/maemo/modest-account-view-window.c: Set a title for the window.
1434 2007-06-02 Armin Burgmeier <armin@openismus.com>
1436 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1437 incoming and outgoing server name based on email address and server
1438 types as long as the names have not been edited manually. This fixes
1439 projects.maemo.org bug NB#58671.
1441 2007-06-02 Armin Burgmeier <armin@openismus.com>
1443 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1444 server type cannot be changed in future to the incoming details page
1445 when creating an account. This fixes projects.maemo.org bug NB#59029.
1447 2007-06-02 Armin Burgmeier <armin@openismus.com>
1449 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1450 and assigned max width chars so that they wrap instead of being
1451 truncated. Fixes projects.maemo.org bug NB#56126.
1453 2007-06-02 Armin Burgmeier <armin@openismus.com>
1455 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1456 introductory note to the connection specific smtp servers dialog, as
1457 section 8.12 of the email UI specification requires. This fixes
1458 projects.maemo.org bug NB#59212.
1460 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1462 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1463 Check for running mail operations, and offer to cancel them, as per the UI
1464 spec. This fixes projects.maemo.org bug NB#59041 .
1465 However, I suspect that tinymail may still use the network connection
1466 in ways that we cannot detect or cancel. But it should at least adapt to
1467 changes fairly well.
1469 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1471 * src/modest-tny-account-store.c: (recreate_all_accounts),
1472 (get_cached_accounts), (get_server_accounts): Do more sensible
1473 ref-counting of the temporarily-cached outbox accounts list. This seems
1474 to fix a crash when entering the password when the password was wrong.
1476 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1478 * src/gnome/modest-main-window.c: (connect_signals):
1479 * src/modest-tny-account-store.c: (get_password),
1480 (modest_tny_account_store_alert): Added comments and clues and
1481 commented-out code about how we currently fail to deal with connection
1482 errors and wrong passwords, and how we should.
1484 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1486 * src/widgets/modest-retrieve-combo-box.c:
1487 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1488 This fixes projects.maemo.org bug NB#58472 .
1490 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1492 * src/maemo/easysetup/modest-easysetup-wizard.c:
1493 (create_page_complete_easysetup):
1494 (create_page_complete_custom): Correct the last commit,
1495 putting the correct sentences in the correct pages.
1497 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/easysetup/modest-easysetup-wizard.c:
1500 (create_page_complete_custom): Show the second sentence of text
1501 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1504 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1506 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1507 Set the leave-on-server conf key by default. This fixes
1508 projects.maemo.org bug NB#59258 .
1510 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1512 * src/maemo/modest-account-view-window.c:
1513 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1514 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1517 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1519 * src/maemo/easysetup/modest-easysetup-wizard.c:
1520 (create_caption_new_with_asterisk):
1521 * src/maemo/modest-account-settings-dialog.c:
1522 (create_caption_new_with_asterisk):
1523 Uncomment the code to add the asterisk, because they are no longer in the
1524 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1525 (update_incoming_server_title): Add an asterisk here too.
1527 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1529 * src/maemo/modest-maemo-global-settings-dialog.c:
1530 (current_connection): Check that we are even connected before trying to
1531 get the current connection name, to prevent a warning.
1533 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1534 Change the comments because tny_maemo_conic_device_connect() is now meant to
1536 * src/modest-mail-operation.c:
1537 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1538 make sure we have a connection and fail if we can't connect.
1540 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1542 * src/maemo/modest-main-window.c:
1543 (on_account_store_connecting_finished): Do not try to get the
1544 connection ID if we are not really connected. I am surprised that
1545 this signal handler is called when we are not connected.
1547 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1549 * src/modest-error.h:
1550 * src/modest-ui-actions.c:
1551 (modest_ui_actions_get_msgs_full_error_handler):
1552 Renamed an enum, added comments, added an enum
1553 for retrieve-limit errors.
1555 * src/modest-mail-operation.c: (foreach_add_item),
1556 (internal_folder_observer_update), (update_account_thread),
1557 (modest_mail_operation_get_msgs_full):
1558 (modest_mail_operation_update_account),
1559 Added comments about how this works, and some code that should
1560 (but does not) check the retrieve-limit. See the TODO comment.
1562 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1564 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1565 Initialize help_id to fix the build. Warnings are good.
1567 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1569 * src/widgets/modest-hbox-cell-renderer.c:
1570 (modest_hbox_cell_renderer_append):
1571 * src/widgets/modest-vbox-cell-renderer.c:
1572 (modest_vbox_cell_renderer_append):
1573 Fix the last commit by doing an extra ref.
1575 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1577 * src/widgets/modest-hbox-cell-renderer.c:
1578 (modest_hbox_cell_renderer_append):
1579 * src/widgets/modest-vbox-cell-renderer.c:
1580 (modest_vbox_cell_renderer_append):
1581 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1582 to fix the build with Maemo Bora.
1583 However, there seems to be a remaining crash, probably due to reference
1586 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1588 * src/modest-tny-account.c:
1589 (modest_tny_account_new_for_local_folders):
1590 Use hildon_file_system_info_async_new() to get a better name for
1591 the memory card account, setting it as the account name.
1592 The timing seems to work, but this is probably
1593 not the best place to do this. See the TODO comment.
1594 * src/maemo/modest-main-window.c: (create_details_widget):
1595 * src/widgets/modest-folder-view.c: (text_cell_data):
1596 Use the tny account name instead of hardcoding a name.
1598 2007-05-30 Christian Kellner <ckellner@openismus.com>
1600 * src/modest-search.c: (modest_search):
1601 Correctly set part_search_func even if we have already parsed
1602 the query and thus a valid OgsTextSearcher object.
1604 2007-05-30 Christian Kellner <ckellner@openismus.com>
1607 Search and check for libogs.
1610 Incooparte the ogs build env.
1612 * src/modest-mime-part-search-stream.c:
1613 * src/modest-mime-part-search-stream.h:
1614 Removed since we do the real searching now in modest-search.c.
1616 * src/modest-search.c:
1617 * src/modest-search.h:
1618 Implement support for ogs. We use that if available and requested
1619 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1620 should now handle the corner case when the search term is spread
1621 across multiple reads.
1622 Also the logic in modest_search () was corrected to search all
1623 requested fields until one is found.
1625 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1627 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1629 * src/modest-init.h:
1630 * src/modest-init.c: Made modest_init_local_folders() take a
1631 path and be public so we can iniitialize maildir folders on
1634 * src/modest-local-folder-info.h:
1635 * src/modest-local-folder-info.c:
1636 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1638 * src/modest-tny-account.c:
1639 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1640 still means the standard local-folders path on the local volume.
1642 * src/modest-tny-account-store.c:
1643 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1644 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1645 all accounts when that happens.
1646 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1647 this too, so it shows up in the treeview.
1649 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1651 * src/maemo/modest-maemo-global-settings-dialog.c:
1652 (current_connection):
1653 * src/widgets/modest-global-settings-dialog.c:
1654 (current_connection_default):
1655 Use the enum values instead of 0, 1 and -1,
1656 to make the code clearer.
1658 * src/modest-account-mgr-helpers.c:
1659 (modest_account_mgr_get_connection_specific_smtp): Make this code
1662 * src/modest-runtime.h:
1663 * src/modest-runtime.c:
1664 Added modest_runtime_remove_all_send_queues().
1665 * src/maemo/modest-main-window.c:
1666 (on_account_store_connecting_finished): Recreate the send queues,
1667 using the appropriate transport accounts for this new connection.
1668 Some futher adapting might be needed if the old send queues are not
1669 automatically stopped at this point.
1671 * src/modest-tny-account-store.c: (get_server_accounts):
1672 Create the connection-specific transport accounts, so that they can
1673 be found later by their ID.
1675 * src/modest-tny-account.h:
1676 * src/modest-tny-account.c:
1677 Added modest_tny_account_new_from_server_account_name().
1678 modest_tny_account_new_from_server_account(): Do not create the
1679 send queues here, because they will be
1680 recreated anyway when the connection changes for the first time.
1682 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1684 * src/modest-local-folder-info.h:
1685 * src/modest-local-folder-info.c:
1686 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1687 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1688 tbox_folder): Take a modest account name instead of a server TnyAccount,
1689 so we can have per-modest-account rather than per-transport-account
1691 We must make sure that we change or recreate the exisitng send queues
1692 when the connection changes for connection-specific transport accounts.
1694 * src/modest-tny-account-store.c:
1695 (create_per_account_local_outbox_folders): Create outboxed per modest
1696 account, not per transport account.
1698 * src/modest-tny-account.h:
1699 * src/modest-tny-account.c:
1700 (modest_tny_account_get_special_folder): For outboxes, get the
1701 parent modest account name. The account is ignored for other folders.
1702 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1703 modest account name rather than a server TnyAccount.
1705 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1707 * src/modest-tny-account.c:
1708 (modest_tny_account_new_from_server_account):
1709 Call modest_runtime_get_send_queue() immediately after creating transport
1710 accounts, so that they start trying to send email from the outbox as soon
1711 as possible at startup. This is probably what we want.
1713 * src/modest-mail-operation.c: (update_account_thread):
1714 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1715 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1716 * src/modest-tny-send-queue.h:
1717 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1718 (modest_ui_actions_on_send):
1719 Added comments about how sending works, though it needs some more work.
1721 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1723 * src/modest-tny-account.c:
1724 (modest_tny_account_get_special_folder): Add TODO because this fails when
1725 the network is busy.
1726 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1727 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1728 Do not try to show this window when there is no active account. The UI
1729 specs does not tell us what to do in this case.
1731 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1735 * src/maemo/Makefile.am:
1736 * src/widgets/Makefile.am: Some dist fixes.
1738 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1740 * src/maemo/modest-connection-specific-smtp-window.c:
1741 (on_button_edit): Make the code clearer, to prevent a double free.
1743 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1745 * src/maemo/modest-account-settings-dialog.c:
1746 (modest_account_settings_dialog_set_account_name),
1747 Check the connection-specific smtp servers checkbox if there are any.
1749 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1750 (modest_connection_specific_smtp_edit_window_init):
1751 Start with a suitable port number.
1753 * src/modest-account-mgr-helpers.h:
1754 * src/modest-account-mgr-helpers.c: Added
1755 modest_account_mgr_get_has_connection_specific_smtp().
1757 (modest_account_mgr_set_connection_specific_smtp),
1758 (modest_account_mgr_remove_connection_specific_smtp),
1759 (modest_account_mgr_get_has_connection_specific_smtp),
1760 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1761 connection-specific smtp server accounts in the account, rather than
1762 the server account conf dir.
1764 This fixes bug projects.maemo.org bug NB#58263 .
1766 * src/modest-tny-account-store.c:
1767 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1768 if there are no server accounts yet, to prevent an infinite loop when there
1769 are no accounts. Document that one must be called before the other.
1771 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1773 * src/modest-account-mgr-helpers.c:
1774 (modest_account_mgr_get_default_account): Make sure that at least
1775 one account is always the default, if there are any enabled accounts.
1776 This is just a sanity check that shouldn't be necessary.
1778 * src/modest-account-mgr-priv.c:
1779 (_modest_account_mgr_account_from_key): Unescape the conf key to
1780 get the real account name. For instance, this is an issue if a space
1781 was in the account name, which can happen because the account name
1782 is generated from the display name.
1783 (_modest_account_mgr_get_account_keyname): Always escape the
1785 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1786 Unescape the conf keys to get the real account names.
1788 For instance, previously the is-default radio button in the accounts
1789 list was not checked for any accounts at first. This fixes that,
1790 and might fix several similar bugs.
1792 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1794 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1795 Removed some debug printfs.
1797 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1799 Modest on-disk outbox directories are now here, for instance:
1800 $HOME/.modest/outboxes/<account-id-1>/outbox
1801 $HOME/.modest/outboxes/<account-id-2>/outbox
1803 $HOME/.modest/local-folders/outbox
1804 so we can have a separate outbox for each account.
1805 But they are shown as one outbox in the GtkTreeView, by using a
1806 TnyMergeFolder in a ModestTnySimpleFolderStore.
1809 * src/modest-tny-simple-folder-store.c:
1810 * src/modest-tny-simple-folder-store.h:
1811 Added ModestTnySimpleFolderStore, used to contain folders from
1812 other folder stores, such as other accounts.
1814 * src/modest-tny-outbox-account.h:
1815 * src/modest-tny-outbox-account.c:
1816 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1817 used for the per-account local outbox folders.
1819 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1820 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1821 only use this (internally) now for the non-outbox local folders.
1823 * src/modest-init.h:
1824 * src/modest-init.c: Added modest_init_one_local_folder(), for
1825 setting up the directory structure for each local folder.
1827 * src/modest-local-folder-info.c:
1828 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1829 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1831 * src/modest-local-folder-info.h:
1832 * src/modest-tny-account-store.c: (on_account_removed),
1833 (on_account_changed), (create_per_account_local_outbox_folders),
1834 (get_server_accounts), (modest_tny_account_store_get_accounts),
1835 (modest_tny_account_store_get_tny_account_by_account),
1836 (modest_tny_folder_store_is_virtual_local_folders):
1838 * src/modest-tny-account.h:
1839 * src/modest-tny-account.c:
1840 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1841 to create an on-disk per-account local outbox folder for each
1843 (create_per_account_local_outbox_folders): Create a local outbox folder
1844 for each transport account.
1845 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1846 for all local folders.
1848 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1849 instead of using g_object_get/set() directly. It is clearer.
1851 (modest_tny_folder_store_get_message_count),
1852 (modest_tny_folder_store_get_local_size
1853 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1854 because we now use these with non-acount folder stores.
1856 (modest_tny_account_get_special_folder),
1857 (modest_tny_account_new_from_server_account),
1858 (modest_tny_account_new_from_account):
1859 (recurse_folders): Adjust to the new outbox system.
1861 * src/modest-tny-folder.h:
1862 * src/modest-tny-folder.c:
1863 (modest_tny_folder_is_local_folder),
1864 (modest_tny_folder_get_local_folder_type),
1865 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1867 * src/widgets/modest-main-window.h:
1868 * src/maemo/modest-main-window.c: (create_details_widget),
1869 (modest_main_window_set_contents_style): Show details for any folder store,
1872 (modest_tny_folder_get_rules):
1873 Remove the const. C does not support constness enough for this.
1875 * src/modest-ui-actions.c:
1876 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1877 make all outboxes appear as one, in the usual local-folders tree node.
1879 (set_active_account_from_tny_account),
1880 (modest_ui_actions_on_folder_selection_changed):
1881 * src/widgets/modest-folder-view.c: (text_cell_data),
1882 (icon_cell_data), (filter_row),
1883 (add_account_folders_to_merged_folder),
1884 (add_account_folders_to_simple_folder_store), (),
1885 (get_cmp_rows_type_pos), (cmp_rows),
1886 (modest_folder_view_set_account_id_of_visible_server_account):
1887 Adjust to the new outbox system, using generic folder stores and folders
1888 in the GtkTreeModel.
1890 2007-05-23 Christian Kellner <ckellner@openismus.com>
1892 * src/modest-mail-operation.c:
1893 (modest_mail_operation_update_account):
1894 Use info->max_size instead of unintialized local var [small
1895 build fix]. (Added TODO to review that change since I don't
1898 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1900 * libmodest-dbus-client/libmodest-dbus-client.c:
1901 (libmodest_dbus_client_compose_mail): function added
1902 * src/dbus_api/modest-dbus-api.h:
1903 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1904 (on_compose_mail): Implementation of the SendAsMail functionality
1906 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1908 * src/modest-account-mgr.c:
1909 (modest_account_mgr_add_server_account): Set the secure-connection
1910 conf key for transport accounts as well as store accounts. I don't know
1911 why the if was there. For instance, this makes sure that we use SSL
1912 for the gmail preset from the easysetup wizard.
1914 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1916 * src/gnome/modest-main-window.c:
1917 (on_account_store_connecting_finished), (connect_signals):
1918 * src/maemo/modest-main-window.c:
1919 (on_account_store_connecting_finished), (connect_signals),
1920 (modest_main_window_new):
1921 Handle TnyAccountStore::connecting-finished instead of
1922 TnyDevice::connection-changed, because we cannot actually perform
1923 operations on accounts until TnyAccountStore has itself responded to
1924 the TnyDevice::connection-changed signal. This prevents a GError from
1926 Do not try to update at startup, because we (at least on scratchbox)
1927 already do an update at startup when the device goes online.
1928 This prevents a GError from tinymail.
1929 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1930 Added TODO about stopping simultaneous operations.
1932 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1934 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1935 * src/modest-mail-operation-queue.c:
1936 (modest_mail_operation_queue_remove):
1937 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1938 about where they happened.
1940 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1942 * src/modest-ui-actions.c:
1943 (modest_ui_actions_on_password_requested): Make sure that the remember
1944 output parameter is always TRUE.
1946 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1948 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1949 Show a OK/Cancel dialog if the error is a question, though we still do not
1950 know anything more about what we are asking the user.
1951 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1952 Fix an uninitialized variable (helper). This is a logic error, however.
1954 2007-05-21 Christian Kellner <ckellner@openismus.com>
1956 * src/modest-search.h:
1957 Correct bit shifting in the ModestSearchFlags enum.
1959 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1961 * src/modest-tny-account.c:
1962 (modest_tny_account_new_from_server_account): Do not use the lsub and
1963 check-all hard-coded IMAP options when using POP.
1965 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1967 * src/modest-tny-account.c:
1968 (modest_tny_account_new_from_server_account):
1969 Use NULL for the secure-auth method for POP when Password auth has been
1970 specified by the user, as we already do for IMAP. "auth=Login" causes
1971 an error from camel or the server.
1973 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1975 * src/maemo/modest-account-settings-dialog.c:
1976 (create_page_account_details),
1977 (modest_account_settings_dialog_set_account_name):
1978 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1979 for the leave-on-server checkbox, rathr than just the checkbox, when
1980 the protocol is not POP.
1982 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1984 * src/widgets/modest-account-view.c:
1985 * src/widgets/modest-account-view.h:
1986 Added modest_account_view_select_account() which will be useful later
1987 to asynchronously re-select the edited account.
1989 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1991 * src/maemo/modest-account-settings-dialog.c:
1992 (modest_account_settings_dialog_set_account_name):
1993 Automatically choose the port numbers based on the secure authentication
1994 methods, if they have not been chosen before.
1995 This fixes projects.maemo.org bug NB#56273 .
1997 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/modest-main-window-ui.h:
2000 * src/modest-ui-actions.c:
2001 * src/modest-ui-actions.h:
2002 Connect the Tools/SMTP Servers menu item to
2003 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2004 SMTP servers dialog, as in the UI specification and saves changes when it
2005 is closed. This fixed projects.maemo.org bug NB#56305 .
2007 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2009 * src/maemo/modest-connection-specific-smtp-window.c:
2010 (modest_connection_specific_smtp_window_init):
2011 Use gtk_window_set_default_size() to make this window big enough, so
2012 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2014 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2016 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2017 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2018 (modest_connection_specific_smtp_edit_window_init),
2019 Do not try to connect to a combobox signal before the combobox exists.
2020 This fixes the cras in projects.maemo.org bug NB#56288 .
2021 (modest_connection_specific_smtp_edit_window_get_settings):
2022 Remove the server_account_name parameter which was being checked for NULL
2023 though it was not used.
2025 * src/maemo/modest-connection-specific-smtp-window.c:
2026 (modest_connection_specific_smtp_window_fill_with_connections),
2027 (on_button_edit), (modest_connection_specific_smtp_window_init):
2028 Correct the number of treemodel columns to prevent a warning.
2029 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2030 libconic does not work.
2032 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2034 * src/modest-tny-account.c:
2035 (modest_tny_account_new_from_server_account):
2036 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2037 SMTP when "None" was chosen by the user. However, with my SMTP server that
2038 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2041 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2043 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2044 to explain the memory management issue with the ID in the ModestPair.
2046 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2047 (add_sending_page), (modest_account_assistant_finalize):
2048 * src/gnome/modest-gnome-global-settings-dialog.c:
2049 (create_updating_page), (create_composing_page):
2050 * src/gnome/modest-msg-edit-window.c: (get_transports),
2051 (init_window), (modest_msg_edit_window_finalize),
2052 (modest_msg_edit_window_get_msg_data):
2053 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2054 * src/gnome/modest-transport-widget.c:
2055 (modest_transport_widget_finalize), (smtp_configuration):
2056 * src/maemo/modest-maemo-global-settings-dialog.c:
2057 (create_updating_page), (create_composing_page):
2058 * src/maemo/modest-msg-edit-window.c: (get_transports),
2059 (init_window), (modest_msg_edit_window_finalize),
2060 (modest_msg_edit_window_get_msg_data),
2061 (modest_msg_edit_window_free_msg_data):
2062 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2063 (modest_store_widget_finalize):
2064 * src/maemo/modest-transport-widget.c:
2065 (modest_transport_widget_finalize), (smtp_configuration):
2066 * src/modest-main.c: (send_mail):
2067 * src/widgets/modest-combo-box.h:
2068 * src/widgets/modest-global-settings-dialog-priv.h:
2069 * src/widgets/modest-global-settings-dialog.c:
2070 (modest_global_settings_dialog_finalize):
2071 * src/widgets/modest-msg-edit-window.h:
2072 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2073 as long as the combo box, to prevent use of freed memory for the ID.
2075 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2077 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2078 get_accounts(), to make this clearer. Do not check for the enabled gconf
2079 key, because we do not use this for server accounts (at least, not yet).
2080 This allows us to send email again.
2082 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2084 * src/maemo/modest-platform.c:
2085 (on_modest_conf_update_interval_changed), (modest_platform_init):
2086 Only respond to this particular key change. All these strcmp()s cannot be
2089 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2091 * src/maemo/modest-maemo-global-settings-dialog.c:
2092 (current_connection): Prevent a crash in scratchbox when
2093 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2094 * src/maemo/modest-platform.c:
2095 (on_modest_conf_update_interval_changed), (modest_platform_init):
2096 Get the update interval from gconf and reset it when the gconf key changes.
2098 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2100 * src/modest-protocol-info.c:
2101 * src/modest-protocol-info.h: Adde enum-specific get functions,
2102 instead of using a ModestProtocolType enum parameter.
2104 * src/gnome/modest-account-assistant.c:
2105 * src/gnome/modest-store-widget.c:
2106 * src/gnome/modest-store-widget.h:
2107 * src/gnome/modest-transport-widget.c:
2108 * src/gnome/modest-transport-widget.h:
2109 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2110 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2111 * src/maemo/easysetup/modest-easysetup-wizard.c:
2112 * src/maemo/modest-account-settings-dialog.c:
2113 * src/maemo/modest-account-settings-dialog.h:
2114 * src/maemo/modest-store-widget.c:
2115 * src/maemo/modest-store-widget.h:
2116 * src/maemo/modest-transport-widget.c:
2117 * src/maemo/modest-transport-widget.h:
2118 * src/modest-account-mgr-helpers.c:
2119 * src/modest-account-mgr-helpers.h:
2120 * src/modest-account-mgr.c:
2121 * src/modest-account-mgr.h:
2122 * src/modest-tny-account.c:
2123 * src/modest-tny-folder.c:
2124 * src/widgets/modest-account-view.c:
2125 * src/widgets/modest-retrieve-combo-box.c:
2126 * src/widgets/modest-retrieve-combo-box.h:
2127 * src/widgets/modest-secureauth-combo-box.c:
2128 * src/widgets/modest-serversecurity-combo-box.c:
2129 * src/widgets/modest-serversecurity-combo-box.h:
2130 * tests/check_account-mgr.c:
2131 Use the specific functions, and use the re-renamed enum values for GNOME too.
2133 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2135 * src/modest-pair.h:
2136 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2137 so we can get the second based on the first.
2139 * src/maemo/modest-account-settings-dialog.h:
2140 * src/maemo/modest-account-settings-dialog.c:
2141 Added get_supported_secure_authentication_methods(), though it is mostly
2142 commented-out for now until the necessary API is committed to tinymail.
2143 (modest_account_settings_dialog_set_account_name),
2144 (save_configuration): Request the supported authentication methods from the
2145 server, so we can choose a working method.
2147 * src/modest-tny-account-store.h:
2148 * src/modest-tny-account-store.c:
2149 (modest_tny_account_store_get_session): Rename from
2150 tny_account_store_get_session().
2152 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2154 * src/modest-protocol-info.h: Split the ModestProtocol enum
2155 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2156 There was no need to have these unrelated values in one enum.
2158 * src/: many files: Adapted to changed enum. This makes the code a bit
2159 clearer, and the compiler could catch some errors.
2161 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2163 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2164 Show the detailed internal camel error message when an error happens
2165 during the configuration, so that our testers can give us more clues.
2166 For instance, in projects.maemo.org bug NB#56910 .
2168 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2170 * src/modest-tny-account.c:
2171 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2172 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2174 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2176 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2177 * src/maemo/modest-account-settings-dialog.c:
2178 (modest_account_settings_dialog_set_account_name),
2179 (save_configuration): For the incoming secure authentication checkbox,
2180 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2181 the UI specification. PLAIN does not seem to be supported for most IMAP
2182 servers anyway, and I am not sure what it would mean.
2183 However, we probably need to discover which of the secure-authentication
2184 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2185 * src/modest-account-mgr-helpers.c:
2186 (modest_account_mgr_get_server_account_data):
2188 * src/modest-tny-account.c:
2189 (modest_tny_account_new_from_server_account):
2190 Use tny_account_set_mech() to set secure-authentication methods,
2191 with some special-casing for IMAP, based on my observations of how
2194 * src/modest-account-mgr-helpers.h:
2195 * src/modest-account-mgr.c:
2196 * src/modest-defs.h: Comment that the URI is only used for local folders.
2198 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2200 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2201 parameter const, just to be neat.
2202 * src/modest-text-utils.c: (modest_text_utils_inline):
2203 End g_strconcat() with NULL, as its documentation says. This is almost
2204 certainly the cause of my crash at startup on the device. Interestingly,
2205 valgrind doesn't tell us about these errors.
2207 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2209 * scripts/build-packages: Added more precise comments about how to use
2210 this script, though I still get this error:
2211 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2212 error building tinymail
2214 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2216 * src/maemo/modest-main-window.c: (on_account_update):
2217 Very slight cleanup, hoping to make it simpler to discover what causes
2218 a crash here sometimes.
2220 * src/modest-tny-account.c:
2221 (modest_tny_account_new_from_server_account): Set the port. Added
2222 comments about the options and a TODO comment because I need to find out
2223 how to specify the secure authentication method.
2225 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2227 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2228 changed CFlags paths form modest to libmodest
2230 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2232 * src/modest-account-mgr-helpers.c:
2233 (modest_account_mgr_get_server_account_data),
2234 (modest_account_mgr_free_server_account_data):
2235 * src/modest-account-mgr-helpers.h:
2236 * src/modest-account-mgr.c:
2237 (modest_account_mgr_add_server_account):
2238 * src/modest-defs.h:
2239 * src/modest-tny-account.c:
2240 (modest_tny_account_new_from_server_account):
2241 Determine the options for tny_camel_account_add_option() here,
2242 based on the settings, rather than storing them directly in gconf.
2244 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2246 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2247 Show a more friendly error dialog now that we expect (from the tinymail
2248 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2250 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2252 * src/maemo/modest-main-window.c: (on_account_update): Check that
2253 account_name is not NULL, to prevent a crash at startup that I am
2254 seeing on the N800. I do wonder why it is NULL.
2256 * src/maemo/easysetup/modest-easysetup-wizard.c:
2257 (create_page_user_details):
2258 * src/maemo/modest-account-settings-dialog.c:
2259 (create_page_user_details), (create_page_outgoing):
2260 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2261 (modest_connection_specific_smtp_edit_window_init):
2262 * src/modest-ui-actions.c:
2263 (modest_ui_actions_on_password_requested):
2264 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2265 might do something useful with the on-screen keyboard.
2267 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2269 * src/maemo/modest-main-window.c: (on_account_update):
2270 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2271 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2273 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2275 * src/modest-tny-account-store.c: (on_account_changed):
2276 Correct the signature of this signal handler.
2278 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2280 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2281 Show a HildonNote instead of a GtkDialog for Maemo.
2283 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2285 * src/widgets/modest-account-view.h:
2286 * src/widgets/modest-account-view.c: (on_account_changed),
2287 (on_account_removed). Added a boolean flag, set/unset by
2288 modest_account_view_block_conf_updates(),
2289 modest_account_view_unblock_conf_updates() to prevent unnecessary
2290 updates, but this is not very useful because the gconf notifications are
2291 so delays (maybe only on Maemo Bora).
2292 So auto-updating is turned off, and these functions do an explicit
2293 update when necessary.
2294 However, something else is still doing too much work when adding/removing
2295 accounts, probably in another part of the application.
2297 * src/maemo/modest-account-view-window.c:
2298 (on_delete_button_clicked), (on_edit_button_clicked),
2299 (on_new_button_clicked): Use the new functions.
2301 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2303 * src/modest-account-mgr-helpers.c:
2304 (modest_account_mgr_set_first_account_as_default):
2305 Sort the list of names alphabetically-by-title, so we choose the first one
2307 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2308 alphabetically by the title.
2310 This fixes projects.maemo.org bug NB#56418 .
2312 * src/modest-account-mgr-priv.c:
2313 (_modest_account_mgr_account_from_key):
2314 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2315 avoid a valgrind error, and possible random behaviour.
2317 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2319 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2320 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2321 tinymail documentation to say that this can be expected.
2322 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2323 pretty, and should not happen, but I would prefer to know when it does.
2325 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2327 * configure.ac: When using the older hildon version, probably on Bora,
2328 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2330 * src/widgets/modest-attachment-view.c:
2331 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2334 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2336 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2337 Implemented the prototype. Can be tested with
2338 tests/dbus_api/test_open_message:
2340 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2342 * src/modest-tny-account-store.c:
2343 (modest_tny_account_store_instance_init), (get_password):
2344 * src/modest-ui-actions.c:
2345 (modest_ui_actions_on_password_requested):
2346 Do not store the password in gconf, because this function is called
2347 for non-remembered passwords. Actually use the cached (in the hash map)
2348 password instead of releasing it.
2349 The password will now not be remembered if it is asked via the protected
2350 password dialog, as per the UI spec.
2352 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2354 * src/modest-defs.h:
2355 * src/modest-account-mgr-helpers.h:
2356 * src/modest-account-mgr-helpers.c:
2357 Added modest_server_account_get_username_has_succeeded(),
2358 modest_server_account_set_username_has_succeeded().
2359 (modest_server_account_set_username),
2360 Reset the has-succeeded flag if the username changes.
2362 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2363 * src/maemo/modest-connection-specific-smtp-window.c:
2364 (modest_connection_specific_smtp_window_save_server_accounts):
2365 Use modest_server_account_set_username() instead of using
2366 modest_conf_set_string() directly, so that the has-succeeded flag is always
2369 * src/modest-ui-actions.c:
2370 (modest_ui_actions_on_password_requested): Dim the username entry if
2371 the username has ever worked, as per the UI spec.
2373 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2375 * src/modest-tny-account-store.c: (get_password):
2376 * src/modest-ui-actions.c:
2377 (modest_ui_actions_on_password_requested):
2378 Allow the username to be changed too, though there is more work to
2379 be done on exactly how this behaves.
2381 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2383 * src/modest-account-mgr-helpers.h:
2384 * src/modest-account-mgr-helpers.c:
2385 Added modest_account_mgr_get_display_name(),
2386 modest_server_account_get_username(),
2387 modest_server_account_set_username(),
2388 modest_server_account_set_password(),
2389 modest_server_account_get_hostname() functions so we do not need to
2390 use the conf API directly.
2392 * src/maemo/modest-main-window.c: (connect_signals):
2393 Actually connect ot the ModestAccountStore::request-password signal,
2394 so that we show the dialog when the password is requested by Tinymail,
2395 for isntance if it is empty.
2397 * src/modest-marshal.list:
2398 * src/modest-tny-account-store.c:
2399 (modest_tny_account_store_class_init), (get_password),
2400 (modest_tny_account_store_alert):
2401 * src/modest-tny-account-store.h:
2402 * src/modest-ui-actions.h:
2403 * src/modest-ui-actions.c:
2404 (modest_ui_actions_on_password_requested):
2405 Change the signal parameters, so it is obvious that we are providing
2406 the non human-readable server name, and receiving both the username
2407 and password, though changing of the username is not yet implemented.
2408 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2409 for the GNOME version.
2411 This should fix the projects.maemo.org bug NB#56209, though it does not
2412 work on Bora, because the gconf_client_get() for the password fails
2413 immediately after we save it with gconf_client_set().
2415 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2418 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2419 caused an undefined symbol error:
2420 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2422 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2424 * src/modest-tny-account-store.c:
2425 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2426 using a GError instead of a string message, so we can translate it in
2429 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2431 * src/maemo/modest-address-book.c:
2432 (modest_address_book_check_names):
2433 * src/maemo/modest-msg-view-window.c:
2434 (modest_msg_view_window_clipboard_owner_change):
2435 * src/modest-init.c: (modest_init_init_ui):
2436 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2437 (update_folders_cb), (modest_mail_operation_update_account):
2438 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2439 (modest_ui_actions_on_msg_attachment_clicked),
2440 (modest_ui_actions_on_msg_recpt_activated):
2441 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2442 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2443 (modest_msg_view_search_next):
2444 * src/widgets/modest-recpt-editor.c:
2445 (modest_recpt_editor_on_button_release_event),
2446 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2447 g_message(). At this point we should only be seeing interesting errors on
2448 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2450 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2452 (modest_wizard_dialog_force_title_update):
2453 * src/maemo/easysetup/modest-wizard-dialog.h:
2454 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2455 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2456 can update the title when appropriate. Otherwise the title is wrong if the
2457 pages are added after adding the notebook to the dialog.
2458 This must be a problem in HildonWizardDialog too.
2459 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2461 * src/maemo/easysetup/modest-easysetup-wizard.c:
2462 (create_subsequent_customsetup_pages),
2463 (create_subsequent_easysetup_pages):
2464 Call modest_wizard_dialog_force_title_update() so that the title is
2465 correct even with GTK+ < 2.10.
2466 This fixes projects.maemo.org bug NB#56145 .
2468 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2470 * src/maemo/modest-platform.c:
2471 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2472 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2475 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2477 * src/widgets/modest-window.h:
2478 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2479 and modest_window_save_state(), which invokes it.
2481 * src/widgets/modest-window-mgr.h:
2482 * src/widgets/modest-window-mgr.c:
2483 Added modest_window_mgr_save_state_for_all_windows(), which calls
2484 the save_state vfunc on all registered windows, if implemented.
2486 * src/gnome/modest-msg-edit-window.c:
2487 * src/gnome/modest-msg-view-window.c:
2488 * src/maemo/modest-msg-edit-window.c:
2489 * src/maemo/modest-msg-view-window.c:
2490 * src/maemo/modest-main-window.c:
2491 Specify the existing save_settings functions as implementations of
2492 ModestWindow::save_state_func().
2494 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2495 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2496 enabling hibernation, for instance.
2498 We may need to do the same thing for restoring settings.
2501 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2503 * src/widgets/modest-window-mgr.c:
2504 * src/widgets/modest-window-mgr.h:
2505 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2506 modest_window_mgr_get_hibernation_is_prevented().
2508 * src/maemo/modest-main-window.c:
2509 (on_hildon_program_is_topmost_notify): Prevent hibernation
2510 (possible when the application goes to the background in the WM),
2511 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2513 * src/maemo/easysetup/modest-easysetup-wizard.c:
2514 (modest_easysetup_wizard_dialog_init):
2515 * src/maemo/modest-account-settings-dialog.c:
2516 (modest_account_settings_dialog_init):
2517 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2518 (modest_connection_specific_smtp_edit_window_init):
2519 * src/maemo/modest-connection-specific-smtp-window.c:
2520 (modest_connection_specific_smtp_window_init):
2521 * src/maemo/modest-signature-editor-dialog.c:
2522 (modest_signature_editor_dialog_init):
2523 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2524 prevent hibernation while any of these account settings dialogs are open.
2526 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2528 * src/maemo/Makefile.am:
2529 * src/maemo/modest-osso-state-saving.c:
2530 * src/maemo/modest-osso-state-saving.h: Added
2531 modest_osso_load_state() and modest_osso_save_state() though they do
2532 nothing now. They should iterate through all the open windows and load/save
2534 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2535 save state when closing.
2537 * src/maemo/modest-main-window.c:
2538 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2539 Add a notification handler for the HildonProgram::is-topmost property,
2540 so we can allow hibernation when the application goes into the background.
2541 But we still need to detect when the accounts setup windows are open so
2542 we can stop hibernation when they are open.
2543 To do this, I also added the main window the HildonProgram. This might have
2544 other side-effects/benefits, and should maybe be done for other windows.
2546 * src/maemo/modest-osso-autosave-callbacks.h:
2547 * src/maemo/modest-osso-autosave-callbacks.c:
2548 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2549 though it does not do anything yet, and we might never need this to do
2550 anything. For instance, we already save drafts.
2552 * src/maemo/modest-platform.c: (modest_platform_init):
2553 Specify the libosso auto-save callback.
2555 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2557 * src/maemo/modest-platform.c:
2558 (modest_platform_set_update_interval):
2559 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2560 aparently stays valid between application instances, so we can use this
2561 to remove and reset it later. According to a maemo-developers email from
2564 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2566 * configure.ac: Depend on libalarm for Maemo.
2568 * src/dbus_api/modest-dbus-api.h:
2569 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2570 (on_send_receive), (modest_dbus_req_handler):
2571 Handle a SEND_RECEIVE D-Bus method.
2573 * libmodest-dbus-client/libmodest-dbus-client.c:
2574 (libmodest_dbus_client_send_and_receive):
2575 * libmodest-dbus-client/libmodest-dbus-client.h:
2576 Add C convenience functions for calling the new D-Bus method.
2578 * src/modest-platform.h:
2579 * src/gnome/modest-platform.c:
2580 * src/maemo/modest-platform.c:
2581 Added modest_platform_set_update_interval(), which uses the
2582 alarmd API on Maemo.
2583 (modest_platform_init),
2584 Call modest_platform_set_update_interval(), using a hard-coded
2585 interval for now (until the global settings dialog is implemented),
2586 though I am not sure that this makes sense yet.
2588 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2590 * src/dbus_api/modest-dbus-callbacks.c:
2591 (modest_osso_cb_hw_state_handler):
2592 * src/dbus_api/modest-dbus-callbacks.h:
2593 * src/maemo/modest-platform.c: (modest_platform_init):
2594 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2595 in case this has some effect on the ability for Maemo to ping the
2598 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2600 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2601 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2602 warning. It is probably a logic error, but I need to fix the build.
2604 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2606 * src/modest-account-mgr.h:
2607 * src/modest-account-mgr.c:
2608 (modest_account_mgr_account_names): Add a gboolean enabled_only
2609 parameter, so we can get lists of onlt the enabled accounts.
2611 (modest_account_mgr_add_account),,
2612 (modest_account_mgr_account_with_display_name_exists):
2613 * src/maemo/modest-msg-edit-window.c: (get_transports):
2614 * src/modest-account-mgr-helpers.c:
2615 (modest_account_mgr_set_first_account_as_default):
2616 * src/modest-init.c: (init_default_account_maybe):
2617 * src/modest-tny-account-store.c: (get_accounts):
2618 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2619 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2620 * tests/check_account-mgr.c: (START_TEST):
2621 Provide the extra parameter, as appropriate.
2623 * src/widgets/modest-account-view.c: (update_account_view):
2624 Do not show disabled accounts (meaning that there is no way to
2625 enable/disable accounts in the UI (the feature is not in our UI
2626 specification), so we can use this internally only to mark unfinished
2627 or temporary account data.
2629 * src/maemo/easysetup/modest-easysetup-wizard.c:
2630 (create_account): Add boolean enable parameter, so we can specify FALSE
2631 to create the temporary account.
2632 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2633 (on_before_next): When finishing, when there is a temporary account, just
2635 Also, use a timeout to delay the showing of the dialog until gconf is likely
2636 to return correct information, due to a maemo gconf bug that is fixed in
2637 osso 1.1, but not yet in Bora.
2638 However, the dialog stays on screen after it is destroyed.
2640 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2641 for invalid data when cancelling. Use a hildon note instead of a dialog
2642 to complain about invalid data. Do not show the account-saved note if the
2643 account is disabled (a temporary account that will not really be saved for use
2646 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2648 * src/modest-account-mgr-helpers.h:
2649 * src/modest-account-mgr-helpers.c:
2650 Added modest_account_mgr_unset_default_account(),
2651 Added modest_account_mgr_set_first_account_as_default().
2653 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2654 If it was the default account, unset the default account name.
2656 * src/maemo/modest-account-view-window.c:
2657 (on_delete_button_clicked): If it was the default account,
2658 set the first remaining account as the default instead.
2660 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2661 a NULL account or a NULL default account, to prevent a crash. This should
2662 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2665 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2667 * src/widgets/modest-recpt-editor.c:
2668 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2669 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2670 TODO comment for this. This fixes the build.
2672 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2673 be the best place for it. This will in future update all auto-update accounts,
2674 rather than just the current/default account, when that gconf key exists.
2675 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2676 if there are no accounts, before calling do_send_receive().
2677 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2679 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2680 * src/maemo/modest-main-window-ui.h:
2681 * src/maemo/modest-main-window.c: (on_connection_changed),
2682 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2683 directly, becaue the signal handler does more.
2685 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2687 * src/modest-account-mgr-helpers.c:
2688 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2689 for the case that the account does not exist.
2691 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2692 (equivalent to the modest account name) rather than the tinymail account name
2693 (equivalent to the modest account title - human readable) to get the account data.
2694 Check for null account data to prevent the crash, and add a TODO comment saying that
2695 this needs fixing because it is using the server account name instead of the account name.
2697 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2699 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2700 * src/maemo/modest-account-settings-dialog.c: (show_error),
2702 Use hildon_note_new_information() for informative and error messages,
2703 which seems to be expected for Maemo applications (no documentation that I know of
2704 says this). I am surprised that there is no distinction between info and error
2707 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2709 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2710 it is easy to find where this is used.
2712 * src/maemo/easysetup/modest-easysetup-wizard.c:
2713 (create_page_welcome), (create_page_account_details),
2714 (create_page_user_details), (create_page_complete_easysetup),
2715 (create_page_custom_incoming), (create_page_custom_outgoing),
2716 (create_page_complete_custom):
2717 * src/maemo/modest-account-settings-dialog.c:
2718 (create_page_account_details), (create_page_user_details),
2719 (create_page_incoming), (create_page_outgoing):
2720 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2721 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2722 (modest_connection_specific_smtp_edit_window_init):
2723 * src/maemo/modest-connection-specific-smtp-window.c:
2724 (modest_connection_specific_smtp_window_init):
2725 * src/maemo/modest-signature-editor-dialog.c:
2726 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2727 and scrolling policy as per the Email Application Layout Guide, if I have
2730 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2732 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2733 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2734 which were empty, because these vfuncs have been removed from TnyAccountStore.
2735 This fixes the build.
2737 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2739 * src/maemo/modest-main-window.c:
2740 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2741 showing/hiding it. Added TODO because it probably should not be NULL.
2742 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2743 because unnecessary g_warnings() make degugging difficult.
2745 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2747 * src/maemo/modest-msg-edit-window.c:
2748 (modest_msg_edit_window_select_color),
2749 (modest_msg_edit_window_select_background_color): 2 const corrections and
2750 moving 2 #endifs before closing brackets, to fix the build.
2752 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2754 * src/maemo/easysetup/modest-easysetup-wizard.h:
2755 * src/maemo/easysetup/modest-easysetup-wizard.c:
2756 (modest_easysetup_wizard_dialog_finalize),
2757 (on_button_edit_advanced_settings), (create_page_complete_custom),
2758 (on_response), (create_account):
2759 Implement the Advanced Settings edit button, by saving the account information,
2760 for the Advanded Settings dialog to use directly from gconf, and removing it
2761 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2762 Bug #5533 in the projects.maemo.org bugzilla.
2764 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2766 * src/maemo/modest-msg-view-window.c:
2767 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2768 when opening a message window.
2770 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2772 * src/maemo/easysetup/modest-easysetup-wizard.c:
2773 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2776 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2777 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2778 gconf settings. I probably added more checks than necessary, but that is safer.
2780 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2781 variable to fix the build, but this seems to be used when it is still NULL.
2783 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2785 * src/modest-platform.h:
2786 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2787 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2788 * src/modest-main.c: Implement this function so we can avoid using
2789 maemo-specific API from cross-platform code.
2791 * src/modest-tny-account-store.c:
2792 (get_smtp_specific_transport_account_for_open_connection):
2793 * src/modest-ui-actions.c: (check_for_connection),
2794 (modest_ui_actions_on_item_not_found):
2795 Use modest_platform_connect_and_wait() and put #idefs around other
2796 maemo-specific code, because only maemo currently has a way to
2797 identify connection names.
2799 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2801 * src/modest-tny-account-store.h:
2802 * src/modest-tny-account-store.c:
2803 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2804 the connection-specific SMTP server settings in the configuration.
2806 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2808 * src/maemo/modest-main-window.c: (on_connection_changed),
2810 * src/modest-main.c: (main), (start_ui), (send_mail):
2811 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2812 that is what is intended.
2814 * src/modest-ui-actions.c: (action_send), (action_receive),
2815 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2816 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2817 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2818 SMTP server is used when it is specified.
2820 (modest_ui_actions_on_send_receive):
2821 Check that a connection is open before proceeding.
2822 Receive and then send, instead of vice-versa, as per the specification.
2824 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2826 * src/modest-mail-operation.c:
2827 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2828 though I guess it should be something other than NULL.
2830 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2832 * src/maemo/easysetup/modest-easysetup-wizard.c:
2833 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2834 combo twice, to avoid an g_warning and to make it visible again.
2835 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2836 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2837 (already intended) dereference when detaching, because we then recreate the menu.
2838 But I am not sure why the warning was happening, and it is possible that this is a memory
2841 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2843 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2844 and uri_parse_mailto() utility functions.
2845 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2847 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2849 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2851 * src/dbus_api/modest-dbus-api.h:
2852 * src/dbus_api/modest-dbus-callbacks.c:
2853 Use an idle callback to execute the modest code in the application's own thread.
2854 Remove the helloworld example method.
2855 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2856 parsed, and the open-message method is not implemented because this is not yet implemented in
2858 * libmodest-dbus-client/libmodest-dbus-client.c:
2859 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2860 (libmodest_dbus_client_open_message):
2861 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2863 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2864 body without crashing.
2866 * tests/dbus_api/Makefile.am:
2867 * tests/dbus_api/test_mail_to.c:
2868 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2870 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2872 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2873 Added file to fix the build. Sorry.
2875 * src/dbus_api/Makefile.am:
2876 * src/dbus_api/modest-dbus-api.h:
2877 * src/dbus_api/modest-dbus-callbacks.h:
2878 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2879 (modest_dbus_req_handler):
2880 Put constants in a separate header so it can be reused by the
2881 client library, without duplication
2883 * libmodest-dbus-client/Makefile.am:
2884 * libmodest-dbus-client/libmodest-dbus-client.c:
2885 (libmodest_dbus_client_call_helloworld),
2886 (libmodfest_dbus_client_send_mail),
2887 (libmodfest_dbus_client_mailto),
2888 (libmodfest_dbus_client_open_message):
2889 * libmodest-dbus-client/libmodest-dbus-client.h:
2890 (Partly) Implement a send_mail D-Bus method.
2892 * tests/dbus_api/Makefile.am:
2893 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2894 the send_email D-Bus method.
2896 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2900 * libmodest-dbus-client/Makefile.am:
2901 * libmodest-dbus-client/libmodest-dbus-client.c:
2902 * libmodest-dbus-client/libmodest-dbus-client.h:
2903 * tests/dbus_api/Makefile.am:
2904 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2905 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2907 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2909 * src/maemo/easysetup/modest-easysetup-wizard.c:
2910 (create_page_account_details):
2911 * src/maemo/modest-account-settings-dialog.c:
2912 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2913 widgets, because this might not be the default in future versions of the Maemo GTK+.
2914 However, I can not not get capitalization to work even in a simple test case.
2916 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2918 * src/maemo/easysetup/modest-easysetup-wizard.c:
2919 (create_page_custom_incoming), (create_page_custom_outgoing):
2920 * src/maemo/modest-account-settings-dialog.c:
2921 (create_page_account_details), (create_page_incoming),
2922 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2923 instead of using gtk_check_button_with_label(), so they are aligned like the other
2924 widgets, as per the UI spec.
2926 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2928 * src/maemo/easysetup/modest-easysetup-wizard.c:
2929 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2930 * src/widgets/modest-validating-entry.c:
2931 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2932 Modest prefix instead of an EasySetup prefix.
2934 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2936 * src/widgets/modest-validating-entry.h:
2937 * src/widgets/modest-validating-entry.c: (on_insert_text),
2938 Added easysetup_validating_entry_set_max_func(), used to set a callback
2939 to call when the max number of characters is reached. GtkEntry has a max-length
2940 already but is silent about it.
2942 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2943 (create_page_account_details), (create_page_user_details),
2945 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2946 (create_page_account_details), (create_page_user_details),
2947 (create_page_outgoing):
2948 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2949 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2950 the UI spec, when the user tries to enter more than the max number of characters.
2952 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2954 * src/maemo/easysetup/modest-easysetup-wizard.c:
2955 (create_page_user_details), (create_page_custom_incoming),
2956 (create_page_custom_outgoing):
2957 * src/maemo/modest-account-settings-dialog.c:
2958 (create_page_user_details), (create_page_incoming),
2959 (create_page_outgoing):
2960 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2961 (modest_connection_specific_smtp_edit_window_init):
2962 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2963 not appropriate. Bad Maemo-specific defaults!.
2965 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2968 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2969 (modest_signature_editor_dialog_set_settings):
2970 Disable the label and textview when the checkbox is disabled, and use the
2971 specified (UI spec) default signature text.
2973 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2975 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2976 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2978 * src/modest-defs.h:
2979 * src/modest-account-mgr-helpers.h:
2980 * src/modest-account-mgr-helpers.c:
2981 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2983 * src/maemo/Makefile.am:
2984 * src/maemo/modest-signature-editor-dialog.c:
2985 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2988 * src/maemo/modest-account-settings-dialog.h:
2989 * src/maemo/modest-account-settings-dialog.c:
2990 (modest_account_settings_dialog_finalize), (on_button_signature),
2991 (save_configuration): Use the new dialog when the Edit button is pressed, and
2992 save the changes if necessary, as per the UI spec.
2994 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2996 * src/maemo/Makefile.am:
2997 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2998 based on maemo-develoers email from Dirk.
3000 * src/maemo/easysetup/modest-easysetup-wizard.c:
3001 (create_page_welcome), (create_page_account_details),
3002 (create_page_user_details), (create_page_complete_easysetup),
3003 (create_page_custom_incoming), (create_page_custom_outgoing),
3004 (create_page_complete_custom),
3005 (modest_easysetup_wizard_dialog_init):
3006 * src/maemo/modest-account-settings-dialog.c:
3007 (create_page_account_details), (create_page_user_details),
3008 (create_page_incoming), (create_page_outgoing),
3009 (modest_account_settings_dialog_init):
3010 * src/maemo/modest-connection-specific-smtp-window.c:
3011 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3013 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3015 * src/maemo/easysetup/modest-easysetup-wizard.c:
3016 (create_page_account_details), (create_page_custom_outgoing),
3017 (create_page_complete_custom):
3018 * src/maemo/modest-account-settings-dialog.c:
3019 (create_page_user_details), (create_page_incoming),
3020 (create_page_outgoing):
3021 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3022 (modest_connection_specific_smtp_edit_window_init):
3023 Use the correct (UI spec) port min/max, and use horizontal separators,
3026 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3028 * src/maemo/easysetup/modest-easysetup-wizard.c:
3029 (set_default_custom_servernames):
3030 * src/maemo/modest-account-settings-dialog.c:
3031 (create_page_incoming), (on_combo_outgoing_security_changed),
3032 (on_combo_incoming_security_changed), (create_page_outgoing),
3033 (modest_account_settings_dialog_set_account_name),
3034 (save_configuration):
3035 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3036 (on_combo_security_changed),
3037 (modest_connection_specific_smtp_edit_window_init),
3038 (modest_connection_specific_smtp_edit_window_set_connection),
3039 (modest_connection_specific_smtp_edit_window_get_settings):
3040 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3043 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3046 * src/maemo/easysetup/modest-easysetup-wizard.c:
3047 (create_page_custom_outgoing), (create_page_complete_custom):
3048 * src/maemo/modest-account-settings-dialog.c:
3049 (create_page_user_details), (create_page_outgoing):
3050 * src/maemo/modest-account-view-window.c: (button_box_new):
3051 Use changed logical IDs as per the most recent UI spec:
3052 mcen_bd_emailsetup_edit -> mcen_bd_edit
3053 mcen_bd_emailsetup_delete -> mcen_bd_delete
3054 mcen_bd_emailsetup_close -> mcen_bd_close
3056 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3060 * src/dbus_api/Makefile.am:
3061 * src/dbus_api/modest-dbus-callbacks.c:
3062 * src/dbus_api/modest-dbus-callbacks.h:
3063 * src/maemo/modest-platform.c: (modest_platform_init):
3064 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3066 * tests/Makefile.am:
3067 * tests/dbus_api/Makefile.am:
3068 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3070 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3072 * src/maemo/modest-account-settings-dialog.c:
3073 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3074 Removed unnecessary includes.
3076 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3078 * src/maemo/easysetup/modest-easysetup-wizard.c:
3079 * src/maemo/modest-account-settings-dialog.c:
3080 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3081 * src/widgets/Makefile.am:
3082 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3083 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3084 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3085 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3086 * src/widgets/modest-secureauth-combo-box.c:
3087 * src/widgets/modest-secureauth-combo-box.h:
3088 * src/widgets/modest-serversecurity-combo-box.c:
3089 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3090 made the GObject names more consistent with the rest of the Modest code.
3092 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3094 * src/maemo/easysetup/Makefile.am:
3095 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3096 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3097 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3098 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3099 * src/maemo/easysetup/modest-easysetup-wizard.c:
3100 * src/maemo/easysetup/modest-validating-entry.c:
3101 * src/maemo/easysetup/modest-validating-entry.h:
3102 * src/maemo/modest-account-settings-dialog.c:
3103 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3104 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3105 widgets/ because they are used outside of easysetup too. After checking in,
3106 svn will allow me to rename them too.
3108 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3110 * src/gnome/modest-msg-edit-window.c:
3111 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3112 linker error, to fix the build on the GNOME platform.
3113 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3114 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3115 ifdefed out to avoid a warning.
3117 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3119 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3120 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3121 some alternative for GTK+ 2.6.
3123 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3125 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3127 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3128 specified for EmailAccountsDialog in UI spec.
3130 * src/maemo/easysetup/modest-easysetup-wizard.c:
3131 * src/maemo/easysetup/modest-easysetup-wizard.h:
3132 * src/maemo/modest-account-settings-dialog.c:
3133 * src/maemo/modest-account-settings-dialog.h:
3134 Reuse a member window widget for the connection-specific SMTP server accounts,
3135 so we can tell it to create/save the accounts only if we actually save changes.
3137 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3138 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3139 (modest_connection_specific_smtp_edit_window_get_settings):
3140 Return a struct instance for temporarily remembering the entered data.
3142 * src/maemo/modest-connection-specific-smtp-window.h:
3143 * src/maemo/modest-connection-specific-smtp-window.c:
3144 (modest_connection_specific_smtp_window_finalize),
3145 (modest_connection_specific_smtp_window_fill_with_connections),
3147 (modest_connection_specific_smtp_window_save_server_accounts),
3148 (update_model_server_names): Do not actually save data until asked,
3149 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3151 (on_selection_changed),
3152 (modest_connection_specific_smtp_window_init): Disable the edit
3153 button when nothing is selected.
3155 * src/modest-account-mgr-helpers.c:
3156 * src/modest-account-mgr-helpers.h:
3157 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3160 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3162 * src/modest-account-mgr-helpers.h:
3163 * src/modest-account-mgr-helpers.c:
3164 (modest_account_mgr_get_unused_account_name),
3165 (modest_account_mgr_get_unused_account_display_name): Added these
3166 utility functions, to avoid code duplication.
3168 * src/maemo/easysetup/modest-easysetup-wizard.c:
3169 (create_page_account_details), (create_account):
3170 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3171 (on_combo_security_changed),
3172 (modest_connection_specific_smtp_edit_window_init),
3173 (modest_connection_specific_smtp_edit_window_save_settings):
3174 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3175 * src/maemo/modest-connection-specific-smtp-window.c:
3176 (modest_connection_specific_smtp_window_finalize),
3177 (modest_connection_specific_smtp_window_fill_with_connections),
3178 (on_button_edit), (modest_connection_specific_smtp_window_init):
3179 * src/maemo/modest-connection-specific-smtp-window.h:
3180 Implementing saving of connection-specific server accounts.
3182 But I need to refactor this so we can save the data for each
3183 possible connection-specific account and only actually create the server accounts
3184 when the easysetup finished, or the OK button is pressed on the account settings
3187 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3189 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3190 (on_combo_security_changed):
3191 (modest_connection_specific_smtp_edit_window_init):
3192 Auto-fill the port number as in the account settings.
3194 (modest_connection_specific_smtp_edit_window_set_connection):
3195 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3196 * src/maemo/modest-connection-specific-smtp-window.c:
3197 (fill_with_connections), (on_button_edit),
3198 (modest_connection_specific_smtp_window_init):
3199 Turn the edit window into a dialog to simplify the code, and
3200 set a WM hint as in a GtkDialog, because only a popup can be on top of
3201 another window in Maemo, and popups usually have no WM decoration.
3203 * src/modest-defs.h:
3204 * src/modest-account-mgr-helpers.c:
3205 (modest_account_mgr_set_connection_specific_smtp),
3206 (modest_account_mgr_remove_connection_specific_smtp),
3207 (modest_account_mgr_get_connection_specific_smtp):
3208 * src/modest-account-mgr-helpers.h: Some functions to write the
3209 connection-specific SMTP server information. Not yet used.
3212 * src/widgets/modest-folder-view.c: (text_cell_data):
3213 Fix a warning about an uninitialized variable.
3214 (on_configuration_key_changed): Put an #ifdef around the use
3215 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3217 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3219 * src/maemo/modest-account-settings-dialog.h:
3220 * src/maemo/modest-account-settings-dialog.c:
3221 Added connect_for_modified() utility function to mark the new modified boolean.
3223 (create_page_account_details), (create_page_user_details),
3224 (create_page_incoming), (create_page_outgoing), (on_response),
3225 (modest_account_settings_dialog_init),
3226 (modest_account_settings_dialog_set_account_name):
3227 Only warn about unsaved changes when there are actually unsaved changes.
3229 * src/modest-account-mgr-helpers.c:
3230 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3231 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3232 to get the data from there in future.
3234 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3236 * src/modest-defs.h:
3238 * src/modest-account-mgr-helpers.h:
3239 * src/modest-account-mgr-helpers.c:
3240 Store the security account setting in a single conf key instead of using
3241 the options list, so that the list is left for just the to-be-removed camel hack,
3242 and because gconf_client_set_list() is failing for some reason.
3244 * src/modest-account-mgr.c:
3245 (modest_account_mgr_add_server_account):
3246 * src/maemo/modest-account-settings-dialog.c:
3247 (modest_account_settings_dialog_set_account_name),
3248 (save_configuration): Use the renamed functions.
3251 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3253 * src/widgets/Makefile.am:
3254 * src/widgets/modest-limit-retrieve-combo-box.c:
3255 * src/widgets/modest-limit-retrieve-combo-box.h:
3256 * src/widgets/modest-retrieve-combo-box.c:
3257 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3258 the account settings dialog.
3260 * src/modest-defs.h:
3261 * src/modest-account-mgr-helpers.h:
3262 * src/modest-account-mgr-helpers.c:
3263 (modest_server_account_get_option_secure_auth),
3264 (modest_server_account_set_option_secure_auth):
3265 * src/modest-account-mgr.c:
3266 (modest_account_mgr_add_server_account):
3267 Use the existing AUTH_MECH conf key for the secure-auth setting,
3268 instead of putting it in the list options, because this was actually used already.
3270 * src/maemo/modest-account-settings-dialog.c:
3271 (create_page_account_details),
3272 (modest_account_settings_dialog_set_account_name),
3273 (save_configuration):
3274 * src/maemo/modest-account-settings-dialog.h:
3275 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3276 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3278 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3280 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3281 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3282 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3284 * src/modest-defs.h:
3285 * src/maemo/modest-account-settings-dialog.c:
3286 (create_page_incoming), (on_combo_outgoing_security_changed),
3287 (on_combo_incoming_security_changed), (create_page_outgoing),
3288 (modest_account_settings_dialog_set_account_name),
3289 (save_configuration): Load/Save the port number, and change it when the
3290 security combo changes, to suitable defaults.
3292 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3294 * src/modest-account-mgr.c:
3295 (modest_account_mgr_add_server_account): Set the security and secure-auth
3296 options, and add a comment saying that the other camel-specific options should be
3299 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3301 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3303 * src/modest-tny-account-store.c: (account_list_free),
3304 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3305 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3308 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3310 * src/modest-protocol-info.c:
3311 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3312 is required by our UI spec. Maybe something in our implementation will use this eventually.
3313 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3314 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3315 instead of the previous 0 placeholder.
3317 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3318 secure-auth settings.
3319 * src/modest-account-mgr-helpers.h:
3320 * src/modest-account-mgr-helpers.c:
3321 (modest_server_account_data_get_option_secure_auth),
3322 (modest_server_account_set_option_secure_auth),
3323 (modest_server_account_data_get_option_security),
3324 (modest_server_account_set_option_security): Added this API for getting and setting the security
3325 and secure-auth settings.
3327 * src/maemo/modest-account-settings-dialog.h:
3328 * src/maemo/modest-account-settings-dialog.c:
3329 (modest_account_settings_dialog_finalize), (check_data),
3330 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3331 about changing titles.
3332 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3333 (save_configuration): Save the security and secure-auth settings.
3335 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3336 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3338 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3340 * src/modest-defs.h:
3341 * src/modest-account-mgr.c:
3342 (modest_account_mgr_add_server_account):
3343 Added and used defines for the options key and value pair strings,
3344 that are used so far, though they do not seem to correspond to anything in our
3345 UI specs or ModestProtocol enum.
3347 * src/modest-account-mgr-helpers.h:
3348 * src/modest-account-mgr-helpers.c:
3349 (compare_option_strings_for_name),
3350 (modest_server_account_data_get_option_value),
3351 (modest_server_account_data_get_option_bool),
3352 (modest_account_mgr_get_server_account_option):
3353 Added helper functions for parsing the options GSList.
3355 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3357 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3358 display name is based on the supplied account name.
3359 * src/modest-account-mgr.c:
3360 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3361 with an inefficient, but good-enough, implementation.
3363 * src/maemo/easysetup/modest-easysetup-wizard.c:
3364 (create_page_account_details), (on_before_next), (create_account):
3365 Check for existing display names rather than (non-user-visible) account names, and just
3366 create and set a unique account name at the end.
3368 * src/maemo/modest-account-settings-dialog.c:
3369 (modest_account_settings_dialog_init),
3370 (modest_account_settings_dialog_set_account_name),
3371 (create_page_incoming): Show the display name, instead of the account name.
3372 (on_response): Do some (not all) extra checks, as in the UI spec.
3373 (save_configuration): Save the display name if it was changed.
3375 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3377 * po/en_GB.po: Added needed logical ID and translation.
3378 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3379 (init_view): Made the is-default column clicking work.
3381 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3384 * src/maemo/easysetup/Makefile.am:
3385 * src/maemo/easysetup/modest-easysetup-wizard.c:
3386 (modest_easysetup_wizard_dialog_init):
3387 * src/maemo/easysetup/provider-data-test.keyfile:
3388 * src/maemo/easysetup/provider-data.keyfile:
3389 Moved the provider data file to the new modest-providers-data package and used it from there.
3391 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3393 * src/modest-local-folder-info.c:
3394 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3395 N_() was already used on the static strings, but this just marks it for translation without
3396 using the translation.
3398 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3400 * src/maemo/modest-account-settings-dialog.c:
3401 (create_page_incoming),
3402 (modest_account_settings_dialog_set_account_name):
3403 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3404 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3405 I will do this if nobody else gets there first.
3407 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3409 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3410 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3411 save the security stuff.
3413 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3415 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3416 Set the email address and user fullname, which I now see must be
3419 * src/maemo/modest-account-settings-dialog.h:
3420 * src/maemo/modest-account-settings-dialog.c:
3422 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3423 leave-on-server and authentication.
3424 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3427 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3430 * src/maemo/modest-account-settings-dialog.c:
3431 * src/maemo/modest-account-settings-dialog.h:
3432 Most (but not all) of the widgets are now present as specified by the UI spec.
3433 No changes are yet saved, and some details are not properly shown yet.
3435 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3437 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3439 * src/maemo/Makefile.am:
3440 * src/maemo/modest-account-settings-dialog.c:
3441 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3442 an existing account. Doesn't do much yet.
3444 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3445 Open the accounts settings dialog when Edit is clicked.
3447 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3449 * src/maemo/easysetup/Makefile.am:
3450 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3452 * src/maemo/easysetup/modest-easysetup-wizard.c:
3453 (modest_easysetup_wizard_dialog_init):
3454 Try to get the source directory from the build system,
3455 instead of hard-coding "./" into the source code, when opening our local
3456 copies of the configuration files.
3457 But this still fails when opening the wizard from the Accounts window,
3458 maybe because the working directory seems to change at runtime.
3459 So the wizard will fail the second time unless you copy the files into their
3460 proper locations - see the stdout warnings for the paths.
3462 (create_page_account_details),(on_before_next):
3463 Check for existing non-server accounts instead of server accounts,
3464 so the default account name is useful again, and to prevent trying to
3467 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3468 Show the wizard when New is clicked.
3470 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3471 (init_view): Show the column headers, and show the columns that are
3472 specified in the UI specs. However, something in Maemo's GTK+ prevents
3473 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3474 change the default account. This is despite unsetting the special properties.
3476 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3478 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3479 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3480 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3481 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3482 to make that clearer.
3483 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3485 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3487 * src/maemo/modest-account-view-window.c:
3488 (modest_account_view_window_init),
3489 (modest_account_view_window_new):
3490 Use the same buttons as specified in the
3491 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3492 the existing widgets, which never had a chance of working.
3493 Put the ModestAccountView treeview in a scrolled window.
3494 Do not repeat the initialization in both _init() and _new().
3496 * src/widgets/modest-account-view.c: (update_account_view):
3497 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3498 this widget and window shows no accounts.
3500 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3502 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3504 * src/maemo/easysetup/modest-easysetup-wizard.c:
3505 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3506 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3507 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3510 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3511 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3512 accounts exist yet, as in the UI spec.
3514 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3516 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3518 * src/maemo/Makefile.am:
3519 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3520 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3521 New window for editing connection-specific smtp details.
3522 Not fully implemented.
3524 * src/maemo/modest-connection-specific-smtp-window.c:
3525 (modest_connection_specific_smtp_window_finalize) :
3526 unref the tree model.
3527 (on_button_edit): Show the edit window.
3529 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3531 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3534 * src/maemo/Makefile.am:
3535 * src/maemo/modest-connection-specific-smtp-window.c:
3536 * src/maemo/modest-connection-specific-smtp-window.h:
3537 New window for showing the list of connections, for connection-specific
3538 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3539 * src/maemo/easysetup/modest-easysetup-wizard.c:
3540 (create_page_custom_outgoing): Show the new window when the button is clicked.
3542 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3544 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3545 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3546 * src/maemo/modest-msg-edit-window.c:
3547 (modest_msg_edit_window_insert_image):
3548 * src/modest-conf.c: (modest_conf_key_escape):
3549 * src/modest-mail-operation.c:
3550 (modest_mail_operation_send_new_mail):
3551 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3552 (modest_ui_actions_on_new_account):
3553 * src/widgets/modest-attachment-view.c: (update_filename_request):
3554 * src/widgets/modest-mail-header-view.c:
3555 Corrected warnings that were breaking the build, by commenting out unused variables,
3556 and a function, and by including a header.
3558 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3560 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3561 so we can #ifdef around platform-specific code when necessary.
3562 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3563 to allow this to build for the GNOME platform too.
3565 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3567 * src/maemo/easysetup/modest-easysetup-wizard.c:
3568 Added util_increment_name() and used it in create_page_account_details()
3569 to make sure that the default account name is always a new name.
3571 (modest_easysetup_wizard_dialog_init),
3572 (set_default_custom_servernames): Some minor memory management fixes.
3574 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3578 * src/modest-runtime.c: (init_i18n): Restored the translation
3579 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3580 are defined in config.h, and the translations are installed.
3582 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3583 is defined for translation.
3585 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3587 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3589 * src/maemo/easysetup/modest-easysetup-wizard.c:
3590 (modest_easysetup_wizard_dialog_init):
3591 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3592 Use realistic paths (though they should use $prefix generically) to the
3593 mcc_mapping and provider-data.keyfile files which might work when they
3594 are installed by the future version of the operator-wizard package,
3595 and then fallback to paths in our source code, with an explanatory
3598 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3602 * src/maemo/Makefile.am:
3603 * src/maemo/easysetup/: Added files from the previously-exernal
3604 osso-modest-easysetup.
3605 * src/maemo/modest-main-window-ui.h:
3606 * src/modest-ui-actions.c:
3607 * src/modest-ui-actions.h:
3608 Added modest_ui_actions_on_new_account() as a signal handler for the
3609 New Account menu item. It shows the easysetup wizard.
3610 * po/en_GB.po: Added additional needed logical IDs and translations.