1 2007-05-31 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-hbox-cell-renderer.c:
4 (modest_hbox_cell_renderer_append):
5 * src/widgets/modest-vbox-cell-renderer.c:
6 (modest_vbox_cell_renderer_append):
7 Fix the last commit by doing an extra ref.
9 2007-05-31 Murray Cumming <murrayc@murrayc.com>
11 * src/widgets/modest-hbox-cell-renderer.c:
12 (modest_hbox_cell_renderer_append):
13 * src/widgets/modest-vbox-cell-renderer.c:
14 (modest_vbox_cell_renderer_append):
15 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
16 to fix the build with Maemo Bora.
17 However, there seems to be a remaining crash, probably due to reference
20 2007-05-30 Murray Cumming <murrayc@murrayc.com>
22 * src/modest-tny-account.c:
23 (modest_tny_account_new_for_local_folders):
24 Use hildon_file_system_info_async_new() to get a better name for
25 the memory card account, setting it as the account name.
26 The timing seems to work, but this is probably
27 not the best place to do this. See the TODO comment.
28 * src/maemo/modest-main-window.c: (create_details_widget):
29 * src/widgets/modest-folder-view.c: (text_cell_data):
30 Use the tny account name instead of hardcoding a name.
32 2007-05-30 Christian Kellner <ckellner@openismus.com>
34 * src/modest-search.c: (modest_search):
35 Correctly set part_search_func even if we have already parsed
36 the query and thus a valid OgsTextSearcher object.
38 2007-05-30 Christian Kellner <ckellner@openismus.com>
41 Search and check for libogs.
44 Incooparte the ogs build env.
46 * src/modest-mime-part-search-stream.c:
47 * src/modest-mime-part-search-stream.h:
48 Removed since we do the real searching now in modest-search.c.
50 * src/modest-search.c:
51 * src/modest-search.h:
52 Implement support for ogs. We use that if available and requested
53 and fall back to modest_text_utils_utf8_strcmp (). The search logic
54 should now handle the corner case when the search term is spread
55 across multiple reads.
56 Also the logic in modest_search () was corrected to search all
57 requested fields until one is found.
59 2007-05-30 Murray Cumming <murrayc@murrayc.com>
61 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
64 * src/modest-init.c: Made modest_init_local_folders() take a
65 path and be public so we can iniitialize maildir folders on
68 * src/modest-local-folder-info.h:
69 * src/modest-local-folder-info.c:
70 (modest_local_folder_info_get_maildir_path): Add a path parameter.
72 * src/modest-tny-account.c:
73 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
74 still means the standard local-folders path on the local volume.
76 * src/modest-tny-account-store.c:
77 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
78 signal so we can detect mount/unmount of the MMC1 card, and do an update of
79 all accounts when that happens.
80 (get_server_accounts): If the MMC1 card is mounted, create a store account for
81 this too, so it shows up in the treeview.
83 2007-05-28 Murray Cumming <murrayc@murrayc.com>
85 * src/maemo/modest-maemo-global-settings-dialog.c:
87 * src/widgets/modest-global-settings-dialog.c:
88 (current_connection_default):
89 Use the enum values instead of 0, 1 and -1,
90 to make the code clearer.
92 * src/modest-account-mgr-helpers.c:
93 (modest_account_mgr_get_connection_specific_smtp): Make this code
96 * src/modest-runtime.h:
97 * src/modest-runtime.c:
98 Added modest_runtime_remove_all_send_queues().
99 * src/maemo/modest-main-window.c:
100 (on_account_store_connecting_finished): Recreate the send queues,
101 using the appropriate transport accounts for this new connection.
102 Some futher adapting might be needed if the old send queues are not
103 automatically stopped at this point.
105 * src/modest-tny-account-store.c: (get_server_accounts):
106 Create the connection-specific transport accounts, so that they can
107 be found later by their ID.
109 * src/modest-tny-account.h:
110 * src/modest-tny-account.c:
111 Added modest_tny_account_new_from_server_account_name().
112 modest_tny_account_new_from_server_account(): Do not create the
113 send queues here, because they will be
114 recreated anyway when the connection changes for the first time.
116 2007-05-28 Murray Cumming <murrayc@murrayc.com>
118 * src/modest-local-folder-info.h:
119 * src/modest-local-folder-info.c:
120 (modest_per_account_local_outbox_folder_info_get_maildir_path),
121 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
122 tbox_folder): Take a modest account name instead of a server TnyAccount,
123 so we can have per-modest-account rather than per-transport-account
125 We must make sure that we change or recreate the exisitng send queues
126 when the connection changes for connection-specific transport accounts.
128 * src/modest-tny-account-store.c:
129 (create_per_account_local_outbox_folders): Create outboxed per modest
130 account, not per transport account.
132 * src/modest-tny-account.h:
133 * src/modest-tny-account.c:
134 (modest_tny_account_get_special_folder): For outboxes, get the
135 parent modest account name. The account is ignored for other folders.
136 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
137 modest account name rather than a server TnyAccount.
139 2007-05-25 Murray Cumming <murrayc@murrayc.com>
141 * src/modest-tny-account.c:
142 (modest_tny_account_new_from_server_account):
143 Call modest_runtime_get_send_queue() immediately after creating transport
144 accounts, so that they start trying to send email from the outbox as soon
145 as possible at startup. This is probably what we want.
147 * src/modest-mail-operation.c: (update_account_thread):
148 * src/modest-runtime.c: (modest_runtime_get_send_queue):
149 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
150 * src/modest-tny-send-queue.h:
151 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
152 (modest_ui_actions_on_send):
153 Added comments about how sending works, though it needs some more work.
155 2007-05-25 Murray Cumming <murrayc@murrayc.com>
157 * src/modest-tny-account.c:
158 (modest_tny_account_get_special_folder): Add TODO because this fails when
160 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
161 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
162 Do not try to show this window when there is no active account. The UI
163 specs does not tell us what to do in this case.
165 2007-05-24 Murray Cumming <murrayc@murrayc.com>
169 * src/maemo/Makefile.am:
170 * src/widgets/Makefile.am: Some dist fixes.
172 2007-05-24 Murray Cumming <murrayc@murrayc.com>
174 * src/maemo/modest-connection-specific-smtp-window.c:
175 (on_button_edit): Make the code clearer, to prevent a double free.
177 2007-05-24 Murray Cumming <murrayc@murrayc.com>
179 * src/maemo/modest-account-settings-dialog.c:
180 (modest_account_settings_dialog_set_account_name),
181 Check the connection-specific smtp servers checkbox if there are any.
183 * src/maemo/modest-connection-specific-smtp-edit-window.c:
184 (modest_connection_specific_smtp_edit_window_init):
185 Start with a suitable port number.
187 * src/modest-account-mgr-helpers.h:
188 * src/modest-account-mgr-helpers.c: Added
189 modest_account_mgr_get_has_connection_specific_smtp().
191 (modest_account_mgr_set_connection_specific_smtp),
192 (modest_account_mgr_remove_connection_specific_smtp),
193 (modest_account_mgr_get_has_connection_specific_smtp),
194 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
195 connection-specific smtp server accounts in the account, rather than
196 the server account conf dir.
198 This fixes bug projects.maemo.org bug NB#58263 .
200 * src/modest-tny-account-store.c:
201 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
202 if there are no server accounts yet, to prevent an infinite loop when there
203 are no accounts. Document that one must be called before the other.
205 2007-05-24 Murray Cumming <murrayc@murrayc.com>
207 * src/modest-account-mgr-helpers.c:
208 (modest_account_mgr_get_default_account): Make sure that at least
209 one account is always the default, if there are any enabled accounts.
210 This is just a sanity check that shouldn't be necessary.
212 * src/modest-account-mgr-priv.c:
213 (_modest_account_mgr_account_from_key): Unescape the conf key to
214 get the real account name. For instance, this is an issue if a space
215 was in the account name, which can happen because the account name
216 is generated from the display name.
217 (_modest_account_mgr_get_account_keyname): Always escape the
219 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
220 Unescape the conf keys to get the real account names.
222 For instance, previously the is-default radio button in the accounts
223 list was not checked for any accounts at first. This fixes that,
224 and might fix several similar bugs.
226 2007-05-23 Murray Cumming <murrayc@murrayc.com>
228 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
229 Removed some debug printfs.
231 2007-05-23 Murray Cumming <murrayc@murrayc.com>
233 Modest on-disk outbox directories are now here, for instance:
234 $HOME/.modest/outboxes/<account-id-1>/outbox
235 $HOME/.modest/outboxes/<account-id-2>/outbox
237 $HOME/.modest/local-folders/outbox
238 so we can have a separate outbox for each account.
239 But they are shown as one outbox in the GtkTreeView, by using a
240 TnyMergeFolder in a ModestTnySimpleFolderStore.
243 * src/modest-tny-simple-folder-store.c:
244 * src/modest-tny-simple-folder-store.h:
245 Added ModestTnySimpleFolderStore, used to contain folders from
246 other folder stores, such as other accounts.
248 * src/modest-tny-outbox-account.h:
249 * src/modest-tny-outbox-account.c:
250 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
251 used for the per-account local outbox folders.
253 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
254 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
255 only use this (internally) now for the non-outbox local folders.
258 * src/modest-init.c: Added modest_init_one_local_folder(), for
259 setting up the directory structure for each local folder.
261 * src/modest-local-folder-info.c:
262 (modest_per_account_local_outbox_folder_info_get_maildir_path),
263 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
265 * src/modest-local-folder-info.h:
266 * src/modest-tny-account-store.c: (on_account_removed),
267 (on_account_changed), (create_per_account_local_outbox_folders),
268 (get_server_accounts), (modest_tny_account_store_get_accounts),
269 (modest_tny_account_store_get_tny_account_by_account),
270 (modest_tny_folder_store_is_virtual_local_folders):
272 * src/modest-tny-account.h:
273 * src/modest-tny-account.c:
274 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
275 to create an on-disk per-account local outbox folder for each
277 (create_per_account_local_outbox_folders): Create a local outbox folder
278 for each transport account.
279 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
280 for all local folders.
282 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
283 instead of using g_object_get/set() directly. It is clearer.
285 (modest_tny_folder_store_get_message_count),
286 (modest_tny_folder_store_get_local_size
287 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
288 because we now use these with non-acount folder stores.
290 (modest_tny_account_get_special_folder),
291 (modest_tny_account_new_from_server_account),
292 (modest_tny_account_new_from_account):
293 (recurse_folders): Adjust to the new outbox system.
295 * src/modest-tny-folder.h:
296 * src/modest-tny-folder.c:
297 (modest_tny_folder_is_local_folder),
298 (modest_tny_folder_get_local_folder_type),
299 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
301 * src/widgets/modest-main-window.h:
302 * src/maemo/modest-main-window.c: (create_details_widget),
303 (modest_main_window_set_contents_style): Show details for any folder store,
306 (modest_tny_folder_get_rules):
307 Remove the const. C does not support constness enough for this.
309 * src/modest-ui-actions.c:
310 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
311 make all outboxes appear as one, in the usual local-folders tree node.
313 (set_active_account_from_tny_account),
314 (modest_ui_actions_on_folder_selection_changed):
315 * src/widgets/modest-folder-view.c: (text_cell_data),
316 (icon_cell_data), (filter_row),
317 (add_account_folders_to_merged_folder),
318 (add_account_folders_to_simple_folder_store), (),
319 (get_cmp_rows_type_pos), (cmp_rows),
320 (modest_folder_view_set_account_id_of_visible_server_account):
321 Adjust to the new outbox system, using generic folder stores and folders
324 2007-05-23 Christian Kellner <ckellner@openismus.com>
326 * src/modest-mail-operation.c:
327 (modest_mail_operation_update_account):
328 Use info->max_size instead of unintialized local var [small
329 build fix]. (Added TODO to review that change since I don't
332 2007-05-23 Marcus Bauer <marcusb@openismus.com>
334 * libmodest-dbus-client/libmodest-dbus-client.c:
335 (libmodest_dbus_client_compose_mail): function added
336 * src/dbus_api/modest-dbus-api.h:
337 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
338 (on_compose_mail): Implementation of the SendAsMail functionality
340 2007-05-22 Murray Cumming <murrayc@murrayc.com>
342 * src/modest-account-mgr.c:
343 (modest_account_mgr_add_server_account): Set the secure-connection
344 conf key for transport accounts as well as store accounts. I don't know
345 why the if was there. For instance, this makes sure that we use SSL
346 for the gmail preset from the easysetup wizard.
348 2007-05-22 Murray Cumming <murrayc@murrayc.com>
350 * src/gnome/modest-main-window.c:
351 (on_account_store_connecting_finished), (connect_signals):
352 * src/maemo/modest-main-window.c:
353 (on_account_store_connecting_finished), (connect_signals),
354 (modest_main_window_new):
355 Handle TnyAccountStore::connecting-finished instead of
356 TnyDevice::connection-changed, because we cannot actually perform
357 operations on accounts until TnyAccountStore has itself responded to
358 the TnyDevice::connection-changed signal. This prevents a GError from
360 Do not try to update at startup, because we (at least on scratchbox)
361 already do an update at startup when the device goes online.
362 This prevents a GError from tinymail.
363 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
364 Added TODO about stopping simultaneous operations.
366 2007-05-21 Murray Cumming <murrayc@murrayc.com>
368 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
369 * src/modest-mail-operation-queue.c:
370 (modest_mail_operation_queue_remove):
371 * src/modest-tny-account-store.c: When GErrors happen, give more clues
372 about where they happened.
374 2007-05-21 Murray Cumming <murrayc@murrayc.com>
376 * src/modest-ui-actions.c:
377 (modest_ui_actions_on_password_requested): Make sure that the remember
378 output parameter is always TRUE.
380 2007-05-21 Murray Cumming <murrayc@murrayc.com>
382 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
383 Show a OK/Cancel dialog if the error is a question, though we still do not
384 know anything more about what we are asking the user.
385 * src/widgets/modest-folder-view.c: (on_drag_data_received):
386 Fix an uninitialized variable (helper). This is a logic error, however.
388 2007-05-21 Christian Kellner <ckellner@openismus.com>
390 * src/modest-search.h:
391 Correct bit shifting in the ModestSearchFlags enum.
393 2007-05-21 Murray Cumming <murrayc@murrayc.com>
395 * src/modest-tny-account.c:
396 (modest_tny_account_new_from_server_account): Do not use the lsub and
397 check-all hard-coded IMAP options when using POP.
399 2007-05-21 Murray Cumming <murrayc@murrayc.com>
401 * src/modest-tny-account.c:
402 (modest_tny_account_new_from_server_account):
403 Use NULL for the secure-auth method for POP when Password auth has been
404 specified by the user, as we already do for IMAP. "auth=Login" causes
405 an error from camel or the server.
407 2007-05-17 Murray Cumming <murrayc@murrayc.com>
409 * src/maemo/modest-account-settings-dialog.c:
410 (create_page_account_details),
411 (modest_account_settings_dialog_set_account_name):
412 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
413 for the leave-on-server checkbox, rathr than just the checkbox, when
414 the protocol is not POP.
416 2007-05-17 Murray Cumming <murrayc@murrayc.com>
418 * src/widgets/modest-account-view.c:
419 * src/widgets/modest-account-view.h:
420 Added modest_account_view_select_account() which will be useful later
421 to asynchronously re-select the edited account.
423 2007-05-17 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/modest-account-settings-dialog.c:
426 (modest_account_settings_dialog_set_account_name):
427 Automatically choose the port numbers based on the secure authentication
428 methods, if they have not been chosen before.
429 This fixes projects.maemo.org bug NB#56273 .
431 2007-05-17 Murray Cumming <murrayc@murrayc.com>
433 * src/maemo/modest-main-window-ui.h:
434 * src/modest-ui-actions.c:
435 * src/modest-ui-actions.h:
436 Connect the Tools/SMTP Servers menu item to
437 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
438 SMTP servers dialog, as in the UI specification and saves changes when it
439 is closed. This fixed projects.maemo.org bug NB#56305 .
441 2007-05-17 Murray Cumming <murrayc@murrayc.com>
443 * src/maemo/modest-connection-specific-smtp-window.c:
444 (modest_connection_specific_smtp_window_init):
445 Use gtk_window_set_default_size() to make this window big enough, so
446 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
448 2007-05-17 Murray Cumming <murrayc@murrayc.com>
450 * src/maemo/modest-connection-specific-smtp-edit-window.h:
451 * src/maemo/modest-connection-specific-smtp-edit-window.c:
452 (modest_connection_specific_smtp_edit_window_init),
453 Do not try to connect to a combobox signal before the combobox exists.
454 This fixes the cras in projects.maemo.org bug NB#56288 .
455 (modest_connection_specific_smtp_edit_window_get_settings):
456 Remove the server_account_name parameter which was being checked for NULL
457 though it was not used.
459 * src/maemo/modest-connection-specific-smtp-window.c:
460 (modest_connection_specific_smtp_window_fill_with_connections),
461 (on_button_edit), (modest_connection_specific_smtp_window_init):
462 Correct the number of treemodel columns to prevent a warning.
463 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
464 libconic does not work.
466 2007-05-16 Murray Cumming <murrayc@murrayc.com>
468 * src/modest-tny-account.c:
469 (modest_tny_account_new_from_server_account):
470 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
471 SMTP when "None" was chosen by the user. However, with my SMTP server that
472 does not support ANONYMOUS, the emails do not leave the Outbox and I see
475 2007-05-16 Murray Cumming <murrayc@murrayc.com>
477 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
478 to explain the memory management issue with the ID in the ModestPair.
480 * src/gnome/modest-account-assistant.c: (add_receiving_page),
481 (add_sending_page), (modest_account_assistant_finalize):
482 * src/gnome/modest-gnome-global-settings-dialog.c:
483 (create_updating_page), (create_composing_page):
484 * src/gnome/modest-msg-edit-window.c: (get_transports),
485 (init_window), (modest_msg_edit_window_finalize),
486 (modest_msg_edit_window_get_msg_data):
487 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
488 * src/gnome/modest-transport-widget.c:
489 (modest_transport_widget_finalize), (smtp_configuration):
490 * src/maemo/modest-maemo-global-settings-dialog.c:
491 (create_updating_page), (create_composing_page):
492 * src/maemo/modest-msg-edit-window.c: (get_transports),
493 (init_window), (modest_msg_edit_window_finalize),
494 (modest_msg_edit_window_get_msg_data),
495 (modest_msg_edit_window_free_msg_data):
496 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
497 (modest_store_widget_finalize):
498 * src/maemo/modest-transport-widget.c:
499 (modest_transport_widget_finalize), (smtp_configuration):
500 * src/modest-main.c: (send_mail):
501 * src/widgets/modest-combo-box.h:
502 * src/widgets/modest-global-settings-dialog-priv.h:
503 * src/widgets/modest-global-settings-dialog.c:
504 (modest_global_settings_dialog_finalize):
505 * src/widgets/modest-msg-edit-window.h:
506 Whenever using modest_combo_box_new(), keep the ModestPairList alive
507 as long as the combo box, to prevent use of freed memory for the ID.
509 2007-05-15 Murray Cumming <murrayc@murrayc.com>
511 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
512 get_accounts(), to make this clearer. Do not check for the enabled gconf
513 key, because we do not use this for server accounts (at least, not yet).
514 This allows us to send email again.
516 2007-05-15 Murray Cumming <murrayc@murrayc.com>
518 * src/maemo/modest-platform.c:
519 (on_modest_conf_update_interval_changed), (modest_platform_init):
520 Only respond to this particular key change. All these strcmp()s cannot be
523 2007-05-15 Murray Cumming <murrayc@murrayc.com>
525 * src/maemo/modest-maemo-global-settings-dialog.c:
526 (current_connection): Prevent a crash in scratchbox when
527 ny_maemo_conic_device_get_current_iap_id() returns NULL.
528 * src/maemo/modest-platform.c:
529 (on_modest_conf_update_interval_changed), (modest_platform_init):
530 Get the update interval from gconf and reset it when the gconf key changes.
532 2007-05-15 Murray Cumming <murrayc@murrayc.com>
534 * src/modest-protocol-info.c:
535 * src/modest-protocol-info.h: Adde enum-specific get functions,
536 instead of using a ModestProtocolType enum parameter.
538 * src/gnome/modest-account-assistant.c:
539 * src/gnome/modest-store-widget.c:
540 * src/gnome/modest-store-widget.h:
541 * src/gnome/modest-transport-widget.c:
542 * src/gnome/modest-transport-widget.h:
543 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
544 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
545 * src/maemo/easysetup/modest-easysetup-wizard.c:
546 * src/maemo/modest-account-settings-dialog.c:
547 * src/maemo/modest-account-settings-dialog.h:
548 * src/maemo/modest-store-widget.c:
549 * src/maemo/modest-store-widget.h:
550 * src/maemo/modest-transport-widget.c:
551 * src/maemo/modest-transport-widget.h:
552 * src/modest-account-mgr-helpers.c:
553 * src/modest-account-mgr-helpers.h:
554 * src/modest-account-mgr.c:
555 * src/modest-account-mgr.h:
556 * src/modest-tny-account.c:
557 * src/modest-tny-folder.c:
558 * src/widgets/modest-account-view.c:
559 * src/widgets/modest-retrieve-combo-box.c:
560 * src/widgets/modest-retrieve-combo-box.h:
561 * src/widgets/modest-secureauth-combo-box.c:
562 * src/widgets/modest-serversecurity-combo-box.c:
563 * src/widgets/modest-serversecurity-combo-box.h:
564 * tests/check_account-mgr.c:
565 Use the specific functions, and use the re-renamed enum values for GNOME too.
567 2007-05-15 Murray Cumming <murrayc@murrayc.com>
570 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
571 so we can get the second based on the first.
573 * src/maemo/modest-account-settings-dialog.h:
574 * src/maemo/modest-account-settings-dialog.c:
575 Added get_supported_secure_authentication_methods(), though it is mostly
576 commented-out for now until the necessary API is committed to tinymail.
577 (modest_account_settings_dialog_set_account_name),
578 (save_configuration): Request the supported authentication methods from the
579 server, so we can choose a working method.
581 * src/modest-tny-account-store.h:
582 * src/modest-tny-account-store.c:
583 (modest_tny_account_store_get_session): Rename from
584 tny_account_store_get_session().
586 2007-05-14 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-protocol-info.h: Split the ModestProtocol enum
589 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
590 There was no need to have these unrelated values in one enum.
592 * src/: many files: Adapted to changed enum. This makes the code a bit
593 clearer, and the compiler could catch some errors.
595 2007-05-14 Murray Cumming <murrayc@murrayc.com>
597 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
598 Show the detailed internal camel error message when an error happens
599 during the configuration, so that our testers can give us more clues.
600 For instance, in projects.maemo.org bug NB#56910 .
602 2007-05-14 Murray Cumming <murrayc@murrayc.com>
604 * src/modest-tny-account.c:
605 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
606 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
608 2007-05-14 Murray Cumming <murrayc@murrayc.com>
610 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
611 * src/maemo/modest-account-settings-dialog.c:
612 (modest_account_settings_dialog_set_account_name),
613 (save_configuration): For the incoming secure authentication checkbox,
614 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
615 the UI specification. PLAIN does not seem to be supported for most IMAP
616 servers anyway, and I am not sure what it would mean.
617 However, we probably need to discover which of the secure-authentication
618 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
619 * src/modest-account-mgr-helpers.c:
620 (modest_account_mgr_get_server_account_data):
622 * src/modest-tny-account.c:
623 (modest_tny_account_new_from_server_account):
624 Use tny_account_set_mech() to set secure-authentication methods,
625 with some special-casing for IMAP, based on my observations of how
628 * src/modest-account-mgr-helpers.h:
629 * src/modest-account-mgr.c:
630 * src/modest-defs.h: Comment that the URI is only used for local folders.
632 2007-05-11 Murray Cumming <murrayc@murrayc.com>
634 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
635 parameter const, just to be neat.
636 * src/modest-text-utils.c: (modest_text_utils_inline):
637 End g_strconcat() with NULL, as its documentation says. This is almost
638 certainly the cause of my crash at startup on the device. Interestingly,
639 valgrind doesn't tell us about these errors.
641 2007-05-11 Murray Cumming <murrayc@murrayc.com>
643 * scripts/build-packages: Added more precise comments about how to use
644 this script, though I still get this error:
645 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
646 error building tinymail
648 2007-05-11 Murray Cumming <murrayc@murrayc.com>
650 * src/maemo/modest-main-window.c: (on_account_update):
651 Very slight cleanup, hoping to make it simpler to discover what causes
652 a crash here sometimes.
654 * src/modest-tny-account.c:
655 (modest_tny_account_new_from_server_account): Set the port. Added
656 comments about the options and a TODO comment because I need to find out
657 how to specify the secure authentication method.
659 2007-05-11 Marcus Bauer <marcusb@openismus.com>
661 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
662 changed CFlags paths form modest to libmodest
664 2007-05-10 Murray Cumming <murrayc@murrayc.com>
666 * src/modest-account-mgr-helpers.c:
667 (modest_account_mgr_get_server_account_data),
668 (modest_account_mgr_free_server_account_data):
669 * src/modest-account-mgr-helpers.h:
670 * src/modest-account-mgr.c:
671 (modest_account_mgr_add_server_account):
673 * src/modest-tny-account.c:
674 (modest_tny_account_new_from_server_account):
675 Determine the options for tny_camel_account_add_option() here,
676 based on the settings, rather than storing them directly in gconf.
678 2007-05-10 Murray Cumming <murrayc@murrayc.com>
680 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
681 Show a more friendly error dialog now that we expect (from the tinymail
682 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
684 2007-05-10 Murray Cumming <murrayc@murrayc.com>
686 * src/maemo/modest-main-window.c: (on_account_update): Check that
687 account_name is not NULL, to prevent a crash at startup that I am
688 seeing on the N800. I do wonder why it is NULL.
690 * src/maemo/easysetup/modest-easysetup-wizard.c:
691 (create_page_user_details):
692 * src/maemo/modest-account-settings-dialog.c:
693 (create_page_user_details), (create_page_outgoing):
694 * src/maemo/modest-connection-specific-smtp-edit-window.c:
695 (modest_connection_specific_smtp_edit_window_init):
696 * src/modest-ui-actions.c:
697 (modest_ui_actions_on_password_requested):
698 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
699 might do something useful with the on-screen keyboard.
701 2007-05-10 Murray Cumming <murrayc@murrayc.com>
703 * src/maemo/modest-main-window.c: (on_account_update):
704 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
705 NULL, to avoid lots of warnings. However, it probably should not be NULL.
707 2007-05-09 Murray Cumming <murrayc@murrayc.com>
709 * src/modest-tny-account-store.c: (on_account_changed):
710 Correct the signature of this signal handler.
712 2007-05-09 Murray Cumming <murrayc@murrayc.com>
714 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
715 Show a HildonNote instead of a GtkDialog for Maemo.
717 2007-05-09 Murray Cumming <murrayc@murrayc.com>
719 * src/widgets/modest-account-view.h:
720 * src/widgets/modest-account-view.c: (on_account_changed),
721 (on_account_removed). Added a boolean flag, set/unset by
722 modest_account_view_block_conf_updates(),
723 modest_account_view_unblock_conf_updates() to prevent unnecessary
724 updates, but this is not very useful because the gconf notifications are
725 so delays (maybe only on Maemo Bora).
726 So auto-updating is turned off, and these functions do an explicit
727 update when necessary.
728 However, something else is still doing too much work when adding/removing
729 accounts, probably in another part of the application.
731 * src/maemo/modest-account-view-window.c:
732 (on_delete_button_clicked), (on_edit_button_clicked),
733 (on_new_button_clicked): Use the new functions.
735 2007-05-09 Murray Cumming <murrayc@murrayc.com>
737 * src/modest-account-mgr-helpers.c:
738 (modest_account_mgr_set_first_account_as_default):
739 Sort the list of names alphabetically-by-title, so we choose the first one
741 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
742 alphabetically by the title.
744 This fixes projects.maemo.org bug NB#56418 .
746 * src/modest-account-mgr-priv.c:
747 (_modest_account_mgr_account_from_key):
748 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
749 avoid a valgrind error, and possible random behaviour.
751 2007-05-09 Murray Cumming <murrayc@murrayc.com>
753 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
754 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
755 tinymail documentation to say that this can be expected.
756 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
757 pretty, and should not happen, but I would prefer to know when it does.
759 2007-05-09 Murray Cumming <murrayc@murrayc.com>
761 * configure.ac: When using the older hildon version, probably on Bora,
762 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
764 * src/widgets/modest-attachment-view.c:
765 (modest_attachment_view_set_part_default): Initialize variables, to fix the
768 2007-05-09 Marcus Bauer <marcusb@openismus.com>
770 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
771 Implemented the prototype. Can be tested with
772 tests/dbus_api/test_open_message:
774 2007-05-08 Murray Cumming <murrayc@murrayc.com>
776 * src/modest-tny-account-store.c:
777 (modest_tny_account_store_instance_init), (get_password):
778 * src/modest-ui-actions.c:
779 (modest_ui_actions_on_password_requested):
780 Do not store the password in gconf, because this function is called
781 for non-remembered passwords. Actually use the cached (in the hash map)
782 password instead of releasing it.
783 The password will now not be remembered if it is asked via the protected
784 password dialog, as per the UI spec.
786 2007-05-08 Murray Cumming <murrayc@murrayc.com>
789 * src/modest-account-mgr-helpers.h:
790 * src/modest-account-mgr-helpers.c:
791 Added modest_server_account_get_username_has_succeeded(),
792 modest_server_account_set_username_has_succeeded().
793 (modest_server_account_set_username),
794 Reset the has-succeeded flag if the username changes.
796 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
797 * src/maemo/modest-connection-specific-smtp-window.c:
798 (modest_connection_specific_smtp_window_save_server_accounts):
799 Use modest_server_account_set_username() instead of using
800 modest_conf_set_string() directly, so that the has-succeeded flag is always
803 * src/modest-ui-actions.c:
804 (modest_ui_actions_on_password_requested): Dim the username entry if
805 the username has ever worked, as per the UI spec.
807 2007-05-08 Murray Cumming <murrayc@murrayc.com>
809 * src/modest-tny-account-store.c: (get_password):
810 * src/modest-ui-actions.c:
811 (modest_ui_actions_on_password_requested):
812 Allow the username to be changed too, though there is more work to
813 be done on exactly how this behaves.
815 2007-05-08 Murray Cumming <murrayc@murrayc.com>
817 * src/modest-account-mgr-helpers.h:
818 * src/modest-account-mgr-helpers.c:
819 Added modest_account_mgr_get_display_name(),
820 modest_server_account_get_username(),
821 modest_server_account_set_username(),
822 modest_server_account_set_password(),
823 modest_server_account_get_hostname() functions so we do not need to
824 use the conf API directly.
826 * src/maemo/modest-main-window.c: (connect_signals):
827 Actually connect ot the ModestAccountStore::request-password signal,
828 so that we show the dialog when the password is requested by Tinymail,
829 for isntance if it is empty.
831 * src/modest-marshal.list:
832 * src/modest-tny-account-store.c:
833 (modest_tny_account_store_class_init), (get_password),
834 (modest_tny_account_store_alert):
835 * src/modest-tny-account-store.h:
836 * src/modest-ui-actions.h:
837 * src/modest-ui-actions.c:
838 (modest_ui_actions_on_password_requested):
839 Change the signal parameters, so it is obvious that we are providing
840 the non human-readable server name, and receiving both the username
841 and password, though changing of the username is not yet implemented.
842 Change the dialog UI to match the Maemo UI specifications, with #idfefing
843 for the GNOME version.
845 This should fix the projects.maemo.org bug NB#56209, though it does not
846 work on Bora, because the gconf_client_get() for the password fails
847 immediately after we save it with gconf_client_set().
849 2007-05-08 Murray Cumming <murrayc@murrayc.com>
852 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
853 caused an undefined symbol error:
854 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
856 2007-05-08 Murray Cumming <murrayc@murrayc.com>
858 * src/modest-tny-account-store.c:
859 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
860 using a GError instead of a string message, so we can translate it in
863 2007-05-08 Murray Cumming <murrayc@murrayc.com>
865 * src/maemo/modest-address-book.c:
866 (modest_address_book_check_names):
867 * src/maemo/modest-msg-view-window.c:
868 (modest_msg_view_window_clipboard_owner_change):
869 * src/modest-init.c: (modest_init_init_ui):
870 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
871 (update_folders_cb), (modest_mail_operation_update_account):
872 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
873 (modest_ui_actions_on_msg_attachment_clicked),
874 (modest_ui_actions_on_msg_recpt_activated):
875 * src/widgets/modest-header-view.c: (drag_data_get_cb):
876 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
877 (modest_msg_view_search_next):
878 * src/widgets/modest-recpt-editor.c:
879 (modest_recpt_editor_on_button_release_event),
880 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
881 g_message(). At this point we should only be seeing interesting errors on
882 stdout. Debugging messages could be #ifdefed-out if they are still useful.
884 2007-05-07 Murray Cumming <murrayc@murrayc.com>
886 (modest_wizard_dialog_force_title_update):
887 * src/maemo/easysetup/modest-wizard-dialog.h:
888 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
889 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
890 can update the title when appropriate. Otherwise the title is wrong if the
891 pages are added after adding the notebook to the dialog.
892 This must be a problem in HildonWizardDialog too.
893 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
895 * src/maemo/easysetup/modest-easysetup-wizard.c:
896 (create_subsequent_customsetup_pages),
897 (create_subsequent_easysetup_pages):
898 Call modest_wizard_dialog_force_title_update() so that the title is
899 correct even with GTK+ < 2.10.
900 This fixes projects.maemo.org bug NB#56145 .
902 2007-05-07 Murray Cumming <murrayc@murrayc.com>
904 * src/maemo/modest-platform.c:
905 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
906 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
909 2007-05-07 Murray Cumming <murrayc@murrayc.com>
911 * src/widgets/modest-window.h:
912 * src/widgets/modest-window.c: Added a save_state_func vfunc,
913 and modest_window_save_state(), which invokes it.
915 * src/widgets/modest-window-mgr.h:
916 * src/widgets/modest-window-mgr.c:
917 Added modest_window_mgr_save_state_for_all_windows(), which calls
918 the save_state vfunc on all registered windows, if implemented.
920 * src/gnome/modest-msg-edit-window.c:
921 * src/gnome/modest-msg-view-window.c:
922 * src/maemo/modest-msg-edit-window.c:
923 * src/maemo/modest-msg-view-window.c:
924 * src/maemo/modest-main-window.c:
925 Specify the existing save_settings functions as implementations of
926 ModestWindow::save_state_func().
928 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
929 Call modest_window_mgr_save_state_for_all_windows(). This happens before
930 enabling hibernation, for instance.
932 We may need to do the same thing for restoring settings.
935 2007-05-07 Murray Cumming <murrayc@murrayc.com>
937 * src/widgets/modest-window-mgr.c:
938 * src/widgets/modest-window-mgr.h:
939 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
940 modest_window_mgr_get_hibernation_is_prevented().
942 * src/maemo/modest-main-window.c:
943 (on_hildon_program_is_topmost_notify): Prevent hibernation
944 (possible when the application goes to the background in the WM),
945 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
947 * src/maemo/easysetup/modest-easysetup-wizard.c:
948 (modest_easysetup_wizard_dialog_init):
949 * src/maemo/modest-account-settings-dialog.c:
950 (modest_account_settings_dialog_init):
951 * src/maemo/modest-connection-specific-smtp-edit-window.c:
952 (modest_connection_specific_smtp_edit_window_init):
953 * src/maemo/modest-connection-specific-smtp-window.c:
954 (modest_connection_specific_smtp_window_init):
955 * src/maemo/modest-signature-editor-dialog.c:
956 (modest_signature_editor_dialog_init):
957 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
958 prevent hibernation while any of these account settings dialogs are open.
960 2007-05-04 Murray Cumming <murrayc@murrayc.com>
962 * src/maemo/Makefile.am:
963 * src/maemo/modest-osso-state-saving.c:
964 * src/maemo/modest-osso-state-saving.h: Added
965 modest_osso_load_state() and modest_osso_save_state() though they do
966 nothing now. They should iterate through all the open windows and load/save
968 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
969 save state when closing.
971 * src/maemo/modest-main-window.c:
972 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
973 Add a notification handler for the HildonProgram::is-topmost property,
974 so we can allow hibernation when the application goes into the background.
975 But we still need to detect when the accounts setup windows are open so
976 we can stop hibernation when they are open.
977 To do this, I also added the main window the HildonProgram. This might have
978 other side-effects/benefits, and should maybe be done for other windows.
980 * src/maemo/modest-osso-autosave-callbacks.h:
981 * src/maemo/modest-osso-autosave-callbacks.c:
982 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
983 though it does not do anything yet, and we might never need this to do
984 anything. For instance, we already save drafts.
986 * src/maemo/modest-platform.c: (modest_platform_init):
987 Specify the libosso auto-save callback.
989 2007-05-03 Murray Cumming <murrayc@murrayc.com>
991 * src/maemo/modest-platform.c:
992 (modest_platform_set_update_interval):
993 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
994 aparently stays valid between application instances, so we can use this
995 to remove and reset it later. According to a maemo-developers email from
998 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1000 * configure.ac: Depend on libalarm for Maemo.
1002 * src/dbus_api/modest-dbus-api.h:
1003 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1004 (on_send_receive), (modest_dbus_req_handler):
1005 Handle a SEND_RECEIVE D-Bus method.
1007 * libmodest-dbus-client/libmodest-dbus-client.c:
1008 (libmodest_dbus_client_send_and_receive):
1009 * libmodest-dbus-client/libmodest-dbus-client.h:
1010 Add C convenience functions for calling the new D-Bus method.
1012 * src/modest-platform.h:
1013 * src/gnome/modest-platform.c:
1014 * src/maemo/modest-platform.c:
1015 Added modest_platform_set_update_interval(), which uses the
1016 alarmd API on Maemo.
1017 (modest_platform_init),
1018 Call modest_platform_set_update_interval(), using a hard-coded
1019 interval for now (until the global settings dialog is implemented),
1020 though I am not sure that this makes sense yet.
1022 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1024 * src/dbus_api/modest-dbus-callbacks.c:
1025 (modest_osso_cb_hw_state_handler):
1026 * src/dbus_api/modest-dbus-callbacks.h:
1027 * src/maemo/modest-platform.c: (modest_platform_init):
1028 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1029 in case this has some effect on the ability for Maemo to ping the
1032 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1034 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1035 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1036 warning. It is probably a logic error, but I need to fix the build.
1038 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1040 * src/modest-account-mgr.h:
1041 * src/modest-account-mgr.c:
1042 (modest_account_mgr_account_names): Add a gboolean enabled_only
1043 parameter, so we can get lists of onlt the enabled accounts.
1045 (modest_account_mgr_add_account),,
1046 (modest_account_mgr_account_with_display_name_exists):
1047 * src/maemo/modest-msg-edit-window.c: (get_transports):
1048 * src/modest-account-mgr-helpers.c:
1049 (modest_account_mgr_set_first_account_as_default):
1050 * src/modest-init.c: (init_default_account_maybe):
1051 * src/modest-tny-account-store.c: (get_accounts):
1052 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1053 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1054 * tests/check_account-mgr.c: (START_TEST):
1055 Provide the extra parameter, as appropriate.
1057 * src/widgets/modest-account-view.c: (update_account_view):
1058 Do not show disabled accounts (meaning that there is no way to
1059 enable/disable accounts in the UI (the feature is not in our UI
1060 specification), so we can use this internally only to mark unfinished
1061 or temporary account data.
1063 * src/maemo/easysetup/modest-easysetup-wizard.c:
1064 (create_account): Add boolean enable parameter, so we can specify FALSE
1065 to create the temporary account.
1066 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1067 (on_before_next): When finishing, when there is a temporary account, just
1069 Also, use a timeout to delay the showing of the dialog until gconf is likely
1070 to return correct information, due to a maemo gconf bug that is fixed in
1071 osso 1.1, but not yet in Bora.
1072 However, the dialog stays on screen after it is destroyed.
1074 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1075 for invalid data when cancelling. Use a hildon note instead of a dialog
1076 to complain about invalid data. Do not show the account-saved note if the
1077 account is disabled (a temporary account that will not really be saved for use
1080 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1082 * src/modest-account-mgr-helpers.h:
1083 * src/modest-account-mgr-helpers.c:
1084 Added modest_account_mgr_unset_default_account(),
1085 Added modest_account_mgr_set_first_account_as_default().
1087 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1088 If it was the default account, unset the default account name.
1090 * src/maemo/modest-account-view-window.c:
1091 (on_delete_button_clicked): If it was the default account,
1092 set the first remaining account as the default instead.
1094 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1095 a NULL account or a NULL default account, to prevent a crash. This should
1096 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1099 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1101 * src/widgets/modest-recpt-editor.c:
1102 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1103 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1104 TODO comment for this. This fixes the build.
1106 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1107 be the best place for it. This will in future update all auto-update accounts,
1108 rather than just the current/default account, when that gconf key exists.
1109 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1110 if there are no accounts, before calling do_send_receive().
1111 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1113 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1114 * src/maemo/modest-main-window-ui.h:
1115 * src/maemo/modest-main-window.c: (on_connection_changed),
1116 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1117 directly, becaue the signal handler does more.
1119 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1121 * src/modest-account-mgr-helpers.c:
1122 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1123 for the case that the account does not exist.
1125 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1126 (equivalent to the modest account name) rather than the tinymail account name
1127 (equivalent to the modest account title - human readable) to get the account data.
1128 Check for null account data to prevent the crash, and add a TODO comment saying that
1129 this needs fixing because it is using the server account name instead of the account name.
1131 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1133 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1134 * src/maemo/modest-account-settings-dialog.c: (show_error),
1136 Use hildon_note_new_information() for informative and error messages,
1137 which seems to be expected for Maemo applications (no documentation that I know of
1138 says this). I am surprised that there is no distinction between info and error
1141 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1143 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1144 it is easy to find where this is used.
1146 * src/maemo/easysetup/modest-easysetup-wizard.c:
1147 (create_page_welcome), (create_page_account_details),
1148 (create_page_user_details), (create_page_complete_easysetup),
1149 (create_page_custom_incoming), (create_page_custom_outgoing),
1150 (create_page_complete_custom):
1151 * src/maemo/modest-account-settings-dialog.c:
1152 (create_page_account_details), (create_page_user_details),
1153 (create_page_incoming), (create_page_outgoing):
1154 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1155 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1156 (modest_connection_specific_smtp_edit_window_init):
1157 * src/maemo/modest-connection-specific-smtp-window.c:
1158 (modest_connection_specific_smtp_window_init):
1159 * src/maemo/modest-signature-editor-dialog.c:
1160 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1161 and scrolling policy as per the Email Application Layout Guide, if I have
1164 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1166 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1167 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1168 which were empty, because these vfuncs have been removed from TnyAccountStore.
1169 This fixes the build.
1171 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1173 * src/maemo/modest-main-window.c:
1174 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1175 showing/hiding it. Added TODO because it probably should not be NULL.
1176 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1177 because unnecessary g_warnings() make degugging difficult.
1179 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1181 * src/maemo/modest-msg-edit-window.c:
1182 (modest_msg_edit_window_select_color),
1183 (modest_msg_edit_window_select_background_color): 2 const corrections and
1184 moving 2 #endifs before closing brackets, to fix the build.
1186 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1188 * src/maemo/easysetup/modest-easysetup-wizard.h:
1189 * src/maemo/easysetup/modest-easysetup-wizard.c:
1190 (modest_easysetup_wizard_dialog_finalize),
1191 (on_button_edit_advanced_settings), (create_page_complete_custom),
1192 (on_response), (create_account):
1193 Implement the Advanced Settings edit button, by saving the account information,
1194 for the Advanded Settings dialog to use directly from gconf, and removing it
1195 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1196 Bug #5533 in the projects.maemo.org bugzilla.
1198 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1200 * src/maemo/modest-msg-view-window.c:
1201 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1202 when opening a message window.
1204 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1206 * src/maemo/easysetup/modest-easysetup-wizard.c:
1207 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1210 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1211 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1212 gconf settings. I probably added more checks than necessary, but that is safer.
1214 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1215 variable to fix the build, but this seems to be used when it is still NULL.
1217 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1219 * src/modest-platform.h:
1220 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1221 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1222 * src/modest-main.c: Implement this function so we can avoid using
1223 maemo-specific API from cross-platform code.
1225 * src/modest-tny-account-store.c:
1226 (get_smtp_specific_transport_account_for_open_connection):
1227 * src/modest-ui-actions.c: (check_for_connection),
1228 (modest_ui_actions_on_item_not_found):
1229 Use modest_platform_connect_and_wait() and put #idefs around other
1230 maemo-specific code, because only maemo currently has a way to
1231 identify connection names.
1233 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1235 * src/modest-tny-account-store.h:
1236 * src/modest-tny-account-store.c:
1237 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1238 the connection-specific SMTP server settings in the configuration.
1240 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1242 * src/maemo/modest-main-window.c: (on_connection_changed),
1244 * src/modest-main.c: (main), (start_ui), (send_mail):
1245 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1246 that is what is intended.
1248 * src/modest-ui-actions.c: (action_send), (action_receive),
1249 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1250 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1251 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1252 SMTP server is used when it is specified.
1254 (modest_ui_actions_on_send_receive):
1255 Check that a connection is open before proceeding.
1256 Receive and then send, instead of vice-versa, as per the specification.
1258 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1260 * src/modest-mail-operation.c:
1261 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1262 though I guess it should be something other than NULL.
1264 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1266 * src/maemo/easysetup/modest-easysetup-wizard.c:
1267 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1268 combo twice, to avoid an g_warning and to make it visible again.
1269 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1270 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1271 (already intended) dereference when detaching, because we then recreate the menu.
1272 But I am not sure why the warning was happening, and it is possible that this is a memory
1275 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1277 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1278 and uri_parse_mailto() utility functions.
1279 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1281 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1283 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1285 * src/dbus_api/modest-dbus-api.h:
1286 * src/dbus_api/modest-dbus-callbacks.c:
1287 Use an idle callback to execute the modest code in the application's own thread.
1288 Remove the helloworld example method.
1289 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1290 parsed, and the open-message method is not implemented because this is not yet implemented in
1292 * libmodest-dbus-client/libmodest-dbus-client.c:
1293 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1294 (libmodest_dbus_client_open_message):
1295 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1297 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1298 body without crashing.
1300 * tests/dbus_api/Makefile.am:
1301 * tests/dbus_api/test_mail_to.c:
1302 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1304 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1306 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1307 Added file to fix the build. Sorry.
1309 * src/dbus_api/Makefile.am:
1310 * src/dbus_api/modest-dbus-api.h:
1311 * src/dbus_api/modest-dbus-callbacks.h:
1312 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1313 (modest_dbus_req_handler):
1314 Put constants in a separate header so it can be reused by the
1315 client library, without duplication
1317 * libmodest-dbus-client/Makefile.am:
1318 * libmodest-dbus-client/libmodest-dbus-client.c:
1319 (libmodest_dbus_client_call_helloworld),
1320 (libmodfest_dbus_client_send_mail),
1321 (libmodfest_dbus_client_mailto),
1322 (libmodfest_dbus_client_open_message):
1323 * libmodest-dbus-client/libmodest-dbus-client.h:
1324 (Partly) Implement a send_mail D-Bus method.
1326 * tests/dbus_api/Makefile.am:
1327 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1328 the send_email D-Bus method.
1330 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1334 * libmodest-dbus-client/Makefile.am:
1335 * libmodest-dbus-client/libmodest-dbus-client.c:
1336 * libmodest-dbus-client/libmodest-dbus-client.h:
1337 * tests/dbus_api/Makefile.am:
1338 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1339 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1341 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1343 * src/maemo/easysetup/modest-easysetup-wizard.c:
1344 (create_page_account_details):
1345 * src/maemo/modest-account-settings-dialog.c:
1346 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1347 widgets, because this might not be the default in future versions of the Maemo GTK+.
1348 However, I can not not get capitalization to work even in a simple test case.
1350 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1352 * src/maemo/easysetup/modest-easysetup-wizard.c:
1353 (create_page_custom_incoming), (create_page_custom_outgoing):
1354 * src/maemo/modest-account-settings-dialog.c:
1355 (create_page_account_details), (create_page_incoming),
1356 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1357 instead of using gtk_check_button_with_label(), so they are aligned like the other
1358 widgets, as per the UI spec.
1360 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1362 * src/maemo/easysetup/modest-easysetup-wizard.c:
1363 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1364 * src/widgets/modest-validating-entry.c:
1365 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1366 Modest prefix instead of an EasySetup prefix.
1368 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1370 * src/widgets/modest-validating-entry.h:
1371 * src/widgets/modest-validating-entry.c: (on_insert_text),
1372 Added easysetup_validating_entry_set_max_func(), used to set a callback
1373 to call when the max number of characters is reached. GtkEntry has a max-length
1374 already but is silent about it.
1376 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1377 (create_page_account_details), (create_page_user_details),
1379 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1380 (create_page_account_details), (create_page_user_details),
1381 (create_page_outgoing):
1382 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1383 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1384 the UI spec, when the user tries to enter more than the max number of characters.
1386 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1388 * src/maemo/easysetup/modest-easysetup-wizard.c:
1389 (create_page_user_details), (create_page_custom_incoming),
1390 (create_page_custom_outgoing):
1391 * src/maemo/modest-account-settings-dialog.c:
1392 (create_page_user_details), (create_page_incoming),
1393 (create_page_outgoing):
1394 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1395 (modest_connection_specific_smtp_edit_window_init):
1396 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1397 not appropriate. Bad Maemo-specific defaults!.
1399 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1401 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1402 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1403 (modest_signature_editor_dialog_set_settings):
1404 Disable the label and textview when the checkbox is disabled, and use the
1405 specified (UI spec) default signature text.
1407 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1409 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1410 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1412 * src/modest-defs.h:
1413 * src/modest-account-mgr-helpers.h:
1414 * src/modest-account-mgr-helpers.c:
1415 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1417 * src/maemo/Makefile.am:
1418 * src/maemo/modest-signature-editor-dialog.c:
1419 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1422 * src/maemo/modest-account-settings-dialog.h:
1423 * src/maemo/modest-account-settings-dialog.c:
1424 (modest_account_settings_dialog_finalize), (on_button_signature),
1425 (save_configuration): Use the new dialog when the Edit button is pressed, and
1426 save the changes if necessary, as per the UI spec.
1428 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1430 * src/maemo/Makefile.am:
1431 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1432 based on maemo-develoers email from Dirk.
1434 * src/maemo/easysetup/modest-easysetup-wizard.c:
1435 (create_page_welcome), (create_page_account_details),
1436 (create_page_user_details), (create_page_complete_easysetup),
1437 (create_page_custom_incoming), (create_page_custom_outgoing),
1438 (create_page_complete_custom),
1439 (modest_easysetup_wizard_dialog_init):
1440 * src/maemo/modest-account-settings-dialog.c:
1441 (create_page_account_details), (create_page_user_details),
1442 (create_page_incoming), (create_page_outgoing),
1443 (modest_account_settings_dialog_init):
1444 * src/maemo/modest-connection-specific-smtp-window.c:
1445 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1447 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1449 * src/maemo/easysetup/modest-easysetup-wizard.c:
1450 (create_page_account_details), (create_page_custom_outgoing),
1451 (create_page_complete_custom):
1452 * src/maemo/modest-account-settings-dialog.c:
1453 (create_page_user_details), (create_page_incoming),
1454 (create_page_outgoing):
1455 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1456 (modest_connection_specific_smtp_edit_window_init):
1457 Use the correct (UI spec) port min/max, and use horizontal separators,
1460 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1462 * src/maemo/easysetup/modest-easysetup-wizard.c:
1463 (set_default_custom_servernames):
1464 * src/maemo/modest-account-settings-dialog.c:
1465 (create_page_incoming), (on_combo_outgoing_security_changed),
1466 (on_combo_incoming_security_changed), (create_page_outgoing),
1467 (modest_account_settings_dialog_set_account_name),
1468 (save_configuration):
1469 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1470 (on_combo_security_changed),
1471 (modest_connection_specific_smtp_edit_window_init),
1472 (modest_connection_specific_smtp_edit_window_set_connection),
1473 (modest_connection_specific_smtp_edit_window_get_settings):
1474 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1477 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1480 * src/maemo/easysetup/modest-easysetup-wizard.c:
1481 (create_page_custom_outgoing), (create_page_complete_custom):
1482 * src/maemo/modest-account-settings-dialog.c:
1483 (create_page_user_details), (create_page_outgoing):
1484 * src/maemo/modest-account-view-window.c: (button_box_new):
1485 Use changed logical IDs as per the most recent UI spec:
1486 mcen_bd_emailsetup_edit -> mcen_bd_edit
1487 mcen_bd_emailsetup_delete -> mcen_bd_delete
1488 mcen_bd_emailsetup_close -> mcen_bd_close
1490 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1494 * src/dbus_api/Makefile.am:
1495 * src/dbus_api/modest-dbus-callbacks.c:
1496 * src/dbus_api/modest-dbus-callbacks.h:
1497 * src/maemo/modest-platform.c: (modest_platform_init):
1498 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1500 * tests/Makefile.am:
1501 * tests/dbus_api/Makefile.am:
1502 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1504 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1506 * src/maemo/modest-account-settings-dialog.c:
1507 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1508 Removed unnecessary includes.
1510 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1512 * src/maemo/easysetup/modest-easysetup-wizard.c:
1513 * src/maemo/modest-account-settings-dialog.c:
1514 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1515 * src/widgets/Makefile.am:
1516 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1517 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1518 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1519 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1520 * src/widgets/modest-secureauth-combo-box.c:
1521 * src/widgets/modest-secureauth-combo-box.h:
1522 * src/widgets/modest-serversecurity-combo-box.c:
1523 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1524 made the GObject names more consistent with the rest of the Modest code.
1526 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1528 * src/maemo/easysetup/Makefile.am:
1529 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1530 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1531 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1532 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1533 * src/maemo/easysetup/modest-easysetup-wizard.c:
1534 * src/maemo/easysetup/modest-validating-entry.c:
1535 * src/maemo/easysetup/modest-validating-entry.h:
1536 * src/maemo/modest-account-settings-dialog.c:
1537 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1538 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1539 widgets/ because they are used outside of easysetup too. After checking in,
1540 svn will allow me to rename them too.
1542 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1544 * src/gnome/modest-msg-edit-window.c:
1545 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1546 linker error, to fix the build on the GNOME platform.
1547 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1548 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1549 ifdefed out to avoid a warning.
1551 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1553 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1554 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1555 some alternative for GTK+ 2.6.
1557 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1559 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1561 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1562 specified for EmailAccountsDialog in UI spec.
1564 * src/maemo/easysetup/modest-easysetup-wizard.c:
1565 * src/maemo/easysetup/modest-easysetup-wizard.h:
1566 * src/maemo/modest-account-settings-dialog.c:
1567 * src/maemo/modest-account-settings-dialog.h:
1568 Reuse a member window widget for the connection-specific SMTP server accounts,
1569 so we can tell it to create/save the accounts only if we actually save changes.
1571 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1572 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1573 (modest_connection_specific_smtp_edit_window_get_settings):
1574 Return a struct instance for temporarily remembering the entered data.
1576 * src/maemo/modest-connection-specific-smtp-window.h:
1577 * src/maemo/modest-connection-specific-smtp-window.c:
1578 (modest_connection_specific_smtp_window_finalize),
1579 (modest_connection_specific_smtp_window_fill_with_connections),
1581 (modest_connection_specific_smtp_window_save_server_accounts),
1582 (update_model_server_names): Do not actually save data until asked,
1583 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1585 (on_selection_changed),
1586 (modest_connection_specific_smtp_window_init): Disable the edit
1587 button when nothing is selected.
1589 * src/modest-account-mgr-helpers.c:
1590 * src/modest-account-mgr-helpers.h:
1591 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1594 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1596 * src/modest-account-mgr-helpers.h:
1597 * src/modest-account-mgr-helpers.c:
1598 (modest_account_mgr_get_unused_account_name),
1599 (modest_account_mgr_get_unused_account_display_name): Added these
1600 utility functions, to avoid code duplication.
1602 * src/maemo/easysetup/modest-easysetup-wizard.c:
1603 (create_page_account_details), (create_account):
1604 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1605 (on_combo_security_changed),
1606 (modest_connection_specific_smtp_edit_window_init),
1607 (modest_connection_specific_smtp_edit_window_save_settings):
1608 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1609 * src/maemo/modest-connection-specific-smtp-window.c:
1610 (modest_connection_specific_smtp_window_finalize),
1611 (modest_connection_specific_smtp_window_fill_with_connections),
1612 (on_button_edit), (modest_connection_specific_smtp_window_init):
1613 * src/maemo/modest-connection-specific-smtp-window.h:
1614 Implementing saving of connection-specific server accounts.
1616 But I need to refactor this so we can save the data for each
1617 possible connection-specific account and only actually create the server accounts
1618 when the easysetup finished, or the OK button is pressed on the account settings
1621 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1623 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1624 (on_combo_security_changed):
1625 (modest_connection_specific_smtp_edit_window_init):
1626 Auto-fill the port number as in the account settings.
1628 (modest_connection_specific_smtp_edit_window_set_connection):
1629 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1630 * src/maemo/modest-connection-specific-smtp-window.c:
1631 (fill_with_connections), (on_button_edit),
1632 (modest_connection_specific_smtp_window_init):
1633 Turn the edit window into a dialog to simplify the code, and
1634 set a WM hint as in a GtkDialog, because only a popup can be on top of
1635 another window in Maemo, and popups usually have no WM decoration.
1637 * src/modest-defs.h:
1638 * src/modest-account-mgr-helpers.c:
1639 (modest_account_mgr_set_connection_specific_smtp),
1640 (modest_account_mgr_remove_connection_specific_smtp),
1641 (modest_account_mgr_get_connection_specific_smtp):
1642 * src/modest-account-mgr-helpers.h: Some functions to write the
1643 connection-specific SMTP server information. Not yet used.
1646 * src/widgets/modest-folder-view.c: (text_cell_data):
1647 Fix a warning about an uninitialized variable.
1648 (on_configuration_key_changed): Put an #ifdef around the use
1649 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1651 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1653 * src/maemo/modest-account-settings-dialog.h:
1654 * src/maemo/modest-account-settings-dialog.c:
1655 Added connect_for_modified() utility function to mark the new modified boolean.
1657 (create_page_account_details), (create_page_user_details),
1658 (create_page_incoming), (create_page_outgoing), (on_response),
1659 (modest_account_settings_dialog_init),
1660 (modest_account_settings_dialog_set_account_name):
1661 Only warn about unsaved changes when there are actually unsaved changes.
1663 * src/modest-account-mgr-helpers.c:
1664 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1665 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1666 to get the data from there in future.
1668 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1670 * src/modest-defs.h:
1672 * src/modest-account-mgr-helpers.h:
1673 * src/modest-account-mgr-helpers.c:
1674 Store the security account setting in a single conf key instead of using
1675 the options list, so that the list is left for just the to-be-removed camel hack,
1676 and because gconf_client_set_list() is failing for some reason.
1678 * src/modest-account-mgr.c:
1679 (modest_account_mgr_add_server_account):
1680 * src/maemo/modest-account-settings-dialog.c:
1681 (modest_account_settings_dialog_set_account_name),
1682 (save_configuration): Use the renamed functions.
1685 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1687 * src/widgets/Makefile.am:
1688 * src/widgets/modest-limit-retrieve-combo-box.c:
1689 * src/widgets/modest-limit-retrieve-combo-box.h:
1690 * src/widgets/modest-retrieve-combo-box.c:
1691 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1692 the account settings dialog.
1694 * src/modest-defs.h:
1695 * src/modest-account-mgr-helpers.h:
1696 * src/modest-account-mgr-helpers.c:
1697 (modest_server_account_get_option_secure_auth),
1698 (modest_server_account_set_option_secure_auth):
1699 * src/modest-account-mgr.c:
1700 (modest_account_mgr_add_server_account):
1701 Use the existing AUTH_MECH conf key for the secure-auth setting,
1702 instead of putting it in the list options, because this was actually used already.
1704 * src/maemo/modest-account-settings-dialog.c:
1705 (create_page_account_details),
1706 (modest_account_settings_dialog_set_account_name),
1707 (save_configuration):
1708 * src/maemo/modest-account-settings-dialog.h:
1709 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1710 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1712 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1714 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1715 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1716 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1718 * src/modest-defs.h:
1719 * src/maemo/modest-account-settings-dialog.c:
1720 (create_page_incoming), (on_combo_outgoing_security_changed),
1721 (on_combo_incoming_security_changed), (create_page_outgoing),
1722 (modest_account_settings_dialog_set_account_name),
1723 (save_configuration): Load/Save the port number, and change it when the
1724 security combo changes, to suitable defaults.
1726 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1728 * src/modest-account-mgr.c:
1729 (modest_account_mgr_add_server_account): Set the security and secure-auth
1730 options, and add a comment saying that the other camel-specific options should be
1733 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1735 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1737 * src/modest-tny-account-store.c: (account_list_free),
1738 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1739 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1742 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1744 * src/modest-protocol-info.c:
1745 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1746 is required by our UI spec. Maybe something in our implementation will use this eventually.
1747 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1748 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1749 instead of the previous 0 placeholder.
1751 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1752 secure-auth settings.
1753 * src/modest-account-mgr-helpers.h:
1754 * src/modest-account-mgr-helpers.c:
1755 (modest_server_account_data_get_option_secure_auth),
1756 (modest_server_account_set_option_secure_auth),
1757 (modest_server_account_data_get_option_security),
1758 (modest_server_account_set_option_security): Added this API for getting and setting the security
1759 and secure-auth settings.
1761 * src/maemo/modest-account-settings-dialog.h:
1762 * src/maemo/modest-account-settings-dialog.c:
1763 (modest_account_settings_dialog_finalize), (check_data),
1764 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1765 about changing titles.
1766 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1767 (save_configuration): Save the security and secure-auth settings.
1769 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1770 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1772 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1774 * src/modest-defs.h:
1775 * src/modest-account-mgr.c:
1776 (modest_account_mgr_add_server_account):
1777 Added and used defines for the options key and value pair strings,
1778 that are used so far, though they do not seem to correspond to anything in our
1779 UI specs or ModestProtocol enum.
1781 * src/modest-account-mgr-helpers.h:
1782 * src/modest-account-mgr-helpers.c:
1783 (compare_option_strings_for_name),
1784 (modest_server_account_data_get_option_value),
1785 (modest_server_account_data_get_option_bool),
1786 (modest_account_mgr_get_server_account_option):
1787 Added helper functions for parsing the options GSList.
1789 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1791 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1792 display name is based on the supplied account name.
1793 * src/modest-account-mgr.c:
1794 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1795 with an inefficient, but good-enough, implementation.
1797 * src/maemo/easysetup/modest-easysetup-wizard.c:
1798 (create_page_account_details), (on_before_next), (create_account):
1799 Check for existing display names rather than (non-user-visible) account names, and just
1800 create and set a unique account name at the end.
1802 * src/maemo/modest-account-settings-dialog.c:
1803 (modest_account_settings_dialog_init),
1804 (modest_account_settings_dialog_set_account_name),
1805 (create_page_incoming): Show the display name, instead of the account name.
1806 (on_response): Do some (not all) extra checks, as in the UI spec.
1807 (save_configuration): Save the display name if it was changed.
1809 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1811 * po/en_GB.po: Added needed logical ID and translation.
1812 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1813 (init_view): Made the is-default column clicking work.
1815 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1818 * src/maemo/easysetup/Makefile.am:
1819 * src/maemo/easysetup/modest-easysetup-wizard.c:
1820 (modest_easysetup_wizard_dialog_init):
1821 * src/maemo/easysetup/provider-data-test.keyfile:
1822 * src/maemo/easysetup/provider-data.keyfile:
1823 Moved the provider data file to the new modest-providers-data package and used it from there.
1825 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1827 * src/modest-local-folder-info.c:
1828 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1829 N_() was already used on the static strings, but this just marks it for translation without
1830 using the translation.
1832 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1834 * src/maemo/modest-account-settings-dialog.c:
1835 (create_page_incoming),
1836 (modest_account_settings_dialog_set_account_name):
1837 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1838 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1839 I will do this if nobody else gets there first.
1841 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1843 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1844 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1845 save the security stuff.
1847 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1849 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1850 Set the email address and user fullname, which I now see must be
1853 * src/maemo/modest-account-settings-dialog.h:
1854 * src/maemo/modest-account-settings-dialog.c:
1856 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1857 leave-on-server and authentication.
1858 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1861 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1864 * src/maemo/modest-account-settings-dialog.c:
1865 * src/maemo/modest-account-settings-dialog.h:
1866 Most (but not all) of the widgets are now present as specified by the UI spec.
1867 No changes are yet saved, and some details are not properly shown yet.
1869 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1871 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1873 * src/maemo/Makefile.am:
1874 * src/maemo/modest-account-settings-dialog.c:
1875 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1876 an existing account. Doesn't do much yet.
1878 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1879 Open the accounts settings dialog when Edit is clicked.
1881 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1883 * src/maemo/easysetup/Makefile.am:
1884 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1886 * src/maemo/easysetup/modest-easysetup-wizard.c:
1887 (modest_easysetup_wizard_dialog_init):
1888 Try to get the source directory from the build system,
1889 instead of hard-coding "./" into the source code, when opening our local
1890 copies of the configuration files.
1891 But this still fails when opening the wizard from the Accounts window,
1892 maybe because the working directory seems to change at runtime.
1893 So the wizard will fail the second time unless you copy the files into their
1894 proper locations - see the stdout warnings for the paths.
1896 (create_page_account_details),(on_before_next):
1897 Check for existing non-server accounts instead of server accounts,
1898 so the default account name is useful again, and to prevent trying to
1901 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1902 Show the wizard when New is clicked.
1904 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1905 (init_view): Show the column headers, and show the columns that are
1906 specified in the UI specs. However, something in Maemo's GTK+ prevents
1907 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1908 change the default account. This is despite unsetting the special properties.
1910 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1912 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1913 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1914 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1915 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1916 to make that clearer.
1917 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1919 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1921 * src/maemo/modest-account-view-window.c:
1922 (modest_account_view_window_init),
1923 (modest_account_view_window_new):
1924 Use the same buttons as specified in the
1925 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1926 the existing widgets, which never had a chance of working.
1927 Put the ModestAccountView treeview in a scrolled window.
1928 Do not repeat the initialization in both _init() and _new().
1930 * src/widgets/modest-account-view.c: (update_account_view):
1931 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1932 this widget and window shows no accounts.
1934 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1936 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1938 * src/maemo/easysetup/modest-easysetup-wizard.c:
1939 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1940 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1941 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1944 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1945 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1946 accounts exist yet, as in the UI spec.
1948 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1950 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1952 * src/maemo/Makefile.am:
1953 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1954 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1955 New window for editing connection-specific smtp details.
1956 Not fully implemented.
1958 * src/maemo/modest-connection-specific-smtp-window.c:
1959 (modest_connection_specific_smtp_window_finalize) :
1960 unref the tree model.
1961 (on_button_edit): Show the edit window.
1963 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1965 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1968 * src/maemo/Makefile.am:
1969 * src/maemo/modest-connection-specific-smtp-window.c:
1970 * src/maemo/modest-connection-specific-smtp-window.h:
1971 New window for showing the list of connections, for connection-specific
1972 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1973 * src/maemo/easysetup/modest-easysetup-wizard.c:
1974 (create_page_custom_outgoing): Show the new window when the button is clicked.
1976 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1978 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1979 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1980 * src/maemo/modest-msg-edit-window.c:
1981 (modest_msg_edit_window_insert_image):
1982 * src/modest-conf.c: (modest_conf_key_escape):
1983 * src/modest-mail-operation.c:
1984 (modest_mail_operation_send_new_mail):
1985 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1986 (modest_ui_actions_on_new_account):
1987 * src/widgets/modest-attachment-view.c: (update_filename_request):
1988 * src/widgets/modest-mail-header-view.c:
1989 Corrected warnings that were breaking the build, by commenting out unused variables,
1990 and a function, and by including a header.
1992 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1994 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1995 so we can #ifdef around platform-specific code when necessary.
1996 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1997 to allow this to build for the GNOME platform too.
1999 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2001 * src/maemo/easysetup/modest-easysetup-wizard.c:
2002 Added util_increment_name() and used it in create_page_account_details()
2003 to make sure that the default account name is always a new name.
2005 (modest_easysetup_wizard_dialog_init),
2006 (set_default_custom_servernames): Some minor memory management fixes.
2008 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2012 * src/modest-runtime.c: (init_i18n): Restored the translation
2013 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2014 are defined in config.h, and the translations are installed.
2016 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2017 is defined for translation.
2019 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2021 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2023 * src/maemo/easysetup/modest-easysetup-wizard.c:
2024 (modest_easysetup_wizard_dialog_init):
2025 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2026 Use realistic paths (though they should use $prefix generically) to the
2027 mcc_mapping and provider-data.keyfile files which might work when they
2028 are installed by the future version of the operator-wizard package,
2029 and then fallback to paths in our source code, with an explanatory
2032 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2036 * src/maemo/Makefile.am:
2037 * src/maemo/easysetup/: Added files from the previously-exernal
2038 osso-modest-easysetup.
2039 * src/maemo/modest-main-window-ui.h:
2040 * src/modest-ui-actions.c:
2041 * src/modest-ui-actions.h:
2042 Added modest_ui_actions_on_new_account() as a signal handler for the
2043 New Account menu item. It shows the easysetup wizard.
2044 * po/en_GB.po: Added additional needed logical IDs and translations.
2046 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2047 Apparently ChangeLog is not used for some vague Nokia legal reasons.