1 2007-06-11 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-presets.c:
4 (modest_presets_get_info_server_security): Do not report secure auth
6 * src/modest-protocol-info.c: Use the defines for the gconf key names
7 for secure authentication. This was not working because we were writing
8 Password and reading password, and the check was case sensitive.
9 With this, gmail now works for receiving and sending when created via
12 2007-06-11 Murray Cumming <murrayc@murrayc.com>
14 * src/maemo/easysetup/modest-presets.c:
15 (modest_presets_get_info_server_security): Correct the key name for
16 SecureSmtp, because it seems to be case-sensitive.
17 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
18 Do not try to get the 0th notebook page if there are 0 pages, to
21 2007-06-11 Murray Cumming <murrayc@murrayc.com>
23 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
24 Prevent use of the new notification feature for now, because it currently
25 shows one dialog for each new email, which is annoying.
27 2007-06-11 Murray Cumming <murrayc@murrayc.com>
29 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
30 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
31 when no country was selected, so that we show the global ones.
32 * src/maemo/easysetup/modest-presets.c:
33 (modest_presets_get_providers): Return only the global providers, not
34 all providers when mmc=0 was requested.
36 2007-06-11 Murray Cumming <murrayc@murrayc.com>
38 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
39 (easysetup_provider_combo_box_fill): Remove debug code that showed the
40 provider ID in the combo.
42 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
43 Do not show the page numbers, because it would be confusing when we add
44 the 2 extra pages for the custom setup, when the user chooses the "Other"
45 provider. This fixes projects.maemo.org bug NB#59028
47 * src/modest-init.c: (modest_init_init_core),
48 (modest_init_local_folders):
50 * src/modest-tny-account.c:
51 (modest_tny_account_new_for_local_folders): Do not create default folders
52 for the memory card. This should fix projects.maemo.org bug NB#59328.
54 2007-06-11 Murray Cumming <murrayc@murrayc.com>
56 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
57 Free the changed_conf_keys string items. They are already freed in the
58 idle handler if that runs first.
60 2007-06-11 Murray Cumming <murrayc@murrayc.com>
62 * src/modest-ui-actions.c:
63 (modest_ui_actions_on_password_requested): Check that the server name
64 is not NULL, because I just saw a password dialog with (null) as the
67 * src/modest-tny-folder.[h|c]: Added
68 modest_tny_folder_is_memory_card_folder().
69 * src/modest-ui-dimming-rules.c:
70 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
71 menu item for memory cards, as per the UI spec (section 7.4). This should
72 fix projects.maemo.org bug NB#59297.
74 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
76 * src/maemo/modest-main-window.c: (sync_accounts_cb):
77 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
78 is another problem with the code, see Murray's comment at line 772)
80 2007-06-08 Murray Cumming <murrayc@murrayc.com>
82 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
83 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
84 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
85 (load_from_file), (easysetup_country_combo_box_init),
86 (easysetup_country_combo_box_get_active_country_ids),
87 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
88 instead of just one ID, to avoid duplicate country names in the UI.
90 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
91 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
92 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
93 a single ID, avoiding duplicate providers.
94 * src/maemo/easysetup/modest-easysetup-wizard.c:
95 (on_combo_account_country): Adapt to use a list.
97 2007-06-08 Murray Cumming <murrayc@murrayc.com>
99 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
100 keys changed in the last X seconds.
102 * src/modest-account-mgr.h:
103 * src/modest-account-mgr.c: (on_timeout_notify_changes),
104 (on_key_change), (modest_account_mgr_class_init),
105 (modest_account_mgr_init), (modest_account_mgr_finalize):
106 As the keys are changed, save them in a GSList* and signal that GSList*
107 further every X seconds, to batch changes, to allow us to do just one
108 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
109 bug NB#56941 and other (UI-blocking) delays when changing account settings.
111 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
112 changed signal signature.
114 * src/modest-conf.c: (modest_conf_set_list),
115 (modest_conf_on_change): Reenable notification.
117 (modest_conf_maemo_fake_on_change): Comment out the hack that
118 notified immediately instead of asynchronously.
120 * src/widgets/modest-account-view.h:
121 * src/widgets/modest-account-view.c:
122 (update_account_view): Select the previously-selected account ID,
123 if possible. This fixes projects.maemo.org bug NB#56933.
125 (on_account_changed), (on_account_removed),
126 (modest_account_view_select_account):
128 Remove the block/unblock functions
129 because they were not useful.
131 * src/maemo/modest-account-view-window.c:
132 (on_delete_button_clicked), (on_edit_button_clicked),
133 (on_new_button_clicked): Remove the use of the non-working block/unblock.
135 2007-06-08 Murray Cumming <murrayc@murrayc.com>
137 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
138 Improve the error dialog to show Incorrect Account Settings, which seems
139 clearer, and say that the internal error message (to be removed from the
140 dialog later) is often misleading.
141 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
143 * src/modest-tny-account.c:
144 (modest_tny_account_new_from_server_account): Uncomment the printf of the
145 URL because this is so useful for debugging on the device.
147 * src/widgets/modest-serversecurity-combo-box.c:
148 (modest_serversecurity_combo_box_fill): Correct a logical ID.
150 2007-06-08 Murray Cumming <murrayc@murrayc.com>
152 * src/modest-mail-operation.c:
153 (modest_mail_operation_send_new_mail):
154 Added a comment about a nasty but apparently harmless message. Details
155 added to the wiki g_warnings() page.
157 2007-06-08 Murray Cumming <murrayc@murrayc.com>
159 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
160 (modest_tny_send_queue_class_init):
161 Do not use the priv struct because it is empty, to avoid g_warnings
162 about a non-existant priv struct.
164 * src/modest-tny-account-store.c:
165 (modest_tny_account_store_get_server_account),
166 (modest_tny_account_store_get_transport_account_for_open_connection
167 ): Do not try to get transport server accounts for local folders,
168 because they don't have any. This avoids a g_warning().
170 * src/maemo/modest-main-window.c:
171 (modest_main_window_notify_send_receive_initied),
172 (on_configuration_key_changed):
173 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
175 * src/modest-mail-operation.c:
176 (modest_mail_operation_update_account):
177 * src/modest-tny-account-store.h:
178 * src/modest-tny-account.c:
179 (modest_tny_account_get_special_folder),
180 (modest_tny_account_new_for_local_folders),
181 (modest_tny_account_new_for_per_account_local_outbox_folder):
182 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
183 * src/modest-tny-local-folders-account.c:
184 (add_account_folders_to_merged_folder):
185 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
186 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
187 (modest_ui_actions_on_send):
188 * src/widgets/modest-folder-view.c: (update_model):
189 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
190 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
191 modest_tny_account_store_get_tny_account_by_account() to
192 modest_tny_account_store_get_server_account() to make the code clearer.
194 2007-06-07 Marcus Bauer <marcusb@openismus.com>
196 * src/dbus_api/modest-dbus-api.h:
197 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
198 * src/maemo/modest-msg-edit-window.c:
199 (modest_msg_edit_window_attach_file_noninteractive):
200 added g_warning in case the file to be attached does not exist
201 * tests/dbus_api/test_compose_mail.c: (main):
202 removed obsolete comment, added generic files as test case
204 2007-06-07 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-tny-account-store.c: (get_server_accounts):
207 Create the local folders account only once, not once for each outbox, and
208 not only when there are some outboxes.
210 2007-06-07 Murray Cumming <murrayc@murrayc.com>
212 * src/widgets/modest-folder-view.c: (update_model): Comment out some
213 code that is causing a crash at startup. Sergio says that he is fixing this.
215 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
217 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
218 * src/maemo/modest-account-settings-dialog.c:
219 (create_page_outgoing),
220 (modest_account_settings_dialog_set_account_name),
221 (save_configuration):
222 - Fixed handling of the "Use secure authentication" toggle to comply with
223 the ui specification. See also projects.maemo.org bug NB#58400
225 - Restore the Secure connection setting combo correctly when loading
228 * src/maemo/modest-maemo-utils.c:
229 (on_camel_account_get_supported_secure_authentication),
230 (modest_maemo_utils_get_supported_secure_authentication_methods):
231 Fixed a crasher if operation is canceled
233 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
234 (modest_protocol_info_auth_is_secure):
235 * src/modest-protocol-info.h:
237 Added two new methods to determine if a protocol/auth method is secure/encrypted in
238 the sense of the "Use secure authentication" toggle.
240 2007-06-07 Murray Cumming <murrayc@murrayc.com>
242 * src/modest-tny-account-store.h:
243 * src/modest-tny-account-store.c:
244 Added modest_tny_account_store_get_local_folders_account().
246 * src/modest-tny-folder.h:
247 * src/modest-tny-folder.c:
248 (modest_tny_folder_get_account):
249 Added this replacement for tny_folder_get_account() which returns
250 the local-folders account for TnyMergeFolders, to avoid the
251 warning about the unimplemented get_account_func() vfunc().
253 (modest_tny_folder_get_rules),
254 * src/modest-ui-actions.c:
255 (modest_ui_actions_on_folder_selection_changed):
256 * src/modest-mail-operation.c:
257 (modest_mail_operation_remove_folder),
258 (modest_mail_operation_xfer_folder),
259 (modest_mail_operation_rename_folder),
260 (modest_mail_operation_get_msg),
261 (modest_mail_operation_get_msgs_full),
262 (modest_mail_operation_remove_msg),
263 (modest_mail_operation_xfer_msgs),
264 (modest_mail_operation_refresh_folder):
265 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
267 2007-06-07 Murray Cumming <murrayc@murrayc.com>
269 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
270 (modest_server_account_set_security):
271 * src/modest-defs.h: Add comments explaining that our
272 UI spec means TLS when it says Normal, so these do not look like errors.
274 * src/modest-tny-account.c:
275 (modest_tny_account_new_from_server_account): Use the new tinymail
276 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
277 for TLS. This should fix projects.maemo.org bug NB#58460.
279 2007-06-06 Murray Cumming <murrayc@murrayc.com>
281 * src/maemo/easysetup/modest-easysetup-wizard.c:
282 (create_account): Correct the position of the gconf sanity check warning.
283 (on_button_edit_advanced_settings): Show the dialog immediately, instead
284 of using the g_idle_add() hack, because this does not seem to be necessary
285 on osso 1.1. It might even work on Maemo Bora if the problems were actually
286 caused by something other than maemo's gconf.
287 This fixes projects.maemo.org bug #59022.
289 2007-06-06 Murray Cumming <murrayc@murrayc.com>
291 * src/modest-account-mgr-helpers.c:
292 (modest_account_mgr_get_default_account): Do not check that the account
293 exists if there is no default account (NULL), to fix a runtime warning.
295 2007-06-06 Murray Cumming <murrayc@murrayc.com>
297 * src/widgets/modest-folder-view.c: (update_model):
298 Do not unref the treemodel before we have finished with it.
299 This prevents a valgrind warning and an occasional crash at startup.
301 2007-06-06 Marcus Bauer <marcusb@openismus.com>
303 * libmodest-dbus-client/libmodest-dbus-client.h:
304 added libmodest_dbus_client_compose_mail()
305 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
307 added functions needed for SendAsMail() functionality
308 * src/maemo/modest-msg-edit-window.c:
309 (modest_msg_edit_window_attach_file_noninteractive):
310 non interactively attaching files to message edit window
311 * src/widgets/modest-msg-edit-window.h:
312 * tests/dbus_api/Makefile.am:
313 added test_compose_mail.c
314 * tests/dbus_api/test_compose_mail.c: (main):
316 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
318 * src/modest-account-view.c:
319 Fixed bug projects.maemo.org bug NB#59307
321 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
323 * src/maemo/easysetup/modest-easysetup-wizard.c:
324 (get_serverport_incoming), (on_before_next), (create_account):
325 * src/maemo/modest-account-settings-dialog.c:
326 (modest_account_settings_dialog_set_account_name):
327 * src/maemo/modest-maemo-utils.c:
328 (on_camel_account_get_supported_secure_authentication_status),
329 (on_camel_account_get_supported_secure_authentication),
330 (on_secure_auth_cancel),
331 (modest_maemo_utils_get_supported_secure_authentication_methods):
333 Implemented security authentication for settings and easysetup.
335 2007-06-05 Murray Cumming <murrayc@murrayc.com>
337 * src/maemo/modest-main-window.c: (create_details_widget):
338 Show the total size for memory card accounts too, instead of showing
339 the name again. Fixes bug projects.maemo.org bug NB#59307.
341 2007-06-05 Murray Cumming <murrayc@murrayc.com>
344 * src/modest-tny-simple-folder-store.c:
345 * src/modest-tny-simple-folder-store.h: Removed.
347 * src/modest-tny-local-folders-account.h
348 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
349 for the local-folders maildir, with an extra TnyMergedFolder containing
350 the folders of the per-account outbox store accounts.
351 * src/modest-tny-account-store.c: (get_server_accounts):
352 Add the outboxes to the special local folders account after creating it.
354 * src/modest-tny-account.c:
355 (modest_tny_account_new_for_local_folders): Create the derived
356 account when creating the main local-folders account.
358 * src/maemo/modest-main-window.c: (create_details_widget),
359 (modest_main_window_set_contents_style):
360 Adapted to the use of the derived account instead of the folder store.
362 * src/modest-ui-actions.c:
363 (modest_ui_actions_on_folder_selection_changed):
364 * src/modest-ui-dimming-rules.c:
365 (modest_ui_dimming_rules_on_new_folder):
366 * src/widgets/modest-folder-view.c: (text_cell_data),
367 (icon_cell_data), (filter_row), (update_model),
368 (get_cmp_rows_type_pos):
371 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
372 Do not get the priv struct, because no priv struct has been set,
373 to avoid a runtime warning.
375 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
376 #ifelse with #else, to fix a warning, to fix the build.
379 2007-06-05 Christian Kellner <ckellner@openismus.com>
381 * libmodest-dbus-client/libmodest-dbus-client.c:
382 Fix small typo in doc (why do you always see them
383 AFTER committing stuff?)
386 2007-06-05 Christian Kellner <ckellner@openismus.com>
388 * libmodest-dbus-client/libmodest-dbus-client.c:
389 (libmodest_dbus_client_search):
390 Initialize hit list with NULL. Also set folder list
391 to "" if NULL was supplied.
394 2007-06-03 Christian Kellner <ckellner@openismus.com>
396 * libmodest-dbus-client/libmodest-dbus-client.c:
397 (modest_search_hit_list_free):
398 Make it save to call it with NULL.
400 * src/dbus_api/modest-dbus-callbacks.c:
401 * src/modest-search.c:
402 Return full ModestSearchHits as the search result list not TnyHeader
403 since can't be around withouth the correspoding TnyFolder.
405 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
407 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
408 Added currently commented code to check for secure auth
410 * src/maemo/modest-account-settings-dialog.c: (on_response),
411 (save_configuration), (show_ok):
412 Fixed projects.maemo.org bugs NB #59248 and #59251
414 * src/maemo/modest-maemo-utils.c:
415 (on_camel_account_get_supported_secure_authentication_status),
416 (on_camel_account_get_supported_secure_authentication),
417 (modest_maemo_utils_get_supported_secure_authentication_methods):
418 * src/maemo/modest-maemo-utils.h:
419 Moved get_supported_secure_authentication() method here to be able
420 to use it from easysetup wizard.
422 * src/modest-pair.c: (on_pair_compare_as_string):
423 Should compare string with first part of pair and not
424 strcmp pairs which will crash.
426 * src/modest-protocol-info.c:
427 (modest_protocol_info_protocol_is_store):
428 * src/modest-protocol-info.h:
429 Added modest_protocol_info_get_auth_protocol_name()
431 2007-06-03 Armin Burgmeier <armin@openismus.com>
433 * src/modest-mail-operation.c:
434 (modest_mail_operation_get_msgs_full): Set priv->account also when
435 only retrieving a single message. This avoids a crash when canceling
438 (modest_mail_operation_notify_end): Do not explicitely remove the
439 operation from the queue but only emit the progress_changed signal.
440 The queue itself listens to that signal to remove the operation when
441 it is finished. This reduces coupling and removes a potential deadlock
442 when modest_mail_operation_notify_end() is called from the queue
443 itself. If that is a problem performance-wise, I would suggest to
444 implement a status-changed signal or something.
446 * src/modest-mail-operation-queue.c: Make sure to never call a
447 function from another file while the queue is locked. This (hopefully)
448 fixes another deadlock when exiting the application while retrieving
451 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
453 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
454 Fixed build if libogs is not available
456 2007-06-03 Christian Kellner <ckellner@openismus.com>
458 * libmodest-dbus-client/libmodest-dbus-client.h:
459 * libmodest-dbus-client/libmodest-dbus-client.c:
460 (libmodest_dbus_client_delete_message):
461 Implement deletion of messages (Client side).
463 (modest_search_hit_free),
464 (modest_search_hit_list_free):
465 Utility functions to free the result hits.
467 * src/dbus_api/modest-dbus-api.h:
468 * src/dbus_api/modest-dbus-callbacks.c:
470 (modest_dbus_req_handler):
471 Implement deletion of messages (Server side).
473 * tests/dbus_api/test_search.c: (main):
476 * tests/dbus_api/Makefile.am:
477 * tests/dbus_api/test_delete_message:
478 Add little test for the message deletion logic
480 2007-06-03 Armin Burgmeier <armin@openismus.com>
482 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
483 when the operation queue was not empty. projects.maemo.org bug
486 2007-06-03 Armin Burgmeier <armin@openismus.com>
488 * src/widgets/modest-account-view.c
489 (on_account_default_toggled): Toggle default account column
490 explicitely instead of waiting for gconf notification (which is
491 currently ignored). This should fix projects.maemo.org bug NB#56910
492 for now. It should probably be removed when gconf notifications are
495 2007-06-03 Christian Kellner <ckellner@openismus.com>
497 * libmodest-dbus-client/libmodest-dbus-client.c:
498 Removed debugging spew.
500 * src/dbus_api/modest-dbus-callbacks.c:
501 Added debugging info.
503 * src/modest-search.c:
504 (modest_search_all_accounts):
505 Use tny_account_store_get_accounts () on the account store
506 to get all accounts which is the way to get all accounts.
508 * tests/dbus_api/test_search.c: (main):
509 Make it possible to supply the search term on the command line.
511 2007-06-03 Christian Kellner <ckellner@openismus.com>
513 * libmodest-dbus-client/libmodest-dbus-client.c:
514 * libmodest-dbus-client/libmodest-dbus-client.h:
515 Implement searching for mesages over raw dbus. (Client side)
517 * src/dbus_api/Makefile.am:
518 * src/dbus_api/modest-dbus-api.h:
519 * src/dbus_api/modest-dbus-callbacks.c:
520 * src/dbus_api/modest-dbus-callbacks.h:
521 Search framework (Server side). Also implement on_idle_open_message().
523 * src/maemo/modest-platform.c: (modest_platform_init):
524 Prepare for raw dbus/osso rpc interaction.
526 * src/modest-search.h:
527 Changed minsize from unspecific guint to guint32.
529 * src/modest-search.c:
531 Added strange hack which magically made tnymail work.
533 (modest_search_folder),
534 (modest_search_account),
535 (modest_search_all_accounts):
536 Implement helper functions to search all accounts, specific account
539 * tests/dbus_api/Makefile.am:
540 * tests/dbus_api/test_open_message.c:
541 Read url to open from commandline.
543 * tests/dbus_api/test_search.c:
544 Implement small test for dbus search stuff
546 2007-06-02 Armin Burgmeier <armin@openismus.com>
548 * src/maemo/modest-account-settings-dialog.c: Changed window title to
549 include account type and account title. This fixes projects.maemo.org
552 * src/maemo/modest-account-view-window.c: Set a title for the window.
554 2007-06-02 Armin Burgmeier <armin@openismus.com>
556 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
557 incoming and outgoing server name based on email address and server
558 types as long as the names have not been edited manually. This fixes
559 projects.maemo.org bug NB#58671.
561 2007-06-02 Armin Burgmeier <armin@openismus.com>
563 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
564 server type cannot be changed in future to the incoming details page
565 when creating an account. This fixes projects.maemo.org bug NB#59029.
567 2007-06-02 Armin Burgmeier <armin@openismus.com>
569 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
570 and assigned max width chars so that they wrap instead of being
571 truncated. Fixes projects.maemo.org bug NB#56126.
573 2007-06-02 Armin Burgmeier <armin@openismus.com>
575 * src/maemo/modest-connection-specific-smtp-window.c: Add an
576 introductory note to the connection specific smtp servers dialog, as
577 section 8.12 of the email UI specification requires. This fixes
578 projects.maemo.org bug NB#59212.
580 2007-06-01 Murray Cumming <murrayc@murrayc.com>
582 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
583 Check for running mail operations, and offer to cancel them, as per the UI
584 spec. This fixes projects.maemo.org bug NB#59041 .
585 However, I suspect that tinymail may still use the network connection
586 in ways that we cannot detect or cancel. But it should at least adapt to
589 2007-06-01 Murray Cumming <murrayc@murrayc.com>
591 * src/modest-tny-account-store.c: (recreate_all_accounts),
592 (get_cached_accounts), (get_server_accounts): Do more sensible
593 ref-counting of the temporarily-cached outbox accounts list. This seems
594 to fix a crash when entering the password when the password was wrong.
596 2007-06-01 Murray Cumming <murrayc@murrayc.com>
598 * src/gnome/modest-main-window.c: (connect_signals):
599 * src/modest-tny-account-store.c: (get_password),
600 (modest_tny_account_store_alert): Added comments and clues and
601 commented-out code about how we currently fail to deal with connection
602 errors and wrong passwords, and how we should.
604 2007-06-01 Murray Cumming <murrayc@murrayc.com>
606 * src/widgets/modest-retrieve-combo-box.c:
607 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
608 This fixes projects.maemo.org bug NB#58472 .
610 2007-06-01 Murray Cumming <murrayc@murrayc.com>
612 * src/maemo/easysetup/modest-easysetup-wizard.c:
613 (create_page_complete_easysetup):
614 (create_page_complete_custom): Correct the last commit,
615 putting the correct sentences in the correct pages.
617 2007-06-01 Murray Cumming <murrayc@murrayc.com>
619 * src/maemo/easysetup/modest-easysetup-wizard.c:
620 (create_page_complete_custom): Show the second sentence of text
621 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
624 2007-06-01 Murray Cumming <murrayc@murrayc.com>
626 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
627 Set the leave-on-server conf key by default. This fixes
628 projects.maemo.org bug NB#59258 .
630 2007-06-01 Murray Cumming <murrayc@murrayc.com>
632 * src/maemo/modest-account-view-window.c:
633 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
634 logical ID for the confirmation messages. Fixed projects.maemo.org bug
637 2007-06-01 Murray Cumming <murrayc@murrayc.com>
639 * src/maemo/easysetup/modest-easysetup-wizard.c:
640 (create_caption_new_with_asterisk):
641 * src/maemo/modest-account-settings-dialog.c:
642 (create_caption_new_with_asterisk):
643 Uncomment the code to add the asterisk, because they are no longer in the
644 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
645 (update_incoming_server_title): Add an asterisk here too.
647 2007-06-01 Murray Cumming <murrayc@murrayc.com>
649 * src/maemo/modest-maemo-global-settings-dialog.c:
650 (current_connection): Check that we are even connected before trying to
651 get the current connection name, to prevent a warning.
653 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
654 Change the comments because tny_maemo_conic_device_connect() is now meant to
656 * src/modest-mail-operation.c:
657 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
658 make sure we have a connection and fail if we can't connect.
660 2007-05-31 Murray Cumming <murrayc@murrayc.com>
662 * src/maemo/modest-main-window.c:
663 (on_account_store_connecting_finished): Do not try to get the
664 connection ID if we are not really connected. I am surprised that
665 this signal handler is called when we are not connected.
667 2007-05-31 Murray Cumming <murrayc@murrayc.com>
669 * src/modest-error.h:
670 * src/modest-ui-actions.c:
671 (modest_ui_actions_get_msgs_full_error_handler):
672 Renamed an enum, added comments, added an enum
673 for retrieve-limit errors.
675 * src/modest-mail-operation.c: (foreach_add_item),
676 (internal_folder_observer_update), (update_account_thread),
677 (modest_mail_operation_get_msgs_full):
678 (modest_mail_operation_update_account),
679 Added comments about how this works, and some code that should
680 (but does not) check the retrieve-limit. See the TODO comment.
682 2007-05-31 Murray Cumming <murrayc@murrayc.com>
684 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
685 Initialize help_id to fix the build. Warnings are good.
687 2007-05-31 Murray Cumming <murrayc@murrayc.com>
689 * src/widgets/modest-hbox-cell-renderer.c:
690 (modest_hbox_cell_renderer_append):
691 * src/widgets/modest-vbox-cell-renderer.c:
692 (modest_vbox_cell_renderer_append):
693 Fix the last commit by doing an extra ref.
695 2007-05-31 Murray Cumming <murrayc@murrayc.com>
697 * src/widgets/modest-hbox-cell-renderer.c:
698 (modest_hbox_cell_renderer_append):
699 * src/widgets/modest-vbox-cell-renderer.c:
700 (modest_vbox_cell_renderer_append):
701 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
702 to fix the build with Maemo Bora.
703 However, there seems to be a remaining crash, probably due to reference
706 2007-05-30 Murray Cumming <murrayc@murrayc.com>
708 * src/modest-tny-account.c:
709 (modest_tny_account_new_for_local_folders):
710 Use hildon_file_system_info_async_new() to get a better name for
711 the memory card account, setting it as the account name.
712 The timing seems to work, but this is probably
713 not the best place to do this. See the TODO comment.
714 * src/maemo/modest-main-window.c: (create_details_widget):
715 * src/widgets/modest-folder-view.c: (text_cell_data):
716 Use the tny account name instead of hardcoding a name.
718 2007-05-30 Christian Kellner <ckellner@openismus.com>
720 * src/modest-search.c: (modest_search):
721 Correctly set part_search_func even if we have already parsed
722 the query and thus a valid OgsTextSearcher object.
724 2007-05-30 Christian Kellner <ckellner@openismus.com>
727 Search and check for libogs.
730 Incooparte the ogs build env.
732 * src/modest-mime-part-search-stream.c:
733 * src/modest-mime-part-search-stream.h:
734 Removed since we do the real searching now in modest-search.c.
736 * src/modest-search.c:
737 * src/modest-search.h:
738 Implement support for ogs. We use that if available and requested
739 and fall back to modest_text_utils_utf8_strcmp (). The search logic
740 should now handle the corner case when the search term is spread
741 across multiple reads.
742 Also the logic in modest_search () was corrected to search all
743 requested fields until one is found.
745 2007-05-30 Murray Cumming <murrayc@murrayc.com>
747 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
750 * src/modest-init.c: Made modest_init_local_folders() take a
751 path and be public so we can iniitialize maildir folders on
754 * src/modest-local-folder-info.h:
755 * src/modest-local-folder-info.c:
756 (modest_local_folder_info_get_maildir_path): Add a path parameter.
758 * src/modest-tny-account.c:
759 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
760 still means the standard local-folders path on the local volume.
762 * src/modest-tny-account-store.c:
763 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
764 signal so we can detect mount/unmount of the MMC1 card, and do an update of
765 all accounts when that happens.
766 (get_server_accounts): If the MMC1 card is mounted, create a store account for
767 this too, so it shows up in the treeview.
769 2007-05-28 Murray Cumming <murrayc@murrayc.com>
771 * src/maemo/modest-maemo-global-settings-dialog.c:
772 (current_connection):
773 * src/widgets/modest-global-settings-dialog.c:
774 (current_connection_default):
775 Use the enum values instead of 0, 1 and -1,
776 to make the code clearer.
778 * src/modest-account-mgr-helpers.c:
779 (modest_account_mgr_get_connection_specific_smtp): Make this code
782 * src/modest-runtime.h:
783 * src/modest-runtime.c:
784 Added modest_runtime_remove_all_send_queues().
785 * src/maemo/modest-main-window.c:
786 (on_account_store_connecting_finished): Recreate the send queues,
787 using the appropriate transport accounts for this new connection.
788 Some futher adapting might be needed if the old send queues are not
789 automatically stopped at this point.
791 * src/modest-tny-account-store.c: (get_server_accounts):
792 Create the connection-specific transport accounts, so that they can
793 be found later by their ID.
795 * src/modest-tny-account.h:
796 * src/modest-tny-account.c:
797 Added modest_tny_account_new_from_server_account_name().
798 modest_tny_account_new_from_server_account(): Do not create the
799 send queues here, because they will be
800 recreated anyway when the connection changes for the first time.
802 2007-05-28 Murray Cumming <murrayc@murrayc.com>
804 * src/modest-local-folder-info.h:
805 * src/modest-local-folder-info.c:
806 (modest_per_account_local_outbox_folder_info_get_maildir_path),
807 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
808 tbox_folder): Take a modest account name instead of a server TnyAccount,
809 so we can have per-modest-account rather than per-transport-account
811 We must make sure that we change or recreate the exisitng send queues
812 when the connection changes for connection-specific transport accounts.
814 * src/modest-tny-account-store.c:
815 (create_per_account_local_outbox_folders): Create outboxed per modest
816 account, not per transport account.
818 * src/modest-tny-account.h:
819 * src/modest-tny-account.c:
820 (modest_tny_account_get_special_folder): For outboxes, get the
821 parent modest account name. The account is ignored for other folders.
822 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
823 modest account name rather than a server TnyAccount.
825 2007-05-25 Murray Cumming <murrayc@murrayc.com>
827 * src/modest-tny-account.c:
828 (modest_tny_account_new_from_server_account):
829 Call modest_runtime_get_send_queue() immediately after creating transport
830 accounts, so that they start trying to send email from the outbox as soon
831 as possible at startup. This is probably what we want.
833 * src/modest-mail-operation.c: (update_account_thread):
834 * src/modest-runtime.c: (modest_runtime_get_send_queue):
835 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
836 * src/modest-tny-send-queue.h:
837 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
838 (modest_ui_actions_on_send):
839 Added comments about how sending works, though it needs some more work.
841 2007-05-25 Murray Cumming <murrayc@murrayc.com>
843 * src/modest-tny-account.c:
844 (modest_tny_account_get_special_folder): Add TODO because this fails when
846 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
847 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
848 Do not try to show this window when there is no active account. The UI
849 specs does not tell us what to do in this case.
851 2007-05-24 Murray Cumming <murrayc@murrayc.com>
855 * src/maemo/Makefile.am:
856 * src/widgets/Makefile.am: Some dist fixes.
858 2007-05-24 Murray Cumming <murrayc@murrayc.com>
860 * src/maemo/modest-connection-specific-smtp-window.c:
861 (on_button_edit): Make the code clearer, to prevent a double free.
863 2007-05-24 Murray Cumming <murrayc@murrayc.com>
865 * src/maemo/modest-account-settings-dialog.c:
866 (modest_account_settings_dialog_set_account_name),
867 Check the connection-specific smtp servers checkbox if there are any.
869 * src/maemo/modest-connection-specific-smtp-edit-window.c:
870 (modest_connection_specific_smtp_edit_window_init):
871 Start with a suitable port number.
873 * src/modest-account-mgr-helpers.h:
874 * src/modest-account-mgr-helpers.c: Added
875 modest_account_mgr_get_has_connection_specific_smtp().
877 (modest_account_mgr_set_connection_specific_smtp),
878 (modest_account_mgr_remove_connection_specific_smtp),
879 (modest_account_mgr_get_has_connection_specific_smtp),
880 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
881 connection-specific smtp server accounts in the account, rather than
882 the server account conf dir.
884 This fixes bug projects.maemo.org bug NB#58263 .
886 * src/modest-tny-account-store.c:
887 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
888 if there are no server accounts yet, to prevent an infinite loop when there
889 are no accounts. Document that one must be called before the other.
891 2007-05-24 Murray Cumming <murrayc@murrayc.com>
893 * src/modest-account-mgr-helpers.c:
894 (modest_account_mgr_get_default_account): Make sure that at least
895 one account is always the default, if there are any enabled accounts.
896 This is just a sanity check that shouldn't be necessary.
898 * src/modest-account-mgr-priv.c:
899 (_modest_account_mgr_account_from_key): Unescape the conf key to
900 get the real account name. For instance, this is an issue if a space
901 was in the account name, which can happen because the account name
902 is generated from the display name.
903 (_modest_account_mgr_get_account_keyname): Always escape the
905 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
906 Unescape the conf keys to get the real account names.
908 For instance, previously the is-default radio button in the accounts
909 list was not checked for any accounts at first. This fixes that,
910 and might fix several similar bugs.
912 2007-05-23 Murray Cumming <murrayc@murrayc.com>
914 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
915 Removed some debug printfs.
917 2007-05-23 Murray Cumming <murrayc@murrayc.com>
919 Modest on-disk outbox directories are now here, for instance:
920 $HOME/.modest/outboxes/<account-id-1>/outbox
921 $HOME/.modest/outboxes/<account-id-2>/outbox
923 $HOME/.modest/local-folders/outbox
924 so we can have a separate outbox for each account.
925 But they are shown as one outbox in the GtkTreeView, by using a
926 TnyMergeFolder in a ModestTnySimpleFolderStore.
929 * src/modest-tny-simple-folder-store.c:
930 * src/modest-tny-simple-folder-store.h:
931 Added ModestTnySimpleFolderStore, used to contain folders from
932 other folder stores, such as other accounts.
934 * src/modest-tny-outbox-account.h:
935 * src/modest-tny-outbox-account.c:
936 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
937 used for the per-account local outbox folders.
939 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
940 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
941 only use this (internally) now for the non-outbox local folders.
944 * src/modest-init.c: Added modest_init_one_local_folder(), for
945 setting up the directory structure for each local folder.
947 * src/modest-local-folder-info.c:
948 (modest_per_account_local_outbox_folder_info_get_maildir_path),
949 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
951 * src/modest-local-folder-info.h:
952 * src/modest-tny-account-store.c: (on_account_removed),
953 (on_account_changed), (create_per_account_local_outbox_folders),
954 (get_server_accounts), (modest_tny_account_store_get_accounts),
955 (modest_tny_account_store_get_tny_account_by_account),
956 (modest_tny_folder_store_is_virtual_local_folders):
958 * src/modest-tny-account.h:
959 * src/modest-tny-account.c:
960 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
961 to create an on-disk per-account local outbox folder for each
963 (create_per_account_local_outbox_folders): Create a local outbox folder
964 for each transport account.
965 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
966 for all local folders.
968 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
969 instead of using g_object_get/set() directly. It is clearer.
971 (modest_tny_folder_store_get_message_count),
972 (modest_tny_folder_store_get_local_size
973 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
974 because we now use these with non-acount folder stores.
976 (modest_tny_account_get_special_folder),
977 (modest_tny_account_new_from_server_account),
978 (modest_tny_account_new_from_account):
979 (recurse_folders): Adjust to the new outbox system.
981 * src/modest-tny-folder.h:
982 * src/modest-tny-folder.c:
983 (modest_tny_folder_is_local_folder),
984 (modest_tny_folder_get_local_folder_type),
985 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
987 * src/widgets/modest-main-window.h:
988 * src/maemo/modest-main-window.c: (create_details_widget),
989 (modest_main_window_set_contents_style): Show details for any folder store,
992 (modest_tny_folder_get_rules):
993 Remove the const. C does not support constness enough for this.
995 * src/modest-ui-actions.c:
996 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
997 make all outboxes appear as one, in the usual local-folders tree node.
999 (set_active_account_from_tny_account),
1000 (modest_ui_actions_on_folder_selection_changed):
1001 * src/widgets/modest-folder-view.c: (text_cell_data),
1002 (icon_cell_data), (filter_row),
1003 (add_account_folders_to_merged_folder),
1004 (add_account_folders_to_simple_folder_store), (),
1005 (get_cmp_rows_type_pos), (cmp_rows),
1006 (modest_folder_view_set_account_id_of_visible_server_account):
1007 Adjust to the new outbox system, using generic folder stores and folders
1008 in the GtkTreeModel.
1010 2007-05-23 Christian Kellner <ckellner@openismus.com>
1012 * src/modest-mail-operation.c:
1013 (modest_mail_operation_update_account):
1014 Use info->max_size instead of unintialized local var [small
1015 build fix]. (Added TODO to review that change since I don't
1018 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1020 * libmodest-dbus-client/libmodest-dbus-client.c:
1021 (libmodest_dbus_client_compose_mail): function added
1022 * src/dbus_api/modest-dbus-api.h:
1023 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1024 (on_compose_mail): Implementation of the SendAsMail functionality
1026 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1028 * src/modest-account-mgr.c:
1029 (modest_account_mgr_add_server_account): Set the secure-connection
1030 conf key for transport accounts as well as store accounts. I don't know
1031 why the if was there. For instance, this makes sure that we use SSL
1032 for the gmail preset from the easysetup wizard.
1034 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1036 * src/gnome/modest-main-window.c:
1037 (on_account_store_connecting_finished), (connect_signals):
1038 * src/maemo/modest-main-window.c:
1039 (on_account_store_connecting_finished), (connect_signals),
1040 (modest_main_window_new):
1041 Handle TnyAccountStore::connecting-finished instead of
1042 TnyDevice::connection-changed, because we cannot actually perform
1043 operations on accounts until TnyAccountStore has itself responded to
1044 the TnyDevice::connection-changed signal. This prevents a GError from
1046 Do not try to update at startup, because we (at least on scratchbox)
1047 already do an update at startup when the device goes online.
1048 This prevents a GError from tinymail.
1049 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1050 Added TODO about stopping simultaneous operations.
1052 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1054 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1055 * src/modest-mail-operation-queue.c:
1056 (modest_mail_operation_queue_remove):
1057 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1058 about where they happened.
1060 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1062 * src/modest-ui-actions.c:
1063 (modest_ui_actions_on_password_requested): Make sure that the remember
1064 output parameter is always TRUE.
1066 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1068 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1069 Show a OK/Cancel dialog if the error is a question, though we still do not
1070 know anything more about what we are asking the user.
1071 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1072 Fix an uninitialized variable (helper). This is a logic error, however.
1074 2007-05-21 Christian Kellner <ckellner@openismus.com>
1076 * src/modest-search.h:
1077 Correct bit shifting in the ModestSearchFlags enum.
1079 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-tny-account.c:
1082 (modest_tny_account_new_from_server_account): Do not use the lsub and
1083 check-all hard-coded IMAP options when using POP.
1085 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1087 * src/modest-tny-account.c:
1088 (modest_tny_account_new_from_server_account):
1089 Use NULL for the secure-auth method for POP when Password auth has been
1090 specified by the user, as we already do for IMAP. "auth=Login" causes
1091 an error from camel or the server.
1093 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1095 * src/maemo/modest-account-settings-dialog.c:
1096 (create_page_account_details),
1097 (modest_account_settings_dialog_set_account_name):
1098 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1099 for the leave-on-server checkbox, rathr than just the checkbox, when
1100 the protocol is not POP.
1102 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1104 * src/widgets/modest-account-view.c:
1105 * src/widgets/modest-account-view.h:
1106 Added modest_account_view_select_account() which will be useful later
1107 to asynchronously re-select the edited account.
1109 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1111 * src/maemo/modest-account-settings-dialog.c:
1112 (modest_account_settings_dialog_set_account_name):
1113 Automatically choose the port numbers based on the secure authentication
1114 methods, if they have not been chosen before.
1115 This fixes projects.maemo.org bug NB#56273 .
1117 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1119 * src/maemo/modest-main-window-ui.h:
1120 * src/modest-ui-actions.c:
1121 * src/modest-ui-actions.h:
1122 Connect the Tools/SMTP Servers menu item to
1123 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1124 SMTP servers dialog, as in the UI specification and saves changes when it
1125 is closed. This fixed projects.maemo.org bug NB#56305 .
1127 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1129 * src/maemo/modest-connection-specific-smtp-window.c:
1130 (modest_connection_specific_smtp_window_init):
1131 Use gtk_window_set_default_size() to make this window big enough, so
1132 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1134 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1136 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1137 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1138 (modest_connection_specific_smtp_edit_window_init),
1139 Do not try to connect to a combobox signal before the combobox exists.
1140 This fixes the cras in projects.maemo.org bug NB#56288 .
1141 (modest_connection_specific_smtp_edit_window_get_settings):
1142 Remove the server_account_name parameter which was being checked for NULL
1143 though it was not used.
1145 * src/maemo/modest-connection-specific-smtp-window.c:
1146 (modest_connection_specific_smtp_window_fill_with_connections),
1147 (on_button_edit), (modest_connection_specific_smtp_window_init):
1148 Correct the number of treemodel columns to prevent a warning.
1149 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1150 libconic does not work.
1152 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1154 * src/modest-tny-account.c:
1155 (modest_tny_account_new_from_server_account):
1156 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1157 SMTP when "None" was chosen by the user. However, with my SMTP server that
1158 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1161 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1163 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1164 to explain the memory management issue with the ID in the ModestPair.
1166 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1167 (add_sending_page), (modest_account_assistant_finalize):
1168 * src/gnome/modest-gnome-global-settings-dialog.c:
1169 (create_updating_page), (create_composing_page):
1170 * src/gnome/modest-msg-edit-window.c: (get_transports),
1171 (init_window), (modest_msg_edit_window_finalize),
1172 (modest_msg_edit_window_get_msg_data):
1173 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1174 * src/gnome/modest-transport-widget.c:
1175 (modest_transport_widget_finalize), (smtp_configuration):
1176 * src/maemo/modest-maemo-global-settings-dialog.c:
1177 (create_updating_page), (create_composing_page):
1178 * src/maemo/modest-msg-edit-window.c: (get_transports),
1179 (init_window), (modest_msg_edit_window_finalize),
1180 (modest_msg_edit_window_get_msg_data),
1181 (modest_msg_edit_window_free_msg_data):
1182 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1183 (modest_store_widget_finalize):
1184 * src/maemo/modest-transport-widget.c:
1185 (modest_transport_widget_finalize), (smtp_configuration):
1186 * src/modest-main.c: (send_mail):
1187 * src/widgets/modest-combo-box.h:
1188 * src/widgets/modest-global-settings-dialog-priv.h:
1189 * src/widgets/modest-global-settings-dialog.c:
1190 (modest_global_settings_dialog_finalize):
1191 * src/widgets/modest-msg-edit-window.h:
1192 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1193 as long as the combo box, to prevent use of freed memory for the ID.
1195 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1197 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1198 get_accounts(), to make this clearer. Do not check for the enabled gconf
1199 key, because we do not use this for server accounts (at least, not yet).
1200 This allows us to send email again.
1202 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1204 * src/maemo/modest-platform.c:
1205 (on_modest_conf_update_interval_changed), (modest_platform_init):
1206 Only respond to this particular key change. All these strcmp()s cannot be
1209 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1211 * src/maemo/modest-maemo-global-settings-dialog.c:
1212 (current_connection): Prevent a crash in scratchbox when
1213 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1214 * src/maemo/modest-platform.c:
1215 (on_modest_conf_update_interval_changed), (modest_platform_init):
1216 Get the update interval from gconf and reset it when the gconf key changes.
1218 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1220 * src/modest-protocol-info.c:
1221 * src/modest-protocol-info.h: Adde enum-specific get functions,
1222 instead of using a ModestProtocolType enum parameter.
1224 * src/gnome/modest-account-assistant.c:
1225 * src/gnome/modest-store-widget.c:
1226 * src/gnome/modest-store-widget.h:
1227 * src/gnome/modest-transport-widget.c:
1228 * src/gnome/modest-transport-widget.h:
1229 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1230 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1231 * src/maemo/easysetup/modest-easysetup-wizard.c:
1232 * src/maemo/modest-account-settings-dialog.c:
1233 * src/maemo/modest-account-settings-dialog.h:
1234 * src/maemo/modest-store-widget.c:
1235 * src/maemo/modest-store-widget.h:
1236 * src/maemo/modest-transport-widget.c:
1237 * src/maemo/modest-transport-widget.h:
1238 * src/modest-account-mgr-helpers.c:
1239 * src/modest-account-mgr-helpers.h:
1240 * src/modest-account-mgr.c:
1241 * src/modest-account-mgr.h:
1242 * src/modest-tny-account.c:
1243 * src/modest-tny-folder.c:
1244 * src/widgets/modest-account-view.c:
1245 * src/widgets/modest-retrieve-combo-box.c:
1246 * src/widgets/modest-retrieve-combo-box.h:
1247 * src/widgets/modest-secureauth-combo-box.c:
1248 * src/widgets/modest-serversecurity-combo-box.c:
1249 * src/widgets/modest-serversecurity-combo-box.h:
1250 * tests/check_account-mgr.c:
1251 Use the specific functions, and use the re-renamed enum values for GNOME too.
1253 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1255 * src/modest-pair.h:
1256 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1257 so we can get the second based on the first.
1259 * src/maemo/modest-account-settings-dialog.h:
1260 * src/maemo/modest-account-settings-dialog.c:
1261 Added get_supported_secure_authentication_methods(), though it is mostly
1262 commented-out for now until the necessary API is committed to tinymail.
1263 (modest_account_settings_dialog_set_account_name),
1264 (save_configuration): Request the supported authentication methods from the
1265 server, so we can choose a working method.
1267 * src/modest-tny-account-store.h:
1268 * src/modest-tny-account-store.c:
1269 (modest_tny_account_store_get_session): Rename from
1270 tny_account_store_get_session().
1272 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1274 * src/modest-protocol-info.h: Split the ModestProtocol enum
1275 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1276 There was no need to have these unrelated values in one enum.
1278 * src/: many files: Adapted to changed enum. This makes the code a bit
1279 clearer, and the compiler could catch some errors.
1281 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1283 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1284 Show the detailed internal camel error message when an error happens
1285 during the configuration, so that our testers can give us more clues.
1286 For instance, in projects.maemo.org bug NB#56910 .
1288 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1290 * src/modest-tny-account.c:
1291 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1292 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1294 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1296 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1297 * src/maemo/modest-account-settings-dialog.c:
1298 (modest_account_settings_dialog_set_account_name),
1299 (save_configuration): For the incoming secure authentication checkbox,
1300 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1301 the UI specification. PLAIN does not seem to be supported for most IMAP
1302 servers anyway, and I am not sure what it would mean.
1303 However, we probably need to discover which of the secure-authentication
1304 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1305 * src/modest-account-mgr-helpers.c:
1306 (modest_account_mgr_get_server_account_data):
1308 * src/modest-tny-account.c:
1309 (modest_tny_account_new_from_server_account):
1310 Use tny_account_set_mech() to set secure-authentication methods,
1311 with some special-casing for IMAP, based on my observations of how
1314 * src/modest-account-mgr-helpers.h:
1315 * src/modest-account-mgr.c:
1316 * src/modest-defs.h: Comment that the URI is only used for local folders.
1318 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1320 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1321 parameter const, just to be neat.
1322 * src/modest-text-utils.c: (modest_text_utils_inline):
1323 End g_strconcat() with NULL, as its documentation says. This is almost
1324 certainly the cause of my crash at startup on the device. Interestingly,
1325 valgrind doesn't tell us about these errors.
1327 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1329 * scripts/build-packages: Added more precise comments about how to use
1330 this script, though I still get this error:
1331 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1332 error building tinymail
1334 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1336 * src/maemo/modest-main-window.c: (on_account_update):
1337 Very slight cleanup, hoping to make it simpler to discover what causes
1338 a crash here sometimes.
1340 * src/modest-tny-account.c:
1341 (modest_tny_account_new_from_server_account): Set the port. Added
1342 comments about the options and a TODO comment because I need to find out
1343 how to specify the secure authentication method.
1345 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1347 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1348 changed CFlags paths form modest to libmodest
1350 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1352 * src/modest-account-mgr-helpers.c:
1353 (modest_account_mgr_get_server_account_data),
1354 (modest_account_mgr_free_server_account_data):
1355 * src/modest-account-mgr-helpers.h:
1356 * src/modest-account-mgr.c:
1357 (modest_account_mgr_add_server_account):
1358 * src/modest-defs.h:
1359 * src/modest-tny-account.c:
1360 (modest_tny_account_new_from_server_account):
1361 Determine the options for tny_camel_account_add_option() here,
1362 based on the settings, rather than storing them directly in gconf.
1364 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1366 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1367 Show a more friendly error dialog now that we expect (from the tinymail
1368 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1370 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1372 * src/maemo/modest-main-window.c: (on_account_update): Check that
1373 account_name is not NULL, to prevent a crash at startup that I am
1374 seeing on the N800. I do wonder why it is NULL.
1376 * src/maemo/easysetup/modest-easysetup-wizard.c:
1377 (create_page_user_details):
1378 * src/maemo/modest-account-settings-dialog.c:
1379 (create_page_user_details), (create_page_outgoing):
1380 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1381 (modest_connection_specific_smtp_edit_window_init):
1382 * src/modest-ui-actions.c:
1383 (modest_ui_actions_on_password_requested):
1384 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1385 might do something useful with the on-screen keyboard.
1387 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1389 * src/maemo/modest-main-window.c: (on_account_update):
1390 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1391 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1393 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1395 * src/modest-tny-account-store.c: (on_account_changed):
1396 Correct the signature of this signal handler.
1398 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1400 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1401 Show a HildonNote instead of a GtkDialog for Maemo.
1403 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1405 * src/widgets/modest-account-view.h:
1406 * src/widgets/modest-account-view.c: (on_account_changed),
1407 (on_account_removed). Added a boolean flag, set/unset by
1408 modest_account_view_block_conf_updates(),
1409 modest_account_view_unblock_conf_updates() to prevent unnecessary
1410 updates, but this is not very useful because the gconf notifications are
1411 so delays (maybe only on Maemo Bora).
1412 So auto-updating is turned off, and these functions do an explicit
1413 update when necessary.
1414 However, something else is still doing too much work when adding/removing
1415 accounts, probably in another part of the application.
1417 * src/maemo/modest-account-view-window.c:
1418 (on_delete_button_clicked), (on_edit_button_clicked),
1419 (on_new_button_clicked): Use the new functions.
1421 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1423 * src/modest-account-mgr-helpers.c:
1424 (modest_account_mgr_set_first_account_as_default):
1425 Sort the list of names alphabetically-by-title, so we choose the first one
1427 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1428 alphabetically by the title.
1430 This fixes projects.maemo.org bug NB#56418 .
1432 * src/modest-account-mgr-priv.c:
1433 (_modest_account_mgr_account_from_key):
1434 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1435 avoid a valgrind error, and possible random behaviour.
1437 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1439 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1440 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1441 tinymail documentation to say that this can be expected.
1442 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1443 pretty, and should not happen, but I would prefer to know when it does.
1445 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1447 * configure.ac: When using the older hildon version, probably on Bora,
1448 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1450 * src/widgets/modest-attachment-view.c:
1451 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1454 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1456 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1457 Implemented the prototype. Can be tested with
1458 tests/dbus_api/test_open_message:
1460 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1462 * src/modest-tny-account-store.c:
1463 (modest_tny_account_store_instance_init), (get_password):
1464 * src/modest-ui-actions.c:
1465 (modest_ui_actions_on_password_requested):
1466 Do not store the password in gconf, because this function is called
1467 for non-remembered passwords. Actually use the cached (in the hash map)
1468 password instead of releasing it.
1469 The password will now not be remembered if it is asked via the protected
1470 password dialog, as per the UI spec.
1472 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1474 * src/modest-defs.h:
1475 * src/modest-account-mgr-helpers.h:
1476 * src/modest-account-mgr-helpers.c:
1477 Added modest_server_account_get_username_has_succeeded(),
1478 modest_server_account_set_username_has_succeeded().
1479 (modest_server_account_set_username),
1480 Reset the has-succeeded flag if the username changes.
1482 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1483 * src/maemo/modest-connection-specific-smtp-window.c:
1484 (modest_connection_specific_smtp_window_save_server_accounts):
1485 Use modest_server_account_set_username() instead of using
1486 modest_conf_set_string() directly, so that the has-succeeded flag is always
1489 * src/modest-ui-actions.c:
1490 (modest_ui_actions_on_password_requested): Dim the username entry if
1491 the username has ever worked, as per the UI spec.
1493 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1495 * src/modest-tny-account-store.c: (get_password):
1496 * src/modest-ui-actions.c:
1497 (modest_ui_actions_on_password_requested):
1498 Allow the username to be changed too, though there is more work to
1499 be done on exactly how this behaves.
1501 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1503 * src/modest-account-mgr-helpers.h:
1504 * src/modest-account-mgr-helpers.c:
1505 Added modest_account_mgr_get_display_name(),
1506 modest_server_account_get_username(),
1507 modest_server_account_set_username(),
1508 modest_server_account_set_password(),
1509 modest_server_account_get_hostname() functions so we do not need to
1510 use the conf API directly.
1512 * src/maemo/modest-main-window.c: (connect_signals):
1513 Actually connect ot the ModestAccountStore::request-password signal,
1514 so that we show the dialog when the password is requested by Tinymail,
1515 for isntance if it is empty.
1517 * src/modest-marshal.list:
1518 * src/modest-tny-account-store.c:
1519 (modest_tny_account_store_class_init), (get_password),
1520 (modest_tny_account_store_alert):
1521 * src/modest-tny-account-store.h:
1522 * src/modest-ui-actions.h:
1523 * src/modest-ui-actions.c:
1524 (modest_ui_actions_on_password_requested):
1525 Change the signal parameters, so it is obvious that we are providing
1526 the non human-readable server name, and receiving both the username
1527 and password, though changing of the username is not yet implemented.
1528 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1529 for the GNOME version.
1531 This should fix the projects.maemo.org bug NB#56209, though it does not
1532 work on Bora, because the gconf_client_get() for the password fails
1533 immediately after we save it with gconf_client_set().
1535 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1538 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1539 caused an undefined symbol error:
1540 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1542 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1544 * src/modest-tny-account-store.c:
1545 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1546 using a GError instead of a string message, so we can translate it in
1549 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1551 * src/maemo/modest-address-book.c:
1552 (modest_address_book_check_names):
1553 * src/maemo/modest-msg-view-window.c:
1554 (modest_msg_view_window_clipboard_owner_change):
1555 * src/modest-init.c: (modest_init_init_ui):
1556 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1557 (update_folders_cb), (modest_mail_operation_update_account):
1558 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1559 (modest_ui_actions_on_msg_attachment_clicked),
1560 (modest_ui_actions_on_msg_recpt_activated):
1561 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1562 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1563 (modest_msg_view_search_next):
1564 * src/widgets/modest-recpt-editor.c:
1565 (modest_recpt_editor_on_button_release_event),
1566 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1567 g_message(). At this point we should only be seeing interesting errors on
1568 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1570 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1572 (modest_wizard_dialog_force_title_update):
1573 * src/maemo/easysetup/modest-wizard-dialog.h:
1574 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1575 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1576 can update the title when appropriate. Otherwise the title is wrong if the
1577 pages are added after adding the notebook to the dialog.
1578 This must be a problem in HildonWizardDialog too.
1579 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1581 * src/maemo/easysetup/modest-easysetup-wizard.c:
1582 (create_subsequent_customsetup_pages),
1583 (create_subsequent_easysetup_pages):
1584 Call modest_wizard_dialog_force_title_update() so that the title is
1585 correct even with GTK+ < 2.10.
1586 This fixes projects.maemo.org bug NB#56145 .
1588 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1590 * src/maemo/modest-platform.c:
1591 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1592 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1595 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1597 * src/widgets/modest-window.h:
1598 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1599 and modest_window_save_state(), which invokes it.
1601 * src/widgets/modest-window-mgr.h:
1602 * src/widgets/modest-window-mgr.c:
1603 Added modest_window_mgr_save_state_for_all_windows(), which calls
1604 the save_state vfunc on all registered windows, if implemented.
1606 * src/gnome/modest-msg-edit-window.c:
1607 * src/gnome/modest-msg-view-window.c:
1608 * src/maemo/modest-msg-edit-window.c:
1609 * src/maemo/modest-msg-view-window.c:
1610 * src/maemo/modest-main-window.c:
1611 Specify the existing save_settings functions as implementations of
1612 ModestWindow::save_state_func().
1614 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1615 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1616 enabling hibernation, for instance.
1618 We may need to do the same thing for restoring settings.
1621 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1623 * src/widgets/modest-window-mgr.c:
1624 * src/widgets/modest-window-mgr.h:
1625 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1626 modest_window_mgr_get_hibernation_is_prevented().
1628 * src/maemo/modest-main-window.c:
1629 (on_hildon_program_is_topmost_notify): Prevent hibernation
1630 (possible when the application goes to the background in the WM),
1631 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1633 * src/maemo/easysetup/modest-easysetup-wizard.c:
1634 (modest_easysetup_wizard_dialog_init):
1635 * src/maemo/modest-account-settings-dialog.c:
1636 (modest_account_settings_dialog_init):
1637 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1638 (modest_connection_specific_smtp_edit_window_init):
1639 * src/maemo/modest-connection-specific-smtp-window.c:
1640 (modest_connection_specific_smtp_window_init):
1641 * src/maemo/modest-signature-editor-dialog.c:
1642 (modest_signature_editor_dialog_init):
1643 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1644 prevent hibernation while any of these account settings dialogs are open.
1646 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1648 * src/maemo/Makefile.am:
1649 * src/maemo/modest-osso-state-saving.c:
1650 * src/maemo/modest-osso-state-saving.h: Added
1651 modest_osso_load_state() and modest_osso_save_state() though they do
1652 nothing now. They should iterate through all the open windows and load/save
1654 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1655 save state when closing.
1657 * src/maemo/modest-main-window.c:
1658 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1659 Add a notification handler for the HildonProgram::is-topmost property,
1660 so we can allow hibernation when the application goes into the background.
1661 But we still need to detect when the accounts setup windows are open so
1662 we can stop hibernation when they are open.
1663 To do this, I also added the main window the HildonProgram. This might have
1664 other side-effects/benefits, and should maybe be done for other windows.
1666 * src/maemo/modest-osso-autosave-callbacks.h:
1667 * src/maemo/modest-osso-autosave-callbacks.c:
1668 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1669 though it does not do anything yet, and we might never need this to do
1670 anything. For instance, we already save drafts.
1672 * src/maemo/modest-platform.c: (modest_platform_init):
1673 Specify the libosso auto-save callback.
1675 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1677 * src/maemo/modest-platform.c:
1678 (modest_platform_set_update_interval):
1679 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1680 aparently stays valid between application instances, so we can use this
1681 to remove and reset it later. According to a maemo-developers email from
1684 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1686 * configure.ac: Depend on libalarm for Maemo.
1688 * src/dbus_api/modest-dbus-api.h:
1689 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1690 (on_send_receive), (modest_dbus_req_handler):
1691 Handle a SEND_RECEIVE D-Bus method.
1693 * libmodest-dbus-client/libmodest-dbus-client.c:
1694 (libmodest_dbus_client_send_and_receive):
1695 * libmodest-dbus-client/libmodest-dbus-client.h:
1696 Add C convenience functions for calling the new D-Bus method.
1698 * src/modest-platform.h:
1699 * src/gnome/modest-platform.c:
1700 * src/maemo/modest-platform.c:
1701 Added modest_platform_set_update_interval(), which uses the
1702 alarmd API on Maemo.
1703 (modest_platform_init),
1704 Call modest_platform_set_update_interval(), using a hard-coded
1705 interval for now (until the global settings dialog is implemented),
1706 though I am not sure that this makes sense yet.
1708 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1710 * src/dbus_api/modest-dbus-callbacks.c:
1711 (modest_osso_cb_hw_state_handler):
1712 * src/dbus_api/modest-dbus-callbacks.h:
1713 * src/maemo/modest-platform.c: (modest_platform_init):
1714 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1715 in case this has some effect on the ability for Maemo to ping the
1718 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1720 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1721 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1722 warning. It is probably a logic error, but I need to fix the build.
1724 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1726 * src/modest-account-mgr.h:
1727 * src/modest-account-mgr.c:
1728 (modest_account_mgr_account_names): Add a gboolean enabled_only
1729 parameter, so we can get lists of onlt the enabled accounts.
1731 (modest_account_mgr_add_account),,
1732 (modest_account_mgr_account_with_display_name_exists):
1733 * src/maemo/modest-msg-edit-window.c: (get_transports):
1734 * src/modest-account-mgr-helpers.c:
1735 (modest_account_mgr_set_first_account_as_default):
1736 * src/modest-init.c: (init_default_account_maybe):
1737 * src/modest-tny-account-store.c: (get_accounts):
1738 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1739 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1740 * tests/check_account-mgr.c: (START_TEST):
1741 Provide the extra parameter, as appropriate.
1743 * src/widgets/modest-account-view.c: (update_account_view):
1744 Do not show disabled accounts (meaning that there is no way to
1745 enable/disable accounts in the UI (the feature is not in our UI
1746 specification), so we can use this internally only to mark unfinished
1747 or temporary account data.
1749 * src/maemo/easysetup/modest-easysetup-wizard.c:
1750 (create_account): Add boolean enable parameter, so we can specify FALSE
1751 to create the temporary account.
1752 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1753 (on_before_next): When finishing, when there is a temporary account, just
1755 Also, use a timeout to delay the showing of the dialog until gconf is likely
1756 to return correct information, due to a maemo gconf bug that is fixed in
1757 osso 1.1, but not yet in Bora.
1758 However, the dialog stays on screen after it is destroyed.
1760 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1761 for invalid data when cancelling. Use a hildon note instead of a dialog
1762 to complain about invalid data. Do not show the account-saved note if the
1763 account is disabled (a temporary account that will not really be saved for use
1766 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1768 * src/modest-account-mgr-helpers.h:
1769 * src/modest-account-mgr-helpers.c:
1770 Added modest_account_mgr_unset_default_account(),
1771 Added modest_account_mgr_set_first_account_as_default().
1773 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1774 If it was the default account, unset the default account name.
1776 * src/maemo/modest-account-view-window.c:
1777 (on_delete_button_clicked): If it was the default account,
1778 set the first remaining account as the default instead.
1780 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1781 a NULL account or a NULL default account, to prevent a crash. This should
1782 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1785 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1787 * src/widgets/modest-recpt-editor.c:
1788 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1789 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1790 TODO comment for this. This fixes the build.
1792 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1793 be the best place for it. This will in future update all auto-update accounts,
1794 rather than just the current/default account, when that gconf key exists.
1795 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1796 if there are no accounts, before calling do_send_receive().
1797 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1799 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1800 * src/maemo/modest-main-window-ui.h:
1801 * src/maemo/modest-main-window.c: (on_connection_changed),
1802 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1803 directly, becaue the signal handler does more.
1805 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1807 * src/modest-account-mgr-helpers.c:
1808 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1809 for the case that the account does not exist.
1811 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1812 (equivalent to the modest account name) rather than the tinymail account name
1813 (equivalent to the modest account title - human readable) to get the account data.
1814 Check for null account data to prevent the crash, and add a TODO comment saying that
1815 this needs fixing because it is using the server account name instead of the account name.
1817 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1819 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1820 * src/maemo/modest-account-settings-dialog.c: (show_error),
1822 Use hildon_note_new_information() for informative and error messages,
1823 which seems to be expected for Maemo applications (no documentation that I know of
1824 says this). I am surprised that there is no distinction between info and error
1827 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1829 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1830 it is easy to find where this is used.
1832 * src/maemo/easysetup/modest-easysetup-wizard.c:
1833 (create_page_welcome), (create_page_account_details),
1834 (create_page_user_details), (create_page_complete_easysetup),
1835 (create_page_custom_incoming), (create_page_custom_outgoing),
1836 (create_page_complete_custom):
1837 * src/maemo/modest-account-settings-dialog.c:
1838 (create_page_account_details), (create_page_user_details),
1839 (create_page_incoming), (create_page_outgoing):
1840 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1841 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1842 (modest_connection_specific_smtp_edit_window_init):
1843 * src/maemo/modest-connection-specific-smtp-window.c:
1844 (modest_connection_specific_smtp_window_init):
1845 * src/maemo/modest-signature-editor-dialog.c:
1846 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1847 and scrolling policy as per the Email Application Layout Guide, if I have
1850 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1852 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1853 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1854 which were empty, because these vfuncs have been removed from TnyAccountStore.
1855 This fixes the build.
1857 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1859 * src/maemo/modest-main-window.c:
1860 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1861 showing/hiding it. Added TODO because it probably should not be NULL.
1862 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1863 because unnecessary g_warnings() make degugging difficult.
1865 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1867 * src/maemo/modest-msg-edit-window.c:
1868 (modest_msg_edit_window_select_color),
1869 (modest_msg_edit_window_select_background_color): 2 const corrections and
1870 moving 2 #endifs before closing brackets, to fix the build.
1872 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1874 * src/maemo/easysetup/modest-easysetup-wizard.h:
1875 * src/maemo/easysetup/modest-easysetup-wizard.c:
1876 (modest_easysetup_wizard_dialog_finalize),
1877 (on_button_edit_advanced_settings), (create_page_complete_custom),
1878 (on_response), (create_account):
1879 Implement the Advanced Settings edit button, by saving the account information,
1880 for the Advanded Settings dialog to use directly from gconf, and removing it
1881 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1882 Bug #5533 in the projects.maemo.org bugzilla.
1884 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1886 * src/maemo/modest-msg-view-window.c:
1887 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1888 when opening a message window.
1890 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1892 * src/maemo/easysetup/modest-easysetup-wizard.c:
1893 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1896 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1897 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1898 gconf settings. I probably added more checks than necessary, but that is safer.
1900 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1901 variable to fix the build, but this seems to be used when it is still NULL.
1903 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1905 * src/modest-platform.h:
1906 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1907 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1908 * src/modest-main.c: Implement this function so we can avoid using
1909 maemo-specific API from cross-platform code.
1911 * src/modest-tny-account-store.c:
1912 (get_smtp_specific_transport_account_for_open_connection):
1913 * src/modest-ui-actions.c: (check_for_connection),
1914 (modest_ui_actions_on_item_not_found):
1915 Use modest_platform_connect_and_wait() and put #idefs around other
1916 maemo-specific code, because only maemo currently has a way to
1917 identify connection names.
1919 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1921 * src/modest-tny-account-store.h:
1922 * src/modest-tny-account-store.c:
1923 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1924 the connection-specific SMTP server settings in the configuration.
1926 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1928 * src/maemo/modest-main-window.c: (on_connection_changed),
1930 * src/modest-main.c: (main), (start_ui), (send_mail):
1931 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1932 that is what is intended.
1934 * src/modest-ui-actions.c: (action_send), (action_receive),
1935 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1936 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1937 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1938 SMTP server is used when it is specified.
1940 (modest_ui_actions_on_send_receive):
1941 Check that a connection is open before proceeding.
1942 Receive and then send, instead of vice-versa, as per the specification.
1944 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1946 * src/modest-mail-operation.c:
1947 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1948 though I guess it should be something other than NULL.
1950 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1952 * src/maemo/easysetup/modest-easysetup-wizard.c:
1953 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1954 combo twice, to avoid an g_warning and to make it visible again.
1955 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1956 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1957 (already intended) dereference when detaching, because we then recreate the menu.
1958 But I am not sure why the warning was happening, and it is possible that this is a memory
1961 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1963 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1964 and uri_parse_mailto() utility functions.
1965 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1967 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1969 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1971 * src/dbus_api/modest-dbus-api.h:
1972 * src/dbus_api/modest-dbus-callbacks.c:
1973 Use an idle callback to execute the modest code in the application's own thread.
1974 Remove the helloworld example method.
1975 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1976 parsed, and the open-message method is not implemented because this is not yet implemented in
1978 * libmodest-dbus-client/libmodest-dbus-client.c:
1979 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1980 (libmodest_dbus_client_open_message):
1981 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1983 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1984 body without crashing.
1986 * tests/dbus_api/Makefile.am:
1987 * tests/dbus_api/test_mail_to.c:
1988 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1990 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1992 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1993 Added file to fix the build. Sorry.
1995 * src/dbus_api/Makefile.am:
1996 * src/dbus_api/modest-dbus-api.h:
1997 * src/dbus_api/modest-dbus-callbacks.h:
1998 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1999 (modest_dbus_req_handler):
2000 Put constants in a separate header so it can be reused by the
2001 client library, without duplication
2003 * libmodest-dbus-client/Makefile.am:
2004 * libmodest-dbus-client/libmodest-dbus-client.c:
2005 (libmodest_dbus_client_call_helloworld),
2006 (libmodfest_dbus_client_send_mail),
2007 (libmodfest_dbus_client_mailto),
2008 (libmodfest_dbus_client_open_message):
2009 * libmodest-dbus-client/libmodest-dbus-client.h:
2010 (Partly) Implement a send_mail D-Bus method.
2012 * tests/dbus_api/Makefile.am:
2013 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2014 the send_email D-Bus method.
2016 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2020 * libmodest-dbus-client/Makefile.am:
2021 * libmodest-dbus-client/libmodest-dbus-client.c:
2022 * libmodest-dbus-client/libmodest-dbus-client.h:
2023 * tests/dbus_api/Makefile.am:
2024 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2025 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2027 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2029 * src/maemo/easysetup/modest-easysetup-wizard.c:
2030 (create_page_account_details):
2031 * src/maemo/modest-account-settings-dialog.c:
2032 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2033 widgets, because this might not be the default in future versions of the Maemo GTK+.
2034 However, I can not not get capitalization to work even in a simple test case.
2036 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2038 * src/maemo/easysetup/modest-easysetup-wizard.c:
2039 (create_page_custom_incoming), (create_page_custom_outgoing):
2040 * src/maemo/modest-account-settings-dialog.c:
2041 (create_page_account_details), (create_page_incoming),
2042 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2043 instead of using gtk_check_button_with_label(), so they are aligned like the other
2044 widgets, as per the UI spec.
2046 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2048 * src/maemo/easysetup/modest-easysetup-wizard.c:
2049 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2050 * src/widgets/modest-validating-entry.c:
2051 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2052 Modest prefix instead of an EasySetup prefix.
2054 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2056 * src/widgets/modest-validating-entry.h:
2057 * src/widgets/modest-validating-entry.c: (on_insert_text),
2058 Added easysetup_validating_entry_set_max_func(), used to set a callback
2059 to call when the max number of characters is reached. GtkEntry has a max-length
2060 already but is silent about it.
2062 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2063 (create_page_account_details), (create_page_user_details),
2065 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2066 (create_page_account_details), (create_page_user_details),
2067 (create_page_outgoing):
2068 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2069 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2070 the UI spec, when the user tries to enter more than the max number of characters.
2072 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2074 * src/maemo/easysetup/modest-easysetup-wizard.c:
2075 (create_page_user_details), (create_page_custom_incoming),
2076 (create_page_custom_outgoing):
2077 * src/maemo/modest-account-settings-dialog.c:
2078 (create_page_user_details), (create_page_incoming),
2079 (create_page_outgoing):
2080 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2081 (modest_connection_specific_smtp_edit_window_init):
2082 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2083 not appropriate. Bad Maemo-specific defaults!.
2085 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2087 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2088 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2089 (modest_signature_editor_dialog_set_settings):
2090 Disable the label and textview when the checkbox is disabled, and use the
2091 specified (UI spec) default signature text.
2093 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2095 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2096 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2098 * src/modest-defs.h:
2099 * src/modest-account-mgr-helpers.h:
2100 * src/modest-account-mgr-helpers.c:
2101 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2103 * src/maemo/Makefile.am:
2104 * src/maemo/modest-signature-editor-dialog.c:
2105 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2108 * src/maemo/modest-account-settings-dialog.h:
2109 * src/maemo/modest-account-settings-dialog.c:
2110 (modest_account_settings_dialog_finalize), (on_button_signature),
2111 (save_configuration): Use the new dialog when the Edit button is pressed, and
2112 save the changes if necessary, as per the UI spec.
2114 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2116 * src/maemo/Makefile.am:
2117 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2118 based on maemo-develoers email from Dirk.
2120 * src/maemo/easysetup/modest-easysetup-wizard.c:
2121 (create_page_welcome), (create_page_account_details),
2122 (create_page_user_details), (create_page_complete_easysetup),
2123 (create_page_custom_incoming), (create_page_custom_outgoing),
2124 (create_page_complete_custom),
2125 (modest_easysetup_wizard_dialog_init):
2126 * src/maemo/modest-account-settings-dialog.c:
2127 (create_page_account_details), (create_page_user_details),
2128 (create_page_incoming), (create_page_outgoing),
2129 (modest_account_settings_dialog_init):
2130 * src/maemo/modest-connection-specific-smtp-window.c:
2131 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2133 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2135 * src/maemo/easysetup/modest-easysetup-wizard.c:
2136 (create_page_account_details), (create_page_custom_outgoing),
2137 (create_page_complete_custom):
2138 * src/maemo/modest-account-settings-dialog.c:
2139 (create_page_user_details), (create_page_incoming),
2140 (create_page_outgoing):
2141 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2142 (modest_connection_specific_smtp_edit_window_init):
2143 Use the correct (UI spec) port min/max, and use horizontal separators,
2146 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2148 * src/maemo/easysetup/modest-easysetup-wizard.c:
2149 (set_default_custom_servernames):
2150 * src/maemo/modest-account-settings-dialog.c:
2151 (create_page_incoming), (on_combo_outgoing_security_changed),
2152 (on_combo_incoming_security_changed), (create_page_outgoing),
2153 (modest_account_settings_dialog_set_account_name),
2154 (save_configuration):
2155 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2156 (on_combo_security_changed),
2157 (modest_connection_specific_smtp_edit_window_init),
2158 (modest_connection_specific_smtp_edit_window_set_connection),
2159 (modest_connection_specific_smtp_edit_window_get_settings):
2160 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2163 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2166 * src/maemo/easysetup/modest-easysetup-wizard.c:
2167 (create_page_custom_outgoing), (create_page_complete_custom):
2168 * src/maemo/modest-account-settings-dialog.c:
2169 (create_page_user_details), (create_page_outgoing):
2170 * src/maemo/modest-account-view-window.c: (button_box_new):
2171 Use changed logical IDs as per the most recent UI spec:
2172 mcen_bd_emailsetup_edit -> mcen_bd_edit
2173 mcen_bd_emailsetup_delete -> mcen_bd_delete
2174 mcen_bd_emailsetup_close -> mcen_bd_close
2176 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2180 * src/dbus_api/Makefile.am:
2181 * src/dbus_api/modest-dbus-callbacks.c:
2182 * src/dbus_api/modest-dbus-callbacks.h:
2183 * src/maemo/modest-platform.c: (modest_platform_init):
2184 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2186 * tests/Makefile.am:
2187 * tests/dbus_api/Makefile.am:
2188 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2190 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2192 * src/maemo/modest-account-settings-dialog.c:
2193 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2194 Removed unnecessary includes.
2196 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2198 * src/maemo/easysetup/modest-easysetup-wizard.c:
2199 * src/maemo/modest-account-settings-dialog.c:
2200 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2201 * src/widgets/Makefile.am:
2202 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2203 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2204 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2205 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2206 * src/widgets/modest-secureauth-combo-box.c:
2207 * src/widgets/modest-secureauth-combo-box.h:
2208 * src/widgets/modest-serversecurity-combo-box.c:
2209 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2210 made the GObject names more consistent with the rest of the Modest code.
2212 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2214 * src/maemo/easysetup/Makefile.am:
2215 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2216 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2217 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2218 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2219 * src/maemo/easysetup/modest-easysetup-wizard.c:
2220 * src/maemo/easysetup/modest-validating-entry.c:
2221 * src/maemo/easysetup/modest-validating-entry.h:
2222 * src/maemo/modest-account-settings-dialog.c:
2223 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2224 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2225 widgets/ because they are used outside of easysetup too. After checking in,
2226 svn will allow me to rename them too.
2228 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2230 * src/gnome/modest-msg-edit-window.c:
2231 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2232 linker error, to fix the build on the GNOME platform.
2233 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2234 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2235 ifdefed out to avoid a warning.
2237 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2239 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2240 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2241 some alternative for GTK+ 2.6.
2243 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2245 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2247 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2248 specified for EmailAccountsDialog in UI spec.
2250 * src/maemo/easysetup/modest-easysetup-wizard.c:
2251 * src/maemo/easysetup/modest-easysetup-wizard.h:
2252 * src/maemo/modest-account-settings-dialog.c:
2253 * src/maemo/modest-account-settings-dialog.h:
2254 Reuse a member window widget for the connection-specific SMTP server accounts,
2255 so we can tell it to create/save the accounts only if we actually save changes.
2257 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2258 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2259 (modest_connection_specific_smtp_edit_window_get_settings):
2260 Return a struct instance for temporarily remembering the entered data.
2262 * src/maemo/modest-connection-specific-smtp-window.h:
2263 * src/maemo/modest-connection-specific-smtp-window.c:
2264 (modest_connection_specific_smtp_window_finalize),
2265 (modest_connection_specific_smtp_window_fill_with_connections),
2267 (modest_connection_specific_smtp_window_save_server_accounts),
2268 (update_model_server_names): Do not actually save data until asked,
2269 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2271 (on_selection_changed),
2272 (modest_connection_specific_smtp_window_init): Disable the edit
2273 button when nothing is selected.
2275 * src/modest-account-mgr-helpers.c:
2276 * src/modest-account-mgr-helpers.h:
2277 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2280 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2282 * src/modest-account-mgr-helpers.h:
2283 * src/modest-account-mgr-helpers.c:
2284 (modest_account_mgr_get_unused_account_name),
2285 (modest_account_mgr_get_unused_account_display_name): Added these
2286 utility functions, to avoid code duplication.
2288 * src/maemo/easysetup/modest-easysetup-wizard.c:
2289 (create_page_account_details), (create_account):
2290 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2291 (on_combo_security_changed),
2292 (modest_connection_specific_smtp_edit_window_init),
2293 (modest_connection_specific_smtp_edit_window_save_settings):
2294 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2295 * src/maemo/modest-connection-specific-smtp-window.c:
2296 (modest_connection_specific_smtp_window_finalize),
2297 (modest_connection_specific_smtp_window_fill_with_connections),
2298 (on_button_edit), (modest_connection_specific_smtp_window_init):
2299 * src/maemo/modest-connection-specific-smtp-window.h:
2300 Implementing saving of connection-specific server accounts.
2302 But I need to refactor this so we can save the data for each
2303 possible connection-specific account and only actually create the server accounts
2304 when the easysetup finished, or the OK button is pressed on the account settings
2307 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2309 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2310 (on_combo_security_changed):
2311 (modest_connection_specific_smtp_edit_window_init):
2312 Auto-fill the port number as in the account settings.
2314 (modest_connection_specific_smtp_edit_window_set_connection):
2315 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2316 * src/maemo/modest-connection-specific-smtp-window.c:
2317 (fill_with_connections), (on_button_edit),
2318 (modest_connection_specific_smtp_window_init):
2319 Turn the edit window into a dialog to simplify the code, and
2320 set a WM hint as in a GtkDialog, because only a popup can be on top of
2321 another window in Maemo, and popups usually have no WM decoration.
2323 * src/modest-defs.h:
2324 * src/modest-account-mgr-helpers.c:
2325 (modest_account_mgr_set_connection_specific_smtp),
2326 (modest_account_mgr_remove_connection_specific_smtp),
2327 (modest_account_mgr_get_connection_specific_smtp):
2328 * src/modest-account-mgr-helpers.h: Some functions to write the
2329 connection-specific SMTP server information. Not yet used.
2332 * src/widgets/modest-folder-view.c: (text_cell_data):
2333 Fix a warning about an uninitialized variable.
2334 (on_configuration_key_changed): Put an #ifdef around the use
2335 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2337 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2339 * src/maemo/modest-account-settings-dialog.h:
2340 * src/maemo/modest-account-settings-dialog.c:
2341 Added connect_for_modified() utility function to mark the new modified boolean.
2343 (create_page_account_details), (create_page_user_details),
2344 (create_page_incoming), (create_page_outgoing), (on_response),
2345 (modest_account_settings_dialog_init),
2346 (modest_account_settings_dialog_set_account_name):
2347 Only warn about unsaved changes when there are actually unsaved changes.
2349 * src/modest-account-mgr-helpers.c:
2350 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2351 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2352 to get the data from there in future.
2354 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2356 * src/modest-defs.h:
2358 * src/modest-account-mgr-helpers.h:
2359 * src/modest-account-mgr-helpers.c:
2360 Store the security account setting in a single conf key instead of using
2361 the options list, so that the list is left for just the to-be-removed camel hack,
2362 and because gconf_client_set_list() is failing for some reason.
2364 * src/modest-account-mgr.c:
2365 (modest_account_mgr_add_server_account):
2366 * src/maemo/modest-account-settings-dialog.c:
2367 (modest_account_settings_dialog_set_account_name),
2368 (save_configuration): Use the renamed functions.
2371 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2373 * src/widgets/Makefile.am:
2374 * src/widgets/modest-limit-retrieve-combo-box.c:
2375 * src/widgets/modest-limit-retrieve-combo-box.h:
2376 * src/widgets/modest-retrieve-combo-box.c:
2377 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2378 the account settings dialog.
2380 * src/modest-defs.h:
2381 * src/modest-account-mgr-helpers.h:
2382 * src/modest-account-mgr-helpers.c:
2383 (modest_server_account_get_option_secure_auth),
2384 (modest_server_account_set_option_secure_auth):
2385 * src/modest-account-mgr.c:
2386 (modest_account_mgr_add_server_account):
2387 Use the existing AUTH_MECH conf key for the secure-auth setting,
2388 instead of putting it in the list options, because this was actually used already.
2390 * src/maemo/modest-account-settings-dialog.c:
2391 (create_page_account_details),
2392 (modest_account_settings_dialog_set_account_name),
2393 (save_configuration):
2394 * src/maemo/modest-account-settings-dialog.h:
2395 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2396 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2398 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2400 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2401 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2402 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2404 * src/modest-defs.h:
2405 * src/maemo/modest-account-settings-dialog.c:
2406 (create_page_incoming), (on_combo_outgoing_security_changed),
2407 (on_combo_incoming_security_changed), (create_page_outgoing),
2408 (modest_account_settings_dialog_set_account_name),
2409 (save_configuration): Load/Save the port number, and change it when the
2410 security combo changes, to suitable defaults.
2412 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2414 * src/modest-account-mgr.c:
2415 (modest_account_mgr_add_server_account): Set the security and secure-auth
2416 options, and add a comment saying that the other camel-specific options should be
2419 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2421 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2423 * src/modest-tny-account-store.c: (account_list_free),
2424 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2425 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2428 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2430 * src/modest-protocol-info.c:
2431 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2432 is required by our UI spec. Maybe something in our implementation will use this eventually.
2433 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2434 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2435 instead of the previous 0 placeholder.
2437 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2438 secure-auth settings.
2439 * src/modest-account-mgr-helpers.h:
2440 * src/modest-account-mgr-helpers.c:
2441 (modest_server_account_data_get_option_secure_auth),
2442 (modest_server_account_set_option_secure_auth),
2443 (modest_server_account_data_get_option_security),
2444 (modest_server_account_set_option_security): Added this API for getting and setting the security
2445 and secure-auth settings.
2447 * src/maemo/modest-account-settings-dialog.h:
2448 * src/maemo/modest-account-settings-dialog.c:
2449 (modest_account_settings_dialog_finalize), (check_data),
2450 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2451 about changing titles.
2452 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2453 (save_configuration): Save the security and secure-auth settings.
2455 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2456 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2458 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2460 * src/modest-defs.h:
2461 * src/modest-account-mgr.c:
2462 (modest_account_mgr_add_server_account):
2463 Added and used defines for the options key and value pair strings,
2464 that are used so far, though they do not seem to correspond to anything in our
2465 UI specs or ModestProtocol enum.
2467 * src/modest-account-mgr-helpers.h:
2468 * src/modest-account-mgr-helpers.c:
2469 (compare_option_strings_for_name),
2470 (modest_server_account_data_get_option_value),
2471 (modest_server_account_data_get_option_bool),
2472 (modest_account_mgr_get_server_account_option):
2473 Added helper functions for parsing the options GSList.
2475 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2477 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2478 display name is based on the supplied account name.
2479 * src/modest-account-mgr.c:
2480 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2481 with an inefficient, but good-enough, implementation.
2483 * src/maemo/easysetup/modest-easysetup-wizard.c:
2484 (create_page_account_details), (on_before_next), (create_account):
2485 Check for existing display names rather than (non-user-visible) account names, and just
2486 create and set a unique account name at the end.
2488 * src/maemo/modest-account-settings-dialog.c:
2489 (modest_account_settings_dialog_init),
2490 (modest_account_settings_dialog_set_account_name),
2491 (create_page_incoming): Show the display name, instead of the account name.
2492 (on_response): Do some (not all) extra checks, as in the UI spec.
2493 (save_configuration): Save the display name if it was changed.
2495 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2497 * po/en_GB.po: Added needed logical ID and translation.
2498 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2499 (init_view): Made the is-default column clicking work.
2501 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2504 * src/maemo/easysetup/Makefile.am:
2505 * src/maemo/easysetup/modest-easysetup-wizard.c:
2506 (modest_easysetup_wizard_dialog_init):
2507 * src/maemo/easysetup/provider-data-test.keyfile:
2508 * src/maemo/easysetup/provider-data.keyfile:
2509 Moved the provider data file to the new modest-providers-data package and used it from there.
2511 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2513 * src/modest-local-folder-info.c:
2514 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2515 N_() was already used on the static strings, but this just marks it for translation without
2516 using the translation.
2518 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2520 * src/maemo/modest-account-settings-dialog.c:
2521 (create_page_incoming),
2522 (modest_account_settings_dialog_set_account_name):
2523 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2524 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2525 I will do this if nobody else gets there first.
2527 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2529 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2530 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2531 save the security stuff.
2533 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2535 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2536 Set the email address and user fullname, which I now see must be
2539 * src/maemo/modest-account-settings-dialog.h:
2540 * src/maemo/modest-account-settings-dialog.c:
2542 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2543 leave-on-server and authentication.
2544 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2547 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2550 * src/maemo/modest-account-settings-dialog.c:
2551 * src/maemo/modest-account-settings-dialog.h:
2552 Most (but not all) of the widgets are now present as specified by the UI spec.
2553 No changes are yet saved, and some details are not properly shown yet.
2555 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2557 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2559 * src/maemo/Makefile.am:
2560 * src/maemo/modest-account-settings-dialog.c:
2561 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2562 an existing account. Doesn't do much yet.
2564 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2565 Open the accounts settings dialog when Edit is clicked.
2567 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2569 * src/maemo/easysetup/Makefile.am:
2570 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2572 * src/maemo/easysetup/modest-easysetup-wizard.c:
2573 (modest_easysetup_wizard_dialog_init):
2574 Try to get the source directory from the build system,
2575 instead of hard-coding "./" into the source code, when opening our local
2576 copies of the configuration files.
2577 But this still fails when opening the wizard from the Accounts window,
2578 maybe because the working directory seems to change at runtime.
2579 So the wizard will fail the second time unless you copy the files into their
2580 proper locations - see the stdout warnings for the paths.
2582 (create_page_account_details),(on_before_next):
2583 Check for existing non-server accounts instead of server accounts,
2584 so the default account name is useful again, and to prevent trying to
2587 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2588 Show the wizard when New is clicked.
2590 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2591 (init_view): Show the column headers, and show the columns that are
2592 specified in the UI specs. However, something in Maemo's GTK+ prevents
2593 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2594 change the default account. This is despite unsetting the special properties.
2596 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2598 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2599 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2600 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2601 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2602 to make that clearer.
2603 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2605 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2607 * src/maemo/modest-account-view-window.c:
2608 (modest_account_view_window_init),
2609 (modest_account_view_window_new):
2610 Use the same buttons as specified in the
2611 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2612 the existing widgets, which never had a chance of working.
2613 Put the ModestAccountView treeview in a scrolled window.
2614 Do not repeat the initialization in both _init() and _new().
2616 * src/widgets/modest-account-view.c: (update_account_view):
2617 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2618 this widget and window shows no accounts.
2620 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2622 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2624 * src/maemo/easysetup/modest-easysetup-wizard.c:
2625 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2626 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2627 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2630 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2631 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2632 accounts exist yet, as in the UI spec.
2634 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2636 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2638 * src/maemo/Makefile.am:
2639 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2640 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2641 New window for editing connection-specific smtp details.
2642 Not fully implemented.
2644 * src/maemo/modest-connection-specific-smtp-window.c:
2645 (modest_connection_specific_smtp_window_finalize) :
2646 unref the tree model.
2647 (on_button_edit): Show the edit window.
2649 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2651 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2654 * src/maemo/Makefile.am:
2655 * src/maemo/modest-connection-specific-smtp-window.c:
2656 * src/maemo/modest-connection-specific-smtp-window.h:
2657 New window for showing the list of connections, for connection-specific
2658 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2659 * src/maemo/easysetup/modest-easysetup-wizard.c:
2660 (create_page_custom_outgoing): Show the new window when the button is clicked.
2662 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2664 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2665 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2666 * src/maemo/modest-msg-edit-window.c:
2667 (modest_msg_edit_window_insert_image):
2668 * src/modest-conf.c: (modest_conf_key_escape):
2669 * src/modest-mail-operation.c:
2670 (modest_mail_operation_send_new_mail):
2671 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2672 (modest_ui_actions_on_new_account):
2673 * src/widgets/modest-attachment-view.c: (update_filename_request):
2674 * src/widgets/modest-mail-header-view.c:
2675 Corrected warnings that were breaking the build, by commenting out unused variables,
2676 and a function, and by including a header.
2678 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2680 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2681 so we can #ifdef around platform-specific code when necessary.
2682 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2683 to allow this to build for the GNOME platform too.
2685 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2687 * src/maemo/easysetup/modest-easysetup-wizard.c:
2688 Added util_increment_name() and used it in create_page_account_details()
2689 to make sure that the default account name is always a new name.
2691 (modest_easysetup_wizard_dialog_init),
2692 (set_default_custom_servernames): Some minor memory management fixes.
2694 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2698 * src/modest-runtime.c: (init_i18n): Restored the translation
2699 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2700 are defined in config.h, and the translations are installed.
2702 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2703 is defined for translation.
2705 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2707 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2709 * src/maemo/easysetup/modest-easysetup-wizard.c:
2710 (modest_easysetup_wizard_dialog_init):
2711 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2712 Use realistic paths (though they should use $prefix generically) to the
2713 mcc_mapping and provider-data.keyfile files which might work when they
2714 are installed by the future version of the operator-wizard package,
2715 and then fallback to paths in our source code, with an explanatory
2718 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2722 * src/maemo/Makefile.am:
2723 * src/maemo/easysetup/: Added files from the previously-exernal
2724 osso-modest-easysetup.
2725 * src/maemo/modest-main-window-ui.h:
2726 * src/modest-ui-actions.c:
2727 * src/modest-ui-actions.h:
2728 Added modest_ui_actions_on_new_account() as a signal handler for the
2729 New Account menu item. It shows the easysetup wizard.
2730 * po/en_GB.po: Added additional needed logical IDs and translations.
2732 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2733 Apparently ChangeLog is not used for some vague Nokia legal reasons.