1 2007-08-17 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c:
4 (on_dbus_method_get_folders): Avoid trying to get the account name
5 when there are no accounts, to avoid critical g_warnings, fixing
6 projects.maemo.org bug NB#65574.
8 2007-08-17 Murray Cumming <murrayc@murrayc.com>
10 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
11 Use modest_account_mgr_get_signature() instead of accessing gconf
12 directly, to slightly simplify the code.
13 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
14 Append the signature also when opening via other applications,
15 fixing projects.maemo.org bug NB#65828.
17 2007-08-17 Murray Cumming <murrayc@murrayc.com>
19 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
20 Check for NULLs to prevent a crash when opening an email that is
21 an attachment in another email, fixing projects.maemo.org bug
24 2007-08-17 Murray Cumming <murrayc@murrayc.com>
26 * src/modest-ui-dimming-rules.c:
27 (modest_ui_dimming_rules_on_view_window_move_to):
28 Enable the Move To toolbar button for search results, fixing the
29 last part of projects.maemo.org bug NB#63807.
31 2007-08-17 Murray Cumming <murrayc@murrayc.com>
33 * src/dbus_api/modest-dbus-callbacks.c:
34 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
35 because this is called from idle handlers, to fix hangs afte the
37 (find_message_by_url): Added a TODO comment about a crash that
38 happens when tinymail was built with DBC checks.
40 2007-08-16 Murray Cumming <murrayc@murrayc.com>
42 * src/modest-search.c: (modest_search_folder):
43 * src/modest-search.h: Rename ModestSearch::before to start_date
44 and after to end_date, using the same names as the libogs struct
46 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
47 The start_date and end_date were swapped in the check. This
48 fixes date range searches, fixing projects.maemo.org bug NB#63407.
50 2007-08-16 Murray Cumming <murrayc@murrayc.com>
52 * src/maemo/modest-account-view-window.c:
53 Added (check_for_active_acount).
54 (on_delete_button_clicked), (on_edit_button_clicked):
55 When an account is doing something (such as refreshing),
56 show the same warning for account deletion as for account
57 editing, to fix projects.maemo.org bug NB#64588.
59 2007-08-16 Murray Cumming <murrayc@murrayc.com>
61 * src/widgets/modest-msg-view-window.h:
62 * src/gnome/modest-msg-view-window.c:
63 * src/maemo/modest-msg-view-window.c:
64 Added modest_msg_view_window_construct().
65 (modest_msg_view_window_new_with_header_model),
66 Added modest_msg_view_window_new_for_search_result),
67 Renamed modest_msg_view_window_new() to
68 modest_msg_view_window_new_for_attachment(),
69 and modest_msg_view_window_is_search_result(),
70 so we can explicitly know that the window is for an
71 attachment or a search result or a message from the list.
73 (modest_msg_view_window_view_attachment):
74 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
75 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
76 Use modest_msg_view_window_new_for_search_result().
78 * src/modest-ui-dimming-rules.c:
79 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
80 for search results, fixing projects.maemo.org bug NB#63811.
82 2007-08-16 Armin Burgmeier <armin@openismus.com>
84 * src/modest-ui-actions.c: Show a banner instead of a dialog when
85 renaming a folder fails, to stay consistent with what happens when
86 creating a folder fails.
88 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
89 slightly country loading from the mmc_mappings file, fixed a memory
92 2007-08-16 Murray Cumming <murrayc@murrayc.com>
94 * src/modest-tny-account-store.c: (volume_path_is_mounted):
95 Check the GnomeVFSVolume activation path instead of the device path,
96 so that the memory card is really really shown in the UI.
98 2007-08-16 Murray Cumming <murrayc@murrayc.com>
100 * src/maemo/easysetup/modest-easysetup-wizard.c:
101 (get_entered_account_title), (on_before_next), (entry_is_empty),
103 * src/maemo/modest-account-settings-dialog.c:
104 (get_entered_account_title), (on_button_signature), (check_data),
105 (save_configuration), (entry_is_empty):
106 Strip the account title of whitespace at the start and end before
107 using it or checking it. This means that an all-whitespace title
108 is not allowed, fixing projects.maemo.org bug NB#64977.
110 2007-08-15 Murray Cumming <murrayc@murrayc.com>
112 * src/modest-ui-actions.h:
113 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
114 to modest_run_account_setup_wizard() and made it public.
115 * src/dbus_api/modest-dbus-callbacks.c:
116 (check_and_offer_account_creation), (on_idle_mail_to),
117 (on_idle_compose_mail), (on_idle_open_default_inbox):
118 Offer account creation if necessary, fixing projects.maemo.org
121 2007-08-15 Murray Cumming <murrayc@murrayc.com>
123 * src/modest-ui-actions.c: (run_account_setup_wizard):
124 Return a gboolean to indicate success.
125 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
126 (modest_ui_actions_on_send): When offering account creation, only
127 give up (return) if account creation failed. Otherwise continue
128 with the original request. This fixed projects.maemo.org bug
131 2007-08-15 Murray Cumming <murrayc@murrayc.com>
133 * src/widgets/modest-recpt-editor.c:
134 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
135 to fix projects.maemo.org bug NB#63789.
137 2007-08-15 Murray Cumming <murrayc@murrayc.com>
139 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
140 (modest_tny_account_store_new): Properly detect the memory card at
141 startup, and add an account for it.
143 2007-08-14 Murray Cumming <murrayc@murrayc.com>
145 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
146 Commented out the MMC code again because it mistakenly detects
147 the card even when it isn't inserted.
149 2007-08-14 Murray Cumming <murrayc@murrayc.com>
151 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
152 Renabled the call to add_mmc_account() because I do not believe
153 it could be the cause of the mentioned hang (in scratchbox, where
154 there is no memory card), and because I have tested that it works
157 2007-08-14 Murray Cumming <murrayc@murrayc.com>
159 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
160 Comment out part of the last commit because it apparently causes
163 2007-08-14 Murray Cumming <murrayc@murrayc.com>
165 * src/modest-tny-account-store.c: Added the add_mmc_account()
166 function to save some copy/pasting.
167 (modest_tny_account_store_new): If the memory card is mounted,
168 create an account for it at the start, instead of waiting for the
169 user to unmount it and mount it.
171 2007-08-13 Murray Cumming <murrayc@murrayc.com>
173 * src/widgets/modest-account-view.c: (on_account_changed):
174 Do not try to use the human-readable TnyAccount name instead of the
175 ID of the modest account to get the transport account. And unref
176 the transport account. This prevents a g_warning(), and a possible
179 2007-08-13 Murray Cumming <murrayc@murrayc.com>
181 * src/maemo/modest-platform.c:
182 (modest_platform_set_update_interval): Handle the new
183 alarmd error to warn when alarmd is not running, as is the case in
184 scratchbox for me now because
185 "Module /usr/lib/alarmd/libretu.so initialization failed"
187 2007-08-13 Murray Cumming <murrayc@murrayc.com>
189 * src/widgets/modest-header-view-render.c:
190 (_modest_header_view_compact_header_cell_data):
191 NULL some strings after freeing them, trying to deal with
192 the double deletion found in projects.maemo.org bug 64183,
193 probably having no effect.
195 2007-08-13 Murray Cumming <murrayc@murrayc.com>
197 * src/maemo/modest-account-settings-dialog.c:
198 (create_page_incoming), (create_page_outgoing): Use a define
199 for the min and max port numbers.
201 (check_hildon_number_editor_and_warn_value_not_in_range),
202 (check_data): Do an extra check for an invalid port number, as needed
203 in projects.maemo.org bug #64275, when the number is cleared, but this
204 does not work due to bugs.maemo.org bug #1806.
206 2007-08-13 Murray Cumming <murrayc@murrayc.com>
208 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
209 Comment out the debug warning about the unexpected D-Bus methods.
210 They are just annoying now.
211 * src/maemo/modest-platform.c:
212 (modest_platform_set_update_interval): Correct the D-Bus path, instead
213 of using a file path, though it did not seem to break things before.
214 It might be needed now:
215 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
216 modest is not already running. This is the behaviour of the old client, and
217 Mox says it is what we should do for modest.
218 This closes projects.maemo.org bug NB#64327.
220 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
222 * src/modest-text-utils.c:
223 Fixed invalid jump due to incorrect string/pointer
225 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
228 2007-08-01 Murray Cumming <murrayc@murrayc.com>
230 * src/modest-account-mgr-helpers.h:
231 * src/modest-account-mgr-helpers.c:
232 Added modest_account_mgr_get_first_account_name(),
233 using code from modest_account_mgr_set_first_account_as_default().
235 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
236 (account_number_changed): Call set_at_least_one_account_visible() so that
237 the first account is visible when first added, without the user having to
239 I do wonder how this worked before.
241 2007-08-01 Murray Cumming <murrayc@murrayc.com>
243 * src/modest-tny-account-store.c: (show_password_warning_only),
244 (show_wrong_password), (request_password_and_wait), (get_password),
245 (modest_tny_account_store_alert): Remove the (incomplete anyway)
246 attempts to show UI only in the main context, which used g_idle_add()
247 and mainloops, because tinymail now guarantees that it only calls these
248 callbacks in the mainloop with the gdk lock. This makes everything much
251 2007-08-01 Murray Cumming <murrayc@murrayc.com>
253 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
254 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
255 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
256 error dialog, instead of ignoring it.
258 2007-08-01 Murray Cumming <murrayc@murrayc.com>
260 * src/maemo/modest-msg-view-window.c:
261 (modest_msg_view_window_get_header),
262 (modest_msg_view_window_last_message_selected):
263 Added comments to explain the use of priv->header_model.
264 * src/modest-ui-dimming-rules.c:
265 (modest_ui_dimming_rules_on_open_msg),
266 (modest_ui_dimming_rules_on_mark_as_read_msg),
267 (modest_ui_dimming_rules_on_mark_as_unread_msg),
268 (modest_ui_dimming_rules_on_remove_attachments),
269 (_invalid_attach_selected), (_selected_msg_marked_as):
270 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
271 and changed the parameter to a ModestMainWindow to make it clearer that
272 it never uses any other kind of window.
273 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
274 instead of the selected message.
275 I notice that much of the dimming code and the ModestMsgViewWindow code
276 hard-codes the assumption that the viewed message is always selected in
277 the header view. This does not seem wise or simple.
279 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
280 examine the actual message instead of whatever might be selected
281 in the header view. This stops the delete toolbar button and menu item
282 from being dimmed when opening a message view the search UI,
283 partially fixing projects.maemo.org bug NB#63811.
285 However, when actually deleting, I now get this warning:
286 "tny_header_set_flags: This is a header instance for a new message.
287 Only priority and attachment flags are supported"
289 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
291 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
293 Show account wizard if no accounts are defined while sending
294 (automatic sending after the account wizard finished does not
295 work because it takes some time until the account manager
296 synchronizes everything. (projects.maemo.org NB#62792)
298 2007-07-30 Murray Cumming <murrayc@murrayc.com>
300 * src/modest-tny-account-store.c: (on_account_removed),
301 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
302 account is removed from the View menu. We have TnyAccountStore
303 and ModestTnyAccountStore signals that seem very similar, but this
304 seems to work for now.
306 * src/maemo/modest-main-window.c:
307 (on_show_account_action_activated): Prevent dereference
308 of a NULL if the accoutn does not really exist, though that
309 should not happen anymore.
311 This fixes projects.maemo.org bug NB#64606.
313 2007-07-30 Murray Cumming <murrayc@murrayc.com>
315 * src/modest-ui-actions.c: (run_account_setup_wizard),
316 (modest_ui_actions_on_accounts): Revert a change that set these
317 to modal dialogs, freezing the UI when they show secondary dialogs.
318 This fixed projects.maemo.org bug NB#64519.
320 2007-07-27 Murray Cumming <murrayc@murrayc.com>
322 * src/widgets/modest-header-view-render.c:
323 (_modest_header_view_compact_header_cell_data):
324 Some checks and initialization to try to deal with a crash,
325 probably ineffective.
327 2007-07-27 Murray Cumming <murrayc@murrayc.com>
329 * src/maemo/modest-maemo-utils.c:
330 (modest_maemo_utils_get_supported_secure_authentication_methods):
331 Make sure that we have a connection, asking the user for one
333 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
334 Check for a connection before showing the wizard, because
335 the wizard needs a connection to check for server capabilities.
337 2007-07-27 Murray Cumming <murrayc@murrayc.com>
339 * src/maemo/modest-account-view-window.c:
340 (on_new_button_clicked): Remember the wizard dialog instance,
341 so we can just present it again if necessary. This prevents
342 multiple windows from appearing if you click again quickly on the
343 New button before the dialog appears, fixing projects.maemo.org
346 2007-07-27 Murray Cumming <murrayc@murrayc.com>
348 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
349 Offer a connection dialog if there is no connection when
350 starting modest. This should fix projects.maemo.org bug NB#61134.
352 2007-07-27 Murray Cumming <murrayc@murrayc.com>
354 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
355 Reverted my last commit. I was able to fix the build by doing
356 apt-get install wpeditor0 (replacing other wpeditor packages) and
357 an explicit apt-get install wpeditor-dev to upgrade the -dev
360 2007-07-27 Murray Cumming <murrayc@murrayc.com>
362 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
363 Commented out the use of wp_text_buffer_replace_image()
364 because it does not exist, to break the build. Added a TODO for it.
366 2007-07-26 Murray Cumming <murrayc@murrayc.com>
368 * src/modest-tny-account-store.c: (recreate_all_accounts):
369 Recreate them even if they were NULL before. I guess something
370 else was already creating them before, or this would never
372 (modest_tny_account_store_get_server_account): Make sure that
373 the tny accounts have been created before trying to find one.
374 This allows libmodest_dbus_client_compose_mail() to work
375 when the UI is not yet visible.
376 This is probably useful in other cases too.
378 (get_password): When the password is wrong after it is entered
379 in the protected password dialog, show an info banner (in an
380 idle handler) before showing the protected password dialog
383 2007-07-26 Murray Cumming <murrayc@murrayc.com>
385 * src/modest-ui-actions.h:
386 * src/modest-ui-actions.c: Added
387 modest_do_refresh_current_folder() containing some code from
388 modest_ui_actions_on_send_receive().
389 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
390 Call modest_do_refresh_current_folder() before refreshing the
391 requested account, as in modest_ui_actions_on_send_receive().
392 This is strange, but seems to be necessary to show new mails.
393 Now new emails are finally visible in the UI when downloaded
394 via the automatic update interval, fixing bug NB#57458.
395 This also works because bug NB#57458 has been fixed somehow.
397 2007-07-26 Murray Cumming <murrayc@murrayc.com>
399 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
400 printf more details when we get unhandled D-Bus methods, because
403 * src/modest-mail-operation.c: (update_account_thread):
404 Comment out the tny_camel_pop_store_account_reconnect(), because this
405 is apparently no longer needed, and it did not work before anyway.
406 See the comment in the code.
408 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
409 by checking the header flags. This fixes projects.maemo.org bug
412 2007-07-25 Murray Cumming <murrayc@murrayc.com>
414 * src/maemo/modest-maemo-utils.h:
415 * src/maemo/modest-maemo-utils.c: Added
416 modest_maemo_show_information_note_in_main_context_and_forget().
417 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
418 Use the new function to show simple error dialogs in the main
419 context, though question dialogs are still in the current context,
420 which is unfortunately usually not the main context. This should
423 2007-07-25 Murray Cumming <murrayc@murrayc.com>
425 * src/modest-tny-account-store.c: (get_password):
426 Never save the entered username and password in gconf,
427 because the UI spec says we should not. This helps
428 slightly with projects.maemo.org bug NB#63671.
430 2007-07-25 Murray Cumming <murrayc@murrayc.com>
432 * src/widgets/modest-msg-edit-window.h:
433 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
434 Moved some code here to make it simpler.
435 (modest_msg_edit_window_attach_file_one): Renamed from
436 modest_msg_edit_window_attach_file_interactive().
437 (modest_msg_edit_window_offer_attach_file): Renamed from
438 modest_msg_edit_window_attach_file() and used
439 modest_msg_edit_window_attach_file_one() instead of
440 copy/pasting the code. The old code for one was not using
441 GnomeVFS. This allows use of smb:// URLs when using send-as
442 from external applications, fixing bug NB#63741.
444 (modest_msg_edit_window_insert_image),
445 (modest_msg_edit_window_add_attachment_clicked):
446 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
447 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
448 Adapted to the new function names.
450 2007-07-25 Murray Cumming <murrayc@murrayc.com>
452 (modest_platform_set_update_interval): Set the alarm recurrence
453 fields so that auto-update does not just happen the first time.
454 This should have fixed projects.maemo.org bug NB#63938.
456 When this happens you can see a printf when the D-Bus method is
458 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
460 However, I do not actually seem to get new POP messages even when
461 clicking the refresh button manually. A restart gets them.
462 This might be a problem in today's tinymail only.
464 2007-07-24 Murray Cumming <murrayc@murrayc.com>
466 * src/maemo/modest-maemo-global-settings-dialog.c:
467 (current_connection):
468 Avoid a crash (probably only in scratchbox) when strcmp()ing a
469 NULL when closing the dialog.
471 2007-07-24 Murray Cumming <murrayc@murrayc.com>
473 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
474 Remove the hacky send/receive that didn't work, and instead
475 refilter the treemodel to make the deleted email really vanish from
476 the UI (though the delete-from-menu code does has commented out
477 the code that does that). This fixes projects.maemo.org bug
480 2007-07-24 Murray Cumming <murrayc@murrayc.com>
482 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
483 Try a couple of tricks to force the treeview to update (
484 poke the folder, and do a send/receive refresh), but the deleted
485 email still appears with a strike-through instead of really being
488 2007-07-23 Murray Cumming <murrayc@murrayc.com>
490 * src/dbus_api/modest-dbus-callbacks.c:
491 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
492 because their ID is not human-readable (see the comment about
493 improvements needed to the osso-email-interface API) and
494 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
496 2007-07-23 Murray Cumming <murrayc@murrayc.com>
498 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
499 (add_folders_to_list), (on_dbus_method_get_folders),
500 (modest_dbus_req_filter):
501 * src/maemo/modest-maemo-utils.c:
502 (on_camel_account_get_supported_secure_authentication):
503 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
504 (on_header_view_focus_in):
505 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
506 * src/modest-formatter.c: (modest_formatter_create_body_part):
507 * src/modest-mail-operation.c: (recurse_folders),
508 (update_account_thread), (get_msgs_full_thread),
509 (modest_mail_operation_get_msgs_full),
510 (modest_mail_operation_xfer_msgs):
511 * src/modest-search.c: (search_mime_part_and_child_parts),
512 (modest_search_account), (modest_search_all_accounts):
513 * src/modest-tny-account.c:
514 (modest_tny_account_get_special_folder), (recurse_folders):
515 * src/modest-tny-local-folders-account.c:
516 (modest_tny_local_folders_account_query_passes):
517 * src/modest-tny-msg.c: (copy_mime_part),
518 (modest_tny_msg_find_body_part_from_mime_part):
519 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
520 (modest_tny_send_queue_try_to_send):
521 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
522 (_modest_ui_actions_open), (download_uncached_messages),
523 (reply_forward), (modest_ui_actions_on_copy),
524 (modest_ui_actions_on_details), (has_retrieved_msgs),
525 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
527 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
528 (_selected_msg_marked_as), (_msg_download_completed),
529 (_selected_msg_sent_in_progress):
530 * src/widgets/modest-attachments-view.c:
531 (modest_attachments_view_set_message):
532 * src/widgets/modest-msg-view.c: (find_cid_image):
533 * tests/check_folder-transfer.c: (find_folders):
534 * tests/check_update-account.c: (func):
535 * tests/dbus_api/test_get_folders.c: (main):
536 Checked all uses of tny_iterator_get_current(), making sure
537 that the object is unreferenced (3 or 4 places did not),
538 and adding checks for NULL.
540 2007-07-23 Murray Cumming <murrayc@murrayc.com>
542 * src/dbus_api/modest-dbus-callbacks.c:
543 (on_idle_open_default_inbox): Make sure that the application UI is
545 * src/maemo/easysetup/modest-easysetup-wizard.c:
546 (on_entry_invalid_character): Show the word whitespace instead
547 of (null) in the banner when whitespace was entered.
548 (show_error): Add a comment that this does not work in
549 Maemo Bora, though we do not know why.
551 2007-07-23 Murray Cumming <murrayc@murrayc.com>
553 * src/modest-tny-account.c:
554 (modest_tny_account_get_special_folder): Use an if instead of
555 an assert for when the parent account name is NULL, because this
556 might be causing a crash in projects.maemo.org bug 63192.
557 * src/modest-mail-operation.c:
558 (modest_mail_operation_send_new_mail_cb),
559 (modest_mail_operation_remove_folder): unref the folder that is
560 returned from modest_tny_account_get_special_folder().
562 2007-07-23 Murray Cumming <murrayc@murrayc.com>
564 * src/modest-ui-actions.c:
565 (modest_ui_actions_on_password_requested):
566 Show mail_ib_login_cancelled info banner when the user cancels
567 the protected password dialog, to fix projects.maemo.org
570 2007-07-23 Murray Cumming <murrayc@murrayc.com>
572 * src/maemo/modest-account-settings-dialog.c:
573 (create_page_outgoing): Put this page in a GtkScrolledWindow,
574 matching the UI mock-up in the UI spec, and allowing access
575 to all widgets even when the on-screen keyboard is active.
577 2007-07-23 Murray Cumming <murrayc@murrayc.com>
579 Reverted this previous commit from Johannes,
580 because the scrollbars are always visible and because
581 I think we only need it on onepage of the account
582 settings, not the account wizard.
583 (I wrote the wrong instructions in the bug.)
585 * src/maemo/easysetup/modest-easysetup-wizard.c:
586 Added scrollbars to account wizard dialog.
587 Fixed projects.maemo.org NB #62744
589 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
591 * src/maemo/easysetup/modest-easysetup-wizard.c:
592 (create_page_user_details):
593 Use auto-cap for name (projects.maemo.org NB#63716)
594 * src/widgets/modest-account-view.c: (on_account_busy_changed):
596 2007-07-22 Armin Burgmeier <armin@openismus.com>
598 * src/maemo/modest-ui-actions.c: Use current account instead of
599 default account for creating viewer windows, so that the viewer
600 window knows to which account the viewed message belongs.
602 * src/maemo/modest-msg-view-window.c: Destroy the window when the
603 corresponding account is deleted. This fixes projects.maemo.org bug
606 2007-07-18 Armin Burgmeier <armin@openismus.com>
608 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
609 the dialog close after entering an invalid port number and clicking
610 OK. This fixes projects.maemo.org bug NB#63602.
612 2007-07-18 Armin Burgmeier <armin@openismus.com>
614 * src/modest-tny-account-store.c:
615 (get_server_accounts): Set parent modest account name for each
616 connection-specific transport account so that special folders of such
617 an account can be looked up. This fixes a crash when changing account
618 settings. This might also be related to projects.maemo.org bug
621 2007-07-16 Armin Burgmeier <armin@openismus.com>
623 * src/modest-ui-actions.c: Added a button to create a folder to the
624 move-to dialog. This fixes projects.maemo.org bug NB#59863.
626 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
628 * src/maemo/easysetup/modest-easysetup-wizard.c:
629 Added scrollbars to account wizard dialog.
630 Fixed projects.maemo.org NB #62744
632 2007-07-16 Murray Cumming <murrayc@murrayc.com>
634 * src/widgets/modest-msg-view.h:
635 * src/widgets/modest-msg-view.c:
636 Added modest_msg_view_get_message_is_empty() but this needs
638 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
639 Check if there is any text in the message yet.
640 But this needs to be implemented properly.
641 (modest_msg_edit_window_toggle_find_toolbar):
642 * src/maemo/modest-msg-view-window.c:
643 (modest_msg_view_window_toggle_find_toolbar):
644 Show a banner warning if there is no text to search, when
645 trying to start a search. This partially fixes
646 projects.maemo.org bug NB#62350.
648 2007-07-13 Murray Cumming <murrayc@murrayc.com>
650 * src/modest-mail-operation.c: (update_account_thread):
651 Initialized num_new_headers to fix the build.
653 2007-07-13 Murray Cumming <murrayc@murrayc.com>
655 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
656 Ignore modest accounts whose server accounts don't exist in gconf.
657 This prevents us trying to create TnyAccount instances for those
658 server accounts when the server account has been removed from gconf,
659 but the parent modest account has not yet been removed from modest.
660 I don't know why this is only noticeable now. It was probably just
661 a harmeless g_warning() anyway.
663 2007-07-13 Murray Cumming <murrayc@murrayc.com>
665 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
666 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
668 2007-07-12 Armin Burgmeier <armin@openismus.com>
670 * src/maemo/modest-main-window.c: Make default account appear bold
671 in view, tools/send & receive and toolbar/send & receive SCM menus.
672 This fixes projects.maemo.org bug NB#59010.
674 2007-07-12 Murray Cumming <murrayc@murrayc.com>
676 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
677 Add a short-cut, by checking if the folder store is an account.
678 This ensures that the Sort menu item and toolbar is dimmed for
679 the local-folders account root item, fixing
680 projects.maemo.org bug NB#62545.
682 2007-07-12 Murray Cumming <murrayc@murrayc.com>
684 * src/modest-tny-account-store.c: (get_password):
685 Show the password dialog (via the signal) only in the mainloop, via
686 an idle handler that we wait for. This could theoretically prevent
687 hangs, though I worry that it could introduce some too.
689 2007-07-12 Murray Cumming <murrayc@murrayc.com>
691 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
692 * src/maemo/modest-platform.c:
693 (modest_platform_connect_and_wait):
694 Take a TnyAccount* parameter and try to set it to online
695 (a TnyCamel-only API), because tinymail sets accounts to offline
696 when the user cancels a password dialog, and doesn't ask again until
697 it has been set to online.
698 However, this is commented out because it causes a hang now.
700 (modest_platform_connect_and_wait_if_network_account):
701 * src/modest-mail-operation.c:
702 (modest_mail_operation_update_account):
703 * src/modest-platform.h:
704 * src/modest-ui-actions.c: (_modest_ui_actions_open),
705 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
707 2007-07-12 Armin Burgmeier <armin@openismus.com>
709 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
711 * src/modest-mail-operation.c:
712 * src/modest-ui-actions.c: Check for already existing folder before
713 querying the server, show error message from camel if the request
714 still fails. This fixes projects.maemo.org bug NB#58701.
716 2007-07-12 Murray Cumming <murrayc@murrayc.com>
718 * src/modest-tny-account-store.h:
719 * src/modest-tny-account-store.c:
720 Added modest_tny_account_store_forget_password_in_memory(),
721 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
722 when creating a new account, so that new passwords will be used, instead of
723 us thinking that it's a second request as a result of a failed password again.
725 2007-07-12 Murray Cumming <murrayc@murrayc.com>
727 * src/dbus_api/modest-dbus-callbacks.c:
728 (on_idle_open_message): If the message is in drafts then open it
729 in an edit window instead of a view window. This fixes
730 projects.maemo.org bug NB#63005.
732 2007-07-12 Murray Cumming <murrayc@murrayc.com>
734 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
735 Avoided a harmless g_warning().
737 2007-07-12 Murray Cumming <murrayc@murrayc.com>
739 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
740 Pass the modest account name, not the TnyAccount display name to
741 modest_msg_view_window_new() so that the reply feature works,
742 fixing projects.maemo.org bug NB#62892.
744 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
745 (modest_msg_view_window_new_with_header_model):
746 * src/maemo/modest-msg-view-window.c:
747 (modest_msg_view_window_new_with_header_model),
748 (modest_msg_view_window_new):
749 * src/modest-ui-actions.c: (reply_forward):
750 * src/widgets/modest-msg-view-window.h:
751 * src/widgets/modest-window.c: (modest_window_set_active_account):
752 Rename an account parameter to modest_account_name to make this clearer.
754 2007-07-11 Murray Cumming <murrayc@murrayc.com>
756 * src/modest-ui-actions.h:
757 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
758 modest_do_message_delete().
759 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
760 Call modest_do_message_delete(), hoping that this would cause messages
761 to be really deleted from search instead of just marked with strike through.
762 Does not seem to help.
764 2007-07-11 Armin Burgmeier <armin@openismus.com>
766 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
767 priv->reselect to FALSE prior to calling
768 modest_folder_view_select_first_inbox_or_local() to prevent endless
769 recursion and thus a crash on startup.
771 2007-07-11 Armin Burgmeier <armin@openismus.com>
773 * src/maemo/modest-account-settings-dialog.h: Include
774 <gtk/gtknotebook.h> to fix the build (at least for me).
776 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
777 Use "New FolderN" as default suggested name if "New folder" already
778 exists, with N being the first free number, though never exceed "New
779 folder99" in which case we just fall back to "New Folder" even though
780 it already exists. This fixes projects.maemo.org bug NB#58663.
782 2007-07-11 Murray Cumming <murrayc@murrayc.com>
784 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
785 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
786 projects.maemo.org bug NB#62778.
788 2007-07-11 Murray Cumming <murrayc@murrayc.com>
790 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
791 Ignore the wrong (for now) secure-smtp setting in the presets -
792 just default to requiring secure authentication for SMTP, because
795 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
797 * src/widgets/modest-folder-view.c: (filter_row)
798 Do not show drafts folder (see UI specs)
800 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
802 * src/modest-ui-actions.c:
803 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
804 place and also not necessary.
806 * src/widgets/modest-folder-view.c: (filter_row)
807 Guess folder type and hide Sent & Outbox if necessary.
808 Fixed project.maemo.org NB#57328
810 2007-07-11 Murray Cumming <murrayc@murrayc.com>
812 * src/modest-ui-actions.h:
813 * src/modest-ui-actions.c:
814 (modest_ui_actions_on_delete_message):
815 Move some code into a new
816 modest_ui_actions_refresh_message_window_after_delete()
817 function so we can use it from elsewhere.
819 * src/dbus_api/modest-dbus-callbacks.c:
820 (on_idle_delete_message), (on_delete_message): Used an idle
821 handler, as we do for the other D-Bus method handlers.
822 Call modest_ui_actions_refresh_message_window_after_delete()
823 if the deleted message was open in a window. This fixed
824 projects.maemo.org bug NB#62862.
826 2007-07-11 Murray Cumming <murrayc@murrayc.com>
828 * src/modest-main.c: (main): Only show the UI at the start if
829 the showui command line option was given. For instance,
830 run-standalone src/modest showui
831 Otherwise, we wait for the top_application D-Bus method to
832 be sent by hildon-desktop when the application is selected
834 This allows us to run without a UI when osso-global-search
835 uses our D-Bus methods.
837 2007-07-11 Murray Cumming <murrayc@murrayc.com>
839 * src/dbus_api/modest-dbus-api.h: Added a define for a
840 top-application D-Bus method.
841 * src/dbus_api/modest-dbus-callbacks.c:
842 (on_top_application),
843 (modest_dbus_req_handler): Handle the top-application D-Bus
844 method, which might be an undocumented D-Bus signal sent by
845 hildon-desktop when it starts the application from the menu.
846 But I am not sure and I need to test it on the device, because
847 my scratchbox does not have the application in the menu now.
848 This method shows the main window, so that it can be invisible
849 when started, for instance, just for email searching from
852 * src/maemo/modest-main-window.c: (restore_settings),
853 (modest_main_window_new): Do not show the window immediately
854 upon creation. We show it later.
855 * src/modest-widget-memory.c: (save_settings_paned):
856 Try (unsuccessfully) to avoid saving the paned position when
857 it is not even visible.
858 (restore_settings_paned): Do not allow a silly paned position.
859 This seems necessary when not showing the window at first.
861 * tests/dbus_api/Makefile.am:
862 * tests/dbus_api/test_top_application.c: (main): Test for the
865 2007-07-10 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-ui-dimming-rules.c:
868 (modest_ui_dimming_rules_on_new_msg),
869 (modest_ui_dimming_rules_on_reply_msg),
870 (modest_ui_dimming_rules_on_delete_msg),
871 (modest_ui_dimming_rules_on_details),
872 (modest_ui_dimming_rules_on_view_window_move_to),
873 (modest_ui_dimming_rules_on_view_previous),
874 (modest_ui_dimming_rules_on_view_next),
875 (_invalid_folder_for_purge): Added checks before
876 casting the window. This looks like an actual
877 logic error in _invalid_folder_for_purge(), because it
878 tries to use a ModestMainWindow as a message window.
880 2007-07-10 Murray Cumming <murrayc@murrayc.com>
882 * src/maemo/modest-account-settings-dialog.c:
883 (show_error): Use the same implementation as in
884 modest-easysetup-wizard.c:
885 (on_entry_invalid_character): The logical ID contains a %s.
886 Guessed what it should be.
887 (on_entry_max), (check_data), (on_response): Adapt to
888 changed show_error().
889 (create_page_account_details): Really call
890 modest_validating_entry_set_func() on the correct widgets.
891 * src/maemo/easysetup/modest-easysetup-wizard.c:
892 (on_entry_invalid_character): Fix the logical ID here too.
893 (create_page_account_details),
894 (create_page_user_details):
896 modest_validating_entry_set_func() on the correct widgets.
898 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
899 Do not try to use the account if it is NULL.
901 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
903 * src/modest-ui-actions.c: (create_move_to_dialog),
904 (modest_ui_actions_on_main_window_move_to),
905 (modest_ui_actions_on_msg_view_window_move_to):
906 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
907 (filter_row), (modest_folder_view_show_non_move_folders):
908 * src/widgets/modest-folder-view.h:
910 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
911 the Sent folder yet as it does not report the correct folder type.
913 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
915 * src/maemo/modest-msg-edit-window.c: (init_window):
918 2007-07-10 Murray Cumming <murrayc@murrayc.com>
920 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
921 Take a parent widget instead of a parent window, and
922 implement this with hildon_banner_show_information() instead.
923 Non-Maemo builds can just ifdef that there.
924 This fixed projects.maemo.org bug NB#62766.
926 (on_entry_invalid_character): Use show_error() again instead
927 of using hildon directly, and use the _CS() macro to use the correct
929 (create_account), (check_for_supported_auth_methods), (on_entry_max):
930 Pass a widget instead od a window to show_error().
932 2007-07-10 Murray Cumming <murrayc@murrayc.com>
934 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
935 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
936 This allows us to show the server name in the error message, fixing
937 projects.maemo.org bug NB#62904.
938 Also, use the appropriate logical ID message for the account protocol.
940 2007-07-10 Murray Cumming <murrayc@murrayc.com>
942 * src/modest-tny-account-store.c: (on_idle_wrong_password):
943 A compilation fix, though the build wasn't broken for me.
945 2007-07-09 Murray Cumming <murrayc@murrayc.com>
947 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
948 Do not try to unref a NULL folder store, to avoid a runtime warning.
949 This seems to happen sometimes when changing accounts settings.
951 2007-07-09 Murray Cumming <murrayc@murrayc.com>
953 * src/modest-tny-account-store.c:
954 (modest_tny_account_store_instance_init),
955 (modest_tny_account_store_finalize),
956 (on_account_settings_hide), (on_idle_wrong_password):
957 Use a GHashTable to ensure that we only show one account settings
958 dialog per modest account. This avoids us having a dialog open for
959 both the store and transport accounts, or due to repeated get_password()
960 calls that shouldn't happen anyway.
962 2007-07-09 Murray Cumming <murrayc@murrayc.com>
964 * src/maemo/modest-maemo-utils.c: (on_hide),
965 (modest_maemo_show_dialog_and_forget): Handle the response, because
966 the window is not even hidden by default.
968 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
969 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
970 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
971 which seems to prevent some modality problems.
973 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
974 Ignore user cancellation errors.
976 * src/modest-account-mgr-helpers.h:
977 * src/modest-account-mgr-helpers.c:
978 Added modest_server_account_get_password() and
979 modest_server_account_get_has_password() to avoid direct use of
982 * src/maemo/modest-account-settings-dialog.h:
983 * src/maemo/modest-account-settings-dialog.c:
984 (modest_account_settings_dialog_init): Store the notebook so we can
986 Added modest_account_settings_dialog_switch_to_user_info().
988 * src/modest-tny-account-store.c:
989 (get_password): When the password in the account settings is wrong (we think),
990 show the relevant page of the account settings dialog, in the mainloop.
991 However, we currently get many of these at once because cancel does not
993 (forget_password): Do not forget the password
994 from the account settings, because this causes side-effects when
995 tinymail seems to call it at strange time, maybe because of how we
996 are cancelling get_password().
997 (modest_tny_account_store_alert): Ignore user cancellations.
999 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1001 * src/maemo/modest-maemo-utils.h:
1002 * src/maemo/modest-maemo-utils.c:
1003 Added modest_maemo_show_information_note_and_forget() for use instead of
1004 gtk_dialog_run() when the response is not needed, to avoid an extra
1005 mainloop which could cause a hang.
1007 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1008 Use the logical IDs for the error message, though they are not
1009 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1010 because gtk_dialog_run() caused a hang here (the window did not close).
1011 This fixes projects.maemo.org bug NB#62646.
1013 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1015 * src/modest-account-mgr-helpers.h:
1016 * src/modest-account-mgr-helpers.c:
1017 Added modest_account_mgr_get_store_protocol().
1019 * src/maemo/modest-account-view-window.c:
1020 (on_delete_button_clicked): Show different warning text depending on
1021 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1022 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1025 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1027 * src/maemo/modest-msg-edit-window.c:
1028 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1029 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1031 2007-07-07 Armin Burgmeier <armin@openismus.com>
1033 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1034 ckdg_ib_maximum_characters_reached from correct package.
1036 * src/modest-ui-actions.c: Show an error message when a folder could
1037 not be created. Tinymail does not give us specific error codes about
1038 what has gone wrong, so we assume that a folder with that name
1039 already exists, though there might be other reasons.
1041 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1043 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1044 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1045 give a more exact error message that can be partly translated.
1047 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1049 * src/maemo/modest-address-book.c:
1050 (select_email_addrs_for_contact): Specify a default window size for the
1051 select-email-address dialog, so that it is probably big enough for the
1052 title. This should fix projects.maemo.org bug NB#62277.
1054 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1056 * src/maemo/easysetup/modest-easysetup-wizard.c:
1057 (create_page_complete_easysetup): Use
1058 gtk_widget_set_size() request to ensure that the text wraps
1061 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1063 * src/maemo/easysetup/modest-easysetup-wizard.c:
1064 (on_entry_invalid_character), (create_page_account_details),
1065 (create_page_user_details):
1066 Use new API of ModestValidatingEntry. But for some reason the banner is
1067 not shown. I will have to investigate that further.
1069 * src/widgets/modest-validating-entry.c: (on_insert_text),
1070 (modest_validating_entry_set_func):
1071 * src/widgets/modest-validating-entry.h:
1072 Added a new callback function to be able to react to prevented
1073 characters whitespaces to e.g show a banner.
1075 2007-07-05 Armin Burgmeier <armin@openismus.com>
1077 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1078 notification of HildonNumberEditor instead of remembering the port
1079 number. Thanks to Johannes for pointing this out.
1081 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1083 * src/maemo/easysetup/modest-easysetup-wizard.c:
1084 Check if there are any user changes before showing a confirmation
1085 dialog (projects.maemo.org NB#60946)
1087 2007-07-05 Armin Burgmeier <armin@openismus.com>
1089 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1090 number at the beginning of the dialog and set the modified flag at the
1091 end if the port number has changed. This is necessary because
1092 HildonNumberEditor does not support notification when the value has
1095 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1097 * src/modest-ui-actions.c:
1098 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1099 a connection before asking anything else. Correct the check for the destination
1100 folder so that it succeeds when online.
1101 This fixed projects.maemo.org bug NB#61645.
1103 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1105 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1106 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1107 to fix projects.maemo.org bug NB#62439.
1109 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1111 * src/modest-tny-account.c: (on_connection_status_changed):
1112 Really do not use tny_device_force_offline() here. See the previous comment.
1114 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1116 * src/modest-tny-account.c: (on_connection_status_changed):
1117 Do not use tny_device_force_offline() when tinymail says that something
1118 went wrong with the connection. It seems to report this unnecessarily.
1120 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1122 * src/maemo/modest-connection-specific-smtp-window.c:
1123 (modest_connection_specific_smtp_window_init):
1124 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1125 does not seem to have any effect in osso 1.1 (though it works in
1126 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1128 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1130 * src/maemo/modest-connection-specific-smtp-window.c:
1131 Fix UI specification problems with projects.meamo.org NB#60479
1133 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1135 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1136 clue when this has failed, because the error dialog is not always shown
1137 (at least in earlier version).
1139 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1140 GError message, because the generic error dialog is not helpful.
1142 'This message is not currently available (can't let a new connection go online)'
1143 when trying to open an IMAP message.
1145 (_modest_ui_actions_open): Offer a connection when some messages would
1146 have to be downloaded and we are offline.
1148 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1150 * src/widgets/modest-folder-view.c:
1151 Don't check for MERGE type anymore as we use the correct type
1153 NOTE: For the last two changes you need to update your tinymail copy
1154 because of API changes!
1156 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1158 * src/modest-tny-local-folders-account.c:
1159 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1160 (see projects.maemo.org NB#61580)
1162 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1164 * src/modest-tny-account.c: (on_connection_status_changed):
1165 Commented out the call to modest_platform_connect_and_wait() because this
1166 seems to always hang, and I would like to know if this is the only thing
1167 that causes a hang when showing the connection dialog.
1168 It is not very useful anyway.
1170 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1172 * src/maemo/modest-msg-view-window.c:
1173 (modest_msg_view_window_select_next_message):
1175 * src/modest-platform.h:
1176 * src/maemo/modest-platform.c:
1177 Added modest_platform_connect_and_wait(), which calls
1178 tny_maemo_conic_device_connect() always in the main thread, by calling it
1179 in an idle handler and waiting for the idle handler to run. It should be
1180 in the main thread because it uses GTK+ UI code. It just returns TRUE
1181 if the device is already online.
1183 There is some nasty code to ensure that subsequent calls to
1184 modest_platform_connect_and_wait() just wait for the first one to finish,
1185 by checking repeatedly in another idle handler. This is necessary,
1186 because other threads (or even the main thread, via another idle handler)
1187 can call modest_platform_connect_and_wait() while
1188 modest_platform_connect_and_wait() is running.
1190 (modest_platform_connect_and_wait_if_network_account),
1191 (modest_platform_connect_and_wait_if_network_folderstore):
1192 Convenience functions that calls modest_platform_connect_and_wait() if
1193 the account or folder might want network access.
1195 * src/modest-mail-operation.c:
1196 (modest_mail_operation_update_account):
1197 * src/modest-ui-actions.c: (download_uncached_messages),
1198 (modest_ui_actions_on_rename_folder), (delete_folder),
1199 (modest_ui_actions_on_main_window_move_to),
1200 (modest_ui_actions_on_msg_view_window_move_to):
1201 * src/widgets/modest-folder-view.c:
1202 (drag_and_drop_from_folder_view):
1203 Offer a connection if we are offline.
1205 * src/modest-tny-account.c: (on_connection_status_changed):
1206 Document this as only handling errors during network operations in progress,
1207 and replace the idle code with a simple call to
1208 modest_platform_connect_and_wait(), which does this instead.
1210 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1212 * src/modest-tny-account.c:
1213 (modest_tny_account_get_special_folder): (util_on_idle),
1214 Handle the GError so we can see when tny_folder_store_get_folders()
1215 fails, as it currently does while something else is connecting.
1217 Added util_run_in_main_thread_and_wait()
1218 which uses an idlen handler and mainloop to ensure that the function
1219 is called in the main thread.
1220 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1221 to make sure that we call attempt the connection in the mainloop only,
1222 which might solve some hangs.
1224 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1226 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1227 be found by their display name. This is never useful.
1228 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1229 by its ID, instead of trying to use its ID as its display name.
1231 * src/modest-tny-account-store.h:
1232 * src/modest-tny-account.c:
1233 (modest_tny_account_get_special_folder): Add a g_warning() when
1234 tny_folder_store_get_folders() returns an empty list for the maildir.
1236 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1237 Add a g_warning() when this returns NULL, because that it not allowed
1240 2007-07-02 Armin Burgmeier <armin@openismus.com>
1242 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1243 note when trying to cancel the wizard. This fixes projects.maemo.org
1246 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1248 * src/modest-tny-account.h:
1249 * src/modest-tny-account.c:
1250 (modest_tny_account_new_from_server_account),
1251 (modest_tny_account_new_from_server_account_name),
1252 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1253 because this must now be set before setting the proto. This is usd in
1254 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1255 warning in camel_session_get_service() caused by
1256 tny_camel_transport_account_prepare().
1258 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1261 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1263 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1265 (modest_connection_specific_smtp_edit_window_init):
1267 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1268 of "changed" for now
1270 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1272 * src/modest-tny-account.c:
1273 (modest_tny_account_new_from_server_account):
1274 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1275 now uses to request a connection when it needs one, and which it uses
1276 to tell us that something is wrong with the connection, so we can force
1277 the accounts offline to prevent further problems.
1279 * src/modest-defs.h:
1280 * src/modest-init.c: (init_default_settings):
1281 * src/modest-mail-operation.c:
1282 (modest_mail_operation_update_account):
1283 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1284 This should not be necessary anymore. Do not set the conf key that
1285 determined this (it was always TRUE and not set anywhere else).
1287 * src/modest-ui-actions.h: Remove unused and unimplemented
1288 modest_ui_actions_on_online_toggle_toggled().
1290 2007-06-29 Murray Cumming <murrayc@murrayc.com
1292 * src/maemo/modest-main-window.c: (connect_signals):
1293 Don't connect to delete_event twice. Maybe this was harmless.
1295 2007-06-29 Murray Cumming <murrayc@murrayc.com
1297 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1298 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1299 Debug output to give some more clue when a folder move is not allowed.
1301 2007-06-28 Murray Cumming <murrayc@murrayc.com
1303 * src/modest-tny-account.c: (on_modest_file_system_info),
1304 (modest_tny_account_get_mmc_account_name):
1305 Always call the callback, without checking whether the name has changed.
1306 * src/widgets/modest-folder-view.c: (strings_are_equal),
1307 (on_model_foreach_set_name), (on_get_mmc_account_name),
1308 (text_cell_data): Compare the name here, and use the name from
1309 the account rather than from the
1310 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1311 if the name was changed after the account was added to the model.
1312 That's a tinymail bug but not one that I want to fix now.
1314 This finally fixes projects.maemo.org bug NB#59301.
1316 2007-06-27 Armin Burgmeier <armin@openismus.com>
1318 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1321 2007-06-27 Murray Cumming <murrayc@murrayc.com
1323 * src/modest-tny-account.h:
1324 * src/modest-tny-account.c:
1325 Added modest_tny_account_get_mmc_account_name(), to set the memory
1326 card name asynchronously for the given account and then notify.
1327 (modest_tny_account_new_for_local_folders): Use this new function instead
1328 of using hildon_file_system_info_async_new() directly.
1330 * src/widgets/modest-folder-view.c: (text_cell_data):
1331 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1332 gtk_tree_model_row_changed() when it is available.
1334 This should fix projects.maemo.org bug NB#59301.
1336 2007-06-27 Murray Cumming <murrayc@murrayc.com
1338 * src/modest-mail-operation.c: (update_account_thread),
1339 (get_msgs_full_thread): Fix typo failures in the revert
1342 2007-06-27 Murray Cumming <murrayc@murrayc.com
1344 * src/maemo/modest-maemo-global-settings-dialog.c:
1345 (idle_select_default_focus):
1346 * src/modest-mail-operation.c: (idle_notify_progress),
1347 (idle_notify_progress_once), (set_last_updated_idle),
1348 (update_account_thread), (get_msgs_full_thread):
1349 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1350 * src/widgets/modest-header-view.c:
1351 (idle_notify_headers_count_changed_destroy),
1352 (idle_notify_headers_count_changed):
1353 Reverted the additions of gdk_threads_enter/leave(), in case this
1354 helps with a startup hang on the device.
1356 2007-06-26 Armin Burgmeier <armin@openismus.com>
1358 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1359 for supported secure authentication methods from server by
1360 gtk_dialog_run(), saving CPU time and a potential race condition.
1362 2007-06-26 Armin Burgmeier <armin@openismus.com>
1364 * src/maemo/modest-maemo-utils.h:
1365 * src/maemo/modest-maemo-utils.c: Added a
1366 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1367 only error code to tell the calling code when the user canceled the
1370 * src/maemo/modest-account-settings-dialog.h:
1371 * src/maemo/modest-account-settings-dialog.c:
1372 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1373 message if the retrieval of secure authentication methods was canceled
1374 by the user. Perform the check before saving anything to configuration
1375 to not end up with half-committed configuration changes, do not show
1376 a "Saving to configuration failed" note when authentication methods
1377 could not be retrieved.
1379 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1382 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1384 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1385 Only return the first level of folders under accounts, because the
1386 osso-global-search UI spec doesn't want the rest.
1387 This fixed projects.maemo.org bug NB#61811.
1389 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1391 * src/modest-tny-account-store.c:
1392 * src/modest-tny-account-store.h:
1393 Added modest_tny_account_is_memory_card_account().
1394 * src/maemo/modest-main-window.c: (create_details_widget):
1395 Show the same information items for the memory card as we show for the
1396 local-folders, to fix projects.maemo.org bug NB#59307.
1398 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1400 * src/modest-tny-account-store.c: (get_password):
1401 Added some checks for NULL to maybe prevent crashes, though I think
1402 it was Philip's last commit that actually prevented the crash here
1403 when creating a first new account.
1404 But the new account is still not usable (no messages are shown)
1405 until a restart of the application.
1407 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1409 * src/maemo/modest-maemo-global-settings-dialog.c:
1410 (idle_select_default_focus):
1411 * src/modest-mail-operation.c: (idle_notify_progress),
1412 (idle_notify_progress_once), (idle_notify_update_account_queue),
1413 (set_last_updated_idle), (update_account_thread),
1414 (notify_get_msgs_full), (get_msgs_full_destroyer),
1415 (get_msgs_full_thread):
1416 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1417 * src/widgets/modest-header-view.c:
1418 (idle_notify_headers_count_changed_destroy),
1419 (idle_notify_headers_count_changed):
1420 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1421 all idle handlers, because some other thread could be blocking
1422 the GDK lock, so that it can do GUI stuff.
1424 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1426 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1427 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1428 (on_idle_send_receive), (on_idle_open_default_inbox):
1429 * src/maemo/modest-msg-edit-window.c:
1430 (modest_msg_edit_window_attach_file_noninteractive):
1431 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1432 to prevent a hang. I don't quite understand why these are necessary,
1433 beause we should already be in the main loop. I guess something outside
1434 of the main loop is taking the lock.
1436 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1437 we are really using URIs, and use files that are more likely to exist.
1439 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1441 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1442 necessary because configure.ac now defines different variables.
1444 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1446 * libmodest-dbus-client/libmodest-dbus-client.c:
1447 * libmodest-dbus-client/libmodest-dbus-client.h:
1448 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1449 libmodest_dbus_client_compose_mail() is what things actually use.
1451 * src/dbus_api/modest-dbus-api.h:
1452 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1453 * tests/dbus_api/Makefile.am:
1454 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1457 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1459 * src/modest-init.c: (modest_init_local_folders):
1460 For memory-card (or other non local-folders) maildir accounts,
1461 always create an Archive folder, so that there is somewhere to put
1462 messages. This should be less confusing, because the user does not need
1463 to guess that the need to create a folder.
1465 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1467 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1468 Fixed icon size by using (50, 50) which is the same as defined by
1471 2007-06-25 Armin Burgmeier <armin@openismus.com>
1473 * src/widgets/modest-window-mgr.c:
1474 * src/modest-init.c:
1475 * configure.ac: Correctly recognize hildon-notify presence and fixed
1476 the build without it being installed.
1478 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1480 * libmodest-dbus-client/libmodest-dbus-client.c:
1481 (libmodest_dbus_client_search): Fix the build. Sorry.
1482 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1483 (reply_forward_cb): Initialize variables to fix the build.
1485 * src/modest-tny-account-store.c:
1486 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1487 comparison (a silly typo) so that email search results can be opened
1488 when there are more than one account.
1490 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1492 * libmodest-dbus-client/libmodest-dbus-client.c:
1493 (libmodest_dbus_client_search),
1494 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1495 instead of 1 second, because the search gets folders and messages from
1496 the server, which can take a long time. When it times out,
1497 osso-global-search will report no results.
1499 We need to specify whether we should search only cached information
1500 (maybe with a user preference), and the osso-email-search-plugin
1501 API should really be improved to allow that option, and to allow results
1502 to be delivered asynchronously in batches.
1504 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1506 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1507 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1508 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1510 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1512 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1513 that is an empty string. D-Bus seems to give us these instead of NULL.
1515 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1517 * src/dbus_api/modest-dbus-callbacks.c:
1518 * src/maemo/easysetup/modest-easysetup-wizard.h:
1519 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1520 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1521 (modest_connection_specific_smtp_edit_window_init):
1522 * src/maemo/modest-maemo-global-settings-dialog.c:
1524 * src/maemo/modest-maemo-utils.c:
1525 (modest_maemo_utils_setup_images_filechooser):
1526 * src/maemo/modest-main-window.c: (create_details_widget):
1527 * src/maemo/modest-msg-edit-window.c:
1528 (modest_msg_edit_window_attach_file_noninteractive),
1529 (modest_msg_edit_window_color_button_change),
1530 (modest_msg_edit_window_set_zoom):
1531 * src/modest-mail-operation.c: (update_account_thread):
1532 * src/modest-tny-account-store.c:
1533 * src/modest-tny-account.c:
1534 * src/widgets/modest-global-settings-dialog.c:
1535 * src/widgets/modest-window.h:
1537 Fixed build on bora!
1539 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1541 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1542 * src/modest-search.c: (modest_search_folder),
1543 (modest_search_all_accounts): Actually search only in the specified folder,
1544 doing a simple match on the folder ID.
1545 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1546 and added some documentation.
1548 2007-06-22 Armin Burgmeier <armin@openismus.com>
1550 * src/maemo/modest-maemo-utils.h:
1551 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1552 modest_maemo_utils_get_supported_secure_authentication_methods.
1554 * src/maemo/easysetup/modest-easysetup-wizard.c:
1555 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1556 one occured, not just "Server does not support secure authentication".
1558 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1560 * src/modest-tny-account-store.c: (get_password):
1561 Restored the call to tny_account_set_user() because Philip seems to have
1562 stopped this from crashing (by not using the freed string). It still does
1563 not work, but now we can test it.
1565 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1567 * src/maemo/modest-msg-edit-window.c: (init_window):
1568 Comment out use of an uninitialzed GtkScrolledWindow variable,
1569 to fix the build and stop a crash. Yet again.
1571 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1573 * src/modest-tny-account-store.c: (get_password):
1574 Remove the call to tny_account_set_user() because this actually crashes.
1575 As mentioned in the last commit, it is known to not work anyway.
1577 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1579 * src/modest-tny-account-store.c: (get_password):
1580 Use tny_account_set_username() to tell tinymail that the username might
1581 have changed too. But tinymail ignores this: see projects.maemo.org
1583 * src/modest-ui-actions.c:
1584 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1585 reset the connection when changing the username, and improve the comments.
1586 Save the changed username to gconf at least, so it is used when Modest is
1589 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1591 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1592 Do not use a query, so that we get all folders, including for POP and
1593 local-folders. They work as search criteria too.
1594 This fixes projects.maemo.org bug NB#57740.
1596 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1598 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1599 Comment out the use of hildon_notification_set_sound() because it is
1600 not declared, to fix the build. Warnings are serious, people.
1602 2007-06-21 Armin Burgmeier <armin@openismus.com>
1604 * src/maemo/modest-maemo-utils.h:
1605 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1606 modest_maemo_utils_get_supported_secure_authentication_methods()
1607 to query authentication methods for a specific user. This should fix
1608 projects.maemo.org bug NB#61369.
1610 * src/maemo/easysetup/modest-easysetup-wizard.c:
1611 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1614 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1616 * libmodest-dbus-client/libmodest-dbus-client.h:
1617 * libmodest-dbus-client/libmodest-dbus-client.c:
1618 (modest_dbus_message_iter_get_search_hit),
1619 (libmodest_dbus_client_search):
1620 Reorganised and commented this.
1621 Removed modest_search_hit_free() from the public API because it
1624 Added libmodest_dbus_client_get_folders() and
1625 modest_folder_result_list_free().
1627 * src/dbus_api/modest-dbus-api.h:
1628 * src/dbus_api/modest-dbus-callbacks.c:
1629 (modest_dbus_req_filter): Commented. Moved most code to
1630 on_dbus_method_search() and added on_dbus_method_get_folders().
1632 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1633 of the extra D-Bus handler.
1635 * tests/dbus_api/Makefile.am:
1636 * tests/dbus_api/test_get_folders.c: New test for
1637 libmodest_dbus_client_get_folders(). This seems to return an empty list
1638 at the moment. That could be the same error that causes the message list
1639 to be empty sometimes.
1640 This should help with projects.maemo.org bug NB#57740.
1642 2007-06-21 Armin Burgmeier <armin@openismus.com>
1644 * src/modest-mail-operation.c: Do not call
1645 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1646 notify the operation's end after having set the status to CANCELED for
1647 the operation queue to listen on. This fixes a deadlock when there
1648 were mail operations in the queue during its finalization.
1650 * src/modest-singletons.c: Reordered uninitialization of the account
1651 manager to happen after the mail operation queue was uninitialized
1652 because the mail operation's in the queue might still try to access
1653 the account manager (see modest_mail_operation_notify_end()). This
1654 fixes a potential crash when terminating the application.
1656 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1658 * src/modest-search.c:
1659 (search_mime_part_and_child_parts): Moved some code here so we
1660 can search recursively in child folders.
1661 (modest_search_folder): Search in the message as a mime part, instead
1662 of just its child mime parts.
1663 (read_chunk), (search_mime_part_ogs):
1664 Check how many bytes were read, to prevent an endless loop.
1665 Searching in message bodies now works. This finishes the fix for
1666 projects.maemo.org bug NB#61007.
1668 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1670 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1671 Add a g_warning when the item is not a folder.
1673 * src/modest-ui-dimming-rules.c:
1674 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1675 when selected item is not a folder (for instance, an account), because
1676 the UI spec only talks about folders.
1677 I am not sure what the UI spec wants, so this might not totally fix
1678 projects.maemo.org bug NB#60794.
1680 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1682 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1683 (load_from_file): Sort the list. The unsorted list would be more noticeable
1684 in non-English locales.
1686 * src/maemo/modest-msg-edit-window.c:
1687 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1688 warning and fix the build.
1690 * src/maemo/modest-progress-bar-widget.c:
1691 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1692 avoid a g_warning, and probably to avoid a crash.
1694 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1696 * src/modest-search.c: (modest_search_folder): Check for a GError
1697 when calling tny_folder_get_headers(), to show that this is not the cause
1700 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1702 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1703 Actually set the body query instead of the subject query.
1705 * src/modest-search.c: (search_mime_part_ogs),
1706 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1707 which would probably cause it to fail if we got this far.
1709 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1710 to simplify the code.
1711 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1712 be causing search-in-body to fail.
1714 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1716 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1718 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1719 Better debug message when the folder cannot be found.
1720 This should help with fixing projects.maemo.org bug #61287.
1721 * src/modest-search.c: (add_hit): Do not leak the furl string.
1723 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1725 * src/modest-ui-actions.c:
1726 (modest_ui_actions_on_folder_selection_changed):
1727 Do not special-case TNY_MERGE_FOLDER here, because
1728 modest_tny_folder_get_account() already does that. This fixes
1729 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1730 shown when the Outbox was selected).
1732 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1734 * libmodest-dbus-client/libmodest-dbus-client.c:
1735 (_dbus_iter_get_string_or_null): Initialize the string variable in
1736 case this helps with Dirk's crash.
1738 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1740 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1741 though it is not implemented yet (this function is maybe not even used),
1742 to avoid breaking ABI in future.
1743 * libmodest-dbus-client/libmodest-dbus-client.c:
1744 (get_attachments_string): Moved some code into this generic function.
1745 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1746 sends email. It is maybe not used.
1747 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1748 (on_send_mail): Use attachments.
1750 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1751 * src/maemo/modest-msg-edit-window.c:
1752 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1753 a filename before using it, to fix projects.maemo.org bug NB#58233.
1755 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1757 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1758 Initialize the continue_download variable to fix the build, and probably
1759 to fix randome behaviour.
1761 2007-06-18 Armin Burgmeier <armin@openismus.com>
1763 * src/modest-tny-send-queue.h:
1764 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1765 the queue so we can later show it in the UI. Replaced
1766 modest_tny_send_queue_msg_is_being_sent() by
1767 modest_tny_send_queue_get_msg_status().
1769 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1771 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1772 gpointer. This probably was not harmful, but just to be sure.
1774 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1776 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1777 Fix the build, but leave the function broken on Bora, because
1778 hildon_uri_action_get_service() does not exist.
1779 osso_uri_action_get_service() does not exist either, it seems.
1781 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1783 * src/modest-tny-account.c:
1784 (modest_tny_account_new_from_server_account):
1785 Uncommented the url debug output again, because it is useful for
1786 debugging, as I said in the comment.
1788 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1790 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1792 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1793 for Mameo Bora, to fix the build.
1795 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1798 Fixed build with hildon < 0.99
1800 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1801 Check if the selected account is busy instead of checking all accounts
1803 * src/modest-account-mgr-priv.h:
1804 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1805 (modest_account_mgr_init), (compare_account_name),
1806 (modest_account_mgr_set_account_busy),
1807 (modest_account_mgr_account_is_busy):
1808 * src/modest-account-mgr.h:
1809 Added busy information to the account manager. It possible to
1810 set an account to busy or not busy now.
1812 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1813 (modest_mail_operation_update_account),
1814 (modest_mail_operation_notify_end):
1815 Set the account to busy/not busy depending on the operation state.
1817 * src/widgets/modest-account-view.c:
1818 (modest_account_view_finalize), (get_last_updated_string),
1819 (update_account_view), (on_account_busy_changed), (init_view):
1820 Show string "Refreshing..." if the account is currently busy.
1822 All this fixes projects.maemo.org bug NB#59711
1824 2007-06-14 Armin Burgmeier <armin@openismus.com>
1826 * src/widgets/modest-attachments-view.h:
1827 * src/widgets/modest-attachments-view.c: Added
1828 modest_attachments_view_has_attachments() and fixed coordinate
1829 transformation in get_att_view_at_coords(). This fixes attachment
1832 * src/widgets/modest-msg-view.c: Make use of
1833 modest_attachments_view_has_attachments() to decide whether to show
1834 attachments in the header.
1836 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1839 (on_change), (on_combo_security_changed),
1840 (modest_connection_specific_smtp_edit_window_init),
1841 (modest_connection_specific_smtp_edit_window_set_connection),
1842 (modest_connection_specific_smtp_edit_window_is_dirty):
1843 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1844 * src/maemo/modest-connection-specific-smtp-window.c:
1847 Show an comfirmation dialog for the smpt-edit-window if there are
1848 unsaved changes and the user hits cancel.
1849 (projects.maemo.org bug NB#60479)
1851 2007-06-14 Armin Burgmeier <armin@openismus.com>
1853 * src/maemo/easysetup/modest-easysetup-wizard.c:
1854 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1855 address" info in banner instead of node, and select all the text as
1856 per UI spec. This fixes projects.maemo.org bug NB#60550.
1858 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1860 reviewed by: <delete if not using a buddy>
1862 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1863 * src/modest-ui-actions.c: (folder_refreshed_cb):
1865 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1867 * src/widgets/modest-folder-view.c: (filter_row):
1868 Explictly filter out the per-account outbox accounts. I don't know why
1869 these only sometimes show up, but now they should never show up in the UI.
1870 This should fix projects.maemo.org bug NB#60160.
1872 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1874 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1875 when the toolbar does not exist yet.
1876 * src/modest-widget-memory.c: (save_settings_header_view):
1877 Added g_warnings() to help us to discover when we are trying to set
1878 an empty columns list in gconf.
1880 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1882 * src/modest-init.h:
1883 * src/modest-init.c:
1884 Added modest_init_get_default_header_view_column_ids().
1886 * src/modest-widget-memory.c: (restore_settings_header_view):
1887 Use the new function to get defaults, if the gconf key is empty,
1888 instead of not creating any columns. This seems to fix the
1889 empty right-hand pane problems.
1891 * src/widgets/modest-header-view.h: Improved documentation.
1893 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1895 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1896 Revert the use of the display name as the account name, because this
1897 is generally wrong and would break the code that follows.
1899 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1901 * src/maemo/easysetup/modest-easysetup-wizard.c:
1902 (check_for_supported_auth_methods), (on_before_next),
1905 More correct fix for projects.maemo.org bug NB# 58991
1906 Do not longer accept AUTH_PASSWORD as secure method and choose
1907 correct method when creating the account.
1909 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1911 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1912 Fixed projects.maemo.org bug NB# 58991
1914 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1916 * src/modest-init.c: (modest_init_init_core),
1917 (modest_init_local_folders): Fixed compilation errors.
1919 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1921 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1922 Remove unnecessary lib/include, though it is good in principle when needed.
1924 * src/modest-init.c: (modest_init_one_local_folder),
1925 (modest_init_local_folders):
1926 * src/modest-init.h: Initialize the .modest library for memory cards,
1927 instead of just doing nothing for them. This should allow us to create
1928 folders there, fixing projects.maemo.org bug NB#59297.
1930 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1932 * libmodest-dbus-client/libmodest-dbus-client.c:
1933 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1934 (libmodest_dbus_client_compose_mail),
1935 (libmodest_dbus_client_open_message),
1936 (libmodest_dbus_client_send_and_receive),
1937 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1939 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1940 (on_idle_open_message), (modest_dbus_req_handler),
1941 (search_result_to_message), (modest_dbus_req_filter):
1942 * src/modest-search.c: (add_hit), (modest_search_folder),
1943 (modest_search_all_accounts): Improved debug messages.
1945 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1947 * src/modest-tny-account-store.c:
1948 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1951 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1954 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1956 * src/modest-tny-account-store.c: (get_server_accounts):
1957 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1958 even when there are no accounts, so that the Outbox folder is always
1959 visible. This fixes projects.maemo.org bug NB#60158.
1961 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1963 * src/maemo/modest-main-window.c: (create_details_widget):
1964 Use the mcen_va_never logical ID.
1966 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1968 * src/dbus_api/modest-dbus-api.h:
1969 * src/dbus_api/modest-dbus-callbacks.c:
1970 (on_idle_open_default_inbox), (on_open_default_inbox),
1971 (modest_dbus_req_handler):
1972 Added a new OpenDefaultInbox method.
1974 * libmodest-dbus-client/libmodest-dbus-client.h:
1975 * libmodest-dbus-client/libmodest-dbus-client.c:
1976 Added libmodest_dbus_client_open_default_inbox() to call the new
1977 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1978 though it should maybe be used by a new osso-email-interface function.
1980 * tests/dbus_api/Makefile.am:
1981 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1984 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1986 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1987 NULL, so that the signals get all the keys. This should not actually
1988 change any behaviour because we currently update everything when anything
1991 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1993 * src/widgets/modest-folder-view.c: (text_cell_data),
1994 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1995 (find_inbox_iter): If tinymail tells us that the folder is
1996 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1997 This causes the inbox to be selected at startup, fixing part of
1998 projects.maemo.org bug NB#56305.
2000 * src/modest-ui-dimming-rules.c:
2001 (modest_ui_dimming_rules_on_tools_smtp_servers):
2002 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2003 the SMTP servers menu item.
2004 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2005 that the SMTP Servers menu item is dimmed when there are no accounts,
2006 as a future version of the UI spec will require. This fixes
2007 projects.maemo.org bug NB#56305.
2009 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2011 * src/maemo/modest-maemo-utils.c:
2012 (modest_maemo_utils_get_supported_secure_authentication_methods):
2013 Added label to dialog instead of unreadable title
2015 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2016 (modest_main_window_new):
2017 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2020 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2021 * src/modest-account-mgr.h:
2022 Added method to avoid code duplication
2024 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2025 (modest_ui_actions_on_send_receive):
2026 Use modest_account_mgr_has_accounts
2028 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2030 * src/maemo/easysetup/modest-presets.c:
2031 (modest_presets_get_info_server_security): Do not report secure auth
2033 * src/modest-protocol-info.c: Use the defines for the gconf key names
2034 for secure authentication. This was not working because we were writing
2035 Password and reading password, and the check was case sensitive.
2036 With this, gmail now works for receiving and sending when created via
2039 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2041 * src/maemo/easysetup/modest-presets.c:
2042 (modest_presets_get_info_server_security): Correct the key name for
2043 SecureSmtp, because it seems to be case-sensitive.
2044 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2045 Do not try to get the 0th notebook page if there are 0 pages, to
2046 avoid a g_warning().
2048 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2050 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2051 Prevent use of the new notification feature for now, because it currently
2052 shows one dialog for each new email, which is annoying.
2054 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2056 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2057 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2058 when no country was selected, so that we show the global ones.
2059 * src/maemo/easysetup/modest-presets.c:
2060 (modest_presets_get_providers): Return only the global providers, not
2061 all providers when mmc=0 was requested.
2063 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2065 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2066 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2067 provider ID in the combo.
2069 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2070 Do not show the page numbers, because it would be confusing when we add
2071 the 2 extra pages for the custom setup, when the user chooses the "Other"
2072 provider. This fixes projects.maemo.org bug NB#59028
2074 * src/modest-init.c: (modest_init_init_core),
2075 (modest_init_local_folders):
2076 * src/modest-init.h:
2077 * src/modest-tny-account.c:
2078 (modest_tny_account_new_for_local_folders): Do not create default folders
2079 for the memory card. This should fix projects.maemo.org bug NB#59328.
2081 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2083 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2084 Free the changed_conf_keys string items. They are already freed in the
2085 idle handler if that runs first.
2087 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2089 * src/modest-ui-actions.c:
2090 (modest_ui_actions_on_password_requested): Check that the server name
2091 is not NULL, because I just saw a password dialog with (null) as the
2094 * src/modest-tny-folder.[h|c]: Added
2095 modest_tny_folder_is_memory_card_folder().
2096 * src/modest-ui-dimming-rules.c:
2097 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2098 menu item for memory cards, as per the UI spec (section 7.4). This should
2099 fix projects.maemo.org bug NB#59297.
2101 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2103 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2104 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2105 is another problem with the code, see Murray's comment at line 772)
2107 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2109 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2110 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2111 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2112 (load_from_file), (easysetup_country_combo_box_init),
2113 (easysetup_country_combo_box_get_active_country_ids),
2114 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2115 instead of just one ID, to avoid duplicate country names in the UI.
2117 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2118 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2119 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2120 a single ID, avoiding duplicate providers.
2121 * src/maemo/easysetup/modest-easysetup-wizard.c:
2122 (on_combo_account_country): Adapt to use a list.
2124 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2126 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2127 keys changed in the last X seconds.
2129 * src/modest-account-mgr.h:
2130 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2131 (on_key_change), (modest_account_mgr_class_init),
2132 (modest_account_mgr_init), (modest_account_mgr_finalize):
2133 As the keys are changed, save them in a GSList* and signal that GSList*
2134 further every X seconds, to batch changes, to allow us to do just one
2135 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2136 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2138 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2139 changed signal signature.
2141 * src/modest-conf.c: (modest_conf_set_list),
2142 (modest_conf_on_change): Reenable notification.
2144 (modest_conf_maemo_fake_on_change): Comment out the hack that
2145 notified immediately instead of asynchronously.
2147 * src/widgets/modest-account-view.h:
2148 * src/widgets/modest-account-view.c:
2149 (update_account_view): Select the previously-selected account ID,
2150 if possible. This fixes projects.maemo.org bug NB#56933.
2152 (on_account_changed), (on_account_removed),
2153 (modest_account_view_select_account):
2155 Remove the block/unblock functions
2156 because they were not useful.
2158 * src/maemo/modest-account-view-window.c:
2159 (on_delete_button_clicked), (on_edit_button_clicked),
2160 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2162 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2164 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2165 Improve the error dialog to show Incorrect Account Settings, which seems
2166 clearer, and say that the internal error message (to be removed from the
2167 dialog later) is often misleading.
2168 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2170 * src/modest-tny-account.c:
2171 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2172 URL because this is so useful for debugging on the device.
2174 * src/widgets/modest-serversecurity-combo-box.c:
2175 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2177 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2179 * src/modest-mail-operation.c:
2180 (modest_mail_operation_send_new_mail):
2181 Added a comment about a nasty but apparently harmless message. Details
2182 added to the wiki g_warnings() page.
2184 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2186 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2187 (modest_tny_send_queue_class_init):
2188 Do not use the priv struct because it is empty, to avoid g_warnings
2189 about a non-existant priv struct.
2191 * src/modest-tny-account-store.c:
2192 (modest_tny_account_store_get_server_account),
2193 (modest_tny_account_store_get_transport_account_for_open_connection
2194 ): Do not try to get transport server accounts for local folders,
2195 because they don't have any. This avoids a g_warning().
2197 * src/maemo/modest-main-window.c:
2198 (modest_main_window_notify_send_receive_initied),
2199 (on_configuration_key_changed):
2200 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2201 * src/modest-defs.h:
2202 * src/modest-mail-operation.c:
2203 (modest_mail_operation_update_account):
2204 * src/modest-tny-account-store.h:
2205 * src/modest-tny-account.c:
2206 (modest_tny_account_get_special_folder),
2207 (modest_tny_account_new_for_local_folders),
2208 (modest_tny_account_new_for_per_account_local_outbox_folder):
2209 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2210 * src/modest-tny-local-folders-account.c:
2211 (add_account_folders_to_merged_folder):
2212 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2213 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2214 (modest_ui_actions_on_send):
2215 * src/widgets/modest-folder-view.c: (update_model):
2216 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2217 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2218 modest_tny_account_store_get_tny_account_by_account() to
2219 modest_tny_account_store_get_server_account() to make the code clearer.
2221 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2223 * src/dbus_api/modest-dbus-api.h:
2224 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2225 * src/maemo/modest-msg-edit-window.c:
2226 (modest_msg_edit_window_attach_file_noninteractive):
2227 added g_warning in case the file to be attached does not exist
2228 * tests/dbus_api/test_compose_mail.c: (main):
2229 removed obsolete comment, added generic files as test case
2231 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2233 * src/modest-tny-account-store.c: (get_server_accounts):
2234 Create the local folders account only once, not once for each outbox, and
2235 not only when there are some outboxes.
2237 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2239 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2240 code that is causing a crash at startup. Sergio says that he is fixing this.
2242 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2244 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2245 * src/maemo/modest-account-settings-dialog.c:
2246 (create_page_outgoing),
2247 (modest_account_settings_dialog_set_account_name),
2248 (save_configuration):
2249 - Fixed handling of the "Use secure authentication" toggle to comply with
2250 the ui specification. See also projects.maemo.org bug NB#58400
2252 - Restore the Secure connection setting combo correctly when loading
2255 * src/maemo/modest-maemo-utils.c:
2256 (on_camel_account_get_supported_secure_authentication),
2257 (modest_maemo_utils_get_supported_secure_authentication_methods):
2258 Fixed a crasher if operation is canceled
2260 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2261 (modest_protocol_info_auth_is_secure):
2262 * src/modest-protocol-info.h:
2264 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2265 the sense of the "Use secure authentication" toggle.
2267 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2269 * src/modest-tny-account-store.h:
2270 * src/modest-tny-account-store.c:
2271 Added modest_tny_account_store_get_local_folders_account().
2273 * src/modest-tny-folder.h:
2274 * src/modest-tny-folder.c:
2275 (modest_tny_folder_get_account):
2276 Added this replacement for tny_folder_get_account() which returns
2277 the local-folders account for TnyMergeFolders, to avoid the
2278 warning about the unimplemented get_account_func() vfunc().
2280 (modest_tny_folder_get_rules),
2281 * src/modest-ui-actions.c:
2282 (modest_ui_actions_on_folder_selection_changed):
2283 * src/modest-mail-operation.c:
2284 (modest_mail_operation_remove_folder),
2285 (modest_mail_operation_xfer_folder),
2286 (modest_mail_operation_rename_folder),
2287 (modest_mail_operation_get_msg),
2288 (modest_mail_operation_get_msgs_full),
2289 (modest_mail_operation_remove_msg),
2290 (modest_mail_operation_xfer_msgs),
2291 (modest_mail_operation_refresh_folder):
2292 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2294 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2296 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2297 (modest_server_account_set_security):
2298 * src/modest-defs.h: Add comments explaining that our
2299 UI spec means TLS when it says Normal, so these do not look like errors.
2301 * src/modest-tny-account.c:
2302 (modest_tny_account_new_from_server_account): Use the new tinymail
2303 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2304 for TLS. This should fix projects.maemo.org bug NB#58460.
2306 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2308 * src/maemo/easysetup/modest-easysetup-wizard.c:
2309 (create_account): Correct the position of the gconf sanity check warning.
2310 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2311 of using the g_idle_add() hack, because this does not seem to be necessary
2312 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2313 caused by something other than maemo's gconf.
2314 This fixes projects.maemo.org bug #59022.
2316 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2318 * src/modest-account-mgr-helpers.c:
2319 (modest_account_mgr_get_default_account): Do not check that the account
2320 exists if there is no default account (NULL), to fix a runtime warning.
2322 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2324 * src/widgets/modest-folder-view.c: (update_model):
2325 Do not unref the treemodel before we have finished with it.
2326 This prevents a valgrind warning and an occasional crash at startup.
2328 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2330 * libmodest-dbus-client/libmodest-dbus-client.h:
2331 added libmodest_dbus_client_compose_mail()
2332 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2334 added functions needed for SendAsMail() functionality
2335 * src/maemo/modest-msg-edit-window.c:
2336 (modest_msg_edit_window_attach_file_noninteractive):
2337 non interactively attaching files to message edit window
2338 * src/widgets/modest-msg-edit-window.h:
2339 * tests/dbus_api/Makefile.am:
2340 added test_compose_mail.c
2341 * tests/dbus_api/test_compose_mail.c: (main):
2343 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2345 * src/modest-account-view.c:
2346 Fixed bug projects.maemo.org bug NB#59307
2348 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2350 * src/maemo/easysetup/modest-easysetup-wizard.c:
2351 (get_serverport_incoming), (on_before_next), (create_account):
2352 * src/maemo/modest-account-settings-dialog.c:
2353 (modest_account_settings_dialog_set_account_name):
2354 * src/maemo/modest-maemo-utils.c:
2355 (on_camel_account_get_supported_secure_authentication_status),
2356 (on_camel_account_get_supported_secure_authentication),
2357 (on_secure_auth_cancel),
2358 (modest_maemo_utils_get_supported_secure_authentication_methods):
2360 Implemented security authentication for settings and easysetup.
2362 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2364 * src/maemo/modest-main-window.c: (create_details_widget):
2365 Show the total size for memory card accounts too, instead of showing
2366 the name again. Fixes bug projects.maemo.org bug NB#59307.
2368 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2371 * src/modest-tny-simple-folder-store.c:
2372 * src/modest-tny-simple-folder-store.h: Removed.
2374 * src/modest-tny-local-folders-account.h
2375 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2376 for the local-folders maildir, with an extra TnyMergedFolder containing
2377 the folders of the per-account outbox store accounts.
2378 * src/modest-tny-account-store.c: (get_server_accounts):
2379 Add the outboxes to the special local folders account after creating it.
2381 * src/modest-tny-account.c:
2382 (modest_tny_account_new_for_local_folders): Create the derived
2383 account when creating the main local-folders account.
2385 * src/maemo/modest-main-window.c: (create_details_widget),
2386 (modest_main_window_set_contents_style):
2387 Adapted to the use of the derived account instead of the folder store.
2389 * src/modest-ui-actions.c:
2390 (modest_ui_actions_on_folder_selection_changed):
2391 * src/modest-ui-dimming-rules.c:
2392 (modest_ui_dimming_rules_on_new_folder):
2393 * src/widgets/modest-folder-view.c: (text_cell_data),
2394 (icon_cell_data), (filter_row), (update_model),
2395 (get_cmp_rows_type_pos):
2398 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2399 Do not get the priv struct, because no priv struct has been set,
2400 to avoid a runtime warning.
2402 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2403 #ifelse with #else, to fix a warning, to fix the build.
2406 2007-06-05 Christian Kellner <ckellner@openismus.com>
2408 * libmodest-dbus-client/libmodest-dbus-client.c:
2409 Fix small typo in doc (why do you always see them
2410 AFTER committing stuff?)
2413 2007-06-05 Christian Kellner <ckellner@openismus.com>
2415 * libmodest-dbus-client/libmodest-dbus-client.c:
2416 (libmodest_dbus_client_search):
2417 Initialize hit list with NULL. Also set folder list
2418 to "" if NULL was supplied.
2421 2007-06-03 Christian Kellner <ckellner@openismus.com>
2423 * libmodest-dbus-client/libmodest-dbus-client.c:
2424 (modest_search_hit_list_free):
2425 Make it save to call it with NULL.
2427 * src/dbus_api/modest-dbus-callbacks.c:
2428 * src/modest-search.c:
2429 Return full ModestSearchHits as the search result list not TnyHeader
2430 since can't be around withouth the correspoding TnyFolder.
2432 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2434 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2435 Added currently commented code to check for secure auth
2437 * src/maemo/modest-account-settings-dialog.c: (on_response),
2438 (save_configuration), (show_ok):
2439 Fixed projects.maemo.org bugs NB #59248 and #59251
2441 * src/maemo/modest-maemo-utils.c:
2442 (on_camel_account_get_supported_secure_authentication_status),
2443 (on_camel_account_get_supported_secure_authentication),
2444 (modest_maemo_utils_get_supported_secure_authentication_methods):
2445 * src/maemo/modest-maemo-utils.h:
2446 Moved get_supported_secure_authentication() method here to be able
2447 to use it from easysetup wizard.
2449 * src/modest-pair.c: (on_pair_compare_as_string):
2450 Should compare string with first part of pair and not
2451 strcmp pairs which will crash.
2453 * src/modest-protocol-info.c:
2454 (modest_protocol_info_protocol_is_store):
2455 * src/modest-protocol-info.h:
2456 Added modest_protocol_info_get_auth_protocol_name()
2458 2007-06-03 Armin Burgmeier <armin@openismus.com>
2460 * src/modest-mail-operation.c:
2461 (modest_mail_operation_get_msgs_full): Set priv->account also when
2462 only retrieving a single message. This avoids a crash when canceling
2465 (modest_mail_operation_notify_end): Do not explicitely remove the
2466 operation from the queue but only emit the progress_changed signal.
2467 The queue itself listens to that signal to remove the operation when
2468 it is finished. This reduces coupling and removes a potential deadlock
2469 when modest_mail_operation_notify_end() is called from the queue
2470 itself. If that is a problem performance-wise, I would suggest to
2471 implement a status-changed signal or something.
2473 * src/modest-mail-operation-queue.c: Make sure to never call a
2474 function from another file while the queue is locked. This (hopefully)
2475 fixes another deadlock when exiting the application while retrieving
2478 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2480 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2481 Fixed build if libogs is not available
2483 2007-06-03 Christian Kellner <ckellner@openismus.com>
2485 * libmodest-dbus-client/libmodest-dbus-client.h:
2486 * libmodest-dbus-client/libmodest-dbus-client.c:
2487 (libmodest_dbus_client_delete_message):
2488 Implement deletion of messages (Client side).
2490 (modest_search_hit_free),
2491 (modest_search_hit_list_free):
2492 Utility functions to free the result hits.
2494 * src/dbus_api/modest-dbus-api.h:
2495 * src/dbus_api/modest-dbus-callbacks.c:
2496 (on_delete_message),
2497 (modest_dbus_req_handler):
2498 Implement deletion of messages (Server side).
2500 * tests/dbus_api/test_search.c: (main):
2503 * tests/dbus_api/Makefile.am:
2504 * tests/dbus_api/test_delete_message:
2505 Add little test for the message deletion logic
2507 2007-06-03 Armin Burgmeier <armin@openismus.com>
2509 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2510 when the operation queue was not empty. projects.maemo.org bug
2513 2007-06-03 Armin Burgmeier <armin@openismus.com>
2515 * src/widgets/modest-account-view.c
2516 (on_account_default_toggled): Toggle default account column
2517 explicitely instead of waiting for gconf notification (which is
2518 currently ignored). This should fix projects.maemo.org bug NB#56910
2519 for now. It should probably be removed when gconf notifications are
2522 2007-06-03 Christian Kellner <ckellner@openismus.com>
2524 * libmodest-dbus-client/libmodest-dbus-client.c:
2525 Removed debugging spew.
2527 * src/dbus_api/modest-dbus-callbacks.c:
2528 Added debugging info.
2530 * src/modest-search.c:
2531 (modest_search_all_accounts):
2532 Use tny_account_store_get_accounts () on the account store
2533 to get all accounts which is the way to get all accounts.
2535 * tests/dbus_api/test_search.c: (main):
2536 Make it possible to supply the search term on the command line.
2538 2007-06-03 Christian Kellner <ckellner@openismus.com>
2540 * libmodest-dbus-client/libmodest-dbus-client.c:
2541 * libmodest-dbus-client/libmodest-dbus-client.h:
2542 Implement searching for mesages over raw dbus. (Client side)
2544 * src/dbus_api/Makefile.am:
2545 * src/dbus_api/modest-dbus-api.h:
2546 * src/dbus_api/modest-dbus-callbacks.c:
2547 * src/dbus_api/modest-dbus-callbacks.h:
2548 Search framework (Server side). Also implement on_idle_open_message().
2550 * src/maemo/modest-platform.c: (modest_platform_init):
2551 Prepare for raw dbus/osso rpc interaction.
2553 * src/modest-search.h:
2554 Changed minsize from unspecific guint to guint32.
2556 * src/modest-search.c:
2558 Added strange hack which magically made tnymail work.
2560 (modest_search_folder),
2561 (modest_search_account),
2562 (modest_search_all_accounts):
2563 Implement helper functions to search all accounts, specific account
2566 * tests/dbus_api/Makefile.am:
2567 * tests/dbus_api/test_open_message.c:
2568 Read url to open from commandline.
2570 * tests/dbus_api/test_search.c:
2571 Implement small test for dbus search stuff
2573 2007-06-02 Armin Burgmeier <armin@openismus.com>
2575 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2576 include account type and account title. This fixes projects.maemo.org
2579 * src/maemo/modest-account-view-window.c: Set a title for the window.
2581 2007-06-02 Armin Burgmeier <armin@openismus.com>
2583 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2584 incoming and outgoing server name based on email address and server
2585 types as long as the names have not been edited manually. This fixes
2586 projects.maemo.org bug NB#58671.
2588 2007-06-02 Armin Burgmeier <armin@openismus.com>
2590 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2591 server type cannot be changed in future to the incoming details page
2592 when creating an account. This fixes projects.maemo.org bug NB#59029.
2594 2007-06-02 Armin Burgmeier <armin@openismus.com>
2596 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2597 and assigned max width chars so that they wrap instead of being
2598 truncated. Fixes projects.maemo.org bug NB#56126.
2600 2007-06-02 Armin Burgmeier <armin@openismus.com>
2602 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2603 introductory note to the connection specific smtp servers dialog, as
2604 section 8.12 of the email UI specification requires. This fixes
2605 projects.maemo.org bug NB#59212.
2607 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2609 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2610 Check for running mail operations, and offer to cancel them, as per the UI
2611 spec. This fixes projects.maemo.org bug NB#59041 .
2612 However, I suspect that tinymail may still use the network connection
2613 in ways that we cannot detect or cancel. But it should at least adapt to
2614 changes fairly well.
2616 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2618 * src/modest-tny-account-store.c: (recreate_all_accounts),
2619 (get_cached_accounts), (get_server_accounts): Do more sensible
2620 ref-counting of the temporarily-cached outbox accounts list. This seems
2621 to fix a crash when entering the password when the password was wrong.
2623 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2625 * src/gnome/modest-main-window.c: (connect_signals):
2626 * src/modest-tny-account-store.c: (get_password),
2627 (modest_tny_account_store_alert): Added comments and clues and
2628 commented-out code about how we currently fail to deal with connection
2629 errors and wrong passwords, and how we should.
2631 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2633 * src/widgets/modest-retrieve-combo-box.c:
2634 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2635 This fixes projects.maemo.org bug NB#58472 .
2637 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2639 * src/maemo/easysetup/modest-easysetup-wizard.c:
2640 (create_page_complete_easysetup):
2641 (create_page_complete_custom): Correct the last commit,
2642 putting the correct sentences in the correct pages.
2644 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2646 * src/maemo/easysetup/modest-easysetup-wizard.c:
2647 (create_page_complete_custom): Show the second sentence of text
2648 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2651 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2653 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2654 Set the leave-on-server conf key by default. This fixes
2655 projects.maemo.org bug NB#59258 .
2657 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/modest-account-view-window.c:
2660 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2661 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2664 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2666 * src/maemo/easysetup/modest-easysetup-wizard.c:
2667 (create_caption_new_with_asterisk):
2668 * src/maemo/modest-account-settings-dialog.c:
2669 (create_caption_new_with_asterisk):
2670 Uncomment the code to add the asterisk, because they are no longer in the
2671 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2672 (update_incoming_server_title): Add an asterisk here too.
2674 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2676 * src/maemo/modest-maemo-global-settings-dialog.c:
2677 (current_connection): Check that we are even connected before trying to
2678 get the current connection name, to prevent a warning.
2680 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2681 Change the comments because tny_maemo_conic_device_connect() is now meant to
2683 * src/modest-mail-operation.c:
2684 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2685 make sure we have a connection and fail if we can't connect.
2687 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2689 * src/maemo/modest-main-window.c:
2690 (on_account_store_connecting_finished): Do not try to get the
2691 connection ID if we are not really connected. I am surprised that
2692 this signal handler is called when we are not connected.
2694 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2696 * src/modest-error.h:
2697 * src/modest-ui-actions.c:
2698 (modest_ui_actions_get_msgs_full_error_handler):
2699 Renamed an enum, added comments, added an enum
2700 for retrieve-limit errors.
2702 * src/modest-mail-operation.c: (foreach_add_item),
2703 (internal_folder_observer_update), (update_account_thread),
2704 (modest_mail_operation_get_msgs_full):
2705 (modest_mail_operation_update_account),
2706 Added comments about how this works, and some code that should
2707 (but does not) check the retrieve-limit. See the TODO comment.
2709 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2711 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2712 Initialize help_id to fix the build. Warnings are good.
2714 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2716 * src/widgets/modest-hbox-cell-renderer.c:
2717 (modest_hbox_cell_renderer_append):
2718 * src/widgets/modest-vbox-cell-renderer.c:
2719 (modest_vbox_cell_renderer_append):
2720 Fix the last commit by doing an extra ref.
2722 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2724 * src/widgets/modest-hbox-cell-renderer.c:
2725 (modest_hbox_cell_renderer_append):
2726 * src/widgets/modest-vbox-cell-renderer.c:
2727 (modest_vbox_cell_renderer_append):
2728 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2729 to fix the build with Maemo Bora.
2730 However, there seems to be a remaining crash, probably due to reference
2733 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2735 * src/modest-tny-account.c:
2736 (modest_tny_account_new_for_local_folders):
2737 Use hildon_file_system_info_async_new() to get a better name for
2738 the memory card account, setting it as the account name.
2739 The timing seems to work, but this is probably
2740 not the best place to do this. See the TODO comment.
2741 * src/maemo/modest-main-window.c: (create_details_widget):
2742 * src/widgets/modest-folder-view.c: (text_cell_data):
2743 Use the tny account name instead of hardcoding a name.
2745 2007-05-30 Christian Kellner <ckellner@openismus.com>
2747 * src/modest-search.c: (modest_search):
2748 Correctly set part_search_func even if we have already parsed
2749 the query and thus a valid OgsTextSearcher object.
2751 2007-05-30 Christian Kellner <ckellner@openismus.com>
2754 Search and check for libogs.
2757 Incooparte the ogs build env.
2759 * src/modest-mime-part-search-stream.c:
2760 * src/modest-mime-part-search-stream.h:
2761 Removed since we do the real searching now in modest-search.c.
2763 * src/modest-search.c:
2764 * src/modest-search.h:
2765 Implement support for ogs. We use that if available and requested
2766 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2767 should now handle the corner case when the search term is spread
2768 across multiple reads.
2769 Also the logic in modest_search () was corrected to search all
2770 requested fields until one is found.
2772 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2774 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2776 * src/modest-init.h:
2777 * src/modest-init.c: Made modest_init_local_folders() take a
2778 path and be public so we can iniitialize maildir folders on
2781 * src/modest-local-folder-info.h:
2782 * src/modest-local-folder-info.c:
2783 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2785 * src/modest-tny-account.c:
2786 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2787 still means the standard local-folders path on the local volume.
2789 * src/modest-tny-account-store.c:
2790 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2791 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2792 all accounts when that happens.
2793 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2794 this too, so it shows up in the treeview.
2796 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2798 * src/maemo/modest-maemo-global-settings-dialog.c:
2799 (current_connection):
2800 * src/widgets/modest-global-settings-dialog.c:
2801 (current_connection_default):
2802 Use the enum values instead of 0, 1 and -1,
2803 to make the code clearer.
2805 * src/modest-account-mgr-helpers.c:
2806 (modest_account_mgr_get_connection_specific_smtp): Make this code
2809 * src/modest-runtime.h:
2810 * src/modest-runtime.c:
2811 Added modest_runtime_remove_all_send_queues().
2812 * src/maemo/modest-main-window.c:
2813 (on_account_store_connecting_finished): Recreate the send queues,
2814 using the appropriate transport accounts for this new connection.
2815 Some futher adapting might be needed if the old send queues are not
2816 automatically stopped at this point.
2818 * src/modest-tny-account-store.c: (get_server_accounts):
2819 Create the connection-specific transport accounts, so that they can
2820 be found later by their ID.
2822 * src/modest-tny-account.h:
2823 * src/modest-tny-account.c:
2824 Added modest_tny_account_new_from_server_account_name().
2825 modest_tny_account_new_from_server_account(): Do not create the
2826 send queues here, because they will be
2827 recreated anyway when the connection changes for the first time.
2829 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2831 * src/modest-local-folder-info.h:
2832 * src/modest-local-folder-info.c:
2833 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2834 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2835 tbox_folder): Take a modest account name instead of a server TnyAccount,
2836 so we can have per-modest-account rather than per-transport-account
2838 We must make sure that we change or recreate the exisitng send queues
2839 when the connection changes for connection-specific transport accounts.
2841 * src/modest-tny-account-store.c:
2842 (create_per_account_local_outbox_folders): Create outboxed per modest
2843 account, not per transport account.
2845 * src/modest-tny-account.h:
2846 * src/modest-tny-account.c:
2847 (modest_tny_account_get_special_folder): For outboxes, get the
2848 parent modest account name. The account is ignored for other folders.
2849 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2850 modest account name rather than a server TnyAccount.
2852 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2854 * src/modest-tny-account.c:
2855 (modest_tny_account_new_from_server_account):
2856 Call modest_runtime_get_send_queue() immediately after creating transport
2857 accounts, so that they start trying to send email from the outbox as soon
2858 as possible at startup. This is probably what we want.
2860 * src/modest-mail-operation.c: (update_account_thread):
2861 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2862 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2863 * src/modest-tny-send-queue.h:
2864 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2865 (modest_ui_actions_on_send):
2866 Added comments about how sending works, though it needs some more work.
2868 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2870 * src/modest-tny-account.c:
2871 (modest_tny_account_get_special_folder): Add TODO because this fails when
2872 the network is busy.
2873 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2874 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2875 Do not try to show this window when there is no active account. The UI
2876 specs does not tell us what to do in this case.
2878 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2882 * src/maemo/Makefile.am:
2883 * src/widgets/Makefile.am: Some dist fixes.
2885 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2887 * src/maemo/modest-connection-specific-smtp-window.c:
2888 (on_button_edit): Make the code clearer, to prevent a double free.
2890 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2892 * src/maemo/modest-account-settings-dialog.c:
2893 (modest_account_settings_dialog_set_account_name),
2894 Check the connection-specific smtp servers checkbox if there are any.
2896 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2897 (modest_connection_specific_smtp_edit_window_init):
2898 Start with a suitable port number.
2900 * src/modest-account-mgr-helpers.h:
2901 * src/modest-account-mgr-helpers.c: Added
2902 modest_account_mgr_get_has_connection_specific_smtp().
2904 (modest_account_mgr_set_connection_specific_smtp),
2905 (modest_account_mgr_remove_connection_specific_smtp),
2906 (modest_account_mgr_get_has_connection_specific_smtp),
2907 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2908 connection-specific smtp server accounts in the account, rather than
2909 the server account conf dir.
2911 This fixes bug projects.maemo.org bug NB#58263 .
2913 * src/modest-tny-account-store.c:
2914 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2915 if there are no server accounts yet, to prevent an infinite loop when there
2916 are no accounts. Document that one must be called before the other.
2918 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2920 * src/modest-account-mgr-helpers.c:
2921 (modest_account_mgr_get_default_account): Make sure that at least
2922 one account is always the default, if there are any enabled accounts.
2923 This is just a sanity check that shouldn't be necessary.
2925 * src/modest-account-mgr-priv.c:
2926 (_modest_account_mgr_account_from_key): Unescape the conf key to
2927 get the real account name. For instance, this is an issue if a space
2928 was in the account name, which can happen because the account name
2929 is generated from the display name.
2930 (_modest_account_mgr_get_account_keyname): Always escape the
2932 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2933 Unescape the conf keys to get the real account names.
2935 For instance, previously the is-default radio button in the accounts
2936 list was not checked for any accounts at first. This fixes that,
2937 and might fix several similar bugs.
2939 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2941 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2942 Removed some debug printfs.
2944 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2946 Modest on-disk outbox directories are now here, for instance:
2947 $HOME/.modest/outboxes/<account-id-1>/outbox
2948 $HOME/.modest/outboxes/<account-id-2>/outbox
2950 $HOME/.modest/local-folders/outbox
2951 so we can have a separate outbox for each account.
2952 But they are shown as one outbox in the GtkTreeView, by using a
2953 TnyMergeFolder in a ModestTnySimpleFolderStore.
2956 * src/modest-tny-simple-folder-store.c:
2957 * src/modest-tny-simple-folder-store.h:
2958 Added ModestTnySimpleFolderStore, used to contain folders from
2959 other folder stores, such as other accounts.
2961 * src/modest-tny-outbox-account.h:
2962 * src/modest-tny-outbox-account.c:
2963 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2964 used for the per-account local outbox folders.
2966 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2967 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2968 only use this (internally) now for the non-outbox local folders.
2970 * src/modest-init.h:
2971 * src/modest-init.c: Added modest_init_one_local_folder(), for
2972 setting up the directory structure for each local folder.
2974 * src/modest-local-folder-info.c:
2975 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2976 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2978 * src/modest-local-folder-info.h:
2979 * src/modest-tny-account-store.c: (on_account_removed),
2980 (on_account_changed), (create_per_account_local_outbox_folders),
2981 (get_server_accounts), (modest_tny_account_store_get_accounts),
2982 (modest_tny_account_store_get_tny_account_by_account),
2983 (modest_tny_folder_store_is_virtual_local_folders):
2985 * src/modest-tny-account.h:
2986 * src/modest-tny-account.c:
2987 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2988 to create an on-disk per-account local outbox folder for each
2990 (create_per_account_local_outbox_folders): Create a local outbox folder
2991 for each transport account.
2992 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2993 for all local folders.
2995 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2996 instead of using g_object_get/set() directly. It is clearer.
2998 (modest_tny_folder_store_get_message_count),
2999 (modest_tny_folder_store_get_local_size
3000 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3001 because we now use these with non-acount folder stores.
3003 (modest_tny_account_get_special_folder),
3004 (modest_tny_account_new_from_server_account),
3005 (modest_tny_account_new_from_account):
3006 (recurse_folders): Adjust to the new outbox system.
3008 * src/modest-tny-folder.h:
3009 * src/modest-tny-folder.c:
3010 (modest_tny_folder_is_local_folder),
3011 (modest_tny_folder_get_local_folder_type),
3012 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3014 * src/widgets/modest-main-window.h:
3015 * src/maemo/modest-main-window.c: (create_details_widget),
3016 (modest_main_window_set_contents_style): Show details for any folder store,
3019 (modest_tny_folder_get_rules):
3020 Remove the const. C does not support constness enough for this.
3022 * src/modest-ui-actions.c:
3023 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3024 make all outboxes appear as one, in the usual local-folders tree node.
3026 (set_active_account_from_tny_account),
3027 (modest_ui_actions_on_folder_selection_changed):
3028 * src/widgets/modest-folder-view.c: (text_cell_data),
3029 (icon_cell_data), (filter_row),
3030 (add_account_folders_to_merged_folder),
3031 (add_account_folders_to_simple_folder_store), (),
3032 (get_cmp_rows_type_pos), (cmp_rows),
3033 (modest_folder_view_set_account_id_of_visible_server_account):
3034 Adjust to the new outbox system, using generic folder stores and folders
3035 in the GtkTreeModel.
3037 2007-05-23 Christian Kellner <ckellner@openismus.com>
3039 * src/modest-mail-operation.c:
3040 (modest_mail_operation_update_account):
3041 Use info->max_size instead of unintialized local var [small
3042 build fix]. (Added TODO to review that change since I don't
3045 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3047 * libmodest-dbus-client/libmodest-dbus-client.c:
3048 (libmodest_dbus_client_compose_mail): function added
3049 * src/dbus_api/modest-dbus-api.h:
3050 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3051 (on_compose_mail): Implementation of the SendAsMail functionality
3053 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3055 * src/modest-account-mgr.c:
3056 (modest_account_mgr_add_server_account): Set the secure-connection
3057 conf key for transport accounts as well as store accounts. I don't know
3058 why the if was there. For instance, this makes sure that we use SSL
3059 for the gmail preset from the easysetup wizard.
3061 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3063 * src/gnome/modest-main-window.c:
3064 (on_account_store_connecting_finished), (connect_signals):
3065 * src/maemo/modest-main-window.c:
3066 (on_account_store_connecting_finished), (connect_signals),
3067 (modest_main_window_new):
3068 Handle TnyAccountStore::connecting-finished instead of
3069 TnyDevice::connection-changed, because we cannot actually perform
3070 operations on accounts until TnyAccountStore has itself responded to
3071 the TnyDevice::connection-changed signal. This prevents a GError from
3073 Do not try to update at startup, because we (at least on scratchbox)
3074 already do an update at startup when the device goes online.
3075 This prevents a GError from tinymail.
3076 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3077 Added TODO about stopping simultaneous operations.
3079 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3081 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3082 * src/modest-mail-operation-queue.c:
3083 (modest_mail_operation_queue_remove):
3084 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3085 about where they happened.
3087 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3089 * src/modest-ui-actions.c:
3090 (modest_ui_actions_on_password_requested): Make sure that the remember
3091 output parameter is always TRUE.
3093 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3095 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3096 Show a OK/Cancel dialog if the error is a question, though we still do not
3097 know anything more about what we are asking the user.
3098 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3099 Fix an uninitialized variable (helper). This is a logic error, however.
3101 2007-05-21 Christian Kellner <ckellner@openismus.com>
3103 * src/modest-search.h:
3104 Correct bit shifting in the ModestSearchFlags enum.
3106 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3108 * src/modest-tny-account.c:
3109 (modest_tny_account_new_from_server_account): Do not use the lsub and
3110 check-all hard-coded IMAP options when using POP.
3112 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3114 * src/modest-tny-account.c:
3115 (modest_tny_account_new_from_server_account):
3116 Use NULL for the secure-auth method for POP when Password auth has been
3117 specified by the user, as we already do for IMAP. "auth=Login" causes
3118 an error from camel or the server.
3120 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3122 * src/maemo/modest-account-settings-dialog.c:
3123 (create_page_account_details),
3124 (modest_account_settings_dialog_set_account_name):
3125 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3126 for the leave-on-server checkbox, rathr than just the checkbox, when
3127 the protocol is not POP.
3129 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3131 * src/widgets/modest-account-view.c:
3132 * src/widgets/modest-account-view.h:
3133 Added modest_account_view_select_account() which will be useful later
3134 to asynchronously re-select the edited account.
3136 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3138 * src/maemo/modest-account-settings-dialog.c:
3139 (modest_account_settings_dialog_set_account_name):
3140 Automatically choose the port numbers based on the secure authentication
3141 methods, if they have not been chosen before.
3142 This fixes projects.maemo.org bug NB#56273 .
3144 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3146 * src/maemo/modest-main-window-ui.h:
3147 * src/modest-ui-actions.c:
3148 * src/modest-ui-actions.h:
3149 Connect the Tools/SMTP Servers menu item to
3150 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3151 SMTP servers dialog, as in the UI specification and saves changes when it
3152 is closed. This fixed projects.maemo.org bug NB#56305 .
3154 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3156 * src/maemo/modest-connection-specific-smtp-window.c:
3157 (modest_connection_specific_smtp_window_init):
3158 Use gtk_window_set_default_size() to make this window big enough, so
3159 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3161 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3163 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3164 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3165 (modest_connection_specific_smtp_edit_window_init),
3166 Do not try to connect to a combobox signal before the combobox exists.
3167 This fixes the cras in projects.maemo.org bug NB#56288 .
3168 (modest_connection_specific_smtp_edit_window_get_settings):
3169 Remove the server_account_name parameter which was being checked for NULL
3170 though it was not used.
3172 * src/maemo/modest-connection-specific-smtp-window.c:
3173 (modest_connection_specific_smtp_window_fill_with_connections),
3174 (on_button_edit), (modest_connection_specific_smtp_window_init):
3175 Correct the number of treemodel columns to prevent a warning.
3176 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3177 libconic does not work.
3179 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3181 * src/modest-tny-account.c:
3182 (modest_tny_account_new_from_server_account):
3183 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3184 SMTP when "None" was chosen by the user. However, with my SMTP server that
3185 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3188 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3190 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3191 to explain the memory management issue with the ID in the ModestPair.
3193 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3194 (add_sending_page), (modest_account_assistant_finalize):
3195 * src/gnome/modest-gnome-global-settings-dialog.c:
3196 (create_updating_page), (create_composing_page):
3197 * src/gnome/modest-msg-edit-window.c: (get_transports),
3198 (init_window), (modest_msg_edit_window_finalize),
3199 (modest_msg_edit_window_get_msg_data):
3200 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3201 * src/gnome/modest-transport-widget.c:
3202 (modest_transport_widget_finalize), (smtp_configuration):
3203 * src/maemo/modest-maemo-global-settings-dialog.c:
3204 (create_updating_page), (create_composing_page):
3205 * src/maemo/modest-msg-edit-window.c: (get_transports),
3206 (init_window), (modest_msg_edit_window_finalize),
3207 (modest_msg_edit_window_get_msg_data),
3208 (modest_msg_edit_window_free_msg_data):
3209 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3210 (modest_store_widget_finalize):
3211 * src/maemo/modest-transport-widget.c:
3212 (modest_transport_widget_finalize), (smtp_configuration):
3213 * src/modest-main.c: (send_mail):
3214 * src/widgets/modest-combo-box.h:
3215 * src/widgets/modest-global-settings-dialog-priv.h:
3216 * src/widgets/modest-global-settings-dialog.c:
3217 (modest_global_settings_dialog_finalize):
3218 * src/widgets/modest-msg-edit-window.h:
3219 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3220 as long as the combo box, to prevent use of freed memory for the ID.
3222 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3224 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3225 get_accounts(), to make this clearer. Do not check for the enabled gconf
3226 key, because we do not use this for server accounts (at least, not yet).
3227 This allows us to send email again.
3229 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3231 * src/maemo/modest-platform.c:
3232 (on_modest_conf_update_interval_changed), (modest_platform_init):
3233 Only respond to this particular key change. All these strcmp()s cannot be
3236 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3238 * src/maemo/modest-maemo-global-settings-dialog.c:
3239 (current_connection): Prevent a crash in scratchbox when
3240 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3241 * src/maemo/modest-platform.c:
3242 (on_modest_conf_update_interval_changed), (modest_platform_init):
3243 Get the update interval from gconf and reset it when the gconf key changes.
3245 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3247 * src/modest-protocol-info.c:
3248 * src/modest-protocol-info.h: Adde enum-specific get functions,
3249 instead of using a ModestProtocolType enum parameter.
3251 * src/gnome/modest-account-assistant.c:
3252 * src/gnome/modest-store-widget.c:
3253 * src/gnome/modest-store-widget.h:
3254 * src/gnome/modest-transport-widget.c:
3255 * src/gnome/modest-transport-widget.h:
3256 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3257 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3258 * src/maemo/easysetup/modest-easysetup-wizard.c:
3259 * src/maemo/modest-account-settings-dialog.c:
3260 * src/maemo/modest-account-settings-dialog.h:
3261 * src/maemo/modest-store-widget.c:
3262 * src/maemo/modest-store-widget.h:
3263 * src/maemo/modest-transport-widget.c:
3264 * src/maemo/modest-transport-widget.h:
3265 * src/modest-account-mgr-helpers.c:
3266 * src/modest-account-mgr-helpers.h:
3267 * src/modest-account-mgr.c:
3268 * src/modest-account-mgr.h:
3269 * src/modest-tny-account.c:
3270 * src/modest-tny-folder.c:
3271 * src/widgets/modest-account-view.c:
3272 * src/widgets/modest-retrieve-combo-box.c:
3273 * src/widgets/modest-retrieve-combo-box.h:
3274 * src/widgets/modest-secureauth-combo-box.c:
3275 * src/widgets/modest-serversecurity-combo-box.c:
3276 * src/widgets/modest-serversecurity-combo-box.h:
3277 * tests/check_account-mgr.c:
3278 Use the specific functions, and use the re-renamed enum values for GNOME too.
3280 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3282 * src/modest-pair.h:
3283 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3284 so we can get the second based on the first.
3286 * src/maemo/modest-account-settings-dialog.h:
3287 * src/maemo/modest-account-settings-dialog.c:
3288 Added get_supported_secure_authentication_methods(), though it is mostly
3289 commented-out for now until the necessary API is committed to tinymail.
3290 (modest_account_settings_dialog_set_account_name),
3291 (save_configuration): Request the supported authentication methods from the
3292 server, so we can choose a working method.
3294 * src/modest-tny-account-store.h:
3295 * src/modest-tny-account-store.c:
3296 (modest_tny_account_store_get_session): Rename from
3297 tny_account_store_get_session().
3299 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3301 * src/modest-protocol-info.h: Split the ModestProtocol enum
3302 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3303 There was no need to have these unrelated values in one enum.
3305 * src/: many files: Adapted to changed enum. This makes the code a bit
3306 clearer, and the compiler could catch some errors.
3308 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3310 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3311 Show the detailed internal camel error message when an error happens
3312 during the configuration, so that our testers can give us more clues.
3313 For instance, in projects.maemo.org bug NB#56910 .
3315 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3317 * src/modest-tny-account.c:
3318 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3319 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3321 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3323 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3324 * src/maemo/modest-account-settings-dialog.c:
3325 (modest_account_settings_dialog_set_account_name),
3326 (save_configuration): For the incoming secure authentication checkbox,
3327 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3328 the UI specification. PLAIN does not seem to be supported for most IMAP
3329 servers anyway, and I am not sure what it would mean.
3330 However, we probably need to discover which of the secure-authentication
3331 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3332 * src/modest-account-mgr-helpers.c:
3333 (modest_account_mgr_get_server_account_data):
3335 * src/modest-tny-account.c:
3336 (modest_tny_account_new_from_server_account):
3337 Use tny_account_set_mech() to set secure-authentication methods,
3338 with some special-casing for IMAP, based on my observations of how
3341 * src/modest-account-mgr-helpers.h:
3342 * src/modest-account-mgr.c:
3343 * src/modest-defs.h: Comment that the URI is only used for local folders.
3345 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3347 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3348 parameter const, just to be neat.
3349 * src/modest-text-utils.c: (modest_text_utils_inline):
3350 End g_strconcat() with NULL, as its documentation says. This is almost
3351 certainly the cause of my crash at startup on the device. Interestingly,
3352 valgrind doesn't tell us about these errors.
3354 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3356 * scripts/build-packages: Added more precise comments about how to use
3357 this script, though I still get this error:
3358 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3359 error building tinymail
3361 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3363 * src/maemo/modest-main-window.c: (on_account_update):
3364 Very slight cleanup, hoping to make it simpler to discover what causes
3365 a crash here sometimes.
3367 * src/modest-tny-account.c:
3368 (modest_tny_account_new_from_server_account): Set the port. Added
3369 comments about the options and a TODO comment because I need to find out
3370 how to specify the secure authentication method.
3372 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3374 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3375 changed CFlags paths form modest to libmodest
3377 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3379 * src/modest-account-mgr-helpers.c:
3380 (modest_account_mgr_get_server_account_data),
3381 (modest_account_mgr_free_server_account_data):
3382 * src/modest-account-mgr-helpers.h:
3383 * src/modest-account-mgr.c:
3384 (modest_account_mgr_add_server_account):
3385 * src/modest-defs.h:
3386 * src/modest-tny-account.c:
3387 (modest_tny_account_new_from_server_account):
3388 Determine the options for tny_camel_account_add_option() here,
3389 based on the settings, rather than storing them directly in gconf.
3391 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3393 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3394 Show a more friendly error dialog now that we expect (from the tinymail
3395 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3397 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3399 * src/maemo/modest-main-window.c: (on_account_update): Check that
3400 account_name is not NULL, to prevent a crash at startup that I am
3401 seeing on the N800. I do wonder why it is NULL.
3403 * src/maemo/easysetup/modest-easysetup-wizard.c:
3404 (create_page_user_details):
3405 * src/maemo/modest-account-settings-dialog.c:
3406 (create_page_user_details), (create_page_outgoing):
3407 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3408 (modest_connection_specific_smtp_edit_window_init):
3409 * src/modest-ui-actions.c:
3410 (modest_ui_actions_on_password_requested):
3411 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3412 might do something useful with the on-screen keyboard.
3414 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3416 * src/maemo/modest-main-window.c: (on_account_update):
3417 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3418 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3420 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3422 * src/modest-tny-account-store.c: (on_account_changed):
3423 Correct the signature of this signal handler.
3425 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3427 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3428 Show a HildonNote instead of a GtkDialog for Maemo.
3430 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3432 * src/widgets/modest-account-view.h:
3433 * src/widgets/modest-account-view.c: (on_account_changed),
3434 (on_account_removed). Added a boolean flag, set/unset by
3435 modest_account_view_block_conf_updates(),
3436 modest_account_view_unblock_conf_updates() to prevent unnecessary
3437 updates, but this is not very useful because the gconf notifications are
3438 so delays (maybe only on Maemo Bora).
3439 So auto-updating is turned off, and these functions do an explicit
3440 update when necessary.
3441 However, something else is still doing too much work when adding/removing
3442 accounts, probably in another part of the application.
3444 * src/maemo/modest-account-view-window.c:
3445 (on_delete_button_clicked), (on_edit_button_clicked),
3446 (on_new_button_clicked): Use the new functions.
3448 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3450 * src/modest-account-mgr-helpers.c:
3451 (modest_account_mgr_set_first_account_as_default):
3452 Sort the list of names alphabetically-by-title, so we choose the first one
3454 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3455 alphabetically by the title.
3457 This fixes projects.maemo.org bug NB#56418 .
3459 * src/modest-account-mgr-priv.c:
3460 (_modest_account_mgr_account_from_key):
3461 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3462 avoid a valgrind error, and possible random behaviour.
3464 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3466 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3467 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3468 tinymail documentation to say that this can be expected.
3469 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3470 pretty, and should not happen, but I would prefer to know when it does.
3472 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3474 * configure.ac: When using the older hildon version, probably on Bora,
3475 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3477 * src/widgets/modest-attachment-view.c:
3478 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3481 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3483 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3484 Implemented the prototype. Can be tested with
3485 tests/dbus_api/test_open_message:
3487 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3489 * src/modest-tny-account-store.c:
3490 (modest_tny_account_store_instance_init), (get_password):
3491 * src/modest-ui-actions.c:
3492 (modest_ui_actions_on_password_requested):
3493 Do not store the password in gconf, because this function is called
3494 for non-remembered passwords. Actually use the cached (in the hash map)
3495 password instead of releasing it.
3496 The password will now not be remembered if it is asked via the protected
3497 password dialog, as per the UI spec.
3499 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3501 * src/modest-defs.h:
3502 * src/modest-account-mgr-helpers.h:
3503 * src/modest-account-mgr-helpers.c:
3504 Added modest_server_account_get_username_has_succeeded(),
3505 modest_server_account_set_username_has_succeeded().
3506 (modest_server_account_set_username),
3507 Reset the has-succeeded flag if the username changes.
3509 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3510 * src/maemo/modest-connection-specific-smtp-window.c:
3511 (modest_connection_specific_smtp_window_save_server_accounts):
3512 Use modest_server_account_set_username() instead of using
3513 modest_conf_set_string() directly, so that the has-succeeded flag is always
3516 * src/modest-ui-actions.c:
3517 (modest_ui_actions_on_password_requested): Dim the username entry if
3518 the username has ever worked, as per the UI spec.
3520 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3522 * src/modest-tny-account-store.c: (get_password):
3523 * src/modest-ui-actions.c:
3524 (modest_ui_actions_on_password_requested):
3525 Allow the username to be changed too, though there is more work to
3526 be done on exactly how this behaves.
3528 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3530 * src/modest-account-mgr-helpers.h:
3531 * src/modest-account-mgr-helpers.c:
3532 Added modest_account_mgr_get_display_name(),
3533 modest_server_account_get_username(),
3534 modest_server_account_set_username(),
3535 modest_server_account_set_password(),
3536 modest_server_account_get_hostname() functions so we do not need to
3537 use the conf API directly.
3539 * src/maemo/modest-main-window.c: (connect_signals):
3540 Actually connect ot the ModestAccountStore::request-password signal,
3541 so that we show the dialog when the password is requested by Tinymail,
3542 for isntance if it is empty.
3544 * src/modest-marshal.list:
3545 * src/modest-tny-account-store.c:
3546 (modest_tny_account_store_class_init), (get_password),
3547 (modest_tny_account_store_alert):
3548 * src/modest-tny-account-store.h:
3549 * src/modest-ui-actions.h:
3550 * src/modest-ui-actions.c:
3551 (modest_ui_actions_on_password_requested):
3552 Change the signal parameters, so it is obvious that we are providing
3553 the non human-readable server name, and receiving both the username
3554 and password, though changing of the username is not yet implemented.
3555 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3556 for the GNOME version.
3558 This should fix the projects.maemo.org bug NB#56209, though it does not
3559 work on Bora, because the gconf_client_get() for the password fails
3560 immediately after we save it with gconf_client_set().
3562 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3565 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3566 caused an undefined symbol error:
3567 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3569 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3571 * src/modest-tny-account-store.c:
3572 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3573 using a GError instead of a string message, so we can translate it in
3576 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3578 * src/maemo/modest-address-book.c:
3579 (modest_address_book_check_names):
3580 * src/maemo/modest-msg-view-window.c:
3581 (modest_msg_view_window_clipboard_owner_change):
3582 * src/modest-init.c: (modest_init_init_ui):
3583 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3584 (update_folders_cb), (modest_mail_operation_update_account):
3585 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3586 (modest_ui_actions_on_msg_attachment_clicked),
3587 (modest_ui_actions_on_msg_recpt_activated):
3588 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3589 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3590 (modest_msg_view_search_next):
3591 * src/widgets/modest-recpt-editor.c:
3592 (modest_recpt_editor_on_button_release_event),
3593 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3594 g_message(). At this point we should only be seeing interesting errors on
3595 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3597 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3599 (modest_wizard_dialog_force_title_update):
3600 * src/maemo/easysetup/modest-wizard-dialog.h:
3601 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3602 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3603 can update the title when appropriate. Otherwise the title is wrong if the
3604 pages are added after adding the notebook to the dialog.
3605 This must be a problem in HildonWizardDialog too.
3606 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3608 * src/maemo/easysetup/modest-easysetup-wizard.c:
3609 (create_subsequent_customsetup_pages),
3610 (create_subsequent_easysetup_pages):
3611 Call modest_wizard_dialog_force_title_update() so that the title is
3612 correct even with GTK+ < 2.10.
3613 This fixes projects.maemo.org bug NB#56145 .
3615 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3617 * src/maemo/modest-platform.c:
3618 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3619 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3622 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3624 * src/widgets/modest-window.h:
3625 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3626 and modest_window_save_state(), which invokes it.
3628 * src/widgets/modest-window-mgr.h:
3629 * src/widgets/modest-window-mgr.c:
3630 Added modest_window_mgr_save_state_for_all_windows(), which calls
3631 the save_state vfunc on all registered windows, if implemented.
3633 * src/gnome/modest-msg-edit-window.c:
3634 * src/gnome/modest-msg-view-window.c:
3635 * src/maemo/modest-msg-edit-window.c:
3636 * src/maemo/modest-msg-view-window.c:
3637 * src/maemo/modest-main-window.c:
3638 Specify the existing save_settings functions as implementations of
3639 ModestWindow::save_state_func().
3641 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3642 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3643 enabling hibernation, for instance.
3645 We may need to do the same thing for restoring settings.
3648 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3650 * src/widgets/modest-window-mgr.c:
3651 * src/widgets/modest-window-mgr.h:
3652 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3653 modest_window_mgr_get_hibernation_is_prevented().
3655 * src/maemo/modest-main-window.c:
3656 (on_hildon_program_is_topmost_notify): Prevent hibernation
3657 (possible when the application goes to the background in the WM),
3658 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3660 * src/maemo/easysetup/modest-easysetup-wizard.c:
3661 (modest_easysetup_wizard_dialog_init):
3662 * src/maemo/modest-account-settings-dialog.c:
3663 (modest_account_settings_dialog_init):
3664 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3665 (modest_connection_specific_smtp_edit_window_init):
3666 * src/maemo/modest-connection-specific-smtp-window.c:
3667 (modest_connection_specific_smtp_window_init):
3668 * src/maemo/modest-signature-editor-dialog.c:
3669 (modest_signature_editor_dialog_init):
3670 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3671 prevent hibernation while any of these account settings dialogs are open.
3673 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3675 * src/maemo/Makefile.am:
3676 * src/maemo/modest-osso-state-saving.c:
3677 * src/maemo/modest-osso-state-saving.h: Added
3678 modest_osso_load_state() and modest_osso_save_state() though they do
3679 nothing now. They should iterate through all the open windows and load/save
3681 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3682 save state when closing.
3684 * src/maemo/modest-main-window.c:
3685 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3686 Add a notification handler for the HildonProgram::is-topmost property,
3687 so we can allow hibernation when the application goes into the background.
3688 But we still need to detect when the accounts setup windows are open so
3689 we can stop hibernation when they are open.
3690 To do this, I also added the main window the HildonProgram. This might have
3691 other side-effects/benefits, and should maybe be done for other windows.
3693 * src/maemo/modest-osso-autosave-callbacks.h:
3694 * src/maemo/modest-osso-autosave-callbacks.c:
3695 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3696 though it does not do anything yet, and we might never need this to do
3697 anything. For instance, we already save drafts.
3699 * src/maemo/modest-platform.c: (modest_platform_init):
3700 Specify the libosso auto-save callback.
3702 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3704 * src/maemo/modest-platform.c:
3705 (modest_platform_set_update_interval):
3706 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3707 aparently stays valid between application instances, so we can use this
3708 to remove and reset it later. According to a maemo-developers email from
3711 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3713 * configure.ac: Depend on libalarm for Maemo.
3715 * src/dbus_api/modest-dbus-api.h:
3716 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3717 (on_send_receive), (modest_dbus_req_handler):
3718 Handle a SEND_RECEIVE D-Bus method.
3720 * libmodest-dbus-client/libmodest-dbus-client.c:
3721 (libmodest_dbus_client_send_and_receive):
3722 * libmodest-dbus-client/libmodest-dbus-client.h:
3723 Add C convenience functions for calling the new D-Bus method.
3725 * src/modest-platform.h:
3726 * src/gnome/modest-platform.c:
3727 * src/maemo/modest-platform.c:
3728 Added modest_platform_set_update_interval(), which uses the
3729 alarmd API on Maemo.
3730 (modest_platform_init),
3731 Call modest_platform_set_update_interval(), using a hard-coded
3732 interval for now (until the global settings dialog is implemented),
3733 though I am not sure that this makes sense yet.
3735 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3737 * src/dbus_api/modest-dbus-callbacks.c:
3738 (modest_osso_cb_hw_state_handler):
3739 * src/dbus_api/modest-dbus-callbacks.h:
3740 * src/maemo/modest-platform.c: (modest_platform_init):
3741 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3742 in case this has some effect on the ability for Maemo to ping the
3745 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3747 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3748 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3749 warning. It is probably a logic error, but I need to fix the build.
3751 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3753 * src/modest-account-mgr.h:
3754 * src/modest-account-mgr.c:
3755 (modest_account_mgr_account_names): Add a gboolean enabled_only
3756 parameter, so we can get lists of onlt the enabled accounts.
3758 (modest_account_mgr_add_account),,
3759 (modest_account_mgr_account_with_display_name_exists):
3760 * src/maemo/modest-msg-edit-window.c: (get_transports):
3761 * src/modest-account-mgr-helpers.c:
3762 (modest_account_mgr_set_first_account_as_default):
3763 * src/modest-init.c: (init_default_account_maybe):
3764 * src/modest-tny-account-store.c: (get_accounts):
3765 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3766 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3767 * tests/check_account-mgr.c: (START_TEST):
3768 Provide the extra parameter, as appropriate.
3770 * src/widgets/modest-account-view.c: (update_account_view):
3771 Do not show disabled accounts (meaning that there is no way to
3772 enable/disable accounts in the UI (the feature is not in our UI
3773 specification), so we can use this internally only to mark unfinished
3774 or temporary account data.
3776 * src/maemo/easysetup/modest-easysetup-wizard.c:
3777 (create_account): Add boolean enable parameter, so we can specify FALSE
3778 to create the temporary account.
3779 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3780 (on_before_next): When finishing, when there is a temporary account, just
3782 Also, use a timeout to delay the showing of the dialog until gconf is likely
3783 to return correct information, due to a maemo gconf bug that is fixed in
3784 osso 1.1, but not yet in Bora.
3785 However, the dialog stays on screen after it is destroyed.
3787 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3788 for invalid data when cancelling. Use a hildon note instead of a dialog
3789 to complain about invalid data. Do not show the account-saved note if the
3790 account is disabled (a temporary account that will not really be saved for use
3793 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3795 * src/modest-account-mgr-helpers.h:
3796 * src/modest-account-mgr-helpers.c:
3797 Added modest_account_mgr_unset_default_account(),
3798 Added modest_account_mgr_set_first_account_as_default().
3800 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3801 If it was the default account, unset the default account name.
3803 * src/maemo/modest-account-view-window.c:
3804 (on_delete_button_clicked): If it was the default account,
3805 set the first remaining account as the default instead.
3807 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3808 a NULL account or a NULL default account, to prevent a crash. This should
3809 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3812 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3814 * src/widgets/modest-recpt-editor.c:
3815 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3816 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3817 TODO comment for this. This fixes the build.
3819 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3820 be the best place for it. This will in future update all auto-update accounts,
3821 rather than just the current/default account, when that gconf key exists.
3822 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3823 if there are no accounts, before calling do_send_receive().
3824 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3826 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3827 * src/maemo/modest-main-window-ui.h:
3828 * src/maemo/modest-main-window.c: (on_connection_changed),
3829 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3830 directly, becaue the signal handler does more.
3832 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3834 * src/modest-account-mgr-helpers.c:
3835 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3836 for the case that the account does not exist.
3838 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3839 (equivalent to the modest account name) rather than the tinymail account name
3840 (equivalent to the modest account title - human readable) to get the account data.
3841 Check for null account data to prevent the crash, and add a TODO comment saying that
3842 this needs fixing because it is using the server account name instead of the account name.
3844 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3846 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3847 * src/maemo/modest-account-settings-dialog.c: (show_error),
3849 Use hildon_note_new_information() for informative and error messages,
3850 which seems to be expected for Maemo applications (no documentation that I know of
3851 says this). I am surprised that there is no distinction between info and error
3854 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3856 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3857 it is easy to find where this is used.
3859 * src/maemo/easysetup/modest-easysetup-wizard.c:
3860 (create_page_welcome), (create_page_account_details),
3861 (create_page_user_details), (create_page_complete_easysetup),
3862 (create_page_custom_incoming), (create_page_custom_outgoing),
3863 (create_page_complete_custom):
3864 * src/maemo/modest-account-settings-dialog.c:
3865 (create_page_account_details), (create_page_user_details),
3866 (create_page_incoming), (create_page_outgoing):
3867 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3868 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3869 (modest_connection_specific_smtp_edit_window_init):
3870 * src/maemo/modest-connection-specific-smtp-window.c:
3871 (modest_connection_specific_smtp_window_init):
3872 * src/maemo/modest-signature-editor-dialog.c:
3873 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3874 and scrolling policy as per the Email Application Layout Guide, if I have
3877 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3879 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3880 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3881 which were empty, because these vfuncs have been removed from TnyAccountStore.
3882 This fixes the build.
3884 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3886 * src/maemo/modest-main-window.c:
3887 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3888 showing/hiding it. Added TODO because it probably should not be NULL.
3889 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3890 because unnecessary g_warnings() make degugging difficult.
3892 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3894 * src/maemo/modest-msg-edit-window.c:
3895 (modest_msg_edit_window_select_color),
3896 (modest_msg_edit_window_select_background_color): 2 const corrections and
3897 moving 2 #endifs before closing brackets, to fix the build.
3899 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3901 * src/maemo/easysetup/modest-easysetup-wizard.h:
3902 * src/maemo/easysetup/modest-easysetup-wizard.c:
3903 (modest_easysetup_wizard_dialog_finalize),
3904 (on_button_edit_advanced_settings), (create_page_complete_custom),
3905 (on_response), (create_account):
3906 Implement the Advanced Settings edit button, by saving the account information,
3907 for the Advanded Settings dialog to use directly from gconf, and removing it
3908 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3909 Bug #5533 in the projects.maemo.org bugzilla.
3911 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3913 * src/maemo/modest-msg-view-window.c:
3914 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3915 when opening a message window.
3917 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3919 * src/maemo/easysetup/modest-easysetup-wizard.c:
3920 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3923 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3924 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3925 gconf settings. I probably added more checks than necessary, but that is safer.
3927 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3928 variable to fix the build, but this seems to be used when it is still NULL.
3930 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3932 * src/modest-platform.h:
3933 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3934 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3935 * src/modest-main.c: Implement this function so we can avoid using
3936 maemo-specific API from cross-platform code.
3938 * src/modest-tny-account-store.c:
3939 (get_smtp_specific_transport_account_for_open_connection):
3940 * src/modest-ui-actions.c: (check_for_connection),
3941 (modest_ui_actions_on_item_not_found):
3942 Use modest_platform_connect_and_wait() and put #idefs around other
3943 maemo-specific code, because only maemo currently has a way to
3944 identify connection names.
3946 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3948 * src/modest-tny-account-store.h:
3949 * src/modest-tny-account-store.c:
3950 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3951 the connection-specific SMTP server settings in the configuration.
3953 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3955 * src/maemo/modest-main-window.c: (on_connection_changed),
3957 * src/modest-main.c: (main), (start_ui), (send_mail):
3958 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3959 that is what is intended.
3961 * src/modest-ui-actions.c: (action_send), (action_receive),
3962 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3963 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3964 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3965 SMTP server is used when it is specified.
3967 (modest_ui_actions_on_send_receive):
3968 Check that a connection is open before proceeding.
3969 Receive and then send, instead of vice-versa, as per the specification.
3971 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3973 * src/modest-mail-operation.c:
3974 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3975 though I guess it should be something other than NULL.
3977 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3979 * src/maemo/easysetup/modest-easysetup-wizard.c:
3980 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3981 combo twice, to avoid an g_warning and to make it visible again.
3982 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3983 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3984 (already intended) dereference when detaching, because we then recreate the menu.
3985 But I am not sure why the warning was happening, and it is possible that this is a memory
3988 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3990 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3991 and uri_parse_mailto() utility functions.
3992 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3994 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3996 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3998 * src/dbus_api/modest-dbus-api.h:
3999 * src/dbus_api/modest-dbus-callbacks.c:
4000 Use an idle callback to execute the modest code in the application's own thread.
4001 Remove the helloworld example method.
4002 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4003 parsed, and the open-message method is not implemented because this is not yet implemented in
4005 * libmodest-dbus-client/libmodest-dbus-client.c:
4006 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4007 (libmodest_dbus_client_open_message):
4008 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4010 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4011 body without crashing.
4013 * tests/dbus_api/Makefile.am:
4014 * tests/dbus_api/test_mail_to.c:
4015 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4017 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4019 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4020 Added file to fix the build. Sorry.
4022 * src/dbus_api/Makefile.am:
4023 * src/dbus_api/modest-dbus-api.h:
4024 * src/dbus_api/modest-dbus-callbacks.h:
4025 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4026 (modest_dbus_req_handler):
4027 Put constants in a separate header so it can be reused by the
4028 client library, without duplication
4030 * libmodest-dbus-client/Makefile.am:
4031 * libmodest-dbus-client/libmodest-dbus-client.c:
4032 (libmodest_dbus_client_call_helloworld),
4033 (libmodfest_dbus_client_send_mail),
4034 (libmodfest_dbus_client_mailto),
4035 (libmodfest_dbus_client_open_message):
4036 * libmodest-dbus-client/libmodest-dbus-client.h:
4037 (Partly) Implement a send_mail D-Bus method.
4039 * tests/dbus_api/Makefile.am:
4040 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4041 the send_email D-Bus method.
4043 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4047 * libmodest-dbus-client/Makefile.am:
4048 * libmodest-dbus-client/libmodest-dbus-client.c:
4049 * libmodest-dbus-client/libmodest-dbus-client.h:
4050 * tests/dbus_api/Makefile.am:
4051 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4052 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4054 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4056 * src/maemo/easysetup/modest-easysetup-wizard.c:
4057 (create_page_account_details):
4058 * src/maemo/modest-account-settings-dialog.c:
4059 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4060 widgets, because this might not be the default in future versions of the Maemo GTK+.
4061 However, I can not not get capitalization to work even in a simple test case.
4063 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4065 * src/maemo/easysetup/modest-easysetup-wizard.c:
4066 (create_page_custom_incoming), (create_page_custom_outgoing):
4067 * src/maemo/modest-account-settings-dialog.c:
4068 (create_page_account_details), (create_page_incoming),
4069 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4070 instead of using gtk_check_button_with_label(), so they are aligned like the other
4071 widgets, as per the UI spec.
4073 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4075 * src/maemo/easysetup/modest-easysetup-wizard.c:
4076 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4077 * src/widgets/modest-validating-entry.c:
4078 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4079 Modest prefix instead of an EasySetup prefix.
4081 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4083 * src/widgets/modest-validating-entry.h:
4084 * src/widgets/modest-validating-entry.c: (on_insert_text),
4085 Added easysetup_validating_entry_set_max_func(), used to set a callback
4086 to call when the max number of characters is reached. GtkEntry has a max-length
4087 already but is silent about it.
4089 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4090 (create_page_account_details), (create_page_user_details),
4092 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4093 (create_page_account_details), (create_page_user_details),
4094 (create_page_outgoing):
4095 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4096 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4097 the UI spec, when the user tries to enter more than the max number of characters.
4099 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4101 * src/maemo/easysetup/modest-easysetup-wizard.c:
4102 (create_page_user_details), (create_page_custom_incoming),
4103 (create_page_custom_outgoing):
4104 * src/maemo/modest-account-settings-dialog.c:
4105 (create_page_user_details), (create_page_incoming),
4106 (create_page_outgoing):
4107 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4108 (modest_connection_specific_smtp_edit_window_init):
4109 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4110 not appropriate. Bad Maemo-specific defaults!.
4112 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4114 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4115 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4116 (modest_signature_editor_dialog_set_settings):
4117 Disable the label and textview when the checkbox is disabled, and use the
4118 specified (UI spec) default signature text.
4120 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4122 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4123 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4125 * src/modest-defs.h:
4126 * src/modest-account-mgr-helpers.h:
4127 * src/modest-account-mgr-helpers.c:
4128 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4130 * src/maemo/Makefile.am:
4131 * src/maemo/modest-signature-editor-dialog.c:
4132 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4135 * src/maemo/modest-account-settings-dialog.h:
4136 * src/maemo/modest-account-settings-dialog.c:
4137 (modest_account_settings_dialog_finalize), (on_button_signature),
4138 (save_configuration): Use the new dialog when the Edit button is pressed, and
4139 save the changes if necessary, as per the UI spec.
4141 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4143 * src/maemo/Makefile.am:
4144 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4145 based on maemo-develoers email from Dirk.
4147 * src/maemo/easysetup/modest-easysetup-wizard.c:
4148 (create_page_welcome), (create_page_account_details),
4149 (create_page_user_details), (create_page_complete_easysetup),
4150 (create_page_custom_incoming), (create_page_custom_outgoing),
4151 (create_page_complete_custom),
4152 (modest_easysetup_wizard_dialog_init):
4153 * src/maemo/modest-account-settings-dialog.c:
4154 (create_page_account_details), (create_page_user_details),
4155 (create_page_incoming), (create_page_outgoing),
4156 (modest_account_settings_dialog_init):
4157 * src/maemo/modest-connection-specific-smtp-window.c:
4158 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4160 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4162 * src/maemo/easysetup/modest-easysetup-wizard.c:
4163 (create_page_account_details), (create_page_custom_outgoing),
4164 (create_page_complete_custom):
4165 * src/maemo/modest-account-settings-dialog.c:
4166 (create_page_user_details), (create_page_incoming),
4167 (create_page_outgoing):
4168 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4169 (modest_connection_specific_smtp_edit_window_init):
4170 Use the correct (UI spec) port min/max, and use horizontal separators,
4173 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4175 * src/maemo/easysetup/modest-easysetup-wizard.c:
4176 (set_default_custom_servernames):
4177 * src/maemo/modest-account-settings-dialog.c:
4178 (create_page_incoming), (on_combo_outgoing_security_changed),
4179 (on_combo_incoming_security_changed), (create_page_outgoing),
4180 (modest_account_settings_dialog_set_account_name),
4181 (save_configuration):
4182 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4183 (on_combo_security_changed),
4184 (modest_connection_specific_smtp_edit_window_init),
4185 (modest_connection_specific_smtp_edit_window_set_connection),
4186 (modest_connection_specific_smtp_edit_window_get_settings):
4187 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4190 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4193 * src/maemo/easysetup/modest-easysetup-wizard.c:
4194 (create_page_custom_outgoing), (create_page_complete_custom):
4195 * src/maemo/modest-account-settings-dialog.c:
4196 (create_page_user_details), (create_page_outgoing):
4197 * src/maemo/modest-account-view-window.c: (button_box_new):
4198 Use changed logical IDs as per the most recent UI spec:
4199 mcen_bd_emailsetup_edit -> mcen_bd_edit
4200 mcen_bd_emailsetup_delete -> mcen_bd_delete
4201 mcen_bd_emailsetup_close -> mcen_bd_close
4203 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4207 * src/dbus_api/Makefile.am:
4208 * src/dbus_api/modest-dbus-callbacks.c:
4209 * src/dbus_api/modest-dbus-callbacks.h:
4210 * src/maemo/modest-platform.c: (modest_platform_init):
4211 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4213 * tests/Makefile.am:
4214 * tests/dbus_api/Makefile.am:
4215 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4217 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4219 * src/maemo/modest-account-settings-dialog.c:
4220 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4221 Removed unnecessary includes.
4223 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4225 * src/maemo/easysetup/modest-easysetup-wizard.c:
4226 * src/maemo/modest-account-settings-dialog.c:
4227 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4228 * src/widgets/Makefile.am:
4229 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4230 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4231 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4232 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4233 * src/widgets/modest-secureauth-combo-box.c:
4234 * src/widgets/modest-secureauth-combo-box.h:
4235 * src/widgets/modest-serversecurity-combo-box.c:
4236 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4237 made the GObject names more consistent with the rest of the Modest code.
4239 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4241 * src/maemo/easysetup/Makefile.am:
4242 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4243 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4244 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4245 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4246 * src/maemo/easysetup/modest-easysetup-wizard.c:
4247 * src/maemo/easysetup/modest-validating-entry.c:
4248 * src/maemo/easysetup/modest-validating-entry.h:
4249 * src/maemo/modest-account-settings-dialog.c:
4250 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4251 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4252 widgets/ because they are used outside of easysetup too. After checking in,
4253 svn will allow me to rename them too.
4255 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4257 * src/gnome/modest-msg-edit-window.c:
4258 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4259 linker error, to fix the build on the GNOME platform.
4260 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4261 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4262 ifdefed out to avoid a warning.
4264 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4266 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4267 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4268 some alternative for GTK+ 2.6.
4270 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4272 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4274 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4275 specified for EmailAccountsDialog in UI spec.
4277 * src/maemo/easysetup/modest-easysetup-wizard.c:
4278 * src/maemo/easysetup/modest-easysetup-wizard.h:
4279 * src/maemo/modest-account-settings-dialog.c:
4280 * src/maemo/modest-account-settings-dialog.h:
4281 Reuse a member window widget for the connection-specific SMTP server accounts,
4282 so we can tell it to create/save the accounts only if we actually save changes.
4284 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4285 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4286 (modest_connection_specific_smtp_edit_window_get_settings):
4287 Return a struct instance for temporarily remembering the entered data.
4289 * src/maemo/modest-connection-specific-smtp-window.h:
4290 * src/maemo/modest-connection-specific-smtp-window.c:
4291 (modest_connection_specific_smtp_window_finalize),
4292 (modest_connection_specific_smtp_window_fill_with_connections),
4294 (modest_connection_specific_smtp_window_save_server_accounts),
4295 (update_model_server_names): Do not actually save data until asked,
4296 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4298 (on_selection_changed),
4299 (modest_connection_specific_smtp_window_init): Disable the edit
4300 button when nothing is selected.
4302 * src/modest-account-mgr-helpers.c:
4303 * src/modest-account-mgr-helpers.h:
4304 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4307 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4309 * src/modest-account-mgr-helpers.h:
4310 * src/modest-account-mgr-helpers.c:
4311 (modest_account_mgr_get_unused_account_name),
4312 (modest_account_mgr_get_unused_account_display_name): Added these
4313 utility functions, to avoid code duplication.
4315 * src/maemo/easysetup/modest-easysetup-wizard.c:
4316 (create_page_account_details), (create_account):
4317 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4318 (on_combo_security_changed),
4319 (modest_connection_specific_smtp_edit_window_init),
4320 (modest_connection_specific_smtp_edit_window_save_settings):
4321 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4322 * src/maemo/modest-connection-specific-smtp-window.c:
4323 (modest_connection_specific_smtp_window_finalize),
4324 (modest_connection_specific_smtp_window_fill_with_connections),
4325 (on_button_edit), (modest_connection_specific_smtp_window_init):
4326 * src/maemo/modest-connection-specific-smtp-window.h:
4327 Implementing saving of connection-specific server accounts.
4329 But I need to refactor this so we can save the data for each
4330 possible connection-specific account and only actually create the server accounts
4331 when the easysetup finished, or the OK button is pressed on the account settings
4334 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4336 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4337 (on_combo_security_changed):
4338 (modest_connection_specific_smtp_edit_window_init):
4339 Auto-fill the port number as in the account settings.
4341 (modest_connection_specific_smtp_edit_window_set_connection):
4342 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4343 * src/maemo/modest-connection-specific-smtp-window.c:
4344 (fill_with_connections), (on_button_edit),
4345 (modest_connection_specific_smtp_window_init):
4346 Turn the edit window into a dialog to simplify the code, and
4347 set a WM hint as in a GtkDialog, because only a popup can be on top of
4348 another window in Maemo, and popups usually have no WM decoration.
4350 * src/modest-defs.h:
4351 * src/modest-account-mgr-helpers.c:
4352 (modest_account_mgr_set_connection_specific_smtp),
4353 (modest_account_mgr_remove_connection_specific_smtp),
4354 (modest_account_mgr_get_connection_specific_smtp):
4355 * src/modest-account-mgr-helpers.h: Some functions to write the
4356 connection-specific SMTP server information. Not yet used.
4359 * src/widgets/modest-folder-view.c: (text_cell_data):
4360 Fix a warning about an uninitialized variable.
4361 (on_configuration_key_changed): Put an #ifdef around the use
4362 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4364 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4366 * src/maemo/modest-account-settings-dialog.h:
4367 * src/maemo/modest-account-settings-dialog.c:
4368 Added connect_for_modified() utility function to mark the new modified boolean.
4370 (create_page_account_details), (create_page_user_details),
4371 (create_page_incoming), (create_page_outgoing), (on_response),
4372 (modest_account_settings_dialog_init),
4373 (modest_account_settings_dialog_set_account_name):
4374 Only warn about unsaved changes when there are actually unsaved changes.
4376 * src/modest-account-mgr-helpers.c:
4377 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4378 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4379 to get the data from there in future.
4381 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4383 * src/modest-defs.h:
4385 * src/modest-account-mgr-helpers.h:
4386 * src/modest-account-mgr-helpers.c:
4387 Store the security account setting in a single conf key instead of using
4388 the options list, so that the list is left for just the to-be-removed camel hack,
4389 and because gconf_client_set_list() is failing for some reason.
4391 * src/modest-account-mgr.c:
4392 (modest_account_mgr_add_server_account):
4393 * src/maemo/modest-account-settings-dialog.c:
4394 (modest_account_settings_dialog_set_account_name),
4395 (save_configuration): Use the renamed functions.
4398 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4400 * src/widgets/Makefile.am:
4401 * src/widgets/modest-limit-retrieve-combo-box.c:
4402 * src/widgets/modest-limit-retrieve-combo-box.h:
4403 * src/widgets/modest-retrieve-combo-box.c:
4404 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4405 the account settings dialog.
4407 * src/modest-defs.h:
4408 * src/modest-account-mgr-helpers.h:
4409 * src/modest-account-mgr-helpers.c:
4410 (modest_server_account_get_option_secure_auth),
4411 (modest_server_account_set_option_secure_auth):
4412 * src/modest-account-mgr.c:
4413 (modest_account_mgr_add_server_account):
4414 Use the existing AUTH_MECH conf key for the secure-auth setting,
4415 instead of putting it in the list options, because this was actually used already.
4417 * src/maemo/modest-account-settings-dialog.c:
4418 (create_page_account_details),
4419 (modest_account_settings_dialog_set_account_name),
4420 (save_configuration):
4421 * src/maemo/modest-account-settings-dialog.h:
4422 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4423 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4425 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4427 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4428 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4429 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4431 * src/modest-defs.h:
4432 * src/maemo/modest-account-settings-dialog.c:
4433 (create_page_incoming), (on_combo_outgoing_security_changed),
4434 (on_combo_incoming_security_changed), (create_page_outgoing),
4435 (modest_account_settings_dialog_set_account_name),
4436 (save_configuration): Load/Save the port number, and change it when the
4437 security combo changes, to suitable defaults.
4439 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4441 * src/modest-account-mgr.c:
4442 (modest_account_mgr_add_server_account): Set the security and secure-auth
4443 options, and add a comment saying that the other camel-specific options should be
4446 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4448 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4450 * src/modest-tny-account-store.c: (account_list_free),
4451 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4452 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4455 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4457 * src/modest-protocol-info.c:
4458 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4459 is required by our UI spec. Maybe something in our implementation will use this eventually.
4460 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4461 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4462 instead of the previous 0 placeholder.
4464 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4465 secure-auth settings.
4466 * src/modest-account-mgr-helpers.h:
4467 * src/modest-account-mgr-helpers.c:
4468 (modest_server_account_data_get_option_secure_auth),
4469 (modest_server_account_set_option_secure_auth),
4470 (modest_server_account_data_get_option_security),
4471 (modest_server_account_set_option_security): Added this API for getting and setting the security
4472 and secure-auth settings.
4474 * src/maemo/modest-account-settings-dialog.h:
4475 * src/maemo/modest-account-settings-dialog.c:
4476 (modest_account_settings_dialog_finalize), (check_data),
4477 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4478 about changing titles.
4479 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4480 (save_configuration): Save the security and secure-auth settings.
4482 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4483 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4485 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4487 * src/modest-defs.h:
4488 * src/modest-account-mgr.c:
4489 (modest_account_mgr_add_server_account):
4490 Added and used defines for the options key and value pair strings,
4491 that are used so far, though they do not seem to correspond to anything in our
4492 UI specs or ModestProtocol enum.
4494 * src/modest-account-mgr-helpers.h:
4495 * src/modest-account-mgr-helpers.c:
4496 (compare_option_strings_for_name),
4497 (modest_server_account_data_get_option_value),
4498 (modest_server_account_data_get_option_bool),
4499 (modest_account_mgr_get_server_account_option):
4500 Added helper functions for parsing the options GSList.
4502 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4504 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4505 display name is based on the supplied account name.
4506 * src/modest-account-mgr.c:
4507 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4508 with an inefficient, but good-enough, implementation.
4510 * src/maemo/easysetup/modest-easysetup-wizard.c:
4511 (create_page_account_details), (on_before_next), (create_account):
4512 Check for existing display names rather than (non-user-visible) account names, and just
4513 create and set a unique account name at the end.
4515 * src/maemo/modest-account-settings-dialog.c:
4516 (modest_account_settings_dialog_init),
4517 (modest_account_settings_dialog_set_account_name),
4518 (create_page_incoming): Show the display name, instead of the account name.
4519 (on_response): Do some (not all) extra checks, as in the UI spec.
4520 (save_configuration): Save the display name if it was changed.
4522 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4524 * po/en_GB.po: Added needed logical ID and translation.
4525 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4526 (init_view): Made the is-default column clicking work.
4528 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4531 * src/maemo/easysetup/Makefile.am:
4532 * src/maemo/easysetup/modest-easysetup-wizard.c:
4533 (modest_easysetup_wizard_dialog_init):
4534 * src/maemo/easysetup/provider-data-test.keyfile:
4535 * src/maemo/easysetup/provider-data.keyfile:
4536 Moved the provider data file to the new modest-providers-data package and used it from there.
4538 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4540 * src/modest-local-folder-info.c:
4541 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4542 N_() was already used on the static strings, but this just marks it for translation without
4543 using the translation.
4545 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4547 * src/maemo/modest-account-settings-dialog.c:
4548 (create_page_incoming),
4549 (modest_account_settings_dialog_set_account_name):
4550 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4551 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4552 I will do this if nobody else gets there first.
4554 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4556 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4557 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4558 save the security stuff.
4560 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4562 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4563 Set the email address and user fullname, which I now see must be
4566 * src/maemo/modest-account-settings-dialog.h:
4567 * src/maemo/modest-account-settings-dialog.c:
4569 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4570 leave-on-server and authentication.
4571 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4574 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4577 * src/maemo/modest-account-settings-dialog.c:
4578 * src/maemo/modest-account-settings-dialog.h:
4579 Most (but not all) of the widgets are now present as specified by the UI spec.
4580 No changes are yet saved, and some details are not properly shown yet.
4582 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4584 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4586 * src/maemo/Makefile.am:
4587 * src/maemo/modest-account-settings-dialog.c:
4588 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4589 an existing account. Doesn't do much yet.
4591 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4592 Open the accounts settings dialog when Edit is clicked.
4594 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4596 * src/maemo/easysetup/Makefile.am:
4597 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4599 * src/maemo/easysetup/modest-easysetup-wizard.c:
4600 (modest_easysetup_wizard_dialog_init):
4601 Try to get the source directory from the build system,
4602 instead of hard-coding "./" into the source code, when opening our local
4603 copies of the configuration files.
4604 But this still fails when opening the wizard from the Accounts window,
4605 maybe because the working directory seems to change at runtime.
4606 So the wizard will fail the second time unless you copy the files into their
4607 proper locations - see the stdout warnings for the paths.
4609 (create_page_account_details),(on_before_next):
4610 Check for existing non-server accounts instead of server accounts,
4611 so the default account name is useful again, and to prevent trying to
4614 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4615 Show the wizard when New is clicked.
4617 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4618 (init_view): Show the column headers, and show the columns that are
4619 specified in the UI specs. However, something in Maemo's GTK+ prevents
4620 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4621 change the default account. This is despite unsetting the special properties.
4623 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4625 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4626 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4627 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4628 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4629 to make that clearer.
4630 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4632 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4634 * src/maemo/modest-account-view-window.c:
4635 (modest_account_view_window_init),
4636 (modest_account_view_window_new):
4637 Use the same buttons as specified in the
4638 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4639 the existing widgets, which never had a chance of working.
4640 Put the ModestAccountView treeview in a scrolled window.
4641 Do not repeat the initialization in both _init() and _new().
4643 * src/widgets/modest-account-view.c: (update_account_view):
4644 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4645 this widget and window shows no accounts.
4647 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4649 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4651 * src/maemo/easysetup/modest-easysetup-wizard.c:
4652 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4653 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4654 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4657 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4658 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4659 accounts exist yet, as in the UI spec.
4661 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4663 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4665 * src/maemo/Makefile.am:
4666 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4667 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4668 New window for editing connection-specific smtp details.
4669 Not fully implemented.
4671 * src/maemo/modest-connection-specific-smtp-window.c:
4672 (modest_connection_specific_smtp_window_finalize) :
4673 unref the tree model.
4674 (on_button_edit): Show the edit window.
4676 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4678 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4681 * src/maemo/Makefile.am:
4682 * src/maemo/modest-connection-specific-smtp-window.c:
4683 * src/maemo/modest-connection-specific-smtp-window.h:
4684 New window for showing the list of connections, for connection-specific
4685 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4686 * src/maemo/easysetup/modest-easysetup-wizard.c:
4687 (create_page_custom_outgoing): Show the new window when the button is clicked.
4689 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4691 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4692 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4693 * src/maemo/modest-msg-edit-window.c:
4694 (modest_msg_edit_window_insert_image):
4695 * src/modest-conf.c: (modest_conf_key_escape):
4696 * src/modest-mail-operation.c:
4697 (modest_mail_operation_send_new_mail):
4698 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4699 (modest_ui_actions_on_new_account):
4700 * src/widgets/modest-attachment-view.c: (update_filename_request):
4701 * src/widgets/modest-mail-header-view.c:
4702 Corrected warnings that were breaking the build, by commenting out unused variables,
4703 and a function, and by including a header.
4705 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4707 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4708 so we can #ifdef around platform-specific code when necessary.
4709 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4710 to allow this to build for the GNOME platform too.
4712 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4714 * src/maemo/easysetup/modest-easysetup-wizard.c:
4715 Added util_increment_name() and used it in create_page_account_details()
4716 to make sure that the default account name is always a new name.
4718 (modest_easysetup_wizard_dialog_init),
4719 (set_default_custom_servernames): Some minor memory management fixes.
4721 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4725 * src/modest-runtime.c: (init_i18n): Restored the translation
4726 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4727 are defined in config.h, and the translations are installed.
4729 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4730 is defined for translation.
4732 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4734 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4736 * src/maemo/easysetup/modest-easysetup-wizard.c:
4737 (modest_easysetup_wizard_dialog_init):
4738 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4739 Use realistic paths (though they should use $prefix generically) to the
4740 mcc_mapping and provider-data.keyfile files which might work when they
4741 are installed by the future version of the operator-wizard package,
4742 and then fallback to paths in our source code, with an explanatory
4745 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4749 * src/maemo/Makefile.am:
4750 * src/maemo/easysetup/: Added files from the previously-exernal
4751 osso-modest-easysetup.
4752 * src/maemo/modest-main-window-ui.h:
4753 * src/modest-ui-actions.c:
4754 * src/modest-ui-actions.h:
4755 Added modest_ui_actions_on_new_account() as a signal handler for the
4756 New Account menu item. It shows the easysetup wizard.
4757 * po/en_GB.po: Added additional needed logical IDs and translations.