1 2007-08-13 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
4 Comment out the debug warning about the unexpected D-Bus methods.
5 They are just annoying now.
6 * src/maemo/modest-platform.c:
7 (modest_platform_set_update_interval): Correct the D-Bus path, instead
8 of using a file path, though it did not seem to break things before.
9 It might be needed now:
10 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
11 modest is not already running. This is the behaviour of the old client, and
12 Mox says it is what we should do for modest.
13 This closes projects.maemo.org bug NB#64327.
15 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
17 * src/modest-text-utils.c:
18 Fixed invalid jump due to incorrect string/pointer
20 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
23 2007-08-01 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-account-mgr-helpers.h:
26 * src/modest-account-mgr-helpers.c:
27 Added modest_account_mgr_get_first_account_name(),
28 using code from modest_account_mgr_set_first_account_as_default().
30 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
31 (account_number_changed): Call set_at_least_one_account_visible() so that
32 the first account is visible when first added, without the user having to
34 I do wonder how this worked before.
36 2007-08-01 Murray Cumming <murrayc@murrayc.com>
38 * src/modest-tny-account-store.c: (show_password_warning_only),
39 (show_wrong_password), (request_password_and_wait), (get_password),
40 (modest_tny_account_store_alert): Remove the (incomplete anyway)
41 attempts to show UI only in the main context, which used g_idle_add()
42 and mainloops, because tinymail now guarantees that it only calls these
43 callbacks in the mainloop with the gdk lock. This makes everything much
46 2007-08-01 Murray Cumming <murrayc@murrayc.com>
48 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
49 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
50 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
51 error dialog, instead of ignoring it.
53 2007-08-01 Murray Cumming <murrayc@murrayc.com>
55 * src/maemo/modest-msg-view-window.c:
56 (modest_msg_view_window_get_header),
57 (modest_msg_view_window_last_message_selected):
58 Added comments to explain the use of priv->header_model.
59 * src/modest-ui-dimming-rules.c:
60 (modest_ui_dimming_rules_on_open_msg),
61 (modest_ui_dimming_rules_on_mark_as_read_msg),
62 (modest_ui_dimming_rules_on_mark_as_unread_msg),
63 (modest_ui_dimming_rules_on_remove_attachments),
64 (_invalid_attach_selected), (_selected_msg_marked_as):
65 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
66 and changed the parameter to a ModestMainWindow to make it clearer that
67 it never uses any other kind of window.
68 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
69 instead of the selected message.
70 I notice that much of the dimming code and the ModestMsgViewWindow code
71 hard-codes the assumption that the viewed message is always selected in
72 the header view. This does not seem wise or simple.
74 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
75 examine the actual message instead of whatever might be selected
76 in the header view. This stops the delete toolbar button and menu item
77 from being dimmed when opening a message view the search UI,
78 partially fixing projects.maemo.org bug NB#63811.
80 However, when actually deleting, I now get this warning:
81 "tny_header_set_flags: This is a header instance for a new message.
82 Only priority and attachment flags are supported"
84 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
86 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
88 Show account wizard if no accounts are defined while sending
89 (automatic sending after the account wizard finished does not
90 work because it takes some time until the account manager
91 synchronizes everything. (projects.maemo.org NB#62792)
93 2007-07-30 Murray Cumming <murrayc@murrayc.com>
95 * src/modest-tny-account-store.c: (on_account_removed),
96 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
97 account is removed from the View menu. We have TnyAccountStore
98 and ModestTnyAccountStore signals that seem very similar, but this
99 seems to work for now.
101 * src/maemo/modest-main-window.c:
102 (on_show_account_action_activated): Prevent dereference
103 of a NULL if the accoutn does not really exist, though that
104 should not happen anymore.
106 This fixes projects.maemo.org bug NB#64606.
108 2007-07-30 Murray Cumming <murrayc@murrayc.com>
110 * src/modest-ui-actions.c: (run_account_setup_wizard),
111 (modest_ui_actions_on_accounts): Revert a change that set these
112 to modal dialogs, freezing the UI when they show secondary dialogs.
113 This fixed projects.maemo.org bug NB#64519.
115 2007-07-27 Murray Cumming <murrayc@murrayc.com>
117 * src/widgets/modest-header-view-render.c:
118 (_modest_header_view_compact_header_cell_data):
119 Some checks and initialization to try to deal with a crash,
120 probably ineffective.
122 2007-07-27 Murray Cumming <murrayc@murrayc.com>
124 * src/maemo/modest-maemo-utils.c:
125 (modest_maemo_utils_get_supported_secure_authentication_methods):
126 Make sure that we have a connection, asking the user for one
128 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
129 Check for a connection before showing the wizard, because
130 the wizard needs a connection to check for server capabilities.
132 2007-07-27 Murray Cumming <murrayc@murrayc.com>
134 * src/maemo/modest-account-view-window.c:
135 (on_new_button_clicked): Remember the wizard dialog instance,
136 so we can just present it again if necessary. This prevents
137 multiple windows from appearing if you click again quickly on the
138 New button before the dialog appears, fixing projects.maemo.org
141 2007-07-27 Murray Cumming <murrayc@murrayc.com>
143 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
144 Offer a connection dialog if there is no connection when
145 starting modest. This should fix projects.maemo.org bug NB#61134.
147 2007-07-27 Murray Cumming <murrayc@murrayc.com>
149 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
150 Reverted my last commit. I was able to fix the build by doing
151 apt-get install wpeditor0 (replacing other wpeditor packages) and
152 an explicit apt-get install wpeditor-dev to upgrade the -dev
155 2007-07-27 Murray Cumming <murrayc@murrayc.com>
157 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
158 Commented out the use of wp_text_buffer_replace_image()
159 because it does not exist, to break the build. Added a TODO for it.
161 2007-07-26 Murray Cumming <murrayc@murrayc.com>
163 * src/modest-tny-account-store.c: (recreate_all_accounts):
164 Recreate them even if they were NULL before. I guess something
165 else was already creating them before, or this would never
167 (modest_tny_account_store_get_server_account): Make sure that
168 the tny accounts have been created before trying to find one.
169 This allows libmodest_dbus_client_compose_mail() to work
170 when the UI is not yet visible.
171 This is probably useful in other cases too.
173 (get_password): When the password is wrong after it is entered
174 in the protected password dialog, show an info banner (in an
175 idle handler) before showing the protected password dialog
178 2007-07-26 Murray Cumming <murrayc@murrayc.com>
180 * src/modest-ui-actions.h:
181 * src/modest-ui-actions.c: Added
182 modest_do_refresh_current_folder() containing some code from
183 modest_ui_actions_on_send_receive().
184 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
185 Call modest_do_refresh_current_folder() before refreshing the
186 requested account, as in modest_ui_actions_on_send_receive().
187 This is strange, but seems to be necessary to show new mails.
188 Now new emails are finally visible in the UI when downloaded
189 via the automatic update interval, fixing bug NB#57458.
190 This also works because bug NB#57458 has been fixed somehow.
192 2007-07-26 Murray Cumming <murrayc@murrayc.com>
194 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
195 printf more details when we get unhandled D-Bus methods, because
198 * src/modest-mail-operation.c: (update_account_thread):
199 Comment out the tny_camel_pop_store_account_reconnect(), because this
200 is apparently no longer needed, and it did not work before anyway.
201 See the comment in the code.
203 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
204 by checking the header flags. This fixes projects.maemo.org bug
207 2007-07-25 Murray Cumming <murrayc@murrayc.com>
209 * src/maemo/modest-maemo-utils.h:
210 * src/maemo/modest-maemo-utils.c: Added
211 modest_maemo_show_information_note_in_main_context_and_forget().
212 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
213 Use the new function to show simple error dialogs in the main
214 context, though question dialogs are still in the current context,
215 which is unfortunately usually not the main context. This should
218 2007-07-25 Murray Cumming <murrayc@murrayc.com>
220 * src/modest-tny-account-store.c: (get_password):
221 Never save the entered username and password in gconf,
222 because the UI spec says we should not. This helps
223 slightly with projects.maemo.org bug NB#63671.
225 2007-07-25 Murray Cumming <murrayc@murrayc.com>
227 * src/widgets/modest-msg-edit-window.h:
228 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
229 Moved some code here to make it simpler.
230 (modest_msg_edit_window_attach_file_one): Renamed from
231 modest_msg_edit_window_attach_file_interactive().
232 (modest_msg_edit_window_offer_attach_file): Renamed from
233 modest_msg_edit_window_attach_file() and used
234 modest_msg_edit_window_attach_file_one() instead of
235 copy/pasting the code. The old code for one was not using
236 GnomeVFS. This allows use of smb:// URLs when using send-as
237 from external applications, fixing bug NB#63741.
239 (modest_msg_edit_window_insert_image),
240 (modest_msg_edit_window_add_attachment_clicked):
241 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
242 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
243 Adapted to the new function names.
245 2007-07-25 Murray Cumming <murrayc@murrayc.com>
247 (modest_platform_set_update_interval): Set the alarm recurrence
248 fields so that auto-update does not just happen the first time.
249 This should have fixed projects.maemo.org bug NB#63938.
251 When this happens you can see a printf when the D-Bus method is
253 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
255 However, I do not actually seem to get new POP messages even when
256 clicking the refresh button manually. A restart gets them.
257 This might be a problem in today's tinymail only.
259 2007-07-24 Murray Cumming <murrayc@murrayc.com>
261 * src/maemo/modest-maemo-global-settings-dialog.c:
262 (current_connection):
263 Avoid a crash (probably only in scratchbox) when strcmp()ing a
264 NULL when closing the dialog.
266 2007-07-24 Murray Cumming <murrayc@murrayc.com>
268 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
269 Remove the hacky send/receive that didn't work, and instead
270 refilter the treemodel to make the deleted email really vanish from
271 the UI (though the delete-from-menu code does has commented out
272 the code that does that). This fixes projects.maemo.org bug
275 2007-07-24 Murray Cumming <murrayc@murrayc.com>
277 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
278 Try a couple of tricks to force the treeview to update (
279 poke the folder, and do a send/receive refresh), but the deleted
280 email still appears with a strike-through instead of really being
283 2007-07-23 Murray Cumming <murrayc@murrayc.com>
285 * src/dbus_api/modest-dbus-callbacks.c:
286 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
287 because their ID is not human-readable (see the comment about
288 improvements needed to the osso-email-interface API) and
289 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
291 2007-07-23 Murray Cumming <murrayc@murrayc.com>
293 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
294 (add_folders_to_list), (on_dbus_method_get_folders),
295 (modest_dbus_req_filter):
296 * src/maemo/modest-maemo-utils.c:
297 (on_camel_account_get_supported_secure_authentication):
298 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
299 (on_header_view_focus_in):
300 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
301 * src/modest-formatter.c: (modest_formatter_create_body_part):
302 * src/modest-mail-operation.c: (recurse_folders),
303 (update_account_thread), (get_msgs_full_thread),
304 (modest_mail_operation_get_msgs_full),
305 (modest_mail_operation_xfer_msgs):
306 * src/modest-search.c: (search_mime_part_and_child_parts),
307 (modest_search_account), (modest_search_all_accounts):
308 * src/modest-tny-account.c:
309 (modest_tny_account_get_special_folder), (recurse_folders):
310 * src/modest-tny-local-folders-account.c:
311 (modest_tny_local_folders_account_query_passes):
312 * src/modest-tny-msg.c: (copy_mime_part),
313 (modest_tny_msg_find_body_part_from_mime_part):
314 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
315 (modest_tny_send_queue_try_to_send):
316 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
317 (_modest_ui_actions_open), (download_uncached_messages),
318 (reply_forward), (modest_ui_actions_on_copy),
319 (modest_ui_actions_on_details), (has_retrieved_msgs),
320 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
322 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
323 (_selected_msg_marked_as), (_msg_download_completed),
324 (_selected_msg_sent_in_progress):
325 * src/widgets/modest-attachments-view.c:
326 (modest_attachments_view_set_message):
327 * src/widgets/modest-msg-view.c: (find_cid_image):
328 * tests/check_folder-transfer.c: (find_folders):
329 * tests/check_update-account.c: (func):
330 * tests/dbus_api/test_get_folders.c: (main):
331 Checked all uses of tny_iterator_get_current(), making sure
332 that the object is unreferenced (3 or 4 places did not),
333 and adding checks for NULL.
335 2007-07-23 Murray Cumming <murrayc@murrayc.com>
337 * src/dbus_api/modest-dbus-callbacks.c:
338 (on_idle_open_default_inbox): Make sure that the application UI is
340 * src/maemo/easysetup/modest-easysetup-wizard.c:
341 (on_entry_invalid_character): Show the word whitespace instead
342 of (null) in the banner when whitespace was entered.
343 (show_error): Add a comment that this does not work in
344 Maemo Bora, though we do not know why.
346 2007-07-23 Murray Cumming <murrayc@murrayc.com>
348 * src/modest-tny-account.c:
349 (modest_tny_account_get_special_folder): Use an if instead of
350 an assert for when the parent account name is NULL, because this
351 might be causing a crash in projects.maemo.org bug 63192.
352 * src/modest-mail-operation.c:
353 (modest_mail_operation_send_new_mail_cb),
354 (modest_mail_operation_remove_folder): unref the folder that is
355 returned from modest_tny_account_get_special_folder().
357 2007-07-23 Murray Cumming <murrayc@murrayc.com>
359 * src/modest-ui-actions.c:
360 (modest_ui_actions_on_password_requested):
361 Show mail_ib_login_cancelled info banner when the user cancels
362 the protected password dialog, to fix projects.maemo.org
365 2007-07-23 Murray Cumming <murrayc@murrayc.com>
367 * src/maemo/modest-account-settings-dialog.c:
368 (create_page_outgoing): Put this page in a GtkScrolledWindow,
369 matching the UI mock-up in the UI spec, and allowing access
370 to all widgets even when the on-screen keyboard is active.
372 2007-07-23 Murray Cumming <murrayc@murrayc.com>
374 Reverted this previous commit from Johannes,
375 because the scrollbars are always visible and because
376 I think we only need it on onepage of the account
377 settings, not the account wizard.
378 (I wrote the wrong instructions in the bug.)
380 * src/maemo/easysetup/modest-easysetup-wizard.c:
381 Added scrollbars to account wizard dialog.
382 Fixed projects.maemo.org NB #62744
384 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
386 * src/maemo/easysetup/modest-easysetup-wizard.c:
387 (create_page_user_details):
388 Use auto-cap for name (projects.maemo.org NB#63716)
389 * src/widgets/modest-account-view.c: (on_account_busy_changed):
391 2007-07-22 Armin Burgmeier <armin@openismus.com>
393 * src/maemo/modest-ui-actions.c: Use current account instead of
394 default account for creating viewer windows, so that the viewer
395 window knows to which account the viewed message belongs.
397 * src/maemo/modest-msg-view-window.c: Destroy the window when the
398 corresponding account is deleted. This fixes projects.maemo.org bug
401 2007-07-18 Armin Burgmeier <armin@openismus.com>
403 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
404 the dialog close after entering an invalid port number and clicking
405 OK. This fixes projects.maemo.org bug NB#63602.
407 2007-07-18 Armin Burgmeier <armin@openismus.com>
409 * src/modest-tny-account-store.c:
410 (get_server_accounts): Set parent modest account name for each
411 connection-specific transport account so that special folders of such
412 an account can be looked up. This fixes a crash when changing account
413 settings. This might also be related to projects.maemo.org bug
416 2007-07-16 Armin Burgmeier <armin@openismus.com>
418 * src/modest-ui-actions.c: Added a button to create a folder to the
419 move-to dialog. This fixes projects.maemo.org bug NB#.
421 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
423 * src/maemo/easysetup/modest-easysetup-wizard.c:
424 Added scrollbars to account wizard dialog.
425 Fixed projects.maemo.org NB #62744
427 2007-07-16 Murray Cumming <murrayc@murrayc.com>
429 * src/widgets/modest-msg-view.h:
430 * src/widgets/modest-msg-view.c:
431 Added modest_msg_view_get_message_is_empty() but this needs
433 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
434 Check if there is any text in the message yet.
435 But this needs to be implemented properly.
436 (modest_msg_edit_window_toggle_find_toolbar):
437 * src/maemo/modest-msg-view-window.c:
438 (modest_msg_view_window_toggle_find_toolbar):
439 Show a banner warning if there is no text to search, when
440 trying to start a search. This partially fixes
441 projects.maemo.org bug NB#62350.
443 2007-07-13 Murray Cumming <murrayc@murrayc.com>
445 * src/modest-mail-operation.c: (update_account_thread):
446 Initialized num_new_headers to fix the build.
448 2007-07-13 Murray Cumming <murrayc@murrayc.com>
450 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
451 Ignore modest accounts whose server accounts don't exist in gconf.
452 This prevents us trying to create TnyAccount instances for those
453 server accounts when the server account has been removed from gconf,
454 but the parent modest account has not yet been removed from modest.
455 I don't know why this is only noticeable now. It was probably just
456 a harmeless g_warning() anyway.
458 2007-07-13 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
461 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
463 2007-07-12 Armin Burgmeier <armin@openismus.com>
465 * src/maemo/modest-main-window.c: Make default account appear bold
466 in view, tools/send & receive and toolbar/send & receive SCM menus.
467 This fixes projects.maemo.org bug NB#59010.
469 2007-07-12 Murray Cumming <murrayc@murrayc.com>
471 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
472 Add a short-cut, by checking if the folder store is an account.
473 This ensures that the Sort menu item and toolbar is dimmed for
474 the local-folders account root item, fixing
475 projects.maemo.org bug NB#62545.
477 2007-07-12 Murray Cumming <murrayc@murrayc.com>
479 * src/modest-tny-account-store.c: (get_password):
480 Show the password dialog (via the signal) only in the mainloop, via
481 an idle handler that we wait for. This could theoretically prevent
482 hangs, though I worry that it could introduce some too.
484 2007-07-12 Murray Cumming <murrayc@murrayc.com>
486 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
487 * src/maemo/modest-platform.c:
488 (modest_platform_connect_and_wait):
489 Take a TnyAccount* parameter and try to set it to online
490 (a TnyCamel-only API), because tinymail sets accounts to offline
491 when the user cancels a password dialog, and doesn't ask again until
492 it has been set to online.
493 However, this is commented out because it causes a hang now.
495 (modest_platform_connect_and_wait_if_network_account):
496 * src/modest-mail-operation.c:
497 (modest_mail_operation_update_account):
498 * src/modest-platform.h:
499 * src/modest-ui-actions.c: (_modest_ui_actions_open),
500 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
502 2007-07-12 Armin Burgmeier <armin@openismus.com>
504 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
506 * src/modest-mail-operation.c:
507 * src/modest-ui-actions.c: Check for already existing folder before
508 querying the server, show error message from camel if the request
509 still fails. This fixes projects.maemo.org bug NB#58701.
511 2007-07-12 Murray Cumming <murrayc@murrayc.com>
513 * src/modest-tny-account-store.h:
514 * src/modest-tny-account-store.c:
515 Added modest_tny_account_store_forget_password_in_memory(),
516 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
517 when creating a new account, so that new passwords will be used, instead of
518 us thinking that it's a second request as a result of a failed password again.
520 2007-07-12 Murray Cumming <murrayc@murrayc.com>
522 * src/dbus_api/modest-dbus-callbacks.c:
523 (on_idle_open_message): If the message is in drafts then open it
524 in an edit window instead of a view window. This fixes
525 projects.maemo.org bug NB#63005.
527 2007-07-12 Murray Cumming <murrayc@murrayc.com>
529 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
530 Avoided a harmless g_warning().
532 2007-07-12 Murray Cumming <murrayc@murrayc.com>
534 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
535 Pass the modest account name, not the TnyAccount display name to
536 modest_msg_view_window_new() so that the reply feature works,
537 fixing projects.maemo.org bug NB#62892.
539 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
540 (modest_msg_view_window_new_with_header_model):
541 * src/maemo/modest-msg-view-window.c:
542 (modest_msg_view_window_new_with_header_model),
543 (modest_msg_view_window_new):
544 * src/modest-ui-actions.c: (reply_forward):
545 * src/widgets/modest-msg-view-window.h:
546 * src/widgets/modest-window.c: (modest_window_set_active_account):
547 Rename an account parameter to modest_account_name to make this clearer.
549 2007-07-11 Murray Cumming <murrayc@murrayc.com>
551 * src/modest-ui-actions.h:
552 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
553 modest_do_message_delete().
554 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
555 Call modest_do_message_delete(), hoping that this would cause messages
556 to be really deleted from search instead of just marked with strike through.
557 Does not seem to help.
559 2007-07-11 Armin Burgmeier <armin@openismus.com>
561 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
562 priv->reselect to FALSE prior to calling
563 modest_folder_view_select_first_inbox_or_local() to prevent endless
564 recursion and thus a crash on startup.
566 2007-07-11 Armin Burgmeier <armin@openismus.com>
568 * src/maemo/modest-account-settings-dialog.h: Include
569 <gtk/gtknotebook.h> to fix the build (at least for me).
571 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
572 Use "New FolderN" as default suggested name if "New folder" already
573 exists, with N being the first free number, though never exceed "New
574 folder99" in which case we just fall back to "New Folder" even though
575 it already exists. This fixes projects.maemo.org bug NB#58663.
577 2007-07-11 Murray Cumming <murrayc@murrayc.com>
579 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
580 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
581 projects.maemo.org bug NB#62778.
583 2007-07-11 Murray Cumming <murrayc@murrayc.com>
585 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
586 Ignore the wrong (for now) secure-smtp setting in the presets -
587 just default to requiring secure authentication for SMTP, because
590 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
592 * src/widgets/modest-folder-view.c: (filter_row)
593 Do not show drafts folder (see UI specs)
595 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
597 * src/modest-ui-actions.c:
598 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
599 place and also not necessary.
601 * src/widgets/modest-folder-view.c: (filter_row)
602 Guess folder type and hide Sent & Outbox if necessary.
603 Fixed project.maemo.org NB#57328
605 2007-07-11 Murray Cumming <murrayc@murrayc.com>
607 * src/modest-ui-actions.h:
608 * src/modest-ui-actions.c:
609 (modest_ui_actions_on_delete_message):
610 Move some code into a new
611 modest_ui_actions_refresh_message_window_after_delete()
612 function so we can use it from elsewhere.
614 * src/dbus_api/modest-dbus-callbacks.c:
615 (on_idle_delete_message), (on_delete_message): Used an idle
616 handler, as we do for the other D-Bus method handlers.
617 Call modest_ui_actions_refresh_message_window_after_delete()
618 if the deleted message was open in a window. This fixed
619 projects.maemo.org bug NB#62862.
621 2007-07-11 Murray Cumming <murrayc@murrayc.com>
623 * src/modest-main.c: (main): Only show the UI at the start if
624 the showui command line option was given. For instance,
625 run-standalone src/modest showui
626 Otherwise, we wait for the top_application D-Bus method to
627 be sent by hildon-desktop when the application is selected
629 This allows us to run without a UI when osso-global-search
630 uses our D-Bus methods.
632 2007-07-11 Murray Cumming <murrayc@murrayc.com>
634 * src/dbus_api/modest-dbus-api.h: Added a define for a
635 top-application D-Bus method.
636 * src/dbus_api/modest-dbus-callbacks.c:
637 (on_top_application),
638 (modest_dbus_req_handler): Handle the top-application D-Bus
639 method, which might be an undocumented D-Bus signal sent by
640 hildon-desktop when it starts the application from the menu.
641 But I am not sure and I need to test it on the device, because
642 my scratchbox does not have the application in the menu now.
643 This method shows the main window, so that it can be invisible
644 when started, for instance, just for email searching from
647 * src/maemo/modest-main-window.c: (restore_settings),
648 (modest_main_window_new): Do not show the window immediately
649 upon creation. We show it later.
650 * src/modest-widget-memory.c: (save_settings_paned):
651 Try (unsuccessfully) to avoid saving the paned position when
652 it is not even visible.
653 (restore_settings_paned): Do not allow a silly paned position.
654 This seems necessary when not showing the window at first.
656 * tests/dbus_api/Makefile.am:
657 * tests/dbus_api/test_top_application.c: (main): Test for the
660 2007-07-10 Murray Cumming <murrayc@murrayc.com>
662 * src/modest-ui-dimming-rules.c:
663 (modest_ui_dimming_rules_on_new_msg),
664 (modest_ui_dimming_rules_on_reply_msg),
665 (modest_ui_dimming_rules_on_delete_msg),
666 (modest_ui_dimming_rules_on_details),
667 (modest_ui_dimming_rules_on_view_window_move_to),
668 (modest_ui_dimming_rules_on_view_previous),
669 (modest_ui_dimming_rules_on_view_next),
670 (_invalid_folder_for_purge): Added checks before
671 casting the window. This looks like an actual
672 logic error in _invalid_folder_for_purge(), because it
673 tries to use a ModestMainWindow as a message window.
675 2007-07-10 Murray Cumming <murrayc@murrayc.com>
677 * src/maemo/modest-account-settings-dialog.c:
678 (show_error): Use the same implementation as in
679 modest-easysetup-wizard.c:
680 (on_entry_invalid_character): The logical ID contains a %s.
681 Guessed what it should be.
682 (on_entry_max), (check_data), (on_response): Adapt to
683 changed show_error().
684 (create_page_account_details): Really call
685 modest_validating_entry_set_func() on the correct widgets.
686 * src/maemo/easysetup/modest-easysetup-wizard.c:
687 (on_entry_invalid_character): Fix the logical ID here too.
688 (create_page_account_details),
689 (create_page_user_details):
691 modest_validating_entry_set_func() on the correct widgets.
693 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
694 Do not try to use the account if it is NULL.
696 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
698 * src/modest-ui-actions.c: (create_move_to_dialog),
699 (modest_ui_actions_on_main_window_move_to),
700 (modest_ui_actions_on_msg_view_window_move_to):
701 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
702 (filter_row), (modest_folder_view_show_non_move_folders):
703 * src/widgets/modest-folder-view.h:
705 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
706 the Sent folder yet as it does not report the correct folder type.
708 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
710 * src/maemo/modest-msg-edit-window.c: (init_window):
713 2007-07-10 Murray Cumming <murrayc@murrayc.com>
715 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
716 Take a parent widget instead of a parent window, and
717 implement this with hildon_banner_show_information() instead.
718 Non-Maemo builds can just ifdef that there.
719 This fixed projects.maemo.org bug NB#62766.
721 (on_entry_invalid_character): Use show_error() again instead
722 of using hildon directly, and use the _CS() macro to use the correct
724 (create_account), (check_for_supported_auth_methods), (on_entry_max):
725 Pass a widget instead od a window to show_error().
727 2007-07-10 Murray Cumming <murrayc@murrayc.com>
729 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
730 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
731 This allows us to show the server name in the error message, fixing
732 projects.maemo.org bug NB#62904.
733 Also, use the appropriate logical ID message for the account protocol.
735 2007-07-10 Murray Cumming <murrayc@murrayc.com>
737 * src/modest-tny-account-store.c: (on_idle_wrong_password):
738 A compilation fix, though the build wasn't broken for me.
740 2007-07-09 Murray Cumming <murrayc@murrayc.com>
742 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
743 Do not try to unref a NULL folder store, to avoid a runtime warning.
744 This seems to happen sometimes when changing accounts settings.
746 2007-07-09 Murray Cumming <murrayc@murrayc.com>
748 * src/modest-tny-account-store.c:
749 (modest_tny_account_store_instance_init),
750 (modest_tny_account_store_finalize),
751 (on_account_settings_hide), (on_idle_wrong_password):
752 Use a GHashTable to ensure that we only show one account settings
753 dialog per modest account. This avoids us having a dialog open for
754 both the store and transport accounts, or due to repeated get_password()
755 calls that shouldn't happen anyway.
757 2007-07-09 Murray Cumming <murrayc@murrayc.com>
759 * src/maemo/modest-maemo-utils.c: (on_hide),
760 (modest_maemo_show_dialog_and_forget): Handle the response, because
761 the window is not even hidden by default.
763 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
764 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
765 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
766 which seems to prevent some modality problems.
768 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
769 Ignore user cancellation errors.
771 * src/modest-account-mgr-helpers.h:
772 * src/modest-account-mgr-helpers.c:
773 Added modest_server_account_get_password() and
774 modest_server_account_get_has_password() to avoid direct use of
777 * src/maemo/modest-account-settings-dialog.h:
778 * src/maemo/modest-account-settings-dialog.c:
779 (modest_account_settings_dialog_init): Store the notebook so we can
781 Added modest_account_settings_dialog_switch_to_user_info().
783 * src/modest-tny-account-store.c:
784 (get_password): When the password in the account settings is wrong (we think),
785 show the relevant page of the account settings dialog, in the mainloop.
786 However, we currently get many of these at once because cancel does not
788 (forget_password): Do not forget the password
789 from the account settings, because this causes side-effects when
790 tinymail seems to call it at strange time, maybe because of how we
791 are cancelling get_password().
792 (modest_tny_account_store_alert): Ignore user cancellations.
794 2007-07-09 Murray Cumming <murrayc@murrayc.com>
796 * src/maemo/modest-maemo-utils.h:
797 * src/maemo/modest-maemo-utils.c:
798 Added modest_maemo_show_information_note_and_forget() for use instead of
799 gtk_dialog_run() when the response is not needed, to avoid an extra
800 mainloop which could cause a hang.
802 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
803 Use the logical IDs for the error message, though they are not
804 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
805 because gtk_dialog_run() caused a hang here (the window did not close).
806 This fixes projects.maemo.org bug NB#62646.
808 2007-07-09 Murray Cumming <murrayc@murrayc.com>
810 * src/modest-account-mgr-helpers.h:
811 * src/modest-account-mgr-helpers.c:
812 Added modest_account_mgr_get_store_protocol().
814 * src/maemo/modest-account-view-window.c:
815 (on_delete_button_clicked): Show different warning text depending on
816 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
817 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
820 2007-07-09 Murray Cumming <murrayc@murrayc.com>
822 * src/maemo/modest-msg-edit-window.c:
823 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
824 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
826 2007-07-07 Armin Burgmeier <armin@openismus.com>
828 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
829 ckdg_ib_maximum_characters_reached from correct package.
831 * src/modest-ui-actions.c: Show an error message when a folder could
832 not be created. Tinymail does not give us specific error codes about
833 what has gone wrong, so we assume that a folder with that name
834 already exists, though there might be other reasons.
836 2007-07-06 Murray Cumming <murrayc@murrayc.com>
838 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
839 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
840 give a more exact error message that can be partly translated.
842 2007-07-05 Murray Cumming <murrayc@murrayc.com>
844 * src/maemo/modest-address-book.c:
845 (select_email_addrs_for_contact): Specify a default window size for the
846 select-email-address dialog, so that it is probably big enough for the
847 title. This should fix projects.maemo.org bug NB#62277.
849 2007-07-05 Murray Cumming <murrayc@murrayc.com>
851 * src/maemo/easysetup/modest-easysetup-wizard.c:
852 (create_page_complete_easysetup): Use
853 gtk_widget_set_size() request to ensure that the text wraps
856 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
858 * src/maemo/easysetup/modest-easysetup-wizard.c:
859 (on_entry_invalid_character), (create_page_account_details),
860 (create_page_user_details):
861 Use new API of ModestValidatingEntry. But for some reason the banner is
862 not shown. I will have to investigate that further.
864 * src/widgets/modest-validating-entry.c: (on_insert_text),
865 (modest_validating_entry_set_func):
866 * src/widgets/modest-validating-entry.h:
867 Added a new callback function to be able to react to prevented
868 characters whitespaces to e.g show a banner.
870 2007-07-05 Armin Burgmeier <armin@openismus.com>
872 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
873 notification of HildonNumberEditor instead of remembering the port
874 number. Thanks to Johannes for pointing this out.
876 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
878 * src/maemo/easysetup/modest-easysetup-wizard.c:
879 Check if there are any user changes before showing a confirmation
880 dialog (projects.maemo.org NB#60946)
882 2007-07-05 Armin Burgmeier <armin@openismus.com>
884 * src/maemo/modest-account-settings-dialog.c: Remember custom port
885 number at the beginning of the dialog and set the modified flag at the
886 end if the port number has changed. This is necessary because
887 HildonNumberEditor does not support notification when the value has
890 2007-07-05 Murray Cumming <murrayc@murrayc.com>
892 * src/modest-ui-actions.c:
893 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
894 a connection before asking anything else. Correct the check for the destination
895 folder so that it succeeds when online.
896 This fixed projects.maemo.org bug NB#61645.
898 2007-07-05 Murray Cumming <murrayc@murrayc.com>
900 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
901 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
902 to fix projects.maemo.org bug NB#62439.
904 2007-07-05 Murray Cumming <murrayc@murrayc.com>
906 * src/modest-tny-account.c: (on_connection_status_changed):
907 Really do not use tny_device_force_offline() here. See the previous comment.
909 2007-07-04 Murray Cumming <murrayc@murrayc.com>
911 * src/modest-tny-account.c: (on_connection_status_changed):
912 Do not use tny_device_force_offline() when tinymail says that something
913 went wrong with the connection. It seems to report this unnecessarily.
915 2007-07-04 Murray Cumming <murrayc@murrayc.com>
917 * src/maemo/modest-connection-specific-smtp-window.c:
918 (modest_connection_specific_smtp_window_init):
919 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
920 does not seem to have any effect in osso 1.1 (though it works in
921 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
923 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
925 * src/maemo/modest-connection-specific-smtp-window.c:
926 Fix UI specification problems with projects.meamo.org NB#60479
928 2007-07-04 Murray Cumming <murrayc@murrayc.com>
930 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
931 clue when this has failed, because the error dialog is not always shown
932 (at least in earlier version).
934 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
935 GError message, because the generic error dialog is not helpful.
937 'This message is not currently available (can't let a new connection go online)'
938 when trying to open an IMAP message.
940 (_modest_ui_actions_open): Offer a connection when some messages would
941 have to be downloaded and we are offline.
943 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
945 * src/widgets/modest-folder-view.c:
946 Don't check for MERGE type anymore as we use the correct type
948 NOTE: For the last two changes you need to update your tinymail copy
949 because of API changes!
951 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
953 * src/modest-tny-local-folders-account.c:
954 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
955 (see projects.maemo.org NB#61580)
957 2007-07-04 Murray Cumming <murrayc@murrayc.com>
959 * src/modest-tny-account.c: (on_connection_status_changed):
960 Commented out the call to modest_platform_connect_and_wait() because this
961 seems to always hang, and I would like to know if this is the only thing
962 that causes a hang when showing the connection dialog.
963 It is not very useful anyway.
965 2007-07-04 Murray Cumming <murrayc@murrayc.com>
967 * src/maemo/modest-msg-view-window.c:
968 (modest_msg_view_window_select_next_message):
970 * src/modest-platform.h:
971 * src/maemo/modest-platform.c:
972 Added modest_platform_connect_and_wait(), which calls
973 tny_maemo_conic_device_connect() always in the main thread, by calling it
974 in an idle handler and waiting for the idle handler to run. It should be
975 in the main thread because it uses GTK+ UI code. It just returns TRUE
976 if the device is already online.
978 There is some nasty code to ensure that subsequent calls to
979 modest_platform_connect_and_wait() just wait for the first one to finish,
980 by checking repeatedly in another idle handler. This is necessary,
981 because other threads (or even the main thread, via another idle handler)
982 can call modest_platform_connect_and_wait() while
983 modest_platform_connect_and_wait() is running.
985 (modest_platform_connect_and_wait_if_network_account),
986 (modest_platform_connect_and_wait_if_network_folderstore):
987 Convenience functions that calls modest_platform_connect_and_wait() if
988 the account or folder might want network access.
990 * src/modest-mail-operation.c:
991 (modest_mail_operation_update_account):
992 * src/modest-ui-actions.c: (download_uncached_messages),
993 (modest_ui_actions_on_rename_folder), (delete_folder),
994 (modest_ui_actions_on_main_window_move_to),
995 (modest_ui_actions_on_msg_view_window_move_to):
996 * src/widgets/modest-folder-view.c:
997 (drag_and_drop_from_folder_view):
998 Offer a connection if we are offline.
1000 * src/modest-tny-account.c: (on_connection_status_changed):
1001 Document this as only handling errors during network operations in progress,
1002 and replace the idle code with a simple call to
1003 modest_platform_connect_and_wait(), which does this instead.
1005 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1007 * src/modest-tny-account.c:
1008 (modest_tny_account_get_special_folder): (util_on_idle),
1009 Handle the GError so we can see when tny_folder_store_get_folders()
1010 fails, as it currently does while something else is connecting.
1012 Added util_run_in_main_thread_and_wait()
1013 which uses an idlen handler and mainloop to ensure that the function
1014 is called in the main thread.
1015 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1016 to make sure that we call attempt the connection in the mainloop only,
1017 which might solve some hangs.
1019 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1021 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1022 be found by their display name. This is never useful.
1023 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1024 by its ID, instead of trying to use its ID as its display name.
1026 * src/modest-tny-account-store.h:
1027 * src/modest-tny-account.c:
1028 (modest_tny_account_get_special_folder): Add a g_warning() when
1029 tny_folder_store_get_folders() returns an empty list for the maildir.
1031 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1032 Add a g_warning() when this returns NULL, because that it not allowed
1035 2007-07-02 Armin Burgmeier <armin@openismus.com>
1037 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1038 note when trying to cancel the wizard. This fixes projects.maemo.org
1041 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1043 * src/modest-tny-account.h:
1044 * src/modest-tny-account.c:
1045 (modest_tny_account_new_from_server_account),
1046 (modest_tny_account_new_from_server_account_name),
1047 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1048 because this must now be set before setting the proto. This is usd in
1049 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1050 warning in camel_session_get_service() caused by
1051 tny_camel_transport_account_prepare().
1053 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1056 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1058 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1060 (modest_connection_specific_smtp_edit_window_init):
1062 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1063 of "changed" for now
1065 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1067 * src/modest-tny-account.c:
1068 (modest_tny_account_new_from_server_account):
1069 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1070 now uses to request a connection when it needs one, and which it uses
1071 to tell us that something is wrong with the connection, so we can force
1072 the accounts offline to prevent further problems.
1074 * src/modest-defs.h:
1075 * src/modest-init.c: (init_default_settings):
1076 * src/modest-mail-operation.c:
1077 (modest_mail_operation_update_account):
1078 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1079 This should not be necessary anymore. Do not set the conf key that
1080 determined this (it was always TRUE and not set anywhere else).
1082 * src/modest-ui-actions.h: Remove unused and unimplemented
1083 modest_ui_actions_on_online_toggle_toggled().
1085 2007-06-29 Murray Cumming <murrayc@murrayc.com
1087 * src/maemo/modest-main-window.c: (connect_signals):
1088 Don't connect to delete_event twice. Maybe this was harmless.
1090 2007-06-29 Murray Cumming <murrayc@murrayc.com
1092 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1093 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1094 Debug output to give some more clue when a folder move is not allowed.
1096 2007-06-28 Murray Cumming <murrayc@murrayc.com
1098 * src/modest-tny-account.c: (on_modest_file_system_info),
1099 (modest_tny_account_get_mmc_account_name):
1100 Always call the callback, without checking whether the name has changed.
1101 * src/widgets/modest-folder-view.c: (strings_are_equal),
1102 (on_model_foreach_set_name), (on_get_mmc_account_name),
1103 (text_cell_data): Compare the name here, and use the name from
1104 the account rather than from the
1105 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1106 if the name was changed after the account was added to the model.
1107 That's a tinymail bug but not one that I want to fix now.
1109 This finally fixes projects.maemo.org bug NB#59301.
1111 2007-06-27 Armin Burgmeier <armin@openismus.com>
1113 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1116 2007-06-27 Murray Cumming <murrayc@murrayc.com
1118 * src/modest-tny-account.h:
1119 * src/modest-tny-account.c:
1120 Added modest_tny_account_get_mmc_account_name(), to set the memory
1121 card name asynchronously for the given account and then notify.
1122 (modest_tny_account_new_for_local_folders): Use this new function instead
1123 of using hildon_file_system_info_async_new() directly.
1125 * src/widgets/modest-folder-view.c: (text_cell_data):
1126 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1127 gtk_tree_model_row_changed() when it is available.
1129 This should fix projects.maemo.org bug NB#59301.
1131 2007-06-27 Murray Cumming <murrayc@murrayc.com
1133 * src/modest-mail-operation.c: (update_account_thread),
1134 (get_msgs_full_thread): Fix typo failures in the revert
1137 2007-06-27 Murray Cumming <murrayc@murrayc.com
1139 * src/maemo/modest-maemo-global-settings-dialog.c:
1140 (idle_select_default_focus):
1141 * src/modest-mail-operation.c: (idle_notify_progress),
1142 (idle_notify_progress_once), (set_last_updated_idle),
1143 (update_account_thread), (get_msgs_full_thread):
1144 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1145 * src/widgets/modest-header-view.c:
1146 (idle_notify_headers_count_changed_destroy),
1147 (idle_notify_headers_count_changed):
1148 Reverted the additions of gdk_threads_enter/leave(), in case this
1149 helps with a startup hang on the device.
1151 2007-06-26 Armin Burgmeier <armin@openismus.com>
1153 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1154 for supported secure authentication methods from server by
1155 gtk_dialog_run(), saving CPU time and a potential race condition.
1157 2007-06-26 Armin Burgmeier <armin@openismus.com>
1159 * src/maemo/modest-maemo-utils.h:
1160 * src/maemo/modest-maemo-utils.c: Added a
1161 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1162 only error code to tell the calling code when the user canceled the
1165 * src/maemo/modest-account-settings-dialog.h:
1166 * src/maemo/modest-account-settings-dialog.c:
1167 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1168 message if the retrieval of secure authentication methods was canceled
1169 by the user. Perform the check before saving anything to configuration
1170 to not end up with half-committed configuration changes, do not show
1171 a "Saving to configuration failed" note when authentication methods
1172 could not be retrieved.
1174 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1177 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1179 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1180 Only return the first level of folders under accounts, because the
1181 osso-global-search UI spec doesn't want the rest.
1182 This fixed projects.maemo.org bug NB#61811.
1184 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1186 * src/modest-tny-account-store.c:
1187 * src/modest-tny-account-store.h:
1188 Added modest_tny_account_is_memory_card_account().
1189 * src/maemo/modest-main-window.c: (create_details_widget):
1190 Show the same information items for the memory card as we show for the
1191 local-folders, to fix projects.maemo.org bug NB#59307.
1193 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1195 * src/modest-tny-account-store.c: (get_password):
1196 Added some checks for NULL to maybe prevent crashes, though I think
1197 it was Philip's last commit that actually prevented the crash here
1198 when creating a first new account.
1199 But the new account is still not usable (no messages are shown)
1200 until a restart of the application.
1202 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1204 * src/maemo/modest-maemo-global-settings-dialog.c:
1205 (idle_select_default_focus):
1206 * src/modest-mail-operation.c: (idle_notify_progress),
1207 (idle_notify_progress_once), (idle_notify_update_account_queue),
1208 (set_last_updated_idle), (update_account_thread),
1209 (notify_get_msgs_full), (get_msgs_full_destroyer),
1210 (get_msgs_full_thread):
1211 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1212 * src/widgets/modest-header-view.c:
1213 (idle_notify_headers_count_changed_destroy),
1214 (idle_notify_headers_count_changed):
1215 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1216 all idle handlers, because some other thread could be blocking
1217 the GDK lock, so that it can do GUI stuff.
1219 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1221 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1222 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1223 (on_idle_send_receive), (on_idle_open_default_inbox):
1224 * src/maemo/modest-msg-edit-window.c:
1225 (modest_msg_edit_window_attach_file_noninteractive):
1226 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1227 to prevent a hang. I don't quite understand why these are necessary,
1228 beause we should already be in the main loop. I guess something outside
1229 of the main loop is taking the lock.
1231 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1232 we are really using URIs, and use files that are more likely to exist.
1234 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1236 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1237 necessary because configure.ac now defines different variables.
1239 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1241 * libmodest-dbus-client/libmodest-dbus-client.c:
1242 * libmodest-dbus-client/libmodest-dbus-client.h:
1243 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1244 libmodest_dbus_client_compose_mail() is what things actually use.
1246 * src/dbus_api/modest-dbus-api.h:
1247 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1248 * tests/dbus_api/Makefile.am:
1249 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1252 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1254 * src/modest-init.c: (modest_init_local_folders):
1255 For memory-card (or other non local-folders) maildir accounts,
1256 always create an Archive folder, so that there is somewhere to put
1257 messages. This should be less confusing, because the user does not need
1258 to guess that the need to create a folder.
1260 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1262 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1263 Fixed icon size by using (50, 50) which is the same as defined by
1266 2007-06-25 Armin Burgmeier <armin@openismus.com>
1268 * src/widgets/modest-window-mgr.c:
1269 * src/modest-init.c:
1270 * configure.ac: Correctly recognize hildon-notify presence and fixed
1271 the build without it being installed.
1273 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1275 * libmodest-dbus-client/libmodest-dbus-client.c:
1276 (libmodest_dbus_client_search): Fix the build. Sorry.
1277 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1278 (reply_forward_cb): Initialize variables to fix the build.
1280 * src/modest-tny-account-store.c:
1281 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1282 comparison (a silly typo) so that email search results can be opened
1283 when there are more than one account.
1285 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1287 * libmodest-dbus-client/libmodest-dbus-client.c:
1288 (libmodest_dbus_client_search),
1289 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1290 instead of 1 second, because the search gets folders and messages from
1291 the server, which can take a long time. When it times out,
1292 osso-global-search will report no results.
1294 We need to specify whether we should search only cached information
1295 (maybe with a user preference), and the osso-email-search-plugin
1296 API should really be improved to allow that option, and to allow results
1297 to be delivered asynchronously in batches.
1299 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1301 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1302 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1303 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1305 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1307 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1308 that is an empty string. D-Bus seems to give us these instead of NULL.
1310 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1312 * src/dbus_api/modest-dbus-callbacks.c:
1313 * src/maemo/easysetup/modest-easysetup-wizard.h:
1314 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1315 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1316 (modest_connection_specific_smtp_edit_window_init):
1317 * src/maemo/modest-maemo-global-settings-dialog.c:
1319 * src/maemo/modest-maemo-utils.c:
1320 (modest_maemo_utils_setup_images_filechooser):
1321 * src/maemo/modest-main-window.c: (create_details_widget):
1322 * src/maemo/modest-msg-edit-window.c:
1323 (modest_msg_edit_window_attach_file_noninteractive),
1324 (modest_msg_edit_window_color_button_change),
1325 (modest_msg_edit_window_set_zoom):
1326 * src/modest-mail-operation.c: (update_account_thread):
1327 * src/modest-tny-account-store.c:
1328 * src/modest-tny-account.c:
1329 * src/widgets/modest-global-settings-dialog.c:
1330 * src/widgets/modest-window.h:
1332 Fixed build on bora!
1334 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1336 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1337 * src/modest-search.c: (modest_search_folder),
1338 (modest_search_all_accounts): Actually search only in the specified folder,
1339 doing a simple match on the folder ID.
1340 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1341 and added some documentation.
1343 2007-06-22 Armin Burgmeier <armin@openismus.com>
1345 * src/maemo/modest-maemo-utils.h:
1346 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1347 modest_maemo_utils_get_supported_secure_authentication_methods.
1349 * src/maemo/easysetup/modest-easysetup-wizard.c:
1350 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1351 one occured, not just "Server does not support secure authentication".
1353 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1355 * src/modest-tny-account-store.c: (get_password):
1356 Restored the call to tny_account_set_user() because Philip seems to have
1357 stopped this from crashing (by not using the freed string). It still does
1358 not work, but now we can test it.
1360 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1362 * src/maemo/modest-msg-edit-window.c: (init_window):
1363 Comment out use of an uninitialzed GtkScrolledWindow variable,
1364 to fix the build and stop a crash. Yet again.
1366 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1368 * src/modest-tny-account-store.c: (get_password):
1369 Remove the call to tny_account_set_user() because this actually crashes.
1370 As mentioned in the last commit, it is known to not work anyway.
1372 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1374 * src/modest-tny-account-store.c: (get_password):
1375 Use tny_account_set_username() to tell tinymail that the username might
1376 have changed too. But tinymail ignores this: see projects.maemo.org
1378 * src/modest-ui-actions.c:
1379 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1380 reset the connection when changing the username, and improve the comments.
1381 Save the changed username to gconf at least, so it is used when Modest is
1384 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1386 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1387 Do not use a query, so that we get all folders, including for POP and
1388 local-folders. They work as search criteria too.
1389 This fixes projects.maemo.org bug NB#57740.
1391 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1393 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1394 Comment out the use of hildon_notification_set_sound() because it is
1395 not declared, to fix the build. Warnings are serious, people.
1397 2007-06-21 Armin Burgmeier <armin@openismus.com>
1399 * src/maemo/modest-maemo-utils.h:
1400 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1401 modest_maemo_utils_get_supported_secure_authentication_methods()
1402 to query authentication methods for a specific user. This should fix
1403 projects.maemo.org bug NB#61369.
1405 * src/maemo/easysetup/modest-easysetup-wizard.c:
1406 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1409 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1411 * libmodest-dbus-client/libmodest-dbus-client.h:
1412 * libmodest-dbus-client/libmodest-dbus-client.c:
1413 (modest_dbus_message_iter_get_search_hit),
1414 (libmodest_dbus_client_search):
1415 Reorganised and commented this.
1416 Removed modest_search_hit_free() from the public API because it
1419 Added libmodest_dbus_client_get_folders() and
1420 modest_folder_result_list_free().
1422 * src/dbus_api/modest-dbus-api.h:
1423 * src/dbus_api/modest-dbus-callbacks.c:
1424 (modest_dbus_req_filter): Commented. Moved most code to
1425 on_dbus_method_search() and added on_dbus_method_get_folders().
1427 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1428 of the extra D-Bus handler.
1430 * tests/dbus_api/Makefile.am:
1431 * tests/dbus_api/test_get_folders.c: New test for
1432 libmodest_dbus_client_get_folders(). This seems to return an empty list
1433 at the moment. That could be the same error that causes the message list
1434 to be empty sometimes.
1435 This should help with projects.maemo.org bug NB#57740.
1437 2007-06-21 Armin Burgmeier <armin@openismus.com>
1439 * src/modest-mail-operation.c: Do not call
1440 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1441 notify the operation's end after having set the status to CANCELED for
1442 the operation queue to listen on. This fixes a deadlock when there
1443 were mail operations in the queue during its finalization.
1445 * src/modest-singletons.c: Reordered uninitialization of the account
1446 manager to happen after the mail operation queue was uninitialized
1447 because the mail operation's in the queue might still try to access
1448 the account manager (see modest_mail_operation_notify_end()). This
1449 fixes a potential crash when terminating the application.
1451 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1453 * src/modest-search.c:
1454 (search_mime_part_and_child_parts): Moved some code here so we
1455 can search recursively in child folders.
1456 (modest_search_folder): Search in the message as a mime part, instead
1457 of just its child mime parts.
1458 (read_chunk), (search_mime_part_ogs):
1459 Check how many bytes were read, to prevent an endless loop.
1460 Searching in message bodies now works. This finishes the fix for
1461 projects.maemo.org bug NB#61007.
1463 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1465 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1466 Add a g_warning when the item is not a folder.
1468 * src/modest-ui-dimming-rules.c:
1469 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1470 when selected item is not a folder (for instance, an account), because
1471 the UI spec only talks about folders.
1472 I am not sure what the UI spec wants, so this might not totally fix
1473 projects.maemo.org bug NB#60794.
1475 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1477 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1478 (load_from_file): Sort the list. The unsorted list would be more noticeable
1479 in non-English locales.
1481 * src/maemo/modest-msg-edit-window.c:
1482 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1483 warning and fix the build.
1485 * src/maemo/modest-progress-bar-widget.c:
1486 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1487 avoid a g_warning, and probably to avoid a crash.
1489 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1491 * src/modest-search.c: (modest_search_folder): Check for a GError
1492 when calling tny_folder_get_headers(), to show that this is not the cause
1495 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1497 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1498 Actually set the body query instead of the subject query.
1500 * src/modest-search.c: (search_mime_part_ogs),
1501 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1502 which would probably cause it to fail if we got this far.
1504 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1505 to simplify the code.
1506 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1507 be causing search-in-body to fail.
1509 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1511 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1513 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1514 Better debug message when the folder cannot be found.
1515 This should help with fixing projects.maemo.org bug #61287.
1516 * src/modest-search.c: (add_hit): Do not leak the furl string.
1518 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1520 * src/modest-ui-actions.c:
1521 (modest_ui_actions_on_folder_selection_changed):
1522 Do not special-case TNY_MERGE_FOLDER here, because
1523 modest_tny_folder_get_account() already does that. This fixes
1524 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1525 shown when the Outbox was selected).
1527 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1529 * libmodest-dbus-client/libmodest-dbus-client.c:
1530 (_dbus_iter_get_string_or_null): Initialize the string variable in
1531 case this helps with Dirk's crash.
1533 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1535 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1536 though it is not implemented yet (this function is maybe not even used),
1537 to avoid breaking ABI in future.
1538 * libmodest-dbus-client/libmodest-dbus-client.c:
1539 (get_attachments_string): Moved some code into this generic function.
1540 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1541 sends email. It is maybe not used.
1542 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1543 (on_send_mail): Use attachments.
1545 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1546 * src/maemo/modest-msg-edit-window.c:
1547 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1548 a filename before using it, to fix projects.maemo.org bug NB#58233.
1550 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1552 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1553 Initialize the continue_download variable to fix the build, and probably
1554 to fix randome behaviour.
1556 2007-06-18 Armin Burgmeier <armin@openismus.com>
1558 * src/modest-tny-send-queue.h:
1559 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1560 the queue so we can later show it in the UI. Replaced
1561 modest_tny_send_queue_msg_is_being_sent() by
1562 modest_tny_send_queue_get_msg_status().
1564 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1566 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1567 gpointer. This probably was not harmful, but just to be sure.
1569 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1571 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1572 Fix the build, but leave the function broken on Bora, because
1573 hildon_uri_action_get_service() does not exist.
1574 osso_uri_action_get_service() does not exist either, it seems.
1576 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1578 * src/modest-tny-account.c:
1579 (modest_tny_account_new_from_server_account):
1580 Uncommented the url debug output again, because it is useful for
1581 debugging, as I said in the comment.
1583 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1585 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1587 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1588 for Mameo Bora, to fix the build.
1590 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1593 Fixed build with hildon < 0.99
1595 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1596 Check if the selected account is busy instead of checking all accounts
1598 * src/modest-account-mgr-priv.h:
1599 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1600 (modest_account_mgr_init), (compare_account_name),
1601 (modest_account_mgr_set_account_busy),
1602 (modest_account_mgr_account_is_busy):
1603 * src/modest-account-mgr.h:
1604 Added busy information to the account manager. It possible to
1605 set an account to busy or not busy now.
1607 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1608 (modest_mail_operation_update_account),
1609 (modest_mail_operation_notify_end):
1610 Set the account to busy/not busy depending on the operation state.
1612 * src/widgets/modest-account-view.c:
1613 (modest_account_view_finalize), (get_last_updated_string),
1614 (update_account_view), (on_account_busy_changed), (init_view):
1615 Show string "Refreshing..." if the account is currently busy.
1617 All this fixes projects.maemo.org bug NB#59711
1619 2007-06-14 Armin Burgmeier <armin@openismus.com>
1621 * src/widgets/modest-attachments-view.h:
1622 * src/widgets/modest-attachments-view.c: Added
1623 modest_attachments_view_has_attachments() and fixed coordinate
1624 transformation in get_att_view_at_coords(). This fixes attachment
1627 * src/widgets/modest-msg-view.c: Make use of
1628 modest_attachments_view_has_attachments() to decide whether to show
1629 attachments in the header.
1631 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1633 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1634 (on_change), (on_combo_security_changed),
1635 (modest_connection_specific_smtp_edit_window_init),
1636 (modest_connection_specific_smtp_edit_window_set_connection),
1637 (modest_connection_specific_smtp_edit_window_is_dirty):
1638 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1639 * src/maemo/modest-connection-specific-smtp-window.c:
1642 Show an comfirmation dialog for the smpt-edit-window if there are
1643 unsaved changes and the user hits cancel.
1644 (projects.maemo.org bug NB#60479)
1646 2007-06-14 Armin Burgmeier <armin@openismus.com>
1648 * src/maemo/easysetup/modest-easysetup-wizard.c:
1649 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1650 address" info in banner instead of node, and select all the text as
1651 per UI spec. This fixes projects.maemo.org bug NB#60550.
1653 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1655 reviewed by: <delete if not using a buddy>
1657 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1658 * src/modest-ui-actions.c: (folder_refreshed_cb):
1660 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1662 * src/widgets/modest-folder-view.c: (filter_row):
1663 Explictly filter out the per-account outbox accounts. I don't know why
1664 these only sometimes show up, but now they should never show up in the UI.
1665 This should fix projects.maemo.org bug NB#60160.
1667 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1669 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1670 when the toolbar does not exist yet.
1671 * src/modest-widget-memory.c: (save_settings_header_view):
1672 Added g_warnings() to help us to discover when we are trying to set
1673 an empty columns list in gconf.
1675 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1677 * src/modest-init.h:
1678 * src/modest-init.c:
1679 Added modest_init_get_default_header_view_column_ids().
1681 * src/modest-widget-memory.c: (restore_settings_header_view):
1682 Use the new function to get defaults, if the gconf key is empty,
1683 instead of not creating any columns. This seems to fix the
1684 empty right-hand pane problems.
1686 * src/widgets/modest-header-view.h: Improved documentation.
1688 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1690 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1691 Revert the use of the display name as the account name, because this
1692 is generally wrong and would break the code that follows.
1694 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1696 * src/maemo/easysetup/modest-easysetup-wizard.c:
1697 (check_for_supported_auth_methods), (on_before_next),
1700 More correct fix for projects.maemo.org bug NB# 58991
1701 Do not longer accept AUTH_PASSWORD as secure method and choose
1702 correct method when creating the account.
1704 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1706 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1707 Fixed projects.maemo.org bug NB# 58991
1709 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1711 * src/modest-init.c: (modest_init_init_core),
1712 (modest_init_local_folders): Fixed compilation errors.
1714 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1716 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1717 Remove unnecessary lib/include, though it is good in principle when needed.
1719 * src/modest-init.c: (modest_init_one_local_folder),
1720 (modest_init_local_folders):
1721 * src/modest-init.h: Initialize the .modest library for memory cards,
1722 instead of just doing nothing for them. This should allow us to create
1723 folders there, fixing projects.maemo.org bug NB#59297.
1725 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1727 * libmodest-dbus-client/libmodest-dbus-client.c:
1728 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1729 (libmodest_dbus_client_compose_mail),
1730 (libmodest_dbus_client_open_message),
1731 (libmodest_dbus_client_send_and_receive),
1732 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1734 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1735 (on_idle_open_message), (modest_dbus_req_handler),
1736 (search_result_to_message), (modest_dbus_req_filter):
1737 * src/modest-search.c: (add_hit), (modest_search_folder),
1738 (modest_search_all_accounts): Improved debug messages.
1740 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1742 * src/modest-tny-account-store.c:
1743 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1746 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1749 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1751 * src/modest-tny-account-store.c: (get_server_accounts):
1752 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1753 even when there are no accounts, so that the Outbox folder is always
1754 visible. This fixes projects.maemo.org bug NB#60158.
1756 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1758 * src/maemo/modest-main-window.c: (create_details_widget):
1759 Use the mcen_va_never logical ID.
1761 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1763 * src/dbus_api/modest-dbus-api.h:
1764 * src/dbus_api/modest-dbus-callbacks.c:
1765 (on_idle_open_default_inbox), (on_open_default_inbox),
1766 (modest_dbus_req_handler):
1767 Added a new OpenDefaultInbox method.
1769 * libmodest-dbus-client/libmodest-dbus-client.h:
1770 * libmodest-dbus-client/libmodest-dbus-client.c:
1771 Added libmodest_dbus_client_open_default_inbox() to call the new
1772 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1773 though it should maybe be used by a new osso-email-interface function.
1775 * tests/dbus_api/Makefile.am:
1776 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1779 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1781 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1782 NULL, so that the signals get all the keys. This should not actually
1783 change any behaviour because we currently update everything when anything
1786 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1788 * src/widgets/modest-folder-view.c: (text_cell_data),
1789 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1790 (find_inbox_iter): If tinymail tells us that the folder is
1791 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1792 This causes the inbox to be selected at startup, fixing part of
1793 projects.maemo.org bug NB#56305.
1795 * src/modest-ui-dimming-rules.c:
1796 (modest_ui_dimming_rules_on_tools_smtp_servers):
1797 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1798 the SMTP servers menu item.
1799 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1800 that the SMTP Servers menu item is dimmed when there are no accounts,
1801 as a future version of the UI spec will require. This fixes
1802 projects.maemo.org bug NB#56305.
1804 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1806 * src/maemo/modest-maemo-utils.c:
1807 (modest_maemo_utils_get_supported_secure_authentication_methods):
1808 Added label to dialog instead of unreadable title
1810 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1811 (modest_main_window_new):
1812 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1815 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1816 * src/modest-account-mgr.h:
1817 Added method to avoid code duplication
1819 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1820 (modest_ui_actions_on_send_receive):
1821 Use modest_account_mgr_has_accounts
1823 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1825 * src/maemo/easysetup/modest-presets.c:
1826 (modest_presets_get_info_server_security): Do not report secure auth
1828 * src/modest-protocol-info.c: Use the defines for the gconf key names
1829 for secure authentication. This was not working because we were writing
1830 Password and reading password, and the check was case sensitive.
1831 With this, gmail now works for receiving and sending when created via
1834 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1836 * src/maemo/easysetup/modest-presets.c:
1837 (modest_presets_get_info_server_security): Correct the key name for
1838 SecureSmtp, because it seems to be case-sensitive.
1839 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1840 Do not try to get the 0th notebook page if there are 0 pages, to
1841 avoid a g_warning().
1843 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1845 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1846 Prevent use of the new notification feature for now, because it currently
1847 shows one dialog for each new email, which is annoying.
1849 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1851 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1852 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1853 when no country was selected, so that we show the global ones.
1854 * src/maemo/easysetup/modest-presets.c:
1855 (modest_presets_get_providers): Return only the global providers, not
1856 all providers when mmc=0 was requested.
1858 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1860 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1861 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1862 provider ID in the combo.
1864 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1865 Do not show the page numbers, because it would be confusing when we add
1866 the 2 extra pages for the custom setup, when the user chooses the "Other"
1867 provider. This fixes projects.maemo.org bug NB#59028
1869 * src/modest-init.c: (modest_init_init_core),
1870 (modest_init_local_folders):
1871 * src/modest-init.h:
1872 * src/modest-tny-account.c:
1873 (modest_tny_account_new_for_local_folders): Do not create default folders
1874 for the memory card. This should fix projects.maemo.org bug NB#59328.
1876 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1878 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1879 Free the changed_conf_keys string items. They are already freed in the
1880 idle handler if that runs first.
1882 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1884 * src/modest-ui-actions.c:
1885 (modest_ui_actions_on_password_requested): Check that the server name
1886 is not NULL, because I just saw a password dialog with (null) as the
1889 * src/modest-tny-folder.[h|c]: Added
1890 modest_tny_folder_is_memory_card_folder().
1891 * src/modest-ui-dimming-rules.c:
1892 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1893 menu item for memory cards, as per the UI spec (section 7.4). This should
1894 fix projects.maemo.org bug NB#59297.
1896 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1898 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1899 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1900 is another problem with the code, see Murray's comment at line 772)
1902 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1904 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1905 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1906 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1907 (load_from_file), (easysetup_country_combo_box_init),
1908 (easysetup_country_combo_box_get_active_country_ids),
1909 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1910 instead of just one ID, to avoid duplicate country names in the UI.
1912 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1913 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1914 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1915 a single ID, avoiding duplicate providers.
1916 * src/maemo/easysetup/modest-easysetup-wizard.c:
1917 (on_combo_account_country): Adapt to use a list.
1919 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1921 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1922 keys changed in the last X seconds.
1924 * src/modest-account-mgr.h:
1925 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1926 (on_key_change), (modest_account_mgr_class_init),
1927 (modest_account_mgr_init), (modest_account_mgr_finalize):
1928 As the keys are changed, save them in a GSList* and signal that GSList*
1929 further every X seconds, to batch changes, to allow us to do just one
1930 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1931 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1933 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1934 changed signal signature.
1936 * src/modest-conf.c: (modest_conf_set_list),
1937 (modest_conf_on_change): Reenable notification.
1939 (modest_conf_maemo_fake_on_change): Comment out the hack that
1940 notified immediately instead of asynchronously.
1942 * src/widgets/modest-account-view.h:
1943 * src/widgets/modest-account-view.c:
1944 (update_account_view): Select the previously-selected account ID,
1945 if possible. This fixes projects.maemo.org bug NB#56933.
1947 (on_account_changed), (on_account_removed),
1948 (modest_account_view_select_account):
1950 Remove the block/unblock functions
1951 because they were not useful.
1953 * src/maemo/modest-account-view-window.c:
1954 (on_delete_button_clicked), (on_edit_button_clicked),
1955 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1957 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1959 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1960 Improve the error dialog to show Incorrect Account Settings, which seems
1961 clearer, and say that the internal error message (to be removed from the
1962 dialog later) is often misleading.
1963 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1965 * src/modest-tny-account.c:
1966 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1967 URL because this is so useful for debugging on the device.
1969 * src/widgets/modest-serversecurity-combo-box.c:
1970 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1972 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1974 * src/modest-mail-operation.c:
1975 (modest_mail_operation_send_new_mail):
1976 Added a comment about a nasty but apparently harmless message. Details
1977 added to the wiki g_warnings() page.
1979 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1981 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1982 (modest_tny_send_queue_class_init):
1983 Do not use the priv struct because it is empty, to avoid g_warnings
1984 about a non-existant priv struct.
1986 * src/modest-tny-account-store.c:
1987 (modest_tny_account_store_get_server_account),
1988 (modest_tny_account_store_get_transport_account_for_open_connection
1989 ): Do not try to get transport server accounts for local folders,
1990 because they don't have any. This avoids a g_warning().
1992 * src/maemo/modest-main-window.c:
1993 (modest_main_window_notify_send_receive_initied),
1994 (on_configuration_key_changed):
1995 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1996 * src/modest-defs.h:
1997 * src/modest-mail-operation.c:
1998 (modest_mail_operation_update_account):
1999 * src/modest-tny-account-store.h:
2000 * src/modest-tny-account.c:
2001 (modest_tny_account_get_special_folder),
2002 (modest_tny_account_new_for_local_folders),
2003 (modest_tny_account_new_for_per_account_local_outbox_folder):
2004 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2005 * src/modest-tny-local-folders-account.c:
2006 (add_account_folders_to_merged_folder):
2007 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2008 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2009 (modest_ui_actions_on_send):
2010 * src/widgets/modest-folder-view.c: (update_model):
2011 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2012 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2013 modest_tny_account_store_get_tny_account_by_account() to
2014 modest_tny_account_store_get_server_account() to make the code clearer.
2016 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2018 * src/dbus_api/modest-dbus-api.h:
2019 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2020 * src/maemo/modest-msg-edit-window.c:
2021 (modest_msg_edit_window_attach_file_noninteractive):
2022 added g_warning in case the file to be attached does not exist
2023 * tests/dbus_api/test_compose_mail.c: (main):
2024 removed obsolete comment, added generic files as test case
2026 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2028 * src/modest-tny-account-store.c: (get_server_accounts):
2029 Create the local folders account only once, not once for each outbox, and
2030 not only when there are some outboxes.
2032 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2034 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2035 code that is causing a crash at startup. Sergio says that he is fixing this.
2037 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2039 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2040 * src/maemo/modest-account-settings-dialog.c:
2041 (create_page_outgoing),
2042 (modest_account_settings_dialog_set_account_name),
2043 (save_configuration):
2044 - Fixed handling of the "Use secure authentication" toggle to comply with
2045 the ui specification. See also projects.maemo.org bug NB#58400
2047 - Restore the Secure connection setting combo correctly when loading
2050 * src/maemo/modest-maemo-utils.c:
2051 (on_camel_account_get_supported_secure_authentication),
2052 (modest_maemo_utils_get_supported_secure_authentication_methods):
2053 Fixed a crasher if operation is canceled
2055 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2056 (modest_protocol_info_auth_is_secure):
2057 * src/modest-protocol-info.h:
2059 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2060 the sense of the "Use secure authentication" toggle.
2062 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2064 * src/modest-tny-account-store.h:
2065 * src/modest-tny-account-store.c:
2066 Added modest_tny_account_store_get_local_folders_account().
2068 * src/modest-tny-folder.h:
2069 * src/modest-tny-folder.c:
2070 (modest_tny_folder_get_account):
2071 Added this replacement for tny_folder_get_account() which returns
2072 the local-folders account for TnyMergeFolders, to avoid the
2073 warning about the unimplemented get_account_func() vfunc().
2075 (modest_tny_folder_get_rules),
2076 * src/modest-ui-actions.c:
2077 (modest_ui_actions_on_folder_selection_changed):
2078 * src/modest-mail-operation.c:
2079 (modest_mail_operation_remove_folder),
2080 (modest_mail_operation_xfer_folder),
2081 (modest_mail_operation_rename_folder),
2082 (modest_mail_operation_get_msg),
2083 (modest_mail_operation_get_msgs_full),
2084 (modest_mail_operation_remove_msg),
2085 (modest_mail_operation_xfer_msgs),
2086 (modest_mail_operation_refresh_folder):
2087 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2089 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2091 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2092 (modest_server_account_set_security):
2093 * src/modest-defs.h: Add comments explaining that our
2094 UI spec means TLS when it says Normal, so these do not look like errors.
2096 * src/modest-tny-account.c:
2097 (modest_tny_account_new_from_server_account): Use the new tinymail
2098 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2099 for TLS. This should fix projects.maemo.org bug NB#58460.
2101 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2103 * src/maemo/easysetup/modest-easysetup-wizard.c:
2104 (create_account): Correct the position of the gconf sanity check warning.
2105 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2106 of using the g_idle_add() hack, because this does not seem to be necessary
2107 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2108 caused by something other than maemo's gconf.
2109 This fixes projects.maemo.org bug #59022.
2111 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2113 * src/modest-account-mgr-helpers.c:
2114 (modest_account_mgr_get_default_account): Do not check that the account
2115 exists if there is no default account (NULL), to fix a runtime warning.
2117 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2119 * src/widgets/modest-folder-view.c: (update_model):
2120 Do not unref the treemodel before we have finished with it.
2121 This prevents a valgrind warning and an occasional crash at startup.
2123 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2125 * libmodest-dbus-client/libmodest-dbus-client.h:
2126 added libmodest_dbus_client_compose_mail()
2127 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2129 added functions needed for SendAsMail() functionality
2130 * src/maemo/modest-msg-edit-window.c:
2131 (modest_msg_edit_window_attach_file_noninteractive):
2132 non interactively attaching files to message edit window
2133 * src/widgets/modest-msg-edit-window.h:
2134 * tests/dbus_api/Makefile.am:
2135 added test_compose_mail.c
2136 * tests/dbus_api/test_compose_mail.c: (main):
2138 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2140 * src/modest-account-view.c:
2141 Fixed bug projects.maemo.org bug NB#59307
2143 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2145 * src/maemo/easysetup/modest-easysetup-wizard.c:
2146 (get_serverport_incoming), (on_before_next), (create_account):
2147 * src/maemo/modest-account-settings-dialog.c:
2148 (modest_account_settings_dialog_set_account_name):
2149 * src/maemo/modest-maemo-utils.c:
2150 (on_camel_account_get_supported_secure_authentication_status),
2151 (on_camel_account_get_supported_secure_authentication),
2152 (on_secure_auth_cancel),
2153 (modest_maemo_utils_get_supported_secure_authentication_methods):
2155 Implemented security authentication for settings and easysetup.
2157 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2159 * src/maemo/modest-main-window.c: (create_details_widget):
2160 Show the total size for memory card accounts too, instead of showing
2161 the name again. Fixes bug projects.maemo.org bug NB#59307.
2163 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2166 * src/modest-tny-simple-folder-store.c:
2167 * src/modest-tny-simple-folder-store.h: Removed.
2169 * src/modest-tny-local-folders-account.h
2170 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2171 for the local-folders maildir, with an extra TnyMergedFolder containing
2172 the folders of the per-account outbox store accounts.
2173 * src/modest-tny-account-store.c: (get_server_accounts):
2174 Add the outboxes to the special local folders account after creating it.
2176 * src/modest-tny-account.c:
2177 (modest_tny_account_new_for_local_folders): Create the derived
2178 account when creating the main local-folders account.
2180 * src/maemo/modest-main-window.c: (create_details_widget),
2181 (modest_main_window_set_contents_style):
2182 Adapted to the use of the derived account instead of the folder store.
2184 * src/modest-ui-actions.c:
2185 (modest_ui_actions_on_folder_selection_changed):
2186 * src/modest-ui-dimming-rules.c:
2187 (modest_ui_dimming_rules_on_new_folder):
2188 * src/widgets/modest-folder-view.c: (text_cell_data),
2189 (icon_cell_data), (filter_row), (update_model),
2190 (get_cmp_rows_type_pos):
2193 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2194 Do not get the priv struct, because no priv struct has been set,
2195 to avoid a runtime warning.
2197 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2198 #ifelse with #else, to fix a warning, to fix the build.
2201 2007-06-05 Christian Kellner <ckellner@openismus.com>
2203 * libmodest-dbus-client/libmodest-dbus-client.c:
2204 Fix small typo in doc (why do you always see them
2205 AFTER committing stuff?)
2208 2007-06-05 Christian Kellner <ckellner@openismus.com>
2210 * libmodest-dbus-client/libmodest-dbus-client.c:
2211 (libmodest_dbus_client_search):
2212 Initialize hit list with NULL. Also set folder list
2213 to "" if NULL was supplied.
2216 2007-06-03 Christian Kellner <ckellner@openismus.com>
2218 * libmodest-dbus-client/libmodest-dbus-client.c:
2219 (modest_search_hit_list_free):
2220 Make it save to call it with NULL.
2222 * src/dbus_api/modest-dbus-callbacks.c:
2223 * src/modest-search.c:
2224 Return full ModestSearchHits as the search result list not TnyHeader
2225 since can't be around withouth the correspoding TnyFolder.
2227 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2229 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2230 Added currently commented code to check for secure auth
2232 * src/maemo/modest-account-settings-dialog.c: (on_response),
2233 (save_configuration), (show_ok):
2234 Fixed projects.maemo.org bugs NB #59248 and #59251
2236 * src/maemo/modest-maemo-utils.c:
2237 (on_camel_account_get_supported_secure_authentication_status),
2238 (on_camel_account_get_supported_secure_authentication),
2239 (modest_maemo_utils_get_supported_secure_authentication_methods):
2240 * src/maemo/modest-maemo-utils.h:
2241 Moved get_supported_secure_authentication() method here to be able
2242 to use it from easysetup wizard.
2244 * src/modest-pair.c: (on_pair_compare_as_string):
2245 Should compare string with first part of pair and not
2246 strcmp pairs which will crash.
2248 * src/modest-protocol-info.c:
2249 (modest_protocol_info_protocol_is_store):
2250 * src/modest-protocol-info.h:
2251 Added modest_protocol_info_get_auth_protocol_name()
2253 2007-06-03 Armin Burgmeier <armin@openismus.com>
2255 * src/modest-mail-operation.c:
2256 (modest_mail_operation_get_msgs_full): Set priv->account also when
2257 only retrieving a single message. This avoids a crash when canceling
2260 (modest_mail_operation_notify_end): Do not explicitely remove the
2261 operation from the queue but only emit the progress_changed signal.
2262 The queue itself listens to that signal to remove the operation when
2263 it is finished. This reduces coupling and removes a potential deadlock
2264 when modest_mail_operation_notify_end() is called from the queue
2265 itself. If that is a problem performance-wise, I would suggest to
2266 implement a status-changed signal or something.
2268 * src/modest-mail-operation-queue.c: Make sure to never call a
2269 function from another file while the queue is locked. This (hopefully)
2270 fixes another deadlock when exiting the application while retrieving
2273 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2275 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2276 Fixed build if libogs is not available
2278 2007-06-03 Christian Kellner <ckellner@openismus.com>
2280 * libmodest-dbus-client/libmodest-dbus-client.h:
2281 * libmodest-dbus-client/libmodest-dbus-client.c:
2282 (libmodest_dbus_client_delete_message):
2283 Implement deletion of messages (Client side).
2285 (modest_search_hit_free),
2286 (modest_search_hit_list_free):
2287 Utility functions to free the result hits.
2289 * src/dbus_api/modest-dbus-api.h:
2290 * src/dbus_api/modest-dbus-callbacks.c:
2291 (on_delete_message),
2292 (modest_dbus_req_handler):
2293 Implement deletion of messages (Server side).
2295 * tests/dbus_api/test_search.c: (main):
2298 * tests/dbus_api/Makefile.am:
2299 * tests/dbus_api/test_delete_message:
2300 Add little test for the message deletion logic
2302 2007-06-03 Armin Burgmeier <armin@openismus.com>
2304 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2305 when the operation queue was not empty. projects.maemo.org bug
2308 2007-06-03 Armin Burgmeier <armin@openismus.com>
2310 * src/widgets/modest-account-view.c
2311 (on_account_default_toggled): Toggle default account column
2312 explicitely instead of waiting for gconf notification (which is
2313 currently ignored). This should fix projects.maemo.org bug NB#56910
2314 for now. It should probably be removed when gconf notifications are
2317 2007-06-03 Christian Kellner <ckellner@openismus.com>
2319 * libmodest-dbus-client/libmodest-dbus-client.c:
2320 Removed debugging spew.
2322 * src/dbus_api/modest-dbus-callbacks.c:
2323 Added debugging info.
2325 * src/modest-search.c:
2326 (modest_search_all_accounts):
2327 Use tny_account_store_get_accounts () on the account store
2328 to get all accounts which is the way to get all accounts.
2330 * tests/dbus_api/test_search.c: (main):
2331 Make it possible to supply the search term on the command line.
2333 2007-06-03 Christian Kellner <ckellner@openismus.com>
2335 * libmodest-dbus-client/libmodest-dbus-client.c:
2336 * libmodest-dbus-client/libmodest-dbus-client.h:
2337 Implement searching for mesages over raw dbus. (Client side)
2339 * src/dbus_api/Makefile.am:
2340 * src/dbus_api/modest-dbus-api.h:
2341 * src/dbus_api/modest-dbus-callbacks.c:
2342 * src/dbus_api/modest-dbus-callbacks.h:
2343 Search framework (Server side). Also implement on_idle_open_message().
2345 * src/maemo/modest-platform.c: (modest_platform_init):
2346 Prepare for raw dbus/osso rpc interaction.
2348 * src/modest-search.h:
2349 Changed minsize from unspecific guint to guint32.
2351 * src/modest-search.c:
2353 Added strange hack which magically made tnymail work.
2355 (modest_search_folder),
2356 (modest_search_account),
2357 (modest_search_all_accounts):
2358 Implement helper functions to search all accounts, specific account
2361 * tests/dbus_api/Makefile.am:
2362 * tests/dbus_api/test_open_message.c:
2363 Read url to open from commandline.
2365 * tests/dbus_api/test_search.c:
2366 Implement small test for dbus search stuff
2368 2007-06-02 Armin Burgmeier <armin@openismus.com>
2370 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2371 include account type and account title. This fixes projects.maemo.org
2374 * src/maemo/modest-account-view-window.c: Set a title for the window.
2376 2007-06-02 Armin Burgmeier <armin@openismus.com>
2378 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2379 incoming and outgoing server name based on email address and server
2380 types as long as the names have not been edited manually. This fixes
2381 projects.maemo.org bug NB#58671.
2383 2007-06-02 Armin Burgmeier <armin@openismus.com>
2385 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2386 server type cannot be changed in future to the incoming details page
2387 when creating an account. This fixes projects.maemo.org bug NB#59029.
2389 2007-06-02 Armin Burgmeier <armin@openismus.com>
2391 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2392 and assigned max width chars so that they wrap instead of being
2393 truncated. Fixes projects.maemo.org bug NB#56126.
2395 2007-06-02 Armin Burgmeier <armin@openismus.com>
2397 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2398 introductory note to the connection specific smtp servers dialog, as
2399 section 8.12 of the email UI specification requires. This fixes
2400 projects.maemo.org bug NB#59212.
2402 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2404 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2405 Check for running mail operations, and offer to cancel them, as per the UI
2406 spec. This fixes projects.maemo.org bug NB#59041 .
2407 However, I suspect that tinymail may still use the network connection
2408 in ways that we cannot detect or cancel. But it should at least adapt to
2409 changes fairly well.
2411 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2413 * src/modest-tny-account-store.c: (recreate_all_accounts),
2414 (get_cached_accounts), (get_server_accounts): Do more sensible
2415 ref-counting of the temporarily-cached outbox accounts list. This seems
2416 to fix a crash when entering the password when the password was wrong.
2418 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2420 * src/gnome/modest-main-window.c: (connect_signals):
2421 * src/modest-tny-account-store.c: (get_password),
2422 (modest_tny_account_store_alert): Added comments and clues and
2423 commented-out code about how we currently fail to deal with connection
2424 errors and wrong passwords, and how we should.
2426 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2428 * src/widgets/modest-retrieve-combo-box.c:
2429 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2430 This fixes projects.maemo.org bug NB#58472 .
2432 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2434 * src/maemo/easysetup/modest-easysetup-wizard.c:
2435 (create_page_complete_easysetup):
2436 (create_page_complete_custom): Correct the last commit,
2437 putting the correct sentences in the correct pages.
2439 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2441 * src/maemo/easysetup/modest-easysetup-wizard.c:
2442 (create_page_complete_custom): Show the second sentence of text
2443 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2446 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2448 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2449 Set the leave-on-server conf key by default. This fixes
2450 projects.maemo.org bug NB#59258 .
2452 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2454 * src/maemo/modest-account-view-window.c:
2455 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2456 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2459 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2461 * src/maemo/easysetup/modest-easysetup-wizard.c:
2462 (create_caption_new_with_asterisk):
2463 * src/maemo/modest-account-settings-dialog.c:
2464 (create_caption_new_with_asterisk):
2465 Uncomment the code to add the asterisk, because they are no longer in the
2466 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2467 (update_incoming_server_title): Add an asterisk here too.
2469 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2471 * src/maemo/modest-maemo-global-settings-dialog.c:
2472 (current_connection): Check that we are even connected before trying to
2473 get the current connection name, to prevent a warning.
2475 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2476 Change the comments because tny_maemo_conic_device_connect() is now meant to
2478 * src/modest-mail-operation.c:
2479 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2480 make sure we have a connection and fail if we can't connect.
2482 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2484 * src/maemo/modest-main-window.c:
2485 (on_account_store_connecting_finished): Do not try to get the
2486 connection ID if we are not really connected. I am surprised that
2487 this signal handler is called when we are not connected.
2489 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2491 * src/modest-error.h:
2492 * src/modest-ui-actions.c:
2493 (modest_ui_actions_get_msgs_full_error_handler):
2494 Renamed an enum, added comments, added an enum
2495 for retrieve-limit errors.
2497 * src/modest-mail-operation.c: (foreach_add_item),
2498 (internal_folder_observer_update), (update_account_thread),
2499 (modest_mail_operation_get_msgs_full):
2500 (modest_mail_operation_update_account),
2501 Added comments about how this works, and some code that should
2502 (but does not) check the retrieve-limit. See the TODO comment.
2504 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2506 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2507 Initialize help_id to fix the build. Warnings are good.
2509 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2511 * src/widgets/modest-hbox-cell-renderer.c:
2512 (modest_hbox_cell_renderer_append):
2513 * src/widgets/modest-vbox-cell-renderer.c:
2514 (modest_vbox_cell_renderer_append):
2515 Fix the last commit by doing an extra ref.
2517 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2519 * src/widgets/modest-hbox-cell-renderer.c:
2520 (modest_hbox_cell_renderer_append):
2521 * src/widgets/modest-vbox-cell-renderer.c:
2522 (modest_vbox_cell_renderer_append):
2523 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2524 to fix the build with Maemo Bora.
2525 However, there seems to be a remaining crash, probably due to reference
2528 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2530 * src/modest-tny-account.c:
2531 (modest_tny_account_new_for_local_folders):
2532 Use hildon_file_system_info_async_new() to get a better name for
2533 the memory card account, setting it as the account name.
2534 The timing seems to work, but this is probably
2535 not the best place to do this. See the TODO comment.
2536 * src/maemo/modest-main-window.c: (create_details_widget):
2537 * src/widgets/modest-folder-view.c: (text_cell_data):
2538 Use the tny account name instead of hardcoding a name.
2540 2007-05-30 Christian Kellner <ckellner@openismus.com>
2542 * src/modest-search.c: (modest_search):
2543 Correctly set part_search_func even if we have already parsed
2544 the query and thus a valid OgsTextSearcher object.
2546 2007-05-30 Christian Kellner <ckellner@openismus.com>
2549 Search and check for libogs.
2552 Incooparte the ogs build env.
2554 * src/modest-mime-part-search-stream.c:
2555 * src/modest-mime-part-search-stream.h:
2556 Removed since we do the real searching now in modest-search.c.
2558 * src/modest-search.c:
2559 * src/modest-search.h:
2560 Implement support for ogs. We use that if available and requested
2561 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2562 should now handle the corner case when the search term is spread
2563 across multiple reads.
2564 Also the logic in modest_search () was corrected to search all
2565 requested fields until one is found.
2567 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2569 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2571 * src/modest-init.h:
2572 * src/modest-init.c: Made modest_init_local_folders() take a
2573 path and be public so we can iniitialize maildir folders on
2576 * src/modest-local-folder-info.h:
2577 * src/modest-local-folder-info.c:
2578 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2580 * src/modest-tny-account.c:
2581 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2582 still means the standard local-folders path on the local volume.
2584 * src/modest-tny-account-store.c:
2585 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2586 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2587 all accounts when that happens.
2588 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2589 this too, so it shows up in the treeview.
2591 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2593 * src/maemo/modest-maemo-global-settings-dialog.c:
2594 (current_connection):
2595 * src/widgets/modest-global-settings-dialog.c:
2596 (current_connection_default):
2597 Use the enum values instead of 0, 1 and -1,
2598 to make the code clearer.
2600 * src/modest-account-mgr-helpers.c:
2601 (modest_account_mgr_get_connection_specific_smtp): Make this code
2604 * src/modest-runtime.h:
2605 * src/modest-runtime.c:
2606 Added modest_runtime_remove_all_send_queues().
2607 * src/maemo/modest-main-window.c:
2608 (on_account_store_connecting_finished): Recreate the send queues,
2609 using the appropriate transport accounts for this new connection.
2610 Some futher adapting might be needed if the old send queues are not
2611 automatically stopped at this point.
2613 * src/modest-tny-account-store.c: (get_server_accounts):
2614 Create the connection-specific transport accounts, so that they can
2615 be found later by their ID.
2617 * src/modest-tny-account.h:
2618 * src/modest-tny-account.c:
2619 Added modest_tny_account_new_from_server_account_name().
2620 modest_tny_account_new_from_server_account(): Do not create the
2621 send queues here, because they will be
2622 recreated anyway when the connection changes for the first time.
2624 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2626 * src/modest-local-folder-info.h:
2627 * src/modest-local-folder-info.c:
2628 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2629 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2630 tbox_folder): Take a modest account name instead of a server TnyAccount,
2631 so we can have per-modest-account rather than per-transport-account
2633 We must make sure that we change or recreate the exisitng send queues
2634 when the connection changes for connection-specific transport accounts.
2636 * src/modest-tny-account-store.c:
2637 (create_per_account_local_outbox_folders): Create outboxed per modest
2638 account, not per transport account.
2640 * src/modest-tny-account.h:
2641 * src/modest-tny-account.c:
2642 (modest_tny_account_get_special_folder): For outboxes, get the
2643 parent modest account name. The account is ignored for other folders.
2644 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2645 modest account name rather than a server TnyAccount.
2647 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2649 * src/modest-tny-account.c:
2650 (modest_tny_account_new_from_server_account):
2651 Call modest_runtime_get_send_queue() immediately after creating transport
2652 accounts, so that they start trying to send email from the outbox as soon
2653 as possible at startup. This is probably what we want.
2655 * src/modest-mail-operation.c: (update_account_thread):
2656 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2657 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2658 * src/modest-tny-send-queue.h:
2659 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2660 (modest_ui_actions_on_send):
2661 Added comments about how sending works, though it needs some more work.
2663 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2665 * src/modest-tny-account.c:
2666 (modest_tny_account_get_special_folder): Add TODO because this fails when
2667 the network is busy.
2668 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2669 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2670 Do not try to show this window when there is no active account. The UI
2671 specs does not tell us what to do in this case.
2673 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2677 * src/maemo/Makefile.am:
2678 * src/widgets/Makefile.am: Some dist fixes.
2680 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2682 * src/maemo/modest-connection-specific-smtp-window.c:
2683 (on_button_edit): Make the code clearer, to prevent a double free.
2685 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2687 * src/maemo/modest-account-settings-dialog.c:
2688 (modest_account_settings_dialog_set_account_name),
2689 Check the connection-specific smtp servers checkbox if there are any.
2691 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2692 (modest_connection_specific_smtp_edit_window_init):
2693 Start with a suitable port number.
2695 * src/modest-account-mgr-helpers.h:
2696 * src/modest-account-mgr-helpers.c: Added
2697 modest_account_mgr_get_has_connection_specific_smtp().
2699 (modest_account_mgr_set_connection_specific_smtp),
2700 (modest_account_mgr_remove_connection_specific_smtp),
2701 (modest_account_mgr_get_has_connection_specific_smtp),
2702 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2703 connection-specific smtp server accounts in the account, rather than
2704 the server account conf dir.
2706 This fixes bug projects.maemo.org bug NB#58263 .
2708 * src/modest-tny-account-store.c:
2709 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2710 if there are no server accounts yet, to prevent an infinite loop when there
2711 are no accounts. Document that one must be called before the other.
2713 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2715 * src/modest-account-mgr-helpers.c:
2716 (modest_account_mgr_get_default_account): Make sure that at least
2717 one account is always the default, if there are any enabled accounts.
2718 This is just a sanity check that shouldn't be necessary.
2720 * src/modest-account-mgr-priv.c:
2721 (_modest_account_mgr_account_from_key): Unescape the conf key to
2722 get the real account name. For instance, this is an issue if a space
2723 was in the account name, which can happen because the account name
2724 is generated from the display name.
2725 (_modest_account_mgr_get_account_keyname): Always escape the
2727 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2728 Unescape the conf keys to get the real account names.
2730 For instance, previously the is-default radio button in the accounts
2731 list was not checked for any accounts at first. This fixes that,
2732 and might fix several similar bugs.
2734 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2736 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2737 Removed some debug printfs.
2739 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2741 Modest on-disk outbox directories are now here, for instance:
2742 $HOME/.modest/outboxes/<account-id-1>/outbox
2743 $HOME/.modest/outboxes/<account-id-2>/outbox
2745 $HOME/.modest/local-folders/outbox
2746 so we can have a separate outbox for each account.
2747 But they are shown as one outbox in the GtkTreeView, by using a
2748 TnyMergeFolder in a ModestTnySimpleFolderStore.
2751 * src/modest-tny-simple-folder-store.c:
2752 * src/modest-tny-simple-folder-store.h:
2753 Added ModestTnySimpleFolderStore, used to contain folders from
2754 other folder stores, such as other accounts.
2756 * src/modest-tny-outbox-account.h:
2757 * src/modest-tny-outbox-account.c:
2758 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2759 used for the per-account local outbox folders.
2761 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2762 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2763 only use this (internally) now for the non-outbox local folders.
2765 * src/modest-init.h:
2766 * src/modest-init.c: Added modest_init_one_local_folder(), for
2767 setting up the directory structure for each local folder.
2769 * src/modest-local-folder-info.c:
2770 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2771 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2773 * src/modest-local-folder-info.h:
2774 * src/modest-tny-account-store.c: (on_account_removed),
2775 (on_account_changed), (create_per_account_local_outbox_folders),
2776 (get_server_accounts), (modest_tny_account_store_get_accounts),
2777 (modest_tny_account_store_get_tny_account_by_account),
2778 (modest_tny_folder_store_is_virtual_local_folders):
2780 * src/modest-tny-account.h:
2781 * src/modest-tny-account.c:
2782 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2783 to create an on-disk per-account local outbox folder for each
2785 (create_per_account_local_outbox_folders): Create a local outbox folder
2786 for each transport account.
2787 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2788 for all local folders.
2790 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2791 instead of using g_object_get/set() directly. It is clearer.
2793 (modest_tny_folder_store_get_message_count),
2794 (modest_tny_folder_store_get_local_size
2795 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2796 because we now use these with non-acount folder stores.
2798 (modest_tny_account_get_special_folder),
2799 (modest_tny_account_new_from_server_account),
2800 (modest_tny_account_new_from_account):
2801 (recurse_folders): Adjust to the new outbox system.
2803 * src/modest-tny-folder.h:
2804 * src/modest-tny-folder.c:
2805 (modest_tny_folder_is_local_folder),
2806 (modest_tny_folder_get_local_folder_type),
2807 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2809 * src/widgets/modest-main-window.h:
2810 * src/maemo/modest-main-window.c: (create_details_widget),
2811 (modest_main_window_set_contents_style): Show details for any folder store,
2814 (modest_tny_folder_get_rules):
2815 Remove the const. C does not support constness enough for this.
2817 * src/modest-ui-actions.c:
2818 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2819 make all outboxes appear as one, in the usual local-folders tree node.
2821 (set_active_account_from_tny_account),
2822 (modest_ui_actions_on_folder_selection_changed):
2823 * src/widgets/modest-folder-view.c: (text_cell_data),
2824 (icon_cell_data), (filter_row),
2825 (add_account_folders_to_merged_folder),
2826 (add_account_folders_to_simple_folder_store), (),
2827 (get_cmp_rows_type_pos), (cmp_rows),
2828 (modest_folder_view_set_account_id_of_visible_server_account):
2829 Adjust to the new outbox system, using generic folder stores and folders
2830 in the GtkTreeModel.
2832 2007-05-23 Christian Kellner <ckellner@openismus.com>
2834 * src/modest-mail-operation.c:
2835 (modest_mail_operation_update_account):
2836 Use info->max_size instead of unintialized local var [small
2837 build fix]. (Added TODO to review that change since I don't
2840 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2842 * libmodest-dbus-client/libmodest-dbus-client.c:
2843 (libmodest_dbus_client_compose_mail): function added
2844 * src/dbus_api/modest-dbus-api.h:
2845 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2846 (on_compose_mail): Implementation of the SendAsMail functionality
2848 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2850 * src/modest-account-mgr.c:
2851 (modest_account_mgr_add_server_account): Set the secure-connection
2852 conf key for transport accounts as well as store accounts. I don't know
2853 why the if was there. For instance, this makes sure that we use SSL
2854 for the gmail preset from the easysetup wizard.
2856 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2858 * src/gnome/modest-main-window.c:
2859 (on_account_store_connecting_finished), (connect_signals):
2860 * src/maemo/modest-main-window.c:
2861 (on_account_store_connecting_finished), (connect_signals),
2862 (modest_main_window_new):
2863 Handle TnyAccountStore::connecting-finished instead of
2864 TnyDevice::connection-changed, because we cannot actually perform
2865 operations on accounts until TnyAccountStore has itself responded to
2866 the TnyDevice::connection-changed signal. This prevents a GError from
2868 Do not try to update at startup, because we (at least on scratchbox)
2869 already do an update at startup when the device goes online.
2870 This prevents a GError from tinymail.
2871 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2872 Added TODO about stopping simultaneous operations.
2874 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2876 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2877 * src/modest-mail-operation-queue.c:
2878 (modest_mail_operation_queue_remove):
2879 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2880 about where they happened.
2882 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2884 * src/modest-ui-actions.c:
2885 (modest_ui_actions_on_password_requested): Make sure that the remember
2886 output parameter is always TRUE.
2888 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2890 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2891 Show a OK/Cancel dialog if the error is a question, though we still do not
2892 know anything more about what we are asking the user.
2893 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2894 Fix an uninitialized variable (helper). This is a logic error, however.
2896 2007-05-21 Christian Kellner <ckellner@openismus.com>
2898 * src/modest-search.h:
2899 Correct bit shifting in the ModestSearchFlags enum.
2901 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2903 * src/modest-tny-account.c:
2904 (modest_tny_account_new_from_server_account): Do not use the lsub and
2905 check-all hard-coded IMAP options when using POP.
2907 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2909 * src/modest-tny-account.c:
2910 (modest_tny_account_new_from_server_account):
2911 Use NULL for the secure-auth method for POP when Password auth has been
2912 specified by the user, as we already do for IMAP. "auth=Login" causes
2913 an error from camel or the server.
2915 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2917 * src/maemo/modest-account-settings-dialog.c:
2918 (create_page_account_details),
2919 (modest_account_settings_dialog_set_account_name):
2920 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2921 for the leave-on-server checkbox, rathr than just the checkbox, when
2922 the protocol is not POP.
2924 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2926 * src/widgets/modest-account-view.c:
2927 * src/widgets/modest-account-view.h:
2928 Added modest_account_view_select_account() which will be useful later
2929 to asynchronously re-select the edited account.
2931 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2933 * src/maemo/modest-account-settings-dialog.c:
2934 (modest_account_settings_dialog_set_account_name):
2935 Automatically choose the port numbers based on the secure authentication
2936 methods, if they have not been chosen before.
2937 This fixes projects.maemo.org bug NB#56273 .
2939 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2941 * src/maemo/modest-main-window-ui.h:
2942 * src/modest-ui-actions.c:
2943 * src/modest-ui-actions.h:
2944 Connect the Tools/SMTP Servers menu item to
2945 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2946 SMTP servers dialog, as in the UI specification and saves changes when it
2947 is closed. This fixed projects.maemo.org bug NB#56305 .
2949 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2951 * src/maemo/modest-connection-specific-smtp-window.c:
2952 (modest_connection_specific_smtp_window_init):
2953 Use gtk_window_set_default_size() to make this window big enough, so
2954 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2956 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2958 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2959 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2960 (modest_connection_specific_smtp_edit_window_init),
2961 Do not try to connect to a combobox signal before the combobox exists.
2962 This fixes the cras in projects.maemo.org bug NB#56288 .
2963 (modest_connection_specific_smtp_edit_window_get_settings):
2964 Remove the server_account_name parameter which was being checked for NULL
2965 though it was not used.
2967 * src/maemo/modest-connection-specific-smtp-window.c:
2968 (modest_connection_specific_smtp_window_fill_with_connections),
2969 (on_button_edit), (modest_connection_specific_smtp_window_init):
2970 Correct the number of treemodel columns to prevent a warning.
2971 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2972 libconic does not work.
2974 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2976 * src/modest-tny-account.c:
2977 (modest_tny_account_new_from_server_account):
2978 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2979 SMTP when "None" was chosen by the user. However, with my SMTP server that
2980 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2983 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2985 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2986 to explain the memory management issue with the ID in the ModestPair.
2988 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2989 (add_sending_page), (modest_account_assistant_finalize):
2990 * src/gnome/modest-gnome-global-settings-dialog.c:
2991 (create_updating_page), (create_composing_page):
2992 * src/gnome/modest-msg-edit-window.c: (get_transports),
2993 (init_window), (modest_msg_edit_window_finalize),
2994 (modest_msg_edit_window_get_msg_data):
2995 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2996 * src/gnome/modest-transport-widget.c:
2997 (modest_transport_widget_finalize), (smtp_configuration):
2998 * src/maemo/modest-maemo-global-settings-dialog.c:
2999 (create_updating_page), (create_composing_page):
3000 * src/maemo/modest-msg-edit-window.c: (get_transports),
3001 (init_window), (modest_msg_edit_window_finalize),
3002 (modest_msg_edit_window_get_msg_data),
3003 (modest_msg_edit_window_free_msg_data):
3004 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3005 (modest_store_widget_finalize):
3006 * src/maemo/modest-transport-widget.c:
3007 (modest_transport_widget_finalize), (smtp_configuration):
3008 * src/modest-main.c: (send_mail):
3009 * src/widgets/modest-combo-box.h:
3010 * src/widgets/modest-global-settings-dialog-priv.h:
3011 * src/widgets/modest-global-settings-dialog.c:
3012 (modest_global_settings_dialog_finalize):
3013 * src/widgets/modest-msg-edit-window.h:
3014 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3015 as long as the combo box, to prevent use of freed memory for the ID.
3017 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3019 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3020 get_accounts(), to make this clearer. Do not check for the enabled gconf
3021 key, because we do not use this for server accounts (at least, not yet).
3022 This allows us to send email again.
3024 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3026 * src/maemo/modest-platform.c:
3027 (on_modest_conf_update_interval_changed), (modest_platform_init):
3028 Only respond to this particular key change. All these strcmp()s cannot be
3031 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3033 * src/maemo/modest-maemo-global-settings-dialog.c:
3034 (current_connection): Prevent a crash in scratchbox when
3035 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3036 * src/maemo/modest-platform.c:
3037 (on_modest_conf_update_interval_changed), (modest_platform_init):
3038 Get the update interval from gconf and reset it when the gconf key changes.
3040 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3042 * src/modest-protocol-info.c:
3043 * src/modest-protocol-info.h: Adde enum-specific get functions,
3044 instead of using a ModestProtocolType enum parameter.
3046 * src/gnome/modest-account-assistant.c:
3047 * src/gnome/modest-store-widget.c:
3048 * src/gnome/modest-store-widget.h:
3049 * src/gnome/modest-transport-widget.c:
3050 * src/gnome/modest-transport-widget.h:
3051 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3052 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3053 * src/maemo/easysetup/modest-easysetup-wizard.c:
3054 * src/maemo/modest-account-settings-dialog.c:
3055 * src/maemo/modest-account-settings-dialog.h:
3056 * src/maemo/modest-store-widget.c:
3057 * src/maemo/modest-store-widget.h:
3058 * src/maemo/modest-transport-widget.c:
3059 * src/maemo/modest-transport-widget.h:
3060 * src/modest-account-mgr-helpers.c:
3061 * src/modest-account-mgr-helpers.h:
3062 * src/modest-account-mgr.c:
3063 * src/modest-account-mgr.h:
3064 * src/modest-tny-account.c:
3065 * src/modest-tny-folder.c:
3066 * src/widgets/modest-account-view.c:
3067 * src/widgets/modest-retrieve-combo-box.c:
3068 * src/widgets/modest-retrieve-combo-box.h:
3069 * src/widgets/modest-secureauth-combo-box.c:
3070 * src/widgets/modest-serversecurity-combo-box.c:
3071 * src/widgets/modest-serversecurity-combo-box.h:
3072 * tests/check_account-mgr.c:
3073 Use the specific functions, and use the re-renamed enum values for GNOME too.
3075 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3077 * src/modest-pair.h:
3078 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3079 so we can get the second based on the first.
3081 * src/maemo/modest-account-settings-dialog.h:
3082 * src/maemo/modest-account-settings-dialog.c:
3083 Added get_supported_secure_authentication_methods(), though it is mostly
3084 commented-out for now until the necessary API is committed to tinymail.
3085 (modest_account_settings_dialog_set_account_name),
3086 (save_configuration): Request the supported authentication methods from the
3087 server, so we can choose a working method.
3089 * src/modest-tny-account-store.h:
3090 * src/modest-tny-account-store.c:
3091 (modest_tny_account_store_get_session): Rename from
3092 tny_account_store_get_session().
3094 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3096 * src/modest-protocol-info.h: Split the ModestProtocol enum
3097 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3098 There was no need to have these unrelated values in one enum.
3100 * src/: many files: Adapted to changed enum. This makes the code a bit
3101 clearer, and the compiler could catch some errors.
3103 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3105 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3106 Show the detailed internal camel error message when an error happens
3107 during the configuration, so that our testers can give us more clues.
3108 For instance, in projects.maemo.org bug NB#56910 .
3110 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3112 * src/modest-tny-account.c:
3113 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3114 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3116 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3118 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3119 * src/maemo/modest-account-settings-dialog.c:
3120 (modest_account_settings_dialog_set_account_name),
3121 (save_configuration): For the incoming secure authentication checkbox,
3122 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3123 the UI specification. PLAIN does not seem to be supported for most IMAP
3124 servers anyway, and I am not sure what it would mean.
3125 However, we probably need to discover which of the secure-authentication
3126 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3127 * src/modest-account-mgr-helpers.c:
3128 (modest_account_mgr_get_server_account_data):
3130 * src/modest-tny-account.c:
3131 (modest_tny_account_new_from_server_account):
3132 Use tny_account_set_mech() to set secure-authentication methods,
3133 with some special-casing for IMAP, based on my observations of how
3136 * src/modest-account-mgr-helpers.h:
3137 * src/modest-account-mgr.c:
3138 * src/modest-defs.h: Comment that the URI is only used for local folders.
3140 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3142 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3143 parameter const, just to be neat.
3144 * src/modest-text-utils.c: (modest_text_utils_inline):
3145 End g_strconcat() with NULL, as its documentation says. This is almost
3146 certainly the cause of my crash at startup on the device. Interestingly,
3147 valgrind doesn't tell us about these errors.
3149 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3151 * scripts/build-packages: Added more precise comments about how to use
3152 this script, though I still get this error:
3153 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3154 error building tinymail
3156 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3158 * src/maemo/modest-main-window.c: (on_account_update):
3159 Very slight cleanup, hoping to make it simpler to discover what causes
3160 a crash here sometimes.
3162 * src/modest-tny-account.c:
3163 (modest_tny_account_new_from_server_account): Set the port. Added
3164 comments about the options and a TODO comment because I need to find out
3165 how to specify the secure authentication method.
3167 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3169 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3170 changed CFlags paths form modest to libmodest
3172 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3174 * src/modest-account-mgr-helpers.c:
3175 (modest_account_mgr_get_server_account_data),
3176 (modest_account_mgr_free_server_account_data):
3177 * src/modest-account-mgr-helpers.h:
3178 * src/modest-account-mgr.c:
3179 (modest_account_mgr_add_server_account):
3180 * src/modest-defs.h:
3181 * src/modest-tny-account.c:
3182 (modest_tny_account_new_from_server_account):
3183 Determine the options for tny_camel_account_add_option() here,
3184 based on the settings, rather than storing them directly in gconf.
3186 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3188 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3189 Show a more friendly error dialog now that we expect (from the tinymail
3190 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3192 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3194 * src/maemo/modest-main-window.c: (on_account_update): Check that
3195 account_name is not NULL, to prevent a crash at startup that I am
3196 seeing on the N800. I do wonder why it is NULL.
3198 * src/maemo/easysetup/modest-easysetup-wizard.c:
3199 (create_page_user_details):
3200 * src/maemo/modest-account-settings-dialog.c:
3201 (create_page_user_details), (create_page_outgoing):
3202 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3203 (modest_connection_specific_smtp_edit_window_init):
3204 * src/modest-ui-actions.c:
3205 (modest_ui_actions_on_password_requested):
3206 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3207 might do something useful with the on-screen keyboard.
3209 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3211 * src/maemo/modest-main-window.c: (on_account_update):
3212 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3213 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3215 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3217 * src/modest-tny-account-store.c: (on_account_changed):
3218 Correct the signature of this signal handler.
3220 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3222 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3223 Show a HildonNote instead of a GtkDialog for Maemo.
3225 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3227 * src/widgets/modest-account-view.h:
3228 * src/widgets/modest-account-view.c: (on_account_changed),
3229 (on_account_removed). Added a boolean flag, set/unset by
3230 modest_account_view_block_conf_updates(),
3231 modest_account_view_unblock_conf_updates() to prevent unnecessary
3232 updates, but this is not very useful because the gconf notifications are
3233 so delays (maybe only on Maemo Bora).
3234 So auto-updating is turned off, and these functions do an explicit
3235 update when necessary.
3236 However, something else is still doing too much work when adding/removing
3237 accounts, probably in another part of the application.
3239 * src/maemo/modest-account-view-window.c:
3240 (on_delete_button_clicked), (on_edit_button_clicked),
3241 (on_new_button_clicked): Use the new functions.
3243 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3245 * src/modest-account-mgr-helpers.c:
3246 (modest_account_mgr_set_first_account_as_default):
3247 Sort the list of names alphabetically-by-title, so we choose the first one
3249 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3250 alphabetically by the title.
3252 This fixes projects.maemo.org bug NB#56418 .
3254 * src/modest-account-mgr-priv.c:
3255 (_modest_account_mgr_account_from_key):
3256 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3257 avoid a valgrind error, and possible random behaviour.
3259 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3261 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3262 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3263 tinymail documentation to say that this can be expected.
3264 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3265 pretty, and should not happen, but I would prefer to know when it does.
3267 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3269 * configure.ac: When using the older hildon version, probably on Bora,
3270 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3272 * src/widgets/modest-attachment-view.c:
3273 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3276 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3278 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3279 Implemented the prototype. Can be tested with
3280 tests/dbus_api/test_open_message:
3282 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3284 * src/modest-tny-account-store.c:
3285 (modest_tny_account_store_instance_init), (get_password):
3286 * src/modest-ui-actions.c:
3287 (modest_ui_actions_on_password_requested):
3288 Do not store the password in gconf, because this function is called
3289 for non-remembered passwords. Actually use the cached (in the hash map)
3290 password instead of releasing it.
3291 The password will now not be remembered if it is asked via the protected
3292 password dialog, as per the UI spec.
3294 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3296 * src/modest-defs.h:
3297 * src/modest-account-mgr-helpers.h:
3298 * src/modest-account-mgr-helpers.c:
3299 Added modest_server_account_get_username_has_succeeded(),
3300 modest_server_account_set_username_has_succeeded().
3301 (modest_server_account_set_username),
3302 Reset the has-succeeded flag if the username changes.
3304 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3305 * src/maemo/modest-connection-specific-smtp-window.c:
3306 (modest_connection_specific_smtp_window_save_server_accounts):
3307 Use modest_server_account_set_username() instead of using
3308 modest_conf_set_string() directly, so that the has-succeeded flag is always
3311 * src/modest-ui-actions.c:
3312 (modest_ui_actions_on_password_requested): Dim the username entry if
3313 the username has ever worked, as per the UI spec.
3315 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3317 * src/modest-tny-account-store.c: (get_password):
3318 * src/modest-ui-actions.c:
3319 (modest_ui_actions_on_password_requested):
3320 Allow the username to be changed too, though there is more work to
3321 be done on exactly how this behaves.
3323 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3325 * src/modest-account-mgr-helpers.h:
3326 * src/modest-account-mgr-helpers.c:
3327 Added modest_account_mgr_get_display_name(),
3328 modest_server_account_get_username(),
3329 modest_server_account_set_username(),
3330 modest_server_account_set_password(),
3331 modest_server_account_get_hostname() functions so we do not need to
3332 use the conf API directly.
3334 * src/maemo/modest-main-window.c: (connect_signals):
3335 Actually connect ot the ModestAccountStore::request-password signal,
3336 so that we show the dialog when the password is requested by Tinymail,
3337 for isntance if it is empty.
3339 * src/modest-marshal.list:
3340 * src/modest-tny-account-store.c:
3341 (modest_tny_account_store_class_init), (get_password),
3342 (modest_tny_account_store_alert):
3343 * src/modest-tny-account-store.h:
3344 * src/modest-ui-actions.h:
3345 * src/modest-ui-actions.c:
3346 (modest_ui_actions_on_password_requested):
3347 Change the signal parameters, so it is obvious that we are providing
3348 the non human-readable server name, and receiving both the username
3349 and password, though changing of the username is not yet implemented.
3350 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3351 for the GNOME version.
3353 This should fix the projects.maemo.org bug NB#56209, though it does not
3354 work on Bora, because the gconf_client_get() for the password fails
3355 immediately after we save it with gconf_client_set().
3357 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3360 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3361 caused an undefined symbol error:
3362 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3364 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3366 * src/modest-tny-account-store.c:
3367 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3368 using a GError instead of a string message, so we can translate it in
3371 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3373 * src/maemo/modest-address-book.c:
3374 (modest_address_book_check_names):
3375 * src/maemo/modest-msg-view-window.c:
3376 (modest_msg_view_window_clipboard_owner_change):
3377 * src/modest-init.c: (modest_init_init_ui):
3378 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3379 (update_folders_cb), (modest_mail_operation_update_account):
3380 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3381 (modest_ui_actions_on_msg_attachment_clicked),
3382 (modest_ui_actions_on_msg_recpt_activated):
3383 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3384 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3385 (modest_msg_view_search_next):
3386 * src/widgets/modest-recpt-editor.c:
3387 (modest_recpt_editor_on_button_release_event),
3388 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3389 g_message(). At this point we should only be seeing interesting errors on
3390 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3392 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3394 (modest_wizard_dialog_force_title_update):
3395 * src/maemo/easysetup/modest-wizard-dialog.h:
3396 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3397 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3398 can update the title when appropriate. Otherwise the title is wrong if the
3399 pages are added after adding the notebook to the dialog.
3400 This must be a problem in HildonWizardDialog too.
3401 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3403 * src/maemo/easysetup/modest-easysetup-wizard.c:
3404 (create_subsequent_customsetup_pages),
3405 (create_subsequent_easysetup_pages):
3406 Call modest_wizard_dialog_force_title_update() so that the title is
3407 correct even with GTK+ < 2.10.
3408 This fixes projects.maemo.org bug NB#56145 .
3410 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3412 * src/maemo/modest-platform.c:
3413 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3414 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3417 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3419 * src/widgets/modest-window.h:
3420 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3421 and modest_window_save_state(), which invokes it.
3423 * src/widgets/modest-window-mgr.h:
3424 * src/widgets/modest-window-mgr.c:
3425 Added modest_window_mgr_save_state_for_all_windows(), which calls
3426 the save_state vfunc on all registered windows, if implemented.
3428 * src/gnome/modest-msg-edit-window.c:
3429 * src/gnome/modest-msg-view-window.c:
3430 * src/maemo/modest-msg-edit-window.c:
3431 * src/maemo/modest-msg-view-window.c:
3432 * src/maemo/modest-main-window.c:
3433 Specify the existing save_settings functions as implementations of
3434 ModestWindow::save_state_func().
3436 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3437 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3438 enabling hibernation, for instance.
3440 We may need to do the same thing for restoring settings.
3443 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3445 * src/widgets/modest-window-mgr.c:
3446 * src/widgets/modest-window-mgr.h:
3447 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3448 modest_window_mgr_get_hibernation_is_prevented().
3450 * src/maemo/modest-main-window.c:
3451 (on_hildon_program_is_topmost_notify): Prevent hibernation
3452 (possible when the application goes to the background in the WM),
3453 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3455 * src/maemo/easysetup/modest-easysetup-wizard.c:
3456 (modest_easysetup_wizard_dialog_init):
3457 * src/maemo/modest-account-settings-dialog.c:
3458 (modest_account_settings_dialog_init):
3459 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3460 (modest_connection_specific_smtp_edit_window_init):
3461 * src/maemo/modest-connection-specific-smtp-window.c:
3462 (modest_connection_specific_smtp_window_init):
3463 * src/maemo/modest-signature-editor-dialog.c:
3464 (modest_signature_editor_dialog_init):
3465 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3466 prevent hibernation while any of these account settings dialogs are open.
3468 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3470 * src/maemo/Makefile.am:
3471 * src/maemo/modest-osso-state-saving.c:
3472 * src/maemo/modest-osso-state-saving.h: Added
3473 modest_osso_load_state() and modest_osso_save_state() though they do
3474 nothing now. They should iterate through all the open windows and load/save
3476 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3477 save state when closing.
3479 * src/maemo/modest-main-window.c:
3480 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3481 Add a notification handler for the HildonProgram::is-topmost property,
3482 so we can allow hibernation when the application goes into the background.
3483 But we still need to detect when the accounts setup windows are open so
3484 we can stop hibernation when they are open.
3485 To do this, I also added the main window the HildonProgram. This might have
3486 other side-effects/benefits, and should maybe be done for other windows.
3488 * src/maemo/modest-osso-autosave-callbacks.h:
3489 * src/maemo/modest-osso-autosave-callbacks.c:
3490 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3491 though it does not do anything yet, and we might never need this to do
3492 anything. For instance, we already save drafts.
3494 * src/maemo/modest-platform.c: (modest_platform_init):
3495 Specify the libosso auto-save callback.
3497 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3499 * src/maemo/modest-platform.c:
3500 (modest_platform_set_update_interval):
3501 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3502 aparently stays valid between application instances, so we can use this
3503 to remove and reset it later. According to a maemo-developers email from
3506 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3508 * configure.ac: Depend on libalarm for Maemo.
3510 * src/dbus_api/modest-dbus-api.h:
3511 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3512 (on_send_receive), (modest_dbus_req_handler):
3513 Handle a SEND_RECEIVE D-Bus method.
3515 * libmodest-dbus-client/libmodest-dbus-client.c:
3516 (libmodest_dbus_client_send_and_receive):
3517 * libmodest-dbus-client/libmodest-dbus-client.h:
3518 Add C convenience functions for calling the new D-Bus method.
3520 * src/modest-platform.h:
3521 * src/gnome/modest-platform.c:
3522 * src/maemo/modest-platform.c:
3523 Added modest_platform_set_update_interval(), which uses the
3524 alarmd API on Maemo.
3525 (modest_platform_init),
3526 Call modest_platform_set_update_interval(), using a hard-coded
3527 interval for now (until the global settings dialog is implemented),
3528 though I am not sure that this makes sense yet.
3530 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3532 * src/dbus_api/modest-dbus-callbacks.c:
3533 (modest_osso_cb_hw_state_handler):
3534 * src/dbus_api/modest-dbus-callbacks.h:
3535 * src/maemo/modest-platform.c: (modest_platform_init):
3536 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3537 in case this has some effect on the ability for Maemo to ping the
3540 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3542 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3543 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3544 warning. It is probably a logic error, but I need to fix the build.
3546 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3548 * src/modest-account-mgr.h:
3549 * src/modest-account-mgr.c:
3550 (modest_account_mgr_account_names): Add a gboolean enabled_only
3551 parameter, so we can get lists of onlt the enabled accounts.
3553 (modest_account_mgr_add_account),,
3554 (modest_account_mgr_account_with_display_name_exists):
3555 * src/maemo/modest-msg-edit-window.c: (get_transports):
3556 * src/modest-account-mgr-helpers.c:
3557 (modest_account_mgr_set_first_account_as_default):
3558 * src/modest-init.c: (init_default_account_maybe):
3559 * src/modest-tny-account-store.c: (get_accounts):
3560 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3561 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3562 * tests/check_account-mgr.c: (START_TEST):
3563 Provide the extra parameter, as appropriate.
3565 * src/widgets/modest-account-view.c: (update_account_view):
3566 Do not show disabled accounts (meaning that there is no way to
3567 enable/disable accounts in the UI (the feature is not in our UI
3568 specification), so we can use this internally only to mark unfinished
3569 or temporary account data.
3571 * src/maemo/easysetup/modest-easysetup-wizard.c:
3572 (create_account): Add boolean enable parameter, so we can specify FALSE
3573 to create the temporary account.
3574 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3575 (on_before_next): When finishing, when there is a temporary account, just
3577 Also, use a timeout to delay the showing of the dialog until gconf is likely
3578 to return correct information, due to a maemo gconf bug that is fixed in
3579 osso 1.1, but not yet in Bora.
3580 However, the dialog stays on screen after it is destroyed.
3582 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3583 for invalid data when cancelling. Use a hildon note instead of a dialog
3584 to complain about invalid data. Do not show the account-saved note if the
3585 account is disabled (a temporary account that will not really be saved for use
3588 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3590 * src/modest-account-mgr-helpers.h:
3591 * src/modest-account-mgr-helpers.c:
3592 Added modest_account_mgr_unset_default_account(),
3593 Added modest_account_mgr_set_first_account_as_default().
3595 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3596 If it was the default account, unset the default account name.
3598 * src/maemo/modest-account-view-window.c:
3599 (on_delete_button_clicked): If it was the default account,
3600 set the first remaining account as the default instead.
3602 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3603 a NULL account or a NULL default account, to prevent a crash. This should
3604 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3607 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3609 * src/widgets/modest-recpt-editor.c:
3610 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3611 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3612 TODO comment for this. This fixes the build.
3614 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3615 be the best place for it. This will in future update all auto-update accounts,
3616 rather than just the current/default account, when that gconf key exists.
3617 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3618 if there are no accounts, before calling do_send_receive().
3619 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3621 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3622 * src/maemo/modest-main-window-ui.h:
3623 * src/maemo/modest-main-window.c: (on_connection_changed),
3624 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3625 directly, becaue the signal handler does more.
3627 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3629 * src/modest-account-mgr-helpers.c:
3630 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3631 for the case that the account does not exist.
3633 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3634 (equivalent to the modest account name) rather than the tinymail account name
3635 (equivalent to the modest account title - human readable) to get the account data.
3636 Check for null account data to prevent the crash, and add a TODO comment saying that
3637 this needs fixing because it is using the server account name instead of the account name.
3639 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3641 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3642 * src/maemo/modest-account-settings-dialog.c: (show_error),
3644 Use hildon_note_new_information() for informative and error messages,
3645 which seems to be expected for Maemo applications (no documentation that I know of
3646 says this). I am surprised that there is no distinction between info and error
3649 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3651 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3652 it is easy to find where this is used.
3654 * src/maemo/easysetup/modest-easysetup-wizard.c:
3655 (create_page_welcome), (create_page_account_details),
3656 (create_page_user_details), (create_page_complete_easysetup),
3657 (create_page_custom_incoming), (create_page_custom_outgoing),
3658 (create_page_complete_custom):
3659 * src/maemo/modest-account-settings-dialog.c:
3660 (create_page_account_details), (create_page_user_details),
3661 (create_page_incoming), (create_page_outgoing):
3662 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3663 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3664 (modest_connection_specific_smtp_edit_window_init):
3665 * src/maemo/modest-connection-specific-smtp-window.c:
3666 (modest_connection_specific_smtp_window_init):
3667 * src/maemo/modest-signature-editor-dialog.c:
3668 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3669 and scrolling policy as per the Email Application Layout Guide, if I have
3672 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3674 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3675 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3676 which were empty, because these vfuncs have been removed from TnyAccountStore.
3677 This fixes the build.
3679 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3681 * src/maemo/modest-main-window.c:
3682 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3683 showing/hiding it. Added TODO because it probably should not be NULL.
3684 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3685 because unnecessary g_warnings() make degugging difficult.
3687 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3689 * src/maemo/modest-msg-edit-window.c:
3690 (modest_msg_edit_window_select_color),
3691 (modest_msg_edit_window_select_background_color): 2 const corrections and
3692 moving 2 #endifs before closing brackets, to fix the build.
3694 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3696 * src/maemo/easysetup/modest-easysetup-wizard.h:
3697 * src/maemo/easysetup/modest-easysetup-wizard.c:
3698 (modest_easysetup_wizard_dialog_finalize),
3699 (on_button_edit_advanced_settings), (create_page_complete_custom),
3700 (on_response), (create_account):
3701 Implement the Advanced Settings edit button, by saving the account information,
3702 for the Advanded Settings dialog to use directly from gconf, and removing it
3703 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3704 Bug #5533 in the projects.maemo.org bugzilla.
3706 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3708 * src/maemo/modest-msg-view-window.c:
3709 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3710 when opening a message window.
3712 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3714 * src/maemo/easysetup/modest-easysetup-wizard.c:
3715 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3718 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3719 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3720 gconf settings. I probably added more checks than necessary, but that is safer.
3722 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3723 variable to fix the build, but this seems to be used when it is still NULL.
3725 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3727 * src/modest-platform.h:
3728 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3729 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3730 * src/modest-main.c: Implement this function so we can avoid using
3731 maemo-specific API from cross-platform code.
3733 * src/modest-tny-account-store.c:
3734 (get_smtp_specific_transport_account_for_open_connection):
3735 * src/modest-ui-actions.c: (check_for_connection),
3736 (modest_ui_actions_on_item_not_found):
3737 Use modest_platform_connect_and_wait() and put #idefs around other
3738 maemo-specific code, because only maemo currently has a way to
3739 identify connection names.
3741 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3743 * src/modest-tny-account-store.h:
3744 * src/modest-tny-account-store.c:
3745 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3746 the connection-specific SMTP server settings in the configuration.
3748 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3750 * src/maemo/modest-main-window.c: (on_connection_changed),
3752 * src/modest-main.c: (main), (start_ui), (send_mail):
3753 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3754 that is what is intended.
3756 * src/modest-ui-actions.c: (action_send), (action_receive),
3757 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3758 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3759 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3760 SMTP server is used when it is specified.
3762 (modest_ui_actions_on_send_receive):
3763 Check that a connection is open before proceeding.
3764 Receive and then send, instead of vice-versa, as per the specification.
3766 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3768 * src/modest-mail-operation.c:
3769 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3770 though I guess it should be something other than NULL.
3772 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3774 * src/maemo/easysetup/modest-easysetup-wizard.c:
3775 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3776 combo twice, to avoid an g_warning and to make it visible again.
3777 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3778 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3779 (already intended) dereference when detaching, because we then recreate the menu.
3780 But I am not sure why the warning was happening, and it is possible that this is a memory
3783 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3785 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3786 and uri_parse_mailto() utility functions.
3787 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3789 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3791 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3793 * src/dbus_api/modest-dbus-api.h:
3794 * src/dbus_api/modest-dbus-callbacks.c:
3795 Use an idle callback to execute the modest code in the application's own thread.
3796 Remove the helloworld example method.
3797 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3798 parsed, and the open-message method is not implemented because this is not yet implemented in
3800 * libmodest-dbus-client/libmodest-dbus-client.c:
3801 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3802 (libmodest_dbus_client_open_message):
3803 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3805 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3806 body without crashing.
3808 * tests/dbus_api/Makefile.am:
3809 * tests/dbus_api/test_mail_to.c:
3810 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3812 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3814 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3815 Added file to fix the build. Sorry.
3817 * src/dbus_api/Makefile.am:
3818 * src/dbus_api/modest-dbus-api.h:
3819 * src/dbus_api/modest-dbus-callbacks.h:
3820 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3821 (modest_dbus_req_handler):
3822 Put constants in a separate header so it can be reused by the
3823 client library, without duplication
3825 * libmodest-dbus-client/Makefile.am:
3826 * libmodest-dbus-client/libmodest-dbus-client.c:
3827 (libmodest_dbus_client_call_helloworld),
3828 (libmodfest_dbus_client_send_mail),
3829 (libmodfest_dbus_client_mailto),
3830 (libmodfest_dbus_client_open_message):
3831 * libmodest-dbus-client/libmodest-dbus-client.h:
3832 (Partly) Implement a send_mail D-Bus method.
3834 * tests/dbus_api/Makefile.am:
3835 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3836 the send_email D-Bus method.
3838 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3842 * libmodest-dbus-client/Makefile.am:
3843 * libmodest-dbus-client/libmodest-dbus-client.c:
3844 * libmodest-dbus-client/libmodest-dbus-client.h:
3845 * tests/dbus_api/Makefile.am:
3846 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3847 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3849 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3851 * src/maemo/easysetup/modest-easysetup-wizard.c:
3852 (create_page_account_details):
3853 * src/maemo/modest-account-settings-dialog.c:
3854 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3855 widgets, because this might not be the default in future versions of the Maemo GTK+.
3856 However, I can not not get capitalization to work even in a simple test case.
3858 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3860 * src/maemo/easysetup/modest-easysetup-wizard.c:
3861 (create_page_custom_incoming), (create_page_custom_outgoing):
3862 * src/maemo/modest-account-settings-dialog.c:
3863 (create_page_account_details), (create_page_incoming),
3864 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3865 instead of using gtk_check_button_with_label(), so they are aligned like the other
3866 widgets, as per the UI spec.
3868 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3870 * src/maemo/easysetup/modest-easysetup-wizard.c:
3871 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3872 * src/widgets/modest-validating-entry.c:
3873 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3874 Modest prefix instead of an EasySetup prefix.
3876 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3878 * src/widgets/modest-validating-entry.h:
3879 * src/widgets/modest-validating-entry.c: (on_insert_text),
3880 Added easysetup_validating_entry_set_max_func(), used to set a callback
3881 to call when the max number of characters is reached. GtkEntry has a max-length
3882 already but is silent about it.
3884 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3885 (create_page_account_details), (create_page_user_details),
3887 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3888 (create_page_account_details), (create_page_user_details),
3889 (create_page_outgoing):
3890 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3891 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3892 the UI spec, when the user tries to enter more than the max number of characters.
3894 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3896 * src/maemo/easysetup/modest-easysetup-wizard.c:
3897 (create_page_user_details), (create_page_custom_incoming),
3898 (create_page_custom_outgoing):
3899 * src/maemo/modest-account-settings-dialog.c:
3900 (create_page_user_details), (create_page_incoming),
3901 (create_page_outgoing):
3902 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3903 (modest_connection_specific_smtp_edit_window_init):
3904 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3905 not appropriate. Bad Maemo-specific defaults!.
3907 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3909 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3910 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3911 (modest_signature_editor_dialog_set_settings):
3912 Disable the label and textview when the checkbox is disabled, and use the
3913 specified (UI spec) default signature text.
3915 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3917 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3918 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3920 * src/modest-defs.h:
3921 * src/modest-account-mgr-helpers.h:
3922 * src/modest-account-mgr-helpers.c:
3923 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3925 * src/maemo/Makefile.am:
3926 * src/maemo/modest-signature-editor-dialog.c:
3927 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3930 * src/maemo/modest-account-settings-dialog.h:
3931 * src/maemo/modest-account-settings-dialog.c:
3932 (modest_account_settings_dialog_finalize), (on_button_signature),
3933 (save_configuration): Use the new dialog when the Edit button is pressed, and
3934 save the changes if necessary, as per the UI spec.
3936 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3938 * src/maemo/Makefile.am:
3939 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3940 based on maemo-develoers email from Dirk.
3942 * src/maemo/easysetup/modest-easysetup-wizard.c:
3943 (create_page_welcome), (create_page_account_details),
3944 (create_page_user_details), (create_page_complete_easysetup),
3945 (create_page_custom_incoming), (create_page_custom_outgoing),
3946 (create_page_complete_custom),
3947 (modest_easysetup_wizard_dialog_init):
3948 * src/maemo/modest-account-settings-dialog.c:
3949 (create_page_account_details), (create_page_user_details),
3950 (create_page_incoming), (create_page_outgoing),
3951 (modest_account_settings_dialog_init):
3952 * src/maemo/modest-connection-specific-smtp-window.c:
3953 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3955 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3957 * src/maemo/easysetup/modest-easysetup-wizard.c:
3958 (create_page_account_details), (create_page_custom_outgoing),
3959 (create_page_complete_custom):
3960 * src/maemo/modest-account-settings-dialog.c:
3961 (create_page_user_details), (create_page_incoming),
3962 (create_page_outgoing):
3963 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3964 (modest_connection_specific_smtp_edit_window_init):
3965 Use the correct (UI spec) port min/max, and use horizontal separators,
3968 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3970 * src/maemo/easysetup/modest-easysetup-wizard.c:
3971 (set_default_custom_servernames):
3972 * src/maemo/modest-account-settings-dialog.c:
3973 (create_page_incoming), (on_combo_outgoing_security_changed),
3974 (on_combo_incoming_security_changed), (create_page_outgoing),
3975 (modest_account_settings_dialog_set_account_name),
3976 (save_configuration):
3977 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3978 (on_combo_security_changed),
3979 (modest_connection_specific_smtp_edit_window_init),
3980 (modest_connection_specific_smtp_edit_window_set_connection),
3981 (modest_connection_specific_smtp_edit_window_get_settings):
3982 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3985 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3988 * src/maemo/easysetup/modest-easysetup-wizard.c:
3989 (create_page_custom_outgoing), (create_page_complete_custom):
3990 * src/maemo/modest-account-settings-dialog.c:
3991 (create_page_user_details), (create_page_outgoing):
3992 * src/maemo/modest-account-view-window.c: (button_box_new):
3993 Use changed logical IDs as per the most recent UI spec:
3994 mcen_bd_emailsetup_edit -> mcen_bd_edit
3995 mcen_bd_emailsetup_delete -> mcen_bd_delete
3996 mcen_bd_emailsetup_close -> mcen_bd_close
3998 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4002 * src/dbus_api/Makefile.am:
4003 * src/dbus_api/modest-dbus-callbacks.c:
4004 * src/dbus_api/modest-dbus-callbacks.h:
4005 * src/maemo/modest-platform.c: (modest_platform_init):
4006 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4008 * tests/Makefile.am:
4009 * tests/dbus_api/Makefile.am:
4010 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4012 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4014 * src/maemo/modest-account-settings-dialog.c:
4015 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4016 Removed unnecessary includes.
4018 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4020 * src/maemo/easysetup/modest-easysetup-wizard.c:
4021 * src/maemo/modest-account-settings-dialog.c:
4022 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4023 * src/widgets/Makefile.am:
4024 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4025 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4026 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4027 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4028 * src/widgets/modest-secureauth-combo-box.c:
4029 * src/widgets/modest-secureauth-combo-box.h:
4030 * src/widgets/modest-serversecurity-combo-box.c:
4031 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4032 made the GObject names more consistent with the rest of the Modest code.
4034 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4036 * src/maemo/easysetup/Makefile.am:
4037 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4038 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4039 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4040 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4041 * src/maemo/easysetup/modest-easysetup-wizard.c:
4042 * src/maemo/easysetup/modest-validating-entry.c:
4043 * src/maemo/easysetup/modest-validating-entry.h:
4044 * src/maemo/modest-account-settings-dialog.c:
4045 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4046 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4047 widgets/ because they are used outside of easysetup too. After checking in,
4048 svn will allow me to rename them too.
4050 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4052 * src/gnome/modest-msg-edit-window.c:
4053 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4054 linker error, to fix the build on the GNOME platform.
4055 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4056 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4057 ifdefed out to avoid a warning.
4059 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4061 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4062 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4063 some alternative for GTK+ 2.6.
4065 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4067 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4069 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4070 specified for EmailAccountsDialog in UI spec.
4072 * src/maemo/easysetup/modest-easysetup-wizard.c:
4073 * src/maemo/easysetup/modest-easysetup-wizard.h:
4074 * src/maemo/modest-account-settings-dialog.c:
4075 * src/maemo/modest-account-settings-dialog.h:
4076 Reuse a member window widget for the connection-specific SMTP server accounts,
4077 so we can tell it to create/save the accounts only if we actually save changes.
4079 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4080 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4081 (modest_connection_specific_smtp_edit_window_get_settings):
4082 Return a struct instance for temporarily remembering the entered data.
4084 * src/maemo/modest-connection-specific-smtp-window.h:
4085 * src/maemo/modest-connection-specific-smtp-window.c:
4086 (modest_connection_specific_smtp_window_finalize),
4087 (modest_connection_specific_smtp_window_fill_with_connections),
4089 (modest_connection_specific_smtp_window_save_server_accounts),
4090 (update_model_server_names): Do not actually save data until asked,
4091 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4093 (on_selection_changed),
4094 (modest_connection_specific_smtp_window_init): Disable the edit
4095 button when nothing is selected.
4097 * src/modest-account-mgr-helpers.c:
4098 * src/modest-account-mgr-helpers.h:
4099 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4102 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4104 * src/modest-account-mgr-helpers.h:
4105 * src/modest-account-mgr-helpers.c:
4106 (modest_account_mgr_get_unused_account_name),
4107 (modest_account_mgr_get_unused_account_display_name): Added these
4108 utility functions, to avoid code duplication.
4110 * src/maemo/easysetup/modest-easysetup-wizard.c:
4111 (create_page_account_details), (create_account):
4112 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4113 (on_combo_security_changed),
4114 (modest_connection_specific_smtp_edit_window_init),
4115 (modest_connection_specific_smtp_edit_window_save_settings):
4116 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4117 * src/maemo/modest-connection-specific-smtp-window.c:
4118 (modest_connection_specific_smtp_window_finalize),
4119 (modest_connection_specific_smtp_window_fill_with_connections),
4120 (on_button_edit), (modest_connection_specific_smtp_window_init):
4121 * src/maemo/modest-connection-specific-smtp-window.h:
4122 Implementing saving of connection-specific server accounts.
4124 But I need to refactor this so we can save the data for each
4125 possible connection-specific account and only actually create the server accounts
4126 when the easysetup finished, or the OK button is pressed on the account settings
4129 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4131 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4132 (on_combo_security_changed):
4133 (modest_connection_specific_smtp_edit_window_init):
4134 Auto-fill the port number as in the account settings.
4136 (modest_connection_specific_smtp_edit_window_set_connection):
4137 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4138 * src/maemo/modest-connection-specific-smtp-window.c:
4139 (fill_with_connections), (on_button_edit),
4140 (modest_connection_specific_smtp_window_init):
4141 Turn the edit window into a dialog to simplify the code, and
4142 set a WM hint as in a GtkDialog, because only a popup can be on top of
4143 another window in Maemo, and popups usually have no WM decoration.
4145 * src/modest-defs.h:
4146 * src/modest-account-mgr-helpers.c:
4147 (modest_account_mgr_set_connection_specific_smtp),
4148 (modest_account_mgr_remove_connection_specific_smtp),
4149 (modest_account_mgr_get_connection_specific_smtp):
4150 * src/modest-account-mgr-helpers.h: Some functions to write the
4151 connection-specific SMTP server information. Not yet used.
4154 * src/widgets/modest-folder-view.c: (text_cell_data):
4155 Fix a warning about an uninitialized variable.
4156 (on_configuration_key_changed): Put an #ifdef around the use
4157 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4159 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4161 * src/maemo/modest-account-settings-dialog.h:
4162 * src/maemo/modest-account-settings-dialog.c:
4163 Added connect_for_modified() utility function to mark the new modified boolean.
4165 (create_page_account_details), (create_page_user_details),
4166 (create_page_incoming), (create_page_outgoing), (on_response),
4167 (modest_account_settings_dialog_init),
4168 (modest_account_settings_dialog_set_account_name):
4169 Only warn about unsaved changes when there are actually unsaved changes.
4171 * src/modest-account-mgr-helpers.c:
4172 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4173 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4174 to get the data from there in future.
4176 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4178 * src/modest-defs.h:
4180 * src/modest-account-mgr-helpers.h:
4181 * src/modest-account-mgr-helpers.c:
4182 Store the security account setting in a single conf key instead of using
4183 the options list, so that the list is left for just the to-be-removed camel hack,
4184 and because gconf_client_set_list() is failing for some reason.
4186 * src/modest-account-mgr.c:
4187 (modest_account_mgr_add_server_account):
4188 * src/maemo/modest-account-settings-dialog.c:
4189 (modest_account_settings_dialog_set_account_name),
4190 (save_configuration): Use the renamed functions.
4193 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4195 * src/widgets/Makefile.am:
4196 * src/widgets/modest-limit-retrieve-combo-box.c:
4197 * src/widgets/modest-limit-retrieve-combo-box.h:
4198 * src/widgets/modest-retrieve-combo-box.c:
4199 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4200 the account settings dialog.
4202 * src/modest-defs.h:
4203 * src/modest-account-mgr-helpers.h:
4204 * src/modest-account-mgr-helpers.c:
4205 (modest_server_account_get_option_secure_auth),
4206 (modest_server_account_set_option_secure_auth):
4207 * src/modest-account-mgr.c:
4208 (modest_account_mgr_add_server_account):
4209 Use the existing AUTH_MECH conf key for the secure-auth setting,
4210 instead of putting it in the list options, because this was actually used already.
4212 * src/maemo/modest-account-settings-dialog.c:
4213 (create_page_account_details),
4214 (modest_account_settings_dialog_set_account_name),
4215 (save_configuration):
4216 * src/maemo/modest-account-settings-dialog.h:
4217 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4218 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4220 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4222 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4223 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4224 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4226 * src/modest-defs.h:
4227 * src/maemo/modest-account-settings-dialog.c:
4228 (create_page_incoming), (on_combo_outgoing_security_changed),
4229 (on_combo_incoming_security_changed), (create_page_outgoing),
4230 (modest_account_settings_dialog_set_account_name),
4231 (save_configuration): Load/Save the port number, and change it when the
4232 security combo changes, to suitable defaults.
4234 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4236 * src/modest-account-mgr.c:
4237 (modest_account_mgr_add_server_account): Set the security and secure-auth
4238 options, and add a comment saying that the other camel-specific options should be
4241 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4243 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4245 * src/modest-tny-account-store.c: (account_list_free),
4246 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4247 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4250 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4252 * src/modest-protocol-info.c:
4253 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4254 is required by our UI spec. Maybe something in our implementation will use this eventually.
4255 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4256 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4257 instead of the previous 0 placeholder.
4259 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4260 secure-auth settings.
4261 * src/modest-account-mgr-helpers.h:
4262 * src/modest-account-mgr-helpers.c:
4263 (modest_server_account_data_get_option_secure_auth),
4264 (modest_server_account_set_option_secure_auth),
4265 (modest_server_account_data_get_option_security),
4266 (modest_server_account_set_option_security): Added this API for getting and setting the security
4267 and secure-auth settings.
4269 * src/maemo/modest-account-settings-dialog.h:
4270 * src/maemo/modest-account-settings-dialog.c:
4271 (modest_account_settings_dialog_finalize), (check_data),
4272 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4273 about changing titles.
4274 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4275 (save_configuration): Save the security and secure-auth settings.
4277 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4278 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4280 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4282 * src/modest-defs.h:
4283 * src/modest-account-mgr.c:
4284 (modest_account_mgr_add_server_account):
4285 Added and used defines for the options key and value pair strings,
4286 that are used so far, though they do not seem to correspond to anything in our
4287 UI specs or ModestProtocol enum.
4289 * src/modest-account-mgr-helpers.h:
4290 * src/modest-account-mgr-helpers.c:
4291 (compare_option_strings_for_name),
4292 (modest_server_account_data_get_option_value),
4293 (modest_server_account_data_get_option_bool),
4294 (modest_account_mgr_get_server_account_option):
4295 Added helper functions for parsing the options GSList.
4297 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4299 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4300 display name is based on the supplied account name.
4301 * src/modest-account-mgr.c:
4302 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4303 with an inefficient, but good-enough, implementation.
4305 * src/maemo/easysetup/modest-easysetup-wizard.c:
4306 (create_page_account_details), (on_before_next), (create_account):
4307 Check for existing display names rather than (non-user-visible) account names, and just
4308 create and set a unique account name at the end.
4310 * src/maemo/modest-account-settings-dialog.c:
4311 (modest_account_settings_dialog_init),
4312 (modest_account_settings_dialog_set_account_name),
4313 (create_page_incoming): Show the display name, instead of the account name.
4314 (on_response): Do some (not all) extra checks, as in the UI spec.
4315 (save_configuration): Save the display name if it was changed.
4317 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4319 * po/en_GB.po: Added needed logical ID and translation.
4320 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4321 (init_view): Made the is-default column clicking work.
4323 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4326 * src/maemo/easysetup/Makefile.am:
4327 * src/maemo/easysetup/modest-easysetup-wizard.c:
4328 (modest_easysetup_wizard_dialog_init):
4329 * src/maemo/easysetup/provider-data-test.keyfile:
4330 * src/maemo/easysetup/provider-data.keyfile:
4331 Moved the provider data file to the new modest-providers-data package and used it from there.
4333 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4335 * src/modest-local-folder-info.c:
4336 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4337 N_() was already used on the static strings, but this just marks it for translation without
4338 using the translation.
4340 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4342 * src/maemo/modest-account-settings-dialog.c:
4343 (create_page_incoming),
4344 (modest_account_settings_dialog_set_account_name):
4345 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4346 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4347 I will do this if nobody else gets there first.
4349 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4351 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4352 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4353 save the security stuff.
4355 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4357 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4358 Set the email address and user fullname, which I now see must be
4361 * src/maemo/modest-account-settings-dialog.h:
4362 * src/maemo/modest-account-settings-dialog.c:
4364 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4365 leave-on-server and authentication.
4366 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4369 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4372 * src/maemo/modest-account-settings-dialog.c:
4373 * src/maemo/modest-account-settings-dialog.h:
4374 Most (but not all) of the widgets are now present as specified by the UI spec.
4375 No changes are yet saved, and some details are not properly shown yet.
4377 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4379 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4381 * src/maemo/Makefile.am:
4382 * src/maemo/modest-account-settings-dialog.c:
4383 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4384 an existing account. Doesn't do much yet.
4386 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4387 Open the accounts settings dialog when Edit is clicked.
4389 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4391 * src/maemo/easysetup/Makefile.am:
4392 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4394 * src/maemo/easysetup/modest-easysetup-wizard.c:
4395 (modest_easysetup_wizard_dialog_init):
4396 Try to get the source directory from the build system,
4397 instead of hard-coding "./" into the source code, when opening our local
4398 copies of the configuration files.
4399 But this still fails when opening the wizard from the Accounts window,
4400 maybe because the working directory seems to change at runtime.
4401 So the wizard will fail the second time unless you copy the files into their
4402 proper locations - see the stdout warnings for the paths.
4404 (create_page_account_details),(on_before_next):
4405 Check for existing non-server accounts instead of server accounts,
4406 so the default account name is useful again, and to prevent trying to
4409 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4410 Show the wizard when New is clicked.
4412 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4413 (init_view): Show the column headers, and show the columns that are
4414 specified in the UI specs. However, something in Maemo's GTK+ prevents
4415 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4416 change the default account. This is despite unsetting the special properties.
4418 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4420 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4421 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4422 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4423 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4424 to make that clearer.
4425 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4427 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4429 * src/maemo/modest-account-view-window.c:
4430 (modest_account_view_window_init),
4431 (modest_account_view_window_new):
4432 Use the same buttons as specified in the
4433 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4434 the existing widgets, which never had a chance of working.
4435 Put the ModestAccountView treeview in a scrolled window.
4436 Do not repeat the initialization in both _init() and _new().
4438 * src/widgets/modest-account-view.c: (update_account_view):
4439 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4440 this widget and window shows no accounts.
4442 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4444 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4446 * src/maemo/easysetup/modest-easysetup-wizard.c:
4447 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4448 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4449 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4452 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4453 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4454 accounts exist yet, as in the UI spec.
4456 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4458 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4460 * src/maemo/Makefile.am:
4461 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4462 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4463 New window for editing connection-specific smtp details.
4464 Not fully implemented.
4466 * src/maemo/modest-connection-specific-smtp-window.c:
4467 (modest_connection_specific_smtp_window_finalize) :
4468 unref the tree model.
4469 (on_button_edit): Show the edit window.
4471 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4473 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4476 * src/maemo/Makefile.am:
4477 * src/maemo/modest-connection-specific-smtp-window.c:
4478 * src/maemo/modest-connection-specific-smtp-window.h:
4479 New window for showing the list of connections, for connection-specific
4480 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4481 * src/maemo/easysetup/modest-easysetup-wizard.c:
4482 (create_page_custom_outgoing): Show the new window when the button is clicked.
4484 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4486 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4487 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4488 * src/maemo/modest-msg-edit-window.c:
4489 (modest_msg_edit_window_insert_image):
4490 * src/modest-conf.c: (modest_conf_key_escape):
4491 * src/modest-mail-operation.c:
4492 (modest_mail_operation_send_new_mail):
4493 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4494 (modest_ui_actions_on_new_account):
4495 * src/widgets/modest-attachment-view.c: (update_filename_request):
4496 * src/widgets/modest-mail-header-view.c:
4497 Corrected warnings that were breaking the build, by commenting out unused variables,
4498 and a function, and by including a header.
4500 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4502 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4503 so we can #ifdef around platform-specific code when necessary.
4504 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4505 to allow this to build for the GNOME platform too.
4507 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4509 * src/maemo/easysetup/modest-easysetup-wizard.c:
4510 Added util_increment_name() and used it in create_page_account_details()
4511 to make sure that the default account name is always a new name.
4513 (modest_easysetup_wizard_dialog_init),
4514 (set_default_custom_servernames): Some minor memory management fixes.
4516 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4520 * src/modest-runtime.c: (init_i18n): Restored the translation
4521 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4522 are defined in config.h, and the translations are installed.
4524 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4525 is defined for translation.
4527 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4529 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4531 * src/maemo/easysetup/modest-easysetup-wizard.c:
4532 (modest_easysetup_wizard_dialog_init):
4533 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4534 Use realistic paths (though they should use $prefix generically) to the
4535 mcc_mapping and provider-data.keyfile files which might work when they
4536 are installed by the future version of the operator-wizard package,
4537 and then fallback to paths in our source code, with an explanatory
4540 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4544 * src/maemo/Makefile.am:
4545 * src/maemo/easysetup/: Added files from the previously-exernal
4546 osso-modest-easysetup.
4547 * src/maemo/modest-main-window-ui.h:
4548 * src/modest-ui-actions.c:
4549 * src/modest-ui-actions.h:
4550 Added modest_ui_actions_on_new_account() as a signal handler for the
4551 New Account menu item. It shows the easysetup wizard.
4552 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob