1 2007-06-13 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-init.c: (modest_init_init_core),
4 (modest_init_local_folders): Fixed compilation errors.
6 2007-06-13 Murray Cumming <murrayc@murrayc.com>
8 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
9 Remove unnecessary lib/include, though it is good in principle when needed.
11 * src/modest-init.c: (modest_init_one_local_folder),
12 (modest_init_local_folders):
13 * src/modest-init.h: Initialize the .modest library for memory cards,
14 instead of just doing nothing for them. This should allow us to create
15 folders there, fixing projects.maemo.org bug NB#59297.
17 2007-06-13 Murray Cumming <murrayc@murrayc.com>
19 * libmodest-dbus-client/libmodest-dbus-client.c:
20 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
21 (libmodest_dbus_client_compose_mail),
22 (libmodest_dbus_client_open_message),
23 (libmodest_dbus_client_send_and_receive),
24 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
26 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
27 (on_idle_open_message), (modest_dbus_req_handler),
28 (search_result_to_message), (modest_dbus_req_filter):
29 * src/modest-search.c: (add_hit), (modest_search_folder),
30 (modest_search_all_accounts): Improved debug messages.
32 * tests/dbus_api/test_open_message.c: (main): Improved comments.
34 * src/modest-tny-account-store.c:
35 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
38 2007-06-13 Murray Cumming <murrayc@murrayc.com>
41 2007-06-12 Murray Cumming <murrayc@murrayc.com>
43 * src/modest-tny-account-store.c: (get_server_accounts):
44 Call modest_tny_local_folders_account_add_merged_outbox_folders()
45 even when there are no accounts, so that the Outbox folder is always
46 visible. This fixes projects.maemo.org bug NB#60158.
48 2007-06-12 Murray Cumming <murrayc@murrayc.com>
50 * src/maemo/modest-main-window.c: (create_details_widget):
51 Use the mcen_va_never logical ID.
53 2007-06-12 Murray Cumming <murrayc@murrayc.com>
55 * src/dbus_api/modest-dbus-api.h:
56 * src/dbus_api/modest-dbus-callbacks.c:
57 (on_idle_open_default_inbox), (on_open_default_inbox),
58 (modest_dbus_req_handler):
59 Added a new OpenDefaultInbox method.
61 * libmodest-dbus-client/libmodest-dbus-client.h:
62 * libmodest-dbus-client/libmodest-dbus-client.c:
63 Added libmodest_dbus_client_open_default_inbox() to call the new
64 dbus method. This should be useful to projects.maemo.org bug NB#57214,
65 though it should maybe be used by a new osso-email-interface function.
67 * tests/dbus_api/Makefile.am:
68 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
71 2007-06-12 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
74 NULL, so that the signals get all the keys. This should not actually
75 change any behaviour because we currently update everything when anything
78 2007-06-12 Murray Cumming <murrayc@murrayc.com>
80 * src/widgets/modest-folder-view.c: (text_cell_data),
81 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
82 (find_inbox_iter): If tinymail tells us that the folder is
83 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
84 This causes the inbox to be selected at startup, fixing part of
85 projects.maemo.org bug NB#56305.
87 * src/modest-ui-dimming-rules.c:
88 (modest_ui_dimming_rules_on_tools_smtp_servers):
89 * src/modest-ui-dimming-rules.h: Added a callback function to dim
90 the SMTP servers menu item.
91 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
92 that the SMTP Servers menu item is dimmed when there are no accounts,
93 as a future version of the UI spec will require. This fixes
94 projects.maemo.org bug NB#56305.
96 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
98 * src/maemo/modest-maemo-utils.c:
99 (modest_maemo_utils_get_supported_secure_authentication_methods):
100 Added label to dialog instead of unreadable title
102 * src/maemo/modest-main-window.c: (sync_accounts_cb),
103 (modest_main_window_new):
104 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
107 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
108 * src/modest-account-mgr.h:
109 Added method to avoid code duplication
111 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
112 (modest_ui_actions_on_send_receive):
113 Use modest_account_mgr_has_accounts
115 2007-06-11 Murray Cumming <murrayc@murrayc.com>
117 * src/maemo/easysetup/modest-presets.c:
118 (modest_presets_get_info_server_security): Do not report secure auth
120 * src/modest-protocol-info.c: Use the defines for the gconf key names
121 for secure authentication. This was not working because we were writing
122 Password and reading password, and the check was case sensitive.
123 With this, gmail now works for receiving and sending when created via
126 2007-06-11 Murray Cumming <murrayc@murrayc.com>
128 * src/maemo/easysetup/modest-presets.c:
129 (modest_presets_get_info_server_security): Correct the key name for
130 SecureSmtp, because it seems to be case-sensitive.
131 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
132 Do not try to get the 0th notebook page if there are 0 pages, to
135 2007-06-11 Murray Cumming <murrayc@murrayc.com>
137 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
138 Prevent use of the new notification feature for now, because it currently
139 shows one dialog for each new email, which is annoying.
141 2007-06-11 Murray Cumming <murrayc@murrayc.com>
143 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
144 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
145 when no country was selected, so that we show the global ones.
146 * src/maemo/easysetup/modest-presets.c:
147 (modest_presets_get_providers): Return only the global providers, not
148 all providers when mmc=0 was requested.
150 2007-06-11 Murray Cumming <murrayc@murrayc.com>
152 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
153 (easysetup_provider_combo_box_fill): Remove debug code that showed the
154 provider ID in the combo.
156 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
157 Do not show the page numbers, because it would be confusing when we add
158 the 2 extra pages for the custom setup, when the user chooses the "Other"
159 provider. This fixes projects.maemo.org bug NB#59028
161 * src/modest-init.c: (modest_init_init_core),
162 (modest_init_local_folders):
164 * src/modest-tny-account.c:
165 (modest_tny_account_new_for_local_folders): Do not create default folders
166 for the memory card. This should fix projects.maemo.org bug NB#59328.
168 2007-06-11 Murray Cumming <murrayc@murrayc.com>
170 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
171 Free the changed_conf_keys string items. They are already freed in the
172 idle handler if that runs first.
174 2007-06-11 Murray Cumming <murrayc@murrayc.com>
176 * src/modest-ui-actions.c:
177 (modest_ui_actions_on_password_requested): Check that the server name
178 is not NULL, because I just saw a password dialog with (null) as the
181 * src/modest-tny-folder.[h|c]: Added
182 modest_tny_folder_is_memory_card_folder().
183 * src/modest-ui-dimming-rules.c:
184 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
185 menu item for memory cards, as per the UI spec (section 7.4). This should
186 fix projects.maemo.org bug NB#59297.
188 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
190 * src/maemo/modest-main-window.c: (sync_accounts_cb):
191 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
192 is another problem with the code, see Murray's comment at line 772)
194 2007-06-08 Murray Cumming <murrayc@murrayc.com>
196 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
197 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
198 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
199 (load_from_file), (easysetup_country_combo_box_init),
200 (easysetup_country_combo_box_get_active_country_ids),
201 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
202 instead of just one ID, to avoid duplicate country names in the UI.
204 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
205 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
206 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
207 a single ID, avoiding duplicate providers.
208 * src/maemo/easysetup/modest-easysetup-wizard.c:
209 (on_combo_account_country): Adapt to use a list.
211 2007-06-08 Murray Cumming <murrayc@murrayc.com>
213 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
214 keys changed in the last X seconds.
216 * src/modest-account-mgr.h:
217 * src/modest-account-mgr.c: (on_timeout_notify_changes),
218 (on_key_change), (modest_account_mgr_class_init),
219 (modest_account_mgr_init), (modest_account_mgr_finalize):
220 As the keys are changed, save them in a GSList* and signal that GSList*
221 further every X seconds, to batch changes, to allow us to do just one
222 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
223 bug NB#56941 and other (UI-blocking) delays when changing account settings.
225 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
226 changed signal signature.
228 * src/modest-conf.c: (modest_conf_set_list),
229 (modest_conf_on_change): Reenable notification.
231 (modest_conf_maemo_fake_on_change): Comment out the hack that
232 notified immediately instead of asynchronously.
234 * src/widgets/modest-account-view.h:
235 * src/widgets/modest-account-view.c:
236 (update_account_view): Select the previously-selected account ID,
237 if possible. This fixes projects.maemo.org bug NB#56933.
239 (on_account_changed), (on_account_removed),
240 (modest_account_view_select_account):
242 Remove the block/unblock functions
243 because they were not useful.
245 * src/maemo/modest-account-view-window.c:
246 (on_delete_button_clicked), (on_edit_button_clicked),
247 (on_new_button_clicked): Remove the use of the non-working block/unblock.
249 2007-06-08 Murray Cumming <murrayc@murrayc.com>
251 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
252 Improve the error dialog to show Incorrect Account Settings, which seems
253 clearer, and say that the internal error message (to be removed from the
254 dialog later) is often misleading.
255 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
257 * src/modest-tny-account.c:
258 (modest_tny_account_new_from_server_account): Uncomment the printf of the
259 URL because this is so useful for debugging on the device.
261 * src/widgets/modest-serversecurity-combo-box.c:
262 (modest_serversecurity_combo_box_fill): Correct a logical ID.
264 2007-06-08 Murray Cumming <murrayc@murrayc.com>
266 * src/modest-mail-operation.c:
267 (modest_mail_operation_send_new_mail):
268 Added a comment about a nasty but apparently harmless message. Details
269 added to the wiki g_warnings() page.
271 2007-06-08 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
274 (modest_tny_send_queue_class_init):
275 Do not use the priv struct because it is empty, to avoid g_warnings
276 about a non-existant priv struct.
278 * src/modest-tny-account-store.c:
279 (modest_tny_account_store_get_server_account),
280 (modest_tny_account_store_get_transport_account_for_open_connection
281 ): Do not try to get transport server accounts for local folders,
282 because they don't have any. This avoids a g_warning().
284 * src/maemo/modest-main-window.c:
285 (modest_main_window_notify_send_receive_initied),
286 (on_configuration_key_changed):
287 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
289 * src/modest-mail-operation.c:
290 (modest_mail_operation_update_account):
291 * src/modest-tny-account-store.h:
292 * src/modest-tny-account.c:
293 (modest_tny_account_get_special_folder),
294 (modest_tny_account_new_for_local_folders),
295 (modest_tny_account_new_for_per_account_local_outbox_folder):
296 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
297 * src/modest-tny-local-folders-account.c:
298 (add_account_folders_to_merged_folder):
299 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
300 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
301 (modest_ui_actions_on_send):
302 * src/widgets/modest-folder-view.c: (update_model):
303 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
304 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
305 modest_tny_account_store_get_tny_account_by_account() to
306 modest_tny_account_store_get_server_account() to make the code clearer.
308 2007-06-07 Marcus Bauer <marcusb@openismus.com>
310 * src/dbus_api/modest-dbus-api.h:
311 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
312 * src/maemo/modest-msg-edit-window.c:
313 (modest_msg_edit_window_attach_file_noninteractive):
314 added g_warning in case the file to be attached does not exist
315 * tests/dbus_api/test_compose_mail.c: (main):
316 removed obsolete comment, added generic files as test case
318 2007-06-07 Murray Cumming <murrayc@murrayc.com>
320 * src/modest-tny-account-store.c: (get_server_accounts):
321 Create the local folders account only once, not once for each outbox, and
322 not only when there are some outboxes.
324 2007-06-07 Murray Cumming <murrayc@murrayc.com>
326 * src/widgets/modest-folder-view.c: (update_model): Comment out some
327 code that is causing a crash at startup. Sergio says that he is fixing this.
329 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
331 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
332 * src/maemo/modest-account-settings-dialog.c:
333 (create_page_outgoing),
334 (modest_account_settings_dialog_set_account_name),
335 (save_configuration):
336 - Fixed handling of the "Use secure authentication" toggle to comply with
337 the ui specification. See also projects.maemo.org bug NB#58400
339 - Restore the Secure connection setting combo correctly when loading
342 * src/maemo/modest-maemo-utils.c:
343 (on_camel_account_get_supported_secure_authentication),
344 (modest_maemo_utils_get_supported_secure_authentication_methods):
345 Fixed a crasher if operation is canceled
347 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
348 (modest_protocol_info_auth_is_secure):
349 * src/modest-protocol-info.h:
351 Added two new methods to determine if a protocol/auth method is secure/encrypted in
352 the sense of the "Use secure authentication" toggle.
354 2007-06-07 Murray Cumming <murrayc@murrayc.com>
356 * src/modest-tny-account-store.h:
357 * src/modest-tny-account-store.c:
358 Added modest_tny_account_store_get_local_folders_account().
360 * src/modest-tny-folder.h:
361 * src/modest-tny-folder.c:
362 (modest_tny_folder_get_account):
363 Added this replacement for tny_folder_get_account() which returns
364 the local-folders account for TnyMergeFolders, to avoid the
365 warning about the unimplemented get_account_func() vfunc().
367 (modest_tny_folder_get_rules),
368 * src/modest-ui-actions.c:
369 (modest_ui_actions_on_folder_selection_changed):
370 * src/modest-mail-operation.c:
371 (modest_mail_operation_remove_folder),
372 (modest_mail_operation_xfer_folder),
373 (modest_mail_operation_rename_folder),
374 (modest_mail_operation_get_msg),
375 (modest_mail_operation_get_msgs_full),
376 (modest_mail_operation_remove_msg),
377 (modest_mail_operation_xfer_msgs),
378 (modest_mail_operation_refresh_folder):
379 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
381 2007-06-07 Murray Cumming <murrayc@murrayc.com>
383 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
384 (modest_server_account_set_security):
385 * src/modest-defs.h: Add comments explaining that our
386 UI spec means TLS when it says Normal, so these do not look like errors.
388 * src/modest-tny-account.c:
389 (modest_tny_account_new_from_server_account): Use the new tinymail
390 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
391 for TLS. This should fix projects.maemo.org bug NB#58460.
393 2007-06-06 Murray Cumming <murrayc@murrayc.com>
395 * src/maemo/easysetup/modest-easysetup-wizard.c:
396 (create_account): Correct the position of the gconf sanity check warning.
397 (on_button_edit_advanced_settings): Show the dialog immediately, instead
398 of using the g_idle_add() hack, because this does not seem to be necessary
399 on osso 1.1. It might even work on Maemo Bora if the problems were actually
400 caused by something other than maemo's gconf.
401 This fixes projects.maemo.org bug #59022.
403 2007-06-06 Murray Cumming <murrayc@murrayc.com>
405 * src/modest-account-mgr-helpers.c:
406 (modest_account_mgr_get_default_account): Do not check that the account
407 exists if there is no default account (NULL), to fix a runtime warning.
409 2007-06-06 Murray Cumming <murrayc@murrayc.com>
411 * src/widgets/modest-folder-view.c: (update_model):
412 Do not unref the treemodel before we have finished with it.
413 This prevents a valgrind warning and an occasional crash at startup.
415 2007-06-06 Marcus Bauer <marcusb@openismus.com>
417 * libmodest-dbus-client/libmodest-dbus-client.h:
418 added libmodest_dbus_client_compose_mail()
419 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
421 added functions needed for SendAsMail() functionality
422 * src/maemo/modest-msg-edit-window.c:
423 (modest_msg_edit_window_attach_file_noninteractive):
424 non interactively attaching files to message edit window
425 * src/widgets/modest-msg-edit-window.h:
426 * tests/dbus_api/Makefile.am:
427 added test_compose_mail.c
428 * tests/dbus_api/test_compose_mail.c: (main):
430 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
432 * src/modest-account-view.c:
433 Fixed bug projects.maemo.org bug NB#59307
435 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
437 * src/maemo/easysetup/modest-easysetup-wizard.c:
438 (get_serverport_incoming), (on_before_next), (create_account):
439 * src/maemo/modest-account-settings-dialog.c:
440 (modest_account_settings_dialog_set_account_name):
441 * src/maemo/modest-maemo-utils.c:
442 (on_camel_account_get_supported_secure_authentication_status),
443 (on_camel_account_get_supported_secure_authentication),
444 (on_secure_auth_cancel),
445 (modest_maemo_utils_get_supported_secure_authentication_methods):
447 Implemented security authentication for settings and easysetup.
449 2007-06-05 Murray Cumming <murrayc@murrayc.com>
451 * src/maemo/modest-main-window.c: (create_details_widget):
452 Show the total size for memory card accounts too, instead of showing
453 the name again. Fixes bug projects.maemo.org bug NB#59307.
455 2007-06-05 Murray Cumming <murrayc@murrayc.com>
458 * src/modest-tny-simple-folder-store.c:
459 * src/modest-tny-simple-folder-store.h: Removed.
461 * src/modest-tny-local-folders-account.h
462 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
463 for the local-folders maildir, with an extra TnyMergedFolder containing
464 the folders of the per-account outbox store accounts.
465 * src/modest-tny-account-store.c: (get_server_accounts):
466 Add the outboxes to the special local folders account after creating it.
468 * src/modest-tny-account.c:
469 (modest_tny_account_new_for_local_folders): Create the derived
470 account when creating the main local-folders account.
472 * src/maemo/modest-main-window.c: (create_details_widget),
473 (modest_main_window_set_contents_style):
474 Adapted to the use of the derived account instead of the folder store.
476 * src/modest-ui-actions.c:
477 (modest_ui_actions_on_folder_selection_changed):
478 * src/modest-ui-dimming-rules.c:
479 (modest_ui_dimming_rules_on_new_folder):
480 * src/widgets/modest-folder-view.c: (text_cell_data),
481 (icon_cell_data), (filter_row), (update_model),
482 (get_cmp_rows_type_pos):
485 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
486 Do not get the priv struct, because no priv struct has been set,
487 to avoid a runtime warning.
489 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
490 #ifelse with #else, to fix a warning, to fix the build.
493 2007-06-05 Christian Kellner <ckellner@openismus.com>
495 * libmodest-dbus-client/libmodest-dbus-client.c:
496 Fix small typo in doc (why do you always see them
497 AFTER committing stuff?)
500 2007-06-05 Christian Kellner <ckellner@openismus.com>
502 * libmodest-dbus-client/libmodest-dbus-client.c:
503 (libmodest_dbus_client_search):
504 Initialize hit list with NULL. Also set folder list
505 to "" if NULL was supplied.
508 2007-06-03 Christian Kellner <ckellner@openismus.com>
510 * libmodest-dbus-client/libmodest-dbus-client.c:
511 (modest_search_hit_list_free):
512 Make it save to call it with NULL.
514 * src/dbus_api/modest-dbus-callbacks.c:
515 * src/modest-search.c:
516 Return full ModestSearchHits as the search result list not TnyHeader
517 since can't be around withouth the correspoding TnyFolder.
519 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
521 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
522 Added currently commented code to check for secure auth
524 * src/maemo/modest-account-settings-dialog.c: (on_response),
525 (save_configuration), (show_ok):
526 Fixed projects.maemo.org bugs NB #59248 and #59251
528 * src/maemo/modest-maemo-utils.c:
529 (on_camel_account_get_supported_secure_authentication_status),
530 (on_camel_account_get_supported_secure_authentication),
531 (modest_maemo_utils_get_supported_secure_authentication_methods):
532 * src/maemo/modest-maemo-utils.h:
533 Moved get_supported_secure_authentication() method here to be able
534 to use it from easysetup wizard.
536 * src/modest-pair.c: (on_pair_compare_as_string):
537 Should compare string with first part of pair and not
538 strcmp pairs which will crash.
540 * src/modest-protocol-info.c:
541 (modest_protocol_info_protocol_is_store):
542 * src/modest-protocol-info.h:
543 Added modest_protocol_info_get_auth_protocol_name()
545 2007-06-03 Armin Burgmeier <armin@openismus.com>
547 * src/modest-mail-operation.c:
548 (modest_mail_operation_get_msgs_full): Set priv->account also when
549 only retrieving a single message. This avoids a crash when canceling
552 (modest_mail_operation_notify_end): Do not explicitely remove the
553 operation from the queue but only emit the progress_changed signal.
554 The queue itself listens to that signal to remove the operation when
555 it is finished. This reduces coupling and removes a potential deadlock
556 when modest_mail_operation_notify_end() is called from the queue
557 itself. If that is a problem performance-wise, I would suggest to
558 implement a status-changed signal or something.
560 * src/modest-mail-operation-queue.c: Make sure to never call a
561 function from another file while the queue is locked. This (hopefully)
562 fixes another deadlock when exiting the application while retrieving
565 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
567 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
568 Fixed build if libogs is not available
570 2007-06-03 Christian Kellner <ckellner@openismus.com>
572 * libmodest-dbus-client/libmodest-dbus-client.h:
573 * libmodest-dbus-client/libmodest-dbus-client.c:
574 (libmodest_dbus_client_delete_message):
575 Implement deletion of messages (Client side).
577 (modest_search_hit_free),
578 (modest_search_hit_list_free):
579 Utility functions to free the result hits.
581 * src/dbus_api/modest-dbus-api.h:
582 * src/dbus_api/modest-dbus-callbacks.c:
584 (modest_dbus_req_handler):
585 Implement deletion of messages (Server side).
587 * tests/dbus_api/test_search.c: (main):
590 * tests/dbus_api/Makefile.am:
591 * tests/dbus_api/test_delete_message:
592 Add little test for the message deletion logic
594 2007-06-03 Armin Burgmeier <armin@openismus.com>
596 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
597 when the operation queue was not empty. projects.maemo.org bug
600 2007-06-03 Armin Burgmeier <armin@openismus.com>
602 * src/widgets/modest-account-view.c
603 (on_account_default_toggled): Toggle default account column
604 explicitely instead of waiting for gconf notification (which is
605 currently ignored). This should fix projects.maemo.org bug NB#56910
606 for now. It should probably be removed when gconf notifications are
609 2007-06-03 Christian Kellner <ckellner@openismus.com>
611 * libmodest-dbus-client/libmodest-dbus-client.c:
612 Removed debugging spew.
614 * src/dbus_api/modest-dbus-callbacks.c:
615 Added debugging info.
617 * src/modest-search.c:
618 (modest_search_all_accounts):
619 Use tny_account_store_get_accounts () on the account store
620 to get all accounts which is the way to get all accounts.
622 * tests/dbus_api/test_search.c: (main):
623 Make it possible to supply the search term on the command line.
625 2007-06-03 Christian Kellner <ckellner@openismus.com>
627 * libmodest-dbus-client/libmodest-dbus-client.c:
628 * libmodest-dbus-client/libmodest-dbus-client.h:
629 Implement searching for mesages over raw dbus. (Client side)
631 * src/dbus_api/Makefile.am:
632 * src/dbus_api/modest-dbus-api.h:
633 * src/dbus_api/modest-dbus-callbacks.c:
634 * src/dbus_api/modest-dbus-callbacks.h:
635 Search framework (Server side). Also implement on_idle_open_message().
637 * src/maemo/modest-platform.c: (modest_platform_init):
638 Prepare for raw dbus/osso rpc interaction.
640 * src/modest-search.h:
641 Changed minsize from unspecific guint to guint32.
643 * src/modest-search.c:
645 Added strange hack which magically made tnymail work.
647 (modest_search_folder),
648 (modest_search_account),
649 (modest_search_all_accounts):
650 Implement helper functions to search all accounts, specific account
653 * tests/dbus_api/Makefile.am:
654 * tests/dbus_api/test_open_message.c:
655 Read url to open from commandline.
657 * tests/dbus_api/test_search.c:
658 Implement small test for dbus search stuff
660 2007-06-02 Armin Burgmeier <armin@openismus.com>
662 * src/maemo/modest-account-settings-dialog.c: Changed window title to
663 include account type and account title. This fixes projects.maemo.org
666 * src/maemo/modest-account-view-window.c: Set a title for the window.
668 2007-06-02 Armin Burgmeier <armin@openismus.com>
670 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
671 incoming and outgoing server name based on email address and server
672 types as long as the names have not been edited manually. This fixes
673 projects.maemo.org bug NB#58671.
675 2007-06-02 Armin Burgmeier <armin@openismus.com>
677 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
678 server type cannot be changed in future to the incoming details page
679 when creating an account. This fixes projects.maemo.org bug NB#59029.
681 2007-06-02 Armin Burgmeier <armin@openismus.com>
683 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
684 and assigned max width chars so that they wrap instead of being
685 truncated. Fixes projects.maemo.org bug NB#56126.
687 2007-06-02 Armin Burgmeier <armin@openismus.com>
689 * src/maemo/modest-connection-specific-smtp-window.c: Add an
690 introductory note to the connection specific smtp servers dialog, as
691 section 8.12 of the email UI specification requires. This fixes
692 projects.maemo.org bug NB#59212.
694 2007-06-01 Murray Cumming <murrayc@murrayc.com>
696 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
697 Check for running mail operations, and offer to cancel them, as per the UI
698 spec. This fixes projects.maemo.org bug NB#59041 .
699 However, I suspect that tinymail may still use the network connection
700 in ways that we cannot detect or cancel. But it should at least adapt to
703 2007-06-01 Murray Cumming <murrayc@murrayc.com>
705 * src/modest-tny-account-store.c: (recreate_all_accounts),
706 (get_cached_accounts), (get_server_accounts): Do more sensible
707 ref-counting of the temporarily-cached outbox accounts list. This seems
708 to fix a crash when entering the password when the password was wrong.
710 2007-06-01 Murray Cumming <murrayc@murrayc.com>
712 * src/gnome/modest-main-window.c: (connect_signals):
713 * src/modest-tny-account-store.c: (get_password),
714 (modest_tny_account_store_alert): Added comments and clues and
715 commented-out code about how we currently fail to deal with connection
716 errors and wrong passwords, and how we should.
718 2007-06-01 Murray Cumming <murrayc@murrayc.com>
720 * src/widgets/modest-retrieve-combo-box.c:
721 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
722 This fixes projects.maemo.org bug NB#58472 .
724 2007-06-01 Murray Cumming <murrayc@murrayc.com>
726 * src/maemo/easysetup/modest-easysetup-wizard.c:
727 (create_page_complete_easysetup):
728 (create_page_complete_custom): Correct the last commit,
729 putting the correct sentences in the correct pages.
731 2007-06-01 Murray Cumming <murrayc@murrayc.com>
733 * src/maemo/easysetup/modest-easysetup-wizard.c:
734 (create_page_complete_custom): Show the second sentence of text
735 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
738 2007-06-01 Murray Cumming <murrayc@murrayc.com>
740 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
741 Set the leave-on-server conf key by default. This fixes
742 projects.maemo.org bug NB#59258 .
744 2007-06-01 Murray Cumming <murrayc@murrayc.com>
746 * src/maemo/modest-account-view-window.c:
747 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
748 logical ID for the confirmation messages. Fixed projects.maemo.org bug
751 2007-06-01 Murray Cumming <murrayc@murrayc.com>
753 * src/maemo/easysetup/modest-easysetup-wizard.c:
754 (create_caption_new_with_asterisk):
755 * src/maemo/modest-account-settings-dialog.c:
756 (create_caption_new_with_asterisk):
757 Uncomment the code to add the asterisk, because they are no longer in the
758 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
759 (update_incoming_server_title): Add an asterisk here too.
761 2007-06-01 Murray Cumming <murrayc@murrayc.com>
763 * src/maemo/modest-maemo-global-settings-dialog.c:
764 (current_connection): Check that we are even connected before trying to
765 get the current connection name, to prevent a warning.
767 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
768 Change the comments because tny_maemo_conic_device_connect() is now meant to
770 * src/modest-mail-operation.c:
771 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
772 make sure we have a connection and fail if we can't connect.
774 2007-05-31 Murray Cumming <murrayc@murrayc.com>
776 * src/maemo/modest-main-window.c:
777 (on_account_store_connecting_finished): Do not try to get the
778 connection ID if we are not really connected. I am surprised that
779 this signal handler is called when we are not connected.
781 2007-05-31 Murray Cumming <murrayc@murrayc.com>
783 * src/modest-error.h:
784 * src/modest-ui-actions.c:
785 (modest_ui_actions_get_msgs_full_error_handler):
786 Renamed an enum, added comments, added an enum
787 for retrieve-limit errors.
789 * src/modest-mail-operation.c: (foreach_add_item),
790 (internal_folder_observer_update), (update_account_thread),
791 (modest_mail_operation_get_msgs_full):
792 (modest_mail_operation_update_account),
793 Added comments about how this works, and some code that should
794 (but does not) check the retrieve-limit. See the TODO comment.
796 2007-05-31 Murray Cumming <murrayc@murrayc.com>
798 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
799 Initialize help_id to fix the build. Warnings are good.
801 2007-05-31 Murray Cumming <murrayc@murrayc.com>
803 * src/widgets/modest-hbox-cell-renderer.c:
804 (modest_hbox_cell_renderer_append):
805 * src/widgets/modest-vbox-cell-renderer.c:
806 (modest_vbox_cell_renderer_append):
807 Fix the last commit by doing an extra ref.
809 2007-05-31 Murray Cumming <murrayc@murrayc.com>
811 * src/widgets/modest-hbox-cell-renderer.c:
812 (modest_hbox_cell_renderer_append):
813 * src/widgets/modest-vbox-cell-renderer.c:
814 (modest_vbox_cell_renderer_append):
815 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
816 to fix the build with Maemo Bora.
817 However, there seems to be a remaining crash, probably due to reference
820 2007-05-30 Murray Cumming <murrayc@murrayc.com>
822 * src/modest-tny-account.c:
823 (modest_tny_account_new_for_local_folders):
824 Use hildon_file_system_info_async_new() to get a better name for
825 the memory card account, setting it as the account name.
826 The timing seems to work, but this is probably
827 not the best place to do this. See the TODO comment.
828 * src/maemo/modest-main-window.c: (create_details_widget):
829 * src/widgets/modest-folder-view.c: (text_cell_data):
830 Use the tny account name instead of hardcoding a name.
832 2007-05-30 Christian Kellner <ckellner@openismus.com>
834 * src/modest-search.c: (modest_search):
835 Correctly set part_search_func even if we have already parsed
836 the query and thus a valid OgsTextSearcher object.
838 2007-05-30 Christian Kellner <ckellner@openismus.com>
841 Search and check for libogs.
844 Incooparte the ogs build env.
846 * src/modest-mime-part-search-stream.c:
847 * src/modest-mime-part-search-stream.h:
848 Removed since we do the real searching now in modest-search.c.
850 * src/modest-search.c:
851 * src/modest-search.h:
852 Implement support for ogs. We use that if available and requested
853 and fall back to modest_text_utils_utf8_strcmp (). The search logic
854 should now handle the corner case when the search term is spread
855 across multiple reads.
856 Also the logic in modest_search () was corrected to search all
857 requested fields until one is found.
859 2007-05-30 Murray Cumming <murrayc@murrayc.com>
861 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
864 * src/modest-init.c: Made modest_init_local_folders() take a
865 path and be public so we can iniitialize maildir folders on
868 * src/modest-local-folder-info.h:
869 * src/modest-local-folder-info.c:
870 (modest_local_folder_info_get_maildir_path): Add a path parameter.
872 * src/modest-tny-account.c:
873 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
874 still means the standard local-folders path on the local volume.
876 * src/modest-tny-account-store.c:
877 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
878 signal so we can detect mount/unmount of the MMC1 card, and do an update of
879 all accounts when that happens.
880 (get_server_accounts): If the MMC1 card is mounted, create a store account for
881 this too, so it shows up in the treeview.
883 2007-05-28 Murray Cumming <murrayc@murrayc.com>
885 * src/maemo/modest-maemo-global-settings-dialog.c:
886 (current_connection):
887 * src/widgets/modest-global-settings-dialog.c:
888 (current_connection_default):
889 Use the enum values instead of 0, 1 and -1,
890 to make the code clearer.
892 * src/modest-account-mgr-helpers.c:
893 (modest_account_mgr_get_connection_specific_smtp): Make this code
896 * src/modest-runtime.h:
897 * src/modest-runtime.c:
898 Added modest_runtime_remove_all_send_queues().
899 * src/maemo/modest-main-window.c:
900 (on_account_store_connecting_finished): Recreate the send queues,
901 using the appropriate transport accounts for this new connection.
902 Some futher adapting might be needed if the old send queues are not
903 automatically stopped at this point.
905 * src/modest-tny-account-store.c: (get_server_accounts):
906 Create the connection-specific transport accounts, so that they can
907 be found later by their ID.
909 * src/modest-tny-account.h:
910 * src/modest-tny-account.c:
911 Added modest_tny_account_new_from_server_account_name().
912 modest_tny_account_new_from_server_account(): Do not create the
913 send queues here, because they will be
914 recreated anyway when the connection changes for the first time.
916 2007-05-28 Murray Cumming <murrayc@murrayc.com>
918 * src/modest-local-folder-info.h:
919 * src/modest-local-folder-info.c:
920 (modest_per_account_local_outbox_folder_info_get_maildir_path),
921 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
922 tbox_folder): Take a modest account name instead of a server TnyAccount,
923 so we can have per-modest-account rather than per-transport-account
925 We must make sure that we change or recreate the exisitng send queues
926 when the connection changes for connection-specific transport accounts.
928 * src/modest-tny-account-store.c:
929 (create_per_account_local_outbox_folders): Create outboxed per modest
930 account, not per transport account.
932 * src/modest-tny-account.h:
933 * src/modest-tny-account.c:
934 (modest_tny_account_get_special_folder): For outboxes, get the
935 parent modest account name. The account is ignored for other folders.
936 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
937 modest account name rather than a server TnyAccount.
939 2007-05-25 Murray Cumming <murrayc@murrayc.com>
941 * src/modest-tny-account.c:
942 (modest_tny_account_new_from_server_account):
943 Call modest_runtime_get_send_queue() immediately after creating transport
944 accounts, so that they start trying to send email from the outbox as soon
945 as possible at startup. This is probably what we want.
947 * src/modest-mail-operation.c: (update_account_thread):
948 * src/modest-runtime.c: (modest_runtime_get_send_queue):
949 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
950 * src/modest-tny-send-queue.h:
951 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
952 (modest_ui_actions_on_send):
953 Added comments about how sending works, though it needs some more work.
955 2007-05-25 Murray Cumming <murrayc@murrayc.com>
957 * src/modest-tny-account.c:
958 (modest_tny_account_get_special_folder): Add TODO because this fails when
960 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
961 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
962 Do not try to show this window when there is no active account. The UI
963 specs does not tell us what to do in this case.
965 2007-05-24 Murray Cumming <murrayc@murrayc.com>
969 * src/maemo/Makefile.am:
970 * src/widgets/Makefile.am: Some dist fixes.
972 2007-05-24 Murray Cumming <murrayc@murrayc.com>
974 * src/maemo/modest-connection-specific-smtp-window.c:
975 (on_button_edit): Make the code clearer, to prevent a double free.
977 2007-05-24 Murray Cumming <murrayc@murrayc.com>
979 * src/maemo/modest-account-settings-dialog.c:
980 (modest_account_settings_dialog_set_account_name),
981 Check the connection-specific smtp servers checkbox if there are any.
983 * src/maemo/modest-connection-specific-smtp-edit-window.c:
984 (modest_connection_specific_smtp_edit_window_init):
985 Start with a suitable port number.
987 * src/modest-account-mgr-helpers.h:
988 * src/modest-account-mgr-helpers.c: Added
989 modest_account_mgr_get_has_connection_specific_smtp().
991 (modest_account_mgr_set_connection_specific_smtp),
992 (modest_account_mgr_remove_connection_specific_smtp),
993 (modest_account_mgr_get_has_connection_specific_smtp),
994 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
995 connection-specific smtp server accounts in the account, rather than
996 the server account conf dir.
998 This fixes bug projects.maemo.org bug NB#58263 .
1000 * src/modest-tny-account-store.c:
1001 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1002 if there are no server accounts yet, to prevent an infinite loop when there
1003 are no accounts. Document that one must be called before the other.
1005 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1007 * src/modest-account-mgr-helpers.c:
1008 (modest_account_mgr_get_default_account): Make sure that at least
1009 one account is always the default, if there are any enabled accounts.
1010 This is just a sanity check that shouldn't be necessary.
1012 * src/modest-account-mgr-priv.c:
1013 (_modest_account_mgr_account_from_key): Unescape the conf key to
1014 get the real account name. For instance, this is an issue if a space
1015 was in the account name, which can happen because the account name
1016 is generated from the display name.
1017 (_modest_account_mgr_get_account_keyname): Always escape the
1019 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1020 Unescape the conf keys to get the real account names.
1022 For instance, previously the is-default radio button in the accounts
1023 list was not checked for any accounts at first. This fixes that,
1024 and might fix several similar bugs.
1026 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1028 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1029 Removed some debug printfs.
1031 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1033 Modest on-disk outbox directories are now here, for instance:
1034 $HOME/.modest/outboxes/<account-id-1>/outbox
1035 $HOME/.modest/outboxes/<account-id-2>/outbox
1037 $HOME/.modest/local-folders/outbox
1038 so we can have a separate outbox for each account.
1039 But they are shown as one outbox in the GtkTreeView, by using a
1040 TnyMergeFolder in a ModestTnySimpleFolderStore.
1043 * src/modest-tny-simple-folder-store.c:
1044 * src/modest-tny-simple-folder-store.h:
1045 Added ModestTnySimpleFolderStore, used to contain folders from
1046 other folder stores, such as other accounts.
1048 * src/modest-tny-outbox-account.h:
1049 * src/modest-tny-outbox-account.c:
1050 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1051 used for the per-account local outbox folders.
1053 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1054 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1055 only use this (internally) now for the non-outbox local folders.
1057 * src/modest-init.h:
1058 * src/modest-init.c: Added modest_init_one_local_folder(), for
1059 setting up the directory structure for each local folder.
1061 * src/modest-local-folder-info.c:
1062 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1063 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1065 * src/modest-local-folder-info.h:
1066 * src/modest-tny-account-store.c: (on_account_removed),
1067 (on_account_changed), (create_per_account_local_outbox_folders),
1068 (get_server_accounts), (modest_tny_account_store_get_accounts),
1069 (modest_tny_account_store_get_tny_account_by_account),
1070 (modest_tny_folder_store_is_virtual_local_folders):
1072 * src/modest-tny-account.h:
1073 * src/modest-tny-account.c:
1074 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1075 to create an on-disk per-account local outbox folder for each
1077 (create_per_account_local_outbox_folders): Create a local outbox folder
1078 for each transport account.
1079 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1080 for all local folders.
1082 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1083 instead of using g_object_get/set() directly. It is clearer.
1085 (modest_tny_folder_store_get_message_count),
1086 (modest_tny_folder_store_get_local_size
1087 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1088 because we now use these with non-acount folder stores.
1090 (modest_tny_account_get_special_folder),
1091 (modest_tny_account_new_from_server_account),
1092 (modest_tny_account_new_from_account):
1093 (recurse_folders): Adjust to the new outbox system.
1095 * src/modest-tny-folder.h:
1096 * src/modest-tny-folder.c:
1097 (modest_tny_folder_is_local_folder),
1098 (modest_tny_folder_get_local_folder_type),
1099 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1101 * src/widgets/modest-main-window.h:
1102 * src/maemo/modest-main-window.c: (create_details_widget),
1103 (modest_main_window_set_contents_style): Show details for any folder store,
1106 (modest_tny_folder_get_rules):
1107 Remove the const. C does not support constness enough for this.
1109 * src/modest-ui-actions.c:
1110 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1111 make all outboxes appear as one, in the usual local-folders tree node.
1113 (set_active_account_from_tny_account),
1114 (modest_ui_actions_on_folder_selection_changed):
1115 * src/widgets/modest-folder-view.c: (text_cell_data),
1116 (icon_cell_data), (filter_row),
1117 (add_account_folders_to_merged_folder),
1118 (add_account_folders_to_simple_folder_store), (),
1119 (get_cmp_rows_type_pos), (cmp_rows),
1120 (modest_folder_view_set_account_id_of_visible_server_account):
1121 Adjust to the new outbox system, using generic folder stores and folders
1122 in the GtkTreeModel.
1124 2007-05-23 Christian Kellner <ckellner@openismus.com>
1126 * src/modest-mail-operation.c:
1127 (modest_mail_operation_update_account):
1128 Use info->max_size instead of unintialized local var [small
1129 build fix]. (Added TODO to review that change since I don't
1132 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1134 * libmodest-dbus-client/libmodest-dbus-client.c:
1135 (libmodest_dbus_client_compose_mail): function added
1136 * src/dbus_api/modest-dbus-api.h:
1137 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1138 (on_compose_mail): Implementation of the SendAsMail functionality
1140 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1142 * src/modest-account-mgr.c:
1143 (modest_account_mgr_add_server_account): Set the secure-connection
1144 conf key for transport accounts as well as store accounts. I don't know
1145 why the if was there. For instance, this makes sure that we use SSL
1146 for the gmail preset from the easysetup wizard.
1148 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1150 * src/gnome/modest-main-window.c:
1151 (on_account_store_connecting_finished), (connect_signals):
1152 * src/maemo/modest-main-window.c:
1153 (on_account_store_connecting_finished), (connect_signals),
1154 (modest_main_window_new):
1155 Handle TnyAccountStore::connecting-finished instead of
1156 TnyDevice::connection-changed, because we cannot actually perform
1157 operations on accounts until TnyAccountStore has itself responded to
1158 the TnyDevice::connection-changed signal. This prevents a GError from
1160 Do not try to update at startup, because we (at least on scratchbox)
1161 already do an update at startup when the device goes online.
1162 This prevents a GError from tinymail.
1163 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1164 Added TODO about stopping simultaneous operations.
1166 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1168 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1169 * src/modest-mail-operation-queue.c:
1170 (modest_mail_operation_queue_remove):
1171 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1172 about where they happened.
1174 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1176 * src/modest-ui-actions.c:
1177 (modest_ui_actions_on_password_requested): Make sure that the remember
1178 output parameter is always TRUE.
1180 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1182 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1183 Show a OK/Cancel dialog if the error is a question, though we still do not
1184 know anything more about what we are asking the user.
1185 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1186 Fix an uninitialized variable (helper). This is a logic error, however.
1188 2007-05-21 Christian Kellner <ckellner@openismus.com>
1190 * src/modest-search.h:
1191 Correct bit shifting in the ModestSearchFlags enum.
1193 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1195 * src/modest-tny-account.c:
1196 (modest_tny_account_new_from_server_account): Do not use the lsub and
1197 check-all hard-coded IMAP options when using POP.
1199 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1201 * src/modest-tny-account.c:
1202 (modest_tny_account_new_from_server_account):
1203 Use NULL for the secure-auth method for POP when Password auth has been
1204 specified by the user, as we already do for IMAP. "auth=Login" causes
1205 an error from camel or the server.
1207 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1209 * src/maemo/modest-account-settings-dialog.c:
1210 (create_page_account_details),
1211 (modest_account_settings_dialog_set_account_name):
1212 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1213 for the leave-on-server checkbox, rathr than just the checkbox, when
1214 the protocol is not POP.
1216 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1218 * src/widgets/modest-account-view.c:
1219 * src/widgets/modest-account-view.h:
1220 Added modest_account_view_select_account() which will be useful later
1221 to asynchronously re-select the edited account.
1223 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1225 * src/maemo/modest-account-settings-dialog.c:
1226 (modest_account_settings_dialog_set_account_name):
1227 Automatically choose the port numbers based on the secure authentication
1228 methods, if they have not been chosen before.
1229 This fixes projects.maemo.org bug NB#56273 .
1231 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1233 * src/maemo/modest-main-window-ui.h:
1234 * src/modest-ui-actions.c:
1235 * src/modest-ui-actions.h:
1236 Connect the Tools/SMTP Servers menu item to
1237 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1238 SMTP servers dialog, as in the UI specification and saves changes when it
1239 is closed. This fixed projects.maemo.org bug NB#56305 .
1241 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1243 * src/maemo/modest-connection-specific-smtp-window.c:
1244 (modest_connection_specific_smtp_window_init):
1245 Use gtk_window_set_default_size() to make this window big enough, so
1246 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1248 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1250 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1251 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1252 (modest_connection_specific_smtp_edit_window_init),
1253 Do not try to connect to a combobox signal before the combobox exists.
1254 This fixes the cras in projects.maemo.org bug NB#56288 .
1255 (modest_connection_specific_smtp_edit_window_get_settings):
1256 Remove the server_account_name parameter which was being checked for NULL
1257 though it was not used.
1259 * src/maemo/modest-connection-specific-smtp-window.c:
1260 (modest_connection_specific_smtp_window_fill_with_connections),
1261 (on_button_edit), (modest_connection_specific_smtp_window_init):
1262 Correct the number of treemodel columns to prevent a warning.
1263 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1264 libconic does not work.
1266 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1268 * src/modest-tny-account.c:
1269 (modest_tny_account_new_from_server_account):
1270 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1271 SMTP when "None" was chosen by the user. However, with my SMTP server that
1272 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1275 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1277 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1278 to explain the memory management issue with the ID in the ModestPair.
1280 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1281 (add_sending_page), (modest_account_assistant_finalize):
1282 * src/gnome/modest-gnome-global-settings-dialog.c:
1283 (create_updating_page), (create_composing_page):
1284 * src/gnome/modest-msg-edit-window.c: (get_transports),
1285 (init_window), (modest_msg_edit_window_finalize),
1286 (modest_msg_edit_window_get_msg_data):
1287 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1288 * src/gnome/modest-transport-widget.c:
1289 (modest_transport_widget_finalize), (smtp_configuration):
1290 * src/maemo/modest-maemo-global-settings-dialog.c:
1291 (create_updating_page), (create_composing_page):
1292 * src/maemo/modest-msg-edit-window.c: (get_transports),
1293 (init_window), (modest_msg_edit_window_finalize),
1294 (modest_msg_edit_window_get_msg_data),
1295 (modest_msg_edit_window_free_msg_data):
1296 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1297 (modest_store_widget_finalize):
1298 * src/maemo/modest-transport-widget.c:
1299 (modest_transport_widget_finalize), (smtp_configuration):
1300 * src/modest-main.c: (send_mail):
1301 * src/widgets/modest-combo-box.h:
1302 * src/widgets/modest-global-settings-dialog-priv.h:
1303 * src/widgets/modest-global-settings-dialog.c:
1304 (modest_global_settings_dialog_finalize):
1305 * src/widgets/modest-msg-edit-window.h:
1306 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1307 as long as the combo box, to prevent use of freed memory for the ID.
1309 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1311 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1312 get_accounts(), to make this clearer. Do not check for the enabled gconf
1313 key, because we do not use this for server accounts (at least, not yet).
1314 This allows us to send email again.
1316 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1318 * src/maemo/modest-platform.c:
1319 (on_modest_conf_update_interval_changed), (modest_platform_init):
1320 Only respond to this particular key change. All these strcmp()s cannot be
1323 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1325 * src/maemo/modest-maemo-global-settings-dialog.c:
1326 (current_connection): Prevent a crash in scratchbox when
1327 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1328 * src/maemo/modest-platform.c:
1329 (on_modest_conf_update_interval_changed), (modest_platform_init):
1330 Get the update interval from gconf and reset it when the gconf key changes.
1332 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1334 * src/modest-protocol-info.c:
1335 * src/modest-protocol-info.h: Adde enum-specific get functions,
1336 instead of using a ModestProtocolType enum parameter.
1338 * src/gnome/modest-account-assistant.c:
1339 * src/gnome/modest-store-widget.c:
1340 * src/gnome/modest-store-widget.h:
1341 * src/gnome/modest-transport-widget.c:
1342 * src/gnome/modest-transport-widget.h:
1343 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1344 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1345 * src/maemo/easysetup/modest-easysetup-wizard.c:
1346 * src/maemo/modest-account-settings-dialog.c:
1347 * src/maemo/modest-account-settings-dialog.h:
1348 * src/maemo/modest-store-widget.c:
1349 * src/maemo/modest-store-widget.h:
1350 * src/maemo/modest-transport-widget.c:
1351 * src/maemo/modest-transport-widget.h:
1352 * src/modest-account-mgr-helpers.c:
1353 * src/modest-account-mgr-helpers.h:
1354 * src/modest-account-mgr.c:
1355 * src/modest-account-mgr.h:
1356 * src/modest-tny-account.c:
1357 * src/modest-tny-folder.c:
1358 * src/widgets/modest-account-view.c:
1359 * src/widgets/modest-retrieve-combo-box.c:
1360 * src/widgets/modest-retrieve-combo-box.h:
1361 * src/widgets/modest-secureauth-combo-box.c:
1362 * src/widgets/modest-serversecurity-combo-box.c:
1363 * src/widgets/modest-serversecurity-combo-box.h:
1364 * tests/check_account-mgr.c:
1365 Use the specific functions, and use the re-renamed enum values for GNOME too.
1367 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1369 * src/modest-pair.h:
1370 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1371 so we can get the second based on the first.
1373 * src/maemo/modest-account-settings-dialog.h:
1374 * src/maemo/modest-account-settings-dialog.c:
1375 Added get_supported_secure_authentication_methods(), though it is mostly
1376 commented-out for now until the necessary API is committed to tinymail.
1377 (modest_account_settings_dialog_set_account_name),
1378 (save_configuration): Request the supported authentication methods from the
1379 server, so we can choose a working method.
1381 * src/modest-tny-account-store.h:
1382 * src/modest-tny-account-store.c:
1383 (modest_tny_account_store_get_session): Rename from
1384 tny_account_store_get_session().
1386 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1388 * src/modest-protocol-info.h: Split the ModestProtocol enum
1389 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1390 There was no need to have these unrelated values in one enum.
1392 * src/: many files: Adapted to changed enum. This makes the code a bit
1393 clearer, and the compiler could catch some errors.
1395 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1397 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1398 Show the detailed internal camel error message when an error happens
1399 during the configuration, so that our testers can give us more clues.
1400 For instance, in projects.maemo.org bug NB#56910 .
1402 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1404 * src/modest-tny-account.c:
1405 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1406 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1408 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1410 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1411 * src/maemo/modest-account-settings-dialog.c:
1412 (modest_account_settings_dialog_set_account_name),
1413 (save_configuration): For the incoming secure authentication checkbox,
1414 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1415 the UI specification. PLAIN does not seem to be supported for most IMAP
1416 servers anyway, and I am not sure what it would mean.
1417 However, we probably need to discover which of the secure-authentication
1418 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1419 * src/modest-account-mgr-helpers.c:
1420 (modest_account_mgr_get_server_account_data):
1422 * src/modest-tny-account.c:
1423 (modest_tny_account_new_from_server_account):
1424 Use tny_account_set_mech() to set secure-authentication methods,
1425 with some special-casing for IMAP, based on my observations of how
1428 * src/modest-account-mgr-helpers.h:
1429 * src/modest-account-mgr.c:
1430 * src/modest-defs.h: Comment that the URI is only used for local folders.
1432 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1434 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1435 parameter const, just to be neat.
1436 * src/modest-text-utils.c: (modest_text_utils_inline):
1437 End g_strconcat() with NULL, as its documentation says. This is almost
1438 certainly the cause of my crash at startup on the device. Interestingly,
1439 valgrind doesn't tell us about these errors.
1441 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1443 * scripts/build-packages: Added more precise comments about how to use
1444 this script, though I still get this error:
1445 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1446 error building tinymail
1448 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1450 * src/maemo/modest-main-window.c: (on_account_update):
1451 Very slight cleanup, hoping to make it simpler to discover what causes
1452 a crash here sometimes.
1454 * src/modest-tny-account.c:
1455 (modest_tny_account_new_from_server_account): Set the port. Added
1456 comments about the options and a TODO comment because I need to find out
1457 how to specify the secure authentication method.
1459 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1461 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1462 changed CFlags paths form modest to libmodest
1464 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1466 * src/modest-account-mgr-helpers.c:
1467 (modest_account_mgr_get_server_account_data),
1468 (modest_account_mgr_free_server_account_data):
1469 * src/modest-account-mgr-helpers.h:
1470 * src/modest-account-mgr.c:
1471 (modest_account_mgr_add_server_account):
1472 * src/modest-defs.h:
1473 * src/modest-tny-account.c:
1474 (modest_tny_account_new_from_server_account):
1475 Determine the options for tny_camel_account_add_option() here,
1476 based on the settings, rather than storing them directly in gconf.
1478 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1480 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1481 Show a more friendly error dialog now that we expect (from the tinymail
1482 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1484 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1486 * src/maemo/modest-main-window.c: (on_account_update): Check that
1487 account_name is not NULL, to prevent a crash at startup that I am
1488 seeing on the N800. I do wonder why it is NULL.
1490 * src/maemo/easysetup/modest-easysetup-wizard.c:
1491 (create_page_user_details):
1492 * src/maemo/modest-account-settings-dialog.c:
1493 (create_page_user_details), (create_page_outgoing):
1494 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1495 (modest_connection_specific_smtp_edit_window_init):
1496 * src/modest-ui-actions.c:
1497 (modest_ui_actions_on_password_requested):
1498 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1499 might do something useful with the on-screen keyboard.
1501 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1503 * src/maemo/modest-main-window.c: (on_account_update):
1504 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1505 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1507 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1509 * src/modest-tny-account-store.c: (on_account_changed):
1510 Correct the signature of this signal handler.
1512 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1514 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1515 Show a HildonNote instead of a GtkDialog for Maemo.
1517 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1519 * src/widgets/modest-account-view.h:
1520 * src/widgets/modest-account-view.c: (on_account_changed),
1521 (on_account_removed). Added a boolean flag, set/unset by
1522 modest_account_view_block_conf_updates(),
1523 modest_account_view_unblock_conf_updates() to prevent unnecessary
1524 updates, but this is not very useful because the gconf notifications are
1525 so delays (maybe only on Maemo Bora).
1526 So auto-updating is turned off, and these functions do an explicit
1527 update when necessary.
1528 However, something else is still doing too much work when adding/removing
1529 accounts, probably in another part of the application.
1531 * src/maemo/modest-account-view-window.c:
1532 (on_delete_button_clicked), (on_edit_button_clicked),
1533 (on_new_button_clicked): Use the new functions.
1535 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1537 * src/modest-account-mgr-helpers.c:
1538 (modest_account_mgr_set_first_account_as_default):
1539 Sort the list of names alphabetically-by-title, so we choose the first one
1541 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1542 alphabetically by the title.
1544 This fixes projects.maemo.org bug NB#56418 .
1546 * src/modest-account-mgr-priv.c:
1547 (_modest_account_mgr_account_from_key):
1548 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1549 avoid a valgrind error, and possible random behaviour.
1551 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1553 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1554 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1555 tinymail documentation to say that this can be expected.
1556 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1557 pretty, and should not happen, but I would prefer to know when it does.
1559 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1561 * configure.ac: When using the older hildon version, probably on Bora,
1562 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1564 * src/widgets/modest-attachment-view.c:
1565 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1568 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1570 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1571 Implemented the prototype. Can be tested with
1572 tests/dbus_api/test_open_message:
1574 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1576 * src/modest-tny-account-store.c:
1577 (modest_tny_account_store_instance_init), (get_password):
1578 * src/modest-ui-actions.c:
1579 (modest_ui_actions_on_password_requested):
1580 Do not store the password in gconf, because this function is called
1581 for non-remembered passwords. Actually use the cached (in the hash map)
1582 password instead of releasing it.
1583 The password will now not be remembered if it is asked via the protected
1584 password dialog, as per the UI spec.
1586 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1588 * src/modest-defs.h:
1589 * src/modest-account-mgr-helpers.h:
1590 * src/modest-account-mgr-helpers.c:
1591 Added modest_server_account_get_username_has_succeeded(),
1592 modest_server_account_set_username_has_succeeded().
1593 (modest_server_account_set_username),
1594 Reset the has-succeeded flag if the username changes.
1596 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1597 * src/maemo/modest-connection-specific-smtp-window.c:
1598 (modest_connection_specific_smtp_window_save_server_accounts):
1599 Use modest_server_account_set_username() instead of using
1600 modest_conf_set_string() directly, so that the has-succeeded flag is always
1603 * src/modest-ui-actions.c:
1604 (modest_ui_actions_on_password_requested): Dim the username entry if
1605 the username has ever worked, as per the UI spec.
1607 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1609 * src/modest-tny-account-store.c: (get_password):
1610 * src/modest-ui-actions.c:
1611 (modest_ui_actions_on_password_requested):
1612 Allow the username to be changed too, though there is more work to
1613 be done on exactly how this behaves.
1615 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1617 * src/modest-account-mgr-helpers.h:
1618 * src/modest-account-mgr-helpers.c:
1619 Added modest_account_mgr_get_display_name(),
1620 modest_server_account_get_username(),
1621 modest_server_account_set_username(),
1622 modest_server_account_set_password(),
1623 modest_server_account_get_hostname() functions so we do not need to
1624 use the conf API directly.
1626 * src/maemo/modest-main-window.c: (connect_signals):
1627 Actually connect ot the ModestAccountStore::request-password signal,
1628 so that we show the dialog when the password is requested by Tinymail,
1629 for isntance if it is empty.
1631 * src/modest-marshal.list:
1632 * src/modest-tny-account-store.c:
1633 (modest_tny_account_store_class_init), (get_password),
1634 (modest_tny_account_store_alert):
1635 * src/modest-tny-account-store.h:
1636 * src/modest-ui-actions.h:
1637 * src/modest-ui-actions.c:
1638 (modest_ui_actions_on_password_requested):
1639 Change the signal parameters, so it is obvious that we are providing
1640 the non human-readable server name, and receiving both the username
1641 and password, though changing of the username is not yet implemented.
1642 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1643 for the GNOME version.
1645 This should fix the projects.maemo.org bug NB#56209, though it does not
1646 work on Bora, because the gconf_client_get() for the password fails
1647 immediately after we save it with gconf_client_set().
1649 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1652 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1653 caused an undefined symbol error:
1654 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1656 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1658 * src/modest-tny-account-store.c:
1659 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1660 using a GError instead of a string message, so we can translate it in
1663 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1665 * src/maemo/modest-address-book.c:
1666 (modest_address_book_check_names):
1667 * src/maemo/modest-msg-view-window.c:
1668 (modest_msg_view_window_clipboard_owner_change):
1669 * src/modest-init.c: (modest_init_init_ui):
1670 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1671 (update_folders_cb), (modest_mail_operation_update_account):
1672 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1673 (modest_ui_actions_on_msg_attachment_clicked),
1674 (modest_ui_actions_on_msg_recpt_activated):
1675 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1676 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1677 (modest_msg_view_search_next):
1678 * src/widgets/modest-recpt-editor.c:
1679 (modest_recpt_editor_on_button_release_event),
1680 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1681 g_message(). At this point we should only be seeing interesting errors on
1682 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1684 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1686 (modest_wizard_dialog_force_title_update):
1687 * src/maemo/easysetup/modest-wizard-dialog.h:
1688 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1689 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1690 can update the title when appropriate. Otherwise the title is wrong if the
1691 pages are added after adding the notebook to the dialog.
1692 This must be a problem in HildonWizardDialog too.
1693 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1695 * src/maemo/easysetup/modest-easysetup-wizard.c:
1696 (create_subsequent_customsetup_pages),
1697 (create_subsequent_easysetup_pages):
1698 Call modest_wizard_dialog_force_title_update() so that the title is
1699 correct even with GTK+ < 2.10.
1700 This fixes projects.maemo.org bug NB#56145 .
1702 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1704 * src/maemo/modest-platform.c:
1705 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1706 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1709 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1711 * src/widgets/modest-window.h:
1712 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1713 and modest_window_save_state(), which invokes it.
1715 * src/widgets/modest-window-mgr.h:
1716 * src/widgets/modest-window-mgr.c:
1717 Added modest_window_mgr_save_state_for_all_windows(), which calls
1718 the save_state vfunc on all registered windows, if implemented.
1720 * src/gnome/modest-msg-edit-window.c:
1721 * src/gnome/modest-msg-view-window.c:
1722 * src/maemo/modest-msg-edit-window.c:
1723 * src/maemo/modest-msg-view-window.c:
1724 * src/maemo/modest-main-window.c:
1725 Specify the existing save_settings functions as implementations of
1726 ModestWindow::save_state_func().
1728 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1729 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1730 enabling hibernation, for instance.
1732 We may need to do the same thing for restoring settings.
1735 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1737 * src/widgets/modest-window-mgr.c:
1738 * src/widgets/modest-window-mgr.h:
1739 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1740 modest_window_mgr_get_hibernation_is_prevented().
1742 * src/maemo/modest-main-window.c:
1743 (on_hildon_program_is_topmost_notify): Prevent hibernation
1744 (possible when the application goes to the background in the WM),
1745 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1747 * src/maemo/easysetup/modest-easysetup-wizard.c:
1748 (modest_easysetup_wizard_dialog_init):
1749 * src/maemo/modest-account-settings-dialog.c:
1750 (modest_account_settings_dialog_init):
1751 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1752 (modest_connection_specific_smtp_edit_window_init):
1753 * src/maemo/modest-connection-specific-smtp-window.c:
1754 (modest_connection_specific_smtp_window_init):
1755 * src/maemo/modest-signature-editor-dialog.c:
1756 (modest_signature_editor_dialog_init):
1757 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1758 prevent hibernation while any of these account settings dialogs are open.
1760 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1762 * src/maemo/Makefile.am:
1763 * src/maemo/modest-osso-state-saving.c:
1764 * src/maemo/modest-osso-state-saving.h: Added
1765 modest_osso_load_state() and modest_osso_save_state() though they do
1766 nothing now. They should iterate through all the open windows and load/save
1768 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1769 save state when closing.
1771 * src/maemo/modest-main-window.c:
1772 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1773 Add a notification handler for the HildonProgram::is-topmost property,
1774 so we can allow hibernation when the application goes into the background.
1775 But we still need to detect when the accounts setup windows are open so
1776 we can stop hibernation when they are open.
1777 To do this, I also added the main window the HildonProgram. This might have
1778 other side-effects/benefits, and should maybe be done for other windows.
1780 * src/maemo/modest-osso-autosave-callbacks.h:
1781 * src/maemo/modest-osso-autosave-callbacks.c:
1782 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1783 though it does not do anything yet, and we might never need this to do
1784 anything. For instance, we already save drafts.
1786 * src/maemo/modest-platform.c: (modest_platform_init):
1787 Specify the libosso auto-save callback.
1789 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1791 * src/maemo/modest-platform.c:
1792 (modest_platform_set_update_interval):
1793 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1794 aparently stays valid between application instances, so we can use this
1795 to remove and reset it later. According to a maemo-developers email from
1798 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1800 * configure.ac: Depend on libalarm for Maemo.
1802 * src/dbus_api/modest-dbus-api.h:
1803 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1804 (on_send_receive), (modest_dbus_req_handler):
1805 Handle a SEND_RECEIVE D-Bus method.
1807 * libmodest-dbus-client/libmodest-dbus-client.c:
1808 (libmodest_dbus_client_send_and_receive):
1809 * libmodest-dbus-client/libmodest-dbus-client.h:
1810 Add C convenience functions for calling the new D-Bus method.
1812 * src/modest-platform.h:
1813 * src/gnome/modest-platform.c:
1814 * src/maemo/modest-platform.c:
1815 Added modest_platform_set_update_interval(), which uses the
1816 alarmd API on Maemo.
1817 (modest_platform_init),
1818 Call modest_platform_set_update_interval(), using a hard-coded
1819 interval for now (until the global settings dialog is implemented),
1820 though I am not sure that this makes sense yet.
1822 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1824 * src/dbus_api/modest-dbus-callbacks.c:
1825 (modest_osso_cb_hw_state_handler):
1826 * src/dbus_api/modest-dbus-callbacks.h:
1827 * src/maemo/modest-platform.c: (modest_platform_init):
1828 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1829 in case this has some effect on the ability for Maemo to ping the
1832 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1834 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1835 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1836 warning. It is probably a logic error, but I need to fix the build.
1838 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1840 * src/modest-account-mgr.h:
1841 * src/modest-account-mgr.c:
1842 (modest_account_mgr_account_names): Add a gboolean enabled_only
1843 parameter, so we can get lists of onlt the enabled accounts.
1845 (modest_account_mgr_add_account),,
1846 (modest_account_mgr_account_with_display_name_exists):
1847 * src/maemo/modest-msg-edit-window.c: (get_transports):
1848 * src/modest-account-mgr-helpers.c:
1849 (modest_account_mgr_set_first_account_as_default):
1850 * src/modest-init.c: (init_default_account_maybe):
1851 * src/modest-tny-account-store.c: (get_accounts):
1852 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1853 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1854 * tests/check_account-mgr.c: (START_TEST):
1855 Provide the extra parameter, as appropriate.
1857 * src/widgets/modest-account-view.c: (update_account_view):
1858 Do not show disabled accounts (meaning that there is no way to
1859 enable/disable accounts in the UI (the feature is not in our UI
1860 specification), so we can use this internally only to mark unfinished
1861 or temporary account data.
1863 * src/maemo/easysetup/modest-easysetup-wizard.c:
1864 (create_account): Add boolean enable parameter, so we can specify FALSE
1865 to create the temporary account.
1866 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1867 (on_before_next): When finishing, when there is a temporary account, just
1869 Also, use a timeout to delay the showing of the dialog until gconf is likely
1870 to return correct information, due to a maemo gconf bug that is fixed in
1871 osso 1.1, but not yet in Bora.
1872 However, the dialog stays on screen after it is destroyed.
1874 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1875 for invalid data when cancelling. Use a hildon note instead of a dialog
1876 to complain about invalid data. Do not show the account-saved note if the
1877 account is disabled (a temporary account that will not really be saved for use
1880 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1882 * src/modest-account-mgr-helpers.h:
1883 * src/modest-account-mgr-helpers.c:
1884 Added modest_account_mgr_unset_default_account(),
1885 Added modest_account_mgr_set_first_account_as_default().
1887 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1888 If it was the default account, unset the default account name.
1890 * src/maemo/modest-account-view-window.c:
1891 (on_delete_button_clicked): If it was the default account,
1892 set the first remaining account as the default instead.
1894 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1895 a NULL account or a NULL default account, to prevent a crash. This should
1896 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1899 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1901 * src/widgets/modest-recpt-editor.c:
1902 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1903 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1904 TODO comment for this. This fixes the build.
1906 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1907 be the best place for it. This will in future update all auto-update accounts,
1908 rather than just the current/default account, when that gconf key exists.
1909 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1910 if there are no accounts, before calling do_send_receive().
1911 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1913 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1914 * src/maemo/modest-main-window-ui.h:
1915 * src/maemo/modest-main-window.c: (on_connection_changed),
1916 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1917 directly, becaue the signal handler does more.
1919 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1921 * src/modest-account-mgr-helpers.c:
1922 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1923 for the case that the account does not exist.
1925 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1926 (equivalent to the modest account name) rather than the tinymail account name
1927 (equivalent to the modest account title - human readable) to get the account data.
1928 Check for null account data to prevent the crash, and add a TODO comment saying that
1929 this needs fixing because it is using the server account name instead of the account name.
1931 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1933 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1934 * src/maemo/modest-account-settings-dialog.c: (show_error),
1936 Use hildon_note_new_information() for informative and error messages,
1937 which seems to be expected for Maemo applications (no documentation that I know of
1938 says this). I am surprised that there is no distinction between info and error
1941 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1943 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1944 it is easy to find where this is used.
1946 * src/maemo/easysetup/modest-easysetup-wizard.c:
1947 (create_page_welcome), (create_page_account_details),
1948 (create_page_user_details), (create_page_complete_easysetup),
1949 (create_page_custom_incoming), (create_page_custom_outgoing),
1950 (create_page_complete_custom):
1951 * src/maemo/modest-account-settings-dialog.c:
1952 (create_page_account_details), (create_page_user_details),
1953 (create_page_incoming), (create_page_outgoing):
1954 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1955 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1956 (modest_connection_specific_smtp_edit_window_init):
1957 * src/maemo/modest-connection-specific-smtp-window.c:
1958 (modest_connection_specific_smtp_window_init):
1959 * src/maemo/modest-signature-editor-dialog.c:
1960 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1961 and scrolling policy as per the Email Application Layout Guide, if I have
1964 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1966 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1967 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1968 which were empty, because these vfuncs have been removed from TnyAccountStore.
1969 This fixes the build.
1971 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1973 * src/maemo/modest-main-window.c:
1974 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1975 showing/hiding it. Added TODO because it probably should not be NULL.
1976 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1977 because unnecessary g_warnings() make degugging difficult.
1979 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1981 * src/maemo/modest-msg-edit-window.c:
1982 (modest_msg_edit_window_select_color),
1983 (modest_msg_edit_window_select_background_color): 2 const corrections and
1984 moving 2 #endifs before closing brackets, to fix the build.
1986 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1988 * src/maemo/easysetup/modest-easysetup-wizard.h:
1989 * src/maemo/easysetup/modest-easysetup-wizard.c:
1990 (modest_easysetup_wizard_dialog_finalize),
1991 (on_button_edit_advanced_settings), (create_page_complete_custom),
1992 (on_response), (create_account):
1993 Implement the Advanced Settings edit button, by saving the account information,
1994 for the Advanded Settings dialog to use directly from gconf, and removing it
1995 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1996 Bug #5533 in the projects.maemo.org bugzilla.
1998 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2000 * src/maemo/modest-msg-view-window.c:
2001 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2002 when opening a message window.
2004 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2006 * src/maemo/easysetup/modest-easysetup-wizard.c:
2007 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2010 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2011 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2012 gconf settings. I probably added more checks than necessary, but that is safer.
2014 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2015 variable to fix the build, but this seems to be used when it is still NULL.
2017 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2019 * src/modest-platform.h:
2020 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2021 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2022 * src/modest-main.c: Implement this function so we can avoid using
2023 maemo-specific API from cross-platform code.
2025 * src/modest-tny-account-store.c:
2026 (get_smtp_specific_transport_account_for_open_connection):
2027 * src/modest-ui-actions.c: (check_for_connection),
2028 (modest_ui_actions_on_item_not_found):
2029 Use modest_platform_connect_and_wait() and put #idefs around other
2030 maemo-specific code, because only maemo currently has a way to
2031 identify connection names.
2033 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2035 * src/modest-tny-account-store.h:
2036 * src/modest-tny-account-store.c:
2037 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2038 the connection-specific SMTP server settings in the configuration.
2040 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2042 * src/maemo/modest-main-window.c: (on_connection_changed),
2044 * src/modest-main.c: (main), (start_ui), (send_mail):
2045 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2046 that is what is intended.
2048 * src/modest-ui-actions.c: (action_send), (action_receive),
2049 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2050 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2051 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2052 SMTP server is used when it is specified.
2054 (modest_ui_actions_on_send_receive):
2055 Check that a connection is open before proceeding.
2056 Receive and then send, instead of vice-versa, as per the specification.
2058 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2060 * src/modest-mail-operation.c:
2061 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2062 though I guess it should be something other than NULL.
2064 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2066 * src/maemo/easysetup/modest-easysetup-wizard.c:
2067 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2068 combo twice, to avoid an g_warning and to make it visible again.
2069 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2070 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2071 (already intended) dereference when detaching, because we then recreate the menu.
2072 But I am not sure why the warning was happening, and it is possible that this is a memory
2075 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2077 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2078 and uri_parse_mailto() utility functions.
2079 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2081 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2083 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2085 * src/dbus_api/modest-dbus-api.h:
2086 * src/dbus_api/modest-dbus-callbacks.c:
2087 Use an idle callback to execute the modest code in the application's own thread.
2088 Remove the helloworld example method.
2089 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2090 parsed, and the open-message method is not implemented because this is not yet implemented in
2092 * libmodest-dbus-client/libmodest-dbus-client.c:
2093 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2094 (libmodest_dbus_client_open_message):
2095 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2097 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2098 body without crashing.
2100 * tests/dbus_api/Makefile.am:
2101 * tests/dbus_api/test_mail_to.c:
2102 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2104 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2106 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2107 Added file to fix the build. Sorry.
2109 * src/dbus_api/Makefile.am:
2110 * src/dbus_api/modest-dbus-api.h:
2111 * src/dbus_api/modest-dbus-callbacks.h:
2112 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2113 (modest_dbus_req_handler):
2114 Put constants in a separate header so it can be reused by the
2115 client library, without duplication
2117 * libmodest-dbus-client/Makefile.am:
2118 * libmodest-dbus-client/libmodest-dbus-client.c:
2119 (libmodest_dbus_client_call_helloworld),
2120 (libmodfest_dbus_client_send_mail),
2121 (libmodfest_dbus_client_mailto),
2122 (libmodfest_dbus_client_open_message):
2123 * libmodest-dbus-client/libmodest-dbus-client.h:
2124 (Partly) Implement a send_mail D-Bus method.
2126 * tests/dbus_api/Makefile.am:
2127 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2128 the send_email D-Bus method.
2130 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2134 * libmodest-dbus-client/Makefile.am:
2135 * libmodest-dbus-client/libmodest-dbus-client.c:
2136 * libmodest-dbus-client/libmodest-dbus-client.h:
2137 * tests/dbus_api/Makefile.am:
2138 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2139 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2141 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2143 * src/maemo/easysetup/modest-easysetup-wizard.c:
2144 (create_page_account_details):
2145 * src/maemo/modest-account-settings-dialog.c:
2146 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2147 widgets, because this might not be the default in future versions of the Maemo GTK+.
2148 However, I can not not get capitalization to work even in a simple test case.
2150 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2152 * src/maemo/easysetup/modest-easysetup-wizard.c:
2153 (create_page_custom_incoming), (create_page_custom_outgoing):
2154 * src/maemo/modest-account-settings-dialog.c:
2155 (create_page_account_details), (create_page_incoming),
2156 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2157 instead of using gtk_check_button_with_label(), so they are aligned like the other
2158 widgets, as per the UI spec.
2160 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2162 * src/maemo/easysetup/modest-easysetup-wizard.c:
2163 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2164 * src/widgets/modest-validating-entry.c:
2165 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2166 Modest prefix instead of an EasySetup prefix.
2168 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2170 * src/widgets/modest-validating-entry.h:
2171 * src/widgets/modest-validating-entry.c: (on_insert_text),
2172 Added easysetup_validating_entry_set_max_func(), used to set a callback
2173 to call when the max number of characters is reached. GtkEntry has a max-length
2174 already but is silent about it.
2176 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2177 (create_page_account_details), (create_page_user_details),
2179 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2180 (create_page_account_details), (create_page_user_details),
2181 (create_page_outgoing):
2182 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2183 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2184 the UI spec, when the user tries to enter more than the max number of characters.
2186 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2188 * src/maemo/easysetup/modest-easysetup-wizard.c:
2189 (create_page_user_details), (create_page_custom_incoming),
2190 (create_page_custom_outgoing):
2191 * src/maemo/modest-account-settings-dialog.c:
2192 (create_page_user_details), (create_page_incoming),
2193 (create_page_outgoing):
2194 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2195 (modest_connection_specific_smtp_edit_window_init):
2196 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2197 not appropriate. Bad Maemo-specific defaults!.
2199 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2201 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2202 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2203 (modest_signature_editor_dialog_set_settings):
2204 Disable the label and textview when the checkbox is disabled, and use the
2205 specified (UI spec) default signature text.
2207 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2209 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2210 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2212 * src/modest-defs.h:
2213 * src/modest-account-mgr-helpers.h:
2214 * src/modest-account-mgr-helpers.c:
2215 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2217 * src/maemo/Makefile.am:
2218 * src/maemo/modest-signature-editor-dialog.c:
2219 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2222 * src/maemo/modest-account-settings-dialog.h:
2223 * src/maemo/modest-account-settings-dialog.c:
2224 (modest_account_settings_dialog_finalize), (on_button_signature),
2225 (save_configuration): Use the new dialog when the Edit button is pressed, and
2226 save the changes if necessary, as per the UI spec.
2228 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2230 * src/maemo/Makefile.am:
2231 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2232 based on maemo-develoers email from Dirk.
2234 * src/maemo/easysetup/modest-easysetup-wizard.c:
2235 (create_page_welcome), (create_page_account_details),
2236 (create_page_user_details), (create_page_complete_easysetup),
2237 (create_page_custom_incoming), (create_page_custom_outgoing),
2238 (create_page_complete_custom),
2239 (modest_easysetup_wizard_dialog_init):
2240 * src/maemo/modest-account-settings-dialog.c:
2241 (create_page_account_details), (create_page_user_details),
2242 (create_page_incoming), (create_page_outgoing),
2243 (modest_account_settings_dialog_init):
2244 * src/maemo/modest-connection-specific-smtp-window.c:
2245 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2247 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2249 * src/maemo/easysetup/modest-easysetup-wizard.c:
2250 (create_page_account_details), (create_page_custom_outgoing),
2251 (create_page_complete_custom):
2252 * src/maemo/modest-account-settings-dialog.c:
2253 (create_page_user_details), (create_page_incoming),
2254 (create_page_outgoing):
2255 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2256 (modest_connection_specific_smtp_edit_window_init):
2257 Use the correct (UI spec) port min/max, and use horizontal separators,
2260 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2262 * src/maemo/easysetup/modest-easysetup-wizard.c:
2263 (set_default_custom_servernames):
2264 * src/maemo/modest-account-settings-dialog.c:
2265 (create_page_incoming), (on_combo_outgoing_security_changed),
2266 (on_combo_incoming_security_changed), (create_page_outgoing),
2267 (modest_account_settings_dialog_set_account_name),
2268 (save_configuration):
2269 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2270 (on_combo_security_changed),
2271 (modest_connection_specific_smtp_edit_window_init),
2272 (modest_connection_specific_smtp_edit_window_set_connection),
2273 (modest_connection_specific_smtp_edit_window_get_settings):
2274 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2277 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2280 * src/maemo/easysetup/modest-easysetup-wizard.c:
2281 (create_page_custom_outgoing), (create_page_complete_custom):
2282 * src/maemo/modest-account-settings-dialog.c:
2283 (create_page_user_details), (create_page_outgoing):
2284 * src/maemo/modest-account-view-window.c: (button_box_new):
2285 Use changed logical IDs as per the most recent UI spec:
2286 mcen_bd_emailsetup_edit -> mcen_bd_edit
2287 mcen_bd_emailsetup_delete -> mcen_bd_delete
2288 mcen_bd_emailsetup_close -> mcen_bd_close
2290 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2294 * src/dbus_api/Makefile.am:
2295 * src/dbus_api/modest-dbus-callbacks.c:
2296 * src/dbus_api/modest-dbus-callbacks.h:
2297 * src/maemo/modest-platform.c: (modest_platform_init):
2298 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2300 * tests/Makefile.am:
2301 * tests/dbus_api/Makefile.am:
2302 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2304 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2306 * src/maemo/modest-account-settings-dialog.c:
2307 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2308 Removed unnecessary includes.
2310 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2312 * src/maemo/easysetup/modest-easysetup-wizard.c:
2313 * src/maemo/modest-account-settings-dialog.c:
2314 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2315 * src/widgets/Makefile.am:
2316 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2317 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2318 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2319 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2320 * src/widgets/modest-secureauth-combo-box.c:
2321 * src/widgets/modest-secureauth-combo-box.h:
2322 * src/widgets/modest-serversecurity-combo-box.c:
2323 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2324 made the GObject names more consistent with the rest of the Modest code.
2326 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2328 * src/maemo/easysetup/Makefile.am:
2329 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2330 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2331 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2332 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2333 * src/maemo/easysetup/modest-easysetup-wizard.c:
2334 * src/maemo/easysetup/modest-validating-entry.c:
2335 * src/maemo/easysetup/modest-validating-entry.h:
2336 * src/maemo/modest-account-settings-dialog.c:
2337 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2338 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2339 widgets/ because they are used outside of easysetup too. After checking in,
2340 svn will allow me to rename them too.
2342 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2344 * src/gnome/modest-msg-edit-window.c:
2345 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2346 linker error, to fix the build on the GNOME platform.
2347 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2348 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2349 ifdefed out to avoid a warning.
2351 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2353 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2354 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2355 some alternative for GTK+ 2.6.
2357 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2359 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2361 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2362 specified for EmailAccountsDialog in UI spec.
2364 * src/maemo/easysetup/modest-easysetup-wizard.c:
2365 * src/maemo/easysetup/modest-easysetup-wizard.h:
2366 * src/maemo/modest-account-settings-dialog.c:
2367 * src/maemo/modest-account-settings-dialog.h:
2368 Reuse a member window widget for the connection-specific SMTP server accounts,
2369 so we can tell it to create/save the accounts only if we actually save changes.
2371 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2372 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2373 (modest_connection_specific_smtp_edit_window_get_settings):
2374 Return a struct instance for temporarily remembering the entered data.
2376 * src/maemo/modest-connection-specific-smtp-window.h:
2377 * src/maemo/modest-connection-specific-smtp-window.c:
2378 (modest_connection_specific_smtp_window_finalize),
2379 (modest_connection_specific_smtp_window_fill_with_connections),
2381 (modest_connection_specific_smtp_window_save_server_accounts),
2382 (update_model_server_names): Do not actually save data until asked,
2383 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2385 (on_selection_changed),
2386 (modest_connection_specific_smtp_window_init): Disable the edit
2387 button when nothing is selected.
2389 * src/modest-account-mgr-helpers.c:
2390 * src/modest-account-mgr-helpers.h:
2391 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2394 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2396 * src/modest-account-mgr-helpers.h:
2397 * src/modest-account-mgr-helpers.c:
2398 (modest_account_mgr_get_unused_account_name),
2399 (modest_account_mgr_get_unused_account_display_name): Added these
2400 utility functions, to avoid code duplication.
2402 * src/maemo/easysetup/modest-easysetup-wizard.c:
2403 (create_page_account_details), (create_account):
2404 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2405 (on_combo_security_changed),
2406 (modest_connection_specific_smtp_edit_window_init),
2407 (modest_connection_specific_smtp_edit_window_save_settings):
2408 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2409 * src/maemo/modest-connection-specific-smtp-window.c:
2410 (modest_connection_specific_smtp_window_finalize),
2411 (modest_connection_specific_smtp_window_fill_with_connections),
2412 (on_button_edit), (modest_connection_specific_smtp_window_init):
2413 * src/maemo/modest-connection-specific-smtp-window.h:
2414 Implementing saving of connection-specific server accounts.
2416 But I need to refactor this so we can save the data for each
2417 possible connection-specific account and only actually create the server accounts
2418 when the easysetup finished, or the OK button is pressed on the account settings
2421 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2423 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2424 (on_combo_security_changed):
2425 (modest_connection_specific_smtp_edit_window_init):
2426 Auto-fill the port number as in the account settings.
2428 (modest_connection_specific_smtp_edit_window_set_connection):
2429 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2430 * src/maemo/modest-connection-specific-smtp-window.c:
2431 (fill_with_connections), (on_button_edit),
2432 (modest_connection_specific_smtp_window_init):
2433 Turn the edit window into a dialog to simplify the code, and
2434 set a WM hint as in a GtkDialog, because only a popup can be on top of
2435 another window in Maemo, and popups usually have no WM decoration.
2437 * src/modest-defs.h:
2438 * src/modest-account-mgr-helpers.c:
2439 (modest_account_mgr_set_connection_specific_smtp),
2440 (modest_account_mgr_remove_connection_specific_smtp),
2441 (modest_account_mgr_get_connection_specific_smtp):
2442 * src/modest-account-mgr-helpers.h: Some functions to write the
2443 connection-specific SMTP server information. Not yet used.
2446 * src/widgets/modest-folder-view.c: (text_cell_data):
2447 Fix a warning about an uninitialized variable.
2448 (on_configuration_key_changed): Put an #ifdef around the use
2449 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2451 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2453 * src/maemo/modest-account-settings-dialog.h:
2454 * src/maemo/modest-account-settings-dialog.c:
2455 Added connect_for_modified() utility function to mark the new modified boolean.
2457 (create_page_account_details), (create_page_user_details),
2458 (create_page_incoming), (create_page_outgoing), (on_response),
2459 (modest_account_settings_dialog_init),
2460 (modest_account_settings_dialog_set_account_name):
2461 Only warn about unsaved changes when there are actually unsaved changes.
2463 * src/modest-account-mgr-helpers.c:
2464 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2465 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2466 to get the data from there in future.
2468 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2470 * src/modest-defs.h:
2472 * src/modest-account-mgr-helpers.h:
2473 * src/modest-account-mgr-helpers.c:
2474 Store the security account setting in a single conf key instead of using
2475 the options list, so that the list is left for just the to-be-removed camel hack,
2476 and because gconf_client_set_list() is failing for some reason.
2478 * src/modest-account-mgr.c:
2479 (modest_account_mgr_add_server_account):
2480 * src/maemo/modest-account-settings-dialog.c:
2481 (modest_account_settings_dialog_set_account_name),
2482 (save_configuration): Use the renamed functions.
2485 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2487 * src/widgets/Makefile.am:
2488 * src/widgets/modest-limit-retrieve-combo-box.c:
2489 * src/widgets/modest-limit-retrieve-combo-box.h:
2490 * src/widgets/modest-retrieve-combo-box.c:
2491 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2492 the account settings dialog.
2494 * src/modest-defs.h:
2495 * src/modest-account-mgr-helpers.h:
2496 * src/modest-account-mgr-helpers.c:
2497 (modest_server_account_get_option_secure_auth),
2498 (modest_server_account_set_option_secure_auth):
2499 * src/modest-account-mgr.c:
2500 (modest_account_mgr_add_server_account):
2501 Use the existing AUTH_MECH conf key for the secure-auth setting,
2502 instead of putting it in the list options, because this was actually used already.
2504 * src/maemo/modest-account-settings-dialog.c:
2505 (create_page_account_details),
2506 (modest_account_settings_dialog_set_account_name),
2507 (save_configuration):
2508 * src/maemo/modest-account-settings-dialog.h:
2509 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2510 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2512 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2514 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2515 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2516 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2518 * src/modest-defs.h:
2519 * src/maemo/modest-account-settings-dialog.c:
2520 (create_page_incoming), (on_combo_outgoing_security_changed),
2521 (on_combo_incoming_security_changed), (create_page_outgoing),
2522 (modest_account_settings_dialog_set_account_name),
2523 (save_configuration): Load/Save the port number, and change it when the
2524 security combo changes, to suitable defaults.
2526 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2528 * src/modest-account-mgr.c:
2529 (modest_account_mgr_add_server_account): Set the security and secure-auth
2530 options, and add a comment saying that the other camel-specific options should be
2533 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2535 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2537 * src/modest-tny-account-store.c: (account_list_free),
2538 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2539 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2542 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2544 * src/modest-protocol-info.c:
2545 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2546 is required by our UI spec. Maybe something in our implementation will use this eventually.
2547 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2548 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2549 instead of the previous 0 placeholder.
2551 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2552 secure-auth settings.
2553 * src/modest-account-mgr-helpers.h:
2554 * src/modest-account-mgr-helpers.c:
2555 (modest_server_account_data_get_option_secure_auth),
2556 (modest_server_account_set_option_secure_auth),
2557 (modest_server_account_data_get_option_security),
2558 (modest_server_account_set_option_security): Added this API for getting and setting the security
2559 and secure-auth settings.
2561 * src/maemo/modest-account-settings-dialog.h:
2562 * src/maemo/modest-account-settings-dialog.c:
2563 (modest_account_settings_dialog_finalize), (check_data),
2564 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2565 about changing titles.
2566 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2567 (save_configuration): Save the security and secure-auth settings.
2569 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2570 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2572 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2574 * src/modest-defs.h:
2575 * src/modest-account-mgr.c:
2576 (modest_account_mgr_add_server_account):
2577 Added and used defines for the options key and value pair strings,
2578 that are used so far, though they do not seem to correspond to anything in our
2579 UI specs or ModestProtocol enum.
2581 * src/modest-account-mgr-helpers.h:
2582 * src/modest-account-mgr-helpers.c:
2583 (compare_option_strings_for_name),
2584 (modest_server_account_data_get_option_value),
2585 (modest_server_account_data_get_option_bool),
2586 (modest_account_mgr_get_server_account_option):
2587 Added helper functions for parsing the options GSList.
2589 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2591 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2592 display name is based on the supplied account name.
2593 * src/modest-account-mgr.c:
2594 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2595 with an inefficient, but good-enough, implementation.
2597 * src/maemo/easysetup/modest-easysetup-wizard.c:
2598 (create_page_account_details), (on_before_next), (create_account):
2599 Check for existing display names rather than (non-user-visible) account names, and just
2600 create and set a unique account name at the end.
2602 * src/maemo/modest-account-settings-dialog.c:
2603 (modest_account_settings_dialog_init),
2604 (modest_account_settings_dialog_set_account_name),
2605 (create_page_incoming): Show the display name, instead of the account name.
2606 (on_response): Do some (not all) extra checks, as in the UI spec.
2607 (save_configuration): Save the display name if it was changed.
2609 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2611 * po/en_GB.po: Added needed logical ID and translation.
2612 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2613 (init_view): Made the is-default column clicking work.
2615 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2618 * src/maemo/easysetup/Makefile.am:
2619 * src/maemo/easysetup/modest-easysetup-wizard.c:
2620 (modest_easysetup_wizard_dialog_init):
2621 * src/maemo/easysetup/provider-data-test.keyfile:
2622 * src/maemo/easysetup/provider-data.keyfile:
2623 Moved the provider data file to the new modest-providers-data package and used it from there.
2625 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2627 * src/modest-local-folder-info.c:
2628 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2629 N_() was already used on the static strings, but this just marks it for translation without
2630 using the translation.
2632 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2634 * src/maemo/modest-account-settings-dialog.c:
2635 (create_page_incoming),
2636 (modest_account_settings_dialog_set_account_name):
2637 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2638 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2639 I will do this if nobody else gets there first.
2641 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2643 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2644 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2645 save the security stuff.
2647 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2649 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2650 Set the email address and user fullname, which I now see must be
2653 * src/maemo/modest-account-settings-dialog.h:
2654 * src/maemo/modest-account-settings-dialog.c:
2656 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2657 leave-on-server and authentication.
2658 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2661 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2664 * src/maemo/modest-account-settings-dialog.c:
2665 * src/maemo/modest-account-settings-dialog.h:
2666 Most (but not all) of the widgets are now present as specified by the UI spec.
2667 No changes are yet saved, and some details are not properly shown yet.
2669 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2671 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2673 * src/maemo/Makefile.am:
2674 * src/maemo/modest-account-settings-dialog.c:
2675 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2676 an existing account. Doesn't do much yet.
2678 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2679 Open the accounts settings dialog when Edit is clicked.
2681 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2683 * src/maemo/easysetup/Makefile.am:
2684 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2686 * src/maemo/easysetup/modest-easysetup-wizard.c:
2687 (modest_easysetup_wizard_dialog_init):
2688 Try to get the source directory from the build system,
2689 instead of hard-coding "./" into the source code, when opening our local
2690 copies of the configuration files.
2691 But this still fails when opening the wizard from the Accounts window,
2692 maybe because the working directory seems to change at runtime.
2693 So the wizard will fail the second time unless you copy the files into their
2694 proper locations - see the stdout warnings for the paths.
2696 (create_page_account_details),(on_before_next):
2697 Check for existing non-server accounts instead of server accounts,
2698 so the default account name is useful again, and to prevent trying to
2701 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2702 Show the wizard when New is clicked.
2704 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2705 (init_view): Show the column headers, and show the columns that are
2706 specified in the UI specs. However, something in Maemo's GTK+ prevents
2707 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2708 change the default account. This is despite unsetting the special properties.
2710 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2712 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2713 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2714 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2715 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2716 to make that clearer.
2717 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2719 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2721 * src/maemo/modest-account-view-window.c:
2722 (modest_account_view_window_init),
2723 (modest_account_view_window_new):
2724 Use the same buttons as specified in the
2725 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2726 the existing widgets, which never had a chance of working.
2727 Put the ModestAccountView treeview in a scrolled window.
2728 Do not repeat the initialization in both _init() and _new().
2730 * src/widgets/modest-account-view.c: (update_account_view):
2731 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2732 this widget and window shows no accounts.
2734 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2736 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2738 * src/maemo/easysetup/modest-easysetup-wizard.c:
2739 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2740 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2741 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2744 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2745 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2746 accounts exist yet, as in the UI spec.
2748 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2750 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2752 * src/maemo/Makefile.am:
2753 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2754 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2755 New window for editing connection-specific smtp details.
2756 Not fully implemented.
2758 * src/maemo/modest-connection-specific-smtp-window.c:
2759 (modest_connection_specific_smtp_window_finalize) :
2760 unref the tree model.
2761 (on_button_edit): Show the edit window.
2763 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2765 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2768 * src/maemo/Makefile.am:
2769 * src/maemo/modest-connection-specific-smtp-window.c:
2770 * src/maemo/modest-connection-specific-smtp-window.h:
2771 New window for showing the list of connections, for connection-specific
2772 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2773 * src/maemo/easysetup/modest-easysetup-wizard.c:
2774 (create_page_custom_outgoing): Show the new window when the button is clicked.
2776 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2778 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2779 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2780 * src/maemo/modest-msg-edit-window.c:
2781 (modest_msg_edit_window_insert_image):
2782 * src/modest-conf.c: (modest_conf_key_escape):
2783 * src/modest-mail-operation.c:
2784 (modest_mail_operation_send_new_mail):
2785 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2786 (modest_ui_actions_on_new_account):
2787 * src/widgets/modest-attachment-view.c: (update_filename_request):
2788 * src/widgets/modest-mail-header-view.c:
2789 Corrected warnings that were breaking the build, by commenting out unused variables,
2790 and a function, and by including a header.
2792 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2794 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2795 so we can #ifdef around platform-specific code when necessary.
2796 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2797 to allow this to build for the GNOME platform too.
2799 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2801 * src/maemo/easysetup/modest-easysetup-wizard.c:
2802 Added util_increment_name() and used it in create_page_account_details()
2803 to make sure that the default account name is always a new name.
2805 (modest_easysetup_wizard_dialog_init),
2806 (set_default_custom_servernames): Some minor memory management fixes.
2808 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2812 * src/modest-runtime.c: (init_i18n): Restored the translation
2813 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2814 are defined in config.h, and the translations are installed.
2816 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2817 is defined for translation.
2819 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2821 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2823 * src/maemo/easysetup/modest-easysetup-wizard.c:
2824 (modest_easysetup_wizard_dialog_init):
2825 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2826 Use realistic paths (though they should use $prefix generically) to the
2827 mcc_mapping and provider-data.keyfile files which might work when they
2828 are installed by the future version of the operator-wizard package,
2829 and then fallback to paths in our source code, with an explanatory
2832 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2836 * src/maemo/Makefile.am:
2837 * src/maemo/easysetup/: Added files from the previously-exernal
2838 osso-modest-easysetup.
2839 * src/maemo/modest-main-window-ui.h:
2840 * src/modest-ui-actions.c:
2841 * src/modest-ui-actions.h:
2842 Added modest_ui_actions_on_new_account() as a signal handler for the
2843 New Account menu item. It shows the easysetup wizard.
2844 * po/en_GB.po: Added additional needed logical IDs and translations.
2846 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2847 Apparently ChangeLog is not used for some vague Nokia legal reasons.