git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
   4         Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
   5         tinymail documentation to say that this can be expected.
   6         Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
   7         pretty, and should not happen, but I would prefer to know when it does.
   8
   9 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  10
  11         * configure.ac: When using the older hildon version, probably on Bora,
  12         require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
  13         to fix the build.
  14         * src/widgets/modest-attachment-view.c:
  15         (modest_attachment_view_set_part_default): Initialize variables, to fix the
  16         build.
  17
  18 2007-05-09  Marcus Bauer  <marcusb@openismus.com>
  19
  20         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
  21         Implemented the prototype. Can be tested with
  22         tests/dbus_api/test_open_message:
  23
  24 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  25
  26         * src/modest-tny-account-store.c:
  27         (modest_tny_account_store_instance_init), (get_password):
  28         * src/modest-ui-actions.c:
  29         (modest_ui_actions_on_password_requested):
  30         Do not store the password in gconf, because this function is called
  31         for non-remembered passwords. Actually use the cached (in the hash map)
  32         password instead of releasing it.
  33         The password will now not be remembered if it is asked via the protected
  34         password dialog, as per the UI spec.
  35
  36 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  37
  38         * src/modest-defs.h:
  39         * src/modest-account-mgr-helpers.h:
  40         * src/modest-account-mgr-helpers.c:
  41         Added modest_server_account_get_username_has_succeeded(),
  42         modest_server_account_set_username_has_succeeded().
  43         (modest_server_account_set_username),
  44         Reset the has-succeeded flag if the username changes.
  45
  46         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
  47         * src/maemo/modest-connection-specific-smtp-window.c:
  48         (modest_connection_specific_smtp_window_save_server_accounts):
  49         Use modest_server_account_set_username() instead of using
  50         modest_conf_set_string() directly, so that the has-succeeded flag is always
  51         reset.
  52
  53         * src/modest-ui-actions.c:
  54         (modest_ui_actions_on_password_requested): Dim the username entry if
  55         the username has ever worked, as per the UI spec.
  56
  57 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  58
  59         * src/modest-tny-account-store.c: (get_password):
  60         * src/modest-ui-actions.c:
  61         (modest_ui_actions_on_password_requested):
  62         Allow the username to be changed too, though there is more work to
  63         be done on exactly how this behaves.
  64
  65 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  66
  67         * src/modest-account-mgr-helpers.h:
  68         * src/modest-account-mgr-helpers.c:
  69         Added modest_account_mgr_get_display_name(),
  70         modest_server_account_get_username(),
  71         modest_server_account_set_username(),
  72         modest_server_account_set_password(),
  73         modest_server_account_get_hostname() functions so we do not need to
  74         use the conf API directly.
  75
  76         * src/maemo/modest-main-window.c: (connect_signals):
  77         Actually connect ot the ModestAccountStore::request-password signal,
  78         so that we show the dialog when the password is requested by Tinymail,
  79         for isntance if it is empty.
  80
  81         * src/modest-marshal.list:
  82         * src/modest-tny-account-store.c:
  83         (modest_tny_account_store_class_init), (get_password),
  84         (modest_tny_account_store_alert):
  85         * src/modest-tny-account-store.h:
  86         * src/modest-ui-actions.h:
  87         * src/modest-ui-actions.c:
  88         (modest_ui_actions_on_password_requested):
  89         Change the signal parameters, so it is obvious that we are providing
  90         the non human-readable server name, and receiving both the username
  91         and password, though changing of the username is not yet implemented.
  92         Change the dialog UI to match the Maemo UI specifications, with #idfefing
  93         for the GNOME version.
  94
  95         This should fix the projects.maemo.org bug NB#56209, though it does not
  96         work on Bora, because the gconf_client_get() for the password fails
  97         immediately after we save it with gconf_client_set().
  98
  99 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 100
 101         * configure.ac:
 102         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
 103         caused an undefined symbol error:
 104         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
 105
 106 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 107
 108         * src/modest-tny-account-store.c:
 109         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
 110         using a GError instead of a string message, so we can translate it in
 111         Modest.
 112
 113 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 114
 115         * src/maemo/modest-address-book.c:
 116         (modest_address_book_check_names):
 117         * src/maemo/modest-msg-view-window.c:
 118         (modest_msg_view_window_clipboard_owner_change):
 119         * src/modest-init.c: (modest_init_init_ui):
 120         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
 121         (update_folders_cb), (modest_mail_operation_update_account):
 122         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 123         (modest_ui_actions_on_msg_attachment_clicked),
 124         (modest_ui_actions_on_msg_recpt_activated):
 125         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 126         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 127         (modest_msg_view_search_next):
 128         * src/widgets/modest-recpt-editor.c:
 129         (modest_recpt_editor_on_button_release_event),
 130         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 131         g_message(). At this point we should only be seeing interesting errors on
 132         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 133
 134 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 135
 136         (modest_wizard_dialog_force_title_update):
 137         * src/maemo/easysetup/modest-wizard-dialog.h:
 138         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 139         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 140         can update the title when appropriate. Otherwise the title is wrong if the
 141         pages are added after adding the notebook to the dialog.
 142         This must be a problem in HildonWizardDialog too.
 143         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 144
 145         * src/maemo/easysetup/modest-easysetup-wizard.c:
 146         (create_subsequent_customsetup_pages),
 147         (create_subsequent_easysetup_pages):
 148         Call modest_wizard_dialog_force_title_update() so that the title is
 149         correct even with GTK+ < 2.10.
 150         This fixes projects.maemo.org bug NB#56145 .
 151
 152 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 153
 154         * src/maemo/modest-platform.c:
 155         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 156         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 157         from being shown.
 158
 159 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 160
 161         * src/widgets/modest-window.h:
 162         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 163         and modest_window_save_state(), which invokes it.
 164
 165         * src/widgets/modest-window-mgr.h:
 166         * src/widgets/modest-window-mgr.c:
 167         Added modest_window_mgr_save_state_for_all_windows(), which calls
 168         the save_state vfunc on all registered windows, if implemented.
 169
 170         * src/gnome/modest-msg-edit-window.c:
 171         * src/gnome/modest-msg-view-window.c:
 172         * src/maemo/modest-msg-edit-window.c:
 173         * src/maemo/modest-msg-view-window.c:
 174         * src/maemo/modest-main-window.c:
 175         Specify the existing save_settings functions as implementations of
 176         ModestWindow::save_state_func().
 177
 178         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 179         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 180         enabling hibernation, for instance.
 181
 182         We may need to do the same thing for restoring settings.
 183
 184
 185 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 186
 187         * src/widgets/modest-window-mgr.c:
 188         * src/widgets/modest-window-mgr.h:
 189         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 190         modest_window_mgr_get_hibernation_is_prevented().
 191
 192         * src/maemo/modest-main-window.c:
 193         (on_hildon_program_is_topmost_notify): Prevent hibernation
 194         (possible when the application goes to the background in the WM),
 195         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 196
 197         * src/maemo/easysetup/modest-easysetup-wizard.c:
 198         (modest_easysetup_wizard_dialog_init):
 199         * src/maemo/modest-account-settings-dialog.c:
 200         (modest_account_settings_dialog_init):
 201         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 202         (modest_connection_specific_smtp_edit_window_init):
 203         * src/maemo/modest-connection-specific-smtp-window.c:
 204         (modest_connection_specific_smtp_window_init):
 205         * src/maemo/modest-signature-editor-dialog.c:
 206         (modest_signature_editor_dialog_init):
 207         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 208         prevent hibernation while any of these account settings dialogs are open.
 209
 210 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 211
 212         * src/maemo/Makefile.am:
 213         * src/maemo/modest-osso-state-saving.c:
 214         * src/maemo/modest-osso-state-saving.h: Added
 215         modest_osso_load_state() and modest_osso_save_state() though they do
 216         nothing now. They should iterate through all the open windows and load/save
 217         their state.
 218         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 219         save state when closing.
 220
 221         * src/maemo/modest-main-window.c:
 222         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 223         Add a notification handler for the HildonProgram::is-topmost property,
 224         so we can allow hibernation when the application goes into the background.
 225         But we still need to detect when the accounts setup windows are open so
 226         we can stop hibernation when they are open.
 227         To do this, I also added the main window the HildonProgram. This might have
 228         other side-effects/benefits, and should maybe be done for other windows.
 229
 230         * src/maemo/modest-osso-autosave-callbacks.h:
 231         * src/maemo/modest-osso-autosave-callbacks.c:
 232         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 233         though it does not do anything yet, and we might never need this to do
 234         anything. For instance, we already save drafts.
 235
 236         * src/maemo/modest-platform.c: (modest_platform_init):
 237         Specify the libosso auto-save callback.
 238
 239 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 240
 241         * src/maemo/modest-platform.c:
 242         (modest_platform_set_update_interval):
 243         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 244         aparently stays valid between application instances, so we can use this
 245         to remove and reset it later. According to a maemo-developers email from
 246         David Weinehall.
 247
 248 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 249
 250         * configure.ac: Depend on libalarm for Maemo.
 251
 252         * src/dbus_api/modest-dbus-api.h:
 253         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 254         (on_send_receive), (modest_dbus_req_handler):
 255         Handle a SEND_RECEIVE D-Bus method.
 256
 257         * libmodest-dbus-client/libmodest-dbus-client.c:
 258         (libmodest_dbus_client_send_and_receive):
 259         * libmodest-dbus-client/libmodest-dbus-client.h:
 260         Add C convenience functions for calling the new D-Bus method.
 261
 262         * src/modest-platform.h:
 263         * src/gnome/modest-platform.c:
 264         * src/maemo/modest-platform.c:
 265         Added modest_platform_set_update_interval(), which uses the
 266         alarmd API on Maemo.
 267         (modest_platform_init),
 268         Call modest_platform_set_update_interval(), using a hard-coded
 269         interval for now (until the global settings dialog is implemented),
 270         though I am not sure that this makes sense yet.
 271
 272 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 273
 274         * src/dbus_api/modest-dbus-callbacks.c:
 275         (modest_osso_cb_hw_state_handler):
 276         * src/dbus_api/modest-dbus-callbacks.h:
 277         * src/maemo/modest-platform.c: (modest_platform_init):
 278         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 279         in case this has some effect on the ability for Maemo to ping the
 280         application.
 281
 282 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 283
 284         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 285         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 286         warning. It is probably a logic error, but I need to fix the build.
 287
 288 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 289
 290         * src/modest-account-mgr.h:
 291         * src/modest-account-mgr.c:
 292         (modest_account_mgr_account_names): Add a gboolean enabled_only
 293         parameter, so we can get lists of onlt the enabled accounts.
 294
 295         (modest_account_mgr_add_account),,
 296         (modest_account_mgr_account_with_display_name_exists):
 297         * src/maemo/modest-msg-edit-window.c: (get_transports):
 298         * src/modest-account-mgr-helpers.c:
 299         (modest_account_mgr_set_first_account_as_default):
 300         * src/modest-init.c: (init_default_account_maybe):
 301         * src/modest-tny-account-store.c: (get_accounts):
 302         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 303         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 304         * tests/check_account-mgr.c: (START_TEST):
 305         Provide the extra parameter, as appropriate.
 306
 307         * src/widgets/modest-account-view.c: (update_account_view):
 308         Do not show disabled accounts (meaning that there is no way to
 309         enable/disable accounts in the UI (the feature is not in our UI
 310         specification), so we can use this internally only to mark unfinished
 311         or temporary account data.
 312
 313         * src/maemo/easysetup/modest-easysetup-wizard.c:
 314         (create_account): Add boolean enable parameter, so we can specify FALSE
 315         to create the temporary account.
 316         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 317         (on_before_next): When finishing, when there is a temporary account, just
 318         set it as enabled.
 319         Also, use a timeout to delay the showing of the dialog until gconf is likely
 320         to return correct information, due to a maemo gconf bug that is fixed in
 321         osso 1.1, but not yet in Bora.
 322         However, the dialog stays on screen after it is destroyed.
 323
 324         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 325         for invalid data when cancelling. Use a hildon note instead of a dialog
 326         to complain about invalid data. Do not show the account-saved note if the
 327         account is disabled (a temporary account that will not really be saved for use
 328         until later.)
 329
 330 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 331
 332         * src/modest-account-mgr-helpers.h:
 333         * src/modest-account-mgr-helpers.c:
 334         Added modest_account_mgr_unset_default_account(),
 335         Added modest_account_mgr_set_first_account_as_default().
 336
 337         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 338         If it was the default account, unset the default account name.
 339
 340         * src/maemo/modest-account-view-window.c:
 341         (on_delete_button_clicked): If it was the default account,
 342         set the first remaining account as the default instead.
 343
 344         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 345         a NULL account or a NULL default account, to prevent a crash. This should
 346         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 347
 348
 349 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 350
 351         * src/widgets/modest-recpt-editor.c:
 352         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 353         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 354         TODO comment for this. This fixes the build.
 355
 356         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 357         be the best place for it. This will in future update all auto-update accounts,
 358         rather than just the current/default account, when that gconf key exists.
 359         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 360         if there are no accounts, before calling do_send_receive().
 361         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 362
 363         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 364         * src/maemo/modest-main-window-ui.h:
 365         * src/maemo/modest-main-window.c: (on_connection_changed),
 366         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 367         directly, becaue the signal handler does more.
 368
 369 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 370
 371         * src/modest-account-mgr-helpers.c:
 372         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 373         for the case that the account does not exist.
 374
 375         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 376         (equivalent to the modest account name) rather than the tinymail account name
 377         (equivalent to the modest account title - human readable) to get the account data.
 378         Check for null account data to prevent the crash, and add a TODO comment saying that
 379         this needs fixing because it is using the server account name instead of the account name.
 380
 381 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 382
 383         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 384         * src/maemo/modest-account-settings-dialog.c: (show_error),
 385         (show_ok):
 386         Use hildon_note_new_information() for informative and error messages,
 387         which seems to be expected for Maemo applications (no documentation that I know of
 388         says this). I am surprised that there is no distinction between info and error
 389         dialogs.
 390
 391 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 392
 393         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 394         it is easy to find where this is used.
 395
 396         * src/maemo/easysetup/modest-easysetup-wizard.c:
 397         (create_page_welcome), (create_page_account_details),
 398         (create_page_user_details), (create_page_complete_easysetup),
 399         (create_page_custom_incoming), (create_page_custom_outgoing),
 400         (create_page_complete_custom):
 401         * src/maemo/modest-account-settings-dialog.c:
 402         (create_page_account_details), (create_page_user_details),
 403         (create_page_incoming), (create_page_outgoing):
 404         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 405         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 406         (modest_connection_specific_smtp_edit_window_init):
 407         * src/maemo/modest-connection-specific-smtp-window.c:
 408         (modest_connection_specific_smtp_window_init):
 409         * src/maemo/modest-signature-editor-dialog.c:
 410         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 411         and scrolling policy as per the Email Application Layout Guide, if I have
 412         understood it.
 413
 414 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 415
 416         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 417         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 418         which were empty, because these vfuncs have been removed from TnyAccountStore.
 419         This fixes the build.
 420
 421 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 422
 423         * src/maemo/modest-main-window.c:
 424         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 425         showing/hiding it. Added TODO because it probably should not be NULL.
 426         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 427         because unnecessary g_warnings() make degugging difficult.
 428
 429 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 430
 431         * src/maemo/modest-msg-edit-window.c:
 432         (modest_msg_edit_window_select_color),
 433         (modest_msg_edit_window_select_background_color): 2 const corrections and
 434         moving 2 #endifs before closing brackets, to fix the build.
 435
 436 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 437
 438         * src/maemo/easysetup/modest-easysetup-wizard.h:
 439         * src/maemo/easysetup/modest-easysetup-wizard.c:
 440         (modest_easysetup_wizard_dialog_finalize),
 441         (on_button_edit_advanced_settings), (create_page_complete_custom),
 442         (on_response), (create_account):
 443         Implement the Advanced Settings edit button, by saving the account information,
 444         for the Advanded Settings dialog to use directly from gconf, and removing it
 445         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 446         Bug #5533 in the projects.maemo.org bugzilla.
 447
 448 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 449
 450         * src/maemo/modest-msg-view-window.c:
 451         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 452         when opening a message window.
 453
 454 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 455
 456         * src/maemo/easysetup/modest-easysetup-wizard.c:
 457         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 458         match the UI spec.
 459
 460         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 461         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 462         gconf settings. I probably added more checks than necessary, but that is safer.
 463
 464         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 465         variable to fix the build, but this seems to be used when it is still NULL.
 466
 467 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 468
 469         * src/modest-platform.h:
 470         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 471         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 472         * src/modest-main.c: Implement this function so we can avoid using
 473         maemo-specific API from cross-platform code.
 474         (main):
 475         * src/modest-tny-account-store.c:
 476         (get_smtp_specific_transport_account_for_open_connection):
 477         * src/modest-ui-actions.c: (check_for_connection),
 478         (modest_ui_actions_on_item_not_found):
 479         Use modest_platform_connect_and_wait() and put #idefs around other
 480         maemo-specific code, because only maemo currently has a way to
 481         identify connection names.
 482
 483 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 484
 485         * src/modest-tny-account-store.h:
 486         * src/modest-tny-account-store.c:
 487         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 488         the connection-specific SMTP server settings in the configuration.
 489
 490         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 491         (on_idle_mail_to):
 492         * src/maemo/modest-main-window.c: (on_connection_changed),
 493         (connect_signals):
 494         * src/modest-main.c: (main), (start_ui), (send_mail):
 495         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 496         that is what is intended.
 497
 498         * src/modest-ui-actions.c: (action_send), (action_receive),
 499         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 500         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 501         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 502         SMTP server is used when it is specified.
 503
 504         (modest_ui_actions_on_send_receive):
 505         Check that a connection is open before proceeding.
 506         Receive and then send, instead of vice-versa, as per the specification.
 507
 508 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 509
 510         * src/modest-mail-operation.c:
 511         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 512         though I guess it should be something other than NULL.
 513
 514 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 515
 516         * src/maemo/easysetup/modest-easysetup-wizard.c:
 517         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 518         combo twice, to avoid an g_warning and to make it visible again.
 519         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 520         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 521         (already intended) dereference when detaching, because we then recreate the menu.
 522         But I am not sure why the warning was happening, and it is possible that this is a memory
 523         leak.
 524
 525 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 526
 527         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 528         and uri_parse_mailto() utility functions.
 529         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 530         the mailto URI.
 531         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 532
 533 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 534
 535         * src/dbus_api/modest-dbus-api.h:
 536         * src/dbus_api/modest-dbus-callbacks.c:
 537         Use an idle callback to execute the modest code in the application's own thread.
 538         Remove the helloworld example method.
 539         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 540         parsed, and the open-message method is not implemented because this is not yet implemented in
 541         modest itself.
 542         * libmodest-dbus-client/libmodest-dbus-client.c:
 543         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 544         (libmodest_dbus_client_open_message):
 545         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 546
 547         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 548         body without crashing.
 549
 550         * tests/dbus_api/Makefile.am:
 551         * tests/dbus_api/test_mail_to.c:
 552         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 553
 554 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 555
 556         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 557         Added file to fix the build. Sorry.
 558
 559         * src/dbus_api/Makefile.am:
 560         * src/dbus_api/modest-dbus-api.h:
 561         * src/dbus_api/modest-dbus-callbacks.h:
 562         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 563         (modest_dbus_req_handler):
 564         Put constants in a separate header so it can be reused by the
 565         client library, without duplication
 566
 567         * libmodest-dbus-client/Makefile.am:
 568         * libmodest-dbus-client/libmodest-dbus-client.c:
 569         (libmodest_dbus_client_call_helloworld),
 570         (libmodfest_dbus_client_send_mail),
 571         (libmodfest_dbus_client_mailto),
 572         (libmodfest_dbus_client_open_message):
 573         * libmodest-dbus-client/libmodest-dbus-client.h:
 574         (Partly) Implement a send_mail D-Bus method.
 575
 576         * tests/dbus_api/Makefile.am:
 577         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 578         the send_email D-Bus method.
 579
 580 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 581
 582         * Makefile.am:
 583         * configure.ac:
 584         * libmodest-dbus-client/Makefile.am:
 585         * libmodest-dbus-client/libmodest-dbus-client.c:
 586         * libmodest-dbus-client/libmodest-dbus-client.h:
 587         * tests/dbus_api/Makefile.am:
 588         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 589         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 590
 591 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 592
 593         * src/maemo/easysetup/modest-easysetup-wizard.c:
 594         (create_page_account_details):
 595         * src/maemo/modest-account-settings-dialog.c:
 596         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 597         widgets, because this might not be the default in future versions of the Maemo GTK+.
 598         However, I can not not get capitalization to work even in a simple test case.
 599
 600 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 601
 602         * src/maemo/easysetup/modest-easysetup-wizard.c:
 603         (create_page_custom_incoming), (create_page_custom_outgoing):
 604         * src/maemo/modest-account-settings-dialog.c:
 605         (create_page_account_details), (create_page_incoming),
 606         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 607         instead of using gtk_check_button_with_label(), so they are aligned like the other
 608         widgets, as per the UI spec.
 609
 610 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 611
 612         * src/maemo/easysetup/modest-easysetup-wizard.c:
 613         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 614         * src/widgets/modest-validating-entry.c:
 615         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 616         Modest prefix instead of an EasySetup prefix.
 617
 618 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 619
 620         * src/widgets/modest-validating-entry.h:
 621         * src/widgets/modest-validating-entry.c: (on_insert_text),
 622         Added easysetup_validating_entry_set_max_func(), used to set a callback
 623         to call when the max number of characters is reached. GtkEntry has a max-length
 624         already but is silent about it.
 625
 626         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 627         (create_page_account_details), (create_page_user_details),
 628         (create_account):
 629         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 630         (create_page_account_details), (create_page_user_details),
 631         (create_page_outgoing):
 632         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 633         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 634         the UI spec, when the user tries to enter more than the max number of characters.
 635
 636 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 637
 638         * src/maemo/easysetup/modest-easysetup-wizard.c:
 639         (create_page_user_details), (create_page_custom_incoming),
 640         (create_page_custom_outgoing):
 641         * src/maemo/modest-account-settings-dialog.c:
 642         (create_page_user_details), (create_page_incoming),
 643         (create_page_outgoing):
 644         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 645         (modest_connection_specific_smtp_edit_window_init):
 646         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 647         not appropriate. Bad Maemo-specific defaults!.
 648
 649 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 650
 651         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 652         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 653         (modest_signature_editor_dialog_set_settings):
 654         Disable the label and textview when the checkbox is disabled, and use the
 655         specified (UI spec) default signature text.
 656
 657 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 658
 659         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 660         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 661
 662         * src/modest-defs.h:
 663         * src/modest-account-mgr-helpers.h:
 664         * src/modest-account-mgr-helpers.c:
 665         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 666
 667         * src/maemo/Makefile.am:
 668         * src/maemo/modest-signature-editor-dialog.c:
 669         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 670         as per the UI spec.
 671
 672         * src/maemo/modest-account-settings-dialog.h:
 673         * src/maemo/modest-account-settings-dialog.c:
 674         (modest_account_settings_dialog_finalize), (on_button_signature),
 675         (save_configuration): Use the new dialog when the Edit button is pressed, and
 676         save the changes if necessary, as per the UI spec.
 677
 678 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 679
 680         * src/maemo/Makefile.am:
 681         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 682         based on maemo-develoers email from Dirk.
 683
 684         * src/maemo/easysetup/modest-easysetup-wizard.c:
 685         (create_page_welcome), (create_page_account_details),
 686         (create_page_user_details), (create_page_complete_easysetup),
 687         (create_page_custom_incoming), (create_page_custom_outgoing),
 688         (create_page_complete_custom),
 689         (modest_easysetup_wizard_dialog_init):
 690         * src/maemo/modest-account-settings-dialog.c:
 691         (create_page_account_details), (create_page_user_details),
 692         (create_page_incoming), (create_page_outgoing),
 693         (modest_account_settings_dialog_init):
 694         * src/maemo/modest-connection-specific-smtp-window.c:
 695         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 696
 697 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 698
 699         * src/maemo/easysetup/modest-easysetup-wizard.c:
 700         (create_page_account_details), (create_page_custom_outgoing),
 701         (create_page_complete_custom):
 702         * src/maemo/modest-account-settings-dialog.c:
 703         (create_page_user_details), (create_page_incoming),
 704         (create_page_outgoing):
 705         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 706         (modest_connection_specific_smtp_edit_window_init):
 707         Use the correct (UI spec) port min/max, and use horizontal separators,
 708         as per the UI spec.
 709
 710 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 711
 712         * src/maemo/easysetup/modest-easysetup-wizard.c:
 713         (set_default_custom_servernames):
 714         * src/maemo/modest-account-settings-dialog.c:
 715         (create_page_incoming), (on_combo_outgoing_security_changed),
 716         (on_combo_incoming_security_changed), (create_page_outgoing),
 717         (modest_account_settings_dialog_set_account_name),
 718         (save_configuration):
 719         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 720         (on_combo_security_changed),
 721         (modest_connection_specific_smtp_edit_window_init),
 722         (modest_connection_specific_smtp_edit_window_set_connection),
 723         (modest_connection_specific_smtp_edit_window_get_settings):
 724         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 725         as per the UI spec.
 726
 727 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 728
 729         * po/en_GB.po:
 730         * src/maemo/easysetup/modest-easysetup-wizard.c:
 731         (create_page_custom_outgoing), (create_page_complete_custom):
 732         * src/maemo/modest-account-settings-dialog.c:
 733         (create_page_user_details), (create_page_outgoing):
 734         * src/maemo/modest-account-view-window.c: (button_box_new):
 735         Use changed logical IDs as per the most recent UI spec:
 736         mcen_bd_emailsetup_edit -> mcen_bd_edit
 737         mcen_bd_emailsetup_delete -> mcen_bd_delete
 738         mcen_bd_emailsetup_close -> mcen_bd_close
 739
 740 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 741
 742         * configure.ac:
 743         * src/Makefile.am:
 744         * src/dbus_api/Makefile.am:
 745         * src/dbus_api/modest-dbus-callbacks.c:
 746         * src/dbus_api/modest-dbus-callbacks.h:
 747         * src/maemo/modest-platform.c: (modest_platform_init):
 748         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 749         method.
 750         * tests/Makefile.am:
 751         * tests/dbus_api/Makefile.am:
 752         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 753
 754 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 755
 756         * src/maemo/modest-account-settings-dialog.c:
 757         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 758         Removed unnecessary includes.
 759
 760 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 761
 762         * src/maemo/easysetup/modest-easysetup-wizard.c:
 763         * src/maemo/modest-account-settings-dialog.c:
 764         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 765         * src/widgets/Makefile.am:
 766         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 767         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 768         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 769         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 770         * src/widgets/modest-secureauth-combo-box.c:
 771         * src/widgets/modest-secureauth-combo-box.h:
 772         * src/widgets/modest-serversecurity-combo-box.c:
 773         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 774         made the GObject names more consistent with the rest of the Modest code.
 775
 776 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 777
 778         * src/maemo/easysetup/Makefile.am:
 779         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 780         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 781         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 782         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 783         * src/maemo/easysetup/modest-easysetup-wizard.c:
 784         * src/maemo/easysetup/modest-validating-entry.c:
 785         * src/maemo/easysetup/modest-validating-entry.h:
 786         * src/maemo/modest-account-settings-dialog.c:
 787         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 788         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 789         widgets/ because they are used outside of easysetup too. After checking in,
 790         svn will allow me to rename them too.
 791
 792 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 793
 794         * src/gnome/modest-msg-edit-window.c:
 795         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 796         linker error, to fix the build on the GNOME platform.
 797         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 798         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 799         ifdefed out to avoid a warning.
 800
 801 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 802
 803         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 804         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 805         some alternative for GTK+ 2.6.
 806
 807 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 808
 809         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 810
 811         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 812         specified for EmailAccountsDialog in UI spec.
 813
 814         * src/maemo/easysetup/modest-easysetup-wizard.c:
 815         * src/maemo/easysetup/modest-easysetup-wizard.h:
 816         * src/maemo/modest-account-settings-dialog.c:
 817         * src/maemo/modest-account-settings-dialog.h:
 818         Reuse a member window widget for the connection-specific SMTP server accounts,
 819         so we can tell it to create/save the accounts only if we actually save changes.
 820
 821         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 822         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 823         (modest_connection_specific_smtp_edit_window_get_settings):
 824         Return a struct instance for temporarily remembering the entered data.
 825
 826         * src/maemo/modest-connection-specific-smtp-window.h:
 827         * src/maemo/modest-connection-specific-smtp-window.c:
 828         (modest_connection_specific_smtp_window_finalize),
 829         (modest_connection_specific_smtp_window_fill_with_connections),
 830         (on_button_edit),
 831         (modest_connection_specific_smtp_window_save_server_accounts),
 832         (update_model_server_names): Do not actually save data until asked,
 833         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 834
 835         (on_selection_changed),
 836         (modest_connection_specific_smtp_window_init): Disable the edit
 837         button when nothing is selected.
 838
 839         * src/modest-account-mgr-helpers.c:
 840         * src/modest-account-mgr-helpers.h:
 841         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 842         elsewhere.
 843
 844 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 845
 846         * src/modest-account-mgr-helpers.h:
 847         * src/modest-account-mgr-helpers.c:
 848         (modest_account_mgr_get_unused_account_name),
 849         (modest_account_mgr_get_unused_account_display_name): Added these
 850         utility functions, to avoid code duplication.
 851
 852         * src/maemo/easysetup/modest-easysetup-wizard.c:
 853         (create_page_account_details), (create_account):
 854         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 855         (on_combo_security_changed),
 856         (modest_connection_specific_smtp_edit_window_init),
 857         (modest_connection_specific_smtp_edit_window_save_settings):
 858         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 859         * src/maemo/modest-connection-specific-smtp-window.c:
 860         (modest_connection_specific_smtp_window_finalize),
 861         (modest_connection_specific_smtp_window_fill_with_connections),
 862         (on_button_edit), (modest_connection_specific_smtp_window_init):
 863         * src/maemo/modest-connection-specific-smtp-window.h:
 864         Implementing saving of connection-specific server accounts.
 865
 866         But I need to refactor this so we can save the data for each
 867         possible connection-specific account and only actually create the server accounts
 868         when the easysetup finished, or the OK button is pressed on the account settings
 869         dialog.
 870
 871 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 872
 873         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 874         (on_combo_security_changed):
 875         (modest_connection_specific_smtp_edit_window_init):
 876         Auto-fill the port number as in the account settings.
 877
 878         (modest_connection_specific_smtp_edit_window_set_connection):
 879         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 880         * src/maemo/modest-connection-specific-smtp-window.c:
 881         (fill_with_connections), (on_button_edit),
 882         (modest_connection_specific_smtp_window_init):
 883         Turn the edit window into a dialog to simplify the code, and
 884         set a WM hint as in a GtkDialog, because only a popup can be on top of
 885         another window in Maemo, and popups usually have no WM decoration.
 886
 887         * src/modest-defs.h:
 888         * src/modest-account-mgr-helpers.c:
 889         (modest_account_mgr_set_connection_specific_smtp),
 890         (modest_account_mgr_remove_connection_specific_smtp),
 891         (modest_account_mgr_get_connection_specific_smtp):
 892         * src/modest-account-mgr-helpers.h: Some functions to write the
 893         connection-specific SMTP server information. Not yet used.
 894
 895
 896         * src/widgets/modest-folder-view.c: (text_cell_data):
 897         Fix a warning about an uninitialized variable.
 898         (on_configuration_key_changed): Put an #ifdef around the use
 899         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 900
 901 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 902
 903         * src/maemo/modest-account-settings-dialog.h:
 904         * src/maemo/modest-account-settings-dialog.c:
 905         Added connect_for_modified() utility function to mark the new modified boolean.
 906
 907         (create_page_account_details), (create_page_user_details),
 908         (create_page_incoming), (create_page_outgoing), (on_response),
 909         (modest_account_settings_dialog_init),
 910         (modest_account_settings_dialog_set_account_name):
 911         Only warn about unsaved changes when there are actually unsaved changes.
 912
 913         * src/modest-account-mgr-helpers.c:
 914         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 915         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 916         to get the data from there in future.
 917
 918 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 919
 920         * src/modest-defs.h:
 921
 922         * src/modest-account-mgr-helpers.h:
 923         * src/modest-account-mgr-helpers.c:
 924         Store the security account setting in a single conf key instead of using
 925         the options list, so that the list is left for just the to-be-removed camel hack,
 926         and because gconf_client_set_list() is failing for some reason.
 927
 928         * src/modest-account-mgr.c:
 929         (modest_account_mgr_add_server_account):
 930         * src/maemo/modest-account-settings-dialog.c:
 931         (modest_account_settings_dialog_set_account_name),
 932         (save_configuration): Use the renamed functions.
 933
 934
 935 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 936
 937         * src/widgets/Makefile.am:
 938         * src/widgets/modest-limit-retrieve-combo-box.c:
 939         * src/widgets/modest-limit-retrieve-combo-box.h:
 940         * src/widgets/modest-retrieve-combo-box.c:
 941         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 942         the account settings dialog.
 943
 944         * src/modest-defs.h:
 945         * src/modest-account-mgr-helpers.h:
 946         * src/modest-account-mgr-helpers.c:
 947         (modest_server_account_get_option_secure_auth),
 948         (modest_server_account_set_option_secure_auth):
 949         * src/modest-account-mgr.c:
 950         (modest_account_mgr_add_server_account):
 951         Use the existing AUTH_MECH conf key for the secure-auth setting,
 952         instead of putting it in the list options, because this was actually used already.
 953
 954         * src/maemo/modest-account-settings-dialog.c:
 955         (create_page_account_details),
 956         (modest_account_settings_dialog_set_account_name),
 957         (save_configuration):
 958         * src/maemo/modest-account-settings-dialog.h:
 959         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 960         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 961
 962 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 963
 964         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 965         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 966         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 967
 968         * src/modest-defs.h:
 969         * src/maemo/modest-account-settings-dialog.c:
 970         (create_page_incoming), (on_combo_outgoing_security_changed),
 971         (on_combo_incoming_security_changed), (create_page_outgoing),
 972         (modest_account_settings_dialog_set_account_name),
 973         (save_configuration): Load/Save the port number, and change it when the
 974         security combo changes, to suitable defaults.
 975
 976 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 977
 978         * src/modest-account-mgr.c:
 979         (modest_account_mgr_add_server_account): Set the security and secure-auth
 980         options, and add a comment saying that the other camel-specific options should be
 981         removed in future.
 982
 983 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 984
 985         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 986         found by valgrind.
 987         * src/modest-tny-account-store.c: (account_list_free),
 988         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 989         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 990         easy to fix.
 991
 992 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 993
 994         * src/modest-protocol-info.c:
 995         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 996         is required by our UI spec. Maybe something in our implementation will use this eventually.
 997         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 998         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 999         instead of the previous 0 placeholder.
1000
1001         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1002         secure-auth settings.
1003         * src/modest-account-mgr-helpers.h:
1004         * src/modest-account-mgr-helpers.c:
1005         (modest_server_account_data_get_option_secure_auth),
1006         (modest_server_account_set_option_secure_auth),
1007         (modest_server_account_data_get_option_security),
1008         (modest_server_account_set_option_security): Added this API for getting and setting the security
1009         and secure-auth settings.
1010
1011         * src/maemo/modest-account-settings-dialog.h:
1012         * src/maemo/modest-account-settings-dialog.c:
1013         (modest_account_settings_dialog_finalize), (check_data),
1014         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1015         about changing titles.
1016         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1017         (save_configuration): Save the security and secure-auth settings.
1018
1019         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1020         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1021
1022 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1023
1024         * src/modest-defs.h:
1025         * src/modest-account-mgr.c:
1026         (modest_account_mgr_add_server_account):
1027         Added and used defines for the options key and value pair strings,
1028         that are used so far, though they do not seem to correspond to anything in our
1029         UI specs or ModestProtocol enum.
1030
1031         * src/modest-account-mgr-helpers.h:
1032         * src/modest-account-mgr-helpers.c:
1033         (compare_option_strings_for_name),
1034         (modest_server_account_data_get_option_value),
1035         (modest_server_account_data_get_option_bool),
1036         (modest_account_mgr_get_server_account_option):
1037         Added helper functions for parsing the options GSList.
1038
1039 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1040
1041         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1042         display name is based on the supplied account name.
1043         * src/modest-account-mgr.c:
1044         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1045         with an inefficient, but good-enough, implementation.
1046
1047         * src/maemo/easysetup/modest-easysetup-wizard.c:
1048         (create_page_account_details), (on_before_next), (create_account):
1049         Check for existing display names rather than (non-user-visible) account names, and just
1050         create and set a unique account name at the end.
1051
1052         * src/maemo/modest-account-settings-dialog.c:
1053         (modest_account_settings_dialog_init),
1054         (modest_account_settings_dialog_set_account_name),
1055         (create_page_incoming): Show the display name, instead of the account name.
1056         (on_response): Do some (not all) extra checks, as in the UI spec.
1057         (save_configuration): Save the display name if it was changed.
1058
1059 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1060
1061         * po/en_GB.po: Added needed logical ID and translation.
1062         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1063         (init_view): Made the is-default column clicking work.
1064
1065 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1066
1067         * configure.ac:
1068         * src/maemo/easysetup/Makefile.am:
1069         * src/maemo/easysetup/modest-easysetup-wizard.c:
1070         (modest_easysetup_wizard_dialog_init):
1071         * src/maemo/easysetup/provider-data-test.keyfile:
1072         * src/maemo/easysetup/provider-data.keyfile:
1073         Moved the provider data file to the new modest-providers-data package and used it from there.
1074
1075 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1076
1077         * src/modest-local-folder-info.c:
1078         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1079         N_() was already used on the static strings, but this just marks it for translation without
1080         using the translation.
1081
1082 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1083
1084         * src/maemo/modest-account-settings-dialog.c:
1085         (create_page_incoming),
1086         (modest_account_settings_dialog_set_account_name):
1087         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1088         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1089         I will do this if nobody else gets there first.
1090
1091 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1092
1093         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1094         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1095         save the security stuff.
1096
1097 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1098
1099         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1100         Set the email address and user fullname, which I now see must be
1101         done separately.
1102
1103         * src/maemo/modest-account-settings-dialog.h:
1104         * src/maemo/modest-account-settings-dialog.c:
1105          (on_response),
1106         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1107         leave-on-server and authentication.
1108         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1109         how to do the rest.
1110
1111 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1112
1113
1114         * src/maemo/modest-account-settings-dialog.c:
1115         * src/maemo/modest-account-settings-dialog.h:
1116         Most (but not all) of the widgets are now present as specified by the UI spec.
1117         No changes are yet saved, and some details are not properly shown yet.
1118
1119         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1120
1121 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1122
1123         * src/maemo/Makefile.am:
1124         * src/maemo/modest-account-settings-dialog.c:
1125         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1126         an existing account. Doesn't do much yet.
1127
1128         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1129         Open the accounts settings dialog when Edit is clicked.
1130
1131 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1132
1133         * src/maemo/easysetup/Makefile.am:
1134         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1135         (load_from_file):
1136         * src/maemo/easysetup/modest-easysetup-wizard.c:
1137         (modest_easysetup_wizard_dialog_init):
1138         Try to get the source directory from the build system,
1139         instead of hard-coding "./" into the source code, when opening our local
1140         copies of the configuration files.
1141         But this still fails when opening the wizard from the Accounts window,
1142         maybe because the working directory seems to change at runtime.
1143         So the wizard will fail the second time unless you copy the files into their
1144         proper locations - see the stdout warnings for the paths.
1145
1146         (create_page_account_details),(on_before_next):
1147         Check for existing non-server accounts instead of server accounts,
1148         so the default account name is useful again, and to prevent trying to
1149         recreate accounts.
1150
1151         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1152         Show the wizard when New is clicked.
1153
1154         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1155         (init_view): Show the column headers, and show the columns that are
1156         specified in the UI specs. However, something in Maemo's GTK+ prevents
1157         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1158         change the default account. This is despite unsetting the special properties.
1159
1160 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1161
1162         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1163         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1164         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1165         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1166         to make that clearer.
1167         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1168
1169 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1170
1171         * src/maemo/modest-account-view-window.c:
1172         (modest_account_view_window_init),
1173         (modest_account_view_window_new):
1174         Use the same buttons as specified in the
1175         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1176         the existing widgets, which never had a chance of working.
1177         Put the ModestAccountView treeview in a scrolled window.
1178         Do not repeat the initialization in both _init() and _new().
1179
1180         * src/widgets/modest-account-view.c: (update_account_view):
1181         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1182         this widget and window shows no accounts.
1183
1184         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1185
1186 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1187
1188         * src/maemo/easysetup/modest-easysetup-wizard.c:
1189         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1190         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1191         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1192         which seems wrong.
1193
1194         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1195         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1196         accounts exist yet, as in the UI spec.
1197
1198         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1199
1200 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1201
1202         * src/maemo/Makefile.am:
1203         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1204         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1205         New window for editing connection-specific smtp details.
1206         Not fully implemented.
1207
1208         * src/maemo/modest-connection-specific-smtp-window.c:
1209         (modest_connection_specific_smtp_window_finalize) :
1210         unref the tree model.
1211         (on_button_edit): Show the edit window.
1212
1213 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1214
1215         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1216         error for me.
1217
1218         * src/maemo/Makefile.am:
1219         * src/maemo/modest-connection-specific-smtp-window.c:
1220         * src/maemo/modest-connection-specific-smtp-window.h:
1221         New window for showing the list of connections, for connection-specific
1222         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1223         * src/maemo/easysetup/modest-easysetup-wizard.c:
1224         (create_page_custom_outgoing): Show the new window when the button is clicked.
1225
1226 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1227
1228         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1229         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1230         * src/maemo/modest-msg-edit-window.c:
1231         (modest_msg_edit_window_insert_image):
1232         * src/modest-conf.c: (modest_conf_key_escape):
1233         * src/modest-mail-operation.c:
1234         (modest_mail_operation_send_new_mail):
1235         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1236         (modest_ui_actions_on_new_account):
1237         * src/widgets/modest-attachment-view.c: (update_filename_request):
1238         * src/widgets/modest-mail-header-view.c:
1239         Corrected warnings that were breaking the build, by commenting out unused variables,
1240         and a function, and by including a header.
1241
1242 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1243
1244         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1245         so we can #ifdef around platform-specific code when necessary.
1246         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1247         to allow this to build for the GNOME platform too.
1248
1249 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1250
1251         * src/maemo/easysetup/modest-easysetup-wizard.c:
1252         Added util_increment_name() and used it in create_page_account_details()
1253         to make sure that the default account name is always a new name.
1254
1255         (modest_easysetup_wizard_dialog_init),
1256         (set_default_custom_servernames): Some minor memory management fixes.
1257
1258 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1259
1260         * Makefile.am:
1261         * configure.ac:
1262         * src/modest-runtime.c: (init_i18n): Restored the translation
1263         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1264         are defined in config.h, and the translations are installed.
1265
1266         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1267         is defined for translation.
1268
1269 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1270
1271         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1272         (load_from_file):
1273         * src/maemo/easysetup/modest-easysetup-wizard.c:
1274         (modest_easysetup_wizard_dialog_init):
1275         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1276         Use realistic paths (though they should use $prefix generically) to the
1277         mcc_mapping and provider-data.keyfile files which might work when they
1278         are installed by the future version of the operator-wizard package,
1279         and then fallback to paths in our source code, with an explanatory
1280         warning.
1281
1282 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1283
1284         * configure.ac:
1285         * src/Makefile.am:
1286         * src/maemo/Makefile.am:
1287         * src/maemo/easysetup/: Added files from the previously-exernal
1288         osso-modest-easysetup.
1289         * src/maemo/modest-main-window-ui.h:
1290         * src/modest-ui-actions.c:
1291         * src/modest-ui-actions.h:
1292         Added modest_ui_actions_on_new_account() as a signal handler for the
1293         New Account menu item. It shows the easysetup wizard.
1294         * po/en_GB.po: Added additional needed logical IDs and translations.
1295
1296 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1297 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1298