git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/modest-platform.c:
   4         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
   5         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
   6         from being shown.
   7
   8 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
   9
  10         * src/widgets/modest-window.h:
  11         * src/widgets/modest-window.c: Added a save_state_func vfunc,
  12         and modest_window_save_state(), which invokes it.
  13
  14         * src/widgets/modest-window-mgr.h:
  15         * src/widgets/modest-window-mgr.c:
  16         Added modest_window_mgr_save_state_for_all_windows(), which calls
  17         the save_state vfunc on all registered windows, if implemented.
  18
  19         * src/gnome/modest-msg-edit-window.c:
  20         * src/gnome/modest-msg-view-window.c:
  21         * src/maemo/modest-msg-edit-window.c:
  22         * src/maemo/modest-msg-view-window.c:
  23         * src/maemo/modest-main-window.c:
  24         Specify the existing save_settings functions as implementations of
  25         ModestWindow::save_state_func().
  26
  27         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
  28         Call modest_window_mgr_save_state_for_all_windows(). This happens before
  29         enabling hibernation, for instance.
  30
  31         We may need to do the same thing for restoring settings.
  32
  33
  34 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  35
  36         * src/widgets/modest-window-mgr.c:
  37         * src/widgets/modest-window-mgr.h:
  38         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
  39         modest_window_mgr_get_hibernation_is_prevented().
  40
  41         * src/maemo/modest-main-window.c:
  42         (on_hildon_program_is_topmost_notify): Prevent hibernation
  43         (possible when the application goes to the background in the WM),
  44         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
  45
  46         * src/maemo/easysetup/modest-easysetup-wizard.c:
  47         (modest_easysetup_wizard_dialog_init):
  48         * src/maemo/modest-account-settings-dialog.c:
  49         (modest_account_settings_dialog_init):
  50         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  51         (modest_connection_specific_smtp_edit_window_init):
  52         * src/maemo/modest-connection-specific-smtp-window.c:
  53         (modest_connection_specific_smtp_window_init):
  54         * src/maemo/modest-signature-editor-dialog.c:
  55         (modest_signature_editor_dialog_init):
  56         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
  57         prevent hibernation while any of these account settings dialogs are open.
  58
  59 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
  60
  61         * src/maemo/Makefile.am:
  62         * src/maemo/modest-osso-state-saving.c:
  63         * src/maemo/modest-osso-state-saving.h: Added
  64         modest_osso_load_state() and modest_osso_save_state() though they do
  65         nothing now. They should iterate through all the open windows and load/save
  66         their state.
  67         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
  68         save state when closing.
  69
  70         * src/maemo/modest-main-window.c:
  71         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
  72         Add a notification handler for the HildonProgram::is-topmost property,
  73         so we can allow hibernation when the application goes into the background.
  74         But we still need to detect when the accounts setup windows are open so
  75         we can stop hibernation when they are open.
  76         To do this, I also added the main window the HildonProgram. This might have
  77         other side-effects/benefits, and should maybe be done for other windows.
  78
  79         * src/maemo/modest-osso-autosave-callbacks.h:
  80         * src/maemo/modest-osso-autosave-callbacks.c:
  81         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
  82         though it does not do anything yet, and we might never need this to do
  83         anything. For instance, we already save drafts.
  84
  85         * src/maemo/modest-platform.c: (modest_platform_init):
  86         Specify the libosso auto-save callback.
  87
  88 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
  89
  90         * src/maemo/modest-platform.c:
  91         (modest_platform_set_update_interval):
  92         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
  93         aparently stays valid between application instances, so we can use this
  94         to remove and reset it later. According to a maemo-developers email from
  95         David Weinehall.
  96
  97 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
  98
  99         * configure.ac: Depend on libalarm for Maemo.
 100
 101         * src/dbus_api/modest-dbus-api.h:
 102         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 103         (on_send_receive), (modest_dbus_req_handler):
 104         Handle a SEND_RECEIVE D-Bus method.
 105
 106         * libmodest-dbus-client/libmodest-dbus-client.c:
 107         (libmodest_dbus_client_send_and_receive):
 108         * libmodest-dbus-client/libmodest-dbus-client.h:
 109         Add C convenience functions for calling the new D-Bus method.
 110
 111         * src/modest-platform.h:
 112         * src/gnome/modest-platform.c:
 113         * src/maemo/modest-platform.c:
 114         Added modest_platform_set_update_interval(), which uses the
 115         alarmd API on Maemo.
 116         (modest_platform_init),
 117         Call modest_platform_set_update_interval(), using a hard-coded
 118         interval for now (until the global settings dialog is implemented),
 119         though I am not sure that this makes sense yet.
 120
 121 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 122
 123         * src/dbus_api/modest-dbus-callbacks.c:
 124         (modest_osso_cb_hw_state_handler):
 125         * src/dbus_api/modest-dbus-callbacks.h:
 126         * src/maemo/modest-platform.c: (modest_platform_init):
 127         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 128         in case this has some effect on the ability for Maemo to ping the
 129         application.
 130
 131 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 132
 133         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 134         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 135         warning. It is probably a logic error, but I need to fix the build.
 136
 137 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 138
 139         * src/modest-account-mgr.h:
 140         * src/modest-account-mgr.c:
 141         (modest_account_mgr_account_names): Add a gboolean enabled_only
 142         parameter, so we can get lists of onlt the enabled accounts.
 143
 144         (modest_account_mgr_add_account),,
 145         (modest_account_mgr_account_with_display_name_exists):
 146         * src/maemo/modest-msg-edit-window.c: (get_transports):
 147         * src/modest-account-mgr-helpers.c:
 148         (modest_account_mgr_set_first_account_as_default):
 149         * src/modest-init.c: (init_default_account_maybe):
 150         * src/modest-tny-account-store.c: (get_accounts):
 151         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 152         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 153         * tests/check_account-mgr.c: (START_TEST):
 154         Provide the extra parameter, as appropriate.
 155
 156         * src/widgets/modest-account-view.c: (update_account_view):
 157         Do not show disabled accounts (meaning that there is no way to
 158         enable/disable accounts in the UI (the feature is not in our UI
 159         specification), so we can use this internally only to mark unfinished
 160         or temporary account data.
 161
 162         * src/maemo/easysetup/modest-easysetup-wizard.c:
 163         (create_account): Add boolean enable parameter, so we can specify FALSE
 164         to create the temporary account.
 165         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 166         (on_before_next): When finishing, when there is a temporary account, just
 167         set it as enabled.
 168         Also, use a timeout to delay the showing of the dialog until gconf is likely
 169         to return correct information, due to a maemo gconf bug that is fixed in
 170         osso 1.1, but not yet in Bora.
 171         However, the dialog stays on screen after it is destroyed.
 172
 173         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 174         for invalid data when cancelling. Use a hildon note instead of a dialog
 175         to complain about invalid data. Do not show the account-saved note if the
 176         account is disabled (a temporary account that will not really be saved for use
 177         until later.)
 178
 179 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 180
 181         * src/modest-account-mgr-helpers.h:
 182         * src/modest-account-mgr-helpers.c:
 183         Added modest_account_mgr_unset_default_account(),
 184         Added modest_account_mgr_set_first_account_as_default().
 185
 186         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 187         If it was the default account, unset the default account name.
 188
 189         * src/maemo/modest-account-view-window.c:
 190         (on_delete_button_clicked): If it was the default account,
 191         set the first remaining account as the default instead.
 192
 193         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 194         a NULL account or a NULL default account, to prevent a crash. This should
 195         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 196
 197
 198 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 199
 200         * src/widgets/modest-recpt-editor.c:
 201         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 202         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 203         TODO comment for this. This fixes the build.
 204
 205         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 206         be the best place for it. This will in future update all auto-update accounts,
 207         rather than just the current/default account, when that gconf key exists.
 208         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 209         if there are no accounts, before calling do_send_receive().
 210         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 211
 212         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 213         * src/maemo/modest-main-window-ui.h:
 214         * src/maemo/modest-main-window.c: (on_connection_changed),
 215         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 216         directly, becaue the signal handler does more.
 217
 218 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 219
 220         * src/modest-account-mgr-helpers.c:
 221         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 222         for the case that the account does not exist.
 223
 224         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 225         (equivalent to the modest account name) rather than the tinymail account name
 226         (equivalent to the modest account title - human readable) to get the account data.
 227         Check for null account data to prevent the crash, and add a TODO comment saying that
 228         this needs fixing because it is using the server account name instead of the account name.
 229
 230 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 231
 232         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 233         * src/maemo/modest-account-settings-dialog.c: (show_error),
 234         (show_ok):
 235         Use hildon_note_new_information() for informative and error messages,
 236         which seems to be expected for Maemo applications (no documentation that I know of
 237         says this). I am surprised that there is no distinction between info and error
 238         dialogs.
 239
 240 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 241
 242         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 243         it is easy to find where this is used.
 244
 245         * src/maemo/easysetup/modest-easysetup-wizard.c:
 246         (create_page_welcome), (create_page_account_details),
 247         (create_page_user_details), (create_page_complete_easysetup),
 248         (create_page_custom_incoming), (create_page_custom_outgoing),
 249         (create_page_complete_custom):
 250         * src/maemo/modest-account-settings-dialog.c:
 251         (create_page_account_details), (create_page_user_details),
 252         (create_page_incoming), (create_page_outgoing):
 253         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 254         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 255         (modest_connection_specific_smtp_edit_window_init):
 256         * src/maemo/modest-connection-specific-smtp-window.c:
 257         (modest_connection_specific_smtp_window_init):
 258         * src/maemo/modest-signature-editor-dialog.c:
 259         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 260         and scrolling policy as per the Email Application Layout Guide, if I have
 261         understood it.
 262
 263 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 264
 265         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 266         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 267         which were empty, because these vfuncs have been removed from TnyAccountStore.
 268         This fixes the build.
 269
 270 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 271
 272         * src/maemo/modest-main-window.c:
 273         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 274         showing/hiding it. Added TODO because it probably should not be NULL.
 275         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 276         because unnecessary g_warnings() make degugging difficult.
 277
 278 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 279
 280         * src/maemo/modest-msg-edit-window.c:
 281         (modest_msg_edit_window_select_color),
 282         (modest_msg_edit_window_select_background_color): 2 const corrections and
 283         moving 2 #endifs before closing brackets, to fix the build.
 284
 285 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 286
 287         * src/maemo/easysetup/modest-easysetup-wizard.h:
 288         * src/maemo/easysetup/modest-easysetup-wizard.c:
 289         (modest_easysetup_wizard_dialog_finalize),
 290         (on_button_edit_advanced_settings), (create_page_complete_custom),
 291         (on_response), (create_account):
 292         Implement the Advanced Settings edit button, by saving the account information,
 293         for the Advanded Settings dialog to use directly from gconf, and removing it
 294         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 295         Bug #5533 in the projects.maemo.org bugzilla.
 296
 297 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 298
 299         * src/maemo/modest-msg-view-window.c:
 300         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 301         when opening a message window.
 302
 303 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 304
 305         * src/maemo/easysetup/modest-easysetup-wizard.c:
 306         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 307         match the UI spec.
 308
 309         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 310         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 311         gconf settings. I probably added more checks than necessary, but that is safer.
 312
 313         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 314         variable to fix the build, but this seems to be used when it is still NULL.
 315
 316 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 317
 318         * src/modest-platform.h:
 319         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 320         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 321         * src/modest-main.c: Implement this function so we can avoid using
 322         maemo-specific API from cross-platform code.
 323         (main):
 324         * src/modest-tny-account-store.c:
 325         (get_smtp_specific_transport_account_for_open_connection):
 326         * src/modest-ui-actions.c: (check_for_connection),
 327         (modest_ui_actions_on_item_not_found):
 328         Use modest_platform_connect_and_wait() and put #idefs around other
 329         maemo-specific code, because only maemo currently has a way to
 330         identify connection names.
 331
 332 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 333
 334         * src/modest-tny-account-store.h:
 335         * src/modest-tny-account-store.c:
 336         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 337         the connection-specific SMTP server settings in the configuration.
 338
 339         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 340         (on_idle_mail_to):
 341         * src/maemo/modest-main-window.c: (on_connection_changed),
 342         (connect_signals):
 343         * src/modest-main.c: (main), (start_ui), (send_mail):
 344         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 345         that is what is intended.
 346
 347         * src/modest-ui-actions.c: (action_send), (action_receive),
 348         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 349         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 350         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 351         SMTP server is used when it is specified.
 352
 353         (modest_ui_actions_on_send_receive):
 354         Check that a connection is open before proceeding.
 355         Receive and then send, instead of vice-versa, as per the specification.
 356
 357 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 358
 359         * src/modest-mail-operation.c:
 360         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 361         though I guess it should be something other than NULL.
 362
 363 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 364
 365         * src/maemo/easysetup/modest-easysetup-wizard.c:
 366         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 367         combo twice, to avoid an g_warning and to make it visible again.
 368         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 369         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 370         (already intended) dereference when detaching, because we then recreate the menu.
 371         But I am not sure why the warning was happening, and it is possible that this is a memory
 372         leak.
 373
 374 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 375
 376         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 377         and uri_parse_mailto() utility functions.
 378         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 379         the mailto URI.
 380         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 381
 382 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 383
 384         * src/dbus_api/modest-dbus-api.h:
 385         * src/dbus_api/modest-dbus-callbacks.c:
 386         Use an idle callback to execute the modest code in the application's own thread.
 387         Remove the helloworld example method.
 388         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 389         parsed, and the open-message method is not implemented because this is not yet implemented in
 390         modest itself.
 391         * libmodest-dbus-client/libmodest-dbus-client.c:
 392         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 393         (libmodest_dbus_client_open_message):
 394         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 395
 396         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 397         body without crashing.
 398
 399         * tests/dbus_api/Makefile.am:
 400         * tests/dbus_api/test_mail_to.c:
 401         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 402
 403 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 404
 405         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 406         Added file to fix the build. Sorry.
 407
 408         * src/dbus_api/Makefile.am:
 409         * src/dbus_api/modest-dbus-api.h:
 410         * src/dbus_api/modest-dbus-callbacks.h:
 411         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 412         (modest_dbus_req_handler):
 413         Put constants in a separate header so it can be reused by the
 414         client library, without duplication
 415
 416         * libmodest-dbus-client/Makefile.am:
 417         * libmodest-dbus-client/libmodest-dbus-client.c:
 418         (libmodest_dbus_client_call_helloworld),
 419         (libmodfest_dbus_client_send_mail),
 420         (libmodfest_dbus_client_mailto),
 421         (libmodfest_dbus_client_open_message):
 422         * libmodest-dbus-client/libmodest-dbus-client.h:
 423         (Partly) Implement a send_mail D-Bus method.
 424
 425         * tests/dbus_api/Makefile.am:
 426         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 427         the send_email D-Bus method.
 428
 429 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 430
 431         * Makefile.am:
 432         * configure.ac:
 433         * libmodest-dbus-client/Makefile.am:
 434         * libmodest-dbus-client/libmodest-dbus-client.c:
 435         * libmodest-dbus-client/libmodest-dbus-client.h:
 436         * tests/dbus_api/Makefile.am:
 437         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 438         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 439
 440 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 441
 442         * src/maemo/easysetup/modest-easysetup-wizard.c:
 443         (create_page_account_details):
 444         * src/maemo/modest-account-settings-dialog.c:
 445         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 446         widgets, because this might not be the default in future versions of the Maemo GTK+.
 447         However, I can not not get capitalization to work even in a simple test case.
 448
 449 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 450
 451         * src/maemo/easysetup/modest-easysetup-wizard.c:
 452         (create_page_custom_incoming), (create_page_custom_outgoing):
 453         * src/maemo/modest-account-settings-dialog.c:
 454         (create_page_account_details), (create_page_incoming),
 455         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 456         instead of using gtk_check_button_with_label(), so they are aligned like the other
 457         widgets, as per the UI spec.
 458
 459 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 460
 461         * src/maemo/easysetup/modest-easysetup-wizard.c:
 462         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 463         * src/widgets/modest-validating-entry.c:
 464         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 465         Modest prefix instead of an EasySetup prefix.
 466
 467 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 468
 469         * src/widgets/modest-validating-entry.h:
 470         * src/widgets/modest-validating-entry.c: (on_insert_text),
 471         Added easysetup_validating_entry_set_max_func(), used to set a callback
 472         to call when the max number of characters is reached. GtkEntry has a max-length
 473         already but is silent about it.
 474
 475         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 476         (create_page_account_details), (create_page_user_details),
 477         (create_account):
 478         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 479         (create_page_account_details), (create_page_user_details),
 480         (create_page_outgoing):
 481         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 482         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 483         the UI spec, when the user tries to enter more than the max number of characters.
 484
 485 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 486
 487         * src/maemo/easysetup/modest-easysetup-wizard.c:
 488         (create_page_user_details), (create_page_custom_incoming),
 489         (create_page_custom_outgoing):
 490         * src/maemo/modest-account-settings-dialog.c:
 491         (create_page_user_details), (create_page_incoming),
 492         (create_page_outgoing):
 493         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 494         (modest_connection_specific_smtp_edit_window_init):
 495         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 496         not appropriate. Bad Maemo-specific defaults!.
 497
 498 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 499
 500         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 501         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 502         (modest_signature_editor_dialog_set_settings):
 503         Disable the label and textview when the checkbox is disabled, and use the
 504         specified (UI spec) default signature text.
 505
 506 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 507
 508         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 509         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 510
 511         * src/modest-defs.h:
 512         * src/modest-account-mgr-helpers.h:
 513         * src/modest-account-mgr-helpers.c:
 514         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 515
 516         * src/maemo/Makefile.am:
 517         * src/maemo/modest-signature-editor-dialog.c:
 518         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 519         as per the UI spec.
 520
 521         * src/maemo/modest-account-settings-dialog.h:
 522         * src/maemo/modest-account-settings-dialog.c:
 523         (modest_account_settings_dialog_finalize), (on_button_signature),
 524         (save_configuration): Use the new dialog when the Edit button is pressed, and
 525         save the changes if necessary, as per the UI spec.
 526
 527 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 528
 529         * src/maemo/Makefile.am:
 530         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 531         based on maemo-develoers email from Dirk.
 532
 533         * src/maemo/easysetup/modest-easysetup-wizard.c:
 534         (create_page_welcome), (create_page_account_details),
 535         (create_page_user_details), (create_page_complete_easysetup),
 536         (create_page_custom_incoming), (create_page_custom_outgoing),
 537         (create_page_complete_custom),
 538         (modest_easysetup_wizard_dialog_init):
 539         * src/maemo/modest-account-settings-dialog.c:
 540         (create_page_account_details), (create_page_user_details),
 541         (create_page_incoming), (create_page_outgoing),
 542         (modest_account_settings_dialog_init):
 543         * src/maemo/modest-connection-specific-smtp-window.c:
 544         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 545
 546 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 547
 548         * src/maemo/easysetup/modest-easysetup-wizard.c:
 549         (create_page_account_details), (create_page_custom_outgoing),
 550         (create_page_complete_custom):
 551         * src/maemo/modest-account-settings-dialog.c:
 552         (create_page_user_details), (create_page_incoming),
 553         (create_page_outgoing):
 554         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 555         (modest_connection_specific_smtp_edit_window_init):
 556         Use the correct (UI spec) port min/max, and use horizontal separators,
 557         as per the UI spec.
 558
 559 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 560
 561         * src/maemo/easysetup/modest-easysetup-wizard.c:
 562         (set_default_custom_servernames):
 563         * src/maemo/modest-account-settings-dialog.c:
 564         (create_page_incoming), (on_combo_outgoing_security_changed),
 565         (on_combo_incoming_security_changed), (create_page_outgoing),
 566         (modest_account_settings_dialog_set_account_name),
 567         (save_configuration):
 568         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 569         (on_combo_security_changed),
 570         (modest_connection_specific_smtp_edit_window_init),
 571         (modest_connection_specific_smtp_edit_window_set_connection),
 572         (modest_connection_specific_smtp_edit_window_get_settings):
 573         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 574         as per the UI spec.
 575
 576 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 577
 578         * po/en_GB.po:
 579         * src/maemo/easysetup/modest-easysetup-wizard.c:
 580         (create_page_custom_outgoing), (create_page_complete_custom):
 581         * src/maemo/modest-account-settings-dialog.c:
 582         (create_page_user_details), (create_page_outgoing):
 583         * src/maemo/modest-account-view-window.c: (button_box_new):
 584         Use changed logical IDs as per the most recent UI spec:
 585         mcen_bd_emailsetup_edit -> mcen_bd_edit
 586         mcen_bd_emailsetup_delete -> mcen_bd_delete
 587         mcen_bd_emailsetup_close -> mcen_bd_close
 588
 589 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 590
 591         * configure.ac:
 592         * src/Makefile.am:
 593         * src/dbus_api/Makefile.am:
 594         * src/dbus_api/modest-dbus-callbacks.c:
 595         * src/dbus_api/modest-dbus-callbacks.h:
 596         * src/maemo/modest-platform.c: (modest_platform_init):
 597         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 598         method.
 599         * tests/Makefile.am:
 600         * tests/dbus_api/Makefile.am:
 601         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 602
 603 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 604
 605         * src/maemo/modest-account-settings-dialog.c:
 606         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 607         Removed unnecessary includes.
 608
 609 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 610
 611         * src/maemo/easysetup/modest-easysetup-wizard.c:
 612         * src/maemo/modest-account-settings-dialog.c:
 613         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 614         * src/widgets/Makefile.am:
 615         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 616         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 617         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 618         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 619         * src/widgets/modest-secureauth-combo-box.c:
 620         * src/widgets/modest-secureauth-combo-box.h:
 621         * src/widgets/modest-serversecurity-combo-box.c:
 622         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 623         made the GObject names more consistent with the rest of the Modest code.
 624
 625 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 626
 627         * src/maemo/easysetup/Makefile.am:
 628         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 629         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 630         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 631         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 632         * src/maemo/easysetup/modest-easysetup-wizard.c:
 633         * src/maemo/easysetup/modest-validating-entry.c:
 634         * src/maemo/easysetup/modest-validating-entry.h:
 635         * src/maemo/modest-account-settings-dialog.c:
 636         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 637         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 638         widgets/ because they are used outside of easysetup too. After checking in,
 639         svn will allow me to rename them too.
 640
 641 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 642
 643         * src/gnome/modest-msg-edit-window.c:
 644         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 645         linker error, to fix the build on the GNOME platform.
 646         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 647         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 648         ifdefed out to avoid a warning.
 649
 650 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 651
 652         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 653         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 654         some alternative for GTK+ 2.6.
 655
 656 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 657
 658         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 659
 660         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 661         specified for EmailAccountsDialog in UI spec.
 662
 663         * src/maemo/easysetup/modest-easysetup-wizard.c:
 664         * src/maemo/easysetup/modest-easysetup-wizard.h:
 665         * src/maemo/modest-account-settings-dialog.c:
 666         * src/maemo/modest-account-settings-dialog.h:
 667         Reuse a member window widget for the connection-specific SMTP server accounts,
 668         so we can tell it to create/save the accounts only if we actually save changes.
 669
 670         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 671         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 672         (modest_connection_specific_smtp_edit_window_get_settings):
 673         Return a struct instance for temporarily remembering the entered data.
 674
 675         * src/maemo/modest-connection-specific-smtp-window.h:
 676         * src/maemo/modest-connection-specific-smtp-window.c:
 677         (modest_connection_specific_smtp_window_finalize),
 678         (modest_connection_specific_smtp_window_fill_with_connections),
 679         (on_button_edit),
 680         (modest_connection_specific_smtp_window_save_server_accounts),
 681         (update_model_server_names): Do not actually save data until asked,
 682         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 683
 684         (on_selection_changed),
 685         (modest_connection_specific_smtp_window_init): Disable the edit
 686         button when nothing is selected.
 687
 688         * src/modest-account-mgr-helpers.c:
 689         * src/modest-account-mgr-helpers.h:
 690         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 691         elsewhere.
 692
 693 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 694
 695         * src/modest-account-mgr-helpers.h:
 696         * src/modest-account-mgr-helpers.c:
 697         (modest_account_mgr_get_unused_account_name),
 698         (modest_account_mgr_get_unused_account_display_name): Added these
 699         utility functions, to avoid code duplication.
 700
 701         * src/maemo/easysetup/modest-easysetup-wizard.c:
 702         (create_page_account_details), (create_account):
 703         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 704         (on_combo_security_changed),
 705         (modest_connection_specific_smtp_edit_window_init),
 706         (modest_connection_specific_smtp_edit_window_save_settings):
 707         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 708         * src/maemo/modest-connection-specific-smtp-window.c:
 709         (modest_connection_specific_smtp_window_finalize),
 710         (modest_connection_specific_smtp_window_fill_with_connections),
 711         (on_button_edit), (modest_connection_specific_smtp_window_init):
 712         * src/maemo/modest-connection-specific-smtp-window.h:
 713         Implementing saving of connection-specific server accounts.
 714
 715         But I need to refactor this so we can save the data for each
 716         possible connection-specific account and only actually create the server accounts
 717         when the easysetup finished, or the OK button is pressed on the account settings
 718         dialog.
 719
 720 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 721
 722         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 723         (on_combo_security_changed):
 724         (modest_connection_specific_smtp_edit_window_init):
 725         Auto-fill the port number as in the account settings.
 726
 727         (modest_connection_specific_smtp_edit_window_set_connection):
 728         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 729         * src/maemo/modest-connection-specific-smtp-window.c:
 730         (fill_with_connections), (on_button_edit),
 731         (modest_connection_specific_smtp_window_init):
 732         Turn the edit window into a dialog to simplify the code, and
 733         set a WM hint as in a GtkDialog, because only a popup can be on top of
 734         another window in Maemo, and popups usually have no WM decoration.
 735
 736         * src/modest-defs.h:
 737         * src/modest-account-mgr-helpers.c:
 738         (modest_account_mgr_set_connection_specific_smtp),
 739         (modest_account_mgr_remove_connection_specific_smtp),
 740         (modest_account_mgr_get_connection_specific_smtp):
 741         * src/modest-account-mgr-helpers.h: Some functions to write the
 742         connection-specific SMTP server information. Not yet used.
 743
 744
 745         * src/widgets/modest-folder-view.c: (text_cell_data):
 746         Fix a warning about an uninitialized variable.
 747         (on_configuration_key_changed): Put an #ifdef around the use
 748         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 749
 750 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 751
 752         * src/maemo/modest-account-settings-dialog.h:
 753         * src/maemo/modest-account-settings-dialog.c:
 754         Added connect_for_modified() utility function to mark the new modified boolean.
 755
 756         (create_page_account_details), (create_page_user_details),
 757         (create_page_incoming), (create_page_outgoing), (on_response),
 758         (modest_account_settings_dialog_init),
 759         (modest_account_settings_dialog_set_account_name):
 760         Only warn about unsaved changes when there are actually unsaved changes.
 761
 762         * src/modest-account-mgr-helpers.c:
 763         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 764         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 765         to get the data from there in future.
 766
 767 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 768
 769         * src/modest-defs.h:
 770
 771         * src/modest-account-mgr-helpers.h:
 772         * src/modest-account-mgr-helpers.c:
 773         Store the security account setting in a single conf key instead of using
 774         the options list, so that the list is left for just the to-be-removed camel hack,
 775         and because gconf_client_set_list() is failing for some reason.
 776
 777         * src/modest-account-mgr.c:
 778         (modest_account_mgr_add_server_account):
 779         * src/maemo/modest-account-settings-dialog.c:
 780         (modest_account_settings_dialog_set_account_name),
 781         (save_configuration): Use the renamed functions.
 782
 783
 784 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 785
 786         * src/widgets/Makefile.am:
 787         * src/widgets/modest-limit-retrieve-combo-box.c:
 788         * src/widgets/modest-limit-retrieve-combo-box.h:
 789         * src/widgets/modest-retrieve-combo-box.c:
 790         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 791         the account settings dialog.
 792
 793         * src/modest-defs.h:
 794         * src/modest-account-mgr-helpers.h:
 795         * src/modest-account-mgr-helpers.c:
 796         (modest_server_account_get_option_secure_auth),
 797         (modest_server_account_set_option_secure_auth):
 798         * src/modest-account-mgr.c:
 799         (modest_account_mgr_add_server_account):
 800         Use the existing AUTH_MECH conf key for the secure-auth setting,
 801         instead of putting it in the list options, because this was actually used already.
 802
 803         * src/maemo/modest-account-settings-dialog.c:
 804         (create_page_account_details),
 805         (modest_account_settings_dialog_set_account_name),
 806         (save_configuration):
 807         * src/maemo/modest-account-settings-dialog.h:
 808         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 809         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 810
 811 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 812
 813         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 814         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 815         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 816
 817         * src/modest-defs.h:
 818         * src/maemo/modest-account-settings-dialog.c:
 819         (create_page_incoming), (on_combo_outgoing_security_changed),
 820         (on_combo_incoming_security_changed), (create_page_outgoing),
 821         (modest_account_settings_dialog_set_account_name),
 822         (save_configuration): Load/Save the port number, and change it when the
 823         security combo changes, to suitable defaults.
 824
 825 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 826
 827         * src/modest-account-mgr.c:
 828         (modest_account_mgr_add_server_account): Set the security and secure-auth
 829         options, and add a comment saying that the other camel-specific options should be
 830         removed in future.
 831
 832 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 833
 834         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 835         found by valgrind.
 836         * src/modest-tny-account-store.c: (account_list_free),
 837         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 838         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 839         easy to fix.
 840
 841 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 842
 843         * src/modest-protocol-info.c:
 844         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 845         is required by our UI spec. Maybe something in our implementation will use this eventually.
 846         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 847         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 848         instead of the previous 0 placeholder.
 849
 850         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 851         secure-auth settings.
 852         * src/modest-account-mgr-helpers.h:
 853         * src/modest-account-mgr-helpers.c:
 854         (modest_server_account_data_get_option_secure_auth),
 855         (modest_server_account_set_option_secure_auth),
 856         (modest_server_account_data_get_option_security),
 857         (modest_server_account_set_option_security): Added this API for getting and setting the security
 858         and secure-auth settings.
 859
 860         * src/maemo/modest-account-settings-dialog.h:
 861         * src/maemo/modest-account-settings-dialog.c:
 862         (modest_account_settings_dialog_finalize), (check_data),
 863         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 864         about changing titles.
 865         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 866         (save_configuration): Save the security and secure-auth settings.
 867
 868         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 869         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 870
 871 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 872
 873         * src/modest-defs.h:
 874         * src/modest-account-mgr.c:
 875         (modest_account_mgr_add_server_account):
 876         Added and used defines for the options key and value pair strings,
 877         that are used so far, though they do not seem to correspond to anything in our
 878         UI specs or ModestProtocol enum.
 879
 880         * src/modest-account-mgr-helpers.h:
 881         * src/modest-account-mgr-helpers.c:
 882         (compare_option_strings_for_name),
 883         (modest_server_account_data_get_option_value),
 884         (modest_server_account_data_get_option_bool),
 885         (modest_account_mgr_get_server_account_option):
 886         Added helper functions for parsing the options GSList.
 887
 888 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 889
 890         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 891         display name is based on the supplied account name.
 892         * src/modest-account-mgr.c:
 893         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 894         with an inefficient, but good-enough, implementation.
 895
 896         * src/maemo/easysetup/modest-easysetup-wizard.c:
 897         (create_page_account_details), (on_before_next), (create_account):
 898         Check for existing display names rather than (non-user-visible) account names, and just
 899         create and set a unique account name at the end.
 900
 901         * src/maemo/modest-account-settings-dialog.c:
 902         (modest_account_settings_dialog_init),
 903         (modest_account_settings_dialog_set_account_name),
 904         (create_page_incoming): Show the display name, instead of the account name.
 905         (on_response): Do some (not all) extra checks, as in the UI spec.
 906         (save_configuration): Save the display name if it was changed.
 907
 908 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 909
 910         * po/en_GB.po: Added needed logical ID and translation.
 911         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 912         (init_view): Made the is-default column clicking work.
 913
 914 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 915
 916         * configure.ac:
 917         * src/maemo/easysetup/Makefile.am:
 918         * src/maemo/easysetup/modest-easysetup-wizard.c:
 919         (modest_easysetup_wizard_dialog_init):
 920         * src/maemo/easysetup/provider-data-test.keyfile:
 921         * src/maemo/easysetup/provider-data.keyfile:
 922         Moved the provider data file to the new modest-providers-data package and used it from there.
 923
 924 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 925
 926         * src/modest-local-folder-info.c:
 927         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 928         N_() was already used on the static strings, but this just marks it for translation without
 929         using the translation.
 930
 931 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 932
 933         * src/maemo/modest-account-settings-dialog.c:
 934         (create_page_incoming),
 935         (modest_account_settings_dialog_set_account_name):
 936         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 937         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 938         I will do this if nobody else gets there first.
 939
 940 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 941
 942         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 943         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 944         save the security stuff.
 945
 946 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 947
 948         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 949         Set the email address and user fullname, which I now see must be
 950         done separately.
 951
 952         * src/maemo/modest-account-settings-dialog.h:
 953         * src/maemo/modest-account-settings-dialog.c:
 954          (on_response),
 955         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 956         leave-on-server and authentication.
 957         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 958         how to do the rest.
 959
 960 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 961
 962
 963         * src/maemo/modest-account-settings-dialog.c:
 964         * src/maemo/modest-account-settings-dialog.h:
 965         Most (but not all) of the widgets are now present as specified by the UI spec.
 966         No changes are yet saved, and some details are not properly shown yet.
 967
 968         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 969
 970 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 971
 972         * src/maemo/Makefile.am:
 973         * src/maemo/modest-account-settings-dialog.c:
 974         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 975         an existing account. Doesn't do much yet.
 976
 977         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 978         Open the accounts settings dialog when Edit is clicked.
 979
 980 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 981
 982         * src/maemo/easysetup/Makefile.am:
 983         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 984         (load_from_file):
 985         * src/maemo/easysetup/modest-easysetup-wizard.c:
 986         (modest_easysetup_wizard_dialog_init):
 987         Try to get the source directory from the build system,
 988         instead of hard-coding "./" into the source code, when opening our local
 989         copies of the configuration files.
 990         But this still fails when opening the wizard from the Accounts window,
 991         maybe because the working directory seems to change at runtime.
 992         So the wizard will fail the second time unless you copy the files into their
 993         proper locations - see the stdout warnings for the paths.
 994
 995         (create_page_account_details),(on_before_next):
 996         Check for existing non-server accounts instead of server accounts,
 997         so the default account name is useful again, and to prevent trying to
 998         recreate accounts.
 999
1000         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1001         Show the wizard when New is clicked.
1002
1003         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1004         (init_view): Show the column headers, and show the columns that are
1005         specified in the UI specs. However, something in Maemo's GTK+ prevents
1006         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1007         change the default account. This is despite unsetting the special properties.
1008
1009 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1010
1011         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1012         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1013         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1014         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1015         to make that clearer.
1016         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1017
1018 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1019
1020         * src/maemo/modest-account-view-window.c:
1021         (modest_account_view_window_init),
1022         (modest_account_view_window_new):
1023         Use the same buttons as specified in the
1024         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1025         the existing widgets, which never had a chance of working.
1026         Put the ModestAccountView treeview in a scrolled window.
1027         Do not repeat the initialization in both _init() and _new().
1028
1029         * src/widgets/modest-account-view.c: (update_account_view):
1030         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1031         this widget and window shows no accounts.
1032
1033         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1034
1035 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1036
1037         * src/maemo/easysetup/modest-easysetup-wizard.c:
1038         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1039         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1040         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1041         which seems wrong.
1042
1043         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1044         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1045         accounts exist yet, as in the UI spec.
1046
1047         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1048
1049 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1050
1051         * src/maemo/Makefile.am:
1052         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1053         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1054         New window for editing connection-specific smtp details.
1055         Not fully implemented.
1056
1057         * src/maemo/modest-connection-specific-smtp-window.c:
1058         (modest_connection_specific_smtp_window_finalize) :
1059         unref the tree model.
1060         (on_button_edit): Show the edit window.
1061
1062 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1063
1064         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1065         error for me.
1066
1067         * src/maemo/Makefile.am:
1068         * src/maemo/modest-connection-specific-smtp-window.c:
1069         * src/maemo/modest-connection-specific-smtp-window.h:
1070         New window for showing the list of connections, for connection-specific
1071         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1072         * src/maemo/easysetup/modest-easysetup-wizard.c:
1073         (create_page_custom_outgoing): Show the new window when the button is clicked.
1074
1075 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1076
1077         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1078         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1079         * src/maemo/modest-msg-edit-window.c:
1080         (modest_msg_edit_window_insert_image):
1081         * src/modest-conf.c: (modest_conf_key_escape):
1082         * src/modest-mail-operation.c:
1083         (modest_mail_operation_send_new_mail):
1084         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1085         (modest_ui_actions_on_new_account):
1086         * src/widgets/modest-attachment-view.c: (update_filename_request):
1087         * src/widgets/modest-mail-header-view.c:
1088         Corrected warnings that were breaking the build, by commenting out unused variables,
1089         and a function, and by including a header.
1090
1091 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1092
1093         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1094         so we can #ifdef around platform-specific code when necessary.
1095         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1096         to allow this to build for the GNOME platform too.
1097
1098 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1099
1100         * src/maemo/easysetup/modest-easysetup-wizard.c:
1101         Added util_increment_name() and used it in create_page_account_details()
1102         to make sure that the default account name is always a new name.
1103
1104         (modest_easysetup_wizard_dialog_init),
1105         (set_default_custom_servernames): Some minor memory management fixes.
1106
1107 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1108
1109         * Makefile.am:
1110         * configure.ac:
1111         * src/modest-runtime.c: (init_i18n): Restored the translation
1112         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1113         are defined in config.h, and the translations are installed.
1114
1115         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1116         is defined for translation.
1117
1118 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1119
1120         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1121         (load_from_file):
1122         * src/maemo/easysetup/modest-easysetup-wizard.c:
1123         (modest_easysetup_wizard_dialog_init):
1124         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1125         Use realistic paths (though they should use $prefix generically) to the
1126         mcc_mapping and provider-data.keyfile files which might work when they
1127         are installed by the future version of the operator-wizard package,
1128         and then fallback to paths in our source code, with an explanatory
1129         warning.
1130
1131 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1132
1133         * configure.ac:
1134         * src/Makefile.am:
1135         * src/maemo/Makefile.am:
1136         * src/maemo/easysetup/: Added files from the previously-exernal
1137         osso-modest-easysetup.
1138         * src/maemo/modest-main-window-ui.h:
1139         * src/modest-ui-actions.c:
1140         * src/modest-ui-actions.h:
1141         Added modest_ui_actions_on_new_account() as a signal handler for the
1142         New Account menu item. It shows the easysetup wizard.
1143         * po/en_GB.po: Added additional needed logical IDs and translations.
1144
1145 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1146 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1147