git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/easysetup/modest-easysetup-wizard.c:
   4         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
   5         combo twice, to avoid an g_warning and to make it visible again.
   6         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
   7         attached before detaching it, to avoid a g_warning, and add comment about the implicit
   8         (already intended) dereference when detaching, because we then recreate the menu.
   9         But I am not sure why the warning was happening, and it is possible that this is a memory
  10         leak.
  11
  12 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
  13
  14         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
  15         and uri_parse_mailto() utility functions.
  16         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
  17         the mailto URI.
  18         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
  19
  20 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  21
  22         * src/dbus_api/modest-dbus-api.h:
  23         * src/dbus_api/modest-dbus-callbacks.c:
  24         Use an idle callback to execute the modest code in the application's own thread.
  25         Remove the helloworld example method.
  26         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
  27         parsed, and the open-message method is not implemented because this is not yet implemented in
  28         modest itself.
  29         * libmodest-dbus-client/libmodest-dbus-client.c:
  30         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
  31         (libmodest_dbus_client_open_message):
  32         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
  33
  34         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
  35         body without crashing.
  36
  37         * tests/dbus_api/Makefile.am:
  38         * tests/dbus_api/test_mail_to.c:
  39         * tests/dbus_api/test_open_message.c: New tests for the new methods.
  40
  41 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  42
  43         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
  44         Added file to fix the build. Sorry.
  45
  46         * src/dbus_api/Makefile.am:
  47         * src/dbus_api/modest-dbus-api.h:
  48         * src/dbus_api/modest-dbus-callbacks.h:
  49         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
  50         (modest_dbus_req_handler):
  51         Put constants in a separate header so it can be reused by the
  52         client library, without duplication
  53
  54         * libmodest-dbus-client/Makefile.am:
  55         * libmodest-dbus-client/libmodest-dbus-client.c:
  56         (libmodest_dbus_client_call_helloworld),
  57         (libmodfest_dbus_client_send_mail),
  58         (libmodfest_dbus_client_mailto),
  59         (libmodfest_dbus_client_open_message):
  60         * libmodest-dbus-client/libmodest-dbus-client.h:
  61         (Partly) Implement a send_mail D-Bus method.
  62
  63         * tests/dbus_api/Makefile.am:
  64         * tests/dbus_api/test_send_mail.c: (main): Added a test for
  65         the send_email D-Bus method.
  66
  67 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  68
  69         * Makefile.am:
  70         * configure.ac:
  71         * libmodest-dbus-client/Makefile.am:
  72         * libmodest-dbus-client/libmodest-dbus-client.c:
  73         * libmodest-dbus-client/libmodest-dbus-client.h:
  74         * tests/dbus_api/Makefile.am:
  75         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
  76         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
  77
  78 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  79
  80         * src/maemo/easysetup/modest-easysetup-wizard.c:
  81         (create_page_account_details):
  82         * src/maemo/modest-account-settings-dialog.c:
  83         (create_page_account_details): Explicitly set auto-capitalization mode for the title
  84         widgets, because this might not be the default in future versions of the Maemo GTK+.
  85         However, I can not not get capitalization to work even in a simple test case.
  86
  87 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  88
  89         * src/maemo/easysetup/modest-easysetup-wizard.c:
  90         (create_page_custom_incoming), (create_page_custom_outgoing):
  91         * src/maemo/modest-account-settings-dialog.c:
  92         (create_page_account_details), (create_page_incoming),
  93         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
  94         instead of using gtk_check_button_with_label(), so they are aligned like the other
  95         widgets, as per the UI spec.
  96
  97 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  98
  99         * src/maemo/easysetup/modest-easysetup-wizard.c:
 100         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 101         * src/widgets/modest-validating-entry.c:
 102         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 103         Modest prefix instead of an EasySetup prefix.
 104
 105 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 106
 107         * src/widgets/modest-validating-entry.h:
 108         * src/widgets/modest-validating-entry.c: (on_insert_text),
 109         Added easysetup_validating_entry_set_max_func(), used to set a callback
 110         to call when the max number of characters is reached. GtkEntry has a max-length
 111         already but is silent about it.
 112
 113         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 114         (create_page_account_details), (create_page_user_details),
 115         (create_account):
 116         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 117         (create_page_account_details), (create_page_user_details),
 118         (create_page_outgoing):
 119         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 120         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 121         the UI spec, when the user tries to enter more than the max number of characters.
 122
 123 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 124
 125         * src/maemo/easysetup/modest-easysetup-wizard.c:
 126         (create_page_user_details), (create_page_custom_incoming),
 127         (create_page_custom_outgoing):
 128         * src/maemo/modest-account-settings-dialog.c:
 129         (create_page_user_details), (create_page_incoming),
 130         (create_page_outgoing):
 131         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 132         (modest_connection_specific_smtp_edit_window_init):
 133         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 134         not appropriate. Bad Maemo-specific defaults!.
 135
 136 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 137
 138         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 139         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 140         (modest_signature_editor_dialog_set_settings):
 141         Disable the label and textview when the checkbox is disabled, and use the
 142         specified (UI spec) default signature text.
 143
 144 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 145
 146         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 147         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 148
 149         * src/modest-defs.h:
 150         * src/modest-account-mgr-helpers.h:
 151         * src/modest-account-mgr-helpers.c:
 152         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 153
 154         * src/maemo/Makefile.am:
 155         * src/maemo/modest-signature-editor-dialog.c:
 156         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 157         as per the UI spec.
 158
 159         * src/maemo/modest-account-settings-dialog.h:
 160         * src/maemo/modest-account-settings-dialog.c:
 161         (modest_account_settings_dialog_finalize), (on_button_signature),
 162         (save_configuration): Use the new dialog when the Edit button is pressed, and
 163         save the changes if necessary, as per the UI spec.
 164
 165 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 166
 167         * src/maemo/Makefile.am:
 168         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 169         based on maemo-develoers email from Dirk.
 170
 171         * src/maemo/easysetup/modest-easysetup-wizard.c:
 172         (create_page_welcome), (create_page_account_details),
 173         (create_page_user_details), (create_page_complete_easysetup),
 174         (create_page_custom_incoming), (create_page_custom_outgoing),
 175         (create_page_complete_custom),
 176         (modest_easysetup_wizard_dialog_init):
 177         * src/maemo/modest-account-settings-dialog.c:
 178         (create_page_account_details), (create_page_user_details),
 179         (create_page_incoming), (create_page_outgoing),
 180         (modest_account_settings_dialog_init):
 181         * src/maemo/modest-connection-specific-smtp-window.c:
 182         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 183
 184 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 185
 186         * src/maemo/easysetup/modest-easysetup-wizard.c:
 187         (create_page_account_details), (create_page_custom_outgoing),
 188         (create_page_complete_custom):
 189         * src/maemo/modest-account-settings-dialog.c:
 190         (create_page_user_details), (create_page_incoming),
 191         (create_page_outgoing):
 192         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 193         (modest_connection_specific_smtp_edit_window_init):
 194         Use the correct (UI spec) port min/max, and use horizontal separators,
 195         as per the UI spec.
 196
 197 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 198
 199         * src/maemo/easysetup/modest-easysetup-wizard.c:
 200         (set_default_custom_servernames):
 201         * src/maemo/modest-account-settings-dialog.c:
 202         (create_page_incoming), (on_combo_outgoing_security_changed),
 203         (on_combo_incoming_security_changed), (create_page_outgoing),
 204         (modest_account_settings_dialog_set_account_name),
 205         (save_configuration):
 206         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 207         (on_combo_security_changed),
 208         (modest_connection_specific_smtp_edit_window_init),
 209         (modest_connection_specific_smtp_edit_window_set_connection),
 210         (modest_connection_specific_smtp_edit_window_get_settings):
 211         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 212         as per the UI spec.
 213
 214 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 215
 216         * po/en_GB.po:
 217         * src/maemo/easysetup/modest-easysetup-wizard.c:
 218         (create_page_custom_outgoing), (create_page_complete_custom):
 219         * src/maemo/modest-account-settings-dialog.c:
 220         (create_page_user_details), (create_page_outgoing):
 221         * src/maemo/modest-account-view-window.c: (button_box_new):
 222         Use changed logical IDs as per the most recent UI spec:
 223         mcen_bd_emailsetup_edit -> mcen_bd_edit
 224         mcen_bd_emailsetup_delete -> mcen_bd_delete
 225         mcen_bd_emailsetup_close -> mcen_bd_close
 226
 227 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 228
 229         * configure.ac:
 230         * src/Makefile.am:
 231         * src/dbus_api/Makefile.am:
 232         * src/dbus_api/modest-dbus-callbacks.c:
 233         * src/dbus_api/modest-dbus-callbacks.h:
 234         * src/maemo/modest-platform.c: (modest_platform_init):
 235         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 236         method.
 237         * tests/Makefile.am:
 238         * tests/dbus_api/Makefile.am:
 239         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 240
 241 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 242
 243         * src/maemo/modest-account-settings-dialog.c:
 244         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 245         Removed unnecessary includes.
 246
 247 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 248
 249         * src/maemo/easysetup/modest-easysetup-wizard.c:
 250         * src/maemo/modest-account-settings-dialog.c:
 251         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 252         * src/widgets/Makefile.am:
 253         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 254         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 255         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 256         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 257         * src/widgets/modest-secureauth-combo-box.c:
 258         * src/widgets/modest-secureauth-combo-box.h:
 259         * src/widgets/modest-serversecurity-combo-box.c:
 260         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 261         made the GObject names more consistent with the rest of the Modest code.
 262
 263 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 264
 265         * src/maemo/easysetup/Makefile.am:
 266         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 267         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 268         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 269         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 270         * src/maemo/easysetup/modest-easysetup-wizard.c:
 271         * src/maemo/easysetup/modest-validating-entry.c:
 272         * src/maemo/easysetup/modest-validating-entry.h:
 273         * src/maemo/modest-account-settings-dialog.c:
 274         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 275         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 276         widgets/ because they are used outside of easysetup too. After checking in,
 277         svn will allow me to rename them too.
 278
 279 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 280
 281         * src/gnome/modest-msg-edit-window.c:
 282         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 283         linker error, to fix the build on the GNOME platform.
 284         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 285         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 286         ifdefed out to avoid a warning.
 287
 288 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 289
 290         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 291         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 292         some alternative for GTK+ 2.6.
 293
 294 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 295
 296         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 297
 298         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 299         specified for EmailAccountsDialog in UI spec.
 300
 301         * src/maemo/easysetup/modest-easysetup-wizard.c:
 302         * src/maemo/easysetup/modest-easysetup-wizard.h:
 303         * src/maemo/modest-account-settings-dialog.c:
 304         * src/maemo/modest-account-settings-dialog.h:
 305         Reuse a member window widget for the connection-specific SMTP server accounts,
 306         so we can tell it to create/save the accounts only if we actually save changes.
 307
 308         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 309         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 310         (modest_connection_specific_smtp_edit_window_get_settings):
 311         Return a struct instance for temporarily remembering the entered data.
 312
 313         * src/maemo/modest-connection-specific-smtp-window.h:
 314         * src/maemo/modest-connection-specific-smtp-window.c:
 315         (modest_connection_specific_smtp_window_finalize),
 316         (modest_connection_specific_smtp_window_fill_with_connections),
 317         (on_button_edit),
 318         (modest_connection_specific_smtp_window_save_server_accounts),
 319         (update_model_server_names): Do not actually save data until asked,
 320         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 321
 322         (on_selection_changed),
 323         (modest_connection_specific_smtp_window_init): Disable the edit
 324         button when nothing is selected.
 325
 326         * src/modest-account-mgr-helpers.c:
 327         * src/modest-account-mgr-helpers.h:
 328         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 329         elsewhere.
 330
 331 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 332
 333         * src/modest-account-mgr-helpers.h:
 334         * src/modest-account-mgr-helpers.c:
 335         (modest_account_mgr_get_unused_account_name),
 336         (modest_account_mgr_get_unused_account_display_name): Added these
 337         utility functions, to avoid code duplication.
 338
 339         * src/maemo/easysetup/modest-easysetup-wizard.c:
 340         (create_page_account_details), (create_account):
 341         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 342         (on_combo_security_changed),
 343         (modest_connection_specific_smtp_edit_window_init),
 344         (modest_connection_specific_smtp_edit_window_save_settings):
 345         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 346         * src/maemo/modest-connection-specific-smtp-window.c:
 347         (modest_connection_specific_smtp_window_finalize),
 348         (modest_connection_specific_smtp_window_fill_with_connections),
 349         (on_button_edit), (modest_connection_specific_smtp_window_init):
 350         * src/maemo/modest-connection-specific-smtp-window.h:
 351         Implementing saving of connection-specific server accounts.
 352
 353         But I need to refactor this so we can save the data for each
 354         possible connection-specific account and only actually create the server accounts
 355         when the easysetup finished, or the OK button is pressed on the account settings
 356         dialog.
 357
 358 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 359
 360         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 361         (on_combo_security_changed):
 362         (modest_connection_specific_smtp_edit_window_init):
 363         Auto-fill the port number as in the account settings.
 364
 365         (modest_connection_specific_smtp_edit_window_set_connection):
 366         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 367         * src/maemo/modest-connection-specific-smtp-window.c:
 368         (fill_with_connections), (on_button_edit),
 369         (modest_connection_specific_smtp_window_init):
 370         Turn the edit window into a dialog to simplify the code, and
 371         set a WM hint as in a GtkDialog, because only a popup can be on top of
 372         another window in Maemo, and popups usually have no WM decoration.
 373
 374         * src/modest-defs.h:
 375         * src/modest-account-mgr-helpers.c:
 376         (modest_account_mgr_set_connection_specific_smtp),
 377         (modest_account_mgr_remove_connection_specific_smtp),
 378         (modest_account_mgr_get_connection_specific_smtp):
 379         * src/modest-account-mgr-helpers.h: Some functions to write the
 380         connection-specific SMTP server information. Not yet used.
 381
 382
 383         * src/widgets/modest-folder-view.c: (text_cell_data):
 384         Fix a warning about an uninitialized variable.
 385         (on_configuration_key_changed): Put an #ifdef around the use
 386         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 387
 388 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 389
 390         * src/maemo/modest-account-settings-dialog.h:
 391         * src/maemo/modest-account-settings-dialog.c:
 392         Added connect_for_modified() utility function to mark the new modified boolean.
 393
 394         (create_page_account_details), (create_page_user_details),
 395         (create_page_incoming), (create_page_outgoing), (on_response),
 396         (modest_account_settings_dialog_init),
 397         (modest_account_settings_dialog_set_account_name):
 398         Only warn about unsaved changes when there are actually unsaved changes.
 399
 400         * src/modest-account-mgr-helpers.c:
 401         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 402         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 403         to get the data from there in future.
 404
 405 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 406
 407         * src/modest-defs.h:
 408
 409         * src/modest-account-mgr-helpers.h:
 410         * src/modest-account-mgr-helpers.c:
 411         Store the security account setting in a single conf key instead of using
 412         the options list, so that the list is left for just the to-be-removed camel hack,
 413         and because gconf_client_set_list() is failing for some reason.
 414
 415         * src/modest-account-mgr.c:
 416         (modest_account_mgr_add_server_account):
 417         * src/maemo/modest-account-settings-dialog.c:
 418         (modest_account_settings_dialog_set_account_name),
 419         (save_configuration): Use the renamed functions.
 420
 421
 422 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 423
 424         * src/widgets/Makefile.am:
 425         * src/widgets/modest-limit-retrieve-combo-box.c:
 426         * src/widgets/modest-limit-retrieve-combo-box.h:
 427         * src/widgets/modest-retrieve-combo-box.c:
 428         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 429         the account settings dialog.
 430
 431         * src/modest-defs.h:
 432         * src/modest-account-mgr-helpers.h:
 433         * src/modest-account-mgr-helpers.c:
 434         (modest_server_account_get_option_secure_auth),
 435         (modest_server_account_set_option_secure_auth):
 436         * src/modest-account-mgr.c:
 437         (modest_account_mgr_add_server_account):
 438         Use the existing AUTH_MECH conf key for the secure-auth setting,
 439         instead of putting it in the list options, because this was actually used already.
 440
 441         * src/maemo/modest-account-settings-dialog.c:
 442         (create_page_account_details),
 443         (modest_account_settings_dialog_set_account_name),
 444         (save_configuration):
 445         * src/maemo/modest-account-settings-dialog.h:
 446         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 447         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 448
 449 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 450
 451         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 452         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 453         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 454
 455         * src/modest-defs.h:
 456         * src/maemo/modest-account-settings-dialog.c:
 457         (create_page_incoming), (on_combo_outgoing_security_changed),
 458         (on_combo_incoming_security_changed), (create_page_outgoing),
 459         (modest_account_settings_dialog_set_account_name),
 460         (save_configuration): Load/Save the port number, and change it when the
 461         security combo changes, to suitable defaults.
 462
 463 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 464
 465         * src/modest-account-mgr.c:
 466         (modest_account_mgr_add_server_account): Set the security and secure-auth
 467         options, and add a comment saying that the other camel-specific options should be
 468         removed in future.
 469
 470 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 471
 472         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 473         found by valgrind.
 474         * src/modest-tny-account-store.c: (account_list_free),
 475         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 476         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 477         easy to fix.
 478
 479 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 480
 481         * src/modest-protocol-info.c:
 482         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 483         is required by our UI spec. Maybe something in our implementation will use this eventually.
 484         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 485         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 486         instead of the previous 0 placeholder.
 487
 488         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 489         secure-auth settings.
 490         * src/modest-account-mgr-helpers.h:
 491         * src/modest-account-mgr-helpers.c:
 492         (modest_server_account_data_get_option_secure_auth),
 493         (modest_server_account_set_option_secure_auth),
 494         (modest_server_account_data_get_option_security),
 495         (modest_server_account_set_option_security): Added this API for getting and setting the security
 496         and secure-auth settings.
 497
 498         * src/maemo/modest-account-settings-dialog.h:
 499         * src/maemo/modest-account-settings-dialog.c:
 500         (modest_account_settings_dialog_finalize), (check_data),
 501         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 502         about changing titles.
 503         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 504         (save_configuration): Save the security and secure-auth settings.
 505
 506         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 507         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 508
 509 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 510
 511         * src/modest-defs.h:
 512         * src/modest-account-mgr.c:
 513         (modest_account_mgr_add_server_account):
 514         Added and used defines for the options key and value pair strings,
 515         that are used so far, though they do not seem to correspond to anything in our
 516         UI specs or ModestProtocol enum.
 517
 518         * src/modest-account-mgr-helpers.h:
 519         * src/modest-account-mgr-helpers.c:
 520         (compare_option_strings_for_name),
 521         (modest_server_account_data_get_option_value),
 522         (modest_server_account_data_get_option_bool),
 523         (modest_account_mgr_get_server_account_option):
 524         Added helper functions for parsing the options GSList.
 525
 526 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 527
 528         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 529         display name is based on the supplied account name.
 530         * src/modest-account-mgr.c:
 531         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 532         with an inefficient, but good-enough, implementation.
 533
 534         * src/maemo/easysetup/modest-easysetup-wizard.c:
 535         (create_page_account_details), (on_before_next), (create_account):
 536         Check for existing display names rather than (non-user-visible) account names, and just
 537         create and set a unique account name at the end.
 538
 539         * src/maemo/modest-account-settings-dialog.c:
 540         (modest_account_settings_dialog_init),
 541         (modest_account_settings_dialog_set_account_name),
 542         (create_page_incoming): Show the display name, instead of the account name.
 543         (on_response): Do some (not all) extra checks, as in the UI spec.
 544         (save_configuration): Save the display name if it was changed.
 545
 546 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 547
 548         * po/en_GB.po: Added needed logical ID and translation.
 549         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 550         (init_view): Made the is-default column clicking work.
 551
 552 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 553
 554         * configure.ac:
 555         * src/maemo/easysetup/Makefile.am:
 556         * src/maemo/easysetup/modest-easysetup-wizard.c:
 557         (modest_easysetup_wizard_dialog_init):
 558         * src/maemo/easysetup/provider-data-test.keyfile:
 559         * src/maemo/easysetup/provider-data.keyfile:
 560         Moved the provider data file to the new modest-providers-data package and used it from there.
 561
 562 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 563
 564         * src/modest-local-folder-info.c:
 565         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 566         N_() was already used on the static strings, but this just marks it for translation without
 567         using the translation.
 568
 569 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 570
 571         * src/maemo/modest-account-settings-dialog.c:
 572         (create_page_incoming),
 573         (modest_account_settings_dialog_set_account_name):
 574         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 575         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 576         I will do this if nobody else gets there first.
 577
 578 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 579
 580         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 581         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 582         save the security stuff.
 583
 584 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 585
 586         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 587         Set the email address and user fullname, which I now see must be
 588         done separately.
 589
 590         * src/maemo/modest-account-settings-dialog.h:
 591         * src/maemo/modest-account-settings-dialog.c:
 592          (on_response),
 593         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 594         leave-on-server and authentication.
 595         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 596         how to do the rest.
 597
 598 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 599
 600
 601         * src/maemo/modest-account-settings-dialog.c:
 602         * src/maemo/modest-account-settings-dialog.h:
 603         Most (but not all) of the widgets are now present as specified by the UI spec.
 604         No changes are yet saved, and some details are not properly shown yet.
 605
 606         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 607
 608 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 609
 610         * src/maemo/Makefile.am:
 611         * src/maemo/modest-account-settings-dialog.c:
 612         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 613         an existing account. Doesn't do much yet.
 614
 615         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 616         Open the accounts settings dialog when Edit is clicked.
 617
 618 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 619
 620         * src/maemo/easysetup/Makefile.am:
 621         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 622         (load_from_file):
 623         * src/maemo/easysetup/modest-easysetup-wizard.c:
 624         (modest_easysetup_wizard_dialog_init):
 625         Try to get the source directory from the build system,
 626         instead of hard-coding "./" into the source code, when opening our local
 627         copies of the configuration files.
 628         But this still fails when opening the wizard from the Accounts window,
 629         maybe because the working directory seems to change at runtime.
 630         So the wizard will fail the second time unless you copy the files into their
 631         proper locations - see the stdout warnings for the paths.
 632
 633         (create_page_account_details),(on_before_next):
 634         Check for existing non-server accounts instead of server accounts,
 635         so the default account name is useful again, and to prevent trying to
 636         recreate accounts.
 637
 638         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 639         Show the wizard when New is clicked.
 640
 641         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 642         (init_view): Show the column headers, and show the columns that are
 643         specified in the UI specs. However, something in Maemo's GTK+ prevents
 644         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 645         change the default account. This is despite unsetting the special properties.
 646
 647 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 648
 649         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 650         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 651         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 652         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 653         to make that clearer.
 654         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 655
 656 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 657
 658         * src/maemo/modest-account-view-window.c:
 659         (modest_account_view_window_init),
 660         (modest_account_view_window_new):
 661         Use the same buttons as specified in the
 662         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 663         the existing widgets, which never had a chance of working.
 664         Put the ModestAccountView treeview in a scrolled window.
 665         Do not repeat the initialization in both _init() and _new().
 666
 667         * src/widgets/modest-account-view.c: (update_account_view):
 668         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 669         this widget and window shows no accounts.
 670
 671         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 672
 673 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 674
 675         * src/maemo/easysetup/modest-easysetup-wizard.c:
 676         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 677         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 678         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 679         which seems wrong.
 680
 681         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 682         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 683         accounts exist yet, as in the UI spec.
 684
 685         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 686
 687 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 688
 689         * src/maemo/Makefile.am:
 690         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 691         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 692         New window for editing connection-specific smtp details.
 693         Not fully implemented.
 694
 695         * src/maemo/modest-connection-specific-smtp-window.c:
 696         (modest_connection_specific_smtp_window_finalize) :
 697         unref the tree model.
 698         (on_button_edit): Show the edit window.
 699
 700 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 701
 702         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 703         error for me.
 704
 705         * src/maemo/Makefile.am:
 706         * src/maemo/modest-connection-specific-smtp-window.c:
 707         * src/maemo/modest-connection-specific-smtp-window.h:
 708         New window for showing the list of connections, for connection-specific
 709         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 710         * src/maemo/easysetup/modest-easysetup-wizard.c:
 711         (create_page_custom_outgoing): Show the new window when the button is clicked.
 712
 713 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 714
 715         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 716         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 717         * src/maemo/modest-msg-edit-window.c:
 718         (modest_msg_edit_window_insert_image):
 719         * src/modest-conf.c: (modest_conf_key_escape):
 720         * src/modest-mail-operation.c:
 721         (modest_mail_operation_send_new_mail):
 722         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 723         (modest_ui_actions_on_new_account):
 724         * src/widgets/modest-attachment-view.c: (update_filename_request):
 725         * src/widgets/modest-mail-header-view.c:
 726         Corrected warnings that were breaking the build, by commenting out unused variables,
 727         and a function, and by including a header.
 728
 729 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 730
 731         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 732         so we can #ifdef around platform-specific code when necessary.
 733         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 734         to allow this to build for the GNOME platform too.
 735
 736 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 737
 738         * src/maemo/easysetup/modest-easysetup-wizard.c:
 739         Added util_increment_name() and used it in create_page_account_details()
 740         to make sure that the default account name is always a new name.
 741
 742         (modest_easysetup_wizard_dialog_init),
 743         (set_default_custom_servernames): Some minor memory management fixes.
 744
 745 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 746
 747         * Makefile.am:
 748         * configure.ac:
 749         * src/modest-runtime.c: (init_i18n): Restored the translation
 750         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 751         are defined in config.h, and the translations are installed.
 752
 753         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 754         is defined for translation.
 755
 756 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 757
 758         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 759         (load_from_file):
 760         * src/maemo/easysetup/modest-easysetup-wizard.c:
 761         (modest_easysetup_wizard_dialog_init):
 762         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 763         Use realistic paths (though they should use $prefix generically) to the
 764         mcc_mapping and provider-data.keyfile files which might work when they
 765         are installed by the future version of the operator-wizard package,
 766         and then fallback to paths in our source code, with an explanatory
 767         warning.
 768
 769 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 770
 771         * configure.ac:
 772         * src/Makefile.am:
 773         * src/maemo/Makefile.am:
 774         * src/maemo/easysetup/: Added files from the previously-exernal
 775         osso-modest-easysetup.
 776         * src/maemo/modest-main-window-ui.h:
 777         * src/modest-ui-actions.c:
 778         * src/modest-ui-actions.h:
 779         Added modest_ui_actions_on_new_account() as a signal handler for the
 780         New Account menu item. It shows the easysetup wizard.
 781         * po/en_GB.po: Added additional needed logical IDs and translations.
 782
 783 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 784 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 785