1 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
4 Removed some debug printfs.
6 2007-05-23 Murray Cumming <murrayc@murrayc.com>
8 Modest on-disk outbox directories are now here, for instance:
9 $HOME/.modest/outboxes/<account-id-1>/outbox
10 $HOME/.modest/outboxes/<account-id-2>/outbox
12 $HOME/.modest/local-folders/outbox
13 so we can have a separate outbox for each account.
14 But they are shown as one outbox in the GtkTreeView, by using a
15 TnyMergeFolder in a ModestTnySimpleFolderStore.
18 * src/modest-tny-simple-folder-store.c:
19 * src/modest-tny-simple-folder-store.h:
20 Added ModestTnySimpleFolderStore, used to contain folders from
21 other folder stores, such as other accounts.
23 * src/modest-tny-outbox-account.h:
24 * src/modest-tny-outbox-account.c:
25 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
26 used for the per-account local outbox folders.
28 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
29 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
30 only use this (internally) now for the non-outbox local folders.
33 * src/modest-init.c: Added modest_init_one_local_folder(), for
34 setting up the directory structure for each local folder.
36 * src/modest-local-folder-info.c:
37 (modest_per_account_local_outbox_folder_info_get_maildir_path),
38 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
40 * src/modest-local-folder-info.h:
41 * src/modest-tny-account-store.c: (on_account_removed),
42 (on_account_changed), (create_per_account_local_outbox_folders),
43 (get_server_accounts), (modest_tny_account_store_get_accounts),
44 (modest_tny_account_store_get_tny_account_by_account),
45 (modest_tny_folder_store_is_virtual_local_folders):
47 * src/modest-tny-account.h:
48 * src/modest-tny-account.c:
49 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
50 to create an on-disk per-account local outbox folder for each
52 (create_per_account_local_outbox_folders): Create a local outbox folder
53 for each transport account.
54 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
55 for all local folders.
57 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
58 instead of using g_object_get/set() directly. It is clearer.
60 (modest_tny_folder_store_get_message_count),
61 (modest_tny_folder_store_get_local_size
62 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
63 because we now use these with non-acount folder stores.
65 (modest_tny_account_get_special_folder),
66 (modest_tny_account_new_from_server_account),
67 (modest_tny_account_new_from_account):
68 (recurse_folders): Adjust to the new outbox system.
70 * src/modest-tny-folder.h:
71 * src/modest-tny-folder.c:
72 (modest_tny_folder_is_local_folder),
73 (modest_tny_folder_get_local_folder_type),
74 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
76 * src/widgets/modest-main-window.h:
77 * src/maemo/modest-main-window.c: (create_details_widget),
78 (modest_main_window_set_contents_style): Show details for any folder store,
81 (modest_tny_folder_get_rules):
82 Remove the const. C does not support constness enough for this.
84 * src/modest-ui-actions.c:
85 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
86 make all outboxes appear as one, in the usual local-folders tree node.
88 (set_active_account_from_tny_account),
89 (modest_ui_actions_on_folder_selection_changed):
90 * src/widgets/modest-folder-view.c: (text_cell_data),
91 (icon_cell_data), (filter_row),
92 (add_account_folders_to_merged_folder),
93 (add_account_folders_to_simple_folder_store), (),
94 (get_cmp_rows_type_pos), (cmp_rows),
95 (modest_folder_view_set_account_id_of_visible_server_account):
96 Adjust to the new outbox system, using generic folder stores and folders
99 2007-05-23 Christian Kellner <ckellner@openismus.com>
101 * src/modest-mail-operation.c:
102 (modest_mail_operation_update_account):
103 Use info->max_size instead of unintialized local var [small
104 build fix]. (Added TODO to review that change since I don't
107 2007-05-23 Marcus Bauer <marcusb@openismus.com>
109 * libmodest-dbus-client/libmodest-dbus-client.c:
110 (libmodest_dbus_client_compose_mail): function added
111 * src/dbus_api/modest-dbus-api.h:
112 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
113 (on_compose_mail): Implementation of the SendAsMail functionality
115 2007-05-22 Murray Cumming <murrayc@murrayc.com>
117 * src/modest-account-mgr.c:
118 (modest_account_mgr_add_server_account): Set the secure-connection
119 conf key for transport accounts as well as store accounts. I don't know
120 why the if was there. For instance, this makes sure that we use SSL
121 for the gmail preset from the easysetup wizard.
123 2007-05-22 Murray Cumming <murrayc@murrayc.com>
125 * src/gnome/modest-main-window.c:
126 (on_account_store_connecting_finished), (connect_signals):
127 * src/maemo/modest-main-window.c:
128 (on_account_store_connecting_finished), (connect_signals),
129 (modest_main_window_new):
130 Handle TnyAccountStore::connecting-finished instead of
131 TnyDevice::connection-changed, because we cannot actually perform
132 operations on accounts until TnyAccountStore has itself responded to
133 the TnyDevice::connection-changed signal. This prevents a GError from
135 Do not try to update at startup, because we (at least on scratchbox)
136 already do an update at startup when the device goes online.
137 This prevents a GError from tinymail.
138 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
139 Added TODO about stopping simultaneous operations.
141 2007-05-21 Murray Cumming <murrayc@murrayc.com>
143 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
144 * src/modest-mail-operation-queue.c:
145 (modest_mail_operation_queue_remove):
146 * src/modest-tny-account-store.c: When GErrors happen, give more clues
147 about where they happened.
149 2007-05-21 Murray Cumming <murrayc@murrayc.com>
151 * src/modest-ui-actions.c:
152 (modest_ui_actions_on_password_requested): Make sure that the remember
153 output parameter is always TRUE.
155 2007-05-21 Murray Cumming <murrayc@murrayc.com>
157 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
158 Show a OK/Cancel dialog if the error is a question, though we still do not
159 know anything more about what we are asking the user.
160 * src/widgets/modest-folder-view.c: (on_drag_data_received):
161 Fix an uninitialized variable (helper). This is a logic error, however.
163 2007-05-21 Christian Kellner <ckellner@openismus.com>
165 * src/modest-search.h:
166 Correct bit shifting in the ModestSearchFlags enum.
168 2007-05-21 Murray Cumming <murrayc@murrayc.com>
170 * src/modest-tny-account.c:
171 (modest_tny_account_new_from_server_account): Do not use the lsub and
172 check-all hard-coded IMAP options when using POP.
174 2007-05-21 Murray Cumming <murrayc@murrayc.com>
176 * src/modest-tny-account.c:
177 (modest_tny_account_new_from_server_account):
178 Use NULL for the secure-auth method for POP when Password auth has been
179 specified by the user, as we already do for IMAP. "auth=Login" causes
180 an error from camel or the server.
182 2007-05-17 Murray Cumming <murrayc@murrayc.com>
184 * src/maemo/modest-account-settings-dialog.c:
185 (create_page_account_details),
186 (modest_account_settings_dialog_set_account_name):
187 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
188 for the leave-on-server checkbox, rathr than just the checkbox, when
189 the protocol is not POP.
191 2007-05-17 Murray Cumming <murrayc@murrayc.com>
193 * src/widgets/modest-account-view.c:
194 * src/widgets/modest-account-view.h:
195 Added modest_account_view_select_account() which will be useful later
196 to asynchronously re-select the edited account.
198 2007-05-17 Murray Cumming <murrayc@murrayc.com>
200 * src/maemo/modest-account-settings-dialog.c:
201 (modest_account_settings_dialog_set_account_name):
202 Automatically choose the port numbers based on the secure authentication
203 methods, if they have not been chosen before.
204 This fixes projects.maemo.org bug NB#56273 .
206 2007-05-17 Murray Cumming <murrayc@murrayc.com>
208 * src/maemo/modest-main-window-ui.h:
209 * src/modest-ui-actions.c:
210 * src/modest-ui-actions.h:
211 Connect the Tools/SMTP Servers menu item to
212 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
213 SMTP servers dialog, as in the UI specification and saves changes when it
214 is closed. This fixed projects.maemo.org bug NB#56305 .
216 2007-05-17 Murray Cumming <murrayc@murrayc.com>
218 * src/maemo/modest-connection-specific-smtp-window.c:
219 (modest_connection_specific_smtp_window_init):
220 Use gtk_window_set_default_size() to make this window big enough, so
221 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
223 2007-05-17 Murray Cumming <murrayc@murrayc.com>
225 * src/maemo/modest-connection-specific-smtp-edit-window.h:
226 * src/maemo/modest-connection-specific-smtp-edit-window.c:
227 (modest_connection_specific_smtp_edit_window_init),
228 Do not try to connect to a combobox signal before the combobox exists.
229 This fixes the cras in projects.maemo.org bug NB#56288 .
230 (modest_connection_specific_smtp_edit_window_get_settings):
231 Remove the server_account_name parameter which was being checked for NULL
232 though it was not used.
234 * src/maemo/modest-connection-specific-smtp-window.c:
235 (modest_connection_specific_smtp_window_fill_with_connections),
236 (on_button_edit), (modest_connection_specific_smtp_window_init):
237 Correct the number of treemodel columns to prevent a warning.
238 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
239 libconic does not work.
241 2007-05-16 Murray Cumming <murrayc@murrayc.com>
243 * src/modest-tny-account.c:
244 (modest_tny_account_new_from_server_account):
245 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
246 SMTP when "None" was chosen by the user. However, with my SMTP server that
247 does not support ANONYMOUS, the emails do not leave the Outbox and I see
250 2007-05-16 Murray Cumming <murrayc@murrayc.com>
252 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
253 to explain the memory management issue with the ID in the ModestPair.
255 * src/gnome/modest-account-assistant.c: (add_receiving_page),
256 (add_sending_page), (modest_account_assistant_finalize):
257 * src/gnome/modest-gnome-global-settings-dialog.c:
258 (create_updating_page), (create_composing_page):
259 * src/gnome/modest-msg-edit-window.c: (get_transports),
260 (init_window), (modest_msg_edit_window_finalize),
261 (modest_msg_edit_window_get_msg_data):
262 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
263 * src/gnome/modest-transport-widget.c:
264 (modest_transport_widget_finalize), (smtp_configuration):
265 * src/maemo/modest-maemo-global-settings-dialog.c:
266 (create_updating_page), (create_composing_page):
267 * src/maemo/modest-msg-edit-window.c: (get_transports),
268 (init_window), (modest_msg_edit_window_finalize),
269 (modest_msg_edit_window_get_msg_data),
270 (modest_msg_edit_window_free_msg_data):
271 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
272 (modest_store_widget_finalize):
273 * src/maemo/modest-transport-widget.c:
274 (modest_transport_widget_finalize), (smtp_configuration):
275 * src/modest-main.c: (send_mail):
276 * src/widgets/modest-combo-box.h:
277 * src/widgets/modest-global-settings-dialog-priv.h:
278 * src/widgets/modest-global-settings-dialog.c:
279 (modest_global_settings_dialog_finalize):
280 * src/widgets/modest-msg-edit-window.h:
281 Whenever using modest_combo_box_new(), keep the ModestPairList alive
282 as long as the combo box, to prevent use of freed memory for the ID.
284 2007-05-15 Murray Cumming <murrayc@murrayc.com>
286 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
287 get_accounts(), to make this clearer. Do not check for the enabled gconf
288 key, because we do not use this for server accounts (at least, not yet).
289 This allows us to send email again.
291 2007-05-15 Murray Cumming <murrayc@murrayc.com>
293 * src/maemo/modest-platform.c:
294 (on_modest_conf_update_interval_changed), (modest_platform_init):
295 Only respond to this particular key change. All these strcmp()s cannot be
298 2007-05-15 Murray Cumming <murrayc@murrayc.com>
300 * src/maemo/modest-maemo-global-settings-dialog.c:
301 (current_connection): Prevent a crash in scratchbox when
302 ny_maemo_conic_device_get_current_iap_id() returns NULL.
303 * src/maemo/modest-platform.c:
304 (on_modest_conf_update_interval_changed), (modest_platform_init):
305 Get the update interval from gconf and reset it when the gconf key changes.
307 2007-05-15 Murray Cumming <murrayc@murrayc.com>
309 * src/modest-protocol-info.c:
310 * src/modest-protocol-info.h: Adde enum-specific get functions,
311 instead of using a ModestProtocolType enum parameter.
313 * src/gnome/modest-account-assistant.c:
314 * src/gnome/modest-store-widget.c:
315 * src/gnome/modest-store-widget.h:
316 * src/gnome/modest-transport-widget.c:
317 * src/gnome/modest-transport-widget.h:
318 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
319 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
320 * src/maemo/easysetup/modest-easysetup-wizard.c:
321 * src/maemo/modest-account-settings-dialog.c:
322 * src/maemo/modest-account-settings-dialog.h:
323 * src/maemo/modest-store-widget.c:
324 * src/maemo/modest-store-widget.h:
325 * src/maemo/modest-transport-widget.c:
326 * src/maemo/modest-transport-widget.h:
327 * src/modest-account-mgr-helpers.c:
328 * src/modest-account-mgr-helpers.h:
329 * src/modest-account-mgr.c:
330 * src/modest-account-mgr.h:
331 * src/modest-tny-account.c:
332 * src/modest-tny-folder.c:
333 * src/widgets/modest-account-view.c:
334 * src/widgets/modest-retrieve-combo-box.c:
335 * src/widgets/modest-retrieve-combo-box.h:
336 * src/widgets/modest-secureauth-combo-box.c:
337 * src/widgets/modest-serversecurity-combo-box.c:
338 * src/widgets/modest-serversecurity-combo-box.h:
339 * tests/check_account-mgr.c:
340 Use the specific functions, and use the re-renamed enum values for GNOME too.
342 2007-05-15 Murray Cumming <murrayc@murrayc.com>
345 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
346 so we can get the second based on the first.
348 * src/maemo/modest-account-settings-dialog.h:
349 * src/maemo/modest-account-settings-dialog.c:
350 Added get_supported_secure_authentication_methods(), though it is mostly
351 commented-out for now until the necessary API is committed to tinymail.
352 (modest_account_settings_dialog_set_account_name),
353 (save_configuration): Request the supported authentication methods from the
354 server, so we can choose a working method.
356 * src/modest-tny-account-store.h:
357 * src/modest-tny-account-store.c:
358 (modest_tny_account_store_get_session): Rename from
359 tny_account_store_get_session().
361 2007-05-14 Murray Cumming <murrayc@murrayc.com>
363 * src/modest-protocol-info.h: Split the ModestProtocol enum
364 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
365 There was no need to have these unrelated values in one enum.
367 * src/: many files: Adapted to changed enum. This makes the code a bit
368 clearer, and the compiler could catch some errors.
370 2007-05-14 Murray Cumming <murrayc@murrayc.com>
372 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
373 Show the detailed internal camel error message when an error happens
374 during the configuration, so that our testers can give us more clues.
375 For instance, in projects.maemo.org bug NB#56910 .
377 2007-05-14 Murray Cumming <murrayc@murrayc.com>
379 * src/modest-tny-account.c:
380 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
381 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
383 2007-05-14 Murray Cumming <murrayc@murrayc.com>
385 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
386 * src/maemo/modest-account-settings-dialog.c:
387 (modest_account_settings_dialog_set_account_name),
388 (save_configuration): For the incoming secure authentication checkbox,
389 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
390 the UI specification. PLAIN does not seem to be supported for most IMAP
391 servers anyway, and I am not sure what it would mean.
392 However, we probably need to discover which of the secure-authentication
393 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
394 * src/modest-account-mgr-helpers.c:
395 (modest_account_mgr_get_server_account_data):
397 * src/modest-tny-account.c:
398 (modest_tny_account_new_from_server_account):
399 Use tny_account_set_mech() to set secure-authentication methods,
400 with some special-casing for IMAP, based on my observations of how
403 * src/modest-account-mgr-helpers.h:
404 * src/modest-account-mgr.c:
405 * src/modest-defs.h: Comment that the URI is only used for local folders.
407 2007-05-11 Murray Cumming <murrayc@murrayc.com>
409 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
410 parameter const, just to be neat.
411 * src/modest-text-utils.c: (modest_text_utils_inline):
412 End g_strconcat() with NULL, as its documentation says. This is almost
413 certainly the cause of my crash at startup on the device. Interestingly,
414 valgrind doesn't tell us about these errors.
416 2007-05-11 Murray Cumming <murrayc@murrayc.com>
418 * scripts/build-packages: Added more precise comments about how to use
419 this script, though I still get this error:
420 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
421 error building tinymail
423 2007-05-11 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/modest-main-window.c: (on_account_update):
426 Very slight cleanup, hoping to make it simpler to discover what causes
427 a crash here sometimes.
429 * src/modest-tny-account.c:
430 (modest_tny_account_new_from_server_account): Set the port. Added
431 comments about the options and a TODO comment because I need to find out
432 how to specify the secure authentication method.
434 2007-05-11 Marcus Bauer <marcusb@openismus.com>
436 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
437 changed CFlags paths form modest to libmodest
439 2007-05-10 Murray Cumming <murrayc@murrayc.com>
441 * src/modest-account-mgr-helpers.c:
442 (modest_account_mgr_get_server_account_data),
443 (modest_account_mgr_free_server_account_data):
444 * src/modest-account-mgr-helpers.h:
445 * src/modest-account-mgr.c:
446 (modest_account_mgr_add_server_account):
448 * src/modest-tny-account.c:
449 (modest_tny_account_new_from_server_account):
450 Determine the options for tny_camel_account_add_option() here,
451 based on the settings, rather than storing them directly in gconf.
453 2007-05-10 Murray Cumming <murrayc@murrayc.com>
455 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
456 Show a more friendly error dialog now that we expect (from the tinymail
457 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
459 2007-05-10 Murray Cumming <murrayc@murrayc.com>
461 * src/maemo/modest-main-window.c: (on_account_update): Check that
462 account_name is not NULL, to prevent a crash at startup that I am
463 seeing on the N800. I do wonder why it is NULL.
465 * src/maemo/easysetup/modest-easysetup-wizard.c:
466 (create_page_user_details):
467 * src/maemo/modest-account-settings-dialog.c:
468 (create_page_user_details), (create_page_outgoing):
469 * src/maemo/modest-connection-specific-smtp-edit-window.c:
470 (modest_connection_specific_smtp_edit_window_init):
471 * src/modest-ui-actions.c:
472 (modest_ui_actions_on_password_requested):
473 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
474 might do something useful with the on-screen keyboard.
476 2007-05-10 Murray Cumming <murrayc@murrayc.com>
478 * src/maemo/modest-main-window.c: (on_account_update):
479 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
480 NULL, to avoid lots of warnings. However, it probably should not be NULL.
482 2007-05-09 Murray Cumming <murrayc@murrayc.com>
484 * src/modest-tny-account-store.c: (on_account_changed):
485 Correct the signature of this signal handler.
487 2007-05-09 Murray Cumming <murrayc@murrayc.com>
489 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
490 Show a HildonNote instead of a GtkDialog for Maemo.
492 2007-05-09 Murray Cumming <murrayc@murrayc.com>
494 * src/widgets/modest-account-view.h:
495 * src/widgets/modest-account-view.c: (on_account_changed),
496 (on_account_removed). Added a boolean flag, set/unset by
497 modest_account_view_block_conf_updates(),
498 modest_account_view_unblock_conf_updates() to prevent unnecessary
499 updates, but this is not very useful because the gconf notifications are
500 so delays (maybe only on Maemo Bora).
501 So auto-updating is turned off, and these functions do an explicit
502 update when necessary.
503 However, something else is still doing too much work when adding/removing
504 accounts, probably in another part of the application.
506 * src/maemo/modest-account-view-window.c:
507 (on_delete_button_clicked), (on_edit_button_clicked),
508 (on_new_button_clicked): Use the new functions.
510 2007-05-09 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-account-mgr-helpers.c:
513 (modest_account_mgr_set_first_account_as_default):
514 Sort the list of names alphabetically-by-title, so we choose the first one
516 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
517 alphabetically by the title.
519 This fixes projects.maemo.org bug NB#56418 .
521 * src/modest-account-mgr-priv.c:
522 (_modest_account_mgr_account_from_key):
523 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
524 avoid a valgrind error, and possible random behaviour.
526 2007-05-09 Murray Cumming <murrayc@murrayc.com>
528 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
529 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
530 tinymail documentation to say that this can be expected.
531 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
532 pretty, and should not happen, but I would prefer to know when it does.
534 2007-05-09 Murray Cumming <murrayc@murrayc.com>
536 * configure.ac: When using the older hildon version, probably on Bora,
537 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
539 * src/widgets/modest-attachment-view.c:
540 (modest_attachment_view_set_part_default): Initialize variables, to fix the
543 2007-05-09 Marcus Bauer <marcusb@openismus.com>
545 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
546 Implemented the prototype. Can be tested with
547 tests/dbus_api/test_open_message:
549 2007-05-08 Murray Cumming <murrayc@murrayc.com>
551 * src/modest-tny-account-store.c:
552 (modest_tny_account_store_instance_init), (get_password):
553 * src/modest-ui-actions.c:
554 (modest_ui_actions_on_password_requested):
555 Do not store the password in gconf, because this function is called
556 for non-remembered passwords. Actually use the cached (in the hash map)
557 password instead of releasing it.
558 The password will now not be remembered if it is asked via the protected
559 password dialog, as per the UI spec.
561 2007-05-08 Murray Cumming <murrayc@murrayc.com>
564 * src/modest-account-mgr-helpers.h:
565 * src/modest-account-mgr-helpers.c:
566 Added modest_server_account_get_username_has_succeeded(),
567 modest_server_account_set_username_has_succeeded().
568 (modest_server_account_set_username),
569 Reset the has-succeeded flag if the username changes.
571 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
572 * src/maemo/modest-connection-specific-smtp-window.c:
573 (modest_connection_specific_smtp_window_save_server_accounts):
574 Use modest_server_account_set_username() instead of using
575 modest_conf_set_string() directly, so that the has-succeeded flag is always
578 * src/modest-ui-actions.c:
579 (modest_ui_actions_on_password_requested): Dim the username entry if
580 the username has ever worked, as per the UI spec.
582 2007-05-08 Murray Cumming <murrayc@murrayc.com>
584 * src/modest-tny-account-store.c: (get_password):
585 * src/modest-ui-actions.c:
586 (modest_ui_actions_on_password_requested):
587 Allow the username to be changed too, though there is more work to
588 be done on exactly how this behaves.
590 2007-05-08 Murray Cumming <murrayc@murrayc.com>
592 * src/modest-account-mgr-helpers.h:
593 * src/modest-account-mgr-helpers.c:
594 Added modest_account_mgr_get_display_name(),
595 modest_server_account_get_username(),
596 modest_server_account_set_username(),
597 modest_server_account_set_password(),
598 modest_server_account_get_hostname() functions so we do not need to
599 use the conf API directly.
601 * src/maemo/modest-main-window.c: (connect_signals):
602 Actually connect ot the ModestAccountStore::request-password signal,
603 so that we show the dialog when the password is requested by Tinymail,
604 for isntance if it is empty.
606 * src/modest-marshal.list:
607 * src/modest-tny-account-store.c:
608 (modest_tny_account_store_class_init), (get_password),
609 (modest_tny_account_store_alert):
610 * src/modest-tny-account-store.h:
611 * src/modest-ui-actions.h:
612 * src/modest-ui-actions.c:
613 (modest_ui_actions_on_password_requested):
614 Change the signal parameters, so it is obvious that we are providing
615 the non human-readable server name, and receiving both the username
616 and password, though changing of the username is not yet implemented.
617 Change the dialog UI to match the Maemo UI specifications, with #idfefing
618 for the GNOME version.
620 This should fix the projects.maemo.org bug NB#56209, though it does not
621 work on Bora, because the gconf_client_get() for the password fails
622 immediately after we save it with gconf_client_set().
624 2007-05-08 Murray Cumming <murrayc@murrayc.com>
627 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
628 caused an undefined symbol error:
629 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
631 2007-05-08 Murray Cumming <murrayc@murrayc.com>
633 * src/modest-tny-account-store.c:
634 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
635 using a GError instead of a string message, so we can translate it in
638 2007-05-08 Murray Cumming <murrayc@murrayc.com>
640 * src/maemo/modest-address-book.c:
641 (modest_address_book_check_names):
642 * src/maemo/modest-msg-view-window.c:
643 (modest_msg_view_window_clipboard_owner_change):
644 * src/modest-init.c: (modest_init_init_ui):
645 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
646 (update_folders_cb), (modest_mail_operation_update_account):
647 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
648 (modest_ui_actions_on_msg_attachment_clicked),
649 (modest_ui_actions_on_msg_recpt_activated):
650 * src/widgets/modest-header-view.c: (drag_data_get_cb):
651 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
652 (modest_msg_view_search_next):
653 * src/widgets/modest-recpt-editor.c:
654 (modest_recpt_editor_on_button_release_event),
655 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
656 g_message(). At this point we should only be seeing interesting errors on
657 stdout. Debugging messages could be #ifdefed-out if they are still useful.
659 2007-05-07 Murray Cumming <murrayc@murrayc.com>
661 (modest_wizard_dialog_force_title_update):
662 * src/maemo/easysetup/modest-wizard-dialog.h:
663 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
664 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
665 can update the title when appropriate. Otherwise the title is wrong if the
666 pages are added after adding the notebook to the dialog.
667 This must be a problem in HildonWizardDialog too.
668 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
670 * src/maemo/easysetup/modest-easysetup-wizard.c:
671 (create_subsequent_customsetup_pages),
672 (create_subsequent_easysetup_pages):
673 Call modest_wizard_dialog_force_title_update() so that the title is
674 correct even with GTK+ < 2.10.
675 This fixes projects.maemo.org bug NB#56145 .
677 2007-05-07 Murray Cumming <murrayc@murrayc.com>
679 * src/maemo/modest-platform.c:
680 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
681 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
684 2007-05-07 Murray Cumming <murrayc@murrayc.com>
686 * src/widgets/modest-window.h:
687 * src/widgets/modest-window.c: Added a save_state_func vfunc,
688 and modest_window_save_state(), which invokes it.
690 * src/widgets/modest-window-mgr.h:
691 * src/widgets/modest-window-mgr.c:
692 Added modest_window_mgr_save_state_for_all_windows(), which calls
693 the save_state vfunc on all registered windows, if implemented.
695 * src/gnome/modest-msg-edit-window.c:
696 * src/gnome/modest-msg-view-window.c:
697 * src/maemo/modest-msg-edit-window.c:
698 * src/maemo/modest-msg-view-window.c:
699 * src/maemo/modest-main-window.c:
700 Specify the existing save_settings functions as implementations of
701 ModestWindow::save_state_func().
703 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
704 Call modest_window_mgr_save_state_for_all_windows(). This happens before
705 enabling hibernation, for instance.
707 We may need to do the same thing for restoring settings.
710 2007-05-07 Murray Cumming <murrayc@murrayc.com>
712 * src/widgets/modest-window-mgr.c:
713 * src/widgets/modest-window-mgr.h:
714 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
715 modest_window_mgr_get_hibernation_is_prevented().
717 * src/maemo/modest-main-window.c:
718 (on_hildon_program_is_topmost_notify): Prevent hibernation
719 (possible when the application goes to the background in the WM),
720 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
722 * src/maemo/easysetup/modest-easysetup-wizard.c:
723 (modest_easysetup_wizard_dialog_init):
724 * src/maemo/modest-account-settings-dialog.c:
725 (modest_account_settings_dialog_init):
726 * src/maemo/modest-connection-specific-smtp-edit-window.c:
727 (modest_connection_specific_smtp_edit_window_init):
728 * src/maemo/modest-connection-specific-smtp-window.c:
729 (modest_connection_specific_smtp_window_init):
730 * src/maemo/modest-signature-editor-dialog.c:
731 (modest_signature_editor_dialog_init):
732 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
733 prevent hibernation while any of these account settings dialogs are open.
735 2007-05-04 Murray Cumming <murrayc@murrayc.com>
737 * src/maemo/Makefile.am:
738 * src/maemo/modest-osso-state-saving.c:
739 * src/maemo/modest-osso-state-saving.h: Added
740 modest_osso_load_state() and modest_osso_save_state() though they do
741 nothing now. They should iterate through all the open windows and load/save
743 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
744 save state when closing.
746 * src/maemo/modest-main-window.c:
747 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
748 Add a notification handler for the HildonProgram::is-topmost property,
749 so we can allow hibernation when the application goes into the background.
750 But we still need to detect when the accounts setup windows are open so
751 we can stop hibernation when they are open.
752 To do this, I also added the main window the HildonProgram. This might have
753 other side-effects/benefits, and should maybe be done for other windows.
755 * src/maemo/modest-osso-autosave-callbacks.h:
756 * src/maemo/modest-osso-autosave-callbacks.c:
757 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
758 though it does not do anything yet, and we might never need this to do
759 anything. For instance, we already save drafts.
761 * src/maemo/modest-platform.c: (modest_platform_init):
762 Specify the libosso auto-save callback.
764 2007-05-03 Murray Cumming <murrayc@murrayc.com>
766 * src/maemo/modest-platform.c:
767 (modest_platform_set_update_interval):
768 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
769 aparently stays valid between application instances, so we can use this
770 to remove and reset it later. According to a maemo-developers email from
773 2007-05-03 Murray Cumming <murrayc@murrayc.com>
775 * configure.ac: Depend on libalarm for Maemo.
777 * src/dbus_api/modest-dbus-api.h:
778 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
779 (on_send_receive), (modest_dbus_req_handler):
780 Handle a SEND_RECEIVE D-Bus method.
782 * libmodest-dbus-client/libmodest-dbus-client.c:
783 (libmodest_dbus_client_send_and_receive):
784 * libmodest-dbus-client/libmodest-dbus-client.h:
785 Add C convenience functions for calling the new D-Bus method.
787 * src/modest-platform.h:
788 * src/gnome/modest-platform.c:
789 * src/maemo/modest-platform.c:
790 Added modest_platform_set_update_interval(), which uses the
792 (modest_platform_init),
793 Call modest_platform_set_update_interval(), using a hard-coded
794 interval for now (until the global settings dialog is implemented),
795 though I am not sure that this makes sense yet.
797 2007-05-02 Murray Cumming <murrayc@murrayc.com>
799 * src/dbus_api/modest-dbus-callbacks.c:
800 (modest_osso_cb_hw_state_handler):
801 * src/dbus_api/modest-dbus-callbacks.h:
802 * src/maemo/modest-platform.c: (modest_platform_init):
803 Registered (empty) callbacks for the osso hardware state D-Bus signals,
804 in case this has some effect on the ability for Maemo to ping the
807 2007-05-02 Murray Cumming <murrayc@murrayc.com>
809 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
810 Comment out an if() that checks a gchar for < 0, causing a build-breaking
811 warning. It is probably a logic error, but I need to fix the build.
813 2007-05-02 Murray Cumming <murrayc@murrayc.com>
815 * src/modest-account-mgr.h:
816 * src/modest-account-mgr.c:
817 (modest_account_mgr_account_names): Add a gboolean enabled_only
818 parameter, so we can get lists of onlt the enabled accounts.
820 (modest_account_mgr_add_account),,
821 (modest_account_mgr_account_with_display_name_exists):
822 * src/maemo/modest-msg-edit-window.c: (get_transports):
823 * src/modest-account-mgr-helpers.c:
824 (modest_account_mgr_set_first_account_as_default):
825 * src/modest-init.c: (init_default_account_maybe):
826 * src/modest-tny-account-store.c: (get_accounts):
827 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
828 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
829 * tests/check_account-mgr.c: (START_TEST):
830 Provide the extra parameter, as appropriate.
832 * src/widgets/modest-account-view.c: (update_account_view):
833 Do not show disabled accounts (meaning that there is no way to
834 enable/disable accounts in the UI (the feature is not in our UI
835 specification), so we can use this internally only to mark unfinished
836 or temporary account data.
838 * src/maemo/easysetup/modest-easysetup-wizard.c:
839 (create_account): Add boolean enable parameter, so we can specify FALSE
840 to create the temporary account.
841 (on_button_edit_advanced_settings): Create the temporary account as disabled.
842 (on_before_next): When finishing, when there is a temporary account, just
844 Also, use a timeout to delay the showing of the dialog until gconf is likely
845 to return correct information, due to a maemo gconf bug that is fixed in
846 osso 1.1, but not yet in Bora.
847 However, the dialog stays on screen after it is destroyed.
849 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
850 for invalid data when cancelling. Use a hildon note instead of a dialog
851 to complain about invalid data. Do not show the account-saved note if the
852 account is disabled (a temporary account that will not really be saved for use
855 2007-04-30 Murray Cumming <murrayc@murrayc.com>
857 * src/modest-account-mgr-helpers.h:
858 * src/modest-account-mgr-helpers.c:
859 Added modest_account_mgr_unset_default_account(),
860 Added modest_account_mgr_set_first_account_as_default().
862 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
863 If it was the default account, unset the default account name.
865 * src/maemo/modest-account-view-window.c:
866 (on_delete_button_clicked): If it was the default account,
867 set the first remaining account as the default instead.
869 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
870 a NULL account or a NULL default account, to prevent a crash. This should
871 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
874 2007-04-30 Murray Cumming <murrayc@murrayc.com>
876 * src/widgets/modest-recpt-editor.c:
877 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
878 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
879 TODO comment for this. This fixes the build.
881 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
882 be the best place for it. This will in future update all auto-update accounts,
883 rather than just the current/default account, when that gconf key exists.
884 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
885 if there are no accounts, before calling do_send_receive().
886 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
888 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
889 * src/maemo/modest-main-window-ui.h:
890 * src/maemo/modest-main-window.c: (on_connection_changed),
891 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
892 directly, becaue the signal handler does more.
894 2007-04-30 Murray Cumming <murrayc@murrayc.com>
896 * src/modest-account-mgr-helpers.c:
897 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
898 for the case that the account does not exist.
900 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
901 (equivalent to the modest account name) rather than the tinymail account name
902 (equivalent to the modest account title - human readable) to get the account data.
903 Check for null account data to prevent the crash, and add a TODO comment saying that
904 this needs fixing because it is using the server account name instead of the account name.
906 2007-04-29 Murray Cumming <murrayc@murrayc.com>
908 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
909 * src/maemo/modest-account-settings-dialog.c: (show_error),
911 Use hildon_note_new_information() for informative and error messages,
912 which seems to be expected for Maemo applications (no documentation that I know of
913 says this). I am surprised that there is no distinction between info and error
916 2007-04-29 Murray Cumming <murrayc@murrayc.com>
918 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
919 it is easy to find where this is used.
921 * src/maemo/easysetup/modest-easysetup-wizard.c:
922 (create_page_welcome), (create_page_account_details),
923 (create_page_user_details), (create_page_complete_easysetup),
924 (create_page_custom_incoming), (create_page_custom_outgoing),
925 (create_page_complete_custom):
926 * src/maemo/modest-account-settings-dialog.c:
927 (create_page_account_details), (create_page_user_details),
928 (create_page_incoming), (create_page_outgoing):
929 * src/maemo/modest-account-view-window.c: (window_vbox_new):
930 * src/maemo/modest-connection-specific-smtp-edit-window.c:
931 (modest_connection_specific_smtp_edit_window_init):
932 * src/maemo/modest-connection-specific-smtp-window.c:
933 (modest_connection_specific_smtp_window_init):
934 * src/maemo/modest-signature-editor-dialog.c:
935 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
936 and scrolling policy as per the Email Application Layout Guide, if I have
939 2007-04-27 Murray Cumming <murrayc@murrayc.com>
941 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
942 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
943 which were empty, because these vfuncs have been removed from TnyAccountStore.
944 This fixes the build.
946 2007-04-27 Murray Cumming <murrayc@murrayc.com>
948 * src/maemo/modest-main-window.c:
949 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
950 showing/hiding it. Added TODO because it probably should not be NULL.
951 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
952 because unnecessary g_warnings() make degugging difficult.
954 2007-04-27 Murray Cumming <murrayc@murrayc.com>
956 * src/maemo/modest-msg-edit-window.c:
957 (modest_msg_edit_window_select_color),
958 (modest_msg_edit_window_select_background_color): 2 const corrections and
959 moving 2 #endifs before closing brackets, to fix the build.
961 2007-04-27 Murray Cumming <murrayc@murrayc.com>
963 * src/maemo/easysetup/modest-easysetup-wizard.h:
964 * src/maemo/easysetup/modest-easysetup-wizard.c:
965 (modest_easysetup_wizard_dialog_finalize),
966 (on_button_edit_advanced_settings), (create_page_complete_custom),
967 (on_response), (create_account):
968 Implement the Advanced Settings edit button, by saving the account information,
969 for the Advanded Settings dialog to use directly from gconf, and removing it
970 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
971 Bug #5533 in the projects.maemo.org bugzilla.
973 2007-04-27 Murray Cumming <murrayc@murrayc.com>
975 * src/maemo/modest-msg-view-window.c:
976 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
977 when opening a message window.
979 2007-04-27 Murray Cumming <murrayc@murrayc.com>
981 * src/maemo/easysetup/modest-easysetup-wizard.c:
982 (create_page_custom_outgoing): Correct the position of the horizontal separator to
985 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
986 before showing/hiding them, to avoid a crash when clicking on folders when there are no
987 gconf settings. I probably added more checks than necessary, but that is safer.
989 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
990 variable to fix the build, but this seems to be used when it is still NULL.
992 2007-04-27 Murray Cumming <murrayc@murrayc.com>
994 * src/modest-platform.h:
995 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
996 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
997 * src/modest-main.c: Implement this function so we can avoid using
998 maemo-specific API from cross-platform code.
1000 * src/modest-tny-account-store.c:
1001 (get_smtp_specific_transport_account_for_open_connection):
1002 * src/modest-ui-actions.c: (check_for_connection),
1003 (modest_ui_actions_on_item_not_found):
1004 Use modest_platform_connect_and_wait() and put #idefs around other
1005 maemo-specific code, because only maemo currently has a way to
1006 identify connection names.
1008 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1010 * src/modest-tny-account-store.h:
1011 * src/modest-tny-account-store.c:
1012 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1013 the connection-specific SMTP server settings in the configuration.
1015 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1017 * src/maemo/modest-main-window.c: (on_connection_changed),
1019 * src/modest-main.c: (main), (start_ui), (send_mail):
1020 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1021 that is what is intended.
1023 * src/modest-ui-actions.c: (action_send), (action_receive),
1024 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1025 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1026 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1027 SMTP server is used when it is specified.
1029 (modest_ui_actions_on_send_receive):
1030 Check that a connection is open before proceeding.
1031 Receive and then send, instead of vice-versa, as per the specification.
1033 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1035 * src/modest-mail-operation.c:
1036 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1037 though I guess it should be something other than NULL.
1039 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1041 * src/maemo/easysetup/modest-easysetup-wizard.c:
1042 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1043 combo twice, to avoid an g_warning and to make it visible again.
1044 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1045 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1046 (already intended) dereference when detaching, because we then recreate the menu.
1047 But I am not sure why the warning was happening, and it is possible that this is a memory
1050 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1052 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1053 and uri_parse_mailto() utility functions.
1054 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1056 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1058 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1060 * src/dbus_api/modest-dbus-api.h:
1061 * src/dbus_api/modest-dbus-callbacks.c:
1062 Use an idle callback to execute the modest code in the application's own thread.
1063 Remove the helloworld example method.
1064 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1065 parsed, and the open-message method is not implemented because this is not yet implemented in
1067 * libmodest-dbus-client/libmodest-dbus-client.c:
1068 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1069 (libmodest_dbus_client_open_message):
1070 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1072 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1073 body without crashing.
1075 * tests/dbus_api/Makefile.am:
1076 * tests/dbus_api/test_mail_to.c:
1077 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1079 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1081 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1082 Added file to fix the build. Sorry.
1084 * src/dbus_api/Makefile.am:
1085 * src/dbus_api/modest-dbus-api.h:
1086 * src/dbus_api/modest-dbus-callbacks.h:
1087 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1088 (modest_dbus_req_handler):
1089 Put constants in a separate header so it can be reused by the
1090 client library, without duplication
1092 * libmodest-dbus-client/Makefile.am:
1093 * libmodest-dbus-client/libmodest-dbus-client.c:
1094 (libmodest_dbus_client_call_helloworld),
1095 (libmodfest_dbus_client_send_mail),
1096 (libmodfest_dbus_client_mailto),
1097 (libmodfest_dbus_client_open_message):
1098 * libmodest-dbus-client/libmodest-dbus-client.h:
1099 (Partly) Implement a send_mail D-Bus method.
1101 * tests/dbus_api/Makefile.am:
1102 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1103 the send_email D-Bus method.
1105 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1109 * libmodest-dbus-client/Makefile.am:
1110 * libmodest-dbus-client/libmodest-dbus-client.c:
1111 * libmodest-dbus-client/libmodest-dbus-client.h:
1112 * tests/dbus_api/Makefile.am:
1113 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1114 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1116 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1118 * src/maemo/easysetup/modest-easysetup-wizard.c:
1119 (create_page_account_details):
1120 * src/maemo/modest-account-settings-dialog.c:
1121 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1122 widgets, because this might not be the default in future versions of the Maemo GTK+.
1123 However, I can not not get capitalization to work even in a simple test case.
1125 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1127 * src/maemo/easysetup/modest-easysetup-wizard.c:
1128 (create_page_custom_incoming), (create_page_custom_outgoing):
1129 * src/maemo/modest-account-settings-dialog.c:
1130 (create_page_account_details), (create_page_incoming),
1131 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1132 instead of using gtk_check_button_with_label(), so they are aligned like the other
1133 widgets, as per the UI spec.
1135 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1137 * src/maemo/easysetup/modest-easysetup-wizard.c:
1138 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1139 * src/widgets/modest-validating-entry.c:
1140 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1141 Modest prefix instead of an EasySetup prefix.
1143 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1145 * src/widgets/modest-validating-entry.h:
1146 * src/widgets/modest-validating-entry.c: (on_insert_text),
1147 Added easysetup_validating_entry_set_max_func(), used to set a callback
1148 to call when the max number of characters is reached. GtkEntry has a max-length
1149 already but is silent about it.
1151 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1152 (create_page_account_details), (create_page_user_details),
1154 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1155 (create_page_account_details), (create_page_user_details),
1156 (create_page_outgoing):
1157 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1158 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1159 the UI spec, when the user tries to enter more than the max number of characters.
1161 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1163 * src/maemo/easysetup/modest-easysetup-wizard.c:
1164 (create_page_user_details), (create_page_custom_incoming),
1165 (create_page_custom_outgoing):
1166 * src/maemo/modest-account-settings-dialog.c:
1167 (create_page_user_details), (create_page_incoming),
1168 (create_page_outgoing):
1169 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1170 (modest_connection_specific_smtp_edit_window_init):
1171 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1172 not appropriate. Bad Maemo-specific defaults!.
1174 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1176 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1177 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1178 (modest_signature_editor_dialog_set_settings):
1179 Disable the label and textview when the checkbox is disabled, and use the
1180 specified (UI spec) default signature text.
1182 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1184 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1185 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1187 * src/modest-defs.h:
1188 * src/modest-account-mgr-helpers.h:
1189 * src/modest-account-mgr-helpers.c:
1190 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1192 * src/maemo/Makefile.am:
1193 * src/maemo/modest-signature-editor-dialog.c:
1194 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1197 * src/maemo/modest-account-settings-dialog.h:
1198 * src/maemo/modest-account-settings-dialog.c:
1199 (modest_account_settings_dialog_finalize), (on_button_signature),
1200 (save_configuration): Use the new dialog when the Edit button is pressed, and
1201 save the changes if necessary, as per the UI spec.
1203 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1205 * src/maemo/Makefile.am:
1206 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1207 based on maemo-develoers email from Dirk.
1209 * src/maemo/easysetup/modest-easysetup-wizard.c:
1210 (create_page_welcome), (create_page_account_details),
1211 (create_page_user_details), (create_page_complete_easysetup),
1212 (create_page_custom_incoming), (create_page_custom_outgoing),
1213 (create_page_complete_custom),
1214 (modest_easysetup_wizard_dialog_init):
1215 * src/maemo/modest-account-settings-dialog.c:
1216 (create_page_account_details), (create_page_user_details),
1217 (create_page_incoming), (create_page_outgoing),
1218 (modest_account_settings_dialog_init):
1219 * src/maemo/modest-connection-specific-smtp-window.c:
1220 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1222 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1224 * src/maemo/easysetup/modest-easysetup-wizard.c:
1225 (create_page_account_details), (create_page_custom_outgoing),
1226 (create_page_complete_custom):
1227 * src/maemo/modest-account-settings-dialog.c:
1228 (create_page_user_details), (create_page_incoming),
1229 (create_page_outgoing):
1230 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1231 (modest_connection_specific_smtp_edit_window_init):
1232 Use the correct (UI spec) port min/max, and use horizontal separators,
1235 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1237 * src/maemo/easysetup/modest-easysetup-wizard.c:
1238 (set_default_custom_servernames):
1239 * src/maemo/modest-account-settings-dialog.c:
1240 (create_page_incoming), (on_combo_outgoing_security_changed),
1241 (on_combo_incoming_security_changed), (create_page_outgoing),
1242 (modest_account_settings_dialog_set_account_name),
1243 (save_configuration):
1244 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1245 (on_combo_security_changed),
1246 (modest_connection_specific_smtp_edit_window_init),
1247 (modest_connection_specific_smtp_edit_window_set_connection),
1248 (modest_connection_specific_smtp_edit_window_get_settings):
1249 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1252 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1255 * src/maemo/easysetup/modest-easysetup-wizard.c:
1256 (create_page_custom_outgoing), (create_page_complete_custom):
1257 * src/maemo/modest-account-settings-dialog.c:
1258 (create_page_user_details), (create_page_outgoing):
1259 * src/maemo/modest-account-view-window.c: (button_box_new):
1260 Use changed logical IDs as per the most recent UI spec:
1261 mcen_bd_emailsetup_edit -> mcen_bd_edit
1262 mcen_bd_emailsetup_delete -> mcen_bd_delete
1263 mcen_bd_emailsetup_close -> mcen_bd_close
1265 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1269 * src/dbus_api/Makefile.am:
1270 * src/dbus_api/modest-dbus-callbacks.c:
1271 * src/dbus_api/modest-dbus-callbacks.h:
1272 * src/maemo/modest-platform.c: (modest_platform_init):
1273 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1275 * tests/Makefile.am:
1276 * tests/dbus_api/Makefile.am:
1277 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1279 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1281 * src/maemo/modest-account-settings-dialog.c:
1282 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1283 Removed unnecessary includes.
1285 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1287 * src/maemo/easysetup/modest-easysetup-wizard.c:
1288 * src/maemo/modest-account-settings-dialog.c:
1289 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1290 * src/widgets/Makefile.am:
1291 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1292 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1293 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1294 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1295 * src/widgets/modest-secureauth-combo-box.c:
1296 * src/widgets/modest-secureauth-combo-box.h:
1297 * src/widgets/modest-serversecurity-combo-box.c:
1298 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1299 made the GObject names more consistent with the rest of the Modest code.
1301 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1303 * src/maemo/easysetup/Makefile.am:
1304 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1305 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1306 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1307 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1308 * src/maemo/easysetup/modest-easysetup-wizard.c:
1309 * src/maemo/easysetup/modest-validating-entry.c:
1310 * src/maemo/easysetup/modest-validating-entry.h:
1311 * src/maemo/modest-account-settings-dialog.c:
1312 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1313 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1314 widgets/ because they are used outside of easysetup too. After checking in,
1315 svn will allow me to rename them too.
1317 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1319 * src/gnome/modest-msg-edit-window.c:
1320 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1321 linker error, to fix the build on the GNOME platform.
1322 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1323 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1324 ifdefed out to avoid a warning.
1326 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1328 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1329 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1330 some alternative for GTK+ 2.6.
1332 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1334 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1336 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1337 specified for EmailAccountsDialog in UI spec.
1339 * src/maemo/easysetup/modest-easysetup-wizard.c:
1340 * src/maemo/easysetup/modest-easysetup-wizard.h:
1341 * src/maemo/modest-account-settings-dialog.c:
1342 * src/maemo/modest-account-settings-dialog.h:
1343 Reuse a member window widget for the connection-specific SMTP server accounts,
1344 so we can tell it to create/save the accounts only if we actually save changes.
1346 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1347 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1348 (modest_connection_specific_smtp_edit_window_get_settings):
1349 Return a struct instance for temporarily remembering the entered data.
1351 * src/maemo/modest-connection-specific-smtp-window.h:
1352 * src/maemo/modest-connection-specific-smtp-window.c:
1353 (modest_connection_specific_smtp_window_finalize),
1354 (modest_connection_specific_smtp_window_fill_with_connections),
1356 (modest_connection_specific_smtp_window_save_server_accounts),
1357 (update_model_server_names): Do not actually save data until asked,
1358 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1360 (on_selection_changed),
1361 (modest_connection_specific_smtp_window_init): Disable the edit
1362 button when nothing is selected.
1364 * src/modest-account-mgr-helpers.c:
1365 * src/modest-account-mgr-helpers.h:
1366 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1369 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1371 * src/modest-account-mgr-helpers.h:
1372 * src/modest-account-mgr-helpers.c:
1373 (modest_account_mgr_get_unused_account_name),
1374 (modest_account_mgr_get_unused_account_display_name): Added these
1375 utility functions, to avoid code duplication.
1377 * src/maemo/easysetup/modest-easysetup-wizard.c:
1378 (create_page_account_details), (create_account):
1379 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1380 (on_combo_security_changed),
1381 (modest_connection_specific_smtp_edit_window_init),
1382 (modest_connection_specific_smtp_edit_window_save_settings):
1383 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1384 * src/maemo/modest-connection-specific-smtp-window.c:
1385 (modest_connection_specific_smtp_window_finalize),
1386 (modest_connection_specific_smtp_window_fill_with_connections),
1387 (on_button_edit), (modest_connection_specific_smtp_window_init):
1388 * src/maemo/modest-connection-specific-smtp-window.h:
1389 Implementing saving of connection-specific server accounts.
1391 But I need to refactor this so we can save the data for each
1392 possible connection-specific account and only actually create the server accounts
1393 when the easysetup finished, or the OK button is pressed on the account settings
1396 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1398 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1399 (on_combo_security_changed):
1400 (modest_connection_specific_smtp_edit_window_init):
1401 Auto-fill the port number as in the account settings.
1403 (modest_connection_specific_smtp_edit_window_set_connection):
1404 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1405 * src/maemo/modest-connection-specific-smtp-window.c:
1406 (fill_with_connections), (on_button_edit),
1407 (modest_connection_specific_smtp_window_init):
1408 Turn the edit window into a dialog to simplify the code, and
1409 set a WM hint as in a GtkDialog, because only a popup can be on top of
1410 another window in Maemo, and popups usually have no WM decoration.
1412 * src/modest-defs.h:
1413 * src/modest-account-mgr-helpers.c:
1414 (modest_account_mgr_set_connection_specific_smtp),
1415 (modest_account_mgr_remove_connection_specific_smtp),
1416 (modest_account_mgr_get_connection_specific_smtp):
1417 * src/modest-account-mgr-helpers.h: Some functions to write the
1418 connection-specific SMTP server information. Not yet used.
1421 * src/widgets/modest-folder-view.c: (text_cell_data):
1422 Fix a warning about an uninitialized variable.
1423 (on_configuration_key_changed): Put an #ifdef around the use
1424 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1426 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1428 * src/maemo/modest-account-settings-dialog.h:
1429 * src/maemo/modest-account-settings-dialog.c:
1430 Added connect_for_modified() utility function to mark the new modified boolean.
1432 (create_page_account_details), (create_page_user_details),
1433 (create_page_incoming), (create_page_outgoing), (on_response),
1434 (modest_account_settings_dialog_init),
1435 (modest_account_settings_dialog_set_account_name):
1436 Only warn about unsaved changes when there are actually unsaved changes.
1438 * src/modest-account-mgr-helpers.c:
1439 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1440 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1441 to get the data from there in future.
1443 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1445 * src/modest-defs.h:
1447 * src/modest-account-mgr-helpers.h:
1448 * src/modest-account-mgr-helpers.c:
1449 Store the security account setting in a single conf key instead of using
1450 the options list, so that the list is left for just the to-be-removed camel hack,
1451 and because gconf_client_set_list() is failing for some reason.
1453 * src/modest-account-mgr.c:
1454 (modest_account_mgr_add_server_account):
1455 * src/maemo/modest-account-settings-dialog.c:
1456 (modest_account_settings_dialog_set_account_name),
1457 (save_configuration): Use the renamed functions.
1460 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1462 * src/widgets/Makefile.am:
1463 * src/widgets/modest-limit-retrieve-combo-box.c:
1464 * src/widgets/modest-limit-retrieve-combo-box.h:
1465 * src/widgets/modest-retrieve-combo-box.c:
1466 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1467 the account settings dialog.
1469 * src/modest-defs.h:
1470 * src/modest-account-mgr-helpers.h:
1471 * src/modest-account-mgr-helpers.c:
1472 (modest_server_account_get_option_secure_auth),
1473 (modest_server_account_set_option_secure_auth):
1474 * src/modest-account-mgr.c:
1475 (modest_account_mgr_add_server_account):
1476 Use the existing AUTH_MECH conf key for the secure-auth setting,
1477 instead of putting it in the list options, because this was actually used already.
1479 * src/maemo/modest-account-settings-dialog.c:
1480 (create_page_account_details),
1481 (modest_account_settings_dialog_set_account_name),
1482 (save_configuration):
1483 * src/maemo/modest-account-settings-dialog.h:
1484 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1485 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1487 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1489 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1490 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1491 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1493 * src/modest-defs.h:
1494 * src/maemo/modest-account-settings-dialog.c:
1495 (create_page_incoming), (on_combo_outgoing_security_changed),
1496 (on_combo_incoming_security_changed), (create_page_outgoing),
1497 (modest_account_settings_dialog_set_account_name),
1498 (save_configuration): Load/Save the port number, and change it when the
1499 security combo changes, to suitable defaults.
1501 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1503 * src/modest-account-mgr.c:
1504 (modest_account_mgr_add_server_account): Set the security and secure-auth
1505 options, and add a comment saying that the other camel-specific options should be
1508 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1510 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1512 * src/modest-tny-account-store.c: (account_list_free),
1513 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1514 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1517 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1519 * src/modest-protocol-info.c:
1520 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1521 is required by our UI spec. Maybe something in our implementation will use this eventually.
1522 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1523 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1524 instead of the previous 0 placeholder.
1526 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1527 secure-auth settings.
1528 * src/modest-account-mgr-helpers.h:
1529 * src/modest-account-mgr-helpers.c:
1530 (modest_server_account_data_get_option_secure_auth),
1531 (modest_server_account_set_option_secure_auth),
1532 (modest_server_account_data_get_option_security),
1533 (modest_server_account_set_option_security): Added this API for getting and setting the security
1534 and secure-auth settings.
1536 * src/maemo/modest-account-settings-dialog.h:
1537 * src/maemo/modest-account-settings-dialog.c:
1538 (modest_account_settings_dialog_finalize), (check_data),
1539 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1540 about changing titles.
1541 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1542 (save_configuration): Save the security and secure-auth settings.
1544 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1545 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1547 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1549 * src/modest-defs.h:
1550 * src/modest-account-mgr.c:
1551 (modest_account_mgr_add_server_account):
1552 Added and used defines for the options key and value pair strings,
1553 that are used so far, though they do not seem to correspond to anything in our
1554 UI specs or ModestProtocol enum.
1556 * src/modest-account-mgr-helpers.h:
1557 * src/modest-account-mgr-helpers.c:
1558 (compare_option_strings_for_name),
1559 (modest_server_account_data_get_option_value),
1560 (modest_server_account_data_get_option_bool),
1561 (modest_account_mgr_get_server_account_option):
1562 Added helper functions for parsing the options GSList.
1564 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1566 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1567 display name is based on the supplied account name.
1568 * src/modest-account-mgr.c:
1569 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1570 with an inefficient, but good-enough, implementation.
1572 * src/maemo/easysetup/modest-easysetup-wizard.c:
1573 (create_page_account_details), (on_before_next), (create_account):
1574 Check for existing display names rather than (non-user-visible) account names, and just
1575 create and set a unique account name at the end.
1577 * src/maemo/modest-account-settings-dialog.c:
1578 (modest_account_settings_dialog_init),
1579 (modest_account_settings_dialog_set_account_name),
1580 (create_page_incoming): Show the display name, instead of the account name.
1581 (on_response): Do some (not all) extra checks, as in the UI spec.
1582 (save_configuration): Save the display name if it was changed.
1584 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1586 * po/en_GB.po: Added needed logical ID and translation.
1587 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1588 (init_view): Made the is-default column clicking work.
1590 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/easysetup/Makefile.am:
1594 * src/maemo/easysetup/modest-easysetup-wizard.c:
1595 (modest_easysetup_wizard_dialog_init):
1596 * src/maemo/easysetup/provider-data-test.keyfile:
1597 * src/maemo/easysetup/provider-data.keyfile:
1598 Moved the provider data file to the new modest-providers-data package and used it from there.
1600 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1602 * src/modest-local-folder-info.c:
1603 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1604 N_() was already used on the static strings, but this just marks it for translation without
1605 using the translation.
1607 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1609 * src/maemo/modest-account-settings-dialog.c:
1610 (create_page_incoming),
1611 (modest_account_settings_dialog_set_account_name):
1612 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1613 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1614 I will do this if nobody else gets there first.
1616 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1618 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1619 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1620 save the security stuff.
1622 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1624 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1625 Set the email address and user fullname, which I now see must be
1628 * src/maemo/modest-account-settings-dialog.h:
1629 * src/maemo/modest-account-settings-dialog.c:
1631 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1632 leave-on-server and authentication.
1633 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1636 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1639 * src/maemo/modest-account-settings-dialog.c:
1640 * src/maemo/modest-account-settings-dialog.h:
1641 Most (but not all) of the widgets are now present as specified by the UI spec.
1642 No changes are yet saved, and some details are not properly shown yet.
1644 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1646 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1648 * src/maemo/Makefile.am:
1649 * src/maemo/modest-account-settings-dialog.c:
1650 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1651 an existing account. Doesn't do much yet.
1653 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1654 Open the accounts settings dialog when Edit is clicked.
1656 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1658 * src/maemo/easysetup/Makefile.am:
1659 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1661 * src/maemo/easysetup/modest-easysetup-wizard.c:
1662 (modest_easysetup_wizard_dialog_init):
1663 Try to get the source directory from the build system,
1664 instead of hard-coding "./" into the source code, when opening our local
1665 copies of the configuration files.
1666 But this still fails when opening the wizard from the Accounts window,
1667 maybe because the working directory seems to change at runtime.
1668 So the wizard will fail the second time unless you copy the files into their
1669 proper locations - see the stdout warnings for the paths.
1671 (create_page_account_details),(on_before_next):
1672 Check for existing non-server accounts instead of server accounts,
1673 so the default account name is useful again, and to prevent trying to
1676 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1677 Show the wizard when New is clicked.
1679 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1680 (init_view): Show the column headers, and show the columns that are
1681 specified in the UI specs. However, something in Maemo's GTK+ prevents
1682 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1683 change the default account. This is despite unsetting the special properties.
1685 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1687 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1688 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1689 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1690 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1691 to make that clearer.
1692 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1694 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1696 * src/maemo/modest-account-view-window.c:
1697 (modest_account_view_window_init),
1698 (modest_account_view_window_new):
1699 Use the same buttons as specified in the
1700 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1701 the existing widgets, which never had a chance of working.
1702 Put the ModestAccountView treeview in a scrolled window.
1703 Do not repeat the initialization in both _init() and _new().
1705 * src/widgets/modest-account-view.c: (update_account_view):
1706 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1707 this widget and window shows no accounts.
1709 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1711 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1713 * src/maemo/easysetup/modest-easysetup-wizard.c:
1714 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1715 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1716 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1719 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1720 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1721 accounts exist yet, as in the UI spec.
1723 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1725 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1727 * src/maemo/Makefile.am:
1728 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1729 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1730 New window for editing connection-specific smtp details.
1731 Not fully implemented.
1733 * src/maemo/modest-connection-specific-smtp-window.c:
1734 (modest_connection_specific_smtp_window_finalize) :
1735 unref the tree model.
1736 (on_button_edit): Show the edit window.
1738 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1740 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1743 * src/maemo/Makefile.am:
1744 * src/maemo/modest-connection-specific-smtp-window.c:
1745 * src/maemo/modest-connection-specific-smtp-window.h:
1746 New window for showing the list of connections, for connection-specific
1747 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1748 * src/maemo/easysetup/modest-easysetup-wizard.c:
1749 (create_page_custom_outgoing): Show the new window when the button is clicked.
1751 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1753 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1754 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1755 * src/maemo/modest-msg-edit-window.c:
1756 (modest_msg_edit_window_insert_image):
1757 * src/modest-conf.c: (modest_conf_key_escape):
1758 * src/modest-mail-operation.c:
1759 (modest_mail_operation_send_new_mail):
1760 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1761 (modest_ui_actions_on_new_account):
1762 * src/widgets/modest-attachment-view.c: (update_filename_request):
1763 * src/widgets/modest-mail-header-view.c:
1764 Corrected warnings that were breaking the build, by commenting out unused variables,
1765 and a function, and by including a header.
1767 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1769 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1770 so we can #ifdef around platform-specific code when necessary.
1771 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1772 to allow this to build for the GNOME platform too.
1774 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1776 * src/maemo/easysetup/modest-easysetup-wizard.c:
1777 Added util_increment_name() and used it in create_page_account_details()
1778 to make sure that the default account name is always a new name.
1780 (modest_easysetup_wizard_dialog_init),
1781 (set_default_custom_servernames): Some minor memory management fixes.
1783 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1787 * src/modest-runtime.c: (init_i18n): Restored the translation
1788 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1789 are defined in config.h, and the translations are installed.
1791 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1792 is defined for translation.
1794 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1796 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1798 * src/maemo/easysetup/modest-easysetup-wizard.c:
1799 (modest_easysetup_wizard_dialog_init):
1800 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1801 Use realistic paths (though they should use $prefix generically) to the
1802 mcc_mapping and provider-data.keyfile files which might work when they
1803 are installed by the future version of the operator-wizard package,
1804 and then fallback to paths in our source code, with an explanatory
1807 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1811 * src/maemo/Makefile.am:
1812 * src/maemo/easysetup/: Added files from the previously-exernal
1813 osso-modest-easysetup.
1814 * src/maemo/modest-main-window-ui.h:
1815 * src/modest-ui-actions.c:
1816 * src/modest-ui-actions.h:
1817 Added modest_ui_actions_on_new_account() as a signal handler for the
1818 New Account menu item. It shows the easysetup wizard.
1819 * po/en_GB.po: Added additional needed logical IDs and translations.
1821 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1822 Apparently ChangeLog is not used for some vague Nokia legal reasons.