1 2007-07-11 Murray Cumming <murrayc@murrayc-desktop>
3 * src/modest-main.c: (main): Only show the UI at the start if
4 the showui command line option was given. For instance,
5 run-standalone src/modest showui
6 Otherwise, we wait for the top_application D-Bus method to
7 be sent by hildon-desktop when the application is selected
9 This allows us to run without a UI when osso-global-search
10 uses our D-Bus methods.
12 2007-07-11 Murray Cumming <murrayc@murrayc.com>
14 * src/dbus_api/modest-dbus-api.h: Added a define for a
15 top-application D-Bus method.
16 * src/dbus_api/modest-dbus-callbacks.c:
18 (modest_dbus_req_handler): Handle the top-application D-Bus
19 method, which might be an undocumented D-Bus signal sent by
20 hildon-desktop when it starts the application from the menu.
21 But I am not sure and I need to test it on the device, because
22 my scratchbox does not have the application in the menu now.
23 This method shows the main window, so that it can be invisible
24 when started, for instance, just for email searching from
27 * src/maemo/modest-main-window.c: (restore_settings),
28 (modest_main_window_new): Do not show the window immediately
29 upon creation. We show it later.
30 * src/modest-widget-memory.c: (save_settings_paned):
31 Try (unsuccessfully) to avoid saving the paned position when
32 it is not even visible.
33 (restore_settings_paned): Do not allow a silly paned position.
34 This seems necessary when not showing the window at first.
36 * tests/dbus_api/Makefile.am:
37 * tests/dbus_api/test_top_application.c: (main): Test for the
40 2007-07-10 Murray Cumming <murrayc@murrayc.com>
42 * src/modest-ui-dimming-rules.c:
43 (modest_ui_dimming_rules_on_new_msg),
44 (modest_ui_dimming_rules_on_reply_msg),
45 (modest_ui_dimming_rules_on_delete_msg),
46 (modest_ui_dimming_rules_on_details),
47 (modest_ui_dimming_rules_on_view_window_move_to),
48 (modest_ui_dimming_rules_on_view_previous),
49 (modest_ui_dimming_rules_on_view_next),
50 (_invalid_folder_for_purge): Added checks before
51 casting the window. This looks like an actual
52 logic error in _invalid_folder_for_purge(), because it
53 tries to use a ModestMainWindow as a message window.
55 2007-07-10 Murray Cumming <murrayc@murrayc.com>
57 * src/maemo/modest-account-settings-dialog.c:
58 (show_error): Use the same implementation as in
59 modest-easysetup-wizard.c:
60 (on_entry_invalid_character): The logical ID contains a %s.
61 Guessed what it should be.
62 (on_entry_max), (check_data), (on_response): Adapt to
64 (create_page_account_details): Really call
65 modest_validating_entry_set_func() on the correct widgets.
66 * src/maemo/easysetup/modest-easysetup-wizard.c:
67 (on_entry_invalid_character): Fix the logical ID here too.
68 (create_page_account_details),
69 (create_page_user_details):
71 modest_validating_entry_set_func() on the correct widgets.
73 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
74 Do not try to use the account if it is NULL.
76 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
78 * src/modest-ui-actions.c: (create_move_to_dialog),
79 (modest_ui_actions_on_main_window_move_to),
80 (modest_ui_actions_on_msg_view_window_move_to):
81 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
82 (filter_row), (modest_folder_view_show_non_move_folders):
83 * src/widgets/modest-folder-view.h:
85 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
86 the Sent folder yet as it does not report the correct folder type.
88 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
90 * src/maemo/modest-msg-edit-window.c: (init_window):
93 2007-07-10 Murray Cumming <murrayc@murrayc.com>
95 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
96 Take a parent widget instead of a parent window, and
97 implement this with hildon_banner_show_information() instead.
98 Non-Maemo builds can just ifdef that there.
99 This fixed projects.maemo.org bug NB#62766.
101 (on_entry_invalid_character): Use show_error() again instead
102 of using hildon directly, and use the _CS() macro to use the correct
104 (create_account), (check_for_supported_auth_methods), (on_entry_max):
105 Pass a widget instead od a window to show_error().
107 2007-07-10 Murray Cumming <murrayc@murrayc.com>
109 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
110 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
111 This allows us to show the server name in the error message, fixing
112 projects.maemo.org bug NB#62904.
113 Also, use the appropriate logical ID message for the account protocol.
115 2007-07-10 Murray Cumming <murrayc@murrayc.com>
117 * src/modest-tny-account-store.c: (on_idle_wrong_password):
118 A compilation fix, though the build wasn't broken for me.
120 2007-07-09 Murray Cumming <murrayc@murrayc.com>
122 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
123 Do not try to unref a NULL folder store, to avoid a runtime warning.
124 This seems to happen sometimes when changing accounts settings.
126 2007-07-09 Murray Cumming <murrayc@murrayc.com>
128 * src/modest-tny-account-store.c:
129 (modest_tny_account_store_instance_init),
130 (modest_tny_account_store_finalize),
131 (on_account_settings_hide), (on_idle_wrong_password):
132 Use a GHashTable to ensure that we only show one account settings
133 dialog per modest account. This avoids us having a dialog open for
134 both the store and transport accounts, or due to repeated get_password()
135 calls that shouldn't happen anyway.
137 2007-07-09 Murray Cumming <murrayc@murrayc.com>
139 * src/maemo/modest-maemo-utils.c: (on_hide),
140 (modest_maemo_show_dialog_and_forget): Handle the response, because
141 the window is not even hidden by default.
143 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
144 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
145 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
146 which seems to prevent some modality problems.
148 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
149 Ignore user cancellation errors.
151 * src/modest-account-mgr-helpers.h:
152 * src/modest-account-mgr-helpers.c:
153 Added modest_server_account_get_password() and
154 modest_server_account_get_has_password() to avoid direct use of
157 * src/maemo/modest-account-settings-dialog.h:
158 * src/maemo/modest-account-settings-dialog.c:
159 (modest_account_settings_dialog_init): Store the notebook so we can
161 Added modest_account_settings_dialog_switch_to_user_info().
163 * src/modest-tny-account-store.c:
164 (get_password): When the password in the account settings is wrong (we think),
165 show the relevant page of the account settings dialog, in the mainloop.
166 However, we currently get many of these at once because cancel does not
168 (forget_password): Do not forget the password
169 from the account settings, because this causes side-effects when
170 tinymail seems to call it at strange time, maybe because of how we
171 are cancelling get_password().
172 (modest_tny_account_store_alert): Ignore user cancellations.
174 2007-07-09 Murray Cumming <murrayc@murrayc.com>
176 * src/maemo/modest-maemo-utils.h:
177 * src/maemo/modest-maemo-utils.c:
178 Added modest_maemo_show_information_note_and_forget() for use instead of
179 gtk_dialog_run() when the response is not needed, to avoid an extra
180 mainloop which could cause a hang.
182 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
183 Use the logical IDs for the error message, though they are not
184 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
185 because gtk_dialog_run() caused a hang here (the window did not close).
186 This fixes projects.maemo.org bug NB#62646.
188 2007-07-09 Murray Cumming <murrayc@murrayc.com>
190 * src/modest-account-mgr-helpers.h:
191 * src/modest-account-mgr-helpers.c:
192 Added modest_account_mgr_get_store_protocol().
194 * src/maemo/modest-account-view-window.c:
195 (on_delete_button_clicked): Show different warning text depending on
196 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
197 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
200 2007-07-09 Murray Cumming <murrayc@murrayc.com>
202 * src/maemo/modest-msg-edit-window.c:
203 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
204 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
206 2007-07-07 Armin Burgmeier <armin@openismus.com>
208 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
209 ckdg_ib_maximum_characters_reached from correct package.
211 * src/modest-ui-actions.c: Show an error message when a folder could
212 not be created. Tinymail does not give us specific error codes about
213 what has gone wrong, so we assume that a folder with that name
214 already exists, though there might be other reasons.
216 2007-07-06 Murray Cumming <murrayc@murrayc.com>
218 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
219 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
220 give a more exact error message that can be partly translated.
222 2007-07-05 Murray Cumming <murrayc@murrayc.com>
224 * src/maemo/modest-address-book.c:
225 (select_email_addrs_for_contact): Specify a default window size for the
226 select-email-address dialog, so that it is probably big enough for the
227 title. This should fix projects.maemo.org bug NB#62277.
229 2007-07-05 Murray Cumming <murrayc@murrayc.com>
231 * src/maemo/easysetup/modest-easysetup-wizard.c:
232 (create_page_complete_easysetup): Use
233 gtk_widget_set_size() request to ensure that the text wraps
236 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
238 * src/maemo/easysetup/modest-easysetup-wizard.c:
239 (on_entry_invalid_character), (create_page_account_details),
240 (create_page_user_details):
241 Use new API of ModestValidatingEntry. But for some reason the banner is
242 not shown. I will have to investigate that further.
244 * src/widgets/modest-validating-entry.c: (on_insert_text),
245 (modest_validating_entry_set_func):
246 * src/widgets/modest-validating-entry.h:
247 Added a new callback function to be able to react to prevented
248 characters whitespaces to e.g show a banner.
250 2007-07-05 Armin Burgmeier <armin@openismus.com>
252 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
253 notification of HildonNumberEditor instead of remembering the port
254 number. Thanks to Johannes for pointing this out.
256 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
258 * src/maemo/easysetup/modest-easysetup-wizard.c:
259 Check if there are any user changes before showing a confirmation
260 dialog (projects.maemo.org NB#60946)
262 2007-07-05 Armin Burgmeier <armin@openismus.com>
264 * src/maemo/modest-account-settings-dialog.c: Remember custom port
265 number at the beginning of the dialog and set the modified flag at the
266 end if the port number has changed. This is necessary because
267 HildonNumberEditor does not support notification when the value has
270 2007-07-05 Murray Cumming <murrayc@murrayc.com>
272 * src/modest-ui-actions.c:
273 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
274 a connection before asking anything else. Correct the check for the destination
275 folder so that it succeeds when online.
276 This fixed projects.maemo.org bug NB#61645.
278 2007-07-05 Murray Cumming <murrayc@murrayc.com>
280 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
281 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
282 to fix projects.maemo.org bug NB#62439.
284 2007-07-05 Murray Cumming <murrayc@murrayc.com>
286 * src/modest-tny-account.c: (on_connection_status_changed):
287 Really do not use tny_device_force_offline() here. See the previous comment.
289 2007-07-04 Murray Cumming <murrayc@murrayc.com>
291 * src/modest-tny-account.c: (on_connection_status_changed):
292 Do not use tny_device_force_offline() when tinymail says that something
293 went wrong with the connection. It seems to report this unnecessarily.
295 2007-07-04 Murray Cumming <murrayc@murrayc.com>
297 * src/maemo/modest-connection-specific-smtp-window.c:
298 (modest_connection_specific_smtp_window_init):
299 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
300 does not seem to have any effect in osso 1.1 (though it works in
301 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
303 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
305 * src/maemo/modest-connection-specific-smtp-window.c:
306 Fix UI specification problems with projects.meamo.org NB#60479
308 2007-07-04 Murray Cumming <murrayc@murrayc.com>
310 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
311 clue when this has failed, because the error dialog is not always shown
312 (at least in earlier version).
314 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
315 GError message, because the generic error dialog is not helpful.
317 'This message is not currently available (can't let a new connection go online)'
318 when trying to open an IMAP message.
320 (_modest_ui_actions_open): Offer a connection when some messages would
321 have to be downloaded and we are offline.
323 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
325 * src/widgets/modest-folder-view.c:
326 Don't check for MERGE type anymore as we use the correct type
328 NOTE: For the last two changes you need to update your tinymail copy
329 because of API changes!
331 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
333 * src/modest-tny-local-folders-account.c:
334 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
335 (see projects.maemo.org NB#61580)
337 2007-07-04 Murray Cumming <murrayc@murrayc.com>
339 * src/modest-tny-account.c: (on_connection_status_changed):
340 Commented out the call to modest_platform_connect_and_wait() because this
341 seems to always hang, and I would like to know if this is the only thing
342 that causes a hang when showing the connection dialog.
343 It is not very useful anyway.
345 2007-07-04 Murray Cumming <murrayc@murrayc.com>
347 * src/maemo/modest-msg-view-window.c:
348 (modest_msg_view_window_select_next_message):
350 * src/modest-platform.h:
351 * src/maemo/modest-platform.c:
352 Added modest_platform_connect_and_wait(), which calls
353 tny_maemo_conic_device_connect() always in the main thread, by calling it
354 in an idle handler and waiting for the idle handler to run. It should be
355 in the main thread because it uses GTK+ UI code. It just returns TRUE
356 if the device is already online.
358 There is some nasty code to ensure that subsequent calls to
359 modest_platform_connect_and_wait() just wait for the first one to finish,
360 by checking repeatedly in another idle handler. This is necessary,
361 because other threads (or even the main thread, via another idle handler)
362 can call modest_platform_connect_and_wait() while
363 modest_platform_connect_and_wait() is running.
365 (modest_platform_connect_and_wait_if_network_account),
366 (modest_platform_connect_and_wait_if_network_folderstore):
367 Convenience functions that calls modest_platform_connect_and_wait() if
368 the account or folder might want network access.
370 * src/modest-mail-operation.c:
371 (modest_mail_operation_update_account):
372 * src/modest-ui-actions.c: (download_uncached_messages),
373 (modest_ui_actions_on_rename_folder), (delete_folder),
374 (modest_ui_actions_on_main_window_move_to),
375 (modest_ui_actions_on_msg_view_window_move_to):
376 * src/widgets/modest-folder-view.c:
377 (drag_and_drop_from_folder_view):
378 Offer a connection if we are offline.
380 * src/modest-tny-account.c: (on_connection_status_changed):
381 Document this as only handling errors during network operations in progress,
382 and replace the idle code with a simple call to
383 modest_platform_connect_and_wait(), which does this instead.
385 2007-07-03 Murray Cumming <murrayc@murrayc.com>
387 * src/modest-tny-account.c:
388 (modest_tny_account_get_special_folder): (util_on_idle),
389 Handle the GError so we can see when tny_folder_store_get_folders()
390 fails, as it currently does while something else is connecting.
392 Added util_run_in_main_thread_and_wait()
393 which uses an idlen handler and mainloop to ensure that the function
394 is called in the main thread.
395 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
396 to make sure that we call attempt the connection in the mainloop only,
397 which might solve some hangs.
399 2007-07-03 Murray Cumming <murrayc@murrayc.com>
401 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
402 be found by their display name. This is never useful.
403 * src/modest-tny-account-store.c: (on_account_removed): Find the account
404 by its ID, instead of trying to use its ID as its display name.
406 * src/modest-tny-account-store.h:
407 * src/modest-tny-account.c:
408 (modest_tny_account_get_special_folder): Add a g_warning() when
409 tny_folder_store_get_folders() returns an empty list for the maildir.
411 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
412 Add a g_warning() when this returns NULL, because that it not allowed
415 2007-07-02 Armin Burgmeier <armin@openismus.com>
417 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
418 note when trying to cancel the wizard. This fixes projects.maemo.org
421 2007-07-02 Murray Cumming <murrayc@murrayc.com>
423 * src/modest-tny-account.h:
424 * src/modest-tny-account.c:
425 (modest_tny_account_new_from_server_account),
426 (modest_tny_account_new_from_server_account_name),
427 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
428 because this must now be set before setting the proto. This is usd in
429 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
430 warning in camel_session_get_service() caused by
431 tny_camel_transport_account_prepare().
433 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
436 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
438 * src/maemo/modest-connection-specific-smtp-edit-window.c:
440 (modest_connection_specific_smtp_edit_window_init):
442 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
445 2007-06-29 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-tny-account.c:
448 (modest_tny_account_new_from_server_account):
449 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
450 now uses to request a connection when it needs one, and which it uses
451 to tell us that something is wrong with the connection, so we can force
452 the accounts offline to prevent further problems.
455 * src/modest-init.c: (init_default_settings):
456 * src/modest-mail-operation.c:
457 (modest_mail_operation_update_account):
458 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
459 This should not be necessary anymore. Do not set the conf key that
460 determined this (it was always TRUE and not set anywhere else).
462 * src/modest-ui-actions.h: Remove unused and unimplemented
463 modest_ui_actions_on_online_toggle_toggled().
465 2007-06-29 Murray Cumming <murrayc@murrayc.com
467 * src/maemo/modest-main-window.c: (connect_signals):
468 Don't connect to delete_event twice. Maybe this was harmless.
470 2007-06-29 Murray Cumming <murrayc@murrayc.com
472 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
473 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
474 Debug output to give some more clue when a folder move is not allowed.
476 2007-06-28 Murray Cumming <murrayc@murrayc.com
478 * src/modest-tny-account.c: (on_modest_file_system_info),
479 (modest_tny_account_get_mmc_account_name):
480 Always call the callback, without checking whether the name has changed.
481 * src/widgets/modest-folder-view.c: (strings_are_equal),
482 (on_model_foreach_set_name), (on_get_mmc_account_name),
483 (text_cell_data): Compare the name here, and use the name from
484 the account rather than from the
485 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
486 if the name was changed after the account was added to the model.
487 That's a tinymail bug but not one that I want to fix now.
489 This finally fixes projects.maemo.org bug NB#59301.
491 2007-06-27 Armin Burgmeier <armin@openismus.com>
493 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
496 2007-06-27 Murray Cumming <murrayc@murrayc.com
498 * src/modest-tny-account.h:
499 * src/modest-tny-account.c:
500 Added modest_tny_account_get_mmc_account_name(), to set the memory
501 card name asynchronously for the given account and then notify.
502 (modest_tny_account_new_for_local_folders): Use this new function instead
503 of using hildon_file_system_info_async_new() directly.
505 * src/widgets/modest-folder-view.c: (text_cell_data):
506 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
507 gtk_tree_model_row_changed() when it is available.
509 This should fix projects.maemo.org bug NB#59301.
511 2007-06-27 Murray Cumming <murrayc@murrayc.com
513 * src/modest-mail-operation.c: (update_account_thread),
514 (get_msgs_full_thread): Fix typo failures in the revert
517 2007-06-27 Murray Cumming <murrayc@murrayc.com
519 * src/maemo/modest-maemo-global-settings-dialog.c:
520 (idle_select_default_focus):
521 * src/modest-mail-operation.c: (idle_notify_progress),
522 (idle_notify_progress_once), (set_last_updated_idle),
523 (update_account_thread), (get_msgs_full_thread):
524 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
525 * src/widgets/modest-header-view.c:
526 (idle_notify_headers_count_changed_destroy),
527 (idle_notify_headers_count_changed):
528 Reverted the additions of gdk_threads_enter/leave(), in case this
529 helps with a startup hang on the device.
531 2007-06-26 Armin Burgmeier <armin@openismus.com>
533 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
534 for supported secure authentication methods from server by
535 gtk_dialog_run(), saving CPU time and a potential race condition.
537 2007-06-26 Armin Burgmeier <armin@openismus.com>
539 * src/maemo/modest-maemo-utils.h:
540 * src/maemo/modest-maemo-utils.c: Added a
541 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
542 only error code to tell the calling code when the user canceled the
545 * src/maemo/modest-account-settings-dialog.h:
546 * src/maemo/modest-account-settings-dialog.c:
547 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
548 message if the retrieval of secure authentication methods was canceled
549 by the user. Perform the check before saving anything to configuration
550 to not end up with half-committed configuration changes, do not show
551 a "Saving to configuration failed" note when authentication methods
552 could not be retrieved.
554 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
557 2007-06-26 Murray Cumming <murrayc@murrayc.com>
559 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
560 Only return the first level of folders under accounts, because the
561 osso-global-search UI spec doesn't want the rest.
562 This fixed projects.maemo.org bug NB#61811.
564 2007-06-26 Murray Cumming <murrayc@murrayc.com>
566 * src/modest-tny-account-store.c:
567 * src/modest-tny-account-store.h:
568 Added modest_tny_account_is_memory_card_account().
569 * src/maemo/modest-main-window.c: (create_details_widget):
570 Show the same information items for the memory card as we show for the
571 local-folders, to fix projects.maemo.org bug NB#59307.
573 2007-06-26 Murray Cumming <murrayc@murrayc.com>
575 * src/modest-tny-account-store.c: (get_password):
576 Added some checks for NULL to maybe prevent crashes, though I think
577 it was Philip's last commit that actually prevented the crash here
578 when creating a first new account.
579 But the new account is still not usable (no messages are shown)
580 until a restart of the application.
582 2007-06-26 Murray Cumming <murrayc@murrayc.com>
584 * src/maemo/modest-maemo-global-settings-dialog.c:
585 (idle_select_default_focus):
586 * src/modest-mail-operation.c: (idle_notify_progress),
587 (idle_notify_progress_once), (idle_notify_update_account_queue),
588 (set_last_updated_idle), (update_account_thread),
589 (notify_get_msgs_full), (get_msgs_full_destroyer),
590 (get_msgs_full_thread):
591 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
592 * src/widgets/modest-header-view.c:
593 (idle_notify_headers_count_changed_destroy),
594 (idle_notify_headers_count_changed):
595 Use gdk_threads_enter() and gdk_threads_enter_leave() in
596 all idle handlers, because some other thread could be blocking
597 the GDK lock, so that it can do GUI stuff.
599 2007-06-26 Murray Cumming <murrayc@murrayc.com>
601 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
602 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
603 (on_idle_send_receive), (on_idle_open_default_inbox):
604 * src/maemo/modest-msg-edit-window.c:
605 (modest_msg_edit_window_attach_file_noninteractive):
606 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
607 to prevent a hang. I don't quite understand why these are necessary,
608 beause we should already be in the main loop. I guess something outside
609 of the main loop is taking the lock.
611 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
612 we are really using URIs, and use files that are more likely to exist.
614 2007-06-26 Murray Cumming <murrayc@murrayc.com>
616 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
617 necessary because configure.ac now defines different variables.
619 2007-06-26 Murray Cumming <murrayc@murrayc.com>
621 * libmodest-dbus-client/libmodest-dbus-client.c:
622 * libmodest-dbus-client/libmodest-dbus-client.h:
623 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
624 libmodest_dbus_client_compose_mail() is what things actually use.
626 * src/dbus_api/modest-dbus-api.h:
627 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
628 * tests/dbus_api/Makefile.am:
629 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
632 2007-06-26 Murray Cumming <murrayc@murrayc.com>
634 * src/modest-init.c: (modest_init_local_folders):
635 For memory-card (or other non local-folders) maildir accounts,
636 always create an Archive folder, so that there is somewhere to put
637 messages. This should be less confusing, because the user does not need
638 to guess that the need to create a folder.
640 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
642 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
643 Fixed icon size by using (50, 50) which is the same as defined by
646 2007-06-25 Armin Burgmeier <armin@openismus.com>
648 * src/widgets/modest-window-mgr.c:
650 * configure.ac: Correctly recognize hildon-notify presence and fixed
651 the build without it being installed.
653 2007-06-25 Murray Cumming <murrayc@murrayc.com>
655 * libmodest-dbus-client/libmodest-dbus-client.c:
656 (libmodest_dbus_client_search): Fix the build. Sorry.
657 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
658 (reply_forward_cb): Initialize variables to fix the build.
660 * src/modest-tny-account-store.c:
661 (modest_tny_account_store_get_tny_account_by): Fix the account URI
662 comparison (a silly typo) so that email search results can be opened
663 when there are more than one account.
665 2007-06-25 Murray Cumming <murrayc@murrayc.com>
667 * libmodest-dbus-client/libmodest-dbus-client.c:
668 (libmodest_dbus_client_search),
669 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
670 instead of 1 second, because the search gets folders and messages from
671 the server, which can take a long time. When it times out,
672 osso-global-search will report no results.
674 We need to specify whether we should search only cached information
675 (maybe with a user preference), and the osso-email-search-plugin
676 API should really be improved to allow that option, and to allow results
677 to be delivered asynchronously in batches.
679 2007-06-25 Murray Cumming <murrayc@murrayc.com>
681 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
682 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
683 GTK_ICON_SIZE_DIALOG is probably the wrong size.
685 2007-06-25 Murray Cumming <murrayc@murrayc.com>
687 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
688 that is an empty string. D-Bus seems to give us these instead of NULL.
690 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
692 * src/dbus_api/modest-dbus-callbacks.c:
693 * src/maemo/easysetup/modest-easysetup-wizard.h:
694 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
695 * src/maemo/modest-connection-specific-smtp-edit-window.c:
696 (modest_connection_specific_smtp_edit_window_init):
697 * src/maemo/modest-maemo-global-settings-dialog.c:
699 * src/maemo/modest-maemo-utils.c:
700 (modest_maemo_utils_setup_images_filechooser):
701 * src/maemo/modest-main-window.c: (create_details_widget):
702 * src/maemo/modest-msg-edit-window.c:
703 (modest_msg_edit_window_attach_file_noninteractive),
704 (modest_msg_edit_window_color_button_change),
705 (modest_msg_edit_window_set_zoom):
706 * src/modest-mail-operation.c: (update_account_thread):
707 * src/modest-tny-account-store.c:
708 * src/modest-tny-account.c:
709 * src/widgets/modest-global-settings-dialog.c:
710 * src/widgets/modest-window.h:
714 2007-06-25 Murray Cumming <murrayc@murrayc.com>
716 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
717 * src/modest-search.c: (modest_search_folder),
718 (modest_search_all_accounts): Actually search only in the specified folder,
719 doing a simple match on the folder ID.
720 * src/modest-search.h: Added a folder field to the ModestSearch struct,
721 and added some documentation.
723 2007-06-22 Armin Burgmeier <armin@openismus.com>
725 * src/maemo/modest-maemo-utils.h:
726 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
727 modest_maemo_utils_get_supported_secure_authentication_methods.
729 * src/maemo/easysetup/modest-easysetup-wizard.c:
730 * src/maemo/modest-account-settings-dialog.c: Show correct error if
731 one occured, not just "Server does not support secure authentication".
733 2007-06-22 Murray Cumming <murrayc@murrayc.com>
735 * src/modest-tny-account-store.c: (get_password):
736 Restored the call to tny_account_set_user() because Philip seems to have
737 stopped this from crashing (by not using the freed string). It still does
738 not work, but now we can test it.
740 2007-06-22 Murray Cumming <murrayc@murrayc.com>
742 * src/maemo/modest-msg-edit-window.c: (init_window):
743 Comment out use of an uninitialzed GtkScrolledWindow variable,
744 to fix the build and stop a crash. Yet again.
746 2007-06-22 Murray Cumming <murrayc@murrayc.com>
748 * src/modest-tny-account-store.c: (get_password):
749 Remove the call to tny_account_set_user() because this actually crashes.
750 As mentioned in the last commit, it is known to not work anyway.
752 2007-06-22 Murray Cumming <murrayc@murrayc.com>
754 * src/modest-tny-account-store.c: (get_password):
755 Use tny_account_set_username() to tell tinymail that the username might
756 have changed too. But tinymail ignores this: see projects.maemo.org
758 * src/modest-ui-actions.c:
759 (modest_ui_actions_on_password_requested): Remove the useless attempt to
760 reset the connection when changing the username, and improve the comments.
761 Save the changed username to gconf at least, so it is used when Modest is
764 2007-06-21 Murray Cumming <murrayc@murrayc.com>
766 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
767 Do not use a query, so that we get all folders, including for POP and
768 local-folders. They work as search criteria too.
769 This fixes projects.maemo.org bug NB#57740.
771 2007-06-21 Murray Cumming <murrayc@murrayc.com>
773 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
774 Comment out the use of hildon_notification_set_sound() because it is
775 not declared, to fix the build. Warnings are serious, people.
777 2007-06-21 Armin Burgmeier <armin@openismus.com>
779 * src/maemo/modest-maemo-utils.h:
780 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
781 modest_maemo_utils_get_supported_secure_authentication_methods()
782 to query authentication methods for a specific user. This should fix
783 projects.maemo.org bug NB#61369.
785 * src/maemo/easysetup/modest-easysetup-wizard.c:
786 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
789 2007-06-21 Murray Cumming <murrayc@murrayc.com>
791 * libmodest-dbus-client/libmodest-dbus-client.h:
792 * libmodest-dbus-client/libmodest-dbus-client.c:
793 (modest_dbus_message_iter_get_search_hit),
794 (libmodest_dbus_client_search):
795 Reorganised and commented this.
796 Removed modest_search_hit_free() from the public API because it
799 Added libmodest_dbus_client_get_folders() and
800 modest_folder_result_list_free().
802 * src/dbus_api/modest-dbus-api.h:
803 * src/dbus_api/modest-dbus-callbacks.c:
804 (modest_dbus_req_filter): Commented. Moved most code to
805 on_dbus_method_search() and added on_dbus_method_get_folders().
807 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
808 of the extra D-Bus handler.
810 * tests/dbus_api/Makefile.am:
811 * tests/dbus_api/test_get_folders.c: New test for
812 libmodest_dbus_client_get_folders(). This seems to return an empty list
813 at the moment. That could be the same error that causes the message list
814 to be empty sometimes.
815 This should help with projects.maemo.org bug NB#57740.
817 2007-06-21 Armin Burgmeier <armin@openismus.com>
819 * src/modest-mail-operation.c: Do not call
820 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
821 notify the operation's end after having set the status to CANCELED for
822 the operation queue to listen on. This fixes a deadlock when there
823 were mail operations in the queue during its finalization.
825 * src/modest-singletons.c: Reordered uninitialization of the account
826 manager to happen after the mail operation queue was uninitialized
827 because the mail operation's in the queue might still try to access
828 the account manager (see modest_mail_operation_notify_end()). This
829 fixes a potential crash when terminating the application.
831 2007-06-21 Murray Cumming <murrayc@murrayc.com>
833 * src/modest-search.c:
834 (search_mime_part_and_child_parts): Moved some code here so we
835 can search recursively in child folders.
836 (modest_search_folder): Search in the message as a mime part, instead
837 of just its child mime parts.
838 (read_chunk), (search_mime_part_ogs):
839 Check how many bytes were read, to prevent an endless loop.
840 Searching in message bodies now works. This finishes the fix for
841 projects.maemo.org bug NB#61007.
843 2007-06-20 Murray Cumming <murrayc@murrayc.com>
845 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
846 Add a g_warning when the item is not a folder.
848 * src/modest-ui-dimming-rules.c:
849 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
850 when selected item is not a folder (for instance, an account), because
851 the UI spec only talks about folders.
852 I am not sure what the UI spec wants, so this might not totally fix
853 projects.maemo.org bug NB#60794.
855 2007-06-20 Murray Cumming <murrayc@murrayc.com>
857 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
858 (load_from_file): Sort the list. The unsorted list would be more noticeable
859 in non-English locales.
861 * src/maemo/modest-msg-edit-window.c:
862 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
863 warning and fix the build.
865 * src/maemo/modest-progress-bar-widget.c:
866 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
867 avoid a g_warning, and probably to avoid a crash.
869 2007-06-20 Murray Cumming <murrayc@murrayc.com>
871 * src/modest-search.c: (modest_search_folder): Check for a GError
872 when calling tny_folder_get_headers(), to show that this is not the cause
875 2007-06-20 Murray Cumming <murrayc@murrayc.com>
877 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
878 Actually set the body query instead of the subject query.
880 * src/modest-search.c: (search_mime_part_ogs),
881 (search_mime_part_strcmp): Remove extra space from the text/* regex,
882 which would probably cause it to fail if we got this far.
884 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
885 to simplify the code.
886 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
887 be causing search-in-body to fail.
889 2007-06-20 Murray Cumming <murrayc@murrayc.com>
891 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
893 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
894 Better debug message when the folder cannot be found.
895 This should help with fixing projects.maemo.org bug #61287.
896 * src/modest-search.c: (add_hit): Do not leak the furl string.
898 2007-06-20 Murray Cumming <murrayc@murrayc.com>
900 * src/modest-ui-actions.c:
901 (modest_ui_actions_on_folder_selection_changed):
902 Do not special-case TNY_MERGE_FOLDER here, because
903 modest_tny_folder_get_account() already does that. This fixes
904 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
905 shown when the Outbox was selected).
907 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
909 * libmodest-dbus-client/libmodest-dbus-client.c:
910 (_dbus_iter_get_string_or_null): Initialize the string variable in
911 case this helps with Dirk's crash.
913 2007-06-19 Murray Cumming <murrayc@murrayc.com>
915 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
916 though it is not implemented yet (this function is maybe not even used),
917 to avoid breaking ABI in future.
918 * libmodest-dbus-client/libmodest-dbus-client.c:
919 (get_attachments_string): Moved some code into this generic function.
920 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
921 sends email. It is maybe not used.
922 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
923 (on_send_mail): Use attachments.
925 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
926 * src/maemo/modest-msg-edit-window.c:
927 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
928 a filename before using it, to fix projects.maemo.org bug NB#58233.
930 2007-06-19 Murray Cumming <murrayc@murrayc.com>
932 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
933 Initialize the continue_download variable to fix the build, and probably
934 to fix randome behaviour.
936 2007-06-18 Armin Burgmeier <armin@openismus.com>
938 * src/modest-tny-send-queue.h:
939 * src/modest-tny-send-queue.c: Keep track of the status of messages in
940 the queue so we can later show it in the UI. Replaced
941 modest_tny_send_queue_msg_is_being_sent() by
942 modest_tny_send_queue_get_msg_status().
944 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
946 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
947 gpointer. This probably was not harmful, but just to be sure.
949 2007-06-18 Murray Cumming <murrayc@murrayc.com>
951 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
952 Fix the build, but leave the function broken on Bora, because
953 hildon_uri_action_get_service() does not exist.
954 osso_uri_action_get_service() does not exist either, it seems.
956 2007-06-18 Murray Cumming <murrayc@murrayc.com>
958 * src/modest-tny-account.c:
959 (modest_tny_account_new_from_server_account):
960 Uncommented the url debug output again, because it is useful for
961 debugging, as I said in the comment.
963 2007-06-18 Murray Cumming <murrayc@murrayc.com>
965 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
967 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
968 for Mameo Bora, to fix the build.
970 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
973 Fixed build with hildon < 0.99
975 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
976 Check if the selected account is busy instead of checking all accounts
978 * src/modest-account-mgr-priv.h:
979 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
980 (modest_account_mgr_init), (compare_account_name),
981 (modest_account_mgr_set_account_busy),
982 (modest_account_mgr_account_is_busy):
983 * src/modest-account-mgr.h:
984 Added busy information to the account manager. It possible to
985 set an account to busy or not busy now.
987 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
988 (modest_mail_operation_update_account),
989 (modest_mail_operation_notify_end):
990 Set the account to busy/not busy depending on the operation state.
992 * src/widgets/modest-account-view.c:
993 (modest_account_view_finalize), (get_last_updated_string),
994 (update_account_view), (on_account_busy_changed), (init_view):
995 Show string "Refreshing..." if the account is currently busy.
997 All this fixes projects.maemo.org bug NB#59711
999 2007-06-14 Armin Burgmeier <armin@openismus.com>
1001 * src/widgets/modest-attachments-view.h:
1002 * src/widgets/modest-attachments-view.c: Added
1003 modest_attachments_view_has_attachments() and fixed coordinate
1004 transformation in get_att_view_at_coords(). This fixes attachment
1007 * src/widgets/modest-msg-view.c: Make use of
1008 modest_attachments_view_has_attachments() to decide whether to show
1009 attachments in the header.
1011 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1013 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1014 (on_change), (on_combo_security_changed),
1015 (modest_connection_specific_smtp_edit_window_init),
1016 (modest_connection_specific_smtp_edit_window_set_connection),
1017 (modest_connection_specific_smtp_edit_window_is_dirty):
1018 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1019 * src/maemo/modest-connection-specific-smtp-window.c:
1022 Show an comfirmation dialog for the smpt-edit-window if there are
1023 unsaved changes and the user hits cancel.
1024 (projects.maemo.org bug NB#60479)
1026 2007-06-14 Armin Burgmeier <armin@openismus.com>
1028 * src/maemo/easysetup/modest-easysetup-wizard.c:
1029 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1030 address" info in banner instead of node, and select all the text as
1031 per UI spec. This fixes projects.maemo.org bug NB#60550.
1033 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1035 reviewed by: <delete if not using a buddy>
1037 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1038 * src/modest-ui-actions.c: (folder_refreshed_cb):
1040 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1042 * src/widgets/modest-folder-view.c: (filter_row):
1043 Explictly filter out the per-account outbox accounts. I don't know why
1044 these only sometimes show up, but now they should never show up in the UI.
1045 This should fix projects.maemo.org bug NB#60160.
1047 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1049 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1050 when the toolbar does not exist yet.
1051 * src/modest-widget-memory.c: (save_settings_header_view):
1052 Added g_warnings() to help us to discover when we are trying to set
1053 an empty columns list in gconf.
1055 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1057 * src/modest-init.h:
1058 * src/modest-init.c:
1059 Added modest_init_get_default_header_view_column_ids().
1061 * src/modest-widget-memory.c: (restore_settings_header_view):
1062 Use the new function to get defaults, if the gconf key is empty,
1063 instead of not creating any columns. This seems to fix the
1064 empty right-hand pane problems.
1066 * src/widgets/modest-header-view.h: Improved documentation.
1068 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1070 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1071 Revert the use of the display name as the account name, because this
1072 is generally wrong and would break the code that follows.
1074 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1076 * src/maemo/easysetup/modest-easysetup-wizard.c:
1077 (check_for_supported_auth_methods), (on_before_next),
1080 More correct fix for projects.maemo.org bug NB# 58991
1081 Do not longer accept AUTH_PASSWORD as secure method and choose
1082 correct method when creating the account.
1084 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1086 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1087 Fixed projects.maemo.org bug NB# 58991
1089 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1091 * src/modest-init.c: (modest_init_init_core),
1092 (modest_init_local_folders): Fixed compilation errors.
1094 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1096 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1097 Remove unnecessary lib/include, though it is good in principle when needed.
1099 * src/modest-init.c: (modest_init_one_local_folder),
1100 (modest_init_local_folders):
1101 * src/modest-init.h: Initialize the .modest library for memory cards,
1102 instead of just doing nothing for them. This should allow us to create
1103 folders there, fixing projects.maemo.org bug NB#59297.
1105 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1107 * libmodest-dbus-client/libmodest-dbus-client.c:
1108 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1109 (libmodest_dbus_client_compose_mail),
1110 (libmodest_dbus_client_open_message),
1111 (libmodest_dbus_client_send_and_receive),
1112 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1114 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1115 (on_idle_open_message), (modest_dbus_req_handler),
1116 (search_result_to_message), (modest_dbus_req_filter):
1117 * src/modest-search.c: (add_hit), (modest_search_folder),
1118 (modest_search_all_accounts): Improved debug messages.
1120 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1122 * src/modest-tny-account-store.c:
1123 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1126 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1129 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1131 * src/modest-tny-account-store.c: (get_server_accounts):
1132 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1133 even when there are no accounts, so that the Outbox folder is always
1134 visible. This fixes projects.maemo.org bug NB#60158.
1136 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1138 * src/maemo/modest-main-window.c: (create_details_widget):
1139 Use the mcen_va_never logical ID.
1141 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1143 * src/dbus_api/modest-dbus-api.h:
1144 * src/dbus_api/modest-dbus-callbacks.c:
1145 (on_idle_open_default_inbox), (on_open_default_inbox),
1146 (modest_dbus_req_handler):
1147 Added a new OpenDefaultInbox method.
1149 * libmodest-dbus-client/libmodest-dbus-client.h:
1150 * libmodest-dbus-client/libmodest-dbus-client.c:
1151 Added libmodest_dbus_client_open_default_inbox() to call the new
1152 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1153 though it should maybe be used by a new osso-email-interface function.
1155 * tests/dbus_api/Makefile.am:
1156 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1159 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1161 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1162 NULL, so that the signals get all the keys. This should not actually
1163 change any behaviour because we currently update everything when anything
1166 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1168 * src/widgets/modest-folder-view.c: (text_cell_data),
1169 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1170 (find_inbox_iter): If tinymail tells us that the folder is
1171 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1172 This causes the inbox to be selected at startup, fixing part of
1173 projects.maemo.org bug NB#56305.
1175 * src/modest-ui-dimming-rules.c:
1176 (modest_ui_dimming_rules_on_tools_smtp_servers):
1177 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1178 the SMTP servers menu item.
1179 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1180 that the SMTP Servers menu item is dimmed when there are no accounts,
1181 as a future version of the UI spec will require. This fixes
1182 projects.maemo.org bug NB#56305.
1184 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1186 * src/maemo/modest-maemo-utils.c:
1187 (modest_maemo_utils_get_supported_secure_authentication_methods):
1188 Added label to dialog instead of unreadable title
1190 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1191 (modest_main_window_new):
1192 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1195 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1196 * src/modest-account-mgr.h:
1197 Added method to avoid code duplication
1199 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1200 (modest_ui_actions_on_send_receive):
1201 Use modest_account_mgr_has_accounts
1203 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1205 * src/maemo/easysetup/modest-presets.c:
1206 (modest_presets_get_info_server_security): Do not report secure auth
1208 * src/modest-protocol-info.c: Use the defines for the gconf key names
1209 for secure authentication. This was not working because we were writing
1210 Password and reading password, and the check was case sensitive.
1211 With this, gmail now works for receiving and sending when created via
1214 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1216 * src/maemo/easysetup/modest-presets.c:
1217 (modest_presets_get_info_server_security): Correct the key name for
1218 SecureSmtp, because it seems to be case-sensitive.
1219 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1220 Do not try to get the 0th notebook page if there are 0 pages, to
1221 avoid a g_warning().
1223 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1225 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1226 Prevent use of the new notification feature for now, because it currently
1227 shows one dialog for each new email, which is annoying.
1229 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1231 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1232 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1233 when no country was selected, so that we show the global ones.
1234 * src/maemo/easysetup/modest-presets.c:
1235 (modest_presets_get_providers): Return only the global providers, not
1236 all providers when mmc=0 was requested.
1238 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1240 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1241 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1242 provider ID in the combo.
1244 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1245 Do not show the page numbers, because it would be confusing when we add
1246 the 2 extra pages for the custom setup, when the user chooses the "Other"
1247 provider. This fixes projects.maemo.org bug NB#59028
1249 * src/modest-init.c: (modest_init_init_core),
1250 (modest_init_local_folders):
1251 * src/modest-init.h:
1252 * src/modest-tny-account.c:
1253 (modest_tny_account_new_for_local_folders): Do not create default folders
1254 for the memory card. This should fix projects.maemo.org bug NB#59328.
1256 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1258 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1259 Free the changed_conf_keys string items. They are already freed in the
1260 idle handler if that runs first.
1262 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1264 * src/modest-ui-actions.c:
1265 (modest_ui_actions_on_password_requested): Check that the server name
1266 is not NULL, because I just saw a password dialog with (null) as the
1269 * src/modest-tny-folder.[h|c]: Added
1270 modest_tny_folder_is_memory_card_folder().
1271 * src/modest-ui-dimming-rules.c:
1272 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1273 menu item for memory cards, as per the UI spec (section 7.4). This should
1274 fix projects.maemo.org bug NB#59297.
1276 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1278 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1279 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1280 is another problem with the code, see Murray's comment at line 772)
1282 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1284 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1285 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1286 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1287 (load_from_file), (easysetup_country_combo_box_init),
1288 (easysetup_country_combo_box_get_active_country_ids),
1289 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1290 instead of just one ID, to avoid duplicate country names in the UI.
1292 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1293 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1294 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1295 a single ID, avoiding duplicate providers.
1296 * src/maemo/easysetup/modest-easysetup-wizard.c:
1297 (on_combo_account_country): Adapt to use a list.
1299 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1301 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1302 keys changed in the last X seconds.
1304 * src/modest-account-mgr.h:
1305 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1306 (on_key_change), (modest_account_mgr_class_init),
1307 (modest_account_mgr_init), (modest_account_mgr_finalize):
1308 As the keys are changed, save them in a GSList* and signal that GSList*
1309 further every X seconds, to batch changes, to allow us to do just one
1310 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1311 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1313 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1314 changed signal signature.
1316 * src/modest-conf.c: (modest_conf_set_list),
1317 (modest_conf_on_change): Reenable notification.
1319 (modest_conf_maemo_fake_on_change): Comment out the hack that
1320 notified immediately instead of asynchronously.
1322 * src/widgets/modest-account-view.h:
1323 * src/widgets/modest-account-view.c:
1324 (update_account_view): Select the previously-selected account ID,
1325 if possible. This fixes projects.maemo.org bug NB#56933.
1327 (on_account_changed), (on_account_removed),
1328 (modest_account_view_select_account):
1330 Remove the block/unblock functions
1331 because they were not useful.
1333 * src/maemo/modest-account-view-window.c:
1334 (on_delete_button_clicked), (on_edit_button_clicked),
1335 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1337 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1339 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1340 Improve the error dialog to show Incorrect Account Settings, which seems
1341 clearer, and say that the internal error message (to be removed from the
1342 dialog later) is often misleading.
1343 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1345 * src/modest-tny-account.c:
1346 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1347 URL because this is so useful for debugging on the device.
1349 * src/widgets/modest-serversecurity-combo-box.c:
1350 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1352 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1354 * src/modest-mail-operation.c:
1355 (modest_mail_operation_send_new_mail):
1356 Added a comment about a nasty but apparently harmless message. Details
1357 added to the wiki g_warnings() page.
1359 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1362 (modest_tny_send_queue_class_init):
1363 Do not use the priv struct because it is empty, to avoid g_warnings
1364 about a non-existant priv struct.
1366 * src/modest-tny-account-store.c:
1367 (modest_tny_account_store_get_server_account),
1368 (modest_tny_account_store_get_transport_account_for_open_connection
1369 ): Do not try to get transport server accounts for local folders,
1370 because they don't have any. This avoids a g_warning().
1372 * src/maemo/modest-main-window.c:
1373 (modest_main_window_notify_send_receive_initied),
1374 (on_configuration_key_changed):
1375 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1376 * src/modest-defs.h:
1377 * src/modest-mail-operation.c:
1378 (modest_mail_operation_update_account):
1379 * src/modest-tny-account-store.h:
1380 * src/modest-tny-account.c:
1381 (modest_tny_account_get_special_folder),
1382 (modest_tny_account_new_for_local_folders),
1383 (modest_tny_account_new_for_per_account_local_outbox_folder):
1384 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1385 * src/modest-tny-local-folders-account.c:
1386 (add_account_folders_to_merged_folder):
1387 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1388 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1389 (modest_ui_actions_on_send):
1390 * src/widgets/modest-folder-view.c: (update_model):
1391 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1392 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1393 modest_tny_account_store_get_tny_account_by_account() to
1394 modest_tny_account_store_get_server_account() to make the code clearer.
1396 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1398 * src/dbus_api/modest-dbus-api.h:
1399 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1400 * src/maemo/modest-msg-edit-window.c:
1401 (modest_msg_edit_window_attach_file_noninteractive):
1402 added g_warning in case the file to be attached does not exist
1403 * tests/dbus_api/test_compose_mail.c: (main):
1404 removed obsolete comment, added generic files as test case
1406 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1408 * src/modest-tny-account-store.c: (get_server_accounts):
1409 Create the local folders account only once, not once for each outbox, and
1410 not only when there are some outboxes.
1412 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1414 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1415 code that is causing a crash at startup. Sergio says that he is fixing this.
1417 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1419 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1420 * src/maemo/modest-account-settings-dialog.c:
1421 (create_page_outgoing),
1422 (modest_account_settings_dialog_set_account_name),
1423 (save_configuration):
1424 - Fixed handling of the "Use secure authentication" toggle to comply with
1425 the ui specification. See also projects.maemo.org bug NB#58400
1427 - Restore the Secure connection setting combo correctly when loading
1430 * src/maemo/modest-maemo-utils.c:
1431 (on_camel_account_get_supported_secure_authentication),
1432 (modest_maemo_utils_get_supported_secure_authentication_methods):
1433 Fixed a crasher if operation is canceled
1435 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1436 (modest_protocol_info_auth_is_secure):
1437 * src/modest-protocol-info.h:
1439 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1440 the sense of the "Use secure authentication" toggle.
1442 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1444 * src/modest-tny-account-store.h:
1445 * src/modest-tny-account-store.c:
1446 Added modest_tny_account_store_get_local_folders_account().
1448 * src/modest-tny-folder.h:
1449 * src/modest-tny-folder.c:
1450 (modest_tny_folder_get_account):
1451 Added this replacement for tny_folder_get_account() which returns
1452 the local-folders account for TnyMergeFolders, to avoid the
1453 warning about the unimplemented get_account_func() vfunc().
1455 (modest_tny_folder_get_rules),
1456 * src/modest-ui-actions.c:
1457 (modest_ui_actions_on_folder_selection_changed):
1458 * src/modest-mail-operation.c:
1459 (modest_mail_operation_remove_folder),
1460 (modest_mail_operation_xfer_folder),
1461 (modest_mail_operation_rename_folder),
1462 (modest_mail_operation_get_msg),
1463 (modest_mail_operation_get_msgs_full),
1464 (modest_mail_operation_remove_msg),
1465 (modest_mail_operation_xfer_msgs),
1466 (modest_mail_operation_refresh_folder):
1467 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1469 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1471 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1472 (modest_server_account_set_security):
1473 * src/modest-defs.h: Add comments explaining that our
1474 UI spec means TLS when it says Normal, so these do not look like errors.
1476 * src/modest-tny-account.c:
1477 (modest_tny_account_new_from_server_account): Use the new tinymail
1478 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1479 for TLS. This should fix projects.maemo.org bug NB#58460.
1481 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1483 * src/maemo/easysetup/modest-easysetup-wizard.c:
1484 (create_account): Correct the position of the gconf sanity check warning.
1485 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1486 of using the g_idle_add() hack, because this does not seem to be necessary
1487 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1488 caused by something other than maemo's gconf.
1489 This fixes projects.maemo.org bug #59022.
1491 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1493 * src/modest-account-mgr-helpers.c:
1494 (modest_account_mgr_get_default_account): Do not check that the account
1495 exists if there is no default account (NULL), to fix a runtime warning.
1497 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1499 * src/widgets/modest-folder-view.c: (update_model):
1500 Do not unref the treemodel before we have finished with it.
1501 This prevents a valgrind warning and an occasional crash at startup.
1503 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1505 * libmodest-dbus-client/libmodest-dbus-client.h:
1506 added libmodest_dbus_client_compose_mail()
1507 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1509 added functions needed for SendAsMail() functionality
1510 * src/maemo/modest-msg-edit-window.c:
1511 (modest_msg_edit_window_attach_file_noninteractive):
1512 non interactively attaching files to message edit window
1513 * src/widgets/modest-msg-edit-window.h:
1514 * tests/dbus_api/Makefile.am:
1515 added test_compose_mail.c
1516 * tests/dbus_api/test_compose_mail.c: (main):
1518 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1520 * src/modest-account-view.c:
1521 Fixed bug projects.maemo.org bug NB#59307
1523 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1525 * src/maemo/easysetup/modest-easysetup-wizard.c:
1526 (get_serverport_incoming), (on_before_next), (create_account):
1527 * src/maemo/modest-account-settings-dialog.c:
1528 (modest_account_settings_dialog_set_account_name):
1529 * src/maemo/modest-maemo-utils.c:
1530 (on_camel_account_get_supported_secure_authentication_status),
1531 (on_camel_account_get_supported_secure_authentication),
1532 (on_secure_auth_cancel),
1533 (modest_maemo_utils_get_supported_secure_authentication_methods):
1535 Implemented security authentication for settings and easysetup.
1537 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1539 * src/maemo/modest-main-window.c: (create_details_widget):
1540 Show the total size for memory card accounts too, instead of showing
1541 the name again. Fixes bug projects.maemo.org bug NB#59307.
1543 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1546 * src/modest-tny-simple-folder-store.c:
1547 * src/modest-tny-simple-folder-store.h: Removed.
1549 * src/modest-tny-local-folders-account.h
1550 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1551 for the local-folders maildir, with an extra TnyMergedFolder containing
1552 the folders of the per-account outbox store accounts.
1553 * src/modest-tny-account-store.c: (get_server_accounts):
1554 Add the outboxes to the special local folders account after creating it.
1556 * src/modest-tny-account.c:
1557 (modest_tny_account_new_for_local_folders): Create the derived
1558 account when creating the main local-folders account.
1560 * src/maemo/modest-main-window.c: (create_details_widget),
1561 (modest_main_window_set_contents_style):
1562 Adapted to the use of the derived account instead of the folder store.
1564 * src/modest-ui-actions.c:
1565 (modest_ui_actions_on_folder_selection_changed):
1566 * src/modest-ui-dimming-rules.c:
1567 (modest_ui_dimming_rules_on_new_folder):
1568 * src/widgets/modest-folder-view.c: (text_cell_data),
1569 (icon_cell_data), (filter_row), (update_model),
1570 (get_cmp_rows_type_pos):
1573 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1574 Do not get the priv struct, because no priv struct has been set,
1575 to avoid a runtime warning.
1577 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1578 #ifelse with #else, to fix a warning, to fix the build.
1581 2007-06-05 Christian Kellner <ckellner@openismus.com>
1583 * libmodest-dbus-client/libmodest-dbus-client.c:
1584 Fix small typo in doc (why do you always see them
1585 AFTER committing stuff?)
1588 2007-06-05 Christian Kellner <ckellner@openismus.com>
1590 * libmodest-dbus-client/libmodest-dbus-client.c:
1591 (libmodest_dbus_client_search):
1592 Initialize hit list with NULL. Also set folder list
1593 to "" if NULL was supplied.
1596 2007-06-03 Christian Kellner <ckellner@openismus.com>
1598 * libmodest-dbus-client/libmodest-dbus-client.c:
1599 (modest_search_hit_list_free):
1600 Make it save to call it with NULL.
1602 * src/dbus_api/modest-dbus-callbacks.c:
1603 * src/modest-search.c:
1604 Return full ModestSearchHits as the search result list not TnyHeader
1605 since can't be around withouth the correspoding TnyFolder.
1607 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1609 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1610 Added currently commented code to check for secure auth
1612 * src/maemo/modest-account-settings-dialog.c: (on_response),
1613 (save_configuration), (show_ok):
1614 Fixed projects.maemo.org bugs NB #59248 and #59251
1616 * src/maemo/modest-maemo-utils.c:
1617 (on_camel_account_get_supported_secure_authentication_status),
1618 (on_camel_account_get_supported_secure_authentication),
1619 (modest_maemo_utils_get_supported_secure_authentication_methods):
1620 * src/maemo/modest-maemo-utils.h:
1621 Moved get_supported_secure_authentication() method here to be able
1622 to use it from easysetup wizard.
1624 * src/modest-pair.c: (on_pair_compare_as_string):
1625 Should compare string with first part of pair and not
1626 strcmp pairs which will crash.
1628 * src/modest-protocol-info.c:
1629 (modest_protocol_info_protocol_is_store):
1630 * src/modest-protocol-info.h:
1631 Added modest_protocol_info_get_auth_protocol_name()
1633 2007-06-03 Armin Burgmeier <armin@openismus.com>
1635 * src/modest-mail-operation.c:
1636 (modest_mail_operation_get_msgs_full): Set priv->account also when
1637 only retrieving a single message. This avoids a crash when canceling
1640 (modest_mail_operation_notify_end): Do not explicitely remove the
1641 operation from the queue but only emit the progress_changed signal.
1642 The queue itself listens to that signal to remove the operation when
1643 it is finished. This reduces coupling and removes a potential deadlock
1644 when modest_mail_operation_notify_end() is called from the queue
1645 itself. If that is a problem performance-wise, I would suggest to
1646 implement a status-changed signal or something.
1648 * src/modest-mail-operation-queue.c: Make sure to never call a
1649 function from another file while the queue is locked. This (hopefully)
1650 fixes another deadlock when exiting the application while retrieving
1653 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1655 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1656 Fixed build if libogs is not available
1658 2007-06-03 Christian Kellner <ckellner@openismus.com>
1660 * libmodest-dbus-client/libmodest-dbus-client.h:
1661 * libmodest-dbus-client/libmodest-dbus-client.c:
1662 (libmodest_dbus_client_delete_message):
1663 Implement deletion of messages (Client side).
1665 (modest_search_hit_free),
1666 (modest_search_hit_list_free):
1667 Utility functions to free the result hits.
1669 * src/dbus_api/modest-dbus-api.h:
1670 * src/dbus_api/modest-dbus-callbacks.c:
1671 (on_delete_message),
1672 (modest_dbus_req_handler):
1673 Implement deletion of messages (Server side).
1675 * tests/dbus_api/test_search.c: (main):
1678 * tests/dbus_api/Makefile.am:
1679 * tests/dbus_api/test_delete_message:
1680 Add little test for the message deletion logic
1682 2007-06-03 Armin Burgmeier <armin@openismus.com>
1684 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1685 when the operation queue was not empty. projects.maemo.org bug
1688 2007-06-03 Armin Burgmeier <armin@openismus.com>
1690 * src/widgets/modest-account-view.c
1691 (on_account_default_toggled): Toggle default account column
1692 explicitely instead of waiting for gconf notification (which is
1693 currently ignored). This should fix projects.maemo.org bug NB#56910
1694 for now. It should probably be removed when gconf notifications are
1697 2007-06-03 Christian Kellner <ckellner@openismus.com>
1699 * libmodest-dbus-client/libmodest-dbus-client.c:
1700 Removed debugging spew.
1702 * src/dbus_api/modest-dbus-callbacks.c:
1703 Added debugging info.
1705 * src/modest-search.c:
1706 (modest_search_all_accounts):
1707 Use tny_account_store_get_accounts () on the account store
1708 to get all accounts which is the way to get all accounts.
1710 * tests/dbus_api/test_search.c: (main):
1711 Make it possible to supply the search term on the command line.
1713 2007-06-03 Christian Kellner <ckellner@openismus.com>
1715 * libmodest-dbus-client/libmodest-dbus-client.c:
1716 * libmodest-dbus-client/libmodest-dbus-client.h:
1717 Implement searching for mesages over raw dbus. (Client side)
1719 * src/dbus_api/Makefile.am:
1720 * src/dbus_api/modest-dbus-api.h:
1721 * src/dbus_api/modest-dbus-callbacks.c:
1722 * src/dbus_api/modest-dbus-callbacks.h:
1723 Search framework (Server side). Also implement on_idle_open_message().
1725 * src/maemo/modest-platform.c: (modest_platform_init):
1726 Prepare for raw dbus/osso rpc interaction.
1728 * src/modest-search.h:
1729 Changed minsize from unspecific guint to guint32.
1731 * src/modest-search.c:
1733 Added strange hack which magically made tnymail work.
1735 (modest_search_folder),
1736 (modest_search_account),
1737 (modest_search_all_accounts):
1738 Implement helper functions to search all accounts, specific account
1741 * tests/dbus_api/Makefile.am:
1742 * tests/dbus_api/test_open_message.c:
1743 Read url to open from commandline.
1745 * tests/dbus_api/test_search.c:
1746 Implement small test for dbus search stuff
1748 2007-06-02 Armin Burgmeier <armin@openismus.com>
1750 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1751 include account type and account title. This fixes projects.maemo.org
1754 * src/maemo/modest-account-view-window.c: Set a title for the window.
1756 2007-06-02 Armin Burgmeier <armin@openismus.com>
1758 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1759 incoming and outgoing server name based on email address and server
1760 types as long as the names have not been edited manually. This fixes
1761 projects.maemo.org bug NB#58671.
1763 2007-06-02 Armin Burgmeier <armin@openismus.com>
1765 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1766 server type cannot be changed in future to the incoming details page
1767 when creating an account. This fixes projects.maemo.org bug NB#59029.
1769 2007-06-02 Armin Burgmeier <armin@openismus.com>
1771 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1772 and assigned max width chars so that they wrap instead of being
1773 truncated. Fixes projects.maemo.org bug NB#56126.
1775 2007-06-02 Armin Burgmeier <armin@openismus.com>
1777 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1778 introductory note to the connection specific smtp servers dialog, as
1779 section 8.12 of the email UI specification requires. This fixes
1780 projects.maemo.org bug NB#59212.
1782 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1784 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1785 Check for running mail operations, and offer to cancel them, as per the UI
1786 spec. This fixes projects.maemo.org bug NB#59041 .
1787 However, I suspect that tinymail may still use the network connection
1788 in ways that we cannot detect or cancel. But it should at least adapt to
1789 changes fairly well.
1791 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1793 * src/modest-tny-account-store.c: (recreate_all_accounts),
1794 (get_cached_accounts), (get_server_accounts): Do more sensible
1795 ref-counting of the temporarily-cached outbox accounts list. This seems
1796 to fix a crash when entering the password when the password was wrong.
1798 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1800 * src/gnome/modest-main-window.c: (connect_signals):
1801 * src/modest-tny-account-store.c: (get_password),
1802 (modest_tny_account_store_alert): Added comments and clues and
1803 commented-out code about how we currently fail to deal with connection
1804 errors and wrong passwords, and how we should.
1806 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1808 * src/widgets/modest-retrieve-combo-box.c:
1809 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1810 This fixes projects.maemo.org bug NB#58472 .
1812 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1814 * src/maemo/easysetup/modest-easysetup-wizard.c:
1815 (create_page_complete_easysetup):
1816 (create_page_complete_custom): Correct the last commit,
1817 putting the correct sentences in the correct pages.
1819 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1821 * src/maemo/easysetup/modest-easysetup-wizard.c:
1822 (create_page_complete_custom): Show the second sentence of text
1823 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1826 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1828 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1829 Set the leave-on-server conf key by default. This fixes
1830 projects.maemo.org bug NB#59258 .
1832 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1834 * src/maemo/modest-account-view-window.c:
1835 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1836 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1839 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1841 * src/maemo/easysetup/modest-easysetup-wizard.c:
1842 (create_caption_new_with_asterisk):
1843 * src/maemo/modest-account-settings-dialog.c:
1844 (create_caption_new_with_asterisk):
1845 Uncomment the code to add the asterisk, because they are no longer in the
1846 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1847 (update_incoming_server_title): Add an asterisk here too.
1849 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1851 * src/maemo/modest-maemo-global-settings-dialog.c:
1852 (current_connection): Check that we are even connected before trying to
1853 get the current connection name, to prevent a warning.
1855 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1856 Change the comments because tny_maemo_conic_device_connect() is now meant to
1858 * src/modest-mail-operation.c:
1859 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1860 make sure we have a connection and fail if we can't connect.
1862 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1864 * src/maemo/modest-main-window.c:
1865 (on_account_store_connecting_finished): Do not try to get the
1866 connection ID if we are not really connected. I am surprised that
1867 this signal handler is called when we are not connected.
1869 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1871 * src/modest-error.h:
1872 * src/modest-ui-actions.c:
1873 (modest_ui_actions_get_msgs_full_error_handler):
1874 Renamed an enum, added comments, added an enum
1875 for retrieve-limit errors.
1877 * src/modest-mail-operation.c: (foreach_add_item),
1878 (internal_folder_observer_update), (update_account_thread),
1879 (modest_mail_operation_get_msgs_full):
1880 (modest_mail_operation_update_account),
1881 Added comments about how this works, and some code that should
1882 (but does not) check the retrieve-limit. See the TODO comment.
1884 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1886 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1887 Initialize help_id to fix the build. Warnings are good.
1889 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1891 * src/widgets/modest-hbox-cell-renderer.c:
1892 (modest_hbox_cell_renderer_append):
1893 * src/widgets/modest-vbox-cell-renderer.c:
1894 (modest_vbox_cell_renderer_append):
1895 Fix the last commit by doing an extra ref.
1897 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1899 * src/widgets/modest-hbox-cell-renderer.c:
1900 (modest_hbox_cell_renderer_append):
1901 * src/widgets/modest-vbox-cell-renderer.c:
1902 (modest_vbox_cell_renderer_append):
1903 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1904 to fix the build with Maemo Bora.
1905 However, there seems to be a remaining crash, probably due to reference
1908 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1910 * src/modest-tny-account.c:
1911 (modest_tny_account_new_for_local_folders):
1912 Use hildon_file_system_info_async_new() to get a better name for
1913 the memory card account, setting it as the account name.
1914 The timing seems to work, but this is probably
1915 not the best place to do this. See the TODO comment.
1916 * src/maemo/modest-main-window.c: (create_details_widget):
1917 * src/widgets/modest-folder-view.c: (text_cell_data):
1918 Use the tny account name instead of hardcoding a name.
1920 2007-05-30 Christian Kellner <ckellner@openismus.com>
1922 * src/modest-search.c: (modest_search):
1923 Correctly set part_search_func even if we have already parsed
1924 the query and thus a valid OgsTextSearcher object.
1926 2007-05-30 Christian Kellner <ckellner@openismus.com>
1929 Search and check for libogs.
1932 Incooparte the ogs build env.
1934 * src/modest-mime-part-search-stream.c:
1935 * src/modest-mime-part-search-stream.h:
1936 Removed since we do the real searching now in modest-search.c.
1938 * src/modest-search.c:
1939 * src/modest-search.h:
1940 Implement support for ogs. We use that if available and requested
1941 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1942 should now handle the corner case when the search term is spread
1943 across multiple reads.
1944 Also the logic in modest_search () was corrected to search all
1945 requested fields until one is found.
1947 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1949 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1951 * src/modest-init.h:
1952 * src/modest-init.c: Made modest_init_local_folders() take a
1953 path and be public so we can iniitialize maildir folders on
1956 * src/modest-local-folder-info.h:
1957 * src/modest-local-folder-info.c:
1958 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1960 * src/modest-tny-account.c:
1961 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1962 still means the standard local-folders path on the local volume.
1964 * src/modest-tny-account-store.c:
1965 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1966 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1967 all accounts when that happens.
1968 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1969 this too, so it shows up in the treeview.
1971 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1973 * src/maemo/modest-maemo-global-settings-dialog.c:
1974 (current_connection):
1975 * src/widgets/modest-global-settings-dialog.c:
1976 (current_connection_default):
1977 Use the enum values instead of 0, 1 and -1,
1978 to make the code clearer.
1980 * src/modest-account-mgr-helpers.c:
1981 (modest_account_mgr_get_connection_specific_smtp): Make this code
1984 * src/modest-runtime.h:
1985 * src/modest-runtime.c:
1986 Added modest_runtime_remove_all_send_queues().
1987 * src/maemo/modest-main-window.c:
1988 (on_account_store_connecting_finished): Recreate the send queues,
1989 using the appropriate transport accounts for this new connection.
1990 Some futher adapting might be needed if the old send queues are not
1991 automatically stopped at this point.
1993 * src/modest-tny-account-store.c: (get_server_accounts):
1994 Create the connection-specific transport accounts, so that they can
1995 be found later by their ID.
1997 * src/modest-tny-account.h:
1998 * src/modest-tny-account.c:
1999 Added modest_tny_account_new_from_server_account_name().
2000 modest_tny_account_new_from_server_account(): Do not create the
2001 send queues here, because they will be
2002 recreated anyway when the connection changes for the first time.
2004 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2006 * src/modest-local-folder-info.h:
2007 * src/modest-local-folder-info.c:
2008 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2009 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2010 tbox_folder): Take a modest account name instead of a server TnyAccount,
2011 so we can have per-modest-account rather than per-transport-account
2013 We must make sure that we change or recreate the exisitng send queues
2014 when the connection changes for connection-specific transport accounts.
2016 * src/modest-tny-account-store.c:
2017 (create_per_account_local_outbox_folders): Create outboxed per modest
2018 account, not per transport account.
2020 * src/modest-tny-account.h:
2021 * src/modest-tny-account.c:
2022 (modest_tny_account_get_special_folder): For outboxes, get the
2023 parent modest account name. The account is ignored for other folders.
2024 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2025 modest account name rather than a server TnyAccount.
2027 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2029 * src/modest-tny-account.c:
2030 (modest_tny_account_new_from_server_account):
2031 Call modest_runtime_get_send_queue() immediately after creating transport
2032 accounts, so that they start trying to send email from the outbox as soon
2033 as possible at startup. This is probably what we want.
2035 * src/modest-mail-operation.c: (update_account_thread):
2036 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2037 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2038 * src/modest-tny-send-queue.h:
2039 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2040 (modest_ui_actions_on_send):
2041 Added comments about how sending works, though it needs some more work.
2043 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2045 * src/modest-tny-account.c:
2046 (modest_tny_account_get_special_folder): Add TODO because this fails when
2047 the network is busy.
2048 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2049 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2050 Do not try to show this window when there is no active account. The UI
2051 specs does not tell us what to do in this case.
2053 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2057 * src/maemo/Makefile.am:
2058 * src/widgets/Makefile.am: Some dist fixes.
2060 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2062 * src/maemo/modest-connection-specific-smtp-window.c:
2063 (on_button_edit): Make the code clearer, to prevent a double free.
2065 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2067 * src/maemo/modest-account-settings-dialog.c:
2068 (modest_account_settings_dialog_set_account_name),
2069 Check the connection-specific smtp servers checkbox if there are any.
2071 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2072 (modest_connection_specific_smtp_edit_window_init):
2073 Start with a suitable port number.
2075 * src/modest-account-mgr-helpers.h:
2076 * src/modest-account-mgr-helpers.c: Added
2077 modest_account_mgr_get_has_connection_specific_smtp().
2079 (modest_account_mgr_set_connection_specific_smtp),
2080 (modest_account_mgr_remove_connection_specific_smtp),
2081 (modest_account_mgr_get_has_connection_specific_smtp),
2082 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2083 connection-specific smtp server accounts in the account, rather than
2084 the server account conf dir.
2086 This fixes bug projects.maemo.org bug NB#58263 .
2088 * src/modest-tny-account-store.c:
2089 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2090 if there are no server accounts yet, to prevent an infinite loop when there
2091 are no accounts. Document that one must be called before the other.
2093 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2095 * src/modest-account-mgr-helpers.c:
2096 (modest_account_mgr_get_default_account): Make sure that at least
2097 one account is always the default, if there are any enabled accounts.
2098 This is just a sanity check that shouldn't be necessary.
2100 * src/modest-account-mgr-priv.c:
2101 (_modest_account_mgr_account_from_key): Unescape the conf key to
2102 get the real account name. For instance, this is an issue if a space
2103 was in the account name, which can happen because the account name
2104 is generated from the display name.
2105 (_modest_account_mgr_get_account_keyname): Always escape the
2107 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2108 Unescape the conf keys to get the real account names.
2110 For instance, previously the is-default radio button in the accounts
2111 list was not checked for any accounts at first. This fixes that,
2112 and might fix several similar bugs.
2114 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2116 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2117 Removed some debug printfs.
2119 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2121 Modest on-disk outbox directories are now here, for instance:
2122 $HOME/.modest/outboxes/<account-id-1>/outbox
2123 $HOME/.modest/outboxes/<account-id-2>/outbox
2125 $HOME/.modest/local-folders/outbox
2126 so we can have a separate outbox for each account.
2127 But they are shown as one outbox in the GtkTreeView, by using a
2128 TnyMergeFolder in a ModestTnySimpleFolderStore.
2131 * src/modest-tny-simple-folder-store.c:
2132 * src/modest-tny-simple-folder-store.h:
2133 Added ModestTnySimpleFolderStore, used to contain folders from
2134 other folder stores, such as other accounts.
2136 * src/modest-tny-outbox-account.h:
2137 * src/modest-tny-outbox-account.c:
2138 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2139 used for the per-account local outbox folders.
2141 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2142 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2143 only use this (internally) now for the non-outbox local folders.
2145 * src/modest-init.h:
2146 * src/modest-init.c: Added modest_init_one_local_folder(), for
2147 setting up the directory structure for each local folder.
2149 * src/modest-local-folder-info.c:
2150 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2151 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2153 * src/modest-local-folder-info.h:
2154 * src/modest-tny-account-store.c: (on_account_removed),
2155 (on_account_changed), (create_per_account_local_outbox_folders),
2156 (get_server_accounts), (modest_tny_account_store_get_accounts),
2157 (modest_tny_account_store_get_tny_account_by_account),
2158 (modest_tny_folder_store_is_virtual_local_folders):
2160 * src/modest-tny-account.h:
2161 * src/modest-tny-account.c:
2162 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2163 to create an on-disk per-account local outbox folder for each
2165 (create_per_account_local_outbox_folders): Create a local outbox folder
2166 for each transport account.
2167 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2168 for all local folders.
2170 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2171 instead of using g_object_get/set() directly. It is clearer.
2173 (modest_tny_folder_store_get_message_count),
2174 (modest_tny_folder_store_get_local_size
2175 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2176 because we now use these with non-acount folder stores.
2178 (modest_tny_account_get_special_folder),
2179 (modest_tny_account_new_from_server_account),
2180 (modest_tny_account_new_from_account):
2181 (recurse_folders): Adjust to the new outbox system.
2183 * src/modest-tny-folder.h:
2184 * src/modest-tny-folder.c:
2185 (modest_tny_folder_is_local_folder),
2186 (modest_tny_folder_get_local_folder_type),
2187 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2189 * src/widgets/modest-main-window.h:
2190 * src/maemo/modest-main-window.c: (create_details_widget),
2191 (modest_main_window_set_contents_style): Show details for any folder store,
2194 (modest_tny_folder_get_rules):
2195 Remove the const. C does not support constness enough for this.
2197 * src/modest-ui-actions.c:
2198 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2199 make all outboxes appear as one, in the usual local-folders tree node.
2201 (set_active_account_from_tny_account),
2202 (modest_ui_actions_on_folder_selection_changed):
2203 * src/widgets/modest-folder-view.c: (text_cell_data),
2204 (icon_cell_data), (filter_row),
2205 (add_account_folders_to_merged_folder),
2206 (add_account_folders_to_simple_folder_store), (),
2207 (get_cmp_rows_type_pos), (cmp_rows),
2208 (modest_folder_view_set_account_id_of_visible_server_account):
2209 Adjust to the new outbox system, using generic folder stores and folders
2210 in the GtkTreeModel.
2212 2007-05-23 Christian Kellner <ckellner@openismus.com>
2214 * src/modest-mail-operation.c:
2215 (modest_mail_operation_update_account):
2216 Use info->max_size instead of unintialized local var [small
2217 build fix]. (Added TODO to review that change since I don't
2220 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2222 * libmodest-dbus-client/libmodest-dbus-client.c:
2223 (libmodest_dbus_client_compose_mail): function added
2224 * src/dbus_api/modest-dbus-api.h:
2225 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2226 (on_compose_mail): Implementation of the SendAsMail functionality
2228 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2230 * src/modest-account-mgr.c:
2231 (modest_account_mgr_add_server_account): Set the secure-connection
2232 conf key for transport accounts as well as store accounts. I don't know
2233 why the if was there. For instance, this makes sure that we use SSL
2234 for the gmail preset from the easysetup wizard.
2236 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2238 * src/gnome/modest-main-window.c:
2239 (on_account_store_connecting_finished), (connect_signals):
2240 * src/maemo/modest-main-window.c:
2241 (on_account_store_connecting_finished), (connect_signals),
2242 (modest_main_window_new):
2243 Handle TnyAccountStore::connecting-finished instead of
2244 TnyDevice::connection-changed, because we cannot actually perform
2245 operations on accounts until TnyAccountStore has itself responded to
2246 the TnyDevice::connection-changed signal. This prevents a GError from
2248 Do not try to update at startup, because we (at least on scratchbox)
2249 already do an update at startup when the device goes online.
2250 This prevents a GError from tinymail.
2251 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2252 Added TODO about stopping simultaneous operations.
2254 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2256 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2257 * src/modest-mail-operation-queue.c:
2258 (modest_mail_operation_queue_remove):
2259 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2260 about where they happened.
2262 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2264 * src/modest-ui-actions.c:
2265 (modest_ui_actions_on_password_requested): Make sure that the remember
2266 output parameter is always TRUE.
2268 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2270 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2271 Show a OK/Cancel dialog if the error is a question, though we still do not
2272 know anything more about what we are asking the user.
2273 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2274 Fix an uninitialized variable (helper). This is a logic error, however.
2276 2007-05-21 Christian Kellner <ckellner@openismus.com>
2278 * src/modest-search.h:
2279 Correct bit shifting in the ModestSearchFlags enum.
2281 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2283 * src/modest-tny-account.c:
2284 (modest_tny_account_new_from_server_account): Do not use the lsub and
2285 check-all hard-coded IMAP options when using POP.
2287 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2289 * src/modest-tny-account.c:
2290 (modest_tny_account_new_from_server_account):
2291 Use NULL for the secure-auth method for POP when Password auth has been
2292 specified by the user, as we already do for IMAP. "auth=Login" causes
2293 an error from camel or the server.
2295 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2297 * src/maemo/modest-account-settings-dialog.c:
2298 (create_page_account_details),
2299 (modest_account_settings_dialog_set_account_name):
2300 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2301 for the leave-on-server checkbox, rathr than just the checkbox, when
2302 the protocol is not POP.
2304 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2306 * src/widgets/modest-account-view.c:
2307 * src/widgets/modest-account-view.h:
2308 Added modest_account_view_select_account() which will be useful later
2309 to asynchronously re-select the edited account.
2311 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2313 * src/maemo/modest-account-settings-dialog.c:
2314 (modest_account_settings_dialog_set_account_name):
2315 Automatically choose the port numbers based on the secure authentication
2316 methods, if they have not been chosen before.
2317 This fixes projects.maemo.org bug NB#56273 .
2319 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2321 * src/maemo/modest-main-window-ui.h:
2322 * src/modest-ui-actions.c:
2323 * src/modest-ui-actions.h:
2324 Connect the Tools/SMTP Servers menu item to
2325 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2326 SMTP servers dialog, as in the UI specification and saves changes when it
2327 is closed. This fixed projects.maemo.org bug NB#56305 .
2329 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2331 * src/maemo/modest-connection-specific-smtp-window.c:
2332 (modest_connection_specific_smtp_window_init):
2333 Use gtk_window_set_default_size() to make this window big enough, so
2334 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2336 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2338 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2339 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2340 (modest_connection_specific_smtp_edit_window_init),
2341 Do not try to connect to a combobox signal before the combobox exists.
2342 This fixes the cras in projects.maemo.org bug NB#56288 .
2343 (modest_connection_specific_smtp_edit_window_get_settings):
2344 Remove the server_account_name parameter which was being checked for NULL
2345 though it was not used.
2347 * src/maemo/modest-connection-specific-smtp-window.c:
2348 (modest_connection_specific_smtp_window_fill_with_connections),
2349 (on_button_edit), (modest_connection_specific_smtp_window_init):
2350 Correct the number of treemodel columns to prevent a warning.
2351 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2352 libconic does not work.
2354 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2356 * src/modest-tny-account.c:
2357 (modest_tny_account_new_from_server_account):
2358 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2359 SMTP when "None" was chosen by the user. However, with my SMTP server that
2360 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2363 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2365 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2366 to explain the memory management issue with the ID in the ModestPair.
2368 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2369 (add_sending_page), (modest_account_assistant_finalize):
2370 * src/gnome/modest-gnome-global-settings-dialog.c:
2371 (create_updating_page), (create_composing_page):
2372 * src/gnome/modest-msg-edit-window.c: (get_transports),
2373 (init_window), (modest_msg_edit_window_finalize),
2374 (modest_msg_edit_window_get_msg_data):
2375 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2376 * src/gnome/modest-transport-widget.c:
2377 (modest_transport_widget_finalize), (smtp_configuration):
2378 * src/maemo/modest-maemo-global-settings-dialog.c:
2379 (create_updating_page), (create_composing_page):
2380 * src/maemo/modest-msg-edit-window.c: (get_transports),
2381 (init_window), (modest_msg_edit_window_finalize),
2382 (modest_msg_edit_window_get_msg_data),
2383 (modest_msg_edit_window_free_msg_data):
2384 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2385 (modest_store_widget_finalize):
2386 * src/maemo/modest-transport-widget.c:
2387 (modest_transport_widget_finalize), (smtp_configuration):
2388 * src/modest-main.c: (send_mail):
2389 * src/widgets/modest-combo-box.h:
2390 * src/widgets/modest-global-settings-dialog-priv.h:
2391 * src/widgets/modest-global-settings-dialog.c:
2392 (modest_global_settings_dialog_finalize):
2393 * src/widgets/modest-msg-edit-window.h:
2394 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2395 as long as the combo box, to prevent use of freed memory for the ID.
2397 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2399 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2400 get_accounts(), to make this clearer. Do not check for the enabled gconf
2401 key, because we do not use this for server accounts (at least, not yet).
2402 This allows us to send email again.
2404 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2406 * src/maemo/modest-platform.c:
2407 (on_modest_conf_update_interval_changed), (modest_platform_init):
2408 Only respond to this particular key change. All these strcmp()s cannot be
2411 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2413 * src/maemo/modest-maemo-global-settings-dialog.c:
2414 (current_connection): Prevent a crash in scratchbox when
2415 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2416 * src/maemo/modest-platform.c:
2417 (on_modest_conf_update_interval_changed), (modest_platform_init):
2418 Get the update interval from gconf and reset it when the gconf key changes.
2420 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2422 * src/modest-protocol-info.c:
2423 * src/modest-protocol-info.h: Adde enum-specific get functions,
2424 instead of using a ModestProtocolType enum parameter.
2426 * src/gnome/modest-account-assistant.c:
2427 * src/gnome/modest-store-widget.c:
2428 * src/gnome/modest-store-widget.h:
2429 * src/gnome/modest-transport-widget.c:
2430 * src/gnome/modest-transport-widget.h:
2431 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2432 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2433 * src/maemo/easysetup/modest-easysetup-wizard.c:
2434 * src/maemo/modest-account-settings-dialog.c:
2435 * src/maemo/modest-account-settings-dialog.h:
2436 * src/maemo/modest-store-widget.c:
2437 * src/maemo/modest-store-widget.h:
2438 * src/maemo/modest-transport-widget.c:
2439 * src/maemo/modest-transport-widget.h:
2440 * src/modest-account-mgr-helpers.c:
2441 * src/modest-account-mgr-helpers.h:
2442 * src/modest-account-mgr.c:
2443 * src/modest-account-mgr.h:
2444 * src/modest-tny-account.c:
2445 * src/modest-tny-folder.c:
2446 * src/widgets/modest-account-view.c:
2447 * src/widgets/modest-retrieve-combo-box.c:
2448 * src/widgets/modest-retrieve-combo-box.h:
2449 * src/widgets/modest-secureauth-combo-box.c:
2450 * src/widgets/modest-serversecurity-combo-box.c:
2451 * src/widgets/modest-serversecurity-combo-box.h:
2452 * tests/check_account-mgr.c:
2453 Use the specific functions, and use the re-renamed enum values for GNOME too.
2455 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2457 * src/modest-pair.h:
2458 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2459 so we can get the second based on the first.
2461 * src/maemo/modest-account-settings-dialog.h:
2462 * src/maemo/modest-account-settings-dialog.c:
2463 Added get_supported_secure_authentication_methods(), though it is mostly
2464 commented-out for now until the necessary API is committed to tinymail.
2465 (modest_account_settings_dialog_set_account_name),
2466 (save_configuration): Request the supported authentication methods from the
2467 server, so we can choose a working method.
2469 * src/modest-tny-account-store.h:
2470 * src/modest-tny-account-store.c:
2471 (modest_tny_account_store_get_session): Rename from
2472 tny_account_store_get_session().
2474 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2476 * src/modest-protocol-info.h: Split the ModestProtocol enum
2477 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2478 There was no need to have these unrelated values in one enum.
2480 * src/: many files: Adapted to changed enum. This makes the code a bit
2481 clearer, and the compiler could catch some errors.
2483 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2485 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2486 Show the detailed internal camel error message when an error happens
2487 during the configuration, so that our testers can give us more clues.
2488 For instance, in projects.maemo.org bug NB#56910 .
2490 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2492 * src/modest-tny-account.c:
2493 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2494 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2496 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2498 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2499 * src/maemo/modest-account-settings-dialog.c:
2500 (modest_account_settings_dialog_set_account_name),
2501 (save_configuration): For the incoming secure authentication checkbox,
2502 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2503 the UI specification. PLAIN does not seem to be supported for most IMAP
2504 servers anyway, and I am not sure what it would mean.
2505 However, we probably need to discover which of the secure-authentication
2506 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2507 * src/modest-account-mgr-helpers.c:
2508 (modest_account_mgr_get_server_account_data):
2510 * src/modest-tny-account.c:
2511 (modest_tny_account_new_from_server_account):
2512 Use tny_account_set_mech() to set secure-authentication methods,
2513 with some special-casing for IMAP, based on my observations of how
2516 * src/modest-account-mgr-helpers.h:
2517 * src/modest-account-mgr.c:
2518 * src/modest-defs.h: Comment that the URI is only used for local folders.
2520 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2522 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2523 parameter const, just to be neat.
2524 * src/modest-text-utils.c: (modest_text_utils_inline):
2525 End g_strconcat() with NULL, as its documentation says. This is almost
2526 certainly the cause of my crash at startup on the device. Interestingly,
2527 valgrind doesn't tell us about these errors.
2529 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2531 * scripts/build-packages: Added more precise comments about how to use
2532 this script, though I still get this error:
2533 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2534 error building tinymail
2536 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2538 * src/maemo/modest-main-window.c: (on_account_update):
2539 Very slight cleanup, hoping to make it simpler to discover what causes
2540 a crash here sometimes.
2542 * src/modest-tny-account.c:
2543 (modest_tny_account_new_from_server_account): Set the port. Added
2544 comments about the options and a TODO comment because I need to find out
2545 how to specify the secure authentication method.
2547 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2549 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2550 changed CFlags paths form modest to libmodest
2552 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2554 * src/modest-account-mgr-helpers.c:
2555 (modest_account_mgr_get_server_account_data),
2556 (modest_account_mgr_free_server_account_data):
2557 * src/modest-account-mgr-helpers.h:
2558 * src/modest-account-mgr.c:
2559 (modest_account_mgr_add_server_account):
2560 * src/modest-defs.h:
2561 * src/modest-tny-account.c:
2562 (modest_tny_account_new_from_server_account):
2563 Determine the options for tny_camel_account_add_option() here,
2564 based on the settings, rather than storing them directly in gconf.
2566 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2568 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2569 Show a more friendly error dialog now that we expect (from the tinymail
2570 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2572 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2574 * src/maemo/modest-main-window.c: (on_account_update): Check that
2575 account_name is not NULL, to prevent a crash at startup that I am
2576 seeing on the N800. I do wonder why it is NULL.
2578 * src/maemo/easysetup/modest-easysetup-wizard.c:
2579 (create_page_user_details):
2580 * src/maemo/modest-account-settings-dialog.c:
2581 (create_page_user_details), (create_page_outgoing):
2582 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2583 (modest_connection_specific_smtp_edit_window_init):
2584 * src/modest-ui-actions.c:
2585 (modest_ui_actions_on_password_requested):
2586 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2587 might do something useful with the on-screen keyboard.
2589 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2591 * src/maemo/modest-main-window.c: (on_account_update):
2592 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2593 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2595 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2597 * src/modest-tny-account-store.c: (on_account_changed):
2598 Correct the signature of this signal handler.
2600 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2602 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2603 Show a HildonNote instead of a GtkDialog for Maemo.
2605 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2607 * src/widgets/modest-account-view.h:
2608 * src/widgets/modest-account-view.c: (on_account_changed),
2609 (on_account_removed). Added a boolean flag, set/unset by
2610 modest_account_view_block_conf_updates(),
2611 modest_account_view_unblock_conf_updates() to prevent unnecessary
2612 updates, but this is not very useful because the gconf notifications are
2613 so delays (maybe only on Maemo Bora).
2614 So auto-updating is turned off, and these functions do an explicit
2615 update when necessary.
2616 However, something else is still doing too much work when adding/removing
2617 accounts, probably in another part of the application.
2619 * src/maemo/modest-account-view-window.c:
2620 (on_delete_button_clicked), (on_edit_button_clicked),
2621 (on_new_button_clicked): Use the new functions.
2623 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2625 * src/modest-account-mgr-helpers.c:
2626 (modest_account_mgr_set_first_account_as_default):
2627 Sort the list of names alphabetically-by-title, so we choose the first one
2629 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2630 alphabetically by the title.
2632 This fixes projects.maemo.org bug NB#56418 .
2634 * src/modest-account-mgr-priv.c:
2635 (_modest_account_mgr_account_from_key):
2636 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2637 avoid a valgrind error, and possible random behaviour.
2639 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2641 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2642 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2643 tinymail documentation to say that this can be expected.
2644 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2645 pretty, and should not happen, but I would prefer to know when it does.
2647 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2649 * configure.ac: When using the older hildon version, probably on Bora,
2650 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2652 * src/widgets/modest-attachment-view.c:
2653 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2656 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2658 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2659 Implemented the prototype. Can be tested with
2660 tests/dbus_api/test_open_message:
2662 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2664 * src/modest-tny-account-store.c:
2665 (modest_tny_account_store_instance_init), (get_password):
2666 * src/modest-ui-actions.c:
2667 (modest_ui_actions_on_password_requested):
2668 Do not store the password in gconf, because this function is called
2669 for non-remembered passwords. Actually use the cached (in the hash map)
2670 password instead of releasing it.
2671 The password will now not be remembered if it is asked via the protected
2672 password dialog, as per the UI spec.
2674 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2676 * src/modest-defs.h:
2677 * src/modest-account-mgr-helpers.h:
2678 * src/modest-account-mgr-helpers.c:
2679 Added modest_server_account_get_username_has_succeeded(),
2680 modest_server_account_set_username_has_succeeded().
2681 (modest_server_account_set_username),
2682 Reset the has-succeeded flag if the username changes.
2684 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2685 * src/maemo/modest-connection-specific-smtp-window.c:
2686 (modest_connection_specific_smtp_window_save_server_accounts):
2687 Use modest_server_account_set_username() instead of using
2688 modest_conf_set_string() directly, so that the has-succeeded flag is always
2691 * src/modest-ui-actions.c:
2692 (modest_ui_actions_on_password_requested): Dim the username entry if
2693 the username has ever worked, as per the UI spec.
2695 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2697 * src/modest-tny-account-store.c: (get_password):
2698 * src/modest-ui-actions.c:
2699 (modest_ui_actions_on_password_requested):
2700 Allow the username to be changed too, though there is more work to
2701 be done on exactly how this behaves.
2703 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2705 * src/modest-account-mgr-helpers.h:
2706 * src/modest-account-mgr-helpers.c:
2707 Added modest_account_mgr_get_display_name(),
2708 modest_server_account_get_username(),
2709 modest_server_account_set_username(),
2710 modest_server_account_set_password(),
2711 modest_server_account_get_hostname() functions so we do not need to
2712 use the conf API directly.
2714 * src/maemo/modest-main-window.c: (connect_signals):
2715 Actually connect ot the ModestAccountStore::request-password signal,
2716 so that we show the dialog when the password is requested by Tinymail,
2717 for isntance if it is empty.
2719 * src/modest-marshal.list:
2720 * src/modest-tny-account-store.c:
2721 (modest_tny_account_store_class_init), (get_password),
2722 (modest_tny_account_store_alert):
2723 * src/modest-tny-account-store.h:
2724 * src/modest-ui-actions.h:
2725 * src/modest-ui-actions.c:
2726 (modest_ui_actions_on_password_requested):
2727 Change the signal parameters, so it is obvious that we are providing
2728 the non human-readable server name, and receiving both the username
2729 and password, though changing of the username is not yet implemented.
2730 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2731 for the GNOME version.
2733 This should fix the projects.maemo.org bug NB#56209, though it does not
2734 work on Bora, because the gconf_client_get() for the password fails
2735 immediately after we save it with gconf_client_set().
2737 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2740 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2741 caused an undefined symbol error:
2742 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2744 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2746 * src/modest-tny-account-store.c:
2747 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2748 using a GError instead of a string message, so we can translate it in
2751 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2753 * src/maemo/modest-address-book.c:
2754 (modest_address_book_check_names):
2755 * src/maemo/modest-msg-view-window.c:
2756 (modest_msg_view_window_clipboard_owner_change):
2757 * src/modest-init.c: (modest_init_init_ui):
2758 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2759 (update_folders_cb), (modest_mail_operation_update_account):
2760 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2761 (modest_ui_actions_on_msg_attachment_clicked),
2762 (modest_ui_actions_on_msg_recpt_activated):
2763 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2764 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2765 (modest_msg_view_search_next):
2766 * src/widgets/modest-recpt-editor.c:
2767 (modest_recpt_editor_on_button_release_event),
2768 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2769 g_message(). At this point we should only be seeing interesting errors on
2770 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2772 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2774 (modest_wizard_dialog_force_title_update):
2775 * src/maemo/easysetup/modest-wizard-dialog.h:
2776 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2777 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2778 can update the title when appropriate. Otherwise the title is wrong if the
2779 pages are added after adding the notebook to the dialog.
2780 This must be a problem in HildonWizardDialog too.
2781 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2783 * src/maemo/easysetup/modest-easysetup-wizard.c:
2784 (create_subsequent_customsetup_pages),
2785 (create_subsequent_easysetup_pages):
2786 Call modest_wizard_dialog_force_title_update() so that the title is
2787 correct even with GTK+ < 2.10.
2788 This fixes projects.maemo.org bug NB#56145 .
2790 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2792 * src/maemo/modest-platform.c:
2793 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2794 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2797 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2799 * src/widgets/modest-window.h:
2800 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2801 and modest_window_save_state(), which invokes it.
2803 * src/widgets/modest-window-mgr.h:
2804 * src/widgets/modest-window-mgr.c:
2805 Added modest_window_mgr_save_state_for_all_windows(), which calls
2806 the save_state vfunc on all registered windows, if implemented.
2808 * src/gnome/modest-msg-edit-window.c:
2809 * src/gnome/modest-msg-view-window.c:
2810 * src/maemo/modest-msg-edit-window.c:
2811 * src/maemo/modest-msg-view-window.c:
2812 * src/maemo/modest-main-window.c:
2813 Specify the existing save_settings functions as implementations of
2814 ModestWindow::save_state_func().
2816 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2817 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2818 enabling hibernation, for instance.
2820 We may need to do the same thing for restoring settings.
2823 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2825 * src/widgets/modest-window-mgr.c:
2826 * src/widgets/modest-window-mgr.h:
2827 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2828 modest_window_mgr_get_hibernation_is_prevented().
2830 * src/maemo/modest-main-window.c:
2831 (on_hildon_program_is_topmost_notify): Prevent hibernation
2832 (possible when the application goes to the background in the WM),
2833 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2835 * src/maemo/easysetup/modest-easysetup-wizard.c:
2836 (modest_easysetup_wizard_dialog_init):
2837 * src/maemo/modest-account-settings-dialog.c:
2838 (modest_account_settings_dialog_init):
2839 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2840 (modest_connection_specific_smtp_edit_window_init):
2841 * src/maemo/modest-connection-specific-smtp-window.c:
2842 (modest_connection_specific_smtp_window_init):
2843 * src/maemo/modest-signature-editor-dialog.c:
2844 (modest_signature_editor_dialog_init):
2845 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2846 prevent hibernation while any of these account settings dialogs are open.
2848 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2850 * src/maemo/Makefile.am:
2851 * src/maemo/modest-osso-state-saving.c:
2852 * src/maemo/modest-osso-state-saving.h: Added
2853 modest_osso_load_state() and modest_osso_save_state() though they do
2854 nothing now. They should iterate through all the open windows and load/save
2856 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2857 save state when closing.
2859 * src/maemo/modest-main-window.c:
2860 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2861 Add a notification handler for the HildonProgram::is-topmost property,
2862 so we can allow hibernation when the application goes into the background.
2863 But we still need to detect when the accounts setup windows are open so
2864 we can stop hibernation when they are open.
2865 To do this, I also added the main window the HildonProgram. This might have
2866 other side-effects/benefits, and should maybe be done for other windows.
2868 * src/maemo/modest-osso-autosave-callbacks.h:
2869 * src/maemo/modest-osso-autosave-callbacks.c:
2870 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2871 though it does not do anything yet, and we might never need this to do
2872 anything. For instance, we already save drafts.
2874 * src/maemo/modest-platform.c: (modest_platform_init):
2875 Specify the libosso auto-save callback.
2877 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2879 * src/maemo/modest-platform.c:
2880 (modest_platform_set_update_interval):
2881 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2882 aparently stays valid between application instances, so we can use this
2883 to remove and reset it later. According to a maemo-developers email from
2886 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2888 * configure.ac: Depend on libalarm for Maemo.
2890 * src/dbus_api/modest-dbus-api.h:
2891 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2892 (on_send_receive), (modest_dbus_req_handler):
2893 Handle a SEND_RECEIVE D-Bus method.
2895 * libmodest-dbus-client/libmodest-dbus-client.c:
2896 (libmodest_dbus_client_send_and_receive):
2897 * libmodest-dbus-client/libmodest-dbus-client.h:
2898 Add C convenience functions for calling the new D-Bus method.
2900 * src/modest-platform.h:
2901 * src/gnome/modest-platform.c:
2902 * src/maemo/modest-platform.c:
2903 Added modest_platform_set_update_interval(), which uses the
2904 alarmd API on Maemo.
2905 (modest_platform_init),
2906 Call modest_platform_set_update_interval(), using a hard-coded
2907 interval for now (until the global settings dialog is implemented),
2908 though I am not sure that this makes sense yet.
2910 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2912 * src/dbus_api/modest-dbus-callbacks.c:
2913 (modest_osso_cb_hw_state_handler):
2914 * src/dbus_api/modest-dbus-callbacks.h:
2915 * src/maemo/modest-platform.c: (modest_platform_init):
2916 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2917 in case this has some effect on the ability for Maemo to ping the
2920 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2922 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2923 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2924 warning. It is probably a logic error, but I need to fix the build.
2926 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2928 * src/modest-account-mgr.h:
2929 * src/modest-account-mgr.c:
2930 (modest_account_mgr_account_names): Add a gboolean enabled_only
2931 parameter, so we can get lists of onlt the enabled accounts.
2933 (modest_account_mgr_add_account),,
2934 (modest_account_mgr_account_with_display_name_exists):
2935 * src/maemo/modest-msg-edit-window.c: (get_transports):
2936 * src/modest-account-mgr-helpers.c:
2937 (modest_account_mgr_set_first_account_as_default):
2938 * src/modest-init.c: (init_default_account_maybe):
2939 * src/modest-tny-account-store.c: (get_accounts):
2940 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2941 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2942 * tests/check_account-mgr.c: (START_TEST):
2943 Provide the extra parameter, as appropriate.
2945 * src/widgets/modest-account-view.c: (update_account_view):
2946 Do not show disabled accounts (meaning that there is no way to
2947 enable/disable accounts in the UI (the feature is not in our UI
2948 specification), so we can use this internally only to mark unfinished
2949 or temporary account data.
2951 * src/maemo/easysetup/modest-easysetup-wizard.c:
2952 (create_account): Add boolean enable parameter, so we can specify FALSE
2953 to create the temporary account.
2954 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2955 (on_before_next): When finishing, when there is a temporary account, just
2957 Also, use a timeout to delay the showing of the dialog until gconf is likely
2958 to return correct information, due to a maemo gconf bug that is fixed in
2959 osso 1.1, but not yet in Bora.
2960 However, the dialog stays on screen after it is destroyed.
2962 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2963 for invalid data when cancelling. Use a hildon note instead of a dialog
2964 to complain about invalid data. Do not show the account-saved note if the
2965 account is disabled (a temporary account that will not really be saved for use
2968 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2970 * src/modest-account-mgr-helpers.h:
2971 * src/modest-account-mgr-helpers.c:
2972 Added modest_account_mgr_unset_default_account(),
2973 Added modest_account_mgr_set_first_account_as_default().
2975 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2976 If it was the default account, unset the default account name.
2978 * src/maemo/modest-account-view-window.c:
2979 (on_delete_button_clicked): If it was the default account,
2980 set the first remaining account as the default instead.
2982 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2983 a NULL account or a NULL default account, to prevent a crash. This should
2984 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2987 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2989 * src/widgets/modest-recpt-editor.c:
2990 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2991 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2992 TODO comment for this. This fixes the build.
2994 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2995 be the best place for it. This will in future update all auto-update accounts,
2996 rather than just the current/default account, when that gconf key exists.
2997 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2998 if there are no accounts, before calling do_send_receive().
2999 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3001 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3002 * src/maemo/modest-main-window-ui.h:
3003 * src/maemo/modest-main-window.c: (on_connection_changed),
3004 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3005 directly, becaue the signal handler does more.
3007 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3009 * src/modest-account-mgr-helpers.c:
3010 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3011 for the case that the account does not exist.
3013 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3014 (equivalent to the modest account name) rather than the tinymail account name
3015 (equivalent to the modest account title - human readable) to get the account data.
3016 Check for null account data to prevent the crash, and add a TODO comment saying that
3017 this needs fixing because it is using the server account name instead of the account name.
3019 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3021 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3022 * src/maemo/modest-account-settings-dialog.c: (show_error),
3024 Use hildon_note_new_information() for informative and error messages,
3025 which seems to be expected for Maemo applications (no documentation that I know of
3026 says this). I am surprised that there is no distinction between info and error
3029 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3031 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3032 it is easy to find where this is used.
3034 * src/maemo/easysetup/modest-easysetup-wizard.c:
3035 (create_page_welcome), (create_page_account_details),
3036 (create_page_user_details), (create_page_complete_easysetup),
3037 (create_page_custom_incoming), (create_page_custom_outgoing),
3038 (create_page_complete_custom):
3039 * src/maemo/modest-account-settings-dialog.c:
3040 (create_page_account_details), (create_page_user_details),
3041 (create_page_incoming), (create_page_outgoing):
3042 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3043 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3044 (modest_connection_specific_smtp_edit_window_init):
3045 * src/maemo/modest-connection-specific-smtp-window.c:
3046 (modest_connection_specific_smtp_window_init):
3047 * src/maemo/modest-signature-editor-dialog.c:
3048 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3049 and scrolling policy as per the Email Application Layout Guide, if I have
3052 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3054 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3055 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3056 which were empty, because these vfuncs have been removed from TnyAccountStore.
3057 This fixes the build.
3059 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3061 * src/maemo/modest-main-window.c:
3062 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3063 showing/hiding it. Added TODO because it probably should not be NULL.
3064 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3065 because unnecessary g_warnings() make degugging difficult.
3067 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3069 * src/maemo/modest-msg-edit-window.c:
3070 (modest_msg_edit_window_select_color),
3071 (modest_msg_edit_window_select_background_color): 2 const corrections and
3072 moving 2 #endifs before closing brackets, to fix the build.
3074 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3076 * src/maemo/easysetup/modest-easysetup-wizard.h:
3077 * src/maemo/easysetup/modest-easysetup-wizard.c:
3078 (modest_easysetup_wizard_dialog_finalize),
3079 (on_button_edit_advanced_settings), (create_page_complete_custom),
3080 (on_response), (create_account):
3081 Implement the Advanced Settings edit button, by saving the account information,
3082 for the Advanded Settings dialog to use directly from gconf, and removing it
3083 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3084 Bug #5533 in the projects.maemo.org bugzilla.
3086 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3088 * src/maemo/modest-msg-view-window.c:
3089 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3090 when opening a message window.
3092 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3094 * src/maemo/easysetup/modest-easysetup-wizard.c:
3095 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3098 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3099 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3100 gconf settings. I probably added more checks than necessary, but that is safer.
3102 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3103 variable to fix the build, but this seems to be used when it is still NULL.
3105 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3107 * src/modest-platform.h:
3108 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3109 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3110 * src/modest-main.c: Implement this function so we can avoid using
3111 maemo-specific API from cross-platform code.
3113 * src/modest-tny-account-store.c:
3114 (get_smtp_specific_transport_account_for_open_connection):
3115 * src/modest-ui-actions.c: (check_for_connection),
3116 (modest_ui_actions_on_item_not_found):
3117 Use modest_platform_connect_and_wait() and put #idefs around other
3118 maemo-specific code, because only maemo currently has a way to
3119 identify connection names.
3121 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3123 * src/modest-tny-account-store.h:
3124 * src/modest-tny-account-store.c:
3125 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3126 the connection-specific SMTP server settings in the configuration.
3128 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3130 * src/maemo/modest-main-window.c: (on_connection_changed),
3132 * src/modest-main.c: (main), (start_ui), (send_mail):
3133 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3134 that is what is intended.
3136 * src/modest-ui-actions.c: (action_send), (action_receive),
3137 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3138 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3139 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3140 SMTP server is used when it is specified.
3142 (modest_ui_actions_on_send_receive):
3143 Check that a connection is open before proceeding.
3144 Receive and then send, instead of vice-versa, as per the specification.
3146 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3148 * src/modest-mail-operation.c:
3149 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3150 though I guess it should be something other than NULL.
3152 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3154 * src/maemo/easysetup/modest-easysetup-wizard.c:
3155 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3156 combo twice, to avoid an g_warning and to make it visible again.
3157 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3158 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3159 (already intended) dereference when detaching, because we then recreate the menu.
3160 But I am not sure why the warning was happening, and it is possible that this is a memory
3163 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3165 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3166 and uri_parse_mailto() utility functions.
3167 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3169 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3171 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3173 * src/dbus_api/modest-dbus-api.h:
3174 * src/dbus_api/modest-dbus-callbacks.c:
3175 Use an idle callback to execute the modest code in the application's own thread.
3176 Remove the helloworld example method.
3177 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3178 parsed, and the open-message method is not implemented because this is not yet implemented in
3180 * libmodest-dbus-client/libmodest-dbus-client.c:
3181 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3182 (libmodest_dbus_client_open_message):
3183 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3185 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3186 body without crashing.
3188 * tests/dbus_api/Makefile.am:
3189 * tests/dbus_api/test_mail_to.c:
3190 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3192 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3194 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3195 Added file to fix the build. Sorry.
3197 * src/dbus_api/Makefile.am:
3198 * src/dbus_api/modest-dbus-api.h:
3199 * src/dbus_api/modest-dbus-callbacks.h:
3200 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3201 (modest_dbus_req_handler):
3202 Put constants in a separate header so it can be reused by the
3203 client library, without duplication
3205 * libmodest-dbus-client/Makefile.am:
3206 * libmodest-dbus-client/libmodest-dbus-client.c:
3207 (libmodest_dbus_client_call_helloworld),
3208 (libmodfest_dbus_client_send_mail),
3209 (libmodfest_dbus_client_mailto),
3210 (libmodfest_dbus_client_open_message):
3211 * libmodest-dbus-client/libmodest-dbus-client.h:
3212 (Partly) Implement a send_mail D-Bus method.
3214 * tests/dbus_api/Makefile.am:
3215 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3216 the send_email D-Bus method.
3218 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3222 * libmodest-dbus-client/Makefile.am:
3223 * libmodest-dbus-client/libmodest-dbus-client.c:
3224 * libmodest-dbus-client/libmodest-dbus-client.h:
3225 * tests/dbus_api/Makefile.am:
3226 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3227 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3229 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3231 * src/maemo/easysetup/modest-easysetup-wizard.c:
3232 (create_page_account_details):
3233 * src/maemo/modest-account-settings-dialog.c:
3234 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3235 widgets, because this might not be the default in future versions of the Maemo GTK+.
3236 However, I can not not get capitalization to work even in a simple test case.
3238 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3240 * src/maemo/easysetup/modest-easysetup-wizard.c:
3241 (create_page_custom_incoming), (create_page_custom_outgoing):
3242 * src/maemo/modest-account-settings-dialog.c:
3243 (create_page_account_details), (create_page_incoming),
3244 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3245 instead of using gtk_check_button_with_label(), so they are aligned like the other
3246 widgets, as per the UI spec.
3248 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3250 * src/maemo/easysetup/modest-easysetup-wizard.c:
3251 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3252 * src/widgets/modest-validating-entry.c:
3253 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3254 Modest prefix instead of an EasySetup prefix.
3256 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3258 * src/widgets/modest-validating-entry.h:
3259 * src/widgets/modest-validating-entry.c: (on_insert_text),
3260 Added easysetup_validating_entry_set_max_func(), used to set a callback
3261 to call when the max number of characters is reached. GtkEntry has a max-length
3262 already but is silent about it.
3264 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3265 (create_page_account_details), (create_page_user_details),
3267 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3268 (create_page_account_details), (create_page_user_details),
3269 (create_page_outgoing):
3270 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3271 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3272 the UI spec, when the user tries to enter more than the max number of characters.
3274 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3276 * src/maemo/easysetup/modest-easysetup-wizard.c:
3277 (create_page_user_details), (create_page_custom_incoming),
3278 (create_page_custom_outgoing):
3279 * src/maemo/modest-account-settings-dialog.c:
3280 (create_page_user_details), (create_page_incoming),
3281 (create_page_outgoing):
3282 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3283 (modest_connection_specific_smtp_edit_window_init):
3284 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3285 not appropriate. Bad Maemo-specific defaults!.
3287 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3289 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3290 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3291 (modest_signature_editor_dialog_set_settings):
3292 Disable the label and textview when the checkbox is disabled, and use the
3293 specified (UI spec) default signature text.
3295 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3297 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3298 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3300 * src/modest-defs.h:
3301 * src/modest-account-mgr-helpers.h:
3302 * src/modest-account-mgr-helpers.c:
3303 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3305 * src/maemo/Makefile.am:
3306 * src/maemo/modest-signature-editor-dialog.c:
3307 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3310 * src/maemo/modest-account-settings-dialog.h:
3311 * src/maemo/modest-account-settings-dialog.c:
3312 (modest_account_settings_dialog_finalize), (on_button_signature),
3313 (save_configuration): Use the new dialog when the Edit button is pressed, and
3314 save the changes if necessary, as per the UI spec.
3316 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3318 * src/maemo/Makefile.am:
3319 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3320 based on maemo-develoers email from Dirk.
3322 * src/maemo/easysetup/modest-easysetup-wizard.c:
3323 (create_page_welcome), (create_page_account_details),
3324 (create_page_user_details), (create_page_complete_easysetup),
3325 (create_page_custom_incoming), (create_page_custom_outgoing),
3326 (create_page_complete_custom),
3327 (modest_easysetup_wizard_dialog_init):
3328 * src/maemo/modest-account-settings-dialog.c:
3329 (create_page_account_details), (create_page_user_details),
3330 (create_page_incoming), (create_page_outgoing),
3331 (modest_account_settings_dialog_init):
3332 * src/maemo/modest-connection-specific-smtp-window.c:
3333 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3335 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3337 * src/maemo/easysetup/modest-easysetup-wizard.c:
3338 (create_page_account_details), (create_page_custom_outgoing),
3339 (create_page_complete_custom):
3340 * src/maemo/modest-account-settings-dialog.c:
3341 (create_page_user_details), (create_page_incoming),
3342 (create_page_outgoing):
3343 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3344 (modest_connection_specific_smtp_edit_window_init):
3345 Use the correct (UI spec) port min/max, and use horizontal separators,
3348 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3350 * src/maemo/easysetup/modest-easysetup-wizard.c:
3351 (set_default_custom_servernames):
3352 * src/maemo/modest-account-settings-dialog.c:
3353 (create_page_incoming), (on_combo_outgoing_security_changed),
3354 (on_combo_incoming_security_changed), (create_page_outgoing),
3355 (modest_account_settings_dialog_set_account_name),
3356 (save_configuration):
3357 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3358 (on_combo_security_changed),
3359 (modest_connection_specific_smtp_edit_window_init),
3360 (modest_connection_specific_smtp_edit_window_set_connection),
3361 (modest_connection_specific_smtp_edit_window_get_settings):
3362 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3365 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3368 * src/maemo/easysetup/modest-easysetup-wizard.c:
3369 (create_page_custom_outgoing), (create_page_complete_custom):
3370 * src/maemo/modest-account-settings-dialog.c:
3371 (create_page_user_details), (create_page_outgoing):
3372 * src/maemo/modest-account-view-window.c: (button_box_new):
3373 Use changed logical IDs as per the most recent UI spec:
3374 mcen_bd_emailsetup_edit -> mcen_bd_edit
3375 mcen_bd_emailsetup_delete -> mcen_bd_delete
3376 mcen_bd_emailsetup_close -> mcen_bd_close
3378 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3382 * src/dbus_api/Makefile.am:
3383 * src/dbus_api/modest-dbus-callbacks.c:
3384 * src/dbus_api/modest-dbus-callbacks.h:
3385 * src/maemo/modest-platform.c: (modest_platform_init):
3386 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3388 * tests/Makefile.am:
3389 * tests/dbus_api/Makefile.am:
3390 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3392 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3394 * src/maemo/modest-account-settings-dialog.c:
3395 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3396 Removed unnecessary includes.
3398 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3400 * src/maemo/easysetup/modest-easysetup-wizard.c:
3401 * src/maemo/modest-account-settings-dialog.c:
3402 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3403 * src/widgets/Makefile.am:
3404 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3405 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3406 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3407 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3408 * src/widgets/modest-secureauth-combo-box.c:
3409 * src/widgets/modest-secureauth-combo-box.h:
3410 * src/widgets/modest-serversecurity-combo-box.c:
3411 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3412 made the GObject names more consistent with the rest of the Modest code.
3414 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3416 * src/maemo/easysetup/Makefile.am:
3417 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3418 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3419 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3420 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3421 * src/maemo/easysetup/modest-easysetup-wizard.c:
3422 * src/maemo/easysetup/modest-validating-entry.c:
3423 * src/maemo/easysetup/modest-validating-entry.h:
3424 * src/maemo/modest-account-settings-dialog.c:
3425 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3426 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3427 widgets/ because they are used outside of easysetup too. After checking in,
3428 svn will allow me to rename them too.
3430 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3432 * src/gnome/modest-msg-edit-window.c:
3433 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3434 linker error, to fix the build on the GNOME platform.
3435 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3436 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3437 ifdefed out to avoid a warning.
3439 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3441 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3442 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3443 some alternative for GTK+ 2.6.
3445 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3447 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3449 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3450 specified for EmailAccountsDialog in UI spec.
3452 * src/maemo/easysetup/modest-easysetup-wizard.c:
3453 * src/maemo/easysetup/modest-easysetup-wizard.h:
3454 * src/maemo/modest-account-settings-dialog.c:
3455 * src/maemo/modest-account-settings-dialog.h:
3456 Reuse a member window widget for the connection-specific SMTP server accounts,
3457 so we can tell it to create/save the accounts only if we actually save changes.
3459 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3460 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3461 (modest_connection_specific_smtp_edit_window_get_settings):
3462 Return a struct instance for temporarily remembering the entered data.
3464 * src/maemo/modest-connection-specific-smtp-window.h:
3465 * src/maemo/modest-connection-specific-smtp-window.c:
3466 (modest_connection_specific_smtp_window_finalize),
3467 (modest_connection_specific_smtp_window_fill_with_connections),
3469 (modest_connection_specific_smtp_window_save_server_accounts),
3470 (update_model_server_names): Do not actually save data until asked,
3471 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3473 (on_selection_changed),
3474 (modest_connection_specific_smtp_window_init): Disable the edit
3475 button when nothing is selected.
3477 * src/modest-account-mgr-helpers.c:
3478 * src/modest-account-mgr-helpers.h:
3479 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3482 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3484 * src/modest-account-mgr-helpers.h:
3485 * src/modest-account-mgr-helpers.c:
3486 (modest_account_mgr_get_unused_account_name),
3487 (modest_account_mgr_get_unused_account_display_name): Added these
3488 utility functions, to avoid code duplication.
3490 * src/maemo/easysetup/modest-easysetup-wizard.c:
3491 (create_page_account_details), (create_account):
3492 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3493 (on_combo_security_changed),
3494 (modest_connection_specific_smtp_edit_window_init),
3495 (modest_connection_specific_smtp_edit_window_save_settings):
3496 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3497 * src/maemo/modest-connection-specific-smtp-window.c:
3498 (modest_connection_specific_smtp_window_finalize),
3499 (modest_connection_specific_smtp_window_fill_with_connections),
3500 (on_button_edit), (modest_connection_specific_smtp_window_init):
3501 * src/maemo/modest-connection-specific-smtp-window.h:
3502 Implementing saving of connection-specific server accounts.
3504 But I need to refactor this so we can save the data for each
3505 possible connection-specific account and only actually create the server accounts
3506 when the easysetup finished, or the OK button is pressed on the account settings
3509 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3511 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3512 (on_combo_security_changed):
3513 (modest_connection_specific_smtp_edit_window_init):
3514 Auto-fill the port number as in the account settings.
3516 (modest_connection_specific_smtp_edit_window_set_connection):
3517 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3518 * src/maemo/modest-connection-specific-smtp-window.c:
3519 (fill_with_connections), (on_button_edit),
3520 (modest_connection_specific_smtp_window_init):
3521 Turn the edit window into a dialog to simplify the code, and
3522 set a WM hint as in a GtkDialog, because only a popup can be on top of
3523 another window in Maemo, and popups usually have no WM decoration.
3525 * src/modest-defs.h:
3526 * src/modest-account-mgr-helpers.c:
3527 (modest_account_mgr_set_connection_specific_smtp),
3528 (modest_account_mgr_remove_connection_specific_smtp),
3529 (modest_account_mgr_get_connection_specific_smtp):
3530 * src/modest-account-mgr-helpers.h: Some functions to write the
3531 connection-specific SMTP server information. Not yet used.
3534 * src/widgets/modest-folder-view.c: (text_cell_data):
3535 Fix a warning about an uninitialized variable.
3536 (on_configuration_key_changed): Put an #ifdef around the use
3537 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3539 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3541 * src/maemo/modest-account-settings-dialog.h:
3542 * src/maemo/modest-account-settings-dialog.c:
3543 Added connect_for_modified() utility function to mark the new modified boolean.
3545 (create_page_account_details), (create_page_user_details),
3546 (create_page_incoming), (create_page_outgoing), (on_response),
3547 (modest_account_settings_dialog_init),
3548 (modest_account_settings_dialog_set_account_name):
3549 Only warn about unsaved changes when there are actually unsaved changes.
3551 * src/modest-account-mgr-helpers.c:
3552 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3553 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3554 to get the data from there in future.
3556 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3558 * src/modest-defs.h:
3560 * src/modest-account-mgr-helpers.h:
3561 * src/modest-account-mgr-helpers.c:
3562 Store the security account setting in a single conf key instead of using
3563 the options list, so that the list is left for just the to-be-removed camel hack,
3564 and because gconf_client_set_list() is failing for some reason.
3566 * src/modest-account-mgr.c:
3567 (modest_account_mgr_add_server_account):
3568 * src/maemo/modest-account-settings-dialog.c:
3569 (modest_account_settings_dialog_set_account_name),
3570 (save_configuration): Use the renamed functions.
3573 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3575 * src/widgets/Makefile.am:
3576 * src/widgets/modest-limit-retrieve-combo-box.c:
3577 * src/widgets/modest-limit-retrieve-combo-box.h:
3578 * src/widgets/modest-retrieve-combo-box.c:
3579 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3580 the account settings dialog.
3582 * src/modest-defs.h:
3583 * src/modest-account-mgr-helpers.h:
3584 * src/modest-account-mgr-helpers.c:
3585 (modest_server_account_get_option_secure_auth),
3586 (modest_server_account_set_option_secure_auth):
3587 * src/modest-account-mgr.c:
3588 (modest_account_mgr_add_server_account):
3589 Use the existing AUTH_MECH conf key for the secure-auth setting,
3590 instead of putting it in the list options, because this was actually used already.
3592 * src/maemo/modest-account-settings-dialog.c:
3593 (create_page_account_details),
3594 (modest_account_settings_dialog_set_account_name),
3595 (save_configuration):
3596 * src/maemo/modest-account-settings-dialog.h:
3597 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3598 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3600 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3602 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3603 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3604 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3606 * src/modest-defs.h:
3607 * src/maemo/modest-account-settings-dialog.c:
3608 (create_page_incoming), (on_combo_outgoing_security_changed),
3609 (on_combo_incoming_security_changed), (create_page_outgoing),
3610 (modest_account_settings_dialog_set_account_name),
3611 (save_configuration): Load/Save the port number, and change it when the
3612 security combo changes, to suitable defaults.
3614 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3616 * src/modest-account-mgr.c:
3617 (modest_account_mgr_add_server_account): Set the security and secure-auth
3618 options, and add a comment saying that the other camel-specific options should be
3621 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3623 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3625 * src/modest-tny-account-store.c: (account_list_free),
3626 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3627 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3630 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3632 * src/modest-protocol-info.c:
3633 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3634 is required by our UI spec. Maybe something in our implementation will use this eventually.
3635 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3636 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3637 instead of the previous 0 placeholder.
3639 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3640 secure-auth settings.
3641 * src/modest-account-mgr-helpers.h:
3642 * src/modest-account-mgr-helpers.c:
3643 (modest_server_account_data_get_option_secure_auth),
3644 (modest_server_account_set_option_secure_auth),
3645 (modest_server_account_data_get_option_security),
3646 (modest_server_account_set_option_security): Added this API for getting and setting the security
3647 and secure-auth settings.
3649 * src/maemo/modest-account-settings-dialog.h:
3650 * src/maemo/modest-account-settings-dialog.c:
3651 (modest_account_settings_dialog_finalize), (check_data),
3652 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3653 about changing titles.
3654 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3655 (save_configuration): Save the security and secure-auth settings.
3657 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3658 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3660 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3662 * src/modest-defs.h:
3663 * src/modest-account-mgr.c:
3664 (modest_account_mgr_add_server_account):
3665 Added and used defines for the options key and value pair strings,
3666 that are used so far, though they do not seem to correspond to anything in our
3667 UI specs or ModestProtocol enum.
3669 * src/modest-account-mgr-helpers.h:
3670 * src/modest-account-mgr-helpers.c:
3671 (compare_option_strings_for_name),
3672 (modest_server_account_data_get_option_value),
3673 (modest_server_account_data_get_option_bool),
3674 (modest_account_mgr_get_server_account_option):
3675 Added helper functions for parsing the options GSList.
3677 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3679 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3680 display name is based on the supplied account name.
3681 * src/modest-account-mgr.c:
3682 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3683 with an inefficient, but good-enough, implementation.
3685 * src/maemo/easysetup/modest-easysetup-wizard.c:
3686 (create_page_account_details), (on_before_next), (create_account):
3687 Check for existing display names rather than (non-user-visible) account names, and just
3688 create and set a unique account name at the end.
3690 * src/maemo/modest-account-settings-dialog.c:
3691 (modest_account_settings_dialog_init),
3692 (modest_account_settings_dialog_set_account_name),
3693 (create_page_incoming): Show the display name, instead of the account name.
3694 (on_response): Do some (not all) extra checks, as in the UI spec.
3695 (save_configuration): Save the display name if it was changed.
3697 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3699 * po/en_GB.po: Added needed logical ID and translation.
3700 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3701 (init_view): Made the is-default column clicking work.
3703 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3706 * src/maemo/easysetup/Makefile.am:
3707 * src/maemo/easysetup/modest-easysetup-wizard.c:
3708 (modest_easysetup_wizard_dialog_init):
3709 * src/maemo/easysetup/provider-data-test.keyfile:
3710 * src/maemo/easysetup/provider-data.keyfile:
3711 Moved the provider data file to the new modest-providers-data package and used it from there.
3713 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3715 * src/modest-local-folder-info.c:
3716 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3717 N_() was already used on the static strings, but this just marks it for translation without
3718 using the translation.
3720 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3722 * src/maemo/modest-account-settings-dialog.c:
3723 (create_page_incoming),
3724 (modest_account_settings_dialog_set_account_name):
3725 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3726 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3727 I will do this if nobody else gets there first.
3729 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3731 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3732 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3733 save the security stuff.
3735 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3737 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3738 Set the email address and user fullname, which I now see must be
3741 * src/maemo/modest-account-settings-dialog.h:
3742 * src/maemo/modest-account-settings-dialog.c:
3744 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3745 leave-on-server and authentication.
3746 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3749 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3752 * src/maemo/modest-account-settings-dialog.c:
3753 * src/maemo/modest-account-settings-dialog.h:
3754 Most (but not all) of the widgets are now present as specified by the UI spec.
3755 No changes are yet saved, and some details are not properly shown yet.
3757 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3759 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3761 * src/maemo/Makefile.am:
3762 * src/maemo/modest-account-settings-dialog.c:
3763 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3764 an existing account. Doesn't do much yet.
3766 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3767 Open the accounts settings dialog when Edit is clicked.
3769 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3771 * src/maemo/easysetup/Makefile.am:
3772 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3774 * src/maemo/easysetup/modest-easysetup-wizard.c:
3775 (modest_easysetup_wizard_dialog_init):
3776 Try to get the source directory from the build system,
3777 instead of hard-coding "./" into the source code, when opening our local
3778 copies of the configuration files.
3779 But this still fails when opening the wizard from the Accounts window,
3780 maybe because the working directory seems to change at runtime.
3781 So the wizard will fail the second time unless you copy the files into their
3782 proper locations - see the stdout warnings for the paths.
3784 (create_page_account_details),(on_before_next):
3785 Check for existing non-server accounts instead of server accounts,
3786 so the default account name is useful again, and to prevent trying to
3789 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3790 Show the wizard when New is clicked.
3792 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3793 (init_view): Show the column headers, and show the columns that are
3794 specified in the UI specs. However, something in Maemo's GTK+ prevents
3795 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3796 change the default account. This is despite unsetting the special properties.
3798 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3800 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3801 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3802 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3803 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3804 to make that clearer.
3805 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3807 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3809 * src/maemo/modest-account-view-window.c:
3810 (modest_account_view_window_init),
3811 (modest_account_view_window_new):
3812 Use the same buttons as specified in the
3813 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3814 the existing widgets, which never had a chance of working.
3815 Put the ModestAccountView treeview in a scrolled window.
3816 Do not repeat the initialization in both _init() and _new().
3818 * src/widgets/modest-account-view.c: (update_account_view):
3819 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3820 this widget and window shows no accounts.
3822 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3824 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3826 * src/maemo/easysetup/modest-easysetup-wizard.c:
3827 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3828 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3829 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3832 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3833 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3834 accounts exist yet, as in the UI spec.
3836 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3838 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3840 * src/maemo/Makefile.am:
3841 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3842 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3843 New window for editing connection-specific smtp details.
3844 Not fully implemented.
3846 * src/maemo/modest-connection-specific-smtp-window.c:
3847 (modest_connection_specific_smtp_window_finalize) :
3848 unref the tree model.
3849 (on_button_edit): Show the edit window.
3851 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3853 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3856 * src/maemo/Makefile.am:
3857 * src/maemo/modest-connection-specific-smtp-window.c:
3858 * src/maemo/modest-connection-specific-smtp-window.h:
3859 New window for showing the list of connections, for connection-specific
3860 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3861 * src/maemo/easysetup/modest-easysetup-wizard.c:
3862 (create_page_custom_outgoing): Show the new window when the button is clicked.
3864 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3866 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3867 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3868 * src/maemo/modest-msg-edit-window.c:
3869 (modest_msg_edit_window_insert_image):
3870 * src/modest-conf.c: (modest_conf_key_escape):
3871 * src/modest-mail-operation.c:
3872 (modest_mail_operation_send_new_mail):
3873 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3874 (modest_ui_actions_on_new_account):
3875 * src/widgets/modest-attachment-view.c: (update_filename_request):
3876 * src/widgets/modest-mail-header-view.c:
3877 Corrected warnings that were breaking the build, by commenting out unused variables,
3878 and a function, and by including a header.
3880 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3882 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3883 so we can #ifdef around platform-specific code when necessary.
3884 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3885 to allow this to build for the GNOME platform too.
3887 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3889 * src/maemo/easysetup/modest-easysetup-wizard.c:
3890 Added util_increment_name() and used it in create_page_account_details()
3891 to make sure that the default account name is always a new name.
3893 (modest_easysetup_wizard_dialog_init),
3894 (set_default_custom_servernames): Some minor memory management fixes.
3896 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3900 * src/modest-runtime.c: (init_i18n): Restored the translation
3901 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3902 are defined in config.h, and the translations are installed.
3904 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3905 is defined for translation.
3907 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3909 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3911 * src/maemo/easysetup/modest-easysetup-wizard.c:
3912 (modest_easysetup_wizard_dialog_init):
3913 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3914 Use realistic paths (though they should use $prefix generically) to the
3915 mcc_mapping and provider-data.keyfile files which might work when they
3916 are installed by the future version of the operator-wizard package,
3917 and then fallback to paths in our source code, with an explanatory
3920 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3924 * src/maemo/Makefile.am:
3925 * src/maemo/easysetup/: Added files from the previously-exernal
3926 osso-modest-easysetup.
3927 * src/maemo/modest-main-window-ui.h:
3928 * src/modest-ui-actions.c:
3929 * src/modest-ui-actions.h:
3930 Added modest_ui_actions_on_new_account() as a signal handler for the
3931 New Account menu item. It shows the easysetup wizard.
3932 * po/en_GB.po: Added additional needed logical IDs and translations.