1 2007-06-02 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
4 incoming and outgoing server name based on email address and server
5 types as long as the names have not been edited manually. This fixes
6 projects.maemo.org bug NB#58671.
8 2007-06-02 Armin Burgmeier <armin@openismus.com>
10 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
11 server type cannot be changed in future to the incoming details page
12 when creating an account. This fixes projects.maemo.org bug NB#59029.
14 2007-06-02 Armin Burgmeier <armin@openismus.com>
16 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
17 and assigned max width chars so that they wrap instead of being
18 truncated. Fixes projects.maemo.org bug NB#56126.
20 2007-06-02 Armin Burgmeier <armin@openismus.com>
22 * src/maemo/modest-connection-specific-smtp-window.c: Add an
23 introductory note to the connection specific smtp servers dialog, as
24 section 8.12 of the email UI specification requires. This fixes
25 projects.maemo.org bug NB#59212.
27 2007-06-01 Murray Cumming <murrayc@murrayc.com>
29 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
30 Check for running mail operations, and offer to cancel them, as per the UI
31 spec. This fixes projects.maemo.org bug NB#59041 .
32 However, I suspect that tinymail may still use the network connection
33 in ways that we cannot detect or cancel. But it should at least adapt to
36 2007-06-01 Murray Cumming <murrayc@murrayc.com>
38 * src/modest-tny-account-store.c: (recreate_all_accounts),
39 (get_cached_accounts), (get_server_accounts): Do more sensible
40 ref-counting of the temporarily-cached outbox accounts list. This seems
41 to fix a crash when entering the password when the password was wrong.
43 2007-06-01 Murray Cumming <murrayc@murrayc.com>
45 * src/gnome/modest-main-window.c: (connect_signals):
46 * src/modest-tny-account-store.c: (get_password),
47 (modest_tny_account_store_alert): Added comments and clues and
48 commented-out code about how we currently fail to deal with connection
49 errors and wrong passwords, and how we should.
51 2007-06-01 Murray Cumming <murrayc@murrayc.com>
53 * src/widgets/modest-retrieve-combo-box.c:
54 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
55 This fixes projects.maemo.org bug NB#58472 .
57 2007-06-01 Murray Cumming <murrayc@murrayc.com>
59 * src/maemo/easysetup/modest-easysetup-wizard.c:
60 (create_page_complete_easysetup):
61 (create_page_complete_custom): Correct the last commit,
62 putting the correct sentences in the correct pages.
64 2007-06-01 Murray Cumming <murrayc@murrayc.com>
66 * src/maemo/easysetup/modest-easysetup-wizard.c:
67 (create_page_complete_custom): Show the second sentence of text
68 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
71 2007-06-01 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
74 Set the leave-on-server conf key by default. This fixes
75 projects.maemo.org bug NB#59258 .
77 2007-06-01 Murray Cumming <murrayc@murrayc.com>
79 * src/maemo/modest-account-view-window.c:
80 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
81 logical ID for the confirmation messages. Fixed projects.maemo.org bug
84 2007-06-01 Murray Cumming <murrayc@murrayc.com>
86 * src/maemo/easysetup/modest-easysetup-wizard.c:
87 (create_caption_new_with_asterisk):
88 * src/maemo/modest-account-settings-dialog.c:
89 (create_caption_new_with_asterisk):
90 Uncomment the code to add the asterisk, because they are no longer in the
91 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
92 (update_incoming_server_title): Add an asterisk here too.
94 2007-06-01 Murray Cumming <murrayc@murrayc.com>
96 * src/maemo/modest-maemo-global-settings-dialog.c:
97 (current_connection): Check that we are even connected before trying to
98 get the current connection name, to prevent a warning.
100 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
101 Change the comments because tny_maemo_conic_device_connect() is now meant to
103 * src/modest-mail-operation.c:
104 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
105 make sure we have a connection and fail if we can't connect.
107 2007-05-31 Murray Cumming <murrayc@murrayc.com>
109 * src/maemo/modest-main-window.c:
110 (on_account_store_connecting_finished): Do not try to get the
111 connection ID if we are not really connected. I am surprised that
112 this signal handler is called when we are not connected.
114 2007-05-31 Murray Cumming <murrayc@murrayc.com>
116 * src/modest-error.h:
117 * src/modest-ui-actions.c:
118 (modest_ui_actions_get_msgs_full_error_handler):
119 Renamed an enum, added comments, added an enum
120 for retrieve-limit errors.
122 * src/modest-mail-operation.c: (foreach_add_item),
123 (internal_folder_observer_update), (update_account_thread),
124 (modest_mail_operation_get_msgs_full):
125 (modest_mail_operation_update_account),
126 Added comments about how this works, and some code that should
127 (but does not) check the retrieve-limit. See the TODO comment.
129 2007-05-31 Murray Cumming <murrayc@murrayc.com>
131 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
132 Initialize help_id to fix the build. Warnings are good.
134 2007-05-31 Murray Cumming <murrayc@murrayc.com>
136 * src/widgets/modest-hbox-cell-renderer.c:
137 (modest_hbox_cell_renderer_append):
138 * src/widgets/modest-vbox-cell-renderer.c:
139 (modest_vbox_cell_renderer_append):
140 Fix the last commit by doing an extra ref.
142 2007-05-31 Murray Cumming <murrayc@murrayc.com>
144 * src/widgets/modest-hbox-cell-renderer.c:
145 (modest_hbox_cell_renderer_append):
146 * src/widgets/modest-vbox-cell-renderer.c:
147 (modest_vbox_cell_renderer_append):
148 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
149 to fix the build with Maemo Bora.
150 However, there seems to be a remaining crash, probably due to reference
153 2007-05-30 Murray Cumming <murrayc@murrayc.com>
155 * src/modest-tny-account.c:
156 (modest_tny_account_new_for_local_folders):
157 Use hildon_file_system_info_async_new() to get a better name for
158 the memory card account, setting it as the account name.
159 The timing seems to work, but this is probably
160 not the best place to do this. See the TODO comment.
161 * src/maemo/modest-main-window.c: (create_details_widget):
162 * src/widgets/modest-folder-view.c: (text_cell_data):
163 Use the tny account name instead of hardcoding a name.
165 2007-05-30 Christian Kellner <ckellner@openismus.com>
167 * src/modest-search.c: (modest_search):
168 Correctly set part_search_func even if we have already parsed
169 the query and thus a valid OgsTextSearcher object.
171 2007-05-30 Christian Kellner <ckellner@openismus.com>
174 Search and check for libogs.
177 Incooparte the ogs build env.
179 * src/modest-mime-part-search-stream.c:
180 * src/modest-mime-part-search-stream.h:
181 Removed since we do the real searching now in modest-search.c.
183 * src/modest-search.c:
184 * src/modest-search.h:
185 Implement support for ogs. We use that if available and requested
186 and fall back to modest_text_utils_utf8_strcmp (). The search logic
187 should now handle the corner case when the search term is spread
188 across multiple reads.
189 Also the logic in modest_search () was corrected to search all
190 requested fields until one is found.
192 2007-05-30 Murray Cumming <murrayc@murrayc.com>
194 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
197 * src/modest-init.c: Made modest_init_local_folders() take a
198 path and be public so we can iniitialize maildir folders on
201 * src/modest-local-folder-info.h:
202 * src/modest-local-folder-info.c:
203 (modest_local_folder_info_get_maildir_path): Add a path parameter.
205 * src/modest-tny-account.c:
206 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
207 still means the standard local-folders path on the local volume.
209 * src/modest-tny-account-store.c:
210 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
211 signal so we can detect mount/unmount of the MMC1 card, and do an update of
212 all accounts when that happens.
213 (get_server_accounts): If the MMC1 card is mounted, create a store account for
214 this too, so it shows up in the treeview.
216 2007-05-28 Murray Cumming <murrayc@murrayc.com>
218 * src/maemo/modest-maemo-global-settings-dialog.c:
219 (current_connection):
220 * src/widgets/modest-global-settings-dialog.c:
221 (current_connection_default):
222 Use the enum values instead of 0, 1 and -1,
223 to make the code clearer.
225 * src/modest-account-mgr-helpers.c:
226 (modest_account_mgr_get_connection_specific_smtp): Make this code
229 * src/modest-runtime.h:
230 * src/modest-runtime.c:
231 Added modest_runtime_remove_all_send_queues().
232 * src/maemo/modest-main-window.c:
233 (on_account_store_connecting_finished): Recreate the send queues,
234 using the appropriate transport accounts for this new connection.
235 Some futher adapting might be needed if the old send queues are not
236 automatically stopped at this point.
238 * src/modest-tny-account-store.c: (get_server_accounts):
239 Create the connection-specific transport accounts, so that they can
240 be found later by their ID.
242 * src/modest-tny-account.h:
243 * src/modest-tny-account.c:
244 Added modest_tny_account_new_from_server_account_name().
245 modest_tny_account_new_from_server_account(): Do not create the
246 send queues here, because they will be
247 recreated anyway when the connection changes for the first time.
249 2007-05-28 Murray Cumming <murrayc@murrayc.com>
251 * src/modest-local-folder-info.h:
252 * src/modest-local-folder-info.c:
253 (modest_per_account_local_outbox_folder_info_get_maildir_path),
254 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
255 tbox_folder): Take a modest account name instead of a server TnyAccount,
256 so we can have per-modest-account rather than per-transport-account
258 We must make sure that we change or recreate the exisitng send queues
259 when the connection changes for connection-specific transport accounts.
261 * src/modest-tny-account-store.c:
262 (create_per_account_local_outbox_folders): Create outboxed per modest
263 account, not per transport account.
265 * src/modest-tny-account.h:
266 * src/modest-tny-account.c:
267 (modest_tny_account_get_special_folder): For outboxes, get the
268 parent modest account name. The account is ignored for other folders.
269 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
270 modest account name rather than a server TnyAccount.
272 2007-05-25 Murray Cumming <murrayc@murrayc.com>
274 * src/modest-tny-account.c:
275 (modest_tny_account_new_from_server_account):
276 Call modest_runtime_get_send_queue() immediately after creating transport
277 accounts, so that they start trying to send email from the outbox as soon
278 as possible at startup. This is probably what we want.
280 * src/modest-mail-operation.c: (update_account_thread):
281 * src/modest-runtime.c: (modest_runtime_get_send_queue):
282 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
283 * src/modest-tny-send-queue.h:
284 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
285 (modest_ui_actions_on_send):
286 Added comments about how sending works, though it needs some more work.
288 2007-05-25 Murray Cumming <murrayc@murrayc.com>
290 * src/modest-tny-account.c:
291 (modest_tny_account_get_special_folder): Add TODO because this fails when
293 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
294 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
295 Do not try to show this window when there is no active account. The UI
296 specs does not tell us what to do in this case.
298 2007-05-24 Murray Cumming <murrayc@murrayc.com>
302 * src/maemo/Makefile.am:
303 * src/widgets/Makefile.am: Some dist fixes.
305 2007-05-24 Murray Cumming <murrayc@murrayc.com>
307 * src/maemo/modest-connection-specific-smtp-window.c:
308 (on_button_edit): Make the code clearer, to prevent a double free.
310 2007-05-24 Murray Cumming <murrayc@murrayc.com>
312 * src/maemo/modest-account-settings-dialog.c:
313 (modest_account_settings_dialog_set_account_name),
314 Check the connection-specific smtp servers checkbox if there are any.
316 * src/maemo/modest-connection-specific-smtp-edit-window.c:
317 (modest_connection_specific_smtp_edit_window_init):
318 Start with a suitable port number.
320 * src/modest-account-mgr-helpers.h:
321 * src/modest-account-mgr-helpers.c: Added
322 modest_account_mgr_get_has_connection_specific_smtp().
324 (modest_account_mgr_set_connection_specific_smtp),
325 (modest_account_mgr_remove_connection_specific_smtp),
326 (modest_account_mgr_get_has_connection_specific_smtp),
327 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
328 connection-specific smtp server accounts in the account, rather than
329 the server account conf dir.
331 This fixes bug projects.maemo.org bug NB#58263 .
333 * src/modest-tny-account-store.c:
334 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
335 if there are no server accounts yet, to prevent an infinite loop when there
336 are no accounts. Document that one must be called before the other.
338 2007-05-24 Murray Cumming <murrayc@murrayc.com>
340 * src/modest-account-mgr-helpers.c:
341 (modest_account_mgr_get_default_account): Make sure that at least
342 one account is always the default, if there are any enabled accounts.
343 This is just a sanity check that shouldn't be necessary.
345 * src/modest-account-mgr-priv.c:
346 (_modest_account_mgr_account_from_key): Unescape the conf key to
347 get the real account name. For instance, this is an issue if a space
348 was in the account name, which can happen because the account name
349 is generated from the display name.
350 (_modest_account_mgr_get_account_keyname): Always escape the
352 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
353 Unescape the conf keys to get the real account names.
355 For instance, previously the is-default radio button in the accounts
356 list was not checked for any accounts at first. This fixes that,
357 and might fix several similar bugs.
359 2007-05-23 Murray Cumming <murrayc@murrayc.com>
361 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
362 Removed some debug printfs.
364 2007-05-23 Murray Cumming <murrayc@murrayc.com>
366 Modest on-disk outbox directories are now here, for instance:
367 $HOME/.modest/outboxes/<account-id-1>/outbox
368 $HOME/.modest/outboxes/<account-id-2>/outbox
370 $HOME/.modest/local-folders/outbox
371 so we can have a separate outbox for each account.
372 But they are shown as one outbox in the GtkTreeView, by using a
373 TnyMergeFolder in a ModestTnySimpleFolderStore.
376 * src/modest-tny-simple-folder-store.c:
377 * src/modest-tny-simple-folder-store.h:
378 Added ModestTnySimpleFolderStore, used to contain folders from
379 other folder stores, such as other accounts.
381 * src/modest-tny-outbox-account.h:
382 * src/modest-tny-outbox-account.c:
383 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
384 used for the per-account local outbox folders.
386 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
387 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
388 only use this (internally) now for the non-outbox local folders.
391 * src/modest-init.c: Added modest_init_one_local_folder(), for
392 setting up the directory structure for each local folder.
394 * src/modest-local-folder-info.c:
395 (modest_per_account_local_outbox_folder_info_get_maildir_path),
396 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
398 * src/modest-local-folder-info.h:
399 * src/modest-tny-account-store.c: (on_account_removed),
400 (on_account_changed), (create_per_account_local_outbox_folders),
401 (get_server_accounts), (modest_tny_account_store_get_accounts),
402 (modest_tny_account_store_get_tny_account_by_account),
403 (modest_tny_folder_store_is_virtual_local_folders):
405 * src/modest-tny-account.h:
406 * src/modest-tny-account.c:
407 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
408 to create an on-disk per-account local outbox folder for each
410 (create_per_account_local_outbox_folders): Create a local outbox folder
411 for each transport account.
412 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
413 for all local folders.
415 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
416 instead of using g_object_get/set() directly. It is clearer.
418 (modest_tny_folder_store_get_message_count),
419 (modest_tny_folder_store_get_local_size
420 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
421 because we now use these with non-acount folder stores.
423 (modest_tny_account_get_special_folder),
424 (modest_tny_account_new_from_server_account),
425 (modest_tny_account_new_from_account):
426 (recurse_folders): Adjust to the new outbox system.
428 * src/modest-tny-folder.h:
429 * src/modest-tny-folder.c:
430 (modest_tny_folder_is_local_folder),
431 (modest_tny_folder_get_local_folder_type),
432 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
434 * src/widgets/modest-main-window.h:
435 * src/maemo/modest-main-window.c: (create_details_widget),
436 (modest_main_window_set_contents_style): Show details for any folder store,
439 (modest_tny_folder_get_rules):
440 Remove the const. C does not support constness enough for this.
442 * src/modest-ui-actions.c:
443 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
444 make all outboxes appear as one, in the usual local-folders tree node.
446 (set_active_account_from_tny_account),
447 (modest_ui_actions_on_folder_selection_changed):
448 * src/widgets/modest-folder-view.c: (text_cell_data),
449 (icon_cell_data), (filter_row),
450 (add_account_folders_to_merged_folder),
451 (add_account_folders_to_simple_folder_store), (),
452 (get_cmp_rows_type_pos), (cmp_rows),
453 (modest_folder_view_set_account_id_of_visible_server_account):
454 Adjust to the new outbox system, using generic folder stores and folders
457 2007-05-23 Christian Kellner <ckellner@openismus.com>
459 * src/modest-mail-operation.c:
460 (modest_mail_operation_update_account):
461 Use info->max_size instead of unintialized local var [small
462 build fix]. (Added TODO to review that change since I don't
465 2007-05-23 Marcus Bauer <marcusb@openismus.com>
467 * libmodest-dbus-client/libmodest-dbus-client.c:
468 (libmodest_dbus_client_compose_mail): function added
469 * src/dbus_api/modest-dbus-api.h:
470 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
471 (on_compose_mail): Implementation of the SendAsMail functionality
473 2007-05-22 Murray Cumming <murrayc@murrayc.com>
475 * src/modest-account-mgr.c:
476 (modest_account_mgr_add_server_account): Set the secure-connection
477 conf key for transport accounts as well as store accounts. I don't know
478 why the if was there. For instance, this makes sure that we use SSL
479 for the gmail preset from the easysetup wizard.
481 2007-05-22 Murray Cumming <murrayc@murrayc.com>
483 * src/gnome/modest-main-window.c:
484 (on_account_store_connecting_finished), (connect_signals):
485 * src/maemo/modest-main-window.c:
486 (on_account_store_connecting_finished), (connect_signals),
487 (modest_main_window_new):
488 Handle TnyAccountStore::connecting-finished instead of
489 TnyDevice::connection-changed, because we cannot actually perform
490 operations on accounts until TnyAccountStore has itself responded to
491 the TnyDevice::connection-changed signal. This prevents a GError from
493 Do not try to update at startup, because we (at least on scratchbox)
494 already do an update at startup when the device goes online.
495 This prevents a GError from tinymail.
496 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
497 Added TODO about stopping simultaneous operations.
499 2007-05-21 Murray Cumming <murrayc@murrayc.com>
501 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
502 * src/modest-mail-operation-queue.c:
503 (modest_mail_operation_queue_remove):
504 * src/modest-tny-account-store.c: When GErrors happen, give more clues
505 about where they happened.
507 2007-05-21 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-ui-actions.c:
510 (modest_ui_actions_on_password_requested): Make sure that the remember
511 output parameter is always TRUE.
513 2007-05-21 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
516 Show a OK/Cancel dialog if the error is a question, though we still do not
517 know anything more about what we are asking the user.
518 * src/widgets/modest-folder-view.c: (on_drag_data_received):
519 Fix an uninitialized variable (helper). This is a logic error, however.
521 2007-05-21 Christian Kellner <ckellner@openismus.com>
523 * src/modest-search.h:
524 Correct bit shifting in the ModestSearchFlags enum.
526 2007-05-21 Murray Cumming <murrayc@murrayc.com>
528 * src/modest-tny-account.c:
529 (modest_tny_account_new_from_server_account): Do not use the lsub and
530 check-all hard-coded IMAP options when using POP.
532 2007-05-21 Murray Cumming <murrayc@murrayc.com>
534 * src/modest-tny-account.c:
535 (modest_tny_account_new_from_server_account):
536 Use NULL for the secure-auth method for POP when Password auth has been
537 specified by the user, as we already do for IMAP. "auth=Login" causes
538 an error from camel or the server.
540 2007-05-17 Murray Cumming <murrayc@murrayc.com>
542 * src/maemo/modest-account-settings-dialog.c:
543 (create_page_account_details),
544 (modest_account_settings_dialog_set_account_name):
545 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
546 for the leave-on-server checkbox, rathr than just the checkbox, when
547 the protocol is not POP.
549 2007-05-17 Murray Cumming <murrayc@murrayc.com>
551 * src/widgets/modest-account-view.c:
552 * src/widgets/modest-account-view.h:
553 Added modest_account_view_select_account() which will be useful later
554 to asynchronously re-select the edited account.
556 2007-05-17 Murray Cumming <murrayc@murrayc.com>
558 * src/maemo/modest-account-settings-dialog.c:
559 (modest_account_settings_dialog_set_account_name):
560 Automatically choose the port numbers based on the secure authentication
561 methods, if they have not been chosen before.
562 This fixes projects.maemo.org bug NB#56273 .
564 2007-05-17 Murray Cumming <murrayc@murrayc.com>
566 * src/maemo/modest-main-window-ui.h:
567 * src/modest-ui-actions.c:
568 * src/modest-ui-actions.h:
569 Connect the Tools/SMTP Servers menu item to
570 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
571 SMTP servers dialog, as in the UI specification and saves changes when it
572 is closed. This fixed projects.maemo.org bug NB#56305 .
574 2007-05-17 Murray Cumming <murrayc@murrayc.com>
576 * src/maemo/modest-connection-specific-smtp-window.c:
577 (modest_connection_specific_smtp_window_init):
578 Use gtk_window_set_default_size() to make this window big enough, so
579 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
581 2007-05-17 Murray Cumming <murrayc@murrayc.com>
583 * src/maemo/modest-connection-specific-smtp-edit-window.h:
584 * src/maemo/modest-connection-specific-smtp-edit-window.c:
585 (modest_connection_specific_smtp_edit_window_init),
586 Do not try to connect to a combobox signal before the combobox exists.
587 This fixes the cras in projects.maemo.org bug NB#56288 .
588 (modest_connection_specific_smtp_edit_window_get_settings):
589 Remove the server_account_name parameter which was being checked for NULL
590 though it was not used.
592 * src/maemo/modest-connection-specific-smtp-window.c:
593 (modest_connection_specific_smtp_window_fill_with_connections),
594 (on_button_edit), (modest_connection_specific_smtp_window_init):
595 Correct the number of treemodel columns to prevent a warning.
596 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
597 libconic does not work.
599 2007-05-16 Murray Cumming <murrayc@murrayc.com>
601 * src/modest-tny-account.c:
602 (modest_tny_account_new_from_server_account):
603 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
604 SMTP when "None" was chosen by the user. However, with my SMTP server that
605 does not support ANONYMOUS, the emails do not leave the Outbox and I see
608 2007-05-16 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
611 to explain the memory management issue with the ID in the ModestPair.
613 * src/gnome/modest-account-assistant.c: (add_receiving_page),
614 (add_sending_page), (modest_account_assistant_finalize):
615 * src/gnome/modest-gnome-global-settings-dialog.c:
616 (create_updating_page), (create_composing_page):
617 * src/gnome/modest-msg-edit-window.c: (get_transports),
618 (init_window), (modest_msg_edit_window_finalize),
619 (modest_msg_edit_window_get_msg_data):
620 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
621 * src/gnome/modest-transport-widget.c:
622 (modest_transport_widget_finalize), (smtp_configuration):
623 * src/maemo/modest-maemo-global-settings-dialog.c:
624 (create_updating_page), (create_composing_page):
625 * src/maemo/modest-msg-edit-window.c: (get_transports),
626 (init_window), (modest_msg_edit_window_finalize),
627 (modest_msg_edit_window_get_msg_data),
628 (modest_msg_edit_window_free_msg_data):
629 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
630 (modest_store_widget_finalize):
631 * src/maemo/modest-transport-widget.c:
632 (modest_transport_widget_finalize), (smtp_configuration):
633 * src/modest-main.c: (send_mail):
634 * src/widgets/modest-combo-box.h:
635 * src/widgets/modest-global-settings-dialog-priv.h:
636 * src/widgets/modest-global-settings-dialog.c:
637 (modest_global_settings_dialog_finalize):
638 * src/widgets/modest-msg-edit-window.h:
639 Whenever using modest_combo_box_new(), keep the ModestPairList alive
640 as long as the combo box, to prevent use of freed memory for the ID.
642 2007-05-15 Murray Cumming <murrayc@murrayc.com>
644 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
645 get_accounts(), to make this clearer. Do not check for the enabled gconf
646 key, because we do not use this for server accounts (at least, not yet).
647 This allows us to send email again.
649 2007-05-15 Murray Cumming <murrayc@murrayc.com>
651 * src/maemo/modest-platform.c:
652 (on_modest_conf_update_interval_changed), (modest_platform_init):
653 Only respond to this particular key change. All these strcmp()s cannot be
656 2007-05-15 Murray Cumming <murrayc@murrayc.com>
658 * src/maemo/modest-maemo-global-settings-dialog.c:
659 (current_connection): Prevent a crash in scratchbox when
660 ny_maemo_conic_device_get_current_iap_id() returns NULL.
661 * src/maemo/modest-platform.c:
662 (on_modest_conf_update_interval_changed), (modest_platform_init):
663 Get the update interval from gconf and reset it when the gconf key changes.
665 2007-05-15 Murray Cumming <murrayc@murrayc.com>
667 * src/modest-protocol-info.c:
668 * src/modest-protocol-info.h: Adde enum-specific get functions,
669 instead of using a ModestProtocolType enum parameter.
671 * src/gnome/modest-account-assistant.c:
672 * src/gnome/modest-store-widget.c:
673 * src/gnome/modest-store-widget.h:
674 * src/gnome/modest-transport-widget.c:
675 * src/gnome/modest-transport-widget.h:
676 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
677 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
678 * src/maemo/easysetup/modest-easysetup-wizard.c:
679 * src/maemo/modest-account-settings-dialog.c:
680 * src/maemo/modest-account-settings-dialog.h:
681 * src/maemo/modest-store-widget.c:
682 * src/maemo/modest-store-widget.h:
683 * src/maemo/modest-transport-widget.c:
684 * src/maemo/modest-transport-widget.h:
685 * src/modest-account-mgr-helpers.c:
686 * src/modest-account-mgr-helpers.h:
687 * src/modest-account-mgr.c:
688 * src/modest-account-mgr.h:
689 * src/modest-tny-account.c:
690 * src/modest-tny-folder.c:
691 * src/widgets/modest-account-view.c:
692 * src/widgets/modest-retrieve-combo-box.c:
693 * src/widgets/modest-retrieve-combo-box.h:
694 * src/widgets/modest-secureauth-combo-box.c:
695 * src/widgets/modest-serversecurity-combo-box.c:
696 * src/widgets/modest-serversecurity-combo-box.h:
697 * tests/check_account-mgr.c:
698 Use the specific functions, and use the re-renamed enum values for GNOME too.
700 2007-05-15 Murray Cumming <murrayc@murrayc.com>
703 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
704 so we can get the second based on the first.
706 * src/maemo/modest-account-settings-dialog.h:
707 * src/maemo/modest-account-settings-dialog.c:
708 Added get_supported_secure_authentication_methods(), though it is mostly
709 commented-out for now until the necessary API is committed to tinymail.
710 (modest_account_settings_dialog_set_account_name),
711 (save_configuration): Request the supported authentication methods from the
712 server, so we can choose a working method.
714 * src/modest-tny-account-store.h:
715 * src/modest-tny-account-store.c:
716 (modest_tny_account_store_get_session): Rename from
717 tny_account_store_get_session().
719 2007-05-14 Murray Cumming <murrayc@murrayc.com>
721 * src/modest-protocol-info.h: Split the ModestProtocol enum
722 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
723 There was no need to have these unrelated values in one enum.
725 * src/: many files: Adapted to changed enum. This makes the code a bit
726 clearer, and the compiler could catch some errors.
728 2007-05-14 Murray Cumming <murrayc@murrayc.com>
730 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
731 Show the detailed internal camel error message when an error happens
732 during the configuration, so that our testers can give us more clues.
733 For instance, in projects.maemo.org bug NB#56910 .
735 2007-05-14 Murray Cumming <murrayc@murrayc.com>
737 * src/modest-tny-account.c:
738 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
739 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
741 2007-05-14 Murray Cumming <murrayc@murrayc.com>
743 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
744 * src/maemo/modest-account-settings-dialog.c:
745 (modest_account_settings_dialog_set_account_name),
746 (save_configuration): For the incoming secure authentication checkbox,
747 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
748 the UI specification. PLAIN does not seem to be supported for most IMAP
749 servers anyway, and I am not sure what it would mean.
750 However, we probably need to discover which of the secure-authentication
751 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
752 * src/modest-account-mgr-helpers.c:
753 (modest_account_mgr_get_server_account_data):
755 * src/modest-tny-account.c:
756 (modest_tny_account_new_from_server_account):
757 Use tny_account_set_mech() to set secure-authentication methods,
758 with some special-casing for IMAP, based on my observations of how
761 * src/modest-account-mgr-helpers.h:
762 * src/modest-account-mgr.c:
763 * src/modest-defs.h: Comment that the URI is only used for local folders.
765 2007-05-11 Murray Cumming <murrayc@murrayc.com>
767 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
768 parameter const, just to be neat.
769 * src/modest-text-utils.c: (modest_text_utils_inline):
770 End g_strconcat() with NULL, as its documentation says. This is almost
771 certainly the cause of my crash at startup on the device. Interestingly,
772 valgrind doesn't tell us about these errors.
774 2007-05-11 Murray Cumming <murrayc@murrayc.com>
776 * scripts/build-packages: Added more precise comments about how to use
777 this script, though I still get this error:
778 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
779 error building tinymail
781 2007-05-11 Murray Cumming <murrayc@murrayc.com>
783 * src/maemo/modest-main-window.c: (on_account_update):
784 Very slight cleanup, hoping to make it simpler to discover what causes
785 a crash here sometimes.
787 * src/modest-tny-account.c:
788 (modest_tny_account_new_from_server_account): Set the port. Added
789 comments about the options and a TODO comment because I need to find out
790 how to specify the secure authentication method.
792 2007-05-11 Marcus Bauer <marcusb@openismus.com>
794 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
795 changed CFlags paths form modest to libmodest
797 2007-05-10 Murray Cumming <murrayc@murrayc.com>
799 * src/modest-account-mgr-helpers.c:
800 (modest_account_mgr_get_server_account_data),
801 (modest_account_mgr_free_server_account_data):
802 * src/modest-account-mgr-helpers.h:
803 * src/modest-account-mgr.c:
804 (modest_account_mgr_add_server_account):
806 * src/modest-tny-account.c:
807 (modest_tny_account_new_from_server_account):
808 Determine the options for tny_camel_account_add_option() here,
809 based on the settings, rather than storing them directly in gconf.
811 2007-05-10 Murray Cumming <murrayc@murrayc.com>
813 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
814 Show a more friendly error dialog now that we expect (from the tinymail
815 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
817 2007-05-10 Murray Cumming <murrayc@murrayc.com>
819 * src/maemo/modest-main-window.c: (on_account_update): Check that
820 account_name is not NULL, to prevent a crash at startup that I am
821 seeing on the N800. I do wonder why it is NULL.
823 * src/maemo/easysetup/modest-easysetup-wizard.c:
824 (create_page_user_details):
825 * src/maemo/modest-account-settings-dialog.c:
826 (create_page_user_details), (create_page_outgoing):
827 * src/maemo/modest-connection-specific-smtp-edit-window.c:
828 (modest_connection_specific_smtp_edit_window_init):
829 * src/modest-ui-actions.c:
830 (modest_ui_actions_on_password_requested):
831 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
832 might do something useful with the on-screen keyboard.
834 2007-05-10 Murray Cumming <murrayc@murrayc.com>
836 * src/maemo/modest-main-window.c: (on_account_update):
837 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
838 NULL, to avoid lots of warnings. However, it probably should not be NULL.
840 2007-05-09 Murray Cumming <murrayc@murrayc.com>
842 * src/modest-tny-account-store.c: (on_account_changed):
843 Correct the signature of this signal handler.
845 2007-05-09 Murray Cumming <murrayc@murrayc.com>
847 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
848 Show a HildonNote instead of a GtkDialog for Maemo.
850 2007-05-09 Murray Cumming <murrayc@murrayc.com>
852 * src/widgets/modest-account-view.h:
853 * src/widgets/modest-account-view.c: (on_account_changed),
854 (on_account_removed). Added a boolean flag, set/unset by
855 modest_account_view_block_conf_updates(),
856 modest_account_view_unblock_conf_updates() to prevent unnecessary
857 updates, but this is not very useful because the gconf notifications are
858 so delays (maybe only on Maemo Bora).
859 So auto-updating is turned off, and these functions do an explicit
860 update when necessary.
861 However, something else is still doing too much work when adding/removing
862 accounts, probably in another part of the application.
864 * src/maemo/modest-account-view-window.c:
865 (on_delete_button_clicked), (on_edit_button_clicked),
866 (on_new_button_clicked): Use the new functions.
868 2007-05-09 Murray Cumming <murrayc@murrayc.com>
870 * src/modest-account-mgr-helpers.c:
871 (modest_account_mgr_set_first_account_as_default):
872 Sort the list of names alphabetically-by-title, so we choose the first one
874 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
875 alphabetically by the title.
877 This fixes projects.maemo.org bug NB#56418 .
879 * src/modest-account-mgr-priv.c:
880 (_modest_account_mgr_account_from_key):
881 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
882 avoid a valgrind error, and possible random behaviour.
884 2007-05-09 Murray Cumming <murrayc@murrayc.com>
886 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
887 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
888 tinymail documentation to say that this can be expected.
889 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
890 pretty, and should not happen, but I would prefer to know when it does.
892 2007-05-09 Murray Cumming <murrayc@murrayc.com>
894 * configure.ac: When using the older hildon version, probably on Bora,
895 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
897 * src/widgets/modest-attachment-view.c:
898 (modest_attachment_view_set_part_default): Initialize variables, to fix the
901 2007-05-09 Marcus Bauer <marcusb@openismus.com>
903 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
904 Implemented the prototype. Can be tested with
905 tests/dbus_api/test_open_message:
907 2007-05-08 Murray Cumming <murrayc@murrayc.com>
909 * src/modest-tny-account-store.c:
910 (modest_tny_account_store_instance_init), (get_password):
911 * src/modest-ui-actions.c:
912 (modest_ui_actions_on_password_requested):
913 Do not store the password in gconf, because this function is called
914 for non-remembered passwords. Actually use the cached (in the hash map)
915 password instead of releasing it.
916 The password will now not be remembered if it is asked via the protected
917 password dialog, as per the UI spec.
919 2007-05-08 Murray Cumming <murrayc@murrayc.com>
922 * src/modest-account-mgr-helpers.h:
923 * src/modest-account-mgr-helpers.c:
924 Added modest_server_account_get_username_has_succeeded(),
925 modest_server_account_set_username_has_succeeded().
926 (modest_server_account_set_username),
927 Reset the has-succeeded flag if the username changes.
929 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
930 * src/maemo/modest-connection-specific-smtp-window.c:
931 (modest_connection_specific_smtp_window_save_server_accounts):
932 Use modest_server_account_set_username() instead of using
933 modest_conf_set_string() directly, so that the has-succeeded flag is always
936 * src/modest-ui-actions.c:
937 (modest_ui_actions_on_password_requested): Dim the username entry if
938 the username has ever worked, as per the UI spec.
940 2007-05-08 Murray Cumming <murrayc@murrayc.com>
942 * src/modest-tny-account-store.c: (get_password):
943 * src/modest-ui-actions.c:
944 (modest_ui_actions_on_password_requested):
945 Allow the username to be changed too, though there is more work to
946 be done on exactly how this behaves.
948 2007-05-08 Murray Cumming <murrayc@murrayc.com>
950 * src/modest-account-mgr-helpers.h:
951 * src/modest-account-mgr-helpers.c:
952 Added modest_account_mgr_get_display_name(),
953 modest_server_account_get_username(),
954 modest_server_account_set_username(),
955 modest_server_account_set_password(),
956 modest_server_account_get_hostname() functions so we do not need to
957 use the conf API directly.
959 * src/maemo/modest-main-window.c: (connect_signals):
960 Actually connect ot the ModestAccountStore::request-password signal,
961 so that we show the dialog when the password is requested by Tinymail,
962 for isntance if it is empty.
964 * src/modest-marshal.list:
965 * src/modest-tny-account-store.c:
966 (modest_tny_account_store_class_init), (get_password),
967 (modest_tny_account_store_alert):
968 * src/modest-tny-account-store.h:
969 * src/modest-ui-actions.h:
970 * src/modest-ui-actions.c:
971 (modest_ui_actions_on_password_requested):
972 Change the signal parameters, so it is obvious that we are providing
973 the non human-readable server name, and receiving both the username
974 and password, though changing of the username is not yet implemented.
975 Change the dialog UI to match the Maemo UI specifications, with #idfefing
976 for the GNOME version.
978 This should fix the projects.maemo.org bug NB#56209, though it does not
979 work on Bora, because the gconf_client_get() for the password fails
980 immediately after we save it with gconf_client_set().
982 2007-05-08 Murray Cumming <murrayc@murrayc.com>
985 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
986 caused an undefined symbol error:
987 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
989 2007-05-08 Murray Cumming <murrayc@murrayc.com>
991 * src/modest-tny-account-store.c:
992 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
993 using a GError instead of a string message, so we can translate it in
996 2007-05-08 Murray Cumming <murrayc@murrayc.com>
998 * src/maemo/modest-address-book.c:
999 (modest_address_book_check_names):
1000 * src/maemo/modest-msg-view-window.c:
1001 (modest_msg_view_window_clipboard_owner_change):
1002 * src/modest-init.c: (modest_init_init_ui):
1003 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1004 (update_folders_cb), (modest_mail_operation_update_account):
1005 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1006 (modest_ui_actions_on_msg_attachment_clicked),
1007 (modest_ui_actions_on_msg_recpt_activated):
1008 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1009 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1010 (modest_msg_view_search_next):
1011 * src/widgets/modest-recpt-editor.c:
1012 (modest_recpt_editor_on_button_release_event),
1013 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1014 g_message(). At this point we should only be seeing interesting errors on
1015 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1017 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1019 (modest_wizard_dialog_force_title_update):
1020 * src/maemo/easysetup/modest-wizard-dialog.h:
1021 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1022 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1023 can update the title when appropriate. Otherwise the title is wrong if the
1024 pages are added after adding the notebook to the dialog.
1025 This must be a problem in HildonWizardDialog too.
1026 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1028 * src/maemo/easysetup/modest-easysetup-wizard.c:
1029 (create_subsequent_customsetup_pages),
1030 (create_subsequent_easysetup_pages):
1031 Call modest_wizard_dialog_force_title_update() so that the title is
1032 correct even with GTK+ < 2.10.
1033 This fixes projects.maemo.org bug NB#56145 .
1035 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1037 * src/maemo/modest-platform.c:
1038 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1039 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1042 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1044 * src/widgets/modest-window.h:
1045 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1046 and modest_window_save_state(), which invokes it.
1048 * src/widgets/modest-window-mgr.h:
1049 * src/widgets/modest-window-mgr.c:
1050 Added modest_window_mgr_save_state_for_all_windows(), which calls
1051 the save_state vfunc on all registered windows, if implemented.
1053 * src/gnome/modest-msg-edit-window.c:
1054 * src/gnome/modest-msg-view-window.c:
1055 * src/maemo/modest-msg-edit-window.c:
1056 * src/maemo/modest-msg-view-window.c:
1057 * src/maemo/modest-main-window.c:
1058 Specify the existing save_settings functions as implementations of
1059 ModestWindow::save_state_func().
1061 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1062 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1063 enabling hibernation, for instance.
1065 We may need to do the same thing for restoring settings.
1068 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1070 * src/widgets/modest-window-mgr.c:
1071 * src/widgets/modest-window-mgr.h:
1072 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1073 modest_window_mgr_get_hibernation_is_prevented().
1075 * src/maemo/modest-main-window.c:
1076 (on_hildon_program_is_topmost_notify): Prevent hibernation
1077 (possible when the application goes to the background in the WM),
1078 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1080 * src/maemo/easysetup/modest-easysetup-wizard.c:
1081 (modest_easysetup_wizard_dialog_init):
1082 * src/maemo/modest-account-settings-dialog.c:
1083 (modest_account_settings_dialog_init):
1084 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1085 (modest_connection_specific_smtp_edit_window_init):
1086 * src/maemo/modest-connection-specific-smtp-window.c:
1087 (modest_connection_specific_smtp_window_init):
1088 * src/maemo/modest-signature-editor-dialog.c:
1089 (modest_signature_editor_dialog_init):
1090 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1091 prevent hibernation while any of these account settings dialogs are open.
1093 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1095 * src/maemo/Makefile.am:
1096 * src/maemo/modest-osso-state-saving.c:
1097 * src/maemo/modest-osso-state-saving.h: Added
1098 modest_osso_load_state() and modest_osso_save_state() though they do
1099 nothing now. They should iterate through all the open windows and load/save
1101 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1102 save state when closing.
1104 * src/maemo/modest-main-window.c:
1105 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1106 Add a notification handler for the HildonProgram::is-topmost property,
1107 so we can allow hibernation when the application goes into the background.
1108 But we still need to detect when the accounts setup windows are open so
1109 we can stop hibernation when they are open.
1110 To do this, I also added the main window the HildonProgram. This might have
1111 other side-effects/benefits, and should maybe be done for other windows.
1113 * src/maemo/modest-osso-autosave-callbacks.h:
1114 * src/maemo/modest-osso-autosave-callbacks.c:
1115 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1116 though it does not do anything yet, and we might never need this to do
1117 anything. For instance, we already save drafts.
1119 * src/maemo/modest-platform.c: (modest_platform_init):
1120 Specify the libosso auto-save callback.
1122 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1124 * src/maemo/modest-platform.c:
1125 (modest_platform_set_update_interval):
1126 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1127 aparently stays valid between application instances, so we can use this
1128 to remove and reset it later. According to a maemo-developers email from
1131 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1133 * configure.ac: Depend on libalarm for Maemo.
1135 * src/dbus_api/modest-dbus-api.h:
1136 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1137 (on_send_receive), (modest_dbus_req_handler):
1138 Handle a SEND_RECEIVE D-Bus method.
1140 * libmodest-dbus-client/libmodest-dbus-client.c:
1141 (libmodest_dbus_client_send_and_receive):
1142 * libmodest-dbus-client/libmodest-dbus-client.h:
1143 Add C convenience functions for calling the new D-Bus method.
1145 * src/modest-platform.h:
1146 * src/gnome/modest-platform.c:
1147 * src/maemo/modest-platform.c:
1148 Added modest_platform_set_update_interval(), which uses the
1149 alarmd API on Maemo.
1150 (modest_platform_init),
1151 Call modest_platform_set_update_interval(), using a hard-coded
1152 interval for now (until the global settings dialog is implemented),
1153 though I am not sure that this makes sense yet.
1155 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1157 * src/dbus_api/modest-dbus-callbacks.c:
1158 (modest_osso_cb_hw_state_handler):
1159 * src/dbus_api/modest-dbus-callbacks.h:
1160 * src/maemo/modest-platform.c: (modest_platform_init):
1161 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1162 in case this has some effect on the ability for Maemo to ping the
1165 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1167 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1168 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1169 warning. It is probably a logic error, but I need to fix the build.
1171 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1173 * src/modest-account-mgr.h:
1174 * src/modest-account-mgr.c:
1175 (modest_account_mgr_account_names): Add a gboolean enabled_only
1176 parameter, so we can get lists of onlt the enabled accounts.
1178 (modest_account_mgr_add_account),,
1179 (modest_account_mgr_account_with_display_name_exists):
1180 * src/maemo/modest-msg-edit-window.c: (get_transports):
1181 * src/modest-account-mgr-helpers.c:
1182 (modest_account_mgr_set_first_account_as_default):
1183 * src/modest-init.c: (init_default_account_maybe):
1184 * src/modest-tny-account-store.c: (get_accounts):
1185 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1186 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1187 * tests/check_account-mgr.c: (START_TEST):
1188 Provide the extra parameter, as appropriate.
1190 * src/widgets/modest-account-view.c: (update_account_view):
1191 Do not show disabled accounts (meaning that there is no way to
1192 enable/disable accounts in the UI (the feature is not in our UI
1193 specification), so we can use this internally only to mark unfinished
1194 or temporary account data.
1196 * src/maemo/easysetup/modest-easysetup-wizard.c:
1197 (create_account): Add boolean enable parameter, so we can specify FALSE
1198 to create the temporary account.
1199 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1200 (on_before_next): When finishing, when there is a temporary account, just
1202 Also, use a timeout to delay the showing of the dialog until gconf is likely
1203 to return correct information, due to a maemo gconf bug that is fixed in
1204 osso 1.1, but not yet in Bora.
1205 However, the dialog stays on screen after it is destroyed.
1207 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1208 for invalid data when cancelling. Use a hildon note instead of a dialog
1209 to complain about invalid data. Do not show the account-saved note if the
1210 account is disabled (a temporary account that will not really be saved for use
1213 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1215 * src/modest-account-mgr-helpers.h:
1216 * src/modest-account-mgr-helpers.c:
1217 Added modest_account_mgr_unset_default_account(),
1218 Added modest_account_mgr_set_first_account_as_default().
1220 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1221 If it was the default account, unset the default account name.
1223 * src/maemo/modest-account-view-window.c:
1224 (on_delete_button_clicked): If it was the default account,
1225 set the first remaining account as the default instead.
1227 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1228 a NULL account or a NULL default account, to prevent a crash. This should
1229 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1232 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1234 * src/widgets/modest-recpt-editor.c:
1235 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1236 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1237 TODO comment for this. This fixes the build.
1239 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1240 be the best place for it. This will in future update all auto-update accounts,
1241 rather than just the current/default account, when that gconf key exists.
1242 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1243 if there are no accounts, before calling do_send_receive().
1244 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1246 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1247 * src/maemo/modest-main-window-ui.h:
1248 * src/maemo/modest-main-window.c: (on_connection_changed),
1249 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1250 directly, becaue the signal handler does more.
1252 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1254 * src/modest-account-mgr-helpers.c:
1255 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1256 for the case that the account does not exist.
1258 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1259 (equivalent to the modest account name) rather than the tinymail account name
1260 (equivalent to the modest account title - human readable) to get the account data.
1261 Check for null account data to prevent the crash, and add a TODO comment saying that
1262 this needs fixing because it is using the server account name instead of the account name.
1264 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1266 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1267 * src/maemo/modest-account-settings-dialog.c: (show_error),
1269 Use hildon_note_new_information() for informative and error messages,
1270 which seems to be expected for Maemo applications (no documentation that I know of
1271 says this). I am surprised that there is no distinction between info and error
1274 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1276 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1277 it is easy to find where this is used.
1279 * src/maemo/easysetup/modest-easysetup-wizard.c:
1280 (create_page_welcome), (create_page_account_details),
1281 (create_page_user_details), (create_page_complete_easysetup),
1282 (create_page_custom_incoming), (create_page_custom_outgoing),
1283 (create_page_complete_custom):
1284 * src/maemo/modest-account-settings-dialog.c:
1285 (create_page_account_details), (create_page_user_details),
1286 (create_page_incoming), (create_page_outgoing):
1287 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1288 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1289 (modest_connection_specific_smtp_edit_window_init):
1290 * src/maemo/modest-connection-specific-smtp-window.c:
1291 (modest_connection_specific_smtp_window_init):
1292 * src/maemo/modest-signature-editor-dialog.c:
1293 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1294 and scrolling policy as per the Email Application Layout Guide, if I have
1297 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1299 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1300 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1301 which were empty, because these vfuncs have been removed from TnyAccountStore.
1302 This fixes the build.
1304 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1306 * src/maemo/modest-main-window.c:
1307 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1308 showing/hiding it. Added TODO because it probably should not be NULL.
1309 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1310 because unnecessary g_warnings() make degugging difficult.
1312 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1314 * src/maemo/modest-msg-edit-window.c:
1315 (modest_msg_edit_window_select_color),
1316 (modest_msg_edit_window_select_background_color): 2 const corrections and
1317 moving 2 #endifs before closing brackets, to fix the build.
1319 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1321 * src/maemo/easysetup/modest-easysetup-wizard.h:
1322 * src/maemo/easysetup/modest-easysetup-wizard.c:
1323 (modest_easysetup_wizard_dialog_finalize),
1324 (on_button_edit_advanced_settings), (create_page_complete_custom),
1325 (on_response), (create_account):
1326 Implement the Advanced Settings edit button, by saving the account information,
1327 for the Advanded Settings dialog to use directly from gconf, and removing it
1328 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1329 Bug #5533 in the projects.maemo.org bugzilla.
1331 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1333 * src/maemo/modest-msg-view-window.c:
1334 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1335 when opening a message window.
1337 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1339 * src/maemo/easysetup/modest-easysetup-wizard.c:
1340 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1343 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1344 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1345 gconf settings. I probably added more checks than necessary, but that is safer.
1347 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1348 variable to fix the build, but this seems to be used when it is still NULL.
1350 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1352 * src/modest-platform.h:
1353 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1354 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1355 * src/modest-main.c: Implement this function so we can avoid using
1356 maemo-specific API from cross-platform code.
1358 * src/modest-tny-account-store.c:
1359 (get_smtp_specific_transport_account_for_open_connection):
1360 * src/modest-ui-actions.c: (check_for_connection),
1361 (modest_ui_actions_on_item_not_found):
1362 Use modest_platform_connect_and_wait() and put #idefs around other
1363 maemo-specific code, because only maemo currently has a way to
1364 identify connection names.
1366 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1368 * src/modest-tny-account-store.h:
1369 * src/modest-tny-account-store.c:
1370 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1371 the connection-specific SMTP server settings in the configuration.
1373 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1375 * src/maemo/modest-main-window.c: (on_connection_changed),
1377 * src/modest-main.c: (main), (start_ui), (send_mail):
1378 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1379 that is what is intended.
1381 * src/modest-ui-actions.c: (action_send), (action_receive),
1382 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1383 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1384 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1385 SMTP server is used when it is specified.
1387 (modest_ui_actions_on_send_receive):
1388 Check that a connection is open before proceeding.
1389 Receive and then send, instead of vice-versa, as per the specification.
1391 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1393 * src/modest-mail-operation.c:
1394 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1395 though I guess it should be something other than NULL.
1397 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1399 * src/maemo/easysetup/modest-easysetup-wizard.c:
1400 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1401 combo twice, to avoid an g_warning and to make it visible again.
1402 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1403 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1404 (already intended) dereference when detaching, because we then recreate the menu.
1405 But I am not sure why the warning was happening, and it is possible that this is a memory
1408 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1410 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1411 and uri_parse_mailto() utility functions.
1412 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1414 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1416 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1418 * src/dbus_api/modest-dbus-api.h:
1419 * src/dbus_api/modest-dbus-callbacks.c:
1420 Use an idle callback to execute the modest code in the application's own thread.
1421 Remove the helloworld example method.
1422 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1423 parsed, and the open-message method is not implemented because this is not yet implemented in
1425 * libmodest-dbus-client/libmodest-dbus-client.c:
1426 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1427 (libmodest_dbus_client_open_message):
1428 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1430 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1431 body without crashing.
1433 * tests/dbus_api/Makefile.am:
1434 * tests/dbus_api/test_mail_to.c:
1435 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1437 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1439 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1440 Added file to fix the build. Sorry.
1442 * src/dbus_api/Makefile.am:
1443 * src/dbus_api/modest-dbus-api.h:
1444 * src/dbus_api/modest-dbus-callbacks.h:
1445 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1446 (modest_dbus_req_handler):
1447 Put constants in a separate header so it can be reused by the
1448 client library, without duplication
1450 * libmodest-dbus-client/Makefile.am:
1451 * libmodest-dbus-client/libmodest-dbus-client.c:
1452 (libmodest_dbus_client_call_helloworld),
1453 (libmodfest_dbus_client_send_mail),
1454 (libmodfest_dbus_client_mailto),
1455 (libmodfest_dbus_client_open_message):
1456 * libmodest-dbus-client/libmodest-dbus-client.h:
1457 (Partly) Implement a send_mail D-Bus method.
1459 * tests/dbus_api/Makefile.am:
1460 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1461 the send_email D-Bus method.
1463 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1467 * libmodest-dbus-client/Makefile.am:
1468 * libmodest-dbus-client/libmodest-dbus-client.c:
1469 * libmodest-dbus-client/libmodest-dbus-client.h:
1470 * tests/dbus_api/Makefile.am:
1471 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1472 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1474 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1476 * src/maemo/easysetup/modest-easysetup-wizard.c:
1477 (create_page_account_details):
1478 * src/maemo/modest-account-settings-dialog.c:
1479 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1480 widgets, because this might not be the default in future versions of the Maemo GTK+.
1481 However, I can not not get capitalization to work even in a simple test case.
1483 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1485 * src/maemo/easysetup/modest-easysetup-wizard.c:
1486 (create_page_custom_incoming), (create_page_custom_outgoing):
1487 * src/maemo/modest-account-settings-dialog.c:
1488 (create_page_account_details), (create_page_incoming),
1489 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1490 instead of using gtk_check_button_with_label(), so they are aligned like the other
1491 widgets, as per the UI spec.
1493 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1495 * src/maemo/easysetup/modest-easysetup-wizard.c:
1496 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1497 * src/widgets/modest-validating-entry.c:
1498 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1499 Modest prefix instead of an EasySetup prefix.
1501 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1503 * src/widgets/modest-validating-entry.h:
1504 * src/widgets/modest-validating-entry.c: (on_insert_text),
1505 Added easysetup_validating_entry_set_max_func(), used to set a callback
1506 to call when the max number of characters is reached. GtkEntry has a max-length
1507 already but is silent about it.
1509 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1510 (create_page_account_details), (create_page_user_details),
1512 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1513 (create_page_account_details), (create_page_user_details),
1514 (create_page_outgoing):
1515 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1516 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1517 the UI spec, when the user tries to enter more than the max number of characters.
1519 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1521 * src/maemo/easysetup/modest-easysetup-wizard.c:
1522 (create_page_user_details), (create_page_custom_incoming),
1523 (create_page_custom_outgoing):
1524 * src/maemo/modest-account-settings-dialog.c:
1525 (create_page_user_details), (create_page_incoming),
1526 (create_page_outgoing):
1527 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1528 (modest_connection_specific_smtp_edit_window_init):
1529 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1530 not appropriate. Bad Maemo-specific defaults!.
1532 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1534 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1535 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1536 (modest_signature_editor_dialog_set_settings):
1537 Disable the label and textview when the checkbox is disabled, and use the
1538 specified (UI spec) default signature text.
1540 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1542 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1543 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1545 * src/modest-defs.h:
1546 * src/modest-account-mgr-helpers.h:
1547 * src/modest-account-mgr-helpers.c:
1548 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1550 * src/maemo/Makefile.am:
1551 * src/maemo/modest-signature-editor-dialog.c:
1552 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1555 * src/maemo/modest-account-settings-dialog.h:
1556 * src/maemo/modest-account-settings-dialog.c:
1557 (modest_account_settings_dialog_finalize), (on_button_signature),
1558 (save_configuration): Use the new dialog when the Edit button is pressed, and
1559 save the changes if necessary, as per the UI spec.
1561 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1563 * src/maemo/Makefile.am:
1564 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1565 based on maemo-develoers email from Dirk.
1567 * src/maemo/easysetup/modest-easysetup-wizard.c:
1568 (create_page_welcome), (create_page_account_details),
1569 (create_page_user_details), (create_page_complete_easysetup),
1570 (create_page_custom_incoming), (create_page_custom_outgoing),
1571 (create_page_complete_custom),
1572 (modest_easysetup_wizard_dialog_init):
1573 * src/maemo/modest-account-settings-dialog.c:
1574 (create_page_account_details), (create_page_user_details),
1575 (create_page_incoming), (create_page_outgoing),
1576 (modest_account_settings_dialog_init):
1577 * src/maemo/modest-connection-specific-smtp-window.c:
1578 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1580 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1582 * src/maemo/easysetup/modest-easysetup-wizard.c:
1583 (create_page_account_details), (create_page_custom_outgoing),
1584 (create_page_complete_custom):
1585 * src/maemo/modest-account-settings-dialog.c:
1586 (create_page_user_details), (create_page_incoming),
1587 (create_page_outgoing):
1588 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1589 (modest_connection_specific_smtp_edit_window_init):
1590 Use the correct (UI spec) port min/max, and use horizontal separators,
1593 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1595 * src/maemo/easysetup/modest-easysetup-wizard.c:
1596 (set_default_custom_servernames):
1597 * src/maemo/modest-account-settings-dialog.c:
1598 (create_page_incoming), (on_combo_outgoing_security_changed),
1599 (on_combo_incoming_security_changed), (create_page_outgoing),
1600 (modest_account_settings_dialog_set_account_name),
1601 (save_configuration):
1602 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1603 (on_combo_security_changed),
1604 (modest_connection_specific_smtp_edit_window_init),
1605 (modest_connection_specific_smtp_edit_window_set_connection),
1606 (modest_connection_specific_smtp_edit_window_get_settings):
1607 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1610 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1613 * src/maemo/easysetup/modest-easysetup-wizard.c:
1614 (create_page_custom_outgoing), (create_page_complete_custom):
1615 * src/maemo/modest-account-settings-dialog.c:
1616 (create_page_user_details), (create_page_outgoing):
1617 * src/maemo/modest-account-view-window.c: (button_box_new):
1618 Use changed logical IDs as per the most recent UI spec:
1619 mcen_bd_emailsetup_edit -> mcen_bd_edit
1620 mcen_bd_emailsetup_delete -> mcen_bd_delete
1621 mcen_bd_emailsetup_close -> mcen_bd_close
1623 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1627 * src/dbus_api/Makefile.am:
1628 * src/dbus_api/modest-dbus-callbacks.c:
1629 * src/dbus_api/modest-dbus-callbacks.h:
1630 * src/maemo/modest-platform.c: (modest_platform_init):
1631 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1633 * tests/Makefile.am:
1634 * tests/dbus_api/Makefile.am:
1635 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1637 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1639 * src/maemo/modest-account-settings-dialog.c:
1640 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1641 Removed unnecessary includes.
1643 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1645 * src/maemo/easysetup/modest-easysetup-wizard.c:
1646 * src/maemo/modest-account-settings-dialog.c:
1647 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1648 * src/widgets/Makefile.am:
1649 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1650 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1651 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1652 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1653 * src/widgets/modest-secureauth-combo-box.c:
1654 * src/widgets/modest-secureauth-combo-box.h:
1655 * src/widgets/modest-serversecurity-combo-box.c:
1656 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1657 made the GObject names more consistent with the rest of the Modest code.
1659 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1661 * src/maemo/easysetup/Makefile.am:
1662 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1663 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1664 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1665 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1666 * src/maemo/easysetup/modest-easysetup-wizard.c:
1667 * src/maemo/easysetup/modest-validating-entry.c:
1668 * src/maemo/easysetup/modest-validating-entry.h:
1669 * src/maemo/modest-account-settings-dialog.c:
1670 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1671 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1672 widgets/ because they are used outside of easysetup too. After checking in,
1673 svn will allow me to rename them too.
1675 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1677 * src/gnome/modest-msg-edit-window.c:
1678 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1679 linker error, to fix the build on the GNOME platform.
1680 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1681 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1682 ifdefed out to avoid a warning.
1684 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1686 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1687 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1688 some alternative for GTK+ 2.6.
1690 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1692 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1694 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1695 specified for EmailAccountsDialog in UI spec.
1697 * src/maemo/easysetup/modest-easysetup-wizard.c:
1698 * src/maemo/easysetup/modest-easysetup-wizard.h:
1699 * src/maemo/modest-account-settings-dialog.c:
1700 * src/maemo/modest-account-settings-dialog.h:
1701 Reuse a member window widget for the connection-specific SMTP server accounts,
1702 so we can tell it to create/save the accounts only if we actually save changes.
1704 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1705 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1706 (modest_connection_specific_smtp_edit_window_get_settings):
1707 Return a struct instance for temporarily remembering the entered data.
1709 * src/maemo/modest-connection-specific-smtp-window.h:
1710 * src/maemo/modest-connection-specific-smtp-window.c:
1711 (modest_connection_specific_smtp_window_finalize),
1712 (modest_connection_specific_smtp_window_fill_with_connections),
1714 (modest_connection_specific_smtp_window_save_server_accounts),
1715 (update_model_server_names): Do not actually save data until asked,
1716 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1718 (on_selection_changed),
1719 (modest_connection_specific_smtp_window_init): Disable the edit
1720 button when nothing is selected.
1722 * src/modest-account-mgr-helpers.c:
1723 * src/modest-account-mgr-helpers.h:
1724 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1727 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1729 * src/modest-account-mgr-helpers.h:
1730 * src/modest-account-mgr-helpers.c:
1731 (modest_account_mgr_get_unused_account_name),
1732 (modest_account_mgr_get_unused_account_display_name): Added these
1733 utility functions, to avoid code duplication.
1735 * src/maemo/easysetup/modest-easysetup-wizard.c:
1736 (create_page_account_details), (create_account):
1737 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1738 (on_combo_security_changed),
1739 (modest_connection_specific_smtp_edit_window_init),
1740 (modest_connection_specific_smtp_edit_window_save_settings):
1741 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1742 * src/maemo/modest-connection-specific-smtp-window.c:
1743 (modest_connection_specific_smtp_window_finalize),
1744 (modest_connection_specific_smtp_window_fill_with_connections),
1745 (on_button_edit), (modest_connection_specific_smtp_window_init):
1746 * src/maemo/modest-connection-specific-smtp-window.h:
1747 Implementing saving of connection-specific server accounts.
1749 But I need to refactor this so we can save the data for each
1750 possible connection-specific account and only actually create the server accounts
1751 when the easysetup finished, or the OK button is pressed on the account settings
1754 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1756 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1757 (on_combo_security_changed):
1758 (modest_connection_specific_smtp_edit_window_init):
1759 Auto-fill the port number as in the account settings.
1761 (modest_connection_specific_smtp_edit_window_set_connection):
1762 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1763 * src/maemo/modest-connection-specific-smtp-window.c:
1764 (fill_with_connections), (on_button_edit),
1765 (modest_connection_specific_smtp_window_init):
1766 Turn the edit window into a dialog to simplify the code, and
1767 set a WM hint as in a GtkDialog, because only a popup can be on top of
1768 another window in Maemo, and popups usually have no WM decoration.
1770 * src/modest-defs.h:
1771 * src/modest-account-mgr-helpers.c:
1772 (modest_account_mgr_set_connection_specific_smtp),
1773 (modest_account_mgr_remove_connection_specific_smtp),
1774 (modest_account_mgr_get_connection_specific_smtp):
1775 * src/modest-account-mgr-helpers.h: Some functions to write the
1776 connection-specific SMTP server information. Not yet used.
1779 * src/widgets/modest-folder-view.c: (text_cell_data):
1780 Fix a warning about an uninitialized variable.
1781 (on_configuration_key_changed): Put an #ifdef around the use
1782 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1784 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1786 * src/maemo/modest-account-settings-dialog.h:
1787 * src/maemo/modest-account-settings-dialog.c:
1788 Added connect_for_modified() utility function to mark the new modified boolean.
1790 (create_page_account_details), (create_page_user_details),
1791 (create_page_incoming), (create_page_outgoing), (on_response),
1792 (modest_account_settings_dialog_init),
1793 (modest_account_settings_dialog_set_account_name):
1794 Only warn about unsaved changes when there are actually unsaved changes.
1796 * src/modest-account-mgr-helpers.c:
1797 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1798 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1799 to get the data from there in future.
1801 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1803 * src/modest-defs.h:
1805 * src/modest-account-mgr-helpers.h:
1806 * src/modest-account-mgr-helpers.c:
1807 Store the security account setting in a single conf key instead of using
1808 the options list, so that the list is left for just the to-be-removed camel hack,
1809 and because gconf_client_set_list() is failing for some reason.
1811 * src/modest-account-mgr.c:
1812 (modest_account_mgr_add_server_account):
1813 * src/maemo/modest-account-settings-dialog.c:
1814 (modest_account_settings_dialog_set_account_name),
1815 (save_configuration): Use the renamed functions.
1818 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1820 * src/widgets/Makefile.am:
1821 * src/widgets/modest-limit-retrieve-combo-box.c:
1822 * src/widgets/modest-limit-retrieve-combo-box.h:
1823 * src/widgets/modest-retrieve-combo-box.c:
1824 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1825 the account settings dialog.
1827 * src/modest-defs.h:
1828 * src/modest-account-mgr-helpers.h:
1829 * src/modest-account-mgr-helpers.c:
1830 (modest_server_account_get_option_secure_auth),
1831 (modest_server_account_set_option_secure_auth):
1832 * src/modest-account-mgr.c:
1833 (modest_account_mgr_add_server_account):
1834 Use the existing AUTH_MECH conf key for the secure-auth setting,
1835 instead of putting it in the list options, because this was actually used already.
1837 * src/maemo/modest-account-settings-dialog.c:
1838 (create_page_account_details),
1839 (modest_account_settings_dialog_set_account_name),
1840 (save_configuration):
1841 * src/maemo/modest-account-settings-dialog.h:
1842 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1843 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1845 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1847 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1848 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1849 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1851 * src/modest-defs.h:
1852 * src/maemo/modest-account-settings-dialog.c:
1853 (create_page_incoming), (on_combo_outgoing_security_changed),
1854 (on_combo_incoming_security_changed), (create_page_outgoing),
1855 (modest_account_settings_dialog_set_account_name),
1856 (save_configuration): Load/Save the port number, and change it when the
1857 security combo changes, to suitable defaults.
1859 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1861 * src/modest-account-mgr.c:
1862 (modest_account_mgr_add_server_account): Set the security and secure-auth
1863 options, and add a comment saying that the other camel-specific options should be
1866 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1868 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1870 * src/modest-tny-account-store.c: (account_list_free),
1871 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1872 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1875 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1877 * src/modest-protocol-info.c:
1878 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1879 is required by our UI spec. Maybe something in our implementation will use this eventually.
1880 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1881 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1882 instead of the previous 0 placeholder.
1884 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1885 secure-auth settings.
1886 * src/modest-account-mgr-helpers.h:
1887 * src/modest-account-mgr-helpers.c:
1888 (modest_server_account_data_get_option_secure_auth),
1889 (modest_server_account_set_option_secure_auth),
1890 (modest_server_account_data_get_option_security),
1891 (modest_server_account_set_option_security): Added this API for getting and setting the security
1892 and secure-auth settings.
1894 * src/maemo/modest-account-settings-dialog.h:
1895 * src/maemo/modest-account-settings-dialog.c:
1896 (modest_account_settings_dialog_finalize), (check_data),
1897 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1898 about changing titles.
1899 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1900 (save_configuration): Save the security and secure-auth settings.
1902 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1903 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1905 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1907 * src/modest-defs.h:
1908 * src/modest-account-mgr.c:
1909 (modest_account_mgr_add_server_account):
1910 Added and used defines for the options key and value pair strings,
1911 that are used so far, though they do not seem to correspond to anything in our
1912 UI specs or ModestProtocol enum.
1914 * src/modest-account-mgr-helpers.h:
1915 * src/modest-account-mgr-helpers.c:
1916 (compare_option_strings_for_name),
1917 (modest_server_account_data_get_option_value),
1918 (modest_server_account_data_get_option_bool),
1919 (modest_account_mgr_get_server_account_option):
1920 Added helper functions for parsing the options GSList.
1922 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1924 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1925 display name is based on the supplied account name.
1926 * src/modest-account-mgr.c:
1927 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1928 with an inefficient, but good-enough, implementation.
1930 * src/maemo/easysetup/modest-easysetup-wizard.c:
1931 (create_page_account_details), (on_before_next), (create_account):
1932 Check for existing display names rather than (non-user-visible) account names, and just
1933 create and set a unique account name at the end.
1935 * src/maemo/modest-account-settings-dialog.c:
1936 (modest_account_settings_dialog_init),
1937 (modest_account_settings_dialog_set_account_name),
1938 (create_page_incoming): Show the display name, instead of the account name.
1939 (on_response): Do some (not all) extra checks, as in the UI spec.
1940 (save_configuration): Save the display name if it was changed.
1942 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1944 * po/en_GB.po: Added needed logical ID and translation.
1945 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1946 (init_view): Made the is-default column clicking work.
1948 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1951 * src/maemo/easysetup/Makefile.am:
1952 * src/maemo/easysetup/modest-easysetup-wizard.c:
1953 (modest_easysetup_wizard_dialog_init):
1954 * src/maemo/easysetup/provider-data-test.keyfile:
1955 * src/maemo/easysetup/provider-data.keyfile:
1956 Moved the provider data file to the new modest-providers-data package and used it from there.
1958 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1960 * src/modest-local-folder-info.c:
1961 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1962 N_() was already used on the static strings, but this just marks it for translation without
1963 using the translation.
1965 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1967 * src/maemo/modest-account-settings-dialog.c:
1968 (create_page_incoming),
1969 (modest_account_settings_dialog_set_account_name):
1970 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1971 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1972 I will do this if nobody else gets there first.
1974 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1976 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1977 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1978 save the security stuff.
1980 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1982 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1983 Set the email address and user fullname, which I now see must be
1986 * src/maemo/modest-account-settings-dialog.h:
1987 * src/maemo/modest-account-settings-dialog.c:
1989 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1990 leave-on-server and authentication.
1991 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1994 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1997 * src/maemo/modest-account-settings-dialog.c:
1998 * src/maemo/modest-account-settings-dialog.h:
1999 Most (but not all) of the widgets are now present as specified by the UI spec.
2000 No changes are yet saved, and some details are not properly shown yet.
2002 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2004 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2006 * src/maemo/Makefile.am:
2007 * src/maemo/modest-account-settings-dialog.c:
2008 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2009 an existing account. Doesn't do much yet.
2011 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2012 Open the accounts settings dialog when Edit is clicked.
2014 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2016 * src/maemo/easysetup/Makefile.am:
2017 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2019 * src/maemo/easysetup/modest-easysetup-wizard.c:
2020 (modest_easysetup_wizard_dialog_init):
2021 Try to get the source directory from the build system,
2022 instead of hard-coding "./" into the source code, when opening our local
2023 copies of the configuration files.
2024 But this still fails when opening the wizard from the Accounts window,
2025 maybe because the working directory seems to change at runtime.
2026 So the wizard will fail the second time unless you copy the files into their
2027 proper locations - see the stdout warnings for the paths.
2029 (create_page_account_details),(on_before_next):
2030 Check for existing non-server accounts instead of server accounts,
2031 so the default account name is useful again, and to prevent trying to
2034 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2035 Show the wizard when New is clicked.
2037 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2038 (init_view): Show the column headers, and show the columns that are
2039 specified in the UI specs. However, something in Maemo's GTK+ prevents
2040 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2041 change the default account. This is despite unsetting the special properties.
2043 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2045 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2046 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2047 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2048 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2049 to make that clearer.
2050 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2052 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2054 * src/maemo/modest-account-view-window.c:
2055 (modest_account_view_window_init),
2056 (modest_account_view_window_new):
2057 Use the same buttons as specified in the
2058 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2059 the existing widgets, which never had a chance of working.
2060 Put the ModestAccountView treeview in a scrolled window.
2061 Do not repeat the initialization in both _init() and _new().
2063 * src/widgets/modest-account-view.c: (update_account_view):
2064 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2065 this widget and window shows no accounts.
2067 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2069 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2071 * src/maemo/easysetup/modest-easysetup-wizard.c:
2072 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2073 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2074 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2077 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2078 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2079 accounts exist yet, as in the UI spec.
2081 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2083 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2085 * src/maemo/Makefile.am:
2086 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2087 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2088 New window for editing connection-specific smtp details.
2089 Not fully implemented.
2091 * src/maemo/modest-connection-specific-smtp-window.c:
2092 (modest_connection_specific_smtp_window_finalize) :
2093 unref the tree model.
2094 (on_button_edit): Show the edit window.
2096 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2098 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2101 * src/maemo/Makefile.am:
2102 * src/maemo/modest-connection-specific-smtp-window.c:
2103 * src/maemo/modest-connection-specific-smtp-window.h:
2104 New window for showing the list of connections, for connection-specific
2105 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2106 * src/maemo/easysetup/modest-easysetup-wizard.c:
2107 (create_page_custom_outgoing): Show the new window when the button is clicked.
2109 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2111 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2112 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2113 * src/maemo/modest-msg-edit-window.c:
2114 (modest_msg_edit_window_insert_image):
2115 * src/modest-conf.c: (modest_conf_key_escape):
2116 * src/modest-mail-operation.c:
2117 (modest_mail_operation_send_new_mail):
2118 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2119 (modest_ui_actions_on_new_account):
2120 * src/widgets/modest-attachment-view.c: (update_filename_request):
2121 * src/widgets/modest-mail-header-view.c:
2122 Corrected warnings that were breaking the build, by commenting out unused variables,
2123 and a function, and by including a header.
2125 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2127 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2128 so we can #ifdef around platform-specific code when necessary.
2129 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2130 to allow this to build for the GNOME platform too.
2132 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2134 * src/maemo/easysetup/modest-easysetup-wizard.c:
2135 Added util_increment_name() and used it in create_page_account_details()
2136 to make sure that the default account name is always a new name.
2138 (modest_easysetup_wizard_dialog_init),
2139 (set_default_custom_servernames): Some minor memory management fixes.
2141 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2145 * src/modest-runtime.c: (init_i18n): Restored the translation
2146 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2147 are defined in config.h, and the translations are installed.
2149 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2150 is defined for translation.
2152 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2154 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2156 * src/maemo/easysetup/modest-easysetup-wizard.c:
2157 (modest_easysetup_wizard_dialog_init):
2158 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2159 Use realistic paths (though they should use $prefix generically) to the
2160 mcc_mapping and provider-data.keyfile files which might work when they
2161 are installed by the future version of the operator-wizard package,
2162 and then fallback to paths in our source code, with an explanatory
2165 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2169 * src/maemo/Makefile.am:
2170 * src/maemo/easysetup/: Added files from the previously-exernal
2171 osso-modest-easysetup.
2172 * src/maemo/modest-main-window-ui.h:
2173 * src/modest-ui-actions.c:
2174 * src/modest-ui-actions.h:
2175 Added modest_ui_actions_on_new_account() as a signal handler for the
2176 New Account menu item. It shows the easysetup wizard.
2177 * po/en_GB.po: Added additional needed logical IDs and translations.
2179 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2180 Apparently ChangeLog is not used for some vague Nokia legal reasons.