1 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-maemo-global-settings-dialog.c:
4 (current_connection): Prevent a crash in scratchbox when
5 ny_maemo_conic_device_get_current_iap_id() returns NULL.
6 * src/maemo/modest-platform.c:
7 (on_modest_conf_update_interval_changed), (modest_platform_init):
8 Get the update interval from gconf and reset it when the gconf key changes.
10 2007-05-15 Murray Cumming <murrayc@murrayc.com>
12 * src/modest-protocol-info.c:
13 * src/modest-protocol-info.h: Adde enum-specific get functions,
14 instead of using a ModestProtocolType enum parameter.
16 * src/gnome/modest-account-assistant.c:
17 * src/gnome/modest-store-widget.c:
18 * src/gnome/modest-store-widget.h:
19 * src/gnome/modest-transport-widget.c:
20 * src/gnome/modest-transport-widget.h:
21 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
22 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
23 * src/maemo/easysetup/modest-easysetup-wizard.c:
24 * src/maemo/modest-account-settings-dialog.c:
25 * src/maemo/modest-account-settings-dialog.h:
26 * src/maemo/modest-store-widget.c:
27 * src/maemo/modest-store-widget.h:
28 * src/maemo/modest-transport-widget.c:
29 * src/maemo/modest-transport-widget.h:
30 * src/modest-account-mgr-helpers.c:
31 * src/modest-account-mgr-helpers.h:
32 * src/modest-account-mgr.c:
33 * src/modest-account-mgr.h:
34 * src/modest-tny-account.c:
35 * src/modest-tny-folder.c:
36 * src/widgets/modest-account-view.c:
37 * src/widgets/modest-retrieve-combo-box.c:
38 * src/widgets/modest-retrieve-combo-box.h:
39 * src/widgets/modest-secureauth-combo-box.c:
40 * src/widgets/modest-serversecurity-combo-box.c:
41 * src/widgets/modest-serversecurity-combo-box.h:
42 * tests/check_account-mgr.c:
43 Use the specific functions, and use the re-renamed enum values for GNOME too.
45 2007-05-15 Murray Cumming <murrayc@murrayc.com>
48 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
49 so we can get the second based on the first.
51 * src/maemo/modest-account-settings-dialog.h:
52 * src/maemo/modest-account-settings-dialog.c:
53 Added get_supported_secure_authentication_methods(), though it is mostly
54 commented-out for now until the necessary API is committed to tinymail.
55 (modest_account_settings_dialog_set_account_name),
56 (save_configuration): Request the supported authentication methods from the
57 server, so we can choose a working method.
59 * src/modest-tny-account-store.h:
60 * src/modest-tny-account-store.c:
61 (modest_tny_account_store_get_session): Rename from
62 tny_account_store_get_session().
64 2007-05-14 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-protocol-info.h: Split the ModestProtocol enum
67 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
68 There was no need to have these unrelated values in one enum.
70 * src/: many files: Adapted to changed enum. This makes the code a bit
71 clearer, and the compiler could catch some errors.
73 2007-05-14 Murray Cumming <murrayc@murrayc.com>
75 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
76 Show the detailed internal camel error message when an error happens
77 during the configuration, so that our testers can give us more clues.
78 For instance, in projects.maemo.org bug NB#56910 .
80 2007-05-14 Murray Cumming <murrayc@murrayc.com>
82 * src/modest-tny-account.c:
83 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
84 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
86 2007-05-14 Murray Cumming <murrayc@murrayc.com>
88 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
89 * src/maemo/modest-account-settings-dialog.c:
90 (modest_account_settings_dialog_set_account_name),
91 (save_configuration): For the incoming secure authentication checkbox,
92 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
93 the UI specification. PLAIN does not seem to be supported for most IMAP
94 servers anyway, and I am not sure what it would mean.
95 However, we probably need to discover which of the secure-authentication
96 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
97 * src/modest-account-mgr-helpers.c:
98 (modest_account_mgr_get_server_account_data):
100 * src/modest-tny-account.c:
101 (modest_tny_account_new_from_server_account):
102 Use tny_account_set_mech() to set secure-authentication methods,
103 with some special-casing for IMAP, based on my observations of how
106 * src/modest-account-mgr-helpers.h:
107 * src/modest-account-mgr.c:
108 * src/modest-defs.h: Comment that the URI is only used for local folders.
110 2007-05-11 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
113 parameter const, just to be neat.
114 * src/modest-text-utils.c: (modest_text_utils_inline):
115 End g_strconcat() with NULL, as its documentation says. This is almost
116 certainly the cause of my crash at startup on the device. Interestingly,
117 valgrind doesn't tell us about these errors.
119 2007-05-11 Murray Cumming <murrayc@murrayc.com>
121 * scripts/build-packages: Added more precise comments about how to use
122 this script, though I still get this error:
123 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
124 error building tinymail
126 2007-05-11 Murray Cumming <murrayc@murrayc.com>
128 * src/maemo/modest-main-window.c: (on_account_update):
129 Very slight cleanup, hoping to make it simpler to discover what causes
130 a crash here sometimes.
132 * src/modest-tny-account.c:
133 (modest_tny_account_new_from_server_account): Set the port. Added
134 comments about the options and a TODO comment because I need to find out
135 how to specify the secure authentication method.
137 2007-05-11 Marcus Bauer <marcusb@openismus.com>
139 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
140 changed CFlags paths form modest to libmodest
142 2007-05-10 Murray Cumming <murrayc@murrayc.com>
144 * src/modest-account-mgr-helpers.c:
145 (modest_account_mgr_get_server_account_data),
146 (modest_account_mgr_free_server_account_data):
147 * src/modest-account-mgr-helpers.h:
148 * src/modest-account-mgr.c:
149 (modest_account_mgr_add_server_account):
151 * src/modest-tny-account.c:
152 (modest_tny_account_new_from_server_account):
153 Determine the options for tny_camel_account_add_option() here,
154 based on the settings, rather than storing them directly in gconf.
156 2007-05-10 Murray Cumming <murrayc@murrayc.com>
158 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
159 Show a more friendly error dialog now that we expect (from the tinymail
160 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
162 2007-05-10 Murray Cumming <murrayc@murrayc.com>
164 * src/maemo/modest-main-window.c: (on_account_update): Check that
165 account_name is not NULL, to prevent a crash at startup that I am
166 seeing on the N800. I do wonder why it is NULL.
168 * src/maemo/easysetup/modest-easysetup-wizard.c:
169 (create_page_user_details):
170 * src/maemo/modest-account-settings-dialog.c:
171 (create_page_user_details), (create_page_outgoing):
172 * src/maemo/modest-connection-specific-smtp-edit-window.c:
173 (modest_connection_specific_smtp_edit_window_init):
174 * src/modest-ui-actions.c:
175 (modest_ui_actions_on_password_requested):
176 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
177 might do something useful with the on-screen keyboard.
179 2007-05-10 Murray Cumming <murrayc@murrayc.com>
181 * src/maemo/modest-main-window.c: (on_account_update):
182 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
183 NULL, to avoid lots of warnings. However, it probably should not be NULL.
185 2007-05-09 Murray Cumming <murrayc@murrayc.com>
187 * src/modest-tny-account-store.c: (on_account_changed):
188 Correct the signature of this signal handler.
190 2007-05-09 Murray Cumming <murrayc@murrayc.com>
192 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
193 Show a HildonNote instead of a GtkDialog for Maemo.
195 2007-05-09 Murray Cumming <murrayc@murrayc.com>
197 * src/widgets/modest-account-view.h:
198 * src/widgets/modest-account-view.c: (on_account_changed),
199 (on_account_removed). Added a boolean flag, set/unset by
200 modest_account_view_block_conf_updates(),
201 modest_account_view_unblock_conf_updates() to prevent unnecessary
202 updates, but this is not very useful because the gconf notifications are
203 so delays (maybe only on Maemo Bora).
204 So auto-updating is turned off, and these functions do an explicit
205 update when necessary.
206 However, something else is still doing too much work when adding/removing
207 accounts, probably in another part of the application.
209 * src/maemo/modest-account-view-window.c:
210 (on_delete_button_clicked), (on_edit_button_clicked),
211 (on_new_button_clicked): Use the new functions.
213 2007-05-09 Murray Cumming <murrayc@murrayc.com>
215 * src/modest-account-mgr-helpers.c:
216 (modest_account_mgr_set_first_account_as_default):
217 Sort the list of names alphabetically-by-title, so we choose the first one
219 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
220 alphabetically by the title.
222 This fixes projects.maemo.org bug NB#56418 .
224 * src/modest-account-mgr-priv.c:
225 (_modest_account_mgr_account_from_key):
226 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
227 avoid a valgrind error, and possible random behaviour.
229 2007-05-09 Murray Cumming <murrayc@murrayc.com>
231 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
232 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
233 tinymail documentation to say that this can be expected.
234 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
235 pretty, and should not happen, but I would prefer to know when it does.
237 2007-05-09 Murray Cumming <murrayc@murrayc.com>
239 * configure.ac: When using the older hildon version, probably on Bora,
240 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
242 * src/widgets/modest-attachment-view.c:
243 (modest_attachment_view_set_part_default): Initialize variables, to fix the
246 2007-05-09 Marcus Bauer <marcusb@openismus.com>
248 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
249 Implemented the prototype. Can be tested with
250 tests/dbus_api/test_open_message:
252 2007-05-08 Murray Cumming <murrayc@murrayc.com>
254 * src/modest-tny-account-store.c:
255 (modest_tny_account_store_instance_init), (get_password):
256 * src/modest-ui-actions.c:
257 (modest_ui_actions_on_password_requested):
258 Do not store the password in gconf, because this function is called
259 for non-remembered passwords. Actually use the cached (in the hash map)
260 password instead of releasing it.
261 The password will now not be remembered if it is asked via the protected
262 password dialog, as per the UI spec.
264 2007-05-08 Murray Cumming <murrayc@murrayc.com>
267 * src/modest-account-mgr-helpers.h:
268 * src/modest-account-mgr-helpers.c:
269 Added modest_server_account_get_username_has_succeeded(),
270 modest_server_account_set_username_has_succeeded().
271 (modest_server_account_set_username),
272 Reset the has-succeeded flag if the username changes.
274 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
275 * src/maemo/modest-connection-specific-smtp-window.c:
276 (modest_connection_specific_smtp_window_save_server_accounts):
277 Use modest_server_account_set_username() instead of using
278 modest_conf_set_string() directly, so that the has-succeeded flag is always
281 * src/modest-ui-actions.c:
282 (modest_ui_actions_on_password_requested): Dim the username entry if
283 the username has ever worked, as per the UI spec.
285 2007-05-08 Murray Cumming <murrayc@murrayc.com>
287 * src/modest-tny-account-store.c: (get_password):
288 * src/modest-ui-actions.c:
289 (modest_ui_actions_on_password_requested):
290 Allow the username to be changed too, though there is more work to
291 be done on exactly how this behaves.
293 2007-05-08 Murray Cumming <murrayc@murrayc.com>
295 * src/modest-account-mgr-helpers.h:
296 * src/modest-account-mgr-helpers.c:
297 Added modest_account_mgr_get_display_name(),
298 modest_server_account_get_username(),
299 modest_server_account_set_username(),
300 modest_server_account_set_password(),
301 modest_server_account_get_hostname() functions so we do not need to
302 use the conf API directly.
304 * src/maemo/modest-main-window.c: (connect_signals):
305 Actually connect ot the ModestAccountStore::request-password signal,
306 so that we show the dialog when the password is requested by Tinymail,
307 for isntance if it is empty.
309 * src/modest-marshal.list:
310 * src/modest-tny-account-store.c:
311 (modest_tny_account_store_class_init), (get_password),
312 (modest_tny_account_store_alert):
313 * src/modest-tny-account-store.h:
314 * src/modest-ui-actions.h:
315 * src/modest-ui-actions.c:
316 (modest_ui_actions_on_password_requested):
317 Change the signal parameters, so it is obvious that we are providing
318 the non human-readable server name, and receiving both the username
319 and password, though changing of the username is not yet implemented.
320 Change the dialog UI to match the Maemo UI specifications, with #idfefing
321 for the GNOME version.
323 This should fix the projects.maemo.org bug NB#56209, though it does not
324 work on Bora, because the gconf_client_get() for the password fails
325 immediately after we save it with gconf_client_set().
327 2007-05-08 Murray Cumming <murrayc@murrayc.com>
330 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
331 caused an undefined symbol error:
332 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
334 2007-05-08 Murray Cumming <murrayc@murrayc.com>
336 * src/modest-tny-account-store.c:
337 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
338 using a GError instead of a string message, so we can translate it in
341 2007-05-08 Murray Cumming <murrayc@murrayc.com>
343 * src/maemo/modest-address-book.c:
344 (modest_address_book_check_names):
345 * src/maemo/modest-msg-view-window.c:
346 (modest_msg_view_window_clipboard_owner_change):
347 * src/modest-init.c: (modest_init_init_ui):
348 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
349 (update_folders_cb), (modest_mail_operation_update_account):
350 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
351 (modest_ui_actions_on_msg_attachment_clicked),
352 (modest_ui_actions_on_msg_recpt_activated):
353 * src/widgets/modest-header-view.c: (drag_data_get_cb):
354 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
355 (modest_msg_view_search_next):
356 * src/widgets/modest-recpt-editor.c:
357 (modest_recpt_editor_on_button_release_event),
358 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
359 g_message(). At this point we should only be seeing interesting errors on
360 stdout. Debugging messages could be #ifdefed-out if they are still useful.
362 2007-05-07 Murray Cumming <murrayc@murrayc.com>
364 (modest_wizard_dialog_force_title_update):
365 * src/maemo/easysetup/modest-wizard-dialog.h:
366 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
367 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
368 can update the title when appropriate. Otherwise the title is wrong if the
369 pages are added after adding the notebook to the dialog.
370 This must be a problem in HildonWizardDialog too.
371 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
373 * src/maemo/easysetup/modest-easysetup-wizard.c:
374 (create_subsequent_customsetup_pages),
375 (create_subsequent_easysetup_pages):
376 Call modest_wizard_dialog_force_title_update() so that the title is
377 correct even with GTK+ < 2.10.
378 This fixes projects.maemo.org bug NB#56145 .
380 2007-05-07 Murray Cumming <murrayc@murrayc.com>
382 * src/maemo/modest-platform.c:
383 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
384 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
387 2007-05-07 Murray Cumming <murrayc@murrayc.com>
389 * src/widgets/modest-window.h:
390 * src/widgets/modest-window.c: Added a save_state_func vfunc,
391 and modest_window_save_state(), which invokes it.
393 * src/widgets/modest-window-mgr.h:
394 * src/widgets/modest-window-mgr.c:
395 Added modest_window_mgr_save_state_for_all_windows(), which calls
396 the save_state vfunc on all registered windows, if implemented.
398 * src/gnome/modest-msg-edit-window.c:
399 * src/gnome/modest-msg-view-window.c:
400 * src/maemo/modest-msg-edit-window.c:
401 * src/maemo/modest-msg-view-window.c:
402 * src/maemo/modest-main-window.c:
403 Specify the existing save_settings functions as implementations of
404 ModestWindow::save_state_func().
406 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
407 Call modest_window_mgr_save_state_for_all_windows(). This happens before
408 enabling hibernation, for instance.
410 We may need to do the same thing for restoring settings.
413 2007-05-07 Murray Cumming <murrayc@murrayc.com>
415 * src/widgets/modest-window-mgr.c:
416 * src/widgets/modest-window-mgr.h:
417 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
418 modest_window_mgr_get_hibernation_is_prevented().
420 * src/maemo/modest-main-window.c:
421 (on_hildon_program_is_topmost_notify): Prevent hibernation
422 (possible when the application goes to the background in the WM),
423 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
425 * src/maemo/easysetup/modest-easysetup-wizard.c:
426 (modest_easysetup_wizard_dialog_init):
427 * src/maemo/modest-account-settings-dialog.c:
428 (modest_account_settings_dialog_init):
429 * src/maemo/modest-connection-specific-smtp-edit-window.c:
430 (modest_connection_specific_smtp_edit_window_init):
431 * src/maemo/modest-connection-specific-smtp-window.c:
432 (modest_connection_specific_smtp_window_init):
433 * src/maemo/modest-signature-editor-dialog.c:
434 (modest_signature_editor_dialog_init):
435 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
436 prevent hibernation while any of these account settings dialogs are open.
438 2007-05-04 Murray Cumming <murrayc@murrayc.com>
440 * src/maemo/Makefile.am:
441 * src/maemo/modest-osso-state-saving.c:
442 * src/maemo/modest-osso-state-saving.h: Added
443 modest_osso_load_state() and modest_osso_save_state() though they do
444 nothing now. They should iterate through all the open windows and load/save
446 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
447 save state when closing.
449 * src/maemo/modest-main-window.c:
450 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
451 Add a notification handler for the HildonProgram::is-topmost property,
452 so we can allow hibernation when the application goes into the background.
453 But we still need to detect when the accounts setup windows are open so
454 we can stop hibernation when they are open.
455 To do this, I also added the main window the HildonProgram. This might have
456 other side-effects/benefits, and should maybe be done for other windows.
458 * src/maemo/modest-osso-autosave-callbacks.h:
459 * src/maemo/modest-osso-autosave-callbacks.c:
460 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
461 though it does not do anything yet, and we might never need this to do
462 anything. For instance, we already save drafts.
464 * src/maemo/modest-platform.c: (modest_platform_init):
465 Specify the libosso auto-save callback.
467 2007-05-03 Murray Cumming <murrayc@murrayc.com>
469 * src/maemo/modest-platform.c:
470 (modest_platform_set_update_interval):
471 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
472 aparently stays valid between application instances, so we can use this
473 to remove and reset it later. According to a maemo-developers email from
476 2007-05-03 Murray Cumming <murrayc@murrayc.com>
478 * configure.ac: Depend on libalarm for Maemo.
480 * src/dbus_api/modest-dbus-api.h:
481 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
482 (on_send_receive), (modest_dbus_req_handler):
483 Handle a SEND_RECEIVE D-Bus method.
485 * libmodest-dbus-client/libmodest-dbus-client.c:
486 (libmodest_dbus_client_send_and_receive):
487 * libmodest-dbus-client/libmodest-dbus-client.h:
488 Add C convenience functions for calling the new D-Bus method.
490 * src/modest-platform.h:
491 * src/gnome/modest-platform.c:
492 * src/maemo/modest-platform.c:
493 Added modest_platform_set_update_interval(), which uses the
495 (modest_platform_init),
496 Call modest_platform_set_update_interval(), using a hard-coded
497 interval for now (until the global settings dialog is implemented),
498 though I am not sure that this makes sense yet.
500 2007-05-02 Murray Cumming <murrayc@murrayc.com>
502 * src/dbus_api/modest-dbus-callbacks.c:
503 (modest_osso_cb_hw_state_handler):
504 * src/dbus_api/modest-dbus-callbacks.h:
505 * src/maemo/modest-platform.c: (modest_platform_init):
506 Registered (empty) callbacks for the osso hardware state D-Bus signals,
507 in case this has some effect on the ability for Maemo to ping the
510 2007-05-02 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
513 Comment out an if() that checks a gchar for < 0, causing a build-breaking
514 warning. It is probably a logic error, but I need to fix the build.
516 2007-05-02 Murray Cumming <murrayc@murrayc.com>
518 * src/modest-account-mgr.h:
519 * src/modest-account-mgr.c:
520 (modest_account_mgr_account_names): Add a gboolean enabled_only
521 parameter, so we can get lists of onlt the enabled accounts.
523 (modest_account_mgr_add_account),,
524 (modest_account_mgr_account_with_display_name_exists):
525 * src/maemo/modest-msg-edit-window.c: (get_transports):
526 * src/modest-account-mgr-helpers.c:
527 (modest_account_mgr_set_first_account_as_default):
528 * src/modest-init.c: (init_default_account_maybe):
529 * src/modest-tny-account-store.c: (get_accounts):
530 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
531 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
532 * tests/check_account-mgr.c: (START_TEST):
533 Provide the extra parameter, as appropriate.
535 * src/widgets/modest-account-view.c: (update_account_view):
536 Do not show disabled accounts (meaning that there is no way to
537 enable/disable accounts in the UI (the feature is not in our UI
538 specification), so we can use this internally only to mark unfinished
539 or temporary account data.
541 * src/maemo/easysetup/modest-easysetup-wizard.c:
542 (create_account): Add boolean enable parameter, so we can specify FALSE
543 to create the temporary account.
544 (on_button_edit_advanced_settings): Create the temporary account as disabled.
545 (on_before_next): When finishing, when there is a temporary account, just
547 Also, use a timeout to delay the showing of the dialog until gconf is likely
548 to return correct information, due to a maemo gconf bug that is fixed in
549 osso 1.1, but not yet in Bora.
550 However, the dialog stays on screen after it is destroyed.
552 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
553 for invalid data when cancelling. Use a hildon note instead of a dialog
554 to complain about invalid data. Do not show the account-saved note if the
555 account is disabled (a temporary account that will not really be saved for use
558 2007-04-30 Murray Cumming <murrayc@murrayc.com>
560 * src/modest-account-mgr-helpers.h:
561 * src/modest-account-mgr-helpers.c:
562 Added modest_account_mgr_unset_default_account(),
563 Added modest_account_mgr_set_first_account_as_default().
565 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
566 If it was the default account, unset the default account name.
568 * src/maemo/modest-account-view-window.c:
569 (on_delete_button_clicked): If it was the default account,
570 set the first remaining account as the default instead.
572 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
573 a NULL account or a NULL default account, to prevent a crash. This should
574 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
577 2007-04-30 Murray Cumming <murrayc@murrayc.com>
579 * src/widgets/modest-recpt-editor.c:
580 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
581 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
582 TODO comment for this. This fixes the build.
584 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
585 be the best place for it. This will in future update all auto-update accounts,
586 rather than just the current/default account, when that gconf key exists.
587 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
588 if there are no accounts, before calling do_send_receive().
589 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
591 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
592 * src/maemo/modest-main-window-ui.h:
593 * src/maemo/modest-main-window.c: (on_connection_changed),
594 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
595 directly, becaue the signal handler does more.
597 2007-04-30 Murray Cumming <murrayc@murrayc.com>
599 * src/modest-account-mgr-helpers.c:
600 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
601 for the case that the account does not exist.
603 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
604 (equivalent to the modest account name) rather than the tinymail account name
605 (equivalent to the modest account title - human readable) to get the account data.
606 Check for null account data to prevent the crash, and add a TODO comment saying that
607 this needs fixing because it is using the server account name instead of the account name.
609 2007-04-29 Murray Cumming <murrayc@murrayc.com>
611 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
612 * src/maemo/modest-account-settings-dialog.c: (show_error),
614 Use hildon_note_new_information() for informative and error messages,
615 which seems to be expected for Maemo applications (no documentation that I know of
616 says this). I am surprised that there is no distinction between info and error
619 2007-04-29 Murray Cumming <murrayc@murrayc.com>
621 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
622 it is easy to find where this is used.
624 * src/maemo/easysetup/modest-easysetup-wizard.c:
625 (create_page_welcome), (create_page_account_details),
626 (create_page_user_details), (create_page_complete_easysetup),
627 (create_page_custom_incoming), (create_page_custom_outgoing),
628 (create_page_complete_custom):
629 * src/maemo/modest-account-settings-dialog.c:
630 (create_page_account_details), (create_page_user_details),
631 (create_page_incoming), (create_page_outgoing):
632 * src/maemo/modest-account-view-window.c: (window_vbox_new):
633 * src/maemo/modest-connection-specific-smtp-edit-window.c:
634 (modest_connection_specific_smtp_edit_window_init):
635 * src/maemo/modest-connection-specific-smtp-window.c:
636 (modest_connection_specific_smtp_window_init):
637 * src/maemo/modest-signature-editor-dialog.c:
638 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
639 and scrolling policy as per the Email Application Layout Guide, if I have
642 2007-04-27 Murray Cumming <murrayc@murrayc.com>
644 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
645 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
646 which were empty, because these vfuncs have been removed from TnyAccountStore.
647 This fixes the build.
649 2007-04-27 Murray Cumming <murrayc@murrayc.com>
651 * src/maemo/modest-main-window.c:
652 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
653 showing/hiding it. Added TODO because it probably should not be NULL.
654 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
655 because unnecessary g_warnings() make degugging difficult.
657 2007-04-27 Murray Cumming <murrayc@murrayc.com>
659 * src/maemo/modest-msg-edit-window.c:
660 (modest_msg_edit_window_select_color),
661 (modest_msg_edit_window_select_background_color): 2 const corrections and
662 moving 2 #endifs before closing brackets, to fix the build.
664 2007-04-27 Murray Cumming <murrayc@murrayc.com>
666 * src/maemo/easysetup/modest-easysetup-wizard.h:
667 * src/maemo/easysetup/modest-easysetup-wizard.c:
668 (modest_easysetup_wizard_dialog_finalize),
669 (on_button_edit_advanced_settings), (create_page_complete_custom),
670 (on_response), (create_account):
671 Implement the Advanced Settings edit button, by saving the account information,
672 for the Advanded Settings dialog to use directly from gconf, and removing it
673 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
674 Bug #5533 in the projects.maemo.org bugzilla.
676 2007-04-27 Murray Cumming <murrayc@murrayc.com>
678 * src/maemo/modest-msg-view-window.c:
679 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
680 when opening a message window.
682 2007-04-27 Murray Cumming <murrayc@murrayc.com>
684 * src/maemo/easysetup/modest-easysetup-wizard.c:
685 (create_page_custom_outgoing): Correct the position of the horizontal separator to
688 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
689 before showing/hiding them, to avoid a crash when clicking on folders when there are no
690 gconf settings. I probably added more checks than necessary, but that is safer.
692 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
693 variable to fix the build, but this seems to be used when it is still NULL.
695 2007-04-27 Murray Cumming <murrayc@murrayc.com>
697 * src/modest-platform.h:
698 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
699 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
700 * src/modest-main.c: Implement this function so we can avoid using
701 maemo-specific API from cross-platform code.
703 * src/modest-tny-account-store.c:
704 (get_smtp_specific_transport_account_for_open_connection):
705 * src/modest-ui-actions.c: (check_for_connection),
706 (modest_ui_actions_on_item_not_found):
707 Use modest_platform_connect_and_wait() and put #idefs around other
708 maemo-specific code, because only maemo currently has a way to
709 identify connection names.
711 2007-04-27 Murray Cumming <murrayc@murrayc.com>
713 * src/modest-tny-account-store.h:
714 * src/modest-tny-account-store.c:
715 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
716 the connection-specific SMTP server settings in the configuration.
718 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
720 * src/maemo/modest-main-window.c: (on_connection_changed),
722 * src/modest-main.c: (main), (start_ui), (send_mail):
723 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
724 that is what is intended.
726 * src/modest-ui-actions.c: (action_send), (action_receive),
727 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
728 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
729 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
730 SMTP server is used when it is specified.
732 (modest_ui_actions_on_send_receive):
733 Check that a connection is open before proceeding.
734 Receive and then send, instead of vice-versa, as per the specification.
736 2007-04-26 Murray Cumming <murrayc@murrayc.com>
738 * src/modest-mail-operation.c:
739 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
740 though I guess it should be something other than NULL.
742 2007-04-26 Murray Cumming <murrayc@murrayc.com>
744 * src/maemo/easysetup/modest-easysetup-wizard.c:
745 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
746 combo twice, to avoid an g_warning and to make it visible again.
747 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
748 attached before detaching it, to avoid a g_warning, and add comment about the implicit
749 (already intended) dereference when detaching, because we then recreate the menu.
750 But I am not sure why the warning was happening, and it is possible that this is a memory
753 2007-04-25 Murray Cumming <murrayc@murrayc.com>
755 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
756 and uri_parse_mailto() utility functions.
757 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
759 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
761 2007-04-24 Murray Cumming <murrayc@murrayc.com>
763 * src/dbus_api/modest-dbus-api.h:
764 * src/dbus_api/modest-dbus-callbacks.c:
765 Use an idle callback to execute the modest code in the application's own thread.
766 Remove the helloworld example method.
767 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
768 parsed, and the open-message method is not implemented because this is not yet implemented in
770 * libmodest-dbus-client/libmodest-dbus-client.c:
771 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
772 (libmodest_dbus_client_open_message):
773 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
775 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
776 body without crashing.
778 * tests/dbus_api/Makefile.am:
779 * tests/dbus_api/test_mail_to.c:
780 * tests/dbus_api/test_open_message.c: New tests for the new methods.
782 2007-04-24 Murray Cumming <murrayc@murrayc.com>
784 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
785 Added file to fix the build. Sorry.
787 * src/dbus_api/Makefile.am:
788 * src/dbus_api/modest-dbus-api.h:
789 * src/dbus_api/modest-dbus-callbacks.h:
790 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
791 (modest_dbus_req_handler):
792 Put constants in a separate header so it can be reused by the
793 client library, without duplication
795 * libmodest-dbus-client/Makefile.am:
796 * libmodest-dbus-client/libmodest-dbus-client.c:
797 (libmodest_dbus_client_call_helloworld),
798 (libmodfest_dbus_client_send_mail),
799 (libmodfest_dbus_client_mailto),
800 (libmodfest_dbus_client_open_message):
801 * libmodest-dbus-client/libmodest-dbus-client.h:
802 (Partly) Implement a send_mail D-Bus method.
804 * tests/dbus_api/Makefile.am:
805 * tests/dbus_api/test_send_mail.c: (main): Added a test for
806 the send_email D-Bus method.
808 2007-04-24 Murray Cumming <murrayc@murrayc.com>
812 * libmodest-dbus-client/Makefile.am:
813 * libmodest-dbus-client/libmodest-dbus-client.c:
814 * libmodest-dbus-client/libmodest-dbus-client.h:
815 * tests/dbus_api/Makefile.am:
816 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
817 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
819 2007-04-24 Murray Cumming <murrayc@murrayc.com>
821 * src/maemo/easysetup/modest-easysetup-wizard.c:
822 (create_page_account_details):
823 * src/maemo/modest-account-settings-dialog.c:
824 (create_page_account_details): Explicitly set auto-capitalization mode for the title
825 widgets, because this might not be the default in future versions of the Maemo GTK+.
826 However, I can not not get capitalization to work even in a simple test case.
828 2007-04-24 Murray Cumming <murrayc@murrayc.com>
830 * src/maemo/easysetup/modest-easysetup-wizard.c:
831 (create_page_custom_incoming), (create_page_custom_outgoing):
832 * src/maemo/modest-account-settings-dialog.c:
833 (create_page_account_details), (create_page_incoming),
834 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
835 instead of using gtk_check_button_with_label(), so they are aligned like the other
836 widgets, as per the UI spec.
838 2007-04-24 Murray Cumming <murrayc@murrayc.com>
840 * src/maemo/easysetup/modest-easysetup-wizard.c:
841 * src/maemo/modest-connection-specific-smtp-edit-window.c:
842 * src/widgets/modest-validating-entry.c:
843 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
844 Modest prefix instead of an EasySetup prefix.
846 2007-04-23 Murray Cumming <murrayc@murrayc.com>
848 * src/widgets/modest-validating-entry.h:
849 * src/widgets/modest-validating-entry.c: (on_insert_text),
850 Added easysetup_validating_entry_set_max_func(), used to set a callback
851 to call when the max number of characters is reached. GtkEntry has a max-length
852 already but is silent about it.
854 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
855 (create_page_account_details), (create_page_user_details),
857 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
858 (create_page_account_details), (create_page_user_details),
859 (create_page_outgoing):
860 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
861 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
862 the UI spec, when the user tries to enter more than the max number of characters.
864 2007-04-23 Murray Cumming <murrayc@murrayc.com>
866 * src/maemo/easysetup/modest-easysetup-wizard.c:
867 (create_page_user_details), (create_page_custom_incoming),
868 (create_page_custom_outgoing):
869 * src/maemo/modest-account-settings-dialog.c:
870 (create_page_user_details), (create_page_incoming),
871 (create_page_outgoing):
872 * src/maemo/modest-connection-specific-smtp-edit-window.c:
873 (modest_connection_specific_smtp_edit_window_init):
874 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
875 not appropriate. Bad Maemo-specific defaults!.
877 2007-04-23 Murray Cumming <murrayc@murrayc.com>
879 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
880 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
881 (modest_signature_editor_dialog_set_settings):
882 Disable the label and textview when the checkbox is disabled, and use the
883 specified (UI spec) default signature text.
885 2007-04-23 Murray Cumming <murrayc@murrayc.com>
887 * src/maemo/modest-connection-specific-smtp-edit-window.c:
888 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
891 * src/modest-account-mgr-helpers.h:
892 * src/modest-account-mgr-helpers.c:
893 Added modest_account_mgr_get/set_signature(), using new gconf keys.
895 * src/maemo/Makefile.am:
896 * src/maemo/modest-signature-editor-dialog.c:
897 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
900 * src/maemo/modest-account-settings-dialog.h:
901 * src/maemo/modest-account-settings-dialog.c:
902 (modest_account_settings_dialog_finalize), (on_button_signature),
903 (save_configuration): Use the new dialog when the Edit button is pressed, and
904 save the changes if necessary, as per the UI spec.
906 2007-04-23 Murray Cumming <murrayc@murrayc.com>
908 * src/maemo/Makefile.am:
909 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
910 based on maemo-develoers email from Dirk.
912 * src/maemo/easysetup/modest-easysetup-wizard.c:
913 (create_page_welcome), (create_page_account_details),
914 (create_page_user_details), (create_page_complete_easysetup),
915 (create_page_custom_incoming), (create_page_custom_outgoing),
916 (create_page_complete_custom),
917 (modest_easysetup_wizard_dialog_init):
918 * src/maemo/modest-account-settings-dialog.c:
919 (create_page_account_details), (create_page_user_details),
920 (create_page_incoming), (create_page_outgoing),
921 (modest_account_settings_dialog_init):
922 * src/maemo/modest-connection-specific-smtp-window.c:
923 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
925 2007-04-23 Murray Cumming <murrayc@murrayc.com>
927 * src/maemo/easysetup/modest-easysetup-wizard.c:
928 (create_page_account_details), (create_page_custom_outgoing),
929 (create_page_complete_custom):
930 * src/maemo/modest-account-settings-dialog.c:
931 (create_page_user_details), (create_page_incoming),
932 (create_page_outgoing):
933 * src/maemo/modest-connection-specific-smtp-edit-window.c:
934 (modest_connection_specific_smtp_edit_window_init):
935 Use the correct (UI spec) port min/max, and use horizontal separators,
938 2007-04-23 Murray Cumming <murrayc@murrayc.com>
940 * src/maemo/easysetup/modest-easysetup-wizard.c:
941 (set_default_custom_servernames):
942 * src/maemo/modest-account-settings-dialog.c:
943 (create_page_incoming), (on_combo_outgoing_security_changed),
944 (on_combo_incoming_security_changed), (create_page_outgoing),
945 (modest_account_settings_dialog_set_account_name),
946 (save_configuration):
947 * src/maemo/modest-connection-specific-smtp-edit-window.c:
948 (on_combo_security_changed),
949 (modest_connection_specific_smtp_edit_window_init),
950 (modest_connection_specific_smtp_edit_window_set_connection),
951 (modest_connection_specific_smtp_edit_window_get_settings):
952 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
955 2007-04-20 Murray Cumming <murrayc@murrayc.com>
958 * src/maemo/easysetup/modest-easysetup-wizard.c:
959 (create_page_custom_outgoing), (create_page_complete_custom):
960 * src/maemo/modest-account-settings-dialog.c:
961 (create_page_user_details), (create_page_outgoing):
962 * src/maemo/modest-account-view-window.c: (button_box_new):
963 Use changed logical IDs as per the most recent UI spec:
964 mcen_bd_emailsetup_edit -> mcen_bd_edit
965 mcen_bd_emailsetup_delete -> mcen_bd_delete
966 mcen_bd_emailsetup_close -> mcen_bd_close
968 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
972 * src/dbus_api/Makefile.am:
973 * src/dbus_api/modest-dbus-callbacks.c:
974 * src/dbus_api/modest-dbus-callbacks.h:
975 * src/maemo/modest-platform.c: (modest_platform_init):
976 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
979 * tests/dbus_api/Makefile.am:
980 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
982 2007-04-20 Murray Cumming <murrayc@murrayc.com>
984 * src/maemo/modest-account-settings-dialog.c:
985 * src/maemo/modest-connection-specific-smtp-edit-window.c:
986 Removed unnecessary includes.
988 2007-04-20 Murray Cumming <murrayc@murrayc.com>
990 * src/maemo/easysetup/modest-easysetup-wizard.c:
991 * src/maemo/modest-account-settings-dialog.c:
992 * src/maemo/modest-connection-specific-smtp-edit-window.c:
993 * src/widgets/Makefile.am:
994 * src/widgets/modest-easysetup-secureauth-combo-box.c:
995 * src/widgets/modest-easysetup-secureauth-combo-box.h:
996 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
997 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
998 * src/widgets/modest-secureauth-combo-box.c:
999 * src/widgets/modest-secureauth-combo-box.h:
1000 * src/widgets/modest-serversecurity-combo-box.c:
1001 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1002 made the GObject names more consistent with the rest of the Modest code.
1004 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1006 * src/maemo/easysetup/Makefile.am:
1007 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1008 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1009 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1010 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1011 * src/maemo/easysetup/modest-easysetup-wizard.c:
1012 * src/maemo/easysetup/modest-validating-entry.c:
1013 * src/maemo/easysetup/modest-validating-entry.h:
1014 * src/maemo/modest-account-settings-dialog.c:
1015 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1016 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1017 widgets/ because they are used outside of easysetup too. After checking in,
1018 svn will allow me to rename them too.
1020 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1022 * src/gnome/modest-msg-edit-window.c:
1023 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1024 linker error, to fix the build on the GNOME platform.
1025 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1026 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1027 ifdefed out to avoid a warning.
1029 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1031 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1032 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1033 some alternative for GTK+ 2.6.
1035 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1037 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1039 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1040 specified for EmailAccountsDialog in UI spec.
1042 * src/maemo/easysetup/modest-easysetup-wizard.c:
1043 * src/maemo/easysetup/modest-easysetup-wizard.h:
1044 * src/maemo/modest-account-settings-dialog.c:
1045 * src/maemo/modest-account-settings-dialog.h:
1046 Reuse a member window widget for the connection-specific SMTP server accounts,
1047 so we can tell it to create/save the accounts only if we actually save changes.
1049 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1050 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1051 (modest_connection_specific_smtp_edit_window_get_settings):
1052 Return a struct instance for temporarily remembering the entered data.
1054 * src/maemo/modest-connection-specific-smtp-window.h:
1055 * src/maemo/modest-connection-specific-smtp-window.c:
1056 (modest_connection_specific_smtp_window_finalize),
1057 (modest_connection_specific_smtp_window_fill_with_connections),
1059 (modest_connection_specific_smtp_window_save_server_accounts),
1060 (update_model_server_names): Do not actually save data until asked,
1061 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1063 (on_selection_changed),
1064 (modest_connection_specific_smtp_window_init): Disable the edit
1065 button when nothing is selected.
1067 * src/modest-account-mgr-helpers.c:
1068 * src/modest-account-mgr-helpers.h:
1069 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1072 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1074 * src/modest-account-mgr-helpers.h:
1075 * src/modest-account-mgr-helpers.c:
1076 (modest_account_mgr_get_unused_account_name),
1077 (modest_account_mgr_get_unused_account_display_name): Added these
1078 utility functions, to avoid code duplication.
1080 * src/maemo/easysetup/modest-easysetup-wizard.c:
1081 (create_page_account_details), (create_account):
1082 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1083 (on_combo_security_changed),
1084 (modest_connection_specific_smtp_edit_window_init),
1085 (modest_connection_specific_smtp_edit_window_save_settings):
1086 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1087 * src/maemo/modest-connection-specific-smtp-window.c:
1088 (modest_connection_specific_smtp_window_finalize),
1089 (modest_connection_specific_smtp_window_fill_with_connections),
1090 (on_button_edit), (modest_connection_specific_smtp_window_init):
1091 * src/maemo/modest-connection-specific-smtp-window.h:
1092 Implementing saving of connection-specific server accounts.
1094 But I need to refactor this so we can save the data for each
1095 possible connection-specific account and only actually create the server accounts
1096 when the easysetup finished, or the OK button is pressed on the account settings
1099 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1101 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1102 (on_combo_security_changed):
1103 (modest_connection_specific_smtp_edit_window_init):
1104 Auto-fill the port number as in the account settings.
1106 (modest_connection_specific_smtp_edit_window_set_connection):
1107 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1108 * src/maemo/modest-connection-specific-smtp-window.c:
1109 (fill_with_connections), (on_button_edit),
1110 (modest_connection_specific_smtp_window_init):
1111 Turn the edit window into a dialog to simplify the code, and
1112 set a WM hint as in a GtkDialog, because only a popup can be on top of
1113 another window in Maemo, and popups usually have no WM decoration.
1115 * src/modest-defs.h:
1116 * src/modest-account-mgr-helpers.c:
1117 (modest_account_mgr_set_connection_specific_smtp),
1118 (modest_account_mgr_remove_connection_specific_smtp),
1119 (modest_account_mgr_get_connection_specific_smtp):
1120 * src/modest-account-mgr-helpers.h: Some functions to write the
1121 connection-specific SMTP server information. Not yet used.
1124 * src/widgets/modest-folder-view.c: (text_cell_data):
1125 Fix a warning about an uninitialized variable.
1126 (on_configuration_key_changed): Put an #ifdef around the use
1127 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1129 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1131 * src/maemo/modest-account-settings-dialog.h:
1132 * src/maemo/modest-account-settings-dialog.c:
1133 Added connect_for_modified() utility function to mark the new modified boolean.
1135 (create_page_account_details), (create_page_user_details),
1136 (create_page_incoming), (create_page_outgoing), (on_response),
1137 (modest_account_settings_dialog_init),
1138 (modest_account_settings_dialog_set_account_name):
1139 Only warn about unsaved changes when there are actually unsaved changes.
1141 * src/modest-account-mgr-helpers.c:
1142 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1143 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1144 to get the data from there in future.
1146 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1148 * src/modest-defs.h:
1150 * src/modest-account-mgr-helpers.h:
1151 * src/modest-account-mgr-helpers.c:
1152 Store the security account setting in a single conf key instead of using
1153 the options list, so that the list is left for just the to-be-removed camel hack,
1154 and because gconf_client_set_list() is failing for some reason.
1156 * src/modest-account-mgr.c:
1157 (modest_account_mgr_add_server_account):
1158 * src/maemo/modest-account-settings-dialog.c:
1159 (modest_account_settings_dialog_set_account_name),
1160 (save_configuration): Use the renamed functions.
1163 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1165 * src/widgets/Makefile.am:
1166 * src/widgets/modest-limit-retrieve-combo-box.c:
1167 * src/widgets/modest-limit-retrieve-combo-box.h:
1168 * src/widgets/modest-retrieve-combo-box.c:
1169 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1170 the account settings dialog.
1172 * src/modest-defs.h:
1173 * src/modest-account-mgr-helpers.h:
1174 * src/modest-account-mgr-helpers.c:
1175 (modest_server_account_get_option_secure_auth),
1176 (modest_server_account_set_option_secure_auth):
1177 * src/modest-account-mgr.c:
1178 (modest_account_mgr_add_server_account):
1179 Use the existing AUTH_MECH conf key for the secure-auth setting,
1180 instead of putting it in the list options, because this was actually used already.
1182 * src/maemo/modest-account-settings-dialog.c:
1183 (create_page_account_details),
1184 (modest_account_settings_dialog_set_account_name),
1185 (save_configuration):
1186 * src/maemo/modest-account-settings-dialog.h:
1187 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1188 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1190 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1192 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1193 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1194 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1196 * src/modest-defs.h:
1197 * src/maemo/modest-account-settings-dialog.c:
1198 (create_page_incoming), (on_combo_outgoing_security_changed),
1199 (on_combo_incoming_security_changed), (create_page_outgoing),
1200 (modest_account_settings_dialog_set_account_name),
1201 (save_configuration): Load/Save the port number, and change it when the
1202 security combo changes, to suitable defaults.
1204 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1206 * src/modest-account-mgr.c:
1207 (modest_account_mgr_add_server_account): Set the security and secure-auth
1208 options, and add a comment saying that the other camel-specific options should be
1211 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1213 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1215 * src/modest-tny-account-store.c: (account_list_free),
1216 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1217 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1220 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1222 * src/modest-protocol-info.c:
1223 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1224 is required by our UI spec. Maybe something in our implementation will use this eventually.
1225 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1226 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1227 instead of the previous 0 placeholder.
1229 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1230 secure-auth settings.
1231 * src/modest-account-mgr-helpers.h:
1232 * src/modest-account-mgr-helpers.c:
1233 (modest_server_account_data_get_option_secure_auth),
1234 (modest_server_account_set_option_secure_auth),
1235 (modest_server_account_data_get_option_security),
1236 (modest_server_account_set_option_security): Added this API for getting and setting the security
1237 and secure-auth settings.
1239 * src/maemo/modest-account-settings-dialog.h:
1240 * src/maemo/modest-account-settings-dialog.c:
1241 (modest_account_settings_dialog_finalize), (check_data),
1242 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1243 about changing titles.
1244 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1245 (save_configuration): Save the security and secure-auth settings.
1247 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1248 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1250 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1252 * src/modest-defs.h:
1253 * src/modest-account-mgr.c:
1254 (modest_account_mgr_add_server_account):
1255 Added and used defines for the options key and value pair strings,
1256 that are used so far, though they do not seem to correspond to anything in our
1257 UI specs or ModestProtocol enum.
1259 * src/modest-account-mgr-helpers.h:
1260 * src/modest-account-mgr-helpers.c:
1261 (compare_option_strings_for_name),
1262 (modest_server_account_data_get_option_value),
1263 (modest_server_account_data_get_option_bool),
1264 (modest_account_mgr_get_server_account_option):
1265 Added helper functions for parsing the options GSList.
1267 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1269 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1270 display name is based on the supplied account name.
1271 * src/modest-account-mgr.c:
1272 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1273 with an inefficient, but good-enough, implementation.
1275 * src/maemo/easysetup/modest-easysetup-wizard.c:
1276 (create_page_account_details), (on_before_next), (create_account):
1277 Check for existing display names rather than (non-user-visible) account names, and just
1278 create and set a unique account name at the end.
1280 * src/maemo/modest-account-settings-dialog.c:
1281 (modest_account_settings_dialog_init),
1282 (modest_account_settings_dialog_set_account_name),
1283 (create_page_incoming): Show the display name, instead of the account name.
1284 (on_response): Do some (not all) extra checks, as in the UI spec.
1285 (save_configuration): Save the display name if it was changed.
1287 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1289 * po/en_GB.po: Added needed logical ID and translation.
1290 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1291 (init_view): Made the is-default column clicking work.
1293 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1296 * src/maemo/easysetup/Makefile.am:
1297 * src/maemo/easysetup/modest-easysetup-wizard.c:
1298 (modest_easysetup_wizard_dialog_init):
1299 * src/maemo/easysetup/provider-data-test.keyfile:
1300 * src/maemo/easysetup/provider-data.keyfile:
1301 Moved the provider data file to the new modest-providers-data package and used it from there.
1303 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1305 * src/modest-local-folder-info.c:
1306 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1307 N_() was already used on the static strings, but this just marks it for translation without
1308 using the translation.
1310 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1312 * src/maemo/modest-account-settings-dialog.c:
1313 (create_page_incoming),
1314 (modest_account_settings_dialog_set_account_name):
1315 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1316 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1317 I will do this if nobody else gets there first.
1319 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1321 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1322 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1323 save the security stuff.
1325 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1327 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1328 Set the email address and user fullname, which I now see must be
1331 * src/maemo/modest-account-settings-dialog.h:
1332 * src/maemo/modest-account-settings-dialog.c:
1334 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1335 leave-on-server and authentication.
1336 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1339 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1342 * src/maemo/modest-account-settings-dialog.c:
1343 * src/maemo/modest-account-settings-dialog.h:
1344 Most (but not all) of the widgets are now present as specified by the UI spec.
1345 No changes are yet saved, and some details are not properly shown yet.
1347 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1349 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1351 * src/maemo/Makefile.am:
1352 * src/maemo/modest-account-settings-dialog.c:
1353 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1354 an existing account. Doesn't do much yet.
1356 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1357 Open the accounts settings dialog when Edit is clicked.
1359 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1361 * src/maemo/easysetup/Makefile.am:
1362 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1364 * src/maemo/easysetup/modest-easysetup-wizard.c:
1365 (modest_easysetup_wizard_dialog_init):
1366 Try to get the source directory from the build system,
1367 instead of hard-coding "./" into the source code, when opening our local
1368 copies of the configuration files.
1369 But this still fails when opening the wizard from the Accounts window,
1370 maybe because the working directory seems to change at runtime.
1371 So the wizard will fail the second time unless you copy the files into their
1372 proper locations - see the stdout warnings for the paths.
1374 (create_page_account_details),(on_before_next):
1375 Check for existing non-server accounts instead of server accounts,
1376 so the default account name is useful again, and to prevent trying to
1379 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1380 Show the wizard when New is clicked.
1382 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1383 (init_view): Show the column headers, and show the columns that are
1384 specified in the UI specs. However, something in Maemo's GTK+ prevents
1385 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1386 change the default account. This is despite unsetting the special properties.
1388 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1390 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1391 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1392 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1393 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1394 to make that clearer.
1395 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1397 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1399 * src/maemo/modest-account-view-window.c:
1400 (modest_account_view_window_init),
1401 (modest_account_view_window_new):
1402 Use the same buttons as specified in the
1403 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1404 the existing widgets, which never had a chance of working.
1405 Put the ModestAccountView treeview in a scrolled window.
1406 Do not repeat the initialization in both _init() and _new().
1408 * src/widgets/modest-account-view.c: (update_account_view):
1409 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1410 this widget and window shows no accounts.
1412 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1414 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1416 * src/maemo/easysetup/modest-easysetup-wizard.c:
1417 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1418 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1419 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1422 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1423 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1424 accounts exist yet, as in the UI spec.
1426 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1428 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1430 * src/maemo/Makefile.am:
1431 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1432 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1433 New window for editing connection-specific smtp details.
1434 Not fully implemented.
1436 * src/maemo/modest-connection-specific-smtp-window.c:
1437 (modest_connection_specific_smtp_window_finalize) :
1438 unref the tree model.
1439 (on_button_edit): Show the edit window.
1441 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1443 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1446 * src/maemo/Makefile.am:
1447 * src/maemo/modest-connection-specific-smtp-window.c:
1448 * src/maemo/modest-connection-specific-smtp-window.h:
1449 New window for showing the list of connections, for connection-specific
1450 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1451 * src/maemo/easysetup/modest-easysetup-wizard.c:
1452 (create_page_custom_outgoing): Show the new window when the button is clicked.
1454 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1456 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1457 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1458 * src/maemo/modest-msg-edit-window.c:
1459 (modest_msg_edit_window_insert_image):
1460 * src/modest-conf.c: (modest_conf_key_escape):
1461 * src/modest-mail-operation.c:
1462 (modest_mail_operation_send_new_mail):
1463 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1464 (modest_ui_actions_on_new_account):
1465 * src/widgets/modest-attachment-view.c: (update_filename_request):
1466 * src/widgets/modest-mail-header-view.c:
1467 Corrected warnings that were breaking the build, by commenting out unused variables,
1468 and a function, and by including a header.
1470 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1472 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1473 so we can #ifdef around platform-specific code when necessary.
1474 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1475 to allow this to build for the GNOME platform too.
1477 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1479 * src/maemo/easysetup/modest-easysetup-wizard.c:
1480 Added util_increment_name() and used it in create_page_account_details()
1481 to make sure that the default account name is always a new name.
1483 (modest_easysetup_wizard_dialog_init),
1484 (set_default_custom_servernames): Some minor memory management fixes.
1486 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1490 * src/modest-runtime.c: (init_i18n): Restored the translation
1491 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1492 are defined in config.h, and the translations are installed.
1494 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1495 is defined for translation.
1497 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1501 * src/maemo/easysetup/modest-easysetup-wizard.c:
1502 (modest_easysetup_wizard_dialog_init):
1503 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1504 Use realistic paths (though they should use $prefix generically) to the
1505 mcc_mapping and provider-data.keyfile files which might work when they
1506 are installed by the future version of the operator-wizard package,
1507 and then fallback to paths in our source code, with an explanatory
1510 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1514 * src/maemo/Makefile.am:
1515 * src/maemo/easysetup/: Added files from the previously-exernal
1516 osso-modest-easysetup.
1517 * src/maemo/modest-main-window-ui.h:
1518 * src/modest-ui-actions.c:
1519 * src/modest-ui-actions.h:
1520 Added modest_ui_actions_on_new_account() as a signal handler for the
1521 New Account menu item. It shows the easysetup wizard.
1522 * po/en_GB.po: Added additional needed logical IDs and translations.
1524 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1525 Apparently ChangeLog is not used for some vague Nokia legal reasons.