git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/modest-main-window.c: (on_account_update):
   4         Very slight cleanup, hoping to make it simpler to discover what causes
   5         a crash here sometimes.
   6
   7         * src/modest-tny-account.c:
   8         (modest_tny_account_new_from_server_account): Set the port. Added
   9         comments about the options and a TODO comment because I need to find out
  10         how to specify the secure authentication method.
  11
  12 2007-05-11  Marcus Bauer  <marcusb@openismus.com>
  13
  14         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
  15         changed CFlags paths form modest to libmodest
  16
  17 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  18
  19         * src/modest-account-mgr-helpers.c:
  20         (modest_account_mgr_get_server_account_data),
  21         (modest_account_mgr_free_server_account_data):
  22         * src/modest-account-mgr-helpers.h:
  23         * src/modest-account-mgr.c:
  24         (modest_account_mgr_add_server_account):
  25         * src/modest-defs.h:
  26         * src/modest-tny-account.c:
  27         (modest_tny_account_new_from_server_account):
  28         Determine the options for tny_camel_account_add_option() here,
  29         based on the settings, rather than storing them directly in gconf.
  30
  31 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  32
  33         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  34         Show a more friendly error dialog now that we expect (from the tinymail
  35         documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
  36
  37 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  38
  39         * src/maemo/modest-main-window.c: (on_account_update): Check that
  40         account_name is not NULL, to prevent a crash at startup that I am
  41         seeing on the N800. I do wonder why it is NULL.
  42
  43         * src/maemo/easysetup/modest-easysetup-wizard.c:
  44         (create_page_user_details):
  45         * src/maemo/modest-account-settings-dialog.c:
  46         (create_page_user_details), (create_page_outgoing):
  47         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  48         (modest_connection_specific_smtp_edit_window_init):
  49         * src/modest-ui-actions.c:
  50         (modest_ui_actions_on_password_requested):
  51         Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
  52         might do something useful with the on-screen keyboard.
  53
  54 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  55
  56         * src/maemo/modest-main-window.c: (on_account_update):
  57         Avoid adding a menu item to priv->accounts_popup if accounts_popup is
  58         NULL, to avoid lots of warnings. However, it probably should not be NULL.
  59
  60 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  61
  62         * src/modest-tny-account-store.c: (on_account_changed):
  63         Correct the signature of this signal handler.
  64
  65 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  66
  67         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  68         Show a HildonNote instead of a GtkDialog for Maemo.
  69
  70 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  71
  72         * src/widgets/modest-account-view.h:
  73         * src/widgets/modest-account-view.c: (on_account_changed),
  74         (on_account_removed). Added a boolean flag, set/unset by
  75         modest_account_view_block_conf_updates(),
  76         modest_account_view_unblock_conf_updates() to prevent unnecessary
  77         updates, but this is not very useful because the gconf notifications are
  78         so delays (maybe only on Maemo Bora).
  79         So auto-updating is turned off, and these functions do an explicit
  80         update when necessary.
  81         However, something else is still doing too much work when adding/removing
  82         accounts, probably in another part of the application.
  83
  84         * src/maemo/modest-account-view-window.c:
  85         (on_delete_button_clicked), (on_edit_button_clicked),
  86         (on_new_button_clicked): Use the new functions.
  87
  88 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  89
  90         * src/modest-account-mgr-helpers.c:
  91         (modest_account_mgr_set_first_account_as_default):
  92         Sort the list of names alphabetically-by-title, so we choose the first one
  93         based on that.
  94         * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
  95         alphabetically by the title.
  96
  97         This fixes projects.maemo.org bug NB#56418 .
  98
  99         * src/modest-account-mgr-priv.c:
 100         (_modest_account_mgr_account_from_key):
 101         * src/modest-account-mgr.c: (on_key_change): Initialize variables to
 102         avoid a valgrind error, and possible random behaviour.
 103
 104 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 105
 106         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 107         Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
 108         tinymail documentation to say that this can be expected.
 109         Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
 110         pretty, and should not happen, but I would prefer to know when it does.
 111
 112 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 113
 114         * configure.ac: When using the older hildon version, probably on Bora,
 115         require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
 116         to fix the build.
 117         * src/widgets/modest-attachment-view.c:
 118         (modest_attachment_view_set_part_default): Initialize variables, to fix the
 119         build.
 120
 121 2007-05-09  Marcus Bauer  <marcusb@openismus.com>
 122
 123         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
 124         Implemented the prototype. Can be tested with
 125         tests/dbus_api/test_open_message:
 126
 127 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 128
 129         * src/modest-tny-account-store.c:
 130         (modest_tny_account_store_instance_init), (get_password):
 131         * src/modest-ui-actions.c:
 132         (modest_ui_actions_on_password_requested):
 133         Do not store the password in gconf, because this function is called
 134         for non-remembered passwords. Actually use the cached (in the hash map)
 135         password instead of releasing it.
 136         The password will now not be remembered if it is asked via the protected
 137         password dialog, as per the UI spec.
 138
 139 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 140
 141         * src/modest-defs.h:
 142         * src/modest-account-mgr-helpers.h:
 143         * src/modest-account-mgr-helpers.c:
 144         Added modest_server_account_get_username_has_succeeded(),
 145         modest_server_account_set_username_has_succeeded().
 146         (modest_server_account_set_username),
 147         Reset the has-succeeded flag if the username changes.
 148
 149         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 150         * src/maemo/modest-connection-specific-smtp-window.c:
 151         (modest_connection_specific_smtp_window_save_server_accounts):
 152         Use modest_server_account_set_username() instead of using
 153         modest_conf_set_string() directly, so that the has-succeeded flag is always
 154         reset.
 155
 156         * src/modest-ui-actions.c:
 157         (modest_ui_actions_on_password_requested): Dim the username entry if
 158         the username has ever worked, as per the UI spec.
 159
 160 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 161
 162         * src/modest-tny-account-store.c: (get_password):
 163         * src/modest-ui-actions.c:
 164         (modest_ui_actions_on_password_requested):
 165         Allow the username to be changed too, though there is more work to
 166         be done on exactly how this behaves.
 167
 168 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 169
 170         * src/modest-account-mgr-helpers.h:
 171         * src/modest-account-mgr-helpers.c:
 172         Added modest_account_mgr_get_display_name(),
 173         modest_server_account_get_username(),
 174         modest_server_account_set_username(),
 175         modest_server_account_set_password(),
 176         modest_server_account_get_hostname() functions so we do not need to
 177         use the conf API directly.
 178
 179         * src/maemo/modest-main-window.c: (connect_signals):
 180         Actually connect ot the ModestAccountStore::request-password signal,
 181         so that we show the dialog when the password is requested by Tinymail,
 182         for isntance if it is empty.
 183
 184         * src/modest-marshal.list:
 185         * src/modest-tny-account-store.c:
 186         (modest_tny_account_store_class_init), (get_password),
 187         (modest_tny_account_store_alert):
 188         * src/modest-tny-account-store.h:
 189         * src/modest-ui-actions.h:
 190         * src/modest-ui-actions.c:
 191         (modest_ui_actions_on_password_requested):
 192         Change the signal parameters, so it is obvious that we are providing
 193         the non human-readable server name, and receiving both the username
 194         and password, though changing of the username is not yet implemented.
 195         Change the dialog UI to match the Maemo UI specifications, with #idfefing
 196         for the GNOME version.
 197
 198         This should fix the projects.maemo.org bug NB#56209, though it does not
 199         work on Bora, because the gconf_client_get() for the password fails
 200         immediately after we save it with gconf_client_set().
 201
 202 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 203
 204         * configure.ac:
 205         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
 206         caused an undefined symbol error:
 207         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
 208
 209 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 210
 211         * src/modest-tny-account-store.c:
 212         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
 213         using a GError instead of a string message, so we can translate it in
 214         Modest.
 215
 216 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 217
 218         * src/maemo/modest-address-book.c:
 219         (modest_address_book_check_names):
 220         * src/maemo/modest-msg-view-window.c:
 221         (modest_msg_view_window_clipboard_owner_change):
 222         * src/modest-init.c: (modest_init_init_ui):
 223         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
 224         (update_folders_cb), (modest_mail_operation_update_account):
 225         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 226         (modest_ui_actions_on_msg_attachment_clicked),
 227         (modest_ui_actions_on_msg_recpt_activated):
 228         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 229         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 230         (modest_msg_view_search_next):
 231         * src/widgets/modest-recpt-editor.c:
 232         (modest_recpt_editor_on_button_release_event),
 233         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 234         g_message(). At this point we should only be seeing interesting errors on
 235         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 236
 237 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 238
 239         (modest_wizard_dialog_force_title_update):
 240         * src/maemo/easysetup/modest-wizard-dialog.h:
 241         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 242         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 243         can update the title when appropriate. Otherwise the title is wrong if the
 244         pages are added after adding the notebook to the dialog.
 245         This must be a problem in HildonWizardDialog too.
 246         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 247
 248         * src/maemo/easysetup/modest-easysetup-wizard.c:
 249         (create_subsequent_customsetup_pages),
 250         (create_subsequent_easysetup_pages):
 251         Call modest_wizard_dialog_force_title_update() so that the title is
 252         correct even with GTK+ < 2.10.
 253         This fixes projects.maemo.org bug NB#56145 .
 254
 255 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 256
 257         * src/maemo/modest-platform.c:
 258         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 259         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 260         from being shown.
 261
 262 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 263
 264         * src/widgets/modest-window.h:
 265         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 266         and modest_window_save_state(), which invokes it.
 267
 268         * src/widgets/modest-window-mgr.h:
 269         * src/widgets/modest-window-mgr.c:
 270         Added modest_window_mgr_save_state_for_all_windows(), which calls
 271         the save_state vfunc on all registered windows, if implemented.
 272
 273         * src/gnome/modest-msg-edit-window.c:
 274         * src/gnome/modest-msg-view-window.c:
 275         * src/maemo/modest-msg-edit-window.c:
 276         * src/maemo/modest-msg-view-window.c:
 277         * src/maemo/modest-main-window.c:
 278         Specify the existing save_settings functions as implementations of
 279         ModestWindow::save_state_func().
 280
 281         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 282         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 283         enabling hibernation, for instance.
 284
 285         We may need to do the same thing for restoring settings.
 286
 287
 288 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 289
 290         * src/widgets/modest-window-mgr.c:
 291         * src/widgets/modest-window-mgr.h:
 292         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 293         modest_window_mgr_get_hibernation_is_prevented().
 294
 295         * src/maemo/modest-main-window.c:
 296         (on_hildon_program_is_topmost_notify): Prevent hibernation
 297         (possible when the application goes to the background in the WM),
 298         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 299
 300         * src/maemo/easysetup/modest-easysetup-wizard.c:
 301         (modest_easysetup_wizard_dialog_init):
 302         * src/maemo/modest-account-settings-dialog.c:
 303         (modest_account_settings_dialog_init):
 304         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 305         (modest_connection_specific_smtp_edit_window_init):
 306         * src/maemo/modest-connection-specific-smtp-window.c:
 307         (modest_connection_specific_smtp_window_init):
 308         * src/maemo/modest-signature-editor-dialog.c:
 309         (modest_signature_editor_dialog_init):
 310         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 311         prevent hibernation while any of these account settings dialogs are open.
 312
 313 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 314
 315         * src/maemo/Makefile.am:
 316         * src/maemo/modest-osso-state-saving.c:
 317         * src/maemo/modest-osso-state-saving.h: Added
 318         modest_osso_load_state() and modest_osso_save_state() though they do
 319         nothing now. They should iterate through all the open windows and load/save
 320         their state.
 321         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 322         save state when closing.
 323
 324         * src/maemo/modest-main-window.c:
 325         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 326         Add a notification handler for the HildonProgram::is-topmost property,
 327         so we can allow hibernation when the application goes into the background.
 328         But we still need to detect when the accounts setup windows are open so
 329         we can stop hibernation when they are open.
 330         To do this, I also added the main window the HildonProgram. This might have
 331         other side-effects/benefits, and should maybe be done for other windows.
 332
 333         * src/maemo/modest-osso-autosave-callbacks.h:
 334         * src/maemo/modest-osso-autosave-callbacks.c:
 335         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 336         though it does not do anything yet, and we might never need this to do
 337         anything. For instance, we already save drafts.
 338
 339         * src/maemo/modest-platform.c: (modest_platform_init):
 340         Specify the libosso auto-save callback.
 341
 342 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 343
 344         * src/maemo/modest-platform.c:
 345         (modest_platform_set_update_interval):
 346         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 347         aparently stays valid between application instances, so we can use this
 348         to remove and reset it later. According to a maemo-developers email from
 349         David Weinehall.
 350
 351 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 352
 353         * configure.ac: Depend on libalarm for Maemo.
 354
 355         * src/dbus_api/modest-dbus-api.h:
 356         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 357         (on_send_receive), (modest_dbus_req_handler):
 358         Handle a SEND_RECEIVE D-Bus method.
 359
 360         * libmodest-dbus-client/libmodest-dbus-client.c:
 361         (libmodest_dbus_client_send_and_receive):
 362         * libmodest-dbus-client/libmodest-dbus-client.h:
 363         Add C convenience functions for calling the new D-Bus method.
 364
 365         * src/modest-platform.h:
 366         * src/gnome/modest-platform.c:
 367         * src/maemo/modest-platform.c:
 368         Added modest_platform_set_update_interval(), which uses the
 369         alarmd API on Maemo.
 370         (modest_platform_init),
 371         Call modest_platform_set_update_interval(), using a hard-coded
 372         interval for now (until the global settings dialog is implemented),
 373         though I am not sure that this makes sense yet.
 374
 375 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 376
 377         * src/dbus_api/modest-dbus-callbacks.c:
 378         (modest_osso_cb_hw_state_handler):
 379         * src/dbus_api/modest-dbus-callbacks.h:
 380         * src/maemo/modest-platform.c: (modest_platform_init):
 381         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 382         in case this has some effect on the ability for Maemo to ping the
 383         application.
 384
 385 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 386
 387         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 388         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 389         warning. It is probably a logic error, but I need to fix the build.
 390
 391 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 392
 393         * src/modest-account-mgr.h:
 394         * src/modest-account-mgr.c:
 395         (modest_account_mgr_account_names): Add a gboolean enabled_only
 396         parameter, so we can get lists of onlt the enabled accounts.
 397
 398         (modest_account_mgr_add_account),,
 399         (modest_account_mgr_account_with_display_name_exists):
 400         * src/maemo/modest-msg-edit-window.c: (get_transports):
 401         * src/modest-account-mgr-helpers.c:
 402         (modest_account_mgr_set_first_account_as_default):
 403         * src/modest-init.c: (init_default_account_maybe):
 404         * src/modest-tny-account-store.c: (get_accounts):
 405         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 406         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 407         * tests/check_account-mgr.c: (START_TEST):
 408         Provide the extra parameter, as appropriate.
 409
 410         * src/widgets/modest-account-view.c: (update_account_view):
 411         Do not show disabled accounts (meaning that there is no way to
 412         enable/disable accounts in the UI (the feature is not in our UI
 413         specification), so we can use this internally only to mark unfinished
 414         or temporary account data.
 415
 416         * src/maemo/easysetup/modest-easysetup-wizard.c:
 417         (create_account): Add boolean enable parameter, so we can specify FALSE
 418         to create the temporary account.
 419         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 420         (on_before_next): When finishing, when there is a temporary account, just
 421         set it as enabled.
 422         Also, use a timeout to delay the showing of the dialog until gconf is likely
 423         to return correct information, due to a maemo gconf bug that is fixed in
 424         osso 1.1, but not yet in Bora.
 425         However, the dialog stays on screen after it is destroyed.
 426
 427         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 428         for invalid data when cancelling. Use a hildon note instead of a dialog
 429         to complain about invalid data. Do not show the account-saved note if the
 430         account is disabled (a temporary account that will not really be saved for use
 431         until later.)
 432
 433 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 434
 435         * src/modest-account-mgr-helpers.h:
 436         * src/modest-account-mgr-helpers.c:
 437         Added modest_account_mgr_unset_default_account(),
 438         Added modest_account_mgr_set_first_account_as_default().
 439
 440         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 441         If it was the default account, unset the default account name.
 442
 443         * src/maemo/modest-account-view-window.c:
 444         (on_delete_button_clicked): If it was the default account,
 445         set the first remaining account as the default instead.
 446
 447         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 448         a NULL account or a NULL default account, to prevent a crash. This should
 449         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 450
 451
 452 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 453
 454         * src/widgets/modest-recpt-editor.c:
 455         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 456         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 457         TODO comment for this. This fixes the build.
 458
 459         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 460         be the best place for it. This will in future update all auto-update accounts,
 461         rather than just the current/default account, when that gconf key exists.
 462         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 463         if there are no accounts, before calling do_send_receive().
 464         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 465
 466         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 467         * src/maemo/modest-main-window-ui.h:
 468         * src/maemo/modest-main-window.c: (on_connection_changed),
 469         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 470         directly, becaue the signal handler does more.
 471
 472 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 473
 474         * src/modest-account-mgr-helpers.c:
 475         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 476         for the case that the account does not exist.
 477
 478         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 479         (equivalent to the modest account name) rather than the tinymail account name
 480         (equivalent to the modest account title - human readable) to get the account data.
 481         Check for null account data to prevent the crash, and add a TODO comment saying that
 482         this needs fixing because it is using the server account name instead of the account name.
 483
 484 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 485
 486         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 487         * src/maemo/modest-account-settings-dialog.c: (show_error),
 488         (show_ok):
 489         Use hildon_note_new_information() for informative and error messages,
 490         which seems to be expected for Maemo applications (no documentation that I know of
 491         says this). I am surprised that there is no distinction between info and error
 492         dialogs.
 493
 494 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 495
 496         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 497         it is easy to find where this is used.
 498
 499         * src/maemo/easysetup/modest-easysetup-wizard.c:
 500         (create_page_welcome), (create_page_account_details),
 501         (create_page_user_details), (create_page_complete_easysetup),
 502         (create_page_custom_incoming), (create_page_custom_outgoing),
 503         (create_page_complete_custom):
 504         * src/maemo/modest-account-settings-dialog.c:
 505         (create_page_account_details), (create_page_user_details),
 506         (create_page_incoming), (create_page_outgoing):
 507         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 508         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 509         (modest_connection_specific_smtp_edit_window_init):
 510         * src/maemo/modest-connection-specific-smtp-window.c:
 511         (modest_connection_specific_smtp_window_init):
 512         * src/maemo/modest-signature-editor-dialog.c:
 513         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 514         and scrolling policy as per the Email Application Layout Guide, if I have
 515         understood it.
 516
 517 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 518
 519         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 520         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 521         which were empty, because these vfuncs have been removed from TnyAccountStore.
 522         This fixes the build.
 523
 524 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 525
 526         * src/maemo/modest-main-window.c:
 527         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 528         showing/hiding it. Added TODO because it probably should not be NULL.
 529         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 530         because unnecessary g_warnings() make degugging difficult.
 531
 532 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 533
 534         * src/maemo/modest-msg-edit-window.c:
 535         (modest_msg_edit_window_select_color),
 536         (modest_msg_edit_window_select_background_color): 2 const corrections and
 537         moving 2 #endifs before closing brackets, to fix the build.
 538
 539 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 540
 541         * src/maemo/easysetup/modest-easysetup-wizard.h:
 542         * src/maemo/easysetup/modest-easysetup-wizard.c:
 543         (modest_easysetup_wizard_dialog_finalize),
 544         (on_button_edit_advanced_settings), (create_page_complete_custom),
 545         (on_response), (create_account):
 546         Implement the Advanced Settings edit button, by saving the account information,
 547         for the Advanded Settings dialog to use directly from gconf, and removing it
 548         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 549         Bug #5533 in the projects.maemo.org bugzilla.
 550
 551 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 552
 553         * src/maemo/modest-msg-view-window.c:
 554         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 555         when opening a message window.
 556
 557 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 558
 559         * src/maemo/easysetup/modest-easysetup-wizard.c:
 560         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 561         match the UI spec.
 562
 563         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 564         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 565         gconf settings. I probably added more checks than necessary, but that is safer.
 566
 567         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 568         variable to fix the build, but this seems to be used when it is still NULL.
 569
 570 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 571
 572         * src/modest-platform.h:
 573         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 574         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 575         * src/modest-main.c: Implement this function so we can avoid using
 576         maemo-specific API from cross-platform code.
 577         (main):
 578         * src/modest-tny-account-store.c:
 579         (get_smtp_specific_transport_account_for_open_connection):
 580         * src/modest-ui-actions.c: (check_for_connection),
 581         (modest_ui_actions_on_item_not_found):
 582         Use modest_platform_connect_and_wait() and put #idefs around other
 583         maemo-specific code, because only maemo currently has a way to
 584         identify connection names.
 585
 586 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 587
 588         * src/modest-tny-account-store.h:
 589         * src/modest-tny-account-store.c:
 590         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 591         the connection-specific SMTP server settings in the configuration.
 592
 593         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 594         (on_idle_mail_to):
 595         * src/maemo/modest-main-window.c: (on_connection_changed),
 596         (connect_signals):
 597         * src/modest-main.c: (main), (start_ui), (send_mail):
 598         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 599         that is what is intended.
 600
 601         * src/modest-ui-actions.c: (action_send), (action_receive),
 602         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 603         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 604         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 605         SMTP server is used when it is specified.
 606
 607         (modest_ui_actions_on_send_receive):
 608         Check that a connection is open before proceeding.
 609         Receive and then send, instead of vice-versa, as per the specification.
 610
 611 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 612
 613         * src/modest-mail-operation.c:
 614         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 615         though I guess it should be something other than NULL.
 616
 617 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 618
 619         * src/maemo/easysetup/modest-easysetup-wizard.c:
 620         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 621         combo twice, to avoid an g_warning and to make it visible again.
 622         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 623         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 624         (already intended) dereference when detaching, because we then recreate the menu.
 625         But I am not sure why the warning was happening, and it is possible that this is a memory
 626         leak.
 627
 628 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 629
 630         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 631         and uri_parse_mailto() utility functions.
 632         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 633         the mailto URI.
 634         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 635
 636 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 637
 638         * src/dbus_api/modest-dbus-api.h:
 639         * src/dbus_api/modest-dbus-callbacks.c:
 640         Use an idle callback to execute the modest code in the application's own thread.
 641         Remove the helloworld example method.
 642         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 643         parsed, and the open-message method is not implemented because this is not yet implemented in
 644         modest itself.
 645         * libmodest-dbus-client/libmodest-dbus-client.c:
 646         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 647         (libmodest_dbus_client_open_message):
 648         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 649
 650         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 651         body without crashing.
 652
 653         * tests/dbus_api/Makefile.am:
 654         * tests/dbus_api/test_mail_to.c:
 655         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 656
 657 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 658
 659         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 660         Added file to fix the build. Sorry.
 661
 662         * src/dbus_api/Makefile.am:
 663         * src/dbus_api/modest-dbus-api.h:
 664         * src/dbus_api/modest-dbus-callbacks.h:
 665         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 666         (modest_dbus_req_handler):
 667         Put constants in a separate header so it can be reused by the
 668         client library, without duplication
 669
 670         * libmodest-dbus-client/Makefile.am:
 671         * libmodest-dbus-client/libmodest-dbus-client.c:
 672         (libmodest_dbus_client_call_helloworld),
 673         (libmodfest_dbus_client_send_mail),
 674         (libmodfest_dbus_client_mailto),
 675         (libmodfest_dbus_client_open_message):
 676         * libmodest-dbus-client/libmodest-dbus-client.h:
 677         (Partly) Implement a send_mail D-Bus method.
 678
 679         * tests/dbus_api/Makefile.am:
 680         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 681         the send_email D-Bus method.
 682
 683 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 684
 685         * Makefile.am:
 686         * configure.ac:
 687         * libmodest-dbus-client/Makefile.am:
 688         * libmodest-dbus-client/libmodest-dbus-client.c:
 689         * libmodest-dbus-client/libmodest-dbus-client.h:
 690         * tests/dbus_api/Makefile.am:
 691         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 692         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 693
 694 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 695
 696         * src/maemo/easysetup/modest-easysetup-wizard.c:
 697         (create_page_account_details):
 698         * src/maemo/modest-account-settings-dialog.c:
 699         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 700         widgets, because this might not be the default in future versions of the Maemo GTK+.
 701         However, I can not not get capitalization to work even in a simple test case.
 702
 703 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 704
 705         * src/maemo/easysetup/modest-easysetup-wizard.c:
 706         (create_page_custom_incoming), (create_page_custom_outgoing):
 707         * src/maemo/modest-account-settings-dialog.c:
 708         (create_page_account_details), (create_page_incoming),
 709         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 710         instead of using gtk_check_button_with_label(), so they are aligned like the other
 711         widgets, as per the UI spec.
 712
 713 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 714
 715         * src/maemo/easysetup/modest-easysetup-wizard.c:
 716         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 717         * src/widgets/modest-validating-entry.c:
 718         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 719         Modest prefix instead of an EasySetup prefix.
 720
 721 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 722
 723         * src/widgets/modest-validating-entry.h:
 724         * src/widgets/modest-validating-entry.c: (on_insert_text),
 725         Added easysetup_validating_entry_set_max_func(), used to set a callback
 726         to call when the max number of characters is reached. GtkEntry has a max-length
 727         already but is silent about it.
 728
 729         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 730         (create_page_account_details), (create_page_user_details),
 731         (create_account):
 732         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 733         (create_page_account_details), (create_page_user_details),
 734         (create_page_outgoing):
 735         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 736         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 737         the UI spec, when the user tries to enter more than the max number of characters.
 738
 739 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 740
 741         * src/maemo/easysetup/modest-easysetup-wizard.c:
 742         (create_page_user_details), (create_page_custom_incoming),
 743         (create_page_custom_outgoing):
 744         * src/maemo/modest-account-settings-dialog.c:
 745         (create_page_user_details), (create_page_incoming),
 746         (create_page_outgoing):
 747         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 748         (modest_connection_specific_smtp_edit_window_init):
 749         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 750         not appropriate. Bad Maemo-specific defaults!.
 751
 752 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 753
 754         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 755         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 756         (modest_signature_editor_dialog_set_settings):
 757         Disable the label and textview when the checkbox is disabled, and use the
 758         specified (UI spec) default signature text.
 759
 760 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 761
 762         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 763         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 764
 765         * src/modest-defs.h:
 766         * src/modest-account-mgr-helpers.h:
 767         * src/modest-account-mgr-helpers.c:
 768         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 769
 770         * src/maemo/Makefile.am:
 771         * src/maemo/modest-signature-editor-dialog.c:
 772         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 773         as per the UI spec.
 774
 775         * src/maemo/modest-account-settings-dialog.h:
 776         * src/maemo/modest-account-settings-dialog.c:
 777         (modest_account_settings_dialog_finalize), (on_button_signature),
 778         (save_configuration): Use the new dialog when the Edit button is pressed, and
 779         save the changes if necessary, as per the UI spec.
 780
 781 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 782
 783         * src/maemo/Makefile.am:
 784         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 785         based on maemo-develoers email from Dirk.
 786
 787         * src/maemo/easysetup/modest-easysetup-wizard.c:
 788         (create_page_welcome), (create_page_account_details),
 789         (create_page_user_details), (create_page_complete_easysetup),
 790         (create_page_custom_incoming), (create_page_custom_outgoing),
 791         (create_page_complete_custom),
 792         (modest_easysetup_wizard_dialog_init):
 793         * src/maemo/modest-account-settings-dialog.c:
 794         (create_page_account_details), (create_page_user_details),
 795         (create_page_incoming), (create_page_outgoing),
 796         (modest_account_settings_dialog_init):
 797         * src/maemo/modest-connection-specific-smtp-window.c:
 798         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 799
 800 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 801
 802         * src/maemo/easysetup/modest-easysetup-wizard.c:
 803         (create_page_account_details), (create_page_custom_outgoing),
 804         (create_page_complete_custom):
 805         * src/maemo/modest-account-settings-dialog.c:
 806         (create_page_user_details), (create_page_incoming),
 807         (create_page_outgoing):
 808         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 809         (modest_connection_specific_smtp_edit_window_init):
 810         Use the correct (UI spec) port min/max, and use horizontal separators,
 811         as per the UI spec.
 812
 813 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 814
 815         * src/maemo/easysetup/modest-easysetup-wizard.c:
 816         (set_default_custom_servernames):
 817         * src/maemo/modest-account-settings-dialog.c:
 818         (create_page_incoming), (on_combo_outgoing_security_changed),
 819         (on_combo_incoming_security_changed), (create_page_outgoing),
 820         (modest_account_settings_dialog_set_account_name),
 821         (save_configuration):
 822         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 823         (on_combo_security_changed),
 824         (modest_connection_specific_smtp_edit_window_init),
 825         (modest_connection_specific_smtp_edit_window_set_connection),
 826         (modest_connection_specific_smtp_edit_window_get_settings):
 827         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 828         as per the UI spec.
 829
 830 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 831
 832         * po/en_GB.po:
 833         * src/maemo/easysetup/modest-easysetup-wizard.c:
 834         (create_page_custom_outgoing), (create_page_complete_custom):
 835         * src/maemo/modest-account-settings-dialog.c:
 836         (create_page_user_details), (create_page_outgoing):
 837         * src/maemo/modest-account-view-window.c: (button_box_new):
 838         Use changed logical IDs as per the most recent UI spec:
 839         mcen_bd_emailsetup_edit -> mcen_bd_edit
 840         mcen_bd_emailsetup_delete -> mcen_bd_delete
 841         mcen_bd_emailsetup_close -> mcen_bd_close
 842
 843 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 844
 845         * configure.ac:
 846         * src/Makefile.am:
 847         * src/dbus_api/Makefile.am:
 848         * src/dbus_api/modest-dbus-callbacks.c:
 849         * src/dbus_api/modest-dbus-callbacks.h:
 850         * src/maemo/modest-platform.c: (modest_platform_init):
 851         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 852         method.
 853         * tests/Makefile.am:
 854         * tests/dbus_api/Makefile.am:
 855         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 856
 857 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 858
 859         * src/maemo/modest-account-settings-dialog.c:
 860         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 861         Removed unnecessary includes.
 862
 863 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 864
 865         * src/maemo/easysetup/modest-easysetup-wizard.c:
 866         * src/maemo/modest-account-settings-dialog.c:
 867         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 868         * src/widgets/Makefile.am:
 869         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 870         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 871         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 872         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 873         * src/widgets/modest-secureauth-combo-box.c:
 874         * src/widgets/modest-secureauth-combo-box.h:
 875         * src/widgets/modest-serversecurity-combo-box.c:
 876         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 877         made the GObject names more consistent with the rest of the Modest code.
 878
 879 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 880
 881         * src/maemo/easysetup/Makefile.am:
 882         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 883         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 884         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 885         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 886         * src/maemo/easysetup/modest-easysetup-wizard.c:
 887         * src/maemo/easysetup/modest-validating-entry.c:
 888         * src/maemo/easysetup/modest-validating-entry.h:
 889         * src/maemo/modest-account-settings-dialog.c:
 890         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 891         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 892         widgets/ because they are used outside of easysetup too. After checking in,
 893         svn will allow me to rename them too.
 894
 895 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 896
 897         * src/gnome/modest-msg-edit-window.c:
 898         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 899         linker error, to fix the build on the GNOME platform.
 900         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 901         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 902         ifdefed out to avoid a warning.
 903
 904 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 905
 906         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 907         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 908         some alternative for GTK+ 2.6.
 909
 910 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 911
 912         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 913
 914         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 915         specified for EmailAccountsDialog in UI spec.
 916
 917         * src/maemo/easysetup/modest-easysetup-wizard.c:
 918         * src/maemo/easysetup/modest-easysetup-wizard.h:
 919         * src/maemo/modest-account-settings-dialog.c:
 920         * src/maemo/modest-account-settings-dialog.h:
 921         Reuse a member window widget for the connection-specific SMTP server accounts,
 922         so we can tell it to create/save the accounts only if we actually save changes.
 923
 924         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 925         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 926         (modest_connection_specific_smtp_edit_window_get_settings):
 927         Return a struct instance for temporarily remembering the entered data.
 928
 929         * src/maemo/modest-connection-specific-smtp-window.h:
 930         * src/maemo/modest-connection-specific-smtp-window.c:
 931         (modest_connection_specific_smtp_window_finalize),
 932         (modest_connection_specific_smtp_window_fill_with_connections),
 933         (on_button_edit),
 934         (modest_connection_specific_smtp_window_save_server_accounts),
 935         (update_model_server_names): Do not actually save data until asked,
 936         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 937
 938         (on_selection_changed),
 939         (modest_connection_specific_smtp_window_init): Disable the edit
 940         button when nothing is selected.
 941
 942         * src/modest-account-mgr-helpers.c:
 943         * src/modest-account-mgr-helpers.h:
 944         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 945         elsewhere.
 946
 947 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 948
 949         * src/modest-account-mgr-helpers.h:
 950         * src/modest-account-mgr-helpers.c:
 951         (modest_account_mgr_get_unused_account_name),
 952         (modest_account_mgr_get_unused_account_display_name): Added these
 953         utility functions, to avoid code duplication.
 954
 955         * src/maemo/easysetup/modest-easysetup-wizard.c:
 956         (create_page_account_details), (create_account):
 957         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 958         (on_combo_security_changed),
 959         (modest_connection_specific_smtp_edit_window_init),
 960         (modest_connection_specific_smtp_edit_window_save_settings):
 961         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 962         * src/maemo/modest-connection-specific-smtp-window.c:
 963         (modest_connection_specific_smtp_window_finalize),
 964         (modest_connection_specific_smtp_window_fill_with_connections),
 965         (on_button_edit), (modest_connection_specific_smtp_window_init):
 966         * src/maemo/modest-connection-specific-smtp-window.h:
 967         Implementing saving of connection-specific server accounts.
 968
 969         But I need to refactor this so we can save the data for each
 970         possible connection-specific account and only actually create the server accounts
 971         when the easysetup finished, or the OK button is pressed on the account settings
 972         dialog.
 973
 974 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 975
 976         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 977         (on_combo_security_changed):
 978         (modest_connection_specific_smtp_edit_window_init):
 979         Auto-fill the port number as in the account settings.
 980
 981         (modest_connection_specific_smtp_edit_window_set_connection):
 982         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 983         * src/maemo/modest-connection-specific-smtp-window.c:
 984         (fill_with_connections), (on_button_edit),
 985         (modest_connection_specific_smtp_window_init):
 986         Turn the edit window into a dialog to simplify the code, and
 987         set a WM hint as in a GtkDialog, because only a popup can be on top of
 988         another window in Maemo, and popups usually have no WM decoration.
 989
 990         * src/modest-defs.h:
 991         * src/modest-account-mgr-helpers.c:
 992         (modest_account_mgr_set_connection_specific_smtp),
 993         (modest_account_mgr_remove_connection_specific_smtp),
 994         (modest_account_mgr_get_connection_specific_smtp):
 995         * src/modest-account-mgr-helpers.h: Some functions to write the
 996         connection-specific SMTP server information. Not yet used.
 997
 998
 999         * src/widgets/modest-folder-view.c: (text_cell_data):
1000         Fix a warning about an uninitialized variable.
1001         (on_configuration_key_changed): Put an #ifdef around the use
1002         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1003
1004 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1005
1006         * src/maemo/modest-account-settings-dialog.h:
1007         * src/maemo/modest-account-settings-dialog.c:
1008         Added connect_for_modified() utility function to mark the new modified boolean.
1009
1010         (create_page_account_details), (create_page_user_details),
1011         (create_page_incoming), (create_page_outgoing), (on_response),
1012         (modest_account_settings_dialog_init),
1013         (modest_account_settings_dialog_set_account_name):
1014         Only warn about unsaved changes when there are actually unsaved changes.
1015
1016         * src/modest-account-mgr-helpers.c:
1017         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1018         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1019         to get the data from there in future.
1020
1021 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1022
1023         * src/modest-defs.h:
1024
1025         * src/modest-account-mgr-helpers.h:
1026         * src/modest-account-mgr-helpers.c:
1027         Store the security account setting in a single conf key instead of using
1028         the options list, so that the list is left for just the to-be-removed camel hack,
1029         and because gconf_client_set_list() is failing for some reason.
1030
1031         * src/modest-account-mgr.c:
1032         (modest_account_mgr_add_server_account):
1033         * src/maemo/modest-account-settings-dialog.c:
1034         (modest_account_settings_dialog_set_account_name),
1035         (save_configuration): Use the renamed functions.
1036
1037
1038 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1039
1040         * src/widgets/Makefile.am:
1041         * src/widgets/modest-limit-retrieve-combo-box.c:
1042         * src/widgets/modest-limit-retrieve-combo-box.h:
1043         * src/widgets/modest-retrieve-combo-box.c:
1044         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1045         the account settings dialog.
1046
1047         * src/modest-defs.h:
1048         * src/modest-account-mgr-helpers.h:
1049         * src/modest-account-mgr-helpers.c:
1050         (modest_server_account_get_option_secure_auth),
1051         (modest_server_account_set_option_secure_auth):
1052         * src/modest-account-mgr.c:
1053         (modest_account_mgr_add_server_account):
1054         Use the existing AUTH_MECH conf key for the secure-auth setting,
1055         instead of putting it in the list options, because this was actually used already.
1056
1057         * src/maemo/modest-account-settings-dialog.c:
1058         (create_page_account_details),
1059         (modest_account_settings_dialog_set_account_name),
1060         (save_configuration):
1061         * src/maemo/modest-account-settings-dialog.h:
1062         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1063         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1064
1065 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1066
1067         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1068         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1069         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1070
1071         * src/modest-defs.h:
1072         * src/maemo/modest-account-settings-dialog.c:
1073         (create_page_incoming), (on_combo_outgoing_security_changed),
1074         (on_combo_incoming_security_changed), (create_page_outgoing),
1075         (modest_account_settings_dialog_set_account_name),
1076         (save_configuration): Load/Save the port number, and change it when the
1077         security combo changes, to suitable defaults.
1078
1079 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1080
1081         * src/modest-account-mgr.c:
1082         (modest_account_mgr_add_server_account): Set the security and secure-auth
1083         options, and add a comment saying that the other camel-specific options should be
1084         removed in future.
1085
1086 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1087
1088         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1089         found by valgrind.
1090         * src/modest-tny-account-store.c: (account_list_free),
1091         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1092         cursor->data after unreffing it. But there is some strange stuff there so it might not be
1093         easy to fix.
1094
1095 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1096
1097         * src/modest-protocol-info.c:
1098         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1099         is required by our UI spec. Maybe something in our implementation will use this eventually.
1100         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1101         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1102         instead of the previous 0 placeholder.
1103
1104         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1105         secure-auth settings.
1106         * src/modest-account-mgr-helpers.h:
1107         * src/modest-account-mgr-helpers.c:
1108         (modest_server_account_data_get_option_secure_auth),
1109         (modest_server_account_set_option_secure_auth),
1110         (modest_server_account_data_get_option_security),
1111         (modest_server_account_set_option_security): Added this API for getting and setting the security
1112         and secure-auth settings.
1113
1114         * src/maemo/modest-account-settings-dialog.h:
1115         * src/maemo/modest-account-settings-dialog.c:
1116         (modest_account_settings_dialog_finalize), (check_data),
1117         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1118         about changing titles.
1119         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1120         (save_configuration): Save the security and secure-auth settings.
1121
1122         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1123         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1124
1125 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1126
1127         * src/modest-defs.h:
1128         * src/modest-account-mgr.c:
1129         (modest_account_mgr_add_server_account):
1130         Added and used defines for the options key and value pair strings,
1131         that are used so far, though they do not seem to correspond to anything in our
1132         UI specs or ModestProtocol enum.
1133
1134         * src/modest-account-mgr-helpers.h:
1135         * src/modest-account-mgr-helpers.c:
1136         (compare_option_strings_for_name),
1137         (modest_server_account_data_get_option_value),
1138         (modest_server_account_data_get_option_bool),
1139         (modest_account_mgr_get_server_account_option):
1140         Added helper functions for parsing the options GSList.
1141
1142 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1143
1144         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1145         display name is based on the supplied account name.
1146         * src/modest-account-mgr.c:
1147         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1148         with an inefficient, but good-enough, implementation.
1149
1150         * src/maemo/easysetup/modest-easysetup-wizard.c:
1151         (create_page_account_details), (on_before_next), (create_account):
1152         Check for existing display names rather than (non-user-visible) account names, and just
1153         create and set a unique account name at the end.
1154
1155         * src/maemo/modest-account-settings-dialog.c:
1156         (modest_account_settings_dialog_init),
1157         (modest_account_settings_dialog_set_account_name),
1158         (create_page_incoming): Show the display name, instead of the account name.
1159         (on_response): Do some (not all) extra checks, as in the UI spec.
1160         (save_configuration): Save the display name if it was changed.
1161
1162 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1163
1164         * po/en_GB.po: Added needed logical ID and translation.
1165         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1166         (init_view): Made the is-default column clicking work.
1167
1168 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1169
1170         * configure.ac:
1171         * src/maemo/easysetup/Makefile.am:
1172         * src/maemo/easysetup/modest-easysetup-wizard.c:
1173         (modest_easysetup_wizard_dialog_init):
1174         * src/maemo/easysetup/provider-data-test.keyfile:
1175         * src/maemo/easysetup/provider-data.keyfile:
1176         Moved the provider data file to the new modest-providers-data package and used it from there.
1177
1178 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1179
1180         * src/modest-local-folder-info.c:
1181         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1182         N_() was already used on the static strings, but this just marks it for translation without
1183         using the translation.
1184
1185 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1186
1187         * src/maemo/modest-account-settings-dialog.c:
1188         (create_page_incoming),
1189         (modest_account_settings_dialog_set_account_name):
1190         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1191         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1192         I will do this if nobody else gets there first.
1193
1194 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1195
1196         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1197         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1198         save the security stuff.
1199
1200 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1201
1202         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1203         Set the email address and user fullname, which I now see must be
1204         done separately.
1205
1206         * src/maemo/modest-account-settings-dialog.h:
1207         * src/maemo/modest-account-settings-dialog.c:
1208          (on_response),
1209         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1210         leave-on-server and authentication.
1211         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1212         how to do the rest.
1213
1214 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1215
1216
1217         * src/maemo/modest-account-settings-dialog.c:
1218         * src/maemo/modest-account-settings-dialog.h:
1219         Most (but not all) of the widgets are now present as specified by the UI spec.
1220         No changes are yet saved, and some details are not properly shown yet.
1221
1222         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1223
1224 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1225
1226         * src/maemo/Makefile.am:
1227         * src/maemo/modest-account-settings-dialog.c:
1228         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1229         an existing account. Doesn't do much yet.
1230
1231         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1232         Open the accounts settings dialog when Edit is clicked.
1233
1234 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1235
1236         * src/maemo/easysetup/Makefile.am:
1237         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1238         (load_from_file):
1239         * src/maemo/easysetup/modest-easysetup-wizard.c:
1240         (modest_easysetup_wizard_dialog_init):
1241         Try to get the source directory from the build system,
1242         instead of hard-coding "./" into the source code, when opening our local
1243         copies of the configuration files.
1244         But this still fails when opening the wizard from the Accounts window,
1245         maybe because the working directory seems to change at runtime.
1246         So the wizard will fail the second time unless you copy the files into their
1247         proper locations - see the stdout warnings for the paths.
1248
1249         (create_page_account_details),(on_before_next):
1250         Check for existing non-server accounts instead of server accounts,
1251         so the default account name is useful again, and to prevent trying to
1252         recreate accounts.
1253
1254         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1255         Show the wizard when New is clicked.
1256
1257         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1258         (init_view): Show the column headers, and show the columns that are
1259         specified in the UI specs. However, something in Maemo's GTK+ prevents
1260         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1261         change the default account. This is despite unsetting the special properties.
1262
1263 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1264
1265         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1266         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1267         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1268         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1269         to make that clearer.
1270         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1271
1272 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1273
1274         * src/maemo/modest-account-view-window.c:
1275         (modest_account_view_window_init),
1276         (modest_account_view_window_new):
1277         Use the same buttons as specified in the
1278         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1279         the existing widgets, which never had a chance of working.
1280         Put the ModestAccountView treeview in a scrolled window.
1281         Do not repeat the initialization in both _init() and _new().
1282
1283         * src/widgets/modest-account-view.c: (update_account_view):
1284         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1285         this widget and window shows no accounts.
1286
1287         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1288
1289 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1290
1291         * src/maemo/easysetup/modest-easysetup-wizard.c:
1292         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1293         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1294         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1295         which seems wrong.
1296
1297         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1298         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1299         accounts exist yet, as in the UI spec.
1300
1301         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1302
1303 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1304
1305         * src/maemo/Makefile.am:
1306         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1307         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1308         New window for editing connection-specific smtp details.
1309         Not fully implemented.
1310
1311         * src/maemo/modest-connection-specific-smtp-window.c:
1312         (modest_connection_specific_smtp_window_finalize) :
1313         unref the tree model.
1314         (on_button_edit): Show the edit window.
1315
1316 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1317
1318         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1319         error for me.
1320
1321         * src/maemo/Makefile.am:
1322         * src/maemo/modest-connection-specific-smtp-window.c:
1323         * src/maemo/modest-connection-specific-smtp-window.h:
1324         New window for showing the list of connections, for connection-specific
1325         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1326         * src/maemo/easysetup/modest-easysetup-wizard.c:
1327         (create_page_custom_outgoing): Show the new window when the button is clicked.
1328
1329 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1330
1331         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1332         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1333         * src/maemo/modest-msg-edit-window.c:
1334         (modest_msg_edit_window_insert_image):
1335         * src/modest-conf.c: (modest_conf_key_escape):
1336         * src/modest-mail-operation.c:
1337         (modest_mail_operation_send_new_mail):
1338         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1339         (modest_ui_actions_on_new_account):
1340         * src/widgets/modest-attachment-view.c: (update_filename_request):
1341         * src/widgets/modest-mail-header-view.c:
1342         Corrected warnings that were breaking the build, by commenting out unused variables,
1343         and a function, and by including a header.
1344
1345 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1346
1347         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1348         so we can #ifdef around platform-specific code when necessary.
1349         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1350         to allow this to build for the GNOME platform too.
1351
1352 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1353
1354         * src/maemo/easysetup/modest-easysetup-wizard.c:
1355         Added util_increment_name() and used it in create_page_account_details()
1356         to make sure that the default account name is always a new name.
1357
1358         (modest_easysetup_wizard_dialog_init),
1359         (set_default_custom_servernames): Some minor memory management fixes.
1360
1361 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1362
1363         * Makefile.am:
1364         * configure.ac:
1365         * src/modest-runtime.c: (init_i18n): Restored the translation
1366         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1367         are defined in config.h, and the translations are installed.
1368
1369         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1370         is defined for translation.
1371
1372 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1373
1374         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1375         (load_from_file):
1376         * src/maemo/easysetup/modest-easysetup-wizard.c:
1377         (modest_easysetup_wizard_dialog_init):
1378         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1379         Use realistic paths (though they should use $prefix generically) to the
1380         mcc_mapping and provider-data.keyfile files which might work when they
1381         are installed by the future version of the operator-wizard package,
1382         and then fallback to paths in our source code, with an explanatory
1383         warning.
1384
1385 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1386
1387         * configure.ac:
1388         * src/Makefile.am:
1389         * src/maemo/Makefile.am:
1390         * src/maemo/easysetup/: Added files from the previously-exernal
1391         osso-modest-easysetup.
1392         * src/maemo/modest-main-window-ui.h:
1393         * src/modest-ui-actions.c:
1394         * src/modest-ui-actions.h:
1395         Added modest_ui_actions_on_new_account() as a signal handler for the
1396         New Account menu item. It shows the easysetup wizard.
1397         * po/en_GB.po: Added additional needed logical IDs and translations.
1398
1399 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1400 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1401