1 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.h:
4 * src/modest-tny-account-store.c:
5 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
6 the connection-specific SMTP server settings in the configuration.
8 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
10 * src/maemo/modest-main-window.c: (on_connection_changed),
12 * src/modest-main.c: (main), (start_ui), (send_mail):
13 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
14 that is what is intended.
16 * src/modest-ui-actions.c: (action_send), (action_receive),
17 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
18 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
19 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
20 SMTP server is used when it is specified.
22 (modest_ui_actions_on_send_receive):
23 Check that a connection is open before proceeding.
24 Receive and then send, instead of vice-versa, as per the specification
26 2007-04-26 Murray Cumming <murrayc@murrayc.com>
28 * src/modest-mail-operation.c:
29 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
30 though I guess it should be something other than NULL.
32 2007-04-26 Murray Cumming <murrayc@murrayc.com>
34 * src/maemo/easysetup/modest-easysetup-wizard.c:
35 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
36 combo twice, to avoid an g_warning and to make it visible again.
37 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
38 attached before detaching it, to avoid a g_warning, and add comment about the implicit
39 (already intended) dereference when detaching, because we then recreate the menu.
40 But I am not sure why the warning was happening, and it is possible that this is a memory
43 2007-04-25 Murray Cumming <murrayc@murrayc.com>
45 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
46 and uri_parse_mailto() utility functions.
47 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
49 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
51 2007-04-24 Murray Cumming <murrayc@murrayc.com>
53 * src/dbus_api/modest-dbus-api.h:
54 * src/dbus_api/modest-dbus-callbacks.c:
55 Use an idle callback to execute the modest code in the application's own thread.
56 Remove the helloworld example method.
57 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
58 parsed, and the open-message method is not implemented because this is not yet implemented in
60 * libmodest-dbus-client/libmodest-dbus-client.c:
61 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
62 (libmodest_dbus_client_open_message):
63 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
65 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
66 body without crashing.
68 * tests/dbus_api/Makefile.am:
69 * tests/dbus_api/test_mail_to.c:
70 * tests/dbus_api/test_open_message.c: New tests for the new methods.
72 2007-04-24 Murray Cumming <murrayc@murrayc.com>
74 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
75 Added file to fix the build. Sorry.
77 * src/dbus_api/Makefile.am:
78 * src/dbus_api/modest-dbus-api.h:
79 * src/dbus_api/modest-dbus-callbacks.h:
80 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
81 (modest_dbus_req_handler):
82 Put constants in a separate header so it can be reused by the
83 client library, without duplication
85 * libmodest-dbus-client/Makefile.am:
86 * libmodest-dbus-client/libmodest-dbus-client.c:
87 (libmodest_dbus_client_call_helloworld),
88 (libmodfest_dbus_client_send_mail),
89 (libmodfest_dbus_client_mailto),
90 (libmodfest_dbus_client_open_message):
91 * libmodest-dbus-client/libmodest-dbus-client.h:
92 (Partly) Implement a send_mail D-Bus method.
94 * tests/dbus_api/Makefile.am:
95 * tests/dbus_api/test_send_mail.c: (main): Added a test for
96 the send_email D-Bus method.
98 2007-04-24 Murray Cumming <murrayc@murrayc.com>
102 * libmodest-dbus-client/Makefile.am:
103 * libmodest-dbus-client/libmodest-dbus-client.c:
104 * libmodest-dbus-client/libmodest-dbus-client.h:
105 * tests/dbus_api/Makefile.am:
106 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
107 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
109 2007-04-24 Murray Cumming <murrayc@murrayc.com>
111 * src/maemo/easysetup/modest-easysetup-wizard.c:
112 (create_page_account_details):
113 * src/maemo/modest-account-settings-dialog.c:
114 (create_page_account_details): Explicitly set auto-capitalization mode for the title
115 widgets, because this might not be the default in future versions of the Maemo GTK+.
116 However, I can not not get capitalization to work even in a simple test case.
118 2007-04-24 Murray Cumming <murrayc@murrayc.com>
120 * src/maemo/easysetup/modest-easysetup-wizard.c:
121 (create_page_custom_incoming), (create_page_custom_outgoing):
122 * src/maemo/modest-account-settings-dialog.c:
123 (create_page_account_details), (create_page_incoming),
124 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
125 instead of using gtk_check_button_with_label(), so they are aligned like the other
126 widgets, as per the UI spec.
128 2007-04-24 Murray Cumming <murrayc@murrayc.com>
130 * src/maemo/easysetup/modest-easysetup-wizard.c:
131 * src/maemo/modest-connection-specific-smtp-edit-window.c:
132 * src/widgets/modest-validating-entry.c:
133 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
134 Modest prefix instead of an EasySetup prefix.
136 2007-04-23 Murray Cumming <murrayc@murrayc.com>
138 * src/widgets/modest-validating-entry.h:
139 * src/widgets/modest-validating-entry.c: (on_insert_text),
140 Added easysetup_validating_entry_set_max_func(), used to set a callback
141 to call when the max number of characters is reached. GtkEntry has a max-length
142 already but is silent about it.
144 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
145 (create_page_account_details), (create_page_user_details),
147 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
148 (create_page_account_details), (create_page_user_details),
149 (create_page_outgoing):
150 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
151 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
152 the UI spec, when the user tries to enter more than the max number of characters.
154 2007-04-23 Murray Cumming <murrayc@murrayc.com>
156 * src/maemo/easysetup/modest-easysetup-wizard.c:
157 (create_page_user_details), (create_page_custom_incoming),
158 (create_page_custom_outgoing):
159 * src/maemo/modest-account-settings-dialog.c:
160 (create_page_user_details), (create_page_incoming),
161 (create_page_outgoing):
162 * src/maemo/modest-connection-specific-smtp-edit-window.c:
163 (modest_connection_specific_smtp_edit_window_init):
164 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
165 not appropriate. Bad Maemo-specific defaults!.
167 2007-04-23 Murray Cumming <murrayc@murrayc.com>
169 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
170 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
171 (modest_signature_editor_dialog_set_settings):
172 Disable the label and textview when the checkbox is disabled, and use the
173 specified (UI spec) default signature text.
175 2007-04-23 Murray Cumming <murrayc@murrayc.com>
177 * src/maemo/modest-connection-specific-smtp-edit-window.c:
178 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
181 * src/modest-account-mgr-helpers.h:
182 * src/modest-account-mgr-helpers.c:
183 Added modest_account_mgr_get/set_signature(), using new gconf keys.
185 * src/maemo/Makefile.am:
186 * src/maemo/modest-signature-editor-dialog.c:
187 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
190 * src/maemo/modest-account-settings-dialog.h:
191 * src/maemo/modest-account-settings-dialog.c:
192 (modest_account_settings_dialog_finalize), (on_button_signature),
193 (save_configuration): Use the new dialog when the Edit button is pressed, and
194 save the changes if necessary, as per the UI spec.
196 2007-04-23 Murray Cumming <murrayc@murrayc.com>
198 * src/maemo/Makefile.am:
199 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
200 based on maemo-develoers email from Dirk.
202 * src/maemo/easysetup/modest-easysetup-wizard.c:
203 (create_page_welcome), (create_page_account_details),
204 (create_page_user_details), (create_page_complete_easysetup),
205 (create_page_custom_incoming), (create_page_custom_outgoing),
206 (create_page_complete_custom),
207 (modest_easysetup_wizard_dialog_init):
208 * src/maemo/modest-account-settings-dialog.c:
209 (create_page_account_details), (create_page_user_details),
210 (create_page_incoming), (create_page_outgoing),
211 (modest_account_settings_dialog_init):
212 * src/maemo/modest-connection-specific-smtp-window.c:
213 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
215 2007-04-23 Murray Cumming <murrayc@murrayc.com>
217 * src/maemo/easysetup/modest-easysetup-wizard.c:
218 (create_page_account_details), (create_page_custom_outgoing),
219 (create_page_complete_custom):
220 * src/maemo/modest-account-settings-dialog.c:
221 (create_page_user_details), (create_page_incoming),
222 (create_page_outgoing):
223 * src/maemo/modest-connection-specific-smtp-edit-window.c:
224 (modest_connection_specific_smtp_edit_window_init):
225 Use the correct (UI spec) port min/max, and use horizontal separators,
228 2007-04-23 Murray Cumming <murrayc@murrayc.com>
230 * src/maemo/easysetup/modest-easysetup-wizard.c:
231 (set_default_custom_servernames):
232 * src/maemo/modest-account-settings-dialog.c:
233 (create_page_incoming), (on_combo_outgoing_security_changed),
234 (on_combo_incoming_security_changed), (create_page_outgoing),
235 (modest_account_settings_dialog_set_account_name),
236 (save_configuration):
237 * src/maemo/modest-connection-specific-smtp-edit-window.c:
238 (on_combo_security_changed),
239 (modest_connection_specific_smtp_edit_window_init),
240 (modest_connection_specific_smtp_edit_window_set_connection),
241 (modest_connection_specific_smtp_edit_window_get_settings):
242 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
245 2007-04-20 Murray Cumming <murrayc@murrayc.com>
248 * src/maemo/easysetup/modest-easysetup-wizard.c:
249 (create_page_custom_outgoing), (create_page_complete_custom):
250 * src/maemo/modest-account-settings-dialog.c:
251 (create_page_user_details), (create_page_outgoing):
252 * src/maemo/modest-account-view-window.c: (button_box_new):
253 Use changed logical IDs as per the most recent UI spec:
254 mcen_bd_emailsetup_edit -> mcen_bd_edit
255 mcen_bd_emailsetup_delete -> mcen_bd_delete
256 mcen_bd_emailsetup_close -> mcen_bd_close
258 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
262 * src/dbus_api/Makefile.am:
263 * src/dbus_api/modest-dbus-callbacks.c:
264 * src/dbus_api/modest-dbus-callbacks.h:
265 * src/maemo/modest-platform.c: (modest_platform_init):
266 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
269 * tests/dbus_api/Makefile.am:
270 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
272 2007-04-20 Murray Cumming <murrayc@murrayc.com>
274 * src/maemo/modest-account-settings-dialog.c:
275 * src/maemo/modest-connection-specific-smtp-edit-window.c:
276 Removed unnecessary includes.
278 2007-04-20 Murray Cumming <murrayc@murrayc.com>
280 * src/maemo/easysetup/modest-easysetup-wizard.c:
281 * src/maemo/modest-account-settings-dialog.c:
282 * src/maemo/modest-connection-specific-smtp-edit-window.c:
283 * src/widgets/Makefile.am:
284 * src/widgets/modest-easysetup-secureauth-combo-box.c:
285 * src/widgets/modest-easysetup-secureauth-combo-box.h:
286 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
287 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
288 * src/widgets/modest-secureauth-combo-box.c:
289 * src/widgets/modest-secureauth-combo-box.h:
290 * src/widgets/modest-serversecurity-combo-box.c:
291 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
292 made the GObject names more consistent with the rest of the Modest code.
294 2007-04-20 Murray Cumming <murrayc@murrayc.com>
296 * src/maemo/easysetup/Makefile.am:
297 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
298 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
299 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
300 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
301 * src/maemo/easysetup/modest-easysetup-wizard.c:
302 * src/maemo/easysetup/modest-validating-entry.c:
303 * src/maemo/easysetup/modest-validating-entry.h:
304 * src/maemo/modest-account-settings-dialog.c:
305 * src/maemo/modest-connection-specific-smtp-edit-window.c:
306 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
307 widgets/ because they are used outside of easysetup too. After checking in,
308 svn will allow me to rename them too.
310 2007-04-20 Murray Cumming <murrayc@murrayc.com>
312 * src/gnome/modest-msg-edit-window.c:
313 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
314 linker error, to fix the build on the GNOME platform.
315 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
316 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
317 ifdefed out to avoid a warning.
319 2007-04-20 Murray Cumming <murrayc@murrayc.com>
321 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
322 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
323 some alternative for GTK+ 2.6.
325 2007-04-19 Murray Cumming <murrayc@murrayc.com>
327 * src/maemo/modest-address-book.c: Added include to avoid a warning.
329 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
330 specified for EmailAccountsDialog in UI spec.
332 * src/maemo/easysetup/modest-easysetup-wizard.c:
333 * src/maemo/easysetup/modest-easysetup-wizard.h:
334 * src/maemo/modest-account-settings-dialog.c:
335 * src/maemo/modest-account-settings-dialog.h:
336 Reuse a member window widget for the connection-specific SMTP server accounts,
337 so we can tell it to create/save the accounts only if we actually save changes.
339 * src/maemo/modest-connection-specific-smtp-edit-window.h:
340 * src/maemo/modest-connection-specific-smtp-edit-window.c:
341 (modest_connection_specific_smtp_edit_window_get_settings):
342 Return a struct instance for temporarily remembering the entered data.
344 * src/maemo/modest-connection-specific-smtp-window.h:
345 * src/maemo/modest-connection-specific-smtp-window.c:
346 (modest_connection_specific_smtp_window_finalize),
347 (modest_connection_specific_smtp_window_fill_with_connections),
349 (modest_connection_specific_smtp_window_save_server_accounts),
350 (update_model_server_names): Do not actually save data until asked,
351 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
353 (on_selection_changed),
354 (modest_connection_specific_smtp_window_init): Disable the edit
355 button when nothing is selected.
357 * src/modest-account-mgr-helpers.c:
358 * src/modest-account-mgr-helpers.h:
359 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
362 2007-04-19 Murray Cumming <murrayc@murrayc.com>
364 * src/modest-account-mgr-helpers.h:
365 * src/modest-account-mgr-helpers.c:
366 (modest_account_mgr_get_unused_account_name),
367 (modest_account_mgr_get_unused_account_display_name): Added these
368 utility functions, to avoid code duplication.
370 * src/maemo/easysetup/modest-easysetup-wizard.c:
371 (create_page_account_details), (create_account):
372 * src/maemo/modest-connection-specific-smtp-edit-window.c:
373 (on_combo_security_changed),
374 (modest_connection_specific_smtp_edit_window_init),
375 (modest_connection_specific_smtp_edit_window_save_settings):
376 * src/maemo/modest-connection-specific-smtp-edit-window.h:
377 * src/maemo/modest-connection-specific-smtp-window.c:
378 (modest_connection_specific_smtp_window_finalize),
379 (modest_connection_specific_smtp_window_fill_with_connections),
380 (on_button_edit), (modest_connection_specific_smtp_window_init):
381 * src/maemo/modest-connection-specific-smtp-window.h:
382 Implementing saving of connection-specific server accounts.
384 But I need to refactor this so we can save the data for each
385 possible connection-specific account and only actually create the server accounts
386 when the easysetup finished, or the OK button is pressed on the account settings
389 2007-04-18 Murray Cumming <murrayc@murrayc.com>
391 * src/maemo/modest-connection-specific-smtp-edit-window.c:
392 (on_combo_security_changed):
393 (modest_connection_specific_smtp_edit_window_init):
394 Auto-fill the port number as in the account settings.
396 (modest_connection_specific_smtp_edit_window_set_connection):
397 * src/maemo/modest-connection-specific-smtp-edit-window.h:
398 * src/maemo/modest-connection-specific-smtp-window.c:
399 (fill_with_connections), (on_button_edit),
400 (modest_connection_specific_smtp_window_init):
401 Turn the edit window into a dialog to simplify the code, and
402 set a WM hint as in a GtkDialog, because only a popup can be on top of
403 another window in Maemo, and popups usually have no WM decoration.
406 * src/modest-account-mgr-helpers.c:
407 (modest_account_mgr_set_connection_specific_smtp),
408 (modest_account_mgr_remove_connection_specific_smtp),
409 (modest_account_mgr_get_connection_specific_smtp):
410 * src/modest-account-mgr-helpers.h: Some functions to write the
411 connection-specific SMTP server information. Not yet used.
414 * src/widgets/modest-folder-view.c: (text_cell_data):
415 Fix a warning about an uninitialized variable.
416 (on_configuration_key_changed): Put an #ifdef around the use
417 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
419 2007-04-18 Murray Cumming <murrayc@murrayc.com>
421 * src/maemo/modest-account-settings-dialog.h:
422 * src/maemo/modest-account-settings-dialog.c:
423 Added connect_for_modified() utility function to mark the new modified boolean.
425 (create_page_account_details), (create_page_user_details),
426 (create_page_incoming), (create_page_outgoing), (on_response),
427 (modest_account_settings_dialog_init),
428 (modest_account_settings_dialog_set_account_name):
429 Only warn about unsaved changes when there are actually unsaved changes.
431 * src/modest-account-mgr-helpers.c:
432 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
433 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
434 to get the data from there in future.
436 2007-04-18 Murray Cumming <murrayc@murrayc.com>
440 * src/modest-account-mgr-helpers.h:
441 * src/modest-account-mgr-helpers.c:
442 Store the security account setting in a single conf key instead of using
443 the options list, so that the list is left for just the to-be-removed camel hack,
444 and because gconf_client_set_list() is failing for some reason.
446 * src/modest-account-mgr.c:
447 (modest_account_mgr_add_server_account):
448 * src/maemo/modest-account-settings-dialog.c:
449 (modest_account_settings_dialog_set_account_name),
450 (save_configuration): Use the renamed functions.
453 2007-04-18 Murray Cumming <murrayc@murrayc.com>
455 * src/widgets/Makefile.am:
456 * src/widgets/modest-limit-retrieve-combo-box.c:
457 * src/widgets/modest-limit-retrieve-combo-box.h:
458 * src/widgets/modest-retrieve-combo-box.c:
459 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
460 the account settings dialog.
463 * src/modest-account-mgr-helpers.h:
464 * src/modest-account-mgr-helpers.c:
465 (modest_server_account_get_option_secure_auth),
466 (modest_server_account_set_option_secure_auth):
467 * src/modest-account-mgr.c:
468 (modest_account_mgr_add_server_account):
469 Use the existing AUTH_MECH conf key for the secure-auth setting,
470 instead of putting it in the list options, because this was actually used already.
472 * src/maemo/modest-account-settings-dialog.c:
473 (create_page_account_details),
474 (modest_account_settings_dialog_set_account_name),
475 (save_configuration):
476 * src/maemo/modest-account-settings-dialog.h:
477 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
478 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
480 2007-04-18 Murray Cumming <murrayc@murrayc.com>
482 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
483 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
484 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
487 * src/maemo/modest-account-settings-dialog.c:
488 (create_page_incoming), (on_combo_outgoing_security_changed),
489 (on_combo_incoming_security_changed), (create_page_outgoing),
490 (modest_account_settings_dialog_set_account_name),
491 (save_configuration): Load/Save the port number, and change it when the
492 security combo changes, to suitable defaults.
494 2007-04-17 Murray Cumming <murrayc@murrayc.com>
496 * src/modest-account-mgr.c:
497 (modest_account_mgr_add_server_account): Set the security and secure-auth
498 options, and add a comment saying that the other camel-specific options should be
501 2007-04-17 Murray Cumming <murrayc@murrayc.com>
503 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
505 * src/modest-tny-account-store.c: (account_list_free),
506 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
507 cursor->data after unreffing it. But there is some strange stuff there so it might not be
510 2007-04-17 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-protocol-info.c:
513 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
514 is required by our UI spec. Maybe something in our implementation will use this eventually.
515 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
516 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
517 instead of the previous 0 placeholder.
519 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
520 secure-auth settings.
521 * src/modest-account-mgr-helpers.h:
522 * src/modest-account-mgr-helpers.c:
523 (modest_server_account_data_get_option_secure_auth),
524 (modest_server_account_set_option_secure_auth),
525 (modest_server_account_data_get_option_security),
526 (modest_server_account_set_option_security): Added this API for getting and setting the security
527 and secure-auth settings.
529 * src/maemo/modest-account-settings-dialog.h:
530 * src/maemo/modest-account-settings-dialog.c:
531 (modest_account_settings_dialog_finalize), (check_data),
532 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
533 about changing titles.
534 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
535 (save_configuration): Save the security and secure-auth settings.
537 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
538 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
540 2007-04-17 Murray Cumming <murrayc@murrayc.com>
543 * src/modest-account-mgr.c:
544 (modest_account_mgr_add_server_account):
545 Added and used defines for the options key and value pair strings,
546 that are used so far, though they do not seem to correspond to anything in our
547 UI specs or ModestProtocol enum.
549 * src/modest-account-mgr-helpers.h:
550 * src/modest-account-mgr-helpers.c:
551 (compare_option_strings_for_name),
552 (modest_server_account_data_get_option_value),
553 (modest_server_account_data_get_option_bool),
554 (modest_account_mgr_get_server_account_option):
555 Added helper functions for parsing the options GSList.
557 2007-04-16 Murray Cumming <murrayc@murrayc.com>
559 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
560 display name is based on the supplied account name.
561 * src/modest-account-mgr.c:
562 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
563 with an inefficient, but good-enough, implementation.
565 * src/maemo/easysetup/modest-easysetup-wizard.c:
566 (create_page_account_details), (on_before_next), (create_account):
567 Check for existing display names rather than (non-user-visible) account names, and just
568 create and set a unique account name at the end.
570 * src/maemo/modest-account-settings-dialog.c:
571 (modest_account_settings_dialog_init),
572 (modest_account_settings_dialog_set_account_name),
573 (create_page_incoming): Show the display name, instead of the account name.
574 (on_response): Do some (not all) extra checks, as in the UI spec.
575 (save_configuration): Save the display name if it was changed.
577 2007-04-16 Murray Cumming <murrayc@murrayc.com>
579 * po/en_GB.po: Added needed logical ID and translation.
580 * src/widgets/modest-account-view.c: (on_account_default_toggled),
581 (init_view): Made the is-default column clicking work.
583 2007-04-16 Murray Cumming <murrayc@murrayc.com>
586 * src/maemo/easysetup/Makefile.am:
587 * src/maemo/easysetup/modest-easysetup-wizard.c:
588 (modest_easysetup_wizard_dialog_init):
589 * src/maemo/easysetup/provider-data-test.keyfile:
590 * src/maemo/easysetup/provider-data.keyfile:
591 Moved the provider data file to the new modest-providers-data package and used it from there.
593 2007-04-16 Murray Cumming <murrayc@murrayc.com>
595 * src/modest-local-folder-info.c:
596 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
597 N_() was already used on the static strings, but this just marks it for translation without
598 using the translation.
600 2007-04-06 Murray Cumming <murrayc@murrayc.com>
602 * src/maemo/modest-account-settings-dialog.c:
603 (create_page_incoming),
604 (modest_account_settings_dialog_set_account_name):
605 Added comments about the need for new API in ModestAccountMgr to handle the authentication
606 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
607 I will do this if nobody else gets there first.
609 2007-04-06 Murray Cumming <murrayc@murrayc.com>
611 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
612 Saved much of the incoming and outgoing data too, though I cannot yet see how to
613 save the security stuff.
615 2007-04-06 Murray Cumming <murrayc@murrayc.com>
617 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
618 Set the email address and user fullname, which I now see must be
621 * src/maemo/modest-account-settings-dialog.h:
622 * src/maemo/modest-account-settings-dialog.c:
624 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
625 leave-on-server and authentication.
626 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
629 2007-04-06 Murray Cumming <murrayc@murrayc.com>
632 * src/maemo/modest-account-settings-dialog.c:
633 * src/maemo/modest-account-settings-dialog.h:
634 Most (but not all) of the widgets are now present as specified by the UI spec.
635 No changes are yet saved, and some details are not properly shown yet.
637 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
639 2007-04-06 Murray Cumming <murrayc@murrayc.com>
641 * src/maemo/Makefile.am:
642 * src/maemo/modest-account-settings-dialog.c:
643 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
644 an existing account. Doesn't do much yet.
646 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
647 Open the accounts settings dialog when Edit is clicked.
649 2007-04-05 Murray Cumming <murrayc@murrayc.com>
651 * src/maemo/easysetup/Makefile.am:
652 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
654 * src/maemo/easysetup/modest-easysetup-wizard.c:
655 (modest_easysetup_wizard_dialog_init):
656 Try to get the source directory from the build system,
657 instead of hard-coding "./" into the source code, when opening our local
658 copies of the configuration files.
659 But this still fails when opening the wizard from the Accounts window,
660 maybe because the working directory seems to change at runtime.
661 So the wizard will fail the second time unless you copy the files into their
662 proper locations - see the stdout warnings for the paths.
664 (create_page_account_details),(on_before_next):
665 Check for existing non-server accounts instead of server accounts,
666 so the default account name is useful again, and to prevent trying to
669 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
670 Show the wizard when New is clicked.
672 * src/widgets/modest-account-view.c: (on_account_default_toggled),
673 (init_view): Show the column headers, and show the columns that are
674 specified in the UI specs. However, something in Maemo's GTK+ prevents
675 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
676 change the default account. This is despite unsetting the special properties.
678 2007-04-05 Murray Cumming <murrayc@murrayc.com>
680 * docs/reference/modest-design.sgml: Corrected spelling mistake.
681 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
682 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
683 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
684 to make that clearer.
685 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
687 2007-04-05 Murray Cumming <murrayc@murrayc.com>
689 * src/maemo/modest-account-view-window.c:
690 (modest_account_view_window_init),
691 (modest_account_view_window_new):
692 Use the same buttons as specified in the
693 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
694 the existing widgets, which never had a chance of working.
695 Put the ModestAccountView treeview in a scrolled window.
696 Do not repeat the initialization in both _init() and _new().
698 * src/widgets/modest-account-view.c: (update_account_view):
699 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
700 this widget and window shows no accounts.
702 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
704 2007-04-05 Murray Cumming <murrayc@murrayc.com>
706 * src/maemo/easysetup/modest-easysetup-wizard.c:
707 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
708 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
709 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
712 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
713 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
714 accounts exist yet, as in the UI spec.
716 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
718 2007-04-05 Murray Cumming <murrayc@murrayc.com>
720 * src/maemo/Makefile.am:
721 * src/maemo/modest-connection-specific-smtp-edit-window.c:
722 * src/maemo/modest-connection-specific-smtp-edit-window.h:
723 New window for editing connection-specific smtp details.
724 Not fully implemented.
726 * src/maemo/modest-connection-specific-smtp-window.c:
727 (modest_connection_specific_smtp_window_finalize) :
728 unref the tree model.
729 (on_button_edit): Show the edit window.
731 2007-04-05 Murray Cumming <murrayc@murrayc.com>
733 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
736 * src/maemo/Makefile.am:
737 * src/maemo/modest-connection-specific-smtp-window.c:
738 * src/maemo/modest-connection-specific-smtp-window.h:
739 New window for showing the list of connections, for connection-specific
740 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
741 * src/maemo/easysetup/modest-easysetup-wizard.c:
742 (create_page_custom_outgoing): Show the new window when the button is clicked.
744 2007-04-04 Murray Cumming <murrayc@murrayc.com>
746 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
747 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
748 * src/maemo/modest-msg-edit-window.c:
749 (modest_msg_edit_window_insert_image):
750 * src/modest-conf.c: (modest_conf_key_escape):
751 * src/modest-mail-operation.c:
752 (modest_mail_operation_send_new_mail):
753 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
754 (modest_ui_actions_on_new_account):
755 * src/widgets/modest-attachment-view.c: (update_filename_request):
756 * src/widgets/modest-mail-header-view.c:
757 Corrected warnings that were breaking the build, by commenting out unused variables,
758 and a function, and by including a header.
760 2007-04-04 Murray Cumming <murrayc@murrayc.com>
762 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
763 so we can #ifdef around platform-specific code when necessary.
764 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
765 to allow this to build for the GNOME platform too.
767 2007-04-04 Murray Cumming <murrayc@murrayc.com>
769 * src/maemo/easysetup/modest-easysetup-wizard.c:
770 Added util_increment_name() and used it in create_page_account_details()
771 to make sure that the default account name is always a new name.
773 (modest_easysetup_wizard_dialog_init),
774 (set_default_custom_servernames): Some minor memory management fixes.
776 2007-04-04 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-runtime.c: (init_i18n): Restored the translation
781 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
782 are defined in config.h, and the translations are installed.
784 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
785 is defined for translation.
787 2007-04-03 Murray Cumming <murrayc@murrayc.com>
789 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
791 * src/maemo/easysetup/modest-easysetup-wizard.c:
792 (modest_easysetup_wizard_dialog_init):
793 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
794 Use realistic paths (though they should use $prefix generically) to the
795 mcc_mapping and provider-data.keyfile files which might work when they
796 are installed by the future version of the operator-wizard package,
797 and then fallback to paths in our source code, with an explanatory
800 2007-04-03 Murray Cumming <murrayc@murrayc.com>
804 * src/maemo/Makefile.am:
805 * src/maemo/easysetup/: Added files from the previously-exernal
806 osso-modest-easysetup.
807 * src/maemo/modest-main-window-ui.h:
808 * src/modest-ui-actions.c:
809 * src/modest-ui-actions.h:
810 Added modest_ui_actions_on_new_account() as a signal handler for the
811 New Account menu item. It shows the easysetup wizard.
812 * po/en_GB.po: Added additional needed logical IDs and translations.
814 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
815 Apparently ChangeLog is not used for some vague Nokia legal reasons.