1 2007-07-16 Armin Burgmeier <armin@openismus.com>
3 * src/modest-ui-actions.c: Added a button to create a folder to the
4 move-to dialog. This fixes projects.maemo.org bug NB#.
6 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
8 * src/maemo/easysetup/modest-easysetup-wizard.c:
9 Added scrollbars to account wizard dialog.
10 Fixed projects.maemo.org NB #62744
12 2007-07-16 Murray Cumming <murrayc@murrayc.com>
14 * src/widgets/modest-msg-view.h:
15 * src/widgets/modest-msg-view.c:
16 Added modest_msg_view_get_message_is_empty() but this needs
18 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
19 Check if there is any text in the message yet.
20 But this needs to be implemented properly.
21 (modest_msg_edit_window_toggle_find_toolbar):
22 * src/maemo/modest-msg-view-window.c:
23 (modest_msg_view_window_toggle_find_toolbar):
24 Show a banner warning if there is no text to search, when
25 trying to start a search. This partially fixes
26 projects.maemo.org bug NB#62350.
28 2007-07-13 Murray Cumming <murrayc@murrayc.com>
30 * src/modest-mail-operation.c: (update_account_thread):
31 Initialized num_new_headers to fix the build.
33 2007-07-13 Murray Cumming <murrayc@murrayc.com>
35 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
36 Ignore modest accounts whose server accounts don't exist in gconf.
37 This prevents us trying to create TnyAccount instances for those
38 server accounts when the server account has been removed from gconf,
39 but the parent modest account has not yet been removed from modest.
40 I don't know why this is only noticeable now. It was probably just
41 a harmeless g_warning() anyway.
43 2007-07-13 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
46 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
48 2007-07-12 Armin Burgmeier <armin@openismus.com>
50 * src/maemo/modest-main-window.c: Make default account appear bold
51 in view, tools/send & receive and toolbar/send & receive SCM menus.
52 This fixes projects.maemo.org bug NB#59010.
54 2007-07-12 Murray Cumming <murrayc@murrayc.com>
56 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
57 Add a short-cut, by checking if the folder store is an account.
58 This ensures that the Sort menu item and toolbar is dimmed for
59 the local-folders account root item, fixing
60 projects.maemo.org bug NB#62545.
62 2007-07-12 Murray Cumming <murrayc@murrayc.com>
64 * src/modest-tny-account-store.c: (get_password):
65 Show the password dialog (via the signal) only in the mainloop, via
66 an idle handler that we wait for. This could theoretically prevent
67 hangs, though I worry that it could introduce some too.
69 2007-07-12 Murray Cumming <murrayc@murrayc.com>
71 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
72 * src/maemo/modest-platform.c:
73 (modest_platform_connect_and_wait):
74 Take a TnyAccount* parameter and try to set it to online
75 (a TnyCamel-only API), because tinymail sets accounts to offline
76 when the user cancels a password dialog, and doesn't ask again until
77 it has been set to online.
78 However, this is commented out because it causes a hang now.
80 (modest_platform_connect_and_wait_if_network_account):
81 * src/modest-mail-operation.c:
82 (modest_mail_operation_update_account):
83 * src/modest-platform.h:
84 * src/modest-ui-actions.c: (_modest_ui_actions_open),
85 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
87 2007-07-12 Armin Burgmeier <armin@openismus.com>
89 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
91 * src/modest-mail-operation.c:
92 * src/modest-ui-actions.c: Check for already existing folder before
93 querying the server, show error message from camel if the request
94 still fails. This fixes projects.maemo.org bug NB#58701.
96 2007-07-12 Murray Cumming <murrayc@murrayc.com>
98 * src/modest-tny-account-store.h:
99 * src/modest-tny-account-store.c:
100 Added modest_tny_account_store_forget_password_in_memory(),
101 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
102 when creating a new account, so that new passwords will be used, instead of
103 us thinking that it's a second request as a result of a failed password again.
105 2007-07-12 Murray Cumming <murrayc@murrayc.com>
107 * src/dbus_api/modest-dbus-callbacks.c:
108 (on_idle_open_message): If the message is in drafts then open it
109 in an edit window instead of a view window. This fixes
110 projects.maemo.org bug NB#63005.
112 2007-07-12 Murray Cumming <murrayc@murrayc.com>
114 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
115 Avoided a harmless g_warning().
117 2007-07-12 Murray Cumming <murrayc@murrayc.com>
119 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
120 Pass the modest account name, not the TnyAccount display name to
121 modest_msg_view_window_new() so that the reply feature works,
122 fixing projects.maemo.org bug NB#62892.
124 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
125 (modest_msg_view_window_new_with_header_model):
126 * src/maemo/modest-msg-view-window.c:
127 (modest_msg_view_window_new_with_header_model),
128 (modest_msg_view_window_new):
129 * src/modest-ui-actions.c: (reply_forward):
130 * src/widgets/modest-msg-view-window.h:
131 * src/widgets/modest-window.c: (modest_window_set_active_account):
132 Rename an account parameter to modest_account_name to make this clearer.
134 2007-07-11 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-ui-actions.h:
137 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
138 modest_do_message_delete().
139 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
140 Call modest_do_message_delete(), hoping that this would cause messages
141 to be really deleted from search instead of just marked with strike through.
142 Does not seem to help.
144 2007-07-11 Armin Burgmeier <armin@openismus.com>
146 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
147 priv->reselect to FALSE prior to calling
148 modest_folder_view_select_first_inbox_or_local() to prevent endless
149 recursion and thus a crash on startup.
151 2007-07-11 Armin Burgmeier <armin@openismus.com>
153 * src/maemo/modest-account-settings-dialog.h: Include
154 <gtk/gtknotebook.h> to fix the build (at least for me).
156 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
157 Use "New FolderN" as default suggested name if "New folder" already
158 exists, with N being the first free number, though never exceed "New
159 folder99" in which case we just fall back to "New Folder" even though
160 it already exists. This fixes projects.maemo.org bug NB#58663.
162 2007-07-11 Murray Cumming <murrayc@murrayc.com>
164 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
165 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
166 projects.maemo.org bug NB#62778.
168 2007-07-11 Murray Cumming <murrayc@murrayc.com>
170 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
171 Ignore the wrong (for now) secure-smtp setting in the presets -
172 just default to requiring secure authentication for SMTP, because
175 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
177 * src/widgets/modest-folder-view.c: (filter_row)
178 Do not show drafts folder (see UI specs)
180 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
182 * src/modest-ui-actions.c:
183 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
184 place and also not necessary.
186 * src/widgets/modest-folder-view.c: (filter_row)
187 Guess folder type and hide Sent & Outbox if necessary.
188 Fixed project.maemo.org NB#57328
190 2007-07-11 Murray Cumming <murrayc@murrayc.com>
192 * src/modest-ui-actions.h:
193 * src/modest-ui-actions.c:
194 (modest_ui_actions_on_delete_message):
195 Move some code into a new
196 modest_ui_actions_refresh_message_window_after_delete()
197 function so we can use it from elsewhere.
199 * src/dbus_api/modest-dbus-callbacks.c:
200 (on_idle_delete_message), (on_delete_message): Used an idle
201 handler, as we do for the other D-Bus method handlers.
202 Call modest_ui_actions_refresh_message_window_after_delete()
203 if the deleted message was open in a window. This fixed
204 projects.maemo.org bug NB#62862.
206 2007-07-11 Murray Cumming <murrayc@murrayc.com>
208 * src/modest-main.c: (main): Only show the UI at the start if
209 the showui command line option was given. For instance,
210 run-standalone src/modest showui
211 Otherwise, we wait for the top_application D-Bus method to
212 be sent by hildon-desktop when the application is selected
214 This allows us to run without a UI when osso-global-search
215 uses our D-Bus methods.
217 2007-07-11 Murray Cumming <murrayc@murrayc.com>
219 * src/dbus_api/modest-dbus-api.h: Added a define for a
220 top-application D-Bus method.
221 * src/dbus_api/modest-dbus-callbacks.c:
222 (on_top_application),
223 (modest_dbus_req_handler): Handle the top-application D-Bus
224 method, which might be an undocumented D-Bus signal sent by
225 hildon-desktop when it starts the application from the menu.
226 But I am not sure and I need to test it on the device, because
227 my scratchbox does not have the application in the menu now.
228 This method shows the main window, so that it can be invisible
229 when started, for instance, just for email searching from
232 * src/maemo/modest-main-window.c: (restore_settings),
233 (modest_main_window_new): Do not show the window immediately
234 upon creation. We show it later.
235 * src/modest-widget-memory.c: (save_settings_paned):
236 Try (unsuccessfully) to avoid saving the paned position when
237 it is not even visible.
238 (restore_settings_paned): Do not allow a silly paned position.
239 This seems necessary when not showing the window at first.
241 * tests/dbus_api/Makefile.am:
242 * tests/dbus_api/test_top_application.c: (main): Test for the
245 2007-07-10 Murray Cumming <murrayc@murrayc.com>
247 * src/modest-ui-dimming-rules.c:
248 (modest_ui_dimming_rules_on_new_msg),
249 (modest_ui_dimming_rules_on_reply_msg),
250 (modest_ui_dimming_rules_on_delete_msg),
251 (modest_ui_dimming_rules_on_details),
252 (modest_ui_dimming_rules_on_view_window_move_to),
253 (modest_ui_dimming_rules_on_view_previous),
254 (modest_ui_dimming_rules_on_view_next),
255 (_invalid_folder_for_purge): Added checks before
256 casting the window. This looks like an actual
257 logic error in _invalid_folder_for_purge(), because it
258 tries to use a ModestMainWindow as a message window.
260 2007-07-10 Murray Cumming <murrayc@murrayc.com>
262 * src/maemo/modest-account-settings-dialog.c:
263 (show_error): Use the same implementation as in
264 modest-easysetup-wizard.c:
265 (on_entry_invalid_character): The logical ID contains a %s.
266 Guessed what it should be.
267 (on_entry_max), (check_data), (on_response): Adapt to
268 changed show_error().
269 (create_page_account_details): Really call
270 modest_validating_entry_set_func() on the correct widgets.
271 * src/maemo/easysetup/modest-easysetup-wizard.c:
272 (on_entry_invalid_character): Fix the logical ID here too.
273 (create_page_account_details),
274 (create_page_user_details):
276 modest_validating_entry_set_func() on the correct widgets.
278 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
279 Do not try to use the account if it is NULL.
281 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
283 * src/modest-ui-actions.c: (create_move_to_dialog),
284 (modest_ui_actions_on_main_window_move_to),
285 (modest_ui_actions_on_msg_view_window_move_to):
286 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
287 (filter_row), (modest_folder_view_show_non_move_folders):
288 * src/widgets/modest-folder-view.h:
290 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
291 the Sent folder yet as it does not report the correct folder type.
293 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
295 * src/maemo/modest-msg-edit-window.c: (init_window):
298 2007-07-10 Murray Cumming <murrayc@murrayc.com>
300 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
301 Take a parent widget instead of a parent window, and
302 implement this with hildon_banner_show_information() instead.
303 Non-Maemo builds can just ifdef that there.
304 This fixed projects.maemo.org bug NB#62766.
306 (on_entry_invalid_character): Use show_error() again instead
307 of using hildon directly, and use the _CS() macro to use the correct
309 (create_account), (check_for_supported_auth_methods), (on_entry_max):
310 Pass a widget instead od a window to show_error().
312 2007-07-10 Murray Cumming <murrayc@murrayc.com>
314 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
315 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
316 This allows us to show the server name in the error message, fixing
317 projects.maemo.org bug NB#62904.
318 Also, use the appropriate logical ID message for the account protocol.
320 2007-07-10 Murray Cumming <murrayc@murrayc.com>
322 * src/modest-tny-account-store.c: (on_idle_wrong_password):
323 A compilation fix, though the build wasn't broken for me.
325 2007-07-09 Murray Cumming <murrayc@murrayc.com>
327 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
328 Do not try to unref a NULL folder store, to avoid a runtime warning.
329 This seems to happen sometimes when changing accounts settings.
331 2007-07-09 Murray Cumming <murrayc@murrayc.com>
333 * src/modest-tny-account-store.c:
334 (modest_tny_account_store_instance_init),
335 (modest_tny_account_store_finalize),
336 (on_account_settings_hide), (on_idle_wrong_password):
337 Use a GHashTable to ensure that we only show one account settings
338 dialog per modest account. This avoids us having a dialog open for
339 both the store and transport accounts, or due to repeated get_password()
340 calls that shouldn't happen anyway.
342 2007-07-09 Murray Cumming <murrayc@murrayc.com>
344 * src/maemo/modest-maemo-utils.c: (on_hide),
345 (modest_maemo_show_dialog_and_forget): Handle the response, because
346 the window is not even hidden by default.
348 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
349 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
350 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
351 which seems to prevent some modality problems.
353 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
354 Ignore user cancellation errors.
356 * src/modest-account-mgr-helpers.h:
357 * src/modest-account-mgr-helpers.c:
358 Added modest_server_account_get_password() and
359 modest_server_account_get_has_password() to avoid direct use of
362 * src/maemo/modest-account-settings-dialog.h:
363 * src/maemo/modest-account-settings-dialog.c:
364 (modest_account_settings_dialog_init): Store the notebook so we can
366 Added modest_account_settings_dialog_switch_to_user_info().
368 * src/modest-tny-account-store.c:
369 (get_password): When the password in the account settings is wrong (we think),
370 show the relevant page of the account settings dialog, in the mainloop.
371 However, we currently get many of these at once because cancel does not
373 (forget_password): Do not forget the password
374 from the account settings, because this causes side-effects when
375 tinymail seems to call it at strange time, maybe because of how we
376 are cancelling get_password().
377 (modest_tny_account_store_alert): Ignore user cancellations.
379 2007-07-09 Murray Cumming <murrayc@murrayc.com>
381 * src/maemo/modest-maemo-utils.h:
382 * src/maemo/modest-maemo-utils.c:
383 Added modest_maemo_show_information_note_and_forget() for use instead of
384 gtk_dialog_run() when the response is not needed, to avoid an extra
385 mainloop which could cause a hang.
387 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
388 Use the logical IDs for the error message, though they are not
389 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
390 because gtk_dialog_run() caused a hang here (the window did not close).
391 This fixes projects.maemo.org bug NB#62646.
393 2007-07-09 Murray Cumming <murrayc@murrayc.com>
395 * src/modest-account-mgr-helpers.h:
396 * src/modest-account-mgr-helpers.c:
397 Added modest_account_mgr_get_store_protocol().
399 * src/maemo/modest-account-view-window.c:
400 (on_delete_button_clicked): Show different warning text depending on
401 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
402 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
405 2007-07-09 Murray Cumming <murrayc@murrayc.com>
407 * src/maemo/modest-msg-edit-window.c:
408 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
409 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
411 2007-07-07 Armin Burgmeier <armin@openismus.com>
413 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
414 ckdg_ib_maximum_characters_reached from correct package.
416 * src/modest-ui-actions.c: Show an error message when a folder could
417 not be created. Tinymail does not give us specific error codes about
418 what has gone wrong, so we assume that a folder with that name
419 already exists, though there might be other reasons.
421 2007-07-06 Murray Cumming <murrayc@murrayc.com>
423 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
424 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
425 give a more exact error message that can be partly translated.
427 2007-07-05 Murray Cumming <murrayc@murrayc.com>
429 * src/maemo/modest-address-book.c:
430 (select_email_addrs_for_contact): Specify a default window size for the
431 select-email-address dialog, so that it is probably big enough for the
432 title. This should fix projects.maemo.org bug NB#62277.
434 2007-07-05 Murray Cumming <murrayc@murrayc.com>
436 * src/maemo/easysetup/modest-easysetup-wizard.c:
437 (create_page_complete_easysetup): Use
438 gtk_widget_set_size() request to ensure that the text wraps
441 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
443 * src/maemo/easysetup/modest-easysetup-wizard.c:
444 (on_entry_invalid_character), (create_page_account_details),
445 (create_page_user_details):
446 Use new API of ModestValidatingEntry. But for some reason the banner is
447 not shown. I will have to investigate that further.
449 * src/widgets/modest-validating-entry.c: (on_insert_text),
450 (modest_validating_entry_set_func):
451 * src/widgets/modest-validating-entry.h:
452 Added a new callback function to be able to react to prevented
453 characters whitespaces to e.g show a banner.
455 2007-07-05 Armin Burgmeier <armin@openismus.com>
457 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
458 notification of HildonNumberEditor instead of remembering the port
459 number. Thanks to Johannes for pointing this out.
461 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
463 * src/maemo/easysetup/modest-easysetup-wizard.c:
464 Check if there are any user changes before showing a confirmation
465 dialog (projects.maemo.org NB#60946)
467 2007-07-05 Armin Burgmeier <armin@openismus.com>
469 * src/maemo/modest-account-settings-dialog.c: Remember custom port
470 number at the beginning of the dialog and set the modified flag at the
471 end if the port number has changed. This is necessary because
472 HildonNumberEditor does not support notification when the value has
475 2007-07-05 Murray Cumming <murrayc@murrayc.com>
477 * src/modest-ui-actions.c:
478 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
479 a connection before asking anything else. Correct the check for the destination
480 folder so that it succeeds when online.
481 This fixed projects.maemo.org bug NB#61645.
483 2007-07-05 Murray Cumming <murrayc@murrayc.com>
485 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
486 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
487 to fix projects.maemo.org bug NB#62439.
489 2007-07-05 Murray Cumming <murrayc@murrayc.com>
491 * src/modest-tny-account.c: (on_connection_status_changed):
492 Really do not use tny_device_force_offline() here. See the previous comment.
494 2007-07-04 Murray Cumming <murrayc@murrayc.com>
496 * src/modest-tny-account.c: (on_connection_status_changed):
497 Do not use tny_device_force_offline() when tinymail says that something
498 went wrong with the connection. It seems to report this unnecessarily.
500 2007-07-04 Murray Cumming <murrayc@murrayc.com>
502 * src/maemo/modest-connection-specific-smtp-window.c:
503 (modest_connection_specific_smtp_window_init):
504 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
505 does not seem to have any effect in osso 1.1 (though it works in
506 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
508 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
510 * src/maemo/modest-connection-specific-smtp-window.c:
511 Fix UI specification problems with projects.meamo.org NB#60479
513 2007-07-04 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
516 clue when this has failed, because the error dialog is not always shown
517 (at least in earlier version).
519 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
520 GError message, because the generic error dialog is not helpful.
522 'This message is not currently available (can't let a new connection go online)'
523 when trying to open an IMAP message.
525 (_modest_ui_actions_open): Offer a connection when some messages would
526 have to be downloaded and we are offline.
528 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
530 * src/widgets/modest-folder-view.c:
531 Don't check for MERGE type anymore as we use the correct type
533 NOTE: For the last two changes you need to update your tinymail copy
534 because of API changes!
536 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
538 * src/modest-tny-local-folders-account.c:
539 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
540 (see projects.maemo.org NB#61580)
542 2007-07-04 Murray Cumming <murrayc@murrayc.com>
544 * src/modest-tny-account.c: (on_connection_status_changed):
545 Commented out the call to modest_platform_connect_and_wait() because this
546 seems to always hang, and I would like to know if this is the only thing
547 that causes a hang when showing the connection dialog.
548 It is not very useful anyway.
550 2007-07-04 Murray Cumming <murrayc@murrayc.com>
552 * src/maemo/modest-msg-view-window.c:
553 (modest_msg_view_window_select_next_message):
555 * src/modest-platform.h:
556 * src/maemo/modest-platform.c:
557 Added modest_platform_connect_and_wait(), which calls
558 tny_maemo_conic_device_connect() always in the main thread, by calling it
559 in an idle handler and waiting for the idle handler to run. It should be
560 in the main thread because it uses GTK+ UI code. It just returns TRUE
561 if the device is already online.
563 There is some nasty code to ensure that subsequent calls to
564 modest_platform_connect_and_wait() just wait for the first one to finish,
565 by checking repeatedly in another idle handler. This is necessary,
566 because other threads (or even the main thread, via another idle handler)
567 can call modest_platform_connect_and_wait() while
568 modest_platform_connect_and_wait() is running.
570 (modest_platform_connect_and_wait_if_network_account),
571 (modest_platform_connect_and_wait_if_network_folderstore):
572 Convenience functions that calls modest_platform_connect_and_wait() if
573 the account or folder might want network access.
575 * src/modest-mail-operation.c:
576 (modest_mail_operation_update_account):
577 * src/modest-ui-actions.c: (download_uncached_messages),
578 (modest_ui_actions_on_rename_folder), (delete_folder),
579 (modest_ui_actions_on_main_window_move_to),
580 (modest_ui_actions_on_msg_view_window_move_to):
581 * src/widgets/modest-folder-view.c:
582 (drag_and_drop_from_folder_view):
583 Offer a connection if we are offline.
585 * src/modest-tny-account.c: (on_connection_status_changed):
586 Document this as only handling errors during network operations in progress,
587 and replace the idle code with a simple call to
588 modest_platform_connect_and_wait(), which does this instead.
590 2007-07-03 Murray Cumming <murrayc@murrayc.com>
592 * src/modest-tny-account.c:
593 (modest_tny_account_get_special_folder): (util_on_idle),
594 Handle the GError so we can see when tny_folder_store_get_folders()
595 fails, as it currently does while something else is connecting.
597 Added util_run_in_main_thread_and_wait()
598 which uses an idlen handler and mainloop to ensure that the function
599 is called in the main thread.
600 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
601 to make sure that we call attempt the connection in the mainloop only,
602 which might solve some hangs.
604 2007-07-03 Murray Cumming <murrayc@murrayc.com>
606 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
607 be found by their display name. This is never useful.
608 * src/modest-tny-account-store.c: (on_account_removed): Find the account
609 by its ID, instead of trying to use its ID as its display name.
611 * src/modest-tny-account-store.h:
612 * src/modest-tny-account.c:
613 (modest_tny_account_get_special_folder): Add a g_warning() when
614 tny_folder_store_get_folders() returns an empty list for the maildir.
616 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
617 Add a g_warning() when this returns NULL, because that it not allowed
620 2007-07-02 Armin Burgmeier <armin@openismus.com>
622 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
623 note when trying to cancel the wizard. This fixes projects.maemo.org
626 2007-07-02 Murray Cumming <murrayc@murrayc.com>
628 * src/modest-tny-account.h:
629 * src/modest-tny-account.c:
630 (modest_tny_account_new_from_server_account),
631 (modest_tny_account_new_from_server_account_name),
632 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
633 because this must now be set before setting the proto. This is usd in
634 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
635 warning in camel_session_get_service() caused by
636 tny_camel_transport_account_prepare().
638 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
641 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
643 * src/maemo/modest-connection-specific-smtp-edit-window.c:
645 (modest_connection_specific_smtp_edit_window_init):
647 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
650 2007-06-29 Murray Cumming <murrayc@murrayc.com>
652 * src/modest-tny-account.c:
653 (modest_tny_account_new_from_server_account):
654 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
655 now uses to request a connection when it needs one, and which it uses
656 to tell us that something is wrong with the connection, so we can force
657 the accounts offline to prevent further problems.
660 * src/modest-init.c: (init_default_settings):
661 * src/modest-mail-operation.c:
662 (modest_mail_operation_update_account):
663 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
664 This should not be necessary anymore. Do not set the conf key that
665 determined this (it was always TRUE and not set anywhere else).
667 * src/modest-ui-actions.h: Remove unused and unimplemented
668 modest_ui_actions_on_online_toggle_toggled().
670 2007-06-29 Murray Cumming <murrayc@murrayc.com
672 * src/maemo/modest-main-window.c: (connect_signals):
673 Don't connect to delete_event twice. Maybe this was harmless.
675 2007-06-29 Murray Cumming <murrayc@murrayc.com
677 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
678 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
679 Debug output to give some more clue when a folder move is not allowed.
681 2007-06-28 Murray Cumming <murrayc@murrayc.com
683 * src/modest-tny-account.c: (on_modest_file_system_info),
684 (modest_tny_account_get_mmc_account_name):
685 Always call the callback, without checking whether the name has changed.
686 * src/widgets/modest-folder-view.c: (strings_are_equal),
687 (on_model_foreach_set_name), (on_get_mmc_account_name),
688 (text_cell_data): Compare the name here, and use the name from
689 the account rather than from the
690 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
691 if the name was changed after the account was added to the model.
692 That's a tinymail bug but not one that I want to fix now.
694 This finally fixes projects.maemo.org bug NB#59301.
696 2007-06-27 Armin Burgmeier <armin@openismus.com>
698 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
701 2007-06-27 Murray Cumming <murrayc@murrayc.com
703 * src/modest-tny-account.h:
704 * src/modest-tny-account.c:
705 Added modest_tny_account_get_mmc_account_name(), to set the memory
706 card name asynchronously for the given account and then notify.
707 (modest_tny_account_new_for_local_folders): Use this new function instead
708 of using hildon_file_system_info_async_new() directly.
710 * src/widgets/modest-folder-view.c: (text_cell_data):
711 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
712 gtk_tree_model_row_changed() when it is available.
714 This should fix projects.maemo.org bug NB#59301.
716 2007-06-27 Murray Cumming <murrayc@murrayc.com
718 * src/modest-mail-operation.c: (update_account_thread),
719 (get_msgs_full_thread): Fix typo failures in the revert
722 2007-06-27 Murray Cumming <murrayc@murrayc.com
724 * src/maemo/modest-maemo-global-settings-dialog.c:
725 (idle_select_default_focus):
726 * src/modest-mail-operation.c: (idle_notify_progress),
727 (idle_notify_progress_once), (set_last_updated_idle),
728 (update_account_thread), (get_msgs_full_thread):
729 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
730 * src/widgets/modest-header-view.c:
731 (idle_notify_headers_count_changed_destroy),
732 (idle_notify_headers_count_changed):
733 Reverted the additions of gdk_threads_enter/leave(), in case this
734 helps with a startup hang on the device.
736 2007-06-26 Armin Burgmeier <armin@openismus.com>
738 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
739 for supported secure authentication methods from server by
740 gtk_dialog_run(), saving CPU time and a potential race condition.
742 2007-06-26 Armin Burgmeier <armin@openismus.com>
744 * src/maemo/modest-maemo-utils.h:
745 * src/maemo/modest-maemo-utils.c: Added a
746 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
747 only error code to tell the calling code when the user canceled the
750 * src/maemo/modest-account-settings-dialog.h:
751 * src/maemo/modest-account-settings-dialog.c:
752 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
753 message if the retrieval of secure authentication methods was canceled
754 by the user. Perform the check before saving anything to configuration
755 to not end up with half-committed configuration changes, do not show
756 a "Saving to configuration failed" note when authentication methods
757 could not be retrieved.
759 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
762 2007-06-26 Murray Cumming <murrayc@murrayc.com>
764 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
765 Only return the first level of folders under accounts, because the
766 osso-global-search UI spec doesn't want the rest.
767 This fixed projects.maemo.org bug NB#61811.
769 2007-06-26 Murray Cumming <murrayc@murrayc.com>
771 * src/modest-tny-account-store.c:
772 * src/modest-tny-account-store.h:
773 Added modest_tny_account_is_memory_card_account().
774 * src/maemo/modest-main-window.c: (create_details_widget):
775 Show the same information items for the memory card as we show for the
776 local-folders, to fix projects.maemo.org bug NB#59307.
778 2007-06-26 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-tny-account-store.c: (get_password):
781 Added some checks for NULL to maybe prevent crashes, though I think
782 it was Philip's last commit that actually prevented the crash here
783 when creating a first new account.
784 But the new account is still not usable (no messages are shown)
785 until a restart of the application.
787 2007-06-26 Murray Cumming <murrayc@murrayc.com>
789 * src/maemo/modest-maemo-global-settings-dialog.c:
790 (idle_select_default_focus):
791 * src/modest-mail-operation.c: (idle_notify_progress),
792 (idle_notify_progress_once), (idle_notify_update_account_queue),
793 (set_last_updated_idle), (update_account_thread),
794 (notify_get_msgs_full), (get_msgs_full_destroyer),
795 (get_msgs_full_thread):
796 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
797 * src/widgets/modest-header-view.c:
798 (idle_notify_headers_count_changed_destroy),
799 (idle_notify_headers_count_changed):
800 Use gdk_threads_enter() and gdk_threads_enter_leave() in
801 all idle handlers, because some other thread could be blocking
802 the GDK lock, so that it can do GUI stuff.
804 2007-06-26 Murray Cumming <murrayc@murrayc.com>
806 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
807 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
808 (on_idle_send_receive), (on_idle_open_default_inbox):
809 * src/maemo/modest-msg-edit-window.c:
810 (modest_msg_edit_window_attach_file_noninteractive):
811 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
812 to prevent a hang. I don't quite understand why these are necessary,
813 beause we should already be in the main loop. I guess something outside
814 of the main loop is taking the lock.
816 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
817 we are really using URIs, and use files that are more likely to exist.
819 2007-06-26 Murray Cumming <murrayc@murrayc.com>
821 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
822 necessary because configure.ac now defines different variables.
824 2007-06-26 Murray Cumming <murrayc@murrayc.com>
826 * libmodest-dbus-client/libmodest-dbus-client.c:
827 * libmodest-dbus-client/libmodest-dbus-client.h:
828 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
829 libmodest_dbus_client_compose_mail() is what things actually use.
831 * src/dbus_api/modest-dbus-api.h:
832 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
833 * tests/dbus_api/Makefile.am:
834 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
837 2007-06-26 Murray Cumming <murrayc@murrayc.com>
839 * src/modest-init.c: (modest_init_local_folders):
840 For memory-card (or other non local-folders) maildir accounts,
841 always create an Archive folder, so that there is somewhere to put
842 messages. This should be less confusing, because the user does not need
843 to guess that the need to create a folder.
845 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
847 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
848 Fixed icon size by using (50, 50) which is the same as defined by
851 2007-06-25 Armin Burgmeier <armin@openismus.com>
853 * src/widgets/modest-window-mgr.c:
855 * configure.ac: Correctly recognize hildon-notify presence and fixed
856 the build without it being installed.
858 2007-06-25 Murray Cumming <murrayc@murrayc.com>
860 * libmodest-dbus-client/libmodest-dbus-client.c:
861 (libmodest_dbus_client_search): Fix the build. Sorry.
862 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
863 (reply_forward_cb): Initialize variables to fix the build.
865 * src/modest-tny-account-store.c:
866 (modest_tny_account_store_get_tny_account_by): Fix the account URI
867 comparison (a silly typo) so that email search results can be opened
868 when there are more than one account.
870 2007-06-25 Murray Cumming <murrayc@murrayc.com>
872 * libmodest-dbus-client/libmodest-dbus-client.c:
873 (libmodest_dbus_client_search),
874 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
875 instead of 1 second, because the search gets folders and messages from
876 the server, which can take a long time. When it times out,
877 osso-global-search will report no results.
879 We need to specify whether we should search only cached information
880 (maybe with a user preference), and the osso-email-search-plugin
881 API should really be improved to allow that option, and to allow results
882 to be delivered asynchronously in batches.
884 2007-06-25 Murray Cumming <murrayc@murrayc.com>
886 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
887 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
888 GTK_ICON_SIZE_DIALOG is probably the wrong size.
890 2007-06-25 Murray Cumming <murrayc@murrayc.com>
892 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
893 that is an empty string. D-Bus seems to give us these instead of NULL.
895 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
897 * src/dbus_api/modest-dbus-callbacks.c:
898 * src/maemo/easysetup/modest-easysetup-wizard.h:
899 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
900 * src/maemo/modest-connection-specific-smtp-edit-window.c:
901 (modest_connection_specific_smtp_edit_window_init):
902 * src/maemo/modest-maemo-global-settings-dialog.c:
904 * src/maemo/modest-maemo-utils.c:
905 (modest_maemo_utils_setup_images_filechooser):
906 * src/maemo/modest-main-window.c: (create_details_widget):
907 * src/maemo/modest-msg-edit-window.c:
908 (modest_msg_edit_window_attach_file_noninteractive),
909 (modest_msg_edit_window_color_button_change),
910 (modest_msg_edit_window_set_zoom):
911 * src/modest-mail-operation.c: (update_account_thread):
912 * src/modest-tny-account-store.c:
913 * src/modest-tny-account.c:
914 * src/widgets/modest-global-settings-dialog.c:
915 * src/widgets/modest-window.h:
919 2007-06-25 Murray Cumming <murrayc@murrayc.com>
921 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
922 * src/modest-search.c: (modest_search_folder),
923 (modest_search_all_accounts): Actually search only in the specified folder,
924 doing a simple match on the folder ID.
925 * src/modest-search.h: Added a folder field to the ModestSearch struct,
926 and added some documentation.
928 2007-06-22 Armin Burgmeier <armin@openismus.com>
930 * src/maemo/modest-maemo-utils.h:
931 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
932 modest_maemo_utils_get_supported_secure_authentication_methods.
934 * src/maemo/easysetup/modest-easysetup-wizard.c:
935 * src/maemo/modest-account-settings-dialog.c: Show correct error if
936 one occured, not just "Server does not support secure authentication".
938 2007-06-22 Murray Cumming <murrayc@murrayc.com>
940 * src/modest-tny-account-store.c: (get_password):
941 Restored the call to tny_account_set_user() because Philip seems to have
942 stopped this from crashing (by not using the freed string). It still does
943 not work, but now we can test it.
945 2007-06-22 Murray Cumming <murrayc@murrayc.com>
947 * src/maemo/modest-msg-edit-window.c: (init_window):
948 Comment out use of an uninitialzed GtkScrolledWindow variable,
949 to fix the build and stop a crash. Yet again.
951 2007-06-22 Murray Cumming <murrayc@murrayc.com>
953 * src/modest-tny-account-store.c: (get_password):
954 Remove the call to tny_account_set_user() because this actually crashes.
955 As mentioned in the last commit, it is known to not work anyway.
957 2007-06-22 Murray Cumming <murrayc@murrayc.com>
959 * src/modest-tny-account-store.c: (get_password):
960 Use tny_account_set_username() to tell tinymail that the username might
961 have changed too. But tinymail ignores this: see projects.maemo.org
963 * src/modest-ui-actions.c:
964 (modest_ui_actions_on_password_requested): Remove the useless attempt to
965 reset the connection when changing the username, and improve the comments.
966 Save the changed username to gconf at least, so it is used when Modest is
969 2007-06-21 Murray Cumming <murrayc@murrayc.com>
971 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
972 Do not use a query, so that we get all folders, including for POP and
973 local-folders. They work as search criteria too.
974 This fixes projects.maemo.org bug NB#57740.
976 2007-06-21 Murray Cumming <murrayc@murrayc.com>
978 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
979 Comment out the use of hildon_notification_set_sound() because it is
980 not declared, to fix the build. Warnings are serious, people.
982 2007-06-21 Armin Burgmeier <armin@openismus.com>
984 * src/maemo/modest-maemo-utils.h:
985 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
986 modest_maemo_utils_get_supported_secure_authentication_methods()
987 to query authentication methods for a specific user. This should fix
988 projects.maemo.org bug NB#61369.
990 * src/maemo/easysetup/modest-easysetup-wizard.c:
991 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
994 2007-06-21 Murray Cumming <murrayc@murrayc.com>
996 * libmodest-dbus-client/libmodest-dbus-client.h:
997 * libmodest-dbus-client/libmodest-dbus-client.c:
998 (modest_dbus_message_iter_get_search_hit),
999 (libmodest_dbus_client_search):
1000 Reorganised and commented this.
1001 Removed modest_search_hit_free() from the public API because it
1004 Added libmodest_dbus_client_get_folders() and
1005 modest_folder_result_list_free().
1007 * src/dbus_api/modest-dbus-api.h:
1008 * src/dbus_api/modest-dbus-callbacks.c:
1009 (modest_dbus_req_filter): Commented. Moved most code to
1010 on_dbus_method_search() and added on_dbus_method_get_folders().
1012 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1013 of the extra D-Bus handler.
1015 * tests/dbus_api/Makefile.am:
1016 * tests/dbus_api/test_get_folders.c: New test for
1017 libmodest_dbus_client_get_folders(). This seems to return an empty list
1018 at the moment. That could be the same error that causes the message list
1019 to be empty sometimes.
1020 This should help with projects.maemo.org bug NB#57740.
1022 2007-06-21 Armin Burgmeier <armin@openismus.com>
1024 * src/modest-mail-operation.c: Do not call
1025 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1026 notify the operation's end after having set the status to CANCELED for
1027 the operation queue to listen on. This fixes a deadlock when there
1028 were mail operations in the queue during its finalization.
1030 * src/modest-singletons.c: Reordered uninitialization of the account
1031 manager to happen after the mail operation queue was uninitialized
1032 because the mail operation's in the queue might still try to access
1033 the account manager (see modest_mail_operation_notify_end()). This
1034 fixes a potential crash when terminating the application.
1036 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1038 * src/modest-search.c:
1039 (search_mime_part_and_child_parts): Moved some code here so we
1040 can search recursively in child folders.
1041 (modest_search_folder): Search in the message as a mime part, instead
1042 of just its child mime parts.
1043 (read_chunk), (search_mime_part_ogs):
1044 Check how many bytes were read, to prevent an endless loop.
1045 Searching in message bodies now works. This finishes the fix for
1046 projects.maemo.org bug NB#61007.
1048 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1050 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1051 Add a g_warning when the item is not a folder.
1053 * src/modest-ui-dimming-rules.c:
1054 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1055 when selected item is not a folder (for instance, an account), because
1056 the UI spec only talks about folders.
1057 I am not sure what the UI spec wants, so this might not totally fix
1058 projects.maemo.org bug NB#60794.
1060 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1062 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1063 (load_from_file): Sort the list. The unsorted list would be more noticeable
1064 in non-English locales.
1066 * src/maemo/modest-msg-edit-window.c:
1067 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1068 warning and fix the build.
1070 * src/maemo/modest-progress-bar-widget.c:
1071 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1072 avoid a g_warning, and probably to avoid a crash.
1074 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1076 * src/modest-search.c: (modest_search_folder): Check for a GError
1077 when calling tny_folder_get_headers(), to show that this is not the cause
1080 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1082 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1083 Actually set the body query instead of the subject query.
1085 * src/modest-search.c: (search_mime_part_ogs),
1086 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1087 which would probably cause it to fail if we got this far.
1089 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1090 to simplify the code.
1091 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1092 be causing search-in-body to fail.
1094 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1096 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1098 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1099 Better debug message when the folder cannot be found.
1100 This should help with fixing projects.maemo.org bug #61287.
1101 * src/modest-search.c: (add_hit): Do not leak the furl string.
1103 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1105 * src/modest-ui-actions.c:
1106 (modest_ui_actions_on_folder_selection_changed):
1107 Do not special-case TNY_MERGE_FOLDER here, because
1108 modest_tny_folder_get_account() already does that. This fixes
1109 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1110 shown when the Outbox was selected).
1112 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1114 * libmodest-dbus-client/libmodest-dbus-client.c:
1115 (_dbus_iter_get_string_or_null): Initialize the string variable in
1116 case this helps with Dirk's crash.
1118 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1120 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1121 though it is not implemented yet (this function is maybe not even used),
1122 to avoid breaking ABI in future.
1123 * libmodest-dbus-client/libmodest-dbus-client.c:
1124 (get_attachments_string): Moved some code into this generic function.
1125 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1126 sends email. It is maybe not used.
1127 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1128 (on_send_mail): Use attachments.
1130 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1131 * src/maemo/modest-msg-edit-window.c:
1132 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1133 a filename before using it, to fix projects.maemo.org bug NB#58233.
1135 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1137 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1138 Initialize the continue_download variable to fix the build, and probably
1139 to fix randome behaviour.
1141 2007-06-18 Armin Burgmeier <armin@openismus.com>
1143 * src/modest-tny-send-queue.h:
1144 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1145 the queue so we can later show it in the UI. Replaced
1146 modest_tny_send_queue_msg_is_being_sent() by
1147 modest_tny_send_queue_get_msg_status().
1149 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1151 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1152 gpointer. This probably was not harmful, but just to be sure.
1154 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1156 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1157 Fix the build, but leave the function broken on Bora, because
1158 hildon_uri_action_get_service() does not exist.
1159 osso_uri_action_get_service() does not exist either, it seems.
1161 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1163 * src/modest-tny-account.c:
1164 (modest_tny_account_new_from_server_account):
1165 Uncommented the url debug output again, because it is useful for
1166 debugging, as I said in the comment.
1168 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1170 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1172 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1173 for Mameo Bora, to fix the build.
1175 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1178 Fixed build with hildon < 0.99
1180 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1181 Check if the selected account is busy instead of checking all accounts
1183 * src/modest-account-mgr-priv.h:
1184 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1185 (modest_account_mgr_init), (compare_account_name),
1186 (modest_account_mgr_set_account_busy),
1187 (modest_account_mgr_account_is_busy):
1188 * src/modest-account-mgr.h:
1189 Added busy information to the account manager. It possible to
1190 set an account to busy or not busy now.
1192 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1193 (modest_mail_operation_update_account),
1194 (modest_mail_operation_notify_end):
1195 Set the account to busy/not busy depending on the operation state.
1197 * src/widgets/modest-account-view.c:
1198 (modest_account_view_finalize), (get_last_updated_string),
1199 (update_account_view), (on_account_busy_changed), (init_view):
1200 Show string "Refreshing..." if the account is currently busy.
1202 All this fixes projects.maemo.org bug NB#59711
1204 2007-06-14 Armin Burgmeier <armin@openismus.com>
1206 * src/widgets/modest-attachments-view.h:
1207 * src/widgets/modest-attachments-view.c: Added
1208 modest_attachments_view_has_attachments() and fixed coordinate
1209 transformation in get_att_view_at_coords(). This fixes attachment
1212 * src/widgets/modest-msg-view.c: Make use of
1213 modest_attachments_view_has_attachments() to decide whether to show
1214 attachments in the header.
1216 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1218 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1219 (on_change), (on_combo_security_changed),
1220 (modest_connection_specific_smtp_edit_window_init),
1221 (modest_connection_specific_smtp_edit_window_set_connection),
1222 (modest_connection_specific_smtp_edit_window_is_dirty):
1223 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1224 * src/maemo/modest-connection-specific-smtp-window.c:
1227 Show an comfirmation dialog for the smpt-edit-window if there are
1228 unsaved changes and the user hits cancel.
1229 (projects.maemo.org bug NB#60479)
1231 2007-06-14 Armin Burgmeier <armin@openismus.com>
1233 * src/maemo/easysetup/modest-easysetup-wizard.c:
1234 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1235 address" info in banner instead of node, and select all the text as
1236 per UI spec. This fixes projects.maemo.org bug NB#60550.
1238 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1240 reviewed by: <delete if not using a buddy>
1242 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1243 * src/modest-ui-actions.c: (folder_refreshed_cb):
1245 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1247 * src/widgets/modest-folder-view.c: (filter_row):
1248 Explictly filter out the per-account outbox accounts. I don't know why
1249 these only sometimes show up, but now they should never show up in the UI.
1250 This should fix projects.maemo.org bug NB#60160.
1252 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1254 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1255 when the toolbar does not exist yet.
1256 * src/modest-widget-memory.c: (save_settings_header_view):
1257 Added g_warnings() to help us to discover when we are trying to set
1258 an empty columns list in gconf.
1260 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1262 * src/modest-init.h:
1263 * src/modest-init.c:
1264 Added modest_init_get_default_header_view_column_ids().
1266 * src/modest-widget-memory.c: (restore_settings_header_view):
1267 Use the new function to get defaults, if the gconf key is empty,
1268 instead of not creating any columns. This seems to fix the
1269 empty right-hand pane problems.
1271 * src/widgets/modest-header-view.h: Improved documentation.
1273 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1275 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1276 Revert the use of the display name as the account name, because this
1277 is generally wrong and would break the code that follows.
1279 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1281 * src/maemo/easysetup/modest-easysetup-wizard.c:
1282 (check_for_supported_auth_methods), (on_before_next),
1285 More correct fix for projects.maemo.org bug NB# 58991
1286 Do not longer accept AUTH_PASSWORD as secure method and choose
1287 correct method when creating the account.
1289 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1291 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1292 Fixed projects.maemo.org bug NB# 58991
1294 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1296 * src/modest-init.c: (modest_init_init_core),
1297 (modest_init_local_folders): Fixed compilation errors.
1299 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1301 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1302 Remove unnecessary lib/include, though it is good in principle when needed.
1304 * src/modest-init.c: (modest_init_one_local_folder),
1305 (modest_init_local_folders):
1306 * src/modest-init.h: Initialize the .modest library for memory cards,
1307 instead of just doing nothing for them. This should allow us to create
1308 folders there, fixing projects.maemo.org bug NB#59297.
1310 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1312 * libmodest-dbus-client/libmodest-dbus-client.c:
1313 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1314 (libmodest_dbus_client_compose_mail),
1315 (libmodest_dbus_client_open_message),
1316 (libmodest_dbus_client_send_and_receive),
1317 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1319 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1320 (on_idle_open_message), (modest_dbus_req_handler),
1321 (search_result_to_message), (modest_dbus_req_filter):
1322 * src/modest-search.c: (add_hit), (modest_search_folder),
1323 (modest_search_all_accounts): Improved debug messages.
1325 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1327 * src/modest-tny-account-store.c:
1328 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1331 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1334 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1336 * src/modest-tny-account-store.c: (get_server_accounts):
1337 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1338 even when there are no accounts, so that the Outbox folder is always
1339 visible. This fixes projects.maemo.org bug NB#60158.
1341 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1343 * src/maemo/modest-main-window.c: (create_details_widget):
1344 Use the mcen_va_never logical ID.
1346 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1348 * src/dbus_api/modest-dbus-api.h:
1349 * src/dbus_api/modest-dbus-callbacks.c:
1350 (on_idle_open_default_inbox), (on_open_default_inbox),
1351 (modest_dbus_req_handler):
1352 Added a new OpenDefaultInbox method.
1354 * libmodest-dbus-client/libmodest-dbus-client.h:
1355 * libmodest-dbus-client/libmodest-dbus-client.c:
1356 Added libmodest_dbus_client_open_default_inbox() to call the new
1357 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1358 though it should maybe be used by a new osso-email-interface function.
1360 * tests/dbus_api/Makefile.am:
1361 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1364 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1366 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1367 NULL, so that the signals get all the keys. This should not actually
1368 change any behaviour because we currently update everything when anything
1371 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1373 * src/widgets/modest-folder-view.c: (text_cell_data),
1374 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1375 (find_inbox_iter): If tinymail tells us that the folder is
1376 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1377 This causes the inbox to be selected at startup, fixing part of
1378 projects.maemo.org bug NB#56305.
1380 * src/modest-ui-dimming-rules.c:
1381 (modest_ui_dimming_rules_on_tools_smtp_servers):
1382 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1383 the SMTP servers menu item.
1384 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1385 that the SMTP Servers menu item is dimmed when there are no accounts,
1386 as a future version of the UI spec will require. This fixes
1387 projects.maemo.org bug NB#56305.
1389 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1391 * src/maemo/modest-maemo-utils.c:
1392 (modest_maemo_utils_get_supported_secure_authentication_methods):
1393 Added label to dialog instead of unreadable title
1395 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1396 (modest_main_window_new):
1397 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1400 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1401 * src/modest-account-mgr.h:
1402 Added method to avoid code duplication
1404 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1405 (modest_ui_actions_on_send_receive):
1406 Use modest_account_mgr_has_accounts
1408 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1410 * src/maemo/easysetup/modest-presets.c:
1411 (modest_presets_get_info_server_security): Do not report secure auth
1413 * src/modest-protocol-info.c: Use the defines for the gconf key names
1414 for secure authentication. This was not working because we were writing
1415 Password and reading password, and the check was case sensitive.
1416 With this, gmail now works for receiving and sending when created via
1419 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1421 * src/maemo/easysetup/modest-presets.c:
1422 (modest_presets_get_info_server_security): Correct the key name for
1423 SecureSmtp, because it seems to be case-sensitive.
1424 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1425 Do not try to get the 0th notebook page if there are 0 pages, to
1426 avoid a g_warning().
1428 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1430 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1431 Prevent use of the new notification feature for now, because it currently
1432 shows one dialog for each new email, which is annoying.
1434 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1436 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1437 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1438 when no country was selected, so that we show the global ones.
1439 * src/maemo/easysetup/modest-presets.c:
1440 (modest_presets_get_providers): Return only the global providers, not
1441 all providers when mmc=0 was requested.
1443 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1445 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1446 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1447 provider ID in the combo.
1449 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1450 Do not show the page numbers, because it would be confusing when we add
1451 the 2 extra pages for the custom setup, when the user chooses the "Other"
1452 provider. This fixes projects.maemo.org bug NB#59028
1454 * src/modest-init.c: (modest_init_init_core),
1455 (modest_init_local_folders):
1456 * src/modest-init.h:
1457 * src/modest-tny-account.c:
1458 (modest_tny_account_new_for_local_folders): Do not create default folders
1459 for the memory card. This should fix projects.maemo.org bug NB#59328.
1461 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1463 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1464 Free the changed_conf_keys string items. They are already freed in the
1465 idle handler if that runs first.
1467 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1469 * src/modest-ui-actions.c:
1470 (modest_ui_actions_on_password_requested): Check that the server name
1471 is not NULL, because I just saw a password dialog with (null) as the
1474 * src/modest-tny-folder.[h|c]: Added
1475 modest_tny_folder_is_memory_card_folder().
1476 * src/modest-ui-dimming-rules.c:
1477 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1478 menu item for memory cards, as per the UI spec (section 7.4). This should
1479 fix projects.maemo.org bug NB#59297.
1481 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1483 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1484 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1485 is another problem with the code, see Murray's comment at line 772)
1487 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1489 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1490 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1491 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1492 (load_from_file), (easysetup_country_combo_box_init),
1493 (easysetup_country_combo_box_get_active_country_ids),
1494 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1495 instead of just one ID, to avoid duplicate country names in the UI.
1497 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1498 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1499 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1500 a single ID, avoiding duplicate providers.
1501 * src/maemo/easysetup/modest-easysetup-wizard.c:
1502 (on_combo_account_country): Adapt to use a list.
1504 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1506 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1507 keys changed in the last X seconds.
1509 * src/modest-account-mgr.h:
1510 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1511 (on_key_change), (modest_account_mgr_class_init),
1512 (modest_account_mgr_init), (modest_account_mgr_finalize):
1513 As the keys are changed, save them in a GSList* and signal that GSList*
1514 further every X seconds, to batch changes, to allow us to do just one
1515 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1516 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1518 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1519 changed signal signature.
1521 * src/modest-conf.c: (modest_conf_set_list),
1522 (modest_conf_on_change): Reenable notification.
1524 (modest_conf_maemo_fake_on_change): Comment out the hack that
1525 notified immediately instead of asynchronously.
1527 * src/widgets/modest-account-view.h:
1528 * src/widgets/modest-account-view.c:
1529 (update_account_view): Select the previously-selected account ID,
1530 if possible. This fixes projects.maemo.org bug NB#56933.
1532 (on_account_changed), (on_account_removed),
1533 (modest_account_view_select_account):
1535 Remove the block/unblock functions
1536 because they were not useful.
1538 * src/maemo/modest-account-view-window.c:
1539 (on_delete_button_clicked), (on_edit_button_clicked),
1540 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1542 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1544 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1545 Improve the error dialog to show Incorrect Account Settings, which seems
1546 clearer, and say that the internal error message (to be removed from the
1547 dialog later) is often misleading.
1548 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1550 * src/modest-tny-account.c:
1551 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1552 URL because this is so useful for debugging on the device.
1554 * src/widgets/modest-serversecurity-combo-box.c:
1555 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1557 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1559 * src/modest-mail-operation.c:
1560 (modest_mail_operation_send_new_mail):
1561 Added a comment about a nasty but apparently harmless message. Details
1562 added to the wiki g_warnings() page.
1564 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1566 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1567 (modest_tny_send_queue_class_init):
1568 Do not use the priv struct because it is empty, to avoid g_warnings
1569 about a non-existant priv struct.
1571 * src/modest-tny-account-store.c:
1572 (modest_tny_account_store_get_server_account),
1573 (modest_tny_account_store_get_transport_account_for_open_connection
1574 ): Do not try to get transport server accounts for local folders,
1575 because they don't have any. This avoids a g_warning().
1577 * src/maemo/modest-main-window.c:
1578 (modest_main_window_notify_send_receive_initied),
1579 (on_configuration_key_changed):
1580 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1581 * src/modest-defs.h:
1582 * src/modest-mail-operation.c:
1583 (modest_mail_operation_update_account):
1584 * src/modest-tny-account-store.h:
1585 * src/modest-tny-account.c:
1586 (modest_tny_account_get_special_folder),
1587 (modest_tny_account_new_for_local_folders),
1588 (modest_tny_account_new_for_per_account_local_outbox_folder):
1589 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1590 * src/modest-tny-local-folders-account.c:
1591 (add_account_folders_to_merged_folder):
1592 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1593 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1594 (modest_ui_actions_on_send):
1595 * src/widgets/modest-folder-view.c: (update_model):
1596 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1597 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1598 modest_tny_account_store_get_tny_account_by_account() to
1599 modest_tny_account_store_get_server_account() to make the code clearer.
1601 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1603 * src/dbus_api/modest-dbus-api.h:
1604 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1605 * src/maemo/modest-msg-edit-window.c:
1606 (modest_msg_edit_window_attach_file_noninteractive):
1607 added g_warning in case the file to be attached does not exist
1608 * tests/dbus_api/test_compose_mail.c: (main):
1609 removed obsolete comment, added generic files as test case
1611 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1613 * src/modest-tny-account-store.c: (get_server_accounts):
1614 Create the local folders account only once, not once for each outbox, and
1615 not only when there are some outboxes.
1617 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1619 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1620 code that is causing a crash at startup. Sergio says that he is fixing this.
1622 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1624 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1625 * src/maemo/modest-account-settings-dialog.c:
1626 (create_page_outgoing),
1627 (modest_account_settings_dialog_set_account_name),
1628 (save_configuration):
1629 - Fixed handling of the "Use secure authentication" toggle to comply with
1630 the ui specification. See also projects.maemo.org bug NB#58400
1632 - Restore the Secure connection setting combo correctly when loading
1635 * src/maemo/modest-maemo-utils.c:
1636 (on_camel_account_get_supported_secure_authentication),
1637 (modest_maemo_utils_get_supported_secure_authentication_methods):
1638 Fixed a crasher if operation is canceled
1640 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1641 (modest_protocol_info_auth_is_secure):
1642 * src/modest-protocol-info.h:
1644 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1645 the sense of the "Use secure authentication" toggle.
1647 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1649 * src/modest-tny-account-store.h:
1650 * src/modest-tny-account-store.c:
1651 Added modest_tny_account_store_get_local_folders_account().
1653 * src/modest-tny-folder.h:
1654 * src/modest-tny-folder.c:
1655 (modest_tny_folder_get_account):
1656 Added this replacement for tny_folder_get_account() which returns
1657 the local-folders account for TnyMergeFolders, to avoid the
1658 warning about the unimplemented get_account_func() vfunc().
1660 (modest_tny_folder_get_rules),
1661 * src/modest-ui-actions.c:
1662 (modest_ui_actions_on_folder_selection_changed):
1663 * src/modest-mail-operation.c:
1664 (modest_mail_operation_remove_folder),
1665 (modest_mail_operation_xfer_folder),
1666 (modest_mail_operation_rename_folder),
1667 (modest_mail_operation_get_msg),
1668 (modest_mail_operation_get_msgs_full),
1669 (modest_mail_operation_remove_msg),
1670 (modest_mail_operation_xfer_msgs),
1671 (modest_mail_operation_refresh_folder):
1672 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1674 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1676 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1677 (modest_server_account_set_security):
1678 * src/modest-defs.h: Add comments explaining that our
1679 UI spec means TLS when it says Normal, so these do not look like errors.
1681 * src/modest-tny-account.c:
1682 (modest_tny_account_new_from_server_account): Use the new tinymail
1683 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1684 for TLS. This should fix projects.maemo.org bug NB#58460.
1686 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1688 * src/maemo/easysetup/modest-easysetup-wizard.c:
1689 (create_account): Correct the position of the gconf sanity check warning.
1690 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1691 of using the g_idle_add() hack, because this does not seem to be necessary
1692 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1693 caused by something other than maemo's gconf.
1694 This fixes projects.maemo.org bug #59022.
1696 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1698 * src/modest-account-mgr-helpers.c:
1699 (modest_account_mgr_get_default_account): Do not check that the account
1700 exists if there is no default account (NULL), to fix a runtime warning.
1702 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1704 * src/widgets/modest-folder-view.c: (update_model):
1705 Do not unref the treemodel before we have finished with it.
1706 This prevents a valgrind warning and an occasional crash at startup.
1708 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1710 * libmodest-dbus-client/libmodest-dbus-client.h:
1711 added libmodest_dbus_client_compose_mail()
1712 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1714 added functions needed for SendAsMail() functionality
1715 * src/maemo/modest-msg-edit-window.c:
1716 (modest_msg_edit_window_attach_file_noninteractive):
1717 non interactively attaching files to message edit window
1718 * src/widgets/modest-msg-edit-window.h:
1719 * tests/dbus_api/Makefile.am:
1720 added test_compose_mail.c
1721 * tests/dbus_api/test_compose_mail.c: (main):
1723 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1725 * src/modest-account-view.c:
1726 Fixed bug projects.maemo.org bug NB#59307
1728 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1730 * src/maemo/easysetup/modest-easysetup-wizard.c:
1731 (get_serverport_incoming), (on_before_next), (create_account):
1732 * src/maemo/modest-account-settings-dialog.c:
1733 (modest_account_settings_dialog_set_account_name):
1734 * src/maemo/modest-maemo-utils.c:
1735 (on_camel_account_get_supported_secure_authentication_status),
1736 (on_camel_account_get_supported_secure_authentication),
1737 (on_secure_auth_cancel),
1738 (modest_maemo_utils_get_supported_secure_authentication_methods):
1740 Implemented security authentication for settings and easysetup.
1742 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1744 * src/maemo/modest-main-window.c: (create_details_widget):
1745 Show the total size for memory card accounts too, instead of showing
1746 the name again. Fixes bug projects.maemo.org bug NB#59307.
1748 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1751 * src/modest-tny-simple-folder-store.c:
1752 * src/modest-tny-simple-folder-store.h: Removed.
1754 * src/modest-tny-local-folders-account.h
1755 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1756 for the local-folders maildir, with an extra TnyMergedFolder containing
1757 the folders of the per-account outbox store accounts.
1758 * src/modest-tny-account-store.c: (get_server_accounts):
1759 Add the outboxes to the special local folders account after creating it.
1761 * src/modest-tny-account.c:
1762 (modest_tny_account_new_for_local_folders): Create the derived
1763 account when creating the main local-folders account.
1765 * src/maemo/modest-main-window.c: (create_details_widget),
1766 (modest_main_window_set_contents_style):
1767 Adapted to the use of the derived account instead of the folder store.
1769 * src/modest-ui-actions.c:
1770 (modest_ui_actions_on_folder_selection_changed):
1771 * src/modest-ui-dimming-rules.c:
1772 (modest_ui_dimming_rules_on_new_folder):
1773 * src/widgets/modest-folder-view.c: (text_cell_data),
1774 (icon_cell_data), (filter_row), (update_model),
1775 (get_cmp_rows_type_pos):
1778 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1779 Do not get the priv struct, because no priv struct has been set,
1780 to avoid a runtime warning.
1782 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1783 #ifelse with #else, to fix a warning, to fix the build.
1786 2007-06-05 Christian Kellner <ckellner@openismus.com>
1788 * libmodest-dbus-client/libmodest-dbus-client.c:
1789 Fix small typo in doc (why do you always see them
1790 AFTER committing stuff?)
1793 2007-06-05 Christian Kellner <ckellner@openismus.com>
1795 * libmodest-dbus-client/libmodest-dbus-client.c:
1796 (libmodest_dbus_client_search):
1797 Initialize hit list with NULL. Also set folder list
1798 to "" if NULL was supplied.
1801 2007-06-03 Christian Kellner <ckellner@openismus.com>
1803 * libmodest-dbus-client/libmodest-dbus-client.c:
1804 (modest_search_hit_list_free):
1805 Make it save to call it with NULL.
1807 * src/dbus_api/modest-dbus-callbacks.c:
1808 * src/modest-search.c:
1809 Return full ModestSearchHits as the search result list not TnyHeader
1810 since can't be around withouth the correspoding TnyFolder.
1812 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1814 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1815 Added currently commented code to check for secure auth
1817 * src/maemo/modest-account-settings-dialog.c: (on_response),
1818 (save_configuration), (show_ok):
1819 Fixed projects.maemo.org bugs NB #59248 and #59251
1821 * src/maemo/modest-maemo-utils.c:
1822 (on_camel_account_get_supported_secure_authentication_status),
1823 (on_camel_account_get_supported_secure_authentication),
1824 (modest_maemo_utils_get_supported_secure_authentication_methods):
1825 * src/maemo/modest-maemo-utils.h:
1826 Moved get_supported_secure_authentication() method here to be able
1827 to use it from easysetup wizard.
1829 * src/modest-pair.c: (on_pair_compare_as_string):
1830 Should compare string with first part of pair and not
1831 strcmp pairs which will crash.
1833 * src/modest-protocol-info.c:
1834 (modest_protocol_info_protocol_is_store):
1835 * src/modest-protocol-info.h:
1836 Added modest_protocol_info_get_auth_protocol_name()
1838 2007-06-03 Armin Burgmeier <armin@openismus.com>
1840 * src/modest-mail-operation.c:
1841 (modest_mail_operation_get_msgs_full): Set priv->account also when
1842 only retrieving a single message. This avoids a crash when canceling
1845 (modest_mail_operation_notify_end): Do not explicitely remove the
1846 operation from the queue but only emit the progress_changed signal.
1847 The queue itself listens to that signal to remove the operation when
1848 it is finished. This reduces coupling and removes a potential deadlock
1849 when modest_mail_operation_notify_end() is called from the queue
1850 itself. If that is a problem performance-wise, I would suggest to
1851 implement a status-changed signal or something.
1853 * src/modest-mail-operation-queue.c: Make sure to never call a
1854 function from another file while the queue is locked. This (hopefully)
1855 fixes another deadlock when exiting the application while retrieving
1858 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1860 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1861 Fixed build if libogs is not available
1863 2007-06-03 Christian Kellner <ckellner@openismus.com>
1865 * libmodest-dbus-client/libmodest-dbus-client.h:
1866 * libmodest-dbus-client/libmodest-dbus-client.c:
1867 (libmodest_dbus_client_delete_message):
1868 Implement deletion of messages (Client side).
1870 (modest_search_hit_free),
1871 (modest_search_hit_list_free):
1872 Utility functions to free the result hits.
1874 * src/dbus_api/modest-dbus-api.h:
1875 * src/dbus_api/modest-dbus-callbacks.c:
1876 (on_delete_message),
1877 (modest_dbus_req_handler):
1878 Implement deletion of messages (Server side).
1880 * tests/dbus_api/test_search.c: (main):
1883 * tests/dbus_api/Makefile.am:
1884 * tests/dbus_api/test_delete_message:
1885 Add little test for the message deletion logic
1887 2007-06-03 Armin Burgmeier <armin@openismus.com>
1889 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1890 when the operation queue was not empty. projects.maemo.org bug
1893 2007-06-03 Armin Burgmeier <armin@openismus.com>
1895 * src/widgets/modest-account-view.c
1896 (on_account_default_toggled): Toggle default account column
1897 explicitely instead of waiting for gconf notification (which is
1898 currently ignored). This should fix projects.maemo.org bug NB#56910
1899 for now. It should probably be removed when gconf notifications are
1902 2007-06-03 Christian Kellner <ckellner@openismus.com>
1904 * libmodest-dbus-client/libmodest-dbus-client.c:
1905 Removed debugging spew.
1907 * src/dbus_api/modest-dbus-callbacks.c:
1908 Added debugging info.
1910 * src/modest-search.c:
1911 (modest_search_all_accounts):
1912 Use tny_account_store_get_accounts () on the account store
1913 to get all accounts which is the way to get all accounts.
1915 * tests/dbus_api/test_search.c: (main):
1916 Make it possible to supply the search term on the command line.
1918 2007-06-03 Christian Kellner <ckellner@openismus.com>
1920 * libmodest-dbus-client/libmodest-dbus-client.c:
1921 * libmodest-dbus-client/libmodest-dbus-client.h:
1922 Implement searching for mesages over raw dbus. (Client side)
1924 * src/dbus_api/Makefile.am:
1925 * src/dbus_api/modest-dbus-api.h:
1926 * src/dbus_api/modest-dbus-callbacks.c:
1927 * src/dbus_api/modest-dbus-callbacks.h:
1928 Search framework (Server side). Also implement on_idle_open_message().
1930 * src/maemo/modest-platform.c: (modest_platform_init):
1931 Prepare for raw dbus/osso rpc interaction.
1933 * src/modest-search.h:
1934 Changed minsize from unspecific guint to guint32.
1936 * src/modest-search.c:
1938 Added strange hack which magically made tnymail work.
1940 (modest_search_folder),
1941 (modest_search_account),
1942 (modest_search_all_accounts):
1943 Implement helper functions to search all accounts, specific account
1946 * tests/dbus_api/Makefile.am:
1947 * tests/dbus_api/test_open_message.c:
1948 Read url to open from commandline.
1950 * tests/dbus_api/test_search.c:
1951 Implement small test for dbus search stuff
1953 2007-06-02 Armin Burgmeier <armin@openismus.com>
1955 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1956 include account type and account title. This fixes projects.maemo.org
1959 * src/maemo/modest-account-view-window.c: Set a title for the window.
1961 2007-06-02 Armin Burgmeier <armin@openismus.com>
1963 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1964 incoming and outgoing server name based on email address and server
1965 types as long as the names have not been edited manually. This fixes
1966 projects.maemo.org bug NB#58671.
1968 2007-06-02 Armin Burgmeier <armin@openismus.com>
1970 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1971 server type cannot be changed in future to the incoming details page
1972 when creating an account. This fixes projects.maemo.org bug NB#59029.
1974 2007-06-02 Armin Burgmeier <armin@openismus.com>
1976 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1977 and assigned max width chars so that they wrap instead of being
1978 truncated. Fixes projects.maemo.org bug NB#56126.
1980 2007-06-02 Armin Burgmeier <armin@openismus.com>
1982 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1983 introductory note to the connection specific smtp servers dialog, as
1984 section 8.12 of the email UI specification requires. This fixes
1985 projects.maemo.org bug NB#59212.
1987 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1989 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1990 Check for running mail operations, and offer to cancel them, as per the UI
1991 spec. This fixes projects.maemo.org bug NB#59041 .
1992 However, I suspect that tinymail may still use the network connection
1993 in ways that we cannot detect or cancel. But it should at least adapt to
1994 changes fairly well.
1996 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1998 * src/modest-tny-account-store.c: (recreate_all_accounts),
1999 (get_cached_accounts), (get_server_accounts): Do more sensible
2000 ref-counting of the temporarily-cached outbox accounts list. This seems
2001 to fix a crash when entering the password when the password was wrong.
2003 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2005 * src/gnome/modest-main-window.c: (connect_signals):
2006 * src/modest-tny-account-store.c: (get_password),
2007 (modest_tny_account_store_alert): Added comments and clues and
2008 commented-out code about how we currently fail to deal with connection
2009 errors and wrong passwords, and how we should.
2011 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2013 * src/widgets/modest-retrieve-combo-box.c:
2014 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2015 This fixes projects.maemo.org bug NB#58472 .
2017 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2019 * src/maemo/easysetup/modest-easysetup-wizard.c:
2020 (create_page_complete_easysetup):
2021 (create_page_complete_custom): Correct the last commit,
2022 putting the correct sentences in the correct pages.
2024 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2026 * src/maemo/easysetup/modest-easysetup-wizard.c:
2027 (create_page_complete_custom): Show the second sentence of text
2028 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2031 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2033 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2034 Set the leave-on-server conf key by default. This fixes
2035 projects.maemo.org bug NB#59258 .
2037 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2039 * src/maemo/modest-account-view-window.c:
2040 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2041 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2044 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2046 * src/maemo/easysetup/modest-easysetup-wizard.c:
2047 (create_caption_new_with_asterisk):
2048 * src/maemo/modest-account-settings-dialog.c:
2049 (create_caption_new_with_asterisk):
2050 Uncomment the code to add the asterisk, because they are no longer in the
2051 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2052 (update_incoming_server_title): Add an asterisk here too.
2054 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2056 * src/maemo/modest-maemo-global-settings-dialog.c:
2057 (current_connection): Check that we are even connected before trying to
2058 get the current connection name, to prevent a warning.
2060 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2061 Change the comments because tny_maemo_conic_device_connect() is now meant to
2063 * src/modest-mail-operation.c:
2064 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2065 make sure we have a connection and fail if we can't connect.
2067 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2069 * src/maemo/modest-main-window.c:
2070 (on_account_store_connecting_finished): Do not try to get the
2071 connection ID if we are not really connected. I am surprised that
2072 this signal handler is called when we are not connected.
2074 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2076 * src/modest-error.h:
2077 * src/modest-ui-actions.c:
2078 (modest_ui_actions_get_msgs_full_error_handler):
2079 Renamed an enum, added comments, added an enum
2080 for retrieve-limit errors.
2082 * src/modest-mail-operation.c: (foreach_add_item),
2083 (internal_folder_observer_update), (update_account_thread),
2084 (modest_mail_operation_get_msgs_full):
2085 (modest_mail_operation_update_account),
2086 Added comments about how this works, and some code that should
2087 (but does not) check the retrieve-limit. See the TODO comment.
2089 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2091 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2092 Initialize help_id to fix the build. Warnings are good.
2094 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2096 * src/widgets/modest-hbox-cell-renderer.c:
2097 (modest_hbox_cell_renderer_append):
2098 * src/widgets/modest-vbox-cell-renderer.c:
2099 (modest_vbox_cell_renderer_append):
2100 Fix the last commit by doing an extra ref.
2102 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2104 * src/widgets/modest-hbox-cell-renderer.c:
2105 (modest_hbox_cell_renderer_append):
2106 * src/widgets/modest-vbox-cell-renderer.c:
2107 (modest_vbox_cell_renderer_append):
2108 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2109 to fix the build with Maemo Bora.
2110 However, there seems to be a remaining crash, probably due to reference
2113 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2115 * src/modest-tny-account.c:
2116 (modest_tny_account_new_for_local_folders):
2117 Use hildon_file_system_info_async_new() to get a better name for
2118 the memory card account, setting it as the account name.
2119 The timing seems to work, but this is probably
2120 not the best place to do this. See the TODO comment.
2121 * src/maemo/modest-main-window.c: (create_details_widget):
2122 * src/widgets/modest-folder-view.c: (text_cell_data):
2123 Use the tny account name instead of hardcoding a name.
2125 2007-05-30 Christian Kellner <ckellner@openismus.com>
2127 * src/modest-search.c: (modest_search):
2128 Correctly set part_search_func even if we have already parsed
2129 the query and thus a valid OgsTextSearcher object.
2131 2007-05-30 Christian Kellner <ckellner@openismus.com>
2134 Search and check for libogs.
2137 Incooparte the ogs build env.
2139 * src/modest-mime-part-search-stream.c:
2140 * src/modest-mime-part-search-stream.h:
2141 Removed since we do the real searching now in modest-search.c.
2143 * src/modest-search.c:
2144 * src/modest-search.h:
2145 Implement support for ogs. We use that if available and requested
2146 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2147 should now handle the corner case when the search term is spread
2148 across multiple reads.
2149 Also the logic in modest_search () was corrected to search all
2150 requested fields until one is found.
2152 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2154 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2156 * src/modest-init.h:
2157 * src/modest-init.c: Made modest_init_local_folders() take a
2158 path and be public so we can iniitialize maildir folders on
2161 * src/modest-local-folder-info.h:
2162 * src/modest-local-folder-info.c:
2163 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2165 * src/modest-tny-account.c:
2166 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2167 still means the standard local-folders path on the local volume.
2169 * src/modest-tny-account-store.c:
2170 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2171 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2172 all accounts when that happens.
2173 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2174 this too, so it shows up in the treeview.
2176 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2178 * src/maemo/modest-maemo-global-settings-dialog.c:
2179 (current_connection):
2180 * src/widgets/modest-global-settings-dialog.c:
2181 (current_connection_default):
2182 Use the enum values instead of 0, 1 and -1,
2183 to make the code clearer.
2185 * src/modest-account-mgr-helpers.c:
2186 (modest_account_mgr_get_connection_specific_smtp): Make this code
2189 * src/modest-runtime.h:
2190 * src/modest-runtime.c:
2191 Added modest_runtime_remove_all_send_queues().
2192 * src/maemo/modest-main-window.c:
2193 (on_account_store_connecting_finished): Recreate the send queues,
2194 using the appropriate transport accounts for this new connection.
2195 Some futher adapting might be needed if the old send queues are not
2196 automatically stopped at this point.
2198 * src/modest-tny-account-store.c: (get_server_accounts):
2199 Create the connection-specific transport accounts, so that they can
2200 be found later by their ID.
2202 * src/modest-tny-account.h:
2203 * src/modest-tny-account.c:
2204 Added modest_tny_account_new_from_server_account_name().
2205 modest_tny_account_new_from_server_account(): Do not create the
2206 send queues here, because they will be
2207 recreated anyway when the connection changes for the first time.
2209 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2211 * src/modest-local-folder-info.h:
2212 * src/modest-local-folder-info.c:
2213 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2214 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2215 tbox_folder): Take a modest account name instead of a server TnyAccount,
2216 so we can have per-modest-account rather than per-transport-account
2218 We must make sure that we change or recreate the exisitng send queues
2219 when the connection changes for connection-specific transport accounts.
2221 * src/modest-tny-account-store.c:
2222 (create_per_account_local_outbox_folders): Create outboxed per modest
2223 account, not per transport account.
2225 * src/modest-tny-account.h:
2226 * src/modest-tny-account.c:
2227 (modest_tny_account_get_special_folder): For outboxes, get the
2228 parent modest account name. The account is ignored for other folders.
2229 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2230 modest account name rather than a server TnyAccount.
2232 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2234 * src/modest-tny-account.c:
2235 (modest_tny_account_new_from_server_account):
2236 Call modest_runtime_get_send_queue() immediately after creating transport
2237 accounts, so that they start trying to send email from the outbox as soon
2238 as possible at startup. This is probably what we want.
2240 * src/modest-mail-operation.c: (update_account_thread):
2241 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2242 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2243 * src/modest-tny-send-queue.h:
2244 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2245 (modest_ui_actions_on_send):
2246 Added comments about how sending works, though it needs some more work.
2248 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2250 * src/modest-tny-account.c:
2251 (modest_tny_account_get_special_folder): Add TODO because this fails when
2252 the network is busy.
2253 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2254 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2255 Do not try to show this window when there is no active account. The UI
2256 specs does not tell us what to do in this case.
2258 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2262 * src/maemo/Makefile.am:
2263 * src/widgets/Makefile.am: Some dist fixes.
2265 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2267 * src/maemo/modest-connection-specific-smtp-window.c:
2268 (on_button_edit): Make the code clearer, to prevent a double free.
2270 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2272 * src/maemo/modest-account-settings-dialog.c:
2273 (modest_account_settings_dialog_set_account_name),
2274 Check the connection-specific smtp servers checkbox if there are any.
2276 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2277 (modest_connection_specific_smtp_edit_window_init):
2278 Start with a suitable port number.
2280 * src/modest-account-mgr-helpers.h:
2281 * src/modest-account-mgr-helpers.c: Added
2282 modest_account_mgr_get_has_connection_specific_smtp().
2284 (modest_account_mgr_set_connection_specific_smtp),
2285 (modest_account_mgr_remove_connection_specific_smtp),
2286 (modest_account_mgr_get_has_connection_specific_smtp),
2287 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2288 connection-specific smtp server accounts in the account, rather than
2289 the server account conf dir.
2291 This fixes bug projects.maemo.org bug NB#58263 .
2293 * src/modest-tny-account-store.c:
2294 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2295 if there are no server accounts yet, to prevent an infinite loop when there
2296 are no accounts. Document that one must be called before the other.
2298 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2300 * src/modest-account-mgr-helpers.c:
2301 (modest_account_mgr_get_default_account): Make sure that at least
2302 one account is always the default, if there are any enabled accounts.
2303 This is just a sanity check that shouldn't be necessary.
2305 * src/modest-account-mgr-priv.c:
2306 (_modest_account_mgr_account_from_key): Unescape the conf key to
2307 get the real account name. For instance, this is an issue if a space
2308 was in the account name, which can happen because the account name
2309 is generated from the display name.
2310 (_modest_account_mgr_get_account_keyname): Always escape the
2312 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2313 Unescape the conf keys to get the real account names.
2315 For instance, previously the is-default radio button in the accounts
2316 list was not checked for any accounts at first. This fixes that,
2317 and might fix several similar bugs.
2319 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2321 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2322 Removed some debug printfs.
2324 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2326 Modest on-disk outbox directories are now here, for instance:
2327 $HOME/.modest/outboxes/<account-id-1>/outbox
2328 $HOME/.modest/outboxes/<account-id-2>/outbox
2330 $HOME/.modest/local-folders/outbox
2331 so we can have a separate outbox for each account.
2332 But they are shown as one outbox in the GtkTreeView, by using a
2333 TnyMergeFolder in a ModestTnySimpleFolderStore.
2336 * src/modest-tny-simple-folder-store.c:
2337 * src/modest-tny-simple-folder-store.h:
2338 Added ModestTnySimpleFolderStore, used to contain folders from
2339 other folder stores, such as other accounts.
2341 * src/modest-tny-outbox-account.h:
2342 * src/modest-tny-outbox-account.c:
2343 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2344 used for the per-account local outbox folders.
2346 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2347 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2348 only use this (internally) now for the non-outbox local folders.
2350 * src/modest-init.h:
2351 * src/modest-init.c: Added modest_init_one_local_folder(), for
2352 setting up the directory structure for each local folder.
2354 * src/modest-local-folder-info.c:
2355 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2356 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2358 * src/modest-local-folder-info.h:
2359 * src/modest-tny-account-store.c: (on_account_removed),
2360 (on_account_changed), (create_per_account_local_outbox_folders),
2361 (get_server_accounts), (modest_tny_account_store_get_accounts),
2362 (modest_tny_account_store_get_tny_account_by_account),
2363 (modest_tny_folder_store_is_virtual_local_folders):
2365 * src/modest-tny-account.h:
2366 * src/modest-tny-account.c:
2367 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2368 to create an on-disk per-account local outbox folder for each
2370 (create_per_account_local_outbox_folders): Create a local outbox folder
2371 for each transport account.
2372 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2373 for all local folders.
2375 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2376 instead of using g_object_get/set() directly. It is clearer.
2378 (modest_tny_folder_store_get_message_count),
2379 (modest_tny_folder_store_get_local_size
2380 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2381 because we now use these with non-acount folder stores.
2383 (modest_tny_account_get_special_folder),
2384 (modest_tny_account_new_from_server_account),
2385 (modest_tny_account_new_from_account):
2386 (recurse_folders): Adjust to the new outbox system.
2388 * src/modest-tny-folder.h:
2389 * src/modest-tny-folder.c:
2390 (modest_tny_folder_is_local_folder),
2391 (modest_tny_folder_get_local_folder_type),
2392 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2394 * src/widgets/modest-main-window.h:
2395 * src/maemo/modest-main-window.c: (create_details_widget),
2396 (modest_main_window_set_contents_style): Show details for any folder store,
2399 (modest_tny_folder_get_rules):
2400 Remove the const. C does not support constness enough for this.
2402 * src/modest-ui-actions.c:
2403 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2404 make all outboxes appear as one, in the usual local-folders tree node.
2406 (set_active_account_from_tny_account),
2407 (modest_ui_actions_on_folder_selection_changed):
2408 * src/widgets/modest-folder-view.c: (text_cell_data),
2409 (icon_cell_data), (filter_row),
2410 (add_account_folders_to_merged_folder),
2411 (add_account_folders_to_simple_folder_store), (),
2412 (get_cmp_rows_type_pos), (cmp_rows),
2413 (modest_folder_view_set_account_id_of_visible_server_account):
2414 Adjust to the new outbox system, using generic folder stores and folders
2415 in the GtkTreeModel.
2417 2007-05-23 Christian Kellner <ckellner@openismus.com>
2419 * src/modest-mail-operation.c:
2420 (modest_mail_operation_update_account):
2421 Use info->max_size instead of unintialized local var [small
2422 build fix]. (Added TODO to review that change since I don't
2425 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2427 * libmodest-dbus-client/libmodest-dbus-client.c:
2428 (libmodest_dbus_client_compose_mail): function added
2429 * src/dbus_api/modest-dbus-api.h:
2430 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2431 (on_compose_mail): Implementation of the SendAsMail functionality
2433 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2435 * src/modest-account-mgr.c:
2436 (modest_account_mgr_add_server_account): Set the secure-connection
2437 conf key for transport accounts as well as store accounts. I don't know
2438 why the if was there. For instance, this makes sure that we use SSL
2439 for the gmail preset from the easysetup wizard.
2441 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2443 * src/gnome/modest-main-window.c:
2444 (on_account_store_connecting_finished), (connect_signals):
2445 * src/maemo/modest-main-window.c:
2446 (on_account_store_connecting_finished), (connect_signals),
2447 (modest_main_window_new):
2448 Handle TnyAccountStore::connecting-finished instead of
2449 TnyDevice::connection-changed, because we cannot actually perform
2450 operations on accounts until TnyAccountStore has itself responded to
2451 the TnyDevice::connection-changed signal. This prevents a GError from
2453 Do not try to update at startup, because we (at least on scratchbox)
2454 already do an update at startup when the device goes online.
2455 This prevents a GError from tinymail.
2456 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2457 Added TODO about stopping simultaneous operations.
2459 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2461 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2462 * src/modest-mail-operation-queue.c:
2463 (modest_mail_operation_queue_remove):
2464 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2465 about where they happened.
2467 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2469 * src/modest-ui-actions.c:
2470 (modest_ui_actions_on_password_requested): Make sure that the remember
2471 output parameter is always TRUE.
2473 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2475 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2476 Show a OK/Cancel dialog if the error is a question, though we still do not
2477 know anything more about what we are asking the user.
2478 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2479 Fix an uninitialized variable (helper). This is a logic error, however.
2481 2007-05-21 Christian Kellner <ckellner@openismus.com>
2483 * src/modest-search.h:
2484 Correct bit shifting in the ModestSearchFlags enum.
2486 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2488 * src/modest-tny-account.c:
2489 (modest_tny_account_new_from_server_account): Do not use the lsub and
2490 check-all hard-coded IMAP options when using POP.
2492 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2494 * src/modest-tny-account.c:
2495 (modest_tny_account_new_from_server_account):
2496 Use NULL for the secure-auth method for POP when Password auth has been
2497 specified by the user, as we already do for IMAP. "auth=Login" causes
2498 an error from camel or the server.
2500 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2502 * src/maemo/modest-account-settings-dialog.c:
2503 (create_page_account_details),
2504 (modest_account_settings_dialog_set_account_name):
2505 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2506 for the leave-on-server checkbox, rathr than just the checkbox, when
2507 the protocol is not POP.
2509 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2511 * src/widgets/modest-account-view.c:
2512 * src/widgets/modest-account-view.h:
2513 Added modest_account_view_select_account() which will be useful later
2514 to asynchronously re-select the edited account.
2516 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2518 * src/maemo/modest-account-settings-dialog.c:
2519 (modest_account_settings_dialog_set_account_name):
2520 Automatically choose the port numbers based on the secure authentication
2521 methods, if they have not been chosen before.
2522 This fixes projects.maemo.org bug NB#56273 .
2524 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2526 * src/maemo/modest-main-window-ui.h:
2527 * src/modest-ui-actions.c:
2528 * src/modest-ui-actions.h:
2529 Connect the Tools/SMTP Servers menu item to
2530 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2531 SMTP servers dialog, as in the UI specification and saves changes when it
2532 is closed. This fixed projects.maemo.org bug NB#56305 .
2534 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2536 * src/maemo/modest-connection-specific-smtp-window.c:
2537 (modest_connection_specific_smtp_window_init):
2538 Use gtk_window_set_default_size() to make this window big enough, so
2539 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2541 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2543 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2544 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2545 (modest_connection_specific_smtp_edit_window_init),
2546 Do not try to connect to a combobox signal before the combobox exists.
2547 This fixes the cras in projects.maemo.org bug NB#56288 .
2548 (modest_connection_specific_smtp_edit_window_get_settings):
2549 Remove the server_account_name parameter which was being checked for NULL
2550 though it was not used.
2552 * src/maemo/modest-connection-specific-smtp-window.c:
2553 (modest_connection_specific_smtp_window_fill_with_connections),
2554 (on_button_edit), (modest_connection_specific_smtp_window_init):
2555 Correct the number of treemodel columns to prevent a warning.
2556 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2557 libconic does not work.
2559 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2561 * src/modest-tny-account.c:
2562 (modest_tny_account_new_from_server_account):
2563 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2564 SMTP when "None" was chosen by the user. However, with my SMTP server that
2565 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2568 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2570 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2571 to explain the memory management issue with the ID in the ModestPair.
2573 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2574 (add_sending_page), (modest_account_assistant_finalize):
2575 * src/gnome/modest-gnome-global-settings-dialog.c:
2576 (create_updating_page), (create_composing_page):
2577 * src/gnome/modest-msg-edit-window.c: (get_transports),
2578 (init_window), (modest_msg_edit_window_finalize),
2579 (modest_msg_edit_window_get_msg_data):
2580 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2581 * src/gnome/modest-transport-widget.c:
2582 (modest_transport_widget_finalize), (smtp_configuration):
2583 * src/maemo/modest-maemo-global-settings-dialog.c:
2584 (create_updating_page), (create_composing_page):
2585 * src/maemo/modest-msg-edit-window.c: (get_transports),
2586 (init_window), (modest_msg_edit_window_finalize),
2587 (modest_msg_edit_window_get_msg_data),
2588 (modest_msg_edit_window_free_msg_data):
2589 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2590 (modest_store_widget_finalize):
2591 * src/maemo/modest-transport-widget.c:
2592 (modest_transport_widget_finalize), (smtp_configuration):
2593 * src/modest-main.c: (send_mail):
2594 * src/widgets/modest-combo-box.h:
2595 * src/widgets/modest-global-settings-dialog-priv.h:
2596 * src/widgets/modest-global-settings-dialog.c:
2597 (modest_global_settings_dialog_finalize):
2598 * src/widgets/modest-msg-edit-window.h:
2599 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2600 as long as the combo box, to prevent use of freed memory for the ID.
2602 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2604 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2605 get_accounts(), to make this clearer. Do not check for the enabled gconf
2606 key, because we do not use this for server accounts (at least, not yet).
2607 This allows us to send email again.
2609 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2611 * src/maemo/modest-platform.c:
2612 (on_modest_conf_update_interval_changed), (modest_platform_init):
2613 Only respond to this particular key change. All these strcmp()s cannot be
2616 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2618 * src/maemo/modest-maemo-global-settings-dialog.c:
2619 (current_connection): Prevent a crash in scratchbox when
2620 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2621 * src/maemo/modest-platform.c:
2622 (on_modest_conf_update_interval_changed), (modest_platform_init):
2623 Get the update interval from gconf and reset it when the gconf key changes.
2625 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2627 * src/modest-protocol-info.c:
2628 * src/modest-protocol-info.h: Adde enum-specific get functions,
2629 instead of using a ModestProtocolType enum parameter.
2631 * src/gnome/modest-account-assistant.c:
2632 * src/gnome/modest-store-widget.c:
2633 * src/gnome/modest-store-widget.h:
2634 * src/gnome/modest-transport-widget.c:
2635 * src/gnome/modest-transport-widget.h:
2636 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2637 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2638 * src/maemo/easysetup/modest-easysetup-wizard.c:
2639 * src/maemo/modest-account-settings-dialog.c:
2640 * src/maemo/modest-account-settings-dialog.h:
2641 * src/maemo/modest-store-widget.c:
2642 * src/maemo/modest-store-widget.h:
2643 * src/maemo/modest-transport-widget.c:
2644 * src/maemo/modest-transport-widget.h:
2645 * src/modest-account-mgr-helpers.c:
2646 * src/modest-account-mgr-helpers.h:
2647 * src/modest-account-mgr.c:
2648 * src/modest-account-mgr.h:
2649 * src/modest-tny-account.c:
2650 * src/modest-tny-folder.c:
2651 * src/widgets/modest-account-view.c:
2652 * src/widgets/modest-retrieve-combo-box.c:
2653 * src/widgets/modest-retrieve-combo-box.h:
2654 * src/widgets/modest-secureauth-combo-box.c:
2655 * src/widgets/modest-serversecurity-combo-box.c:
2656 * src/widgets/modest-serversecurity-combo-box.h:
2657 * tests/check_account-mgr.c:
2658 Use the specific functions, and use the re-renamed enum values for GNOME too.
2660 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2662 * src/modest-pair.h:
2663 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2664 so we can get the second based on the first.
2666 * src/maemo/modest-account-settings-dialog.h:
2667 * src/maemo/modest-account-settings-dialog.c:
2668 Added get_supported_secure_authentication_methods(), though it is mostly
2669 commented-out for now until the necessary API is committed to tinymail.
2670 (modest_account_settings_dialog_set_account_name),
2671 (save_configuration): Request the supported authentication methods from the
2672 server, so we can choose a working method.
2674 * src/modest-tny-account-store.h:
2675 * src/modest-tny-account-store.c:
2676 (modest_tny_account_store_get_session): Rename from
2677 tny_account_store_get_session().
2679 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2681 * src/modest-protocol-info.h: Split the ModestProtocol enum
2682 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2683 There was no need to have these unrelated values in one enum.
2685 * src/: many files: Adapted to changed enum. This makes the code a bit
2686 clearer, and the compiler could catch some errors.
2688 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2690 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2691 Show the detailed internal camel error message when an error happens
2692 during the configuration, so that our testers can give us more clues.
2693 For instance, in projects.maemo.org bug NB#56910 .
2695 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2697 * src/modest-tny-account.c:
2698 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2699 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2701 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2703 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2704 * src/maemo/modest-account-settings-dialog.c:
2705 (modest_account_settings_dialog_set_account_name),
2706 (save_configuration): For the incoming secure authentication checkbox,
2707 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2708 the UI specification. PLAIN does not seem to be supported for most IMAP
2709 servers anyway, and I am not sure what it would mean.
2710 However, we probably need to discover which of the secure-authentication
2711 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2712 * src/modest-account-mgr-helpers.c:
2713 (modest_account_mgr_get_server_account_data):
2715 * src/modest-tny-account.c:
2716 (modest_tny_account_new_from_server_account):
2717 Use tny_account_set_mech() to set secure-authentication methods,
2718 with some special-casing for IMAP, based on my observations of how
2721 * src/modest-account-mgr-helpers.h:
2722 * src/modest-account-mgr.c:
2723 * src/modest-defs.h: Comment that the URI is only used for local folders.
2725 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2727 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2728 parameter const, just to be neat.
2729 * src/modest-text-utils.c: (modest_text_utils_inline):
2730 End g_strconcat() with NULL, as its documentation says. This is almost
2731 certainly the cause of my crash at startup on the device. Interestingly,
2732 valgrind doesn't tell us about these errors.
2734 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2736 * scripts/build-packages: Added more precise comments about how to use
2737 this script, though I still get this error:
2738 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2739 error building tinymail
2741 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2743 * src/maemo/modest-main-window.c: (on_account_update):
2744 Very slight cleanup, hoping to make it simpler to discover what causes
2745 a crash here sometimes.
2747 * src/modest-tny-account.c:
2748 (modest_tny_account_new_from_server_account): Set the port. Added
2749 comments about the options and a TODO comment because I need to find out
2750 how to specify the secure authentication method.
2752 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2754 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2755 changed CFlags paths form modest to libmodest
2757 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2759 * src/modest-account-mgr-helpers.c:
2760 (modest_account_mgr_get_server_account_data),
2761 (modest_account_mgr_free_server_account_data):
2762 * src/modest-account-mgr-helpers.h:
2763 * src/modest-account-mgr.c:
2764 (modest_account_mgr_add_server_account):
2765 * src/modest-defs.h:
2766 * src/modest-tny-account.c:
2767 (modest_tny_account_new_from_server_account):
2768 Determine the options for tny_camel_account_add_option() here,
2769 based on the settings, rather than storing them directly in gconf.
2771 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2773 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2774 Show a more friendly error dialog now that we expect (from the tinymail
2775 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2777 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2779 * src/maemo/modest-main-window.c: (on_account_update): Check that
2780 account_name is not NULL, to prevent a crash at startup that I am
2781 seeing on the N800. I do wonder why it is NULL.
2783 * src/maemo/easysetup/modest-easysetup-wizard.c:
2784 (create_page_user_details):
2785 * src/maemo/modest-account-settings-dialog.c:
2786 (create_page_user_details), (create_page_outgoing):
2787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2788 (modest_connection_specific_smtp_edit_window_init):
2789 * src/modest-ui-actions.c:
2790 (modest_ui_actions_on_password_requested):
2791 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2792 might do something useful with the on-screen keyboard.
2794 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2796 * src/maemo/modest-main-window.c: (on_account_update):
2797 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2798 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2800 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2802 * src/modest-tny-account-store.c: (on_account_changed):
2803 Correct the signature of this signal handler.
2805 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2807 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2808 Show a HildonNote instead of a GtkDialog for Maemo.
2810 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2812 * src/widgets/modest-account-view.h:
2813 * src/widgets/modest-account-view.c: (on_account_changed),
2814 (on_account_removed). Added a boolean flag, set/unset by
2815 modest_account_view_block_conf_updates(),
2816 modest_account_view_unblock_conf_updates() to prevent unnecessary
2817 updates, but this is not very useful because the gconf notifications are
2818 so delays (maybe only on Maemo Bora).
2819 So auto-updating is turned off, and these functions do an explicit
2820 update when necessary.
2821 However, something else is still doing too much work when adding/removing
2822 accounts, probably in another part of the application.
2824 * src/maemo/modest-account-view-window.c:
2825 (on_delete_button_clicked), (on_edit_button_clicked),
2826 (on_new_button_clicked): Use the new functions.
2828 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2830 * src/modest-account-mgr-helpers.c:
2831 (modest_account_mgr_set_first_account_as_default):
2832 Sort the list of names alphabetically-by-title, so we choose the first one
2834 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2835 alphabetically by the title.
2837 This fixes projects.maemo.org bug NB#56418 .
2839 * src/modest-account-mgr-priv.c:
2840 (_modest_account_mgr_account_from_key):
2841 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2842 avoid a valgrind error, and possible random behaviour.
2844 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2846 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2847 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2848 tinymail documentation to say that this can be expected.
2849 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2850 pretty, and should not happen, but I would prefer to know when it does.
2852 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2854 * configure.ac: When using the older hildon version, probably on Bora,
2855 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2857 * src/widgets/modest-attachment-view.c:
2858 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2861 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2863 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2864 Implemented the prototype. Can be tested with
2865 tests/dbus_api/test_open_message:
2867 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2869 * src/modest-tny-account-store.c:
2870 (modest_tny_account_store_instance_init), (get_password):
2871 * src/modest-ui-actions.c:
2872 (modest_ui_actions_on_password_requested):
2873 Do not store the password in gconf, because this function is called
2874 for non-remembered passwords. Actually use the cached (in the hash map)
2875 password instead of releasing it.
2876 The password will now not be remembered if it is asked via the protected
2877 password dialog, as per the UI spec.
2879 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2881 * src/modest-defs.h:
2882 * src/modest-account-mgr-helpers.h:
2883 * src/modest-account-mgr-helpers.c:
2884 Added modest_server_account_get_username_has_succeeded(),
2885 modest_server_account_set_username_has_succeeded().
2886 (modest_server_account_set_username),
2887 Reset the has-succeeded flag if the username changes.
2889 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2890 * src/maemo/modest-connection-specific-smtp-window.c:
2891 (modest_connection_specific_smtp_window_save_server_accounts):
2892 Use modest_server_account_set_username() instead of using
2893 modest_conf_set_string() directly, so that the has-succeeded flag is always
2896 * src/modest-ui-actions.c:
2897 (modest_ui_actions_on_password_requested): Dim the username entry if
2898 the username has ever worked, as per the UI spec.
2900 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2902 * src/modest-tny-account-store.c: (get_password):
2903 * src/modest-ui-actions.c:
2904 (modest_ui_actions_on_password_requested):
2905 Allow the username to be changed too, though there is more work to
2906 be done on exactly how this behaves.
2908 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2910 * src/modest-account-mgr-helpers.h:
2911 * src/modest-account-mgr-helpers.c:
2912 Added modest_account_mgr_get_display_name(),
2913 modest_server_account_get_username(),
2914 modest_server_account_set_username(),
2915 modest_server_account_set_password(),
2916 modest_server_account_get_hostname() functions so we do not need to
2917 use the conf API directly.
2919 * src/maemo/modest-main-window.c: (connect_signals):
2920 Actually connect ot the ModestAccountStore::request-password signal,
2921 so that we show the dialog when the password is requested by Tinymail,
2922 for isntance if it is empty.
2924 * src/modest-marshal.list:
2925 * src/modest-tny-account-store.c:
2926 (modest_tny_account_store_class_init), (get_password),
2927 (modest_tny_account_store_alert):
2928 * src/modest-tny-account-store.h:
2929 * src/modest-ui-actions.h:
2930 * src/modest-ui-actions.c:
2931 (modest_ui_actions_on_password_requested):
2932 Change the signal parameters, so it is obvious that we are providing
2933 the non human-readable server name, and receiving both the username
2934 and password, though changing of the username is not yet implemented.
2935 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2936 for the GNOME version.
2938 This should fix the projects.maemo.org bug NB#56209, though it does not
2939 work on Bora, because the gconf_client_get() for the password fails
2940 immediately after we save it with gconf_client_set().
2942 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2945 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2946 caused an undefined symbol error:
2947 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2949 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2951 * src/modest-tny-account-store.c:
2952 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2953 using a GError instead of a string message, so we can translate it in
2956 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2958 * src/maemo/modest-address-book.c:
2959 (modest_address_book_check_names):
2960 * src/maemo/modest-msg-view-window.c:
2961 (modest_msg_view_window_clipboard_owner_change):
2962 * src/modest-init.c: (modest_init_init_ui):
2963 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2964 (update_folders_cb), (modest_mail_operation_update_account):
2965 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2966 (modest_ui_actions_on_msg_attachment_clicked),
2967 (modest_ui_actions_on_msg_recpt_activated):
2968 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2969 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2970 (modest_msg_view_search_next):
2971 * src/widgets/modest-recpt-editor.c:
2972 (modest_recpt_editor_on_button_release_event),
2973 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2974 g_message(). At this point we should only be seeing interesting errors on
2975 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2977 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2979 (modest_wizard_dialog_force_title_update):
2980 * src/maemo/easysetup/modest-wizard-dialog.h:
2981 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2982 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2983 can update the title when appropriate. Otherwise the title is wrong if the
2984 pages are added after adding the notebook to the dialog.
2985 This must be a problem in HildonWizardDialog too.
2986 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2988 * src/maemo/easysetup/modest-easysetup-wizard.c:
2989 (create_subsequent_customsetup_pages),
2990 (create_subsequent_easysetup_pages):
2991 Call modest_wizard_dialog_force_title_update() so that the title is
2992 correct even with GTK+ < 2.10.
2993 This fixes projects.maemo.org bug NB#56145 .
2995 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2997 * src/maemo/modest-platform.c:
2998 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2999 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3002 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3004 * src/widgets/modest-window.h:
3005 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3006 and modest_window_save_state(), which invokes it.
3008 * src/widgets/modest-window-mgr.h:
3009 * src/widgets/modest-window-mgr.c:
3010 Added modest_window_mgr_save_state_for_all_windows(), which calls
3011 the save_state vfunc on all registered windows, if implemented.
3013 * src/gnome/modest-msg-edit-window.c:
3014 * src/gnome/modest-msg-view-window.c:
3015 * src/maemo/modest-msg-edit-window.c:
3016 * src/maemo/modest-msg-view-window.c:
3017 * src/maemo/modest-main-window.c:
3018 Specify the existing save_settings functions as implementations of
3019 ModestWindow::save_state_func().
3021 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3022 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3023 enabling hibernation, for instance.
3025 We may need to do the same thing for restoring settings.
3028 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3030 * src/widgets/modest-window-mgr.c:
3031 * src/widgets/modest-window-mgr.h:
3032 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3033 modest_window_mgr_get_hibernation_is_prevented().
3035 * src/maemo/modest-main-window.c:
3036 (on_hildon_program_is_topmost_notify): Prevent hibernation
3037 (possible when the application goes to the background in the WM),
3038 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3040 * src/maemo/easysetup/modest-easysetup-wizard.c:
3041 (modest_easysetup_wizard_dialog_init):
3042 * src/maemo/modest-account-settings-dialog.c:
3043 (modest_account_settings_dialog_init):
3044 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3045 (modest_connection_specific_smtp_edit_window_init):
3046 * src/maemo/modest-connection-specific-smtp-window.c:
3047 (modest_connection_specific_smtp_window_init):
3048 * src/maemo/modest-signature-editor-dialog.c:
3049 (modest_signature_editor_dialog_init):
3050 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3051 prevent hibernation while any of these account settings dialogs are open.
3053 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3055 * src/maemo/Makefile.am:
3056 * src/maemo/modest-osso-state-saving.c:
3057 * src/maemo/modest-osso-state-saving.h: Added
3058 modest_osso_load_state() and modest_osso_save_state() though they do
3059 nothing now. They should iterate through all the open windows and load/save
3061 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3062 save state when closing.
3064 * src/maemo/modest-main-window.c:
3065 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3066 Add a notification handler for the HildonProgram::is-topmost property,
3067 so we can allow hibernation when the application goes into the background.
3068 But we still need to detect when the accounts setup windows are open so
3069 we can stop hibernation when they are open.
3070 To do this, I also added the main window the HildonProgram. This might have
3071 other side-effects/benefits, and should maybe be done for other windows.
3073 * src/maemo/modest-osso-autosave-callbacks.h:
3074 * src/maemo/modest-osso-autosave-callbacks.c:
3075 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3076 though it does not do anything yet, and we might never need this to do
3077 anything. For instance, we already save drafts.
3079 * src/maemo/modest-platform.c: (modest_platform_init):
3080 Specify the libosso auto-save callback.
3082 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3084 * src/maemo/modest-platform.c:
3085 (modest_platform_set_update_interval):
3086 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3087 aparently stays valid between application instances, so we can use this
3088 to remove and reset it later. According to a maemo-developers email from
3091 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3093 * configure.ac: Depend on libalarm for Maemo.
3095 * src/dbus_api/modest-dbus-api.h:
3096 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3097 (on_send_receive), (modest_dbus_req_handler):
3098 Handle a SEND_RECEIVE D-Bus method.
3100 * libmodest-dbus-client/libmodest-dbus-client.c:
3101 (libmodest_dbus_client_send_and_receive):
3102 * libmodest-dbus-client/libmodest-dbus-client.h:
3103 Add C convenience functions for calling the new D-Bus method.
3105 * src/modest-platform.h:
3106 * src/gnome/modest-platform.c:
3107 * src/maemo/modest-platform.c:
3108 Added modest_platform_set_update_interval(), which uses the
3109 alarmd API on Maemo.
3110 (modest_platform_init),
3111 Call modest_platform_set_update_interval(), using a hard-coded
3112 interval for now (until the global settings dialog is implemented),
3113 though I am not sure that this makes sense yet.
3115 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3117 * src/dbus_api/modest-dbus-callbacks.c:
3118 (modest_osso_cb_hw_state_handler):
3119 * src/dbus_api/modest-dbus-callbacks.h:
3120 * src/maemo/modest-platform.c: (modest_platform_init):
3121 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3122 in case this has some effect on the ability for Maemo to ping the
3125 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3127 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3128 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3129 warning. It is probably a logic error, but I need to fix the build.
3131 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3133 * src/modest-account-mgr.h:
3134 * src/modest-account-mgr.c:
3135 (modest_account_mgr_account_names): Add a gboolean enabled_only
3136 parameter, so we can get lists of onlt the enabled accounts.
3138 (modest_account_mgr_add_account),,
3139 (modest_account_mgr_account_with_display_name_exists):
3140 * src/maemo/modest-msg-edit-window.c: (get_transports):
3141 * src/modest-account-mgr-helpers.c:
3142 (modest_account_mgr_set_first_account_as_default):
3143 * src/modest-init.c: (init_default_account_maybe):
3144 * src/modest-tny-account-store.c: (get_accounts):
3145 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3146 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3147 * tests/check_account-mgr.c: (START_TEST):
3148 Provide the extra parameter, as appropriate.
3150 * src/widgets/modest-account-view.c: (update_account_view):
3151 Do not show disabled accounts (meaning that there is no way to
3152 enable/disable accounts in the UI (the feature is not in our UI
3153 specification), so we can use this internally only to mark unfinished
3154 or temporary account data.
3156 * src/maemo/easysetup/modest-easysetup-wizard.c:
3157 (create_account): Add boolean enable parameter, so we can specify FALSE
3158 to create the temporary account.
3159 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3160 (on_before_next): When finishing, when there is a temporary account, just
3162 Also, use a timeout to delay the showing of the dialog until gconf is likely
3163 to return correct information, due to a maemo gconf bug that is fixed in
3164 osso 1.1, but not yet in Bora.
3165 However, the dialog stays on screen after it is destroyed.
3167 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3168 for invalid data when cancelling. Use a hildon note instead of a dialog
3169 to complain about invalid data. Do not show the account-saved note if the
3170 account is disabled (a temporary account that will not really be saved for use
3173 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3175 * src/modest-account-mgr-helpers.h:
3176 * src/modest-account-mgr-helpers.c:
3177 Added modest_account_mgr_unset_default_account(),
3178 Added modest_account_mgr_set_first_account_as_default().
3180 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3181 If it was the default account, unset the default account name.
3183 * src/maemo/modest-account-view-window.c:
3184 (on_delete_button_clicked): If it was the default account,
3185 set the first remaining account as the default instead.
3187 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3188 a NULL account or a NULL default account, to prevent a crash. This should
3189 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3192 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3194 * src/widgets/modest-recpt-editor.c:
3195 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3196 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3197 TODO comment for this. This fixes the build.
3199 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3200 be the best place for it. This will in future update all auto-update accounts,
3201 rather than just the current/default account, when that gconf key exists.
3202 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3203 if there are no accounts, before calling do_send_receive().
3204 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3206 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3207 * src/maemo/modest-main-window-ui.h:
3208 * src/maemo/modest-main-window.c: (on_connection_changed),
3209 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3210 directly, becaue the signal handler does more.
3212 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3214 * src/modest-account-mgr-helpers.c:
3215 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3216 for the case that the account does not exist.
3218 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3219 (equivalent to the modest account name) rather than the tinymail account name
3220 (equivalent to the modest account title - human readable) to get the account data.
3221 Check for null account data to prevent the crash, and add a TODO comment saying that
3222 this needs fixing because it is using the server account name instead of the account name.
3224 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3226 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3227 * src/maemo/modest-account-settings-dialog.c: (show_error),
3229 Use hildon_note_new_information() for informative and error messages,
3230 which seems to be expected for Maemo applications (no documentation that I know of
3231 says this). I am surprised that there is no distinction between info and error
3234 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3236 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3237 it is easy to find where this is used.
3239 * src/maemo/easysetup/modest-easysetup-wizard.c:
3240 (create_page_welcome), (create_page_account_details),
3241 (create_page_user_details), (create_page_complete_easysetup),
3242 (create_page_custom_incoming), (create_page_custom_outgoing),
3243 (create_page_complete_custom):
3244 * src/maemo/modest-account-settings-dialog.c:
3245 (create_page_account_details), (create_page_user_details),
3246 (create_page_incoming), (create_page_outgoing):
3247 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3248 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3249 (modest_connection_specific_smtp_edit_window_init):
3250 * src/maemo/modest-connection-specific-smtp-window.c:
3251 (modest_connection_specific_smtp_window_init):
3252 * src/maemo/modest-signature-editor-dialog.c:
3253 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3254 and scrolling policy as per the Email Application Layout Guide, if I have
3257 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3259 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3260 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3261 which were empty, because these vfuncs have been removed from TnyAccountStore.
3262 This fixes the build.
3264 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3266 * src/maemo/modest-main-window.c:
3267 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3268 showing/hiding it. Added TODO because it probably should not be NULL.
3269 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3270 because unnecessary g_warnings() make degugging difficult.
3272 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3274 * src/maemo/modest-msg-edit-window.c:
3275 (modest_msg_edit_window_select_color),
3276 (modest_msg_edit_window_select_background_color): 2 const corrections and
3277 moving 2 #endifs before closing brackets, to fix the build.
3279 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3281 * src/maemo/easysetup/modest-easysetup-wizard.h:
3282 * src/maemo/easysetup/modest-easysetup-wizard.c:
3283 (modest_easysetup_wizard_dialog_finalize),
3284 (on_button_edit_advanced_settings), (create_page_complete_custom),
3285 (on_response), (create_account):
3286 Implement the Advanced Settings edit button, by saving the account information,
3287 for the Advanded Settings dialog to use directly from gconf, and removing it
3288 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3289 Bug #5533 in the projects.maemo.org bugzilla.
3291 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3293 * src/maemo/modest-msg-view-window.c:
3294 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3295 when opening a message window.
3297 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3299 * src/maemo/easysetup/modest-easysetup-wizard.c:
3300 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3303 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3304 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3305 gconf settings. I probably added more checks than necessary, but that is safer.
3307 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3308 variable to fix the build, but this seems to be used when it is still NULL.
3310 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3312 * src/modest-platform.h:
3313 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3314 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3315 * src/modest-main.c: Implement this function so we can avoid using
3316 maemo-specific API from cross-platform code.
3318 * src/modest-tny-account-store.c:
3319 (get_smtp_specific_transport_account_for_open_connection):
3320 * src/modest-ui-actions.c: (check_for_connection),
3321 (modest_ui_actions_on_item_not_found):
3322 Use modest_platform_connect_and_wait() and put #idefs around other
3323 maemo-specific code, because only maemo currently has a way to
3324 identify connection names.
3326 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3328 * src/modest-tny-account-store.h:
3329 * src/modest-tny-account-store.c:
3330 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3331 the connection-specific SMTP server settings in the configuration.
3333 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3335 * src/maemo/modest-main-window.c: (on_connection_changed),
3337 * src/modest-main.c: (main), (start_ui), (send_mail):
3338 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3339 that is what is intended.
3341 * src/modest-ui-actions.c: (action_send), (action_receive),
3342 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3343 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3344 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3345 SMTP server is used when it is specified.
3347 (modest_ui_actions_on_send_receive):
3348 Check that a connection is open before proceeding.
3349 Receive and then send, instead of vice-versa, as per the specification.
3351 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3353 * src/modest-mail-operation.c:
3354 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3355 though I guess it should be something other than NULL.
3357 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3359 * src/maemo/easysetup/modest-easysetup-wizard.c:
3360 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3361 combo twice, to avoid an g_warning and to make it visible again.
3362 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3363 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3364 (already intended) dereference when detaching, because we then recreate the menu.
3365 But I am not sure why the warning was happening, and it is possible that this is a memory
3368 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3370 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3371 and uri_parse_mailto() utility functions.
3372 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3374 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3376 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3378 * src/dbus_api/modest-dbus-api.h:
3379 * src/dbus_api/modest-dbus-callbacks.c:
3380 Use an idle callback to execute the modest code in the application's own thread.
3381 Remove the helloworld example method.
3382 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3383 parsed, and the open-message method is not implemented because this is not yet implemented in
3385 * libmodest-dbus-client/libmodest-dbus-client.c:
3386 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3387 (libmodest_dbus_client_open_message):
3388 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3390 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3391 body without crashing.
3393 * tests/dbus_api/Makefile.am:
3394 * tests/dbus_api/test_mail_to.c:
3395 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3397 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3399 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3400 Added file to fix the build. Sorry.
3402 * src/dbus_api/Makefile.am:
3403 * src/dbus_api/modest-dbus-api.h:
3404 * src/dbus_api/modest-dbus-callbacks.h:
3405 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3406 (modest_dbus_req_handler):
3407 Put constants in a separate header so it can be reused by the
3408 client library, without duplication
3410 * libmodest-dbus-client/Makefile.am:
3411 * libmodest-dbus-client/libmodest-dbus-client.c:
3412 (libmodest_dbus_client_call_helloworld),
3413 (libmodfest_dbus_client_send_mail),
3414 (libmodfest_dbus_client_mailto),
3415 (libmodfest_dbus_client_open_message):
3416 * libmodest-dbus-client/libmodest-dbus-client.h:
3417 (Partly) Implement a send_mail D-Bus method.
3419 * tests/dbus_api/Makefile.am:
3420 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3421 the send_email D-Bus method.
3423 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3427 * libmodest-dbus-client/Makefile.am:
3428 * libmodest-dbus-client/libmodest-dbus-client.c:
3429 * libmodest-dbus-client/libmodest-dbus-client.h:
3430 * tests/dbus_api/Makefile.am:
3431 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3432 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3434 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3436 * src/maemo/easysetup/modest-easysetup-wizard.c:
3437 (create_page_account_details):
3438 * src/maemo/modest-account-settings-dialog.c:
3439 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3440 widgets, because this might not be the default in future versions of the Maemo GTK+.
3441 However, I can not not get capitalization to work even in a simple test case.
3443 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3445 * src/maemo/easysetup/modest-easysetup-wizard.c:
3446 (create_page_custom_incoming), (create_page_custom_outgoing):
3447 * src/maemo/modest-account-settings-dialog.c:
3448 (create_page_account_details), (create_page_incoming),
3449 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3450 instead of using gtk_check_button_with_label(), so they are aligned like the other
3451 widgets, as per the UI spec.
3453 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3455 * src/maemo/easysetup/modest-easysetup-wizard.c:
3456 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3457 * src/widgets/modest-validating-entry.c:
3458 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3459 Modest prefix instead of an EasySetup prefix.
3461 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3463 * src/widgets/modest-validating-entry.h:
3464 * src/widgets/modest-validating-entry.c: (on_insert_text),
3465 Added easysetup_validating_entry_set_max_func(), used to set a callback
3466 to call when the max number of characters is reached. GtkEntry has a max-length
3467 already but is silent about it.
3469 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3470 (create_page_account_details), (create_page_user_details),
3472 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3473 (create_page_account_details), (create_page_user_details),
3474 (create_page_outgoing):
3475 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3476 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3477 the UI spec, when the user tries to enter more than the max number of characters.
3479 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3481 * src/maemo/easysetup/modest-easysetup-wizard.c:
3482 (create_page_user_details), (create_page_custom_incoming),
3483 (create_page_custom_outgoing):
3484 * src/maemo/modest-account-settings-dialog.c:
3485 (create_page_user_details), (create_page_incoming),
3486 (create_page_outgoing):
3487 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3488 (modest_connection_specific_smtp_edit_window_init):
3489 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3490 not appropriate. Bad Maemo-specific defaults!.
3492 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3494 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3495 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3496 (modest_signature_editor_dialog_set_settings):
3497 Disable the label and textview when the checkbox is disabled, and use the
3498 specified (UI spec) default signature text.
3500 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3502 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3503 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3505 * src/modest-defs.h:
3506 * src/modest-account-mgr-helpers.h:
3507 * src/modest-account-mgr-helpers.c:
3508 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3510 * src/maemo/Makefile.am:
3511 * src/maemo/modest-signature-editor-dialog.c:
3512 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3515 * src/maemo/modest-account-settings-dialog.h:
3516 * src/maemo/modest-account-settings-dialog.c:
3517 (modest_account_settings_dialog_finalize), (on_button_signature),
3518 (save_configuration): Use the new dialog when the Edit button is pressed, and
3519 save the changes if necessary, as per the UI spec.
3521 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3523 * src/maemo/Makefile.am:
3524 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3525 based on maemo-develoers email from Dirk.
3527 * src/maemo/easysetup/modest-easysetup-wizard.c:
3528 (create_page_welcome), (create_page_account_details),
3529 (create_page_user_details), (create_page_complete_easysetup),
3530 (create_page_custom_incoming), (create_page_custom_outgoing),
3531 (create_page_complete_custom),
3532 (modest_easysetup_wizard_dialog_init):
3533 * src/maemo/modest-account-settings-dialog.c:
3534 (create_page_account_details), (create_page_user_details),
3535 (create_page_incoming), (create_page_outgoing),
3536 (modest_account_settings_dialog_init):
3537 * src/maemo/modest-connection-specific-smtp-window.c:
3538 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3540 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3542 * src/maemo/easysetup/modest-easysetup-wizard.c:
3543 (create_page_account_details), (create_page_custom_outgoing),
3544 (create_page_complete_custom):
3545 * src/maemo/modest-account-settings-dialog.c:
3546 (create_page_user_details), (create_page_incoming),
3547 (create_page_outgoing):
3548 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3549 (modest_connection_specific_smtp_edit_window_init):
3550 Use the correct (UI spec) port min/max, and use horizontal separators,
3553 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3555 * src/maemo/easysetup/modest-easysetup-wizard.c:
3556 (set_default_custom_servernames):
3557 * src/maemo/modest-account-settings-dialog.c:
3558 (create_page_incoming), (on_combo_outgoing_security_changed),
3559 (on_combo_incoming_security_changed), (create_page_outgoing),
3560 (modest_account_settings_dialog_set_account_name),
3561 (save_configuration):
3562 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3563 (on_combo_security_changed),
3564 (modest_connection_specific_smtp_edit_window_init),
3565 (modest_connection_specific_smtp_edit_window_set_connection),
3566 (modest_connection_specific_smtp_edit_window_get_settings):
3567 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3570 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3573 * src/maemo/easysetup/modest-easysetup-wizard.c:
3574 (create_page_custom_outgoing), (create_page_complete_custom):
3575 * src/maemo/modest-account-settings-dialog.c:
3576 (create_page_user_details), (create_page_outgoing):
3577 * src/maemo/modest-account-view-window.c: (button_box_new):
3578 Use changed logical IDs as per the most recent UI spec:
3579 mcen_bd_emailsetup_edit -> mcen_bd_edit
3580 mcen_bd_emailsetup_delete -> mcen_bd_delete
3581 mcen_bd_emailsetup_close -> mcen_bd_close
3583 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3587 * src/dbus_api/Makefile.am:
3588 * src/dbus_api/modest-dbus-callbacks.c:
3589 * src/dbus_api/modest-dbus-callbacks.h:
3590 * src/maemo/modest-platform.c: (modest_platform_init):
3591 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3593 * tests/Makefile.am:
3594 * tests/dbus_api/Makefile.am:
3595 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3597 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3599 * src/maemo/modest-account-settings-dialog.c:
3600 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3601 Removed unnecessary includes.
3603 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3605 * src/maemo/easysetup/modest-easysetup-wizard.c:
3606 * src/maemo/modest-account-settings-dialog.c:
3607 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3608 * src/widgets/Makefile.am:
3609 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3610 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3611 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3612 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3613 * src/widgets/modest-secureauth-combo-box.c:
3614 * src/widgets/modest-secureauth-combo-box.h:
3615 * src/widgets/modest-serversecurity-combo-box.c:
3616 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3617 made the GObject names more consistent with the rest of the Modest code.
3619 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3621 * src/maemo/easysetup/Makefile.am:
3622 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3623 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3624 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3625 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3626 * src/maemo/easysetup/modest-easysetup-wizard.c:
3627 * src/maemo/easysetup/modest-validating-entry.c:
3628 * src/maemo/easysetup/modest-validating-entry.h:
3629 * src/maemo/modest-account-settings-dialog.c:
3630 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3631 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3632 widgets/ because they are used outside of easysetup too. After checking in,
3633 svn will allow me to rename them too.
3635 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3637 * src/gnome/modest-msg-edit-window.c:
3638 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3639 linker error, to fix the build on the GNOME platform.
3640 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3641 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3642 ifdefed out to avoid a warning.
3644 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3646 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3647 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3648 some alternative for GTK+ 2.6.
3650 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3652 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3654 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3655 specified for EmailAccountsDialog in UI spec.
3657 * src/maemo/easysetup/modest-easysetup-wizard.c:
3658 * src/maemo/easysetup/modest-easysetup-wizard.h:
3659 * src/maemo/modest-account-settings-dialog.c:
3660 * src/maemo/modest-account-settings-dialog.h:
3661 Reuse a member window widget for the connection-specific SMTP server accounts,
3662 so we can tell it to create/save the accounts only if we actually save changes.
3664 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3665 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3666 (modest_connection_specific_smtp_edit_window_get_settings):
3667 Return a struct instance for temporarily remembering the entered data.
3669 * src/maemo/modest-connection-specific-smtp-window.h:
3670 * src/maemo/modest-connection-specific-smtp-window.c:
3671 (modest_connection_specific_smtp_window_finalize),
3672 (modest_connection_specific_smtp_window_fill_with_connections),
3674 (modest_connection_specific_smtp_window_save_server_accounts),
3675 (update_model_server_names): Do not actually save data until asked,
3676 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3678 (on_selection_changed),
3679 (modest_connection_specific_smtp_window_init): Disable the edit
3680 button when nothing is selected.
3682 * src/modest-account-mgr-helpers.c:
3683 * src/modest-account-mgr-helpers.h:
3684 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3687 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3689 * src/modest-account-mgr-helpers.h:
3690 * src/modest-account-mgr-helpers.c:
3691 (modest_account_mgr_get_unused_account_name),
3692 (modest_account_mgr_get_unused_account_display_name): Added these
3693 utility functions, to avoid code duplication.
3695 * src/maemo/easysetup/modest-easysetup-wizard.c:
3696 (create_page_account_details), (create_account):
3697 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3698 (on_combo_security_changed),
3699 (modest_connection_specific_smtp_edit_window_init),
3700 (modest_connection_specific_smtp_edit_window_save_settings):
3701 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3702 * src/maemo/modest-connection-specific-smtp-window.c:
3703 (modest_connection_specific_smtp_window_finalize),
3704 (modest_connection_specific_smtp_window_fill_with_connections),
3705 (on_button_edit), (modest_connection_specific_smtp_window_init):
3706 * src/maemo/modest-connection-specific-smtp-window.h:
3707 Implementing saving of connection-specific server accounts.
3709 But I need to refactor this so we can save the data for each
3710 possible connection-specific account and only actually create the server accounts
3711 when the easysetup finished, or the OK button is pressed on the account settings
3714 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3716 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3717 (on_combo_security_changed):
3718 (modest_connection_specific_smtp_edit_window_init):
3719 Auto-fill the port number as in the account settings.
3721 (modest_connection_specific_smtp_edit_window_set_connection):
3722 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3723 * src/maemo/modest-connection-specific-smtp-window.c:
3724 (fill_with_connections), (on_button_edit),
3725 (modest_connection_specific_smtp_window_init):
3726 Turn the edit window into a dialog to simplify the code, and
3727 set a WM hint as in a GtkDialog, because only a popup can be on top of
3728 another window in Maemo, and popups usually have no WM decoration.
3730 * src/modest-defs.h:
3731 * src/modest-account-mgr-helpers.c:
3732 (modest_account_mgr_set_connection_specific_smtp),
3733 (modest_account_mgr_remove_connection_specific_smtp),
3734 (modest_account_mgr_get_connection_specific_smtp):
3735 * src/modest-account-mgr-helpers.h: Some functions to write the
3736 connection-specific SMTP server information. Not yet used.
3739 * src/widgets/modest-folder-view.c: (text_cell_data):
3740 Fix a warning about an uninitialized variable.
3741 (on_configuration_key_changed): Put an #ifdef around the use
3742 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3744 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3746 * src/maemo/modest-account-settings-dialog.h:
3747 * src/maemo/modest-account-settings-dialog.c:
3748 Added connect_for_modified() utility function to mark the new modified boolean.
3750 (create_page_account_details), (create_page_user_details),
3751 (create_page_incoming), (create_page_outgoing), (on_response),
3752 (modest_account_settings_dialog_init),
3753 (modest_account_settings_dialog_set_account_name):
3754 Only warn about unsaved changes when there are actually unsaved changes.
3756 * src/modest-account-mgr-helpers.c:
3757 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3758 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3759 to get the data from there in future.
3761 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3763 * src/modest-defs.h:
3765 * src/modest-account-mgr-helpers.h:
3766 * src/modest-account-mgr-helpers.c:
3767 Store the security account setting in a single conf key instead of using
3768 the options list, so that the list is left for just the to-be-removed camel hack,
3769 and because gconf_client_set_list() is failing for some reason.
3771 * src/modest-account-mgr.c:
3772 (modest_account_mgr_add_server_account):
3773 * src/maemo/modest-account-settings-dialog.c:
3774 (modest_account_settings_dialog_set_account_name),
3775 (save_configuration): Use the renamed functions.
3778 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3780 * src/widgets/Makefile.am:
3781 * src/widgets/modest-limit-retrieve-combo-box.c:
3782 * src/widgets/modest-limit-retrieve-combo-box.h:
3783 * src/widgets/modest-retrieve-combo-box.c:
3784 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3785 the account settings dialog.
3787 * src/modest-defs.h:
3788 * src/modest-account-mgr-helpers.h:
3789 * src/modest-account-mgr-helpers.c:
3790 (modest_server_account_get_option_secure_auth),
3791 (modest_server_account_set_option_secure_auth):
3792 * src/modest-account-mgr.c:
3793 (modest_account_mgr_add_server_account):
3794 Use the existing AUTH_MECH conf key for the secure-auth setting,
3795 instead of putting it in the list options, because this was actually used already.
3797 * src/maemo/modest-account-settings-dialog.c:
3798 (create_page_account_details),
3799 (modest_account_settings_dialog_set_account_name),
3800 (save_configuration):
3801 * src/maemo/modest-account-settings-dialog.h:
3802 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3803 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3805 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3807 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3808 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3809 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3811 * src/modest-defs.h:
3812 * src/maemo/modest-account-settings-dialog.c:
3813 (create_page_incoming), (on_combo_outgoing_security_changed),
3814 (on_combo_incoming_security_changed), (create_page_outgoing),
3815 (modest_account_settings_dialog_set_account_name),
3816 (save_configuration): Load/Save the port number, and change it when the
3817 security combo changes, to suitable defaults.
3819 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3821 * src/modest-account-mgr.c:
3822 (modest_account_mgr_add_server_account): Set the security and secure-auth
3823 options, and add a comment saying that the other camel-specific options should be
3826 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3828 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3830 * src/modest-tny-account-store.c: (account_list_free),
3831 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3832 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3835 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3837 * src/modest-protocol-info.c:
3838 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3839 is required by our UI spec. Maybe something in our implementation will use this eventually.
3840 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3841 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3842 instead of the previous 0 placeholder.
3844 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3845 secure-auth settings.
3846 * src/modest-account-mgr-helpers.h:
3847 * src/modest-account-mgr-helpers.c:
3848 (modest_server_account_data_get_option_secure_auth),
3849 (modest_server_account_set_option_secure_auth),
3850 (modest_server_account_data_get_option_security),
3851 (modest_server_account_set_option_security): Added this API for getting and setting the security
3852 and secure-auth settings.
3854 * src/maemo/modest-account-settings-dialog.h:
3855 * src/maemo/modest-account-settings-dialog.c:
3856 (modest_account_settings_dialog_finalize), (check_data),
3857 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3858 about changing titles.
3859 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3860 (save_configuration): Save the security and secure-auth settings.
3862 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3863 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3865 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3867 * src/modest-defs.h:
3868 * src/modest-account-mgr.c:
3869 (modest_account_mgr_add_server_account):
3870 Added and used defines for the options key and value pair strings,
3871 that are used so far, though they do not seem to correspond to anything in our
3872 UI specs or ModestProtocol enum.
3874 * src/modest-account-mgr-helpers.h:
3875 * src/modest-account-mgr-helpers.c:
3876 (compare_option_strings_for_name),
3877 (modest_server_account_data_get_option_value),
3878 (modest_server_account_data_get_option_bool),
3879 (modest_account_mgr_get_server_account_option):
3880 Added helper functions for parsing the options GSList.
3882 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3884 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3885 display name is based on the supplied account name.
3886 * src/modest-account-mgr.c:
3887 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3888 with an inefficient, but good-enough, implementation.
3890 * src/maemo/easysetup/modest-easysetup-wizard.c:
3891 (create_page_account_details), (on_before_next), (create_account):
3892 Check for existing display names rather than (non-user-visible) account names, and just
3893 create and set a unique account name at the end.
3895 * src/maemo/modest-account-settings-dialog.c:
3896 (modest_account_settings_dialog_init),
3897 (modest_account_settings_dialog_set_account_name),
3898 (create_page_incoming): Show the display name, instead of the account name.
3899 (on_response): Do some (not all) extra checks, as in the UI spec.
3900 (save_configuration): Save the display name if it was changed.
3902 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3904 * po/en_GB.po: Added needed logical ID and translation.
3905 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3906 (init_view): Made the is-default column clicking work.
3908 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3911 * src/maemo/easysetup/Makefile.am:
3912 * src/maemo/easysetup/modest-easysetup-wizard.c:
3913 (modest_easysetup_wizard_dialog_init):
3914 * src/maemo/easysetup/provider-data-test.keyfile:
3915 * src/maemo/easysetup/provider-data.keyfile:
3916 Moved the provider data file to the new modest-providers-data package and used it from there.
3918 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3920 * src/modest-local-folder-info.c:
3921 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3922 N_() was already used on the static strings, but this just marks it for translation without
3923 using the translation.
3925 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3927 * src/maemo/modest-account-settings-dialog.c:
3928 (create_page_incoming),
3929 (modest_account_settings_dialog_set_account_name):
3930 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3931 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3932 I will do this if nobody else gets there first.
3934 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3936 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3937 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3938 save the security stuff.
3940 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3942 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3943 Set the email address and user fullname, which I now see must be
3946 * src/maemo/modest-account-settings-dialog.h:
3947 * src/maemo/modest-account-settings-dialog.c:
3949 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3950 leave-on-server and authentication.
3951 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3954 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3957 * src/maemo/modest-account-settings-dialog.c:
3958 * src/maemo/modest-account-settings-dialog.h:
3959 Most (but not all) of the widgets are now present as specified by the UI spec.
3960 No changes are yet saved, and some details are not properly shown yet.
3962 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3964 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3966 * src/maemo/Makefile.am:
3967 * src/maemo/modest-account-settings-dialog.c:
3968 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3969 an existing account. Doesn't do much yet.
3971 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3972 Open the accounts settings dialog when Edit is clicked.
3974 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3976 * src/maemo/easysetup/Makefile.am:
3977 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3979 * src/maemo/easysetup/modest-easysetup-wizard.c:
3980 (modest_easysetup_wizard_dialog_init):
3981 Try to get the source directory from the build system,
3982 instead of hard-coding "./" into the source code, when opening our local
3983 copies of the configuration files.
3984 But this still fails when opening the wizard from the Accounts window,
3985 maybe because the working directory seems to change at runtime.
3986 So the wizard will fail the second time unless you copy the files into their
3987 proper locations - see the stdout warnings for the paths.
3989 (create_page_account_details),(on_before_next):
3990 Check for existing non-server accounts instead of server accounts,
3991 so the default account name is useful again, and to prevent trying to
3994 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3995 Show the wizard when New is clicked.
3997 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3998 (init_view): Show the column headers, and show the columns that are
3999 specified in the UI specs. However, something in Maemo's GTK+ prevents
4000 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4001 change the default account. This is despite unsetting the special properties.
4003 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4005 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4006 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4007 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4008 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4009 to make that clearer.
4010 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4012 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4014 * src/maemo/modest-account-view-window.c:
4015 (modest_account_view_window_init),
4016 (modest_account_view_window_new):
4017 Use the same buttons as specified in the
4018 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4019 the existing widgets, which never had a chance of working.
4020 Put the ModestAccountView treeview in a scrolled window.
4021 Do not repeat the initialization in both _init() and _new().
4023 * src/widgets/modest-account-view.c: (update_account_view):
4024 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4025 this widget and window shows no accounts.
4027 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4029 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4031 * src/maemo/easysetup/modest-easysetup-wizard.c:
4032 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4033 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4034 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4037 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4038 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4039 accounts exist yet, as in the UI spec.
4041 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4043 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4045 * src/maemo/Makefile.am:
4046 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4047 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4048 New window for editing connection-specific smtp details.
4049 Not fully implemented.
4051 * src/maemo/modest-connection-specific-smtp-window.c:
4052 (modest_connection_specific_smtp_window_finalize) :
4053 unref the tree model.
4054 (on_button_edit): Show the edit window.
4056 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4058 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4061 * src/maemo/Makefile.am:
4062 * src/maemo/modest-connection-specific-smtp-window.c:
4063 * src/maemo/modest-connection-specific-smtp-window.h:
4064 New window for showing the list of connections, for connection-specific
4065 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4066 * src/maemo/easysetup/modest-easysetup-wizard.c:
4067 (create_page_custom_outgoing): Show the new window when the button is clicked.
4069 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4071 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4072 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4073 * src/maemo/modest-msg-edit-window.c:
4074 (modest_msg_edit_window_insert_image):
4075 * src/modest-conf.c: (modest_conf_key_escape):
4076 * src/modest-mail-operation.c:
4077 (modest_mail_operation_send_new_mail):
4078 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4079 (modest_ui_actions_on_new_account):
4080 * src/widgets/modest-attachment-view.c: (update_filename_request):
4081 * src/widgets/modest-mail-header-view.c:
4082 Corrected warnings that were breaking the build, by commenting out unused variables,
4083 and a function, and by including a header.
4085 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4087 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4088 so we can #ifdef around platform-specific code when necessary.
4089 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4090 to allow this to build for the GNOME platform too.
4092 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4094 * src/maemo/easysetup/modest-easysetup-wizard.c:
4095 Added util_increment_name() and used it in create_page_account_details()
4096 to make sure that the default account name is always a new name.
4098 (modest_easysetup_wizard_dialog_init),
4099 (set_default_custom_servernames): Some minor memory management fixes.
4101 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4105 * src/modest-runtime.c: (init_i18n): Restored the translation
4106 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4107 are defined in config.h, and the translations are installed.
4109 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4110 is defined for translation.
4112 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4114 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4116 * src/maemo/easysetup/modest-easysetup-wizard.c:
4117 (modest_easysetup_wizard_dialog_init):
4118 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4119 Use realistic paths (though they should use $prefix generically) to the
4120 mcc_mapping and provider-data.keyfile files which might work when they
4121 are installed by the future version of the operator-wizard package,
4122 and then fallback to paths in our source code, with an explanatory
4125 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4129 * src/maemo/Makefile.am:
4130 * src/maemo/easysetup/: Added files from the previously-exernal
4131 osso-modest-easysetup.
4132 * src/maemo/modest-main-window-ui.h:
4133 * src/modest-ui-actions.c:
4134 * src/modest-ui-actions.h:
4135 Added modest_ui_actions_on_new_account() as a signal handler for the
4136 New Account menu item. It shows the easysetup wizard.
4137 * po/en_GB.po: Added additional needed logical IDs and translations.