1 2007-06-22 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-msg-edit-window.c: (init_window):
4 Comment out use of an uninitialzed GtkScrolledWindow variable,
5 to fix the build and stop a crash. Yet again.
7 2007-06-22 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-tny-account-store.c: (get_password):
10 Remove the call to tny_account_set_user() because this actually crashes.
11 As mentioned in the last commit, it is known to not work anyway.
13 2007-06-22 Murray Cumming <murrayc@murrayc.com>
15 * src/modest-tny-account-store.c: (get_password):
16 Use tny_account_set_username() to tell tinymail that the username might
17 have changed too. But tinymail ignores this: see projects.maemo.org
19 * src/modest-ui-actions.c:
20 (modest_ui_actions_on_password_requested): Remove the useless attempt to
21 reset the connection when changing the username, and improve the comments.
22 Save the changed username to gconf at least, so it is used when Modest is
25 2007-06-21 Murray Cumming <murrayc@murrayc.com>
27 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
28 Do not use a query, so that we get all folders, including for POP and
29 local-folders. They work as search criteria too.
30 This fixes projects.maemo.org bug NB#57740.
32 2007-06-21 Murray Cumming <murrayc@murrayc.com>
34 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
35 Comment out the use of hildon_notification_set_sound() because it is
36 not declared, to fix the build. Warnings are serious, people.
38 2007-06-21 Armin Burgmeier <armin@openismus.com>
40 * src/maemo/modest-maemo-utils.h:
41 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
42 modest_maemo_utils_get_supported_secure_authentication_methods()
43 to query authentication methods for a specific user. This should fix
44 projects.maemo.org bug NB#61369.
46 * src/maemo/easysetup/modest-easysetup-wizard.c:
47 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
50 2007-06-21 Murray Cumming <murrayc@murrayc.com>
52 * libmodest-dbus-client/libmodest-dbus-client.h:
53 * libmodest-dbus-client/libmodest-dbus-client.c:
54 (modest_dbus_message_iter_get_search_hit),
55 (libmodest_dbus_client_search):
56 Reorganised and commented this.
57 Removed modest_search_hit_free() from the public API because it
60 Added libmodest_dbus_client_get_folders() and
61 modest_folder_result_list_free().
63 * src/dbus_api/modest-dbus-api.h:
64 * src/dbus_api/modest-dbus-callbacks.c:
65 (modest_dbus_req_filter): Commented. Moved most code to
66 on_dbus_method_search() and added on_dbus_method_get_folders().
68 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
69 of the extra D-Bus handler.
71 * tests/dbus_api/Makefile.am:
72 * tests/dbus_api/test_get_folders.c: New test for
73 libmodest_dbus_client_get_folders(). This seems to return an empty list
74 at the moment. That could be the same error that causes the message list
75 to be empty sometimes.
76 This should help with projects.maemo.org bug NB#57740.
78 2007-06-21 Armin Burgmeier <armin@openismus.com>
80 * src/modest-mail-operation.c: Do not call
81 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
82 notify the operation's end after having set the status to CANCELED for
83 the operation queue to listen on. This fixes a deadlock when there
84 were mail operations in the queue during its finalization.
86 * src/modest-singletons.c: Reordered uninitialization of the account
87 manager to happen after the mail operation queue was uninitialized
88 because the mail operation's in the queue might still try to access
89 the account manager (see modest_mail_operation_notify_end()). This
90 fixes a potential crash when terminating the application.
92 2007-06-21 Murray Cumming <murrayc@murrayc.com>
94 * src/modest-search.c:
95 (search_mime_part_and_child_parts): Moved some code here so we
96 can search recursively in child folders.
97 (modest_search_folder): Search in the message as a mime part, instead
98 of just its child mime parts.
99 (read_chunk), (search_mime_part_ogs):
100 Check how many bytes were read, to prevent an endless loop.
101 Searching in message bodies now works. This finishes the fix for
102 projects.maemo.org bug NB#61007.
104 2007-06-20 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
107 Add a g_warning when the item is not a folder.
109 * src/modest-ui-dimming-rules.c:
110 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
111 when selected item is not a folder (for instance, an account), because
112 the UI spec only talks about folders.
113 I am not sure what the UI spec wants, so this might not totally fix
114 projects.maemo.org bug NB#60794.
116 2007-06-20 Murray Cumming <murrayc@murrayc.com>
118 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
119 (load_from_file): Sort the list. The unsorted list would be more noticeable
120 in non-English locales.
122 * src/maemo/modest-msg-edit-window.c:
123 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
124 warning and fix the build.
126 * src/maemo/modest-progress-bar-widget.c:
127 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
128 avoid a g_warning, and probably to avoid a crash.
130 2007-06-20 Murray Cumming <murrayc@murrayc.com>
132 * src/modest-search.c: (modest_search_folder): Check for a GError
133 when calling tny_folder_get_headers(), to show that this is not the cause
136 2007-06-20 Murray Cumming <murrayc@murrayc.com>
138 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
139 Actually set the body query instead of the subject query.
141 * src/modest-search.c: (search_mime_part_ogs),
142 (search_mime_part_strcmp): Remove extra space from the text/* regex,
143 which would probably cause it to fail if we got this far.
145 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
146 to simplify the code.
147 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
148 be causing search-in-body to fail.
150 2007-06-20 Murray Cumming <murrayc@murrayc.com>
152 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
154 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
155 Better debug message when the folder cannot be found.
156 This should help with fixing projects.maemo.org bug #61287.
157 * src/modest-search.c: (add_hit): Do not leak the furl string.
159 2007-06-20 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-ui-actions.c:
162 (modest_ui_actions_on_folder_selection_changed):
163 Do not special-case TNY_MERGE_FOLDER here, because
164 modest_tny_folder_get_account() already does that. This fixes
165 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
166 shown when the Outbox was selected).
168 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
170 * libmodest-dbus-client/libmodest-dbus-client.c:
171 (_dbus_iter_get_string_or_null): Initialize the string variable in
172 case this helps with Dirk's crash.
174 2007-06-19 Murray Cumming <murrayc@murrayc.com>
176 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
177 though it is not implemented yet (this function is maybe not even used),
178 to avoid breaking ABI in future.
179 * libmodest-dbus-client/libmodest-dbus-client.c:
180 (get_attachments_string): Moved some code into this generic function.
181 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
182 sends email. It is maybe not used.
183 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
184 (on_send_mail): Use attachments.
186 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
187 * src/maemo/modest-msg-edit-window.c:
188 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
189 a filename before using it, to fix projects.maemo.org bug NB#58233.
191 2007-06-19 Murray Cumming <murrayc@murrayc.com>
193 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
194 Initialize the continue_download variable to fix the build, and probably
195 to fix randome behaviour.
197 2007-06-18 Armin Burgmeier <armin@openismus.com>
199 * src/modest-tny-send-queue.h:
200 * src/modest-tny-send-queue.c: Keep track of the status of messages in
201 the queue so we can later show it in the UI. Replaced
202 modest_tny_send_queue_msg_is_being_sent() by
203 modest_tny_send_queue_get_msg_status().
205 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
207 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
208 gpointer. This probably was not harmful, but just to be sure.
210 2007-06-18 Murray Cumming <murrayc@murrayc.com>
212 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
213 Fix the build, but leave the function broken on Bora, because
214 hildon_uri_action_get_service() does not exist.
215 osso_uri_action_get_service() does not exist either, it seems.
217 2007-06-18 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-tny-account.c:
220 (modest_tny_account_new_from_server_account):
221 Uncommented the url debug output again, because it is useful for
222 debugging, as I said in the comment.
224 2007-06-18 Murray Cumming <murrayc@murrayc.com>
226 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
228 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
229 for Mameo Bora, to fix the build.
231 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
234 Fixed build with hildon < 0.99
236 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
237 Check if the selected account is busy instead of checking all accounts
239 * src/modest-account-mgr-priv.h:
240 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
241 (modest_account_mgr_init), (compare_account_name),
242 (modest_account_mgr_set_account_busy),
243 (modest_account_mgr_account_is_busy):
244 * src/modest-account-mgr.h:
245 Added busy information to the account manager. It possible to
246 set an account to busy or not busy now.
248 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
249 (modest_mail_operation_update_account),
250 (modest_mail_operation_notify_end):
251 Set the account to busy/not busy depending on the operation state.
253 * src/widgets/modest-account-view.c:
254 (modest_account_view_finalize), (get_last_updated_string),
255 (update_account_view), (on_account_busy_changed), (init_view):
256 Show string "Refreshing..." if the account is currently busy.
258 All this fixes projects.maemo.org bug NB#59711
260 2007-06-14 Armin Burgmeier <armin@openismus.com>
262 * src/widgets/modest-attachments-view.h:
263 * src/widgets/modest-attachments-view.c: Added
264 modest_attachments_view_has_attachments() and fixed coordinate
265 transformation in get_att_view_at_coords(). This fixes attachment
268 * src/widgets/modest-msg-view.c: Make use of
269 modest_attachments_view_has_attachments() to decide whether to show
270 attachments in the header.
272 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
274 * src/maemo/modest-connection-specific-smtp-edit-window.c:
275 (on_change), (on_combo_security_changed),
276 (modest_connection_specific_smtp_edit_window_init),
277 (modest_connection_specific_smtp_edit_window_set_connection),
278 (modest_connection_specific_smtp_edit_window_is_dirty):
279 * src/maemo/modest-connection-specific-smtp-edit-window.h:
280 * src/maemo/modest-connection-specific-smtp-window.c:
283 Show an comfirmation dialog for the smpt-edit-window if there are
284 unsaved changes and the user hits cancel.
285 (projects.maemo.org bug NB#60479)
287 2007-06-14 Armin Burgmeier <armin@openismus.com>
289 * src/maemo/easysetup/modest-easysetup-wizard.c:
290 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
291 address" info in banner instead of node, and select all the text as
292 per UI spec. This fixes projects.maemo.org bug NB#60550.
294 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
296 reviewed by: <delete if not using a buddy>
298 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
299 * src/modest-ui-actions.c: (folder_refreshed_cb):
301 2007-06-14 Murray Cumming <murrayc@murrayc.com>
303 * src/widgets/modest-folder-view.c: (filter_row):
304 Explictly filter out the per-account outbox accounts. I don't know why
305 these only sometimes show up, but now they should never show up in the UI.
306 This should fix projects.maemo.org bug NB#60160.
308 2007-06-14 Murray Cumming <murrayc@murrayc.com>
310 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
311 when the toolbar does not exist yet.
312 * src/modest-widget-memory.c: (save_settings_header_view):
313 Added g_warnings() to help us to discover when we are trying to set
314 an empty columns list in gconf.
316 2007-06-14 Murray Cumming <murrayc@murrayc.com>
320 Added modest_init_get_default_header_view_column_ids().
322 * src/modest-widget-memory.c: (restore_settings_header_view):
323 Use the new function to get defaults, if the gconf key is empty,
324 instead of not creating any columns. This seems to fix the
325 empty right-hand pane problems.
327 * src/widgets/modest-header-view.h: Improved documentation.
329 2007-06-13 Murray Cumming <murrayc@murrayc.com>
331 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
332 Revert the use of the display name as the account name, because this
333 is generally wrong and would break the code that follows.
335 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
337 * src/maemo/easysetup/modest-easysetup-wizard.c:
338 (check_for_supported_auth_methods), (on_before_next),
341 More correct fix for projects.maemo.org bug NB# 58991
342 Do not longer accept AUTH_PASSWORD as secure method and choose
343 correct method when creating the account.
345 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
347 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
348 Fixed projects.maemo.org bug NB# 58991
350 2007-06-13 Murray Cumming <murrayc@murrayc.com>
352 * src/modest-init.c: (modest_init_init_core),
353 (modest_init_local_folders): Fixed compilation errors.
355 2007-06-13 Murray Cumming <murrayc@murrayc.com>
357 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
358 Remove unnecessary lib/include, though it is good in principle when needed.
360 * src/modest-init.c: (modest_init_one_local_folder),
361 (modest_init_local_folders):
362 * src/modest-init.h: Initialize the .modest library for memory cards,
363 instead of just doing nothing for them. This should allow us to create
364 folders there, fixing projects.maemo.org bug NB#59297.
366 2007-06-13 Murray Cumming <murrayc@murrayc.com>
368 * libmodest-dbus-client/libmodest-dbus-client.c:
369 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
370 (libmodest_dbus_client_compose_mail),
371 (libmodest_dbus_client_open_message),
372 (libmodest_dbus_client_send_and_receive),
373 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
375 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
376 (on_idle_open_message), (modest_dbus_req_handler),
377 (search_result_to_message), (modest_dbus_req_filter):
378 * src/modest-search.c: (add_hit), (modest_search_folder),
379 (modest_search_all_accounts): Improved debug messages.
381 * tests/dbus_api/test_open_message.c: (main): Improved comments.
383 * src/modest-tny-account-store.c:
384 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
387 2007-06-13 Murray Cumming <murrayc@murrayc.com>
390 2007-06-12 Murray Cumming <murrayc@murrayc.com>
392 * src/modest-tny-account-store.c: (get_server_accounts):
393 Call modest_tny_local_folders_account_add_merged_outbox_folders()
394 even when there are no accounts, so that the Outbox folder is always
395 visible. This fixes projects.maemo.org bug NB#60158.
397 2007-06-12 Murray Cumming <murrayc@murrayc.com>
399 * src/maemo/modest-main-window.c: (create_details_widget):
400 Use the mcen_va_never logical ID.
402 2007-06-12 Murray Cumming <murrayc@murrayc.com>
404 * src/dbus_api/modest-dbus-api.h:
405 * src/dbus_api/modest-dbus-callbacks.c:
406 (on_idle_open_default_inbox), (on_open_default_inbox),
407 (modest_dbus_req_handler):
408 Added a new OpenDefaultInbox method.
410 * libmodest-dbus-client/libmodest-dbus-client.h:
411 * libmodest-dbus-client/libmodest-dbus-client.c:
412 Added libmodest_dbus_client_open_default_inbox() to call the new
413 dbus method. This should be useful to projects.maemo.org bug NB#57214,
414 though it should maybe be used by a new osso-email-interface function.
416 * tests/dbus_api/Makefile.am:
417 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
420 2007-06-12 Murray Cumming <murrayc@murrayc.com>
422 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
423 NULL, so that the signals get all the keys. This should not actually
424 change any behaviour because we currently update everything when anything
427 2007-06-12 Murray Cumming <murrayc@murrayc.com>
429 * src/widgets/modest-folder-view.c: (text_cell_data),
430 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
431 (find_inbox_iter): If tinymail tells us that the folder is
432 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
433 This causes the inbox to be selected at startup, fixing part of
434 projects.maemo.org bug NB#56305.
436 * src/modest-ui-dimming-rules.c:
437 (modest_ui_dimming_rules_on_tools_smtp_servers):
438 * src/modest-ui-dimming-rules.h: Added a callback function to dim
439 the SMTP servers menu item.
440 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
441 that the SMTP Servers menu item is dimmed when there are no accounts,
442 as a future version of the UI spec will require. This fixes
443 projects.maemo.org bug NB#56305.
445 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
447 * src/maemo/modest-maemo-utils.c:
448 (modest_maemo_utils_get_supported_secure_authentication_methods):
449 Added label to dialog instead of unreadable title
451 * src/maemo/modest-main-window.c: (sync_accounts_cb),
452 (modest_main_window_new):
453 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
456 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
457 * src/modest-account-mgr.h:
458 Added method to avoid code duplication
460 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
461 (modest_ui_actions_on_send_receive):
462 Use modest_account_mgr_has_accounts
464 2007-06-11 Murray Cumming <murrayc@murrayc.com>
466 * src/maemo/easysetup/modest-presets.c:
467 (modest_presets_get_info_server_security): Do not report secure auth
469 * src/modest-protocol-info.c: Use the defines for the gconf key names
470 for secure authentication. This was not working because we were writing
471 Password and reading password, and the check was case sensitive.
472 With this, gmail now works for receiving and sending when created via
475 2007-06-11 Murray Cumming <murrayc@murrayc.com>
477 * src/maemo/easysetup/modest-presets.c:
478 (modest_presets_get_info_server_security): Correct the key name for
479 SecureSmtp, because it seems to be case-sensitive.
480 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
481 Do not try to get the 0th notebook page if there are 0 pages, to
484 2007-06-11 Murray Cumming <murrayc@murrayc.com>
486 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
487 Prevent use of the new notification feature for now, because it currently
488 shows one dialog for each new email, which is annoying.
490 2007-06-11 Murray Cumming <murrayc@murrayc.com>
492 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
493 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
494 when no country was selected, so that we show the global ones.
495 * src/maemo/easysetup/modest-presets.c:
496 (modest_presets_get_providers): Return only the global providers, not
497 all providers when mmc=0 was requested.
499 2007-06-11 Murray Cumming <murrayc@murrayc.com>
501 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
502 (easysetup_provider_combo_box_fill): Remove debug code that showed the
503 provider ID in the combo.
505 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
506 Do not show the page numbers, because it would be confusing when we add
507 the 2 extra pages for the custom setup, when the user chooses the "Other"
508 provider. This fixes projects.maemo.org bug NB#59028
510 * src/modest-init.c: (modest_init_init_core),
511 (modest_init_local_folders):
513 * src/modest-tny-account.c:
514 (modest_tny_account_new_for_local_folders): Do not create default folders
515 for the memory card. This should fix projects.maemo.org bug NB#59328.
517 2007-06-11 Murray Cumming <murrayc@murrayc.com>
519 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
520 Free the changed_conf_keys string items. They are already freed in the
521 idle handler if that runs first.
523 2007-06-11 Murray Cumming <murrayc@murrayc.com>
525 * src/modest-ui-actions.c:
526 (modest_ui_actions_on_password_requested): Check that the server name
527 is not NULL, because I just saw a password dialog with (null) as the
530 * src/modest-tny-folder.[h|c]: Added
531 modest_tny_folder_is_memory_card_folder().
532 * src/modest-ui-dimming-rules.c:
533 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
534 menu item for memory cards, as per the UI spec (section 7.4). This should
535 fix projects.maemo.org bug NB#59297.
537 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
539 * src/maemo/modest-main-window.c: (sync_accounts_cb):
540 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
541 is another problem with the code, see Murray's comment at line 772)
543 2007-06-08 Murray Cumming <murrayc@murrayc.com>
545 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
546 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
547 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
548 (load_from_file), (easysetup_country_combo_box_init),
549 (easysetup_country_combo_box_get_active_country_ids),
550 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
551 instead of just one ID, to avoid duplicate country names in the UI.
553 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
554 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
555 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
556 a single ID, avoiding duplicate providers.
557 * src/maemo/easysetup/modest-easysetup-wizard.c:
558 (on_combo_account_country): Adapt to use a list.
560 2007-06-08 Murray Cumming <murrayc@murrayc.com>
562 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
563 keys changed in the last X seconds.
565 * src/modest-account-mgr.h:
566 * src/modest-account-mgr.c: (on_timeout_notify_changes),
567 (on_key_change), (modest_account_mgr_class_init),
568 (modest_account_mgr_init), (modest_account_mgr_finalize):
569 As the keys are changed, save them in a GSList* and signal that GSList*
570 further every X seconds, to batch changes, to allow us to do just one
571 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
572 bug NB#56941 and other (UI-blocking) delays when changing account settings.
574 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
575 changed signal signature.
577 * src/modest-conf.c: (modest_conf_set_list),
578 (modest_conf_on_change): Reenable notification.
580 (modest_conf_maemo_fake_on_change): Comment out the hack that
581 notified immediately instead of asynchronously.
583 * src/widgets/modest-account-view.h:
584 * src/widgets/modest-account-view.c:
585 (update_account_view): Select the previously-selected account ID,
586 if possible. This fixes projects.maemo.org bug NB#56933.
588 (on_account_changed), (on_account_removed),
589 (modest_account_view_select_account):
591 Remove the block/unblock functions
592 because they were not useful.
594 * src/maemo/modest-account-view-window.c:
595 (on_delete_button_clicked), (on_edit_button_clicked),
596 (on_new_button_clicked): Remove the use of the non-working block/unblock.
598 2007-06-08 Murray Cumming <murrayc@murrayc.com>
600 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
601 Improve the error dialog to show Incorrect Account Settings, which seems
602 clearer, and say that the internal error message (to be removed from the
603 dialog later) is often misleading.
604 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
606 * src/modest-tny-account.c:
607 (modest_tny_account_new_from_server_account): Uncomment the printf of the
608 URL because this is so useful for debugging on the device.
610 * src/widgets/modest-serversecurity-combo-box.c:
611 (modest_serversecurity_combo_box_fill): Correct a logical ID.
613 2007-06-08 Murray Cumming <murrayc@murrayc.com>
615 * src/modest-mail-operation.c:
616 (modest_mail_operation_send_new_mail):
617 Added a comment about a nasty but apparently harmless message. Details
618 added to the wiki g_warnings() page.
620 2007-06-08 Murray Cumming <murrayc@murrayc.com>
622 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
623 (modest_tny_send_queue_class_init):
624 Do not use the priv struct because it is empty, to avoid g_warnings
625 about a non-existant priv struct.
627 * src/modest-tny-account-store.c:
628 (modest_tny_account_store_get_server_account),
629 (modest_tny_account_store_get_transport_account_for_open_connection
630 ): Do not try to get transport server accounts for local folders,
631 because they don't have any. This avoids a g_warning().
633 * src/maemo/modest-main-window.c:
634 (modest_main_window_notify_send_receive_initied),
635 (on_configuration_key_changed):
636 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
638 * src/modest-mail-operation.c:
639 (modest_mail_operation_update_account):
640 * src/modest-tny-account-store.h:
641 * src/modest-tny-account.c:
642 (modest_tny_account_get_special_folder),
643 (modest_tny_account_new_for_local_folders),
644 (modest_tny_account_new_for_per_account_local_outbox_folder):
645 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
646 * src/modest-tny-local-folders-account.c:
647 (add_account_folders_to_merged_folder):
648 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
649 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
650 (modest_ui_actions_on_send):
651 * src/widgets/modest-folder-view.c: (update_model):
652 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
653 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
654 modest_tny_account_store_get_tny_account_by_account() to
655 modest_tny_account_store_get_server_account() to make the code clearer.
657 2007-06-07 Marcus Bauer <marcusb@openismus.com>
659 * src/dbus_api/modest-dbus-api.h:
660 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
661 * src/maemo/modest-msg-edit-window.c:
662 (modest_msg_edit_window_attach_file_noninteractive):
663 added g_warning in case the file to be attached does not exist
664 * tests/dbus_api/test_compose_mail.c: (main):
665 removed obsolete comment, added generic files as test case
667 2007-06-07 Murray Cumming <murrayc@murrayc.com>
669 * src/modest-tny-account-store.c: (get_server_accounts):
670 Create the local folders account only once, not once for each outbox, and
671 not only when there are some outboxes.
673 2007-06-07 Murray Cumming <murrayc@murrayc.com>
675 * src/widgets/modest-folder-view.c: (update_model): Comment out some
676 code that is causing a crash at startup. Sergio says that he is fixing this.
678 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
680 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
681 * src/maemo/modest-account-settings-dialog.c:
682 (create_page_outgoing),
683 (modest_account_settings_dialog_set_account_name),
684 (save_configuration):
685 - Fixed handling of the "Use secure authentication" toggle to comply with
686 the ui specification. See also projects.maemo.org bug NB#58400
688 - Restore the Secure connection setting combo correctly when loading
691 * src/maemo/modest-maemo-utils.c:
692 (on_camel_account_get_supported_secure_authentication),
693 (modest_maemo_utils_get_supported_secure_authentication_methods):
694 Fixed a crasher if operation is canceled
696 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
697 (modest_protocol_info_auth_is_secure):
698 * src/modest-protocol-info.h:
700 Added two new methods to determine if a protocol/auth method is secure/encrypted in
701 the sense of the "Use secure authentication" toggle.
703 2007-06-07 Murray Cumming <murrayc@murrayc.com>
705 * src/modest-tny-account-store.h:
706 * src/modest-tny-account-store.c:
707 Added modest_tny_account_store_get_local_folders_account().
709 * src/modest-tny-folder.h:
710 * src/modest-tny-folder.c:
711 (modest_tny_folder_get_account):
712 Added this replacement for tny_folder_get_account() which returns
713 the local-folders account for TnyMergeFolders, to avoid the
714 warning about the unimplemented get_account_func() vfunc().
716 (modest_tny_folder_get_rules),
717 * src/modest-ui-actions.c:
718 (modest_ui_actions_on_folder_selection_changed):
719 * src/modest-mail-operation.c:
720 (modest_mail_operation_remove_folder),
721 (modest_mail_operation_xfer_folder),
722 (modest_mail_operation_rename_folder),
723 (modest_mail_operation_get_msg),
724 (modest_mail_operation_get_msgs_full),
725 (modest_mail_operation_remove_msg),
726 (modest_mail_operation_xfer_msgs),
727 (modest_mail_operation_refresh_folder):
728 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
730 2007-06-07 Murray Cumming <murrayc@murrayc.com>
732 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
733 (modest_server_account_set_security):
734 * src/modest-defs.h: Add comments explaining that our
735 UI spec means TLS when it says Normal, so these do not look like errors.
737 * src/modest-tny-account.c:
738 (modest_tny_account_new_from_server_account): Use the new tinymail
739 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
740 for TLS. This should fix projects.maemo.org bug NB#58460.
742 2007-06-06 Murray Cumming <murrayc@murrayc.com>
744 * src/maemo/easysetup/modest-easysetup-wizard.c:
745 (create_account): Correct the position of the gconf sanity check warning.
746 (on_button_edit_advanced_settings): Show the dialog immediately, instead
747 of using the g_idle_add() hack, because this does not seem to be necessary
748 on osso 1.1. It might even work on Maemo Bora if the problems were actually
749 caused by something other than maemo's gconf.
750 This fixes projects.maemo.org bug #59022.
752 2007-06-06 Murray Cumming <murrayc@murrayc.com>
754 * src/modest-account-mgr-helpers.c:
755 (modest_account_mgr_get_default_account): Do not check that the account
756 exists if there is no default account (NULL), to fix a runtime warning.
758 2007-06-06 Murray Cumming <murrayc@murrayc.com>
760 * src/widgets/modest-folder-view.c: (update_model):
761 Do not unref the treemodel before we have finished with it.
762 This prevents a valgrind warning and an occasional crash at startup.
764 2007-06-06 Marcus Bauer <marcusb@openismus.com>
766 * libmodest-dbus-client/libmodest-dbus-client.h:
767 added libmodest_dbus_client_compose_mail()
768 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
770 added functions needed for SendAsMail() functionality
771 * src/maemo/modest-msg-edit-window.c:
772 (modest_msg_edit_window_attach_file_noninteractive):
773 non interactively attaching files to message edit window
774 * src/widgets/modest-msg-edit-window.h:
775 * tests/dbus_api/Makefile.am:
776 added test_compose_mail.c
777 * tests/dbus_api/test_compose_mail.c: (main):
779 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
781 * src/modest-account-view.c:
782 Fixed bug projects.maemo.org bug NB#59307
784 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
786 * src/maemo/easysetup/modest-easysetup-wizard.c:
787 (get_serverport_incoming), (on_before_next), (create_account):
788 * src/maemo/modest-account-settings-dialog.c:
789 (modest_account_settings_dialog_set_account_name):
790 * src/maemo/modest-maemo-utils.c:
791 (on_camel_account_get_supported_secure_authentication_status),
792 (on_camel_account_get_supported_secure_authentication),
793 (on_secure_auth_cancel),
794 (modest_maemo_utils_get_supported_secure_authentication_methods):
796 Implemented security authentication for settings and easysetup.
798 2007-06-05 Murray Cumming <murrayc@murrayc.com>
800 * src/maemo/modest-main-window.c: (create_details_widget):
801 Show the total size for memory card accounts too, instead of showing
802 the name again. Fixes bug projects.maemo.org bug NB#59307.
804 2007-06-05 Murray Cumming <murrayc@murrayc.com>
807 * src/modest-tny-simple-folder-store.c:
808 * src/modest-tny-simple-folder-store.h: Removed.
810 * src/modest-tny-local-folders-account.h
811 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
812 for the local-folders maildir, with an extra TnyMergedFolder containing
813 the folders of the per-account outbox store accounts.
814 * src/modest-tny-account-store.c: (get_server_accounts):
815 Add the outboxes to the special local folders account after creating it.
817 * src/modest-tny-account.c:
818 (modest_tny_account_new_for_local_folders): Create the derived
819 account when creating the main local-folders account.
821 * src/maemo/modest-main-window.c: (create_details_widget),
822 (modest_main_window_set_contents_style):
823 Adapted to the use of the derived account instead of the folder store.
825 * src/modest-ui-actions.c:
826 (modest_ui_actions_on_folder_selection_changed):
827 * src/modest-ui-dimming-rules.c:
828 (modest_ui_dimming_rules_on_new_folder):
829 * src/widgets/modest-folder-view.c: (text_cell_data),
830 (icon_cell_data), (filter_row), (update_model),
831 (get_cmp_rows_type_pos):
834 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
835 Do not get the priv struct, because no priv struct has been set,
836 to avoid a runtime warning.
838 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
839 #ifelse with #else, to fix a warning, to fix the build.
842 2007-06-05 Christian Kellner <ckellner@openismus.com>
844 * libmodest-dbus-client/libmodest-dbus-client.c:
845 Fix small typo in doc (why do you always see them
846 AFTER committing stuff?)
849 2007-06-05 Christian Kellner <ckellner@openismus.com>
851 * libmodest-dbus-client/libmodest-dbus-client.c:
852 (libmodest_dbus_client_search):
853 Initialize hit list with NULL. Also set folder list
854 to "" if NULL was supplied.
857 2007-06-03 Christian Kellner <ckellner@openismus.com>
859 * libmodest-dbus-client/libmodest-dbus-client.c:
860 (modest_search_hit_list_free):
861 Make it save to call it with NULL.
863 * src/dbus_api/modest-dbus-callbacks.c:
864 * src/modest-search.c:
865 Return full ModestSearchHits as the search result list not TnyHeader
866 since can't be around withouth the correspoding TnyFolder.
868 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
870 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
871 Added currently commented code to check for secure auth
873 * src/maemo/modest-account-settings-dialog.c: (on_response),
874 (save_configuration), (show_ok):
875 Fixed projects.maemo.org bugs NB #59248 and #59251
877 * src/maemo/modest-maemo-utils.c:
878 (on_camel_account_get_supported_secure_authentication_status),
879 (on_camel_account_get_supported_secure_authentication),
880 (modest_maemo_utils_get_supported_secure_authentication_methods):
881 * src/maemo/modest-maemo-utils.h:
882 Moved get_supported_secure_authentication() method here to be able
883 to use it from easysetup wizard.
885 * src/modest-pair.c: (on_pair_compare_as_string):
886 Should compare string with first part of pair and not
887 strcmp pairs which will crash.
889 * src/modest-protocol-info.c:
890 (modest_protocol_info_protocol_is_store):
891 * src/modest-protocol-info.h:
892 Added modest_protocol_info_get_auth_protocol_name()
894 2007-06-03 Armin Burgmeier <armin@openismus.com>
896 * src/modest-mail-operation.c:
897 (modest_mail_operation_get_msgs_full): Set priv->account also when
898 only retrieving a single message. This avoids a crash when canceling
901 (modest_mail_operation_notify_end): Do not explicitely remove the
902 operation from the queue but only emit the progress_changed signal.
903 The queue itself listens to that signal to remove the operation when
904 it is finished. This reduces coupling and removes a potential deadlock
905 when modest_mail_operation_notify_end() is called from the queue
906 itself. If that is a problem performance-wise, I would suggest to
907 implement a status-changed signal or something.
909 * src/modest-mail-operation-queue.c: Make sure to never call a
910 function from another file while the queue is locked. This (hopefully)
911 fixes another deadlock when exiting the application while retrieving
914 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
916 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
917 Fixed build if libogs is not available
919 2007-06-03 Christian Kellner <ckellner@openismus.com>
921 * libmodest-dbus-client/libmodest-dbus-client.h:
922 * libmodest-dbus-client/libmodest-dbus-client.c:
923 (libmodest_dbus_client_delete_message):
924 Implement deletion of messages (Client side).
926 (modest_search_hit_free),
927 (modest_search_hit_list_free):
928 Utility functions to free the result hits.
930 * src/dbus_api/modest-dbus-api.h:
931 * src/dbus_api/modest-dbus-callbacks.c:
933 (modest_dbus_req_handler):
934 Implement deletion of messages (Server side).
936 * tests/dbus_api/test_search.c: (main):
939 * tests/dbus_api/Makefile.am:
940 * tests/dbus_api/test_delete_message:
941 Add little test for the message deletion logic
943 2007-06-03 Armin Burgmeier <armin@openismus.com>
945 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
946 when the operation queue was not empty. projects.maemo.org bug
949 2007-06-03 Armin Burgmeier <armin@openismus.com>
951 * src/widgets/modest-account-view.c
952 (on_account_default_toggled): Toggle default account column
953 explicitely instead of waiting for gconf notification (which is
954 currently ignored). This should fix projects.maemo.org bug NB#56910
955 for now. It should probably be removed when gconf notifications are
958 2007-06-03 Christian Kellner <ckellner@openismus.com>
960 * libmodest-dbus-client/libmodest-dbus-client.c:
961 Removed debugging spew.
963 * src/dbus_api/modest-dbus-callbacks.c:
964 Added debugging info.
966 * src/modest-search.c:
967 (modest_search_all_accounts):
968 Use tny_account_store_get_accounts () on the account store
969 to get all accounts which is the way to get all accounts.
971 * tests/dbus_api/test_search.c: (main):
972 Make it possible to supply the search term on the command line.
974 2007-06-03 Christian Kellner <ckellner@openismus.com>
976 * libmodest-dbus-client/libmodest-dbus-client.c:
977 * libmodest-dbus-client/libmodest-dbus-client.h:
978 Implement searching for mesages over raw dbus. (Client side)
980 * src/dbus_api/Makefile.am:
981 * src/dbus_api/modest-dbus-api.h:
982 * src/dbus_api/modest-dbus-callbacks.c:
983 * src/dbus_api/modest-dbus-callbacks.h:
984 Search framework (Server side). Also implement on_idle_open_message().
986 * src/maemo/modest-platform.c: (modest_platform_init):
987 Prepare for raw dbus/osso rpc interaction.
989 * src/modest-search.h:
990 Changed minsize from unspecific guint to guint32.
992 * src/modest-search.c:
994 Added strange hack which magically made tnymail work.
996 (modest_search_folder),
997 (modest_search_account),
998 (modest_search_all_accounts):
999 Implement helper functions to search all accounts, specific account
1002 * tests/dbus_api/Makefile.am:
1003 * tests/dbus_api/test_open_message.c:
1004 Read url to open from commandline.
1006 * tests/dbus_api/test_search.c:
1007 Implement small test for dbus search stuff
1009 2007-06-02 Armin Burgmeier <armin@openismus.com>
1011 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1012 include account type and account title. This fixes projects.maemo.org
1015 * src/maemo/modest-account-view-window.c: Set a title for the window.
1017 2007-06-02 Armin Burgmeier <armin@openismus.com>
1019 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1020 incoming and outgoing server name based on email address and server
1021 types as long as the names have not been edited manually. This fixes
1022 projects.maemo.org bug NB#58671.
1024 2007-06-02 Armin Burgmeier <armin@openismus.com>
1026 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1027 server type cannot be changed in future to the incoming details page
1028 when creating an account. This fixes projects.maemo.org bug NB#59029.
1030 2007-06-02 Armin Burgmeier <armin@openismus.com>
1032 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1033 and assigned max width chars so that they wrap instead of being
1034 truncated. Fixes projects.maemo.org bug NB#56126.
1036 2007-06-02 Armin Burgmeier <armin@openismus.com>
1038 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1039 introductory note to the connection specific smtp servers dialog, as
1040 section 8.12 of the email UI specification requires. This fixes
1041 projects.maemo.org bug NB#59212.
1043 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1045 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1046 Check for running mail operations, and offer to cancel them, as per the UI
1047 spec. This fixes projects.maemo.org bug NB#59041 .
1048 However, I suspect that tinymail may still use the network connection
1049 in ways that we cannot detect or cancel. But it should at least adapt to
1050 changes fairly well.
1052 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1054 * src/modest-tny-account-store.c: (recreate_all_accounts),
1055 (get_cached_accounts), (get_server_accounts): Do more sensible
1056 ref-counting of the temporarily-cached outbox accounts list. This seems
1057 to fix a crash when entering the password when the password was wrong.
1059 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1061 * src/gnome/modest-main-window.c: (connect_signals):
1062 * src/modest-tny-account-store.c: (get_password),
1063 (modest_tny_account_store_alert): Added comments and clues and
1064 commented-out code about how we currently fail to deal with connection
1065 errors and wrong passwords, and how we should.
1067 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1069 * src/widgets/modest-retrieve-combo-box.c:
1070 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1071 This fixes projects.maemo.org bug NB#58472 .
1073 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1075 * src/maemo/easysetup/modest-easysetup-wizard.c:
1076 (create_page_complete_easysetup):
1077 (create_page_complete_custom): Correct the last commit,
1078 putting the correct sentences in the correct pages.
1080 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1082 * src/maemo/easysetup/modest-easysetup-wizard.c:
1083 (create_page_complete_custom): Show the second sentence of text
1084 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1087 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1089 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1090 Set the leave-on-server conf key by default. This fixes
1091 projects.maemo.org bug NB#59258 .
1093 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1095 * src/maemo/modest-account-view-window.c:
1096 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1097 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1100 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1102 * src/maemo/easysetup/modest-easysetup-wizard.c:
1103 (create_caption_new_with_asterisk):
1104 * src/maemo/modest-account-settings-dialog.c:
1105 (create_caption_new_with_asterisk):
1106 Uncomment the code to add the asterisk, because they are no longer in the
1107 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1108 (update_incoming_server_title): Add an asterisk here too.
1110 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1112 * src/maemo/modest-maemo-global-settings-dialog.c:
1113 (current_connection): Check that we are even connected before trying to
1114 get the current connection name, to prevent a warning.
1116 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1117 Change the comments because tny_maemo_conic_device_connect() is now meant to
1119 * src/modest-mail-operation.c:
1120 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1121 make sure we have a connection and fail if we can't connect.
1123 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1125 * src/maemo/modest-main-window.c:
1126 (on_account_store_connecting_finished): Do not try to get the
1127 connection ID if we are not really connected. I am surprised that
1128 this signal handler is called when we are not connected.
1130 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1132 * src/modest-error.h:
1133 * src/modest-ui-actions.c:
1134 (modest_ui_actions_get_msgs_full_error_handler):
1135 Renamed an enum, added comments, added an enum
1136 for retrieve-limit errors.
1138 * src/modest-mail-operation.c: (foreach_add_item),
1139 (internal_folder_observer_update), (update_account_thread),
1140 (modest_mail_operation_get_msgs_full):
1141 (modest_mail_operation_update_account),
1142 Added comments about how this works, and some code that should
1143 (but does not) check the retrieve-limit. See the TODO comment.
1145 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1147 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1148 Initialize help_id to fix the build. Warnings are good.
1150 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1152 * src/widgets/modest-hbox-cell-renderer.c:
1153 (modest_hbox_cell_renderer_append):
1154 * src/widgets/modest-vbox-cell-renderer.c:
1155 (modest_vbox_cell_renderer_append):
1156 Fix the last commit by doing an extra ref.
1158 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1160 * src/widgets/modest-hbox-cell-renderer.c:
1161 (modest_hbox_cell_renderer_append):
1162 * src/widgets/modest-vbox-cell-renderer.c:
1163 (modest_vbox_cell_renderer_append):
1164 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1165 to fix the build with Maemo Bora.
1166 However, there seems to be a remaining crash, probably due to reference
1169 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1171 * src/modest-tny-account.c:
1172 (modest_tny_account_new_for_local_folders):
1173 Use hildon_file_system_info_async_new() to get a better name for
1174 the memory card account, setting it as the account name.
1175 The timing seems to work, but this is probably
1176 not the best place to do this. See the TODO comment.
1177 * src/maemo/modest-main-window.c: (create_details_widget):
1178 * src/widgets/modest-folder-view.c: (text_cell_data):
1179 Use the tny account name instead of hardcoding a name.
1181 2007-05-30 Christian Kellner <ckellner@openismus.com>
1183 * src/modest-search.c: (modest_search):
1184 Correctly set part_search_func even if we have already parsed
1185 the query and thus a valid OgsTextSearcher object.
1187 2007-05-30 Christian Kellner <ckellner@openismus.com>
1190 Search and check for libogs.
1193 Incooparte the ogs build env.
1195 * src/modest-mime-part-search-stream.c:
1196 * src/modest-mime-part-search-stream.h:
1197 Removed since we do the real searching now in modest-search.c.
1199 * src/modest-search.c:
1200 * src/modest-search.h:
1201 Implement support for ogs. We use that if available and requested
1202 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1203 should now handle the corner case when the search term is spread
1204 across multiple reads.
1205 Also the logic in modest_search () was corrected to search all
1206 requested fields until one is found.
1208 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1212 * src/modest-init.h:
1213 * src/modest-init.c: Made modest_init_local_folders() take a
1214 path and be public so we can iniitialize maildir folders on
1217 * src/modest-local-folder-info.h:
1218 * src/modest-local-folder-info.c:
1219 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1221 * src/modest-tny-account.c:
1222 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1223 still means the standard local-folders path on the local volume.
1225 * src/modest-tny-account-store.c:
1226 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1227 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1228 all accounts when that happens.
1229 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1230 this too, so it shows up in the treeview.
1232 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1234 * src/maemo/modest-maemo-global-settings-dialog.c:
1235 (current_connection):
1236 * src/widgets/modest-global-settings-dialog.c:
1237 (current_connection_default):
1238 Use the enum values instead of 0, 1 and -1,
1239 to make the code clearer.
1241 * src/modest-account-mgr-helpers.c:
1242 (modest_account_mgr_get_connection_specific_smtp): Make this code
1245 * src/modest-runtime.h:
1246 * src/modest-runtime.c:
1247 Added modest_runtime_remove_all_send_queues().
1248 * src/maemo/modest-main-window.c:
1249 (on_account_store_connecting_finished): Recreate the send queues,
1250 using the appropriate transport accounts for this new connection.
1251 Some futher adapting might be needed if the old send queues are not
1252 automatically stopped at this point.
1254 * src/modest-tny-account-store.c: (get_server_accounts):
1255 Create the connection-specific transport accounts, so that they can
1256 be found later by their ID.
1258 * src/modest-tny-account.h:
1259 * src/modest-tny-account.c:
1260 Added modest_tny_account_new_from_server_account_name().
1261 modest_tny_account_new_from_server_account(): Do not create the
1262 send queues here, because they will be
1263 recreated anyway when the connection changes for the first time.
1265 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1267 * src/modest-local-folder-info.h:
1268 * src/modest-local-folder-info.c:
1269 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1270 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1271 tbox_folder): Take a modest account name instead of a server TnyAccount,
1272 so we can have per-modest-account rather than per-transport-account
1274 We must make sure that we change or recreate the exisitng send queues
1275 when the connection changes for connection-specific transport accounts.
1277 * src/modest-tny-account-store.c:
1278 (create_per_account_local_outbox_folders): Create outboxed per modest
1279 account, not per transport account.
1281 * src/modest-tny-account.h:
1282 * src/modest-tny-account.c:
1283 (modest_tny_account_get_special_folder): For outboxes, get the
1284 parent modest account name. The account is ignored for other folders.
1285 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1286 modest account name rather than a server TnyAccount.
1288 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1290 * src/modest-tny-account.c:
1291 (modest_tny_account_new_from_server_account):
1292 Call modest_runtime_get_send_queue() immediately after creating transport
1293 accounts, so that they start trying to send email from the outbox as soon
1294 as possible at startup. This is probably what we want.
1296 * src/modest-mail-operation.c: (update_account_thread):
1297 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1298 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1299 * src/modest-tny-send-queue.h:
1300 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1301 (modest_ui_actions_on_send):
1302 Added comments about how sending works, though it needs some more work.
1304 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1306 * src/modest-tny-account.c:
1307 (modest_tny_account_get_special_folder): Add TODO because this fails when
1308 the network is busy.
1309 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1310 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1311 Do not try to show this window when there is no active account. The UI
1312 specs does not tell us what to do in this case.
1314 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1318 * src/maemo/Makefile.am:
1319 * src/widgets/Makefile.am: Some dist fixes.
1321 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1323 * src/maemo/modest-connection-specific-smtp-window.c:
1324 (on_button_edit): Make the code clearer, to prevent a double free.
1326 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1328 * src/maemo/modest-account-settings-dialog.c:
1329 (modest_account_settings_dialog_set_account_name),
1330 Check the connection-specific smtp servers checkbox if there are any.
1332 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1333 (modest_connection_specific_smtp_edit_window_init):
1334 Start with a suitable port number.
1336 * src/modest-account-mgr-helpers.h:
1337 * src/modest-account-mgr-helpers.c: Added
1338 modest_account_mgr_get_has_connection_specific_smtp().
1340 (modest_account_mgr_set_connection_specific_smtp),
1341 (modest_account_mgr_remove_connection_specific_smtp),
1342 (modest_account_mgr_get_has_connection_specific_smtp),
1343 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1344 connection-specific smtp server accounts in the account, rather than
1345 the server account conf dir.
1347 This fixes bug projects.maemo.org bug NB#58263 .
1349 * src/modest-tny-account-store.c:
1350 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1351 if there are no server accounts yet, to prevent an infinite loop when there
1352 are no accounts. Document that one must be called before the other.
1354 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1356 * src/modest-account-mgr-helpers.c:
1357 (modest_account_mgr_get_default_account): Make sure that at least
1358 one account is always the default, if there are any enabled accounts.
1359 This is just a sanity check that shouldn't be necessary.
1361 * src/modest-account-mgr-priv.c:
1362 (_modest_account_mgr_account_from_key): Unescape the conf key to
1363 get the real account name. For instance, this is an issue if a space
1364 was in the account name, which can happen because the account name
1365 is generated from the display name.
1366 (_modest_account_mgr_get_account_keyname): Always escape the
1368 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1369 Unescape the conf keys to get the real account names.
1371 For instance, previously the is-default radio button in the accounts
1372 list was not checked for any accounts at first. This fixes that,
1373 and might fix several similar bugs.
1375 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1377 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1378 Removed some debug printfs.
1380 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1382 Modest on-disk outbox directories are now here, for instance:
1383 $HOME/.modest/outboxes/<account-id-1>/outbox
1384 $HOME/.modest/outboxes/<account-id-2>/outbox
1386 $HOME/.modest/local-folders/outbox
1387 so we can have a separate outbox for each account.
1388 But they are shown as one outbox in the GtkTreeView, by using a
1389 TnyMergeFolder in a ModestTnySimpleFolderStore.
1392 * src/modest-tny-simple-folder-store.c:
1393 * src/modest-tny-simple-folder-store.h:
1394 Added ModestTnySimpleFolderStore, used to contain folders from
1395 other folder stores, such as other accounts.
1397 * src/modest-tny-outbox-account.h:
1398 * src/modest-tny-outbox-account.c:
1399 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1400 used for the per-account local outbox folders.
1402 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1403 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1404 only use this (internally) now for the non-outbox local folders.
1406 * src/modest-init.h:
1407 * src/modest-init.c: Added modest_init_one_local_folder(), for
1408 setting up the directory structure for each local folder.
1410 * src/modest-local-folder-info.c:
1411 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1412 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1414 * src/modest-local-folder-info.h:
1415 * src/modest-tny-account-store.c: (on_account_removed),
1416 (on_account_changed), (create_per_account_local_outbox_folders),
1417 (get_server_accounts), (modest_tny_account_store_get_accounts),
1418 (modest_tny_account_store_get_tny_account_by_account),
1419 (modest_tny_folder_store_is_virtual_local_folders):
1421 * src/modest-tny-account.h:
1422 * src/modest-tny-account.c:
1423 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1424 to create an on-disk per-account local outbox folder for each
1426 (create_per_account_local_outbox_folders): Create a local outbox folder
1427 for each transport account.
1428 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1429 for all local folders.
1431 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1432 instead of using g_object_get/set() directly. It is clearer.
1434 (modest_tny_folder_store_get_message_count),
1435 (modest_tny_folder_store_get_local_size
1436 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1437 because we now use these with non-acount folder stores.
1439 (modest_tny_account_get_special_folder),
1440 (modest_tny_account_new_from_server_account),
1441 (modest_tny_account_new_from_account):
1442 (recurse_folders): Adjust to the new outbox system.
1444 * src/modest-tny-folder.h:
1445 * src/modest-tny-folder.c:
1446 (modest_tny_folder_is_local_folder),
1447 (modest_tny_folder_get_local_folder_type),
1448 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1450 * src/widgets/modest-main-window.h:
1451 * src/maemo/modest-main-window.c: (create_details_widget),
1452 (modest_main_window_set_contents_style): Show details for any folder store,
1455 (modest_tny_folder_get_rules):
1456 Remove the const. C does not support constness enough for this.
1458 * src/modest-ui-actions.c:
1459 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1460 make all outboxes appear as one, in the usual local-folders tree node.
1462 (set_active_account_from_tny_account),
1463 (modest_ui_actions_on_folder_selection_changed):
1464 * src/widgets/modest-folder-view.c: (text_cell_data),
1465 (icon_cell_data), (filter_row),
1466 (add_account_folders_to_merged_folder),
1467 (add_account_folders_to_simple_folder_store), (),
1468 (get_cmp_rows_type_pos), (cmp_rows),
1469 (modest_folder_view_set_account_id_of_visible_server_account):
1470 Adjust to the new outbox system, using generic folder stores and folders
1471 in the GtkTreeModel.
1473 2007-05-23 Christian Kellner <ckellner@openismus.com>
1475 * src/modest-mail-operation.c:
1476 (modest_mail_operation_update_account):
1477 Use info->max_size instead of unintialized local var [small
1478 build fix]. (Added TODO to review that change since I don't
1481 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1483 * libmodest-dbus-client/libmodest-dbus-client.c:
1484 (libmodest_dbus_client_compose_mail): function added
1485 * src/dbus_api/modest-dbus-api.h:
1486 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1487 (on_compose_mail): Implementation of the SendAsMail functionality
1489 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1491 * src/modest-account-mgr.c:
1492 (modest_account_mgr_add_server_account): Set the secure-connection
1493 conf key for transport accounts as well as store accounts. I don't know
1494 why the if was there. For instance, this makes sure that we use SSL
1495 for the gmail preset from the easysetup wizard.
1497 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1499 * src/gnome/modest-main-window.c:
1500 (on_account_store_connecting_finished), (connect_signals):
1501 * src/maemo/modest-main-window.c:
1502 (on_account_store_connecting_finished), (connect_signals),
1503 (modest_main_window_new):
1504 Handle TnyAccountStore::connecting-finished instead of
1505 TnyDevice::connection-changed, because we cannot actually perform
1506 operations on accounts until TnyAccountStore has itself responded to
1507 the TnyDevice::connection-changed signal. This prevents a GError from
1509 Do not try to update at startup, because we (at least on scratchbox)
1510 already do an update at startup when the device goes online.
1511 This prevents a GError from tinymail.
1512 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1513 Added TODO about stopping simultaneous operations.
1515 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1517 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1518 * src/modest-mail-operation-queue.c:
1519 (modest_mail_operation_queue_remove):
1520 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1521 about where they happened.
1523 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1525 * src/modest-ui-actions.c:
1526 (modest_ui_actions_on_password_requested): Make sure that the remember
1527 output parameter is always TRUE.
1529 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1531 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1532 Show a OK/Cancel dialog if the error is a question, though we still do not
1533 know anything more about what we are asking the user.
1534 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1535 Fix an uninitialized variable (helper). This is a logic error, however.
1537 2007-05-21 Christian Kellner <ckellner@openismus.com>
1539 * src/modest-search.h:
1540 Correct bit shifting in the ModestSearchFlags enum.
1542 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1544 * src/modest-tny-account.c:
1545 (modest_tny_account_new_from_server_account): Do not use the lsub and
1546 check-all hard-coded IMAP options when using POP.
1548 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1550 * src/modest-tny-account.c:
1551 (modest_tny_account_new_from_server_account):
1552 Use NULL for the secure-auth method for POP when Password auth has been
1553 specified by the user, as we already do for IMAP. "auth=Login" causes
1554 an error from camel or the server.
1556 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1558 * src/maemo/modest-account-settings-dialog.c:
1559 (create_page_account_details),
1560 (modest_account_settings_dialog_set_account_name):
1561 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1562 for the leave-on-server checkbox, rathr than just the checkbox, when
1563 the protocol is not POP.
1565 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1567 * src/widgets/modest-account-view.c:
1568 * src/widgets/modest-account-view.h:
1569 Added modest_account_view_select_account() which will be useful later
1570 to asynchronously re-select the edited account.
1572 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1574 * src/maemo/modest-account-settings-dialog.c:
1575 (modest_account_settings_dialog_set_account_name):
1576 Automatically choose the port numbers based on the secure authentication
1577 methods, if they have not been chosen before.
1578 This fixes projects.maemo.org bug NB#56273 .
1580 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1582 * src/maemo/modest-main-window-ui.h:
1583 * src/modest-ui-actions.c:
1584 * src/modest-ui-actions.h:
1585 Connect the Tools/SMTP Servers menu item to
1586 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1587 SMTP servers dialog, as in the UI specification and saves changes when it
1588 is closed. This fixed projects.maemo.org bug NB#56305 .
1590 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1592 * src/maemo/modest-connection-specific-smtp-window.c:
1593 (modest_connection_specific_smtp_window_init):
1594 Use gtk_window_set_default_size() to make this window big enough, so
1595 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1597 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1599 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1600 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1601 (modest_connection_specific_smtp_edit_window_init),
1602 Do not try to connect to a combobox signal before the combobox exists.
1603 This fixes the cras in projects.maemo.org bug NB#56288 .
1604 (modest_connection_specific_smtp_edit_window_get_settings):
1605 Remove the server_account_name parameter which was being checked for NULL
1606 though it was not used.
1608 * src/maemo/modest-connection-specific-smtp-window.c:
1609 (modest_connection_specific_smtp_window_fill_with_connections),
1610 (on_button_edit), (modest_connection_specific_smtp_window_init):
1611 Correct the number of treemodel columns to prevent a warning.
1612 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1613 libconic does not work.
1615 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1617 * src/modest-tny-account.c:
1618 (modest_tny_account_new_from_server_account):
1619 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1620 SMTP when "None" was chosen by the user. However, with my SMTP server that
1621 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1624 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1626 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1627 to explain the memory management issue with the ID in the ModestPair.
1629 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1630 (add_sending_page), (modest_account_assistant_finalize):
1631 * src/gnome/modest-gnome-global-settings-dialog.c:
1632 (create_updating_page), (create_composing_page):
1633 * src/gnome/modest-msg-edit-window.c: (get_transports),
1634 (init_window), (modest_msg_edit_window_finalize),
1635 (modest_msg_edit_window_get_msg_data):
1636 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1637 * src/gnome/modest-transport-widget.c:
1638 (modest_transport_widget_finalize), (smtp_configuration):
1639 * src/maemo/modest-maemo-global-settings-dialog.c:
1640 (create_updating_page), (create_composing_page):
1641 * src/maemo/modest-msg-edit-window.c: (get_transports),
1642 (init_window), (modest_msg_edit_window_finalize),
1643 (modest_msg_edit_window_get_msg_data),
1644 (modest_msg_edit_window_free_msg_data):
1645 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1646 (modest_store_widget_finalize):
1647 * src/maemo/modest-transport-widget.c:
1648 (modest_transport_widget_finalize), (smtp_configuration):
1649 * src/modest-main.c: (send_mail):
1650 * src/widgets/modest-combo-box.h:
1651 * src/widgets/modest-global-settings-dialog-priv.h:
1652 * src/widgets/modest-global-settings-dialog.c:
1653 (modest_global_settings_dialog_finalize):
1654 * src/widgets/modest-msg-edit-window.h:
1655 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1656 as long as the combo box, to prevent use of freed memory for the ID.
1658 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1660 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1661 get_accounts(), to make this clearer. Do not check for the enabled gconf
1662 key, because we do not use this for server accounts (at least, not yet).
1663 This allows us to send email again.
1665 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1667 * src/maemo/modest-platform.c:
1668 (on_modest_conf_update_interval_changed), (modest_platform_init):
1669 Only respond to this particular key change. All these strcmp()s cannot be
1672 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1674 * src/maemo/modest-maemo-global-settings-dialog.c:
1675 (current_connection): Prevent a crash in scratchbox when
1676 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1677 * src/maemo/modest-platform.c:
1678 (on_modest_conf_update_interval_changed), (modest_platform_init):
1679 Get the update interval from gconf and reset it when the gconf key changes.
1681 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1683 * src/modest-protocol-info.c:
1684 * src/modest-protocol-info.h: Adde enum-specific get functions,
1685 instead of using a ModestProtocolType enum parameter.
1687 * src/gnome/modest-account-assistant.c:
1688 * src/gnome/modest-store-widget.c:
1689 * src/gnome/modest-store-widget.h:
1690 * src/gnome/modest-transport-widget.c:
1691 * src/gnome/modest-transport-widget.h:
1692 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1693 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1694 * src/maemo/easysetup/modest-easysetup-wizard.c:
1695 * src/maemo/modest-account-settings-dialog.c:
1696 * src/maemo/modest-account-settings-dialog.h:
1697 * src/maemo/modest-store-widget.c:
1698 * src/maemo/modest-store-widget.h:
1699 * src/maemo/modest-transport-widget.c:
1700 * src/maemo/modest-transport-widget.h:
1701 * src/modest-account-mgr-helpers.c:
1702 * src/modest-account-mgr-helpers.h:
1703 * src/modest-account-mgr.c:
1704 * src/modest-account-mgr.h:
1705 * src/modest-tny-account.c:
1706 * src/modest-tny-folder.c:
1707 * src/widgets/modest-account-view.c:
1708 * src/widgets/modest-retrieve-combo-box.c:
1709 * src/widgets/modest-retrieve-combo-box.h:
1710 * src/widgets/modest-secureauth-combo-box.c:
1711 * src/widgets/modest-serversecurity-combo-box.c:
1712 * src/widgets/modest-serversecurity-combo-box.h:
1713 * tests/check_account-mgr.c:
1714 Use the specific functions, and use the re-renamed enum values for GNOME too.
1716 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1718 * src/modest-pair.h:
1719 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1720 so we can get the second based on the first.
1722 * src/maemo/modest-account-settings-dialog.h:
1723 * src/maemo/modest-account-settings-dialog.c:
1724 Added get_supported_secure_authentication_methods(), though it is mostly
1725 commented-out for now until the necessary API is committed to tinymail.
1726 (modest_account_settings_dialog_set_account_name),
1727 (save_configuration): Request the supported authentication methods from the
1728 server, so we can choose a working method.
1730 * src/modest-tny-account-store.h:
1731 * src/modest-tny-account-store.c:
1732 (modest_tny_account_store_get_session): Rename from
1733 tny_account_store_get_session().
1735 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1737 * src/modest-protocol-info.h: Split the ModestProtocol enum
1738 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1739 There was no need to have these unrelated values in one enum.
1741 * src/: many files: Adapted to changed enum. This makes the code a bit
1742 clearer, and the compiler could catch some errors.
1744 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1746 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1747 Show the detailed internal camel error message when an error happens
1748 during the configuration, so that our testers can give us more clues.
1749 For instance, in projects.maemo.org bug NB#56910 .
1751 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1753 * src/modest-tny-account.c:
1754 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1755 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1757 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1759 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1760 * src/maemo/modest-account-settings-dialog.c:
1761 (modest_account_settings_dialog_set_account_name),
1762 (save_configuration): For the incoming secure authentication checkbox,
1763 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1764 the UI specification. PLAIN does not seem to be supported for most IMAP
1765 servers anyway, and I am not sure what it would mean.
1766 However, we probably need to discover which of the secure-authentication
1767 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1768 * src/modest-account-mgr-helpers.c:
1769 (modest_account_mgr_get_server_account_data):
1771 * src/modest-tny-account.c:
1772 (modest_tny_account_new_from_server_account):
1773 Use tny_account_set_mech() to set secure-authentication methods,
1774 with some special-casing for IMAP, based on my observations of how
1777 * src/modest-account-mgr-helpers.h:
1778 * src/modest-account-mgr.c:
1779 * src/modest-defs.h: Comment that the URI is only used for local folders.
1781 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1783 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1784 parameter const, just to be neat.
1785 * src/modest-text-utils.c: (modest_text_utils_inline):
1786 End g_strconcat() with NULL, as its documentation says. This is almost
1787 certainly the cause of my crash at startup on the device. Interestingly,
1788 valgrind doesn't tell us about these errors.
1790 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1792 * scripts/build-packages: Added more precise comments about how to use
1793 this script, though I still get this error:
1794 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1795 error building tinymail
1797 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1799 * src/maemo/modest-main-window.c: (on_account_update):
1800 Very slight cleanup, hoping to make it simpler to discover what causes
1801 a crash here sometimes.
1803 * src/modest-tny-account.c:
1804 (modest_tny_account_new_from_server_account): Set the port. Added
1805 comments about the options and a TODO comment because I need to find out
1806 how to specify the secure authentication method.
1808 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1810 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1811 changed CFlags paths form modest to libmodest
1813 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1815 * src/modest-account-mgr-helpers.c:
1816 (modest_account_mgr_get_server_account_data),
1817 (modest_account_mgr_free_server_account_data):
1818 * src/modest-account-mgr-helpers.h:
1819 * src/modest-account-mgr.c:
1820 (modest_account_mgr_add_server_account):
1821 * src/modest-defs.h:
1822 * src/modest-tny-account.c:
1823 (modest_tny_account_new_from_server_account):
1824 Determine the options for tny_camel_account_add_option() here,
1825 based on the settings, rather than storing them directly in gconf.
1827 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1829 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1830 Show a more friendly error dialog now that we expect (from the tinymail
1831 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1833 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1835 * src/maemo/modest-main-window.c: (on_account_update): Check that
1836 account_name is not NULL, to prevent a crash at startup that I am
1837 seeing on the N800. I do wonder why it is NULL.
1839 * src/maemo/easysetup/modest-easysetup-wizard.c:
1840 (create_page_user_details):
1841 * src/maemo/modest-account-settings-dialog.c:
1842 (create_page_user_details), (create_page_outgoing):
1843 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1844 (modest_connection_specific_smtp_edit_window_init):
1845 * src/modest-ui-actions.c:
1846 (modest_ui_actions_on_password_requested):
1847 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1848 might do something useful with the on-screen keyboard.
1850 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1852 * src/maemo/modest-main-window.c: (on_account_update):
1853 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1854 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1856 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1858 * src/modest-tny-account-store.c: (on_account_changed):
1859 Correct the signature of this signal handler.
1861 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1863 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1864 Show a HildonNote instead of a GtkDialog for Maemo.
1866 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1868 * src/widgets/modest-account-view.h:
1869 * src/widgets/modest-account-view.c: (on_account_changed),
1870 (on_account_removed). Added a boolean flag, set/unset by
1871 modest_account_view_block_conf_updates(),
1872 modest_account_view_unblock_conf_updates() to prevent unnecessary
1873 updates, but this is not very useful because the gconf notifications are
1874 so delays (maybe only on Maemo Bora).
1875 So auto-updating is turned off, and these functions do an explicit
1876 update when necessary.
1877 However, something else is still doing too much work when adding/removing
1878 accounts, probably in another part of the application.
1880 * src/maemo/modest-account-view-window.c:
1881 (on_delete_button_clicked), (on_edit_button_clicked),
1882 (on_new_button_clicked): Use the new functions.
1884 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1886 * src/modest-account-mgr-helpers.c:
1887 (modest_account_mgr_set_first_account_as_default):
1888 Sort the list of names alphabetically-by-title, so we choose the first one
1890 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1891 alphabetically by the title.
1893 This fixes projects.maemo.org bug NB#56418 .
1895 * src/modest-account-mgr-priv.c:
1896 (_modest_account_mgr_account_from_key):
1897 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1898 avoid a valgrind error, and possible random behaviour.
1900 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1902 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1903 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1904 tinymail documentation to say that this can be expected.
1905 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1906 pretty, and should not happen, but I would prefer to know when it does.
1908 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1910 * configure.ac: When using the older hildon version, probably on Bora,
1911 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1913 * src/widgets/modest-attachment-view.c:
1914 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1917 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1919 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1920 Implemented the prototype. Can be tested with
1921 tests/dbus_api/test_open_message:
1923 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1925 * src/modest-tny-account-store.c:
1926 (modest_tny_account_store_instance_init), (get_password):
1927 * src/modest-ui-actions.c:
1928 (modest_ui_actions_on_password_requested):
1929 Do not store the password in gconf, because this function is called
1930 for non-remembered passwords. Actually use the cached (in the hash map)
1931 password instead of releasing it.
1932 The password will now not be remembered if it is asked via the protected
1933 password dialog, as per the UI spec.
1935 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1937 * src/modest-defs.h:
1938 * src/modest-account-mgr-helpers.h:
1939 * src/modest-account-mgr-helpers.c:
1940 Added modest_server_account_get_username_has_succeeded(),
1941 modest_server_account_set_username_has_succeeded().
1942 (modest_server_account_set_username),
1943 Reset the has-succeeded flag if the username changes.
1945 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1946 * src/maemo/modest-connection-specific-smtp-window.c:
1947 (modest_connection_specific_smtp_window_save_server_accounts):
1948 Use modest_server_account_set_username() instead of using
1949 modest_conf_set_string() directly, so that the has-succeeded flag is always
1952 * src/modest-ui-actions.c:
1953 (modest_ui_actions_on_password_requested): Dim the username entry if
1954 the username has ever worked, as per the UI spec.
1956 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1958 * src/modest-tny-account-store.c: (get_password):
1959 * src/modest-ui-actions.c:
1960 (modest_ui_actions_on_password_requested):
1961 Allow the username to be changed too, though there is more work to
1962 be done on exactly how this behaves.
1964 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1966 * src/modest-account-mgr-helpers.h:
1967 * src/modest-account-mgr-helpers.c:
1968 Added modest_account_mgr_get_display_name(),
1969 modest_server_account_get_username(),
1970 modest_server_account_set_username(),
1971 modest_server_account_set_password(),
1972 modest_server_account_get_hostname() functions so we do not need to
1973 use the conf API directly.
1975 * src/maemo/modest-main-window.c: (connect_signals):
1976 Actually connect ot the ModestAccountStore::request-password signal,
1977 so that we show the dialog when the password is requested by Tinymail,
1978 for isntance if it is empty.
1980 * src/modest-marshal.list:
1981 * src/modest-tny-account-store.c:
1982 (modest_tny_account_store_class_init), (get_password),
1983 (modest_tny_account_store_alert):
1984 * src/modest-tny-account-store.h:
1985 * src/modest-ui-actions.h:
1986 * src/modest-ui-actions.c:
1987 (modest_ui_actions_on_password_requested):
1988 Change the signal parameters, so it is obvious that we are providing
1989 the non human-readable server name, and receiving both the username
1990 and password, though changing of the username is not yet implemented.
1991 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1992 for the GNOME version.
1994 This should fix the projects.maemo.org bug NB#56209, though it does not
1995 work on Bora, because the gconf_client_get() for the password fails
1996 immediately after we save it with gconf_client_set().
1998 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2001 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2002 caused an undefined symbol error:
2003 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2005 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2007 * src/modest-tny-account-store.c:
2008 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2009 using a GError instead of a string message, so we can translate it in
2012 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2014 * src/maemo/modest-address-book.c:
2015 (modest_address_book_check_names):
2016 * src/maemo/modest-msg-view-window.c:
2017 (modest_msg_view_window_clipboard_owner_change):
2018 * src/modest-init.c: (modest_init_init_ui):
2019 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2020 (update_folders_cb), (modest_mail_operation_update_account):
2021 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2022 (modest_ui_actions_on_msg_attachment_clicked),
2023 (modest_ui_actions_on_msg_recpt_activated):
2024 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2025 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2026 (modest_msg_view_search_next):
2027 * src/widgets/modest-recpt-editor.c:
2028 (modest_recpt_editor_on_button_release_event),
2029 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2030 g_message(). At this point we should only be seeing interesting errors on
2031 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2033 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2035 (modest_wizard_dialog_force_title_update):
2036 * src/maemo/easysetup/modest-wizard-dialog.h:
2037 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2038 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2039 can update the title when appropriate. Otherwise the title is wrong if the
2040 pages are added after adding the notebook to the dialog.
2041 This must be a problem in HildonWizardDialog too.
2042 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2044 * src/maemo/easysetup/modest-easysetup-wizard.c:
2045 (create_subsequent_customsetup_pages),
2046 (create_subsequent_easysetup_pages):
2047 Call modest_wizard_dialog_force_title_update() so that the title is
2048 correct even with GTK+ < 2.10.
2049 This fixes projects.maemo.org bug NB#56145 .
2051 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2053 * src/maemo/modest-platform.c:
2054 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2055 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2058 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2060 * src/widgets/modest-window.h:
2061 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2062 and modest_window_save_state(), which invokes it.
2064 * src/widgets/modest-window-mgr.h:
2065 * src/widgets/modest-window-mgr.c:
2066 Added modest_window_mgr_save_state_for_all_windows(), which calls
2067 the save_state vfunc on all registered windows, if implemented.
2069 * src/gnome/modest-msg-edit-window.c:
2070 * src/gnome/modest-msg-view-window.c:
2071 * src/maemo/modest-msg-edit-window.c:
2072 * src/maemo/modest-msg-view-window.c:
2073 * src/maemo/modest-main-window.c:
2074 Specify the existing save_settings functions as implementations of
2075 ModestWindow::save_state_func().
2077 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2078 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2079 enabling hibernation, for instance.
2081 We may need to do the same thing for restoring settings.
2084 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2086 * src/widgets/modest-window-mgr.c:
2087 * src/widgets/modest-window-mgr.h:
2088 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2089 modest_window_mgr_get_hibernation_is_prevented().
2091 * src/maemo/modest-main-window.c:
2092 (on_hildon_program_is_topmost_notify): Prevent hibernation
2093 (possible when the application goes to the background in the WM),
2094 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2096 * src/maemo/easysetup/modest-easysetup-wizard.c:
2097 (modest_easysetup_wizard_dialog_init):
2098 * src/maemo/modest-account-settings-dialog.c:
2099 (modest_account_settings_dialog_init):
2100 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2101 (modest_connection_specific_smtp_edit_window_init):
2102 * src/maemo/modest-connection-specific-smtp-window.c:
2103 (modest_connection_specific_smtp_window_init):
2104 * src/maemo/modest-signature-editor-dialog.c:
2105 (modest_signature_editor_dialog_init):
2106 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2107 prevent hibernation while any of these account settings dialogs are open.
2109 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2111 * src/maemo/Makefile.am:
2112 * src/maemo/modest-osso-state-saving.c:
2113 * src/maemo/modest-osso-state-saving.h: Added
2114 modest_osso_load_state() and modest_osso_save_state() though they do
2115 nothing now. They should iterate through all the open windows and load/save
2117 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2118 save state when closing.
2120 * src/maemo/modest-main-window.c:
2121 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2122 Add a notification handler for the HildonProgram::is-topmost property,
2123 so we can allow hibernation when the application goes into the background.
2124 But we still need to detect when the accounts setup windows are open so
2125 we can stop hibernation when they are open.
2126 To do this, I also added the main window the HildonProgram. This might have
2127 other side-effects/benefits, and should maybe be done for other windows.
2129 * src/maemo/modest-osso-autosave-callbacks.h:
2130 * src/maemo/modest-osso-autosave-callbacks.c:
2131 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2132 though it does not do anything yet, and we might never need this to do
2133 anything. For instance, we already save drafts.
2135 * src/maemo/modest-platform.c: (modest_platform_init):
2136 Specify the libosso auto-save callback.
2138 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2140 * src/maemo/modest-platform.c:
2141 (modest_platform_set_update_interval):
2142 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2143 aparently stays valid between application instances, so we can use this
2144 to remove and reset it later. According to a maemo-developers email from
2147 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2149 * configure.ac: Depend on libalarm for Maemo.
2151 * src/dbus_api/modest-dbus-api.h:
2152 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2153 (on_send_receive), (modest_dbus_req_handler):
2154 Handle a SEND_RECEIVE D-Bus method.
2156 * libmodest-dbus-client/libmodest-dbus-client.c:
2157 (libmodest_dbus_client_send_and_receive):
2158 * libmodest-dbus-client/libmodest-dbus-client.h:
2159 Add C convenience functions for calling the new D-Bus method.
2161 * src/modest-platform.h:
2162 * src/gnome/modest-platform.c:
2163 * src/maemo/modest-platform.c:
2164 Added modest_platform_set_update_interval(), which uses the
2165 alarmd API on Maemo.
2166 (modest_platform_init),
2167 Call modest_platform_set_update_interval(), using a hard-coded
2168 interval for now (until the global settings dialog is implemented),
2169 though I am not sure that this makes sense yet.
2171 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2173 * src/dbus_api/modest-dbus-callbacks.c:
2174 (modest_osso_cb_hw_state_handler):
2175 * src/dbus_api/modest-dbus-callbacks.h:
2176 * src/maemo/modest-platform.c: (modest_platform_init):
2177 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2178 in case this has some effect on the ability for Maemo to ping the
2181 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2183 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2184 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2185 warning. It is probably a logic error, but I need to fix the build.
2187 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2189 * src/modest-account-mgr.h:
2190 * src/modest-account-mgr.c:
2191 (modest_account_mgr_account_names): Add a gboolean enabled_only
2192 parameter, so we can get lists of onlt the enabled accounts.
2194 (modest_account_mgr_add_account),,
2195 (modest_account_mgr_account_with_display_name_exists):
2196 * src/maemo/modest-msg-edit-window.c: (get_transports):
2197 * src/modest-account-mgr-helpers.c:
2198 (modest_account_mgr_set_first_account_as_default):
2199 * src/modest-init.c: (init_default_account_maybe):
2200 * src/modest-tny-account-store.c: (get_accounts):
2201 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2202 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2203 * tests/check_account-mgr.c: (START_TEST):
2204 Provide the extra parameter, as appropriate.
2206 * src/widgets/modest-account-view.c: (update_account_view):
2207 Do not show disabled accounts (meaning that there is no way to
2208 enable/disable accounts in the UI (the feature is not in our UI
2209 specification), so we can use this internally only to mark unfinished
2210 or temporary account data.
2212 * src/maemo/easysetup/modest-easysetup-wizard.c:
2213 (create_account): Add boolean enable parameter, so we can specify FALSE
2214 to create the temporary account.
2215 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2216 (on_before_next): When finishing, when there is a temporary account, just
2218 Also, use a timeout to delay the showing of the dialog until gconf is likely
2219 to return correct information, due to a maemo gconf bug that is fixed in
2220 osso 1.1, but not yet in Bora.
2221 However, the dialog stays on screen after it is destroyed.
2223 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2224 for invalid data when cancelling. Use a hildon note instead of a dialog
2225 to complain about invalid data. Do not show the account-saved note if the
2226 account is disabled (a temporary account that will not really be saved for use
2229 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2231 * src/modest-account-mgr-helpers.h:
2232 * src/modest-account-mgr-helpers.c:
2233 Added modest_account_mgr_unset_default_account(),
2234 Added modest_account_mgr_set_first_account_as_default().
2236 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2237 If it was the default account, unset the default account name.
2239 * src/maemo/modest-account-view-window.c:
2240 (on_delete_button_clicked): If it was the default account,
2241 set the first remaining account as the default instead.
2243 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2244 a NULL account or a NULL default account, to prevent a crash. This should
2245 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2248 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2250 * src/widgets/modest-recpt-editor.c:
2251 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2252 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2253 TODO comment for this. This fixes the build.
2255 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2256 be the best place for it. This will in future update all auto-update accounts,
2257 rather than just the current/default account, when that gconf key exists.
2258 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2259 if there are no accounts, before calling do_send_receive().
2260 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2262 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2263 * src/maemo/modest-main-window-ui.h:
2264 * src/maemo/modest-main-window.c: (on_connection_changed),
2265 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2266 directly, becaue the signal handler does more.
2268 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2270 * src/modest-account-mgr-helpers.c:
2271 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2272 for the case that the account does not exist.
2274 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2275 (equivalent to the modest account name) rather than the tinymail account name
2276 (equivalent to the modest account title - human readable) to get the account data.
2277 Check for null account data to prevent the crash, and add a TODO comment saying that
2278 this needs fixing because it is using the server account name instead of the account name.
2280 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2282 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2283 * src/maemo/modest-account-settings-dialog.c: (show_error),
2285 Use hildon_note_new_information() for informative and error messages,
2286 which seems to be expected for Maemo applications (no documentation that I know of
2287 says this). I am surprised that there is no distinction between info and error
2290 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2292 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2293 it is easy to find where this is used.
2295 * src/maemo/easysetup/modest-easysetup-wizard.c:
2296 (create_page_welcome), (create_page_account_details),
2297 (create_page_user_details), (create_page_complete_easysetup),
2298 (create_page_custom_incoming), (create_page_custom_outgoing),
2299 (create_page_complete_custom):
2300 * src/maemo/modest-account-settings-dialog.c:
2301 (create_page_account_details), (create_page_user_details),
2302 (create_page_incoming), (create_page_outgoing):
2303 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2304 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2305 (modest_connection_specific_smtp_edit_window_init):
2306 * src/maemo/modest-connection-specific-smtp-window.c:
2307 (modest_connection_specific_smtp_window_init):
2308 * src/maemo/modest-signature-editor-dialog.c:
2309 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2310 and scrolling policy as per the Email Application Layout Guide, if I have
2313 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2315 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2316 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2317 which were empty, because these vfuncs have been removed from TnyAccountStore.
2318 This fixes the build.
2320 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2322 * src/maemo/modest-main-window.c:
2323 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2324 showing/hiding it. Added TODO because it probably should not be NULL.
2325 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2326 because unnecessary g_warnings() make degugging difficult.
2328 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2330 * src/maemo/modest-msg-edit-window.c:
2331 (modest_msg_edit_window_select_color),
2332 (modest_msg_edit_window_select_background_color): 2 const corrections and
2333 moving 2 #endifs before closing brackets, to fix the build.
2335 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2337 * src/maemo/easysetup/modest-easysetup-wizard.h:
2338 * src/maemo/easysetup/modest-easysetup-wizard.c:
2339 (modest_easysetup_wizard_dialog_finalize),
2340 (on_button_edit_advanced_settings), (create_page_complete_custom),
2341 (on_response), (create_account):
2342 Implement the Advanced Settings edit button, by saving the account information,
2343 for the Advanded Settings dialog to use directly from gconf, and removing it
2344 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2345 Bug #5533 in the projects.maemo.org bugzilla.
2347 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2349 * src/maemo/modest-msg-view-window.c:
2350 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2351 when opening a message window.
2353 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2355 * src/maemo/easysetup/modest-easysetup-wizard.c:
2356 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2359 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2360 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2361 gconf settings. I probably added more checks than necessary, but that is safer.
2363 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2364 variable to fix the build, but this seems to be used when it is still NULL.
2366 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2368 * src/modest-platform.h:
2369 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2370 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2371 * src/modest-main.c: Implement this function so we can avoid using
2372 maemo-specific API from cross-platform code.
2374 * src/modest-tny-account-store.c:
2375 (get_smtp_specific_transport_account_for_open_connection):
2376 * src/modest-ui-actions.c: (check_for_connection),
2377 (modest_ui_actions_on_item_not_found):
2378 Use modest_platform_connect_and_wait() and put #idefs around other
2379 maemo-specific code, because only maemo currently has a way to
2380 identify connection names.
2382 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2384 * src/modest-tny-account-store.h:
2385 * src/modest-tny-account-store.c:
2386 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2387 the connection-specific SMTP server settings in the configuration.
2389 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2391 * src/maemo/modest-main-window.c: (on_connection_changed),
2393 * src/modest-main.c: (main), (start_ui), (send_mail):
2394 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2395 that is what is intended.
2397 * src/modest-ui-actions.c: (action_send), (action_receive),
2398 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2399 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2400 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2401 SMTP server is used when it is specified.
2403 (modest_ui_actions_on_send_receive):
2404 Check that a connection is open before proceeding.
2405 Receive and then send, instead of vice-versa, as per the specification.
2407 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2409 * src/modest-mail-operation.c:
2410 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2411 though I guess it should be something other than NULL.
2413 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2415 * src/maemo/easysetup/modest-easysetup-wizard.c:
2416 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2417 combo twice, to avoid an g_warning and to make it visible again.
2418 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2419 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2420 (already intended) dereference when detaching, because we then recreate the menu.
2421 But I am not sure why the warning was happening, and it is possible that this is a memory
2424 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2426 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2427 and uri_parse_mailto() utility functions.
2428 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2430 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2432 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2434 * src/dbus_api/modest-dbus-api.h:
2435 * src/dbus_api/modest-dbus-callbacks.c:
2436 Use an idle callback to execute the modest code in the application's own thread.
2437 Remove the helloworld example method.
2438 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2439 parsed, and the open-message method is not implemented because this is not yet implemented in
2441 * libmodest-dbus-client/libmodest-dbus-client.c:
2442 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2443 (libmodest_dbus_client_open_message):
2444 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2446 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2447 body without crashing.
2449 * tests/dbus_api/Makefile.am:
2450 * tests/dbus_api/test_mail_to.c:
2451 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2453 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2455 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2456 Added file to fix the build. Sorry.
2458 * src/dbus_api/Makefile.am:
2459 * src/dbus_api/modest-dbus-api.h:
2460 * src/dbus_api/modest-dbus-callbacks.h:
2461 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2462 (modest_dbus_req_handler):
2463 Put constants in a separate header so it can be reused by the
2464 client library, without duplication
2466 * libmodest-dbus-client/Makefile.am:
2467 * libmodest-dbus-client/libmodest-dbus-client.c:
2468 (libmodest_dbus_client_call_helloworld),
2469 (libmodfest_dbus_client_send_mail),
2470 (libmodfest_dbus_client_mailto),
2471 (libmodfest_dbus_client_open_message):
2472 * libmodest-dbus-client/libmodest-dbus-client.h:
2473 (Partly) Implement a send_mail D-Bus method.
2475 * tests/dbus_api/Makefile.am:
2476 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2477 the send_email D-Bus method.
2479 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2483 * libmodest-dbus-client/Makefile.am:
2484 * libmodest-dbus-client/libmodest-dbus-client.c:
2485 * libmodest-dbus-client/libmodest-dbus-client.h:
2486 * tests/dbus_api/Makefile.am:
2487 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2488 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2490 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2492 * src/maemo/easysetup/modest-easysetup-wizard.c:
2493 (create_page_account_details):
2494 * src/maemo/modest-account-settings-dialog.c:
2495 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2496 widgets, because this might not be the default in future versions of the Maemo GTK+.
2497 However, I can not not get capitalization to work even in a simple test case.
2499 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2501 * src/maemo/easysetup/modest-easysetup-wizard.c:
2502 (create_page_custom_incoming), (create_page_custom_outgoing):
2503 * src/maemo/modest-account-settings-dialog.c:
2504 (create_page_account_details), (create_page_incoming),
2505 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2506 instead of using gtk_check_button_with_label(), so they are aligned like the other
2507 widgets, as per the UI spec.
2509 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2511 * src/maemo/easysetup/modest-easysetup-wizard.c:
2512 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2513 * src/widgets/modest-validating-entry.c:
2514 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2515 Modest prefix instead of an EasySetup prefix.
2517 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2519 * src/widgets/modest-validating-entry.h:
2520 * src/widgets/modest-validating-entry.c: (on_insert_text),
2521 Added easysetup_validating_entry_set_max_func(), used to set a callback
2522 to call when the max number of characters is reached. GtkEntry has a max-length
2523 already but is silent about it.
2525 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2526 (create_page_account_details), (create_page_user_details),
2528 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2529 (create_page_account_details), (create_page_user_details),
2530 (create_page_outgoing):
2531 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2532 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2533 the UI spec, when the user tries to enter more than the max number of characters.
2535 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2537 * src/maemo/easysetup/modest-easysetup-wizard.c:
2538 (create_page_user_details), (create_page_custom_incoming),
2539 (create_page_custom_outgoing):
2540 * src/maemo/modest-account-settings-dialog.c:
2541 (create_page_user_details), (create_page_incoming),
2542 (create_page_outgoing):
2543 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2544 (modest_connection_specific_smtp_edit_window_init):
2545 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2546 not appropriate. Bad Maemo-specific defaults!.
2548 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2550 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2551 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2552 (modest_signature_editor_dialog_set_settings):
2553 Disable the label and textview when the checkbox is disabled, and use the
2554 specified (UI spec) default signature text.
2556 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2558 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2559 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2561 * src/modest-defs.h:
2562 * src/modest-account-mgr-helpers.h:
2563 * src/modest-account-mgr-helpers.c:
2564 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2566 * src/maemo/Makefile.am:
2567 * src/maemo/modest-signature-editor-dialog.c:
2568 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2571 * src/maemo/modest-account-settings-dialog.h:
2572 * src/maemo/modest-account-settings-dialog.c:
2573 (modest_account_settings_dialog_finalize), (on_button_signature),
2574 (save_configuration): Use the new dialog when the Edit button is pressed, and
2575 save the changes if necessary, as per the UI spec.
2577 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2579 * src/maemo/Makefile.am:
2580 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2581 based on maemo-develoers email from Dirk.
2583 * src/maemo/easysetup/modest-easysetup-wizard.c:
2584 (create_page_welcome), (create_page_account_details),
2585 (create_page_user_details), (create_page_complete_easysetup),
2586 (create_page_custom_incoming), (create_page_custom_outgoing),
2587 (create_page_complete_custom),
2588 (modest_easysetup_wizard_dialog_init):
2589 * src/maemo/modest-account-settings-dialog.c:
2590 (create_page_account_details), (create_page_user_details),
2591 (create_page_incoming), (create_page_outgoing),
2592 (modest_account_settings_dialog_init):
2593 * src/maemo/modest-connection-specific-smtp-window.c:
2594 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2596 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2598 * src/maemo/easysetup/modest-easysetup-wizard.c:
2599 (create_page_account_details), (create_page_custom_outgoing),
2600 (create_page_complete_custom):
2601 * src/maemo/modest-account-settings-dialog.c:
2602 (create_page_user_details), (create_page_incoming),
2603 (create_page_outgoing):
2604 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2605 (modest_connection_specific_smtp_edit_window_init):
2606 Use the correct (UI spec) port min/max, and use horizontal separators,
2609 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2611 * src/maemo/easysetup/modest-easysetup-wizard.c:
2612 (set_default_custom_servernames):
2613 * src/maemo/modest-account-settings-dialog.c:
2614 (create_page_incoming), (on_combo_outgoing_security_changed),
2615 (on_combo_incoming_security_changed), (create_page_outgoing),
2616 (modest_account_settings_dialog_set_account_name),
2617 (save_configuration):
2618 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2619 (on_combo_security_changed),
2620 (modest_connection_specific_smtp_edit_window_init),
2621 (modest_connection_specific_smtp_edit_window_set_connection),
2622 (modest_connection_specific_smtp_edit_window_get_settings):
2623 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2626 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2629 * src/maemo/easysetup/modest-easysetup-wizard.c:
2630 (create_page_custom_outgoing), (create_page_complete_custom):
2631 * src/maemo/modest-account-settings-dialog.c:
2632 (create_page_user_details), (create_page_outgoing):
2633 * src/maemo/modest-account-view-window.c: (button_box_new):
2634 Use changed logical IDs as per the most recent UI spec:
2635 mcen_bd_emailsetup_edit -> mcen_bd_edit
2636 mcen_bd_emailsetup_delete -> mcen_bd_delete
2637 mcen_bd_emailsetup_close -> mcen_bd_close
2639 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2643 * src/dbus_api/Makefile.am:
2644 * src/dbus_api/modest-dbus-callbacks.c:
2645 * src/dbus_api/modest-dbus-callbacks.h:
2646 * src/maemo/modest-platform.c: (modest_platform_init):
2647 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2649 * tests/Makefile.am:
2650 * tests/dbus_api/Makefile.am:
2651 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2653 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2655 * src/maemo/modest-account-settings-dialog.c:
2656 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2657 Removed unnecessary includes.
2659 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2661 * src/maemo/easysetup/modest-easysetup-wizard.c:
2662 * src/maemo/modest-account-settings-dialog.c:
2663 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2664 * src/widgets/Makefile.am:
2665 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2666 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2667 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2668 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2669 * src/widgets/modest-secureauth-combo-box.c:
2670 * src/widgets/modest-secureauth-combo-box.h:
2671 * src/widgets/modest-serversecurity-combo-box.c:
2672 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2673 made the GObject names more consistent with the rest of the Modest code.
2675 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2677 * src/maemo/easysetup/Makefile.am:
2678 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2679 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2680 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2681 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2682 * src/maemo/easysetup/modest-easysetup-wizard.c:
2683 * src/maemo/easysetup/modest-validating-entry.c:
2684 * src/maemo/easysetup/modest-validating-entry.h:
2685 * src/maemo/modest-account-settings-dialog.c:
2686 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2687 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2688 widgets/ because they are used outside of easysetup too. After checking in,
2689 svn will allow me to rename them too.
2691 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2693 * src/gnome/modest-msg-edit-window.c:
2694 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2695 linker error, to fix the build on the GNOME platform.
2696 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2697 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2698 ifdefed out to avoid a warning.
2700 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2702 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2703 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2704 some alternative for GTK+ 2.6.
2706 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2708 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2710 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2711 specified for EmailAccountsDialog in UI spec.
2713 * src/maemo/easysetup/modest-easysetup-wizard.c:
2714 * src/maemo/easysetup/modest-easysetup-wizard.h:
2715 * src/maemo/modest-account-settings-dialog.c:
2716 * src/maemo/modest-account-settings-dialog.h:
2717 Reuse a member window widget for the connection-specific SMTP server accounts,
2718 so we can tell it to create/save the accounts only if we actually save changes.
2720 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2721 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2722 (modest_connection_specific_smtp_edit_window_get_settings):
2723 Return a struct instance for temporarily remembering the entered data.
2725 * src/maemo/modest-connection-specific-smtp-window.h:
2726 * src/maemo/modest-connection-specific-smtp-window.c:
2727 (modest_connection_specific_smtp_window_finalize),
2728 (modest_connection_specific_smtp_window_fill_with_connections),
2730 (modest_connection_specific_smtp_window_save_server_accounts),
2731 (update_model_server_names): Do not actually save data until asked,
2732 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2734 (on_selection_changed),
2735 (modest_connection_specific_smtp_window_init): Disable the edit
2736 button when nothing is selected.
2738 * src/modest-account-mgr-helpers.c:
2739 * src/modest-account-mgr-helpers.h:
2740 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2743 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2745 * src/modest-account-mgr-helpers.h:
2746 * src/modest-account-mgr-helpers.c:
2747 (modest_account_mgr_get_unused_account_name),
2748 (modest_account_mgr_get_unused_account_display_name): Added these
2749 utility functions, to avoid code duplication.
2751 * src/maemo/easysetup/modest-easysetup-wizard.c:
2752 (create_page_account_details), (create_account):
2753 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2754 (on_combo_security_changed),
2755 (modest_connection_specific_smtp_edit_window_init),
2756 (modest_connection_specific_smtp_edit_window_save_settings):
2757 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2758 * src/maemo/modest-connection-specific-smtp-window.c:
2759 (modest_connection_specific_smtp_window_finalize),
2760 (modest_connection_specific_smtp_window_fill_with_connections),
2761 (on_button_edit), (modest_connection_specific_smtp_window_init):
2762 * src/maemo/modest-connection-specific-smtp-window.h:
2763 Implementing saving of connection-specific server accounts.
2765 But I need to refactor this so we can save the data for each
2766 possible connection-specific account and only actually create the server accounts
2767 when the easysetup finished, or the OK button is pressed on the account settings
2770 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2772 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2773 (on_combo_security_changed):
2774 (modest_connection_specific_smtp_edit_window_init):
2775 Auto-fill the port number as in the account settings.
2777 (modest_connection_specific_smtp_edit_window_set_connection):
2778 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2779 * src/maemo/modest-connection-specific-smtp-window.c:
2780 (fill_with_connections), (on_button_edit),
2781 (modest_connection_specific_smtp_window_init):
2782 Turn the edit window into a dialog to simplify the code, and
2783 set a WM hint as in a GtkDialog, because only a popup can be on top of
2784 another window in Maemo, and popups usually have no WM decoration.
2786 * src/modest-defs.h:
2787 * src/modest-account-mgr-helpers.c:
2788 (modest_account_mgr_set_connection_specific_smtp),
2789 (modest_account_mgr_remove_connection_specific_smtp),
2790 (modest_account_mgr_get_connection_specific_smtp):
2791 * src/modest-account-mgr-helpers.h: Some functions to write the
2792 connection-specific SMTP server information. Not yet used.
2795 * src/widgets/modest-folder-view.c: (text_cell_data):
2796 Fix a warning about an uninitialized variable.
2797 (on_configuration_key_changed): Put an #ifdef around the use
2798 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2800 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2802 * src/maemo/modest-account-settings-dialog.h:
2803 * src/maemo/modest-account-settings-dialog.c:
2804 Added connect_for_modified() utility function to mark the new modified boolean.
2806 (create_page_account_details), (create_page_user_details),
2807 (create_page_incoming), (create_page_outgoing), (on_response),
2808 (modest_account_settings_dialog_init),
2809 (modest_account_settings_dialog_set_account_name):
2810 Only warn about unsaved changes when there are actually unsaved changes.
2812 * src/modest-account-mgr-helpers.c:
2813 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2814 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2815 to get the data from there in future.
2817 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2819 * src/modest-defs.h:
2821 * src/modest-account-mgr-helpers.h:
2822 * src/modest-account-mgr-helpers.c:
2823 Store the security account setting in a single conf key instead of using
2824 the options list, so that the list is left for just the to-be-removed camel hack,
2825 and because gconf_client_set_list() is failing for some reason.
2827 * src/modest-account-mgr.c:
2828 (modest_account_mgr_add_server_account):
2829 * src/maemo/modest-account-settings-dialog.c:
2830 (modest_account_settings_dialog_set_account_name),
2831 (save_configuration): Use the renamed functions.
2834 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2836 * src/widgets/Makefile.am:
2837 * src/widgets/modest-limit-retrieve-combo-box.c:
2838 * src/widgets/modest-limit-retrieve-combo-box.h:
2839 * src/widgets/modest-retrieve-combo-box.c:
2840 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2841 the account settings dialog.
2843 * src/modest-defs.h:
2844 * src/modest-account-mgr-helpers.h:
2845 * src/modest-account-mgr-helpers.c:
2846 (modest_server_account_get_option_secure_auth),
2847 (modest_server_account_set_option_secure_auth):
2848 * src/modest-account-mgr.c:
2849 (modest_account_mgr_add_server_account):
2850 Use the existing AUTH_MECH conf key for the secure-auth setting,
2851 instead of putting it in the list options, because this was actually used already.
2853 * src/maemo/modest-account-settings-dialog.c:
2854 (create_page_account_details),
2855 (modest_account_settings_dialog_set_account_name),
2856 (save_configuration):
2857 * src/maemo/modest-account-settings-dialog.h:
2858 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2859 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2861 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2863 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2864 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2865 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2867 * src/modest-defs.h:
2868 * src/maemo/modest-account-settings-dialog.c:
2869 (create_page_incoming), (on_combo_outgoing_security_changed),
2870 (on_combo_incoming_security_changed), (create_page_outgoing),
2871 (modest_account_settings_dialog_set_account_name),
2872 (save_configuration): Load/Save the port number, and change it when the
2873 security combo changes, to suitable defaults.
2875 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2877 * src/modest-account-mgr.c:
2878 (modest_account_mgr_add_server_account): Set the security and secure-auth
2879 options, and add a comment saying that the other camel-specific options should be
2882 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2884 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2886 * src/modest-tny-account-store.c: (account_list_free),
2887 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2888 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2891 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2893 * src/modest-protocol-info.c:
2894 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2895 is required by our UI spec. Maybe something in our implementation will use this eventually.
2896 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2897 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2898 instead of the previous 0 placeholder.
2900 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2901 secure-auth settings.
2902 * src/modest-account-mgr-helpers.h:
2903 * src/modest-account-mgr-helpers.c:
2904 (modest_server_account_data_get_option_secure_auth),
2905 (modest_server_account_set_option_secure_auth),
2906 (modest_server_account_data_get_option_security),
2907 (modest_server_account_set_option_security): Added this API for getting and setting the security
2908 and secure-auth settings.
2910 * src/maemo/modest-account-settings-dialog.h:
2911 * src/maemo/modest-account-settings-dialog.c:
2912 (modest_account_settings_dialog_finalize), (check_data),
2913 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2914 about changing titles.
2915 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2916 (save_configuration): Save the security and secure-auth settings.
2918 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2919 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2921 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2923 * src/modest-defs.h:
2924 * src/modest-account-mgr.c:
2925 (modest_account_mgr_add_server_account):
2926 Added and used defines for the options key and value pair strings,
2927 that are used so far, though they do not seem to correspond to anything in our
2928 UI specs or ModestProtocol enum.
2930 * src/modest-account-mgr-helpers.h:
2931 * src/modest-account-mgr-helpers.c:
2932 (compare_option_strings_for_name),
2933 (modest_server_account_data_get_option_value),
2934 (modest_server_account_data_get_option_bool),
2935 (modest_account_mgr_get_server_account_option):
2936 Added helper functions for parsing the options GSList.
2938 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2940 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2941 display name is based on the supplied account name.
2942 * src/modest-account-mgr.c:
2943 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2944 with an inefficient, but good-enough, implementation.
2946 * src/maemo/easysetup/modest-easysetup-wizard.c:
2947 (create_page_account_details), (on_before_next), (create_account):
2948 Check for existing display names rather than (non-user-visible) account names, and just
2949 create and set a unique account name at the end.
2951 * src/maemo/modest-account-settings-dialog.c:
2952 (modest_account_settings_dialog_init),
2953 (modest_account_settings_dialog_set_account_name),
2954 (create_page_incoming): Show the display name, instead of the account name.
2955 (on_response): Do some (not all) extra checks, as in the UI spec.
2956 (save_configuration): Save the display name if it was changed.
2958 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2960 * po/en_GB.po: Added needed logical ID and translation.
2961 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2962 (init_view): Made the is-default column clicking work.
2964 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/easysetup/Makefile.am:
2968 * src/maemo/easysetup/modest-easysetup-wizard.c:
2969 (modest_easysetup_wizard_dialog_init):
2970 * src/maemo/easysetup/provider-data-test.keyfile:
2971 * src/maemo/easysetup/provider-data.keyfile:
2972 Moved the provider data file to the new modest-providers-data package and used it from there.
2974 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2976 * src/modest-local-folder-info.c:
2977 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2978 N_() was already used on the static strings, but this just marks it for translation without
2979 using the translation.
2981 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2983 * src/maemo/modest-account-settings-dialog.c:
2984 (create_page_incoming),
2985 (modest_account_settings_dialog_set_account_name):
2986 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2987 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2988 I will do this if nobody else gets there first.
2990 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2992 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2993 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2994 save the security stuff.
2996 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2998 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2999 Set the email address and user fullname, which I now see must be
3002 * src/maemo/modest-account-settings-dialog.h:
3003 * src/maemo/modest-account-settings-dialog.c:
3005 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3006 leave-on-server and authentication.
3007 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3010 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3013 * src/maemo/modest-account-settings-dialog.c:
3014 * src/maemo/modest-account-settings-dialog.h:
3015 Most (but not all) of the widgets are now present as specified by the UI spec.
3016 No changes are yet saved, and some details are not properly shown yet.
3018 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3020 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3022 * src/maemo/Makefile.am:
3023 * src/maemo/modest-account-settings-dialog.c:
3024 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3025 an existing account. Doesn't do much yet.
3027 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3028 Open the accounts settings dialog when Edit is clicked.
3030 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3032 * src/maemo/easysetup/Makefile.am:
3033 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3035 * src/maemo/easysetup/modest-easysetup-wizard.c:
3036 (modest_easysetup_wizard_dialog_init):
3037 Try to get the source directory from the build system,
3038 instead of hard-coding "./" into the source code, when opening our local
3039 copies of the configuration files.
3040 But this still fails when opening the wizard from the Accounts window,
3041 maybe because the working directory seems to change at runtime.
3042 So the wizard will fail the second time unless you copy the files into their
3043 proper locations - see the stdout warnings for the paths.
3045 (create_page_account_details),(on_before_next):
3046 Check for existing non-server accounts instead of server accounts,
3047 so the default account name is useful again, and to prevent trying to
3050 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3051 Show the wizard when New is clicked.
3053 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3054 (init_view): Show the column headers, and show the columns that are
3055 specified in the UI specs. However, something in Maemo's GTK+ prevents
3056 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3057 change the default account. This is despite unsetting the special properties.
3059 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3061 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3062 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3063 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3064 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3065 to make that clearer.
3066 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3068 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3070 * src/maemo/modest-account-view-window.c:
3071 (modest_account_view_window_init),
3072 (modest_account_view_window_new):
3073 Use the same buttons as specified in the
3074 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3075 the existing widgets, which never had a chance of working.
3076 Put the ModestAccountView treeview in a scrolled window.
3077 Do not repeat the initialization in both _init() and _new().
3079 * src/widgets/modest-account-view.c: (update_account_view):
3080 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3081 this widget and window shows no accounts.
3083 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3085 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3087 * src/maemo/easysetup/modest-easysetup-wizard.c:
3088 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3089 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3090 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3093 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3094 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3095 accounts exist yet, as in the UI spec.
3097 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3099 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3101 * src/maemo/Makefile.am:
3102 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3103 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3104 New window for editing connection-specific smtp details.
3105 Not fully implemented.
3107 * src/maemo/modest-connection-specific-smtp-window.c:
3108 (modest_connection_specific_smtp_window_finalize) :
3109 unref the tree model.
3110 (on_button_edit): Show the edit window.
3112 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3114 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3117 * src/maemo/Makefile.am:
3118 * src/maemo/modest-connection-specific-smtp-window.c:
3119 * src/maemo/modest-connection-specific-smtp-window.h:
3120 New window for showing the list of connections, for connection-specific
3121 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3122 * src/maemo/easysetup/modest-easysetup-wizard.c:
3123 (create_page_custom_outgoing): Show the new window when the button is clicked.
3125 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3127 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3128 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3129 * src/maemo/modest-msg-edit-window.c:
3130 (modest_msg_edit_window_insert_image):
3131 * src/modest-conf.c: (modest_conf_key_escape):
3132 * src/modest-mail-operation.c:
3133 (modest_mail_operation_send_new_mail):
3134 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3135 (modest_ui_actions_on_new_account):
3136 * src/widgets/modest-attachment-view.c: (update_filename_request):
3137 * src/widgets/modest-mail-header-view.c:
3138 Corrected warnings that were breaking the build, by commenting out unused variables,
3139 and a function, and by including a header.
3141 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3143 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3144 so we can #ifdef around platform-specific code when necessary.
3145 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3146 to allow this to build for the GNOME platform too.
3148 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3150 * src/maemo/easysetup/modest-easysetup-wizard.c:
3151 Added util_increment_name() and used it in create_page_account_details()
3152 to make sure that the default account name is always a new name.
3154 (modest_easysetup_wizard_dialog_init),
3155 (set_default_custom_servernames): Some minor memory management fixes.
3157 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3161 * src/modest-runtime.c: (init_i18n): Restored the translation
3162 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3163 are defined in config.h, and the translations are installed.
3165 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3166 is defined for translation.
3168 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3170 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3172 * src/maemo/easysetup/modest-easysetup-wizard.c:
3173 (modest_easysetup_wizard_dialog_init):
3174 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3175 Use realistic paths (though they should use $prefix generically) to the
3176 mcc_mapping and provider-data.keyfile files which might work when they
3177 are installed by the future version of the operator-wizard package,
3178 and then fallback to paths in our source code, with an explanatory
3181 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3185 * src/maemo/Makefile.am:
3186 * src/maemo/easysetup/: Added files from the previously-exernal
3187 osso-modest-easysetup.
3188 * src/maemo/modest-main-window-ui.h:
3189 * src/modest-ui-actions.c:
3190 * src/modest-ui-actions.h:
3191 Added modest_ui_actions_on_new_account() as a signal handler for the
3192 New Account menu item. It shows the easysetup wizard.
3193 * po/en_GB.po: Added additional needed logical IDs and translations.