git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/easysetup/modest-easysetup-wizard.c:
   4         (create_page_custom_incoming), (create_page_custom_outgoing):
   5         * src/maemo/modest-account-settings-dialog.c:
   6         (create_page_account_details), (create_page_incoming),
   7         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
   8         instead of using gtk_check_button_with_label(), so they are aligned like the other
   9         widgets, as per the UI spec.
  10
  11 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  12
  13         * src/maemo/easysetup/modest-easysetup-wizard.c:
  14         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  15         * src/widgets/modest-validating-entry.c:
  16         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
  17         Modest prefix instead of an EasySetup prefix.
  18
  19 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  20
  21         * src/widgets/modest-validating-entry.h:
  22         * src/widgets/modest-validating-entry.c: (on_insert_text),
  23         Added easysetup_validating_entry_set_max_func(), used to set a callback
  24         to call when the max number of characters is reached. GtkEntry has a max-length
  25         already but is silent about it.
  26
  27         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
  28         (create_page_account_details), (create_page_user_details),
  29         (create_account):
  30         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
  31         (create_page_account_details), (create_page_user_details),
  32         (create_page_outgoing):
  33         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
  34         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
  35         the UI spec, when the user tries to enter more than the max number of characters.
  36
  37 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  38
  39         * src/maemo/easysetup/modest-easysetup-wizard.c:
  40         (create_page_user_details), (create_page_custom_incoming),
  41         (create_page_custom_outgoing):
  42         * src/maemo/modest-account-settings-dialog.c:
  43         (create_page_user_details), (create_page_incoming),
  44         (create_page_outgoing):
  45         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  46         (modest_connection_specific_smtp_edit_window_init):
  47         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
  48         not appropriate. Bad Maemo-specific defaults!.
  49
  50 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  51
  52         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
  53         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
  54         (modest_signature_editor_dialog_set_settings):
  55         Disable the label and textview when the checkbox is disabled, and use the
  56         specified (UI spec) default signature text.
  57
  58 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  59
  60         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  61         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
  62
  63         * src/modest-defs.h:
  64         * src/modest-account-mgr-helpers.h:
  65         * src/modest-account-mgr-helpers.c:
  66         Added modest_account_mgr_get/set_signature(), using new gconf keys.
  67
  68         * src/maemo/Makefile.am:
  69         * src/maemo/modest-signature-editor-dialog.c:
  70         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
  71         as per the UI spec.
  72
  73         * src/maemo/modest-account-settings-dialog.h:
  74         * src/maemo/modest-account-settings-dialog.c:
  75         (modest_account_settings_dialog_finalize), (on_button_signature),
  76         (save_configuration): Use the new dialog when the Edit button is pressed, and
  77         save the changes if necessary, as per the UI spec.
  78
  79 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  80
  81         * src/maemo/Makefile.am:
  82         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
  83         based on maemo-develoers email from Dirk.
  84
  85         * src/maemo/easysetup/modest-easysetup-wizard.c:
  86         (create_page_welcome), (create_page_account_details),
  87         (create_page_user_details), (create_page_complete_easysetup),
  88         (create_page_custom_incoming), (create_page_custom_outgoing),
  89         (create_page_complete_custom),
  90         (modest_easysetup_wizard_dialog_init):
  91         * src/maemo/modest-account-settings-dialog.c:
  92         (create_page_account_details), (create_page_user_details),
  93         (create_page_incoming), (create_page_outgoing),
  94         (modest_account_settings_dialog_init):
  95         * src/maemo/modest-connection-specific-smtp-window.c:
  96         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
  97
  98 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  99
 100         * src/maemo/easysetup/modest-easysetup-wizard.c:
 101         (create_page_account_details), (create_page_custom_outgoing),
 102         (create_page_complete_custom):
 103         * src/maemo/modest-account-settings-dialog.c:
 104         (create_page_user_details), (create_page_incoming),
 105         (create_page_outgoing):
 106         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 107         (modest_connection_specific_smtp_edit_window_init):
 108         Use the correct (UI spec) port min/max, and use horizontal separators,
 109         as per the UI spec.
 110
 111 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 112
 113         * src/maemo/easysetup/modest-easysetup-wizard.c:
 114         (set_default_custom_servernames):
 115         * src/maemo/modest-account-settings-dialog.c:
 116         (create_page_incoming), (on_combo_outgoing_security_changed),
 117         (on_combo_incoming_security_changed), (create_page_outgoing),
 118         (modest_account_settings_dialog_set_account_name),
 119         (save_configuration):
 120         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 121         (on_combo_security_changed),
 122         (modest_connection_specific_smtp_edit_window_init),
 123         (modest_connection_specific_smtp_edit_window_set_connection),
 124         (modest_connection_specific_smtp_edit_window_get_settings):
 125         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 126         as per the UI spec.
 127
 128 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 129
 130         * po/en_GB.po:
 131         * src/maemo/easysetup/modest-easysetup-wizard.c:
 132         (create_page_custom_outgoing), (create_page_complete_custom):
 133         * src/maemo/modest-account-settings-dialog.c:
 134         (create_page_user_details), (create_page_outgoing):
 135         * src/maemo/modest-account-view-window.c: (button_box_new):
 136         Use changed logical IDs as per the most recent UI spec:
 137         mcen_bd_emailsetup_edit -> mcen_bd_edit
 138         mcen_bd_emailsetup_delete -> mcen_bd_delete
 139         mcen_bd_emailsetup_close -> mcen_bd_close
 140
 141 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 142
 143         * configure.ac:
 144         * src/Makefile.am:
 145         * src/dbus_api/Makefile.am:
 146         * src/dbus_api/modest-dbus-callbacks.c:
 147         * src/dbus_api/modest-dbus-callbacks.h:
 148         * src/maemo/modest-platform.c: (modest_platform_init):
 149         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 150         method.
 151         * tests/Makefile.am:
 152         * tests/dbus_api/Makefile.am:
 153         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 154
 155 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 156
 157         * src/maemo/modest-account-settings-dialog.c:
 158         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 159         Removed unnecessary includes.
 160
 161 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 162
 163         * src/maemo/easysetup/modest-easysetup-wizard.c:
 164         * src/maemo/modest-account-settings-dialog.c:
 165         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 166         * src/widgets/Makefile.am:
 167         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 168         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 169         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 170         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 171         * src/widgets/modest-secureauth-combo-box.c:
 172         * src/widgets/modest-secureauth-combo-box.h:
 173         * src/widgets/modest-serversecurity-combo-box.c:
 174         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 175         made the GObject names more consistent with the rest of the Modest code.
 176
 177 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 178
 179         * src/maemo/easysetup/Makefile.am:
 180         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 181         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 182         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 183         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 184         * src/maemo/easysetup/modest-easysetup-wizard.c:
 185         * src/maemo/easysetup/modest-validating-entry.c:
 186         * src/maemo/easysetup/modest-validating-entry.h:
 187         * src/maemo/modest-account-settings-dialog.c:
 188         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 189         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 190         widgets/ because they are used outside of easysetup too. After checking in,
 191         svn will allow me to rename them too.
 192
 193 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 194
 195         * src/gnome/modest-msg-edit-window.c:
 196         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 197         linker error, to fix the build on the GNOME platform.
 198         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 199         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 200         ifdefed out to avoid a warning.
 201
 202 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 203
 204         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 205         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 206         some alternative for GTK+ 2.6.
 207
 208 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 209
 210         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 211
 212         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 213         specified for EmailAccountsDialog in UI spec.
 214
 215         * src/maemo/easysetup/modest-easysetup-wizard.c:
 216         * src/maemo/easysetup/modest-easysetup-wizard.h:
 217         * src/maemo/modest-account-settings-dialog.c:
 218         * src/maemo/modest-account-settings-dialog.h:
 219         Reuse a member window widget for the connection-specific SMTP server accounts,
 220         so we can tell it to create/save the accounts only if we actually save changes.
 221
 222         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 223         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 224         (modest_connection_specific_smtp_edit_window_get_settings):
 225         Return a struct instance for temporarily remembering the entered data.
 226
 227         * src/maemo/modest-connection-specific-smtp-window.h:
 228         * src/maemo/modest-connection-specific-smtp-window.c:
 229         (modest_connection_specific_smtp_window_finalize),
 230         (modest_connection_specific_smtp_window_fill_with_connections),
 231         (on_button_edit),
 232         (modest_connection_specific_smtp_window_save_server_accounts),
 233         (update_model_server_names): Do not actually save data until asked,
 234         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 235
 236         (on_selection_changed),
 237         (modest_connection_specific_smtp_window_init): Disable the edit
 238         button when nothing is selected.
 239
 240         * src/modest-account-mgr-helpers.c:
 241         * src/modest-account-mgr-helpers.h:
 242         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 243         elsewhere.
 244
 245 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 246
 247         * src/modest-account-mgr-helpers.h:
 248         * src/modest-account-mgr-helpers.c:
 249         (modest_account_mgr_get_unused_account_name),
 250         (modest_account_mgr_get_unused_account_display_name): Added these
 251         utility functions, to avoid code duplication.
 252
 253         * src/maemo/easysetup/modest-easysetup-wizard.c:
 254         (create_page_account_details), (create_account):
 255         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 256         (on_combo_security_changed),
 257         (modest_connection_specific_smtp_edit_window_init),
 258         (modest_connection_specific_smtp_edit_window_save_settings):
 259         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 260         * src/maemo/modest-connection-specific-smtp-window.c:
 261         (modest_connection_specific_smtp_window_finalize),
 262         (modest_connection_specific_smtp_window_fill_with_connections),
 263         (on_button_edit), (modest_connection_specific_smtp_window_init):
 264         * src/maemo/modest-connection-specific-smtp-window.h:
 265         Implementing saving of connection-specific server accounts.
 266
 267         But I need to refactor this so we can save the data for each
 268         possible connection-specific account and only actually create the server accounts
 269         when the easysetup finished, or the OK button is pressed on the account settings
 270         dialog.
 271
 272 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 273
 274         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 275         (on_combo_security_changed):
 276         (modest_connection_specific_smtp_edit_window_init):
 277         Auto-fill the port number as in the account settings.
 278
 279         (modest_connection_specific_smtp_edit_window_set_connection):
 280         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 281         * src/maemo/modest-connection-specific-smtp-window.c:
 282         (fill_with_connections), (on_button_edit),
 283         (modest_connection_specific_smtp_window_init):
 284         Turn the edit window into a dialog to simplify the code, and
 285         set a WM hint as in a GtkDialog, because only a popup can be on top of
 286         another window in Maemo, and popups usually have no WM decoration.
 287
 288         * src/modest-defs.h:
 289         * src/modest-account-mgr-helpers.c:
 290         (modest_account_mgr_set_connection_specific_smtp),
 291         (modest_account_mgr_remove_connection_specific_smtp),
 292         (modest_account_mgr_get_connection_specific_smtp):
 293         * src/modest-account-mgr-helpers.h: Some functions to write the
 294         connection-specific SMTP server information. Not yet used.
 295
 296
 297         * src/widgets/modest-folder-view.c: (text_cell_data):
 298         Fix a warning about an uninitialized variable.
 299         (on_configuration_key_changed): Put an #ifdef around the use
 300         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 301
 302 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 303
 304         * src/maemo/modest-account-settings-dialog.h:
 305         * src/maemo/modest-account-settings-dialog.c:
 306         Added connect_for_modified() utility function to mark the new modified boolean.
 307
 308         (create_page_account_details), (create_page_user_details),
 309         (create_page_incoming), (create_page_outgoing), (on_response),
 310         (modest_account_settings_dialog_init),
 311         (modest_account_settings_dialog_set_account_name):
 312         Only warn about unsaved changes when there are actually unsaved changes.
 313
 314         * src/modest-account-mgr-helpers.c:
 315         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 316         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 317         to get the data from there in future.
 318
 319 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 320
 321         * src/modest-defs.h:
 322
 323         * src/modest-account-mgr-helpers.h:
 324         * src/modest-account-mgr-helpers.c:
 325         Store the security account setting in a single conf key instead of using
 326         the options list, so that the list is left for just the to-be-removed camel hack,
 327         and because gconf_client_set_list() is failing for some reason.
 328
 329         * src/modest-account-mgr.c:
 330         (modest_account_mgr_add_server_account):
 331         * src/maemo/modest-account-settings-dialog.c:
 332         (modest_account_settings_dialog_set_account_name),
 333         (save_configuration): Use the renamed functions.
 334
 335
 336 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 337
 338         * src/widgets/Makefile.am:
 339         * src/widgets/modest-limit-retrieve-combo-box.c:
 340         * src/widgets/modest-limit-retrieve-combo-box.h:
 341         * src/widgets/modest-retrieve-combo-box.c:
 342         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 343         the account settings dialog.
 344
 345         * src/modest-defs.h:
 346         * src/modest-account-mgr-helpers.h:
 347         * src/modest-account-mgr-helpers.c:
 348         (modest_server_account_get_option_secure_auth),
 349         (modest_server_account_set_option_secure_auth):
 350         * src/modest-account-mgr.c:
 351         (modest_account_mgr_add_server_account):
 352         Use the existing AUTH_MECH conf key for the secure-auth setting,
 353         instead of putting it in the list options, because this was actually used already.
 354
 355         * src/maemo/modest-account-settings-dialog.c:
 356         (create_page_account_details),
 357         (modest_account_settings_dialog_set_account_name),
 358         (save_configuration):
 359         * src/maemo/modest-account-settings-dialog.h:
 360         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 361         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 362
 363 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 364
 365         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 366         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 367         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 368
 369         * src/modest-defs.h:
 370         * src/maemo/modest-account-settings-dialog.c:
 371         (create_page_incoming), (on_combo_outgoing_security_changed),
 372         (on_combo_incoming_security_changed), (create_page_outgoing),
 373         (modest_account_settings_dialog_set_account_name),
 374         (save_configuration): Load/Save the port number, and change it when the
 375         security combo changes, to suitable defaults.
 376
 377 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 378
 379         * src/modest-account-mgr.c:
 380         (modest_account_mgr_add_server_account): Set the security and secure-auth
 381         options, and add a comment saying that the other camel-specific options should be
 382         removed in future.
 383
 384 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 385
 386         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 387         found by valgrind.
 388         * src/modest-tny-account-store.c: (account_list_free),
 389         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 390         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 391         easy to fix.
 392
 393 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 394
 395         * src/modest-protocol-info.c:
 396         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 397         is required by our UI spec. Maybe something in our implementation will use this eventually.
 398         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 399         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 400         instead of the previous 0 placeholder.
 401
 402         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 403         secure-auth settings.
 404         * src/modest-account-mgr-helpers.h:
 405         * src/modest-account-mgr-helpers.c:
 406         (modest_server_account_data_get_option_secure_auth),
 407         (modest_server_account_set_option_secure_auth),
 408         (modest_server_account_data_get_option_security),
 409         (modest_server_account_set_option_security): Added this API for getting and setting the security
 410         and secure-auth settings.
 411
 412         * src/maemo/modest-account-settings-dialog.h:
 413         * src/maemo/modest-account-settings-dialog.c:
 414         (modest_account_settings_dialog_finalize), (check_data),
 415         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 416         about changing titles.
 417         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 418         (save_configuration): Save the security and secure-auth settings.
 419
 420         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 421         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 422
 423 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 424
 425         * src/modest-defs.h:
 426         * src/modest-account-mgr.c:
 427         (modest_account_mgr_add_server_account):
 428         Added and used defines for the options key and value pair strings,
 429         that are used so far, though they do not seem to correspond to anything in our
 430         UI specs or ModestProtocol enum.
 431
 432         * src/modest-account-mgr-helpers.h:
 433         * src/modest-account-mgr-helpers.c:
 434         (compare_option_strings_for_name),
 435         (modest_server_account_data_get_option_value),
 436         (modest_server_account_data_get_option_bool),
 437         (modest_account_mgr_get_server_account_option):
 438         Added helper functions for parsing the options GSList.
 439
 440 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 441
 442         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 443         display name is based on the supplied account name.
 444         * src/modest-account-mgr.c:
 445         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 446         with an inefficient, but good-enough, implementation.
 447
 448         * src/maemo/easysetup/modest-easysetup-wizard.c:
 449         (create_page_account_details), (on_before_next), (create_account):
 450         Check for existing display names rather than (non-user-visible) account names, and just
 451         create and set a unique account name at the end.
 452
 453         * src/maemo/modest-account-settings-dialog.c:
 454         (modest_account_settings_dialog_init),
 455         (modest_account_settings_dialog_set_account_name),
 456         (create_page_incoming): Show the display name, instead of the account name.
 457         (on_response): Do some (not all) extra checks, as in the UI spec.
 458         (save_configuration): Save the display name if it was changed.
 459
 460 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 461
 462         * po/en_GB.po: Added needed logical ID and translation.
 463         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 464         (init_view): Made the is-default column clicking work.
 465
 466 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 467
 468         * configure.ac:
 469         * src/maemo/easysetup/Makefile.am:
 470         * src/maemo/easysetup/modest-easysetup-wizard.c:
 471         (modest_easysetup_wizard_dialog_init):
 472         * src/maemo/easysetup/provider-data-test.keyfile:
 473         * src/maemo/easysetup/provider-data.keyfile:
 474         Moved the provider data file to the new modest-providers-data package and used it from there.
 475
 476 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 477
 478         * src/modest-local-folder-info.c:
 479         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 480         N_() was already used on the static strings, but this just marks it for translation without
 481         using the translation.
 482
 483 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 484
 485         * src/maemo/modest-account-settings-dialog.c:
 486         (create_page_incoming),
 487         (modest_account_settings_dialog_set_account_name):
 488         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 489         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 490         I will do this if nobody else gets there first.
 491
 492 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 493
 494         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 495         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 496         save the security stuff.
 497
 498 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 499
 500         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 501         Set the email address and user fullname, which I now see must be
 502         done separately.
 503
 504         * src/maemo/modest-account-settings-dialog.h:
 505         * src/maemo/modest-account-settings-dialog.c:
 506          (on_response),
 507         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 508         leave-on-server and authentication.
 509         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 510         how to do the rest.
 511
 512 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 513
 514
 515         * src/maemo/modest-account-settings-dialog.c:
 516         * src/maemo/modest-account-settings-dialog.h:
 517         Most (but not all) of the widgets are now present as specified by the UI spec.
 518         No changes are yet saved, and some details are not properly shown yet.
 519
 520         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 521
 522 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 523
 524         * src/maemo/Makefile.am:
 525         * src/maemo/modest-account-settings-dialog.c:
 526         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 527         an existing account. Doesn't do much yet.
 528
 529         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 530         Open the accounts settings dialog when Edit is clicked.
 531
 532 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 533
 534         * src/maemo/easysetup/Makefile.am:
 535         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 536         (load_from_file):
 537         * src/maemo/easysetup/modest-easysetup-wizard.c:
 538         (modest_easysetup_wizard_dialog_init):
 539         Try to get the source directory from the build system,
 540         instead of hard-coding "./" into the source code, when opening our local
 541         copies of the configuration files.
 542         But this still fails when opening the wizard from the Accounts window,
 543         maybe because the working directory seems to change at runtime.
 544         So the wizard will fail the second time unless you copy the files into their
 545         proper locations - see the stdout warnings for the paths.
 546
 547         (create_page_account_details),(on_before_next):
 548         Check for existing non-server accounts instead of server accounts,
 549         so the default account name is useful again, and to prevent trying to
 550         recreate accounts.
 551
 552         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 553         Show the wizard when New is clicked.
 554
 555         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 556         (init_view): Show the column headers, and show the columns that are
 557         specified in the UI specs. However, something in Maemo's GTK+ prevents
 558         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 559         change the default account. This is despite unsetting the special properties.
 560
 561 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 562
 563         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 564         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 565         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 566         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 567         to make that clearer.
 568         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 569
 570 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 571
 572         * src/maemo/modest-account-view-window.c:
 573         (modest_account_view_window_init),
 574         (modest_account_view_window_new):
 575         Use the same buttons as specified in the
 576         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 577         the existing widgets, which never had a chance of working.
 578         Put the ModestAccountView treeview in a scrolled window.
 579         Do not repeat the initialization in both _init() and _new().
 580
 581         * src/widgets/modest-account-view.c: (update_account_view):
 582         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 583         this widget and window shows no accounts.
 584
 585         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 586
 587 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 588
 589         * src/maemo/easysetup/modest-easysetup-wizard.c:
 590         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 591         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 592         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 593         which seems wrong.
 594
 595         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 596         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 597         accounts exist yet, as in the UI spec.
 598
 599         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 600
 601 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 602
 603         * src/maemo/Makefile.am:
 604         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 605         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 606         New window for editing connection-specific smtp details.
 607         Not fully implemented.
 608
 609         * src/maemo/modest-connection-specific-smtp-window.c:
 610         (modest_connection_specific_smtp_window_finalize) :
 611         unref the tree model.
 612         (on_button_edit): Show the edit window.
 613
 614 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 615
 616         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 617         error for me.
 618
 619         * src/maemo/Makefile.am:
 620         * src/maemo/modest-connection-specific-smtp-window.c:
 621         * src/maemo/modest-connection-specific-smtp-window.h:
 622         New window for showing the list of connections, for connection-specific
 623         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 624         * src/maemo/easysetup/modest-easysetup-wizard.c:
 625         (create_page_custom_outgoing): Show the new window when the button is clicked.
 626
 627 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 628
 629         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 630         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 631         * src/maemo/modest-msg-edit-window.c:
 632         (modest_msg_edit_window_insert_image):
 633         * src/modest-conf.c: (modest_conf_key_escape):
 634         * src/modest-mail-operation.c:
 635         (modest_mail_operation_send_new_mail):
 636         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 637         (modest_ui_actions_on_new_account):
 638         * src/widgets/modest-attachment-view.c: (update_filename_request):
 639         * src/widgets/modest-mail-header-view.c:
 640         Corrected warnings that were breaking the build, by commenting out unused variables,
 641         and a function, and by including a header.
 642
 643 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 644
 645         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 646         so we can #ifdef around platform-specific code when necessary.
 647         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 648         to allow this to build for the GNOME platform too.
 649
 650 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 651
 652         * src/maemo/easysetup/modest-easysetup-wizard.c:
 653         Added util_increment_name() and used it in create_page_account_details()
 654         to make sure that the default account name is always a new name.
 655
 656         (modest_easysetup_wizard_dialog_init),
 657         (set_default_custom_servernames): Some minor memory management fixes.
 658
 659 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 660
 661         * Makefile.am:
 662         * configure.ac:
 663         * src/modest-runtime.c: (init_i18n): Restored the translation
 664         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 665         are defined in config.h, and the translations are installed.
 666
 667         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 668         is defined for translation.
 669
 670 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 671
 672         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 673         (load_from_file):
 674         * src/maemo/easysetup/modest-easysetup-wizard.c:
 675         (modest_easysetup_wizard_dialog_init):
 676         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 677         Use realistic paths (though they should use $prefix generically) to the
 678         mcc_mapping and provider-data.keyfile files which might work when they
 679         are installed by the future version of the operator-wizard package,
 680         and then fallback to paths in our source code, with an explanatory
 681         warning.
 682
 683 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 684
 685         * configure.ac:
 686         * src/Makefile.am:
 687         * src/maemo/Makefile.am:
 688         * src/maemo/easysetup/: Added files from the previously-exernal
 689         osso-modest-easysetup.
 690         * src/maemo/modest-main-window-ui.h:
 691         * src/modest-ui-actions.c:
 692         * src/modest-ui-actions.h:
 693         Added modest_ui_actions_on_new_account() as a signal handler for the
 694         New Account menu item. It shows the easysetup wizard.
 695         * po/en_GB.po: Added additional needed logical IDs and translations.
 696
 697 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 698 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 699