git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-17  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/modest-connection-specific-smtp-window.c:
   4         (modest_connection_specific_smtp_window_init):
   5         Use gtk_window_set_default_size() to make this window big enough, so
   6         we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
   7
   8 2007-05-17  Murray Cumming  <murrayc@murrayc.com>
   9
  10         * src/maemo/modest-connection-specific-smtp-edit-window.h:
  11         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  12         (modest_connection_specific_smtp_edit_window_init),
  13         Do not try to connect to a combobox signal before the combobox exists.
  14         This fixes the cras in projects.maemo.org bug NB#56288 .
  15         (modest_connection_specific_smtp_edit_window_get_settings):
  16         Remove the server_account_name parameter which was being checked for NULL
  17         though it was not used.
  18
  19         * src/maemo/modest-connection-specific-smtp-window.c:
  20         (modest_connection_specific_smtp_window_fill_with_connections),
  21         (on_button_edit), (modest_connection_specific_smtp_window_init):
  22         Correct the number of treemodel columns to prevent a warning.
  23         Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
  24         libconic does not work.
  25
  26 2007-05-16  Murray Cumming  <murrayc@murrayc.com>
  27
  28         * src/modest-tny-account.c:
  29         (modest_tny_account_new_from_server_account):
  30         Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
  31         SMTP when "None" was chosen by the user. However, with my SMTP server that
  32         does not support ANONYMOUS, the emails do not leave the Outbox and I see
  33         no error dialog.
  34
  35 2007-05-16  Murray Cumming  <murrayc@murrayc.com>
  36
  37         * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
  38         to explain the memory management issue with the ID in the ModestPair.
  39
  40         * src/gnome/modest-account-assistant.c: (add_receiving_page),
  41         (add_sending_page), (modest_account_assistant_finalize):
  42         * src/gnome/modest-gnome-global-settings-dialog.c:
  43         (create_updating_page), (create_composing_page):
  44         * src/gnome/modest-msg-edit-window.c: (get_transports),
  45         (init_window), (modest_msg_edit_window_finalize),
  46         (modest_msg_edit_window_get_msg_data):
  47         * src/gnome/modest-store-widget.c: (imap_pop_configuration):
  48         * src/gnome/modest-transport-widget.c:
  49         (modest_transport_widget_finalize), (smtp_configuration):
  50         * src/maemo/modest-maemo-global-settings-dialog.c:
  51         (create_updating_page), (create_composing_page):
  52         * src/maemo/modest-msg-edit-window.c: (get_transports),
  53         (init_window), (modest_msg_edit_window_finalize),
  54         (modest_msg_edit_window_get_msg_data),
  55         (modest_msg_edit_window_free_msg_data):
  56         * src/maemo/modest-store-widget.c: (imap_pop_configuration),
  57         (modest_store_widget_finalize):
  58         * src/maemo/modest-transport-widget.c:
  59         (modest_transport_widget_finalize), (smtp_configuration):
  60         * src/modest-main.c: (send_mail):
  61         * src/widgets/modest-combo-box.h:
  62         * src/widgets/modest-global-settings-dialog-priv.h:
  63         * src/widgets/modest-global-settings-dialog.c:
  64         (modest_global_settings_dialog_finalize):
  65         * src/widgets/modest-msg-edit-window.h:
  66         Whenever using modest_combo_box_new(), keep the ModestPairList alive
  67         as long as the combo box, to prevent use of freed memory for the ID.
  68
  69 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  70
  71         * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
  72         get_accounts(), to make this clearer. Do not check for the enabled gconf
  73         key, because we do not use this for server accounts (at least, not yet).
  74         This allows us to send email again.
  75
  76 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  77
  78         * src/maemo/modest-platform.c:
  79         (on_modest_conf_update_interval_changed), (modest_platform_init):
  80         Only respond to this particular key change. All these strcmp()s cannot be
  81         efficient.
  82
  83 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  84
  85         * src/maemo/modest-maemo-global-settings-dialog.c:
  86         (current_connection): Prevent a crash in scratchbox when
  87         ny_maemo_conic_device_get_current_iap_id() returns NULL.
  88         * src/maemo/modest-platform.c:
  89         (on_modest_conf_update_interval_changed), (modest_platform_init):
  90         Get the update interval from gconf and reset it when the gconf key changes.
  91
  92 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  93
  94         * src/modest-protocol-info.c:
  95         * src/modest-protocol-info.h: Adde enum-specific get functions,
  96         instead of using a ModestProtocolType enum parameter.
  97
  98         * src/gnome/modest-account-assistant.c:
  99         * src/gnome/modest-store-widget.c:
 100         * src/gnome/modest-store-widget.h:
 101         * src/gnome/modest-transport-widget.c:
 102         * src/gnome/modest-transport-widget.h:
 103         * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
 104         * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
 105         * src/maemo/easysetup/modest-easysetup-wizard.c:
 106         * src/maemo/modest-account-settings-dialog.c:
 107         * src/maemo/modest-account-settings-dialog.h:
 108         * src/maemo/modest-store-widget.c:
 109         * src/maemo/modest-store-widget.h:
 110         * src/maemo/modest-transport-widget.c:
 111         * src/maemo/modest-transport-widget.h:
 112         * src/modest-account-mgr-helpers.c:
 113         * src/modest-account-mgr-helpers.h:
 114         * src/modest-account-mgr.c:
 115         * src/modest-account-mgr.h:
 116         * src/modest-tny-account.c:
 117         * src/modest-tny-folder.c:
 118         * src/widgets/modest-account-view.c:
 119         * src/widgets/modest-retrieve-combo-box.c:
 120         * src/widgets/modest-retrieve-combo-box.h:
 121         * src/widgets/modest-secureauth-combo-box.c:
 122         * src/widgets/modest-serversecurity-combo-box.c:
 123         * src/widgets/modest-serversecurity-combo-box.h:
 124         * tests/check_account-mgr.c:
 125         Use the specific functions, and use the re-renamed enum values for GNOME too.
 126
 127 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
 128
 129         * src/modest-pair.h:
 130         * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
 131         so we can get the second based on the first.
 132
 133         * src/maemo/modest-account-settings-dialog.h:
 134         * src/maemo/modest-account-settings-dialog.c:
 135         Added get_supported_secure_authentication_methods(), though it is mostly
 136         commented-out for now until the necessary API is committed to tinymail.
 137         (modest_account_settings_dialog_set_account_name),
 138         (save_configuration): Request the supported authentication methods from the
 139         server, so we can choose a working method.
 140
 141         * src/modest-tny-account-store.h:
 142         * src/modest-tny-account-store.c:
 143         (modest_tny_account_store_get_session): Rename from
 144         tny_account_store_get_session().
 145
 146 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 147
 148         * src/modest-protocol-info.h: Split the ModestProtocol enum
 149         into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
 150         There was no need to have these unrelated values in one enum.
 151
 152         * src/: many files: Adapted to changed enum. This makes the code a bit
 153         clearer, and the compiler could catch some errors.
 154
 155 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 156
 157         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 158         Show the detailed internal camel error message when an error happens
 159         during the configuration, so that our testers can give us more clues.
 160         For instance, in projects.maemo.org bug NB#56910 .
 161
 162 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 163
 164         * src/modest-tny-account.c:
 165         (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
 166         change tny_account_set_mech() to tny_account_set_secure_auth_mech().
 167
 168 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 169
 170         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 171         * src/maemo/modest-account-settings-dialog.c:
 172         (modest_account_settings_dialog_set_account_name),
 173         (save_configuration): For the incoming secure authentication checkbox,
 174         use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
 175         the UI specification. PLAIN does not seem to be supported for most IMAP
 176         servers anyway, and I am not sure what it would mean.
 177         However, we probably need to discover which of the secure-authentication
 178         mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
 179         * src/modest-account-mgr-helpers.c:
 180         (modest_account_mgr_get_server_account_data):
 181
 182         * src/modest-tny-account.c:
 183         (modest_tny_account_new_from_server_account):
 184         Use tny_account_set_mech() to set secure-authentication methods,
 185         with some special-casing for IMAP, based on my observations of how
 186         evolution behaves.
 187
 188         * src/modest-account-mgr-helpers.h:
 189         * src/modest-account-mgr.c:
 190         * src/modest-defs.h: Comment that the URI is only used for local folders.
 191
 192 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
 193
 194         * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
 195         parameter const, just to be neat.
 196         * src/modest-text-utils.c: (modest_text_utils_inline):
 197         End g_strconcat() with NULL, as its documentation says. This is almost
 198         certainly the cause of my crash at startup on the device. Interestingly,
 199         valgrind doesn't tell us about these errors.
 200
 201 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
 202
 203         * scripts/build-packages: Added more precise comments about how to use
 204         this script, though I still get this error:
 205         dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
 206         error building tinymail
 207
 208 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
 209
 210         * src/maemo/modest-main-window.c: (on_account_update):
 211         Very slight cleanup, hoping to make it simpler to discover what causes
 212         a crash here sometimes.
 213
 214         * src/modest-tny-account.c:
 215         (modest_tny_account_new_from_server_account): Set the port. Added
 216         comments about the options and a TODO comment because I need to find out
 217         how to specify the secure authentication method.
 218
 219 2007-05-11  Marcus Bauer  <marcusb@openismus.com>
 220
 221         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 222         changed CFlags paths form modest to libmodest
 223
 224 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 225
 226         * src/modest-account-mgr-helpers.c:
 227         (modest_account_mgr_get_server_account_data),
 228         (modest_account_mgr_free_server_account_data):
 229         * src/modest-account-mgr-helpers.h:
 230         * src/modest-account-mgr.c:
 231         (modest_account_mgr_add_server_account):
 232         * src/modest-defs.h:
 233         * src/modest-tny-account.c:
 234         (modest_tny_account_new_from_server_account):
 235         Determine the options for tny_camel_account_add_option() here,
 236         based on the settings, rather than storing them directly in gconf.
 237
 238 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 239
 240         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 241         Show a more friendly error dialog now that we expect (from the tinymail
 242         documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
 243
 244 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 245
 246         * src/maemo/modest-main-window.c: (on_account_update): Check that
 247         account_name is not NULL, to prevent a crash at startup that I am
 248         seeing on the N800. I do wonder why it is NULL.
 249
 250         * src/maemo/easysetup/modest-easysetup-wizard.c:
 251         (create_page_user_details):
 252         * src/maemo/modest-account-settings-dialog.c:
 253         (create_page_user_details), (create_page_outgoing):
 254         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 255         (modest_connection_specific_smtp_edit_window_init):
 256         * src/modest-ui-actions.c:
 257         (modest_ui_actions_on_password_requested):
 258         Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
 259         might do something useful with the on-screen keyboard.
 260
 261 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 262
 263         * src/maemo/modest-main-window.c: (on_account_update):
 264         Avoid adding a menu item to priv->accounts_popup if accounts_popup is
 265         NULL, to avoid lots of warnings. However, it probably should not be NULL.
 266
 267 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 268
 269         * src/modest-tny-account-store.c: (on_account_changed):
 270         Correct the signature of this signal handler.
 271
 272 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 273
 274         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 275         Show a HildonNote instead of a GtkDialog for Maemo.
 276
 277 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 278
 279         * src/widgets/modest-account-view.h:
 280         * src/widgets/modest-account-view.c: (on_account_changed),
 281         (on_account_removed). Added a boolean flag, set/unset by
 282         modest_account_view_block_conf_updates(),
 283         modest_account_view_unblock_conf_updates() to prevent unnecessary
 284         updates, but this is not very useful because the gconf notifications are
 285         so delays (maybe only on Maemo Bora).
 286         So auto-updating is turned off, and these functions do an explicit
 287         update when necessary.
 288         However, something else is still doing too much work when adding/removing
 289         accounts, probably in another part of the application.
 290
 291         * src/maemo/modest-account-view-window.c:
 292         (on_delete_button_clicked), (on_edit_button_clicked),
 293         (on_new_button_clicked): Use the new functions.
 294
 295 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 296
 297         * src/modest-account-mgr-helpers.c:
 298         (modest_account_mgr_set_first_account_as_default):
 299         Sort the list of names alphabetically-by-title, so we choose the first one
 300         based on that.
 301         * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
 302         alphabetically by the title.
 303
 304         This fixes projects.maemo.org bug NB#56418 .
 305
 306         * src/modest-account-mgr-priv.c:
 307         (_modest_account_mgr_account_from_key):
 308         * src/modest-account-mgr.c: (on_key_change): Initialize variables to
 309         avoid a valgrind error, and possible random behaviour.
 310
 311 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 312
 313         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 314         Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
 315         tinymail documentation to say that this can be expected.
 316         Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
 317         pretty, and should not happen, but I would prefer to know when it does.
 318
 319 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 320
 321         * configure.ac: When using the older hildon version, probably on Bora,
 322         require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
 323         to fix the build.
 324         * src/widgets/modest-attachment-view.c:
 325         (modest_attachment_view_set_part_default): Initialize variables, to fix the
 326         build.
 327
 328 2007-05-09  Marcus Bauer  <marcusb@openismus.com>
 329
 330         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
 331         Implemented the prototype. Can be tested with
 332         tests/dbus_api/test_open_message:
 333
 334 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 335
 336         * src/modest-tny-account-store.c:
 337         (modest_tny_account_store_instance_init), (get_password):
 338         * src/modest-ui-actions.c:
 339         (modest_ui_actions_on_password_requested):
 340         Do not store the password in gconf, because this function is called
 341         for non-remembered passwords. Actually use the cached (in the hash map)
 342         password instead of releasing it.
 343         The password will now not be remembered if it is asked via the protected
 344         password dialog, as per the UI spec.
 345
 346 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 347
 348         * src/modest-defs.h:
 349         * src/modest-account-mgr-helpers.h:
 350         * src/modest-account-mgr-helpers.c:
 351         Added modest_server_account_get_username_has_succeeded(),
 352         modest_server_account_set_username_has_succeeded().
 353         (modest_server_account_set_username),
 354         Reset the has-succeeded flag if the username changes.
 355
 356         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 357         * src/maemo/modest-connection-specific-smtp-window.c:
 358         (modest_connection_specific_smtp_window_save_server_accounts):
 359         Use modest_server_account_set_username() instead of using
 360         modest_conf_set_string() directly, so that the has-succeeded flag is always
 361         reset.
 362
 363         * src/modest-ui-actions.c:
 364         (modest_ui_actions_on_password_requested): Dim the username entry if
 365         the username has ever worked, as per the UI spec.
 366
 367 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 368
 369         * src/modest-tny-account-store.c: (get_password):
 370         * src/modest-ui-actions.c:
 371         (modest_ui_actions_on_password_requested):
 372         Allow the username to be changed too, though there is more work to
 373         be done on exactly how this behaves.
 374
 375 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 376
 377         * src/modest-account-mgr-helpers.h:
 378         * src/modest-account-mgr-helpers.c:
 379         Added modest_account_mgr_get_display_name(),
 380         modest_server_account_get_username(),
 381         modest_server_account_set_username(),
 382         modest_server_account_set_password(),
 383         modest_server_account_get_hostname() functions so we do not need to
 384         use the conf API directly.
 385
 386         * src/maemo/modest-main-window.c: (connect_signals):
 387         Actually connect ot the ModestAccountStore::request-password signal,
 388         so that we show the dialog when the password is requested by Tinymail,
 389         for isntance if it is empty.
 390
 391         * src/modest-marshal.list:
 392         * src/modest-tny-account-store.c:
 393         (modest_tny_account_store_class_init), (get_password),
 394         (modest_tny_account_store_alert):
 395         * src/modest-tny-account-store.h:
 396         * src/modest-ui-actions.h:
 397         * src/modest-ui-actions.c:
 398         (modest_ui_actions_on_password_requested):
 399         Change the signal parameters, so it is obvious that we are providing
 400         the non human-readable server name, and receiving both the username
 401         and password, though changing of the username is not yet implemented.
 402         Change the dialog UI to match the Maemo UI specifications, with #idfefing
 403         for the GNOME version.
 404
 405         This should fix the projects.maemo.org bug NB#56209, though it does not
 406         work on Bora, because the gconf_client_get() for the password fails
 407         immediately after we save it with gconf_client_set().
 408
 409 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 410
 411         * configure.ac:
 412         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
 413         caused an undefined symbol error:
 414         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
 415
 416 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 417
 418         * src/modest-tny-account-store.c:
 419         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
 420         using a GError instead of a string message, so we can translate it in
 421         Modest.
 422
 423 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 424
 425         * src/maemo/modest-address-book.c:
 426         (modest_address_book_check_names):
 427         * src/maemo/modest-msg-view-window.c:
 428         (modest_msg_view_window_clipboard_owner_change):
 429         * src/modest-init.c: (modest_init_init_ui):
 430         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
 431         (update_folders_cb), (modest_mail_operation_update_account):
 432         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 433         (modest_ui_actions_on_msg_attachment_clicked),
 434         (modest_ui_actions_on_msg_recpt_activated):
 435         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 436         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 437         (modest_msg_view_search_next):
 438         * src/widgets/modest-recpt-editor.c:
 439         (modest_recpt_editor_on_button_release_event),
 440         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 441         g_message(). At this point we should only be seeing interesting errors on
 442         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 443
 444 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 445
 446         (modest_wizard_dialog_force_title_update):
 447         * src/maemo/easysetup/modest-wizard-dialog.h:
 448         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 449         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 450         can update the title when appropriate. Otherwise the title is wrong if the
 451         pages are added after adding the notebook to the dialog.
 452         This must be a problem in HildonWizardDialog too.
 453         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 454
 455         * src/maemo/easysetup/modest-easysetup-wizard.c:
 456         (create_subsequent_customsetup_pages),
 457         (create_subsequent_easysetup_pages):
 458         Call modest_wizard_dialog_force_title_update() so that the title is
 459         correct even with GTK+ < 2.10.
 460         This fixes projects.maemo.org bug NB#56145 .
 461
 462 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 463
 464         * src/maemo/modest-platform.c:
 465         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 466         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 467         from being shown.
 468
 469 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 470
 471         * src/widgets/modest-window.h:
 472         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 473         and modest_window_save_state(), which invokes it.
 474
 475         * src/widgets/modest-window-mgr.h:
 476         * src/widgets/modest-window-mgr.c:
 477         Added modest_window_mgr_save_state_for_all_windows(), which calls
 478         the save_state vfunc on all registered windows, if implemented.
 479
 480         * src/gnome/modest-msg-edit-window.c:
 481         * src/gnome/modest-msg-view-window.c:
 482         * src/maemo/modest-msg-edit-window.c:
 483         * src/maemo/modest-msg-view-window.c:
 484         * src/maemo/modest-main-window.c:
 485         Specify the existing save_settings functions as implementations of
 486         ModestWindow::save_state_func().
 487
 488         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 489         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 490         enabling hibernation, for instance.
 491
 492         We may need to do the same thing for restoring settings.
 493
 494
 495 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 496
 497         * src/widgets/modest-window-mgr.c:
 498         * src/widgets/modest-window-mgr.h:
 499         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 500         modest_window_mgr_get_hibernation_is_prevented().
 501
 502         * src/maemo/modest-main-window.c:
 503         (on_hildon_program_is_topmost_notify): Prevent hibernation
 504         (possible when the application goes to the background in the WM),
 505         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 506
 507         * src/maemo/easysetup/modest-easysetup-wizard.c:
 508         (modest_easysetup_wizard_dialog_init):
 509         * src/maemo/modest-account-settings-dialog.c:
 510         (modest_account_settings_dialog_init):
 511         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 512         (modest_connection_specific_smtp_edit_window_init):
 513         * src/maemo/modest-connection-specific-smtp-window.c:
 514         (modest_connection_specific_smtp_window_init):
 515         * src/maemo/modest-signature-editor-dialog.c:
 516         (modest_signature_editor_dialog_init):
 517         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 518         prevent hibernation while any of these account settings dialogs are open.
 519
 520 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 521
 522         * src/maemo/Makefile.am:
 523         * src/maemo/modest-osso-state-saving.c:
 524         * src/maemo/modest-osso-state-saving.h: Added
 525         modest_osso_load_state() and modest_osso_save_state() though they do
 526         nothing now. They should iterate through all the open windows and load/save
 527         their state.
 528         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 529         save state when closing.
 530
 531         * src/maemo/modest-main-window.c:
 532         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 533         Add a notification handler for the HildonProgram::is-topmost property,
 534         so we can allow hibernation when the application goes into the background.
 535         But we still need to detect when the accounts setup windows are open so
 536         we can stop hibernation when they are open.
 537         To do this, I also added the main window the HildonProgram. This might have
 538         other side-effects/benefits, and should maybe be done for other windows.
 539
 540         * src/maemo/modest-osso-autosave-callbacks.h:
 541         * src/maemo/modest-osso-autosave-callbacks.c:
 542         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 543         though it does not do anything yet, and we might never need this to do
 544         anything. For instance, we already save drafts.
 545
 546         * src/maemo/modest-platform.c: (modest_platform_init):
 547         Specify the libosso auto-save callback.
 548
 549 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 550
 551         * src/maemo/modest-platform.c:
 552         (modest_platform_set_update_interval):
 553         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 554         aparently stays valid between application instances, so we can use this
 555         to remove and reset it later. According to a maemo-developers email from
 556         David Weinehall.
 557
 558 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 559
 560         * configure.ac: Depend on libalarm for Maemo.
 561
 562         * src/dbus_api/modest-dbus-api.h:
 563         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 564         (on_send_receive), (modest_dbus_req_handler):
 565         Handle a SEND_RECEIVE D-Bus method.
 566
 567         * libmodest-dbus-client/libmodest-dbus-client.c:
 568         (libmodest_dbus_client_send_and_receive):
 569         * libmodest-dbus-client/libmodest-dbus-client.h:
 570         Add C convenience functions for calling the new D-Bus method.
 571
 572         * src/modest-platform.h:
 573         * src/gnome/modest-platform.c:
 574         * src/maemo/modest-platform.c:
 575         Added modest_platform_set_update_interval(), which uses the
 576         alarmd API on Maemo.
 577         (modest_platform_init),
 578         Call modest_platform_set_update_interval(), using a hard-coded
 579         interval for now (until the global settings dialog is implemented),
 580         though I am not sure that this makes sense yet.
 581
 582 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 583
 584         * src/dbus_api/modest-dbus-callbacks.c:
 585         (modest_osso_cb_hw_state_handler):
 586         * src/dbus_api/modest-dbus-callbacks.h:
 587         * src/maemo/modest-platform.c: (modest_platform_init):
 588         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 589         in case this has some effect on the ability for Maemo to ping the
 590         application.
 591
 592 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 593
 594         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 595         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 596         warning. It is probably a logic error, but I need to fix the build.
 597
 598 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 599
 600         * src/modest-account-mgr.h:
 601         * src/modest-account-mgr.c:
 602         (modest_account_mgr_account_names): Add a gboolean enabled_only
 603         parameter, so we can get lists of onlt the enabled accounts.
 604
 605         (modest_account_mgr_add_account),,
 606         (modest_account_mgr_account_with_display_name_exists):
 607         * src/maemo/modest-msg-edit-window.c: (get_transports):
 608         * src/modest-account-mgr-helpers.c:
 609         (modest_account_mgr_set_first_account_as_default):
 610         * src/modest-init.c: (init_default_account_maybe):
 611         * src/modest-tny-account-store.c: (get_accounts):
 612         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 613         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 614         * tests/check_account-mgr.c: (START_TEST):
 615         Provide the extra parameter, as appropriate.
 616
 617         * src/widgets/modest-account-view.c: (update_account_view):
 618         Do not show disabled accounts (meaning that there is no way to
 619         enable/disable accounts in the UI (the feature is not in our UI
 620         specification), so we can use this internally only to mark unfinished
 621         or temporary account data.
 622
 623         * src/maemo/easysetup/modest-easysetup-wizard.c:
 624         (create_account): Add boolean enable parameter, so we can specify FALSE
 625         to create the temporary account.
 626         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 627         (on_before_next): When finishing, when there is a temporary account, just
 628         set it as enabled.
 629         Also, use a timeout to delay the showing of the dialog until gconf is likely
 630         to return correct information, due to a maemo gconf bug that is fixed in
 631         osso 1.1, but not yet in Bora.
 632         However, the dialog stays on screen after it is destroyed.
 633
 634         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 635         for invalid data when cancelling. Use a hildon note instead of a dialog
 636         to complain about invalid data. Do not show the account-saved note if the
 637         account is disabled (a temporary account that will not really be saved for use
 638         until later.)
 639
 640 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 641
 642         * src/modest-account-mgr-helpers.h:
 643         * src/modest-account-mgr-helpers.c:
 644         Added modest_account_mgr_unset_default_account(),
 645         Added modest_account_mgr_set_first_account_as_default().
 646
 647         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 648         If it was the default account, unset the default account name.
 649
 650         * src/maemo/modest-account-view-window.c:
 651         (on_delete_button_clicked): If it was the default account,
 652         set the first remaining account as the default instead.
 653
 654         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 655         a NULL account or a NULL default account, to prevent a crash. This should
 656         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 657
 658
 659 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 660
 661         * src/widgets/modest-recpt-editor.c:
 662         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 663         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 664         TODO comment for this. This fixes the build.
 665
 666         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 667         be the best place for it. This will in future update all auto-update accounts,
 668         rather than just the current/default account, when that gconf key exists.
 669         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 670         if there are no accounts, before calling do_send_receive().
 671         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 672
 673         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 674         * src/maemo/modest-main-window-ui.h:
 675         * src/maemo/modest-main-window.c: (on_connection_changed),
 676         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 677         directly, becaue the signal handler does more.
 678
 679 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 680
 681         * src/modest-account-mgr-helpers.c:
 682         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 683         for the case that the account does not exist.
 684
 685         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 686         (equivalent to the modest account name) rather than the tinymail account name
 687         (equivalent to the modest account title - human readable) to get the account data.
 688         Check for null account data to prevent the crash, and add a TODO comment saying that
 689         this needs fixing because it is using the server account name instead of the account name.
 690
 691 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 692
 693         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 694         * src/maemo/modest-account-settings-dialog.c: (show_error),
 695         (show_ok):
 696         Use hildon_note_new_information() for informative and error messages,
 697         which seems to be expected for Maemo applications (no documentation that I know of
 698         says this). I am surprised that there is no distinction between info and error
 699         dialogs.
 700
 701 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 702
 703         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 704         it is easy to find where this is used.
 705
 706         * src/maemo/easysetup/modest-easysetup-wizard.c:
 707         (create_page_welcome), (create_page_account_details),
 708         (create_page_user_details), (create_page_complete_easysetup),
 709         (create_page_custom_incoming), (create_page_custom_outgoing),
 710         (create_page_complete_custom):
 711         * src/maemo/modest-account-settings-dialog.c:
 712         (create_page_account_details), (create_page_user_details),
 713         (create_page_incoming), (create_page_outgoing):
 714         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 715         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 716         (modest_connection_specific_smtp_edit_window_init):
 717         * src/maemo/modest-connection-specific-smtp-window.c:
 718         (modest_connection_specific_smtp_window_init):
 719         * src/maemo/modest-signature-editor-dialog.c:
 720         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 721         and scrolling policy as per the Email Application Layout Guide, if I have
 722         understood it.
 723
 724 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 725
 726         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 727         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 728         which were empty, because these vfuncs have been removed from TnyAccountStore.
 729         This fixes the build.
 730
 731 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 732
 733         * src/maemo/modest-main-window.c:
 734         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 735         showing/hiding it. Added TODO because it probably should not be NULL.
 736         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 737         because unnecessary g_warnings() make degugging difficult.
 738
 739 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 740
 741         * src/maemo/modest-msg-edit-window.c:
 742         (modest_msg_edit_window_select_color),
 743         (modest_msg_edit_window_select_background_color): 2 const corrections and
 744         moving 2 #endifs before closing brackets, to fix the build.
 745
 746 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 747
 748         * src/maemo/easysetup/modest-easysetup-wizard.h:
 749         * src/maemo/easysetup/modest-easysetup-wizard.c:
 750         (modest_easysetup_wizard_dialog_finalize),
 751         (on_button_edit_advanced_settings), (create_page_complete_custom),
 752         (on_response), (create_account):
 753         Implement the Advanced Settings edit button, by saving the account information,
 754         for the Advanded Settings dialog to use directly from gconf, and removing it
 755         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 756         Bug #5533 in the projects.maemo.org bugzilla.
 757
 758 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 759
 760         * src/maemo/modest-msg-view-window.c:
 761         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 762         when opening a message window.
 763
 764 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 765
 766         * src/maemo/easysetup/modest-easysetup-wizard.c:
 767         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 768         match the UI spec.
 769
 770         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 771         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 772         gconf settings. I probably added more checks than necessary, but that is safer.
 773
 774         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 775         variable to fix the build, but this seems to be used when it is still NULL.
 776
 777 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 778
 779         * src/modest-platform.h:
 780         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 781         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 782         * src/modest-main.c: Implement this function so we can avoid using
 783         maemo-specific API from cross-platform code.
 784         (main):
 785         * src/modest-tny-account-store.c:
 786         (get_smtp_specific_transport_account_for_open_connection):
 787         * src/modest-ui-actions.c: (check_for_connection),
 788         (modest_ui_actions_on_item_not_found):
 789         Use modest_platform_connect_and_wait() and put #idefs around other
 790         maemo-specific code, because only maemo currently has a way to
 791         identify connection names.
 792
 793 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 794
 795         * src/modest-tny-account-store.h:
 796         * src/modest-tny-account-store.c:
 797         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 798         the connection-specific SMTP server settings in the configuration.
 799
 800         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 801         (on_idle_mail_to):
 802         * src/maemo/modest-main-window.c: (on_connection_changed),
 803         (connect_signals):
 804         * src/modest-main.c: (main), (start_ui), (send_mail):
 805         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 806         that is what is intended.
 807
 808         * src/modest-ui-actions.c: (action_send), (action_receive),
 809         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 810         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 811         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 812         SMTP server is used when it is specified.
 813
 814         (modest_ui_actions_on_send_receive):
 815         Check that a connection is open before proceeding.
 816         Receive and then send, instead of vice-versa, as per the specification.
 817
 818 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 819
 820         * src/modest-mail-operation.c:
 821         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 822         though I guess it should be something other than NULL.
 823
 824 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 825
 826         * src/maemo/easysetup/modest-easysetup-wizard.c:
 827         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 828         combo twice, to avoid an g_warning and to make it visible again.
 829         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 830         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 831         (already intended) dereference when detaching, because we then recreate the menu.
 832         But I am not sure why the warning was happening, and it is possible that this is a memory
 833         leak.
 834
 835 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 836
 837         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 838         and uri_parse_mailto() utility functions.
 839         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 840         the mailto URI.
 841         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 842
 843 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 844
 845         * src/dbus_api/modest-dbus-api.h:
 846         * src/dbus_api/modest-dbus-callbacks.c:
 847         Use an idle callback to execute the modest code in the application's own thread.
 848         Remove the helloworld example method.
 849         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 850         parsed, and the open-message method is not implemented because this is not yet implemented in
 851         modest itself.
 852         * libmodest-dbus-client/libmodest-dbus-client.c:
 853         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 854         (libmodest_dbus_client_open_message):
 855         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 856
 857         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 858         body without crashing.
 859
 860         * tests/dbus_api/Makefile.am:
 861         * tests/dbus_api/test_mail_to.c:
 862         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 863
 864 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 865
 866         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 867         Added file to fix the build. Sorry.
 868
 869         * src/dbus_api/Makefile.am:
 870         * src/dbus_api/modest-dbus-api.h:
 871         * src/dbus_api/modest-dbus-callbacks.h:
 872         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 873         (modest_dbus_req_handler):
 874         Put constants in a separate header so it can be reused by the
 875         client library, without duplication
 876
 877         * libmodest-dbus-client/Makefile.am:
 878         * libmodest-dbus-client/libmodest-dbus-client.c:
 879         (libmodest_dbus_client_call_helloworld),
 880         (libmodfest_dbus_client_send_mail),
 881         (libmodfest_dbus_client_mailto),
 882         (libmodfest_dbus_client_open_message):
 883         * libmodest-dbus-client/libmodest-dbus-client.h:
 884         (Partly) Implement a send_mail D-Bus method.
 885
 886         * tests/dbus_api/Makefile.am:
 887         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 888         the send_email D-Bus method.
 889
 890 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 891
 892         * Makefile.am:
 893         * configure.ac:
 894         * libmodest-dbus-client/Makefile.am:
 895         * libmodest-dbus-client/libmodest-dbus-client.c:
 896         * libmodest-dbus-client/libmodest-dbus-client.h:
 897         * tests/dbus_api/Makefile.am:
 898         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 899         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 900
 901 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 902
 903         * src/maemo/easysetup/modest-easysetup-wizard.c:
 904         (create_page_account_details):
 905         * src/maemo/modest-account-settings-dialog.c:
 906         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 907         widgets, because this might not be the default in future versions of the Maemo GTK+.
 908         However, I can not not get capitalization to work even in a simple test case.
 909
 910 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 911
 912         * src/maemo/easysetup/modest-easysetup-wizard.c:
 913         (create_page_custom_incoming), (create_page_custom_outgoing):
 914         * src/maemo/modest-account-settings-dialog.c:
 915         (create_page_account_details), (create_page_incoming),
 916         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 917         instead of using gtk_check_button_with_label(), so they are aligned like the other
 918         widgets, as per the UI spec.
 919
 920 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 921
 922         * src/maemo/easysetup/modest-easysetup-wizard.c:
 923         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 924         * src/widgets/modest-validating-entry.c:
 925         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 926         Modest prefix instead of an EasySetup prefix.
 927
 928 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 929
 930         * src/widgets/modest-validating-entry.h:
 931         * src/widgets/modest-validating-entry.c: (on_insert_text),
 932         Added easysetup_validating_entry_set_max_func(), used to set a callback
 933         to call when the max number of characters is reached. GtkEntry has a max-length
 934         already but is silent about it.
 935
 936         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 937         (create_page_account_details), (create_page_user_details),
 938         (create_account):
 939         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 940         (create_page_account_details), (create_page_user_details),
 941         (create_page_outgoing):
 942         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 943         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 944         the UI spec, when the user tries to enter more than the max number of characters.
 945
 946 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 947
 948         * src/maemo/easysetup/modest-easysetup-wizard.c:
 949         (create_page_user_details), (create_page_custom_incoming),
 950         (create_page_custom_outgoing):
 951         * src/maemo/modest-account-settings-dialog.c:
 952         (create_page_user_details), (create_page_incoming),
 953         (create_page_outgoing):
 954         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 955         (modest_connection_specific_smtp_edit_window_init):
 956         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 957         not appropriate. Bad Maemo-specific defaults!.
 958
 959 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 960
 961         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 962         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 963         (modest_signature_editor_dialog_set_settings):
 964         Disable the label and textview when the checkbox is disabled, and use the
 965         specified (UI spec) default signature text.
 966
 967 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 968
 969         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 970         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 971
 972         * src/modest-defs.h:
 973         * src/modest-account-mgr-helpers.h:
 974         * src/modest-account-mgr-helpers.c:
 975         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 976
 977         * src/maemo/Makefile.am:
 978         * src/maemo/modest-signature-editor-dialog.c:
 979         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 980         as per the UI spec.
 981
 982         * src/maemo/modest-account-settings-dialog.h:
 983         * src/maemo/modest-account-settings-dialog.c:
 984         (modest_account_settings_dialog_finalize), (on_button_signature),
 985         (save_configuration): Use the new dialog when the Edit button is pressed, and
 986         save the changes if necessary, as per the UI spec.
 987
 988 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 989
 990         * src/maemo/Makefile.am:
 991         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 992         based on maemo-develoers email from Dirk.
 993
 994         * src/maemo/easysetup/modest-easysetup-wizard.c:
 995         (create_page_welcome), (create_page_account_details),
 996         (create_page_user_details), (create_page_complete_easysetup),
 997         (create_page_custom_incoming), (create_page_custom_outgoing),
 998         (create_page_complete_custom),
 999         (modest_easysetup_wizard_dialog_init):
1000         * src/maemo/modest-account-settings-dialog.c:
1001         (create_page_account_details), (create_page_user_details),
1002         (create_page_incoming), (create_page_outgoing),
1003         (modest_account_settings_dialog_init):
1004         * src/maemo/modest-connection-specific-smtp-window.c:
1005         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1006
1007 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
1008
1009         * src/maemo/easysetup/modest-easysetup-wizard.c:
1010         (create_page_account_details), (create_page_custom_outgoing),
1011         (create_page_complete_custom):
1012         * src/maemo/modest-account-settings-dialog.c:
1013         (create_page_user_details), (create_page_incoming),
1014         (create_page_outgoing):
1015         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1016         (modest_connection_specific_smtp_edit_window_init):
1017         Use the correct (UI spec) port min/max, and use horizontal separators,
1018         as per the UI spec.
1019
1020 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
1021
1022         * src/maemo/easysetup/modest-easysetup-wizard.c:
1023         (set_default_custom_servernames):
1024         * src/maemo/modest-account-settings-dialog.c:
1025         (create_page_incoming), (on_combo_outgoing_security_changed),
1026         (on_combo_incoming_security_changed), (create_page_outgoing),
1027         (modest_account_settings_dialog_set_account_name),
1028         (save_configuration):
1029         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1030         (on_combo_security_changed),
1031         (modest_connection_specific_smtp_edit_window_init),
1032         (modest_connection_specific_smtp_edit_window_set_connection),
1033         (modest_connection_specific_smtp_edit_window_get_settings):
1034         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1035         as per the UI spec.
1036
1037 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1038
1039         * po/en_GB.po:
1040         * src/maemo/easysetup/modest-easysetup-wizard.c:
1041         (create_page_custom_outgoing), (create_page_complete_custom):
1042         * src/maemo/modest-account-settings-dialog.c:
1043         (create_page_user_details), (create_page_outgoing):
1044         * src/maemo/modest-account-view-window.c: (button_box_new):
1045         Use changed logical IDs as per the most recent UI spec:
1046         mcen_bd_emailsetup_edit -> mcen_bd_edit
1047         mcen_bd_emailsetup_delete -> mcen_bd_delete
1048         mcen_bd_emailsetup_close -> mcen_bd_close
1049
1050 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1051
1052         * configure.ac:
1053         * src/Makefile.am:
1054         * src/dbus_api/Makefile.am:
1055         * src/dbus_api/modest-dbus-callbacks.c:
1056         * src/dbus_api/modest-dbus-callbacks.h:
1057         * src/maemo/modest-platform.c: (modest_platform_init):
1058         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1059         method.
1060         * tests/Makefile.am:
1061         * tests/dbus_api/Makefile.am:
1062         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1063
1064 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1065
1066         * src/maemo/modest-account-settings-dialog.c:
1067         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1068         Removed unnecessary includes.
1069
1070 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1071
1072         * src/maemo/easysetup/modest-easysetup-wizard.c:
1073         * src/maemo/modest-account-settings-dialog.c:
1074         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1075         * src/widgets/Makefile.am:
1076         * src/widgets/modest-easysetup-secureauth-combo-box.c:
1077         * src/widgets/modest-easysetup-secureauth-combo-box.h:
1078         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1079         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1080         * src/widgets/modest-secureauth-combo-box.c:
1081         * src/widgets/modest-secureauth-combo-box.h:
1082         * src/widgets/modest-serversecurity-combo-box.c:
1083         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1084         made the GObject names more consistent with the rest of the Modest code.
1085
1086 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1087
1088         * src/maemo/easysetup/Makefile.am:
1089         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1090         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1091         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1092         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1093         * src/maemo/easysetup/modest-easysetup-wizard.c:
1094         * src/maemo/easysetup/modest-validating-entry.c:
1095         * src/maemo/easysetup/modest-validating-entry.h:
1096         * src/maemo/modest-account-settings-dialog.c:
1097         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1098         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1099         widgets/ because they are used outside of easysetup too. After checking in,
1100         svn will allow me to rename them too.
1101
1102 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1103
1104         * src/gnome/modest-msg-edit-window.c:
1105         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1106         linker error, to fix the build on the GNOME platform.
1107         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1108         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1109         ifdefed out to avoid a warning.
1110
1111 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1112
1113         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1114         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1115         some alternative for GTK+ 2.6.
1116
1117 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
1118
1119         * src/maemo/modest-address-book.c: Added include to avoid a warning.
1120
1121         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1122         specified for EmailAccountsDialog in UI spec.
1123
1124         * src/maemo/easysetup/modest-easysetup-wizard.c:
1125         * src/maemo/easysetup/modest-easysetup-wizard.h:
1126         * src/maemo/modest-account-settings-dialog.c:
1127         * src/maemo/modest-account-settings-dialog.h:
1128         Reuse a member window widget for the connection-specific SMTP server accounts,
1129         so we can tell it to create/save the accounts only if we actually save changes.
1130
1131         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1132         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1133         (modest_connection_specific_smtp_edit_window_get_settings):
1134         Return a struct instance for temporarily remembering the entered data.
1135
1136         * src/maemo/modest-connection-specific-smtp-window.h:
1137         * src/maemo/modest-connection-specific-smtp-window.c:
1138         (modest_connection_specific_smtp_window_finalize),
1139         (modest_connection_specific_smtp_window_fill_with_connections),
1140         (on_button_edit),
1141         (modest_connection_specific_smtp_window_save_server_accounts),
1142         (update_model_server_names): Do not actually save data until asked,
1143         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1144
1145         (on_selection_changed),
1146         (modest_connection_specific_smtp_window_init): Disable the edit
1147         button when nothing is selected.
1148
1149         * src/modest-account-mgr-helpers.c:
1150         * src/modest-account-mgr-helpers.h:
1151         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1152         elsewhere.
1153
1154 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
1155
1156         * src/modest-account-mgr-helpers.h:
1157         * src/modest-account-mgr-helpers.c:
1158         (modest_account_mgr_get_unused_account_name),
1159         (modest_account_mgr_get_unused_account_display_name): Added these
1160         utility functions, to avoid code duplication.
1161
1162         * src/maemo/easysetup/modest-easysetup-wizard.c:
1163         (create_page_account_details), (create_account):
1164         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1165         (on_combo_security_changed),
1166         (modest_connection_specific_smtp_edit_window_init),
1167         (modest_connection_specific_smtp_edit_window_save_settings):
1168         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1169         * src/maemo/modest-connection-specific-smtp-window.c:
1170         (modest_connection_specific_smtp_window_finalize),
1171         (modest_connection_specific_smtp_window_fill_with_connections),
1172         (on_button_edit), (modest_connection_specific_smtp_window_init):
1173         * src/maemo/modest-connection-specific-smtp-window.h:
1174         Implementing saving of connection-specific server accounts.
1175
1176         But I need to refactor this so we can save the data for each
1177         possible connection-specific account and only actually create the server accounts
1178         when the easysetup finished, or the OK button is pressed on the account settings
1179         dialog.
1180
1181 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1182
1183         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1184         (on_combo_security_changed):
1185         (modest_connection_specific_smtp_edit_window_init):
1186         Auto-fill the port number as in the account settings.
1187
1188         (modest_connection_specific_smtp_edit_window_set_connection):
1189         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1190         * src/maemo/modest-connection-specific-smtp-window.c:
1191         (fill_with_connections), (on_button_edit),
1192         (modest_connection_specific_smtp_window_init):
1193         Turn the edit window into a dialog to simplify the code, and
1194         set a WM hint as in a GtkDialog, because only a popup can be on top of
1195         another window in Maemo, and popups usually have no WM decoration.
1196
1197         * src/modest-defs.h:
1198         * src/modest-account-mgr-helpers.c:
1199         (modest_account_mgr_set_connection_specific_smtp),
1200         (modest_account_mgr_remove_connection_specific_smtp),
1201         (modest_account_mgr_get_connection_specific_smtp):
1202         * src/modest-account-mgr-helpers.h: Some functions to write the
1203         connection-specific SMTP server information. Not yet used.
1204
1205
1206         * src/widgets/modest-folder-view.c: (text_cell_data):
1207         Fix a warning about an uninitialized variable.
1208         (on_configuration_key_changed): Put an #ifdef around the use
1209         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1210
1211 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1212
1213         * src/maemo/modest-account-settings-dialog.h:
1214         * src/maemo/modest-account-settings-dialog.c:
1215         Added connect_for_modified() utility function to mark the new modified boolean.
1216
1217         (create_page_account_details), (create_page_user_details),
1218         (create_page_incoming), (create_page_outgoing), (on_response),
1219         (modest_account_settings_dialog_init),
1220         (modest_account_settings_dialog_set_account_name):
1221         Only warn about unsaved changes when there are actually unsaved changes.
1222
1223         * src/modest-account-mgr-helpers.c:
1224         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1225         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1226         to get the data from there in future.
1227
1228 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1229
1230         * src/modest-defs.h:
1231
1232         * src/modest-account-mgr-helpers.h:
1233         * src/modest-account-mgr-helpers.c:
1234         Store the security account setting in a single conf key instead of using
1235         the options list, so that the list is left for just the to-be-removed camel hack,
1236         and because gconf_client_set_list() is failing for some reason.
1237
1238         * src/modest-account-mgr.c:
1239         (modest_account_mgr_add_server_account):
1240         * src/maemo/modest-account-settings-dialog.c:
1241         (modest_account_settings_dialog_set_account_name),
1242         (save_configuration): Use the renamed functions.
1243
1244
1245 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1246
1247         * src/widgets/Makefile.am:
1248         * src/widgets/modest-limit-retrieve-combo-box.c:
1249         * src/widgets/modest-limit-retrieve-combo-box.h:
1250         * src/widgets/modest-retrieve-combo-box.c:
1251         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1252         the account settings dialog.
1253
1254         * src/modest-defs.h:
1255         * src/modest-account-mgr-helpers.h:
1256         * src/modest-account-mgr-helpers.c:
1257         (modest_server_account_get_option_secure_auth),
1258         (modest_server_account_set_option_secure_auth):
1259         * src/modest-account-mgr.c:
1260         (modest_account_mgr_add_server_account):
1261         Use the existing AUTH_MECH conf key for the secure-auth setting,
1262         instead of putting it in the list options, because this was actually used already.
1263
1264         * src/maemo/modest-account-settings-dialog.c:
1265         (create_page_account_details),
1266         (modest_account_settings_dialog_set_account_name),
1267         (save_configuration):
1268         * src/maemo/modest-account-settings-dialog.h:
1269         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1270         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1271
1272 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1273
1274         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1275         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1276         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1277
1278         * src/modest-defs.h:
1279         * src/maemo/modest-account-settings-dialog.c:
1280         (create_page_incoming), (on_combo_outgoing_security_changed),
1281         (on_combo_incoming_security_changed), (create_page_outgoing),
1282         (modest_account_settings_dialog_set_account_name),
1283         (save_configuration): Load/Save the port number, and change it when the
1284         security combo changes, to suitable defaults.
1285
1286 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1287
1288         * src/modest-account-mgr.c:
1289         (modest_account_mgr_add_server_account): Set the security and secure-auth
1290         options, and add a comment saying that the other camel-specific options should be
1291         removed in future.
1292
1293 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1294
1295         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1296         found by valgrind.
1297         * src/modest-tny-account-store.c: (account_list_free),
1298         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1299         cursor->data after unreffing it. But there is some strange stuff there so it might not be
1300         easy to fix.
1301
1302 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1303
1304         * src/modest-protocol-info.c:
1305         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1306         is required by our UI spec. Maybe something in our implementation will use this eventually.
1307         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1308         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1309         instead of the previous 0 placeholder.
1310
1311         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1312         secure-auth settings.
1313         * src/modest-account-mgr-helpers.h:
1314         * src/modest-account-mgr-helpers.c:
1315         (modest_server_account_data_get_option_secure_auth),
1316         (modest_server_account_set_option_secure_auth),
1317         (modest_server_account_data_get_option_security),
1318         (modest_server_account_set_option_security): Added this API for getting and setting the security
1319         and secure-auth settings.
1320
1321         * src/maemo/modest-account-settings-dialog.h:
1322         * src/maemo/modest-account-settings-dialog.c:
1323         (modest_account_settings_dialog_finalize), (check_data),
1324         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1325         about changing titles.
1326         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1327         (save_configuration): Save the security and secure-auth settings.
1328
1329         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1330         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1331
1332 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1333
1334         * src/modest-defs.h:
1335         * src/modest-account-mgr.c:
1336         (modest_account_mgr_add_server_account):
1337         Added and used defines for the options key and value pair strings,
1338         that are used so far, though they do not seem to correspond to anything in our
1339         UI specs or ModestProtocol enum.
1340
1341         * src/modest-account-mgr-helpers.h:
1342         * src/modest-account-mgr-helpers.c:
1343         (compare_option_strings_for_name),
1344         (modest_server_account_data_get_option_value),
1345         (modest_server_account_data_get_option_bool),
1346         (modest_account_mgr_get_server_account_option):
1347         Added helper functions for parsing the options GSList.
1348
1349 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1350
1351         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1352         display name is based on the supplied account name.
1353         * src/modest-account-mgr.c:
1354         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1355         with an inefficient, but good-enough, implementation.
1356
1357         * src/maemo/easysetup/modest-easysetup-wizard.c:
1358         (create_page_account_details), (on_before_next), (create_account):
1359         Check for existing display names rather than (non-user-visible) account names, and just
1360         create and set a unique account name at the end.
1361
1362         * src/maemo/modest-account-settings-dialog.c:
1363         (modest_account_settings_dialog_init),
1364         (modest_account_settings_dialog_set_account_name),
1365         (create_page_incoming): Show the display name, instead of the account name.
1366         (on_response): Do some (not all) extra checks, as in the UI spec.
1367         (save_configuration): Save the display name if it was changed.
1368
1369 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1370
1371         * po/en_GB.po: Added needed logical ID and translation.
1372         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1373         (init_view): Made the is-default column clicking work.
1374
1375 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1376
1377         * configure.ac:
1378         * src/maemo/easysetup/Makefile.am:
1379         * src/maemo/easysetup/modest-easysetup-wizard.c:
1380         (modest_easysetup_wizard_dialog_init):
1381         * src/maemo/easysetup/provider-data-test.keyfile:
1382         * src/maemo/easysetup/provider-data.keyfile:
1383         Moved the provider data file to the new modest-providers-data package and used it from there.
1384
1385 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1386
1387         * src/modest-local-folder-info.c:
1388         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1389         N_() was already used on the static strings, but this just marks it for translation without
1390         using the translation.
1391
1392 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1393
1394         * src/maemo/modest-account-settings-dialog.c:
1395         (create_page_incoming),
1396         (modest_account_settings_dialog_set_account_name):
1397         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1398         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1399         I will do this if nobody else gets there first.
1400
1401 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1402
1403         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1404         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1405         save the security stuff.
1406
1407 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1408
1409         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1410         Set the email address and user fullname, which I now see must be
1411         done separately.
1412
1413         * src/maemo/modest-account-settings-dialog.h:
1414         * src/maemo/modest-account-settings-dialog.c:
1415          (on_response),
1416         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1417         leave-on-server and authentication.
1418         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1419         how to do the rest.
1420
1421 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1422
1423
1424         * src/maemo/modest-account-settings-dialog.c:
1425         * src/maemo/modest-account-settings-dialog.h:
1426         Most (but not all) of the widgets are now present as specified by the UI spec.
1427         No changes are yet saved, and some details are not properly shown yet.
1428
1429         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1430
1431 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1432
1433         * src/maemo/Makefile.am:
1434         * src/maemo/modest-account-settings-dialog.c:
1435         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1436         an existing account. Doesn't do much yet.
1437
1438         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1439         Open the accounts settings dialog when Edit is clicked.
1440
1441 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1442
1443         * src/maemo/easysetup/Makefile.am:
1444         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1445         (load_from_file):
1446         * src/maemo/easysetup/modest-easysetup-wizard.c:
1447         (modest_easysetup_wizard_dialog_init):
1448         Try to get the source directory from the build system,
1449         instead of hard-coding "./" into the source code, when opening our local
1450         copies of the configuration files.
1451         But this still fails when opening the wizard from the Accounts window,
1452         maybe because the working directory seems to change at runtime.
1453         So the wizard will fail the second time unless you copy the files into their
1454         proper locations - see the stdout warnings for the paths.
1455
1456         (create_page_account_details),(on_before_next):
1457         Check for existing non-server accounts instead of server accounts,
1458         so the default account name is useful again, and to prevent trying to
1459         recreate accounts.
1460
1461         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1462         Show the wizard when New is clicked.
1463
1464         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1465         (init_view): Show the column headers, and show the columns that are
1466         specified in the UI specs. However, something in Maemo's GTK+ prevents
1467         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1468         change the default account. This is despite unsetting the special properties.
1469
1470 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1471
1472         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1473         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1474         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1475         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1476         to make that clearer.
1477         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1478
1479 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1480
1481         * src/maemo/modest-account-view-window.c:
1482         (modest_account_view_window_init),
1483         (modest_account_view_window_new):
1484         Use the same buttons as specified in the
1485         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1486         the existing widgets, which never had a chance of working.
1487         Put the ModestAccountView treeview in a scrolled window.
1488         Do not repeat the initialization in both _init() and _new().
1489
1490         * src/widgets/modest-account-view.c: (update_account_view):
1491         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1492         this widget and window shows no accounts.
1493
1494         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1495
1496 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1497
1498         * src/maemo/easysetup/modest-easysetup-wizard.c:
1499         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1500         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1501         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1502         which seems wrong.
1503
1504         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1505         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1506         accounts exist yet, as in the UI spec.
1507
1508         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1509
1510 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1511
1512         * src/maemo/Makefile.am:
1513         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1514         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1515         New window for editing connection-specific smtp details.
1516         Not fully implemented.
1517
1518         * src/maemo/modest-connection-specific-smtp-window.c:
1519         (modest_connection_specific_smtp_window_finalize) :
1520         unref the tree model.
1521         (on_button_edit): Show the edit window.
1522
1523 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1524
1525         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1526         error for me.
1527
1528         * src/maemo/Makefile.am:
1529         * src/maemo/modest-connection-specific-smtp-window.c:
1530         * src/maemo/modest-connection-specific-smtp-window.h:
1531         New window for showing the list of connections, for connection-specific
1532         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1533         * src/maemo/easysetup/modest-easysetup-wizard.c:
1534         (create_page_custom_outgoing): Show the new window when the button is clicked.
1535
1536 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1537
1538         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1539         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1540         * src/maemo/modest-msg-edit-window.c:
1541         (modest_msg_edit_window_insert_image):
1542         * src/modest-conf.c: (modest_conf_key_escape):
1543         * src/modest-mail-operation.c:
1544         (modest_mail_operation_send_new_mail):
1545         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1546         (modest_ui_actions_on_new_account):
1547         * src/widgets/modest-attachment-view.c: (update_filename_request):
1548         * src/widgets/modest-mail-header-view.c:
1549         Corrected warnings that were breaking the build, by commenting out unused variables,
1550         and a function, and by including a header.
1551
1552 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1553
1554         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1555         so we can #ifdef around platform-specific code when necessary.
1556         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1557         to allow this to build for the GNOME platform too.
1558
1559 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1560
1561         * src/maemo/easysetup/modest-easysetup-wizard.c:
1562         Added util_increment_name() and used it in create_page_account_details()
1563         to make sure that the default account name is always a new name.
1564
1565         (modest_easysetup_wizard_dialog_init),
1566         (set_default_custom_servernames): Some minor memory management fixes.
1567
1568 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1569
1570         * Makefile.am:
1571         * configure.ac:
1572         * src/modest-runtime.c: (init_i18n): Restored the translation
1573         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1574         are defined in config.h, and the translations are installed.
1575
1576         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1577         is defined for translation.
1578
1579 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1580
1581         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1582         (load_from_file):
1583         * src/maemo/easysetup/modest-easysetup-wizard.c:
1584         (modest_easysetup_wizard_dialog_init):
1585         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1586         Use realistic paths (though they should use $prefix generically) to the
1587         mcc_mapping and provider-data.keyfile files which might work when they
1588         are installed by the future version of the operator-wizard package,
1589         and then fallback to paths in our source code, with an explanatory
1590         warning.
1591
1592 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1593
1594         * configure.ac:
1595         * src/Makefile.am:
1596         * src/maemo/Makefile.am:
1597         * src/maemo/easysetup/: Added files from the previously-exernal
1598         osso-modest-easysetup.
1599         * src/maemo/modest-main-window-ui.h:
1600         * src/modest-ui-actions.c:
1601         * src/modest-ui-actions.h:
1602         Added modest_ui_actions_on_new_account() as a signal handler for the
1603         New Account menu item. It shows the easysetup wizard.
1604         * po/en_GB.po: Added additional needed logical IDs and translations.
1605
1606 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1607 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1608