1 2007-07-23 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c:
4 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
5 because their ID is not human-readable (see the comment about
6 improvements needed to the osso-email-interface API) and
7 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
9 2007-07-23 Murray Cumming <murrayc@murrayc.com>
11 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
12 (add_folders_to_list), (on_dbus_method_get_folders),
13 (modest_dbus_req_filter):
14 * src/maemo/modest-maemo-utils.c:
15 (on_camel_account_get_supported_secure_authentication):
16 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
17 (on_header_view_focus_in):
18 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
19 * src/modest-formatter.c: (modest_formatter_create_body_part):
20 * src/modest-mail-operation.c: (recurse_folders),
21 (update_account_thread), (get_msgs_full_thread),
22 (modest_mail_operation_get_msgs_full),
23 (modest_mail_operation_xfer_msgs):
24 * src/modest-search.c: (search_mime_part_and_child_parts),
25 (modest_search_account), (modest_search_all_accounts):
26 * src/modest-tny-account.c:
27 (modest_tny_account_get_special_folder), (recurse_folders):
28 * src/modest-tny-local-folders-account.c:
29 (modest_tny_local_folders_account_query_passes):
30 * src/modest-tny-msg.c: (copy_mime_part),
31 (modest_tny_msg_find_body_part_from_mime_part):
32 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
33 (modest_tny_send_queue_try_to_send):
34 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
35 (_modest_ui_actions_open), (download_uncached_messages),
36 (reply_forward), (modest_ui_actions_on_copy),
37 (modest_ui_actions_on_details), (has_retrieved_msgs),
38 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
40 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
41 (_selected_msg_marked_as), (_msg_download_completed),
42 (_selected_msg_sent_in_progress):
43 * src/widgets/modest-attachments-view.c:
44 (modest_attachments_view_set_message):
45 * src/widgets/modest-msg-view.c: (find_cid_image):
46 * tests/check_folder-transfer.c: (find_folders):
47 * tests/check_update-account.c: (func):
48 * tests/dbus_api/test_get_folders.c: (main):
49 Checked all uses of tny_iterator_get_current(), making sure
50 that the object is unreferenced (3 or 4 places did not),
51 and adding checks for NULL.
53 2007-07-23 Murray Cumming <murrayc@murrayc.com>
55 * src/dbus_api/modest-dbus-callbacks.c:
56 (on_idle_open_default_inbox): Make sure that the application UI is
58 * src/maemo/easysetup/modest-easysetup-wizard.c:
59 (on_entry_invalid_character): Show the word whitespace instead
60 of (null) in the banner when whitespace was entered.
61 (show_error): Add a comment that this does not work in
62 Maemo Bora, though we do not know why.
64 2007-07-23 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-tny-account.c:
67 (modest_tny_account_get_special_folder): Use an if instead of
68 an assert for when the parent account name is NULL, because this
69 might be causing a crash in projects.maemo.org bug 63192.
70 * src/modest-mail-operation.c:
71 (modest_mail_operation_send_new_mail_cb),
72 (modest_mail_operation_remove_folder): unref the folder that is
73 returned from modest_tny_account_get_special_folder().
75 2007-07-23 Murray Cumming <murrayc@murrayc.com>
77 * src/modest-ui-actions.c:
78 (modest_ui_actions_on_password_requested):
79 Show mail_ib_login_cancelled info banner when the user cancels
80 the protected password dialog, to fix projects.maemo.org
83 2007-07-23 Murray Cumming <murrayc@murrayc.com>
85 * src/maemo/modest-account-settings-dialog.c:
86 (create_page_outgoing): Put this page in a GtkScrolledWindow,
87 matching the UI mock-up in the UI spec, and allowing access
88 to all widgets even when the on-screen keyboard is active.
90 2007-07-23 Murray Cumming <murrayc@murrayc.com>
92 Reverted this previous commit from Johannes,
93 because the scrollbars are always visible and because
94 I think we only need it on onepage of the account
95 settings, not the account wizard.
96 (I wrote the wrong instructions in the bug.)
98 * src/maemo/easysetup/modest-easysetup-wizard.c:
99 Added scrollbars to account wizard dialog.
100 Fixed projects.maemo.org NB #62744
102 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
104 * src/maemo/easysetup/modest-easysetup-wizard.c:
105 (create_page_user_details):
106 Use auto-cap for name (projects.maemo.org NB#63716)
107 * src/widgets/modest-account-view.c: (on_account_busy_changed):
109 2007-07-22 Armin Burgmeier <armin@openismus.com>
111 * src/maemo/modest-ui-actions.c: Use current account instead of
112 default account for creating viewer windows, so that the viewer
113 window knows to which account the viewed message belongs.
115 * src/maemo/modest-msg-view-window.c: Destroy the window when the
116 corresponding account is deleted. This fixes projects.maemo.org bug
119 2007-07-18 Armin Burgmeier <armin@openismus.com>
121 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
122 the dialog close after entering an invalid port number and clicking
123 OK. This fixes projects.maemo.org bug NB#63602.
125 2007-07-18 Armin Burgmeier <armin@openismus.com>
127 * src/modest-tny-account-store.c:
128 (get_server_accounts): Set parent modest account name for each
129 connection-specific transport account so that special folders of such
130 an account can be looked up. This fixes a crash when changing account
131 settings. This might also be related to projects.maemo.org bug
134 2007-07-16 Armin Burgmeier <armin@openismus.com>
136 * src/modest-ui-actions.c: Added a button to create a folder to the
137 move-to dialog. This fixes projects.maemo.org bug NB#.
139 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
141 * src/maemo/easysetup/modest-easysetup-wizard.c:
142 Added scrollbars to account wizard dialog.
143 Fixed projects.maemo.org NB #62744
145 2007-07-16 Murray Cumming <murrayc@murrayc.com>
147 * src/widgets/modest-msg-view.h:
148 * src/widgets/modest-msg-view.c:
149 Added modest_msg_view_get_message_is_empty() but this needs
151 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
152 Check if there is any text in the message yet.
153 But this needs to be implemented properly.
154 (modest_msg_edit_window_toggle_find_toolbar):
155 * src/maemo/modest-msg-view-window.c:
156 (modest_msg_view_window_toggle_find_toolbar):
157 Show a banner warning if there is no text to search, when
158 trying to start a search. This partially fixes
159 projects.maemo.org bug NB#62350.
161 2007-07-13 Murray Cumming <murrayc@murrayc.com>
163 * src/modest-mail-operation.c: (update_account_thread):
164 Initialized num_new_headers to fix the build.
166 2007-07-13 Murray Cumming <murrayc@murrayc.com>
168 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
169 Ignore modest accounts whose server accounts don't exist in gconf.
170 This prevents us trying to create TnyAccount instances for those
171 server accounts when the server account has been removed from gconf,
172 but the parent modest account has not yet been removed from modest.
173 I don't know why this is only noticeable now. It was probably just
174 a harmeless g_warning() anyway.
176 2007-07-13 Murray Cumming <murrayc@murrayc.com>
178 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
179 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
181 2007-07-12 Armin Burgmeier <armin@openismus.com>
183 * src/maemo/modest-main-window.c: Make default account appear bold
184 in view, tools/send & receive and toolbar/send & receive SCM menus.
185 This fixes projects.maemo.org bug NB#59010.
187 2007-07-12 Murray Cumming <murrayc@murrayc.com>
189 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
190 Add a short-cut, by checking if the folder store is an account.
191 This ensures that the Sort menu item and toolbar is dimmed for
192 the local-folders account root item, fixing
193 projects.maemo.org bug NB#62545.
195 2007-07-12 Murray Cumming <murrayc@murrayc.com>
197 * src/modest-tny-account-store.c: (get_password):
198 Show the password dialog (via the signal) only in the mainloop, via
199 an idle handler that we wait for. This could theoretically prevent
200 hangs, though I worry that it could introduce some too.
202 2007-07-12 Murray Cumming <murrayc@murrayc.com>
204 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
205 * src/maemo/modest-platform.c:
206 (modest_platform_connect_and_wait):
207 Take a TnyAccount* parameter and try to set it to online
208 (a TnyCamel-only API), because tinymail sets accounts to offline
209 when the user cancels a password dialog, and doesn't ask again until
210 it has been set to online.
211 However, this is commented out because it causes a hang now.
213 (modest_platform_connect_and_wait_if_network_account):
214 * src/modest-mail-operation.c:
215 (modest_mail_operation_update_account):
216 * src/modest-platform.h:
217 * src/modest-ui-actions.c: (_modest_ui_actions_open),
218 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
220 2007-07-12 Armin Burgmeier <armin@openismus.com>
222 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
224 * src/modest-mail-operation.c:
225 * src/modest-ui-actions.c: Check for already existing folder before
226 querying the server, show error message from camel if the request
227 still fails. This fixes projects.maemo.org bug NB#58701.
229 2007-07-12 Murray Cumming <murrayc@murrayc.com>
231 * src/modest-tny-account-store.h:
232 * src/modest-tny-account-store.c:
233 Added modest_tny_account_store_forget_password_in_memory(),
234 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
235 when creating a new account, so that new passwords will be used, instead of
236 us thinking that it's a second request as a result of a failed password again.
238 2007-07-12 Murray Cumming <murrayc@murrayc.com>
240 * src/dbus_api/modest-dbus-callbacks.c:
241 (on_idle_open_message): If the message is in drafts then open it
242 in an edit window instead of a view window. This fixes
243 projects.maemo.org bug NB#63005.
245 2007-07-12 Murray Cumming <murrayc@murrayc.com>
247 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
248 Avoided a harmless g_warning().
250 2007-07-12 Murray Cumming <murrayc@murrayc.com>
252 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
253 Pass the modest account name, not the TnyAccount display name to
254 modest_msg_view_window_new() so that the reply feature works,
255 fixing projects.maemo.org bug NB#62892.
257 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
258 (modest_msg_view_window_new_with_header_model):
259 * src/maemo/modest-msg-view-window.c:
260 (modest_msg_view_window_new_with_header_model),
261 (modest_msg_view_window_new):
262 * src/modest-ui-actions.c: (reply_forward):
263 * src/widgets/modest-msg-view-window.h:
264 * src/widgets/modest-window.c: (modest_window_set_active_account):
265 Rename an account parameter to modest_account_name to make this clearer.
267 2007-07-11 Murray Cumming <murrayc@murrayc.com>
269 * src/modest-ui-actions.h:
270 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
271 modest_do_message_delete().
272 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
273 Call modest_do_message_delete(), hoping that this would cause messages
274 to be really deleted from search instead of just marked with strike through.
275 Does not seem to help.
277 2007-07-11 Armin Burgmeier <armin@openismus.com>
279 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
280 priv->reselect to FALSE prior to calling
281 modest_folder_view_select_first_inbox_or_local() to prevent endless
282 recursion and thus a crash on startup.
284 2007-07-11 Armin Burgmeier <armin@openismus.com>
286 * src/maemo/modest-account-settings-dialog.h: Include
287 <gtk/gtknotebook.h> to fix the build (at least for me).
289 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
290 Use "New FolderN" as default suggested name if "New folder" already
291 exists, with N being the first free number, though never exceed "New
292 folder99" in which case we just fall back to "New Folder" even though
293 it already exists. This fixes projects.maemo.org bug NB#58663.
295 2007-07-11 Murray Cumming <murrayc@murrayc.com>
297 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
298 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
299 projects.maemo.org bug NB#62778.
301 2007-07-11 Murray Cumming <murrayc@murrayc.com>
303 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
304 Ignore the wrong (for now) secure-smtp setting in the presets -
305 just default to requiring secure authentication for SMTP, because
308 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
310 * src/widgets/modest-folder-view.c: (filter_row)
311 Do not show drafts folder (see UI specs)
313 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
315 * src/modest-ui-actions.c:
316 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
317 place and also not necessary.
319 * src/widgets/modest-folder-view.c: (filter_row)
320 Guess folder type and hide Sent & Outbox if necessary.
321 Fixed project.maemo.org NB#57328
323 2007-07-11 Murray Cumming <murrayc@murrayc.com>
325 * src/modest-ui-actions.h:
326 * src/modest-ui-actions.c:
327 (modest_ui_actions_on_delete_message):
328 Move some code into a new
329 modest_ui_actions_refresh_message_window_after_delete()
330 function so we can use it from elsewhere.
332 * src/dbus_api/modest-dbus-callbacks.c:
333 (on_idle_delete_message), (on_delete_message): Used an idle
334 handler, as we do for the other D-Bus method handlers.
335 Call modest_ui_actions_refresh_message_window_after_delete()
336 if the deleted message was open in a window. This fixed
337 projects.maemo.org bug NB#62862.
339 2007-07-11 Murray Cumming <murrayc@murrayc.com>
341 * src/modest-main.c: (main): Only show the UI at the start if
342 the showui command line option was given. For instance,
343 run-standalone src/modest showui
344 Otherwise, we wait for the top_application D-Bus method to
345 be sent by hildon-desktop when the application is selected
347 This allows us to run without a UI when osso-global-search
348 uses our D-Bus methods.
350 2007-07-11 Murray Cumming <murrayc@murrayc.com>
352 * src/dbus_api/modest-dbus-api.h: Added a define for a
353 top-application D-Bus method.
354 * src/dbus_api/modest-dbus-callbacks.c:
355 (on_top_application),
356 (modest_dbus_req_handler): Handle the top-application D-Bus
357 method, which might be an undocumented D-Bus signal sent by
358 hildon-desktop when it starts the application from the menu.
359 But I am not sure and I need to test it on the device, because
360 my scratchbox does not have the application in the menu now.
361 This method shows the main window, so that it can be invisible
362 when started, for instance, just for email searching from
365 * src/maemo/modest-main-window.c: (restore_settings),
366 (modest_main_window_new): Do not show the window immediately
367 upon creation. We show it later.
368 * src/modest-widget-memory.c: (save_settings_paned):
369 Try (unsuccessfully) to avoid saving the paned position when
370 it is not even visible.
371 (restore_settings_paned): Do not allow a silly paned position.
372 This seems necessary when not showing the window at first.
374 * tests/dbus_api/Makefile.am:
375 * tests/dbus_api/test_top_application.c: (main): Test for the
378 2007-07-10 Murray Cumming <murrayc@murrayc.com>
380 * src/modest-ui-dimming-rules.c:
381 (modest_ui_dimming_rules_on_new_msg),
382 (modest_ui_dimming_rules_on_reply_msg),
383 (modest_ui_dimming_rules_on_delete_msg),
384 (modest_ui_dimming_rules_on_details),
385 (modest_ui_dimming_rules_on_view_window_move_to),
386 (modest_ui_dimming_rules_on_view_previous),
387 (modest_ui_dimming_rules_on_view_next),
388 (_invalid_folder_for_purge): Added checks before
389 casting the window. This looks like an actual
390 logic error in _invalid_folder_for_purge(), because it
391 tries to use a ModestMainWindow as a message window.
393 2007-07-10 Murray Cumming <murrayc@murrayc.com>
395 * src/maemo/modest-account-settings-dialog.c:
396 (show_error): Use the same implementation as in
397 modest-easysetup-wizard.c:
398 (on_entry_invalid_character): The logical ID contains a %s.
399 Guessed what it should be.
400 (on_entry_max), (check_data), (on_response): Adapt to
401 changed show_error().
402 (create_page_account_details): Really call
403 modest_validating_entry_set_func() on the correct widgets.
404 * src/maemo/easysetup/modest-easysetup-wizard.c:
405 (on_entry_invalid_character): Fix the logical ID here too.
406 (create_page_account_details),
407 (create_page_user_details):
409 modest_validating_entry_set_func() on the correct widgets.
411 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
412 Do not try to use the account if it is NULL.
414 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
416 * src/modest-ui-actions.c: (create_move_to_dialog),
417 (modest_ui_actions_on_main_window_move_to),
418 (modest_ui_actions_on_msg_view_window_move_to):
419 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
420 (filter_row), (modest_folder_view_show_non_move_folders):
421 * src/widgets/modest-folder-view.h:
423 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
424 the Sent folder yet as it does not report the correct folder type.
426 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
428 * src/maemo/modest-msg-edit-window.c: (init_window):
431 2007-07-10 Murray Cumming <murrayc@murrayc.com>
433 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
434 Take a parent widget instead of a parent window, and
435 implement this with hildon_banner_show_information() instead.
436 Non-Maemo builds can just ifdef that there.
437 This fixed projects.maemo.org bug NB#62766.
439 (on_entry_invalid_character): Use show_error() again instead
440 of using hildon directly, and use the _CS() macro to use the correct
442 (create_account), (check_for_supported_auth_methods), (on_entry_max):
443 Pass a widget instead od a window to show_error().
445 2007-07-10 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
448 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
449 This allows us to show the server name in the error message, fixing
450 projects.maemo.org bug NB#62904.
451 Also, use the appropriate logical ID message for the account protocol.
453 2007-07-10 Murray Cumming <murrayc@murrayc.com>
455 * src/modest-tny-account-store.c: (on_idle_wrong_password):
456 A compilation fix, though the build wasn't broken for me.
458 2007-07-09 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
461 Do not try to unref a NULL folder store, to avoid a runtime warning.
462 This seems to happen sometimes when changing accounts settings.
464 2007-07-09 Murray Cumming <murrayc@murrayc.com>
466 * src/modest-tny-account-store.c:
467 (modest_tny_account_store_instance_init),
468 (modest_tny_account_store_finalize),
469 (on_account_settings_hide), (on_idle_wrong_password):
470 Use a GHashTable to ensure that we only show one account settings
471 dialog per modest account. This avoids us having a dialog open for
472 both the store and transport accounts, or due to repeated get_password()
473 calls that shouldn't happen anyway.
475 2007-07-09 Murray Cumming <murrayc@murrayc.com>
477 * src/maemo/modest-maemo-utils.c: (on_hide),
478 (modest_maemo_show_dialog_and_forget): Handle the response, because
479 the window is not even hidden by default.
481 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
482 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
483 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
484 which seems to prevent some modality problems.
486 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
487 Ignore user cancellation errors.
489 * src/modest-account-mgr-helpers.h:
490 * src/modest-account-mgr-helpers.c:
491 Added modest_server_account_get_password() and
492 modest_server_account_get_has_password() to avoid direct use of
495 * src/maemo/modest-account-settings-dialog.h:
496 * src/maemo/modest-account-settings-dialog.c:
497 (modest_account_settings_dialog_init): Store the notebook so we can
499 Added modest_account_settings_dialog_switch_to_user_info().
501 * src/modest-tny-account-store.c:
502 (get_password): When the password in the account settings is wrong (we think),
503 show the relevant page of the account settings dialog, in the mainloop.
504 However, we currently get many of these at once because cancel does not
506 (forget_password): Do not forget the password
507 from the account settings, because this causes side-effects when
508 tinymail seems to call it at strange time, maybe because of how we
509 are cancelling get_password().
510 (modest_tny_account_store_alert): Ignore user cancellations.
512 2007-07-09 Murray Cumming <murrayc@murrayc.com>
514 * src/maemo/modest-maemo-utils.h:
515 * src/maemo/modest-maemo-utils.c:
516 Added modest_maemo_show_information_note_and_forget() for use instead of
517 gtk_dialog_run() when the response is not needed, to avoid an extra
518 mainloop which could cause a hang.
520 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
521 Use the logical IDs for the error message, though they are not
522 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
523 because gtk_dialog_run() caused a hang here (the window did not close).
524 This fixes projects.maemo.org bug NB#62646.
526 2007-07-09 Murray Cumming <murrayc@murrayc.com>
528 * src/modest-account-mgr-helpers.h:
529 * src/modest-account-mgr-helpers.c:
530 Added modest_account_mgr_get_store_protocol().
532 * src/maemo/modest-account-view-window.c:
533 (on_delete_button_clicked): Show different warning text depending on
534 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
535 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
538 2007-07-09 Murray Cumming <murrayc@murrayc.com>
540 * src/maemo/modest-msg-edit-window.c:
541 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
542 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
544 2007-07-07 Armin Burgmeier <armin@openismus.com>
546 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
547 ckdg_ib_maximum_characters_reached from correct package.
549 * src/modest-ui-actions.c: Show an error message when a folder could
550 not be created. Tinymail does not give us specific error codes about
551 what has gone wrong, so we assume that a folder with that name
552 already exists, though there might be other reasons.
554 2007-07-06 Murray Cumming <murrayc@murrayc.com>
556 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
557 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
558 give a more exact error message that can be partly translated.
560 2007-07-05 Murray Cumming <murrayc@murrayc.com>
562 * src/maemo/modest-address-book.c:
563 (select_email_addrs_for_contact): Specify a default window size for the
564 select-email-address dialog, so that it is probably big enough for the
565 title. This should fix projects.maemo.org bug NB#62277.
567 2007-07-05 Murray Cumming <murrayc@murrayc.com>
569 * src/maemo/easysetup/modest-easysetup-wizard.c:
570 (create_page_complete_easysetup): Use
571 gtk_widget_set_size() request to ensure that the text wraps
574 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
576 * src/maemo/easysetup/modest-easysetup-wizard.c:
577 (on_entry_invalid_character), (create_page_account_details),
578 (create_page_user_details):
579 Use new API of ModestValidatingEntry. But for some reason the banner is
580 not shown. I will have to investigate that further.
582 * src/widgets/modest-validating-entry.c: (on_insert_text),
583 (modest_validating_entry_set_func):
584 * src/widgets/modest-validating-entry.h:
585 Added a new callback function to be able to react to prevented
586 characters whitespaces to e.g show a banner.
588 2007-07-05 Armin Burgmeier <armin@openismus.com>
590 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
591 notification of HildonNumberEditor instead of remembering the port
592 number. Thanks to Johannes for pointing this out.
594 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
596 * src/maemo/easysetup/modest-easysetup-wizard.c:
597 Check if there are any user changes before showing a confirmation
598 dialog (projects.maemo.org NB#60946)
600 2007-07-05 Armin Burgmeier <armin@openismus.com>
602 * src/maemo/modest-account-settings-dialog.c: Remember custom port
603 number at the beginning of the dialog and set the modified flag at the
604 end if the port number has changed. This is necessary because
605 HildonNumberEditor does not support notification when the value has
608 2007-07-05 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-ui-actions.c:
611 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
612 a connection before asking anything else. Correct the check for the destination
613 folder so that it succeeds when online.
614 This fixed projects.maemo.org bug NB#61645.
616 2007-07-05 Murray Cumming <murrayc@murrayc.com>
618 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
619 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
620 to fix projects.maemo.org bug NB#62439.
622 2007-07-05 Murray Cumming <murrayc@murrayc.com>
624 * src/modest-tny-account.c: (on_connection_status_changed):
625 Really do not use tny_device_force_offline() here. See the previous comment.
627 2007-07-04 Murray Cumming <murrayc@murrayc.com>
629 * src/modest-tny-account.c: (on_connection_status_changed):
630 Do not use tny_device_force_offline() when tinymail says that something
631 went wrong with the connection. It seems to report this unnecessarily.
633 2007-07-04 Murray Cumming <murrayc@murrayc.com>
635 * src/maemo/modest-connection-specific-smtp-window.c:
636 (modest_connection_specific_smtp_window_init):
637 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
638 does not seem to have any effect in osso 1.1 (though it works in
639 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
641 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
643 * src/maemo/modest-connection-specific-smtp-window.c:
644 Fix UI specification problems with projects.meamo.org NB#60479
646 2007-07-04 Murray Cumming <murrayc@murrayc.com>
648 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
649 clue when this has failed, because the error dialog is not always shown
650 (at least in earlier version).
652 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
653 GError message, because the generic error dialog is not helpful.
655 'This message is not currently available (can't let a new connection go online)'
656 when trying to open an IMAP message.
658 (_modest_ui_actions_open): Offer a connection when some messages would
659 have to be downloaded and we are offline.
661 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
663 * src/widgets/modest-folder-view.c:
664 Don't check for MERGE type anymore as we use the correct type
666 NOTE: For the last two changes you need to update your tinymail copy
667 because of API changes!
669 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
671 * src/modest-tny-local-folders-account.c:
672 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
673 (see projects.maemo.org NB#61580)
675 2007-07-04 Murray Cumming <murrayc@murrayc.com>
677 * src/modest-tny-account.c: (on_connection_status_changed):
678 Commented out the call to modest_platform_connect_and_wait() because this
679 seems to always hang, and I would like to know if this is the only thing
680 that causes a hang when showing the connection dialog.
681 It is not very useful anyway.
683 2007-07-04 Murray Cumming <murrayc@murrayc.com>
685 * src/maemo/modest-msg-view-window.c:
686 (modest_msg_view_window_select_next_message):
688 * src/modest-platform.h:
689 * src/maemo/modest-platform.c:
690 Added modest_platform_connect_and_wait(), which calls
691 tny_maemo_conic_device_connect() always in the main thread, by calling it
692 in an idle handler and waiting for the idle handler to run. It should be
693 in the main thread because it uses GTK+ UI code. It just returns TRUE
694 if the device is already online.
696 There is some nasty code to ensure that subsequent calls to
697 modest_platform_connect_and_wait() just wait for the first one to finish,
698 by checking repeatedly in another idle handler. This is necessary,
699 because other threads (or even the main thread, via another idle handler)
700 can call modest_platform_connect_and_wait() while
701 modest_platform_connect_and_wait() is running.
703 (modest_platform_connect_and_wait_if_network_account),
704 (modest_platform_connect_and_wait_if_network_folderstore):
705 Convenience functions that calls modest_platform_connect_and_wait() if
706 the account or folder might want network access.
708 * src/modest-mail-operation.c:
709 (modest_mail_operation_update_account):
710 * src/modest-ui-actions.c: (download_uncached_messages),
711 (modest_ui_actions_on_rename_folder), (delete_folder),
712 (modest_ui_actions_on_main_window_move_to),
713 (modest_ui_actions_on_msg_view_window_move_to):
714 * src/widgets/modest-folder-view.c:
715 (drag_and_drop_from_folder_view):
716 Offer a connection if we are offline.
718 * src/modest-tny-account.c: (on_connection_status_changed):
719 Document this as only handling errors during network operations in progress,
720 and replace the idle code with a simple call to
721 modest_platform_connect_and_wait(), which does this instead.
723 2007-07-03 Murray Cumming <murrayc@murrayc.com>
725 * src/modest-tny-account.c:
726 (modest_tny_account_get_special_folder): (util_on_idle),
727 Handle the GError so we can see when tny_folder_store_get_folders()
728 fails, as it currently does while something else is connecting.
730 Added util_run_in_main_thread_and_wait()
731 which uses an idlen handler and mainloop to ensure that the function
732 is called in the main thread.
733 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
734 to make sure that we call attempt the connection in the mainloop only,
735 which might solve some hangs.
737 2007-07-03 Murray Cumming <murrayc@murrayc.com>
739 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
740 be found by their display name. This is never useful.
741 * src/modest-tny-account-store.c: (on_account_removed): Find the account
742 by its ID, instead of trying to use its ID as its display name.
744 * src/modest-tny-account-store.h:
745 * src/modest-tny-account.c:
746 (modest_tny_account_get_special_folder): Add a g_warning() when
747 tny_folder_store_get_folders() returns an empty list for the maildir.
749 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
750 Add a g_warning() when this returns NULL, because that it not allowed
753 2007-07-02 Armin Burgmeier <armin@openismus.com>
755 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
756 note when trying to cancel the wizard. This fixes projects.maemo.org
759 2007-07-02 Murray Cumming <murrayc@murrayc.com>
761 * src/modest-tny-account.h:
762 * src/modest-tny-account.c:
763 (modest_tny_account_new_from_server_account),
764 (modest_tny_account_new_from_server_account_name),
765 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
766 because this must now be set before setting the proto. This is usd in
767 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
768 warning in camel_session_get_service() caused by
769 tny_camel_transport_account_prepare().
771 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
774 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
776 * src/maemo/modest-connection-specific-smtp-edit-window.c:
778 (modest_connection_specific_smtp_edit_window_init):
780 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
783 2007-06-29 Murray Cumming <murrayc@murrayc.com>
785 * src/modest-tny-account.c:
786 (modest_tny_account_new_from_server_account):
787 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
788 now uses to request a connection when it needs one, and which it uses
789 to tell us that something is wrong with the connection, so we can force
790 the accounts offline to prevent further problems.
793 * src/modest-init.c: (init_default_settings):
794 * src/modest-mail-operation.c:
795 (modest_mail_operation_update_account):
796 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
797 This should not be necessary anymore. Do not set the conf key that
798 determined this (it was always TRUE and not set anywhere else).
800 * src/modest-ui-actions.h: Remove unused and unimplemented
801 modest_ui_actions_on_online_toggle_toggled().
803 2007-06-29 Murray Cumming <murrayc@murrayc.com
805 * src/maemo/modest-main-window.c: (connect_signals):
806 Don't connect to delete_event twice. Maybe this was harmless.
808 2007-06-29 Murray Cumming <murrayc@murrayc.com
810 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
811 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
812 Debug output to give some more clue when a folder move is not allowed.
814 2007-06-28 Murray Cumming <murrayc@murrayc.com
816 * src/modest-tny-account.c: (on_modest_file_system_info),
817 (modest_tny_account_get_mmc_account_name):
818 Always call the callback, without checking whether the name has changed.
819 * src/widgets/modest-folder-view.c: (strings_are_equal),
820 (on_model_foreach_set_name), (on_get_mmc_account_name),
821 (text_cell_data): Compare the name here, and use the name from
822 the account rather than from the
823 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
824 if the name was changed after the account was added to the model.
825 That's a tinymail bug but not one that I want to fix now.
827 This finally fixes projects.maemo.org bug NB#59301.
829 2007-06-27 Armin Burgmeier <armin@openismus.com>
831 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
834 2007-06-27 Murray Cumming <murrayc@murrayc.com
836 * src/modest-tny-account.h:
837 * src/modest-tny-account.c:
838 Added modest_tny_account_get_mmc_account_name(), to set the memory
839 card name asynchronously for the given account and then notify.
840 (modest_tny_account_new_for_local_folders): Use this new function instead
841 of using hildon_file_system_info_async_new() directly.
843 * src/widgets/modest-folder-view.c: (text_cell_data):
844 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
845 gtk_tree_model_row_changed() when it is available.
847 This should fix projects.maemo.org bug NB#59301.
849 2007-06-27 Murray Cumming <murrayc@murrayc.com
851 * src/modest-mail-operation.c: (update_account_thread),
852 (get_msgs_full_thread): Fix typo failures in the revert
855 2007-06-27 Murray Cumming <murrayc@murrayc.com
857 * src/maemo/modest-maemo-global-settings-dialog.c:
858 (idle_select_default_focus):
859 * src/modest-mail-operation.c: (idle_notify_progress),
860 (idle_notify_progress_once), (set_last_updated_idle),
861 (update_account_thread), (get_msgs_full_thread):
862 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
863 * src/widgets/modest-header-view.c:
864 (idle_notify_headers_count_changed_destroy),
865 (idle_notify_headers_count_changed):
866 Reverted the additions of gdk_threads_enter/leave(), in case this
867 helps with a startup hang on the device.
869 2007-06-26 Armin Burgmeier <armin@openismus.com>
871 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
872 for supported secure authentication methods from server by
873 gtk_dialog_run(), saving CPU time and a potential race condition.
875 2007-06-26 Armin Burgmeier <armin@openismus.com>
877 * src/maemo/modest-maemo-utils.h:
878 * src/maemo/modest-maemo-utils.c: Added a
879 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
880 only error code to tell the calling code when the user canceled the
883 * src/maemo/modest-account-settings-dialog.h:
884 * src/maemo/modest-account-settings-dialog.c:
885 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
886 message if the retrieval of secure authentication methods was canceled
887 by the user. Perform the check before saving anything to configuration
888 to not end up with half-committed configuration changes, do not show
889 a "Saving to configuration failed" note when authentication methods
890 could not be retrieved.
892 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
895 2007-06-26 Murray Cumming <murrayc@murrayc.com>
897 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
898 Only return the first level of folders under accounts, because the
899 osso-global-search UI spec doesn't want the rest.
900 This fixed projects.maemo.org bug NB#61811.
902 2007-06-26 Murray Cumming <murrayc@murrayc.com>
904 * src/modest-tny-account-store.c:
905 * src/modest-tny-account-store.h:
906 Added modest_tny_account_is_memory_card_account().
907 * src/maemo/modest-main-window.c: (create_details_widget):
908 Show the same information items for the memory card as we show for the
909 local-folders, to fix projects.maemo.org bug NB#59307.
911 2007-06-26 Murray Cumming <murrayc@murrayc.com>
913 * src/modest-tny-account-store.c: (get_password):
914 Added some checks for NULL to maybe prevent crashes, though I think
915 it was Philip's last commit that actually prevented the crash here
916 when creating a first new account.
917 But the new account is still not usable (no messages are shown)
918 until a restart of the application.
920 2007-06-26 Murray Cumming <murrayc@murrayc.com>
922 * src/maemo/modest-maemo-global-settings-dialog.c:
923 (idle_select_default_focus):
924 * src/modest-mail-operation.c: (idle_notify_progress),
925 (idle_notify_progress_once), (idle_notify_update_account_queue),
926 (set_last_updated_idle), (update_account_thread),
927 (notify_get_msgs_full), (get_msgs_full_destroyer),
928 (get_msgs_full_thread):
929 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
930 * src/widgets/modest-header-view.c:
931 (idle_notify_headers_count_changed_destroy),
932 (idle_notify_headers_count_changed):
933 Use gdk_threads_enter() and gdk_threads_enter_leave() in
934 all idle handlers, because some other thread could be blocking
935 the GDK lock, so that it can do GUI stuff.
937 2007-06-26 Murray Cumming <murrayc@murrayc.com>
939 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
940 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
941 (on_idle_send_receive), (on_idle_open_default_inbox):
942 * src/maemo/modest-msg-edit-window.c:
943 (modest_msg_edit_window_attach_file_noninteractive):
944 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
945 to prevent a hang. I don't quite understand why these are necessary,
946 beause we should already be in the main loop. I guess something outside
947 of the main loop is taking the lock.
949 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
950 we are really using URIs, and use files that are more likely to exist.
952 2007-06-26 Murray Cumming <murrayc@murrayc.com>
954 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
955 necessary because configure.ac now defines different variables.
957 2007-06-26 Murray Cumming <murrayc@murrayc.com>
959 * libmodest-dbus-client/libmodest-dbus-client.c:
960 * libmodest-dbus-client/libmodest-dbus-client.h:
961 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
962 libmodest_dbus_client_compose_mail() is what things actually use.
964 * src/dbus_api/modest-dbus-api.h:
965 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
966 * tests/dbus_api/Makefile.am:
967 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
970 2007-06-26 Murray Cumming <murrayc@murrayc.com>
972 * src/modest-init.c: (modest_init_local_folders):
973 For memory-card (or other non local-folders) maildir accounts,
974 always create an Archive folder, so that there is somewhere to put
975 messages. This should be less confusing, because the user does not need
976 to guess that the need to create a folder.
978 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
980 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
981 Fixed icon size by using (50, 50) which is the same as defined by
984 2007-06-25 Armin Burgmeier <armin@openismus.com>
986 * src/widgets/modest-window-mgr.c:
988 * configure.ac: Correctly recognize hildon-notify presence and fixed
989 the build without it being installed.
991 2007-06-25 Murray Cumming <murrayc@murrayc.com>
993 * libmodest-dbus-client/libmodest-dbus-client.c:
994 (libmodest_dbus_client_search): Fix the build. Sorry.
995 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
996 (reply_forward_cb): Initialize variables to fix the build.
998 * src/modest-tny-account-store.c:
999 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1000 comparison (a silly typo) so that email search results can be opened
1001 when there are more than one account.
1003 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1005 * libmodest-dbus-client/libmodest-dbus-client.c:
1006 (libmodest_dbus_client_search),
1007 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1008 instead of 1 second, because the search gets folders and messages from
1009 the server, which can take a long time. When it times out,
1010 osso-global-search will report no results.
1012 We need to specify whether we should search only cached information
1013 (maybe with a user preference), and the osso-email-search-plugin
1014 API should really be improved to allow that option, and to allow results
1015 to be delivered asynchronously in batches.
1017 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1019 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1020 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1021 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1023 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1025 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1026 that is an empty string. D-Bus seems to give us these instead of NULL.
1028 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1030 * src/dbus_api/modest-dbus-callbacks.c:
1031 * src/maemo/easysetup/modest-easysetup-wizard.h:
1032 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1033 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1034 (modest_connection_specific_smtp_edit_window_init):
1035 * src/maemo/modest-maemo-global-settings-dialog.c:
1037 * src/maemo/modest-maemo-utils.c:
1038 (modest_maemo_utils_setup_images_filechooser):
1039 * src/maemo/modest-main-window.c: (create_details_widget):
1040 * src/maemo/modest-msg-edit-window.c:
1041 (modest_msg_edit_window_attach_file_noninteractive),
1042 (modest_msg_edit_window_color_button_change),
1043 (modest_msg_edit_window_set_zoom):
1044 * src/modest-mail-operation.c: (update_account_thread):
1045 * src/modest-tny-account-store.c:
1046 * src/modest-tny-account.c:
1047 * src/widgets/modest-global-settings-dialog.c:
1048 * src/widgets/modest-window.h:
1050 Fixed build on bora!
1052 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1054 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1055 * src/modest-search.c: (modest_search_folder),
1056 (modest_search_all_accounts): Actually search only in the specified folder,
1057 doing a simple match on the folder ID.
1058 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1059 and added some documentation.
1061 2007-06-22 Armin Burgmeier <armin@openismus.com>
1063 * src/maemo/modest-maemo-utils.h:
1064 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1065 modest_maemo_utils_get_supported_secure_authentication_methods.
1067 * src/maemo/easysetup/modest-easysetup-wizard.c:
1068 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1069 one occured, not just "Server does not support secure authentication".
1071 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1073 * src/modest-tny-account-store.c: (get_password):
1074 Restored the call to tny_account_set_user() because Philip seems to have
1075 stopped this from crashing (by not using the freed string). It still does
1076 not work, but now we can test it.
1078 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1080 * src/maemo/modest-msg-edit-window.c: (init_window):
1081 Comment out use of an uninitialzed GtkScrolledWindow variable,
1082 to fix the build and stop a crash. Yet again.
1084 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1086 * src/modest-tny-account-store.c: (get_password):
1087 Remove the call to tny_account_set_user() because this actually crashes.
1088 As mentioned in the last commit, it is known to not work anyway.
1090 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1092 * src/modest-tny-account-store.c: (get_password):
1093 Use tny_account_set_username() to tell tinymail that the username might
1094 have changed too. But tinymail ignores this: see projects.maemo.org
1096 * src/modest-ui-actions.c:
1097 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1098 reset the connection when changing the username, and improve the comments.
1099 Save the changed username to gconf at least, so it is used when Modest is
1102 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1104 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1105 Do not use a query, so that we get all folders, including for POP and
1106 local-folders. They work as search criteria too.
1107 This fixes projects.maemo.org bug NB#57740.
1109 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1111 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1112 Comment out the use of hildon_notification_set_sound() because it is
1113 not declared, to fix the build. Warnings are serious, people.
1115 2007-06-21 Armin Burgmeier <armin@openismus.com>
1117 * src/maemo/modest-maemo-utils.h:
1118 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1119 modest_maemo_utils_get_supported_secure_authentication_methods()
1120 to query authentication methods for a specific user. This should fix
1121 projects.maemo.org bug NB#61369.
1123 * src/maemo/easysetup/modest-easysetup-wizard.c:
1124 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1127 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1129 * libmodest-dbus-client/libmodest-dbus-client.h:
1130 * libmodest-dbus-client/libmodest-dbus-client.c:
1131 (modest_dbus_message_iter_get_search_hit),
1132 (libmodest_dbus_client_search):
1133 Reorganised and commented this.
1134 Removed modest_search_hit_free() from the public API because it
1137 Added libmodest_dbus_client_get_folders() and
1138 modest_folder_result_list_free().
1140 * src/dbus_api/modest-dbus-api.h:
1141 * src/dbus_api/modest-dbus-callbacks.c:
1142 (modest_dbus_req_filter): Commented. Moved most code to
1143 on_dbus_method_search() and added on_dbus_method_get_folders().
1145 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1146 of the extra D-Bus handler.
1148 * tests/dbus_api/Makefile.am:
1149 * tests/dbus_api/test_get_folders.c: New test for
1150 libmodest_dbus_client_get_folders(). This seems to return an empty list
1151 at the moment. That could be the same error that causes the message list
1152 to be empty sometimes.
1153 This should help with projects.maemo.org bug NB#57740.
1155 2007-06-21 Armin Burgmeier <armin@openismus.com>
1157 * src/modest-mail-operation.c: Do not call
1158 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1159 notify the operation's end after having set the status to CANCELED for
1160 the operation queue to listen on. This fixes a deadlock when there
1161 were mail operations in the queue during its finalization.
1163 * src/modest-singletons.c: Reordered uninitialization of the account
1164 manager to happen after the mail operation queue was uninitialized
1165 because the mail operation's in the queue might still try to access
1166 the account manager (see modest_mail_operation_notify_end()). This
1167 fixes a potential crash when terminating the application.
1169 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1171 * src/modest-search.c:
1172 (search_mime_part_and_child_parts): Moved some code here so we
1173 can search recursively in child folders.
1174 (modest_search_folder): Search in the message as a mime part, instead
1175 of just its child mime parts.
1176 (read_chunk), (search_mime_part_ogs):
1177 Check how many bytes were read, to prevent an endless loop.
1178 Searching in message bodies now works. This finishes the fix for
1179 projects.maemo.org bug NB#61007.
1181 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1183 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1184 Add a g_warning when the item is not a folder.
1186 * src/modest-ui-dimming-rules.c:
1187 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1188 when selected item is not a folder (for instance, an account), because
1189 the UI spec only talks about folders.
1190 I am not sure what the UI spec wants, so this might not totally fix
1191 projects.maemo.org bug NB#60794.
1193 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1195 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1196 (load_from_file): Sort the list. The unsorted list would be more noticeable
1197 in non-English locales.
1199 * src/maemo/modest-msg-edit-window.c:
1200 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1201 warning and fix the build.
1203 * src/maemo/modest-progress-bar-widget.c:
1204 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1205 avoid a g_warning, and probably to avoid a crash.
1207 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1209 * src/modest-search.c: (modest_search_folder): Check for a GError
1210 when calling tny_folder_get_headers(), to show that this is not the cause
1213 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1215 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1216 Actually set the body query instead of the subject query.
1218 * src/modest-search.c: (search_mime_part_ogs),
1219 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1220 which would probably cause it to fail if we got this far.
1222 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1223 to simplify the code.
1224 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1225 be causing search-in-body to fail.
1227 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1229 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1231 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1232 Better debug message when the folder cannot be found.
1233 This should help with fixing projects.maemo.org bug #61287.
1234 * src/modest-search.c: (add_hit): Do not leak the furl string.
1236 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1238 * src/modest-ui-actions.c:
1239 (modest_ui_actions_on_folder_selection_changed):
1240 Do not special-case TNY_MERGE_FOLDER here, because
1241 modest_tny_folder_get_account() already does that. This fixes
1242 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1243 shown when the Outbox was selected).
1245 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1247 * libmodest-dbus-client/libmodest-dbus-client.c:
1248 (_dbus_iter_get_string_or_null): Initialize the string variable in
1249 case this helps with Dirk's crash.
1251 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1253 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1254 though it is not implemented yet (this function is maybe not even used),
1255 to avoid breaking ABI in future.
1256 * libmodest-dbus-client/libmodest-dbus-client.c:
1257 (get_attachments_string): Moved some code into this generic function.
1258 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1259 sends email. It is maybe not used.
1260 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1261 (on_send_mail): Use attachments.
1263 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1264 * src/maemo/modest-msg-edit-window.c:
1265 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1266 a filename before using it, to fix projects.maemo.org bug NB#58233.
1268 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1270 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1271 Initialize the continue_download variable to fix the build, and probably
1272 to fix randome behaviour.
1274 2007-06-18 Armin Burgmeier <armin@openismus.com>
1276 * src/modest-tny-send-queue.h:
1277 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1278 the queue so we can later show it in the UI. Replaced
1279 modest_tny_send_queue_msg_is_being_sent() by
1280 modest_tny_send_queue_get_msg_status().
1282 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1284 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1285 gpointer. This probably was not harmful, but just to be sure.
1287 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1289 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1290 Fix the build, but leave the function broken on Bora, because
1291 hildon_uri_action_get_service() does not exist.
1292 osso_uri_action_get_service() does not exist either, it seems.
1294 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1296 * src/modest-tny-account.c:
1297 (modest_tny_account_new_from_server_account):
1298 Uncommented the url debug output again, because it is useful for
1299 debugging, as I said in the comment.
1301 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1303 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1305 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1306 for Mameo Bora, to fix the build.
1308 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1311 Fixed build with hildon < 0.99
1313 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1314 Check if the selected account is busy instead of checking all accounts
1316 * src/modest-account-mgr-priv.h:
1317 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1318 (modest_account_mgr_init), (compare_account_name),
1319 (modest_account_mgr_set_account_busy),
1320 (modest_account_mgr_account_is_busy):
1321 * src/modest-account-mgr.h:
1322 Added busy information to the account manager. It possible to
1323 set an account to busy or not busy now.
1325 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1326 (modest_mail_operation_update_account),
1327 (modest_mail_operation_notify_end):
1328 Set the account to busy/not busy depending on the operation state.
1330 * src/widgets/modest-account-view.c:
1331 (modest_account_view_finalize), (get_last_updated_string),
1332 (update_account_view), (on_account_busy_changed), (init_view):
1333 Show string "Refreshing..." if the account is currently busy.
1335 All this fixes projects.maemo.org bug NB#59711
1337 2007-06-14 Armin Burgmeier <armin@openismus.com>
1339 * src/widgets/modest-attachments-view.h:
1340 * src/widgets/modest-attachments-view.c: Added
1341 modest_attachments_view_has_attachments() and fixed coordinate
1342 transformation in get_att_view_at_coords(). This fixes attachment
1345 * src/widgets/modest-msg-view.c: Make use of
1346 modest_attachments_view_has_attachments() to decide whether to show
1347 attachments in the header.
1349 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1351 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1352 (on_change), (on_combo_security_changed),
1353 (modest_connection_specific_smtp_edit_window_init),
1354 (modest_connection_specific_smtp_edit_window_set_connection),
1355 (modest_connection_specific_smtp_edit_window_is_dirty):
1356 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1357 * src/maemo/modest-connection-specific-smtp-window.c:
1360 Show an comfirmation dialog for the smpt-edit-window if there are
1361 unsaved changes and the user hits cancel.
1362 (projects.maemo.org bug NB#60479)
1364 2007-06-14 Armin Burgmeier <armin@openismus.com>
1366 * src/maemo/easysetup/modest-easysetup-wizard.c:
1367 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1368 address" info in banner instead of node, and select all the text as
1369 per UI spec. This fixes projects.maemo.org bug NB#60550.
1371 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1373 reviewed by: <delete if not using a buddy>
1375 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1376 * src/modest-ui-actions.c: (folder_refreshed_cb):
1378 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1380 * src/widgets/modest-folder-view.c: (filter_row):
1381 Explictly filter out the per-account outbox accounts. I don't know why
1382 these only sometimes show up, but now they should never show up in the UI.
1383 This should fix projects.maemo.org bug NB#60160.
1385 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1387 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1388 when the toolbar does not exist yet.
1389 * src/modest-widget-memory.c: (save_settings_header_view):
1390 Added g_warnings() to help us to discover when we are trying to set
1391 an empty columns list in gconf.
1393 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1395 * src/modest-init.h:
1396 * src/modest-init.c:
1397 Added modest_init_get_default_header_view_column_ids().
1399 * src/modest-widget-memory.c: (restore_settings_header_view):
1400 Use the new function to get defaults, if the gconf key is empty,
1401 instead of not creating any columns. This seems to fix the
1402 empty right-hand pane problems.
1404 * src/widgets/modest-header-view.h: Improved documentation.
1406 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1408 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1409 Revert the use of the display name as the account name, because this
1410 is generally wrong and would break the code that follows.
1412 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1414 * src/maemo/easysetup/modest-easysetup-wizard.c:
1415 (check_for_supported_auth_methods), (on_before_next),
1418 More correct fix for projects.maemo.org bug NB# 58991
1419 Do not longer accept AUTH_PASSWORD as secure method and choose
1420 correct method when creating the account.
1422 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1424 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1425 Fixed projects.maemo.org bug NB# 58991
1427 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1429 * src/modest-init.c: (modest_init_init_core),
1430 (modest_init_local_folders): Fixed compilation errors.
1432 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1434 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1435 Remove unnecessary lib/include, though it is good in principle when needed.
1437 * src/modest-init.c: (modest_init_one_local_folder),
1438 (modest_init_local_folders):
1439 * src/modest-init.h: Initialize the .modest library for memory cards,
1440 instead of just doing nothing for them. This should allow us to create
1441 folders there, fixing projects.maemo.org bug NB#59297.
1443 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1445 * libmodest-dbus-client/libmodest-dbus-client.c:
1446 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1447 (libmodest_dbus_client_compose_mail),
1448 (libmodest_dbus_client_open_message),
1449 (libmodest_dbus_client_send_and_receive),
1450 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1452 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1453 (on_idle_open_message), (modest_dbus_req_handler),
1454 (search_result_to_message), (modest_dbus_req_filter):
1455 * src/modest-search.c: (add_hit), (modest_search_folder),
1456 (modest_search_all_accounts): Improved debug messages.
1458 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1460 * src/modest-tny-account-store.c:
1461 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1464 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1467 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1469 * src/modest-tny-account-store.c: (get_server_accounts):
1470 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1471 even when there are no accounts, so that the Outbox folder is always
1472 visible. This fixes projects.maemo.org bug NB#60158.
1474 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1476 * src/maemo/modest-main-window.c: (create_details_widget):
1477 Use the mcen_va_never logical ID.
1479 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1481 * src/dbus_api/modest-dbus-api.h:
1482 * src/dbus_api/modest-dbus-callbacks.c:
1483 (on_idle_open_default_inbox), (on_open_default_inbox),
1484 (modest_dbus_req_handler):
1485 Added a new OpenDefaultInbox method.
1487 * libmodest-dbus-client/libmodest-dbus-client.h:
1488 * libmodest-dbus-client/libmodest-dbus-client.c:
1489 Added libmodest_dbus_client_open_default_inbox() to call the new
1490 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1491 though it should maybe be used by a new osso-email-interface function.
1493 * tests/dbus_api/Makefile.am:
1494 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1497 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1499 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1500 NULL, so that the signals get all the keys. This should not actually
1501 change any behaviour because we currently update everything when anything
1504 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1506 * src/widgets/modest-folder-view.c: (text_cell_data),
1507 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1508 (find_inbox_iter): If tinymail tells us that the folder is
1509 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1510 This causes the inbox to be selected at startup, fixing part of
1511 projects.maemo.org bug NB#56305.
1513 * src/modest-ui-dimming-rules.c:
1514 (modest_ui_dimming_rules_on_tools_smtp_servers):
1515 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1516 the SMTP servers menu item.
1517 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1518 that the SMTP Servers menu item is dimmed when there are no accounts,
1519 as a future version of the UI spec will require. This fixes
1520 projects.maemo.org bug NB#56305.
1522 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1524 * src/maemo/modest-maemo-utils.c:
1525 (modest_maemo_utils_get_supported_secure_authentication_methods):
1526 Added label to dialog instead of unreadable title
1528 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1529 (modest_main_window_new):
1530 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1533 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1534 * src/modest-account-mgr.h:
1535 Added method to avoid code duplication
1537 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1538 (modest_ui_actions_on_send_receive):
1539 Use modest_account_mgr_has_accounts
1541 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1543 * src/maemo/easysetup/modest-presets.c:
1544 (modest_presets_get_info_server_security): Do not report secure auth
1546 * src/modest-protocol-info.c: Use the defines for the gconf key names
1547 for secure authentication. This was not working because we were writing
1548 Password and reading password, and the check was case sensitive.
1549 With this, gmail now works for receiving and sending when created via
1552 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1554 * src/maemo/easysetup/modest-presets.c:
1555 (modest_presets_get_info_server_security): Correct the key name for
1556 SecureSmtp, because it seems to be case-sensitive.
1557 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1558 Do not try to get the 0th notebook page if there are 0 pages, to
1559 avoid a g_warning().
1561 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1563 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1564 Prevent use of the new notification feature for now, because it currently
1565 shows one dialog for each new email, which is annoying.
1567 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1569 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1570 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1571 when no country was selected, so that we show the global ones.
1572 * src/maemo/easysetup/modest-presets.c:
1573 (modest_presets_get_providers): Return only the global providers, not
1574 all providers when mmc=0 was requested.
1576 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1578 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1579 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1580 provider ID in the combo.
1582 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1583 Do not show the page numbers, because it would be confusing when we add
1584 the 2 extra pages for the custom setup, when the user chooses the "Other"
1585 provider. This fixes projects.maemo.org bug NB#59028
1587 * src/modest-init.c: (modest_init_init_core),
1588 (modest_init_local_folders):
1589 * src/modest-init.h:
1590 * src/modest-tny-account.c:
1591 (modest_tny_account_new_for_local_folders): Do not create default folders
1592 for the memory card. This should fix projects.maemo.org bug NB#59328.
1594 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1596 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1597 Free the changed_conf_keys string items. They are already freed in the
1598 idle handler if that runs first.
1600 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1602 * src/modest-ui-actions.c:
1603 (modest_ui_actions_on_password_requested): Check that the server name
1604 is not NULL, because I just saw a password dialog with (null) as the
1607 * src/modest-tny-folder.[h|c]: Added
1608 modest_tny_folder_is_memory_card_folder().
1609 * src/modest-ui-dimming-rules.c:
1610 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1611 menu item for memory cards, as per the UI spec (section 7.4). This should
1612 fix projects.maemo.org bug NB#59297.
1614 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1616 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1617 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1618 is another problem with the code, see Murray's comment at line 772)
1620 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1622 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1623 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1624 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1625 (load_from_file), (easysetup_country_combo_box_init),
1626 (easysetup_country_combo_box_get_active_country_ids),
1627 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1628 instead of just one ID, to avoid duplicate country names in the UI.
1630 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1631 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1632 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1633 a single ID, avoiding duplicate providers.
1634 * src/maemo/easysetup/modest-easysetup-wizard.c:
1635 (on_combo_account_country): Adapt to use a list.
1637 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1639 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1640 keys changed in the last X seconds.
1642 * src/modest-account-mgr.h:
1643 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1644 (on_key_change), (modest_account_mgr_class_init),
1645 (modest_account_mgr_init), (modest_account_mgr_finalize):
1646 As the keys are changed, save them in a GSList* and signal that GSList*
1647 further every X seconds, to batch changes, to allow us to do just one
1648 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1649 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1651 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1652 changed signal signature.
1654 * src/modest-conf.c: (modest_conf_set_list),
1655 (modest_conf_on_change): Reenable notification.
1657 (modest_conf_maemo_fake_on_change): Comment out the hack that
1658 notified immediately instead of asynchronously.
1660 * src/widgets/modest-account-view.h:
1661 * src/widgets/modest-account-view.c:
1662 (update_account_view): Select the previously-selected account ID,
1663 if possible. This fixes projects.maemo.org bug NB#56933.
1665 (on_account_changed), (on_account_removed),
1666 (modest_account_view_select_account):
1668 Remove the block/unblock functions
1669 because they were not useful.
1671 * src/maemo/modest-account-view-window.c:
1672 (on_delete_button_clicked), (on_edit_button_clicked),
1673 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1675 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1677 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1678 Improve the error dialog to show Incorrect Account Settings, which seems
1679 clearer, and say that the internal error message (to be removed from the
1680 dialog later) is often misleading.
1681 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1683 * src/modest-tny-account.c:
1684 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1685 URL because this is so useful for debugging on the device.
1687 * src/widgets/modest-serversecurity-combo-box.c:
1688 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1690 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1692 * src/modest-mail-operation.c:
1693 (modest_mail_operation_send_new_mail):
1694 Added a comment about a nasty but apparently harmless message. Details
1695 added to the wiki g_warnings() page.
1697 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1699 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1700 (modest_tny_send_queue_class_init):
1701 Do not use the priv struct because it is empty, to avoid g_warnings
1702 about a non-existant priv struct.
1704 * src/modest-tny-account-store.c:
1705 (modest_tny_account_store_get_server_account),
1706 (modest_tny_account_store_get_transport_account_for_open_connection
1707 ): Do not try to get transport server accounts for local folders,
1708 because they don't have any. This avoids a g_warning().
1710 * src/maemo/modest-main-window.c:
1711 (modest_main_window_notify_send_receive_initied),
1712 (on_configuration_key_changed):
1713 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1714 * src/modest-defs.h:
1715 * src/modest-mail-operation.c:
1716 (modest_mail_operation_update_account):
1717 * src/modest-tny-account-store.h:
1718 * src/modest-tny-account.c:
1719 (modest_tny_account_get_special_folder),
1720 (modest_tny_account_new_for_local_folders),
1721 (modest_tny_account_new_for_per_account_local_outbox_folder):
1722 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1723 * src/modest-tny-local-folders-account.c:
1724 (add_account_folders_to_merged_folder):
1725 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1726 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1727 (modest_ui_actions_on_send):
1728 * src/widgets/modest-folder-view.c: (update_model):
1729 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1730 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1731 modest_tny_account_store_get_tny_account_by_account() to
1732 modest_tny_account_store_get_server_account() to make the code clearer.
1734 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1736 * src/dbus_api/modest-dbus-api.h:
1737 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1738 * src/maemo/modest-msg-edit-window.c:
1739 (modest_msg_edit_window_attach_file_noninteractive):
1740 added g_warning in case the file to be attached does not exist
1741 * tests/dbus_api/test_compose_mail.c: (main):
1742 removed obsolete comment, added generic files as test case
1744 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1746 * src/modest-tny-account-store.c: (get_server_accounts):
1747 Create the local folders account only once, not once for each outbox, and
1748 not only when there are some outboxes.
1750 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1752 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1753 code that is causing a crash at startup. Sergio says that he is fixing this.
1755 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1757 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1758 * src/maemo/modest-account-settings-dialog.c:
1759 (create_page_outgoing),
1760 (modest_account_settings_dialog_set_account_name),
1761 (save_configuration):
1762 - Fixed handling of the "Use secure authentication" toggle to comply with
1763 the ui specification. See also projects.maemo.org bug NB#58400
1765 - Restore the Secure connection setting combo correctly when loading
1768 * src/maemo/modest-maemo-utils.c:
1769 (on_camel_account_get_supported_secure_authentication),
1770 (modest_maemo_utils_get_supported_secure_authentication_methods):
1771 Fixed a crasher if operation is canceled
1773 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1774 (modest_protocol_info_auth_is_secure):
1775 * src/modest-protocol-info.h:
1777 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1778 the sense of the "Use secure authentication" toggle.
1780 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1782 * src/modest-tny-account-store.h:
1783 * src/modest-tny-account-store.c:
1784 Added modest_tny_account_store_get_local_folders_account().
1786 * src/modest-tny-folder.h:
1787 * src/modest-tny-folder.c:
1788 (modest_tny_folder_get_account):
1789 Added this replacement for tny_folder_get_account() which returns
1790 the local-folders account for TnyMergeFolders, to avoid the
1791 warning about the unimplemented get_account_func() vfunc().
1793 (modest_tny_folder_get_rules),
1794 * src/modest-ui-actions.c:
1795 (modest_ui_actions_on_folder_selection_changed):
1796 * src/modest-mail-operation.c:
1797 (modest_mail_operation_remove_folder),
1798 (modest_mail_operation_xfer_folder),
1799 (modest_mail_operation_rename_folder),
1800 (modest_mail_operation_get_msg),
1801 (modest_mail_operation_get_msgs_full),
1802 (modest_mail_operation_remove_msg),
1803 (modest_mail_operation_xfer_msgs),
1804 (modest_mail_operation_refresh_folder):
1805 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1807 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1809 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1810 (modest_server_account_set_security):
1811 * src/modest-defs.h: Add comments explaining that our
1812 UI spec means TLS when it says Normal, so these do not look like errors.
1814 * src/modest-tny-account.c:
1815 (modest_tny_account_new_from_server_account): Use the new tinymail
1816 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1817 for TLS. This should fix projects.maemo.org bug NB#58460.
1819 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1821 * src/maemo/easysetup/modest-easysetup-wizard.c:
1822 (create_account): Correct the position of the gconf sanity check warning.
1823 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1824 of using the g_idle_add() hack, because this does not seem to be necessary
1825 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1826 caused by something other than maemo's gconf.
1827 This fixes projects.maemo.org bug #59022.
1829 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1831 * src/modest-account-mgr-helpers.c:
1832 (modest_account_mgr_get_default_account): Do not check that the account
1833 exists if there is no default account (NULL), to fix a runtime warning.
1835 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1837 * src/widgets/modest-folder-view.c: (update_model):
1838 Do not unref the treemodel before we have finished with it.
1839 This prevents a valgrind warning and an occasional crash at startup.
1841 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1843 * libmodest-dbus-client/libmodest-dbus-client.h:
1844 added libmodest_dbus_client_compose_mail()
1845 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1847 added functions needed for SendAsMail() functionality
1848 * src/maemo/modest-msg-edit-window.c:
1849 (modest_msg_edit_window_attach_file_noninteractive):
1850 non interactively attaching files to message edit window
1851 * src/widgets/modest-msg-edit-window.h:
1852 * tests/dbus_api/Makefile.am:
1853 added test_compose_mail.c
1854 * tests/dbus_api/test_compose_mail.c: (main):
1856 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1858 * src/modest-account-view.c:
1859 Fixed bug projects.maemo.org bug NB#59307
1861 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1863 * src/maemo/easysetup/modest-easysetup-wizard.c:
1864 (get_serverport_incoming), (on_before_next), (create_account):
1865 * src/maemo/modest-account-settings-dialog.c:
1866 (modest_account_settings_dialog_set_account_name):
1867 * src/maemo/modest-maemo-utils.c:
1868 (on_camel_account_get_supported_secure_authentication_status),
1869 (on_camel_account_get_supported_secure_authentication),
1870 (on_secure_auth_cancel),
1871 (modest_maemo_utils_get_supported_secure_authentication_methods):
1873 Implemented security authentication for settings and easysetup.
1875 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1877 * src/maemo/modest-main-window.c: (create_details_widget):
1878 Show the total size for memory card accounts too, instead of showing
1879 the name again. Fixes bug projects.maemo.org bug NB#59307.
1881 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1884 * src/modest-tny-simple-folder-store.c:
1885 * src/modest-tny-simple-folder-store.h: Removed.
1887 * src/modest-tny-local-folders-account.h
1888 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1889 for the local-folders maildir, with an extra TnyMergedFolder containing
1890 the folders of the per-account outbox store accounts.
1891 * src/modest-tny-account-store.c: (get_server_accounts):
1892 Add the outboxes to the special local folders account after creating it.
1894 * src/modest-tny-account.c:
1895 (modest_tny_account_new_for_local_folders): Create the derived
1896 account when creating the main local-folders account.
1898 * src/maemo/modest-main-window.c: (create_details_widget),
1899 (modest_main_window_set_contents_style):
1900 Adapted to the use of the derived account instead of the folder store.
1902 * src/modest-ui-actions.c:
1903 (modest_ui_actions_on_folder_selection_changed):
1904 * src/modest-ui-dimming-rules.c:
1905 (modest_ui_dimming_rules_on_new_folder):
1906 * src/widgets/modest-folder-view.c: (text_cell_data),
1907 (icon_cell_data), (filter_row), (update_model),
1908 (get_cmp_rows_type_pos):
1911 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1912 Do not get the priv struct, because no priv struct has been set,
1913 to avoid a runtime warning.
1915 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1916 #ifelse with #else, to fix a warning, to fix the build.
1919 2007-06-05 Christian Kellner <ckellner@openismus.com>
1921 * libmodest-dbus-client/libmodest-dbus-client.c:
1922 Fix small typo in doc (why do you always see them
1923 AFTER committing stuff?)
1926 2007-06-05 Christian Kellner <ckellner@openismus.com>
1928 * libmodest-dbus-client/libmodest-dbus-client.c:
1929 (libmodest_dbus_client_search):
1930 Initialize hit list with NULL. Also set folder list
1931 to "" if NULL was supplied.
1934 2007-06-03 Christian Kellner <ckellner@openismus.com>
1936 * libmodest-dbus-client/libmodest-dbus-client.c:
1937 (modest_search_hit_list_free):
1938 Make it save to call it with NULL.
1940 * src/dbus_api/modest-dbus-callbacks.c:
1941 * src/modest-search.c:
1942 Return full ModestSearchHits as the search result list not TnyHeader
1943 since can't be around withouth the correspoding TnyFolder.
1945 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1947 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1948 Added currently commented code to check for secure auth
1950 * src/maemo/modest-account-settings-dialog.c: (on_response),
1951 (save_configuration), (show_ok):
1952 Fixed projects.maemo.org bugs NB #59248 and #59251
1954 * src/maemo/modest-maemo-utils.c:
1955 (on_camel_account_get_supported_secure_authentication_status),
1956 (on_camel_account_get_supported_secure_authentication),
1957 (modest_maemo_utils_get_supported_secure_authentication_methods):
1958 * src/maemo/modest-maemo-utils.h:
1959 Moved get_supported_secure_authentication() method here to be able
1960 to use it from easysetup wizard.
1962 * src/modest-pair.c: (on_pair_compare_as_string):
1963 Should compare string with first part of pair and not
1964 strcmp pairs which will crash.
1966 * src/modest-protocol-info.c:
1967 (modest_protocol_info_protocol_is_store):
1968 * src/modest-protocol-info.h:
1969 Added modest_protocol_info_get_auth_protocol_name()
1971 2007-06-03 Armin Burgmeier <armin@openismus.com>
1973 * src/modest-mail-operation.c:
1974 (modest_mail_operation_get_msgs_full): Set priv->account also when
1975 only retrieving a single message. This avoids a crash when canceling
1978 (modest_mail_operation_notify_end): Do not explicitely remove the
1979 operation from the queue but only emit the progress_changed signal.
1980 The queue itself listens to that signal to remove the operation when
1981 it is finished. This reduces coupling and removes a potential deadlock
1982 when modest_mail_operation_notify_end() is called from the queue
1983 itself. If that is a problem performance-wise, I would suggest to
1984 implement a status-changed signal or something.
1986 * src/modest-mail-operation-queue.c: Make sure to never call a
1987 function from another file while the queue is locked. This (hopefully)
1988 fixes another deadlock when exiting the application while retrieving
1991 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1993 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1994 Fixed build if libogs is not available
1996 2007-06-03 Christian Kellner <ckellner@openismus.com>
1998 * libmodest-dbus-client/libmodest-dbus-client.h:
1999 * libmodest-dbus-client/libmodest-dbus-client.c:
2000 (libmodest_dbus_client_delete_message):
2001 Implement deletion of messages (Client side).
2003 (modest_search_hit_free),
2004 (modest_search_hit_list_free):
2005 Utility functions to free the result hits.
2007 * src/dbus_api/modest-dbus-api.h:
2008 * src/dbus_api/modest-dbus-callbacks.c:
2009 (on_delete_message),
2010 (modest_dbus_req_handler):
2011 Implement deletion of messages (Server side).
2013 * tests/dbus_api/test_search.c: (main):
2016 * tests/dbus_api/Makefile.am:
2017 * tests/dbus_api/test_delete_message:
2018 Add little test for the message deletion logic
2020 2007-06-03 Armin Burgmeier <armin@openismus.com>
2022 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2023 when the operation queue was not empty. projects.maemo.org bug
2026 2007-06-03 Armin Burgmeier <armin@openismus.com>
2028 * src/widgets/modest-account-view.c
2029 (on_account_default_toggled): Toggle default account column
2030 explicitely instead of waiting for gconf notification (which is
2031 currently ignored). This should fix projects.maemo.org bug NB#56910
2032 for now. It should probably be removed when gconf notifications are
2035 2007-06-03 Christian Kellner <ckellner@openismus.com>
2037 * libmodest-dbus-client/libmodest-dbus-client.c:
2038 Removed debugging spew.
2040 * src/dbus_api/modest-dbus-callbacks.c:
2041 Added debugging info.
2043 * src/modest-search.c:
2044 (modest_search_all_accounts):
2045 Use tny_account_store_get_accounts () on the account store
2046 to get all accounts which is the way to get all accounts.
2048 * tests/dbus_api/test_search.c: (main):
2049 Make it possible to supply the search term on the command line.
2051 2007-06-03 Christian Kellner <ckellner@openismus.com>
2053 * libmodest-dbus-client/libmodest-dbus-client.c:
2054 * libmodest-dbus-client/libmodest-dbus-client.h:
2055 Implement searching for mesages over raw dbus. (Client side)
2057 * src/dbus_api/Makefile.am:
2058 * src/dbus_api/modest-dbus-api.h:
2059 * src/dbus_api/modest-dbus-callbacks.c:
2060 * src/dbus_api/modest-dbus-callbacks.h:
2061 Search framework (Server side). Also implement on_idle_open_message().
2063 * src/maemo/modest-platform.c: (modest_platform_init):
2064 Prepare for raw dbus/osso rpc interaction.
2066 * src/modest-search.h:
2067 Changed minsize from unspecific guint to guint32.
2069 * src/modest-search.c:
2071 Added strange hack which magically made tnymail work.
2073 (modest_search_folder),
2074 (modest_search_account),
2075 (modest_search_all_accounts):
2076 Implement helper functions to search all accounts, specific account
2079 * tests/dbus_api/Makefile.am:
2080 * tests/dbus_api/test_open_message.c:
2081 Read url to open from commandline.
2083 * tests/dbus_api/test_search.c:
2084 Implement small test for dbus search stuff
2086 2007-06-02 Armin Burgmeier <armin@openismus.com>
2088 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2089 include account type and account title. This fixes projects.maemo.org
2092 * src/maemo/modest-account-view-window.c: Set a title for the window.
2094 2007-06-02 Armin Burgmeier <armin@openismus.com>
2096 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2097 incoming and outgoing server name based on email address and server
2098 types as long as the names have not been edited manually. This fixes
2099 projects.maemo.org bug NB#58671.
2101 2007-06-02 Armin Burgmeier <armin@openismus.com>
2103 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2104 server type cannot be changed in future to the incoming details page
2105 when creating an account. This fixes projects.maemo.org bug NB#59029.
2107 2007-06-02 Armin Burgmeier <armin@openismus.com>
2109 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2110 and assigned max width chars so that they wrap instead of being
2111 truncated. Fixes projects.maemo.org bug NB#56126.
2113 2007-06-02 Armin Burgmeier <armin@openismus.com>
2115 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2116 introductory note to the connection specific smtp servers dialog, as
2117 section 8.12 of the email UI specification requires. This fixes
2118 projects.maemo.org bug NB#59212.
2120 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2122 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2123 Check for running mail operations, and offer to cancel them, as per the UI
2124 spec. This fixes projects.maemo.org bug NB#59041 .
2125 However, I suspect that tinymail may still use the network connection
2126 in ways that we cannot detect or cancel. But it should at least adapt to
2127 changes fairly well.
2129 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2131 * src/modest-tny-account-store.c: (recreate_all_accounts),
2132 (get_cached_accounts), (get_server_accounts): Do more sensible
2133 ref-counting of the temporarily-cached outbox accounts list. This seems
2134 to fix a crash when entering the password when the password was wrong.
2136 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2138 * src/gnome/modest-main-window.c: (connect_signals):
2139 * src/modest-tny-account-store.c: (get_password),
2140 (modest_tny_account_store_alert): Added comments and clues and
2141 commented-out code about how we currently fail to deal with connection
2142 errors and wrong passwords, and how we should.
2144 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2146 * src/widgets/modest-retrieve-combo-box.c:
2147 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2148 This fixes projects.maemo.org bug NB#58472 .
2150 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2152 * src/maemo/easysetup/modest-easysetup-wizard.c:
2153 (create_page_complete_easysetup):
2154 (create_page_complete_custom): Correct the last commit,
2155 putting the correct sentences in the correct pages.
2157 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2159 * src/maemo/easysetup/modest-easysetup-wizard.c:
2160 (create_page_complete_custom): Show the second sentence of text
2161 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2164 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2166 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2167 Set the leave-on-server conf key by default. This fixes
2168 projects.maemo.org bug NB#59258 .
2170 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2172 * src/maemo/modest-account-view-window.c:
2173 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2174 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2177 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2179 * src/maemo/easysetup/modest-easysetup-wizard.c:
2180 (create_caption_new_with_asterisk):
2181 * src/maemo/modest-account-settings-dialog.c:
2182 (create_caption_new_with_asterisk):
2183 Uncomment the code to add the asterisk, because they are no longer in the
2184 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2185 (update_incoming_server_title): Add an asterisk here too.
2187 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2189 * src/maemo/modest-maemo-global-settings-dialog.c:
2190 (current_connection): Check that we are even connected before trying to
2191 get the current connection name, to prevent a warning.
2193 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2194 Change the comments because tny_maemo_conic_device_connect() is now meant to
2196 * src/modest-mail-operation.c:
2197 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2198 make sure we have a connection and fail if we can't connect.
2200 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2202 * src/maemo/modest-main-window.c:
2203 (on_account_store_connecting_finished): Do not try to get the
2204 connection ID if we are not really connected. I am surprised that
2205 this signal handler is called when we are not connected.
2207 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2209 * src/modest-error.h:
2210 * src/modest-ui-actions.c:
2211 (modest_ui_actions_get_msgs_full_error_handler):
2212 Renamed an enum, added comments, added an enum
2213 for retrieve-limit errors.
2215 * src/modest-mail-operation.c: (foreach_add_item),
2216 (internal_folder_observer_update), (update_account_thread),
2217 (modest_mail_operation_get_msgs_full):
2218 (modest_mail_operation_update_account),
2219 Added comments about how this works, and some code that should
2220 (but does not) check the retrieve-limit. See the TODO comment.
2222 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2224 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2225 Initialize help_id to fix the build. Warnings are good.
2227 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2229 * src/widgets/modest-hbox-cell-renderer.c:
2230 (modest_hbox_cell_renderer_append):
2231 * src/widgets/modest-vbox-cell-renderer.c:
2232 (modest_vbox_cell_renderer_append):
2233 Fix the last commit by doing an extra ref.
2235 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2237 * src/widgets/modest-hbox-cell-renderer.c:
2238 (modest_hbox_cell_renderer_append):
2239 * src/widgets/modest-vbox-cell-renderer.c:
2240 (modest_vbox_cell_renderer_append):
2241 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2242 to fix the build with Maemo Bora.
2243 However, there seems to be a remaining crash, probably due to reference
2246 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2248 * src/modest-tny-account.c:
2249 (modest_tny_account_new_for_local_folders):
2250 Use hildon_file_system_info_async_new() to get a better name for
2251 the memory card account, setting it as the account name.
2252 The timing seems to work, but this is probably
2253 not the best place to do this. See the TODO comment.
2254 * src/maemo/modest-main-window.c: (create_details_widget):
2255 * src/widgets/modest-folder-view.c: (text_cell_data):
2256 Use the tny account name instead of hardcoding a name.
2258 2007-05-30 Christian Kellner <ckellner@openismus.com>
2260 * src/modest-search.c: (modest_search):
2261 Correctly set part_search_func even if we have already parsed
2262 the query and thus a valid OgsTextSearcher object.
2264 2007-05-30 Christian Kellner <ckellner@openismus.com>
2267 Search and check for libogs.
2270 Incooparte the ogs build env.
2272 * src/modest-mime-part-search-stream.c:
2273 * src/modest-mime-part-search-stream.h:
2274 Removed since we do the real searching now in modest-search.c.
2276 * src/modest-search.c:
2277 * src/modest-search.h:
2278 Implement support for ogs. We use that if available and requested
2279 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2280 should now handle the corner case when the search term is spread
2281 across multiple reads.
2282 Also the logic in modest_search () was corrected to search all
2283 requested fields until one is found.
2285 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2287 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2289 * src/modest-init.h:
2290 * src/modest-init.c: Made modest_init_local_folders() take a
2291 path and be public so we can iniitialize maildir folders on
2294 * src/modest-local-folder-info.h:
2295 * src/modest-local-folder-info.c:
2296 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2298 * src/modest-tny-account.c:
2299 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2300 still means the standard local-folders path on the local volume.
2302 * src/modest-tny-account-store.c:
2303 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2304 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2305 all accounts when that happens.
2306 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2307 this too, so it shows up in the treeview.
2309 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2311 * src/maemo/modest-maemo-global-settings-dialog.c:
2312 (current_connection):
2313 * src/widgets/modest-global-settings-dialog.c:
2314 (current_connection_default):
2315 Use the enum values instead of 0, 1 and -1,
2316 to make the code clearer.
2318 * src/modest-account-mgr-helpers.c:
2319 (modest_account_mgr_get_connection_specific_smtp): Make this code
2322 * src/modest-runtime.h:
2323 * src/modest-runtime.c:
2324 Added modest_runtime_remove_all_send_queues().
2325 * src/maemo/modest-main-window.c:
2326 (on_account_store_connecting_finished): Recreate the send queues,
2327 using the appropriate transport accounts for this new connection.
2328 Some futher adapting might be needed if the old send queues are not
2329 automatically stopped at this point.
2331 * src/modest-tny-account-store.c: (get_server_accounts):
2332 Create the connection-specific transport accounts, so that they can
2333 be found later by their ID.
2335 * src/modest-tny-account.h:
2336 * src/modest-tny-account.c:
2337 Added modest_tny_account_new_from_server_account_name().
2338 modest_tny_account_new_from_server_account(): Do not create the
2339 send queues here, because they will be
2340 recreated anyway when the connection changes for the first time.
2342 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2344 * src/modest-local-folder-info.h:
2345 * src/modest-local-folder-info.c:
2346 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2347 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2348 tbox_folder): Take a modest account name instead of a server TnyAccount,
2349 so we can have per-modest-account rather than per-transport-account
2351 We must make sure that we change or recreate the exisitng send queues
2352 when the connection changes for connection-specific transport accounts.
2354 * src/modest-tny-account-store.c:
2355 (create_per_account_local_outbox_folders): Create outboxed per modest
2356 account, not per transport account.
2358 * src/modest-tny-account.h:
2359 * src/modest-tny-account.c:
2360 (modest_tny_account_get_special_folder): For outboxes, get the
2361 parent modest account name. The account is ignored for other folders.
2362 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2363 modest account name rather than a server TnyAccount.
2365 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2367 * src/modest-tny-account.c:
2368 (modest_tny_account_new_from_server_account):
2369 Call modest_runtime_get_send_queue() immediately after creating transport
2370 accounts, so that they start trying to send email from the outbox as soon
2371 as possible at startup. This is probably what we want.
2373 * src/modest-mail-operation.c: (update_account_thread):
2374 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2375 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2376 * src/modest-tny-send-queue.h:
2377 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2378 (modest_ui_actions_on_send):
2379 Added comments about how sending works, though it needs some more work.
2381 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2383 * src/modest-tny-account.c:
2384 (modest_tny_account_get_special_folder): Add TODO because this fails when
2385 the network is busy.
2386 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2387 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2388 Do not try to show this window when there is no active account. The UI
2389 specs does not tell us what to do in this case.
2391 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2395 * src/maemo/Makefile.am:
2396 * src/widgets/Makefile.am: Some dist fixes.
2398 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2400 * src/maemo/modest-connection-specific-smtp-window.c:
2401 (on_button_edit): Make the code clearer, to prevent a double free.
2403 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2405 * src/maemo/modest-account-settings-dialog.c:
2406 (modest_account_settings_dialog_set_account_name),
2407 Check the connection-specific smtp servers checkbox if there are any.
2409 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2410 (modest_connection_specific_smtp_edit_window_init):
2411 Start with a suitable port number.
2413 * src/modest-account-mgr-helpers.h:
2414 * src/modest-account-mgr-helpers.c: Added
2415 modest_account_mgr_get_has_connection_specific_smtp().
2417 (modest_account_mgr_set_connection_specific_smtp),
2418 (modest_account_mgr_remove_connection_specific_smtp),
2419 (modest_account_mgr_get_has_connection_specific_smtp),
2420 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2421 connection-specific smtp server accounts in the account, rather than
2422 the server account conf dir.
2424 This fixes bug projects.maemo.org bug NB#58263 .
2426 * src/modest-tny-account-store.c:
2427 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2428 if there are no server accounts yet, to prevent an infinite loop when there
2429 are no accounts. Document that one must be called before the other.
2431 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2433 * src/modest-account-mgr-helpers.c:
2434 (modest_account_mgr_get_default_account): Make sure that at least
2435 one account is always the default, if there are any enabled accounts.
2436 This is just a sanity check that shouldn't be necessary.
2438 * src/modest-account-mgr-priv.c:
2439 (_modest_account_mgr_account_from_key): Unescape the conf key to
2440 get the real account name. For instance, this is an issue if a space
2441 was in the account name, which can happen because the account name
2442 is generated from the display name.
2443 (_modest_account_mgr_get_account_keyname): Always escape the
2445 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2446 Unescape the conf keys to get the real account names.
2448 For instance, previously the is-default radio button in the accounts
2449 list was not checked for any accounts at first. This fixes that,
2450 and might fix several similar bugs.
2452 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2454 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2455 Removed some debug printfs.
2457 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2459 Modest on-disk outbox directories are now here, for instance:
2460 $HOME/.modest/outboxes/<account-id-1>/outbox
2461 $HOME/.modest/outboxes/<account-id-2>/outbox
2463 $HOME/.modest/local-folders/outbox
2464 so we can have a separate outbox for each account.
2465 But they are shown as one outbox in the GtkTreeView, by using a
2466 TnyMergeFolder in a ModestTnySimpleFolderStore.
2469 * src/modest-tny-simple-folder-store.c:
2470 * src/modest-tny-simple-folder-store.h:
2471 Added ModestTnySimpleFolderStore, used to contain folders from
2472 other folder stores, such as other accounts.
2474 * src/modest-tny-outbox-account.h:
2475 * src/modest-tny-outbox-account.c:
2476 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2477 used for the per-account local outbox folders.
2479 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2480 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2481 only use this (internally) now for the non-outbox local folders.
2483 * src/modest-init.h:
2484 * src/modest-init.c: Added modest_init_one_local_folder(), for
2485 setting up the directory structure for each local folder.
2487 * src/modest-local-folder-info.c:
2488 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2489 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2491 * src/modest-local-folder-info.h:
2492 * src/modest-tny-account-store.c: (on_account_removed),
2493 (on_account_changed), (create_per_account_local_outbox_folders),
2494 (get_server_accounts), (modest_tny_account_store_get_accounts),
2495 (modest_tny_account_store_get_tny_account_by_account),
2496 (modest_tny_folder_store_is_virtual_local_folders):
2498 * src/modest-tny-account.h:
2499 * src/modest-tny-account.c:
2500 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2501 to create an on-disk per-account local outbox folder for each
2503 (create_per_account_local_outbox_folders): Create a local outbox folder
2504 for each transport account.
2505 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2506 for all local folders.
2508 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2509 instead of using g_object_get/set() directly. It is clearer.
2511 (modest_tny_folder_store_get_message_count),
2512 (modest_tny_folder_store_get_local_size
2513 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2514 because we now use these with non-acount folder stores.
2516 (modest_tny_account_get_special_folder),
2517 (modest_tny_account_new_from_server_account),
2518 (modest_tny_account_new_from_account):
2519 (recurse_folders): Adjust to the new outbox system.
2521 * src/modest-tny-folder.h:
2522 * src/modest-tny-folder.c:
2523 (modest_tny_folder_is_local_folder),
2524 (modest_tny_folder_get_local_folder_type),
2525 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2527 * src/widgets/modest-main-window.h:
2528 * src/maemo/modest-main-window.c: (create_details_widget),
2529 (modest_main_window_set_contents_style): Show details for any folder store,
2532 (modest_tny_folder_get_rules):
2533 Remove the const. C does not support constness enough for this.
2535 * src/modest-ui-actions.c:
2536 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2537 make all outboxes appear as one, in the usual local-folders tree node.
2539 (set_active_account_from_tny_account),
2540 (modest_ui_actions_on_folder_selection_changed):
2541 * src/widgets/modest-folder-view.c: (text_cell_data),
2542 (icon_cell_data), (filter_row),
2543 (add_account_folders_to_merged_folder),
2544 (add_account_folders_to_simple_folder_store), (),
2545 (get_cmp_rows_type_pos), (cmp_rows),
2546 (modest_folder_view_set_account_id_of_visible_server_account):
2547 Adjust to the new outbox system, using generic folder stores and folders
2548 in the GtkTreeModel.
2550 2007-05-23 Christian Kellner <ckellner@openismus.com>
2552 * src/modest-mail-operation.c:
2553 (modest_mail_operation_update_account):
2554 Use info->max_size instead of unintialized local var [small
2555 build fix]. (Added TODO to review that change since I don't
2558 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2560 * libmodest-dbus-client/libmodest-dbus-client.c:
2561 (libmodest_dbus_client_compose_mail): function added
2562 * src/dbus_api/modest-dbus-api.h:
2563 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2564 (on_compose_mail): Implementation of the SendAsMail functionality
2566 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2568 * src/modest-account-mgr.c:
2569 (modest_account_mgr_add_server_account): Set the secure-connection
2570 conf key for transport accounts as well as store accounts. I don't know
2571 why the if was there. For instance, this makes sure that we use SSL
2572 for the gmail preset from the easysetup wizard.
2574 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2576 * src/gnome/modest-main-window.c:
2577 (on_account_store_connecting_finished), (connect_signals):
2578 * src/maemo/modest-main-window.c:
2579 (on_account_store_connecting_finished), (connect_signals),
2580 (modest_main_window_new):
2581 Handle TnyAccountStore::connecting-finished instead of
2582 TnyDevice::connection-changed, because we cannot actually perform
2583 operations on accounts until TnyAccountStore has itself responded to
2584 the TnyDevice::connection-changed signal. This prevents a GError from
2586 Do not try to update at startup, because we (at least on scratchbox)
2587 already do an update at startup when the device goes online.
2588 This prevents a GError from tinymail.
2589 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2590 Added TODO about stopping simultaneous operations.
2592 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2594 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2595 * src/modest-mail-operation-queue.c:
2596 (modest_mail_operation_queue_remove):
2597 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2598 about where they happened.
2600 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2602 * src/modest-ui-actions.c:
2603 (modest_ui_actions_on_password_requested): Make sure that the remember
2604 output parameter is always TRUE.
2606 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2608 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2609 Show a OK/Cancel dialog if the error is a question, though we still do not
2610 know anything more about what we are asking the user.
2611 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2612 Fix an uninitialized variable (helper). This is a logic error, however.
2614 2007-05-21 Christian Kellner <ckellner@openismus.com>
2616 * src/modest-search.h:
2617 Correct bit shifting in the ModestSearchFlags enum.
2619 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2621 * src/modest-tny-account.c:
2622 (modest_tny_account_new_from_server_account): Do not use the lsub and
2623 check-all hard-coded IMAP options when using POP.
2625 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2627 * src/modest-tny-account.c:
2628 (modest_tny_account_new_from_server_account):
2629 Use NULL for the secure-auth method for POP when Password auth has been
2630 specified by the user, as we already do for IMAP. "auth=Login" causes
2631 an error from camel or the server.
2633 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2635 * src/maemo/modest-account-settings-dialog.c:
2636 (create_page_account_details),
2637 (modest_account_settings_dialog_set_account_name):
2638 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2639 for the leave-on-server checkbox, rathr than just the checkbox, when
2640 the protocol is not POP.
2642 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2644 * src/widgets/modest-account-view.c:
2645 * src/widgets/modest-account-view.h:
2646 Added modest_account_view_select_account() which will be useful later
2647 to asynchronously re-select the edited account.
2649 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2651 * src/maemo/modest-account-settings-dialog.c:
2652 (modest_account_settings_dialog_set_account_name):
2653 Automatically choose the port numbers based on the secure authentication
2654 methods, if they have not been chosen before.
2655 This fixes projects.maemo.org bug NB#56273 .
2657 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/modest-main-window-ui.h:
2660 * src/modest-ui-actions.c:
2661 * src/modest-ui-actions.h:
2662 Connect the Tools/SMTP Servers menu item to
2663 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2664 SMTP servers dialog, as in the UI specification and saves changes when it
2665 is closed. This fixed projects.maemo.org bug NB#56305 .
2667 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2669 * src/maemo/modest-connection-specific-smtp-window.c:
2670 (modest_connection_specific_smtp_window_init):
2671 Use gtk_window_set_default_size() to make this window big enough, so
2672 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2674 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2676 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2677 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2678 (modest_connection_specific_smtp_edit_window_init),
2679 Do not try to connect to a combobox signal before the combobox exists.
2680 This fixes the cras in projects.maemo.org bug NB#56288 .
2681 (modest_connection_specific_smtp_edit_window_get_settings):
2682 Remove the server_account_name parameter which was being checked for NULL
2683 though it was not used.
2685 * src/maemo/modest-connection-specific-smtp-window.c:
2686 (modest_connection_specific_smtp_window_fill_with_connections),
2687 (on_button_edit), (modest_connection_specific_smtp_window_init):
2688 Correct the number of treemodel columns to prevent a warning.
2689 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2690 libconic does not work.
2692 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2694 * src/modest-tny-account.c:
2695 (modest_tny_account_new_from_server_account):
2696 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2697 SMTP when "None" was chosen by the user. However, with my SMTP server that
2698 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2701 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2703 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2704 to explain the memory management issue with the ID in the ModestPair.
2706 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2707 (add_sending_page), (modest_account_assistant_finalize):
2708 * src/gnome/modest-gnome-global-settings-dialog.c:
2709 (create_updating_page), (create_composing_page):
2710 * src/gnome/modest-msg-edit-window.c: (get_transports),
2711 (init_window), (modest_msg_edit_window_finalize),
2712 (modest_msg_edit_window_get_msg_data):
2713 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2714 * src/gnome/modest-transport-widget.c:
2715 (modest_transport_widget_finalize), (smtp_configuration):
2716 * src/maemo/modest-maemo-global-settings-dialog.c:
2717 (create_updating_page), (create_composing_page):
2718 * src/maemo/modest-msg-edit-window.c: (get_transports),
2719 (init_window), (modest_msg_edit_window_finalize),
2720 (modest_msg_edit_window_get_msg_data),
2721 (modest_msg_edit_window_free_msg_data):
2722 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2723 (modest_store_widget_finalize):
2724 * src/maemo/modest-transport-widget.c:
2725 (modest_transport_widget_finalize), (smtp_configuration):
2726 * src/modest-main.c: (send_mail):
2727 * src/widgets/modest-combo-box.h:
2728 * src/widgets/modest-global-settings-dialog-priv.h:
2729 * src/widgets/modest-global-settings-dialog.c:
2730 (modest_global_settings_dialog_finalize):
2731 * src/widgets/modest-msg-edit-window.h:
2732 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2733 as long as the combo box, to prevent use of freed memory for the ID.
2735 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2737 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2738 get_accounts(), to make this clearer. Do not check for the enabled gconf
2739 key, because we do not use this for server accounts (at least, not yet).
2740 This allows us to send email again.
2742 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2744 * src/maemo/modest-platform.c:
2745 (on_modest_conf_update_interval_changed), (modest_platform_init):
2746 Only respond to this particular key change. All these strcmp()s cannot be
2749 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2751 * src/maemo/modest-maemo-global-settings-dialog.c:
2752 (current_connection): Prevent a crash in scratchbox when
2753 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2754 * src/maemo/modest-platform.c:
2755 (on_modest_conf_update_interval_changed), (modest_platform_init):
2756 Get the update interval from gconf and reset it when the gconf key changes.
2758 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2760 * src/modest-protocol-info.c:
2761 * src/modest-protocol-info.h: Adde enum-specific get functions,
2762 instead of using a ModestProtocolType enum parameter.
2764 * src/gnome/modest-account-assistant.c:
2765 * src/gnome/modest-store-widget.c:
2766 * src/gnome/modest-store-widget.h:
2767 * src/gnome/modest-transport-widget.c:
2768 * src/gnome/modest-transport-widget.h:
2769 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2770 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2771 * src/maemo/easysetup/modest-easysetup-wizard.c:
2772 * src/maemo/modest-account-settings-dialog.c:
2773 * src/maemo/modest-account-settings-dialog.h:
2774 * src/maemo/modest-store-widget.c:
2775 * src/maemo/modest-store-widget.h:
2776 * src/maemo/modest-transport-widget.c:
2777 * src/maemo/modest-transport-widget.h:
2778 * src/modest-account-mgr-helpers.c:
2779 * src/modest-account-mgr-helpers.h:
2780 * src/modest-account-mgr.c:
2781 * src/modest-account-mgr.h:
2782 * src/modest-tny-account.c:
2783 * src/modest-tny-folder.c:
2784 * src/widgets/modest-account-view.c:
2785 * src/widgets/modest-retrieve-combo-box.c:
2786 * src/widgets/modest-retrieve-combo-box.h:
2787 * src/widgets/modest-secureauth-combo-box.c:
2788 * src/widgets/modest-serversecurity-combo-box.c:
2789 * src/widgets/modest-serversecurity-combo-box.h:
2790 * tests/check_account-mgr.c:
2791 Use the specific functions, and use the re-renamed enum values for GNOME too.
2793 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2795 * src/modest-pair.h:
2796 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2797 so we can get the second based on the first.
2799 * src/maemo/modest-account-settings-dialog.h:
2800 * src/maemo/modest-account-settings-dialog.c:
2801 Added get_supported_secure_authentication_methods(), though it is mostly
2802 commented-out for now until the necessary API is committed to tinymail.
2803 (modest_account_settings_dialog_set_account_name),
2804 (save_configuration): Request the supported authentication methods from the
2805 server, so we can choose a working method.
2807 * src/modest-tny-account-store.h:
2808 * src/modest-tny-account-store.c:
2809 (modest_tny_account_store_get_session): Rename from
2810 tny_account_store_get_session().
2812 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2814 * src/modest-protocol-info.h: Split the ModestProtocol enum
2815 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2816 There was no need to have these unrelated values in one enum.
2818 * src/: many files: Adapted to changed enum. This makes the code a bit
2819 clearer, and the compiler could catch some errors.
2821 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2823 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2824 Show the detailed internal camel error message when an error happens
2825 during the configuration, so that our testers can give us more clues.
2826 For instance, in projects.maemo.org bug NB#56910 .
2828 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2830 * src/modest-tny-account.c:
2831 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2832 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2834 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2836 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2837 * src/maemo/modest-account-settings-dialog.c:
2838 (modest_account_settings_dialog_set_account_name),
2839 (save_configuration): For the incoming secure authentication checkbox,
2840 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2841 the UI specification. PLAIN does not seem to be supported for most IMAP
2842 servers anyway, and I am not sure what it would mean.
2843 However, we probably need to discover which of the secure-authentication
2844 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2845 * src/modest-account-mgr-helpers.c:
2846 (modest_account_mgr_get_server_account_data):
2848 * src/modest-tny-account.c:
2849 (modest_tny_account_new_from_server_account):
2850 Use tny_account_set_mech() to set secure-authentication methods,
2851 with some special-casing for IMAP, based on my observations of how
2854 * src/modest-account-mgr-helpers.h:
2855 * src/modest-account-mgr.c:
2856 * src/modest-defs.h: Comment that the URI is only used for local folders.
2858 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2860 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2861 parameter const, just to be neat.
2862 * src/modest-text-utils.c: (modest_text_utils_inline):
2863 End g_strconcat() with NULL, as its documentation says. This is almost
2864 certainly the cause of my crash at startup on the device. Interestingly,
2865 valgrind doesn't tell us about these errors.
2867 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2869 * scripts/build-packages: Added more precise comments about how to use
2870 this script, though I still get this error:
2871 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2872 error building tinymail
2874 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2876 * src/maemo/modest-main-window.c: (on_account_update):
2877 Very slight cleanup, hoping to make it simpler to discover what causes
2878 a crash here sometimes.
2880 * src/modest-tny-account.c:
2881 (modest_tny_account_new_from_server_account): Set the port. Added
2882 comments about the options and a TODO comment because I need to find out
2883 how to specify the secure authentication method.
2885 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2887 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2888 changed CFlags paths form modest to libmodest
2890 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2892 * src/modest-account-mgr-helpers.c:
2893 (modest_account_mgr_get_server_account_data),
2894 (modest_account_mgr_free_server_account_data):
2895 * src/modest-account-mgr-helpers.h:
2896 * src/modest-account-mgr.c:
2897 (modest_account_mgr_add_server_account):
2898 * src/modest-defs.h:
2899 * src/modest-tny-account.c:
2900 (modest_tny_account_new_from_server_account):
2901 Determine the options for tny_camel_account_add_option() here,
2902 based on the settings, rather than storing them directly in gconf.
2904 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2906 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2907 Show a more friendly error dialog now that we expect (from the tinymail
2908 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2910 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2912 * src/maemo/modest-main-window.c: (on_account_update): Check that
2913 account_name is not NULL, to prevent a crash at startup that I am
2914 seeing on the N800. I do wonder why it is NULL.
2916 * src/maemo/easysetup/modest-easysetup-wizard.c:
2917 (create_page_user_details):
2918 * src/maemo/modest-account-settings-dialog.c:
2919 (create_page_user_details), (create_page_outgoing):
2920 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2921 (modest_connection_specific_smtp_edit_window_init):
2922 * src/modest-ui-actions.c:
2923 (modest_ui_actions_on_password_requested):
2924 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2925 might do something useful with the on-screen keyboard.
2927 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2929 * src/maemo/modest-main-window.c: (on_account_update):
2930 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2931 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2933 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2935 * src/modest-tny-account-store.c: (on_account_changed):
2936 Correct the signature of this signal handler.
2938 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2940 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2941 Show a HildonNote instead of a GtkDialog for Maemo.
2943 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2945 * src/widgets/modest-account-view.h:
2946 * src/widgets/modest-account-view.c: (on_account_changed),
2947 (on_account_removed). Added a boolean flag, set/unset by
2948 modest_account_view_block_conf_updates(),
2949 modest_account_view_unblock_conf_updates() to prevent unnecessary
2950 updates, but this is not very useful because the gconf notifications are
2951 so delays (maybe only on Maemo Bora).
2952 So auto-updating is turned off, and these functions do an explicit
2953 update when necessary.
2954 However, something else is still doing too much work when adding/removing
2955 accounts, probably in another part of the application.
2957 * src/maemo/modest-account-view-window.c:
2958 (on_delete_button_clicked), (on_edit_button_clicked),
2959 (on_new_button_clicked): Use the new functions.
2961 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2963 * src/modest-account-mgr-helpers.c:
2964 (modest_account_mgr_set_first_account_as_default):
2965 Sort the list of names alphabetically-by-title, so we choose the first one
2967 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2968 alphabetically by the title.
2970 This fixes projects.maemo.org bug NB#56418 .
2972 * src/modest-account-mgr-priv.c:
2973 (_modest_account_mgr_account_from_key):
2974 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2975 avoid a valgrind error, and possible random behaviour.
2977 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2979 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2980 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2981 tinymail documentation to say that this can be expected.
2982 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2983 pretty, and should not happen, but I would prefer to know when it does.
2985 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2987 * configure.ac: When using the older hildon version, probably on Bora,
2988 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2990 * src/widgets/modest-attachment-view.c:
2991 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2994 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2996 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2997 Implemented the prototype. Can be tested with
2998 tests/dbus_api/test_open_message:
3000 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3002 * src/modest-tny-account-store.c:
3003 (modest_tny_account_store_instance_init), (get_password):
3004 * src/modest-ui-actions.c:
3005 (modest_ui_actions_on_password_requested):
3006 Do not store the password in gconf, because this function is called
3007 for non-remembered passwords. Actually use the cached (in the hash map)
3008 password instead of releasing it.
3009 The password will now not be remembered if it is asked via the protected
3010 password dialog, as per the UI spec.
3012 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3014 * src/modest-defs.h:
3015 * src/modest-account-mgr-helpers.h:
3016 * src/modest-account-mgr-helpers.c:
3017 Added modest_server_account_get_username_has_succeeded(),
3018 modest_server_account_set_username_has_succeeded().
3019 (modest_server_account_set_username),
3020 Reset the has-succeeded flag if the username changes.
3022 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3023 * src/maemo/modest-connection-specific-smtp-window.c:
3024 (modest_connection_specific_smtp_window_save_server_accounts):
3025 Use modest_server_account_set_username() instead of using
3026 modest_conf_set_string() directly, so that the has-succeeded flag is always
3029 * src/modest-ui-actions.c:
3030 (modest_ui_actions_on_password_requested): Dim the username entry if
3031 the username has ever worked, as per the UI spec.
3033 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3035 * src/modest-tny-account-store.c: (get_password):
3036 * src/modest-ui-actions.c:
3037 (modest_ui_actions_on_password_requested):
3038 Allow the username to be changed too, though there is more work to
3039 be done on exactly how this behaves.
3041 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3043 * src/modest-account-mgr-helpers.h:
3044 * src/modest-account-mgr-helpers.c:
3045 Added modest_account_mgr_get_display_name(),
3046 modest_server_account_get_username(),
3047 modest_server_account_set_username(),
3048 modest_server_account_set_password(),
3049 modest_server_account_get_hostname() functions so we do not need to
3050 use the conf API directly.
3052 * src/maemo/modest-main-window.c: (connect_signals):
3053 Actually connect ot the ModestAccountStore::request-password signal,
3054 so that we show the dialog when the password is requested by Tinymail,
3055 for isntance if it is empty.
3057 * src/modest-marshal.list:
3058 * src/modest-tny-account-store.c:
3059 (modest_tny_account_store_class_init), (get_password),
3060 (modest_tny_account_store_alert):
3061 * src/modest-tny-account-store.h:
3062 * src/modest-ui-actions.h:
3063 * src/modest-ui-actions.c:
3064 (modest_ui_actions_on_password_requested):
3065 Change the signal parameters, so it is obvious that we are providing
3066 the non human-readable server name, and receiving both the username
3067 and password, though changing of the username is not yet implemented.
3068 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3069 for the GNOME version.
3071 This should fix the projects.maemo.org bug NB#56209, though it does not
3072 work on Bora, because the gconf_client_get() for the password fails
3073 immediately after we save it with gconf_client_set().
3075 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3078 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3079 caused an undefined symbol error:
3080 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3082 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3084 * src/modest-tny-account-store.c:
3085 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3086 using a GError instead of a string message, so we can translate it in
3089 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3091 * src/maemo/modest-address-book.c:
3092 (modest_address_book_check_names):
3093 * src/maemo/modest-msg-view-window.c:
3094 (modest_msg_view_window_clipboard_owner_change):
3095 * src/modest-init.c: (modest_init_init_ui):
3096 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3097 (update_folders_cb), (modest_mail_operation_update_account):
3098 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3099 (modest_ui_actions_on_msg_attachment_clicked),
3100 (modest_ui_actions_on_msg_recpt_activated):
3101 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3102 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3103 (modest_msg_view_search_next):
3104 * src/widgets/modest-recpt-editor.c:
3105 (modest_recpt_editor_on_button_release_event),
3106 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3107 g_message(). At this point we should only be seeing interesting errors on
3108 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3110 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3112 (modest_wizard_dialog_force_title_update):
3113 * src/maemo/easysetup/modest-wizard-dialog.h:
3114 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3115 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3116 can update the title when appropriate. Otherwise the title is wrong if the
3117 pages are added after adding the notebook to the dialog.
3118 This must be a problem in HildonWizardDialog too.
3119 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3121 * src/maemo/easysetup/modest-easysetup-wizard.c:
3122 (create_subsequent_customsetup_pages),
3123 (create_subsequent_easysetup_pages):
3124 Call modest_wizard_dialog_force_title_update() so that the title is
3125 correct even with GTK+ < 2.10.
3126 This fixes projects.maemo.org bug NB#56145 .
3128 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3130 * src/maemo/modest-platform.c:
3131 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3132 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3135 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3137 * src/widgets/modest-window.h:
3138 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3139 and modest_window_save_state(), which invokes it.
3141 * src/widgets/modest-window-mgr.h:
3142 * src/widgets/modest-window-mgr.c:
3143 Added modest_window_mgr_save_state_for_all_windows(), which calls
3144 the save_state vfunc on all registered windows, if implemented.
3146 * src/gnome/modest-msg-edit-window.c:
3147 * src/gnome/modest-msg-view-window.c:
3148 * src/maemo/modest-msg-edit-window.c:
3149 * src/maemo/modest-msg-view-window.c:
3150 * src/maemo/modest-main-window.c:
3151 Specify the existing save_settings functions as implementations of
3152 ModestWindow::save_state_func().
3154 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3155 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3156 enabling hibernation, for instance.
3158 We may need to do the same thing for restoring settings.
3161 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3163 * src/widgets/modest-window-mgr.c:
3164 * src/widgets/modest-window-mgr.h:
3165 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3166 modest_window_mgr_get_hibernation_is_prevented().
3168 * src/maemo/modest-main-window.c:
3169 (on_hildon_program_is_topmost_notify): Prevent hibernation
3170 (possible when the application goes to the background in the WM),
3171 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3173 * src/maemo/easysetup/modest-easysetup-wizard.c:
3174 (modest_easysetup_wizard_dialog_init):
3175 * src/maemo/modest-account-settings-dialog.c:
3176 (modest_account_settings_dialog_init):
3177 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3178 (modest_connection_specific_smtp_edit_window_init):
3179 * src/maemo/modest-connection-specific-smtp-window.c:
3180 (modest_connection_specific_smtp_window_init):
3181 * src/maemo/modest-signature-editor-dialog.c:
3182 (modest_signature_editor_dialog_init):
3183 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3184 prevent hibernation while any of these account settings dialogs are open.
3186 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3188 * src/maemo/Makefile.am:
3189 * src/maemo/modest-osso-state-saving.c:
3190 * src/maemo/modest-osso-state-saving.h: Added
3191 modest_osso_load_state() and modest_osso_save_state() though they do
3192 nothing now. They should iterate through all the open windows and load/save
3194 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3195 save state when closing.
3197 * src/maemo/modest-main-window.c:
3198 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3199 Add a notification handler for the HildonProgram::is-topmost property,
3200 so we can allow hibernation when the application goes into the background.
3201 But we still need to detect when the accounts setup windows are open so
3202 we can stop hibernation when they are open.
3203 To do this, I also added the main window the HildonProgram. This might have
3204 other side-effects/benefits, and should maybe be done for other windows.
3206 * src/maemo/modest-osso-autosave-callbacks.h:
3207 * src/maemo/modest-osso-autosave-callbacks.c:
3208 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3209 though it does not do anything yet, and we might never need this to do
3210 anything. For instance, we already save drafts.
3212 * src/maemo/modest-platform.c: (modest_platform_init):
3213 Specify the libosso auto-save callback.
3215 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3217 * src/maemo/modest-platform.c:
3218 (modest_platform_set_update_interval):
3219 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3220 aparently stays valid between application instances, so we can use this
3221 to remove and reset it later. According to a maemo-developers email from
3224 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3226 * configure.ac: Depend on libalarm for Maemo.
3228 * src/dbus_api/modest-dbus-api.h:
3229 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3230 (on_send_receive), (modest_dbus_req_handler):
3231 Handle a SEND_RECEIVE D-Bus method.
3233 * libmodest-dbus-client/libmodest-dbus-client.c:
3234 (libmodest_dbus_client_send_and_receive):
3235 * libmodest-dbus-client/libmodest-dbus-client.h:
3236 Add C convenience functions for calling the new D-Bus method.
3238 * src/modest-platform.h:
3239 * src/gnome/modest-platform.c:
3240 * src/maemo/modest-platform.c:
3241 Added modest_platform_set_update_interval(), which uses the
3242 alarmd API on Maemo.
3243 (modest_platform_init),
3244 Call modest_platform_set_update_interval(), using a hard-coded
3245 interval for now (until the global settings dialog is implemented),
3246 though I am not sure that this makes sense yet.
3248 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3250 * src/dbus_api/modest-dbus-callbacks.c:
3251 (modest_osso_cb_hw_state_handler):
3252 * src/dbus_api/modest-dbus-callbacks.h:
3253 * src/maemo/modest-platform.c: (modest_platform_init):
3254 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3255 in case this has some effect on the ability for Maemo to ping the
3258 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3260 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3261 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3262 warning. It is probably a logic error, but I need to fix the build.
3264 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3266 * src/modest-account-mgr.h:
3267 * src/modest-account-mgr.c:
3268 (modest_account_mgr_account_names): Add a gboolean enabled_only
3269 parameter, so we can get lists of onlt the enabled accounts.
3271 (modest_account_mgr_add_account),,
3272 (modest_account_mgr_account_with_display_name_exists):
3273 * src/maemo/modest-msg-edit-window.c: (get_transports):
3274 * src/modest-account-mgr-helpers.c:
3275 (modest_account_mgr_set_first_account_as_default):
3276 * src/modest-init.c: (init_default_account_maybe):
3277 * src/modest-tny-account-store.c: (get_accounts):
3278 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3279 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3280 * tests/check_account-mgr.c: (START_TEST):
3281 Provide the extra parameter, as appropriate.
3283 * src/widgets/modest-account-view.c: (update_account_view):
3284 Do not show disabled accounts (meaning that there is no way to
3285 enable/disable accounts in the UI (the feature is not in our UI
3286 specification), so we can use this internally only to mark unfinished
3287 or temporary account data.
3289 * src/maemo/easysetup/modest-easysetup-wizard.c:
3290 (create_account): Add boolean enable parameter, so we can specify FALSE
3291 to create the temporary account.
3292 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3293 (on_before_next): When finishing, when there is a temporary account, just
3295 Also, use a timeout to delay the showing of the dialog until gconf is likely
3296 to return correct information, due to a maemo gconf bug that is fixed in
3297 osso 1.1, but not yet in Bora.
3298 However, the dialog stays on screen after it is destroyed.
3300 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3301 for invalid data when cancelling. Use a hildon note instead of a dialog
3302 to complain about invalid data. Do not show the account-saved note if the
3303 account is disabled (a temporary account that will not really be saved for use
3306 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3308 * src/modest-account-mgr-helpers.h:
3309 * src/modest-account-mgr-helpers.c:
3310 Added modest_account_mgr_unset_default_account(),
3311 Added modest_account_mgr_set_first_account_as_default().
3313 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3314 If it was the default account, unset the default account name.
3316 * src/maemo/modest-account-view-window.c:
3317 (on_delete_button_clicked): If it was the default account,
3318 set the first remaining account as the default instead.
3320 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3321 a NULL account or a NULL default account, to prevent a crash. This should
3322 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3325 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3327 * src/widgets/modest-recpt-editor.c:
3328 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3329 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3330 TODO comment for this. This fixes the build.
3332 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3333 be the best place for it. This will in future update all auto-update accounts,
3334 rather than just the current/default account, when that gconf key exists.
3335 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3336 if there are no accounts, before calling do_send_receive().
3337 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3339 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3340 * src/maemo/modest-main-window-ui.h:
3341 * src/maemo/modest-main-window.c: (on_connection_changed),
3342 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3343 directly, becaue the signal handler does more.
3345 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3347 * src/modest-account-mgr-helpers.c:
3348 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3349 for the case that the account does not exist.
3351 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3352 (equivalent to the modest account name) rather than the tinymail account name
3353 (equivalent to the modest account title - human readable) to get the account data.
3354 Check for null account data to prevent the crash, and add a TODO comment saying that
3355 this needs fixing because it is using the server account name instead of the account name.
3357 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3359 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3360 * src/maemo/modest-account-settings-dialog.c: (show_error),
3362 Use hildon_note_new_information() for informative and error messages,
3363 which seems to be expected for Maemo applications (no documentation that I know of
3364 says this). I am surprised that there is no distinction between info and error
3367 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3369 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3370 it is easy to find where this is used.
3372 * src/maemo/easysetup/modest-easysetup-wizard.c:
3373 (create_page_welcome), (create_page_account_details),
3374 (create_page_user_details), (create_page_complete_easysetup),
3375 (create_page_custom_incoming), (create_page_custom_outgoing),
3376 (create_page_complete_custom):
3377 * src/maemo/modest-account-settings-dialog.c:
3378 (create_page_account_details), (create_page_user_details),
3379 (create_page_incoming), (create_page_outgoing):
3380 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3381 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3382 (modest_connection_specific_smtp_edit_window_init):
3383 * src/maemo/modest-connection-specific-smtp-window.c:
3384 (modest_connection_specific_smtp_window_init):
3385 * src/maemo/modest-signature-editor-dialog.c:
3386 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3387 and scrolling policy as per the Email Application Layout Guide, if I have
3390 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3392 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3393 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3394 which were empty, because these vfuncs have been removed from TnyAccountStore.
3395 This fixes the build.
3397 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3399 * src/maemo/modest-main-window.c:
3400 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3401 showing/hiding it. Added TODO because it probably should not be NULL.
3402 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3403 because unnecessary g_warnings() make degugging difficult.
3405 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3407 * src/maemo/modest-msg-edit-window.c:
3408 (modest_msg_edit_window_select_color),
3409 (modest_msg_edit_window_select_background_color): 2 const corrections and
3410 moving 2 #endifs before closing brackets, to fix the build.
3412 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3414 * src/maemo/easysetup/modest-easysetup-wizard.h:
3415 * src/maemo/easysetup/modest-easysetup-wizard.c:
3416 (modest_easysetup_wizard_dialog_finalize),
3417 (on_button_edit_advanced_settings), (create_page_complete_custom),
3418 (on_response), (create_account):
3419 Implement the Advanced Settings edit button, by saving the account information,
3420 for the Advanded Settings dialog to use directly from gconf, and removing it
3421 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3422 Bug #5533 in the projects.maemo.org bugzilla.
3424 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3426 * src/maemo/modest-msg-view-window.c:
3427 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3428 when opening a message window.
3430 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3432 * src/maemo/easysetup/modest-easysetup-wizard.c:
3433 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3436 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3437 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3438 gconf settings. I probably added more checks than necessary, but that is safer.
3440 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3441 variable to fix the build, but this seems to be used when it is still NULL.
3443 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3445 * src/modest-platform.h:
3446 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3447 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3448 * src/modest-main.c: Implement this function so we can avoid using
3449 maemo-specific API from cross-platform code.
3451 * src/modest-tny-account-store.c:
3452 (get_smtp_specific_transport_account_for_open_connection):
3453 * src/modest-ui-actions.c: (check_for_connection),
3454 (modest_ui_actions_on_item_not_found):
3455 Use modest_platform_connect_and_wait() and put #idefs around other
3456 maemo-specific code, because only maemo currently has a way to
3457 identify connection names.
3459 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3461 * src/modest-tny-account-store.h:
3462 * src/modest-tny-account-store.c:
3463 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3464 the connection-specific SMTP server settings in the configuration.
3466 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3468 * src/maemo/modest-main-window.c: (on_connection_changed),
3470 * src/modest-main.c: (main), (start_ui), (send_mail):
3471 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3472 that is what is intended.
3474 * src/modest-ui-actions.c: (action_send), (action_receive),
3475 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3476 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3477 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3478 SMTP server is used when it is specified.
3480 (modest_ui_actions_on_send_receive):
3481 Check that a connection is open before proceeding.
3482 Receive and then send, instead of vice-versa, as per the specification.
3484 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3486 * src/modest-mail-operation.c:
3487 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3488 though I guess it should be something other than NULL.
3490 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3492 * src/maemo/easysetup/modest-easysetup-wizard.c:
3493 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3494 combo twice, to avoid an g_warning and to make it visible again.
3495 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3496 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3497 (already intended) dereference when detaching, because we then recreate the menu.
3498 But I am not sure why the warning was happening, and it is possible that this is a memory
3501 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3503 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3504 and uri_parse_mailto() utility functions.
3505 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3507 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3509 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3511 * src/dbus_api/modest-dbus-api.h:
3512 * src/dbus_api/modest-dbus-callbacks.c:
3513 Use an idle callback to execute the modest code in the application's own thread.
3514 Remove the helloworld example method.
3515 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3516 parsed, and the open-message method is not implemented because this is not yet implemented in
3518 * libmodest-dbus-client/libmodest-dbus-client.c:
3519 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3520 (libmodest_dbus_client_open_message):
3521 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3523 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3524 body without crashing.
3526 * tests/dbus_api/Makefile.am:
3527 * tests/dbus_api/test_mail_to.c:
3528 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3530 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3532 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3533 Added file to fix the build. Sorry.
3535 * src/dbus_api/Makefile.am:
3536 * src/dbus_api/modest-dbus-api.h:
3537 * src/dbus_api/modest-dbus-callbacks.h:
3538 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3539 (modest_dbus_req_handler):
3540 Put constants in a separate header so it can be reused by the
3541 client library, without duplication
3543 * libmodest-dbus-client/Makefile.am:
3544 * libmodest-dbus-client/libmodest-dbus-client.c:
3545 (libmodest_dbus_client_call_helloworld),
3546 (libmodfest_dbus_client_send_mail),
3547 (libmodfest_dbus_client_mailto),
3548 (libmodfest_dbus_client_open_message):
3549 * libmodest-dbus-client/libmodest-dbus-client.h:
3550 (Partly) Implement a send_mail D-Bus method.
3552 * tests/dbus_api/Makefile.am:
3553 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3554 the send_email D-Bus method.
3556 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3560 * libmodest-dbus-client/Makefile.am:
3561 * libmodest-dbus-client/libmodest-dbus-client.c:
3562 * libmodest-dbus-client/libmodest-dbus-client.h:
3563 * tests/dbus_api/Makefile.am:
3564 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3565 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3567 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3569 * src/maemo/easysetup/modest-easysetup-wizard.c:
3570 (create_page_account_details):
3571 * src/maemo/modest-account-settings-dialog.c:
3572 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3573 widgets, because this might not be the default in future versions of the Maemo GTK+.
3574 However, I can not not get capitalization to work even in a simple test case.
3576 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3578 * src/maemo/easysetup/modest-easysetup-wizard.c:
3579 (create_page_custom_incoming), (create_page_custom_outgoing):
3580 * src/maemo/modest-account-settings-dialog.c:
3581 (create_page_account_details), (create_page_incoming),
3582 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3583 instead of using gtk_check_button_with_label(), so they are aligned like the other
3584 widgets, as per the UI spec.
3586 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3588 * src/maemo/easysetup/modest-easysetup-wizard.c:
3589 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3590 * src/widgets/modest-validating-entry.c:
3591 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3592 Modest prefix instead of an EasySetup prefix.
3594 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3596 * src/widgets/modest-validating-entry.h:
3597 * src/widgets/modest-validating-entry.c: (on_insert_text),
3598 Added easysetup_validating_entry_set_max_func(), used to set a callback
3599 to call when the max number of characters is reached. GtkEntry has a max-length
3600 already but is silent about it.
3602 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3603 (create_page_account_details), (create_page_user_details),
3605 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3606 (create_page_account_details), (create_page_user_details),
3607 (create_page_outgoing):
3608 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3609 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3610 the UI spec, when the user tries to enter more than the max number of characters.
3612 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3614 * src/maemo/easysetup/modest-easysetup-wizard.c:
3615 (create_page_user_details), (create_page_custom_incoming),
3616 (create_page_custom_outgoing):
3617 * src/maemo/modest-account-settings-dialog.c:
3618 (create_page_user_details), (create_page_incoming),
3619 (create_page_outgoing):
3620 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3621 (modest_connection_specific_smtp_edit_window_init):
3622 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3623 not appropriate. Bad Maemo-specific defaults!.
3625 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3627 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3628 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3629 (modest_signature_editor_dialog_set_settings):
3630 Disable the label and textview when the checkbox is disabled, and use the
3631 specified (UI spec) default signature text.
3633 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3635 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3636 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3638 * src/modest-defs.h:
3639 * src/modest-account-mgr-helpers.h:
3640 * src/modest-account-mgr-helpers.c:
3641 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3643 * src/maemo/Makefile.am:
3644 * src/maemo/modest-signature-editor-dialog.c:
3645 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3648 * src/maemo/modest-account-settings-dialog.h:
3649 * src/maemo/modest-account-settings-dialog.c:
3650 (modest_account_settings_dialog_finalize), (on_button_signature),
3651 (save_configuration): Use the new dialog when the Edit button is pressed, and
3652 save the changes if necessary, as per the UI spec.
3654 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3656 * src/maemo/Makefile.am:
3657 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3658 based on maemo-develoers email from Dirk.
3660 * src/maemo/easysetup/modest-easysetup-wizard.c:
3661 (create_page_welcome), (create_page_account_details),
3662 (create_page_user_details), (create_page_complete_easysetup),
3663 (create_page_custom_incoming), (create_page_custom_outgoing),
3664 (create_page_complete_custom),
3665 (modest_easysetup_wizard_dialog_init):
3666 * src/maemo/modest-account-settings-dialog.c:
3667 (create_page_account_details), (create_page_user_details),
3668 (create_page_incoming), (create_page_outgoing),
3669 (modest_account_settings_dialog_init):
3670 * src/maemo/modest-connection-specific-smtp-window.c:
3671 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3673 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3675 * src/maemo/easysetup/modest-easysetup-wizard.c:
3676 (create_page_account_details), (create_page_custom_outgoing),
3677 (create_page_complete_custom):
3678 * src/maemo/modest-account-settings-dialog.c:
3679 (create_page_user_details), (create_page_incoming),
3680 (create_page_outgoing):
3681 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3682 (modest_connection_specific_smtp_edit_window_init):
3683 Use the correct (UI spec) port min/max, and use horizontal separators,
3686 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3688 * src/maemo/easysetup/modest-easysetup-wizard.c:
3689 (set_default_custom_servernames):
3690 * src/maemo/modest-account-settings-dialog.c:
3691 (create_page_incoming), (on_combo_outgoing_security_changed),
3692 (on_combo_incoming_security_changed), (create_page_outgoing),
3693 (modest_account_settings_dialog_set_account_name),
3694 (save_configuration):
3695 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3696 (on_combo_security_changed),
3697 (modest_connection_specific_smtp_edit_window_init),
3698 (modest_connection_specific_smtp_edit_window_set_connection),
3699 (modest_connection_specific_smtp_edit_window_get_settings):
3700 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3703 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3706 * src/maemo/easysetup/modest-easysetup-wizard.c:
3707 (create_page_custom_outgoing), (create_page_complete_custom):
3708 * src/maemo/modest-account-settings-dialog.c:
3709 (create_page_user_details), (create_page_outgoing):
3710 * src/maemo/modest-account-view-window.c: (button_box_new):
3711 Use changed logical IDs as per the most recent UI spec:
3712 mcen_bd_emailsetup_edit -> mcen_bd_edit
3713 mcen_bd_emailsetup_delete -> mcen_bd_delete
3714 mcen_bd_emailsetup_close -> mcen_bd_close
3716 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3720 * src/dbus_api/Makefile.am:
3721 * src/dbus_api/modest-dbus-callbacks.c:
3722 * src/dbus_api/modest-dbus-callbacks.h:
3723 * src/maemo/modest-platform.c: (modest_platform_init):
3724 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3726 * tests/Makefile.am:
3727 * tests/dbus_api/Makefile.am:
3728 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3730 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3732 * src/maemo/modest-account-settings-dialog.c:
3733 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3734 Removed unnecessary includes.
3736 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3738 * src/maemo/easysetup/modest-easysetup-wizard.c:
3739 * src/maemo/modest-account-settings-dialog.c:
3740 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3741 * src/widgets/Makefile.am:
3742 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3743 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3744 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3745 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3746 * src/widgets/modest-secureauth-combo-box.c:
3747 * src/widgets/modest-secureauth-combo-box.h:
3748 * src/widgets/modest-serversecurity-combo-box.c:
3749 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3750 made the GObject names more consistent with the rest of the Modest code.
3752 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3754 * src/maemo/easysetup/Makefile.am:
3755 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3756 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3757 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3758 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3759 * src/maemo/easysetup/modest-easysetup-wizard.c:
3760 * src/maemo/easysetup/modest-validating-entry.c:
3761 * src/maemo/easysetup/modest-validating-entry.h:
3762 * src/maemo/modest-account-settings-dialog.c:
3763 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3764 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3765 widgets/ because they are used outside of easysetup too. After checking in,
3766 svn will allow me to rename them too.
3768 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3770 * src/gnome/modest-msg-edit-window.c:
3771 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3772 linker error, to fix the build on the GNOME platform.
3773 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3774 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3775 ifdefed out to avoid a warning.
3777 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3779 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3780 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3781 some alternative for GTK+ 2.6.
3783 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3785 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3787 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3788 specified for EmailAccountsDialog in UI spec.
3790 * src/maemo/easysetup/modest-easysetup-wizard.c:
3791 * src/maemo/easysetup/modest-easysetup-wizard.h:
3792 * src/maemo/modest-account-settings-dialog.c:
3793 * src/maemo/modest-account-settings-dialog.h:
3794 Reuse a member window widget for the connection-specific SMTP server accounts,
3795 so we can tell it to create/save the accounts only if we actually save changes.
3797 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3798 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3799 (modest_connection_specific_smtp_edit_window_get_settings):
3800 Return a struct instance for temporarily remembering the entered data.
3802 * src/maemo/modest-connection-specific-smtp-window.h:
3803 * src/maemo/modest-connection-specific-smtp-window.c:
3804 (modest_connection_specific_smtp_window_finalize),
3805 (modest_connection_specific_smtp_window_fill_with_connections),
3807 (modest_connection_specific_smtp_window_save_server_accounts),
3808 (update_model_server_names): Do not actually save data until asked,
3809 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3811 (on_selection_changed),
3812 (modest_connection_specific_smtp_window_init): Disable the edit
3813 button when nothing is selected.
3815 * src/modest-account-mgr-helpers.c:
3816 * src/modest-account-mgr-helpers.h:
3817 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3820 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3822 * src/modest-account-mgr-helpers.h:
3823 * src/modest-account-mgr-helpers.c:
3824 (modest_account_mgr_get_unused_account_name),
3825 (modest_account_mgr_get_unused_account_display_name): Added these
3826 utility functions, to avoid code duplication.
3828 * src/maemo/easysetup/modest-easysetup-wizard.c:
3829 (create_page_account_details), (create_account):
3830 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3831 (on_combo_security_changed),
3832 (modest_connection_specific_smtp_edit_window_init),
3833 (modest_connection_specific_smtp_edit_window_save_settings):
3834 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3835 * src/maemo/modest-connection-specific-smtp-window.c:
3836 (modest_connection_specific_smtp_window_finalize),
3837 (modest_connection_specific_smtp_window_fill_with_connections),
3838 (on_button_edit), (modest_connection_specific_smtp_window_init):
3839 * src/maemo/modest-connection-specific-smtp-window.h:
3840 Implementing saving of connection-specific server accounts.
3842 But I need to refactor this so we can save the data for each
3843 possible connection-specific account and only actually create the server accounts
3844 when the easysetup finished, or the OK button is pressed on the account settings
3847 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3849 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3850 (on_combo_security_changed):
3851 (modest_connection_specific_smtp_edit_window_init):
3852 Auto-fill the port number as in the account settings.
3854 (modest_connection_specific_smtp_edit_window_set_connection):
3855 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3856 * src/maemo/modest-connection-specific-smtp-window.c:
3857 (fill_with_connections), (on_button_edit),
3858 (modest_connection_specific_smtp_window_init):
3859 Turn the edit window into a dialog to simplify the code, and
3860 set a WM hint as in a GtkDialog, because only a popup can be on top of
3861 another window in Maemo, and popups usually have no WM decoration.
3863 * src/modest-defs.h:
3864 * src/modest-account-mgr-helpers.c:
3865 (modest_account_mgr_set_connection_specific_smtp),
3866 (modest_account_mgr_remove_connection_specific_smtp),
3867 (modest_account_mgr_get_connection_specific_smtp):
3868 * src/modest-account-mgr-helpers.h: Some functions to write the
3869 connection-specific SMTP server information. Not yet used.
3872 * src/widgets/modest-folder-view.c: (text_cell_data):
3873 Fix a warning about an uninitialized variable.
3874 (on_configuration_key_changed): Put an #ifdef around the use
3875 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3877 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3879 * src/maemo/modest-account-settings-dialog.h:
3880 * src/maemo/modest-account-settings-dialog.c:
3881 Added connect_for_modified() utility function to mark the new modified boolean.
3883 (create_page_account_details), (create_page_user_details),
3884 (create_page_incoming), (create_page_outgoing), (on_response),
3885 (modest_account_settings_dialog_init),
3886 (modest_account_settings_dialog_set_account_name):
3887 Only warn about unsaved changes when there are actually unsaved changes.
3889 * src/modest-account-mgr-helpers.c:
3890 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3891 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3892 to get the data from there in future.
3894 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3896 * src/modest-defs.h:
3898 * src/modest-account-mgr-helpers.h:
3899 * src/modest-account-mgr-helpers.c:
3900 Store the security account setting in a single conf key instead of using
3901 the options list, so that the list is left for just the to-be-removed camel hack,
3902 and because gconf_client_set_list() is failing for some reason.
3904 * src/modest-account-mgr.c:
3905 (modest_account_mgr_add_server_account):
3906 * src/maemo/modest-account-settings-dialog.c:
3907 (modest_account_settings_dialog_set_account_name),
3908 (save_configuration): Use the renamed functions.
3911 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3913 * src/widgets/Makefile.am:
3914 * src/widgets/modest-limit-retrieve-combo-box.c:
3915 * src/widgets/modest-limit-retrieve-combo-box.h:
3916 * src/widgets/modest-retrieve-combo-box.c:
3917 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3918 the account settings dialog.
3920 * src/modest-defs.h:
3921 * src/modest-account-mgr-helpers.h:
3922 * src/modest-account-mgr-helpers.c:
3923 (modest_server_account_get_option_secure_auth),
3924 (modest_server_account_set_option_secure_auth):
3925 * src/modest-account-mgr.c:
3926 (modest_account_mgr_add_server_account):
3927 Use the existing AUTH_MECH conf key for the secure-auth setting,
3928 instead of putting it in the list options, because this was actually used already.
3930 * src/maemo/modest-account-settings-dialog.c:
3931 (create_page_account_details),
3932 (modest_account_settings_dialog_set_account_name),
3933 (save_configuration):
3934 * src/maemo/modest-account-settings-dialog.h:
3935 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3936 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3938 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3940 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3941 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3942 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3944 * src/modest-defs.h:
3945 * src/maemo/modest-account-settings-dialog.c:
3946 (create_page_incoming), (on_combo_outgoing_security_changed),
3947 (on_combo_incoming_security_changed), (create_page_outgoing),
3948 (modest_account_settings_dialog_set_account_name),
3949 (save_configuration): Load/Save the port number, and change it when the
3950 security combo changes, to suitable defaults.
3952 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3954 * src/modest-account-mgr.c:
3955 (modest_account_mgr_add_server_account): Set the security and secure-auth
3956 options, and add a comment saying that the other camel-specific options should be
3959 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3961 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3963 * src/modest-tny-account-store.c: (account_list_free),
3964 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3965 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3968 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3970 * src/modest-protocol-info.c:
3971 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3972 is required by our UI spec. Maybe something in our implementation will use this eventually.
3973 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3974 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3975 instead of the previous 0 placeholder.
3977 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3978 secure-auth settings.
3979 * src/modest-account-mgr-helpers.h:
3980 * src/modest-account-mgr-helpers.c:
3981 (modest_server_account_data_get_option_secure_auth),
3982 (modest_server_account_set_option_secure_auth),
3983 (modest_server_account_data_get_option_security),
3984 (modest_server_account_set_option_security): Added this API for getting and setting the security
3985 and secure-auth settings.
3987 * src/maemo/modest-account-settings-dialog.h:
3988 * src/maemo/modest-account-settings-dialog.c:
3989 (modest_account_settings_dialog_finalize), (check_data),
3990 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3991 about changing titles.
3992 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3993 (save_configuration): Save the security and secure-auth settings.
3995 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3996 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3998 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4000 * src/modest-defs.h:
4001 * src/modest-account-mgr.c:
4002 (modest_account_mgr_add_server_account):
4003 Added and used defines for the options key and value pair strings,
4004 that are used so far, though they do not seem to correspond to anything in our
4005 UI specs or ModestProtocol enum.
4007 * src/modest-account-mgr-helpers.h:
4008 * src/modest-account-mgr-helpers.c:
4009 (compare_option_strings_for_name),
4010 (modest_server_account_data_get_option_value),
4011 (modest_server_account_data_get_option_bool),
4012 (modest_account_mgr_get_server_account_option):
4013 Added helper functions for parsing the options GSList.
4015 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4017 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4018 display name is based on the supplied account name.
4019 * src/modest-account-mgr.c:
4020 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4021 with an inefficient, but good-enough, implementation.
4023 * src/maemo/easysetup/modest-easysetup-wizard.c:
4024 (create_page_account_details), (on_before_next), (create_account):
4025 Check for existing display names rather than (non-user-visible) account names, and just
4026 create and set a unique account name at the end.
4028 * src/maemo/modest-account-settings-dialog.c:
4029 (modest_account_settings_dialog_init),
4030 (modest_account_settings_dialog_set_account_name),
4031 (create_page_incoming): Show the display name, instead of the account name.
4032 (on_response): Do some (not all) extra checks, as in the UI spec.
4033 (save_configuration): Save the display name if it was changed.
4035 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4037 * po/en_GB.po: Added needed logical ID and translation.
4038 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4039 (init_view): Made the is-default column clicking work.
4041 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4044 * src/maemo/easysetup/Makefile.am:
4045 * src/maemo/easysetup/modest-easysetup-wizard.c:
4046 (modest_easysetup_wizard_dialog_init):
4047 * src/maemo/easysetup/provider-data-test.keyfile:
4048 * src/maemo/easysetup/provider-data.keyfile:
4049 Moved the provider data file to the new modest-providers-data package and used it from there.
4051 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4053 * src/modest-local-folder-info.c:
4054 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4055 N_() was already used on the static strings, but this just marks it for translation without
4056 using the translation.
4058 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4060 * src/maemo/modest-account-settings-dialog.c:
4061 (create_page_incoming),
4062 (modest_account_settings_dialog_set_account_name):
4063 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4064 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4065 I will do this if nobody else gets there first.
4067 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4069 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4070 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4071 save the security stuff.
4073 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4075 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4076 Set the email address and user fullname, which I now see must be
4079 * src/maemo/modest-account-settings-dialog.h:
4080 * src/maemo/modest-account-settings-dialog.c:
4082 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4083 leave-on-server and authentication.
4084 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4087 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4090 * src/maemo/modest-account-settings-dialog.c:
4091 * src/maemo/modest-account-settings-dialog.h:
4092 Most (but not all) of the widgets are now present as specified by the UI spec.
4093 No changes are yet saved, and some details are not properly shown yet.
4095 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4097 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4099 * src/maemo/Makefile.am:
4100 * src/maemo/modest-account-settings-dialog.c:
4101 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4102 an existing account. Doesn't do much yet.
4104 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4105 Open the accounts settings dialog when Edit is clicked.
4107 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4109 * src/maemo/easysetup/Makefile.am:
4110 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4112 * src/maemo/easysetup/modest-easysetup-wizard.c:
4113 (modest_easysetup_wizard_dialog_init):
4114 Try to get the source directory from the build system,
4115 instead of hard-coding "./" into the source code, when opening our local
4116 copies of the configuration files.
4117 But this still fails when opening the wizard from the Accounts window,
4118 maybe because the working directory seems to change at runtime.
4119 So the wizard will fail the second time unless you copy the files into their
4120 proper locations - see the stdout warnings for the paths.
4122 (create_page_account_details),(on_before_next):
4123 Check for existing non-server accounts instead of server accounts,
4124 so the default account name is useful again, and to prevent trying to
4127 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4128 Show the wizard when New is clicked.
4130 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4131 (init_view): Show the column headers, and show the columns that are
4132 specified in the UI specs. However, something in Maemo's GTK+ prevents
4133 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4134 change the default account. This is despite unsetting the special properties.
4136 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4138 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4139 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4140 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4141 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4142 to make that clearer.
4143 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4145 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4147 * src/maemo/modest-account-view-window.c:
4148 (modest_account_view_window_init),
4149 (modest_account_view_window_new):
4150 Use the same buttons as specified in the
4151 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4152 the existing widgets, which never had a chance of working.
4153 Put the ModestAccountView treeview in a scrolled window.
4154 Do not repeat the initialization in both _init() and _new().
4156 * src/widgets/modest-account-view.c: (update_account_view):
4157 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4158 this widget and window shows no accounts.
4160 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4162 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4164 * src/maemo/easysetup/modest-easysetup-wizard.c:
4165 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4166 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4167 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4170 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4171 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4172 accounts exist yet, as in the UI spec.
4174 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4176 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4178 * src/maemo/Makefile.am:
4179 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4180 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4181 New window for editing connection-specific smtp details.
4182 Not fully implemented.
4184 * src/maemo/modest-connection-specific-smtp-window.c:
4185 (modest_connection_specific_smtp_window_finalize) :
4186 unref the tree model.
4187 (on_button_edit): Show the edit window.
4189 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4191 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4194 * src/maemo/Makefile.am:
4195 * src/maemo/modest-connection-specific-smtp-window.c:
4196 * src/maemo/modest-connection-specific-smtp-window.h:
4197 New window for showing the list of connections, for connection-specific
4198 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4199 * src/maemo/easysetup/modest-easysetup-wizard.c:
4200 (create_page_custom_outgoing): Show the new window when the button is clicked.
4202 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4204 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4205 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4206 * src/maemo/modest-msg-edit-window.c:
4207 (modest_msg_edit_window_insert_image):
4208 * src/modest-conf.c: (modest_conf_key_escape):
4209 * src/modest-mail-operation.c:
4210 (modest_mail_operation_send_new_mail):
4211 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4212 (modest_ui_actions_on_new_account):
4213 * src/widgets/modest-attachment-view.c: (update_filename_request):
4214 * src/widgets/modest-mail-header-view.c:
4215 Corrected warnings that were breaking the build, by commenting out unused variables,
4216 and a function, and by including a header.
4218 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4220 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4221 so we can #ifdef around platform-specific code when necessary.
4222 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4223 to allow this to build for the GNOME platform too.
4225 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4227 * src/maemo/easysetup/modest-easysetup-wizard.c:
4228 Added util_increment_name() and used it in create_page_account_details()
4229 to make sure that the default account name is always a new name.
4231 (modest_easysetup_wizard_dialog_init),
4232 (set_default_custom_servernames): Some minor memory management fixes.
4234 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4238 * src/modest-runtime.c: (init_i18n): Restored the translation
4239 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4240 are defined in config.h, and the translations are installed.
4242 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4243 is defined for translation.
4245 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4247 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4249 * src/maemo/easysetup/modest-easysetup-wizard.c:
4250 (modest_easysetup_wizard_dialog_init):
4251 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4252 Use realistic paths (though they should use $prefix generically) to the
4253 mcc_mapping and provider-data.keyfile files which might work when they
4254 are installed by the future version of the operator-wizard package,
4255 and then fallback to paths in our source code, with an explanatory
4258 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4262 * src/maemo/Makefile.am:
4263 * src/maemo/easysetup/: Added files from the previously-exernal
4264 osso-modest-easysetup.
4265 * src/maemo/modest-main-window-ui.h:
4266 * src/modest-ui-actions.c:
4267 * src/modest-ui-actions.h:
4268 Added modest_ui_actions_on_new_account() as a signal handler for the
4269 New Account menu item. It shows the easysetup wizard.
4270 * po/en_GB.po: Added additional needed logical IDs and translations.