1 2007-08-13 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-account-view.c: (on_account_changed):
4 Do not try to use the human-readable TnyAccount name instead of the
5 ID of the modest account to get the transport account. And unref
6 the transport account. This prevents a g_warning(), and a possible
9 2007-08-13 Murray Cumming <murrayc@murrayc.com>
11 * src/maemo/modest-platform.c:
12 (modest_platform_set_update_interval): Handle the new
13 alarmd error to warn when alarmd is not running, as is the case in
14 scratchbox for me now because
15 "Module /usr/lib/alarmd/libretu.so initialization failed"
17 2007-08-13 Murray Cumming <murrayc@murrayc.com>
19 * src/widgets/modest-header-view-render.c:
20 (_modest_header_view_compact_header_cell_data):
21 NULL some strings after freeing them, trying to deal with
22 the double deletion found in projects.maemo.org bug 64183,
23 probably having no effect.
25 2007-08-13 Murray Cumming <murrayc@murrayc.com>
27 * src/maemo/modest-account-settings-dialog.c:
28 (create_page_incoming), (create_page_outgoing): Use a define
29 for the min and max port numbers.
31 (check_hildon_number_editor_and_warn_value_not_in_range),
32 (check_data): Do an extra check for an invalid port number, as needed
33 in projects.maemo.org bug #64275, when the number is cleared, but this
34 does not work due to bugs.maemo.org bug #1806.
36 2007-08-13 Murray Cumming <murrayc@murrayc.com>
38 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
39 Comment out the debug warning about the unexpected D-Bus methods.
40 They are just annoying now.
41 * src/maemo/modest-platform.c:
42 (modest_platform_set_update_interval): Correct the D-Bus path, instead
43 of using a file path, though it did not seem to break things before.
44 It might be needed now:
45 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
46 modest is not already running. This is the behaviour of the old client, and
47 Mox says it is what we should do for modest.
48 This closes projects.maemo.org bug NB#64327.
50 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
52 * src/modest-text-utils.c:
53 Fixed invalid jump due to incorrect string/pointer
55 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
58 2007-08-01 Murray Cumming <murrayc@murrayc.com>
60 * src/modest-account-mgr-helpers.h:
61 * src/modest-account-mgr-helpers.c:
62 Added modest_account_mgr_get_first_account_name(),
63 using code from modest_account_mgr_set_first_account_as_default().
65 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
66 (account_number_changed): Call set_at_least_one_account_visible() so that
67 the first account is visible when first added, without the user having to
69 I do wonder how this worked before.
71 2007-08-01 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-tny-account-store.c: (show_password_warning_only),
74 (show_wrong_password), (request_password_and_wait), (get_password),
75 (modest_tny_account_store_alert): Remove the (incomplete anyway)
76 attempts to show UI only in the main context, which used g_idle_add()
77 and mainloops, because tinymail now guarantees that it only calls these
78 callbacks in the mainloop with the gdk lock. This makes everything much
81 2007-08-01 Murray Cumming <murrayc@murrayc.com>
83 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
84 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
85 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
86 error dialog, instead of ignoring it.
88 2007-08-01 Murray Cumming <murrayc@murrayc.com>
90 * src/maemo/modest-msg-view-window.c:
91 (modest_msg_view_window_get_header),
92 (modest_msg_view_window_last_message_selected):
93 Added comments to explain the use of priv->header_model.
94 * src/modest-ui-dimming-rules.c:
95 (modest_ui_dimming_rules_on_open_msg),
96 (modest_ui_dimming_rules_on_mark_as_read_msg),
97 (modest_ui_dimming_rules_on_mark_as_unread_msg),
98 (modest_ui_dimming_rules_on_remove_attachments),
99 (_invalid_attach_selected), (_selected_msg_marked_as):
100 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
101 and changed the parameter to a ModestMainWindow to make it clearer that
102 it never uses any other kind of window.
103 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
104 instead of the selected message.
105 I notice that much of the dimming code and the ModestMsgViewWindow code
106 hard-codes the assumption that the viewed message is always selected in
107 the header view. This does not seem wise or simple.
109 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
110 examine the actual message instead of whatever might be selected
111 in the header view. This stops the delete toolbar button and menu item
112 from being dimmed when opening a message view the search UI,
113 partially fixing projects.maemo.org bug NB#63811.
115 However, when actually deleting, I now get this warning:
116 "tny_header_set_flags: This is a header instance for a new message.
117 Only priority and attachment flags are supported"
119 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
121 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
123 Show account wizard if no accounts are defined while sending
124 (automatic sending after the account wizard finished does not
125 work because it takes some time until the account manager
126 synchronizes everything. (projects.maemo.org NB#62792)
128 2007-07-30 Murray Cumming <murrayc@murrayc.com>
130 * src/modest-tny-account-store.c: (on_account_removed),
131 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
132 account is removed from the View menu. We have TnyAccountStore
133 and ModestTnyAccountStore signals that seem very similar, but this
134 seems to work for now.
136 * src/maemo/modest-main-window.c:
137 (on_show_account_action_activated): Prevent dereference
138 of a NULL if the accoutn does not really exist, though that
139 should not happen anymore.
141 This fixes projects.maemo.org bug NB#64606.
143 2007-07-30 Murray Cumming <murrayc@murrayc.com>
145 * src/modest-ui-actions.c: (run_account_setup_wizard),
146 (modest_ui_actions_on_accounts): Revert a change that set these
147 to modal dialogs, freezing the UI when they show secondary dialogs.
148 This fixed projects.maemo.org bug NB#64519.
150 2007-07-27 Murray Cumming <murrayc@murrayc.com>
152 * src/widgets/modest-header-view-render.c:
153 (_modest_header_view_compact_header_cell_data):
154 Some checks and initialization to try to deal with a crash,
155 probably ineffective.
157 2007-07-27 Murray Cumming <murrayc@murrayc.com>
159 * src/maemo/modest-maemo-utils.c:
160 (modest_maemo_utils_get_supported_secure_authentication_methods):
161 Make sure that we have a connection, asking the user for one
163 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
164 Check for a connection before showing the wizard, because
165 the wizard needs a connection to check for server capabilities.
167 2007-07-27 Murray Cumming <murrayc@murrayc.com>
169 * src/maemo/modest-account-view-window.c:
170 (on_new_button_clicked): Remember the wizard dialog instance,
171 so we can just present it again if necessary. This prevents
172 multiple windows from appearing if you click again quickly on the
173 New button before the dialog appears, fixing projects.maemo.org
176 2007-07-27 Murray Cumming <murrayc@murrayc.com>
178 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
179 Offer a connection dialog if there is no connection when
180 starting modest. This should fix projects.maemo.org bug NB#61134.
182 2007-07-27 Murray Cumming <murrayc@murrayc.com>
184 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
185 Reverted my last commit. I was able to fix the build by doing
186 apt-get install wpeditor0 (replacing other wpeditor packages) and
187 an explicit apt-get install wpeditor-dev to upgrade the -dev
190 2007-07-27 Murray Cumming <murrayc@murrayc.com>
192 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
193 Commented out the use of wp_text_buffer_replace_image()
194 because it does not exist, to break the build. Added a TODO for it.
196 2007-07-26 Murray Cumming <murrayc@murrayc.com>
198 * src/modest-tny-account-store.c: (recreate_all_accounts):
199 Recreate them even if they were NULL before. I guess something
200 else was already creating them before, or this would never
202 (modest_tny_account_store_get_server_account): Make sure that
203 the tny accounts have been created before trying to find one.
204 This allows libmodest_dbus_client_compose_mail() to work
205 when the UI is not yet visible.
206 This is probably useful in other cases too.
208 (get_password): When the password is wrong after it is entered
209 in the protected password dialog, show an info banner (in an
210 idle handler) before showing the protected password dialog
213 2007-07-26 Murray Cumming <murrayc@murrayc.com>
215 * src/modest-ui-actions.h:
216 * src/modest-ui-actions.c: Added
217 modest_do_refresh_current_folder() containing some code from
218 modest_ui_actions_on_send_receive().
219 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
220 Call modest_do_refresh_current_folder() before refreshing the
221 requested account, as in modest_ui_actions_on_send_receive().
222 This is strange, but seems to be necessary to show new mails.
223 Now new emails are finally visible in the UI when downloaded
224 via the automatic update interval, fixing bug NB#57458.
225 This also works because bug NB#57458 has been fixed somehow.
227 2007-07-26 Murray Cumming <murrayc@murrayc.com>
229 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
230 printf more details when we get unhandled D-Bus methods, because
233 * src/modest-mail-operation.c: (update_account_thread):
234 Comment out the tny_camel_pop_store_account_reconnect(), because this
235 is apparently no longer needed, and it did not work before anyway.
236 See the comment in the code.
238 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
239 by checking the header flags. This fixes projects.maemo.org bug
242 2007-07-25 Murray Cumming <murrayc@murrayc.com>
244 * src/maemo/modest-maemo-utils.h:
245 * src/maemo/modest-maemo-utils.c: Added
246 modest_maemo_show_information_note_in_main_context_and_forget().
247 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
248 Use the new function to show simple error dialogs in the main
249 context, though question dialogs are still in the current context,
250 which is unfortunately usually not the main context. This should
253 2007-07-25 Murray Cumming <murrayc@murrayc.com>
255 * src/modest-tny-account-store.c: (get_password):
256 Never save the entered username and password in gconf,
257 because the UI spec says we should not. This helps
258 slightly with projects.maemo.org bug NB#63671.
260 2007-07-25 Murray Cumming <murrayc@murrayc.com>
262 * src/widgets/modest-msg-edit-window.h:
263 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
264 Moved some code here to make it simpler.
265 (modest_msg_edit_window_attach_file_one): Renamed from
266 modest_msg_edit_window_attach_file_interactive().
267 (modest_msg_edit_window_offer_attach_file): Renamed from
268 modest_msg_edit_window_attach_file() and used
269 modest_msg_edit_window_attach_file_one() instead of
270 copy/pasting the code. The old code for one was not using
271 GnomeVFS. This allows use of smb:// URLs when using send-as
272 from external applications, fixing bug NB#63741.
274 (modest_msg_edit_window_insert_image),
275 (modest_msg_edit_window_add_attachment_clicked):
276 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
277 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
278 Adapted to the new function names.
280 2007-07-25 Murray Cumming <murrayc@murrayc.com>
282 (modest_platform_set_update_interval): Set the alarm recurrence
283 fields so that auto-update does not just happen the first time.
284 This should have fixed projects.maemo.org bug NB#63938.
286 When this happens you can see a printf when the D-Bus method is
288 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
290 However, I do not actually seem to get new POP messages even when
291 clicking the refresh button manually. A restart gets them.
292 This might be a problem in today's tinymail only.
294 2007-07-24 Murray Cumming <murrayc@murrayc.com>
296 * src/maemo/modest-maemo-global-settings-dialog.c:
297 (current_connection):
298 Avoid a crash (probably only in scratchbox) when strcmp()ing a
299 NULL when closing the dialog.
301 2007-07-24 Murray Cumming <murrayc@murrayc.com>
303 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
304 Remove the hacky send/receive that didn't work, and instead
305 refilter the treemodel to make the deleted email really vanish from
306 the UI (though the delete-from-menu code does has commented out
307 the code that does that). This fixes projects.maemo.org bug
310 2007-07-24 Murray Cumming <murrayc@murrayc.com>
312 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
313 Try a couple of tricks to force the treeview to update (
314 poke the folder, and do a send/receive refresh), but the deleted
315 email still appears with a strike-through instead of really being
318 2007-07-23 Murray Cumming <murrayc@murrayc.com>
320 * src/dbus_api/modest-dbus-callbacks.c:
321 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
322 because their ID is not human-readable (see the comment about
323 improvements needed to the osso-email-interface API) and
324 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
326 2007-07-23 Murray Cumming <murrayc@murrayc.com>
328 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
329 (add_folders_to_list), (on_dbus_method_get_folders),
330 (modest_dbus_req_filter):
331 * src/maemo/modest-maemo-utils.c:
332 (on_camel_account_get_supported_secure_authentication):
333 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
334 (on_header_view_focus_in):
335 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
336 * src/modest-formatter.c: (modest_formatter_create_body_part):
337 * src/modest-mail-operation.c: (recurse_folders),
338 (update_account_thread), (get_msgs_full_thread),
339 (modest_mail_operation_get_msgs_full),
340 (modest_mail_operation_xfer_msgs):
341 * src/modest-search.c: (search_mime_part_and_child_parts),
342 (modest_search_account), (modest_search_all_accounts):
343 * src/modest-tny-account.c:
344 (modest_tny_account_get_special_folder), (recurse_folders):
345 * src/modest-tny-local-folders-account.c:
346 (modest_tny_local_folders_account_query_passes):
347 * src/modest-tny-msg.c: (copy_mime_part),
348 (modest_tny_msg_find_body_part_from_mime_part):
349 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
350 (modest_tny_send_queue_try_to_send):
351 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
352 (_modest_ui_actions_open), (download_uncached_messages),
353 (reply_forward), (modest_ui_actions_on_copy),
354 (modest_ui_actions_on_details), (has_retrieved_msgs),
355 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
357 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
358 (_selected_msg_marked_as), (_msg_download_completed),
359 (_selected_msg_sent_in_progress):
360 * src/widgets/modest-attachments-view.c:
361 (modest_attachments_view_set_message):
362 * src/widgets/modest-msg-view.c: (find_cid_image):
363 * tests/check_folder-transfer.c: (find_folders):
364 * tests/check_update-account.c: (func):
365 * tests/dbus_api/test_get_folders.c: (main):
366 Checked all uses of tny_iterator_get_current(), making sure
367 that the object is unreferenced (3 or 4 places did not),
368 and adding checks for NULL.
370 2007-07-23 Murray Cumming <murrayc@murrayc.com>
372 * src/dbus_api/modest-dbus-callbacks.c:
373 (on_idle_open_default_inbox): Make sure that the application UI is
375 * src/maemo/easysetup/modest-easysetup-wizard.c:
376 (on_entry_invalid_character): Show the word whitespace instead
377 of (null) in the banner when whitespace was entered.
378 (show_error): Add a comment that this does not work in
379 Maemo Bora, though we do not know why.
381 2007-07-23 Murray Cumming <murrayc@murrayc.com>
383 * src/modest-tny-account.c:
384 (modest_tny_account_get_special_folder): Use an if instead of
385 an assert for when the parent account name is NULL, because this
386 might be causing a crash in projects.maemo.org bug 63192.
387 * src/modest-mail-operation.c:
388 (modest_mail_operation_send_new_mail_cb),
389 (modest_mail_operation_remove_folder): unref the folder that is
390 returned from modest_tny_account_get_special_folder().
392 2007-07-23 Murray Cumming <murrayc@murrayc.com>
394 * src/modest-ui-actions.c:
395 (modest_ui_actions_on_password_requested):
396 Show mail_ib_login_cancelled info banner when the user cancels
397 the protected password dialog, to fix projects.maemo.org
400 2007-07-23 Murray Cumming <murrayc@murrayc.com>
402 * src/maemo/modest-account-settings-dialog.c:
403 (create_page_outgoing): Put this page in a GtkScrolledWindow,
404 matching the UI mock-up in the UI spec, and allowing access
405 to all widgets even when the on-screen keyboard is active.
407 2007-07-23 Murray Cumming <murrayc@murrayc.com>
409 Reverted this previous commit from Johannes,
410 because the scrollbars are always visible and because
411 I think we only need it on onepage of the account
412 settings, not the account wizard.
413 (I wrote the wrong instructions in the bug.)
415 * src/maemo/easysetup/modest-easysetup-wizard.c:
416 Added scrollbars to account wizard dialog.
417 Fixed projects.maemo.org NB #62744
419 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
421 * src/maemo/easysetup/modest-easysetup-wizard.c:
422 (create_page_user_details):
423 Use auto-cap for name (projects.maemo.org NB#63716)
424 * src/widgets/modest-account-view.c: (on_account_busy_changed):
426 2007-07-22 Armin Burgmeier <armin@openismus.com>
428 * src/maemo/modest-ui-actions.c: Use current account instead of
429 default account for creating viewer windows, so that the viewer
430 window knows to which account the viewed message belongs.
432 * src/maemo/modest-msg-view-window.c: Destroy the window when the
433 corresponding account is deleted. This fixes projects.maemo.org bug
436 2007-07-18 Armin Burgmeier <armin@openismus.com>
438 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
439 the dialog close after entering an invalid port number and clicking
440 OK. This fixes projects.maemo.org bug NB#63602.
442 2007-07-18 Armin Burgmeier <armin@openismus.com>
444 * src/modest-tny-account-store.c:
445 (get_server_accounts): Set parent modest account name for each
446 connection-specific transport account so that special folders of such
447 an account can be looked up. This fixes a crash when changing account
448 settings. This might also be related to projects.maemo.org bug
451 2007-07-16 Armin Burgmeier <armin@openismus.com>
453 * src/modest-ui-actions.c: Added a button to create a folder to the
454 move-to dialog. This fixes projects.maemo.org bug NB#.
456 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
458 * src/maemo/easysetup/modest-easysetup-wizard.c:
459 Added scrollbars to account wizard dialog.
460 Fixed projects.maemo.org NB #62744
462 2007-07-16 Murray Cumming <murrayc@murrayc.com>
464 * src/widgets/modest-msg-view.h:
465 * src/widgets/modest-msg-view.c:
466 Added modest_msg_view_get_message_is_empty() but this needs
468 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
469 Check if there is any text in the message yet.
470 But this needs to be implemented properly.
471 (modest_msg_edit_window_toggle_find_toolbar):
472 * src/maemo/modest-msg-view-window.c:
473 (modest_msg_view_window_toggle_find_toolbar):
474 Show a banner warning if there is no text to search, when
475 trying to start a search. This partially fixes
476 projects.maemo.org bug NB#62350.
478 2007-07-13 Murray Cumming <murrayc@murrayc.com>
480 * src/modest-mail-operation.c: (update_account_thread):
481 Initialized num_new_headers to fix the build.
483 2007-07-13 Murray Cumming <murrayc@murrayc.com>
485 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
486 Ignore modest accounts whose server accounts don't exist in gconf.
487 This prevents us trying to create TnyAccount instances for those
488 server accounts when the server account has been removed from gconf,
489 but the parent modest account has not yet been removed from modest.
490 I don't know why this is only noticeable now. It was probably just
491 a harmeless g_warning() anyway.
493 2007-07-13 Murray Cumming <murrayc@murrayc.com>
495 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
496 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
498 2007-07-12 Armin Burgmeier <armin@openismus.com>
500 * src/maemo/modest-main-window.c: Make default account appear bold
501 in view, tools/send & receive and toolbar/send & receive SCM menus.
502 This fixes projects.maemo.org bug NB#59010.
504 2007-07-12 Murray Cumming <murrayc@murrayc.com>
506 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
507 Add a short-cut, by checking if the folder store is an account.
508 This ensures that the Sort menu item and toolbar is dimmed for
509 the local-folders account root item, fixing
510 projects.maemo.org bug NB#62545.
512 2007-07-12 Murray Cumming <murrayc@murrayc.com>
514 * src/modest-tny-account-store.c: (get_password):
515 Show the password dialog (via the signal) only in the mainloop, via
516 an idle handler that we wait for. This could theoretically prevent
517 hangs, though I worry that it could introduce some too.
519 2007-07-12 Murray Cumming <murrayc@murrayc.com>
521 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
522 * src/maemo/modest-platform.c:
523 (modest_platform_connect_and_wait):
524 Take a TnyAccount* parameter and try to set it to online
525 (a TnyCamel-only API), because tinymail sets accounts to offline
526 when the user cancels a password dialog, and doesn't ask again until
527 it has been set to online.
528 However, this is commented out because it causes a hang now.
530 (modest_platform_connect_and_wait_if_network_account):
531 * src/modest-mail-operation.c:
532 (modest_mail_operation_update_account):
533 * src/modest-platform.h:
534 * src/modest-ui-actions.c: (_modest_ui_actions_open),
535 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
537 2007-07-12 Armin Burgmeier <armin@openismus.com>
539 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
541 * src/modest-mail-operation.c:
542 * src/modest-ui-actions.c: Check for already existing folder before
543 querying the server, show error message from camel if the request
544 still fails. This fixes projects.maemo.org bug NB#58701.
546 2007-07-12 Murray Cumming <murrayc@murrayc.com>
548 * src/modest-tny-account-store.h:
549 * src/modest-tny-account-store.c:
550 Added modest_tny_account_store_forget_password_in_memory(),
551 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
552 when creating a new account, so that new passwords will be used, instead of
553 us thinking that it's a second request as a result of a failed password again.
555 2007-07-12 Murray Cumming <murrayc@murrayc.com>
557 * src/dbus_api/modest-dbus-callbacks.c:
558 (on_idle_open_message): If the message is in drafts then open it
559 in an edit window instead of a view window. This fixes
560 projects.maemo.org bug NB#63005.
562 2007-07-12 Murray Cumming <murrayc@murrayc.com>
564 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
565 Avoided a harmless g_warning().
567 2007-07-12 Murray Cumming <murrayc@murrayc.com>
569 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
570 Pass the modest account name, not the TnyAccount display name to
571 modest_msg_view_window_new() so that the reply feature works,
572 fixing projects.maemo.org bug NB#62892.
574 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
575 (modest_msg_view_window_new_with_header_model):
576 * src/maemo/modest-msg-view-window.c:
577 (modest_msg_view_window_new_with_header_model),
578 (modest_msg_view_window_new):
579 * src/modest-ui-actions.c: (reply_forward):
580 * src/widgets/modest-msg-view-window.h:
581 * src/widgets/modest-window.c: (modest_window_set_active_account):
582 Rename an account parameter to modest_account_name to make this clearer.
584 2007-07-11 Murray Cumming <murrayc@murrayc.com>
586 * src/modest-ui-actions.h:
587 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
588 modest_do_message_delete().
589 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
590 Call modest_do_message_delete(), hoping that this would cause messages
591 to be really deleted from search instead of just marked with strike through.
592 Does not seem to help.
594 2007-07-11 Armin Burgmeier <armin@openismus.com>
596 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
597 priv->reselect to FALSE prior to calling
598 modest_folder_view_select_first_inbox_or_local() to prevent endless
599 recursion and thus a crash on startup.
601 2007-07-11 Armin Burgmeier <armin@openismus.com>
603 * src/maemo/modest-account-settings-dialog.h: Include
604 <gtk/gtknotebook.h> to fix the build (at least for me).
606 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
607 Use "New FolderN" as default suggested name if "New folder" already
608 exists, with N being the first free number, though never exceed "New
609 folder99" in which case we just fall back to "New Folder" even though
610 it already exists. This fixes projects.maemo.org bug NB#58663.
612 2007-07-11 Murray Cumming <murrayc@murrayc.com>
614 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
615 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
616 projects.maemo.org bug NB#62778.
618 2007-07-11 Murray Cumming <murrayc@murrayc.com>
620 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
621 Ignore the wrong (for now) secure-smtp setting in the presets -
622 just default to requiring secure authentication for SMTP, because
625 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
627 * src/widgets/modest-folder-view.c: (filter_row)
628 Do not show drafts folder (see UI specs)
630 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
632 * src/modest-ui-actions.c:
633 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
634 place and also not necessary.
636 * src/widgets/modest-folder-view.c: (filter_row)
637 Guess folder type and hide Sent & Outbox if necessary.
638 Fixed project.maemo.org NB#57328
640 2007-07-11 Murray Cumming <murrayc@murrayc.com>
642 * src/modest-ui-actions.h:
643 * src/modest-ui-actions.c:
644 (modest_ui_actions_on_delete_message):
645 Move some code into a new
646 modest_ui_actions_refresh_message_window_after_delete()
647 function so we can use it from elsewhere.
649 * src/dbus_api/modest-dbus-callbacks.c:
650 (on_idle_delete_message), (on_delete_message): Used an idle
651 handler, as we do for the other D-Bus method handlers.
652 Call modest_ui_actions_refresh_message_window_after_delete()
653 if the deleted message was open in a window. This fixed
654 projects.maemo.org bug NB#62862.
656 2007-07-11 Murray Cumming <murrayc@murrayc.com>
658 * src/modest-main.c: (main): Only show the UI at the start if
659 the showui command line option was given. For instance,
660 run-standalone src/modest showui
661 Otherwise, we wait for the top_application D-Bus method to
662 be sent by hildon-desktop when the application is selected
664 This allows us to run without a UI when osso-global-search
665 uses our D-Bus methods.
667 2007-07-11 Murray Cumming <murrayc@murrayc.com>
669 * src/dbus_api/modest-dbus-api.h: Added a define for a
670 top-application D-Bus method.
671 * src/dbus_api/modest-dbus-callbacks.c:
672 (on_top_application),
673 (modest_dbus_req_handler): Handle the top-application D-Bus
674 method, which might be an undocumented D-Bus signal sent by
675 hildon-desktop when it starts the application from the menu.
676 But I am not sure and I need to test it on the device, because
677 my scratchbox does not have the application in the menu now.
678 This method shows the main window, so that it can be invisible
679 when started, for instance, just for email searching from
682 * src/maemo/modest-main-window.c: (restore_settings),
683 (modest_main_window_new): Do not show the window immediately
684 upon creation. We show it later.
685 * src/modest-widget-memory.c: (save_settings_paned):
686 Try (unsuccessfully) to avoid saving the paned position when
687 it is not even visible.
688 (restore_settings_paned): Do not allow a silly paned position.
689 This seems necessary when not showing the window at first.
691 * tests/dbus_api/Makefile.am:
692 * tests/dbus_api/test_top_application.c: (main): Test for the
695 2007-07-10 Murray Cumming <murrayc@murrayc.com>
697 * src/modest-ui-dimming-rules.c:
698 (modest_ui_dimming_rules_on_new_msg),
699 (modest_ui_dimming_rules_on_reply_msg),
700 (modest_ui_dimming_rules_on_delete_msg),
701 (modest_ui_dimming_rules_on_details),
702 (modest_ui_dimming_rules_on_view_window_move_to),
703 (modest_ui_dimming_rules_on_view_previous),
704 (modest_ui_dimming_rules_on_view_next),
705 (_invalid_folder_for_purge): Added checks before
706 casting the window. This looks like an actual
707 logic error in _invalid_folder_for_purge(), because it
708 tries to use a ModestMainWindow as a message window.
710 2007-07-10 Murray Cumming <murrayc@murrayc.com>
712 * src/maemo/modest-account-settings-dialog.c:
713 (show_error): Use the same implementation as in
714 modest-easysetup-wizard.c:
715 (on_entry_invalid_character): The logical ID contains a %s.
716 Guessed what it should be.
717 (on_entry_max), (check_data), (on_response): Adapt to
718 changed show_error().
719 (create_page_account_details): Really call
720 modest_validating_entry_set_func() on the correct widgets.
721 * src/maemo/easysetup/modest-easysetup-wizard.c:
722 (on_entry_invalid_character): Fix the logical ID here too.
723 (create_page_account_details),
724 (create_page_user_details):
726 modest_validating_entry_set_func() on the correct widgets.
728 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
729 Do not try to use the account if it is NULL.
731 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
733 * src/modest-ui-actions.c: (create_move_to_dialog),
734 (modest_ui_actions_on_main_window_move_to),
735 (modest_ui_actions_on_msg_view_window_move_to):
736 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
737 (filter_row), (modest_folder_view_show_non_move_folders):
738 * src/widgets/modest-folder-view.h:
740 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
741 the Sent folder yet as it does not report the correct folder type.
743 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
745 * src/maemo/modest-msg-edit-window.c: (init_window):
748 2007-07-10 Murray Cumming <murrayc@murrayc.com>
750 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
751 Take a parent widget instead of a parent window, and
752 implement this with hildon_banner_show_information() instead.
753 Non-Maemo builds can just ifdef that there.
754 This fixed projects.maemo.org bug NB#62766.
756 (on_entry_invalid_character): Use show_error() again instead
757 of using hildon directly, and use the _CS() macro to use the correct
759 (create_account), (check_for_supported_auth_methods), (on_entry_max):
760 Pass a widget instead od a window to show_error().
762 2007-07-10 Murray Cumming <murrayc@murrayc.com>
764 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
765 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
766 This allows us to show the server name in the error message, fixing
767 projects.maemo.org bug NB#62904.
768 Also, use the appropriate logical ID message for the account protocol.
770 2007-07-10 Murray Cumming <murrayc@murrayc.com>
772 * src/modest-tny-account-store.c: (on_idle_wrong_password):
773 A compilation fix, though the build wasn't broken for me.
775 2007-07-09 Murray Cumming <murrayc@murrayc.com>
777 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
778 Do not try to unref a NULL folder store, to avoid a runtime warning.
779 This seems to happen sometimes when changing accounts settings.
781 2007-07-09 Murray Cumming <murrayc@murrayc.com>
783 * src/modest-tny-account-store.c:
784 (modest_tny_account_store_instance_init),
785 (modest_tny_account_store_finalize),
786 (on_account_settings_hide), (on_idle_wrong_password):
787 Use a GHashTable to ensure that we only show one account settings
788 dialog per modest account. This avoids us having a dialog open for
789 both the store and transport accounts, or due to repeated get_password()
790 calls that shouldn't happen anyway.
792 2007-07-09 Murray Cumming <murrayc@murrayc.com>
794 * src/maemo/modest-maemo-utils.c: (on_hide),
795 (modest_maemo_show_dialog_and_forget): Handle the response, because
796 the window is not even hidden by default.
798 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
799 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
800 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
801 which seems to prevent some modality problems.
803 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
804 Ignore user cancellation errors.
806 * src/modest-account-mgr-helpers.h:
807 * src/modest-account-mgr-helpers.c:
808 Added modest_server_account_get_password() and
809 modest_server_account_get_has_password() to avoid direct use of
812 * src/maemo/modest-account-settings-dialog.h:
813 * src/maemo/modest-account-settings-dialog.c:
814 (modest_account_settings_dialog_init): Store the notebook so we can
816 Added modest_account_settings_dialog_switch_to_user_info().
818 * src/modest-tny-account-store.c:
819 (get_password): When the password in the account settings is wrong (we think),
820 show the relevant page of the account settings dialog, in the mainloop.
821 However, we currently get many of these at once because cancel does not
823 (forget_password): Do not forget the password
824 from the account settings, because this causes side-effects when
825 tinymail seems to call it at strange time, maybe because of how we
826 are cancelling get_password().
827 (modest_tny_account_store_alert): Ignore user cancellations.
829 2007-07-09 Murray Cumming <murrayc@murrayc.com>
831 * src/maemo/modest-maemo-utils.h:
832 * src/maemo/modest-maemo-utils.c:
833 Added modest_maemo_show_information_note_and_forget() for use instead of
834 gtk_dialog_run() when the response is not needed, to avoid an extra
835 mainloop which could cause a hang.
837 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
838 Use the logical IDs for the error message, though they are not
839 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
840 because gtk_dialog_run() caused a hang here (the window did not close).
841 This fixes projects.maemo.org bug NB#62646.
843 2007-07-09 Murray Cumming <murrayc@murrayc.com>
845 * src/modest-account-mgr-helpers.h:
846 * src/modest-account-mgr-helpers.c:
847 Added modest_account_mgr_get_store_protocol().
849 * src/maemo/modest-account-view-window.c:
850 (on_delete_button_clicked): Show different warning text depending on
851 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
852 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
855 2007-07-09 Murray Cumming <murrayc@murrayc.com>
857 * src/maemo/modest-msg-edit-window.c:
858 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
859 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
861 2007-07-07 Armin Burgmeier <armin@openismus.com>
863 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
864 ckdg_ib_maximum_characters_reached from correct package.
866 * src/modest-ui-actions.c: Show an error message when a folder could
867 not be created. Tinymail does not give us specific error codes about
868 what has gone wrong, so we assume that a folder with that name
869 already exists, though there might be other reasons.
871 2007-07-06 Murray Cumming <murrayc@murrayc.com>
873 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
874 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
875 give a more exact error message that can be partly translated.
877 2007-07-05 Murray Cumming <murrayc@murrayc.com>
879 * src/maemo/modest-address-book.c:
880 (select_email_addrs_for_contact): Specify a default window size for the
881 select-email-address dialog, so that it is probably big enough for the
882 title. This should fix projects.maemo.org bug NB#62277.
884 2007-07-05 Murray Cumming <murrayc@murrayc.com>
886 * src/maemo/easysetup/modest-easysetup-wizard.c:
887 (create_page_complete_easysetup): Use
888 gtk_widget_set_size() request to ensure that the text wraps
891 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
893 * src/maemo/easysetup/modest-easysetup-wizard.c:
894 (on_entry_invalid_character), (create_page_account_details),
895 (create_page_user_details):
896 Use new API of ModestValidatingEntry. But for some reason the banner is
897 not shown. I will have to investigate that further.
899 * src/widgets/modest-validating-entry.c: (on_insert_text),
900 (modest_validating_entry_set_func):
901 * src/widgets/modest-validating-entry.h:
902 Added a new callback function to be able to react to prevented
903 characters whitespaces to e.g show a banner.
905 2007-07-05 Armin Burgmeier <armin@openismus.com>
907 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
908 notification of HildonNumberEditor instead of remembering the port
909 number. Thanks to Johannes for pointing this out.
911 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
913 * src/maemo/easysetup/modest-easysetup-wizard.c:
914 Check if there are any user changes before showing a confirmation
915 dialog (projects.maemo.org NB#60946)
917 2007-07-05 Armin Burgmeier <armin@openismus.com>
919 * src/maemo/modest-account-settings-dialog.c: Remember custom port
920 number at the beginning of the dialog and set the modified flag at the
921 end if the port number has changed. This is necessary because
922 HildonNumberEditor does not support notification when the value has
925 2007-07-05 Murray Cumming <murrayc@murrayc.com>
927 * src/modest-ui-actions.c:
928 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
929 a connection before asking anything else. Correct the check for the destination
930 folder so that it succeeds when online.
931 This fixed projects.maemo.org bug NB#61645.
933 2007-07-05 Murray Cumming <murrayc@murrayc.com>
935 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
936 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
937 to fix projects.maemo.org bug NB#62439.
939 2007-07-05 Murray Cumming <murrayc@murrayc.com>
941 * src/modest-tny-account.c: (on_connection_status_changed):
942 Really do not use tny_device_force_offline() here. See the previous comment.
944 2007-07-04 Murray Cumming <murrayc@murrayc.com>
946 * src/modest-tny-account.c: (on_connection_status_changed):
947 Do not use tny_device_force_offline() when tinymail says that something
948 went wrong with the connection. It seems to report this unnecessarily.
950 2007-07-04 Murray Cumming <murrayc@murrayc.com>
952 * src/maemo/modest-connection-specific-smtp-window.c:
953 (modest_connection_specific_smtp_window_init):
954 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
955 does not seem to have any effect in osso 1.1 (though it works in
956 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
958 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
960 * src/maemo/modest-connection-specific-smtp-window.c:
961 Fix UI specification problems with projects.meamo.org NB#60479
963 2007-07-04 Murray Cumming <murrayc@murrayc.com>
965 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
966 clue when this has failed, because the error dialog is not always shown
967 (at least in earlier version).
969 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
970 GError message, because the generic error dialog is not helpful.
972 'This message is not currently available (can't let a new connection go online)'
973 when trying to open an IMAP message.
975 (_modest_ui_actions_open): Offer a connection when some messages would
976 have to be downloaded and we are offline.
978 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
980 * src/widgets/modest-folder-view.c:
981 Don't check for MERGE type anymore as we use the correct type
983 NOTE: For the last two changes you need to update your tinymail copy
984 because of API changes!
986 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
988 * src/modest-tny-local-folders-account.c:
989 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
990 (see projects.maemo.org NB#61580)
992 2007-07-04 Murray Cumming <murrayc@murrayc.com>
994 * src/modest-tny-account.c: (on_connection_status_changed):
995 Commented out the call to modest_platform_connect_and_wait() because this
996 seems to always hang, and I would like to know if this is the only thing
997 that causes a hang when showing the connection dialog.
998 It is not very useful anyway.
1000 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1002 * src/maemo/modest-msg-view-window.c:
1003 (modest_msg_view_window_select_next_message):
1005 * src/modest-platform.h:
1006 * src/maemo/modest-platform.c:
1007 Added modest_platform_connect_and_wait(), which calls
1008 tny_maemo_conic_device_connect() always in the main thread, by calling it
1009 in an idle handler and waiting for the idle handler to run. It should be
1010 in the main thread because it uses GTK+ UI code. It just returns TRUE
1011 if the device is already online.
1013 There is some nasty code to ensure that subsequent calls to
1014 modest_platform_connect_and_wait() just wait for the first one to finish,
1015 by checking repeatedly in another idle handler. This is necessary,
1016 because other threads (or even the main thread, via another idle handler)
1017 can call modest_platform_connect_and_wait() while
1018 modest_platform_connect_and_wait() is running.
1020 (modest_platform_connect_and_wait_if_network_account),
1021 (modest_platform_connect_and_wait_if_network_folderstore):
1022 Convenience functions that calls modest_platform_connect_and_wait() if
1023 the account or folder might want network access.
1025 * src/modest-mail-operation.c:
1026 (modest_mail_operation_update_account):
1027 * src/modest-ui-actions.c: (download_uncached_messages),
1028 (modest_ui_actions_on_rename_folder), (delete_folder),
1029 (modest_ui_actions_on_main_window_move_to),
1030 (modest_ui_actions_on_msg_view_window_move_to):
1031 * src/widgets/modest-folder-view.c:
1032 (drag_and_drop_from_folder_view):
1033 Offer a connection if we are offline.
1035 * src/modest-tny-account.c: (on_connection_status_changed):
1036 Document this as only handling errors during network operations in progress,
1037 and replace the idle code with a simple call to
1038 modest_platform_connect_and_wait(), which does this instead.
1040 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1042 * src/modest-tny-account.c:
1043 (modest_tny_account_get_special_folder): (util_on_idle),
1044 Handle the GError so we can see when tny_folder_store_get_folders()
1045 fails, as it currently does while something else is connecting.
1047 Added util_run_in_main_thread_and_wait()
1048 which uses an idlen handler and mainloop to ensure that the function
1049 is called in the main thread.
1050 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1051 to make sure that we call attempt the connection in the mainloop only,
1052 which might solve some hangs.
1054 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1056 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1057 be found by their display name. This is never useful.
1058 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1059 by its ID, instead of trying to use its ID as its display name.
1061 * src/modest-tny-account-store.h:
1062 * src/modest-tny-account.c:
1063 (modest_tny_account_get_special_folder): Add a g_warning() when
1064 tny_folder_store_get_folders() returns an empty list for the maildir.
1066 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1067 Add a g_warning() when this returns NULL, because that it not allowed
1070 2007-07-02 Armin Burgmeier <armin@openismus.com>
1072 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1073 note when trying to cancel the wizard. This fixes projects.maemo.org
1076 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1078 * src/modest-tny-account.h:
1079 * src/modest-tny-account.c:
1080 (modest_tny_account_new_from_server_account),
1081 (modest_tny_account_new_from_server_account_name),
1082 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1083 because this must now be set before setting the proto. This is usd in
1084 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1085 warning in camel_session_get_service() caused by
1086 tny_camel_transport_account_prepare().
1088 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1091 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1093 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1095 (modest_connection_specific_smtp_edit_window_init):
1097 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1098 of "changed" for now
1100 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1102 * src/modest-tny-account.c:
1103 (modest_tny_account_new_from_server_account):
1104 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1105 now uses to request a connection when it needs one, and which it uses
1106 to tell us that something is wrong with the connection, so we can force
1107 the accounts offline to prevent further problems.
1109 * src/modest-defs.h:
1110 * src/modest-init.c: (init_default_settings):
1111 * src/modest-mail-operation.c:
1112 (modest_mail_operation_update_account):
1113 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1114 This should not be necessary anymore. Do not set the conf key that
1115 determined this (it was always TRUE and not set anywhere else).
1117 * src/modest-ui-actions.h: Remove unused and unimplemented
1118 modest_ui_actions_on_online_toggle_toggled().
1120 2007-06-29 Murray Cumming <murrayc@murrayc.com
1122 * src/maemo/modest-main-window.c: (connect_signals):
1123 Don't connect to delete_event twice. Maybe this was harmless.
1125 2007-06-29 Murray Cumming <murrayc@murrayc.com
1127 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1128 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1129 Debug output to give some more clue when a folder move is not allowed.
1131 2007-06-28 Murray Cumming <murrayc@murrayc.com
1133 * src/modest-tny-account.c: (on_modest_file_system_info),
1134 (modest_tny_account_get_mmc_account_name):
1135 Always call the callback, without checking whether the name has changed.
1136 * src/widgets/modest-folder-view.c: (strings_are_equal),
1137 (on_model_foreach_set_name), (on_get_mmc_account_name),
1138 (text_cell_data): Compare the name here, and use the name from
1139 the account rather than from the
1140 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1141 if the name was changed after the account was added to the model.
1142 That's a tinymail bug but not one that I want to fix now.
1144 This finally fixes projects.maemo.org bug NB#59301.
1146 2007-06-27 Armin Burgmeier <armin@openismus.com>
1148 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1151 2007-06-27 Murray Cumming <murrayc@murrayc.com
1153 * src/modest-tny-account.h:
1154 * src/modest-tny-account.c:
1155 Added modest_tny_account_get_mmc_account_name(), to set the memory
1156 card name asynchronously for the given account and then notify.
1157 (modest_tny_account_new_for_local_folders): Use this new function instead
1158 of using hildon_file_system_info_async_new() directly.
1160 * src/widgets/modest-folder-view.c: (text_cell_data):
1161 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1162 gtk_tree_model_row_changed() when it is available.
1164 This should fix projects.maemo.org bug NB#59301.
1166 2007-06-27 Murray Cumming <murrayc@murrayc.com
1168 * src/modest-mail-operation.c: (update_account_thread),
1169 (get_msgs_full_thread): Fix typo failures in the revert
1172 2007-06-27 Murray Cumming <murrayc@murrayc.com
1174 * src/maemo/modest-maemo-global-settings-dialog.c:
1175 (idle_select_default_focus):
1176 * src/modest-mail-operation.c: (idle_notify_progress),
1177 (idle_notify_progress_once), (set_last_updated_idle),
1178 (update_account_thread), (get_msgs_full_thread):
1179 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1180 * src/widgets/modest-header-view.c:
1181 (idle_notify_headers_count_changed_destroy),
1182 (idle_notify_headers_count_changed):
1183 Reverted the additions of gdk_threads_enter/leave(), in case this
1184 helps with a startup hang on the device.
1186 2007-06-26 Armin Burgmeier <armin@openismus.com>
1188 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1189 for supported secure authentication methods from server by
1190 gtk_dialog_run(), saving CPU time and a potential race condition.
1192 2007-06-26 Armin Burgmeier <armin@openismus.com>
1194 * src/maemo/modest-maemo-utils.h:
1195 * src/maemo/modest-maemo-utils.c: Added a
1196 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1197 only error code to tell the calling code when the user canceled the
1200 * src/maemo/modest-account-settings-dialog.h:
1201 * src/maemo/modest-account-settings-dialog.c:
1202 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1203 message if the retrieval of secure authentication methods was canceled
1204 by the user. Perform the check before saving anything to configuration
1205 to not end up with half-committed configuration changes, do not show
1206 a "Saving to configuration failed" note when authentication methods
1207 could not be retrieved.
1209 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1212 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1214 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1215 Only return the first level of folders under accounts, because the
1216 osso-global-search UI spec doesn't want the rest.
1217 This fixed projects.maemo.org bug NB#61811.
1219 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1221 * src/modest-tny-account-store.c:
1222 * src/modest-tny-account-store.h:
1223 Added modest_tny_account_is_memory_card_account().
1224 * src/maemo/modest-main-window.c: (create_details_widget):
1225 Show the same information items for the memory card as we show for the
1226 local-folders, to fix projects.maemo.org bug NB#59307.
1228 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1230 * src/modest-tny-account-store.c: (get_password):
1231 Added some checks for NULL to maybe prevent crashes, though I think
1232 it was Philip's last commit that actually prevented the crash here
1233 when creating a first new account.
1234 But the new account is still not usable (no messages are shown)
1235 until a restart of the application.
1237 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1239 * src/maemo/modest-maemo-global-settings-dialog.c:
1240 (idle_select_default_focus):
1241 * src/modest-mail-operation.c: (idle_notify_progress),
1242 (idle_notify_progress_once), (idle_notify_update_account_queue),
1243 (set_last_updated_idle), (update_account_thread),
1244 (notify_get_msgs_full), (get_msgs_full_destroyer),
1245 (get_msgs_full_thread):
1246 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1247 * src/widgets/modest-header-view.c:
1248 (idle_notify_headers_count_changed_destroy),
1249 (idle_notify_headers_count_changed):
1250 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1251 all idle handlers, because some other thread could be blocking
1252 the GDK lock, so that it can do GUI stuff.
1254 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1256 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1257 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1258 (on_idle_send_receive), (on_idle_open_default_inbox):
1259 * src/maemo/modest-msg-edit-window.c:
1260 (modest_msg_edit_window_attach_file_noninteractive):
1261 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1262 to prevent a hang. I don't quite understand why these are necessary,
1263 beause we should already be in the main loop. I guess something outside
1264 of the main loop is taking the lock.
1266 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1267 we are really using URIs, and use files that are more likely to exist.
1269 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1271 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1272 necessary because configure.ac now defines different variables.
1274 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1276 * libmodest-dbus-client/libmodest-dbus-client.c:
1277 * libmodest-dbus-client/libmodest-dbus-client.h:
1278 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1279 libmodest_dbus_client_compose_mail() is what things actually use.
1281 * src/dbus_api/modest-dbus-api.h:
1282 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1283 * tests/dbus_api/Makefile.am:
1284 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1287 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1289 * src/modest-init.c: (modest_init_local_folders):
1290 For memory-card (or other non local-folders) maildir accounts,
1291 always create an Archive folder, so that there is somewhere to put
1292 messages. This should be less confusing, because the user does not need
1293 to guess that the need to create a folder.
1295 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1297 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1298 Fixed icon size by using (50, 50) which is the same as defined by
1301 2007-06-25 Armin Burgmeier <armin@openismus.com>
1303 * src/widgets/modest-window-mgr.c:
1304 * src/modest-init.c:
1305 * configure.ac: Correctly recognize hildon-notify presence and fixed
1306 the build without it being installed.
1308 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1310 * libmodest-dbus-client/libmodest-dbus-client.c:
1311 (libmodest_dbus_client_search): Fix the build. Sorry.
1312 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1313 (reply_forward_cb): Initialize variables to fix the build.
1315 * src/modest-tny-account-store.c:
1316 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1317 comparison (a silly typo) so that email search results can be opened
1318 when there are more than one account.
1320 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1322 * libmodest-dbus-client/libmodest-dbus-client.c:
1323 (libmodest_dbus_client_search),
1324 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1325 instead of 1 second, because the search gets folders and messages from
1326 the server, which can take a long time. When it times out,
1327 osso-global-search will report no results.
1329 We need to specify whether we should search only cached information
1330 (maybe with a user preference), and the osso-email-search-plugin
1331 API should really be improved to allow that option, and to allow results
1332 to be delivered asynchronously in batches.
1334 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1336 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1337 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1338 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1340 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1342 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1343 that is an empty string. D-Bus seems to give us these instead of NULL.
1345 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1347 * src/dbus_api/modest-dbus-callbacks.c:
1348 * src/maemo/easysetup/modest-easysetup-wizard.h:
1349 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1350 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1351 (modest_connection_specific_smtp_edit_window_init):
1352 * src/maemo/modest-maemo-global-settings-dialog.c:
1354 * src/maemo/modest-maemo-utils.c:
1355 (modest_maemo_utils_setup_images_filechooser):
1356 * src/maemo/modest-main-window.c: (create_details_widget):
1357 * src/maemo/modest-msg-edit-window.c:
1358 (modest_msg_edit_window_attach_file_noninteractive),
1359 (modest_msg_edit_window_color_button_change),
1360 (modest_msg_edit_window_set_zoom):
1361 * src/modest-mail-operation.c: (update_account_thread):
1362 * src/modest-tny-account-store.c:
1363 * src/modest-tny-account.c:
1364 * src/widgets/modest-global-settings-dialog.c:
1365 * src/widgets/modest-window.h:
1367 Fixed build on bora!
1369 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1371 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1372 * src/modest-search.c: (modest_search_folder),
1373 (modest_search_all_accounts): Actually search only in the specified folder,
1374 doing a simple match on the folder ID.
1375 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1376 and added some documentation.
1378 2007-06-22 Armin Burgmeier <armin@openismus.com>
1380 * src/maemo/modest-maemo-utils.h:
1381 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1382 modest_maemo_utils_get_supported_secure_authentication_methods.
1384 * src/maemo/easysetup/modest-easysetup-wizard.c:
1385 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1386 one occured, not just "Server does not support secure authentication".
1388 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1390 * src/modest-tny-account-store.c: (get_password):
1391 Restored the call to tny_account_set_user() because Philip seems to have
1392 stopped this from crashing (by not using the freed string). It still does
1393 not work, but now we can test it.
1395 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1397 * src/maemo/modest-msg-edit-window.c: (init_window):
1398 Comment out use of an uninitialzed GtkScrolledWindow variable,
1399 to fix the build and stop a crash. Yet again.
1401 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1403 * src/modest-tny-account-store.c: (get_password):
1404 Remove the call to tny_account_set_user() because this actually crashes.
1405 As mentioned in the last commit, it is known to not work anyway.
1407 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1409 * src/modest-tny-account-store.c: (get_password):
1410 Use tny_account_set_username() to tell tinymail that the username might
1411 have changed too. But tinymail ignores this: see projects.maemo.org
1413 * src/modest-ui-actions.c:
1414 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1415 reset the connection when changing the username, and improve the comments.
1416 Save the changed username to gconf at least, so it is used when Modest is
1419 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1421 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1422 Do not use a query, so that we get all folders, including for POP and
1423 local-folders. They work as search criteria too.
1424 This fixes projects.maemo.org bug NB#57740.
1426 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1428 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1429 Comment out the use of hildon_notification_set_sound() because it is
1430 not declared, to fix the build. Warnings are serious, people.
1432 2007-06-21 Armin Burgmeier <armin@openismus.com>
1434 * src/maemo/modest-maemo-utils.h:
1435 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1436 modest_maemo_utils_get_supported_secure_authentication_methods()
1437 to query authentication methods for a specific user. This should fix
1438 projects.maemo.org bug NB#61369.
1440 * src/maemo/easysetup/modest-easysetup-wizard.c:
1441 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1444 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1446 * libmodest-dbus-client/libmodest-dbus-client.h:
1447 * libmodest-dbus-client/libmodest-dbus-client.c:
1448 (modest_dbus_message_iter_get_search_hit),
1449 (libmodest_dbus_client_search):
1450 Reorganised and commented this.
1451 Removed modest_search_hit_free() from the public API because it
1454 Added libmodest_dbus_client_get_folders() and
1455 modest_folder_result_list_free().
1457 * src/dbus_api/modest-dbus-api.h:
1458 * src/dbus_api/modest-dbus-callbacks.c:
1459 (modest_dbus_req_filter): Commented. Moved most code to
1460 on_dbus_method_search() and added on_dbus_method_get_folders().
1462 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1463 of the extra D-Bus handler.
1465 * tests/dbus_api/Makefile.am:
1466 * tests/dbus_api/test_get_folders.c: New test for
1467 libmodest_dbus_client_get_folders(). This seems to return an empty list
1468 at the moment. That could be the same error that causes the message list
1469 to be empty sometimes.
1470 This should help with projects.maemo.org bug NB#57740.
1472 2007-06-21 Armin Burgmeier <armin@openismus.com>
1474 * src/modest-mail-operation.c: Do not call
1475 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1476 notify the operation's end after having set the status to CANCELED for
1477 the operation queue to listen on. This fixes a deadlock when there
1478 were mail operations in the queue during its finalization.
1480 * src/modest-singletons.c: Reordered uninitialization of the account
1481 manager to happen after the mail operation queue was uninitialized
1482 because the mail operation's in the queue might still try to access
1483 the account manager (see modest_mail_operation_notify_end()). This
1484 fixes a potential crash when terminating the application.
1486 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1488 * src/modest-search.c:
1489 (search_mime_part_and_child_parts): Moved some code here so we
1490 can search recursively in child folders.
1491 (modest_search_folder): Search in the message as a mime part, instead
1492 of just its child mime parts.
1493 (read_chunk), (search_mime_part_ogs):
1494 Check how many bytes were read, to prevent an endless loop.
1495 Searching in message bodies now works. This finishes the fix for
1496 projects.maemo.org bug NB#61007.
1498 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1500 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1501 Add a g_warning when the item is not a folder.
1503 * src/modest-ui-dimming-rules.c:
1504 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1505 when selected item is not a folder (for instance, an account), because
1506 the UI spec only talks about folders.
1507 I am not sure what the UI spec wants, so this might not totally fix
1508 projects.maemo.org bug NB#60794.
1510 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1512 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1513 (load_from_file): Sort the list. The unsorted list would be more noticeable
1514 in non-English locales.
1516 * src/maemo/modest-msg-edit-window.c:
1517 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1518 warning and fix the build.
1520 * src/maemo/modest-progress-bar-widget.c:
1521 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1522 avoid a g_warning, and probably to avoid a crash.
1524 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1526 * src/modest-search.c: (modest_search_folder): Check for a GError
1527 when calling tny_folder_get_headers(), to show that this is not the cause
1530 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1532 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1533 Actually set the body query instead of the subject query.
1535 * src/modest-search.c: (search_mime_part_ogs),
1536 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1537 which would probably cause it to fail if we got this far.
1539 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1540 to simplify the code.
1541 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1542 be causing search-in-body to fail.
1544 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1546 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1548 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1549 Better debug message when the folder cannot be found.
1550 This should help with fixing projects.maemo.org bug #61287.
1551 * src/modest-search.c: (add_hit): Do not leak the furl string.
1553 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1555 * src/modest-ui-actions.c:
1556 (modest_ui_actions_on_folder_selection_changed):
1557 Do not special-case TNY_MERGE_FOLDER here, because
1558 modest_tny_folder_get_account() already does that. This fixes
1559 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1560 shown when the Outbox was selected).
1562 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1564 * libmodest-dbus-client/libmodest-dbus-client.c:
1565 (_dbus_iter_get_string_or_null): Initialize the string variable in
1566 case this helps with Dirk's crash.
1568 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1570 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1571 though it is not implemented yet (this function is maybe not even used),
1572 to avoid breaking ABI in future.
1573 * libmodest-dbus-client/libmodest-dbus-client.c:
1574 (get_attachments_string): Moved some code into this generic function.
1575 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1576 sends email. It is maybe not used.
1577 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1578 (on_send_mail): Use attachments.
1580 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1581 * src/maemo/modest-msg-edit-window.c:
1582 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1583 a filename before using it, to fix projects.maemo.org bug NB#58233.
1585 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1587 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1588 Initialize the continue_download variable to fix the build, and probably
1589 to fix randome behaviour.
1591 2007-06-18 Armin Burgmeier <armin@openismus.com>
1593 * src/modest-tny-send-queue.h:
1594 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1595 the queue so we can later show it in the UI. Replaced
1596 modest_tny_send_queue_msg_is_being_sent() by
1597 modest_tny_send_queue_get_msg_status().
1599 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1601 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1602 gpointer. This probably was not harmful, but just to be sure.
1604 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1606 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1607 Fix the build, but leave the function broken on Bora, because
1608 hildon_uri_action_get_service() does not exist.
1609 osso_uri_action_get_service() does not exist either, it seems.
1611 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1613 * src/modest-tny-account.c:
1614 (modest_tny_account_new_from_server_account):
1615 Uncommented the url debug output again, because it is useful for
1616 debugging, as I said in the comment.
1618 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1620 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1622 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1623 for Mameo Bora, to fix the build.
1625 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1628 Fixed build with hildon < 0.99
1630 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1631 Check if the selected account is busy instead of checking all accounts
1633 * src/modest-account-mgr-priv.h:
1634 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1635 (modest_account_mgr_init), (compare_account_name),
1636 (modest_account_mgr_set_account_busy),
1637 (modest_account_mgr_account_is_busy):
1638 * src/modest-account-mgr.h:
1639 Added busy information to the account manager. It possible to
1640 set an account to busy or not busy now.
1642 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1643 (modest_mail_operation_update_account),
1644 (modest_mail_operation_notify_end):
1645 Set the account to busy/not busy depending on the operation state.
1647 * src/widgets/modest-account-view.c:
1648 (modest_account_view_finalize), (get_last_updated_string),
1649 (update_account_view), (on_account_busy_changed), (init_view):
1650 Show string "Refreshing..." if the account is currently busy.
1652 All this fixes projects.maemo.org bug NB#59711
1654 2007-06-14 Armin Burgmeier <armin@openismus.com>
1656 * src/widgets/modest-attachments-view.h:
1657 * src/widgets/modest-attachments-view.c: Added
1658 modest_attachments_view_has_attachments() and fixed coordinate
1659 transformation in get_att_view_at_coords(). This fixes attachment
1662 * src/widgets/modest-msg-view.c: Make use of
1663 modest_attachments_view_has_attachments() to decide whether to show
1664 attachments in the header.
1666 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1668 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1669 (on_change), (on_combo_security_changed),
1670 (modest_connection_specific_smtp_edit_window_init),
1671 (modest_connection_specific_smtp_edit_window_set_connection),
1672 (modest_connection_specific_smtp_edit_window_is_dirty):
1673 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1674 * src/maemo/modest-connection-specific-smtp-window.c:
1677 Show an comfirmation dialog for the smpt-edit-window if there are
1678 unsaved changes and the user hits cancel.
1679 (projects.maemo.org bug NB#60479)
1681 2007-06-14 Armin Burgmeier <armin@openismus.com>
1683 * src/maemo/easysetup/modest-easysetup-wizard.c:
1684 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1685 address" info in banner instead of node, and select all the text as
1686 per UI spec. This fixes projects.maemo.org bug NB#60550.
1688 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1690 reviewed by: <delete if not using a buddy>
1692 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1693 * src/modest-ui-actions.c: (folder_refreshed_cb):
1695 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1697 * src/widgets/modest-folder-view.c: (filter_row):
1698 Explictly filter out the per-account outbox accounts. I don't know why
1699 these only sometimes show up, but now they should never show up in the UI.
1700 This should fix projects.maemo.org bug NB#60160.
1702 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1704 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1705 when the toolbar does not exist yet.
1706 * src/modest-widget-memory.c: (save_settings_header_view):
1707 Added g_warnings() to help us to discover when we are trying to set
1708 an empty columns list in gconf.
1710 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1712 * src/modest-init.h:
1713 * src/modest-init.c:
1714 Added modest_init_get_default_header_view_column_ids().
1716 * src/modest-widget-memory.c: (restore_settings_header_view):
1717 Use the new function to get defaults, if the gconf key is empty,
1718 instead of not creating any columns. This seems to fix the
1719 empty right-hand pane problems.
1721 * src/widgets/modest-header-view.h: Improved documentation.
1723 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1725 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1726 Revert the use of the display name as the account name, because this
1727 is generally wrong and would break the code that follows.
1729 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1731 * src/maemo/easysetup/modest-easysetup-wizard.c:
1732 (check_for_supported_auth_methods), (on_before_next),
1735 More correct fix for projects.maemo.org bug NB# 58991
1736 Do not longer accept AUTH_PASSWORD as secure method and choose
1737 correct method when creating the account.
1739 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1741 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1742 Fixed projects.maemo.org bug NB# 58991
1744 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1746 * src/modest-init.c: (modest_init_init_core),
1747 (modest_init_local_folders): Fixed compilation errors.
1749 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1751 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1752 Remove unnecessary lib/include, though it is good in principle when needed.
1754 * src/modest-init.c: (modest_init_one_local_folder),
1755 (modest_init_local_folders):
1756 * src/modest-init.h: Initialize the .modest library for memory cards,
1757 instead of just doing nothing for them. This should allow us to create
1758 folders there, fixing projects.maemo.org bug NB#59297.
1760 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1762 * libmodest-dbus-client/libmodest-dbus-client.c:
1763 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1764 (libmodest_dbus_client_compose_mail),
1765 (libmodest_dbus_client_open_message),
1766 (libmodest_dbus_client_send_and_receive),
1767 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1769 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1770 (on_idle_open_message), (modest_dbus_req_handler),
1771 (search_result_to_message), (modest_dbus_req_filter):
1772 * src/modest-search.c: (add_hit), (modest_search_folder),
1773 (modest_search_all_accounts): Improved debug messages.
1775 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1777 * src/modest-tny-account-store.c:
1778 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1781 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1784 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1786 * src/modest-tny-account-store.c: (get_server_accounts):
1787 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1788 even when there are no accounts, so that the Outbox folder is always
1789 visible. This fixes projects.maemo.org bug NB#60158.
1791 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1793 * src/maemo/modest-main-window.c: (create_details_widget):
1794 Use the mcen_va_never logical ID.
1796 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1798 * src/dbus_api/modest-dbus-api.h:
1799 * src/dbus_api/modest-dbus-callbacks.c:
1800 (on_idle_open_default_inbox), (on_open_default_inbox),
1801 (modest_dbus_req_handler):
1802 Added a new OpenDefaultInbox method.
1804 * libmodest-dbus-client/libmodest-dbus-client.h:
1805 * libmodest-dbus-client/libmodest-dbus-client.c:
1806 Added libmodest_dbus_client_open_default_inbox() to call the new
1807 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1808 though it should maybe be used by a new osso-email-interface function.
1810 * tests/dbus_api/Makefile.am:
1811 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1814 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1816 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1817 NULL, so that the signals get all the keys. This should not actually
1818 change any behaviour because we currently update everything when anything
1821 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1823 * src/widgets/modest-folder-view.c: (text_cell_data),
1824 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1825 (find_inbox_iter): If tinymail tells us that the folder is
1826 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1827 This causes the inbox to be selected at startup, fixing part of
1828 projects.maemo.org bug NB#56305.
1830 * src/modest-ui-dimming-rules.c:
1831 (modest_ui_dimming_rules_on_tools_smtp_servers):
1832 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1833 the SMTP servers menu item.
1834 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1835 that the SMTP Servers menu item is dimmed when there are no accounts,
1836 as a future version of the UI spec will require. This fixes
1837 projects.maemo.org bug NB#56305.
1839 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1841 * src/maemo/modest-maemo-utils.c:
1842 (modest_maemo_utils_get_supported_secure_authentication_methods):
1843 Added label to dialog instead of unreadable title
1845 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1846 (modest_main_window_new):
1847 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1850 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1851 * src/modest-account-mgr.h:
1852 Added method to avoid code duplication
1854 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1855 (modest_ui_actions_on_send_receive):
1856 Use modest_account_mgr_has_accounts
1858 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1860 * src/maemo/easysetup/modest-presets.c:
1861 (modest_presets_get_info_server_security): Do not report secure auth
1863 * src/modest-protocol-info.c: Use the defines for the gconf key names
1864 for secure authentication. This was not working because we were writing
1865 Password and reading password, and the check was case sensitive.
1866 With this, gmail now works for receiving and sending when created via
1869 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1871 * src/maemo/easysetup/modest-presets.c:
1872 (modest_presets_get_info_server_security): Correct the key name for
1873 SecureSmtp, because it seems to be case-sensitive.
1874 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1875 Do not try to get the 0th notebook page if there are 0 pages, to
1876 avoid a g_warning().
1878 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1880 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1881 Prevent use of the new notification feature for now, because it currently
1882 shows one dialog for each new email, which is annoying.
1884 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1886 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1887 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1888 when no country was selected, so that we show the global ones.
1889 * src/maemo/easysetup/modest-presets.c:
1890 (modest_presets_get_providers): Return only the global providers, not
1891 all providers when mmc=0 was requested.
1893 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1895 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1896 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1897 provider ID in the combo.
1899 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1900 Do not show the page numbers, because it would be confusing when we add
1901 the 2 extra pages for the custom setup, when the user chooses the "Other"
1902 provider. This fixes projects.maemo.org bug NB#59028
1904 * src/modest-init.c: (modest_init_init_core),
1905 (modest_init_local_folders):
1906 * src/modest-init.h:
1907 * src/modest-tny-account.c:
1908 (modest_tny_account_new_for_local_folders): Do not create default folders
1909 for the memory card. This should fix projects.maemo.org bug NB#59328.
1911 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1913 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1914 Free the changed_conf_keys string items. They are already freed in the
1915 idle handler if that runs first.
1917 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1919 * src/modest-ui-actions.c:
1920 (modest_ui_actions_on_password_requested): Check that the server name
1921 is not NULL, because I just saw a password dialog with (null) as the
1924 * src/modest-tny-folder.[h|c]: Added
1925 modest_tny_folder_is_memory_card_folder().
1926 * src/modest-ui-dimming-rules.c:
1927 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1928 menu item for memory cards, as per the UI spec (section 7.4). This should
1929 fix projects.maemo.org bug NB#59297.
1931 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1933 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1934 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1935 is another problem with the code, see Murray's comment at line 772)
1937 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1939 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1940 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1941 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1942 (load_from_file), (easysetup_country_combo_box_init),
1943 (easysetup_country_combo_box_get_active_country_ids),
1944 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1945 instead of just one ID, to avoid duplicate country names in the UI.
1947 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1948 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1949 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1950 a single ID, avoiding duplicate providers.
1951 * src/maemo/easysetup/modest-easysetup-wizard.c:
1952 (on_combo_account_country): Adapt to use a list.
1954 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1956 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1957 keys changed in the last X seconds.
1959 * src/modest-account-mgr.h:
1960 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1961 (on_key_change), (modest_account_mgr_class_init),
1962 (modest_account_mgr_init), (modest_account_mgr_finalize):
1963 As the keys are changed, save them in a GSList* and signal that GSList*
1964 further every X seconds, to batch changes, to allow us to do just one
1965 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1966 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1968 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1969 changed signal signature.
1971 * src/modest-conf.c: (modest_conf_set_list),
1972 (modest_conf_on_change): Reenable notification.
1974 (modest_conf_maemo_fake_on_change): Comment out the hack that
1975 notified immediately instead of asynchronously.
1977 * src/widgets/modest-account-view.h:
1978 * src/widgets/modest-account-view.c:
1979 (update_account_view): Select the previously-selected account ID,
1980 if possible. This fixes projects.maemo.org bug NB#56933.
1982 (on_account_changed), (on_account_removed),
1983 (modest_account_view_select_account):
1985 Remove the block/unblock functions
1986 because they were not useful.
1988 * src/maemo/modest-account-view-window.c:
1989 (on_delete_button_clicked), (on_edit_button_clicked),
1990 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1992 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1994 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1995 Improve the error dialog to show Incorrect Account Settings, which seems
1996 clearer, and say that the internal error message (to be removed from the
1997 dialog later) is often misleading.
1998 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2000 * src/modest-tny-account.c:
2001 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2002 URL because this is so useful for debugging on the device.
2004 * src/widgets/modest-serversecurity-combo-box.c:
2005 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2007 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2009 * src/modest-mail-operation.c:
2010 (modest_mail_operation_send_new_mail):
2011 Added a comment about a nasty but apparently harmless message. Details
2012 added to the wiki g_warnings() page.
2014 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2016 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2017 (modest_tny_send_queue_class_init):
2018 Do not use the priv struct because it is empty, to avoid g_warnings
2019 about a non-existant priv struct.
2021 * src/modest-tny-account-store.c:
2022 (modest_tny_account_store_get_server_account),
2023 (modest_tny_account_store_get_transport_account_for_open_connection
2024 ): Do not try to get transport server accounts for local folders,
2025 because they don't have any. This avoids a g_warning().
2027 * src/maemo/modest-main-window.c:
2028 (modest_main_window_notify_send_receive_initied),
2029 (on_configuration_key_changed):
2030 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2031 * src/modest-defs.h:
2032 * src/modest-mail-operation.c:
2033 (modest_mail_operation_update_account):
2034 * src/modest-tny-account-store.h:
2035 * src/modest-tny-account.c:
2036 (modest_tny_account_get_special_folder),
2037 (modest_tny_account_new_for_local_folders),
2038 (modest_tny_account_new_for_per_account_local_outbox_folder):
2039 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2040 * src/modest-tny-local-folders-account.c:
2041 (add_account_folders_to_merged_folder):
2042 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2043 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2044 (modest_ui_actions_on_send):
2045 * src/widgets/modest-folder-view.c: (update_model):
2046 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2047 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2048 modest_tny_account_store_get_tny_account_by_account() to
2049 modest_tny_account_store_get_server_account() to make the code clearer.
2051 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2053 * src/dbus_api/modest-dbus-api.h:
2054 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2055 * src/maemo/modest-msg-edit-window.c:
2056 (modest_msg_edit_window_attach_file_noninteractive):
2057 added g_warning in case the file to be attached does not exist
2058 * tests/dbus_api/test_compose_mail.c: (main):
2059 removed obsolete comment, added generic files as test case
2061 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2063 * src/modest-tny-account-store.c: (get_server_accounts):
2064 Create the local folders account only once, not once for each outbox, and
2065 not only when there are some outboxes.
2067 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2069 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2070 code that is causing a crash at startup. Sergio says that he is fixing this.
2072 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2074 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2075 * src/maemo/modest-account-settings-dialog.c:
2076 (create_page_outgoing),
2077 (modest_account_settings_dialog_set_account_name),
2078 (save_configuration):
2079 - Fixed handling of the "Use secure authentication" toggle to comply with
2080 the ui specification. See also projects.maemo.org bug NB#58400
2082 - Restore the Secure connection setting combo correctly when loading
2085 * src/maemo/modest-maemo-utils.c:
2086 (on_camel_account_get_supported_secure_authentication),
2087 (modest_maemo_utils_get_supported_secure_authentication_methods):
2088 Fixed a crasher if operation is canceled
2090 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2091 (modest_protocol_info_auth_is_secure):
2092 * src/modest-protocol-info.h:
2094 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2095 the sense of the "Use secure authentication" toggle.
2097 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2099 * src/modest-tny-account-store.h:
2100 * src/modest-tny-account-store.c:
2101 Added modest_tny_account_store_get_local_folders_account().
2103 * src/modest-tny-folder.h:
2104 * src/modest-tny-folder.c:
2105 (modest_tny_folder_get_account):
2106 Added this replacement for tny_folder_get_account() which returns
2107 the local-folders account for TnyMergeFolders, to avoid the
2108 warning about the unimplemented get_account_func() vfunc().
2110 (modest_tny_folder_get_rules),
2111 * src/modest-ui-actions.c:
2112 (modest_ui_actions_on_folder_selection_changed):
2113 * src/modest-mail-operation.c:
2114 (modest_mail_operation_remove_folder),
2115 (modest_mail_operation_xfer_folder),
2116 (modest_mail_operation_rename_folder),
2117 (modest_mail_operation_get_msg),
2118 (modest_mail_operation_get_msgs_full),
2119 (modest_mail_operation_remove_msg),
2120 (modest_mail_operation_xfer_msgs),
2121 (modest_mail_operation_refresh_folder):
2122 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2124 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2126 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2127 (modest_server_account_set_security):
2128 * src/modest-defs.h: Add comments explaining that our
2129 UI spec means TLS when it says Normal, so these do not look like errors.
2131 * src/modest-tny-account.c:
2132 (modest_tny_account_new_from_server_account): Use the new tinymail
2133 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2134 for TLS. This should fix projects.maemo.org bug NB#58460.
2136 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2138 * src/maemo/easysetup/modest-easysetup-wizard.c:
2139 (create_account): Correct the position of the gconf sanity check warning.
2140 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2141 of using the g_idle_add() hack, because this does not seem to be necessary
2142 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2143 caused by something other than maemo's gconf.
2144 This fixes projects.maemo.org bug #59022.
2146 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2148 * src/modest-account-mgr-helpers.c:
2149 (modest_account_mgr_get_default_account): Do not check that the account
2150 exists if there is no default account (NULL), to fix a runtime warning.
2152 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2154 * src/widgets/modest-folder-view.c: (update_model):
2155 Do not unref the treemodel before we have finished with it.
2156 This prevents a valgrind warning and an occasional crash at startup.
2158 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2160 * libmodest-dbus-client/libmodest-dbus-client.h:
2161 added libmodest_dbus_client_compose_mail()
2162 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2164 added functions needed for SendAsMail() functionality
2165 * src/maemo/modest-msg-edit-window.c:
2166 (modest_msg_edit_window_attach_file_noninteractive):
2167 non interactively attaching files to message edit window
2168 * src/widgets/modest-msg-edit-window.h:
2169 * tests/dbus_api/Makefile.am:
2170 added test_compose_mail.c
2171 * tests/dbus_api/test_compose_mail.c: (main):
2173 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2175 * src/modest-account-view.c:
2176 Fixed bug projects.maemo.org bug NB#59307
2178 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2180 * src/maemo/easysetup/modest-easysetup-wizard.c:
2181 (get_serverport_incoming), (on_before_next), (create_account):
2182 * src/maemo/modest-account-settings-dialog.c:
2183 (modest_account_settings_dialog_set_account_name):
2184 * src/maemo/modest-maemo-utils.c:
2185 (on_camel_account_get_supported_secure_authentication_status),
2186 (on_camel_account_get_supported_secure_authentication),
2187 (on_secure_auth_cancel),
2188 (modest_maemo_utils_get_supported_secure_authentication_methods):
2190 Implemented security authentication for settings and easysetup.
2192 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2194 * src/maemo/modest-main-window.c: (create_details_widget):
2195 Show the total size for memory card accounts too, instead of showing
2196 the name again. Fixes bug projects.maemo.org bug NB#59307.
2198 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2201 * src/modest-tny-simple-folder-store.c:
2202 * src/modest-tny-simple-folder-store.h: Removed.
2204 * src/modest-tny-local-folders-account.h
2205 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2206 for the local-folders maildir, with an extra TnyMergedFolder containing
2207 the folders of the per-account outbox store accounts.
2208 * src/modest-tny-account-store.c: (get_server_accounts):
2209 Add the outboxes to the special local folders account after creating it.
2211 * src/modest-tny-account.c:
2212 (modest_tny_account_new_for_local_folders): Create the derived
2213 account when creating the main local-folders account.
2215 * src/maemo/modest-main-window.c: (create_details_widget),
2216 (modest_main_window_set_contents_style):
2217 Adapted to the use of the derived account instead of the folder store.
2219 * src/modest-ui-actions.c:
2220 (modest_ui_actions_on_folder_selection_changed):
2221 * src/modest-ui-dimming-rules.c:
2222 (modest_ui_dimming_rules_on_new_folder):
2223 * src/widgets/modest-folder-view.c: (text_cell_data),
2224 (icon_cell_data), (filter_row), (update_model),
2225 (get_cmp_rows_type_pos):
2228 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2229 Do not get the priv struct, because no priv struct has been set,
2230 to avoid a runtime warning.
2232 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2233 #ifelse with #else, to fix a warning, to fix the build.
2236 2007-06-05 Christian Kellner <ckellner@openismus.com>
2238 * libmodest-dbus-client/libmodest-dbus-client.c:
2239 Fix small typo in doc (why do you always see them
2240 AFTER committing stuff?)
2243 2007-06-05 Christian Kellner <ckellner@openismus.com>
2245 * libmodest-dbus-client/libmodest-dbus-client.c:
2246 (libmodest_dbus_client_search):
2247 Initialize hit list with NULL. Also set folder list
2248 to "" if NULL was supplied.
2251 2007-06-03 Christian Kellner <ckellner@openismus.com>
2253 * libmodest-dbus-client/libmodest-dbus-client.c:
2254 (modest_search_hit_list_free):
2255 Make it save to call it with NULL.
2257 * src/dbus_api/modest-dbus-callbacks.c:
2258 * src/modest-search.c:
2259 Return full ModestSearchHits as the search result list not TnyHeader
2260 since can't be around withouth the correspoding TnyFolder.
2262 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2264 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2265 Added currently commented code to check for secure auth
2267 * src/maemo/modest-account-settings-dialog.c: (on_response),
2268 (save_configuration), (show_ok):
2269 Fixed projects.maemo.org bugs NB #59248 and #59251
2271 * src/maemo/modest-maemo-utils.c:
2272 (on_camel_account_get_supported_secure_authentication_status),
2273 (on_camel_account_get_supported_secure_authentication),
2274 (modest_maemo_utils_get_supported_secure_authentication_methods):
2275 * src/maemo/modest-maemo-utils.h:
2276 Moved get_supported_secure_authentication() method here to be able
2277 to use it from easysetup wizard.
2279 * src/modest-pair.c: (on_pair_compare_as_string):
2280 Should compare string with first part of pair and not
2281 strcmp pairs which will crash.
2283 * src/modest-protocol-info.c:
2284 (modest_protocol_info_protocol_is_store):
2285 * src/modest-protocol-info.h:
2286 Added modest_protocol_info_get_auth_protocol_name()
2288 2007-06-03 Armin Burgmeier <armin@openismus.com>
2290 * src/modest-mail-operation.c:
2291 (modest_mail_operation_get_msgs_full): Set priv->account also when
2292 only retrieving a single message. This avoids a crash when canceling
2295 (modest_mail_operation_notify_end): Do not explicitely remove the
2296 operation from the queue but only emit the progress_changed signal.
2297 The queue itself listens to that signal to remove the operation when
2298 it is finished. This reduces coupling and removes a potential deadlock
2299 when modest_mail_operation_notify_end() is called from the queue
2300 itself. If that is a problem performance-wise, I would suggest to
2301 implement a status-changed signal or something.
2303 * src/modest-mail-operation-queue.c: Make sure to never call a
2304 function from another file while the queue is locked. This (hopefully)
2305 fixes another deadlock when exiting the application while retrieving
2308 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2310 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2311 Fixed build if libogs is not available
2313 2007-06-03 Christian Kellner <ckellner@openismus.com>
2315 * libmodest-dbus-client/libmodest-dbus-client.h:
2316 * libmodest-dbus-client/libmodest-dbus-client.c:
2317 (libmodest_dbus_client_delete_message):
2318 Implement deletion of messages (Client side).
2320 (modest_search_hit_free),
2321 (modest_search_hit_list_free):
2322 Utility functions to free the result hits.
2324 * src/dbus_api/modest-dbus-api.h:
2325 * src/dbus_api/modest-dbus-callbacks.c:
2326 (on_delete_message),
2327 (modest_dbus_req_handler):
2328 Implement deletion of messages (Server side).
2330 * tests/dbus_api/test_search.c: (main):
2333 * tests/dbus_api/Makefile.am:
2334 * tests/dbus_api/test_delete_message:
2335 Add little test for the message deletion logic
2337 2007-06-03 Armin Burgmeier <armin@openismus.com>
2339 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2340 when the operation queue was not empty. projects.maemo.org bug
2343 2007-06-03 Armin Burgmeier <armin@openismus.com>
2345 * src/widgets/modest-account-view.c
2346 (on_account_default_toggled): Toggle default account column
2347 explicitely instead of waiting for gconf notification (which is
2348 currently ignored). This should fix projects.maemo.org bug NB#56910
2349 for now. It should probably be removed when gconf notifications are
2352 2007-06-03 Christian Kellner <ckellner@openismus.com>
2354 * libmodest-dbus-client/libmodest-dbus-client.c:
2355 Removed debugging spew.
2357 * src/dbus_api/modest-dbus-callbacks.c:
2358 Added debugging info.
2360 * src/modest-search.c:
2361 (modest_search_all_accounts):
2362 Use tny_account_store_get_accounts () on the account store
2363 to get all accounts which is the way to get all accounts.
2365 * tests/dbus_api/test_search.c: (main):
2366 Make it possible to supply the search term on the command line.
2368 2007-06-03 Christian Kellner <ckellner@openismus.com>
2370 * libmodest-dbus-client/libmodest-dbus-client.c:
2371 * libmodest-dbus-client/libmodest-dbus-client.h:
2372 Implement searching for mesages over raw dbus. (Client side)
2374 * src/dbus_api/Makefile.am:
2375 * src/dbus_api/modest-dbus-api.h:
2376 * src/dbus_api/modest-dbus-callbacks.c:
2377 * src/dbus_api/modest-dbus-callbacks.h:
2378 Search framework (Server side). Also implement on_idle_open_message().
2380 * src/maemo/modest-platform.c: (modest_platform_init):
2381 Prepare for raw dbus/osso rpc interaction.
2383 * src/modest-search.h:
2384 Changed minsize from unspecific guint to guint32.
2386 * src/modest-search.c:
2388 Added strange hack which magically made tnymail work.
2390 (modest_search_folder),
2391 (modest_search_account),
2392 (modest_search_all_accounts):
2393 Implement helper functions to search all accounts, specific account
2396 * tests/dbus_api/Makefile.am:
2397 * tests/dbus_api/test_open_message.c:
2398 Read url to open from commandline.
2400 * tests/dbus_api/test_search.c:
2401 Implement small test for dbus search stuff
2403 2007-06-02 Armin Burgmeier <armin@openismus.com>
2405 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2406 include account type and account title. This fixes projects.maemo.org
2409 * src/maemo/modest-account-view-window.c: Set a title for the window.
2411 2007-06-02 Armin Burgmeier <armin@openismus.com>
2413 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2414 incoming and outgoing server name based on email address and server
2415 types as long as the names have not been edited manually. This fixes
2416 projects.maemo.org bug NB#58671.
2418 2007-06-02 Armin Burgmeier <armin@openismus.com>
2420 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2421 server type cannot be changed in future to the incoming details page
2422 when creating an account. This fixes projects.maemo.org bug NB#59029.
2424 2007-06-02 Armin Burgmeier <armin@openismus.com>
2426 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2427 and assigned max width chars so that they wrap instead of being
2428 truncated. Fixes projects.maemo.org bug NB#56126.
2430 2007-06-02 Armin Burgmeier <armin@openismus.com>
2432 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2433 introductory note to the connection specific smtp servers dialog, as
2434 section 8.12 of the email UI specification requires. This fixes
2435 projects.maemo.org bug NB#59212.
2437 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2439 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2440 Check for running mail operations, and offer to cancel them, as per the UI
2441 spec. This fixes projects.maemo.org bug NB#59041 .
2442 However, I suspect that tinymail may still use the network connection
2443 in ways that we cannot detect or cancel. But it should at least adapt to
2444 changes fairly well.
2446 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2448 * src/modest-tny-account-store.c: (recreate_all_accounts),
2449 (get_cached_accounts), (get_server_accounts): Do more sensible
2450 ref-counting of the temporarily-cached outbox accounts list. This seems
2451 to fix a crash when entering the password when the password was wrong.
2453 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2455 * src/gnome/modest-main-window.c: (connect_signals):
2456 * src/modest-tny-account-store.c: (get_password),
2457 (modest_tny_account_store_alert): Added comments and clues and
2458 commented-out code about how we currently fail to deal with connection
2459 errors and wrong passwords, and how we should.
2461 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2463 * src/widgets/modest-retrieve-combo-box.c:
2464 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2465 This fixes projects.maemo.org bug NB#58472 .
2467 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2469 * src/maemo/easysetup/modest-easysetup-wizard.c:
2470 (create_page_complete_easysetup):
2471 (create_page_complete_custom): Correct the last commit,
2472 putting the correct sentences in the correct pages.
2474 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2476 * src/maemo/easysetup/modest-easysetup-wizard.c:
2477 (create_page_complete_custom): Show the second sentence of text
2478 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2481 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2483 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2484 Set the leave-on-server conf key by default. This fixes
2485 projects.maemo.org bug NB#59258 .
2487 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2489 * src/maemo/modest-account-view-window.c:
2490 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2491 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2494 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2496 * src/maemo/easysetup/modest-easysetup-wizard.c:
2497 (create_caption_new_with_asterisk):
2498 * src/maemo/modest-account-settings-dialog.c:
2499 (create_caption_new_with_asterisk):
2500 Uncomment the code to add the asterisk, because they are no longer in the
2501 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2502 (update_incoming_server_title): Add an asterisk here too.
2504 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2506 * src/maemo/modest-maemo-global-settings-dialog.c:
2507 (current_connection): Check that we are even connected before trying to
2508 get the current connection name, to prevent a warning.
2510 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2511 Change the comments because tny_maemo_conic_device_connect() is now meant to
2513 * src/modest-mail-operation.c:
2514 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2515 make sure we have a connection and fail if we can't connect.
2517 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2519 * src/maemo/modest-main-window.c:
2520 (on_account_store_connecting_finished): Do not try to get the
2521 connection ID if we are not really connected. I am surprised that
2522 this signal handler is called when we are not connected.
2524 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2526 * src/modest-error.h:
2527 * src/modest-ui-actions.c:
2528 (modest_ui_actions_get_msgs_full_error_handler):
2529 Renamed an enum, added comments, added an enum
2530 for retrieve-limit errors.
2532 * src/modest-mail-operation.c: (foreach_add_item),
2533 (internal_folder_observer_update), (update_account_thread),
2534 (modest_mail_operation_get_msgs_full):
2535 (modest_mail_operation_update_account),
2536 Added comments about how this works, and some code that should
2537 (but does not) check the retrieve-limit. See the TODO comment.
2539 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2541 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2542 Initialize help_id to fix the build. Warnings are good.
2544 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2546 * src/widgets/modest-hbox-cell-renderer.c:
2547 (modest_hbox_cell_renderer_append):
2548 * src/widgets/modest-vbox-cell-renderer.c:
2549 (modest_vbox_cell_renderer_append):
2550 Fix the last commit by doing an extra ref.
2552 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2554 * src/widgets/modest-hbox-cell-renderer.c:
2555 (modest_hbox_cell_renderer_append):
2556 * src/widgets/modest-vbox-cell-renderer.c:
2557 (modest_vbox_cell_renderer_append):
2558 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2559 to fix the build with Maemo Bora.
2560 However, there seems to be a remaining crash, probably due to reference
2563 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2565 * src/modest-tny-account.c:
2566 (modest_tny_account_new_for_local_folders):
2567 Use hildon_file_system_info_async_new() to get a better name for
2568 the memory card account, setting it as the account name.
2569 The timing seems to work, but this is probably
2570 not the best place to do this. See the TODO comment.
2571 * src/maemo/modest-main-window.c: (create_details_widget):
2572 * src/widgets/modest-folder-view.c: (text_cell_data):
2573 Use the tny account name instead of hardcoding a name.
2575 2007-05-30 Christian Kellner <ckellner@openismus.com>
2577 * src/modest-search.c: (modest_search):
2578 Correctly set part_search_func even if we have already parsed
2579 the query and thus a valid OgsTextSearcher object.
2581 2007-05-30 Christian Kellner <ckellner@openismus.com>
2584 Search and check for libogs.
2587 Incooparte the ogs build env.
2589 * src/modest-mime-part-search-stream.c:
2590 * src/modest-mime-part-search-stream.h:
2591 Removed since we do the real searching now in modest-search.c.
2593 * src/modest-search.c:
2594 * src/modest-search.h:
2595 Implement support for ogs. We use that if available and requested
2596 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2597 should now handle the corner case when the search term is spread
2598 across multiple reads.
2599 Also the logic in modest_search () was corrected to search all
2600 requested fields until one is found.
2602 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2604 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2606 * src/modest-init.h:
2607 * src/modest-init.c: Made modest_init_local_folders() take a
2608 path and be public so we can iniitialize maildir folders on
2611 * src/modest-local-folder-info.h:
2612 * src/modest-local-folder-info.c:
2613 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2615 * src/modest-tny-account.c:
2616 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2617 still means the standard local-folders path on the local volume.
2619 * src/modest-tny-account-store.c:
2620 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2621 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2622 all accounts when that happens.
2623 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2624 this too, so it shows up in the treeview.
2626 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2628 * src/maemo/modest-maemo-global-settings-dialog.c:
2629 (current_connection):
2630 * src/widgets/modest-global-settings-dialog.c:
2631 (current_connection_default):
2632 Use the enum values instead of 0, 1 and -1,
2633 to make the code clearer.
2635 * src/modest-account-mgr-helpers.c:
2636 (modest_account_mgr_get_connection_specific_smtp): Make this code
2639 * src/modest-runtime.h:
2640 * src/modest-runtime.c:
2641 Added modest_runtime_remove_all_send_queues().
2642 * src/maemo/modest-main-window.c:
2643 (on_account_store_connecting_finished): Recreate the send queues,
2644 using the appropriate transport accounts for this new connection.
2645 Some futher adapting might be needed if the old send queues are not
2646 automatically stopped at this point.
2648 * src/modest-tny-account-store.c: (get_server_accounts):
2649 Create the connection-specific transport accounts, so that they can
2650 be found later by their ID.
2652 * src/modest-tny-account.h:
2653 * src/modest-tny-account.c:
2654 Added modest_tny_account_new_from_server_account_name().
2655 modest_tny_account_new_from_server_account(): Do not create the
2656 send queues here, because they will be
2657 recreated anyway when the connection changes for the first time.
2659 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2661 * src/modest-local-folder-info.h:
2662 * src/modest-local-folder-info.c:
2663 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2664 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2665 tbox_folder): Take a modest account name instead of a server TnyAccount,
2666 so we can have per-modest-account rather than per-transport-account
2668 We must make sure that we change or recreate the exisitng send queues
2669 when the connection changes for connection-specific transport accounts.
2671 * src/modest-tny-account-store.c:
2672 (create_per_account_local_outbox_folders): Create outboxed per modest
2673 account, not per transport account.
2675 * src/modest-tny-account.h:
2676 * src/modest-tny-account.c:
2677 (modest_tny_account_get_special_folder): For outboxes, get the
2678 parent modest account name. The account is ignored for other folders.
2679 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2680 modest account name rather than a server TnyAccount.
2682 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2684 * src/modest-tny-account.c:
2685 (modest_tny_account_new_from_server_account):
2686 Call modest_runtime_get_send_queue() immediately after creating transport
2687 accounts, so that they start trying to send email from the outbox as soon
2688 as possible at startup. This is probably what we want.
2690 * src/modest-mail-operation.c: (update_account_thread):
2691 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2692 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2693 * src/modest-tny-send-queue.h:
2694 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2695 (modest_ui_actions_on_send):
2696 Added comments about how sending works, though it needs some more work.
2698 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2700 * src/modest-tny-account.c:
2701 (modest_tny_account_get_special_folder): Add TODO because this fails when
2702 the network is busy.
2703 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2704 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2705 Do not try to show this window when there is no active account. The UI
2706 specs does not tell us what to do in this case.
2708 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2712 * src/maemo/Makefile.am:
2713 * src/widgets/Makefile.am: Some dist fixes.
2715 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2717 * src/maemo/modest-connection-specific-smtp-window.c:
2718 (on_button_edit): Make the code clearer, to prevent a double free.
2720 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2722 * src/maemo/modest-account-settings-dialog.c:
2723 (modest_account_settings_dialog_set_account_name),
2724 Check the connection-specific smtp servers checkbox if there are any.
2726 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2727 (modest_connection_specific_smtp_edit_window_init):
2728 Start with a suitable port number.
2730 * src/modest-account-mgr-helpers.h:
2731 * src/modest-account-mgr-helpers.c: Added
2732 modest_account_mgr_get_has_connection_specific_smtp().
2734 (modest_account_mgr_set_connection_specific_smtp),
2735 (modest_account_mgr_remove_connection_specific_smtp),
2736 (modest_account_mgr_get_has_connection_specific_smtp),
2737 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2738 connection-specific smtp server accounts in the account, rather than
2739 the server account conf dir.
2741 This fixes bug projects.maemo.org bug NB#58263 .
2743 * src/modest-tny-account-store.c:
2744 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2745 if there are no server accounts yet, to prevent an infinite loop when there
2746 are no accounts. Document that one must be called before the other.
2748 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2750 * src/modest-account-mgr-helpers.c:
2751 (modest_account_mgr_get_default_account): Make sure that at least
2752 one account is always the default, if there are any enabled accounts.
2753 This is just a sanity check that shouldn't be necessary.
2755 * src/modest-account-mgr-priv.c:
2756 (_modest_account_mgr_account_from_key): Unescape the conf key to
2757 get the real account name. For instance, this is an issue if a space
2758 was in the account name, which can happen because the account name
2759 is generated from the display name.
2760 (_modest_account_mgr_get_account_keyname): Always escape the
2762 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2763 Unescape the conf keys to get the real account names.
2765 For instance, previously the is-default radio button in the accounts
2766 list was not checked for any accounts at first. This fixes that,
2767 and might fix several similar bugs.
2769 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2771 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2772 Removed some debug printfs.
2774 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2776 Modest on-disk outbox directories are now here, for instance:
2777 $HOME/.modest/outboxes/<account-id-1>/outbox
2778 $HOME/.modest/outboxes/<account-id-2>/outbox
2780 $HOME/.modest/local-folders/outbox
2781 so we can have a separate outbox for each account.
2782 But they are shown as one outbox in the GtkTreeView, by using a
2783 TnyMergeFolder in a ModestTnySimpleFolderStore.
2786 * src/modest-tny-simple-folder-store.c:
2787 * src/modest-tny-simple-folder-store.h:
2788 Added ModestTnySimpleFolderStore, used to contain folders from
2789 other folder stores, such as other accounts.
2791 * src/modest-tny-outbox-account.h:
2792 * src/modest-tny-outbox-account.c:
2793 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2794 used for the per-account local outbox folders.
2796 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2797 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2798 only use this (internally) now for the non-outbox local folders.
2800 * src/modest-init.h:
2801 * src/modest-init.c: Added modest_init_one_local_folder(), for
2802 setting up the directory structure for each local folder.
2804 * src/modest-local-folder-info.c:
2805 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2806 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2808 * src/modest-local-folder-info.h:
2809 * src/modest-tny-account-store.c: (on_account_removed),
2810 (on_account_changed), (create_per_account_local_outbox_folders),
2811 (get_server_accounts), (modest_tny_account_store_get_accounts),
2812 (modest_tny_account_store_get_tny_account_by_account),
2813 (modest_tny_folder_store_is_virtual_local_folders):
2815 * src/modest-tny-account.h:
2816 * src/modest-tny-account.c:
2817 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2818 to create an on-disk per-account local outbox folder for each
2820 (create_per_account_local_outbox_folders): Create a local outbox folder
2821 for each transport account.
2822 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2823 for all local folders.
2825 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2826 instead of using g_object_get/set() directly. It is clearer.
2828 (modest_tny_folder_store_get_message_count),
2829 (modest_tny_folder_store_get_local_size
2830 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2831 because we now use these with non-acount folder stores.
2833 (modest_tny_account_get_special_folder),
2834 (modest_tny_account_new_from_server_account),
2835 (modest_tny_account_new_from_account):
2836 (recurse_folders): Adjust to the new outbox system.
2838 * src/modest-tny-folder.h:
2839 * src/modest-tny-folder.c:
2840 (modest_tny_folder_is_local_folder),
2841 (modest_tny_folder_get_local_folder_type),
2842 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2844 * src/widgets/modest-main-window.h:
2845 * src/maemo/modest-main-window.c: (create_details_widget),
2846 (modest_main_window_set_contents_style): Show details for any folder store,
2849 (modest_tny_folder_get_rules):
2850 Remove the const. C does not support constness enough for this.
2852 * src/modest-ui-actions.c:
2853 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2854 make all outboxes appear as one, in the usual local-folders tree node.
2856 (set_active_account_from_tny_account),
2857 (modest_ui_actions_on_folder_selection_changed):
2858 * src/widgets/modest-folder-view.c: (text_cell_data),
2859 (icon_cell_data), (filter_row),
2860 (add_account_folders_to_merged_folder),
2861 (add_account_folders_to_simple_folder_store), (),
2862 (get_cmp_rows_type_pos), (cmp_rows),
2863 (modest_folder_view_set_account_id_of_visible_server_account):
2864 Adjust to the new outbox system, using generic folder stores and folders
2865 in the GtkTreeModel.
2867 2007-05-23 Christian Kellner <ckellner@openismus.com>
2869 * src/modest-mail-operation.c:
2870 (modest_mail_operation_update_account):
2871 Use info->max_size instead of unintialized local var [small
2872 build fix]. (Added TODO to review that change since I don't
2875 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2877 * libmodest-dbus-client/libmodest-dbus-client.c:
2878 (libmodest_dbus_client_compose_mail): function added
2879 * src/dbus_api/modest-dbus-api.h:
2880 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2881 (on_compose_mail): Implementation of the SendAsMail functionality
2883 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2885 * src/modest-account-mgr.c:
2886 (modest_account_mgr_add_server_account): Set the secure-connection
2887 conf key for transport accounts as well as store accounts. I don't know
2888 why the if was there. For instance, this makes sure that we use SSL
2889 for the gmail preset from the easysetup wizard.
2891 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2893 * src/gnome/modest-main-window.c:
2894 (on_account_store_connecting_finished), (connect_signals):
2895 * src/maemo/modest-main-window.c:
2896 (on_account_store_connecting_finished), (connect_signals),
2897 (modest_main_window_new):
2898 Handle TnyAccountStore::connecting-finished instead of
2899 TnyDevice::connection-changed, because we cannot actually perform
2900 operations on accounts until TnyAccountStore has itself responded to
2901 the TnyDevice::connection-changed signal. This prevents a GError from
2903 Do not try to update at startup, because we (at least on scratchbox)
2904 already do an update at startup when the device goes online.
2905 This prevents a GError from tinymail.
2906 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2907 Added TODO about stopping simultaneous operations.
2909 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2911 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2912 * src/modest-mail-operation-queue.c:
2913 (modest_mail_operation_queue_remove):
2914 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2915 about where they happened.
2917 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2919 * src/modest-ui-actions.c:
2920 (modest_ui_actions_on_password_requested): Make sure that the remember
2921 output parameter is always TRUE.
2923 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2925 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2926 Show a OK/Cancel dialog if the error is a question, though we still do not
2927 know anything more about what we are asking the user.
2928 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2929 Fix an uninitialized variable (helper). This is a logic error, however.
2931 2007-05-21 Christian Kellner <ckellner@openismus.com>
2933 * src/modest-search.h:
2934 Correct bit shifting in the ModestSearchFlags enum.
2936 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2938 * src/modest-tny-account.c:
2939 (modest_tny_account_new_from_server_account): Do not use the lsub and
2940 check-all hard-coded IMAP options when using POP.
2942 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2944 * src/modest-tny-account.c:
2945 (modest_tny_account_new_from_server_account):
2946 Use NULL for the secure-auth method for POP when Password auth has been
2947 specified by the user, as we already do for IMAP. "auth=Login" causes
2948 an error from camel or the server.
2950 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2952 * src/maemo/modest-account-settings-dialog.c:
2953 (create_page_account_details),
2954 (modest_account_settings_dialog_set_account_name):
2955 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2956 for the leave-on-server checkbox, rathr than just the checkbox, when
2957 the protocol is not POP.
2959 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2961 * src/widgets/modest-account-view.c:
2962 * src/widgets/modest-account-view.h:
2963 Added modest_account_view_select_account() which will be useful later
2964 to asynchronously re-select the edited account.
2966 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2968 * src/maemo/modest-account-settings-dialog.c:
2969 (modest_account_settings_dialog_set_account_name):
2970 Automatically choose the port numbers based on the secure authentication
2971 methods, if they have not been chosen before.
2972 This fixes projects.maemo.org bug NB#56273 .
2974 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2976 * src/maemo/modest-main-window-ui.h:
2977 * src/modest-ui-actions.c:
2978 * src/modest-ui-actions.h:
2979 Connect the Tools/SMTP Servers menu item to
2980 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2981 SMTP servers dialog, as in the UI specification and saves changes when it
2982 is closed. This fixed projects.maemo.org bug NB#56305 .
2984 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2986 * src/maemo/modest-connection-specific-smtp-window.c:
2987 (modest_connection_specific_smtp_window_init):
2988 Use gtk_window_set_default_size() to make this window big enough, so
2989 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2991 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2993 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2994 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2995 (modest_connection_specific_smtp_edit_window_init),
2996 Do not try to connect to a combobox signal before the combobox exists.
2997 This fixes the cras in projects.maemo.org bug NB#56288 .
2998 (modest_connection_specific_smtp_edit_window_get_settings):
2999 Remove the server_account_name parameter which was being checked for NULL
3000 though it was not used.
3002 * src/maemo/modest-connection-specific-smtp-window.c:
3003 (modest_connection_specific_smtp_window_fill_with_connections),
3004 (on_button_edit), (modest_connection_specific_smtp_window_init):
3005 Correct the number of treemodel columns to prevent a warning.
3006 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3007 libconic does not work.
3009 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3011 * src/modest-tny-account.c:
3012 (modest_tny_account_new_from_server_account):
3013 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3014 SMTP when "None" was chosen by the user. However, with my SMTP server that
3015 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3018 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3020 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3021 to explain the memory management issue with the ID in the ModestPair.
3023 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3024 (add_sending_page), (modest_account_assistant_finalize):
3025 * src/gnome/modest-gnome-global-settings-dialog.c:
3026 (create_updating_page), (create_composing_page):
3027 * src/gnome/modest-msg-edit-window.c: (get_transports),
3028 (init_window), (modest_msg_edit_window_finalize),
3029 (modest_msg_edit_window_get_msg_data):
3030 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3031 * src/gnome/modest-transport-widget.c:
3032 (modest_transport_widget_finalize), (smtp_configuration):
3033 * src/maemo/modest-maemo-global-settings-dialog.c:
3034 (create_updating_page), (create_composing_page):
3035 * src/maemo/modest-msg-edit-window.c: (get_transports),
3036 (init_window), (modest_msg_edit_window_finalize),
3037 (modest_msg_edit_window_get_msg_data),
3038 (modest_msg_edit_window_free_msg_data):
3039 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3040 (modest_store_widget_finalize):
3041 * src/maemo/modest-transport-widget.c:
3042 (modest_transport_widget_finalize), (smtp_configuration):
3043 * src/modest-main.c: (send_mail):
3044 * src/widgets/modest-combo-box.h:
3045 * src/widgets/modest-global-settings-dialog-priv.h:
3046 * src/widgets/modest-global-settings-dialog.c:
3047 (modest_global_settings_dialog_finalize):
3048 * src/widgets/modest-msg-edit-window.h:
3049 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3050 as long as the combo box, to prevent use of freed memory for the ID.
3052 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3054 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3055 get_accounts(), to make this clearer. Do not check for the enabled gconf
3056 key, because we do not use this for server accounts (at least, not yet).
3057 This allows us to send email again.
3059 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3061 * src/maemo/modest-platform.c:
3062 (on_modest_conf_update_interval_changed), (modest_platform_init):
3063 Only respond to this particular key change. All these strcmp()s cannot be
3066 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3068 * src/maemo/modest-maemo-global-settings-dialog.c:
3069 (current_connection): Prevent a crash in scratchbox when
3070 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3071 * src/maemo/modest-platform.c:
3072 (on_modest_conf_update_interval_changed), (modest_platform_init):
3073 Get the update interval from gconf and reset it when the gconf key changes.
3075 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3077 * src/modest-protocol-info.c:
3078 * src/modest-protocol-info.h: Adde enum-specific get functions,
3079 instead of using a ModestProtocolType enum parameter.
3081 * src/gnome/modest-account-assistant.c:
3082 * src/gnome/modest-store-widget.c:
3083 * src/gnome/modest-store-widget.h:
3084 * src/gnome/modest-transport-widget.c:
3085 * src/gnome/modest-transport-widget.h:
3086 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3087 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3088 * src/maemo/easysetup/modest-easysetup-wizard.c:
3089 * src/maemo/modest-account-settings-dialog.c:
3090 * src/maemo/modest-account-settings-dialog.h:
3091 * src/maemo/modest-store-widget.c:
3092 * src/maemo/modest-store-widget.h:
3093 * src/maemo/modest-transport-widget.c:
3094 * src/maemo/modest-transport-widget.h:
3095 * src/modest-account-mgr-helpers.c:
3096 * src/modest-account-mgr-helpers.h:
3097 * src/modest-account-mgr.c:
3098 * src/modest-account-mgr.h:
3099 * src/modest-tny-account.c:
3100 * src/modest-tny-folder.c:
3101 * src/widgets/modest-account-view.c:
3102 * src/widgets/modest-retrieve-combo-box.c:
3103 * src/widgets/modest-retrieve-combo-box.h:
3104 * src/widgets/modest-secureauth-combo-box.c:
3105 * src/widgets/modest-serversecurity-combo-box.c:
3106 * src/widgets/modest-serversecurity-combo-box.h:
3107 * tests/check_account-mgr.c:
3108 Use the specific functions, and use the re-renamed enum values for GNOME too.
3110 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3112 * src/modest-pair.h:
3113 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3114 so we can get the second based on the first.
3116 * src/maemo/modest-account-settings-dialog.h:
3117 * src/maemo/modest-account-settings-dialog.c:
3118 Added get_supported_secure_authentication_methods(), though it is mostly
3119 commented-out for now until the necessary API is committed to tinymail.
3120 (modest_account_settings_dialog_set_account_name),
3121 (save_configuration): Request the supported authentication methods from the
3122 server, so we can choose a working method.
3124 * src/modest-tny-account-store.h:
3125 * src/modest-tny-account-store.c:
3126 (modest_tny_account_store_get_session): Rename from
3127 tny_account_store_get_session().
3129 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3131 * src/modest-protocol-info.h: Split the ModestProtocol enum
3132 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3133 There was no need to have these unrelated values in one enum.
3135 * src/: many files: Adapted to changed enum. This makes the code a bit
3136 clearer, and the compiler could catch some errors.
3138 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3140 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3141 Show the detailed internal camel error message when an error happens
3142 during the configuration, so that our testers can give us more clues.
3143 For instance, in projects.maemo.org bug NB#56910 .
3145 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3147 * src/modest-tny-account.c:
3148 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3149 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3151 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3153 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3154 * src/maemo/modest-account-settings-dialog.c:
3155 (modest_account_settings_dialog_set_account_name),
3156 (save_configuration): For the incoming secure authentication checkbox,
3157 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3158 the UI specification. PLAIN does not seem to be supported for most IMAP
3159 servers anyway, and I am not sure what it would mean.
3160 However, we probably need to discover which of the secure-authentication
3161 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3162 * src/modest-account-mgr-helpers.c:
3163 (modest_account_mgr_get_server_account_data):
3165 * src/modest-tny-account.c:
3166 (modest_tny_account_new_from_server_account):
3167 Use tny_account_set_mech() to set secure-authentication methods,
3168 with some special-casing for IMAP, based on my observations of how
3171 * src/modest-account-mgr-helpers.h:
3172 * src/modest-account-mgr.c:
3173 * src/modest-defs.h: Comment that the URI is only used for local folders.
3175 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3177 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3178 parameter const, just to be neat.
3179 * src/modest-text-utils.c: (modest_text_utils_inline):
3180 End g_strconcat() with NULL, as its documentation says. This is almost
3181 certainly the cause of my crash at startup on the device. Interestingly,
3182 valgrind doesn't tell us about these errors.
3184 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3186 * scripts/build-packages: Added more precise comments about how to use
3187 this script, though I still get this error:
3188 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3189 error building tinymail
3191 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3193 * src/maemo/modest-main-window.c: (on_account_update):
3194 Very slight cleanup, hoping to make it simpler to discover what causes
3195 a crash here sometimes.
3197 * src/modest-tny-account.c:
3198 (modest_tny_account_new_from_server_account): Set the port. Added
3199 comments about the options and a TODO comment because I need to find out
3200 how to specify the secure authentication method.
3202 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3204 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3205 changed CFlags paths form modest to libmodest
3207 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3209 * src/modest-account-mgr-helpers.c:
3210 (modest_account_mgr_get_server_account_data),
3211 (modest_account_mgr_free_server_account_data):
3212 * src/modest-account-mgr-helpers.h:
3213 * src/modest-account-mgr.c:
3214 (modest_account_mgr_add_server_account):
3215 * src/modest-defs.h:
3216 * src/modest-tny-account.c:
3217 (modest_tny_account_new_from_server_account):
3218 Determine the options for tny_camel_account_add_option() here,
3219 based on the settings, rather than storing them directly in gconf.
3221 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3223 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3224 Show a more friendly error dialog now that we expect (from the tinymail
3225 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3227 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3229 * src/maemo/modest-main-window.c: (on_account_update): Check that
3230 account_name is not NULL, to prevent a crash at startup that I am
3231 seeing on the N800. I do wonder why it is NULL.
3233 * src/maemo/easysetup/modest-easysetup-wizard.c:
3234 (create_page_user_details):
3235 * src/maemo/modest-account-settings-dialog.c:
3236 (create_page_user_details), (create_page_outgoing):
3237 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3238 (modest_connection_specific_smtp_edit_window_init):
3239 * src/modest-ui-actions.c:
3240 (modest_ui_actions_on_password_requested):
3241 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3242 might do something useful with the on-screen keyboard.
3244 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3246 * src/maemo/modest-main-window.c: (on_account_update):
3247 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3248 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3250 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3252 * src/modest-tny-account-store.c: (on_account_changed):
3253 Correct the signature of this signal handler.
3255 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3257 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3258 Show a HildonNote instead of a GtkDialog for Maemo.
3260 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3262 * src/widgets/modest-account-view.h:
3263 * src/widgets/modest-account-view.c: (on_account_changed),
3264 (on_account_removed). Added a boolean flag, set/unset by
3265 modest_account_view_block_conf_updates(),
3266 modest_account_view_unblock_conf_updates() to prevent unnecessary
3267 updates, but this is not very useful because the gconf notifications are
3268 so delays (maybe only on Maemo Bora).
3269 So auto-updating is turned off, and these functions do an explicit
3270 update when necessary.
3271 However, something else is still doing too much work when adding/removing
3272 accounts, probably in another part of the application.
3274 * src/maemo/modest-account-view-window.c:
3275 (on_delete_button_clicked), (on_edit_button_clicked),
3276 (on_new_button_clicked): Use the new functions.
3278 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3280 * src/modest-account-mgr-helpers.c:
3281 (modest_account_mgr_set_first_account_as_default):
3282 Sort the list of names alphabetically-by-title, so we choose the first one
3284 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3285 alphabetically by the title.
3287 This fixes projects.maemo.org bug NB#56418 .
3289 * src/modest-account-mgr-priv.c:
3290 (_modest_account_mgr_account_from_key):
3291 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3292 avoid a valgrind error, and possible random behaviour.
3294 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3296 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3297 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3298 tinymail documentation to say that this can be expected.
3299 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3300 pretty, and should not happen, but I would prefer to know when it does.
3302 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3304 * configure.ac: When using the older hildon version, probably on Bora,
3305 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3307 * src/widgets/modest-attachment-view.c:
3308 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3311 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3313 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3314 Implemented the prototype. Can be tested with
3315 tests/dbus_api/test_open_message:
3317 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3319 * src/modest-tny-account-store.c:
3320 (modest_tny_account_store_instance_init), (get_password):
3321 * src/modest-ui-actions.c:
3322 (modest_ui_actions_on_password_requested):
3323 Do not store the password in gconf, because this function is called
3324 for non-remembered passwords. Actually use the cached (in the hash map)
3325 password instead of releasing it.
3326 The password will now not be remembered if it is asked via the protected
3327 password dialog, as per the UI spec.
3329 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3331 * src/modest-defs.h:
3332 * src/modest-account-mgr-helpers.h:
3333 * src/modest-account-mgr-helpers.c:
3334 Added modest_server_account_get_username_has_succeeded(),
3335 modest_server_account_set_username_has_succeeded().
3336 (modest_server_account_set_username),
3337 Reset the has-succeeded flag if the username changes.
3339 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3340 * src/maemo/modest-connection-specific-smtp-window.c:
3341 (modest_connection_specific_smtp_window_save_server_accounts):
3342 Use modest_server_account_set_username() instead of using
3343 modest_conf_set_string() directly, so that the has-succeeded flag is always
3346 * src/modest-ui-actions.c:
3347 (modest_ui_actions_on_password_requested): Dim the username entry if
3348 the username has ever worked, as per the UI spec.
3350 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3352 * src/modest-tny-account-store.c: (get_password):
3353 * src/modest-ui-actions.c:
3354 (modest_ui_actions_on_password_requested):
3355 Allow the username to be changed too, though there is more work to
3356 be done on exactly how this behaves.
3358 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3360 * src/modest-account-mgr-helpers.h:
3361 * src/modest-account-mgr-helpers.c:
3362 Added modest_account_mgr_get_display_name(),
3363 modest_server_account_get_username(),
3364 modest_server_account_set_username(),
3365 modest_server_account_set_password(),
3366 modest_server_account_get_hostname() functions so we do not need to
3367 use the conf API directly.
3369 * src/maemo/modest-main-window.c: (connect_signals):
3370 Actually connect ot the ModestAccountStore::request-password signal,
3371 so that we show the dialog when the password is requested by Tinymail,
3372 for isntance if it is empty.
3374 * src/modest-marshal.list:
3375 * src/modest-tny-account-store.c:
3376 (modest_tny_account_store_class_init), (get_password),
3377 (modest_tny_account_store_alert):
3378 * src/modest-tny-account-store.h:
3379 * src/modest-ui-actions.h:
3380 * src/modest-ui-actions.c:
3381 (modest_ui_actions_on_password_requested):
3382 Change the signal parameters, so it is obvious that we are providing
3383 the non human-readable server name, and receiving both the username
3384 and password, though changing of the username is not yet implemented.
3385 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3386 for the GNOME version.
3388 This should fix the projects.maemo.org bug NB#56209, though it does not
3389 work on Bora, because the gconf_client_get() for the password fails
3390 immediately after we save it with gconf_client_set().
3392 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3395 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3396 caused an undefined symbol error:
3397 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3399 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3401 * src/modest-tny-account-store.c:
3402 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3403 using a GError instead of a string message, so we can translate it in
3406 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3408 * src/maemo/modest-address-book.c:
3409 (modest_address_book_check_names):
3410 * src/maemo/modest-msg-view-window.c:
3411 (modest_msg_view_window_clipboard_owner_change):
3412 * src/modest-init.c: (modest_init_init_ui):
3413 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3414 (update_folders_cb), (modest_mail_operation_update_account):
3415 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3416 (modest_ui_actions_on_msg_attachment_clicked),
3417 (modest_ui_actions_on_msg_recpt_activated):
3418 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3419 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3420 (modest_msg_view_search_next):
3421 * src/widgets/modest-recpt-editor.c:
3422 (modest_recpt_editor_on_button_release_event),
3423 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3424 g_message(). At this point we should only be seeing interesting errors on
3425 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3427 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3429 (modest_wizard_dialog_force_title_update):
3430 * src/maemo/easysetup/modest-wizard-dialog.h:
3431 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3432 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3433 can update the title when appropriate. Otherwise the title is wrong if the
3434 pages are added after adding the notebook to the dialog.
3435 This must be a problem in HildonWizardDialog too.
3436 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3438 * src/maemo/easysetup/modest-easysetup-wizard.c:
3439 (create_subsequent_customsetup_pages),
3440 (create_subsequent_easysetup_pages):
3441 Call modest_wizard_dialog_force_title_update() so that the title is
3442 correct even with GTK+ < 2.10.
3443 This fixes projects.maemo.org bug NB#56145 .
3445 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3447 * src/maemo/modest-platform.c:
3448 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3449 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3452 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3454 * src/widgets/modest-window.h:
3455 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3456 and modest_window_save_state(), which invokes it.
3458 * src/widgets/modest-window-mgr.h:
3459 * src/widgets/modest-window-mgr.c:
3460 Added modest_window_mgr_save_state_for_all_windows(), which calls
3461 the save_state vfunc on all registered windows, if implemented.
3463 * src/gnome/modest-msg-edit-window.c:
3464 * src/gnome/modest-msg-view-window.c:
3465 * src/maemo/modest-msg-edit-window.c:
3466 * src/maemo/modest-msg-view-window.c:
3467 * src/maemo/modest-main-window.c:
3468 Specify the existing save_settings functions as implementations of
3469 ModestWindow::save_state_func().
3471 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3472 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3473 enabling hibernation, for instance.
3475 We may need to do the same thing for restoring settings.
3478 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3480 * src/widgets/modest-window-mgr.c:
3481 * src/widgets/modest-window-mgr.h:
3482 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3483 modest_window_mgr_get_hibernation_is_prevented().
3485 * src/maemo/modest-main-window.c:
3486 (on_hildon_program_is_topmost_notify): Prevent hibernation
3487 (possible when the application goes to the background in the WM),
3488 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3490 * src/maemo/easysetup/modest-easysetup-wizard.c:
3491 (modest_easysetup_wizard_dialog_init):
3492 * src/maemo/modest-account-settings-dialog.c:
3493 (modest_account_settings_dialog_init):
3494 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3495 (modest_connection_specific_smtp_edit_window_init):
3496 * src/maemo/modest-connection-specific-smtp-window.c:
3497 (modest_connection_specific_smtp_window_init):
3498 * src/maemo/modest-signature-editor-dialog.c:
3499 (modest_signature_editor_dialog_init):
3500 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3501 prevent hibernation while any of these account settings dialogs are open.
3503 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3505 * src/maemo/Makefile.am:
3506 * src/maemo/modest-osso-state-saving.c:
3507 * src/maemo/modest-osso-state-saving.h: Added
3508 modest_osso_load_state() and modest_osso_save_state() though they do
3509 nothing now. They should iterate through all the open windows and load/save
3511 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3512 save state when closing.
3514 * src/maemo/modest-main-window.c:
3515 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3516 Add a notification handler for the HildonProgram::is-topmost property,
3517 so we can allow hibernation when the application goes into the background.
3518 But we still need to detect when the accounts setup windows are open so
3519 we can stop hibernation when they are open.
3520 To do this, I also added the main window the HildonProgram. This might have
3521 other side-effects/benefits, and should maybe be done for other windows.
3523 * src/maemo/modest-osso-autosave-callbacks.h:
3524 * src/maemo/modest-osso-autosave-callbacks.c:
3525 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3526 though it does not do anything yet, and we might never need this to do
3527 anything. For instance, we already save drafts.
3529 * src/maemo/modest-platform.c: (modest_platform_init):
3530 Specify the libosso auto-save callback.
3532 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3534 * src/maemo/modest-platform.c:
3535 (modest_platform_set_update_interval):
3536 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3537 aparently stays valid between application instances, so we can use this
3538 to remove and reset it later. According to a maemo-developers email from
3541 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3543 * configure.ac: Depend on libalarm for Maemo.
3545 * src/dbus_api/modest-dbus-api.h:
3546 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3547 (on_send_receive), (modest_dbus_req_handler):
3548 Handle a SEND_RECEIVE D-Bus method.
3550 * libmodest-dbus-client/libmodest-dbus-client.c:
3551 (libmodest_dbus_client_send_and_receive):
3552 * libmodest-dbus-client/libmodest-dbus-client.h:
3553 Add C convenience functions for calling the new D-Bus method.
3555 * src/modest-platform.h:
3556 * src/gnome/modest-platform.c:
3557 * src/maemo/modest-platform.c:
3558 Added modest_platform_set_update_interval(), which uses the
3559 alarmd API on Maemo.
3560 (modest_platform_init),
3561 Call modest_platform_set_update_interval(), using a hard-coded
3562 interval for now (until the global settings dialog is implemented),
3563 though I am not sure that this makes sense yet.
3565 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3567 * src/dbus_api/modest-dbus-callbacks.c:
3568 (modest_osso_cb_hw_state_handler):
3569 * src/dbus_api/modest-dbus-callbacks.h:
3570 * src/maemo/modest-platform.c: (modest_platform_init):
3571 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3572 in case this has some effect on the ability for Maemo to ping the
3575 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3577 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3578 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3579 warning. It is probably a logic error, but I need to fix the build.
3581 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3583 * src/modest-account-mgr.h:
3584 * src/modest-account-mgr.c:
3585 (modest_account_mgr_account_names): Add a gboolean enabled_only
3586 parameter, so we can get lists of onlt the enabled accounts.
3588 (modest_account_mgr_add_account),,
3589 (modest_account_mgr_account_with_display_name_exists):
3590 * src/maemo/modest-msg-edit-window.c: (get_transports):
3591 * src/modest-account-mgr-helpers.c:
3592 (modest_account_mgr_set_first_account_as_default):
3593 * src/modest-init.c: (init_default_account_maybe):
3594 * src/modest-tny-account-store.c: (get_accounts):
3595 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3596 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3597 * tests/check_account-mgr.c: (START_TEST):
3598 Provide the extra parameter, as appropriate.
3600 * src/widgets/modest-account-view.c: (update_account_view):
3601 Do not show disabled accounts (meaning that there is no way to
3602 enable/disable accounts in the UI (the feature is not in our UI
3603 specification), so we can use this internally only to mark unfinished
3604 or temporary account data.
3606 * src/maemo/easysetup/modest-easysetup-wizard.c:
3607 (create_account): Add boolean enable parameter, so we can specify FALSE
3608 to create the temporary account.
3609 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3610 (on_before_next): When finishing, when there is a temporary account, just
3612 Also, use a timeout to delay the showing of the dialog until gconf is likely
3613 to return correct information, due to a maemo gconf bug that is fixed in
3614 osso 1.1, but not yet in Bora.
3615 However, the dialog stays on screen after it is destroyed.
3617 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3618 for invalid data when cancelling. Use a hildon note instead of a dialog
3619 to complain about invalid data. Do not show the account-saved note if the
3620 account is disabled (a temporary account that will not really be saved for use
3623 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3625 * src/modest-account-mgr-helpers.h:
3626 * src/modest-account-mgr-helpers.c:
3627 Added modest_account_mgr_unset_default_account(),
3628 Added modest_account_mgr_set_first_account_as_default().
3630 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3631 If it was the default account, unset the default account name.
3633 * src/maemo/modest-account-view-window.c:
3634 (on_delete_button_clicked): If it was the default account,
3635 set the first remaining account as the default instead.
3637 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3638 a NULL account or a NULL default account, to prevent a crash. This should
3639 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3642 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3644 * src/widgets/modest-recpt-editor.c:
3645 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3646 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3647 TODO comment for this. This fixes the build.
3649 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3650 be the best place for it. This will in future update all auto-update accounts,
3651 rather than just the current/default account, when that gconf key exists.
3652 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3653 if there are no accounts, before calling do_send_receive().
3654 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3656 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3657 * src/maemo/modest-main-window-ui.h:
3658 * src/maemo/modest-main-window.c: (on_connection_changed),
3659 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3660 directly, becaue the signal handler does more.
3662 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3664 * src/modest-account-mgr-helpers.c:
3665 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3666 for the case that the account does not exist.
3668 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3669 (equivalent to the modest account name) rather than the tinymail account name
3670 (equivalent to the modest account title - human readable) to get the account data.
3671 Check for null account data to prevent the crash, and add a TODO comment saying that
3672 this needs fixing because it is using the server account name instead of the account name.
3674 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3676 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3677 * src/maemo/modest-account-settings-dialog.c: (show_error),
3679 Use hildon_note_new_information() for informative and error messages,
3680 which seems to be expected for Maemo applications (no documentation that I know of
3681 says this). I am surprised that there is no distinction between info and error
3684 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3686 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3687 it is easy to find where this is used.
3689 * src/maemo/easysetup/modest-easysetup-wizard.c:
3690 (create_page_welcome), (create_page_account_details),
3691 (create_page_user_details), (create_page_complete_easysetup),
3692 (create_page_custom_incoming), (create_page_custom_outgoing),
3693 (create_page_complete_custom):
3694 * src/maemo/modest-account-settings-dialog.c:
3695 (create_page_account_details), (create_page_user_details),
3696 (create_page_incoming), (create_page_outgoing):
3697 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3698 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3699 (modest_connection_specific_smtp_edit_window_init):
3700 * src/maemo/modest-connection-specific-smtp-window.c:
3701 (modest_connection_specific_smtp_window_init):
3702 * src/maemo/modest-signature-editor-dialog.c:
3703 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3704 and scrolling policy as per the Email Application Layout Guide, if I have
3707 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3709 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3710 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3711 which were empty, because these vfuncs have been removed from TnyAccountStore.
3712 This fixes the build.
3714 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3716 * src/maemo/modest-main-window.c:
3717 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3718 showing/hiding it. Added TODO because it probably should not be NULL.
3719 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3720 because unnecessary g_warnings() make degugging difficult.
3722 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3724 * src/maemo/modest-msg-edit-window.c:
3725 (modest_msg_edit_window_select_color),
3726 (modest_msg_edit_window_select_background_color): 2 const corrections and
3727 moving 2 #endifs before closing brackets, to fix the build.
3729 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3731 * src/maemo/easysetup/modest-easysetup-wizard.h:
3732 * src/maemo/easysetup/modest-easysetup-wizard.c:
3733 (modest_easysetup_wizard_dialog_finalize),
3734 (on_button_edit_advanced_settings), (create_page_complete_custom),
3735 (on_response), (create_account):
3736 Implement the Advanced Settings edit button, by saving the account information,
3737 for the Advanded Settings dialog to use directly from gconf, and removing it
3738 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3739 Bug #5533 in the projects.maemo.org bugzilla.
3741 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3743 * src/maemo/modest-msg-view-window.c:
3744 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3745 when opening a message window.
3747 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3749 * src/maemo/easysetup/modest-easysetup-wizard.c:
3750 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3753 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3754 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3755 gconf settings. I probably added more checks than necessary, but that is safer.
3757 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3758 variable to fix the build, but this seems to be used when it is still NULL.
3760 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3762 * src/modest-platform.h:
3763 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3764 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3765 * src/modest-main.c: Implement this function so we can avoid using
3766 maemo-specific API from cross-platform code.
3768 * src/modest-tny-account-store.c:
3769 (get_smtp_specific_transport_account_for_open_connection):
3770 * src/modest-ui-actions.c: (check_for_connection),
3771 (modest_ui_actions_on_item_not_found):
3772 Use modest_platform_connect_and_wait() and put #idefs around other
3773 maemo-specific code, because only maemo currently has a way to
3774 identify connection names.
3776 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3778 * src/modest-tny-account-store.h:
3779 * src/modest-tny-account-store.c:
3780 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3781 the connection-specific SMTP server settings in the configuration.
3783 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3785 * src/maemo/modest-main-window.c: (on_connection_changed),
3787 * src/modest-main.c: (main), (start_ui), (send_mail):
3788 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3789 that is what is intended.
3791 * src/modest-ui-actions.c: (action_send), (action_receive),
3792 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3793 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3794 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3795 SMTP server is used when it is specified.
3797 (modest_ui_actions_on_send_receive):
3798 Check that a connection is open before proceeding.
3799 Receive and then send, instead of vice-versa, as per the specification.
3801 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3803 * src/modest-mail-operation.c:
3804 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3805 though I guess it should be something other than NULL.
3807 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3809 * src/maemo/easysetup/modest-easysetup-wizard.c:
3810 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3811 combo twice, to avoid an g_warning and to make it visible again.
3812 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3813 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3814 (already intended) dereference when detaching, because we then recreate the menu.
3815 But I am not sure why the warning was happening, and it is possible that this is a memory
3818 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3820 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3821 and uri_parse_mailto() utility functions.
3822 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3824 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3826 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3828 * src/dbus_api/modest-dbus-api.h:
3829 * src/dbus_api/modest-dbus-callbacks.c:
3830 Use an idle callback to execute the modest code in the application's own thread.
3831 Remove the helloworld example method.
3832 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3833 parsed, and the open-message method is not implemented because this is not yet implemented in
3835 * libmodest-dbus-client/libmodest-dbus-client.c:
3836 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3837 (libmodest_dbus_client_open_message):
3838 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3840 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3841 body without crashing.
3843 * tests/dbus_api/Makefile.am:
3844 * tests/dbus_api/test_mail_to.c:
3845 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3847 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3849 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3850 Added file to fix the build. Sorry.
3852 * src/dbus_api/Makefile.am:
3853 * src/dbus_api/modest-dbus-api.h:
3854 * src/dbus_api/modest-dbus-callbacks.h:
3855 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3856 (modest_dbus_req_handler):
3857 Put constants in a separate header so it can be reused by the
3858 client library, without duplication
3860 * libmodest-dbus-client/Makefile.am:
3861 * libmodest-dbus-client/libmodest-dbus-client.c:
3862 (libmodest_dbus_client_call_helloworld),
3863 (libmodfest_dbus_client_send_mail),
3864 (libmodfest_dbus_client_mailto),
3865 (libmodfest_dbus_client_open_message):
3866 * libmodest-dbus-client/libmodest-dbus-client.h:
3867 (Partly) Implement a send_mail D-Bus method.
3869 * tests/dbus_api/Makefile.am:
3870 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3871 the send_email D-Bus method.
3873 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3877 * libmodest-dbus-client/Makefile.am:
3878 * libmodest-dbus-client/libmodest-dbus-client.c:
3879 * libmodest-dbus-client/libmodest-dbus-client.h:
3880 * tests/dbus_api/Makefile.am:
3881 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3882 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3884 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3886 * src/maemo/easysetup/modest-easysetup-wizard.c:
3887 (create_page_account_details):
3888 * src/maemo/modest-account-settings-dialog.c:
3889 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3890 widgets, because this might not be the default in future versions of the Maemo GTK+.
3891 However, I can not not get capitalization to work even in a simple test case.
3893 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3895 * src/maemo/easysetup/modest-easysetup-wizard.c:
3896 (create_page_custom_incoming), (create_page_custom_outgoing):
3897 * src/maemo/modest-account-settings-dialog.c:
3898 (create_page_account_details), (create_page_incoming),
3899 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3900 instead of using gtk_check_button_with_label(), so they are aligned like the other
3901 widgets, as per the UI spec.
3903 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3905 * src/maemo/easysetup/modest-easysetup-wizard.c:
3906 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3907 * src/widgets/modest-validating-entry.c:
3908 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3909 Modest prefix instead of an EasySetup prefix.
3911 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3913 * src/widgets/modest-validating-entry.h:
3914 * src/widgets/modest-validating-entry.c: (on_insert_text),
3915 Added easysetup_validating_entry_set_max_func(), used to set a callback
3916 to call when the max number of characters is reached. GtkEntry has a max-length
3917 already but is silent about it.
3919 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3920 (create_page_account_details), (create_page_user_details),
3922 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3923 (create_page_account_details), (create_page_user_details),
3924 (create_page_outgoing):
3925 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3926 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3927 the UI spec, when the user tries to enter more than the max number of characters.
3929 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3931 * src/maemo/easysetup/modest-easysetup-wizard.c:
3932 (create_page_user_details), (create_page_custom_incoming),
3933 (create_page_custom_outgoing):
3934 * src/maemo/modest-account-settings-dialog.c:
3935 (create_page_user_details), (create_page_incoming),
3936 (create_page_outgoing):
3937 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3938 (modest_connection_specific_smtp_edit_window_init):
3939 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3940 not appropriate. Bad Maemo-specific defaults!.
3942 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3944 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3945 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3946 (modest_signature_editor_dialog_set_settings):
3947 Disable the label and textview when the checkbox is disabled, and use the
3948 specified (UI spec) default signature text.
3950 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3952 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3953 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3955 * src/modest-defs.h:
3956 * src/modest-account-mgr-helpers.h:
3957 * src/modest-account-mgr-helpers.c:
3958 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3960 * src/maemo/Makefile.am:
3961 * src/maemo/modest-signature-editor-dialog.c:
3962 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3965 * src/maemo/modest-account-settings-dialog.h:
3966 * src/maemo/modest-account-settings-dialog.c:
3967 (modest_account_settings_dialog_finalize), (on_button_signature),
3968 (save_configuration): Use the new dialog when the Edit button is pressed, and
3969 save the changes if necessary, as per the UI spec.
3971 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3973 * src/maemo/Makefile.am:
3974 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3975 based on maemo-develoers email from Dirk.
3977 * src/maemo/easysetup/modest-easysetup-wizard.c:
3978 (create_page_welcome), (create_page_account_details),
3979 (create_page_user_details), (create_page_complete_easysetup),
3980 (create_page_custom_incoming), (create_page_custom_outgoing),
3981 (create_page_complete_custom),
3982 (modest_easysetup_wizard_dialog_init):
3983 * src/maemo/modest-account-settings-dialog.c:
3984 (create_page_account_details), (create_page_user_details),
3985 (create_page_incoming), (create_page_outgoing),
3986 (modest_account_settings_dialog_init):
3987 * src/maemo/modest-connection-specific-smtp-window.c:
3988 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3990 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3992 * src/maemo/easysetup/modest-easysetup-wizard.c:
3993 (create_page_account_details), (create_page_custom_outgoing),
3994 (create_page_complete_custom):
3995 * src/maemo/modest-account-settings-dialog.c:
3996 (create_page_user_details), (create_page_incoming),
3997 (create_page_outgoing):
3998 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3999 (modest_connection_specific_smtp_edit_window_init):
4000 Use the correct (UI spec) port min/max, and use horizontal separators,
4003 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4005 * src/maemo/easysetup/modest-easysetup-wizard.c:
4006 (set_default_custom_servernames):
4007 * src/maemo/modest-account-settings-dialog.c:
4008 (create_page_incoming), (on_combo_outgoing_security_changed),
4009 (on_combo_incoming_security_changed), (create_page_outgoing),
4010 (modest_account_settings_dialog_set_account_name),
4011 (save_configuration):
4012 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4013 (on_combo_security_changed),
4014 (modest_connection_specific_smtp_edit_window_init),
4015 (modest_connection_specific_smtp_edit_window_set_connection),
4016 (modest_connection_specific_smtp_edit_window_get_settings):
4017 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4020 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4023 * src/maemo/easysetup/modest-easysetup-wizard.c:
4024 (create_page_custom_outgoing), (create_page_complete_custom):
4025 * src/maemo/modest-account-settings-dialog.c:
4026 (create_page_user_details), (create_page_outgoing):
4027 * src/maemo/modest-account-view-window.c: (button_box_new):
4028 Use changed logical IDs as per the most recent UI spec:
4029 mcen_bd_emailsetup_edit -> mcen_bd_edit
4030 mcen_bd_emailsetup_delete -> mcen_bd_delete
4031 mcen_bd_emailsetup_close -> mcen_bd_close
4033 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4037 * src/dbus_api/Makefile.am:
4038 * src/dbus_api/modest-dbus-callbacks.c:
4039 * src/dbus_api/modest-dbus-callbacks.h:
4040 * src/maemo/modest-platform.c: (modest_platform_init):
4041 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4043 * tests/Makefile.am:
4044 * tests/dbus_api/Makefile.am:
4045 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4047 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4049 * src/maemo/modest-account-settings-dialog.c:
4050 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4051 Removed unnecessary includes.
4053 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4055 * src/maemo/easysetup/modest-easysetup-wizard.c:
4056 * src/maemo/modest-account-settings-dialog.c:
4057 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4058 * src/widgets/Makefile.am:
4059 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4060 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4061 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4062 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4063 * src/widgets/modest-secureauth-combo-box.c:
4064 * src/widgets/modest-secureauth-combo-box.h:
4065 * src/widgets/modest-serversecurity-combo-box.c:
4066 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4067 made the GObject names more consistent with the rest of the Modest code.
4069 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4071 * src/maemo/easysetup/Makefile.am:
4072 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4073 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4074 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4075 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4076 * src/maemo/easysetup/modest-easysetup-wizard.c:
4077 * src/maemo/easysetup/modest-validating-entry.c:
4078 * src/maemo/easysetup/modest-validating-entry.h:
4079 * src/maemo/modest-account-settings-dialog.c:
4080 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4081 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4082 widgets/ because they are used outside of easysetup too. After checking in,
4083 svn will allow me to rename them too.
4085 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4087 * src/gnome/modest-msg-edit-window.c:
4088 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4089 linker error, to fix the build on the GNOME platform.
4090 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4091 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4092 ifdefed out to avoid a warning.
4094 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4096 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4097 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4098 some alternative for GTK+ 2.6.
4100 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4102 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4104 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4105 specified for EmailAccountsDialog in UI spec.
4107 * src/maemo/easysetup/modest-easysetup-wizard.c:
4108 * src/maemo/easysetup/modest-easysetup-wizard.h:
4109 * src/maemo/modest-account-settings-dialog.c:
4110 * src/maemo/modest-account-settings-dialog.h:
4111 Reuse a member window widget for the connection-specific SMTP server accounts,
4112 so we can tell it to create/save the accounts only if we actually save changes.
4114 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4115 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4116 (modest_connection_specific_smtp_edit_window_get_settings):
4117 Return a struct instance for temporarily remembering the entered data.
4119 * src/maemo/modest-connection-specific-smtp-window.h:
4120 * src/maemo/modest-connection-specific-smtp-window.c:
4121 (modest_connection_specific_smtp_window_finalize),
4122 (modest_connection_specific_smtp_window_fill_with_connections),
4124 (modest_connection_specific_smtp_window_save_server_accounts),
4125 (update_model_server_names): Do not actually save data until asked,
4126 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4128 (on_selection_changed),
4129 (modest_connection_specific_smtp_window_init): Disable the edit
4130 button when nothing is selected.
4132 * src/modest-account-mgr-helpers.c:
4133 * src/modest-account-mgr-helpers.h:
4134 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4137 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4139 * src/modest-account-mgr-helpers.h:
4140 * src/modest-account-mgr-helpers.c:
4141 (modest_account_mgr_get_unused_account_name),
4142 (modest_account_mgr_get_unused_account_display_name): Added these
4143 utility functions, to avoid code duplication.
4145 * src/maemo/easysetup/modest-easysetup-wizard.c:
4146 (create_page_account_details), (create_account):
4147 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4148 (on_combo_security_changed),
4149 (modest_connection_specific_smtp_edit_window_init),
4150 (modest_connection_specific_smtp_edit_window_save_settings):
4151 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4152 * src/maemo/modest-connection-specific-smtp-window.c:
4153 (modest_connection_specific_smtp_window_finalize),
4154 (modest_connection_specific_smtp_window_fill_with_connections),
4155 (on_button_edit), (modest_connection_specific_smtp_window_init):
4156 * src/maemo/modest-connection-specific-smtp-window.h:
4157 Implementing saving of connection-specific server accounts.
4159 But I need to refactor this so we can save the data for each
4160 possible connection-specific account and only actually create the server accounts
4161 when the easysetup finished, or the OK button is pressed on the account settings
4164 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4166 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4167 (on_combo_security_changed):
4168 (modest_connection_specific_smtp_edit_window_init):
4169 Auto-fill the port number as in the account settings.
4171 (modest_connection_specific_smtp_edit_window_set_connection):
4172 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4173 * src/maemo/modest-connection-specific-smtp-window.c:
4174 (fill_with_connections), (on_button_edit),
4175 (modest_connection_specific_smtp_window_init):
4176 Turn the edit window into a dialog to simplify the code, and
4177 set a WM hint as in a GtkDialog, because only a popup can be on top of
4178 another window in Maemo, and popups usually have no WM decoration.
4180 * src/modest-defs.h:
4181 * src/modest-account-mgr-helpers.c:
4182 (modest_account_mgr_set_connection_specific_smtp),
4183 (modest_account_mgr_remove_connection_specific_smtp),
4184 (modest_account_mgr_get_connection_specific_smtp):
4185 * src/modest-account-mgr-helpers.h: Some functions to write the
4186 connection-specific SMTP server information. Not yet used.
4189 * src/widgets/modest-folder-view.c: (text_cell_data):
4190 Fix a warning about an uninitialized variable.
4191 (on_configuration_key_changed): Put an #ifdef around the use
4192 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4194 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4196 * src/maemo/modest-account-settings-dialog.h:
4197 * src/maemo/modest-account-settings-dialog.c:
4198 Added connect_for_modified() utility function to mark the new modified boolean.
4200 (create_page_account_details), (create_page_user_details),
4201 (create_page_incoming), (create_page_outgoing), (on_response),
4202 (modest_account_settings_dialog_init),
4203 (modest_account_settings_dialog_set_account_name):
4204 Only warn about unsaved changes when there are actually unsaved changes.
4206 * src/modest-account-mgr-helpers.c:
4207 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4208 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4209 to get the data from there in future.
4211 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4213 * src/modest-defs.h:
4215 * src/modest-account-mgr-helpers.h:
4216 * src/modest-account-mgr-helpers.c:
4217 Store the security account setting in a single conf key instead of using
4218 the options list, so that the list is left for just the to-be-removed camel hack,
4219 and because gconf_client_set_list() is failing for some reason.
4221 * src/modest-account-mgr.c:
4222 (modest_account_mgr_add_server_account):
4223 * src/maemo/modest-account-settings-dialog.c:
4224 (modest_account_settings_dialog_set_account_name),
4225 (save_configuration): Use the renamed functions.
4228 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4230 * src/widgets/Makefile.am:
4231 * src/widgets/modest-limit-retrieve-combo-box.c:
4232 * src/widgets/modest-limit-retrieve-combo-box.h:
4233 * src/widgets/modest-retrieve-combo-box.c:
4234 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4235 the account settings dialog.
4237 * src/modest-defs.h:
4238 * src/modest-account-mgr-helpers.h:
4239 * src/modest-account-mgr-helpers.c:
4240 (modest_server_account_get_option_secure_auth),
4241 (modest_server_account_set_option_secure_auth):
4242 * src/modest-account-mgr.c:
4243 (modest_account_mgr_add_server_account):
4244 Use the existing AUTH_MECH conf key for the secure-auth setting,
4245 instead of putting it in the list options, because this was actually used already.
4247 * src/maemo/modest-account-settings-dialog.c:
4248 (create_page_account_details),
4249 (modest_account_settings_dialog_set_account_name),
4250 (save_configuration):
4251 * src/maemo/modest-account-settings-dialog.h:
4252 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4253 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4255 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4257 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4258 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4259 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4261 * src/modest-defs.h:
4262 * src/maemo/modest-account-settings-dialog.c:
4263 (create_page_incoming), (on_combo_outgoing_security_changed),
4264 (on_combo_incoming_security_changed), (create_page_outgoing),
4265 (modest_account_settings_dialog_set_account_name),
4266 (save_configuration): Load/Save the port number, and change it when the
4267 security combo changes, to suitable defaults.
4269 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4271 * src/modest-account-mgr.c:
4272 (modest_account_mgr_add_server_account): Set the security and secure-auth
4273 options, and add a comment saying that the other camel-specific options should be
4276 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4278 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4280 * src/modest-tny-account-store.c: (account_list_free),
4281 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4282 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4285 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4287 * src/modest-protocol-info.c:
4288 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4289 is required by our UI spec. Maybe something in our implementation will use this eventually.
4290 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4291 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4292 instead of the previous 0 placeholder.
4294 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4295 secure-auth settings.
4296 * src/modest-account-mgr-helpers.h:
4297 * src/modest-account-mgr-helpers.c:
4298 (modest_server_account_data_get_option_secure_auth),
4299 (modest_server_account_set_option_secure_auth),
4300 (modest_server_account_data_get_option_security),
4301 (modest_server_account_set_option_security): Added this API for getting and setting the security
4302 and secure-auth settings.
4304 * src/maemo/modest-account-settings-dialog.h:
4305 * src/maemo/modest-account-settings-dialog.c:
4306 (modest_account_settings_dialog_finalize), (check_data),
4307 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4308 about changing titles.
4309 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4310 (save_configuration): Save the security and secure-auth settings.
4312 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4313 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4315 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4317 * src/modest-defs.h:
4318 * src/modest-account-mgr.c:
4319 (modest_account_mgr_add_server_account):
4320 Added and used defines for the options key and value pair strings,
4321 that are used so far, though they do not seem to correspond to anything in our
4322 UI specs or ModestProtocol enum.
4324 * src/modest-account-mgr-helpers.h:
4325 * src/modest-account-mgr-helpers.c:
4326 (compare_option_strings_for_name),
4327 (modest_server_account_data_get_option_value),
4328 (modest_server_account_data_get_option_bool),
4329 (modest_account_mgr_get_server_account_option):
4330 Added helper functions for parsing the options GSList.
4332 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4334 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4335 display name is based on the supplied account name.
4336 * src/modest-account-mgr.c:
4337 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4338 with an inefficient, but good-enough, implementation.
4340 * src/maemo/easysetup/modest-easysetup-wizard.c:
4341 (create_page_account_details), (on_before_next), (create_account):
4342 Check for existing display names rather than (non-user-visible) account names, and just
4343 create and set a unique account name at the end.
4345 * src/maemo/modest-account-settings-dialog.c:
4346 (modest_account_settings_dialog_init),
4347 (modest_account_settings_dialog_set_account_name),
4348 (create_page_incoming): Show the display name, instead of the account name.
4349 (on_response): Do some (not all) extra checks, as in the UI spec.
4350 (save_configuration): Save the display name if it was changed.
4352 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4354 * po/en_GB.po: Added needed logical ID and translation.
4355 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4356 (init_view): Made the is-default column clicking work.
4358 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4361 * src/maemo/easysetup/Makefile.am:
4362 * src/maemo/easysetup/modest-easysetup-wizard.c:
4363 (modest_easysetup_wizard_dialog_init):
4364 * src/maemo/easysetup/provider-data-test.keyfile:
4365 * src/maemo/easysetup/provider-data.keyfile:
4366 Moved the provider data file to the new modest-providers-data package and used it from there.
4368 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4370 * src/modest-local-folder-info.c:
4371 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4372 N_() was already used on the static strings, but this just marks it for translation without
4373 using the translation.
4375 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4377 * src/maemo/modest-account-settings-dialog.c:
4378 (create_page_incoming),
4379 (modest_account_settings_dialog_set_account_name):
4380 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4381 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4382 I will do this if nobody else gets there first.
4384 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4386 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4387 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4388 save the security stuff.
4390 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4392 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4393 Set the email address and user fullname, which I now see must be
4396 * src/maemo/modest-account-settings-dialog.h:
4397 * src/maemo/modest-account-settings-dialog.c:
4399 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4400 leave-on-server and authentication.
4401 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4404 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4407 * src/maemo/modest-account-settings-dialog.c:
4408 * src/maemo/modest-account-settings-dialog.h:
4409 Most (but not all) of the widgets are now present as specified by the UI spec.
4410 No changes are yet saved, and some details are not properly shown yet.
4412 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4414 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4416 * src/maemo/Makefile.am:
4417 * src/maemo/modest-account-settings-dialog.c:
4418 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4419 an existing account. Doesn't do much yet.
4421 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4422 Open the accounts settings dialog when Edit is clicked.
4424 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4426 * src/maemo/easysetup/Makefile.am:
4427 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4429 * src/maemo/easysetup/modest-easysetup-wizard.c:
4430 (modest_easysetup_wizard_dialog_init):
4431 Try to get the source directory from the build system,
4432 instead of hard-coding "./" into the source code, when opening our local
4433 copies of the configuration files.
4434 But this still fails when opening the wizard from the Accounts window,
4435 maybe because the working directory seems to change at runtime.
4436 So the wizard will fail the second time unless you copy the files into their
4437 proper locations - see the stdout warnings for the paths.
4439 (create_page_account_details),(on_before_next):
4440 Check for existing non-server accounts instead of server accounts,
4441 so the default account name is useful again, and to prevent trying to
4444 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4445 Show the wizard when New is clicked.
4447 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4448 (init_view): Show the column headers, and show the columns that are
4449 specified in the UI specs. However, something in Maemo's GTK+ prevents
4450 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4451 change the default account. This is despite unsetting the special properties.
4453 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4455 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4456 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4457 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4458 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4459 to make that clearer.
4460 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4462 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4464 * src/maemo/modest-account-view-window.c:
4465 (modest_account_view_window_init),
4466 (modest_account_view_window_new):
4467 Use the same buttons as specified in the
4468 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4469 the existing widgets, which never had a chance of working.
4470 Put the ModestAccountView treeview in a scrolled window.
4471 Do not repeat the initialization in both _init() and _new().
4473 * src/widgets/modest-account-view.c: (update_account_view):
4474 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4475 this widget and window shows no accounts.
4477 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4479 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4481 * src/maemo/easysetup/modest-easysetup-wizard.c:
4482 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4483 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4484 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4487 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4488 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4489 accounts exist yet, as in the UI spec.
4491 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4493 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4495 * src/maemo/Makefile.am:
4496 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4497 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4498 New window for editing connection-specific smtp details.
4499 Not fully implemented.
4501 * src/maemo/modest-connection-specific-smtp-window.c:
4502 (modest_connection_specific_smtp_window_finalize) :
4503 unref the tree model.
4504 (on_button_edit): Show the edit window.
4506 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4508 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4511 * src/maemo/Makefile.am:
4512 * src/maemo/modest-connection-specific-smtp-window.c:
4513 * src/maemo/modest-connection-specific-smtp-window.h:
4514 New window for showing the list of connections, for connection-specific
4515 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4516 * src/maemo/easysetup/modest-easysetup-wizard.c:
4517 (create_page_custom_outgoing): Show the new window when the button is clicked.
4519 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4521 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4522 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4523 * src/maemo/modest-msg-edit-window.c:
4524 (modest_msg_edit_window_insert_image):
4525 * src/modest-conf.c: (modest_conf_key_escape):
4526 * src/modest-mail-operation.c:
4527 (modest_mail_operation_send_new_mail):
4528 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4529 (modest_ui_actions_on_new_account):
4530 * src/widgets/modest-attachment-view.c: (update_filename_request):
4531 * src/widgets/modest-mail-header-view.c:
4532 Corrected warnings that were breaking the build, by commenting out unused variables,
4533 and a function, and by including a header.
4535 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4537 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4538 so we can #ifdef around platform-specific code when necessary.
4539 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4540 to allow this to build for the GNOME platform too.
4542 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4544 * src/maemo/easysetup/modest-easysetup-wizard.c:
4545 Added util_increment_name() and used it in create_page_account_details()
4546 to make sure that the default account name is always a new name.
4548 (modest_easysetup_wizard_dialog_init),
4549 (set_default_custom_servernames): Some minor memory management fixes.
4551 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4555 * src/modest-runtime.c: (init_i18n): Restored the translation
4556 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4557 are defined in config.h, and the translations are installed.
4559 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4560 is defined for translation.
4562 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4564 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4566 * src/maemo/easysetup/modest-easysetup-wizard.c:
4567 (modest_easysetup_wizard_dialog_init):
4568 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4569 Use realistic paths (though they should use $prefix generically) to the
4570 mcc_mapping and provider-data.keyfile files which might work when they
4571 are installed by the future version of the operator-wizard package,
4572 and then fallback to paths in our source code, with an explanatory
4575 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4579 * src/maemo/Makefile.am:
4580 * src/maemo/easysetup/: Added files from the previously-exernal
4581 osso-modest-easysetup.
4582 * src/maemo/modest-main-window-ui.h:
4583 * src/modest-ui-actions.c:
4584 * src/modest-ui-actions.h:
4585 Added modest_ui_actions_on_new_account() as a signal handler for the
4586 New Account menu item. It shows the easysetup wizard.
4587 * po/en_GB.po: Added additional needed logical IDs and translations.