1 2007-07-11 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
5 projects.maemo.org bug NB#62778.
7 2007-07-11 Murray Cumming <murrayc@murrayc.com>
9 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
10 Ignore the wrong (for now) secure-smtp setting in the presets -
11 just default to requiring secure authentication for SMTP, because
14 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
16 * src/widgets/modest-folder-view.c: (filter_row)
17 Do not show drafts folder (see UI specs)
19 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
21 * src/modest-ui-actions.c:
22 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
23 place and also not necessary.
25 * src/widgets/modest-folder-view.c: (filter_row)
26 Guess folder type and hide Sent & Outbox if necessary.
27 Fixed project.maemo.org NB#57328
29 2007-07-11 Murray Cumming <murrayc@murrayc.com>
31 * src/modest-ui-actions.h:
32 * src/modest-ui-actions.c:
33 (modest_ui_actions_on_delete_message):
34 Move some code into a new
35 modest_ui_actions_refresh_message_window_after_delete()
36 function so we can use it from elsewhere.
38 * src/dbus_api/modest-dbus-callbacks.c:
39 (on_idle_delete_message), (on_delete_message): Used an idle
40 handler, as we do for the other D-Bus method handlers.
41 Call modest_ui_actions_refresh_message_window_after_delete()
42 if the deleted message was open in a window. This fixed
43 projects.maemo.org bug NB#62862.
45 2007-07-11 Murray Cumming <murrayc@murrayc.com>
47 * src/modest-main.c: (main): Only show the UI at the start if
48 the showui command line option was given. For instance,
49 run-standalone src/modest showui
50 Otherwise, we wait for the top_application D-Bus method to
51 be sent by hildon-desktop when the application is selected
53 This allows us to run without a UI when osso-global-search
54 uses our D-Bus methods.
56 2007-07-11 Murray Cumming <murrayc@murrayc.com>
58 * src/dbus_api/modest-dbus-api.h: Added a define for a
59 top-application D-Bus method.
60 * src/dbus_api/modest-dbus-callbacks.c:
62 (modest_dbus_req_handler): Handle the top-application D-Bus
63 method, which might be an undocumented D-Bus signal sent by
64 hildon-desktop when it starts the application from the menu.
65 But I am not sure and I need to test it on the device, because
66 my scratchbox does not have the application in the menu now.
67 This method shows the main window, so that it can be invisible
68 when started, for instance, just for email searching from
71 * src/maemo/modest-main-window.c: (restore_settings),
72 (modest_main_window_new): Do not show the window immediately
73 upon creation. We show it later.
74 * src/modest-widget-memory.c: (save_settings_paned):
75 Try (unsuccessfully) to avoid saving the paned position when
76 it is not even visible.
77 (restore_settings_paned): Do not allow a silly paned position.
78 This seems necessary when not showing the window at first.
80 * tests/dbus_api/Makefile.am:
81 * tests/dbus_api/test_top_application.c: (main): Test for the
84 2007-07-10 Murray Cumming <murrayc@murrayc.com>
86 * src/modest-ui-dimming-rules.c:
87 (modest_ui_dimming_rules_on_new_msg),
88 (modest_ui_dimming_rules_on_reply_msg),
89 (modest_ui_dimming_rules_on_delete_msg),
90 (modest_ui_dimming_rules_on_details),
91 (modest_ui_dimming_rules_on_view_window_move_to),
92 (modest_ui_dimming_rules_on_view_previous),
93 (modest_ui_dimming_rules_on_view_next),
94 (_invalid_folder_for_purge): Added checks before
95 casting the window. This looks like an actual
96 logic error in _invalid_folder_for_purge(), because it
97 tries to use a ModestMainWindow as a message window.
99 2007-07-10 Murray Cumming <murrayc@murrayc.com>
101 * src/maemo/modest-account-settings-dialog.c:
102 (show_error): Use the same implementation as in
103 modest-easysetup-wizard.c:
104 (on_entry_invalid_character): The logical ID contains a %s.
105 Guessed what it should be.
106 (on_entry_max), (check_data), (on_response): Adapt to
107 changed show_error().
108 (create_page_account_details): Really call
109 modest_validating_entry_set_func() on the correct widgets.
110 * src/maemo/easysetup/modest-easysetup-wizard.c:
111 (on_entry_invalid_character): Fix the logical ID here too.
112 (create_page_account_details),
113 (create_page_user_details):
115 modest_validating_entry_set_func() on the correct widgets.
117 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
118 Do not try to use the account if it is NULL.
120 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
122 * src/modest-ui-actions.c: (create_move_to_dialog),
123 (modest_ui_actions_on_main_window_move_to),
124 (modest_ui_actions_on_msg_view_window_move_to):
125 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
126 (filter_row), (modest_folder_view_show_non_move_folders):
127 * src/widgets/modest-folder-view.h:
129 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
130 the Sent folder yet as it does not report the correct folder type.
132 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
134 * src/maemo/modest-msg-edit-window.c: (init_window):
137 2007-07-10 Murray Cumming <murrayc@murrayc.com>
139 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
140 Take a parent widget instead of a parent window, and
141 implement this with hildon_banner_show_information() instead.
142 Non-Maemo builds can just ifdef that there.
143 This fixed projects.maemo.org bug NB#62766.
145 (on_entry_invalid_character): Use show_error() again instead
146 of using hildon directly, and use the _CS() macro to use the correct
148 (create_account), (check_for_supported_auth_methods), (on_entry_max):
149 Pass a widget instead od a window to show_error().
151 2007-07-10 Murray Cumming <murrayc@murrayc.com>
153 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
154 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
155 This allows us to show the server name in the error message, fixing
156 projects.maemo.org bug NB#62904.
157 Also, use the appropriate logical ID message for the account protocol.
159 2007-07-10 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-tny-account-store.c: (on_idle_wrong_password):
162 A compilation fix, though the build wasn't broken for me.
164 2007-07-09 Murray Cumming <murrayc@murrayc.com>
166 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
167 Do not try to unref a NULL folder store, to avoid a runtime warning.
168 This seems to happen sometimes when changing accounts settings.
170 2007-07-09 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-tny-account-store.c:
173 (modest_tny_account_store_instance_init),
174 (modest_tny_account_store_finalize),
175 (on_account_settings_hide), (on_idle_wrong_password):
176 Use a GHashTable to ensure that we only show one account settings
177 dialog per modest account. This avoids us having a dialog open for
178 both the store and transport accounts, or due to repeated get_password()
179 calls that shouldn't happen anyway.
181 2007-07-09 Murray Cumming <murrayc@murrayc.com>
183 * src/maemo/modest-maemo-utils.c: (on_hide),
184 (modest_maemo_show_dialog_and_forget): Handle the response, because
185 the window is not even hidden by default.
187 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
188 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
189 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
190 which seems to prevent some modality problems.
192 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
193 Ignore user cancellation errors.
195 * src/modest-account-mgr-helpers.h:
196 * src/modest-account-mgr-helpers.c:
197 Added modest_server_account_get_password() and
198 modest_server_account_get_has_password() to avoid direct use of
201 * src/maemo/modest-account-settings-dialog.h:
202 * src/maemo/modest-account-settings-dialog.c:
203 (modest_account_settings_dialog_init): Store the notebook so we can
205 Added modest_account_settings_dialog_switch_to_user_info().
207 * src/modest-tny-account-store.c:
208 (get_password): When the password in the account settings is wrong (we think),
209 show the relevant page of the account settings dialog, in the mainloop.
210 However, we currently get many of these at once because cancel does not
212 (forget_password): Do not forget the password
213 from the account settings, because this causes side-effects when
214 tinymail seems to call it at strange time, maybe because of how we
215 are cancelling get_password().
216 (modest_tny_account_store_alert): Ignore user cancellations.
218 2007-07-09 Murray Cumming <murrayc@murrayc.com>
220 * src/maemo/modest-maemo-utils.h:
221 * src/maemo/modest-maemo-utils.c:
222 Added modest_maemo_show_information_note_and_forget() for use instead of
223 gtk_dialog_run() when the response is not needed, to avoid an extra
224 mainloop which could cause a hang.
226 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
227 Use the logical IDs for the error message, though they are not
228 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
229 because gtk_dialog_run() caused a hang here (the window did not close).
230 This fixes projects.maemo.org bug NB#62646.
232 2007-07-09 Murray Cumming <murrayc@murrayc.com>
234 * src/modest-account-mgr-helpers.h:
235 * src/modest-account-mgr-helpers.c:
236 Added modest_account_mgr_get_store_protocol().
238 * src/maemo/modest-account-view-window.c:
239 (on_delete_button_clicked): Show different warning text depending on
240 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
241 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
244 2007-07-09 Murray Cumming <murrayc@murrayc.com>
246 * src/maemo/modest-msg-edit-window.c:
247 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
248 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
250 2007-07-07 Armin Burgmeier <armin@openismus.com>
252 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
253 ckdg_ib_maximum_characters_reached from correct package.
255 * src/modest-ui-actions.c: Show an error message when a folder could
256 not be created. Tinymail does not give us specific error codes about
257 what has gone wrong, so we assume that a folder with that name
258 already exists, though there might be other reasons.
260 2007-07-06 Murray Cumming <murrayc@murrayc.com>
262 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
263 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
264 give a more exact error message that can be partly translated.
266 2007-07-05 Murray Cumming <murrayc@murrayc.com>
268 * src/maemo/modest-address-book.c:
269 (select_email_addrs_for_contact): Specify a default window size for the
270 select-email-address dialog, so that it is probably big enough for the
271 title. This should fix projects.maemo.org bug NB#62277.
273 2007-07-05 Murray Cumming <murrayc@murrayc.com>
275 * src/maemo/easysetup/modest-easysetup-wizard.c:
276 (create_page_complete_easysetup): Use
277 gtk_widget_set_size() request to ensure that the text wraps
280 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
282 * src/maemo/easysetup/modest-easysetup-wizard.c:
283 (on_entry_invalid_character), (create_page_account_details),
284 (create_page_user_details):
285 Use new API of ModestValidatingEntry. But for some reason the banner is
286 not shown. I will have to investigate that further.
288 * src/widgets/modest-validating-entry.c: (on_insert_text),
289 (modest_validating_entry_set_func):
290 * src/widgets/modest-validating-entry.h:
291 Added a new callback function to be able to react to prevented
292 characters whitespaces to e.g show a banner.
294 2007-07-05 Armin Burgmeier <armin@openismus.com>
296 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
297 notification of HildonNumberEditor instead of remembering the port
298 number. Thanks to Johannes for pointing this out.
300 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
302 * src/maemo/easysetup/modest-easysetup-wizard.c:
303 Check if there are any user changes before showing a confirmation
304 dialog (projects.maemo.org NB#60946)
306 2007-07-05 Armin Burgmeier <armin@openismus.com>
308 * src/maemo/modest-account-settings-dialog.c: Remember custom port
309 number at the beginning of the dialog and set the modified flag at the
310 end if the port number has changed. This is necessary because
311 HildonNumberEditor does not support notification when the value has
314 2007-07-05 Murray Cumming <murrayc@murrayc.com>
316 * src/modest-ui-actions.c:
317 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
318 a connection before asking anything else. Correct the check for the destination
319 folder so that it succeeds when online.
320 This fixed projects.maemo.org bug NB#61645.
322 2007-07-05 Murray Cumming <murrayc@murrayc.com>
324 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
325 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
326 to fix projects.maemo.org bug NB#62439.
328 2007-07-05 Murray Cumming <murrayc@murrayc.com>
330 * src/modest-tny-account.c: (on_connection_status_changed):
331 Really do not use tny_device_force_offline() here. See the previous comment.
333 2007-07-04 Murray Cumming <murrayc@murrayc.com>
335 * src/modest-tny-account.c: (on_connection_status_changed):
336 Do not use tny_device_force_offline() when tinymail says that something
337 went wrong with the connection. It seems to report this unnecessarily.
339 2007-07-04 Murray Cumming <murrayc@murrayc.com>
341 * src/maemo/modest-connection-specific-smtp-window.c:
342 (modest_connection_specific_smtp_window_init):
343 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
344 does not seem to have any effect in osso 1.1 (though it works in
345 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
347 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
349 * src/maemo/modest-connection-specific-smtp-window.c:
350 Fix UI specification problems with projects.meamo.org NB#60479
352 2007-07-04 Murray Cumming <murrayc@murrayc.com>
354 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
355 clue when this has failed, because the error dialog is not always shown
356 (at least in earlier version).
358 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
359 GError message, because the generic error dialog is not helpful.
361 'This message is not currently available (can't let a new connection go online)'
362 when trying to open an IMAP message.
364 (_modest_ui_actions_open): Offer a connection when some messages would
365 have to be downloaded and we are offline.
367 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
369 * src/widgets/modest-folder-view.c:
370 Don't check for MERGE type anymore as we use the correct type
372 NOTE: For the last two changes you need to update your tinymail copy
373 because of API changes!
375 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
377 * src/modest-tny-local-folders-account.c:
378 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
379 (see projects.maemo.org NB#61580)
381 2007-07-04 Murray Cumming <murrayc@murrayc.com>
383 * src/modest-tny-account.c: (on_connection_status_changed):
384 Commented out the call to modest_platform_connect_and_wait() because this
385 seems to always hang, and I would like to know if this is the only thing
386 that causes a hang when showing the connection dialog.
387 It is not very useful anyway.
389 2007-07-04 Murray Cumming <murrayc@murrayc.com>
391 * src/maemo/modest-msg-view-window.c:
392 (modest_msg_view_window_select_next_message):
394 * src/modest-platform.h:
395 * src/maemo/modest-platform.c:
396 Added modest_platform_connect_and_wait(), which calls
397 tny_maemo_conic_device_connect() always in the main thread, by calling it
398 in an idle handler and waiting for the idle handler to run. It should be
399 in the main thread because it uses GTK+ UI code. It just returns TRUE
400 if the device is already online.
402 There is some nasty code to ensure that subsequent calls to
403 modest_platform_connect_and_wait() just wait for the first one to finish,
404 by checking repeatedly in another idle handler. This is necessary,
405 because other threads (or even the main thread, via another idle handler)
406 can call modest_platform_connect_and_wait() while
407 modest_platform_connect_and_wait() is running.
409 (modest_platform_connect_and_wait_if_network_account),
410 (modest_platform_connect_and_wait_if_network_folderstore):
411 Convenience functions that calls modest_platform_connect_and_wait() if
412 the account or folder might want network access.
414 * src/modest-mail-operation.c:
415 (modest_mail_operation_update_account):
416 * src/modest-ui-actions.c: (download_uncached_messages),
417 (modest_ui_actions_on_rename_folder), (delete_folder),
418 (modest_ui_actions_on_main_window_move_to),
419 (modest_ui_actions_on_msg_view_window_move_to):
420 * src/widgets/modest-folder-view.c:
421 (drag_and_drop_from_folder_view):
422 Offer a connection if we are offline.
424 * src/modest-tny-account.c: (on_connection_status_changed):
425 Document this as only handling errors during network operations in progress,
426 and replace the idle code with a simple call to
427 modest_platform_connect_and_wait(), which does this instead.
429 2007-07-03 Murray Cumming <murrayc@murrayc.com>
431 * src/modest-tny-account.c:
432 (modest_tny_account_get_special_folder): (util_on_idle),
433 Handle the GError so we can see when tny_folder_store_get_folders()
434 fails, as it currently does while something else is connecting.
436 Added util_run_in_main_thread_and_wait()
437 which uses an idlen handler and mainloop to ensure that the function
438 is called in the main thread.
439 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
440 to make sure that we call attempt the connection in the mainloop only,
441 which might solve some hangs.
443 2007-07-03 Murray Cumming <murrayc@murrayc.com>
445 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
446 be found by their display name. This is never useful.
447 * src/modest-tny-account-store.c: (on_account_removed): Find the account
448 by its ID, instead of trying to use its ID as its display name.
450 * src/modest-tny-account-store.h:
451 * src/modest-tny-account.c:
452 (modest_tny_account_get_special_folder): Add a g_warning() when
453 tny_folder_store_get_folders() returns an empty list for the maildir.
455 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
456 Add a g_warning() when this returns NULL, because that it not allowed
459 2007-07-02 Armin Burgmeier <armin@openismus.com>
461 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
462 note when trying to cancel the wizard. This fixes projects.maemo.org
465 2007-07-02 Murray Cumming <murrayc@murrayc.com>
467 * src/modest-tny-account.h:
468 * src/modest-tny-account.c:
469 (modest_tny_account_new_from_server_account),
470 (modest_tny_account_new_from_server_account_name),
471 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
472 because this must now be set before setting the proto. This is usd in
473 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
474 warning in camel_session_get_service() caused by
475 tny_camel_transport_account_prepare().
477 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
480 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
482 * src/maemo/modest-connection-specific-smtp-edit-window.c:
484 (modest_connection_specific_smtp_edit_window_init):
486 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
489 2007-06-29 Murray Cumming <murrayc@murrayc.com>
491 * src/modest-tny-account.c:
492 (modest_tny_account_new_from_server_account):
493 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
494 now uses to request a connection when it needs one, and which it uses
495 to tell us that something is wrong with the connection, so we can force
496 the accounts offline to prevent further problems.
499 * src/modest-init.c: (init_default_settings):
500 * src/modest-mail-operation.c:
501 (modest_mail_operation_update_account):
502 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
503 This should not be necessary anymore. Do not set the conf key that
504 determined this (it was always TRUE and not set anywhere else).
506 * src/modest-ui-actions.h: Remove unused and unimplemented
507 modest_ui_actions_on_online_toggle_toggled().
509 2007-06-29 Murray Cumming <murrayc@murrayc.com
511 * src/maemo/modest-main-window.c: (connect_signals):
512 Don't connect to delete_event twice. Maybe this was harmless.
514 2007-06-29 Murray Cumming <murrayc@murrayc.com
516 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
517 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
518 Debug output to give some more clue when a folder move is not allowed.
520 2007-06-28 Murray Cumming <murrayc@murrayc.com
522 * src/modest-tny-account.c: (on_modest_file_system_info),
523 (modest_tny_account_get_mmc_account_name):
524 Always call the callback, without checking whether the name has changed.
525 * src/widgets/modest-folder-view.c: (strings_are_equal),
526 (on_model_foreach_set_name), (on_get_mmc_account_name),
527 (text_cell_data): Compare the name here, and use the name from
528 the account rather than from the
529 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
530 if the name was changed after the account was added to the model.
531 That's a tinymail bug but not one that I want to fix now.
533 This finally fixes projects.maemo.org bug NB#59301.
535 2007-06-27 Armin Burgmeier <armin@openismus.com>
537 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
540 2007-06-27 Murray Cumming <murrayc@murrayc.com
542 * src/modest-tny-account.h:
543 * src/modest-tny-account.c:
544 Added modest_tny_account_get_mmc_account_name(), to set the memory
545 card name asynchronously for the given account and then notify.
546 (modest_tny_account_new_for_local_folders): Use this new function instead
547 of using hildon_file_system_info_async_new() directly.
549 * src/widgets/modest-folder-view.c: (text_cell_data):
550 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
551 gtk_tree_model_row_changed() when it is available.
553 This should fix projects.maemo.org bug NB#59301.
555 2007-06-27 Murray Cumming <murrayc@murrayc.com
557 * src/modest-mail-operation.c: (update_account_thread),
558 (get_msgs_full_thread): Fix typo failures in the revert
561 2007-06-27 Murray Cumming <murrayc@murrayc.com
563 * src/maemo/modest-maemo-global-settings-dialog.c:
564 (idle_select_default_focus):
565 * src/modest-mail-operation.c: (idle_notify_progress),
566 (idle_notify_progress_once), (set_last_updated_idle),
567 (update_account_thread), (get_msgs_full_thread):
568 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
569 * src/widgets/modest-header-view.c:
570 (idle_notify_headers_count_changed_destroy),
571 (idle_notify_headers_count_changed):
572 Reverted the additions of gdk_threads_enter/leave(), in case this
573 helps with a startup hang on the device.
575 2007-06-26 Armin Burgmeier <armin@openismus.com>
577 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
578 for supported secure authentication methods from server by
579 gtk_dialog_run(), saving CPU time and a potential race condition.
581 2007-06-26 Armin Burgmeier <armin@openismus.com>
583 * src/maemo/modest-maemo-utils.h:
584 * src/maemo/modest-maemo-utils.c: Added a
585 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
586 only error code to tell the calling code when the user canceled the
589 * src/maemo/modest-account-settings-dialog.h:
590 * src/maemo/modest-account-settings-dialog.c:
591 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
592 message if the retrieval of secure authentication methods was canceled
593 by the user. Perform the check before saving anything to configuration
594 to not end up with half-committed configuration changes, do not show
595 a "Saving to configuration failed" note when authentication methods
596 could not be retrieved.
598 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
601 2007-06-26 Murray Cumming <murrayc@murrayc.com>
603 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
604 Only return the first level of folders under accounts, because the
605 osso-global-search UI spec doesn't want the rest.
606 This fixed projects.maemo.org bug NB#61811.
608 2007-06-26 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-tny-account-store.c:
611 * src/modest-tny-account-store.h:
612 Added modest_tny_account_is_memory_card_account().
613 * src/maemo/modest-main-window.c: (create_details_widget):
614 Show the same information items for the memory card as we show for the
615 local-folders, to fix projects.maemo.org bug NB#59307.
617 2007-06-26 Murray Cumming <murrayc@murrayc.com>
619 * src/modest-tny-account-store.c: (get_password):
620 Added some checks for NULL to maybe prevent crashes, though I think
621 it was Philip's last commit that actually prevented the crash here
622 when creating a first new account.
623 But the new account is still not usable (no messages are shown)
624 until a restart of the application.
626 2007-06-26 Murray Cumming <murrayc@murrayc.com>
628 * src/maemo/modest-maemo-global-settings-dialog.c:
629 (idle_select_default_focus):
630 * src/modest-mail-operation.c: (idle_notify_progress),
631 (idle_notify_progress_once), (idle_notify_update_account_queue),
632 (set_last_updated_idle), (update_account_thread),
633 (notify_get_msgs_full), (get_msgs_full_destroyer),
634 (get_msgs_full_thread):
635 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
636 * src/widgets/modest-header-view.c:
637 (idle_notify_headers_count_changed_destroy),
638 (idle_notify_headers_count_changed):
639 Use gdk_threads_enter() and gdk_threads_enter_leave() in
640 all idle handlers, because some other thread could be blocking
641 the GDK lock, so that it can do GUI stuff.
643 2007-06-26 Murray Cumming <murrayc@murrayc.com>
645 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
646 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
647 (on_idle_send_receive), (on_idle_open_default_inbox):
648 * src/maemo/modest-msg-edit-window.c:
649 (modest_msg_edit_window_attach_file_noninteractive):
650 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
651 to prevent a hang. I don't quite understand why these are necessary,
652 beause we should already be in the main loop. I guess something outside
653 of the main loop is taking the lock.
655 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
656 we are really using URIs, and use files that are more likely to exist.
658 2007-06-26 Murray Cumming <murrayc@murrayc.com>
660 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
661 necessary because configure.ac now defines different variables.
663 2007-06-26 Murray Cumming <murrayc@murrayc.com>
665 * libmodest-dbus-client/libmodest-dbus-client.c:
666 * libmodest-dbus-client/libmodest-dbus-client.h:
667 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
668 libmodest_dbus_client_compose_mail() is what things actually use.
670 * src/dbus_api/modest-dbus-api.h:
671 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
672 * tests/dbus_api/Makefile.am:
673 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
676 2007-06-26 Murray Cumming <murrayc@murrayc.com>
678 * src/modest-init.c: (modest_init_local_folders):
679 For memory-card (or other non local-folders) maildir accounts,
680 always create an Archive folder, so that there is somewhere to put
681 messages. This should be less confusing, because the user does not need
682 to guess that the need to create a folder.
684 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
686 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
687 Fixed icon size by using (50, 50) which is the same as defined by
690 2007-06-25 Armin Burgmeier <armin@openismus.com>
692 * src/widgets/modest-window-mgr.c:
694 * configure.ac: Correctly recognize hildon-notify presence and fixed
695 the build without it being installed.
697 2007-06-25 Murray Cumming <murrayc@murrayc.com>
699 * libmodest-dbus-client/libmodest-dbus-client.c:
700 (libmodest_dbus_client_search): Fix the build. Sorry.
701 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
702 (reply_forward_cb): Initialize variables to fix the build.
704 * src/modest-tny-account-store.c:
705 (modest_tny_account_store_get_tny_account_by): Fix the account URI
706 comparison (a silly typo) so that email search results can be opened
707 when there are more than one account.
709 2007-06-25 Murray Cumming <murrayc@murrayc.com>
711 * libmodest-dbus-client/libmodest-dbus-client.c:
712 (libmodest_dbus_client_search),
713 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
714 instead of 1 second, because the search gets folders and messages from
715 the server, which can take a long time. When it times out,
716 osso-global-search will report no results.
718 We need to specify whether we should search only cached information
719 (maybe with a user preference), and the osso-email-search-plugin
720 API should really be improved to allow that option, and to allow results
721 to be delivered asynchronously in batches.
723 2007-06-25 Murray Cumming <murrayc@murrayc.com>
725 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
726 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
727 GTK_ICON_SIZE_DIALOG is probably the wrong size.
729 2007-06-25 Murray Cumming <murrayc@murrayc.com>
731 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
732 that is an empty string. D-Bus seems to give us these instead of NULL.
734 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
736 * src/dbus_api/modest-dbus-callbacks.c:
737 * src/maemo/easysetup/modest-easysetup-wizard.h:
738 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
739 * src/maemo/modest-connection-specific-smtp-edit-window.c:
740 (modest_connection_specific_smtp_edit_window_init):
741 * src/maemo/modest-maemo-global-settings-dialog.c:
743 * src/maemo/modest-maemo-utils.c:
744 (modest_maemo_utils_setup_images_filechooser):
745 * src/maemo/modest-main-window.c: (create_details_widget):
746 * src/maemo/modest-msg-edit-window.c:
747 (modest_msg_edit_window_attach_file_noninteractive),
748 (modest_msg_edit_window_color_button_change),
749 (modest_msg_edit_window_set_zoom):
750 * src/modest-mail-operation.c: (update_account_thread):
751 * src/modest-tny-account-store.c:
752 * src/modest-tny-account.c:
753 * src/widgets/modest-global-settings-dialog.c:
754 * src/widgets/modest-window.h:
758 2007-06-25 Murray Cumming <murrayc@murrayc.com>
760 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
761 * src/modest-search.c: (modest_search_folder),
762 (modest_search_all_accounts): Actually search only in the specified folder,
763 doing a simple match on the folder ID.
764 * src/modest-search.h: Added a folder field to the ModestSearch struct,
765 and added some documentation.
767 2007-06-22 Armin Burgmeier <armin@openismus.com>
769 * src/maemo/modest-maemo-utils.h:
770 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
771 modest_maemo_utils_get_supported_secure_authentication_methods.
773 * src/maemo/easysetup/modest-easysetup-wizard.c:
774 * src/maemo/modest-account-settings-dialog.c: Show correct error if
775 one occured, not just "Server does not support secure authentication".
777 2007-06-22 Murray Cumming <murrayc@murrayc.com>
779 * src/modest-tny-account-store.c: (get_password):
780 Restored the call to tny_account_set_user() because Philip seems to have
781 stopped this from crashing (by not using the freed string). It still does
782 not work, but now we can test it.
784 2007-06-22 Murray Cumming <murrayc@murrayc.com>
786 * src/maemo/modest-msg-edit-window.c: (init_window):
787 Comment out use of an uninitialzed GtkScrolledWindow variable,
788 to fix the build and stop a crash. Yet again.
790 2007-06-22 Murray Cumming <murrayc@murrayc.com>
792 * src/modest-tny-account-store.c: (get_password):
793 Remove the call to tny_account_set_user() because this actually crashes.
794 As mentioned in the last commit, it is known to not work anyway.
796 2007-06-22 Murray Cumming <murrayc@murrayc.com>
798 * src/modest-tny-account-store.c: (get_password):
799 Use tny_account_set_username() to tell tinymail that the username might
800 have changed too. But tinymail ignores this: see projects.maemo.org
802 * src/modest-ui-actions.c:
803 (modest_ui_actions_on_password_requested): Remove the useless attempt to
804 reset the connection when changing the username, and improve the comments.
805 Save the changed username to gconf at least, so it is used when Modest is
808 2007-06-21 Murray Cumming <murrayc@murrayc.com>
810 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
811 Do not use a query, so that we get all folders, including for POP and
812 local-folders. They work as search criteria too.
813 This fixes projects.maemo.org bug NB#57740.
815 2007-06-21 Murray Cumming <murrayc@murrayc.com>
817 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
818 Comment out the use of hildon_notification_set_sound() because it is
819 not declared, to fix the build. Warnings are serious, people.
821 2007-06-21 Armin Burgmeier <armin@openismus.com>
823 * src/maemo/modest-maemo-utils.h:
824 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
825 modest_maemo_utils_get_supported_secure_authentication_methods()
826 to query authentication methods for a specific user. This should fix
827 projects.maemo.org bug NB#61369.
829 * src/maemo/easysetup/modest-easysetup-wizard.c:
830 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
833 2007-06-21 Murray Cumming <murrayc@murrayc.com>
835 * libmodest-dbus-client/libmodest-dbus-client.h:
836 * libmodest-dbus-client/libmodest-dbus-client.c:
837 (modest_dbus_message_iter_get_search_hit),
838 (libmodest_dbus_client_search):
839 Reorganised and commented this.
840 Removed modest_search_hit_free() from the public API because it
843 Added libmodest_dbus_client_get_folders() and
844 modest_folder_result_list_free().
846 * src/dbus_api/modest-dbus-api.h:
847 * src/dbus_api/modest-dbus-callbacks.c:
848 (modest_dbus_req_filter): Commented. Moved most code to
849 on_dbus_method_search() and added on_dbus_method_get_folders().
851 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
852 of the extra D-Bus handler.
854 * tests/dbus_api/Makefile.am:
855 * tests/dbus_api/test_get_folders.c: New test for
856 libmodest_dbus_client_get_folders(). This seems to return an empty list
857 at the moment. That could be the same error that causes the message list
858 to be empty sometimes.
859 This should help with projects.maemo.org bug NB#57740.
861 2007-06-21 Armin Burgmeier <armin@openismus.com>
863 * src/modest-mail-operation.c: Do not call
864 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
865 notify the operation's end after having set the status to CANCELED for
866 the operation queue to listen on. This fixes a deadlock when there
867 were mail operations in the queue during its finalization.
869 * src/modest-singletons.c: Reordered uninitialization of the account
870 manager to happen after the mail operation queue was uninitialized
871 because the mail operation's in the queue might still try to access
872 the account manager (see modest_mail_operation_notify_end()). This
873 fixes a potential crash when terminating the application.
875 2007-06-21 Murray Cumming <murrayc@murrayc.com>
877 * src/modest-search.c:
878 (search_mime_part_and_child_parts): Moved some code here so we
879 can search recursively in child folders.
880 (modest_search_folder): Search in the message as a mime part, instead
881 of just its child mime parts.
882 (read_chunk), (search_mime_part_ogs):
883 Check how many bytes were read, to prevent an endless loop.
884 Searching in message bodies now works. This finishes the fix for
885 projects.maemo.org bug NB#61007.
887 2007-06-20 Murray Cumming <murrayc@murrayc.com>
889 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
890 Add a g_warning when the item is not a folder.
892 * src/modest-ui-dimming-rules.c:
893 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
894 when selected item is not a folder (for instance, an account), because
895 the UI spec only talks about folders.
896 I am not sure what the UI spec wants, so this might not totally fix
897 projects.maemo.org bug NB#60794.
899 2007-06-20 Murray Cumming <murrayc@murrayc.com>
901 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
902 (load_from_file): Sort the list. The unsorted list would be more noticeable
903 in non-English locales.
905 * src/maemo/modest-msg-edit-window.c:
906 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
907 warning and fix the build.
909 * src/maemo/modest-progress-bar-widget.c:
910 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
911 avoid a g_warning, and probably to avoid a crash.
913 2007-06-20 Murray Cumming <murrayc@murrayc.com>
915 * src/modest-search.c: (modest_search_folder): Check for a GError
916 when calling tny_folder_get_headers(), to show that this is not the cause
919 2007-06-20 Murray Cumming <murrayc@murrayc.com>
921 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
922 Actually set the body query instead of the subject query.
924 * src/modest-search.c: (search_mime_part_ogs),
925 (search_mime_part_strcmp): Remove extra space from the text/* regex,
926 which would probably cause it to fail if we got this far.
928 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
929 to simplify the code.
930 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
931 be causing search-in-body to fail.
933 2007-06-20 Murray Cumming <murrayc@murrayc.com>
935 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
937 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
938 Better debug message when the folder cannot be found.
939 This should help with fixing projects.maemo.org bug #61287.
940 * src/modest-search.c: (add_hit): Do not leak the furl string.
942 2007-06-20 Murray Cumming <murrayc@murrayc.com>
944 * src/modest-ui-actions.c:
945 (modest_ui_actions_on_folder_selection_changed):
946 Do not special-case TNY_MERGE_FOLDER here, because
947 modest_tny_folder_get_account() already does that. This fixes
948 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
949 shown when the Outbox was selected).
951 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
953 * libmodest-dbus-client/libmodest-dbus-client.c:
954 (_dbus_iter_get_string_or_null): Initialize the string variable in
955 case this helps with Dirk's crash.
957 2007-06-19 Murray Cumming <murrayc@murrayc.com>
959 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
960 though it is not implemented yet (this function is maybe not even used),
961 to avoid breaking ABI in future.
962 * libmodest-dbus-client/libmodest-dbus-client.c:
963 (get_attachments_string): Moved some code into this generic function.
964 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
965 sends email. It is maybe not used.
966 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
967 (on_send_mail): Use attachments.
969 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
970 * src/maemo/modest-msg-edit-window.c:
971 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
972 a filename before using it, to fix projects.maemo.org bug NB#58233.
974 2007-06-19 Murray Cumming <murrayc@murrayc.com>
976 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
977 Initialize the continue_download variable to fix the build, and probably
978 to fix randome behaviour.
980 2007-06-18 Armin Burgmeier <armin@openismus.com>
982 * src/modest-tny-send-queue.h:
983 * src/modest-tny-send-queue.c: Keep track of the status of messages in
984 the queue so we can later show it in the UI. Replaced
985 modest_tny_send_queue_msg_is_being_sent() by
986 modest_tny_send_queue_get_msg_status().
988 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
990 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
991 gpointer. This probably was not harmful, but just to be sure.
993 2007-06-18 Murray Cumming <murrayc@murrayc.com>
995 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
996 Fix the build, but leave the function broken on Bora, because
997 hildon_uri_action_get_service() does not exist.
998 osso_uri_action_get_service() does not exist either, it seems.
1000 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1002 * src/modest-tny-account.c:
1003 (modest_tny_account_new_from_server_account):
1004 Uncommented the url debug output again, because it is useful for
1005 debugging, as I said in the comment.
1007 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1009 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1011 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1012 for Mameo Bora, to fix the build.
1014 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1017 Fixed build with hildon < 0.99
1019 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1020 Check if the selected account is busy instead of checking all accounts
1022 * src/modest-account-mgr-priv.h:
1023 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1024 (modest_account_mgr_init), (compare_account_name),
1025 (modest_account_mgr_set_account_busy),
1026 (modest_account_mgr_account_is_busy):
1027 * src/modest-account-mgr.h:
1028 Added busy information to the account manager. It possible to
1029 set an account to busy or not busy now.
1031 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1032 (modest_mail_operation_update_account),
1033 (modest_mail_operation_notify_end):
1034 Set the account to busy/not busy depending on the operation state.
1036 * src/widgets/modest-account-view.c:
1037 (modest_account_view_finalize), (get_last_updated_string),
1038 (update_account_view), (on_account_busy_changed), (init_view):
1039 Show string "Refreshing..." if the account is currently busy.
1041 All this fixes projects.maemo.org bug NB#59711
1043 2007-06-14 Armin Burgmeier <armin@openismus.com>
1045 * src/widgets/modest-attachments-view.h:
1046 * src/widgets/modest-attachments-view.c: Added
1047 modest_attachments_view_has_attachments() and fixed coordinate
1048 transformation in get_att_view_at_coords(). This fixes attachment
1051 * src/widgets/modest-msg-view.c: Make use of
1052 modest_attachments_view_has_attachments() to decide whether to show
1053 attachments in the header.
1055 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1057 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1058 (on_change), (on_combo_security_changed),
1059 (modest_connection_specific_smtp_edit_window_init),
1060 (modest_connection_specific_smtp_edit_window_set_connection),
1061 (modest_connection_specific_smtp_edit_window_is_dirty):
1062 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1063 * src/maemo/modest-connection-specific-smtp-window.c:
1066 Show an comfirmation dialog for the smpt-edit-window if there are
1067 unsaved changes and the user hits cancel.
1068 (projects.maemo.org bug NB#60479)
1070 2007-06-14 Armin Burgmeier <armin@openismus.com>
1072 * src/maemo/easysetup/modest-easysetup-wizard.c:
1073 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1074 address" info in banner instead of node, and select all the text as
1075 per UI spec. This fixes projects.maemo.org bug NB#60550.
1077 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1079 reviewed by: <delete if not using a buddy>
1081 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1082 * src/modest-ui-actions.c: (folder_refreshed_cb):
1084 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1086 * src/widgets/modest-folder-view.c: (filter_row):
1087 Explictly filter out the per-account outbox accounts. I don't know why
1088 these only sometimes show up, but now they should never show up in the UI.
1089 This should fix projects.maemo.org bug NB#60160.
1091 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1093 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1094 when the toolbar does not exist yet.
1095 * src/modest-widget-memory.c: (save_settings_header_view):
1096 Added g_warnings() to help us to discover when we are trying to set
1097 an empty columns list in gconf.
1099 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1101 * src/modest-init.h:
1102 * src/modest-init.c:
1103 Added modest_init_get_default_header_view_column_ids().
1105 * src/modest-widget-memory.c: (restore_settings_header_view):
1106 Use the new function to get defaults, if the gconf key is empty,
1107 instead of not creating any columns. This seems to fix the
1108 empty right-hand pane problems.
1110 * src/widgets/modest-header-view.h: Improved documentation.
1112 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1114 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1115 Revert the use of the display name as the account name, because this
1116 is generally wrong and would break the code that follows.
1118 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1120 * src/maemo/easysetup/modest-easysetup-wizard.c:
1121 (check_for_supported_auth_methods), (on_before_next),
1124 More correct fix for projects.maemo.org bug NB# 58991
1125 Do not longer accept AUTH_PASSWORD as secure method and choose
1126 correct method when creating the account.
1128 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1130 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1131 Fixed projects.maemo.org bug NB# 58991
1133 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1135 * src/modest-init.c: (modest_init_init_core),
1136 (modest_init_local_folders): Fixed compilation errors.
1138 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1140 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1141 Remove unnecessary lib/include, though it is good in principle when needed.
1143 * src/modest-init.c: (modest_init_one_local_folder),
1144 (modest_init_local_folders):
1145 * src/modest-init.h: Initialize the .modest library for memory cards,
1146 instead of just doing nothing for them. This should allow us to create
1147 folders there, fixing projects.maemo.org bug NB#59297.
1149 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1151 * libmodest-dbus-client/libmodest-dbus-client.c:
1152 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1153 (libmodest_dbus_client_compose_mail),
1154 (libmodest_dbus_client_open_message),
1155 (libmodest_dbus_client_send_and_receive),
1156 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1158 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1159 (on_idle_open_message), (modest_dbus_req_handler),
1160 (search_result_to_message), (modest_dbus_req_filter):
1161 * src/modest-search.c: (add_hit), (modest_search_folder),
1162 (modest_search_all_accounts): Improved debug messages.
1164 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1166 * src/modest-tny-account-store.c:
1167 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1170 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1173 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1175 * src/modest-tny-account-store.c: (get_server_accounts):
1176 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1177 even when there are no accounts, so that the Outbox folder is always
1178 visible. This fixes projects.maemo.org bug NB#60158.
1180 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1182 * src/maemo/modest-main-window.c: (create_details_widget):
1183 Use the mcen_va_never logical ID.
1185 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1187 * src/dbus_api/modest-dbus-api.h:
1188 * src/dbus_api/modest-dbus-callbacks.c:
1189 (on_idle_open_default_inbox), (on_open_default_inbox),
1190 (modest_dbus_req_handler):
1191 Added a new OpenDefaultInbox method.
1193 * libmodest-dbus-client/libmodest-dbus-client.h:
1194 * libmodest-dbus-client/libmodest-dbus-client.c:
1195 Added libmodest_dbus_client_open_default_inbox() to call the new
1196 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1197 though it should maybe be used by a new osso-email-interface function.
1199 * tests/dbus_api/Makefile.am:
1200 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1203 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1205 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1206 NULL, so that the signals get all the keys. This should not actually
1207 change any behaviour because we currently update everything when anything
1210 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1212 * src/widgets/modest-folder-view.c: (text_cell_data),
1213 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1214 (find_inbox_iter): If tinymail tells us that the folder is
1215 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1216 This causes the inbox to be selected at startup, fixing part of
1217 projects.maemo.org bug NB#56305.
1219 * src/modest-ui-dimming-rules.c:
1220 (modest_ui_dimming_rules_on_tools_smtp_servers):
1221 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1222 the SMTP servers menu item.
1223 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1224 that the SMTP Servers menu item is dimmed when there are no accounts,
1225 as a future version of the UI spec will require. This fixes
1226 projects.maemo.org bug NB#56305.
1228 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1230 * src/maemo/modest-maemo-utils.c:
1231 (modest_maemo_utils_get_supported_secure_authentication_methods):
1232 Added label to dialog instead of unreadable title
1234 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1235 (modest_main_window_new):
1236 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1239 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1240 * src/modest-account-mgr.h:
1241 Added method to avoid code duplication
1243 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1244 (modest_ui_actions_on_send_receive):
1245 Use modest_account_mgr_has_accounts
1247 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1249 * src/maemo/easysetup/modest-presets.c:
1250 (modest_presets_get_info_server_security): Do not report secure auth
1252 * src/modest-protocol-info.c: Use the defines for the gconf key names
1253 for secure authentication. This was not working because we were writing
1254 Password and reading password, and the check was case sensitive.
1255 With this, gmail now works for receiving and sending when created via
1258 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1260 * src/maemo/easysetup/modest-presets.c:
1261 (modest_presets_get_info_server_security): Correct the key name for
1262 SecureSmtp, because it seems to be case-sensitive.
1263 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1264 Do not try to get the 0th notebook page if there are 0 pages, to
1265 avoid a g_warning().
1267 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1269 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1270 Prevent use of the new notification feature for now, because it currently
1271 shows one dialog for each new email, which is annoying.
1273 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1275 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1276 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1277 when no country was selected, so that we show the global ones.
1278 * src/maemo/easysetup/modest-presets.c:
1279 (modest_presets_get_providers): Return only the global providers, not
1280 all providers when mmc=0 was requested.
1282 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1284 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1285 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1286 provider ID in the combo.
1288 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1289 Do not show the page numbers, because it would be confusing when we add
1290 the 2 extra pages for the custom setup, when the user chooses the "Other"
1291 provider. This fixes projects.maemo.org bug NB#59028
1293 * src/modest-init.c: (modest_init_init_core),
1294 (modest_init_local_folders):
1295 * src/modest-init.h:
1296 * src/modest-tny-account.c:
1297 (modest_tny_account_new_for_local_folders): Do not create default folders
1298 for the memory card. This should fix projects.maemo.org bug NB#59328.
1300 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1302 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1303 Free the changed_conf_keys string items. They are already freed in the
1304 idle handler if that runs first.
1306 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1308 * src/modest-ui-actions.c:
1309 (modest_ui_actions_on_password_requested): Check that the server name
1310 is not NULL, because I just saw a password dialog with (null) as the
1313 * src/modest-tny-folder.[h|c]: Added
1314 modest_tny_folder_is_memory_card_folder().
1315 * src/modest-ui-dimming-rules.c:
1316 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1317 menu item for memory cards, as per the UI spec (section 7.4). This should
1318 fix projects.maemo.org bug NB#59297.
1320 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1322 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1323 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1324 is another problem with the code, see Murray's comment at line 772)
1326 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1328 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1329 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1330 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1331 (load_from_file), (easysetup_country_combo_box_init),
1332 (easysetup_country_combo_box_get_active_country_ids),
1333 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1334 instead of just one ID, to avoid duplicate country names in the UI.
1336 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1337 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1338 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1339 a single ID, avoiding duplicate providers.
1340 * src/maemo/easysetup/modest-easysetup-wizard.c:
1341 (on_combo_account_country): Adapt to use a list.
1343 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1345 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1346 keys changed in the last X seconds.
1348 * src/modest-account-mgr.h:
1349 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1350 (on_key_change), (modest_account_mgr_class_init),
1351 (modest_account_mgr_init), (modest_account_mgr_finalize):
1352 As the keys are changed, save them in a GSList* and signal that GSList*
1353 further every X seconds, to batch changes, to allow us to do just one
1354 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1355 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1357 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1358 changed signal signature.
1360 * src/modest-conf.c: (modest_conf_set_list),
1361 (modest_conf_on_change): Reenable notification.
1363 (modest_conf_maemo_fake_on_change): Comment out the hack that
1364 notified immediately instead of asynchronously.
1366 * src/widgets/modest-account-view.h:
1367 * src/widgets/modest-account-view.c:
1368 (update_account_view): Select the previously-selected account ID,
1369 if possible. This fixes projects.maemo.org bug NB#56933.
1371 (on_account_changed), (on_account_removed),
1372 (modest_account_view_select_account):
1374 Remove the block/unblock functions
1375 because they were not useful.
1377 * src/maemo/modest-account-view-window.c:
1378 (on_delete_button_clicked), (on_edit_button_clicked),
1379 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1381 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1383 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1384 Improve the error dialog to show Incorrect Account Settings, which seems
1385 clearer, and say that the internal error message (to be removed from the
1386 dialog later) is often misleading.
1387 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1389 * src/modest-tny-account.c:
1390 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1391 URL because this is so useful for debugging on the device.
1393 * src/widgets/modest-serversecurity-combo-box.c:
1394 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1396 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1398 * src/modest-mail-operation.c:
1399 (modest_mail_operation_send_new_mail):
1400 Added a comment about a nasty but apparently harmless message. Details
1401 added to the wiki g_warnings() page.
1403 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1405 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1406 (modest_tny_send_queue_class_init):
1407 Do not use the priv struct because it is empty, to avoid g_warnings
1408 about a non-existant priv struct.
1410 * src/modest-tny-account-store.c:
1411 (modest_tny_account_store_get_server_account),
1412 (modest_tny_account_store_get_transport_account_for_open_connection
1413 ): Do not try to get transport server accounts for local folders,
1414 because they don't have any. This avoids a g_warning().
1416 * src/maemo/modest-main-window.c:
1417 (modest_main_window_notify_send_receive_initied),
1418 (on_configuration_key_changed):
1419 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1420 * src/modest-defs.h:
1421 * src/modest-mail-operation.c:
1422 (modest_mail_operation_update_account):
1423 * src/modest-tny-account-store.h:
1424 * src/modest-tny-account.c:
1425 (modest_tny_account_get_special_folder),
1426 (modest_tny_account_new_for_local_folders),
1427 (modest_tny_account_new_for_per_account_local_outbox_folder):
1428 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1429 * src/modest-tny-local-folders-account.c:
1430 (add_account_folders_to_merged_folder):
1431 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1432 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1433 (modest_ui_actions_on_send):
1434 * src/widgets/modest-folder-view.c: (update_model):
1435 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1436 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1437 modest_tny_account_store_get_tny_account_by_account() to
1438 modest_tny_account_store_get_server_account() to make the code clearer.
1440 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1442 * src/dbus_api/modest-dbus-api.h:
1443 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1444 * src/maemo/modest-msg-edit-window.c:
1445 (modest_msg_edit_window_attach_file_noninteractive):
1446 added g_warning in case the file to be attached does not exist
1447 * tests/dbus_api/test_compose_mail.c: (main):
1448 removed obsolete comment, added generic files as test case
1450 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1452 * src/modest-tny-account-store.c: (get_server_accounts):
1453 Create the local folders account only once, not once for each outbox, and
1454 not only when there are some outboxes.
1456 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1458 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1459 code that is causing a crash at startup. Sergio says that he is fixing this.
1461 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1463 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1464 * src/maemo/modest-account-settings-dialog.c:
1465 (create_page_outgoing),
1466 (modest_account_settings_dialog_set_account_name),
1467 (save_configuration):
1468 - Fixed handling of the "Use secure authentication" toggle to comply with
1469 the ui specification. See also projects.maemo.org bug NB#58400
1471 - Restore the Secure connection setting combo correctly when loading
1474 * src/maemo/modest-maemo-utils.c:
1475 (on_camel_account_get_supported_secure_authentication),
1476 (modest_maemo_utils_get_supported_secure_authentication_methods):
1477 Fixed a crasher if operation is canceled
1479 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1480 (modest_protocol_info_auth_is_secure):
1481 * src/modest-protocol-info.h:
1483 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1484 the sense of the "Use secure authentication" toggle.
1486 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1488 * src/modest-tny-account-store.h:
1489 * src/modest-tny-account-store.c:
1490 Added modest_tny_account_store_get_local_folders_account().
1492 * src/modest-tny-folder.h:
1493 * src/modest-tny-folder.c:
1494 (modest_tny_folder_get_account):
1495 Added this replacement for tny_folder_get_account() which returns
1496 the local-folders account for TnyMergeFolders, to avoid the
1497 warning about the unimplemented get_account_func() vfunc().
1499 (modest_tny_folder_get_rules),
1500 * src/modest-ui-actions.c:
1501 (modest_ui_actions_on_folder_selection_changed):
1502 * src/modest-mail-operation.c:
1503 (modest_mail_operation_remove_folder),
1504 (modest_mail_operation_xfer_folder),
1505 (modest_mail_operation_rename_folder),
1506 (modest_mail_operation_get_msg),
1507 (modest_mail_operation_get_msgs_full),
1508 (modest_mail_operation_remove_msg),
1509 (modest_mail_operation_xfer_msgs),
1510 (modest_mail_operation_refresh_folder):
1511 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1513 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1515 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1516 (modest_server_account_set_security):
1517 * src/modest-defs.h: Add comments explaining that our
1518 UI spec means TLS when it says Normal, so these do not look like errors.
1520 * src/modest-tny-account.c:
1521 (modest_tny_account_new_from_server_account): Use the new tinymail
1522 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1523 for TLS. This should fix projects.maemo.org bug NB#58460.
1525 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1527 * src/maemo/easysetup/modest-easysetup-wizard.c:
1528 (create_account): Correct the position of the gconf sanity check warning.
1529 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1530 of using the g_idle_add() hack, because this does not seem to be necessary
1531 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1532 caused by something other than maemo's gconf.
1533 This fixes projects.maemo.org bug #59022.
1535 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1537 * src/modest-account-mgr-helpers.c:
1538 (modest_account_mgr_get_default_account): Do not check that the account
1539 exists if there is no default account (NULL), to fix a runtime warning.
1541 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1543 * src/widgets/modest-folder-view.c: (update_model):
1544 Do not unref the treemodel before we have finished with it.
1545 This prevents a valgrind warning and an occasional crash at startup.
1547 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1549 * libmodest-dbus-client/libmodest-dbus-client.h:
1550 added libmodest_dbus_client_compose_mail()
1551 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1553 added functions needed for SendAsMail() functionality
1554 * src/maemo/modest-msg-edit-window.c:
1555 (modest_msg_edit_window_attach_file_noninteractive):
1556 non interactively attaching files to message edit window
1557 * src/widgets/modest-msg-edit-window.h:
1558 * tests/dbus_api/Makefile.am:
1559 added test_compose_mail.c
1560 * tests/dbus_api/test_compose_mail.c: (main):
1562 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1564 * src/modest-account-view.c:
1565 Fixed bug projects.maemo.org bug NB#59307
1567 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1569 * src/maemo/easysetup/modest-easysetup-wizard.c:
1570 (get_serverport_incoming), (on_before_next), (create_account):
1571 * src/maemo/modest-account-settings-dialog.c:
1572 (modest_account_settings_dialog_set_account_name):
1573 * src/maemo/modest-maemo-utils.c:
1574 (on_camel_account_get_supported_secure_authentication_status),
1575 (on_camel_account_get_supported_secure_authentication),
1576 (on_secure_auth_cancel),
1577 (modest_maemo_utils_get_supported_secure_authentication_methods):
1579 Implemented security authentication for settings and easysetup.
1581 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1583 * src/maemo/modest-main-window.c: (create_details_widget):
1584 Show the total size for memory card accounts too, instead of showing
1585 the name again. Fixes bug projects.maemo.org bug NB#59307.
1587 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1590 * src/modest-tny-simple-folder-store.c:
1591 * src/modest-tny-simple-folder-store.h: Removed.
1593 * src/modest-tny-local-folders-account.h
1594 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1595 for the local-folders maildir, with an extra TnyMergedFolder containing
1596 the folders of the per-account outbox store accounts.
1597 * src/modest-tny-account-store.c: (get_server_accounts):
1598 Add the outboxes to the special local folders account after creating it.
1600 * src/modest-tny-account.c:
1601 (modest_tny_account_new_for_local_folders): Create the derived
1602 account when creating the main local-folders account.
1604 * src/maemo/modest-main-window.c: (create_details_widget),
1605 (modest_main_window_set_contents_style):
1606 Adapted to the use of the derived account instead of the folder store.
1608 * src/modest-ui-actions.c:
1609 (modest_ui_actions_on_folder_selection_changed):
1610 * src/modest-ui-dimming-rules.c:
1611 (modest_ui_dimming_rules_on_new_folder):
1612 * src/widgets/modest-folder-view.c: (text_cell_data),
1613 (icon_cell_data), (filter_row), (update_model),
1614 (get_cmp_rows_type_pos):
1617 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1618 Do not get the priv struct, because no priv struct has been set,
1619 to avoid a runtime warning.
1621 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1622 #ifelse with #else, to fix a warning, to fix the build.
1625 2007-06-05 Christian Kellner <ckellner@openismus.com>
1627 * libmodest-dbus-client/libmodest-dbus-client.c:
1628 Fix small typo in doc (why do you always see them
1629 AFTER committing stuff?)
1632 2007-06-05 Christian Kellner <ckellner@openismus.com>
1634 * libmodest-dbus-client/libmodest-dbus-client.c:
1635 (libmodest_dbus_client_search):
1636 Initialize hit list with NULL. Also set folder list
1637 to "" if NULL was supplied.
1640 2007-06-03 Christian Kellner <ckellner@openismus.com>
1642 * libmodest-dbus-client/libmodest-dbus-client.c:
1643 (modest_search_hit_list_free):
1644 Make it save to call it with NULL.
1646 * src/dbus_api/modest-dbus-callbacks.c:
1647 * src/modest-search.c:
1648 Return full ModestSearchHits as the search result list not TnyHeader
1649 since can't be around withouth the correspoding TnyFolder.
1651 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1653 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1654 Added currently commented code to check for secure auth
1656 * src/maemo/modest-account-settings-dialog.c: (on_response),
1657 (save_configuration), (show_ok):
1658 Fixed projects.maemo.org bugs NB #59248 and #59251
1660 * src/maemo/modest-maemo-utils.c:
1661 (on_camel_account_get_supported_secure_authentication_status),
1662 (on_camel_account_get_supported_secure_authentication),
1663 (modest_maemo_utils_get_supported_secure_authentication_methods):
1664 * src/maemo/modest-maemo-utils.h:
1665 Moved get_supported_secure_authentication() method here to be able
1666 to use it from easysetup wizard.
1668 * src/modest-pair.c: (on_pair_compare_as_string):
1669 Should compare string with first part of pair and not
1670 strcmp pairs which will crash.
1672 * src/modest-protocol-info.c:
1673 (modest_protocol_info_protocol_is_store):
1674 * src/modest-protocol-info.h:
1675 Added modest_protocol_info_get_auth_protocol_name()
1677 2007-06-03 Armin Burgmeier <armin@openismus.com>
1679 * src/modest-mail-operation.c:
1680 (modest_mail_operation_get_msgs_full): Set priv->account also when
1681 only retrieving a single message. This avoids a crash when canceling
1684 (modest_mail_operation_notify_end): Do not explicitely remove the
1685 operation from the queue but only emit the progress_changed signal.
1686 The queue itself listens to that signal to remove the operation when
1687 it is finished. This reduces coupling and removes a potential deadlock
1688 when modest_mail_operation_notify_end() is called from the queue
1689 itself. If that is a problem performance-wise, I would suggest to
1690 implement a status-changed signal or something.
1692 * src/modest-mail-operation-queue.c: Make sure to never call a
1693 function from another file while the queue is locked. This (hopefully)
1694 fixes another deadlock when exiting the application while retrieving
1697 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1699 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1700 Fixed build if libogs is not available
1702 2007-06-03 Christian Kellner <ckellner@openismus.com>
1704 * libmodest-dbus-client/libmodest-dbus-client.h:
1705 * libmodest-dbus-client/libmodest-dbus-client.c:
1706 (libmodest_dbus_client_delete_message):
1707 Implement deletion of messages (Client side).
1709 (modest_search_hit_free),
1710 (modest_search_hit_list_free):
1711 Utility functions to free the result hits.
1713 * src/dbus_api/modest-dbus-api.h:
1714 * src/dbus_api/modest-dbus-callbacks.c:
1715 (on_delete_message),
1716 (modest_dbus_req_handler):
1717 Implement deletion of messages (Server side).
1719 * tests/dbus_api/test_search.c: (main):
1722 * tests/dbus_api/Makefile.am:
1723 * tests/dbus_api/test_delete_message:
1724 Add little test for the message deletion logic
1726 2007-06-03 Armin Burgmeier <armin@openismus.com>
1728 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1729 when the operation queue was not empty. projects.maemo.org bug
1732 2007-06-03 Armin Burgmeier <armin@openismus.com>
1734 * src/widgets/modest-account-view.c
1735 (on_account_default_toggled): Toggle default account column
1736 explicitely instead of waiting for gconf notification (which is
1737 currently ignored). This should fix projects.maemo.org bug NB#56910
1738 for now. It should probably be removed when gconf notifications are
1741 2007-06-03 Christian Kellner <ckellner@openismus.com>
1743 * libmodest-dbus-client/libmodest-dbus-client.c:
1744 Removed debugging spew.
1746 * src/dbus_api/modest-dbus-callbacks.c:
1747 Added debugging info.
1749 * src/modest-search.c:
1750 (modest_search_all_accounts):
1751 Use tny_account_store_get_accounts () on the account store
1752 to get all accounts which is the way to get all accounts.
1754 * tests/dbus_api/test_search.c: (main):
1755 Make it possible to supply the search term on the command line.
1757 2007-06-03 Christian Kellner <ckellner@openismus.com>
1759 * libmodest-dbus-client/libmodest-dbus-client.c:
1760 * libmodest-dbus-client/libmodest-dbus-client.h:
1761 Implement searching for mesages over raw dbus. (Client side)
1763 * src/dbus_api/Makefile.am:
1764 * src/dbus_api/modest-dbus-api.h:
1765 * src/dbus_api/modest-dbus-callbacks.c:
1766 * src/dbus_api/modest-dbus-callbacks.h:
1767 Search framework (Server side). Also implement on_idle_open_message().
1769 * src/maemo/modest-platform.c: (modest_platform_init):
1770 Prepare for raw dbus/osso rpc interaction.
1772 * src/modest-search.h:
1773 Changed minsize from unspecific guint to guint32.
1775 * src/modest-search.c:
1777 Added strange hack which magically made tnymail work.
1779 (modest_search_folder),
1780 (modest_search_account),
1781 (modest_search_all_accounts):
1782 Implement helper functions to search all accounts, specific account
1785 * tests/dbus_api/Makefile.am:
1786 * tests/dbus_api/test_open_message.c:
1787 Read url to open from commandline.
1789 * tests/dbus_api/test_search.c:
1790 Implement small test for dbus search stuff
1792 2007-06-02 Armin Burgmeier <armin@openismus.com>
1794 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1795 include account type and account title. This fixes projects.maemo.org
1798 * src/maemo/modest-account-view-window.c: Set a title for the window.
1800 2007-06-02 Armin Burgmeier <armin@openismus.com>
1802 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1803 incoming and outgoing server name based on email address and server
1804 types as long as the names have not been edited manually. This fixes
1805 projects.maemo.org bug NB#58671.
1807 2007-06-02 Armin Burgmeier <armin@openismus.com>
1809 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1810 server type cannot be changed in future to the incoming details page
1811 when creating an account. This fixes projects.maemo.org bug NB#59029.
1813 2007-06-02 Armin Burgmeier <armin@openismus.com>
1815 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1816 and assigned max width chars so that they wrap instead of being
1817 truncated. Fixes projects.maemo.org bug NB#56126.
1819 2007-06-02 Armin Burgmeier <armin@openismus.com>
1821 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1822 introductory note to the connection specific smtp servers dialog, as
1823 section 8.12 of the email UI specification requires. This fixes
1824 projects.maemo.org bug NB#59212.
1826 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1828 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1829 Check for running mail operations, and offer to cancel them, as per the UI
1830 spec. This fixes projects.maemo.org bug NB#59041 .
1831 However, I suspect that tinymail may still use the network connection
1832 in ways that we cannot detect or cancel. But it should at least adapt to
1833 changes fairly well.
1835 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1837 * src/modest-tny-account-store.c: (recreate_all_accounts),
1838 (get_cached_accounts), (get_server_accounts): Do more sensible
1839 ref-counting of the temporarily-cached outbox accounts list. This seems
1840 to fix a crash when entering the password when the password was wrong.
1842 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1844 * src/gnome/modest-main-window.c: (connect_signals):
1845 * src/modest-tny-account-store.c: (get_password),
1846 (modest_tny_account_store_alert): Added comments and clues and
1847 commented-out code about how we currently fail to deal with connection
1848 errors and wrong passwords, and how we should.
1850 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1852 * src/widgets/modest-retrieve-combo-box.c:
1853 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1854 This fixes projects.maemo.org bug NB#58472 .
1856 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1858 * src/maemo/easysetup/modest-easysetup-wizard.c:
1859 (create_page_complete_easysetup):
1860 (create_page_complete_custom): Correct the last commit,
1861 putting the correct sentences in the correct pages.
1863 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1865 * src/maemo/easysetup/modest-easysetup-wizard.c:
1866 (create_page_complete_custom): Show the second sentence of text
1867 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1870 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1872 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1873 Set the leave-on-server conf key by default. This fixes
1874 projects.maemo.org bug NB#59258 .
1876 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1878 * src/maemo/modest-account-view-window.c:
1879 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1880 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1883 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1885 * src/maemo/easysetup/modest-easysetup-wizard.c:
1886 (create_caption_new_with_asterisk):
1887 * src/maemo/modest-account-settings-dialog.c:
1888 (create_caption_new_with_asterisk):
1889 Uncomment the code to add the asterisk, because they are no longer in the
1890 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1891 (update_incoming_server_title): Add an asterisk here too.
1893 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1895 * src/maemo/modest-maemo-global-settings-dialog.c:
1896 (current_connection): Check that we are even connected before trying to
1897 get the current connection name, to prevent a warning.
1899 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1900 Change the comments because tny_maemo_conic_device_connect() is now meant to
1902 * src/modest-mail-operation.c:
1903 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1904 make sure we have a connection and fail if we can't connect.
1906 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1908 * src/maemo/modest-main-window.c:
1909 (on_account_store_connecting_finished): Do not try to get the
1910 connection ID if we are not really connected. I am surprised that
1911 this signal handler is called when we are not connected.
1913 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1915 * src/modest-error.h:
1916 * src/modest-ui-actions.c:
1917 (modest_ui_actions_get_msgs_full_error_handler):
1918 Renamed an enum, added comments, added an enum
1919 for retrieve-limit errors.
1921 * src/modest-mail-operation.c: (foreach_add_item),
1922 (internal_folder_observer_update), (update_account_thread),
1923 (modest_mail_operation_get_msgs_full):
1924 (modest_mail_operation_update_account),
1925 Added comments about how this works, and some code that should
1926 (but does not) check the retrieve-limit. See the TODO comment.
1928 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1930 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1931 Initialize help_id to fix the build. Warnings are good.
1933 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1935 * src/widgets/modest-hbox-cell-renderer.c:
1936 (modest_hbox_cell_renderer_append):
1937 * src/widgets/modest-vbox-cell-renderer.c:
1938 (modest_vbox_cell_renderer_append):
1939 Fix the last commit by doing an extra ref.
1941 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1943 * src/widgets/modest-hbox-cell-renderer.c:
1944 (modest_hbox_cell_renderer_append):
1945 * src/widgets/modest-vbox-cell-renderer.c:
1946 (modest_vbox_cell_renderer_append):
1947 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1948 to fix the build with Maemo Bora.
1949 However, there seems to be a remaining crash, probably due to reference
1952 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1954 * src/modest-tny-account.c:
1955 (modest_tny_account_new_for_local_folders):
1956 Use hildon_file_system_info_async_new() to get a better name for
1957 the memory card account, setting it as the account name.
1958 The timing seems to work, but this is probably
1959 not the best place to do this. See the TODO comment.
1960 * src/maemo/modest-main-window.c: (create_details_widget):
1961 * src/widgets/modest-folder-view.c: (text_cell_data):
1962 Use the tny account name instead of hardcoding a name.
1964 2007-05-30 Christian Kellner <ckellner@openismus.com>
1966 * src/modest-search.c: (modest_search):
1967 Correctly set part_search_func even if we have already parsed
1968 the query and thus a valid OgsTextSearcher object.
1970 2007-05-30 Christian Kellner <ckellner@openismus.com>
1973 Search and check for libogs.
1976 Incooparte the ogs build env.
1978 * src/modest-mime-part-search-stream.c:
1979 * src/modest-mime-part-search-stream.h:
1980 Removed since we do the real searching now in modest-search.c.
1982 * src/modest-search.c:
1983 * src/modest-search.h:
1984 Implement support for ogs. We use that if available and requested
1985 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1986 should now handle the corner case when the search term is spread
1987 across multiple reads.
1988 Also the logic in modest_search () was corrected to search all
1989 requested fields until one is found.
1991 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1993 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1995 * src/modest-init.h:
1996 * src/modest-init.c: Made modest_init_local_folders() take a
1997 path and be public so we can iniitialize maildir folders on
2000 * src/modest-local-folder-info.h:
2001 * src/modest-local-folder-info.c:
2002 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2004 * src/modest-tny-account.c:
2005 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2006 still means the standard local-folders path on the local volume.
2008 * src/modest-tny-account-store.c:
2009 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2010 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2011 all accounts when that happens.
2012 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2013 this too, so it shows up in the treeview.
2015 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2017 * src/maemo/modest-maemo-global-settings-dialog.c:
2018 (current_connection):
2019 * src/widgets/modest-global-settings-dialog.c:
2020 (current_connection_default):
2021 Use the enum values instead of 0, 1 and -1,
2022 to make the code clearer.
2024 * src/modest-account-mgr-helpers.c:
2025 (modest_account_mgr_get_connection_specific_smtp): Make this code
2028 * src/modest-runtime.h:
2029 * src/modest-runtime.c:
2030 Added modest_runtime_remove_all_send_queues().
2031 * src/maemo/modest-main-window.c:
2032 (on_account_store_connecting_finished): Recreate the send queues,
2033 using the appropriate transport accounts for this new connection.
2034 Some futher adapting might be needed if the old send queues are not
2035 automatically stopped at this point.
2037 * src/modest-tny-account-store.c: (get_server_accounts):
2038 Create the connection-specific transport accounts, so that they can
2039 be found later by their ID.
2041 * src/modest-tny-account.h:
2042 * src/modest-tny-account.c:
2043 Added modest_tny_account_new_from_server_account_name().
2044 modest_tny_account_new_from_server_account(): Do not create the
2045 send queues here, because they will be
2046 recreated anyway when the connection changes for the first time.
2048 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2050 * src/modest-local-folder-info.h:
2051 * src/modest-local-folder-info.c:
2052 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2053 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2054 tbox_folder): Take a modest account name instead of a server TnyAccount,
2055 so we can have per-modest-account rather than per-transport-account
2057 We must make sure that we change or recreate the exisitng send queues
2058 when the connection changes for connection-specific transport accounts.
2060 * src/modest-tny-account-store.c:
2061 (create_per_account_local_outbox_folders): Create outboxed per modest
2062 account, not per transport account.
2064 * src/modest-tny-account.h:
2065 * src/modest-tny-account.c:
2066 (modest_tny_account_get_special_folder): For outboxes, get the
2067 parent modest account name. The account is ignored for other folders.
2068 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2069 modest account name rather than a server TnyAccount.
2071 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2073 * src/modest-tny-account.c:
2074 (modest_tny_account_new_from_server_account):
2075 Call modest_runtime_get_send_queue() immediately after creating transport
2076 accounts, so that they start trying to send email from the outbox as soon
2077 as possible at startup. This is probably what we want.
2079 * src/modest-mail-operation.c: (update_account_thread):
2080 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2081 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2082 * src/modest-tny-send-queue.h:
2083 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2084 (modest_ui_actions_on_send):
2085 Added comments about how sending works, though it needs some more work.
2087 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2089 * src/modest-tny-account.c:
2090 (modest_tny_account_get_special_folder): Add TODO because this fails when
2091 the network is busy.
2092 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2093 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2094 Do not try to show this window when there is no active account. The UI
2095 specs does not tell us what to do in this case.
2097 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2101 * src/maemo/Makefile.am:
2102 * src/widgets/Makefile.am: Some dist fixes.
2104 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2106 * src/maemo/modest-connection-specific-smtp-window.c:
2107 (on_button_edit): Make the code clearer, to prevent a double free.
2109 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2111 * src/maemo/modest-account-settings-dialog.c:
2112 (modest_account_settings_dialog_set_account_name),
2113 Check the connection-specific smtp servers checkbox if there are any.
2115 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2116 (modest_connection_specific_smtp_edit_window_init):
2117 Start with a suitable port number.
2119 * src/modest-account-mgr-helpers.h:
2120 * src/modest-account-mgr-helpers.c: Added
2121 modest_account_mgr_get_has_connection_specific_smtp().
2123 (modest_account_mgr_set_connection_specific_smtp),
2124 (modest_account_mgr_remove_connection_specific_smtp),
2125 (modest_account_mgr_get_has_connection_specific_smtp),
2126 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2127 connection-specific smtp server accounts in the account, rather than
2128 the server account conf dir.
2130 This fixes bug projects.maemo.org bug NB#58263 .
2132 * src/modest-tny-account-store.c:
2133 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2134 if there are no server accounts yet, to prevent an infinite loop when there
2135 are no accounts. Document that one must be called before the other.
2137 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2139 * src/modest-account-mgr-helpers.c:
2140 (modest_account_mgr_get_default_account): Make sure that at least
2141 one account is always the default, if there are any enabled accounts.
2142 This is just a sanity check that shouldn't be necessary.
2144 * src/modest-account-mgr-priv.c:
2145 (_modest_account_mgr_account_from_key): Unescape the conf key to
2146 get the real account name. For instance, this is an issue if a space
2147 was in the account name, which can happen because the account name
2148 is generated from the display name.
2149 (_modest_account_mgr_get_account_keyname): Always escape the
2151 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2152 Unescape the conf keys to get the real account names.
2154 For instance, previously the is-default radio button in the accounts
2155 list was not checked for any accounts at first. This fixes that,
2156 and might fix several similar bugs.
2158 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2160 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2161 Removed some debug printfs.
2163 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2165 Modest on-disk outbox directories are now here, for instance:
2166 $HOME/.modest/outboxes/<account-id-1>/outbox
2167 $HOME/.modest/outboxes/<account-id-2>/outbox
2169 $HOME/.modest/local-folders/outbox
2170 so we can have a separate outbox for each account.
2171 But they are shown as one outbox in the GtkTreeView, by using a
2172 TnyMergeFolder in a ModestTnySimpleFolderStore.
2175 * src/modest-tny-simple-folder-store.c:
2176 * src/modest-tny-simple-folder-store.h:
2177 Added ModestTnySimpleFolderStore, used to contain folders from
2178 other folder stores, such as other accounts.
2180 * src/modest-tny-outbox-account.h:
2181 * src/modest-tny-outbox-account.c:
2182 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2183 used for the per-account local outbox folders.
2185 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2186 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2187 only use this (internally) now for the non-outbox local folders.
2189 * src/modest-init.h:
2190 * src/modest-init.c: Added modest_init_one_local_folder(), for
2191 setting up the directory structure for each local folder.
2193 * src/modest-local-folder-info.c:
2194 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2195 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2197 * src/modest-local-folder-info.h:
2198 * src/modest-tny-account-store.c: (on_account_removed),
2199 (on_account_changed), (create_per_account_local_outbox_folders),
2200 (get_server_accounts), (modest_tny_account_store_get_accounts),
2201 (modest_tny_account_store_get_tny_account_by_account),
2202 (modest_tny_folder_store_is_virtual_local_folders):
2204 * src/modest-tny-account.h:
2205 * src/modest-tny-account.c:
2206 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2207 to create an on-disk per-account local outbox folder for each
2209 (create_per_account_local_outbox_folders): Create a local outbox folder
2210 for each transport account.
2211 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2212 for all local folders.
2214 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2215 instead of using g_object_get/set() directly. It is clearer.
2217 (modest_tny_folder_store_get_message_count),
2218 (modest_tny_folder_store_get_local_size
2219 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2220 because we now use these with non-acount folder stores.
2222 (modest_tny_account_get_special_folder),
2223 (modest_tny_account_new_from_server_account),
2224 (modest_tny_account_new_from_account):
2225 (recurse_folders): Adjust to the new outbox system.
2227 * src/modest-tny-folder.h:
2228 * src/modest-tny-folder.c:
2229 (modest_tny_folder_is_local_folder),
2230 (modest_tny_folder_get_local_folder_type),
2231 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2233 * src/widgets/modest-main-window.h:
2234 * src/maemo/modest-main-window.c: (create_details_widget),
2235 (modest_main_window_set_contents_style): Show details for any folder store,
2238 (modest_tny_folder_get_rules):
2239 Remove the const. C does not support constness enough for this.
2241 * src/modest-ui-actions.c:
2242 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2243 make all outboxes appear as one, in the usual local-folders tree node.
2245 (set_active_account_from_tny_account),
2246 (modest_ui_actions_on_folder_selection_changed):
2247 * src/widgets/modest-folder-view.c: (text_cell_data),
2248 (icon_cell_data), (filter_row),
2249 (add_account_folders_to_merged_folder),
2250 (add_account_folders_to_simple_folder_store), (),
2251 (get_cmp_rows_type_pos), (cmp_rows),
2252 (modest_folder_view_set_account_id_of_visible_server_account):
2253 Adjust to the new outbox system, using generic folder stores and folders
2254 in the GtkTreeModel.
2256 2007-05-23 Christian Kellner <ckellner@openismus.com>
2258 * src/modest-mail-operation.c:
2259 (modest_mail_operation_update_account):
2260 Use info->max_size instead of unintialized local var [small
2261 build fix]. (Added TODO to review that change since I don't
2264 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2266 * libmodest-dbus-client/libmodest-dbus-client.c:
2267 (libmodest_dbus_client_compose_mail): function added
2268 * src/dbus_api/modest-dbus-api.h:
2269 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2270 (on_compose_mail): Implementation of the SendAsMail functionality
2272 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2274 * src/modest-account-mgr.c:
2275 (modest_account_mgr_add_server_account): Set the secure-connection
2276 conf key for transport accounts as well as store accounts. I don't know
2277 why the if was there. For instance, this makes sure that we use SSL
2278 for the gmail preset from the easysetup wizard.
2280 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2282 * src/gnome/modest-main-window.c:
2283 (on_account_store_connecting_finished), (connect_signals):
2284 * src/maemo/modest-main-window.c:
2285 (on_account_store_connecting_finished), (connect_signals),
2286 (modest_main_window_new):
2287 Handle TnyAccountStore::connecting-finished instead of
2288 TnyDevice::connection-changed, because we cannot actually perform
2289 operations on accounts until TnyAccountStore has itself responded to
2290 the TnyDevice::connection-changed signal. This prevents a GError from
2292 Do not try to update at startup, because we (at least on scratchbox)
2293 already do an update at startup when the device goes online.
2294 This prevents a GError from tinymail.
2295 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2296 Added TODO about stopping simultaneous operations.
2298 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2300 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2301 * src/modest-mail-operation-queue.c:
2302 (modest_mail_operation_queue_remove):
2303 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2304 about where they happened.
2306 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2308 * src/modest-ui-actions.c:
2309 (modest_ui_actions_on_password_requested): Make sure that the remember
2310 output parameter is always TRUE.
2312 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2314 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2315 Show a OK/Cancel dialog if the error is a question, though we still do not
2316 know anything more about what we are asking the user.
2317 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2318 Fix an uninitialized variable (helper). This is a logic error, however.
2320 2007-05-21 Christian Kellner <ckellner@openismus.com>
2322 * src/modest-search.h:
2323 Correct bit shifting in the ModestSearchFlags enum.
2325 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2327 * src/modest-tny-account.c:
2328 (modest_tny_account_new_from_server_account): Do not use the lsub and
2329 check-all hard-coded IMAP options when using POP.
2331 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2333 * src/modest-tny-account.c:
2334 (modest_tny_account_new_from_server_account):
2335 Use NULL for the secure-auth method for POP when Password auth has been
2336 specified by the user, as we already do for IMAP. "auth=Login" causes
2337 an error from camel or the server.
2339 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2341 * src/maemo/modest-account-settings-dialog.c:
2342 (create_page_account_details),
2343 (modest_account_settings_dialog_set_account_name):
2344 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2345 for the leave-on-server checkbox, rathr than just the checkbox, when
2346 the protocol is not POP.
2348 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2350 * src/widgets/modest-account-view.c:
2351 * src/widgets/modest-account-view.h:
2352 Added modest_account_view_select_account() which will be useful later
2353 to asynchronously re-select the edited account.
2355 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2357 * src/maemo/modest-account-settings-dialog.c:
2358 (modest_account_settings_dialog_set_account_name):
2359 Automatically choose the port numbers based on the secure authentication
2360 methods, if they have not been chosen before.
2361 This fixes projects.maemo.org bug NB#56273 .
2363 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2365 * src/maemo/modest-main-window-ui.h:
2366 * src/modest-ui-actions.c:
2367 * src/modest-ui-actions.h:
2368 Connect the Tools/SMTP Servers menu item to
2369 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2370 SMTP servers dialog, as in the UI specification and saves changes when it
2371 is closed. This fixed projects.maemo.org bug NB#56305 .
2373 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2375 * src/maemo/modest-connection-specific-smtp-window.c:
2376 (modest_connection_specific_smtp_window_init):
2377 Use gtk_window_set_default_size() to make this window big enough, so
2378 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2380 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2382 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2383 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2384 (modest_connection_specific_smtp_edit_window_init),
2385 Do not try to connect to a combobox signal before the combobox exists.
2386 This fixes the cras in projects.maemo.org bug NB#56288 .
2387 (modest_connection_specific_smtp_edit_window_get_settings):
2388 Remove the server_account_name parameter which was being checked for NULL
2389 though it was not used.
2391 * src/maemo/modest-connection-specific-smtp-window.c:
2392 (modest_connection_specific_smtp_window_fill_with_connections),
2393 (on_button_edit), (modest_connection_specific_smtp_window_init):
2394 Correct the number of treemodel columns to prevent a warning.
2395 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2396 libconic does not work.
2398 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2400 * src/modest-tny-account.c:
2401 (modest_tny_account_new_from_server_account):
2402 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2403 SMTP when "None" was chosen by the user. However, with my SMTP server that
2404 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2407 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2409 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2410 to explain the memory management issue with the ID in the ModestPair.
2412 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2413 (add_sending_page), (modest_account_assistant_finalize):
2414 * src/gnome/modest-gnome-global-settings-dialog.c:
2415 (create_updating_page), (create_composing_page):
2416 * src/gnome/modest-msg-edit-window.c: (get_transports),
2417 (init_window), (modest_msg_edit_window_finalize),
2418 (modest_msg_edit_window_get_msg_data):
2419 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2420 * src/gnome/modest-transport-widget.c:
2421 (modest_transport_widget_finalize), (smtp_configuration):
2422 * src/maemo/modest-maemo-global-settings-dialog.c:
2423 (create_updating_page), (create_composing_page):
2424 * src/maemo/modest-msg-edit-window.c: (get_transports),
2425 (init_window), (modest_msg_edit_window_finalize),
2426 (modest_msg_edit_window_get_msg_data),
2427 (modest_msg_edit_window_free_msg_data):
2428 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2429 (modest_store_widget_finalize):
2430 * src/maemo/modest-transport-widget.c:
2431 (modest_transport_widget_finalize), (smtp_configuration):
2432 * src/modest-main.c: (send_mail):
2433 * src/widgets/modest-combo-box.h:
2434 * src/widgets/modest-global-settings-dialog-priv.h:
2435 * src/widgets/modest-global-settings-dialog.c:
2436 (modest_global_settings_dialog_finalize):
2437 * src/widgets/modest-msg-edit-window.h:
2438 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2439 as long as the combo box, to prevent use of freed memory for the ID.
2441 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2443 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2444 get_accounts(), to make this clearer. Do not check for the enabled gconf
2445 key, because we do not use this for server accounts (at least, not yet).
2446 This allows us to send email again.
2448 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2450 * src/maemo/modest-platform.c:
2451 (on_modest_conf_update_interval_changed), (modest_platform_init):
2452 Only respond to this particular key change. All these strcmp()s cannot be
2455 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2457 * src/maemo/modest-maemo-global-settings-dialog.c:
2458 (current_connection): Prevent a crash in scratchbox when
2459 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2460 * src/maemo/modest-platform.c:
2461 (on_modest_conf_update_interval_changed), (modest_platform_init):
2462 Get the update interval from gconf and reset it when the gconf key changes.
2464 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2466 * src/modest-protocol-info.c:
2467 * src/modest-protocol-info.h: Adde enum-specific get functions,
2468 instead of using a ModestProtocolType enum parameter.
2470 * src/gnome/modest-account-assistant.c:
2471 * src/gnome/modest-store-widget.c:
2472 * src/gnome/modest-store-widget.h:
2473 * src/gnome/modest-transport-widget.c:
2474 * src/gnome/modest-transport-widget.h:
2475 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2476 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2477 * src/maemo/easysetup/modest-easysetup-wizard.c:
2478 * src/maemo/modest-account-settings-dialog.c:
2479 * src/maemo/modest-account-settings-dialog.h:
2480 * src/maemo/modest-store-widget.c:
2481 * src/maemo/modest-store-widget.h:
2482 * src/maemo/modest-transport-widget.c:
2483 * src/maemo/modest-transport-widget.h:
2484 * src/modest-account-mgr-helpers.c:
2485 * src/modest-account-mgr-helpers.h:
2486 * src/modest-account-mgr.c:
2487 * src/modest-account-mgr.h:
2488 * src/modest-tny-account.c:
2489 * src/modest-tny-folder.c:
2490 * src/widgets/modest-account-view.c:
2491 * src/widgets/modest-retrieve-combo-box.c:
2492 * src/widgets/modest-retrieve-combo-box.h:
2493 * src/widgets/modest-secureauth-combo-box.c:
2494 * src/widgets/modest-serversecurity-combo-box.c:
2495 * src/widgets/modest-serversecurity-combo-box.h:
2496 * tests/check_account-mgr.c:
2497 Use the specific functions, and use the re-renamed enum values for GNOME too.
2499 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2501 * src/modest-pair.h:
2502 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2503 so we can get the second based on the first.
2505 * src/maemo/modest-account-settings-dialog.h:
2506 * src/maemo/modest-account-settings-dialog.c:
2507 Added get_supported_secure_authentication_methods(), though it is mostly
2508 commented-out for now until the necessary API is committed to tinymail.
2509 (modest_account_settings_dialog_set_account_name),
2510 (save_configuration): Request the supported authentication methods from the
2511 server, so we can choose a working method.
2513 * src/modest-tny-account-store.h:
2514 * src/modest-tny-account-store.c:
2515 (modest_tny_account_store_get_session): Rename from
2516 tny_account_store_get_session().
2518 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2520 * src/modest-protocol-info.h: Split the ModestProtocol enum
2521 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2522 There was no need to have these unrelated values in one enum.
2524 * src/: many files: Adapted to changed enum. This makes the code a bit
2525 clearer, and the compiler could catch some errors.
2527 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2529 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2530 Show the detailed internal camel error message when an error happens
2531 during the configuration, so that our testers can give us more clues.
2532 For instance, in projects.maemo.org bug NB#56910 .
2534 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2536 * src/modest-tny-account.c:
2537 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2538 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2540 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2542 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2543 * src/maemo/modest-account-settings-dialog.c:
2544 (modest_account_settings_dialog_set_account_name),
2545 (save_configuration): For the incoming secure authentication checkbox,
2546 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2547 the UI specification. PLAIN does not seem to be supported for most IMAP
2548 servers anyway, and I am not sure what it would mean.
2549 However, we probably need to discover which of the secure-authentication
2550 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2551 * src/modest-account-mgr-helpers.c:
2552 (modest_account_mgr_get_server_account_data):
2554 * src/modest-tny-account.c:
2555 (modest_tny_account_new_from_server_account):
2556 Use tny_account_set_mech() to set secure-authentication methods,
2557 with some special-casing for IMAP, based on my observations of how
2560 * src/modest-account-mgr-helpers.h:
2561 * src/modest-account-mgr.c:
2562 * src/modest-defs.h: Comment that the URI is only used for local folders.
2564 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2566 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2567 parameter const, just to be neat.
2568 * src/modest-text-utils.c: (modest_text_utils_inline):
2569 End g_strconcat() with NULL, as its documentation says. This is almost
2570 certainly the cause of my crash at startup on the device. Interestingly,
2571 valgrind doesn't tell us about these errors.
2573 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2575 * scripts/build-packages: Added more precise comments about how to use
2576 this script, though I still get this error:
2577 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2578 error building tinymail
2580 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2582 * src/maemo/modest-main-window.c: (on_account_update):
2583 Very slight cleanup, hoping to make it simpler to discover what causes
2584 a crash here sometimes.
2586 * src/modest-tny-account.c:
2587 (modest_tny_account_new_from_server_account): Set the port. Added
2588 comments about the options and a TODO comment because I need to find out
2589 how to specify the secure authentication method.
2591 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2593 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2594 changed CFlags paths form modest to libmodest
2596 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2598 * src/modest-account-mgr-helpers.c:
2599 (modest_account_mgr_get_server_account_data),
2600 (modest_account_mgr_free_server_account_data):
2601 * src/modest-account-mgr-helpers.h:
2602 * src/modest-account-mgr.c:
2603 (modest_account_mgr_add_server_account):
2604 * src/modest-defs.h:
2605 * src/modest-tny-account.c:
2606 (modest_tny_account_new_from_server_account):
2607 Determine the options for tny_camel_account_add_option() here,
2608 based on the settings, rather than storing them directly in gconf.
2610 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2612 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2613 Show a more friendly error dialog now that we expect (from the tinymail
2614 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2616 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2618 * src/maemo/modest-main-window.c: (on_account_update): Check that
2619 account_name is not NULL, to prevent a crash at startup that I am
2620 seeing on the N800. I do wonder why it is NULL.
2622 * src/maemo/easysetup/modest-easysetup-wizard.c:
2623 (create_page_user_details):
2624 * src/maemo/modest-account-settings-dialog.c:
2625 (create_page_user_details), (create_page_outgoing):
2626 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2627 (modest_connection_specific_smtp_edit_window_init):
2628 * src/modest-ui-actions.c:
2629 (modest_ui_actions_on_password_requested):
2630 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2631 might do something useful with the on-screen keyboard.
2633 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2635 * src/maemo/modest-main-window.c: (on_account_update):
2636 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2637 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2639 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2641 * src/modest-tny-account-store.c: (on_account_changed):
2642 Correct the signature of this signal handler.
2644 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2646 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2647 Show a HildonNote instead of a GtkDialog for Maemo.
2649 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2651 * src/widgets/modest-account-view.h:
2652 * src/widgets/modest-account-view.c: (on_account_changed),
2653 (on_account_removed). Added a boolean flag, set/unset by
2654 modest_account_view_block_conf_updates(),
2655 modest_account_view_unblock_conf_updates() to prevent unnecessary
2656 updates, but this is not very useful because the gconf notifications are
2657 so delays (maybe only on Maemo Bora).
2658 So auto-updating is turned off, and these functions do an explicit
2659 update when necessary.
2660 However, something else is still doing too much work when adding/removing
2661 accounts, probably in another part of the application.
2663 * src/maemo/modest-account-view-window.c:
2664 (on_delete_button_clicked), (on_edit_button_clicked),
2665 (on_new_button_clicked): Use the new functions.
2667 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2669 * src/modest-account-mgr-helpers.c:
2670 (modest_account_mgr_set_first_account_as_default):
2671 Sort the list of names alphabetically-by-title, so we choose the first one
2673 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2674 alphabetically by the title.
2676 This fixes projects.maemo.org bug NB#56418 .
2678 * src/modest-account-mgr-priv.c:
2679 (_modest_account_mgr_account_from_key):
2680 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2681 avoid a valgrind error, and possible random behaviour.
2683 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2685 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2686 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2687 tinymail documentation to say that this can be expected.
2688 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2689 pretty, and should not happen, but I would prefer to know when it does.
2691 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2693 * configure.ac: When using the older hildon version, probably on Bora,
2694 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2696 * src/widgets/modest-attachment-view.c:
2697 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2700 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2702 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2703 Implemented the prototype. Can be tested with
2704 tests/dbus_api/test_open_message:
2706 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2708 * src/modest-tny-account-store.c:
2709 (modest_tny_account_store_instance_init), (get_password):
2710 * src/modest-ui-actions.c:
2711 (modest_ui_actions_on_password_requested):
2712 Do not store the password in gconf, because this function is called
2713 for non-remembered passwords. Actually use the cached (in the hash map)
2714 password instead of releasing it.
2715 The password will now not be remembered if it is asked via the protected
2716 password dialog, as per the UI spec.
2718 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2720 * src/modest-defs.h:
2721 * src/modest-account-mgr-helpers.h:
2722 * src/modest-account-mgr-helpers.c:
2723 Added modest_server_account_get_username_has_succeeded(),
2724 modest_server_account_set_username_has_succeeded().
2725 (modest_server_account_set_username),
2726 Reset the has-succeeded flag if the username changes.
2728 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2729 * src/maemo/modest-connection-specific-smtp-window.c:
2730 (modest_connection_specific_smtp_window_save_server_accounts):
2731 Use modest_server_account_set_username() instead of using
2732 modest_conf_set_string() directly, so that the has-succeeded flag is always
2735 * src/modest-ui-actions.c:
2736 (modest_ui_actions_on_password_requested): Dim the username entry if
2737 the username has ever worked, as per the UI spec.
2739 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2741 * src/modest-tny-account-store.c: (get_password):
2742 * src/modest-ui-actions.c:
2743 (modest_ui_actions_on_password_requested):
2744 Allow the username to be changed too, though there is more work to
2745 be done on exactly how this behaves.
2747 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2749 * src/modest-account-mgr-helpers.h:
2750 * src/modest-account-mgr-helpers.c:
2751 Added modest_account_mgr_get_display_name(),
2752 modest_server_account_get_username(),
2753 modest_server_account_set_username(),
2754 modest_server_account_set_password(),
2755 modest_server_account_get_hostname() functions so we do not need to
2756 use the conf API directly.
2758 * src/maemo/modest-main-window.c: (connect_signals):
2759 Actually connect ot the ModestAccountStore::request-password signal,
2760 so that we show the dialog when the password is requested by Tinymail,
2761 for isntance if it is empty.
2763 * src/modest-marshal.list:
2764 * src/modest-tny-account-store.c:
2765 (modest_tny_account_store_class_init), (get_password),
2766 (modest_tny_account_store_alert):
2767 * src/modest-tny-account-store.h:
2768 * src/modest-ui-actions.h:
2769 * src/modest-ui-actions.c:
2770 (modest_ui_actions_on_password_requested):
2771 Change the signal parameters, so it is obvious that we are providing
2772 the non human-readable server name, and receiving both the username
2773 and password, though changing of the username is not yet implemented.
2774 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2775 for the GNOME version.
2777 This should fix the projects.maemo.org bug NB#56209, though it does not
2778 work on Bora, because the gconf_client_get() for the password fails
2779 immediately after we save it with gconf_client_set().
2781 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2784 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2785 caused an undefined symbol error:
2786 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2788 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2790 * src/modest-tny-account-store.c:
2791 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2792 using a GError instead of a string message, so we can translate it in
2795 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2797 * src/maemo/modest-address-book.c:
2798 (modest_address_book_check_names):
2799 * src/maemo/modest-msg-view-window.c:
2800 (modest_msg_view_window_clipboard_owner_change):
2801 * src/modest-init.c: (modest_init_init_ui):
2802 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2803 (update_folders_cb), (modest_mail_operation_update_account):
2804 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2805 (modest_ui_actions_on_msg_attachment_clicked),
2806 (modest_ui_actions_on_msg_recpt_activated):
2807 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2808 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2809 (modest_msg_view_search_next):
2810 * src/widgets/modest-recpt-editor.c:
2811 (modest_recpt_editor_on_button_release_event),
2812 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2813 g_message(). At this point we should only be seeing interesting errors on
2814 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2816 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2818 (modest_wizard_dialog_force_title_update):
2819 * src/maemo/easysetup/modest-wizard-dialog.h:
2820 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2821 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2822 can update the title when appropriate. Otherwise the title is wrong if the
2823 pages are added after adding the notebook to the dialog.
2824 This must be a problem in HildonWizardDialog too.
2825 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2827 * src/maemo/easysetup/modest-easysetup-wizard.c:
2828 (create_subsequent_customsetup_pages),
2829 (create_subsequent_easysetup_pages):
2830 Call modest_wizard_dialog_force_title_update() so that the title is
2831 correct even with GTK+ < 2.10.
2832 This fixes projects.maemo.org bug NB#56145 .
2834 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2836 * src/maemo/modest-platform.c:
2837 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2838 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2841 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2843 * src/widgets/modest-window.h:
2844 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2845 and modest_window_save_state(), which invokes it.
2847 * src/widgets/modest-window-mgr.h:
2848 * src/widgets/modest-window-mgr.c:
2849 Added modest_window_mgr_save_state_for_all_windows(), which calls
2850 the save_state vfunc on all registered windows, if implemented.
2852 * src/gnome/modest-msg-edit-window.c:
2853 * src/gnome/modest-msg-view-window.c:
2854 * src/maemo/modest-msg-edit-window.c:
2855 * src/maemo/modest-msg-view-window.c:
2856 * src/maemo/modest-main-window.c:
2857 Specify the existing save_settings functions as implementations of
2858 ModestWindow::save_state_func().
2860 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2861 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2862 enabling hibernation, for instance.
2864 We may need to do the same thing for restoring settings.
2867 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2869 * src/widgets/modest-window-mgr.c:
2870 * src/widgets/modest-window-mgr.h:
2871 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2872 modest_window_mgr_get_hibernation_is_prevented().
2874 * src/maemo/modest-main-window.c:
2875 (on_hildon_program_is_topmost_notify): Prevent hibernation
2876 (possible when the application goes to the background in the WM),
2877 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2879 * src/maemo/easysetup/modest-easysetup-wizard.c:
2880 (modest_easysetup_wizard_dialog_init):
2881 * src/maemo/modest-account-settings-dialog.c:
2882 (modest_account_settings_dialog_init):
2883 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2884 (modest_connection_specific_smtp_edit_window_init):
2885 * src/maemo/modest-connection-specific-smtp-window.c:
2886 (modest_connection_specific_smtp_window_init):
2887 * src/maemo/modest-signature-editor-dialog.c:
2888 (modest_signature_editor_dialog_init):
2889 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2890 prevent hibernation while any of these account settings dialogs are open.
2892 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2894 * src/maemo/Makefile.am:
2895 * src/maemo/modest-osso-state-saving.c:
2896 * src/maemo/modest-osso-state-saving.h: Added
2897 modest_osso_load_state() and modest_osso_save_state() though they do
2898 nothing now. They should iterate through all the open windows and load/save
2900 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2901 save state when closing.
2903 * src/maemo/modest-main-window.c:
2904 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2905 Add a notification handler for the HildonProgram::is-topmost property,
2906 so we can allow hibernation when the application goes into the background.
2907 But we still need to detect when the accounts setup windows are open so
2908 we can stop hibernation when they are open.
2909 To do this, I also added the main window the HildonProgram. This might have
2910 other side-effects/benefits, and should maybe be done for other windows.
2912 * src/maemo/modest-osso-autosave-callbacks.h:
2913 * src/maemo/modest-osso-autosave-callbacks.c:
2914 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2915 though it does not do anything yet, and we might never need this to do
2916 anything. For instance, we already save drafts.
2918 * src/maemo/modest-platform.c: (modest_platform_init):
2919 Specify the libosso auto-save callback.
2921 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2923 * src/maemo/modest-platform.c:
2924 (modest_platform_set_update_interval):
2925 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2926 aparently stays valid between application instances, so we can use this
2927 to remove and reset it later. According to a maemo-developers email from
2930 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2932 * configure.ac: Depend on libalarm for Maemo.
2934 * src/dbus_api/modest-dbus-api.h:
2935 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2936 (on_send_receive), (modest_dbus_req_handler):
2937 Handle a SEND_RECEIVE D-Bus method.
2939 * libmodest-dbus-client/libmodest-dbus-client.c:
2940 (libmodest_dbus_client_send_and_receive):
2941 * libmodest-dbus-client/libmodest-dbus-client.h:
2942 Add C convenience functions for calling the new D-Bus method.
2944 * src/modest-platform.h:
2945 * src/gnome/modest-platform.c:
2946 * src/maemo/modest-platform.c:
2947 Added modest_platform_set_update_interval(), which uses the
2948 alarmd API on Maemo.
2949 (modest_platform_init),
2950 Call modest_platform_set_update_interval(), using a hard-coded
2951 interval for now (until the global settings dialog is implemented),
2952 though I am not sure that this makes sense yet.
2954 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2956 * src/dbus_api/modest-dbus-callbacks.c:
2957 (modest_osso_cb_hw_state_handler):
2958 * src/dbus_api/modest-dbus-callbacks.h:
2959 * src/maemo/modest-platform.c: (modest_platform_init):
2960 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2961 in case this has some effect on the ability for Maemo to ping the
2964 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2966 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2967 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2968 warning. It is probably a logic error, but I need to fix the build.
2970 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2972 * src/modest-account-mgr.h:
2973 * src/modest-account-mgr.c:
2974 (modest_account_mgr_account_names): Add a gboolean enabled_only
2975 parameter, so we can get lists of onlt the enabled accounts.
2977 (modest_account_mgr_add_account),,
2978 (modest_account_mgr_account_with_display_name_exists):
2979 * src/maemo/modest-msg-edit-window.c: (get_transports):
2980 * src/modest-account-mgr-helpers.c:
2981 (modest_account_mgr_set_first_account_as_default):
2982 * src/modest-init.c: (init_default_account_maybe):
2983 * src/modest-tny-account-store.c: (get_accounts):
2984 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2985 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2986 * tests/check_account-mgr.c: (START_TEST):
2987 Provide the extra parameter, as appropriate.
2989 * src/widgets/modest-account-view.c: (update_account_view):
2990 Do not show disabled accounts (meaning that there is no way to
2991 enable/disable accounts in the UI (the feature is not in our UI
2992 specification), so we can use this internally only to mark unfinished
2993 or temporary account data.
2995 * src/maemo/easysetup/modest-easysetup-wizard.c:
2996 (create_account): Add boolean enable parameter, so we can specify FALSE
2997 to create the temporary account.
2998 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2999 (on_before_next): When finishing, when there is a temporary account, just
3001 Also, use a timeout to delay the showing of the dialog until gconf is likely
3002 to return correct information, due to a maemo gconf bug that is fixed in
3003 osso 1.1, but not yet in Bora.
3004 However, the dialog stays on screen after it is destroyed.
3006 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3007 for invalid data when cancelling. Use a hildon note instead of a dialog
3008 to complain about invalid data. Do not show the account-saved note if the
3009 account is disabled (a temporary account that will not really be saved for use
3012 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3014 * src/modest-account-mgr-helpers.h:
3015 * src/modest-account-mgr-helpers.c:
3016 Added modest_account_mgr_unset_default_account(),
3017 Added modest_account_mgr_set_first_account_as_default().
3019 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3020 If it was the default account, unset the default account name.
3022 * src/maemo/modest-account-view-window.c:
3023 (on_delete_button_clicked): If it was the default account,
3024 set the first remaining account as the default instead.
3026 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3027 a NULL account or a NULL default account, to prevent a crash. This should
3028 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3031 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3033 * src/widgets/modest-recpt-editor.c:
3034 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3035 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3036 TODO comment for this. This fixes the build.
3038 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3039 be the best place for it. This will in future update all auto-update accounts,
3040 rather than just the current/default account, when that gconf key exists.
3041 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3042 if there are no accounts, before calling do_send_receive().
3043 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3045 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3046 * src/maemo/modest-main-window-ui.h:
3047 * src/maemo/modest-main-window.c: (on_connection_changed),
3048 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3049 directly, becaue the signal handler does more.
3051 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3053 * src/modest-account-mgr-helpers.c:
3054 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3055 for the case that the account does not exist.
3057 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3058 (equivalent to the modest account name) rather than the tinymail account name
3059 (equivalent to the modest account title - human readable) to get the account data.
3060 Check for null account data to prevent the crash, and add a TODO comment saying that
3061 this needs fixing because it is using the server account name instead of the account name.
3063 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3065 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3066 * src/maemo/modest-account-settings-dialog.c: (show_error),
3068 Use hildon_note_new_information() for informative and error messages,
3069 which seems to be expected for Maemo applications (no documentation that I know of
3070 says this). I am surprised that there is no distinction between info and error
3073 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3075 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3076 it is easy to find where this is used.
3078 * src/maemo/easysetup/modest-easysetup-wizard.c:
3079 (create_page_welcome), (create_page_account_details),
3080 (create_page_user_details), (create_page_complete_easysetup),
3081 (create_page_custom_incoming), (create_page_custom_outgoing),
3082 (create_page_complete_custom):
3083 * src/maemo/modest-account-settings-dialog.c:
3084 (create_page_account_details), (create_page_user_details),
3085 (create_page_incoming), (create_page_outgoing):
3086 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3087 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3088 (modest_connection_specific_smtp_edit_window_init):
3089 * src/maemo/modest-connection-specific-smtp-window.c:
3090 (modest_connection_specific_smtp_window_init):
3091 * src/maemo/modest-signature-editor-dialog.c:
3092 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3093 and scrolling policy as per the Email Application Layout Guide, if I have
3096 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3098 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3099 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3100 which were empty, because these vfuncs have been removed from TnyAccountStore.
3101 This fixes the build.
3103 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3105 * src/maemo/modest-main-window.c:
3106 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3107 showing/hiding it. Added TODO because it probably should not be NULL.
3108 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3109 because unnecessary g_warnings() make degugging difficult.
3111 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3113 * src/maemo/modest-msg-edit-window.c:
3114 (modest_msg_edit_window_select_color),
3115 (modest_msg_edit_window_select_background_color): 2 const corrections and
3116 moving 2 #endifs before closing brackets, to fix the build.
3118 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3120 * src/maemo/easysetup/modest-easysetup-wizard.h:
3121 * src/maemo/easysetup/modest-easysetup-wizard.c:
3122 (modest_easysetup_wizard_dialog_finalize),
3123 (on_button_edit_advanced_settings), (create_page_complete_custom),
3124 (on_response), (create_account):
3125 Implement the Advanced Settings edit button, by saving the account information,
3126 for the Advanded Settings dialog to use directly from gconf, and removing it
3127 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3128 Bug #5533 in the projects.maemo.org bugzilla.
3130 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3132 * src/maemo/modest-msg-view-window.c:
3133 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3134 when opening a message window.
3136 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3138 * src/maemo/easysetup/modest-easysetup-wizard.c:
3139 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3142 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3143 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3144 gconf settings. I probably added more checks than necessary, but that is safer.
3146 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3147 variable to fix the build, but this seems to be used when it is still NULL.
3149 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3151 * src/modest-platform.h:
3152 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3153 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3154 * src/modest-main.c: Implement this function so we can avoid using
3155 maemo-specific API from cross-platform code.
3157 * src/modest-tny-account-store.c:
3158 (get_smtp_specific_transport_account_for_open_connection):
3159 * src/modest-ui-actions.c: (check_for_connection),
3160 (modest_ui_actions_on_item_not_found):
3161 Use modest_platform_connect_and_wait() and put #idefs around other
3162 maemo-specific code, because only maemo currently has a way to
3163 identify connection names.
3165 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3167 * src/modest-tny-account-store.h:
3168 * src/modest-tny-account-store.c:
3169 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3170 the connection-specific SMTP server settings in the configuration.
3172 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3174 * src/maemo/modest-main-window.c: (on_connection_changed),
3176 * src/modest-main.c: (main), (start_ui), (send_mail):
3177 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3178 that is what is intended.
3180 * src/modest-ui-actions.c: (action_send), (action_receive),
3181 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3182 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3183 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3184 SMTP server is used when it is specified.
3186 (modest_ui_actions_on_send_receive):
3187 Check that a connection is open before proceeding.
3188 Receive and then send, instead of vice-versa, as per the specification.
3190 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3192 * src/modest-mail-operation.c:
3193 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3194 though I guess it should be something other than NULL.
3196 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3198 * src/maemo/easysetup/modest-easysetup-wizard.c:
3199 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3200 combo twice, to avoid an g_warning and to make it visible again.
3201 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3202 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3203 (already intended) dereference when detaching, because we then recreate the menu.
3204 But I am not sure why the warning was happening, and it is possible that this is a memory
3207 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3209 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3210 and uri_parse_mailto() utility functions.
3211 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3213 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3215 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3217 * src/dbus_api/modest-dbus-api.h:
3218 * src/dbus_api/modest-dbus-callbacks.c:
3219 Use an idle callback to execute the modest code in the application's own thread.
3220 Remove the helloworld example method.
3221 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3222 parsed, and the open-message method is not implemented because this is not yet implemented in
3224 * libmodest-dbus-client/libmodest-dbus-client.c:
3225 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3226 (libmodest_dbus_client_open_message):
3227 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3229 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3230 body without crashing.
3232 * tests/dbus_api/Makefile.am:
3233 * tests/dbus_api/test_mail_to.c:
3234 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3236 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3238 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3239 Added file to fix the build. Sorry.
3241 * src/dbus_api/Makefile.am:
3242 * src/dbus_api/modest-dbus-api.h:
3243 * src/dbus_api/modest-dbus-callbacks.h:
3244 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3245 (modest_dbus_req_handler):
3246 Put constants in a separate header so it can be reused by the
3247 client library, without duplication
3249 * libmodest-dbus-client/Makefile.am:
3250 * libmodest-dbus-client/libmodest-dbus-client.c:
3251 (libmodest_dbus_client_call_helloworld),
3252 (libmodfest_dbus_client_send_mail),
3253 (libmodfest_dbus_client_mailto),
3254 (libmodfest_dbus_client_open_message):
3255 * libmodest-dbus-client/libmodest-dbus-client.h:
3256 (Partly) Implement a send_mail D-Bus method.
3258 * tests/dbus_api/Makefile.am:
3259 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3260 the send_email D-Bus method.
3262 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3266 * libmodest-dbus-client/Makefile.am:
3267 * libmodest-dbus-client/libmodest-dbus-client.c:
3268 * libmodest-dbus-client/libmodest-dbus-client.h:
3269 * tests/dbus_api/Makefile.am:
3270 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3271 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3273 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3275 * src/maemo/easysetup/modest-easysetup-wizard.c:
3276 (create_page_account_details):
3277 * src/maemo/modest-account-settings-dialog.c:
3278 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3279 widgets, because this might not be the default in future versions of the Maemo GTK+.
3280 However, I can not not get capitalization to work even in a simple test case.
3282 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3284 * src/maemo/easysetup/modest-easysetup-wizard.c:
3285 (create_page_custom_incoming), (create_page_custom_outgoing):
3286 * src/maemo/modest-account-settings-dialog.c:
3287 (create_page_account_details), (create_page_incoming),
3288 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3289 instead of using gtk_check_button_with_label(), so they are aligned like the other
3290 widgets, as per the UI spec.
3292 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3294 * src/maemo/easysetup/modest-easysetup-wizard.c:
3295 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3296 * src/widgets/modest-validating-entry.c:
3297 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3298 Modest prefix instead of an EasySetup prefix.
3300 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3302 * src/widgets/modest-validating-entry.h:
3303 * src/widgets/modest-validating-entry.c: (on_insert_text),
3304 Added easysetup_validating_entry_set_max_func(), used to set a callback
3305 to call when the max number of characters is reached. GtkEntry has a max-length
3306 already but is silent about it.
3308 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3309 (create_page_account_details), (create_page_user_details),
3311 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3312 (create_page_account_details), (create_page_user_details),
3313 (create_page_outgoing):
3314 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3315 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3316 the UI spec, when the user tries to enter more than the max number of characters.
3318 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3320 * src/maemo/easysetup/modest-easysetup-wizard.c:
3321 (create_page_user_details), (create_page_custom_incoming),
3322 (create_page_custom_outgoing):
3323 * src/maemo/modest-account-settings-dialog.c:
3324 (create_page_user_details), (create_page_incoming),
3325 (create_page_outgoing):
3326 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3327 (modest_connection_specific_smtp_edit_window_init):
3328 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3329 not appropriate. Bad Maemo-specific defaults!.
3331 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3333 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3334 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3335 (modest_signature_editor_dialog_set_settings):
3336 Disable the label and textview when the checkbox is disabled, and use the
3337 specified (UI spec) default signature text.
3339 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3341 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3342 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3344 * src/modest-defs.h:
3345 * src/modest-account-mgr-helpers.h:
3346 * src/modest-account-mgr-helpers.c:
3347 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3349 * src/maemo/Makefile.am:
3350 * src/maemo/modest-signature-editor-dialog.c:
3351 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3354 * src/maemo/modest-account-settings-dialog.h:
3355 * src/maemo/modest-account-settings-dialog.c:
3356 (modest_account_settings_dialog_finalize), (on_button_signature),
3357 (save_configuration): Use the new dialog when the Edit button is pressed, and
3358 save the changes if necessary, as per the UI spec.
3360 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3362 * src/maemo/Makefile.am:
3363 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3364 based on maemo-develoers email from Dirk.
3366 * src/maemo/easysetup/modest-easysetup-wizard.c:
3367 (create_page_welcome), (create_page_account_details),
3368 (create_page_user_details), (create_page_complete_easysetup),
3369 (create_page_custom_incoming), (create_page_custom_outgoing),
3370 (create_page_complete_custom),
3371 (modest_easysetup_wizard_dialog_init):
3372 * src/maemo/modest-account-settings-dialog.c:
3373 (create_page_account_details), (create_page_user_details),
3374 (create_page_incoming), (create_page_outgoing),
3375 (modest_account_settings_dialog_init):
3376 * src/maemo/modest-connection-specific-smtp-window.c:
3377 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3379 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3381 * src/maemo/easysetup/modest-easysetup-wizard.c:
3382 (create_page_account_details), (create_page_custom_outgoing),
3383 (create_page_complete_custom):
3384 * src/maemo/modest-account-settings-dialog.c:
3385 (create_page_user_details), (create_page_incoming),
3386 (create_page_outgoing):
3387 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3388 (modest_connection_specific_smtp_edit_window_init):
3389 Use the correct (UI spec) port min/max, and use horizontal separators,
3392 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3394 * src/maemo/easysetup/modest-easysetup-wizard.c:
3395 (set_default_custom_servernames):
3396 * src/maemo/modest-account-settings-dialog.c:
3397 (create_page_incoming), (on_combo_outgoing_security_changed),
3398 (on_combo_incoming_security_changed), (create_page_outgoing),
3399 (modest_account_settings_dialog_set_account_name),
3400 (save_configuration):
3401 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3402 (on_combo_security_changed),
3403 (modest_connection_specific_smtp_edit_window_init),
3404 (modest_connection_specific_smtp_edit_window_set_connection),
3405 (modest_connection_specific_smtp_edit_window_get_settings):
3406 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3409 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3412 * src/maemo/easysetup/modest-easysetup-wizard.c:
3413 (create_page_custom_outgoing), (create_page_complete_custom):
3414 * src/maemo/modest-account-settings-dialog.c:
3415 (create_page_user_details), (create_page_outgoing):
3416 * src/maemo/modest-account-view-window.c: (button_box_new):
3417 Use changed logical IDs as per the most recent UI spec:
3418 mcen_bd_emailsetup_edit -> mcen_bd_edit
3419 mcen_bd_emailsetup_delete -> mcen_bd_delete
3420 mcen_bd_emailsetup_close -> mcen_bd_close
3422 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3426 * src/dbus_api/Makefile.am:
3427 * src/dbus_api/modest-dbus-callbacks.c:
3428 * src/dbus_api/modest-dbus-callbacks.h:
3429 * src/maemo/modest-platform.c: (modest_platform_init):
3430 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3432 * tests/Makefile.am:
3433 * tests/dbus_api/Makefile.am:
3434 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3436 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3438 * src/maemo/modest-account-settings-dialog.c:
3439 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3440 Removed unnecessary includes.
3442 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3444 * src/maemo/easysetup/modest-easysetup-wizard.c:
3445 * src/maemo/modest-account-settings-dialog.c:
3446 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3447 * src/widgets/Makefile.am:
3448 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3449 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3450 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3451 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3452 * src/widgets/modest-secureauth-combo-box.c:
3453 * src/widgets/modest-secureauth-combo-box.h:
3454 * src/widgets/modest-serversecurity-combo-box.c:
3455 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3456 made the GObject names more consistent with the rest of the Modest code.
3458 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3460 * src/maemo/easysetup/Makefile.am:
3461 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3462 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3463 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3464 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3465 * src/maemo/easysetup/modest-easysetup-wizard.c:
3466 * src/maemo/easysetup/modest-validating-entry.c:
3467 * src/maemo/easysetup/modest-validating-entry.h:
3468 * src/maemo/modest-account-settings-dialog.c:
3469 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3470 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3471 widgets/ because they are used outside of easysetup too. After checking in,
3472 svn will allow me to rename them too.
3474 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3476 * src/gnome/modest-msg-edit-window.c:
3477 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3478 linker error, to fix the build on the GNOME platform.
3479 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3480 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3481 ifdefed out to avoid a warning.
3483 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3485 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3486 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3487 some alternative for GTK+ 2.6.
3489 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3491 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3493 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3494 specified for EmailAccountsDialog in UI spec.
3496 * src/maemo/easysetup/modest-easysetup-wizard.c:
3497 * src/maemo/easysetup/modest-easysetup-wizard.h:
3498 * src/maemo/modest-account-settings-dialog.c:
3499 * src/maemo/modest-account-settings-dialog.h:
3500 Reuse a member window widget for the connection-specific SMTP server accounts,
3501 so we can tell it to create/save the accounts only if we actually save changes.
3503 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3504 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3505 (modest_connection_specific_smtp_edit_window_get_settings):
3506 Return a struct instance for temporarily remembering the entered data.
3508 * src/maemo/modest-connection-specific-smtp-window.h:
3509 * src/maemo/modest-connection-specific-smtp-window.c:
3510 (modest_connection_specific_smtp_window_finalize),
3511 (modest_connection_specific_smtp_window_fill_with_connections),
3513 (modest_connection_specific_smtp_window_save_server_accounts),
3514 (update_model_server_names): Do not actually save data until asked,
3515 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3517 (on_selection_changed),
3518 (modest_connection_specific_smtp_window_init): Disable the edit
3519 button when nothing is selected.
3521 * src/modest-account-mgr-helpers.c:
3522 * src/modest-account-mgr-helpers.h:
3523 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3526 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3528 * src/modest-account-mgr-helpers.h:
3529 * src/modest-account-mgr-helpers.c:
3530 (modest_account_mgr_get_unused_account_name),
3531 (modest_account_mgr_get_unused_account_display_name): Added these
3532 utility functions, to avoid code duplication.
3534 * src/maemo/easysetup/modest-easysetup-wizard.c:
3535 (create_page_account_details), (create_account):
3536 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3537 (on_combo_security_changed),
3538 (modest_connection_specific_smtp_edit_window_init),
3539 (modest_connection_specific_smtp_edit_window_save_settings):
3540 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3541 * src/maemo/modest-connection-specific-smtp-window.c:
3542 (modest_connection_specific_smtp_window_finalize),
3543 (modest_connection_specific_smtp_window_fill_with_connections),
3544 (on_button_edit), (modest_connection_specific_smtp_window_init):
3545 * src/maemo/modest-connection-specific-smtp-window.h:
3546 Implementing saving of connection-specific server accounts.
3548 But I need to refactor this so we can save the data for each
3549 possible connection-specific account and only actually create the server accounts
3550 when the easysetup finished, or the OK button is pressed on the account settings
3553 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3555 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3556 (on_combo_security_changed):
3557 (modest_connection_specific_smtp_edit_window_init):
3558 Auto-fill the port number as in the account settings.
3560 (modest_connection_specific_smtp_edit_window_set_connection):
3561 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3562 * src/maemo/modest-connection-specific-smtp-window.c:
3563 (fill_with_connections), (on_button_edit),
3564 (modest_connection_specific_smtp_window_init):
3565 Turn the edit window into a dialog to simplify the code, and
3566 set a WM hint as in a GtkDialog, because only a popup can be on top of
3567 another window in Maemo, and popups usually have no WM decoration.
3569 * src/modest-defs.h:
3570 * src/modest-account-mgr-helpers.c:
3571 (modest_account_mgr_set_connection_specific_smtp),
3572 (modest_account_mgr_remove_connection_specific_smtp),
3573 (modest_account_mgr_get_connection_specific_smtp):
3574 * src/modest-account-mgr-helpers.h: Some functions to write the
3575 connection-specific SMTP server information. Not yet used.
3578 * src/widgets/modest-folder-view.c: (text_cell_data):
3579 Fix a warning about an uninitialized variable.
3580 (on_configuration_key_changed): Put an #ifdef around the use
3581 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3583 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3585 * src/maemo/modest-account-settings-dialog.h:
3586 * src/maemo/modest-account-settings-dialog.c:
3587 Added connect_for_modified() utility function to mark the new modified boolean.
3589 (create_page_account_details), (create_page_user_details),
3590 (create_page_incoming), (create_page_outgoing), (on_response),
3591 (modest_account_settings_dialog_init),
3592 (modest_account_settings_dialog_set_account_name):
3593 Only warn about unsaved changes when there are actually unsaved changes.
3595 * src/modest-account-mgr-helpers.c:
3596 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3597 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3598 to get the data from there in future.
3600 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3602 * src/modest-defs.h:
3604 * src/modest-account-mgr-helpers.h:
3605 * src/modest-account-mgr-helpers.c:
3606 Store the security account setting in a single conf key instead of using
3607 the options list, so that the list is left for just the to-be-removed camel hack,
3608 and because gconf_client_set_list() is failing for some reason.
3610 * src/modest-account-mgr.c:
3611 (modest_account_mgr_add_server_account):
3612 * src/maemo/modest-account-settings-dialog.c:
3613 (modest_account_settings_dialog_set_account_name),
3614 (save_configuration): Use the renamed functions.
3617 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3619 * src/widgets/Makefile.am:
3620 * src/widgets/modest-limit-retrieve-combo-box.c:
3621 * src/widgets/modest-limit-retrieve-combo-box.h:
3622 * src/widgets/modest-retrieve-combo-box.c:
3623 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3624 the account settings dialog.
3626 * src/modest-defs.h:
3627 * src/modest-account-mgr-helpers.h:
3628 * src/modest-account-mgr-helpers.c:
3629 (modest_server_account_get_option_secure_auth),
3630 (modest_server_account_set_option_secure_auth):
3631 * src/modest-account-mgr.c:
3632 (modest_account_mgr_add_server_account):
3633 Use the existing AUTH_MECH conf key for the secure-auth setting,
3634 instead of putting it in the list options, because this was actually used already.
3636 * src/maemo/modest-account-settings-dialog.c:
3637 (create_page_account_details),
3638 (modest_account_settings_dialog_set_account_name),
3639 (save_configuration):
3640 * src/maemo/modest-account-settings-dialog.h:
3641 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3642 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3644 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3646 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3647 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3648 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3650 * src/modest-defs.h:
3651 * src/maemo/modest-account-settings-dialog.c:
3652 (create_page_incoming), (on_combo_outgoing_security_changed),
3653 (on_combo_incoming_security_changed), (create_page_outgoing),
3654 (modest_account_settings_dialog_set_account_name),
3655 (save_configuration): Load/Save the port number, and change it when the
3656 security combo changes, to suitable defaults.
3658 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3660 * src/modest-account-mgr.c:
3661 (modest_account_mgr_add_server_account): Set the security and secure-auth
3662 options, and add a comment saying that the other camel-specific options should be
3665 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3667 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3669 * src/modest-tny-account-store.c: (account_list_free),
3670 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3671 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3674 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3676 * src/modest-protocol-info.c:
3677 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3678 is required by our UI spec. Maybe something in our implementation will use this eventually.
3679 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3680 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3681 instead of the previous 0 placeholder.
3683 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3684 secure-auth settings.
3685 * src/modest-account-mgr-helpers.h:
3686 * src/modest-account-mgr-helpers.c:
3687 (modest_server_account_data_get_option_secure_auth),
3688 (modest_server_account_set_option_secure_auth),
3689 (modest_server_account_data_get_option_security),
3690 (modest_server_account_set_option_security): Added this API for getting and setting the security
3691 and secure-auth settings.
3693 * src/maemo/modest-account-settings-dialog.h:
3694 * src/maemo/modest-account-settings-dialog.c:
3695 (modest_account_settings_dialog_finalize), (check_data),
3696 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3697 about changing titles.
3698 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3699 (save_configuration): Save the security and secure-auth settings.
3701 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3702 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3704 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3706 * src/modest-defs.h:
3707 * src/modest-account-mgr.c:
3708 (modest_account_mgr_add_server_account):
3709 Added and used defines for the options key and value pair strings,
3710 that are used so far, though they do not seem to correspond to anything in our
3711 UI specs or ModestProtocol enum.
3713 * src/modest-account-mgr-helpers.h:
3714 * src/modest-account-mgr-helpers.c:
3715 (compare_option_strings_for_name),
3716 (modest_server_account_data_get_option_value),
3717 (modest_server_account_data_get_option_bool),
3718 (modest_account_mgr_get_server_account_option):
3719 Added helper functions for parsing the options GSList.
3721 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3723 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3724 display name is based on the supplied account name.
3725 * src/modest-account-mgr.c:
3726 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3727 with an inefficient, but good-enough, implementation.
3729 * src/maemo/easysetup/modest-easysetup-wizard.c:
3730 (create_page_account_details), (on_before_next), (create_account):
3731 Check for existing display names rather than (non-user-visible) account names, and just
3732 create and set a unique account name at the end.
3734 * src/maemo/modest-account-settings-dialog.c:
3735 (modest_account_settings_dialog_init),
3736 (modest_account_settings_dialog_set_account_name),
3737 (create_page_incoming): Show the display name, instead of the account name.
3738 (on_response): Do some (not all) extra checks, as in the UI spec.
3739 (save_configuration): Save the display name if it was changed.
3741 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3743 * po/en_GB.po: Added needed logical ID and translation.
3744 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3745 (init_view): Made the is-default column clicking work.
3747 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3750 * src/maemo/easysetup/Makefile.am:
3751 * src/maemo/easysetup/modest-easysetup-wizard.c:
3752 (modest_easysetup_wizard_dialog_init):
3753 * src/maemo/easysetup/provider-data-test.keyfile:
3754 * src/maemo/easysetup/provider-data.keyfile:
3755 Moved the provider data file to the new modest-providers-data package and used it from there.
3757 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3759 * src/modest-local-folder-info.c:
3760 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3761 N_() was already used on the static strings, but this just marks it for translation without
3762 using the translation.
3764 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3766 * src/maemo/modest-account-settings-dialog.c:
3767 (create_page_incoming),
3768 (modest_account_settings_dialog_set_account_name):
3769 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3770 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3771 I will do this if nobody else gets there first.
3773 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3775 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3776 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3777 save the security stuff.
3779 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3781 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3782 Set the email address and user fullname, which I now see must be
3785 * src/maemo/modest-account-settings-dialog.h:
3786 * src/maemo/modest-account-settings-dialog.c:
3788 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3789 leave-on-server and authentication.
3790 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3793 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3796 * src/maemo/modest-account-settings-dialog.c:
3797 * src/maemo/modest-account-settings-dialog.h:
3798 Most (but not all) of the widgets are now present as specified by the UI spec.
3799 No changes are yet saved, and some details are not properly shown yet.
3801 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3803 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3805 * src/maemo/Makefile.am:
3806 * src/maemo/modest-account-settings-dialog.c:
3807 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3808 an existing account. Doesn't do much yet.
3810 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3811 Open the accounts settings dialog when Edit is clicked.
3813 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3815 * src/maemo/easysetup/Makefile.am:
3816 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3818 * src/maemo/easysetup/modest-easysetup-wizard.c:
3819 (modest_easysetup_wizard_dialog_init):
3820 Try to get the source directory from the build system,
3821 instead of hard-coding "./" into the source code, when opening our local
3822 copies of the configuration files.
3823 But this still fails when opening the wizard from the Accounts window,
3824 maybe because the working directory seems to change at runtime.
3825 So the wizard will fail the second time unless you copy the files into their
3826 proper locations - see the stdout warnings for the paths.
3828 (create_page_account_details),(on_before_next):
3829 Check for existing non-server accounts instead of server accounts,
3830 so the default account name is useful again, and to prevent trying to
3833 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3834 Show the wizard when New is clicked.
3836 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3837 (init_view): Show the column headers, and show the columns that are
3838 specified in the UI specs. However, something in Maemo's GTK+ prevents
3839 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3840 change the default account. This is despite unsetting the special properties.
3842 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3844 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3845 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3846 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3847 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3848 to make that clearer.
3849 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3851 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3853 * src/maemo/modest-account-view-window.c:
3854 (modest_account_view_window_init),
3855 (modest_account_view_window_new):
3856 Use the same buttons as specified in the
3857 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3858 the existing widgets, which never had a chance of working.
3859 Put the ModestAccountView treeview in a scrolled window.
3860 Do not repeat the initialization in both _init() and _new().
3862 * src/widgets/modest-account-view.c: (update_account_view):
3863 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3864 this widget and window shows no accounts.
3866 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3868 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3870 * src/maemo/easysetup/modest-easysetup-wizard.c:
3871 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3872 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3873 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3876 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3877 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3878 accounts exist yet, as in the UI spec.
3880 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3882 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3884 * src/maemo/Makefile.am:
3885 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3886 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3887 New window for editing connection-specific smtp details.
3888 Not fully implemented.
3890 * src/maemo/modest-connection-specific-smtp-window.c:
3891 (modest_connection_specific_smtp_window_finalize) :
3892 unref the tree model.
3893 (on_button_edit): Show the edit window.
3895 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3897 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3900 * src/maemo/Makefile.am:
3901 * src/maemo/modest-connection-specific-smtp-window.c:
3902 * src/maemo/modest-connection-specific-smtp-window.h:
3903 New window for showing the list of connections, for connection-specific
3904 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3905 * src/maemo/easysetup/modest-easysetup-wizard.c:
3906 (create_page_custom_outgoing): Show the new window when the button is clicked.
3908 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3910 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3911 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3912 * src/maemo/modest-msg-edit-window.c:
3913 (modest_msg_edit_window_insert_image):
3914 * src/modest-conf.c: (modest_conf_key_escape):
3915 * src/modest-mail-operation.c:
3916 (modest_mail_operation_send_new_mail):
3917 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3918 (modest_ui_actions_on_new_account):
3919 * src/widgets/modest-attachment-view.c: (update_filename_request):
3920 * src/widgets/modest-mail-header-view.c:
3921 Corrected warnings that were breaking the build, by commenting out unused variables,
3922 and a function, and by including a header.
3924 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3926 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3927 so we can #ifdef around platform-specific code when necessary.
3928 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3929 to allow this to build for the GNOME platform too.
3931 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3933 * src/maemo/easysetup/modest-easysetup-wizard.c:
3934 Added util_increment_name() and used it in create_page_account_details()
3935 to make sure that the default account name is always a new name.
3937 (modest_easysetup_wizard_dialog_init),
3938 (set_default_custom_servernames): Some minor memory management fixes.
3940 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3944 * src/modest-runtime.c: (init_i18n): Restored the translation
3945 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3946 are defined in config.h, and the translations are installed.
3948 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3949 is defined for translation.
3951 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3953 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3955 * src/maemo/easysetup/modest-easysetup-wizard.c:
3956 (modest_easysetup_wizard_dialog_init):
3957 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3958 Use realistic paths (though they should use $prefix generically) to the
3959 mcc_mapping and provider-data.keyfile files which might work when they
3960 are installed by the future version of the operator-wizard package,
3961 and then fallback to paths in our source code, with an explanatory
3964 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3968 * src/maemo/Makefile.am:
3969 * src/maemo/easysetup/: Added files from the previously-exernal
3970 osso-modest-easysetup.
3971 * src/maemo/modest-main-window-ui.h:
3972 * src/modest-ui-actions.c:
3973 * src/modest-ui-actions.h:
3974 Added modest_ui_actions_on_new_account() as a signal handler for the
3975 New Account menu item. It shows the easysetup wizard.
3976 * po/en_GB.po: Added additional needed logical IDs and translations.