1 2007-06-26 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-maemo-utils.h:
4 * src/maemo/modest-maemo-utils.c: Added a
5 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
6 only error code to tell the calling code when the user canceled the
9 * src/maemo/modest-account-settings-dialog.h:
10 * src/maemo/modest-account-settings-dialog.c:
11 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
12 message if the retrieval of secure authentication methods was canceled
13 by the user. Perform the check before saving anything to configuration
14 to not end up with half-committed configuration changes, do not show
15 a "Saving to configuration failed" note when authentication methods
16 could not be retrieved.
18 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
21 2007-06-26 Murray Cumming <murrayc@murrayc.com>
23 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
24 Only return the first level of folders under accounts, because the
25 osso-global-search UI spec doesn't want the rest.
26 This fixed projects.maemo.org bug NB#61811.
28 2007-06-26 Murray Cumming <murrayc@murrayc.com>
30 * src/modest-tny-account-store.c:
31 * src/modest-tny-account-store.h:
32 Added modest_tny_account_is_memory_card_account().
33 * src/maemo/modest-main-window.c: (create_details_widget):
34 Show the same information items for the memory card as we show for the
35 local-folders, to fix projects.maemo.org bug NB#59307.
37 2007-06-26 Murray Cumming <murrayc@murrayc.com>
39 * src/modest-tny-account-store.c: (get_password):
40 Added some checks for NULL to maybe prevent crashes, though I think
41 it was Philip's last commit that actually prevented the crash here
42 when creating a first new account.
43 But the new account is still not usable (no messages are shown)
44 until a restart of the application.
46 2007-06-26 Murray Cumming <murrayc@murrayc.com>
48 * src/maemo/modest-maemo-global-settings-dialog.c:
49 (idle_select_default_focus):
50 * src/modest-mail-operation.c: (idle_notify_progress),
51 (idle_notify_progress_once), (idle_notify_update_account_queue),
52 (set_last_updated_idle), (update_account_thread),
53 (notify_get_msgs_full), (get_msgs_full_destroyer),
54 (get_msgs_full_thread):
55 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
56 * src/widgets/modest-header-view.c:
57 (idle_notify_headers_count_changed_destroy),
58 (idle_notify_headers_count_changed):
59 Use gdk_threads_enter() and gdk_threads_enter_leave() in
60 all idle handlers, because some other thread could be blocking
61 the GDK lock, so that it can do GUI stuff.
63 2007-06-26 Murray Cumming <murrayc@murrayc.com>
65 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
66 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
67 (on_idle_send_receive), (on_idle_open_default_inbox):
68 * src/maemo/modest-msg-edit-window.c:
69 (modest_msg_edit_window_attach_file_noninteractive):
70 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
71 to prevent a hang. I don't quite understand why these are necessary,
72 beause we should already be in the main loop. I guess something outside
73 of the main loop is taking the lock.
75 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
76 we are really using URIs, and use files that are more likely to exist.
78 2007-06-26 Murray Cumming <murrayc@murrayc.com>
80 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
81 necessary because configure.ac now defines different variables.
83 2007-06-26 Murray Cumming <murrayc@murrayc.com>
85 * libmodest-dbus-client/libmodest-dbus-client.c:
86 * libmodest-dbus-client/libmodest-dbus-client.h:
87 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
88 libmodest_dbus_client_compose_mail() is what things actually use.
90 * src/dbus_api/modest-dbus-api.h:
91 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
92 * tests/dbus_api/Makefile.am:
93 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
96 2007-06-26 Murray Cumming <murrayc@murrayc.com>
98 * src/modest-init.c: (modest_init_local_folders):
99 For memory-card (or other non local-folders) maildir accounts,
100 always create an Archive folder, so that there is somewhere to put
101 messages. This should be less confusing, because the user does not need
102 to guess that the need to create a folder.
104 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
106 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
107 Fixed icon size by using (50, 50) which is the same as defined by
110 2007-06-25 Armin Burgmeier <armin@openismus.com>
112 * src/widgets/modest-window-mgr.c:
114 * configure.ac: Correctly recognize hildon-notify presence and fixed
115 the build without it being installed.
117 2007-06-25 Murray Cumming <murrayc@murrayc.com>
119 * libmodest-dbus-client/libmodest-dbus-client.c:
120 (libmodest_dbus_client_search): Fix the build. Sorry.
121 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
122 (reply_forward_cb): Initialize variables to fix the build.
124 * src/modest-tny-account-store.c:
125 (modest_tny_account_store_get_tny_account_by): Fix the account URI
126 comparison (a silly typo) so that email search results can be opened
127 when there are more than one account.
129 2007-06-25 Murray Cumming <murrayc@murrayc.com>
131 * libmodest-dbus-client/libmodest-dbus-client.c:
132 (libmodest_dbus_client_search),
133 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
134 instead of 1 second, because the search gets folders and messages from
135 the server, which can take a long time. When it times out,
136 osso-global-search will report no results.
138 We need to specify whether we should search only cached information
139 (maybe with a user preference), and the osso-email-search-plugin
140 API should really be improved to allow that option, and to allow results
141 to be delivered asynchronously in batches.
143 2007-06-25 Murray Cumming <murrayc@murrayc.com>
145 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
146 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
147 GTK_ICON_SIZE_DIALOG is probably the wrong size.
149 2007-06-25 Murray Cumming <murrayc@murrayc.com>
151 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
152 that is an empty string. D-Bus seems to give us these instead of NULL.
154 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
156 * src/dbus_api/modest-dbus-callbacks.c:
157 * src/maemo/easysetup/modest-easysetup-wizard.h:
158 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
159 * src/maemo/modest-connection-specific-smtp-edit-window.c:
160 (modest_connection_specific_smtp_edit_window_init):
161 * src/maemo/modest-maemo-global-settings-dialog.c:
163 * src/maemo/modest-maemo-utils.c:
164 (modest_maemo_utils_setup_images_filechooser):
165 * src/maemo/modest-main-window.c: (create_details_widget):
166 * src/maemo/modest-msg-edit-window.c:
167 (modest_msg_edit_window_attach_file_noninteractive),
168 (modest_msg_edit_window_color_button_change),
169 (modest_msg_edit_window_set_zoom):
170 * src/modest-mail-operation.c: (update_account_thread):
171 * src/modest-tny-account-store.c:
172 * src/modest-tny-account.c:
173 * src/widgets/modest-global-settings-dialog.c:
174 * src/widgets/modest-window.h:
178 2007-06-25 Murray Cumming <murrayc@murrayc.com>
180 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
181 * src/modest-search.c: (modest_search_folder),
182 (modest_search_all_accounts): Actually search only in the specified folder,
183 doing a simple match on the folder ID.
184 * src/modest-search.h: Added a folder field to the ModestSearch struct,
185 and added some documentation.
187 2007-06-22 Armin Burgmeier <armin@openismus.com>
189 * src/maemo/modest-maemo-utils.h:
190 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
191 modest_maemo_utils_get_supported_secure_authentication_methods.
193 * src/maemo/easysetup/modest-easysetup-wizard.c:
194 * src/maemo/modest-account-settings-dialog.c: Show correct error if
195 one occured, not just "Server does not support secure authentication".
197 2007-06-22 Murray Cumming <murrayc@murrayc.com>
199 * src/modest-tny-account-store.c: (get_password):
200 Restored the call to tny_account_set_user() because Philip seems to have
201 stopped this from crashing (by not using the freed string). It still does
202 not work, but now we can test it.
204 2007-06-22 Murray Cumming <murrayc@murrayc.com>
206 * src/maemo/modest-msg-edit-window.c: (init_window):
207 Comment out use of an uninitialzed GtkScrolledWindow variable,
208 to fix the build and stop a crash. Yet again.
210 2007-06-22 Murray Cumming <murrayc@murrayc.com>
212 * src/modest-tny-account-store.c: (get_password):
213 Remove the call to tny_account_set_user() because this actually crashes.
214 As mentioned in the last commit, it is known to not work anyway.
216 2007-06-22 Murray Cumming <murrayc@murrayc.com>
218 * src/modest-tny-account-store.c: (get_password):
219 Use tny_account_set_username() to tell tinymail that the username might
220 have changed too. But tinymail ignores this: see projects.maemo.org
222 * src/modest-ui-actions.c:
223 (modest_ui_actions_on_password_requested): Remove the useless attempt to
224 reset the connection when changing the username, and improve the comments.
225 Save the changed username to gconf at least, so it is used when Modest is
228 2007-06-21 Murray Cumming <murrayc@murrayc.com>
230 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
231 Do not use a query, so that we get all folders, including for POP and
232 local-folders. They work as search criteria too.
233 This fixes projects.maemo.org bug NB#57740.
235 2007-06-21 Murray Cumming <murrayc@murrayc.com>
237 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
238 Comment out the use of hildon_notification_set_sound() because it is
239 not declared, to fix the build. Warnings are serious, people.
241 2007-06-21 Armin Burgmeier <armin@openismus.com>
243 * src/maemo/modest-maemo-utils.h:
244 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
245 modest_maemo_utils_get_supported_secure_authentication_methods()
246 to query authentication methods for a specific user. This should fix
247 projects.maemo.org bug NB#61369.
249 * src/maemo/easysetup/modest-easysetup-wizard.c:
250 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
253 2007-06-21 Murray Cumming <murrayc@murrayc.com>
255 * libmodest-dbus-client/libmodest-dbus-client.h:
256 * libmodest-dbus-client/libmodest-dbus-client.c:
257 (modest_dbus_message_iter_get_search_hit),
258 (libmodest_dbus_client_search):
259 Reorganised and commented this.
260 Removed modest_search_hit_free() from the public API because it
263 Added libmodest_dbus_client_get_folders() and
264 modest_folder_result_list_free().
266 * src/dbus_api/modest-dbus-api.h:
267 * src/dbus_api/modest-dbus-callbacks.c:
268 (modest_dbus_req_filter): Commented. Moved most code to
269 on_dbus_method_search() and added on_dbus_method_get_folders().
271 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
272 of the extra D-Bus handler.
274 * tests/dbus_api/Makefile.am:
275 * tests/dbus_api/test_get_folders.c: New test for
276 libmodest_dbus_client_get_folders(). This seems to return an empty list
277 at the moment. That could be the same error that causes the message list
278 to be empty sometimes.
279 This should help with projects.maemo.org bug NB#57740.
281 2007-06-21 Armin Burgmeier <armin@openismus.com>
283 * src/modest-mail-operation.c: Do not call
284 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
285 notify the operation's end after having set the status to CANCELED for
286 the operation queue to listen on. This fixes a deadlock when there
287 were mail operations in the queue during its finalization.
289 * src/modest-singletons.c: Reordered uninitialization of the account
290 manager to happen after the mail operation queue was uninitialized
291 because the mail operation's in the queue might still try to access
292 the account manager (see modest_mail_operation_notify_end()). This
293 fixes a potential crash when terminating the application.
295 2007-06-21 Murray Cumming <murrayc@murrayc.com>
297 * src/modest-search.c:
298 (search_mime_part_and_child_parts): Moved some code here so we
299 can search recursively in child folders.
300 (modest_search_folder): Search in the message as a mime part, instead
301 of just its child mime parts.
302 (read_chunk), (search_mime_part_ogs):
303 Check how many bytes were read, to prevent an endless loop.
304 Searching in message bodies now works. This finishes the fix for
305 projects.maemo.org bug NB#61007.
307 2007-06-20 Murray Cumming <murrayc@murrayc.com>
309 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
310 Add a g_warning when the item is not a folder.
312 * src/modest-ui-dimming-rules.c:
313 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
314 when selected item is not a folder (for instance, an account), because
315 the UI spec only talks about folders.
316 I am not sure what the UI spec wants, so this might not totally fix
317 projects.maemo.org bug NB#60794.
319 2007-06-20 Murray Cumming <murrayc@murrayc.com>
321 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
322 (load_from_file): Sort the list. The unsorted list would be more noticeable
323 in non-English locales.
325 * src/maemo/modest-msg-edit-window.c:
326 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
327 warning and fix the build.
329 * src/maemo/modest-progress-bar-widget.c:
330 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
331 avoid a g_warning, and probably to avoid a crash.
333 2007-06-20 Murray Cumming <murrayc@murrayc.com>
335 * src/modest-search.c: (modest_search_folder): Check for a GError
336 when calling tny_folder_get_headers(), to show that this is not the cause
339 2007-06-20 Murray Cumming <murrayc@murrayc.com>
341 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
342 Actually set the body query instead of the subject query.
344 * src/modest-search.c: (search_mime_part_ogs),
345 (search_mime_part_strcmp): Remove extra space from the text/* regex,
346 which would probably cause it to fail if we got this far.
348 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
349 to simplify the code.
350 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
351 be causing search-in-body to fail.
353 2007-06-20 Murray Cumming <murrayc@murrayc.com>
355 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
357 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
358 Better debug message when the folder cannot be found.
359 This should help with fixing projects.maemo.org bug #61287.
360 * src/modest-search.c: (add_hit): Do not leak the furl string.
362 2007-06-20 Murray Cumming <murrayc@murrayc.com>
364 * src/modest-ui-actions.c:
365 (modest_ui_actions_on_folder_selection_changed):
366 Do not special-case TNY_MERGE_FOLDER here, because
367 modest_tny_folder_get_account() already does that. This fixes
368 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
369 shown when the Outbox was selected).
371 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
373 * libmodest-dbus-client/libmodest-dbus-client.c:
374 (_dbus_iter_get_string_or_null): Initialize the string variable in
375 case this helps with Dirk's crash.
377 2007-06-19 Murray Cumming <murrayc@murrayc.com>
379 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
380 though it is not implemented yet (this function is maybe not even used),
381 to avoid breaking ABI in future.
382 * libmodest-dbus-client/libmodest-dbus-client.c:
383 (get_attachments_string): Moved some code into this generic function.
384 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
385 sends email. It is maybe not used.
386 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
387 (on_send_mail): Use attachments.
389 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
390 * src/maemo/modest-msg-edit-window.c:
391 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
392 a filename before using it, to fix projects.maemo.org bug NB#58233.
394 2007-06-19 Murray Cumming <murrayc@murrayc.com>
396 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
397 Initialize the continue_download variable to fix the build, and probably
398 to fix randome behaviour.
400 2007-06-18 Armin Burgmeier <armin@openismus.com>
402 * src/modest-tny-send-queue.h:
403 * src/modest-tny-send-queue.c: Keep track of the status of messages in
404 the queue so we can later show it in the UI. Replaced
405 modest_tny_send_queue_msg_is_being_sent() by
406 modest_tny_send_queue_get_msg_status().
408 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
410 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
411 gpointer. This probably was not harmful, but just to be sure.
413 2007-06-18 Murray Cumming <murrayc@murrayc.com>
415 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
416 Fix the build, but leave the function broken on Bora, because
417 hildon_uri_action_get_service() does not exist.
418 osso_uri_action_get_service() does not exist either, it seems.
420 2007-06-18 Murray Cumming <murrayc@murrayc.com>
422 * src/modest-tny-account.c:
423 (modest_tny_account_new_from_server_account):
424 Uncommented the url debug output again, because it is useful for
425 debugging, as I said in the comment.
427 2007-06-18 Murray Cumming <murrayc@murrayc.com>
429 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
431 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
432 for Mameo Bora, to fix the build.
434 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
437 Fixed build with hildon < 0.99
439 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
440 Check if the selected account is busy instead of checking all accounts
442 * src/modest-account-mgr-priv.h:
443 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
444 (modest_account_mgr_init), (compare_account_name),
445 (modest_account_mgr_set_account_busy),
446 (modest_account_mgr_account_is_busy):
447 * src/modest-account-mgr.h:
448 Added busy information to the account manager. It possible to
449 set an account to busy or not busy now.
451 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
452 (modest_mail_operation_update_account),
453 (modest_mail_operation_notify_end):
454 Set the account to busy/not busy depending on the operation state.
456 * src/widgets/modest-account-view.c:
457 (modest_account_view_finalize), (get_last_updated_string),
458 (update_account_view), (on_account_busy_changed), (init_view):
459 Show string "Refreshing..." if the account is currently busy.
461 All this fixes projects.maemo.org bug NB#59711
463 2007-06-14 Armin Burgmeier <armin@openismus.com>
465 * src/widgets/modest-attachments-view.h:
466 * src/widgets/modest-attachments-view.c: Added
467 modest_attachments_view_has_attachments() and fixed coordinate
468 transformation in get_att_view_at_coords(). This fixes attachment
471 * src/widgets/modest-msg-view.c: Make use of
472 modest_attachments_view_has_attachments() to decide whether to show
473 attachments in the header.
475 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
477 * src/maemo/modest-connection-specific-smtp-edit-window.c:
478 (on_change), (on_combo_security_changed),
479 (modest_connection_specific_smtp_edit_window_init),
480 (modest_connection_specific_smtp_edit_window_set_connection),
481 (modest_connection_specific_smtp_edit_window_is_dirty):
482 * src/maemo/modest-connection-specific-smtp-edit-window.h:
483 * src/maemo/modest-connection-specific-smtp-window.c:
486 Show an comfirmation dialog for the smpt-edit-window if there are
487 unsaved changes and the user hits cancel.
488 (projects.maemo.org bug NB#60479)
490 2007-06-14 Armin Burgmeier <armin@openismus.com>
492 * src/maemo/easysetup/modest-easysetup-wizard.c:
493 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
494 address" info in banner instead of node, and select all the text as
495 per UI spec. This fixes projects.maemo.org bug NB#60550.
497 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
499 reviewed by: <delete if not using a buddy>
501 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
502 * src/modest-ui-actions.c: (folder_refreshed_cb):
504 2007-06-14 Murray Cumming <murrayc@murrayc.com>
506 * src/widgets/modest-folder-view.c: (filter_row):
507 Explictly filter out the per-account outbox accounts. I don't know why
508 these only sometimes show up, but now they should never show up in the UI.
509 This should fix projects.maemo.org bug NB#60160.
511 2007-06-14 Murray Cumming <murrayc@murrayc.com>
513 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
514 when the toolbar does not exist yet.
515 * src/modest-widget-memory.c: (save_settings_header_view):
516 Added g_warnings() to help us to discover when we are trying to set
517 an empty columns list in gconf.
519 2007-06-14 Murray Cumming <murrayc@murrayc.com>
523 Added modest_init_get_default_header_view_column_ids().
525 * src/modest-widget-memory.c: (restore_settings_header_view):
526 Use the new function to get defaults, if the gconf key is empty,
527 instead of not creating any columns. This seems to fix the
528 empty right-hand pane problems.
530 * src/widgets/modest-header-view.h: Improved documentation.
532 2007-06-13 Murray Cumming <murrayc@murrayc.com>
534 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
535 Revert the use of the display name as the account name, because this
536 is generally wrong and would break the code that follows.
538 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
540 * src/maemo/easysetup/modest-easysetup-wizard.c:
541 (check_for_supported_auth_methods), (on_before_next),
544 More correct fix for projects.maemo.org bug NB# 58991
545 Do not longer accept AUTH_PASSWORD as secure method and choose
546 correct method when creating the account.
548 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
550 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
551 Fixed projects.maemo.org bug NB# 58991
553 2007-06-13 Murray Cumming <murrayc@murrayc.com>
555 * src/modest-init.c: (modest_init_init_core),
556 (modest_init_local_folders): Fixed compilation errors.
558 2007-06-13 Murray Cumming <murrayc@murrayc.com>
560 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
561 Remove unnecessary lib/include, though it is good in principle when needed.
563 * src/modest-init.c: (modest_init_one_local_folder),
564 (modest_init_local_folders):
565 * src/modest-init.h: Initialize the .modest library for memory cards,
566 instead of just doing nothing for them. This should allow us to create
567 folders there, fixing projects.maemo.org bug NB#59297.
569 2007-06-13 Murray Cumming <murrayc@murrayc.com>
571 * libmodest-dbus-client/libmodest-dbus-client.c:
572 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
573 (libmodest_dbus_client_compose_mail),
574 (libmodest_dbus_client_open_message),
575 (libmodest_dbus_client_send_and_receive),
576 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
578 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
579 (on_idle_open_message), (modest_dbus_req_handler),
580 (search_result_to_message), (modest_dbus_req_filter):
581 * src/modest-search.c: (add_hit), (modest_search_folder),
582 (modest_search_all_accounts): Improved debug messages.
584 * tests/dbus_api/test_open_message.c: (main): Improved comments.
586 * src/modest-tny-account-store.c:
587 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
590 2007-06-13 Murray Cumming <murrayc@murrayc.com>
593 2007-06-12 Murray Cumming <murrayc@murrayc.com>
595 * src/modest-tny-account-store.c: (get_server_accounts):
596 Call modest_tny_local_folders_account_add_merged_outbox_folders()
597 even when there are no accounts, so that the Outbox folder is always
598 visible. This fixes projects.maemo.org bug NB#60158.
600 2007-06-12 Murray Cumming <murrayc@murrayc.com>
602 * src/maemo/modest-main-window.c: (create_details_widget):
603 Use the mcen_va_never logical ID.
605 2007-06-12 Murray Cumming <murrayc@murrayc.com>
607 * src/dbus_api/modest-dbus-api.h:
608 * src/dbus_api/modest-dbus-callbacks.c:
609 (on_idle_open_default_inbox), (on_open_default_inbox),
610 (modest_dbus_req_handler):
611 Added a new OpenDefaultInbox method.
613 * libmodest-dbus-client/libmodest-dbus-client.h:
614 * libmodest-dbus-client/libmodest-dbus-client.c:
615 Added libmodest_dbus_client_open_default_inbox() to call the new
616 dbus method. This should be useful to projects.maemo.org bug NB#57214,
617 though it should maybe be used by a new osso-email-interface function.
619 * tests/dbus_api/Makefile.am:
620 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
623 2007-06-12 Murray Cumming <murrayc@murrayc.com>
625 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
626 NULL, so that the signals get all the keys. This should not actually
627 change any behaviour because we currently update everything when anything
630 2007-06-12 Murray Cumming <murrayc@murrayc.com>
632 * src/widgets/modest-folder-view.c: (text_cell_data),
633 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
634 (find_inbox_iter): If tinymail tells us that the folder is
635 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
636 This causes the inbox to be selected at startup, fixing part of
637 projects.maemo.org bug NB#56305.
639 * src/modest-ui-dimming-rules.c:
640 (modest_ui_dimming_rules_on_tools_smtp_servers):
641 * src/modest-ui-dimming-rules.h: Added a callback function to dim
642 the SMTP servers menu item.
643 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
644 that the SMTP Servers menu item is dimmed when there are no accounts,
645 as a future version of the UI spec will require. This fixes
646 projects.maemo.org bug NB#56305.
648 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
650 * src/maemo/modest-maemo-utils.c:
651 (modest_maemo_utils_get_supported_secure_authentication_methods):
652 Added label to dialog instead of unreadable title
654 * src/maemo/modest-main-window.c: (sync_accounts_cb),
655 (modest_main_window_new):
656 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
659 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
660 * src/modest-account-mgr.h:
661 Added method to avoid code duplication
663 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
664 (modest_ui_actions_on_send_receive):
665 Use modest_account_mgr_has_accounts
667 2007-06-11 Murray Cumming <murrayc@murrayc.com>
669 * src/maemo/easysetup/modest-presets.c:
670 (modest_presets_get_info_server_security): Do not report secure auth
672 * src/modest-protocol-info.c: Use the defines for the gconf key names
673 for secure authentication. This was not working because we were writing
674 Password and reading password, and the check was case sensitive.
675 With this, gmail now works for receiving and sending when created via
678 2007-06-11 Murray Cumming <murrayc@murrayc.com>
680 * src/maemo/easysetup/modest-presets.c:
681 (modest_presets_get_info_server_security): Correct the key name for
682 SecureSmtp, because it seems to be case-sensitive.
683 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
684 Do not try to get the 0th notebook page if there are 0 pages, to
687 2007-06-11 Murray Cumming <murrayc@murrayc.com>
689 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
690 Prevent use of the new notification feature for now, because it currently
691 shows one dialog for each new email, which is annoying.
693 2007-06-11 Murray Cumming <murrayc@murrayc.com>
695 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
696 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
697 when no country was selected, so that we show the global ones.
698 * src/maemo/easysetup/modest-presets.c:
699 (modest_presets_get_providers): Return only the global providers, not
700 all providers when mmc=0 was requested.
702 2007-06-11 Murray Cumming <murrayc@murrayc.com>
704 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
705 (easysetup_provider_combo_box_fill): Remove debug code that showed the
706 provider ID in the combo.
708 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
709 Do not show the page numbers, because it would be confusing when we add
710 the 2 extra pages for the custom setup, when the user chooses the "Other"
711 provider. This fixes projects.maemo.org bug NB#59028
713 * src/modest-init.c: (modest_init_init_core),
714 (modest_init_local_folders):
716 * src/modest-tny-account.c:
717 (modest_tny_account_new_for_local_folders): Do not create default folders
718 for the memory card. This should fix projects.maemo.org bug NB#59328.
720 2007-06-11 Murray Cumming <murrayc@murrayc.com>
722 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
723 Free the changed_conf_keys string items. They are already freed in the
724 idle handler if that runs first.
726 2007-06-11 Murray Cumming <murrayc@murrayc.com>
728 * src/modest-ui-actions.c:
729 (modest_ui_actions_on_password_requested): Check that the server name
730 is not NULL, because I just saw a password dialog with (null) as the
733 * src/modest-tny-folder.[h|c]: Added
734 modest_tny_folder_is_memory_card_folder().
735 * src/modest-ui-dimming-rules.c:
736 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
737 menu item for memory cards, as per the UI spec (section 7.4). This should
738 fix projects.maemo.org bug NB#59297.
740 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
742 * src/maemo/modest-main-window.c: (sync_accounts_cb):
743 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
744 is another problem with the code, see Murray's comment at line 772)
746 2007-06-08 Murray Cumming <murrayc@murrayc.com>
748 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
749 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
750 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
751 (load_from_file), (easysetup_country_combo_box_init),
752 (easysetup_country_combo_box_get_active_country_ids),
753 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
754 instead of just one ID, to avoid duplicate country names in the UI.
756 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
757 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
758 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
759 a single ID, avoiding duplicate providers.
760 * src/maemo/easysetup/modest-easysetup-wizard.c:
761 (on_combo_account_country): Adapt to use a list.
763 2007-06-08 Murray Cumming <murrayc@murrayc.com>
765 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
766 keys changed in the last X seconds.
768 * src/modest-account-mgr.h:
769 * src/modest-account-mgr.c: (on_timeout_notify_changes),
770 (on_key_change), (modest_account_mgr_class_init),
771 (modest_account_mgr_init), (modest_account_mgr_finalize):
772 As the keys are changed, save them in a GSList* and signal that GSList*
773 further every X seconds, to batch changes, to allow us to do just one
774 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
775 bug NB#56941 and other (UI-blocking) delays when changing account settings.
777 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
778 changed signal signature.
780 * src/modest-conf.c: (modest_conf_set_list),
781 (modest_conf_on_change): Reenable notification.
783 (modest_conf_maemo_fake_on_change): Comment out the hack that
784 notified immediately instead of asynchronously.
786 * src/widgets/modest-account-view.h:
787 * src/widgets/modest-account-view.c:
788 (update_account_view): Select the previously-selected account ID,
789 if possible. This fixes projects.maemo.org bug NB#56933.
791 (on_account_changed), (on_account_removed),
792 (modest_account_view_select_account):
794 Remove the block/unblock functions
795 because they were not useful.
797 * src/maemo/modest-account-view-window.c:
798 (on_delete_button_clicked), (on_edit_button_clicked),
799 (on_new_button_clicked): Remove the use of the non-working block/unblock.
801 2007-06-08 Murray Cumming <murrayc@murrayc.com>
803 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
804 Improve the error dialog to show Incorrect Account Settings, which seems
805 clearer, and say that the internal error message (to be removed from the
806 dialog later) is often misleading.
807 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
809 * src/modest-tny-account.c:
810 (modest_tny_account_new_from_server_account): Uncomment the printf of the
811 URL because this is so useful for debugging on the device.
813 * src/widgets/modest-serversecurity-combo-box.c:
814 (modest_serversecurity_combo_box_fill): Correct a logical ID.
816 2007-06-08 Murray Cumming <murrayc@murrayc.com>
818 * src/modest-mail-operation.c:
819 (modest_mail_operation_send_new_mail):
820 Added a comment about a nasty but apparently harmless message. Details
821 added to the wiki g_warnings() page.
823 2007-06-08 Murray Cumming <murrayc@murrayc.com>
825 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
826 (modest_tny_send_queue_class_init):
827 Do not use the priv struct because it is empty, to avoid g_warnings
828 about a non-existant priv struct.
830 * src/modest-tny-account-store.c:
831 (modest_tny_account_store_get_server_account),
832 (modest_tny_account_store_get_transport_account_for_open_connection
833 ): Do not try to get transport server accounts for local folders,
834 because they don't have any. This avoids a g_warning().
836 * src/maemo/modest-main-window.c:
837 (modest_main_window_notify_send_receive_initied),
838 (on_configuration_key_changed):
839 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
841 * src/modest-mail-operation.c:
842 (modest_mail_operation_update_account):
843 * src/modest-tny-account-store.h:
844 * src/modest-tny-account.c:
845 (modest_tny_account_get_special_folder),
846 (modest_tny_account_new_for_local_folders),
847 (modest_tny_account_new_for_per_account_local_outbox_folder):
848 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
849 * src/modest-tny-local-folders-account.c:
850 (add_account_folders_to_merged_folder):
851 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
852 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
853 (modest_ui_actions_on_send):
854 * src/widgets/modest-folder-view.c: (update_model):
855 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
856 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
857 modest_tny_account_store_get_tny_account_by_account() to
858 modest_tny_account_store_get_server_account() to make the code clearer.
860 2007-06-07 Marcus Bauer <marcusb@openismus.com>
862 * src/dbus_api/modest-dbus-api.h:
863 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
864 * src/maemo/modest-msg-edit-window.c:
865 (modest_msg_edit_window_attach_file_noninteractive):
866 added g_warning in case the file to be attached does not exist
867 * tests/dbus_api/test_compose_mail.c: (main):
868 removed obsolete comment, added generic files as test case
870 2007-06-07 Murray Cumming <murrayc@murrayc.com>
872 * src/modest-tny-account-store.c: (get_server_accounts):
873 Create the local folders account only once, not once for each outbox, and
874 not only when there are some outboxes.
876 2007-06-07 Murray Cumming <murrayc@murrayc.com>
878 * src/widgets/modest-folder-view.c: (update_model): Comment out some
879 code that is causing a crash at startup. Sergio says that he is fixing this.
881 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
883 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
884 * src/maemo/modest-account-settings-dialog.c:
885 (create_page_outgoing),
886 (modest_account_settings_dialog_set_account_name),
887 (save_configuration):
888 - Fixed handling of the "Use secure authentication" toggle to comply with
889 the ui specification. See also projects.maemo.org bug NB#58400
891 - Restore the Secure connection setting combo correctly when loading
894 * src/maemo/modest-maemo-utils.c:
895 (on_camel_account_get_supported_secure_authentication),
896 (modest_maemo_utils_get_supported_secure_authentication_methods):
897 Fixed a crasher if operation is canceled
899 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
900 (modest_protocol_info_auth_is_secure):
901 * src/modest-protocol-info.h:
903 Added two new methods to determine if a protocol/auth method is secure/encrypted in
904 the sense of the "Use secure authentication" toggle.
906 2007-06-07 Murray Cumming <murrayc@murrayc.com>
908 * src/modest-tny-account-store.h:
909 * src/modest-tny-account-store.c:
910 Added modest_tny_account_store_get_local_folders_account().
912 * src/modest-tny-folder.h:
913 * src/modest-tny-folder.c:
914 (modest_tny_folder_get_account):
915 Added this replacement for tny_folder_get_account() which returns
916 the local-folders account for TnyMergeFolders, to avoid the
917 warning about the unimplemented get_account_func() vfunc().
919 (modest_tny_folder_get_rules),
920 * src/modest-ui-actions.c:
921 (modest_ui_actions_on_folder_selection_changed):
922 * src/modest-mail-operation.c:
923 (modest_mail_operation_remove_folder),
924 (modest_mail_operation_xfer_folder),
925 (modest_mail_operation_rename_folder),
926 (modest_mail_operation_get_msg),
927 (modest_mail_operation_get_msgs_full),
928 (modest_mail_operation_remove_msg),
929 (modest_mail_operation_xfer_msgs),
930 (modest_mail_operation_refresh_folder):
931 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
933 2007-06-07 Murray Cumming <murrayc@murrayc.com>
935 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
936 (modest_server_account_set_security):
937 * src/modest-defs.h: Add comments explaining that our
938 UI spec means TLS when it says Normal, so these do not look like errors.
940 * src/modest-tny-account.c:
941 (modest_tny_account_new_from_server_account): Use the new tinymail
942 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
943 for TLS. This should fix projects.maemo.org bug NB#58460.
945 2007-06-06 Murray Cumming <murrayc@murrayc.com>
947 * src/maemo/easysetup/modest-easysetup-wizard.c:
948 (create_account): Correct the position of the gconf sanity check warning.
949 (on_button_edit_advanced_settings): Show the dialog immediately, instead
950 of using the g_idle_add() hack, because this does not seem to be necessary
951 on osso 1.1. It might even work on Maemo Bora if the problems were actually
952 caused by something other than maemo's gconf.
953 This fixes projects.maemo.org bug #59022.
955 2007-06-06 Murray Cumming <murrayc@murrayc.com>
957 * src/modest-account-mgr-helpers.c:
958 (modest_account_mgr_get_default_account): Do not check that the account
959 exists if there is no default account (NULL), to fix a runtime warning.
961 2007-06-06 Murray Cumming <murrayc@murrayc.com>
963 * src/widgets/modest-folder-view.c: (update_model):
964 Do not unref the treemodel before we have finished with it.
965 This prevents a valgrind warning and an occasional crash at startup.
967 2007-06-06 Marcus Bauer <marcusb@openismus.com>
969 * libmodest-dbus-client/libmodest-dbus-client.h:
970 added libmodest_dbus_client_compose_mail()
971 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
973 added functions needed for SendAsMail() functionality
974 * src/maemo/modest-msg-edit-window.c:
975 (modest_msg_edit_window_attach_file_noninteractive):
976 non interactively attaching files to message edit window
977 * src/widgets/modest-msg-edit-window.h:
978 * tests/dbus_api/Makefile.am:
979 added test_compose_mail.c
980 * tests/dbus_api/test_compose_mail.c: (main):
982 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
984 * src/modest-account-view.c:
985 Fixed bug projects.maemo.org bug NB#59307
987 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
989 * src/maemo/easysetup/modest-easysetup-wizard.c:
990 (get_serverport_incoming), (on_before_next), (create_account):
991 * src/maemo/modest-account-settings-dialog.c:
992 (modest_account_settings_dialog_set_account_name):
993 * src/maemo/modest-maemo-utils.c:
994 (on_camel_account_get_supported_secure_authentication_status),
995 (on_camel_account_get_supported_secure_authentication),
996 (on_secure_auth_cancel),
997 (modest_maemo_utils_get_supported_secure_authentication_methods):
999 Implemented security authentication for settings and easysetup.
1001 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1003 * src/maemo/modest-main-window.c: (create_details_widget):
1004 Show the total size for memory card accounts too, instead of showing
1005 the name again. Fixes bug projects.maemo.org bug NB#59307.
1007 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1010 * src/modest-tny-simple-folder-store.c:
1011 * src/modest-tny-simple-folder-store.h: Removed.
1013 * src/modest-tny-local-folders-account.h
1014 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1015 for the local-folders maildir, with an extra TnyMergedFolder containing
1016 the folders of the per-account outbox store accounts.
1017 * src/modest-tny-account-store.c: (get_server_accounts):
1018 Add the outboxes to the special local folders account after creating it.
1020 * src/modest-tny-account.c:
1021 (modest_tny_account_new_for_local_folders): Create the derived
1022 account when creating the main local-folders account.
1024 * src/maemo/modest-main-window.c: (create_details_widget),
1025 (modest_main_window_set_contents_style):
1026 Adapted to the use of the derived account instead of the folder store.
1028 * src/modest-ui-actions.c:
1029 (modest_ui_actions_on_folder_selection_changed):
1030 * src/modest-ui-dimming-rules.c:
1031 (modest_ui_dimming_rules_on_new_folder):
1032 * src/widgets/modest-folder-view.c: (text_cell_data),
1033 (icon_cell_data), (filter_row), (update_model),
1034 (get_cmp_rows_type_pos):
1037 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1038 Do not get the priv struct, because no priv struct has been set,
1039 to avoid a runtime warning.
1041 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1042 #ifelse with #else, to fix a warning, to fix the build.
1045 2007-06-05 Christian Kellner <ckellner@openismus.com>
1047 * libmodest-dbus-client/libmodest-dbus-client.c:
1048 Fix small typo in doc (why do you always see them
1049 AFTER committing stuff?)
1052 2007-06-05 Christian Kellner <ckellner@openismus.com>
1054 * libmodest-dbus-client/libmodest-dbus-client.c:
1055 (libmodest_dbus_client_search):
1056 Initialize hit list with NULL. Also set folder list
1057 to "" if NULL was supplied.
1060 2007-06-03 Christian Kellner <ckellner@openismus.com>
1062 * libmodest-dbus-client/libmodest-dbus-client.c:
1063 (modest_search_hit_list_free):
1064 Make it save to call it with NULL.
1066 * src/dbus_api/modest-dbus-callbacks.c:
1067 * src/modest-search.c:
1068 Return full ModestSearchHits as the search result list not TnyHeader
1069 since can't be around withouth the correspoding TnyFolder.
1071 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1073 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1074 Added currently commented code to check for secure auth
1076 * src/maemo/modest-account-settings-dialog.c: (on_response),
1077 (save_configuration), (show_ok):
1078 Fixed projects.maemo.org bugs NB #59248 and #59251
1080 * src/maemo/modest-maemo-utils.c:
1081 (on_camel_account_get_supported_secure_authentication_status),
1082 (on_camel_account_get_supported_secure_authentication),
1083 (modest_maemo_utils_get_supported_secure_authentication_methods):
1084 * src/maemo/modest-maemo-utils.h:
1085 Moved get_supported_secure_authentication() method here to be able
1086 to use it from easysetup wizard.
1088 * src/modest-pair.c: (on_pair_compare_as_string):
1089 Should compare string with first part of pair and not
1090 strcmp pairs which will crash.
1092 * src/modest-protocol-info.c:
1093 (modest_protocol_info_protocol_is_store):
1094 * src/modest-protocol-info.h:
1095 Added modest_protocol_info_get_auth_protocol_name()
1097 2007-06-03 Armin Burgmeier <armin@openismus.com>
1099 * src/modest-mail-operation.c:
1100 (modest_mail_operation_get_msgs_full): Set priv->account also when
1101 only retrieving a single message. This avoids a crash when canceling
1104 (modest_mail_operation_notify_end): Do not explicitely remove the
1105 operation from the queue but only emit the progress_changed signal.
1106 The queue itself listens to that signal to remove the operation when
1107 it is finished. This reduces coupling and removes a potential deadlock
1108 when modest_mail_operation_notify_end() is called from the queue
1109 itself. If that is a problem performance-wise, I would suggest to
1110 implement a status-changed signal or something.
1112 * src/modest-mail-operation-queue.c: Make sure to never call a
1113 function from another file while the queue is locked. This (hopefully)
1114 fixes another deadlock when exiting the application while retrieving
1117 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1119 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1120 Fixed build if libogs is not available
1122 2007-06-03 Christian Kellner <ckellner@openismus.com>
1124 * libmodest-dbus-client/libmodest-dbus-client.h:
1125 * libmodest-dbus-client/libmodest-dbus-client.c:
1126 (libmodest_dbus_client_delete_message):
1127 Implement deletion of messages (Client side).
1129 (modest_search_hit_free),
1130 (modest_search_hit_list_free):
1131 Utility functions to free the result hits.
1133 * src/dbus_api/modest-dbus-api.h:
1134 * src/dbus_api/modest-dbus-callbacks.c:
1135 (on_delete_message),
1136 (modest_dbus_req_handler):
1137 Implement deletion of messages (Server side).
1139 * tests/dbus_api/test_search.c: (main):
1142 * tests/dbus_api/Makefile.am:
1143 * tests/dbus_api/test_delete_message:
1144 Add little test for the message deletion logic
1146 2007-06-03 Armin Burgmeier <armin@openismus.com>
1148 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1149 when the operation queue was not empty. projects.maemo.org bug
1152 2007-06-03 Armin Burgmeier <armin@openismus.com>
1154 * src/widgets/modest-account-view.c
1155 (on_account_default_toggled): Toggle default account column
1156 explicitely instead of waiting for gconf notification (which is
1157 currently ignored). This should fix projects.maemo.org bug NB#56910
1158 for now. It should probably be removed when gconf notifications are
1161 2007-06-03 Christian Kellner <ckellner@openismus.com>
1163 * libmodest-dbus-client/libmodest-dbus-client.c:
1164 Removed debugging spew.
1166 * src/dbus_api/modest-dbus-callbacks.c:
1167 Added debugging info.
1169 * src/modest-search.c:
1170 (modest_search_all_accounts):
1171 Use tny_account_store_get_accounts () on the account store
1172 to get all accounts which is the way to get all accounts.
1174 * tests/dbus_api/test_search.c: (main):
1175 Make it possible to supply the search term on the command line.
1177 2007-06-03 Christian Kellner <ckellner@openismus.com>
1179 * libmodest-dbus-client/libmodest-dbus-client.c:
1180 * libmodest-dbus-client/libmodest-dbus-client.h:
1181 Implement searching for mesages over raw dbus. (Client side)
1183 * src/dbus_api/Makefile.am:
1184 * src/dbus_api/modest-dbus-api.h:
1185 * src/dbus_api/modest-dbus-callbacks.c:
1186 * src/dbus_api/modest-dbus-callbacks.h:
1187 Search framework (Server side). Also implement on_idle_open_message().
1189 * src/maemo/modest-platform.c: (modest_platform_init):
1190 Prepare for raw dbus/osso rpc interaction.
1192 * src/modest-search.h:
1193 Changed minsize from unspecific guint to guint32.
1195 * src/modest-search.c:
1197 Added strange hack which magically made tnymail work.
1199 (modest_search_folder),
1200 (modest_search_account),
1201 (modest_search_all_accounts):
1202 Implement helper functions to search all accounts, specific account
1205 * tests/dbus_api/Makefile.am:
1206 * tests/dbus_api/test_open_message.c:
1207 Read url to open from commandline.
1209 * tests/dbus_api/test_search.c:
1210 Implement small test for dbus search stuff
1212 2007-06-02 Armin Burgmeier <armin@openismus.com>
1214 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1215 include account type and account title. This fixes projects.maemo.org
1218 * src/maemo/modest-account-view-window.c: Set a title for the window.
1220 2007-06-02 Armin Burgmeier <armin@openismus.com>
1222 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1223 incoming and outgoing server name based on email address and server
1224 types as long as the names have not been edited manually. This fixes
1225 projects.maemo.org bug NB#58671.
1227 2007-06-02 Armin Burgmeier <armin@openismus.com>
1229 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1230 server type cannot be changed in future to the incoming details page
1231 when creating an account. This fixes projects.maemo.org bug NB#59029.
1233 2007-06-02 Armin Burgmeier <armin@openismus.com>
1235 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1236 and assigned max width chars so that they wrap instead of being
1237 truncated. Fixes projects.maemo.org bug NB#56126.
1239 2007-06-02 Armin Burgmeier <armin@openismus.com>
1241 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1242 introductory note to the connection specific smtp servers dialog, as
1243 section 8.12 of the email UI specification requires. This fixes
1244 projects.maemo.org bug NB#59212.
1246 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1248 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1249 Check for running mail operations, and offer to cancel them, as per the UI
1250 spec. This fixes projects.maemo.org bug NB#59041 .
1251 However, I suspect that tinymail may still use the network connection
1252 in ways that we cannot detect or cancel. But it should at least adapt to
1253 changes fairly well.
1255 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1257 * src/modest-tny-account-store.c: (recreate_all_accounts),
1258 (get_cached_accounts), (get_server_accounts): Do more sensible
1259 ref-counting of the temporarily-cached outbox accounts list. This seems
1260 to fix a crash when entering the password when the password was wrong.
1262 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1264 * src/gnome/modest-main-window.c: (connect_signals):
1265 * src/modest-tny-account-store.c: (get_password),
1266 (modest_tny_account_store_alert): Added comments and clues and
1267 commented-out code about how we currently fail to deal with connection
1268 errors and wrong passwords, and how we should.
1270 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1272 * src/widgets/modest-retrieve-combo-box.c:
1273 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1274 This fixes projects.maemo.org bug NB#58472 .
1276 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1278 * src/maemo/easysetup/modest-easysetup-wizard.c:
1279 (create_page_complete_easysetup):
1280 (create_page_complete_custom): Correct the last commit,
1281 putting the correct sentences in the correct pages.
1283 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1285 * src/maemo/easysetup/modest-easysetup-wizard.c:
1286 (create_page_complete_custom): Show the second sentence of text
1287 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1290 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1292 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1293 Set the leave-on-server conf key by default. This fixes
1294 projects.maemo.org bug NB#59258 .
1296 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1298 * src/maemo/modest-account-view-window.c:
1299 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1300 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1303 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1305 * src/maemo/easysetup/modest-easysetup-wizard.c:
1306 (create_caption_new_with_asterisk):
1307 * src/maemo/modest-account-settings-dialog.c:
1308 (create_caption_new_with_asterisk):
1309 Uncomment the code to add the asterisk, because they are no longer in the
1310 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1311 (update_incoming_server_title): Add an asterisk here too.
1313 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1315 * src/maemo/modest-maemo-global-settings-dialog.c:
1316 (current_connection): Check that we are even connected before trying to
1317 get the current connection name, to prevent a warning.
1319 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1320 Change the comments because tny_maemo_conic_device_connect() is now meant to
1322 * src/modest-mail-operation.c:
1323 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1324 make sure we have a connection and fail if we can't connect.
1326 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1328 * src/maemo/modest-main-window.c:
1329 (on_account_store_connecting_finished): Do not try to get the
1330 connection ID if we are not really connected. I am surprised that
1331 this signal handler is called when we are not connected.
1333 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1335 * src/modest-error.h:
1336 * src/modest-ui-actions.c:
1337 (modest_ui_actions_get_msgs_full_error_handler):
1338 Renamed an enum, added comments, added an enum
1339 for retrieve-limit errors.
1341 * src/modest-mail-operation.c: (foreach_add_item),
1342 (internal_folder_observer_update), (update_account_thread),
1343 (modest_mail_operation_get_msgs_full):
1344 (modest_mail_operation_update_account),
1345 Added comments about how this works, and some code that should
1346 (but does not) check the retrieve-limit. See the TODO comment.
1348 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1350 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1351 Initialize help_id to fix the build. Warnings are good.
1353 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1355 * src/widgets/modest-hbox-cell-renderer.c:
1356 (modest_hbox_cell_renderer_append):
1357 * src/widgets/modest-vbox-cell-renderer.c:
1358 (modest_vbox_cell_renderer_append):
1359 Fix the last commit by doing an extra ref.
1361 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1363 * src/widgets/modest-hbox-cell-renderer.c:
1364 (modest_hbox_cell_renderer_append):
1365 * src/widgets/modest-vbox-cell-renderer.c:
1366 (modest_vbox_cell_renderer_append):
1367 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1368 to fix the build with Maemo Bora.
1369 However, there seems to be a remaining crash, probably due to reference
1372 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1374 * src/modest-tny-account.c:
1375 (modest_tny_account_new_for_local_folders):
1376 Use hildon_file_system_info_async_new() to get a better name for
1377 the memory card account, setting it as the account name.
1378 The timing seems to work, but this is probably
1379 not the best place to do this. See the TODO comment.
1380 * src/maemo/modest-main-window.c: (create_details_widget):
1381 * src/widgets/modest-folder-view.c: (text_cell_data):
1382 Use the tny account name instead of hardcoding a name.
1384 2007-05-30 Christian Kellner <ckellner@openismus.com>
1386 * src/modest-search.c: (modest_search):
1387 Correctly set part_search_func even if we have already parsed
1388 the query and thus a valid OgsTextSearcher object.
1390 2007-05-30 Christian Kellner <ckellner@openismus.com>
1393 Search and check for libogs.
1396 Incooparte the ogs build env.
1398 * src/modest-mime-part-search-stream.c:
1399 * src/modest-mime-part-search-stream.h:
1400 Removed since we do the real searching now in modest-search.c.
1402 * src/modest-search.c:
1403 * src/modest-search.h:
1404 Implement support for ogs. We use that if available and requested
1405 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1406 should now handle the corner case when the search term is spread
1407 across multiple reads.
1408 Also the logic in modest_search () was corrected to search all
1409 requested fields until one is found.
1411 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1413 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1415 * src/modest-init.h:
1416 * src/modest-init.c: Made modest_init_local_folders() take a
1417 path and be public so we can iniitialize maildir folders on
1420 * src/modest-local-folder-info.h:
1421 * src/modest-local-folder-info.c:
1422 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1424 * src/modest-tny-account.c:
1425 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1426 still means the standard local-folders path on the local volume.
1428 * src/modest-tny-account-store.c:
1429 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1430 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1431 all accounts when that happens.
1432 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1433 this too, so it shows up in the treeview.
1435 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1437 * src/maemo/modest-maemo-global-settings-dialog.c:
1438 (current_connection):
1439 * src/widgets/modest-global-settings-dialog.c:
1440 (current_connection_default):
1441 Use the enum values instead of 0, 1 and -1,
1442 to make the code clearer.
1444 * src/modest-account-mgr-helpers.c:
1445 (modest_account_mgr_get_connection_specific_smtp): Make this code
1448 * src/modest-runtime.h:
1449 * src/modest-runtime.c:
1450 Added modest_runtime_remove_all_send_queues().
1451 * src/maemo/modest-main-window.c:
1452 (on_account_store_connecting_finished): Recreate the send queues,
1453 using the appropriate transport accounts for this new connection.
1454 Some futher adapting might be needed if the old send queues are not
1455 automatically stopped at this point.
1457 * src/modest-tny-account-store.c: (get_server_accounts):
1458 Create the connection-specific transport accounts, so that they can
1459 be found later by their ID.
1461 * src/modest-tny-account.h:
1462 * src/modest-tny-account.c:
1463 Added modest_tny_account_new_from_server_account_name().
1464 modest_tny_account_new_from_server_account(): Do not create the
1465 send queues here, because they will be
1466 recreated anyway when the connection changes for the first time.
1468 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1470 * src/modest-local-folder-info.h:
1471 * src/modest-local-folder-info.c:
1472 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1473 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1474 tbox_folder): Take a modest account name instead of a server TnyAccount,
1475 so we can have per-modest-account rather than per-transport-account
1477 We must make sure that we change or recreate the exisitng send queues
1478 when the connection changes for connection-specific transport accounts.
1480 * src/modest-tny-account-store.c:
1481 (create_per_account_local_outbox_folders): Create outboxed per modest
1482 account, not per transport account.
1484 * src/modest-tny-account.h:
1485 * src/modest-tny-account.c:
1486 (modest_tny_account_get_special_folder): For outboxes, get the
1487 parent modest account name. The account is ignored for other folders.
1488 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1489 modest account name rather than a server TnyAccount.
1491 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1493 * src/modest-tny-account.c:
1494 (modest_tny_account_new_from_server_account):
1495 Call modest_runtime_get_send_queue() immediately after creating transport
1496 accounts, so that they start trying to send email from the outbox as soon
1497 as possible at startup. This is probably what we want.
1499 * src/modest-mail-operation.c: (update_account_thread):
1500 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1501 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1502 * src/modest-tny-send-queue.h:
1503 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1504 (modest_ui_actions_on_send):
1505 Added comments about how sending works, though it needs some more work.
1507 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1509 * src/modest-tny-account.c:
1510 (modest_tny_account_get_special_folder): Add TODO because this fails when
1511 the network is busy.
1512 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1513 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1514 Do not try to show this window when there is no active account. The UI
1515 specs does not tell us what to do in this case.
1517 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1521 * src/maemo/Makefile.am:
1522 * src/widgets/Makefile.am: Some dist fixes.
1524 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1526 * src/maemo/modest-connection-specific-smtp-window.c:
1527 (on_button_edit): Make the code clearer, to prevent a double free.
1529 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1531 * src/maemo/modest-account-settings-dialog.c:
1532 (modest_account_settings_dialog_set_account_name),
1533 Check the connection-specific smtp servers checkbox if there are any.
1535 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1536 (modest_connection_specific_smtp_edit_window_init):
1537 Start with a suitable port number.
1539 * src/modest-account-mgr-helpers.h:
1540 * src/modest-account-mgr-helpers.c: Added
1541 modest_account_mgr_get_has_connection_specific_smtp().
1543 (modest_account_mgr_set_connection_specific_smtp),
1544 (modest_account_mgr_remove_connection_specific_smtp),
1545 (modest_account_mgr_get_has_connection_specific_smtp),
1546 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1547 connection-specific smtp server accounts in the account, rather than
1548 the server account conf dir.
1550 This fixes bug projects.maemo.org bug NB#58263 .
1552 * src/modest-tny-account-store.c:
1553 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1554 if there are no server accounts yet, to prevent an infinite loop when there
1555 are no accounts. Document that one must be called before the other.
1557 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1559 * src/modest-account-mgr-helpers.c:
1560 (modest_account_mgr_get_default_account): Make sure that at least
1561 one account is always the default, if there are any enabled accounts.
1562 This is just a sanity check that shouldn't be necessary.
1564 * src/modest-account-mgr-priv.c:
1565 (_modest_account_mgr_account_from_key): Unescape the conf key to
1566 get the real account name. For instance, this is an issue if a space
1567 was in the account name, which can happen because the account name
1568 is generated from the display name.
1569 (_modest_account_mgr_get_account_keyname): Always escape the
1571 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1572 Unescape the conf keys to get the real account names.
1574 For instance, previously the is-default radio button in the accounts
1575 list was not checked for any accounts at first. This fixes that,
1576 and might fix several similar bugs.
1578 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1580 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1581 Removed some debug printfs.
1583 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1585 Modest on-disk outbox directories are now here, for instance:
1586 $HOME/.modest/outboxes/<account-id-1>/outbox
1587 $HOME/.modest/outboxes/<account-id-2>/outbox
1589 $HOME/.modest/local-folders/outbox
1590 so we can have a separate outbox for each account.
1591 But they are shown as one outbox in the GtkTreeView, by using a
1592 TnyMergeFolder in a ModestTnySimpleFolderStore.
1595 * src/modest-tny-simple-folder-store.c:
1596 * src/modest-tny-simple-folder-store.h:
1597 Added ModestTnySimpleFolderStore, used to contain folders from
1598 other folder stores, such as other accounts.
1600 * src/modest-tny-outbox-account.h:
1601 * src/modest-tny-outbox-account.c:
1602 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1603 used for the per-account local outbox folders.
1605 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1606 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1607 only use this (internally) now for the non-outbox local folders.
1609 * src/modest-init.h:
1610 * src/modest-init.c: Added modest_init_one_local_folder(), for
1611 setting up the directory structure for each local folder.
1613 * src/modest-local-folder-info.c:
1614 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1615 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1617 * src/modest-local-folder-info.h:
1618 * src/modest-tny-account-store.c: (on_account_removed),
1619 (on_account_changed), (create_per_account_local_outbox_folders),
1620 (get_server_accounts), (modest_tny_account_store_get_accounts),
1621 (modest_tny_account_store_get_tny_account_by_account),
1622 (modest_tny_folder_store_is_virtual_local_folders):
1624 * src/modest-tny-account.h:
1625 * src/modest-tny-account.c:
1626 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1627 to create an on-disk per-account local outbox folder for each
1629 (create_per_account_local_outbox_folders): Create a local outbox folder
1630 for each transport account.
1631 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1632 for all local folders.
1634 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1635 instead of using g_object_get/set() directly. It is clearer.
1637 (modest_tny_folder_store_get_message_count),
1638 (modest_tny_folder_store_get_local_size
1639 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1640 because we now use these with non-acount folder stores.
1642 (modest_tny_account_get_special_folder),
1643 (modest_tny_account_new_from_server_account),
1644 (modest_tny_account_new_from_account):
1645 (recurse_folders): Adjust to the new outbox system.
1647 * src/modest-tny-folder.h:
1648 * src/modest-tny-folder.c:
1649 (modest_tny_folder_is_local_folder),
1650 (modest_tny_folder_get_local_folder_type),
1651 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1653 * src/widgets/modest-main-window.h:
1654 * src/maemo/modest-main-window.c: (create_details_widget),
1655 (modest_main_window_set_contents_style): Show details for any folder store,
1658 (modest_tny_folder_get_rules):
1659 Remove the const. C does not support constness enough for this.
1661 * src/modest-ui-actions.c:
1662 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1663 make all outboxes appear as one, in the usual local-folders tree node.
1665 (set_active_account_from_tny_account),
1666 (modest_ui_actions_on_folder_selection_changed):
1667 * src/widgets/modest-folder-view.c: (text_cell_data),
1668 (icon_cell_data), (filter_row),
1669 (add_account_folders_to_merged_folder),
1670 (add_account_folders_to_simple_folder_store), (),
1671 (get_cmp_rows_type_pos), (cmp_rows),
1672 (modest_folder_view_set_account_id_of_visible_server_account):
1673 Adjust to the new outbox system, using generic folder stores and folders
1674 in the GtkTreeModel.
1676 2007-05-23 Christian Kellner <ckellner@openismus.com>
1678 * src/modest-mail-operation.c:
1679 (modest_mail_operation_update_account):
1680 Use info->max_size instead of unintialized local var [small
1681 build fix]. (Added TODO to review that change since I don't
1684 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1686 * libmodest-dbus-client/libmodest-dbus-client.c:
1687 (libmodest_dbus_client_compose_mail): function added
1688 * src/dbus_api/modest-dbus-api.h:
1689 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1690 (on_compose_mail): Implementation of the SendAsMail functionality
1692 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1694 * src/modest-account-mgr.c:
1695 (modest_account_mgr_add_server_account): Set the secure-connection
1696 conf key for transport accounts as well as store accounts. I don't know
1697 why the if was there. For instance, this makes sure that we use SSL
1698 for the gmail preset from the easysetup wizard.
1700 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1702 * src/gnome/modest-main-window.c:
1703 (on_account_store_connecting_finished), (connect_signals):
1704 * src/maemo/modest-main-window.c:
1705 (on_account_store_connecting_finished), (connect_signals),
1706 (modest_main_window_new):
1707 Handle TnyAccountStore::connecting-finished instead of
1708 TnyDevice::connection-changed, because we cannot actually perform
1709 operations on accounts until TnyAccountStore has itself responded to
1710 the TnyDevice::connection-changed signal. This prevents a GError from
1712 Do not try to update at startup, because we (at least on scratchbox)
1713 already do an update at startup when the device goes online.
1714 This prevents a GError from tinymail.
1715 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1716 Added TODO about stopping simultaneous operations.
1718 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1720 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1721 * src/modest-mail-operation-queue.c:
1722 (modest_mail_operation_queue_remove):
1723 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1724 about where they happened.
1726 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1728 * src/modest-ui-actions.c:
1729 (modest_ui_actions_on_password_requested): Make sure that the remember
1730 output parameter is always TRUE.
1732 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1734 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1735 Show a OK/Cancel dialog if the error is a question, though we still do not
1736 know anything more about what we are asking the user.
1737 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1738 Fix an uninitialized variable (helper). This is a logic error, however.
1740 2007-05-21 Christian Kellner <ckellner@openismus.com>
1742 * src/modest-search.h:
1743 Correct bit shifting in the ModestSearchFlags enum.
1745 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1747 * src/modest-tny-account.c:
1748 (modest_tny_account_new_from_server_account): Do not use the lsub and
1749 check-all hard-coded IMAP options when using POP.
1751 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1753 * src/modest-tny-account.c:
1754 (modest_tny_account_new_from_server_account):
1755 Use NULL for the secure-auth method for POP when Password auth has been
1756 specified by the user, as we already do for IMAP. "auth=Login" causes
1757 an error from camel or the server.
1759 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1761 * src/maemo/modest-account-settings-dialog.c:
1762 (create_page_account_details),
1763 (modest_account_settings_dialog_set_account_name):
1764 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1765 for the leave-on-server checkbox, rathr than just the checkbox, when
1766 the protocol is not POP.
1768 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1770 * src/widgets/modest-account-view.c:
1771 * src/widgets/modest-account-view.h:
1772 Added modest_account_view_select_account() which will be useful later
1773 to asynchronously re-select the edited account.
1775 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1777 * src/maemo/modest-account-settings-dialog.c:
1778 (modest_account_settings_dialog_set_account_name):
1779 Automatically choose the port numbers based on the secure authentication
1780 methods, if they have not been chosen before.
1781 This fixes projects.maemo.org bug NB#56273 .
1783 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1785 * src/maemo/modest-main-window-ui.h:
1786 * src/modest-ui-actions.c:
1787 * src/modest-ui-actions.h:
1788 Connect the Tools/SMTP Servers menu item to
1789 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1790 SMTP servers dialog, as in the UI specification and saves changes when it
1791 is closed. This fixed projects.maemo.org bug NB#56305 .
1793 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1795 * src/maemo/modest-connection-specific-smtp-window.c:
1796 (modest_connection_specific_smtp_window_init):
1797 Use gtk_window_set_default_size() to make this window big enough, so
1798 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1800 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1802 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1803 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1804 (modest_connection_specific_smtp_edit_window_init),
1805 Do not try to connect to a combobox signal before the combobox exists.
1806 This fixes the cras in projects.maemo.org bug NB#56288 .
1807 (modest_connection_specific_smtp_edit_window_get_settings):
1808 Remove the server_account_name parameter which was being checked for NULL
1809 though it was not used.
1811 * src/maemo/modest-connection-specific-smtp-window.c:
1812 (modest_connection_specific_smtp_window_fill_with_connections),
1813 (on_button_edit), (modest_connection_specific_smtp_window_init):
1814 Correct the number of treemodel columns to prevent a warning.
1815 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1816 libconic does not work.
1818 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1820 * src/modest-tny-account.c:
1821 (modest_tny_account_new_from_server_account):
1822 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1823 SMTP when "None" was chosen by the user. However, with my SMTP server that
1824 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1827 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1829 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1830 to explain the memory management issue with the ID in the ModestPair.
1832 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1833 (add_sending_page), (modest_account_assistant_finalize):
1834 * src/gnome/modest-gnome-global-settings-dialog.c:
1835 (create_updating_page), (create_composing_page):
1836 * src/gnome/modest-msg-edit-window.c: (get_transports),
1837 (init_window), (modest_msg_edit_window_finalize),
1838 (modest_msg_edit_window_get_msg_data):
1839 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1840 * src/gnome/modest-transport-widget.c:
1841 (modest_transport_widget_finalize), (smtp_configuration):
1842 * src/maemo/modest-maemo-global-settings-dialog.c:
1843 (create_updating_page), (create_composing_page):
1844 * src/maemo/modest-msg-edit-window.c: (get_transports),
1845 (init_window), (modest_msg_edit_window_finalize),
1846 (modest_msg_edit_window_get_msg_data),
1847 (modest_msg_edit_window_free_msg_data):
1848 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1849 (modest_store_widget_finalize):
1850 * src/maemo/modest-transport-widget.c:
1851 (modest_transport_widget_finalize), (smtp_configuration):
1852 * src/modest-main.c: (send_mail):
1853 * src/widgets/modest-combo-box.h:
1854 * src/widgets/modest-global-settings-dialog-priv.h:
1855 * src/widgets/modest-global-settings-dialog.c:
1856 (modest_global_settings_dialog_finalize):
1857 * src/widgets/modest-msg-edit-window.h:
1858 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1859 as long as the combo box, to prevent use of freed memory for the ID.
1861 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1863 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1864 get_accounts(), to make this clearer. Do not check for the enabled gconf
1865 key, because we do not use this for server accounts (at least, not yet).
1866 This allows us to send email again.
1868 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1870 * src/maemo/modest-platform.c:
1871 (on_modest_conf_update_interval_changed), (modest_platform_init):
1872 Only respond to this particular key change. All these strcmp()s cannot be
1875 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1877 * src/maemo/modest-maemo-global-settings-dialog.c:
1878 (current_connection): Prevent a crash in scratchbox when
1879 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1880 * src/maemo/modest-platform.c:
1881 (on_modest_conf_update_interval_changed), (modest_platform_init):
1882 Get the update interval from gconf and reset it when the gconf key changes.
1884 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1886 * src/modest-protocol-info.c:
1887 * src/modest-protocol-info.h: Adde enum-specific get functions,
1888 instead of using a ModestProtocolType enum parameter.
1890 * src/gnome/modest-account-assistant.c:
1891 * src/gnome/modest-store-widget.c:
1892 * src/gnome/modest-store-widget.h:
1893 * src/gnome/modest-transport-widget.c:
1894 * src/gnome/modest-transport-widget.h:
1895 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1896 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1897 * src/maemo/easysetup/modest-easysetup-wizard.c:
1898 * src/maemo/modest-account-settings-dialog.c:
1899 * src/maemo/modest-account-settings-dialog.h:
1900 * src/maemo/modest-store-widget.c:
1901 * src/maemo/modest-store-widget.h:
1902 * src/maemo/modest-transport-widget.c:
1903 * src/maemo/modest-transport-widget.h:
1904 * src/modest-account-mgr-helpers.c:
1905 * src/modest-account-mgr-helpers.h:
1906 * src/modest-account-mgr.c:
1907 * src/modest-account-mgr.h:
1908 * src/modest-tny-account.c:
1909 * src/modest-tny-folder.c:
1910 * src/widgets/modest-account-view.c:
1911 * src/widgets/modest-retrieve-combo-box.c:
1912 * src/widgets/modest-retrieve-combo-box.h:
1913 * src/widgets/modest-secureauth-combo-box.c:
1914 * src/widgets/modest-serversecurity-combo-box.c:
1915 * src/widgets/modest-serversecurity-combo-box.h:
1916 * tests/check_account-mgr.c:
1917 Use the specific functions, and use the re-renamed enum values for GNOME too.
1919 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1921 * src/modest-pair.h:
1922 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1923 so we can get the second based on the first.
1925 * src/maemo/modest-account-settings-dialog.h:
1926 * src/maemo/modest-account-settings-dialog.c:
1927 Added get_supported_secure_authentication_methods(), though it is mostly
1928 commented-out for now until the necessary API is committed to tinymail.
1929 (modest_account_settings_dialog_set_account_name),
1930 (save_configuration): Request the supported authentication methods from the
1931 server, so we can choose a working method.
1933 * src/modest-tny-account-store.h:
1934 * src/modest-tny-account-store.c:
1935 (modest_tny_account_store_get_session): Rename from
1936 tny_account_store_get_session().
1938 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1940 * src/modest-protocol-info.h: Split the ModestProtocol enum
1941 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1942 There was no need to have these unrelated values in one enum.
1944 * src/: many files: Adapted to changed enum. This makes the code a bit
1945 clearer, and the compiler could catch some errors.
1947 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1949 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1950 Show the detailed internal camel error message when an error happens
1951 during the configuration, so that our testers can give us more clues.
1952 For instance, in projects.maemo.org bug NB#56910 .
1954 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1956 * src/modest-tny-account.c:
1957 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1958 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1960 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1962 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1963 * src/maemo/modest-account-settings-dialog.c:
1964 (modest_account_settings_dialog_set_account_name),
1965 (save_configuration): For the incoming secure authentication checkbox,
1966 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1967 the UI specification. PLAIN does not seem to be supported for most IMAP
1968 servers anyway, and I am not sure what it would mean.
1969 However, we probably need to discover which of the secure-authentication
1970 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1971 * src/modest-account-mgr-helpers.c:
1972 (modest_account_mgr_get_server_account_data):
1974 * src/modest-tny-account.c:
1975 (modest_tny_account_new_from_server_account):
1976 Use tny_account_set_mech() to set secure-authentication methods,
1977 with some special-casing for IMAP, based on my observations of how
1980 * src/modest-account-mgr-helpers.h:
1981 * src/modest-account-mgr.c:
1982 * src/modest-defs.h: Comment that the URI is only used for local folders.
1984 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1986 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1987 parameter const, just to be neat.
1988 * src/modest-text-utils.c: (modest_text_utils_inline):
1989 End g_strconcat() with NULL, as its documentation says. This is almost
1990 certainly the cause of my crash at startup on the device. Interestingly,
1991 valgrind doesn't tell us about these errors.
1993 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1995 * scripts/build-packages: Added more precise comments about how to use
1996 this script, though I still get this error:
1997 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1998 error building tinymail
2000 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2002 * src/maemo/modest-main-window.c: (on_account_update):
2003 Very slight cleanup, hoping to make it simpler to discover what causes
2004 a crash here sometimes.
2006 * src/modest-tny-account.c:
2007 (modest_tny_account_new_from_server_account): Set the port. Added
2008 comments about the options and a TODO comment because I need to find out
2009 how to specify the secure authentication method.
2011 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2013 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2014 changed CFlags paths form modest to libmodest
2016 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2018 * src/modest-account-mgr-helpers.c:
2019 (modest_account_mgr_get_server_account_data),
2020 (modest_account_mgr_free_server_account_data):
2021 * src/modest-account-mgr-helpers.h:
2022 * src/modest-account-mgr.c:
2023 (modest_account_mgr_add_server_account):
2024 * src/modest-defs.h:
2025 * src/modest-tny-account.c:
2026 (modest_tny_account_new_from_server_account):
2027 Determine the options for tny_camel_account_add_option() here,
2028 based on the settings, rather than storing them directly in gconf.
2030 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2032 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2033 Show a more friendly error dialog now that we expect (from the tinymail
2034 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2036 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2038 * src/maemo/modest-main-window.c: (on_account_update): Check that
2039 account_name is not NULL, to prevent a crash at startup that I am
2040 seeing on the N800. I do wonder why it is NULL.
2042 * src/maemo/easysetup/modest-easysetup-wizard.c:
2043 (create_page_user_details):
2044 * src/maemo/modest-account-settings-dialog.c:
2045 (create_page_user_details), (create_page_outgoing):
2046 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2047 (modest_connection_specific_smtp_edit_window_init):
2048 * src/modest-ui-actions.c:
2049 (modest_ui_actions_on_password_requested):
2050 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2051 might do something useful with the on-screen keyboard.
2053 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2055 * src/maemo/modest-main-window.c: (on_account_update):
2056 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2057 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2059 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2061 * src/modest-tny-account-store.c: (on_account_changed):
2062 Correct the signature of this signal handler.
2064 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2066 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2067 Show a HildonNote instead of a GtkDialog for Maemo.
2069 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2071 * src/widgets/modest-account-view.h:
2072 * src/widgets/modest-account-view.c: (on_account_changed),
2073 (on_account_removed). Added a boolean flag, set/unset by
2074 modest_account_view_block_conf_updates(),
2075 modest_account_view_unblock_conf_updates() to prevent unnecessary
2076 updates, but this is not very useful because the gconf notifications are
2077 so delays (maybe only on Maemo Bora).
2078 So auto-updating is turned off, and these functions do an explicit
2079 update when necessary.
2080 However, something else is still doing too much work when adding/removing
2081 accounts, probably in another part of the application.
2083 * src/maemo/modest-account-view-window.c:
2084 (on_delete_button_clicked), (on_edit_button_clicked),
2085 (on_new_button_clicked): Use the new functions.
2087 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2089 * src/modest-account-mgr-helpers.c:
2090 (modest_account_mgr_set_first_account_as_default):
2091 Sort the list of names alphabetically-by-title, so we choose the first one
2093 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2094 alphabetically by the title.
2096 This fixes projects.maemo.org bug NB#56418 .
2098 * src/modest-account-mgr-priv.c:
2099 (_modest_account_mgr_account_from_key):
2100 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2101 avoid a valgrind error, and possible random behaviour.
2103 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2105 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2106 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2107 tinymail documentation to say that this can be expected.
2108 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2109 pretty, and should not happen, but I would prefer to know when it does.
2111 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2113 * configure.ac: When using the older hildon version, probably on Bora,
2114 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2116 * src/widgets/modest-attachment-view.c:
2117 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2120 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2122 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2123 Implemented the prototype. Can be tested with
2124 tests/dbus_api/test_open_message:
2126 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2128 * src/modest-tny-account-store.c:
2129 (modest_tny_account_store_instance_init), (get_password):
2130 * src/modest-ui-actions.c:
2131 (modest_ui_actions_on_password_requested):
2132 Do not store the password in gconf, because this function is called
2133 for non-remembered passwords. Actually use the cached (in the hash map)
2134 password instead of releasing it.
2135 The password will now not be remembered if it is asked via the protected
2136 password dialog, as per the UI spec.
2138 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2140 * src/modest-defs.h:
2141 * src/modest-account-mgr-helpers.h:
2142 * src/modest-account-mgr-helpers.c:
2143 Added modest_server_account_get_username_has_succeeded(),
2144 modest_server_account_set_username_has_succeeded().
2145 (modest_server_account_set_username),
2146 Reset the has-succeeded flag if the username changes.
2148 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2149 * src/maemo/modest-connection-specific-smtp-window.c:
2150 (modest_connection_specific_smtp_window_save_server_accounts):
2151 Use modest_server_account_set_username() instead of using
2152 modest_conf_set_string() directly, so that the has-succeeded flag is always
2155 * src/modest-ui-actions.c:
2156 (modest_ui_actions_on_password_requested): Dim the username entry if
2157 the username has ever worked, as per the UI spec.
2159 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2161 * src/modest-tny-account-store.c: (get_password):
2162 * src/modest-ui-actions.c:
2163 (modest_ui_actions_on_password_requested):
2164 Allow the username to be changed too, though there is more work to
2165 be done on exactly how this behaves.
2167 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2169 * src/modest-account-mgr-helpers.h:
2170 * src/modest-account-mgr-helpers.c:
2171 Added modest_account_mgr_get_display_name(),
2172 modest_server_account_get_username(),
2173 modest_server_account_set_username(),
2174 modest_server_account_set_password(),
2175 modest_server_account_get_hostname() functions so we do not need to
2176 use the conf API directly.
2178 * src/maemo/modest-main-window.c: (connect_signals):
2179 Actually connect ot the ModestAccountStore::request-password signal,
2180 so that we show the dialog when the password is requested by Tinymail,
2181 for isntance if it is empty.
2183 * src/modest-marshal.list:
2184 * src/modest-tny-account-store.c:
2185 (modest_tny_account_store_class_init), (get_password),
2186 (modest_tny_account_store_alert):
2187 * src/modest-tny-account-store.h:
2188 * src/modest-ui-actions.h:
2189 * src/modest-ui-actions.c:
2190 (modest_ui_actions_on_password_requested):
2191 Change the signal parameters, so it is obvious that we are providing
2192 the non human-readable server name, and receiving both the username
2193 and password, though changing of the username is not yet implemented.
2194 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2195 for the GNOME version.
2197 This should fix the projects.maemo.org bug NB#56209, though it does not
2198 work on Bora, because the gconf_client_get() for the password fails
2199 immediately after we save it with gconf_client_set().
2201 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2204 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2205 caused an undefined symbol error:
2206 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2208 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2210 * src/modest-tny-account-store.c:
2211 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2212 using a GError instead of a string message, so we can translate it in
2215 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2217 * src/maemo/modest-address-book.c:
2218 (modest_address_book_check_names):
2219 * src/maemo/modest-msg-view-window.c:
2220 (modest_msg_view_window_clipboard_owner_change):
2221 * src/modest-init.c: (modest_init_init_ui):
2222 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2223 (update_folders_cb), (modest_mail_operation_update_account):
2224 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2225 (modest_ui_actions_on_msg_attachment_clicked),
2226 (modest_ui_actions_on_msg_recpt_activated):
2227 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2228 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2229 (modest_msg_view_search_next):
2230 * src/widgets/modest-recpt-editor.c:
2231 (modest_recpt_editor_on_button_release_event),
2232 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2233 g_message(). At this point we should only be seeing interesting errors on
2234 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2236 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2238 (modest_wizard_dialog_force_title_update):
2239 * src/maemo/easysetup/modest-wizard-dialog.h:
2240 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2241 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2242 can update the title when appropriate. Otherwise the title is wrong if the
2243 pages are added after adding the notebook to the dialog.
2244 This must be a problem in HildonWizardDialog too.
2245 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2247 * src/maemo/easysetup/modest-easysetup-wizard.c:
2248 (create_subsequent_customsetup_pages),
2249 (create_subsequent_easysetup_pages):
2250 Call modest_wizard_dialog_force_title_update() so that the title is
2251 correct even with GTK+ < 2.10.
2252 This fixes projects.maemo.org bug NB#56145 .
2254 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2256 * src/maemo/modest-platform.c:
2257 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2258 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2261 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2263 * src/widgets/modest-window.h:
2264 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2265 and modest_window_save_state(), which invokes it.
2267 * src/widgets/modest-window-mgr.h:
2268 * src/widgets/modest-window-mgr.c:
2269 Added modest_window_mgr_save_state_for_all_windows(), which calls
2270 the save_state vfunc on all registered windows, if implemented.
2272 * src/gnome/modest-msg-edit-window.c:
2273 * src/gnome/modest-msg-view-window.c:
2274 * src/maemo/modest-msg-edit-window.c:
2275 * src/maemo/modest-msg-view-window.c:
2276 * src/maemo/modest-main-window.c:
2277 Specify the existing save_settings functions as implementations of
2278 ModestWindow::save_state_func().
2280 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2281 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2282 enabling hibernation, for instance.
2284 We may need to do the same thing for restoring settings.
2287 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2289 * src/widgets/modest-window-mgr.c:
2290 * src/widgets/modest-window-mgr.h:
2291 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2292 modest_window_mgr_get_hibernation_is_prevented().
2294 * src/maemo/modest-main-window.c:
2295 (on_hildon_program_is_topmost_notify): Prevent hibernation
2296 (possible when the application goes to the background in the WM),
2297 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2299 * src/maemo/easysetup/modest-easysetup-wizard.c:
2300 (modest_easysetup_wizard_dialog_init):
2301 * src/maemo/modest-account-settings-dialog.c:
2302 (modest_account_settings_dialog_init):
2303 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2304 (modest_connection_specific_smtp_edit_window_init):
2305 * src/maemo/modest-connection-specific-smtp-window.c:
2306 (modest_connection_specific_smtp_window_init):
2307 * src/maemo/modest-signature-editor-dialog.c:
2308 (modest_signature_editor_dialog_init):
2309 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2310 prevent hibernation while any of these account settings dialogs are open.
2312 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2314 * src/maemo/Makefile.am:
2315 * src/maemo/modest-osso-state-saving.c:
2316 * src/maemo/modest-osso-state-saving.h: Added
2317 modest_osso_load_state() and modest_osso_save_state() though they do
2318 nothing now. They should iterate through all the open windows and load/save
2320 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2321 save state when closing.
2323 * src/maemo/modest-main-window.c:
2324 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2325 Add a notification handler for the HildonProgram::is-topmost property,
2326 so we can allow hibernation when the application goes into the background.
2327 But we still need to detect when the accounts setup windows are open so
2328 we can stop hibernation when they are open.
2329 To do this, I also added the main window the HildonProgram. This might have
2330 other side-effects/benefits, and should maybe be done for other windows.
2332 * src/maemo/modest-osso-autosave-callbacks.h:
2333 * src/maemo/modest-osso-autosave-callbacks.c:
2334 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2335 though it does not do anything yet, and we might never need this to do
2336 anything. For instance, we already save drafts.
2338 * src/maemo/modest-platform.c: (modest_platform_init):
2339 Specify the libosso auto-save callback.
2341 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2343 * src/maemo/modest-platform.c:
2344 (modest_platform_set_update_interval):
2345 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2346 aparently stays valid between application instances, so we can use this
2347 to remove and reset it later. According to a maemo-developers email from
2350 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2352 * configure.ac: Depend on libalarm for Maemo.
2354 * src/dbus_api/modest-dbus-api.h:
2355 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2356 (on_send_receive), (modest_dbus_req_handler):
2357 Handle a SEND_RECEIVE D-Bus method.
2359 * libmodest-dbus-client/libmodest-dbus-client.c:
2360 (libmodest_dbus_client_send_and_receive):
2361 * libmodest-dbus-client/libmodest-dbus-client.h:
2362 Add C convenience functions for calling the new D-Bus method.
2364 * src/modest-platform.h:
2365 * src/gnome/modest-platform.c:
2366 * src/maemo/modest-platform.c:
2367 Added modest_platform_set_update_interval(), which uses the
2368 alarmd API on Maemo.
2369 (modest_platform_init),
2370 Call modest_platform_set_update_interval(), using a hard-coded
2371 interval for now (until the global settings dialog is implemented),
2372 though I am not sure that this makes sense yet.
2374 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2376 * src/dbus_api/modest-dbus-callbacks.c:
2377 (modest_osso_cb_hw_state_handler):
2378 * src/dbus_api/modest-dbus-callbacks.h:
2379 * src/maemo/modest-platform.c: (modest_platform_init):
2380 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2381 in case this has some effect on the ability for Maemo to ping the
2384 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2386 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2387 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2388 warning. It is probably a logic error, but I need to fix the build.
2390 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2392 * src/modest-account-mgr.h:
2393 * src/modest-account-mgr.c:
2394 (modest_account_mgr_account_names): Add a gboolean enabled_only
2395 parameter, so we can get lists of onlt the enabled accounts.
2397 (modest_account_mgr_add_account),,
2398 (modest_account_mgr_account_with_display_name_exists):
2399 * src/maemo/modest-msg-edit-window.c: (get_transports):
2400 * src/modest-account-mgr-helpers.c:
2401 (modest_account_mgr_set_first_account_as_default):
2402 * src/modest-init.c: (init_default_account_maybe):
2403 * src/modest-tny-account-store.c: (get_accounts):
2404 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2405 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2406 * tests/check_account-mgr.c: (START_TEST):
2407 Provide the extra parameter, as appropriate.
2409 * src/widgets/modest-account-view.c: (update_account_view):
2410 Do not show disabled accounts (meaning that there is no way to
2411 enable/disable accounts in the UI (the feature is not in our UI
2412 specification), so we can use this internally only to mark unfinished
2413 or temporary account data.
2415 * src/maemo/easysetup/modest-easysetup-wizard.c:
2416 (create_account): Add boolean enable parameter, so we can specify FALSE
2417 to create the temporary account.
2418 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2419 (on_before_next): When finishing, when there is a temporary account, just
2421 Also, use a timeout to delay the showing of the dialog until gconf is likely
2422 to return correct information, due to a maemo gconf bug that is fixed in
2423 osso 1.1, but not yet in Bora.
2424 However, the dialog stays on screen after it is destroyed.
2426 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2427 for invalid data when cancelling. Use a hildon note instead of a dialog
2428 to complain about invalid data. Do not show the account-saved note if the
2429 account is disabled (a temporary account that will not really be saved for use
2432 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2434 * src/modest-account-mgr-helpers.h:
2435 * src/modest-account-mgr-helpers.c:
2436 Added modest_account_mgr_unset_default_account(),
2437 Added modest_account_mgr_set_first_account_as_default().
2439 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2440 If it was the default account, unset the default account name.
2442 * src/maemo/modest-account-view-window.c:
2443 (on_delete_button_clicked): If it was the default account,
2444 set the first remaining account as the default instead.
2446 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2447 a NULL account or a NULL default account, to prevent a crash. This should
2448 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2451 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2453 * src/widgets/modest-recpt-editor.c:
2454 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2455 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2456 TODO comment for this. This fixes the build.
2458 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2459 be the best place for it. This will in future update all auto-update accounts,
2460 rather than just the current/default account, when that gconf key exists.
2461 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2462 if there are no accounts, before calling do_send_receive().
2463 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2465 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2466 * src/maemo/modest-main-window-ui.h:
2467 * src/maemo/modest-main-window.c: (on_connection_changed),
2468 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2469 directly, becaue the signal handler does more.
2471 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2473 * src/modest-account-mgr-helpers.c:
2474 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2475 for the case that the account does not exist.
2477 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2478 (equivalent to the modest account name) rather than the tinymail account name
2479 (equivalent to the modest account title - human readable) to get the account data.
2480 Check for null account data to prevent the crash, and add a TODO comment saying that
2481 this needs fixing because it is using the server account name instead of the account name.
2483 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2485 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2486 * src/maemo/modest-account-settings-dialog.c: (show_error),
2488 Use hildon_note_new_information() for informative and error messages,
2489 which seems to be expected for Maemo applications (no documentation that I know of
2490 says this). I am surprised that there is no distinction between info and error
2493 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2495 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2496 it is easy to find where this is used.
2498 * src/maemo/easysetup/modest-easysetup-wizard.c:
2499 (create_page_welcome), (create_page_account_details),
2500 (create_page_user_details), (create_page_complete_easysetup),
2501 (create_page_custom_incoming), (create_page_custom_outgoing),
2502 (create_page_complete_custom):
2503 * src/maemo/modest-account-settings-dialog.c:
2504 (create_page_account_details), (create_page_user_details),
2505 (create_page_incoming), (create_page_outgoing):
2506 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2507 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2508 (modest_connection_specific_smtp_edit_window_init):
2509 * src/maemo/modest-connection-specific-smtp-window.c:
2510 (modest_connection_specific_smtp_window_init):
2511 * src/maemo/modest-signature-editor-dialog.c:
2512 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2513 and scrolling policy as per the Email Application Layout Guide, if I have
2516 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2518 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2519 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2520 which were empty, because these vfuncs have been removed from TnyAccountStore.
2521 This fixes the build.
2523 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2525 * src/maemo/modest-main-window.c:
2526 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2527 showing/hiding it. Added TODO because it probably should not be NULL.
2528 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2529 because unnecessary g_warnings() make degugging difficult.
2531 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2533 * src/maemo/modest-msg-edit-window.c:
2534 (modest_msg_edit_window_select_color),
2535 (modest_msg_edit_window_select_background_color): 2 const corrections and
2536 moving 2 #endifs before closing brackets, to fix the build.
2538 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2540 * src/maemo/easysetup/modest-easysetup-wizard.h:
2541 * src/maemo/easysetup/modest-easysetup-wizard.c:
2542 (modest_easysetup_wizard_dialog_finalize),
2543 (on_button_edit_advanced_settings), (create_page_complete_custom),
2544 (on_response), (create_account):
2545 Implement the Advanced Settings edit button, by saving the account information,
2546 for the Advanded Settings dialog to use directly from gconf, and removing it
2547 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2548 Bug #5533 in the projects.maemo.org bugzilla.
2550 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2552 * src/maemo/modest-msg-view-window.c:
2553 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2554 when opening a message window.
2556 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2558 * src/maemo/easysetup/modest-easysetup-wizard.c:
2559 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2562 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2563 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2564 gconf settings. I probably added more checks than necessary, but that is safer.
2566 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2567 variable to fix the build, but this seems to be used when it is still NULL.
2569 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2571 * src/modest-platform.h:
2572 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2573 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2574 * src/modest-main.c: Implement this function so we can avoid using
2575 maemo-specific API from cross-platform code.
2577 * src/modest-tny-account-store.c:
2578 (get_smtp_specific_transport_account_for_open_connection):
2579 * src/modest-ui-actions.c: (check_for_connection),
2580 (modest_ui_actions_on_item_not_found):
2581 Use modest_platform_connect_and_wait() and put #idefs around other
2582 maemo-specific code, because only maemo currently has a way to
2583 identify connection names.
2585 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2587 * src/modest-tny-account-store.h:
2588 * src/modest-tny-account-store.c:
2589 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2590 the connection-specific SMTP server settings in the configuration.
2592 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2594 * src/maemo/modest-main-window.c: (on_connection_changed),
2596 * src/modest-main.c: (main), (start_ui), (send_mail):
2597 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2598 that is what is intended.
2600 * src/modest-ui-actions.c: (action_send), (action_receive),
2601 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2602 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2603 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2604 SMTP server is used when it is specified.
2606 (modest_ui_actions_on_send_receive):
2607 Check that a connection is open before proceeding.
2608 Receive and then send, instead of vice-versa, as per the specification.
2610 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2612 * src/modest-mail-operation.c:
2613 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2614 though I guess it should be something other than NULL.
2616 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2618 * src/maemo/easysetup/modest-easysetup-wizard.c:
2619 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2620 combo twice, to avoid an g_warning and to make it visible again.
2621 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2622 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2623 (already intended) dereference when detaching, because we then recreate the menu.
2624 But I am not sure why the warning was happening, and it is possible that this is a memory
2627 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2629 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2630 and uri_parse_mailto() utility functions.
2631 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2633 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2635 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2637 * src/dbus_api/modest-dbus-api.h:
2638 * src/dbus_api/modest-dbus-callbacks.c:
2639 Use an idle callback to execute the modest code in the application's own thread.
2640 Remove the helloworld example method.
2641 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2642 parsed, and the open-message method is not implemented because this is not yet implemented in
2644 * libmodest-dbus-client/libmodest-dbus-client.c:
2645 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2646 (libmodest_dbus_client_open_message):
2647 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2649 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2650 body without crashing.
2652 * tests/dbus_api/Makefile.am:
2653 * tests/dbus_api/test_mail_to.c:
2654 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2656 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2658 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2659 Added file to fix the build. Sorry.
2661 * src/dbus_api/Makefile.am:
2662 * src/dbus_api/modest-dbus-api.h:
2663 * src/dbus_api/modest-dbus-callbacks.h:
2664 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2665 (modest_dbus_req_handler):
2666 Put constants in a separate header so it can be reused by the
2667 client library, without duplication
2669 * libmodest-dbus-client/Makefile.am:
2670 * libmodest-dbus-client/libmodest-dbus-client.c:
2671 (libmodest_dbus_client_call_helloworld),
2672 (libmodfest_dbus_client_send_mail),
2673 (libmodfest_dbus_client_mailto),
2674 (libmodfest_dbus_client_open_message):
2675 * libmodest-dbus-client/libmodest-dbus-client.h:
2676 (Partly) Implement a send_mail D-Bus method.
2678 * tests/dbus_api/Makefile.am:
2679 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2680 the send_email D-Bus method.
2682 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2686 * libmodest-dbus-client/Makefile.am:
2687 * libmodest-dbus-client/libmodest-dbus-client.c:
2688 * libmodest-dbus-client/libmodest-dbus-client.h:
2689 * tests/dbus_api/Makefile.am:
2690 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2691 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2693 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2695 * src/maemo/easysetup/modest-easysetup-wizard.c:
2696 (create_page_account_details):
2697 * src/maemo/modest-account-settings-dialog.c:
2698 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2699 widgets, because this might not be the default in future versions of the Maemo GTK+.
2700 However, I can not not get capitalization to work even in a simple test case.
2702 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2704 * src/maemo/easysetup/modest-easysetup-wizard.c:
2705 (create_page_custom_incoming), (create_page_custom_outgoing):
2706 * src/maemo/modest-account-settings-dialog.c:
2707 (create_page_account_details), (create_page_incoming),
2708 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2709 instead of using gtk_check_button_with_label(), so they are aligned like the other
2710 widgets, as per the UI spec.
2712 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2714 * src/maemo/easysetup/modest-easysetup-wizard.c:
2715 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2716 * src/widgets/modest-validating-entry.c:
2717 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2718 Modest prefix instead of an EasySetup prefix.
2720 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2722 * src/widgets/modest-validating-entry.h:
2723 * src/widgets/modest-validating-entry.c: (on_insert_text),
2724 Added easysetup_validating_entry_set_max_func(), used to set a callback
2725 to call when the max number of characters is reached. GtkEntry has a max-length
2726 already but is silent about it.
2728 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2729 (create_page_account_details), (create_page_user_details),
2731 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2732 (create_page_account_details), (create_page_user_details),
2733 (create_page_outgoing):
2734 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2735 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2736 the UI spec, when the user tries to enter more than the max number of characters.
2738 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2740 * src/maemo/easysetup/modest-easysetup-wizard.c:
2741 (create_page_user_details), (create_page_custom_incoming),
2742 (create_page_custom_outgoing):
2743 * src/maemo/modest-account-settings-dialog.c:
2744 (create_page_user_details), (create_page_incoming),
2745 (create_page_outgoing):
2746 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2747 (modest_connection_specific_smtp_edit_window_init):
2748 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2749 not appropriate. Bad Maemo-specific defaults!.
2751 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2753 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2754 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2755 (modest_signature_editor_dialog_set_settings):
2756 Disable the label and textview when the checkbox is disabled, and use the
2757 specified (UI spec) default signature text.
2759 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2761 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2762 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2764 * src/modest-defs.h:
2765 * src/modest-account-mgr-helpers.h:
2766 * src/modest-account-mgr-helpers.c:
2767 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2769 * src/maemo/Makefile.am:
2770 * src/maemo/modest-signature-editor-dialog.c:
2771 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2774 * src/maemo/modest-account-settings-dialog.h:
2775 * src/maemo/modest-account-settings-dialog.c:
2776 (modest_account_settings_dialog_finalize), (on_button_signature),
2777 (save_configuration): Use the new dialog when the Edit button is pressed, and
2778 save the changes if necessary, as per the UI spec.
2780 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2782 * src/maemo/Makefile.am:
2783 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2784 based on maemo-develoers email from Dirk.
2786 * src/maemo/easysetup/modest-easysetup-wizard.c:
2787 (create_page_welcome), (create_page_account_details),
2788 (create_page_user_details), (create_page_complete_easysetup),
2789 (create_page_custom_incoming), (create_page_custom_outgoing),
2790 (create_page_complete_custom),
2791 (modest_easysetup_wizard_dialog_init):
2792 * src/maemo/modest-account-settings-dialog.c:
2793 (create_page_account_details), (create_page_user_details),
2794 (create_page_incoming), (create_page_outgoing),
2795 (modest_account_settings_dialog_init):
2796 * src/maemo/modest-connection-specific-smtp-window.c:
2797 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2799 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2801 * src/maemo/easysetup/modest-easysetup-wizard.c:
2802 (create_page_account_details), (create_page_custom_outgoing),
2803 (create_page_complete_custom):
2804 * src/maemo/modest-account-settings-dialog.c:
2805 (create_page_user_details), (create_page_incoming),
2806 (create_page_outgoing):
2807 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2808 (modest_connection_specific_smtp_edit_window_init):
2809 Use the correct (UI spec) port min/max, and use horizontal separators,
2812 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2814 * src/maemo/easysetup/modest-easysetup-wizard.c:
2815 (set_default_custom_servernames):
2816 * src/maemo/modest-account-settings-dialog.c:
2817 (create_page_incoming), (on_combo_outgoing_security_changed),
2818 (on_combo_incoming_security_changed), (create_page_outgoing),
2819 (modest_account_settings_dialog_set_account_name),
2820 (save_configuration):
2821 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2822 (on_combo_security_changed),
2823 (modest_connection_specific_smtp_edit_window_init),
2824 (modest_connection_specific_smtp_edit_window_set_connection),
2825 (modest_connection_specific_smtp_edit_window_get_settings):
2826 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2829 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2832 * src/maemo/easysetup/modest-easysetup-wizard.c:
2833 (create_page_custom_outgoing), (create_page_complete_custom):
2834 * src/maemo/modest-account-settings-dialog.c:
2835 (create_page_user_details), (create_page_outgoing):
2836 * src/maemo/modest-account-view-window.c: (button_box_new):
2837 Use changed logical IDs as per the most recent UI spec:
2838 mcen_bd_emailsetup_edit -> mcen_bd_edit
2839 mcen_bd_emailsetup_delete -> mcen_bd_delete
2840 mcen_bd_emailsetup_close -> mcen_bd_close
2842 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2846 * src/dbus_api/Makefile.am:
2847 * src/dbus_api/modest-dbus-callbacks.c:
2848 * src/dbus_api/modest-dbus-callbacks.h:
2849 * src/maemo/modest-platform.c: (modest_platform_init):
2850 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2852 * tests/Makefile.am:
2853 * tests/dbus_api/Makefile.am:
2854 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2856 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2858 * src/maemo/modest-account-settings-dialog.c:
2859 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2860 Removed unnecessary includes.
2862 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2864 * src/maemo/easysetup/modest-easysetup-wizard.c:
2865 * src/maemo/modest-account-settings-dialog.c:
2866 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2867 * src/widgets/Makefile.am:
2868 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2869 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2870 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2871 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2872 * src/widgets/modest-secureauth-combo-box.c:
2873 * src/widgets/modest-secureauth-combo-box.h:
2874 * src/widgets/modest-serversecurity-combo-box.c:
2875 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2876 made the GObject names more consistent with the rest of the Modest code.
2878 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2880 * src/maemo/easysetup/Makefile.am:
2881 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2882 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2883 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2884 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2885 * src/maemo/easysetup/modest-easysetup-wizard.c:
2886 * src/maemo/easysetup/modest-validating-entry.c:
2887 * src/maemo/easysetup/modest-validating-entry.h:
2888 * src/maemo/modest-account-settings-dialog.c:
2889 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2890 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2891 widgets/ because they are used outside of easysetup too. After checking in,
2892 svn will allow me to rename them too.
2894 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2896 * src/gnome/modest-msg-edit-window.c:
2897 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2898 linker error, to fix the build on the GNOME platform.
2899 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2900 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2901 ifdefed out to avoid a warning.
2903 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2905 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2906 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2907 some alternative for GTK+ 2.6.
2909 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2911 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2913 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2914 specified for EmailAccountsDialog in UI spec.
2916 * src/maemo/easysetup/modest-easysetup-wizard.c:
2917 * src/maemo/easysetup/modest-easysetup-wizard.h:
2918 * src/maemo/modest-account-settings-dialog.c:
2919 * src/maemo/modest-account-settings-dialog.h:
2920 Reuse a member window widget for the connection-specific SMTP server accounts,
2921 so we can tell it to create/save the accounts only if we actually save changes.
2923 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2924 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2925 (modest_connection_specific_smtp_edit_window_get_settings):
2926 Return a struct instance for temporarily remembering the entered data.
2928 * src/maemo/modest-connection-specific-smtp-window.h:
2929 * src/maemo/modest-connection-specific-smtp-window.c:
2930 (modest_connection_specific_smtp_window_finalize),
2931 (modest_connection_specific_smtp_window_fill_with_connections),
2933 (modest_connection_specific_smtp_window_save_server_accounts),
2934 (update_model_server_names): Do not actually save data until asked,
2935 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2937 (on_selection_changed),
2938 (modest_connection_specific_smtp_window_init): Disable the edit
2939 button when nothing is selected.
2941 * src/modest-account-mgr-helpers.c:
2942 * src/modest-account-mgr-helpers.h:
2943 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2946 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2948 * src/modest-account-mgr-helpers.h:
2949 * src/modest-account-mgr-helpers.c:
2950 (modest_account_mgr_get_unused_account_name),
2951 (modest_account_mgr_get_unused_account_display_name): Added these
2952 utility functions, to avoid code duplication.
2954 * src/maemo/easysetup/modest-easysetup-wizard.c:
2955 (create_page_account_details), (create_account):
2956 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2957 (on_combo_security_changed),
2958 (modest_connection_specific_smtp_edit_window_init),
2959 (modest_connection_specific_smtp_edit_window_save_settings):
2960 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2961 * src/maemo/modest-connection-specific-smtp-window.c:
2962 (modest_connection_specific_smtp_window_finalize),
2963 (modest_connection_specific_smtp_window_fill_with_connections),
2964 (on_button_edit), (modest_connection_specific_smtp_window_init):
2965 * src/maemo/modest-connection-specific-smtp-window.h:
2966 Implementing saving of connection-specific server accounts.
2968 But I need to refactor this so we can save the data for each
2969 possible connection-specific account and only actually create the server accounts
2970 when the easysetup finished, or the OK button is pressed on the account settings
2973 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2975 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2976 (on_combo_security_changed):
2977 (modest_connection_specific_smtp_edit_window_init):
2978 Auto-fill the port number as in the account settings.
2980 (modest_connection_specific_smtp_edit_window_set_connection):
2981 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2982 * src/maemo/modest-connection-specific-smtp-window.c:
2983 (fill_with_connections), (on_button_edit),
2984 (modest_connection_specific_smtp_window_init):
2985 Turn the edit window into a dialog to simplify the code, and
2986 set a WM hint as in a GtkDialog, because only a popup can be on top of
2987 another window in Maemo, and popups usually have no WM decoration.
2989 * src/modest-defs.h:
2990 * src/modest-account-mgr-helpers.c:
2991 (modest_account_mgr_set_connection_specific_smtp),
2992 (modest_account_mgr_remove_connection_specific_smtp),
2993 (modest_account_mgr_get_connection_specific_smtp):
2994 * src/modest-account-mgr-helpers.h: Some functions to write the
2995 connection-specific SMTP server information. Not yet used.
2998 * src/widgets/modest-folder-view.c: (text_cell_data):
2999 Fix a warning about an uninitialized variable.
3000 (on_configuration_key_changed): Put an #ifdef around the use
3001 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3003 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3005 * src/maemo/modest-account-settings-dialog.h:
3006 * src/maemo/modest-account-settings-dialog.c:
3007 Added connect_for_modified() utility function to mark the new modified boolean.
3009 (create_page_account_details), (create_page_user_details),
3010 (create_page_incoming), (create_page_outgoing), (on_response),
3011 (modest_account_settings_dialog_init),
3012 (modest_account_settings_dialog_set_account_name):
3013 Only warn about unsaved changes when there are actually unsaved changes.
3015 * src/modest-account-mgr-helpers.c:
3016 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3017 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3018 to get the data from there in future.
3020 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3022 * src/modest-defs.h:
3024 * src/modest-account-mgr-helpers.h:
3025 * src/modest-account-mgr-helpers.c:
3026 Store the security account setting in a single conf key instead of using
3027 the options list, so that the list is left for just the to-be-removed camel hack,
3028 and because gconf_client_set_list() is failing for some reason.
3030 * src/modest-account-mgr.c:
3031 (modest_account_mgr_add_server_account):
3032 * src/maemo/modest-account-settings-dialog.c:
3033 (modest_account_settings_dialog_set_account_name),
3034 (save_configuration): Use the renamed functions.
3037 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3039 * src/widgets/Makefile.am:
3040 * src/widgets/modest-limit-retrieve-combo-box.c:
3041 * src/widgets/modest-limit-retrieve-combo-box.h:
3042 * src/widgets/modest-retrieve-combo-box.c:
3043 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3044 the account settings dialog.
3046 * src/modest-defs.h:
3047 * src/modest-account-mgr-helpers.h:
3048 * src/modest-account-mgr-helpers.c:
3049 (modest_server_account_get_option_secure_auth),
3050 (modest_server_account_set_option_secure_auth):
3051 * src/modest-account-mgr.c:
3052 (modest_account_mgr_add_server_account):
3053 Use the existing AUTH_MECH conf key for the secure-auth setting,
3054 instead of putting it in the list options, because this was actually used already.
3056 * src/maemo/modest-account-settings-dialog.c:
3057 (create_page_account_details),
3058 (modest_account_settings_dialog_set_account_name),
3059 (save_configuration):
3060 * src/maemo/modest-account-settings-dialog.h:
3061 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3062 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3064 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3066 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3067 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3068 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3070 * src/modest-defs.h:
3071 * src/maemo/modest-account-settings-dialog.c:
3072 (create_page_incoming), (on_combo_outgoing_security_changed),
3073 (on_combo_incoming_security_changed), (create_page_outgoing),
3074 (modest_account_settings_dialog_set_account_name),
3075 (save_configuration): Load/Save the port number, and change it when the
3076 security combo changes, to suitable defaults.
3078 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3080 * src/modest-account-mgr.c:
3081 (modest_account_mgr_add_server_account): Set the security and secure-auth
3082 options, and add a comment saying that the other camel-specific options should be
3085 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3087 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3089 * src/modest-tny-account-store.c: (account_list_free),
3090 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3091 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3094 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3096 * src/modest-protocol-info.c:
3097 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3098 is required by our UI spec. Maybe something in our implementation will use this eventually.
3099 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3100 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3101 instead of the previous 0 placeholder.
3103 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3104 secure-auth settings.
3105 * src/modest-account-mgr-helpers.h:
3106 * src/modest-account-mgr-helpers.c:
3107 (modest_server_account_data_get_option_secure_auth),
3108 (modest_server_account_set_option_secure_auth),
3109 (modest_server_account_data_get_option_security),
3110 (modest_server_account_set_option_security): Added this API for getting and setting the security
3111 and secure-auth settings.
3113 * src/maemo/modest-account-settings-dialog.h:
3114 * src/maemo/modest-account-settings-dialog.c:
3115 (modest_account_settings_dialog_finalize), (check_data),
3116 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3117 about changing titles.
3118 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3119 (save_configuration): Save the security and secure-auth settings.
3121 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3122 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3124 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3126 * src/modest-defs.h:
3127 * src/modest-account-mgr.c:
3128 (modest_account_mgr_add_server_account):
3129 Added and used defines for the options key and value pair strings,
3130 that are used so far, though they do not seem to correspond to anything in our
3131 UI specs or ModestProtocol enum.
3133 * src/modest-account-mgr-helpers.h:
3134 * src/modest-account-mgr-helpers.c:
3135 (compare_option_strings_for_name),
3136 (modest_server_account_data_get_option_value),
3137 (modest_server_account_data_get_option_bool),
3138 (modest_account_mgr_get_server_account_option):
3139 Added helper functions for parsing the options GSList.
3141 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3143 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3144 display name is based on the supplied account name.
3145 * src/modest-account-mgr.c:
3146 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3147 with an inefficient, but good-enough, implementation.
3149 * src/maemo/easysetup/modest-easysetup-wizard.c:
3150 (create_page_account_details), (on_before_next), (create_account):
3151 Check for existing display names rather than (non-user-visible) account names, and just
3152 create and set a unique account name at the end.
3154 * src/maemo/modest-account-settings-dialog.c:
3155 (modest_account_settings_dialog_init),
3156 (modest_account_settings_dialog_set_account_name),
3157 (create_page_incoming): Show the display name, instead of the account name.
3158 (on_response): Do some (not all) extra checks, as in the UI spec.
3159 (save_configuration): Save the display name if it was changed.
3161 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3163 * po/en_GB.po: Added needed logical ID and translation.
3164 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3165 (init_view): Made the is-default column clicking work.
3167 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3170 * src/maemo/easysetup/Makefile.am:
3171 * src/maemo/easysetup/modest-easysetup-wizard.c:
3172 (modest_easysetup_wizard_dialog_init):
3173 * src/maemo/easysetup/provider-data-test.keyfile:
3174 * src/maemo/easysetup/provider-data.keyfile:
3175 Moved the provider data file to the new modest-providers-data package and used it from there.
3177 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3179 * src/modest-local-folder-info.c:
3180 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3181 N_() was already used on the static strings, but this just marks it for translation without
3182 using the translation.
3184 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3186 * src/maemo/modest-account-settings-dialog.c:
3187 (create_page_incoming),
3188 (modest_account_settings_dialog_set_account_name):
3189 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3190 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3191 I will do this if nobody else gets there first.
3193 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3195 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3196 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3197 save the security stuff.
3199 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3201 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3202 Set the email address and user fullname, which I now see must be
3205 * src/maemo/modest-account-settings-dialog.h:
3206 * src/maemo/modest-account-settings-dialog.c:
3208 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3209 leave-on-server and authentication.
3210 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3213 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3216 * src/maemo/modest-account-settings-dialog.c:
3217 * src/maemo/modest-account-settings-dialog.h:
3218 Most (but not all) of the widgets are now present as specified by the UI spec.
3219 No changes are yet saved, and some details are not properly shown yet.
3221 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3223 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3225 * src/maemo/Makefile.am:
3226 * src/maemo/modest-account-settings-dialog.c:
3227 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3228 an existing account. Doesn't do much yet.
3230 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3231 Open the accounts settings dialog when Edit is clicked.
3233 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3235 * src/maemo/easysetup/Makefile.am:
3236 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3238 * src/maemo/easysetup/modest-easysetup-wizard.c:
3239 (modest_easysetup_wizard_dialog_init):
3240 Try to get the source directory from the build system,
3241 instead of hard-coding "./" into the source code, when opening our local
3242 copies of the configuration files.
3243 But this still fails when opening the wizard from the Accounts window,
3244 maybe because the working directory seems to change at runtime.
3245 So the wizard will fail the second time unless you copy the files into their
3246 proper locations - see the stdout warnings for the paths.
3248 (create_page_account_details),(on_before_next):
3249 Check for existing non-server accounts instead of server accounts,
3250 so the default account name is useful again, and to prevent trying to
3253 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3254 Show the wizard when New is clicked.
3256 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3257 (init_view): Show the column headers, and show the columns that are
3258 specified in the UI specs. However, something in Maemo's GTK+ prevents
3259 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3260 change the default account. This is despite unsetting the special properties.
3262 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3264 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3265 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3266 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3267 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3268 to make that clearer.
3269 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3271 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3273 * src/maemo/modest-account-view-window.c:
3274 (modest_account_view_window_init),
3275 (modest_account_view_window_new):
3276 Use the same buttons as specified in the
3277 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3278 the existing widgets, which never had a chance of working.
3279 Put the ModestAccountView treeview in a scrolled window.
3280 Do not repeat the initialization in both _init() and _new().
3282 * src/widgets/modest-account-view.c: (update_account_view):
3283 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3284 this widget and window shows no accounts.
3286 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3288 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3290 * src/maemo/easysetup/modest-easysetup-wizard.c:
3291 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3292 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3293 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3296 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3297 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3298 accounts exist yet, as in the UI spec.
3300 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3302 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3304 * src/maemo/Makefile.am:
3305 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3306 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3307 New window for editing connection-specific smtp details.
3308 Not fully implemented.
3310 * src/maemo/modest-connection-specific-smtp-window.c:
3311 (modest_connection_specific_smtp_window_finalize) :
3312 unref the tree model.
3313 (on_button_edit): Show the edit window.
3315 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3317 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3320 * src/maemo/Makefile.am:
3321 * src/maemo/modest-connection-specific-smtp-window.c:
3322 * src/maemo/modest-connection-specific-smtp-window.h:
3323 New window for showing the list of connections, for connection-specific
3324 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3325 * src/maemo/easysetup/modest-easysetup-wizard.c:
3326 (create_page_custom_outgoing): Show the new window when the button is clicked.
3328 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3330 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3331 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3332 * src/maemo/modest-msg-edit-window.c:
3333 (modest_msg_edit_window_insert_image):
3334 * src/modest-conf.c: (modest_conf_key_escape):
3335 * src/modest-mail-operation.c:
3336 (modest_mail_operation_send_new_mail):
3337 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3338 (modest_ui_actions_on_new_account):
3339 * src/widgets/modest-attachment-view.c: (update_filename_request):
3340 * src/widgets/modest-mail-header-view.c:
3341 Corrected warnings that were breaking the build, by commenting out unused variables,
3342 and a function, and by including a header.
3344 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3346 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3347 so we can #ifdef around platform-specific code when necessary.
3348 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3349 to allow this to build for the GNOME platform too.
3351 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3353 * src/maemo/easysetup/modest-easysetup-wizard.c:
3354 Added util_increment_name() and used it in create_page_account_details()
3355 to make sure that the default account name is always a new name.
3357 (modest_easysetup_wizard_dialog_init),
3358 (set_default_custom_servernames): Some minor memory management fixes.
3360 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3364 * src/modest-runtime.c: (init_i18n): Restored the translation
3365 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3366 are defined in config.h, and the translations are installed.
3368 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3369 is defined for translation.
3371 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3373 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3375 * src/maemo/easysetup/modest-easysetup-wizard.c:
3376 (modest_easysetup_wizard_dialog_init):
3377 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3378 Use realistic paths (though they should use $prefix generically) to the
3379 mcc_mapping and provider-data.keyfile files which might work when they
3380 are installed by the future version of the operator-wizard package,
3381 and then fallback to paths in our source code, with an explanatory
3384 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3388 * src/maemo/Makefile.am:
3389 * src/maemo/easysetup/: Added files from the previously-exernal
3390 osso-modest-easysetup.
3391 * src/maemo/modest-main-window-ui.h:
3392 * src/modest-ui-actions.c:
3393 * src/modest-ui-actions.h:
3394 Added modest_ui_actions_on_new_account() as a signal handler for the
3395 New Account menu item. It shows the easysetup wizard.
3396 * po/en_GB.po: Added additional needed logical IDs and translations.