1 2007-08-27 Armin Burgmeier <armin@openismus.com>
3 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
4 observe outbox for added messages to assign them a status. Previously,
5 this was done in modest_tny_send_queue_add(), but the message id might
6 not yet be known at that point. This reduces warnings when sending
7 mail, though I am not sure how this even worked before.
9 2007-08-27 Murray Cumming <murrayc@murrayc.com>
11 * src/maemo/modest-account-settings-dialog.c:
12 (modest_account_settings_dialog_init):
13 * src/maemo/modest-connection-specific-smtp-edit-window.c:
14 (modest_connection_specific_smtp_edit_window_init):
15 * src/maemo/modest-connection-specific-smtp-window.c:
16 (modest_connection_specific_smtp_window_init):
17 * src/maemo/modest-maemo-utils.c:
18 (modest_maemo_utils_get_supported_secure_authentication_methods):
19 * src/maemo/modest-platform.c:
20 (modest_platform_run_folder_name_dialog):
21 * src/maemo/modest-signature-editor-dialog.c:
22 (modest_signature_editor_dialog_init):
23 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
24 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
25 * src/widgets/modest-global-settings-dialog.c:
26 (modest_global_settings_dialog_init):
27 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
29 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
30 GTK_STOCK_EDIT with mcen_bd_edit, and
31 GTK_STOCK_CLOSE with mcen_bd_close,
32 to fix projects.maemo.org bug NB#64995.
33 I strongly believe that Maemo's GTK+ should have the wanted translations
34 instead of duplicating this in each application and complicating the code.
36 2007-08-27 Armin Burgmeier <armin@openismus.com>
38 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
39 recursion when entering text in the subject field.
41 2007-08-27 Murray Cumming <murrayc@murrayc.com>
43 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
44 which checks every second, 10 times, to wait until the account is online
45 so that we can use it, if the account is in the process of going online.
46 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
47 so that searching works even when the application was not yet started before.
48 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
50 2007-08-24 Armin Burgmeier <armin@openismus.com>
52 * src/modest-widget-memory.c: Always show the default account when the
53 application is started, as stated in the UI spec. This fixes
54 projects.maemo.org bug NB#66630.
56 2007-08-24 Armin Burgmeier <armin@openismus.com>
58 * src/maemo/modest-platform.c:
59 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
60 english text for strings in the rename folder dialog, fixing
61 projects.maemo.org bug NB#66338.
63 2007-08-22 Armin Burgmeier <armin@openismus.com>
65 * src/widgets/modest-account-view.c: Fix for bora by using
66 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
67 latter seems not be used anymore.
69 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
72 * src/maemo/modest-main-window.c: Update menu items when the default
73 account changes so that the current default account is always bolded.
74 This fixes maemo.projects.org bug NB#66173.
76 2007-08-17 Murray Cumming <murrayc@murrayc.com>
78 * src/dbus_api/modest-dbus-callbacks.c:
79 (on_dbus_method_get_folders): Avoid trying to get the account name
80 when there are no accounts, to avoid critical g_warnings, fixing
81 projects.maemo.org bug NB#65574.
83 2007-08-17 Murray Cumming <murrayc@murrayc.com>
85 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
86 Use modest_account_mgr_get_signature() instead of accessing gconf
87 directly, to slightly simplify the code.
88 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
89 Append the signature also when opening via other applications,
90 fixing projects.maemo.org bug NB#65828.
92 2007-08-17 Murray Cumming <murrayc@murrayc.com>
94 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
95 Check for NULLs to prevent a crash when opening an email that is
96 an attachment in another email, fixing projects.maemo.org bug
99 2007-08-17 Murray Cumming <murrayc@murrayc.com>
101 * src/modest-ui-dimming-rules.c:
102 (modest_ui_dimming_rules_on_view_window_move_to):
103 Enable the Move To toolbar button for search results, fixing the
104 last part of projects.maemo.org bug NB#63807.
106 2007-08-17 Murray Cumming <murrayc@murrayc.com>
108 * src/dbus_api/modest-dbus-callbacks.c:
109 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
110 because this is called from idle handlers, to fix hangs afte the
112 (find_message_by_url): Added a TODO comment about a crash that
113 happens when tinymail was built with DBC checks.
115 2007-08-16 Murray Cumming <murrayc@murrayc.com>
117 * src/modest-search.c: (modest_search_folder):
118 * src/modest-search.h: Rename ModestSearch::before to start_date
119 and after to end_date, using the same names as the libogs struct
121 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
122 The start_date and end_date were swapped in the check. This
123 fixes date range searches, fixing projects.maemo.org bug NB#63407.
125 2007-08-16 Murray Cumming <murrayc@murrayc.com>
127 * src/maemo/modest-account-view-window.c:
128 Added (check_for_active_acount).
129 (on_delete_button_clicked), (on_edit_button_clicked):
130 When an account is doing something (such as refreshing),
131 show the same warning for account deletion as for account
132 editing, to fix projects.maemo.org bug NB#64588.
134 2007-08-16 Murray Cumming <murrayc@murrayc.com>
136 * src/widgets/modest-msg-view-window.h:
137 * src/gnome/modest-msg-view-window.c:
138 * src/maemo/modest-msg-view-window.c:
139 Added modest_msg_view_window_construct().
140 (modest_msg_view_window_new_with_header_model),
141 Added modest_msg_view_window_new_for_search_result),
142 Renamed modest_msg_view_window_new() to
143 modest_msg_view_window_new_for_attachment(),
144 and modest_msg_view_window_is_search_result(),
145 so we can explicitly know that the window is for an
146 attachment or a search result or a message from the list.
148 (modest_msg_view_window_view_attachment):
149 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
150 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
151 Use modest_msg_view_window_new_for_search_result().
153 * src/modest-ui-dimming-rules.c:
154 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
155 for search results, fixing projects.maemo.org bug NB#63811.
157 2007-08-16 Armin Burgmeier <armin@openismus.com>
159 * src/modest-ui-actions.c: Show a banner instead of a dialog when
160 renaming a folder fails, to stay consistent with what happens when
161 creating a folder fails.
163 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
164 slightly country loading from the mmc_mappings file, fixed a memory
167 2007-08-16 Murray Cumming <murrayc@murrayc.com>
169 * src/modest-tny-account-store.c: (volume_path_is_mounted):
170 Check the GnomeVFSVolume activation path instead of the device path,
171 so that the memory card is really really shown in the UI.
173 2007-08-16 Murray Cumming <murrayc@murrayc.com>
175 * src/maemo/easysetup/modest-easysetup-wizard.c:
176 (get_entered_account_title), (on_before_next), (entry_is_empty),
178 * src/maemo/modest-account-settings-dialog.c:
179 (get_entered_account_title), (on_button_signature), (check_data),
180 (save_configuration), (entry_is_empty):
181 Strip the account title of whitespace at the start and end before
182 using it or checking it. This means that an all-whitespace title
183 is not allowed, fixing projects.maemo.org bug NB#64977.
185 2007-08-15 Murray Cumming <murrayc@murrayc.com>
187 * src/modest-ui-actions.h:
188 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
189 to modest_run_account_setup_wizard() and made it public.
190 * src/dbus_api/modest-dbus-callbacks.c:
191 (check_and_offer_account_creation), (on_idle_mail_to),
192 (on_idle_compose_mail), (on_idle_open_default_inbox):
193 Offer account creation if necessary, fixing projects.maemo.org
196 2007-08-15 Murray Cumming <murrayc@murrayc.com>
198 * src/modest-ui-actions.c: (run_account_setup_wizard):
199 Return a gboolean to indicate success.
200 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
201 (modest_ui_actions_on_send): When offering account creation, only
202 give up (return) if account creation failed. Otherwise continue
203 with the original request. This fixed projects.maemo.org bug
206 2007-08-15 Murray Cumming <murrayc@murrayc.com>
208 * src/widgets/modest-recpt-editor.c:
209 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
210 to fix projects.maemo.org bug NB#63789.
212 2007-08-15 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
215 (modest_tny_account_store_new): Properly detect the memory card at
216 startup, and add an account for it.
218 2007-08-14 Murray Cumming <murrayc@murrayc.com>
220 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
221 Commented out the MMC code again because it mistakenly detects
222 the card even when it isn't inserted.
224 2007-08-14 Murray Cumming <murrayc@murrayc.com>
226 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
227 Renabled the call to add_mmc_account() because I do not believe
228 it could be the cause of the mentioned hang (in scratchbox, where
229 there is no memory card), and because I have tested that it works
232 2007-08-14 Murray Cumming <murrayc@murrayc.com>
234 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
235 Comment out part of the last commit because it apparently causes
238 2007-08-14 Murray Cumming <murrayc@murrayc.com>
240 * src/modest-tny-account-store.c: Added the add_mmc_account()
241 function to save some copy/pasting.
242 (modest_tny_account_store_new): If the memory card is mounted,
243 create an account for it at the start, instead of waiting for the
244 user to unmount it and mount it.
246 2007-08-13 Murray Cumming <murrayc@murrayc.com>
248 * src/widgets/modest-account-view.c: (on_account_changed):
249 Do not try to use the human-readable TnyAccount name instead of the
250 ID of the modest account to get the transport account. And unref
251 the transport account. This prevents a g_warning(), and a possible
254 2007-08-13 Murray Cumming <murrayc@murrayc.com>
256 * src/maemo/modest-platform.c:
257 (modest_platform_set_update_interval): Handle the new
258 alarmd error to warn when alarmd is not running, as is the case in
259 scratchbox for me now because
260 "Module /usr/lib/alarmd/libretu.so initialization failed"
262 2007-08-13 Murray Cumming <murrayc@murrayc.com>
264 * src/widgets/modest-header-view-render.c:
265 (_modest_header_view_compact_header_cell_data):
266 NULL some strings after freeing them, trying to deal with
267 the double deletion found in projects.maemo.org bug 64183,
268 probably having no effect.
270 2007-08-13 Murray Cumming <murrayc@murrayc.com>
272 * src/maemo/modest-account-settings-dialog.c:
273 (create_page_incoming), (create_page_outgoing): Use a define
274 for the min and max port numbers.
276 (check_hildon_number_editor_and_warn_value_not_in_range),
277 (check_data): Do an extra check for an invalid port number, as needed
278 in projects.maemo.org bug #64275, when the number is cleared, but this
279 does not work due to bugs.maemo.org bug #1806.
281 2007-08-13 Murray Cumming <murrayc@murrayc.com>
283 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
284 Comment out the debug warning about the unexpected D-Bus methods.
285 They are just annoying now.
286 * src/maemo/modest-platform.c:
287 (modest_platform_set_update_interval): Correct the D-Bus path, instead
288 of using a file path, though it did not seem to break things before.
289 It might be needed now:
290 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
291 modest is not already running. This is the behaviour of the old client, and
292 Mox says it is what we should do for modest.
293 This closes projects.maemo.org bug NB#64327.
295 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
297 * src/modest-text-utils.c:
298 Fixed invalid jump due to incorrect string/pointer
300 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
303 2007-08-01 Murray Cumming <murrayc@murrayc.com>
305 * src/modest-account-mgr-helpers.h:
306 * src/modest-account-mgr-helpers.c:
307 Added modest_account_mgr_get_first_account_name(),
308 using code from modest_account_mgr_set_first_account_as_default().
310 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
311 (account_number_changed): Call set_at_least_one_account_visible() so that
312 the first account is visible when first added, without the user having to
314 I do wonder how this worked before.
316 2007-08-01 Murray Cumming <murrayc@murrayc.com>
318 * src/modest-tny-account-store.c: (show_password_warning_only),
319 (show_wrong_password), (request_password_and_wait), (get_password),
320 (modest_tny_account_store_alert): Remove the (incomplete anyway)
321 attempts to show UI only in the main context, which used g_idle_add()
322 and mainloops, because tinymail now guarantees that it only calls these
323 callbacks in the mainloop with the gdk lock. This makes everything much
326 2007-08-01 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
329 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
330 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
331 error dialog, instead of ignoring it.
333 2007-08-01 Murray Cumming <murrayc@murrayc.com>
335 * src/maemo/modest-msg-view-window.c:
336 (modest_msg_view_window_get_header),
337 (modest_msg_view_window_last_message_selected):
338 Added comments to explain the use of priv->header_model.
339 * src/modest-ui-dimming-rules.c:
340 (modest_ui_dimming_rules_on_open_msg),
341 (modest_ui_dimming_rules_on_mark_as_read_msg),
342 (modest_ui_dimming_rules_on_mark_as_unread_msg),
343 (modest_ui_dimming_rules_on_remove_attachments),
344 (_invalid_attach_selected), (_selected_msg_marked_as):
345 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
346 and changed the parameter to a ModestMainWindow to make it clearer that
347 it never uses any other kind of window.
348 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
349 instead of the selected message.
350 I notice that much of the dimming code and the ModestMsgViewWindow code
351 hard-codes the assumption that the viewed message is always selected in
352 the header view. This does not seem wise or simple.
354 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
355 examine the actual message instead of whatever might be selected
356 in the header view. This stops the delete toolbar button and menu item
357 from being dimmed when opening a message view the search UI,
358 partially fixing projects.maemo.org bug NB#63811.
360 However, when actually deleting, I now get this warning:
361 "tny_header_set_flags: This is a header instance for a new message.
362 Only priority and attachment flags are supported"
364 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
366 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
368 Show account wizard if no accounts are defined while sending
369 (automatic sending after the account wizard finished does not
370 work because it takes some time until the account manager
371 synchronizes everything. (projects.maemo.org NB#62792)
373 2007-07-30 Murray Cumming <murrayc@murrayc.com>
375 * src/modest-tny-account-store.c: (on_account_removed),
376 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
377 account is removed from the View menu. We have TnyAccountStore
378 and ModestTnyAccountStore signals that seem very similar, but this
379 seems to work for now.
381 * src/maemo/modest-main-window.c:
382 (on_show_account_action_activated): Prevent dereference
383 of a NULL if the accoutn does not really exist, though that
384 should not happen anymore.
386 This fixes projects.maemo.org bug NB#64606.
388 2007-07-30 Murray Cumming <murrayc@murrayc.com>
390 * src/modest-ui-actions.c: (run_account_setup_wizard),
391 (modest_ui_actions_on_accounts): Revert a change that set these
392 to modal dialogs, freezing the UI when they show secondary dialogs.
393 This fixed projects.maemo.org bug NB#64519.
395 2007-07-27 Murray Cumming <murrayc@murrayc.com>
397 * src/widgets/modest-header-view-render.c:
398 (_modest_header_view_compact_header_cell_data):
399 Some checks and initialization to try to deal with a crash,
400 probably ineffective.
402 2007-07-27 Murray Cumming <murrayc@murrayc.com>
404 * src/maemo/modest-maemo-utils.c:
405 (modest_maemo_utils_get_supported_secure_authentication_methods):
406 Make sure that we have a connection, asking the user for one
408 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
409 Check for a connection before showing the wizard, because
410 the wizard needs a connection to check for server capabilities.
412 2007-07-27 Murray Cumming <murrayc@murrayc.com>
414 * src/maemo/modest-account-view-window.c:
415 (on_new_button_clicked): Remember the wizard dialog instance,
416 so we can just present it again if necessary. This prevents
417 multiple windows from appearing if you click again quickly on the
418 New button before the dialog appears, fixing projects.maemo.org
421 2007-07-27 Murray Cumming <murrayc@murrayc.com>
423 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
424 Offer a connection dialog if there is no connection when
425 starting modest. This should fix projects.maemo.org bug NB#61134.
427 2007-07-27 Murray Cumming <murrayc@murrayc.com>
429 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
430 Reverted my last commit. I was able to fix the build by doing
431 apt-get install wpeditor0 (replacing other wpeditor packages) and
432 an explicit apt-get install wpeditor-dev to upgrade the -dev
435 2007-07-27 Murray Cumming <murrayc@murrayc.com>
437 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
438 Commented out the use of wp_text_buffer_replace_image()
439 because it does not exist, to break the build. Added a TODO for it.
441 2007-07-26 Murray Cumming <murrayc@murrayc.com>
443 * src/modest-tny-account-store.c: (recreate_all_accounts):
444 Recreate them even if they were NULL before. I guess something
445 else was already creating them before, or this would never
447 (modest_tny_account_store_get_server_account): Make sure that
448 the tny accounts have been created before trying to find one.
449 This allows libmodest_dbus_client_compose_mail() to work
450 when the UI is not yet visible.
451 This is probably useful in other cases too.
453 (get_password): When the password is wrong after it is entered
454 in the protected password dialog, show an info banner (in an
455 idle handler) before showing the protected password dialog
458 2007-07-26 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-ui-actions.h:
461 * src/modest-ui-actions.c: Added
462 modest_do_refresh_current_folder() containing some code from
463 modest_ui_actions_on_send_receive().
464 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
465 Call modest_do_refresh_current_folder() before refreshing the
466 requested account, as in modest_ui_actions_on_send_receive().
467 This is strange, but seems to be necessary to show new mails.
468 Now new emails are finally visible in the UI when downloaded
469 via the automatic update interval, fixing bug NB#57458.
470 This also works because bug NB#57458 has been fixed somehow.
472 2007-07-26 Murray Cumming <murrayc@murrayc.com>
474 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
475 printf more details when we get unhandled D-Bus methods, because
478 * src/modest-mail-operation.c: (update_account_thread):
479 Comment out the tny_camel_pop_store_account_reconnect(), because this
480 is apparently no longer needed, and it did not work before anyway.
481 See the comment in the code.
483 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
484 by checking the header flags. This fixes projects.maemo.org bug
487 2007-07-25 Murray Cumming <murrayc@murrayc.com>
489 * src/maemo/modest-maemo-utils.h:
490 * src/maemo/modest-maemo-utils.c: Added
491 modest_maemo_show_information_note_in_main_context_and_forget().
492 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
493 Use the new function to show simple error dialogs in the main
494 context, though question dialogs are still in the current context,
495 which is unfortunately usually not the main context. This should
498 2007-07-25 Murray Cumming <murrayc@murrayc.com>
500 * src/modest-tny-account-store.c: (get_password):
501 Never save the entered username and password in gconf,
502 because the UI spec says we should not. This helps
503 slightly with projects.maemo.org bug NB#63671.
505 2007-07-25 Murray Cumming <murrayc@murrayc.com>
507 * src/widgets/modest-msg-edit-window.h:
508 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
509 Moved some code here to make it simpler.
510 (modest_msg_edit_window_attach_file_one): Renamed from
511 modest_msg_edit_window_attach_file_interactive().
512 (modest_msg_edit_window_offer_attach_file): Renamed from
513 modest_msg_edit_window_attach_file() and used
514 modest_msg_edit_window_attach_file_one() instead of
515 copy/pasting the code. The old code for one was not using
516 GnomeVFS. This allows use of smb:// URLs when using send-as
517 from external applications, fixing bug NB#63741.
519 (modest_msg_edit_window_insert_image),
520 (modest_msg_edit_window_add_attachment_clicked):
521 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
522 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
523 Adapted to the new function names.
525 2007-07-25 Murray Cumming <murrayc@murrayc.com>
527 (modest_platform_set_update_interval): Set the alarm recurrence
528 fields so that auto-update does not just happen the first time.
529 This should have fixed projects.maemo.org bug NB#63938.
531 When this happens you can see a printf when the D-Bus method is
533 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
535 However, I do not actually seem to get new POP messages even when
536 clicking the refresh button manually. A restart gets them.
537 This might be a problem in today's tinymail only.
539 2007-07-24 Murray Cumming <murrayc@murrayc.com>
541 * src/maemo/modest-maemo-global-settings-dialog.c:
542 (current_connection):
543 Avoid a crash (probably only in scratchbox) when strcmp()ing a
544 NULL when closing the dialog.
546 2007-07-24 Murray Cumming <murrayc@murrayc.com>
548 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
549 Remove the hacky send/receive that didn't work, and instead
550 refilter the treemodel to make the deleted email really vanish from
551 the UI (though the delete-from-menu code does has commented out
552 the code that does that). This fixes projects.maemo.org bug
555 2007-07-24 Murray Cumming <murrayc@murrayc.com>
557 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
558 Try a couple of tricks to force the treeview to update (
559 poke the folder, and do a send/receive refresh), but the deleted
560 email still appears with a strike-through instead of really being
563 2007-07-23 Murray Cumming <murrayc@murrayc.com>
565 * src/dbus_api/modest-dbus-callbacks.c:
566 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
567 because their ID is not human-readable (see the comment about
568 improvements needed to the osso-email-interface API) and
569 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
571 2007-07-23 Murray Cumming <murrayc@murrayc.com>
573 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
574 (add_folders_to_list), (on_dbus_method_get_folders),
575 (modest_dbus_req_filter):
576 * src/maemo/modest-maemo-utils.c:
577 (on_camel_account_get_supported_secure_authentication):
578 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
579 (on_header_view_focus_in):
580 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
581 * src/modest-formatter.c: (modest_formatter_create_body_part):
582 * src/modest-mail-operation.c: (recurse_folders),
583 (update_account_thread), (get_msgs_full_thread),
584 (modest_mail_operation_get_msgs_full),
585 (modest_mail_operation_xfer_msgs):
586 * src/modest-search.c: (search_mime_part_and_child_parts),
587 (modest_search_account), (modest_search_all_accounts):
588 * src/modest-tny-account.c:
589 (modest_tny_account_get_special_folder), (recurse_folders):
590 * src/modest-tny-local-folders-account.c:
591 (modest_tny_local_folders_account_query_passes):
592 * src/modest-tny-msg.c: (copy_mime_part),
593 (modest_tny_msg_find_body_part_from_mime_part):
594 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
595 (modest_tny_send_queue_try_to_send):
596 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
597 (_modest_ui_actions_open), (download_uncached_messages),
598 (reply_forward), (modest_ui_actions_on_copy),
599 (modest_ui_actions_on_details), (has_retrieved_msgs),
600 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
602 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
603 (_selected_msg_marked_as), (_msg_download_completed),
604 (_selected_msg_sent_in_progress):
605 * src/widgets/modest-attachments-view.c:
606 (modest_attachments_view_set_message):
607 * src/widgets/modest-msg-view.c: (find_cid_image):
608 * tests/check_folder-transfer.c: (find_folders):
609 * tests/check_update-account.c: (func):
610 * tests/dbus_api/test_get_folders.c: (main):
611 Checked all uses of tny_iterator_get_current(), making sure
612 that the object is unreferenced (3 or 4 places did not),
613 and adding checks for NULL.
615 2007-07-23 Murray Cumming <murrayc@murrayc.com>
617 * src/dbus_api/modest-dbus-callbacks.c:
618 (on_idle_open_default_inbox): Make sure that the application UI is
620 * src/maemo/easysetup/modest-easysetup-wizard.c:
621 (on_entry_invalid_character): Show the word whitespace instead
622 of (null) in the banner when whitespace was entered.
623 (show_error): Add a comment that this does not work in
624 Maemo Bora, though we do not know why.
626 2007-07-23 Murray Cumming <murrayc@murrayc.com>
628 * src/modest-tny-account.c:
629 (modest_tny_account_get_special_folder): Use an if instead of
630 an assert for when the parent account name is NULL, because this
631 might be causing a crash in projects.maemo.org bug 63192.
632 * src/modest-mail-operation.c:
633 (modest_mail_operation_send_new_mail_cb),
634 (modest_mail_operation_remove_folder): unref the folder that is
635 returned from modest_tny_account_get_special_folder().
637 2007-07-23 Murray Cumming <murrayc@murrayc.com>
639 * src/modest-ui-actions.c:
640 (modest_ui_actions_on_password_requested):
641 Show mail_ib_login_cancelled info banner when the user cancels
642 the protected password dialog, to fix projects.maemo.org
645 2007-07-23 Murray Cumming <murrayc@murrayc.com>
647 * src/maemo/modest-account-settings-dialog.c:
648 (create_page_outgoing): Put this page in a GtkScrolledWindow,
649 matching the UI mock-up in the UI spec, and allowing access
650 to all widgets even when the on-screen keyboard is active.
652 2007-07-23 Murray Cumming <murrayc@murrayc.com>
654 Reverted this previous commit from Johannes,
655 because the scrollbars are always visible and because
656 I think we only need it on onepage of the account
657 settings, not the account wizard.
658 (I wrote the wrong instructions in the bug.)
660 * src/maemo/easysetup/modest-easysetup-wizard.c:
661 Added scrollbars to account wizard dialog.
662 Fixed projects.maemo.org NB #62744
664 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
666 * src/maemo/easysetup/modest-easysetup-wizard.c:
667 (create_page_user_details):
668 Use auto-cap for name (projects.maemo.org NB#63716)
669 * src/widgets/modest-account-view.c: (on_account_busy_changed):
671 2007-07-22 Armin Burgmeier <armin@openismus.com>
673 * src/maemo/modest-ui-actions.c: Use current account instead of
674 default account for creating viewer windows, so that the viewer
675 window knows to which account the viewed message belongs.
677 * src/maemo/modest-msg-view-window.c: Destroy the window when the
678 corresponding account is deleted. This fixes projects.maemo.org bug
681 2007-07-18 Armin Burgmeier <armin@openismus.com>
683 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
684 the dialog close after entering an invalid port number and clicking
685 OK. This fixes projects.maemo.org bug NB#63602.
687 2007-07-18 Armin Burgmeier <armin@openismus.com>
689 * src/modest-tny-account-store.c:
690 (get_server_accounts): Set parent modest account name for each
691 connection-specific transport account so that special folders of such
692 an account can be looked up. This fixes a crash when changing account
693 settings. This might also be related to projects.maemo.org bug
696 2007-07-16 Armin Burgmeier <armin@openismus.com>
698 * src/modest-ui-actions.c: Added a button to create a folder to the
699 move-to dialog. This fixes projects.maemo.org bug NB#59863.
701 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
703 * src/maemo/easysetup/modest-easysetup-wizard.c:
704 Added scrollbars to account wizard dialog.
705 Fixed projects.maemo.org NB #62744
707 2007-07-16 Murray Cumming <murrayc@murrayc.com>
709 * src/widgets/modest-msg-view.h:
710 * src/widgets/modest-msg-view.c:
711 Added modest_msg_view_get_message_is_empty() but this needs
713 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
714 Check if there is any text in the message yet.
715 But this needs to be implemented properly.
716 (modest_msg_edit_window_toggle_find_toolbar):
717 * src/maemo/modest-msg-view-window.c:
718 (modest_msg_view_window_toggle_find_toolbar):
719 Show a banner warning if there is no text to search, when
720 trying to start a search. This partially fixes
721 projects.maemo.org bug NB#62350.
723 2007-07-13 Murray Cumming <murrayc@murrayc.com>
725 * src/modest-mail-operation.c: (update_account_thread):
726 Initialized num_new_headers to fix the build.
728 2007-07-13 Murray Cumming <murrayc@murrayc.com>
730 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
731 Ignore modest accounts whose server accounts don't exist in gconf.
732 This prevents us trying to create TnyAccount instances for those
733 server accounts when the server account has been removed from gconf,
734 but the parent modest account has not yet been removed from modest.
735 I don't know why this is only noticeable now. It was probably just
736 a harmeless g_warning() anyway.
738 2007-07-13 Murray Cumming <murrayc@murrayc.com>
740 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
741 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
743 2007-07-12 Armin Burgmeier <armin@openismus.com>
745 * src/maemo/modest-main-window.c: Make default account appear bold
746 in view, tools/send & receive and toolbar/send & receive SCM menus.
747 This fixes projects.maemo.org bug NB#59010.
749 2007-07-12 Murray Cumming <murrayc@murrayc.com>
751 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
752 Add a short-cut, by checking if the folder store is an account.
753 This ensures that the Sort menu item and toolbar is dimmed for
754 the local-folders account root item, fixing
755 projects.maemo.org bug NB#62545.
757 2007-07-12 Murray Cumming <murrayc@murrayc.com>
759 * src/modest-tny-account-store.c: (get_password):
760 Show the password dialog (via the signal) only in the mainloop, via
761 an idle handler that we wait for. This could theoretically prevent
762 hangs, though I worry that it could introduce some too.
764 2007-07-12 Murray Cumming <murrayc@murrayc.com>
766 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
767 * src/maemo/modest-platform.c:
768 (modest_platform_connect_and_wait):
769 Take a TnyAccount* parameter and try to set it to online
770 (a TnyCamel-only API), because tinymail sets accounts to offline
771 when the user cancels a password dialog, and doesn't ask again until
772 it has been set to online.
773 However, this is commented out because it causes a hang now.
775 (modest_platform_connect_and_wait_if_network_account):
776 * src/modest-mail-operation.c:
777 (modest_mail_operation_update_account):
778 * src/modest-platform.h:
779 * src/modest-ui-actions.c: (_modest_ui_actions_open),
780 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
782 2007-07-12 Armin Burgmeier <armin@openismus.com>
784 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
786 * src/modest-mail-operation.c:
787 * src/modest-ui-actions.c: Check for already existing folder before
788 querying the server, show error message from camel if the request
789 still fails. This fixes projects.maemo.org bug NB#58701.
791 2007-07-12 Murray Cumming <murrayc@murrayc.com>
793 * src/modest-tny-account-store.h:
794 * src/modest-tny-account-store.c:
795 Added modest_tny_account_store_forget_password_in_memory(),
796 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
797 when creating a new account, so that new passwords will be used, instead of
798 us thinking that it's a second request as a result of a failed password again.
800 2007-07-12 Murray Cumming <murrayc@murrayc.com>
802 * src/dbus_api/modest-dbus-callbacks.c:
803 (on_idle_open_message): If the message is in drafts then open it
804 in an edit window instead of a view window. This fixes
805 projects.maemo.org bug NB#63005.
807 2007-07-12 Murray Cumming <murrayc@murrayc.com>
809 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
810 Avoided a harmless g_warning().
812 2007-07-12 Murray Cumming <murrayc@murrayc.com>
814 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
815 Pass the modest account name, not the TnyAccount display name to
816 modest_msg_view_window_new() so that the reply feature works,
817 fixing projects.maemo.org bug NB#62892.
819 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
820 (modest_msg_view_window_new_with_header_model):
821 * src/maemo/modest-msg-view-window.c:
822 (modest_msg_view_window_new_with_header_model),
823 (modest_msg_view_window_new):
824 * src/modest-ui-actions.c: (reply_forward):
825 * src/widgets/modest-msg-view-window.h:
826 * src/widgets/modest-window.c: (modest_window_set_active_account):
827 Rename an account parameter to modest_account_name to make this clearer.
829 2007-07-11 Murray Cumming <murrayc@murrayc.com>
831 * src/modest-ui-actions.h:
832 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
833 modest_do_message_delete().
834 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
835 Call modest_do_message_delete(), hoping that this would cause messages
836 to be really deleted from search instead of just marked with strike through.
837 Does not seem to help.
839 2007-07-11 Armin Burgmeier <armin@openismus.com>
841 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
842 priv->reselect to FALSE prior to calling
843 modest_folder_view_select_first_inbox_or_local() to prevent endless
844 recursion and thus a crash on startup.
846 2007-07-11 Armin Burgmeier <armin@openismus.com>
848 * src/maemo/modest-account-settings-dialog.h: Include
849 <gtk/gtknotebook.h> to fix the build (at least for me).
851 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
852 Use "New FolderN" as default suggested name if "New folder" already
853 exists, with N being the first free number, though never exceed "New
854 folder99" in which case we just fall back to "New Folder" even though
855 it already exists. This fixes projects.maemo.org bug NB#58663.
857 2007-07-11 Murray Cumming <murrayc@murrayc.com>
859 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
860 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
861 projects.maemo.org bug NB#62778.
863 2007-07-11 Murray Cumming <murrayc@murrayc.com>
865 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
866 Ignore the wrong (for now) secure-smtp setting in the presets -
867 just default to requiring secure authentication for SMTP, because
870 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
872 * src/widgets/modest-folder-view.c: (filter_row)
873 Do not show drafts folder (see UI specs)
875 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
877 * src/modest-ui-actions.c:
878 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
879 place and also not necessary.
881 * src/widgets/modest-folder-view.c: (filter_row)
882 Guess folder type and hide Sent & Outbox if necessary.
883 Fixed project.maemo.org NB#57328
885 2007-07-11 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-ui-actions.h:
888 * src/modest-ui-actions.c:
889 (modest_ui_actions_on_delete_message):
890 Move some code into a new
891 modest_ui_actions_refresh_message_window_after_delete()
892 function so we can use it from elsewhere.
894 * src/dbus_api/modest-dbus-callbacks.c:
895 (on_idle_delete_message), (on_delete_message): Used an idle
896 handler, as we do for the other D-Bus method handlers.
897 Call modest_ui_actions_refresh_message_window_after_delete()
898 if the deleted message was open in a window. This fixed
899 projects.maemo.org bug NB#62862.
901 2007-07-11 Murray Cumming <murrayc@murrayc.com>
903 * src/modest-main.c: (main): Only show the UI at the start if
904 the showui command line option was given. For instance,
905 run-standalone src/modest showui
906 Otherwise, we wait for the top_application D-Bus method to
907 be sent by hildon-desktop when the application is selected
909 This allows us to run without a UI when osso-global-search
910 uses our D-Bus methods.
912 2007-07-11 Murray Cumming <murrayc@murrayc.com>
914 * src/dbus_api/modest-dbus-api.h: Added a define for a
915 top-application D-Bus method.
916 * src/dbus_api/modest-dbus-callbacks.c:
917 (on_top_application),
918 (modest_dbus_req_handler): Handle the top-application D-Bus
919 method, which might be an undocumented D-Bus signal sent by
920 hildon-desktop when it starts the application from the menu.
921 But I am not sure and I need to test it on the device, because
922 my scratchbox does not have the application in the menu now.
923 This method shows the main window, so that it can be invisible
924 when started, for instance, just for email searching from
927 * src/maemo/modest-main-window.c: (restore_settings),
928 (modest_main_window_new): Do not show the window immediately
929 upon creation. We show it later.
930 * src/modest-widget-memory.c: (save_settings_paned):
931 Try (unsuccessfully) to avoid saving the paned position when
932 it is not even visible.
933 (restore_settings_paned): Do not allow a silly paned position.
934 This seems necessary when not showing the window at first.
936 * tests/dbus_api/Makefile.am:
937 * tests/dbus_api/test_top_application.c: (main): Test for the
940 2007-07-10 Murray Cumming <murrayc@murrayc.com>
942 * src/modest-ui-dimming-rules.c:
943 (modest_ui_dimming_rules_on_new_msg),
944 (modest_ui_dimming_rules_on_reply_msg),
945 (modest_ui_dimming_rules_on_delete_msg),
946 (modest_ui_dimming_rules_on_details),
947 (modest_ui_dimming_rules_on_view_window_move_to),
948 (modest_ui_dimming_rules_on_view_previous),
949 (modest_ui_dimming_rules_on_view_next),
950 (_invalid_folder_for_purge): Added checks before
951 casting the window. This looks like an actual
952 logic error in _invalid_folder_for_purge(), because it
953 tries to use a ModestMainWindow as a message window.
955 2007-07-10 Murray Cumming <murrayc@murrayc.com>
957 * src/maemo/modest-account-settings-dialog.c:
958 (show_error): Use the same implementation as in
959 modest-easysetup-wizard.c:
960 (on_entry_invalid_character): The logical ID contains a %s.
961 Guessed what it should be.
962 (on_entry_max), (check_data), (on_response): Adapt to
963 changed show_error().
964 (create_page_account_details): Really call
965 modest_validating_entry_set_func() on the correct widgets.
966 * src/maemo/easysetup/modest-easysetup-wizard.c:
967 (on_entry_invalid_character): Fix the logical ID here too.
968 (create_page_account_details),
969 (create_page_user_details):
971 modest_validating_entry_set_func() on the correct widgets.
973 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
974 Do not try to use the account if it is NULL.
976 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
978 * src/modest-ui-actions.c: (create_move_to_dialog),
979 (modest_ui_actions_on_main_window_move_to),
980 (modest_ui_actions_on_msg_view_window_move_to):
981 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
982 (filter_row), (modest_folder_view_show_non_move_folders):
983 * src/widgets/modest-folder-view.h:
985 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
986 the Sent folder yet as it does not report the correct folder type.
988 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
990 * src/maemo/modest-msg-edit-window.c: (init_window):
993 2007-07-10 Murray Cumming <murrayc@murrayc.com>
995 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
996 Take a parent widget instead of a parent window, and
997 implement this with hildon_banner_show_information() instead.
998 Non-Maemo builds can just ifdef that there.
999 This fixed projects.maemo.org bug NB#62766.
1001 (on_entry_invalid_character): Use show_error() again instead
1002 of using hildon directly, and use the _CS() macro to use the correct
1004 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1005 Pass a widget instead od a window to show_error().
1007 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1009 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1010 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1011 This allows us to show the server name in the error message, fixing
1012 projects.maemo.org bug NB#62904.
1013 Also, use the appropriate logical ID message for the account protocol.
1015 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1017 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1018 A compilation fix, though the build wasn't broken for me.
1020 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1022 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1023 Do not try to unref a NULL folder store, to avoid a runtime warning.
1024 This seems to happen sometimes when changing accounts settings.
1026 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1028 * src/modest-tny-account-store.c:
1029 (modest_tny_account_store_instance_init),
1030 (modest_tny_account_store_finalize),
1031 (on_account_settings_hide), (on_idle_wrong_password):
1032 Use a GHashTable to ensure that we only show one account settings
1033 dialog per modest account. This avoids us having a dialog open for
1034 both the store and transport accounts, or due to repeated get_password()
1035 calls that shouldn't happen anyway.
1037 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1039 * src/maemo/modest-maemo-utils.c: (on_hide),
1040 (modest_maemo_show_dialog_and_forget): Handle the response, because
1041 the window is not even hidden by default.
1043 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1044 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1045 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1046 which seems to prevent some modality problems.
1048 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1049 Ignore user cancellation errors.
1051 * src/modest-account-mgr-helpers.h:
1052 * src/modest-account-mgr-helpers.c:
1053 Added modest_server_account_get_password() and
1054 modest_server_account_get_has_password() to avoid direct use of
1057 * src/maemo/modest-account-settings-dialog.h:
1058 * src/maemo/modest-account-settings-dialog.c:
1059 (modest_account_settings_dialog_init): Store the notebook so we can
1061 Added modest_account_settings_dialog_switch_to_user_info().
1063 * src/modest-tny-account-store.c:
1064 (get_password): When the password in the account settings is wrong (we think),
1065 show the relevant page of the account settings dialog, in the mainloop.
1066 However, we currently get many of these at once because cancel does not
1068 (forget_password): Do not forget the password
1069 from the account settings, because this causes side-effects when
1070 tinymail seems to call it at strange time, maybe because of how we
1071 are cancelling get_password().
1072 (modest_tny_account_store_alert): Ignore user cancellations.
1074 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1076 * src/maemo/modest-maemo-utils.h:
1077 * src/maemo/modest-maemo-utils.c:
1078 Added modest_maemo_show_information_note_and_forget() for use instead of
1079 gtk_dialog_run() when the response is not needed, to avoid an extra
1080 mainloop which could cause a hang.
1082 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1083 Use the logical IDs for the error message, though they are not
1084 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1085 because gtk_dialog_run() caused a hang here (the window did not close).
1086 This fixes projects.maemo.org bug NB#62646.
1088 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1090 * src/modest-account-mgr-helpers.h:
1091 * src/modest-account-mgr-helpers.c:
1092 Added modest_account_mgr_get_store_protocol().
1094 * src/maemo/modest-account-view-window.c:
1095 (on_delete_button_clicked): Show different warning text depending on
1096 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1097 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1100 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1102 * src/maemo/modest-msg-edit-window.c:
1103 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1104 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1106 2007-07-07 Armin Burgmeier <armin@openismus.com>
1108 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1109 ckdg_ib_maximum_characters_reached from correct package.
1111 * src/modest-ui-actions.c: Show an error message when a folder could
1112 not be created. Tinymail does not give us specific error codes about
1113 what has gone wrong, so we assume that a folder with that name
1114 already exists, though there might be other reasons.
1116 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1118 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1119 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1120 give a more exact error message that can be partly translated.
1122 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1124 * src/maemo/modest-address-book.c:
1125 (select_email_addrs_for_contact): Specify a default window size for the
1126 select-email-address dialog, so that it is probably big enough for the
1127 title. This should fix projects.maemo.org bug NB#62277.
1129 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1131 * src/maemo/easysetup/modest-easysetup-wizard.c:
1132 (create_page_complete_easysetup): Use
1133 gtk_widget_set_size() request to ensure that the text wraps
1136 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1138 * src/maemo/easysetup/modest-easysetup-wizard.c:
1139 (on_entry_invalid_character), (create_page_account_details),
1140 (create_page_user_details):
1141 Use new API of ModestValidatingEntry. But for some reason the banner is
1142 not shown. I will have to investigate that further.
1144 * src/widgets/modest-validating-entry.c: (on_insert_text),
1145 (modest_validating_entry_set_func):
1146 * src/widgets/modest-validating-entry.h:
1147 Added a new callback function to be able to react to prevented
1148 characters whitespaces to e.g show a banner.
1150 2007-07-05 Armin Burgmeier <armin@openismus.com>
1152 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1153 notification of HildonNumberEditor instead of remembering the port
1154 number. Thanks to Johannes for pointing this out.
1156 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1158 * src/maemo/easysetup/modest-easysetup-wizard.c:
1159 Check if there are any user changes before showing a confirmation
1160 dialog (projects.maemo.org NB#60946)
1162 2007-07-05 Armin Burgmeier <armin@openismus.com>
1164 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1165 number at the beginning of the dialog and set the modified flag at the
1166 end if the port number has changed. This is necessary because
1167 HildonNumberEditor does not support notification when the value has
1170 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1172 * src/modest-ui-actions.c:
1173 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1174 a connection before asking anything else. Correct the check for the destination
1175 folder so that it succeeds when online.
1176 This fixed projects.maemo.org bug NB#61645.
1178 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1180 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1181 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1182 to fix projects.maemo.org bug NB#62439.
1184 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1186 * src/modest-tny-account.c: (on_connection_status_changed):
1187 Really do not use tny_device_force_offline() here. See the previous comment.
1189 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1191 * src/modest-tny-account.c: (on_connection_status_changed):
1192 Do not use tny_device_force_offline() when tinymail says that something
1193 went wrong with the connection. It seems to report this unnecessarily.
1195 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1197 * src/maemo/modest-connection-specific-smtp-window.c:
1198 (modest_connection_specific_smtp_window_init):
1199 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1200 does not seem to have any effect in osso 1.1 (though it works in
1201 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1203 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1205 * src/maemo/modest-connection-specific-smtp-window.c:
1206 Fix UI specification problems with projects.meamo.org NB#60479
1208 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1211 clue when this has failed, because the error dialog is not always shown
1212 (at least in earlier version).
1214 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1215 GError message, because the generic error dialog is not helpful.
1217 'This message is not currently available (can't let a new connection go online)'
1218 when trying to open an IMAP message.
1220 (_modest_ui_actions_open): Offer a connection when some messages would
1221 have to be downloaded and we are offline.
1223 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1225 * src/widgets/modest-folder-view.c:
1226 Don't check for MERGE type anymore as we use the correct type
1228 NOTE: For the last two changes you need to update your tinymail copy
1229 because of API changes!
1231 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1233 * src/modest-tny-local-folders-account.c:
1234 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1235 (see projects.maemo.org NB#61580)
1237 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1239 * src/modest-tny-account.c: (on_connection_status_changed):
1240 Commented out the call to modest_platform_connect_and_wait() because this
1241 seems to always hang, and I would like to know if this is the only thing
1242 that causes a hang when showing the connection dialog.
1243 It is not very useful anyway.
1245 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1247 * src/maemo/modest-msg-view-window.c:
1248 (modest_msg_view_window_select_next_message):
1250 * src/modest-platform.h:
1251 * src/maemo/modest-platform.c:
1252 Added modest_platform_connect_and_wait(), which calls
1253 tny_maemo_conic_device_connect() always in the main thread, by calling it
1254 in an idle handler and waiting for the idle handler to run. It should be
1255 in the main thread because it uses GTK+ UI code. It just returns TRUE
1256 if the device is already online.
1258 There is some nasty code to ensure that subsequent calls to
1259 modest_platform_connect_and_wait() just wait for the first one to finish,
1260 by checking repeatedly in another idle handler. This is necessary,
1261 because other threads (or even the main thread, via another idle handler)
1262 can call modest_platform_connect_and_wait() while
1263 modest_platform_connect_and_wait() is running.
1265 (modest_platform_connect_and_wait_if_network_account),
1266 (modest_platform_connect_and_wait_if_network_folderstore):
1267 Convenience functions that calls modest_platform_connect_and_wait() if
1268 the account or folder might want network access.
1270 * src/modest-mail-operation.c:
1271 (modest_mail_operation_update_account):
1272 * src/modest-ui-actions.c: (download_uncached_messages),
1273 (modest_ui_actions_on_rename_folder), (delete_folder),
1274 (modest_ui_actions_on_main_window_move_to),
1275 (modest_ui_actions_on_msg_view_window_move_to):
1276 * src/widgets/modest-folder-view.c:
1277 (drag_and_drop_from_folder_view):
1278 Offer a connection if we are offline.
1280 * src/modest-tny-account.c: (on_connection_status_changed):
1281 Document this as only handling errors during network operations in progress,
1282 and replace the idle code with a simple call to
1283 modest_platform_connect_and_wait(), which does this instead.
1285 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1287 * src/modest-tny-account.c:
1288 (modest_tny_account_get_special_folder): (util_on_idle),
1289 Handle the GError so we can see when tny_folder_store_get_folders()
1290 fails, as it currently does while something else is connecting.
1292 Added util_run_in_main_thread_and_wait()
1293 which uses an idlen handler and mainloop to ensure that the function
1294 is called in the main thread.
1295 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1296 to make sure that we call attempt the connection in the mainloop only,
1297 which might solve some hangs.
1299 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1301 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1302 be found by their display name. This is never useful.
1303 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1304 by its ID, instead of trying to use its ID as its display name.
1306 * src/modest-tny-account-store.h:
1307 * src/modest-tny-account.c:
1308 (modest_tny_account_get_special_folder): Add a g_warning() when
1309 tny_folder_store_get_folders() returns an empty list for the maildir.
1311 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1312 Add a g_warning() when this returns NULL, because that it not allowed
1315 2007-07-02 Armin Burgmeier <armin@openismus.com>
1317 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1318 note when trying to cancel the wizard. This fixes projects.maemo.org
1321 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1323 * src/modest-tny-account.h:
1324 * src/modest-tny-account.c:
1325 (modest_tny_account_new_from_server_account),
1326 (modest_tny_account_new_from_server_account_name),
1327 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1328 because this must now be set before setting the proto. This is usd in
1329 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1330 warning in camel_session_get_service() caused by
1331 tny_camel_transport_account_prepare().
1333 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1336 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1338 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1340 (modest_connection_specific_smtp_edit_window_init):
1342 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1343 of "changed" for now
1345 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1347 * src/modest-tny-account.c:
1348 (modest_tny_account_new_from_server_account):
1349 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1350 now uses to request a connection when it needs one, and which it uses
1351 to tell us that something is wrong with the connection, so we can force
1352 the accounts offline to prevent further problems.
1354 * src/modest-defs.h:
1355 * src/modest-init.c: (init_default_settings):
1356 * src/modest-mail-operation.c:
1357 (modest_mail_operation_update_account):
1358 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1359 This should not be necessary anymore. Do not set the conf key that
1360 determined this (it was always TRUE and not set anywhere else).
1362 * src/modest-ui-actions.h: Remove unused and unimplemented
1363 modest_ui_actions_on_online_toggle_toggled().
1365 2007-06-29 Murray Cumming <murrayc@murrayc.com
1367 * src/maemo/modest-main-window.c: (connect_signals):
1368 Don't connect to delete_event twice. Maybe this was harmless.
1370 2007-06-29 Murray Cumming <murrayc@murrayc.com
1372 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1373 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1374 Debug output to give some more clue when a folder move is not allowed.
1376 2007-06-28 Murray Cumming <murrayc@murrayc.com
1378 * src/modest-tny-account.c: (on_modest_file_system_info),
1379 (modest_tny_account_get_mmc_account_name):
1380 Always call the callback, without checking whether the name has changed.
1381 * src/widgets/modest-folder-view.c: (strings_are_equal),
1382 (on_model_foreach_set_name), (on_get_mmc_account_name),
1383 (text_cell_data): Compare the name here, and use the name from
1384 the account rather than from the
1385 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1386 if the name was changed after the account was added to the model.
1387 That's a tinymail bug but not one that I want to fix now.
1389 This finally fixes projects.maemo.org bug NB#59301.
1391 2007-06-27 Armin Burgmeier <armin@openismus.com>
1393 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1396 2007-06-27 Murray Cumming <murrayc@murrayc.com
1398 * src/modest-tny-account.h:
1399 * src/modest-tny-account.c:
1400 Added modest_tny_account_get_mmc_account_name(), to set the memory
1401 card name asynchronously for the given account and then notify.
1402 (modest_tny_account_new_for_local_folders): Use this new function instead
1403 of using hildon_file_system_info_async_new() directly.
1405 * src/widgets/modest-folder-view.c: (text_cell_data):
1406 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1407 gtk_tree_model_row_changed() when it is available.
1409 This should fix projects.maemo.org bug NB#59301.
1411 2007-06-27 Murray Cumming <murrayc@murrayc.com
1413 * src/modest-mail-operation.c: (update_account_thread),
1414 (get_msgs_full_thread): Fix typo failures in the revert
1417 2007-06-27 Murray Cumming <murrayc@murrayc.com
1419 * src/maemo/modest-maemo-global-settings-dialog.c:
1420 (idle_select_default_focus):
1421 * src/modest-mail-operation.c: (idle_notify_progress),
1422 (idle_notify_progress_once), (set_last_updated_idle),
1423 (update_account_thread), (get_msgs_full_thread):
1424 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1425 * src/widgets/modest-header-view.c:
1426 (idle_notify_headers_count_changed_destroy),
1427 (idle_notify_headers_count_changed):
1428 Reverted the additions of gdk_threads_enter/leave(), in case this
1429 helps with a startup hang on the device.
1431 2007-06-26 Armin Burgmeier <armin@openismus.com>
1433 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1434 for supported secure authentication methods from server by
1435 gtk_dialog_run(), saving CPU time and a potential race condition.
1437 2007-06-26 Armin Burgmeier <armin@openismus.com>
1439 * src/maemo/modest-maemo-utils.h:
1440 * src/maemo/modest-maemo-utils.c: Added a
1441 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1442 only error code to tell the calling code when the user canceled the
1445 * src/maemo/modest-account-settings-dialog.h:
1446 * src/maemo/modest-account-settings-dialog.c:
1447 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1448 message if the retrieval of secure authentication methods was canceled
1449 by the user. Perform the check before saving anything to configuration
1450 to not end up with half-committed configuration changes, do not show
1451 a "Saving to configuration failed" note when authentication methods
1452 could not be retrieved.
1454 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1457 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1459 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1460 Only return the first level of folders under accounts, because the
1461 osso-global-search UI spec doesn't want the rest.
1462 This fixed projects.maemo.org bug NB#61811.
1464 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1466 * src/modest-tny-account-store.c:
1467 * src/modest-tny-account-store.h:
1468 Added modest_tny_account_is_memory_card_account().
1469 * src/maemo/modest-main-window.c: (create_details_widget):
1470 Show the same information items for the memory card as we show for the
1471 local-folders, to fix projects.maemo.org bug NB#59307.
1473 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1475 * src/modest-tny-account-store.c: (get_password):
1476 Added some checks for NULL to maybe prevent crashes, though I think
1477 it was Philip's last commit that actually prevented the crash here
1478 when creating a first new account.
1479 But the new account is still not usable (no messages are shown)
1480 until a restart of the application.
1482 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1484 * src/maemo/modest-maemo-global-settings-dialog.c:
1485 (idle_select_default_focus):
1486 * src/modest-mail-operation.c: (idle_notify_progress),
1487 (idle_notify_progress_once), (idle_notify_update_account_queue),
1488 (set_last_updated_idle), (update_account_thread),
1489 (notify_get_msgs_full), (get_msgs_full_destroyer),
1490 (get_msgs_full_thread):
1491 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1492 * src/widgets/modest-header-view.c:
1493 (idle_notify_headers_count_changed_destroy),
1494 (idle_notify_headers_count_changed):
1495 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1496 all idle handlers, because some other thread could be blocking
1497 the GDK lock, so that it can do GUI stuff.
1499 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1501 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1502 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1503 (on_idle_send_receive), (on_idle_open_default_inbox):
1504 * src/maemo/modest-msg-edit-window.c:
1505 (modest_msg_edit_window_attach_file_noninteractive):
1506 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1507 to prevent a hang. I don't quite understand why these are necessary,
1508 beause we should already be in the main loop. I guess something outside
1509 of the main loop is taking the lock.
1511 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1512 we are really using URIs, and use files that are more likely to exist.
1514 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1516 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1517 necessary because configure.ac now defines different variables.
1519 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1521 * libmodest-dbus-client/libmodest-dbus-client.c:
1522 * libmodest-dbus-client/libmodest-dbus-client.h:
1523 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1524 libmodest_dbus_client_compose_mail() is what things actually use.
1526 * src/dbus_api/modest-dbus-api.h:
1527 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1528 * tests/dbus_api/Makefile.am:
1529 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1532 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1534 * src/modest-init.c: (modest_init_local_folders):
1535 For memory-card (or other non local-folders) maildir accounts,
1536 always create an Archive folder, so that there is somewhere to put
1537 messages. This should be less confusing, because the user does not need
1538 to guess that the need to create a folder.
1540 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1542 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1543 Fixed icon size by using (50, 50) which is the same as defined by
1546 2007-06-25 Armin Burgmeier <armin@openismus.com>
1548 * src/widgets/modest-window-mgr.c:
1549 * src/modest-init.c:
1550 * configure.ac: Correctly recognize hildon-notify presence and fixed
1551 the build without it being installed.
1553 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1555 * libmodest-dbus-client/libmodest-dbus-client.c:
1556 (libmodest_dbus_client_search): Fix the build. Sorry.
1557 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1558 (reply_forward_cb): Initialize variables to fix the build.
1560 * src/modest-tny-account-store.c:
1561 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1562 comparison (a silly typo) so that email search results can be opened
1563 when there are more than one account.
1565 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1567 * libmodest-dbus-client/libmodest-dbus-client.c:
1568 (libmodest_dbus_client_search),
1569 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1570 instead of 1 second, because the search gets folders and messages from
1571 the server, which can take a long time. When it times out,
1572 osso-global-search will report no results.
1574 We need to specify whether we should search only cached information
1575 (maybe with a user preference), and the osso-email-search-plugin
1576 API should really be improved to allow that option, and to allow results
1577 to be delivered asynchronously in batches.
1579 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1581 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1582 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1583 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1585 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1587 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1588 that is an empty string. D-Bus seems to give us these instead of NULL.
1590 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1592 * src/dbus_api/modest-dbus-callbacks.c:
1593 * src/maemo/easysetup/modest-easysetup-wizard.h:
1594 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1595 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1596 (modest_connection_specific_smtp_edit_window_init):
1597 * src/maemo/modest-maemo-global-settings-dialog.c:
1599 * src/maemo/modest-maemo-utils.c:
1600 (modest_maemo_utils_setup_images_filechooser):
1601 * src/maemo/modest-main-window.c: (create_details_widget):
1602 * src/maemo/modest-msg-edit-window.c:
1603 (modest_msg_edit_window_attach_file_noninteractive),
1604 (modest_msg_edit_window_color_button_change),
1605 (modest_msg_edit_window_set_zoom):
1606 * src/modest-mail-operation.c: (update_account_thread):
1607 * src/modest-tny-account-store.c:
1608 * src/modest-tny-account.c:
1609 * src/widgets/modest-global-settings-dialog.c:
1610 * src/widgets/modest-window.h:
1612 Fixed build on bora!
1614 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1616 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1617 * src/modest-search.c: (modest_search_folder),
1618 (modest_search_all_accounts): Actually search only in the specified folder,
1619 doing a simple match on the folder ID.
1620 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1621 and added some documentation.
1623 2007-06-22 Armin Burgmeier <armin@openismus.com>
1625 * src/maemo/modest-maemo-utils.h:
1626 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1627 modest_maemo_utils_get_supported_secure_authentication_methods.
1629 * src/maemo/easysetup/modest-easysetup-wizard.c:
1630 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1631 one occured, not just "Server does not support secure authentication".
1633 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1635 * src/modest-tny-account-store.c: (get_password):
1636 Restored the call to tny_account_set_user() because Philip seems to have
1637 stopped this from crashing (by not using the freed string). It still does
1638 not work, but now we can test it.
1640 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1642 * src/maemo/modest-msg-edit-window.c: (init_window):
1643 Comment out use of an uninitialzed GtkScrolledWindow variable,
1644 to fix the build and stop a crash. Yet again.
1646 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1648 * src/modest-tny-account-store.c: (get_password):
1649 Remove the call to tny_account_set_user() because this actually crashes.
1650 As mentioned in the last commit, it is known to not work anyway.
1652 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1654 * src/modest-tny-account-store.c: (get_password):
1655 Use tny_account_set_username() to tell tinymail that the username might
1656 have changed too. But tinymail ignores this: see projects.maemo.org
1658 * src/modest-ui-actions.c:
1659 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1660 reset the connection when changing the username, and improve the comments.
1661 Save the changed username to gconf at least, so it is used when Modest is
1664 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1666 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1667 Do not use a query, so that we get all folders, including for POP and
1668 local-folders. They work as search criteria too.
1669 This fixes projects.maemo.org bug NB#57740.
1671 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1673 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1674 Comment out the use of hildon_notification_set_sound() because it is
1675 not declared, to fix the build. Warnings are serious, people.
1677 2007-06-21 Armin Burgmeier <armin@openismus.com>
1679 * src/maemo/modest-maemo-utils.h:
1680 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1681 modest_maemo_utils_get_supported_secure_authentication_methods()
1682 to query authentication methods for a specific user. This should fix
1683 projects.maemo.org bug NB#61369.
1685 * src/maemo/easysetup/modest-easysetup-wizard.c:
1686 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1689 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1691 * libmodest-dbus-client/libmodest-dbus-client.h:
1692 * libmodest-dbus-client/libmodest-dbus-client.c:
1693 (modest_dbus_message_iter_get_search_hit),
1694 (libmodest_dbus_client_search):
1695 Reorganised and commented this.
1696 Removed modest_search_hit_free() from the public API because it
1699 Added libmodest_dbus_client_get_folders() and
1700 modest_folder_result_list_free().
1702 * src/dbus_api/modest-dbus-api.h:
1703 * src/dbus_api/modest-dbus-callbacks.c:
1704 (modest_dbus_req_filter): Commented. Moved most code to
1705 on_dbus_method_search() and added on_dbus_method_get_folders().
1707 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1708 of the extra D-Bus handler.
1710 * tests/dbus_api/Makefile.am:
1711 * tests/dbus_api/test_get_folders.c: New test for
1712 libmodest_dbus_client_get_folders(). This seems to return an empty list
1713 at the moment. That could be the same error that causes the message list
1714 to be empty sometimes.
1715 This should help with projects.maemo.org bug NB#57740.
1717 2007-06-21 Armin Burgmeier <armin@openismus.com>
1719 * src/modest-mail-operation.c: Do not call
1720 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1721 notify the operation's end after having set the status to CANCELED for
1722 the operation queue to listen on. This fixes a deadlock when there
1723 were mail operations in the queue during its finalization.
1725 * src/modest-singletons.c: Reordered uninitialization of the account
1726 manager to happen after the mail operation queue was uninitialized
1727 because the mail operation's in the queue might still try to access
1728 the account manager (see modest_mail_operation_notify_end()). This
1729 fixes a potential crash when terminating the application.
1731 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1733 * src/modest-search.c:
1734 (search_mime_part_and_child_parts): Moved some code here so we
1735 can search recursively in child folders.
1736 (modest_search_folder): Search in the message as a mime part, instead
1737 of just its child mime parts.
1738 (read_chunk), (search_mime_part_ogs):
1739 Check how many bytes were read, to prevent an endless loop.
1740 Searching in message bodies now works. This finishes the fix for
1741 projects.maemo.org bug NB#61007.
1743 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1745 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1746 Add a g_warning when the item is not a folder.
1748 * src/modest-ui-dimming-rules.c:
1749 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1750 when selected item is not a folder (for instance, an account), because
1751 the UI spec only talks about folders.
1752 I am not sure what the UI spec wants, so this might not totally fix
1753 projects.maemo.org bug NB#60794.
1755 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1757 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1758 (load_from_file): Sort the list. The unsorted list would be more noticeable
1759 in non-English locales.
1761 * src/maemo/modest-msg-edit-window.c:
1762 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1763 warning and fix the build.
1765 * src/maemo/modest-progress-bar-widget.c:
1766 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1767 avoid a g_warning, and probably to avoid a crash.
1769 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1771 * src/modest-search.c: (modest_search_folder): Check for a GError
1772 when calling tny_folder_get_headers(), to show that this is not the cause
1775 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1777 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1778 Actually set the body query instead of the subject query.
1780 * src/modest-search.c: (search_mime_part_ogs),
1781 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1782 which would probably cause it to fail if we got this far.
1784 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1785 to simplify the code.
1786 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1787 be causing search-in-body to fail.
1789 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1791 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1793 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1794 Better debug message when the folder cannot be found.
1795 This should help with fixing projects.maemo.org bug #61287.
1796 * src/modest-search.c: (add_hit): Do not leak the furl string.
1798 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1800 * src/modest-ui-actions.c:
1801 (modest_ui_actions_on_folder_selection_changed):
1802 Do not special-case TNY_MERGE_FOLDER here, because
1803 modest_tny_folder_get_account() already does that. This fixes
1804 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1805 shown when the Outbox was selected).
1807 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1809 * libmodest-dbus-client/libmodest-dbus-client.c:
1810 (_dbus_iter_get_string_or_null): Initialize the string variable in
1811 case this helps with Dirk's crash.
1813 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1815 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1816 though it is not implemented yet (this function is maybe not even used),
1817 to avoid breaking ABI in future.
1818 * libmodest-dbus-client/libmodest-dbus-client.c:
1819 (get_attachments_string): Moved some code into this generic function.
1820 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1821 sends email. It is maybe not used.
1822 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1823 (on_send_mail): Use attachments.
1825 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1826 * src/maemo/modest-msg-edit-window.c:
1827 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1828 a filename before using it, to fix projects.maemo.org bug NB#58233.
1830 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1833 Initialize the continue_download variable to fix the build, and probably
1834 to fix randome behaviour.
1836 2007-06-18 Armin Burgmeier <armin@openismus.com>
1838 * src/modest-tny-send-queue.h:
1839 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1840 the queue so we can later show it in the UI. Replaced
1841 modest_tny_send_queue_msg_is_being_sent() by
1842 modest_tny_send_queue_get_msg_status().
1844 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1846 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1847 gpointer. This probably was not harmful, but just to be sure.
1849 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1851 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1852 Fix the build, but leave the function broken on Bora, because
1853 hildon_uri_action_get_service() does not exist.
1854 osso_uri_action_get_service() does not exist either, it seems.
1856 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1858 * src/modest-tny-account.c:
1859 (modest_tny_account_new_from_server_account):
1860 Uncommented the url debug output again, because it is useful for
1861 debugging, as I said in the comment.
1863 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1865 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1867 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1868 for Mameo Bora, to fix the build.
1870 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1873 Fixed build with hildon < 0.99
1875 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1876 Check if the selected account is busy instead of checking all accounts
1878 * src/modest-account-mgr-priv.h:
1879 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1880 (modest_account_mgr_init), (compare_account_name),
1881 (modest_account_mgr_set_account_busy),
1882 (modest_account_mgr_account_is_busy):
1883 * src/modest-account-mgr.h:
1884 Added busy information to the account manager. It possible to
1885 set an account to busy or not busy now.
1887 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1888 (modest_mail_operation_update_account),
1889 (modest_mail_operation_notify_end):
1890 Set the account to busy/not busy depending on the operation state.
1892 * src/widgets/modest-account-view.c:
1893 (modest_account_view_finalize), (get_last_updated_string),
1894 (update_account_view), (on_account_busy_changed), (init_view):
1895 Show string "Refreshing..." if the account is currently busy.
1897 All this fixes projects.maemo.org bug NB#59711
1899 2007-06-14 Armin Burgmeier <armin@openismus.com>
1901 * src/widgets/modest-attachments-view.h:
1902 * src/widgets/modest-attachments-view.c: Added
1903 modest_attachments_view_has_attachments() and fixed coordinate
1904 transformation in get_att_view_at_coords(). This fixes attachment
1907 * src/widgets/modest-msg-view.c: Make use of
1908 modest_attachments_view_has_attachments() to decide whether to show
1909 attachments in the header.
1911 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1913 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1914 (on_change), (on_combo_security_changed),
1915 (modest_connection_specific_smtp_edit_window_init),
1916 (modest_connection_specific_smtp_edit_window_set_connection),
1917 (modest_connection_specific_smtp_edit_window_is_dirty):
1918 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1919 * src/maemo/modest-connection-specific-smtp-window.c:
1922 Show an comfirmation dialog for the smpt-edit-window if there are
1923 unsaved changes and the user hits cancel.
1924 (projects.maemo.org bug NB#60479)
1926 2007-06-14 Armin Burgmeier <armin@openismus.com>
1928 * src/maemo/easysetup/modest-easysetup-wizard.c:
1929 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1930 address" info in banner instead of node, and select all the text as
1931 per UI spec. This fixes projects.maemo.org bug NB#60550.
1933 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1935 reviewed by: <delete if not using a buddy>
1937 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1938 * src/modest-ui-actions.c: (folder_refreshed_cb):
1940 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1942 * src/widgets/modest-folder-view.c: (filter_row):
1943 Explictly filter out the per-account outbox accounts. I don't know why
1944 these only sometimes show up, but now they should never show up in the UI.
1945 This should fix projects.maemo.org bug NB#60160.
1947 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1949 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1950 when the toolbar does not exist yet.
1951 * src/modest-widget-memory.c: (save_settings_header_view):
1952 Added g_warnings() to help us to discover when we are trying to set
1953 an empty columns list in gconf.
1955 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1957 * src/modest-init.h:
1958 * src/modest-init.c:
1959 Added modest_init_get_default_header_view_column_ids().
1961 * src/modest-widget-memory.c: (restore_settings_header_view):
1962 Use the new function to get defaults, if the gconf key is empty,
1963 instead of not creating any columns. This seems to fix the
1964 empty right-hand pane problems.
1966 * src/widgets/modest-header-view.h: Improved documentation.
1968 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1970 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1971 Revert the use of the display name as the account name, because this
1972 is generally wrong and would break the code that follows.
1974 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1976 * src/maemo/easysetup/modest-easysetup-wizard.c:
1977 (check_for_supported_auth_methods), (on_before_next),
1980 More correct fix for projects.maemo.org bug NB# 58991
1981 Do not longer accept AUTH_PASSWORD as secure method and choose
1982 correct method when creating the account.
1984 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1986 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1987 Fixed projects.maemo.org bug NB# 58991
1989 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1991 * src/modest-init.c: (modest_init_init_core),
1992 (modest_init_local_folders): Fixed compilation errors.
1994 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1996 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1997 Remove unnecessary lib/include, though it is good in principle when needed.
1999 * src/modest-init.c: (modest_init_one_local_folder),
2000 (modest_init_local_folders):
2001 * src/modest-init.h: Initialize the .modest library for memory cards,
2002 instead of just doing nothing for them. This should allow us to create
2003 folders there, fixing projects.maemo.org bug NB#59297.
2005 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2007 * libmodest-dbus-client/libmodest-dbus-client.c:
2008 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2009 (libmodest_dbus_client_compose_mail),
2010 (libmodest_dbus_client_open_message),
2011 (libmodest_dbus_client_send_and_receive),
2012 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2014 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2015 (on_idle_open_message), (modest_dbus_req_handler),
2016 (search_result_to_message), (modest_dbus_req_filter):
2017 * src/modest-search.c: (add_hit), (modest_search_folder),
2018 (modest_search_all_accounts): Improved debug messages.
2020 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2022 * src/modest-tny-account-store.c:
2023 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2026 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2029 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2031 * src/modest-tny-account-store.c: (get_server_accounts):
2032 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2033 even when there are no accounts, so that the Outbox folder is always
2034 visible. This fixes projects.maemo.org bug NB#60158.
2036 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2038 * src/maemo/modest-main-window.c: (create_details_widget):
2039 Use the mcen_va_never logical ID.
2041 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2043 * src/dbus_api/modest-dbus-api.h:
2044 * src/dbus_api/modest-dbus-callbacks.c:
2045 (on_idle_open_default_inbox), (on_open_default_inbox),
2046 (modest_dbus_req_handler):
2047 Added a new OpenDefaultInbox method.
2049 * libmodest-dbus-client/libmodest-dbus-client.h:
2050 * libmodest-dbus-client/libmodest-dbus-client.c:
2051 Added libmodest_dbus_client_open_default_inbox() to call the new
2052 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2053 though it should maybe be used by a new osso-email-interface function.
2055 * tests/dbus_api/Makefile.am:
2056 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2059 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2061 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2062 NULL, so that the signals get all the keys. This should not actually
2063 change any behaviour because we currently update everything when anything
2066 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2068 * src/widgets/modest-folder-view.c: (text_cell_data),
2069 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2070 (find_inbox_iter): If tinymail tells us that the folder is
2071 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2072 This causes the inbox to be selected at startup, fixing part of
2073 projects.maemo.org bug NB#56305.
2075 * src/modest-ui-dimming-rules.c:
2076 (modest_ui_dimming_rules_on_tools_smtp_servers):
2077 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2078 the SMTP servers menu item.
2079 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2080 that the SMTP Servers menu item is dimmed when there are no accounts,
2081 as a future version of the UI spec will require. This fixes
2082 projects.maemo.org bug NB#56305.
2084 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2086 * src/maemo/modest-maemo-utils.c:
2087 (modest_maemo_utils_get_supported_secure_authentication_methods):
2088 Added label to dialog instead of unreadable title
2090 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2091 (modest_main_window_new):
2092 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2095 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2096 * src/modest-account-mgr.h:
2097 Added method to avoid code duplication
2099 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2100 (modest_ui_actions_on_send_receive):
2101 Use modest_account_mgr_has_accounts
2103 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2105 * src/maemo/easysetup/modest-presets.c:
2106 (modest_presets_get_info_server_security): Do not report secure auth
2108 * src/modest-protocol-info.c: Use the defines for the gconf key names
2109 for secure authentication. This was not working because we were writing
2110 Password and reading password, and the check was case sensitive.
2111 With this, gmail now works for receiving and sending when created via
2114 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2116 * src/maemo/easysetup/modest-presets.c:
2117 (modest_presets_get_info_server_security): Correct the key name for
2118 SecureSmtp, because it seems to be case-sensitive.
2119 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2120 Do not try to get the 0th notebook page if there are 0 pages, to
2121 avoid a g_warning().
2123 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2125 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2126 Prevent use of the new notification feature for now, because it currently
2127 shows one dialog for each new email, which is annoying.
2129 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2131 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2132 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2133 when no country was selected, so that we show the global ones.
2134 * src/maemo/easysetup/modest-presets.c:
2135 (modest_presets_get_providers): Return only the global providers, not
2136 all providers when mmc=0 was requested.
2138 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2140 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2141 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2142 provider ID in the combo.
2144 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2145 Do not show the page numbers, because it would be confusing when we add
2146 the 2 extra pages for the custom setup, when the user chooses the "Other"
2147 provider. This fixes projects.maemo.org bug NB#59028
2149 * src/modest-init.c: (modest_init_init_core),
2150 (modest_init_local_folders):
2151 * src/modest-init.h:
2152 * src/modest-tny-account.c:
2153 (modest_tny_account_new_for_local_folders): Do not create default folders
2154 for the memory card. This should fix projects.maemo.org bug NB#59328.
2156 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2158 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2159 Free the changed_conf_keys string items. They are already freed in the
2160 idle handler if that runs first.
2162 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2164 * src/modest-ui-actions.c:
2165 (modest_ui_actions_on_password_requested): Check that the server name
2166 is not NULL, because I just saw a password dialog with (null) as the
2169 * src/modest-tny-folder.[h|c]: Added
2170 modest_tny_folder_is_memory_card_folder().
2171 * src/modest-ui-dimming-rules.c:
2172 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2173 menu item for memory cards, as per the UI spec (section 7.4). This should
2174 fix projects.maemo.org bug NB#59297.
2176 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2178 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2179 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2180 is another problem with the code, see Murray's comment at line 772)
2182 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2184 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2185 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2186 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2187 (load_from_file), (easysetup_country_combo_box_init),
2188 (easysetup_country_combo_box_get_active_country_ids),
2189 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2190 instead of just one ID, to avoid duplicate country names in the UI.
2192 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2193 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2194 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2195 a single ID, avoiding duplicate providers.
2196 * src/maemo/easysetup/modest-easysetup-wizard.c:
2197 (on_combo_account_country): Adapt to use a list.
2199 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2201 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2202 keys changed in the last X seconds.
2204 * src/modest-account-mgr.h:
2205 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2206 (on_key_change), (modest_account_mgr_class_init),
2207 (modest_account_mgr_init), (modest_account_mgr_finalize):
2208 As the keys are changed, save them in a GSList* and signal that GSList*
2209 further every X seconds, to batch changes, to allow us to do just one
2210 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2211 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2213 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2214 changed signal signature.
2216 * src/modest-conf.c: (modest_conf_set_list),
2217 (modest_conf_on_change): Reenable notification.
2219 (modest_conf_maemo_fake_on_change): Comment out the hack that
2220 notified immediately instead of asynchronously.
2222 * src/widgets/modest-account-view.h:
2223 * src/widgets/modest-account-view.c:
2224 (update_account_view): Select the previously-selected account ID,
2225 if possible. This fixes projects.maemo.org bug NB#56933.
2227 (on_account_changed), (on_account_removed),
2228 (modest_account_view_select_account):
2230 Remove the block/unblock functions
2231 because they were not useful.
2233 * src/maemo/modest-account-view-window.c:
2234 (on_delete_button_clicked), (on_edit_button_clicked),
2235 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2237 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2239 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2240 Improve the error dialog to show Incorrect Account Settings, which seems
2241 clearer, and say that the internal error message (to be removed from the
2242 dialog later) is often misleading.
2243 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2245 * src/modest-tny-account.c:
2246 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2247 URL because this is so useful for debugging on the device.
2249 * src/widgets/modest-serversecurity-combo-box.c:
2250 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2252 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2254 * src/modest-mail-operation.c:
2255 (modest_mail_operation_send_new_mail):
2256 Added a comment about a nasty but apparently harmless message. Details
2257 added to the wiki g_warnings() page.
2259 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2261 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2262 (modest_tny_send_queue_class_init):
2263 Do not use the priv struct because it is empty, to avoid g_warnings
2264 about a non-existant priv struct.
2266 * src/modest-tny-account-store.c:
2267 (modest_tny_account_store_get_server_account),
2268 (modest_tny_account_store_get_transport_account_for_open_connection
2269 ): Do not try to get transport server accounts for local folders,
2270 because they don't have any. This avoids a g_warning().
2272 * src/maemo/modest-main-window.c:
2273 (modest_main_window_notify_send_receive_initied),
2274 (on_configuration_key_changed):
2275 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2276 * src/modest-defs.h:
2277 * src/modest-mail-operation.c:
2278 (modest_mail_operation_update_account):
2279 * src/modest-tny-account-store.h:
2280 * src/modest-tny-account.c:
2281 (modest_tny_account_get_special_folder),
2282 (modest_tny_account_new_for_local_folders),
2283 (modest_tny_account_new_for_per_account_local_outbox_folder):
2284 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2285 * src/modest-tny-local-folders-account.c:
2286 (add_account_folders_to_merged_folder):
2287 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2288 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2289 (modest_ui_actions_on_send):
2290 * src/widgets/modest-folder-view.c: (update_model):
2291 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2292 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2293 modest_tny_account_store_get_tny_account_by_account() to
2294 modest_tny_account_store_get_server_account() to make the code clearer.
2296 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2298 * src/dbus_api/modest-dbus-api.h:
2299 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2300 * src/maemo/modest-msg-edit-window.c:
2301 (modest_msg_edit_window_attach_file_noninteractive):
2302 added g_warning in case the file to be attached does not exist
2303 * tests/dbus_api/test_compose_mail.c: (main):
2304 removed obsolete comment, added generic files as test case
2306 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2308 * src/modest-tny-account-store.c: (get_server_accounts):
2309 Create the local folders account only once, not once for each outbox, and
2310 not only when there are some outboxes.
2312 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2314 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2315 code that is causing a crash at startup. Sergio says that he is fixing this.
2317 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2319 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2320 * src/maemo/modest-account-settings-dialog.c:
2321 (create_page_outgoing),
2322 (modest_account_settings_dialog_set_account_name),
2323 (save_configuration):
2324 - Fixed handling of the "Use secure authentication" toggle to comply with
2325 the ui specification. See also projects.maemo.org bug NB#58400
2327 - Restore the Secure connection setting combo correctly when loading
2330 * src/maemo/modest-maemo-utils.c:
2331 (on_camel_account_get_supported_secure_authentication),
2332 (modest_maemo_utils_get_supported_secure_authentication_methods):
2333 Fixed a crasher if operation is canceled
2335 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2336 (modest_protocol_info_auth_is_secure):
2337 * src/modest-protocol-info.h:
2339 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2340 the sense of the "Use secure authentication" toggle.
2342 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2344 * src/modest-tny-account-store.h:
2345 * src/modest-tny-account-store.c:
2346 Added modest_tny_account_store_get_local_folders_account().
2348 * src/modest-tny-folder.h:
2349 * src/modest-tny-folder.c:
2350 (modest_tny_folder_get_account):
2351 Added this replacement for tny_folder_get_account() which returns
2352 the local-folders account for TnyMergeFolders, to avoid the
2353 warning about the unimplemented get_account_func() vfunc().
2355 (modest_tny_folder_get_rules),
2356 * src/modest-ui-actions.c:
2357 (modest_ui_actions_on_folder_selection_changed):
2358 * src/modest-mail-operation.c:
2359 (modest_mail_operation_remove_folder),
2360 (modest_mail_operation_xfer_folder),
2361 (modest_mail_operation_rename_folder),
2362 (modest_mail_operation_get_msg),
2363 (modest_mail_operation_get_msgs_full),
2364 (modest_mail_operation_remove_msg),
2365 (modest_mail_operation_xfer_msgs),
2366 (modest_mail_operation_refresh_folder):
2367 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2369 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2371 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2372 (modest_server_account_set_security):
2373 * src/modest-defs.h: Add comments explaining that our
2374 UI spec means TLS when it says Normal, so these do not look like errors.
2376 * src/modest-tny-account.c:
2377 (modest_tny_account_new_from_server_account): Use the new tinymail
2378 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2379 for TLS. This should fix projects.maemo.org bug NB#58460.
2381 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2383 * src/maemo/easysetup/modest-easysetup-wizard.c:
2384 (create_account): Correct the position of the gconf sanity check warning.
2385 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2386 of using the g_idle_add() hack, because this does not seem to be necessary
2387 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2388 caused by something other than maemo's gconf.
2389 This fixes projects.maemo.org bug #59022.
2391 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2393 * src/modest-account-mgr-helpers.c:
2394 (modest_account_mgr_get_default_account): Do not check that the account
2395 exists if there is no default account (NULL), to fix a runtime warning.
2397 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2399 * src/widgets/modest-folder-view.c: (update_model):
2400 Do not unref the treemodel before we have finished with it.
2401 This prevents a valgrind warning and an occasional crash at startup.
2403 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2405 * libmodest-dbus-client/libmodest-dbus-client.h:
2406 added libmodest_dbus_client_compose_mail()
2407 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2409 added functions needed for SendAsMail() functionality
2410 * src/maemo/modest-msg-edit-window.c:
2411 (modest_msg_edit_window_attach_file_noninteractive):
2412 non interactively attaching files to message edit window
2413 * src/widgets/modest-msg-edit-window.h:
2414 * tests/dbus_api/Makefile.am:
2415 added test_compose_mail.c
2416 * tests/dbus_api/test_compose_mail.c: (main):
2418 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2420 * src/modest-account-view.c:
2421 Fixed bug projects.maemo.org bug NB#59307
2423 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2425 * src/maemo/easysetup/modest-easysetup-wizard.c:
2426 (get_serverport_incoming), (on_before_next), (create_account):
2427 * src/maemo/modest-account-settings-dialog.c:
2428 (modest_account_settings_dialog_set_account_name):
2429 * src/maemo/modest-maemo-utils.c:
2430 (on_camel_account_get_supported_secure_authentication_status),
2431 (on_camel_account_get_supported_secure_authentication),
2432 (on_secure_auth_cancel),
2433 (modest_maemo_utils_get_supported_secure_authentication_methods):
2435 Implemented security authentication for settings and easysetup.
2437 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2439 * src/maemo/modest-main-window.c: (create_details_widget):
2440 Show the total size for memory card accounts too, instead of showing
2441 the name again. Fixes bug projects.maemo.org bug NB#59307.
2443 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2446 * src/modest-tny-simple-folder-store.c:
2447 * src/modest-tny-simple-folder-store.h: Removed.
2449 * src/modest-tny-local-folders-account.h
2450 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2451 for the local-folders maildir, with an extra TnyMergedFolder containing
2452 the folders of the per-account outbox store accounts.
2453 * src/modest-tny-account-store.c: (get_server_accounts):
2454 Add the outboxes to the special local folders account after creating it.
2456 * src/modest-tny-account.c:
2457 (modest_tny_account_new_for_local_folders): Create the derived
2458 account when creating the main local-folders account.
2460 * src/maemo/modest-main-window.c: (create_details_widget),
2461 (modest_main_window_set_contents_style):
2462 Adapted to the use of the derived account instead of the folder store.
2464 * src/modest-ui-actions.c:
2465 (modest_ui_actions_on_folder_selection_changed):
2466 * src/modest-ui-dimming-rules.c:
2467 (modest_ui_dimming_rules_on_new_folder):
2468 * src/widgets/modest-folder-view.c: (text_cell_data),
2469 (icon_cell_data), (filter_row), (update_model),
2470 (get_cmp_rows_type_pos):
2473 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2474 Do not get the priv struct, because no priv struct has been set,
2475 to avoid a runtime warning.
2477 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2478 #ifelse with #else, to fix a warning, to fix the build.
2481 2007-06-05 Christian Kellner <ckellner@openismus.com>
2483 * libmodest-dbus-client/libmodest-dbus-client.c:
2484 Fix small typo in doc (why do you always see them
2485 AFTER committing stuff?)
2488 2007-06-05 Christian Kellner <ckellner@openismus.com>
2490 * libmodest-dbus-client/libmodest-dbus-client.c:
2491 (libmodest_dbus_client_search):
2492 Initialize hit list with NULL. Also set folder list
2493 to "" if NULL was supplied.
2496 2007-06-03 Christian Kellner <ckellner@openismus.com>
2498 * libmodest-dbus-client/libmodest-dbus-client.c:
2499 (modest_search_hit_list_free):
2500 Make it save to call it with NULL.
2502 * src/dbus_api/modest-dbus-callbacks.c:
2503 * src/modest-search.c:
2504 Return full ModestSearchHits as the search result list not TnyHeader
2505 since can't be around withouth the correspoding TnyFolder.
2507 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2509 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2510 Added currently commented code to check for secure auth
2512 * src/maemo/modest-account-settings-dialog.c: (on_response),
2513 (save_configuration), (show_ok):
2514 Fixed projects.maemo.org bugs NB #59248 and #59251
2516 * src/maemo/modest-maemo-utils.c:
2517 (on_camel_account_get_supported_secure_authentication_status),
2518 (on_camel_account_get_supported_secure_authentication),
2519 (modest_maemo_utils_get_supported_secure_authentication_methods):
2520 * src/maemo/modest-maemo-utils.h:
2521 Moved get_supported_secure_authentication() method here to be able
2522 to use it from easysetup wizard.
2524 * src/modest-pair.c: (on_pair_compare_as_string):
2525 Should compare string with first part of pair and not
2526 strcmp pairs which will crash.
2528 * src/modest-protocol-info.c:
2529 (modest_protocol_info_protocol_is_store):
2530 * src/modest-protocol-info.h:
2531 Added modest_protocol_info_get_auth_protocol_name()
2533 2007-06-03 Armin Burgmeier <armin@openismus.com>
2535 * src/modest-mail-operation.c:
2536 (modest_mail_operation_get_msgs_full): Set priv->account also when
2537 only retrieving a single message. This avoids a crash when canceling
2540 (modest_mail_operation_notify_end): Do not explicitely remove the
2541 operation from the queue but only emit the progress_changed signal.
2542 The queue itself listens to that signal to remove the operation when
2543 it is finished. This reduces coupling and removes a potential deadlock
2544 when modest_mail_operation_notify_end() is called from the queue
2545 itself. If that is a problem performance-wise, I would suggest to
2546 implement a status-changed signal or something.
2548 * src/modest-mail-operation-queue.c: Make sure to never call a
2549 function from another file while the queue is locked. This (hopefully)
2550 fixes another deadlock when exiting the application while retrieving
2553 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2555 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2556 Fixed build if libogs is not available
2558 2007-06-03 Christian Kellner <ckellner@openismus.com>
2560 * libmodest-dbus-client/libmodest-dbus-client.h:
2561 * libmodest-dbus-client/libmodest-dbus-client.c:
2562 (libmodest_dbus_client_delete_message):
2563 Implement deletion of messages (Client side).
2565 (modest_search_hit_free),
2566 (modest_search_hit_list_free):
2567 Utility functions to free the result hits.
2569 * src/dbus_api/modest-dbus-api.h:
2570 * src/dbus_api/modest-dbus-callbacks.c:
2571 (on_delete_message),
2572 (modest_dbus_req_handler):
2573 Implement deletion of messages (Server side).
2575 * tests/dbus_api/test_search.c: (main):
2578 * tests/dbus_api/Makefile.am:
2579 * tests/dbus_api/test_delete_message:
2580 Add little test for the message deletion logic
2582 2007-06-03 Armin Burgmeier <armin@openismus.com>
2584 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2585 when the operation queue was not empty. projects.maemo.org bug
2588 2007-06-03 Armin Burgmeier <armin@openismus.com>
2590 * src/widgets/modest-account-view.c
2591 (on_account_default_toggled): Toggle default account column
2592 explicitely instead of waiting for gconf notification (which is
2593 currently ignored). This should fix projects.maemo.org bug NB#56910
2594 for now. It should probably be removed when gconf notifications are
2597 2007-06-03 Christian Kellner <ckellner@openismus.com>
2599 * libmodest-dbus-client/libmodest-dbus-client.c:
2600 Removed debugging spew.
2602 * src/dbus_api/modest-dbus-callbacks.c:
2603 Added debugging info.
2605 * src/modest-search.c:
2606 (modest_search_all_accounts):
2607 Use tny_account_store_get_accounts () on the account store
2608 to get all accounts which is the way to get all accounts.
2610 * tests/dbus_api/test_search.c: (main):
2611 Make it possible to supply the search term on the command line.
2613 2007-06-03 Christian Kellner <ckellner@openismus.com>
2615 * libmodest-dbus-client/libmodest-dbus-client.c:
2616 * libmodest-dbus-client/libmodest-dbus-client.h:
2617 Implement searching for mesages over raw dbus. (Client side)
2619 * src/dbus_api/Makefile.am:
2620 * src/dbus_api/modest-dbus-api.h:
2621 * src/dbus_api/modest-dbus-callbacks.c:
2622 * src/dbus_api/modest-dbus-callbacks.h:
2623 Search framework (Server side). Also implement on_idle_open_message().
2625 * src/maemo/modest-platform.c: (modest_platform_init):
2626 Prepare for raw dbus/osso rpc interaction.
2628 * src/modest-search.h:
2629 Changed minsize from unspecific guint to guint32.
2631 * src/modest-search.c:
2633 Added strange hack which magically made tnymail work.
2635 (modest_search_folder),
2636 (modest_search_account),
2637 (modest_search_all_accounts):
2638 Implement helper functions to search all accounts, specific account
2641 * tests/dbus_api/Makefile.am:
2642 * tests/dbus_api/test_open_message.c:
2643 Read url to open from commandline.
2645 * tests/dbus_api/test_search.c:
2646 Implement small test for dbus search stuff
2648 2007-06-02 Armin Burgmeier <armin@openismus.com>
2650 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2651 include account type and account title. This fixes projects.maemo.org
2654 * src/maemo/modest-account-view-window.c: Set a title for the window.
2656 2007-06-02 Armin Burgmeier <armin@openismus.com>
2658 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2659 incoming and outgoing server name based on email address and server
2660 types as long as the names have not been edited manually. This fixes
2661 projects.maemo.org bug NB#58671.
2663 2007-06-02 Armin Burgmeier <armin@openismus.com>
2665 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2666 server type cannot be changed in future to the incoming details page
2667 when creating an account. This fixes projects.maemo.org bug NB#59029.
2669 2007-06-02 Armin Burgmeier <armin@openismus.com>
2671 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2672 and assigned max width chars so that they wrap instead of being
2673 truncated. Fixes projects.maemo.org bug NB#56126.
2675 2007-06-02 Armin Burgmeier <armin@openismus.com>
2677 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2678 introductory note to the connection specific smtp servers dialog, as
2679 section 8.12 of the email UI specification requires. This fixes
2680 projects.maemo.org bug NB#59212.
2682 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2684 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2685 Check for running mail operations, and offer to cancel them, as per the UI
2686 spec. This fixes projects.maemo.org bug NB#59041 .
2687 However, I suspect that tinymail may still use the network connection
2688 in ways that we cannot detect or cancel. But it should at least adapt to
2689 changes fairly well.
2691 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2693 * src/modest-tny-account-store.c: (recreate_all_accounts),
2694 (get_cached_accounts), (get_server_accounts): Do more sensible
2695 ref-counting of the temporarily-cached outbox accounts list. This seems
2696 to fix a crash when entering the password when the password was wrong.
2698 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2700 * src/gnome/modest-main-window.c: (connect_signals):
2701 * src/modest-tny-account-store.c: (get_password),
2702 (modest_tny_account_store_alert): Added comments and clues and
2703 commented-out code about how we currently fail to deal with connection
2704 errors and wrong passwords, and how we should.
2706 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2708 * src/widgets/modest-retrieve-combo-box.c:
2709 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2710 This fixes projects.maemo.org bug NB#58472 .
2712 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2714 * src/maemo/easysetup/modest-easysetup-wizard.c:
2715 (create_page_complete_easysetup):
2716 (create_page_complete_custom): Correct the last commit,
2717 putting the correct sentences in the correct pages.
2719 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2721 * src/maemo/easysetup/modest-easysetup-wizard.c:
2722 (create_page_complete_custom): Show the second sentence of text
2723 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2726 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2728 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2729 Set the leave-on-server conf key by default. This fixes
2730 projects.maemo.org bug NB#59258 .
2732 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2734 * src/maemo/modest-account-view-window.c:
2735 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2736 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2739 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2741 * src/maemo/easysetup/modest-easysetup-wizard.c:
2742 (create_caption_new_with_asterisk):
2743 * src/maemo/modest-account-settings-dialog.c:
2744 (create_caption_new_with_asterisk):
2745 Uncomment the code to add the asterisk, because they are no longer in the
2746 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2747 (update_incoming_server_title): Add an asterisk here too.
2749 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2751 * src/maemo/modest-maemo-global-settings-dialog.c:
2752 (current_connection): Check that we are even connected before trying to
2753 get the current connection name, to prevent a warning.
2755 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2756 Change the comments because tny_maemo_conic_device_connect() is now meant to
2758 * src/modest-mail-operation.c:
2759 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2760 make sure we have a connection and fail if we can't connect.
2762 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2764 * src/maemo/modest-main-window.c:
2765 (on_account_store_connecting_finished): Do not try to get the
2766 connection ID if we are not really connected. I am surprised that
2767 this signal handler is called when we are not connected.
2769 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2771 * src/modest-error.h:
2772 * src/modest-ui-actions.c:
2773 (modest_ui_actions_get_msgs_full_error_handler):
2774 Renamed an enum, added comments, added an enum
2775 for retrieve-limit errors.
2777 * src/modest-mail-operation.c: (foreach_add_item),
2778 (internal_folder_observer_update), (update_account_thread),
2779 (modest_mail_operation_get_msgs_full):
2780 (modest_mail_operation_update_account),
2781 Added comments about how this works, and some code that should
2782 (but does not) check the retrieve-limit. See the TODO comment.
2784 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2786 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2787 Initialize help_id to fix the build. Warnings are good.
2789 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2791 * src/widgets/modest-hbox-cell-renderer.c:
2792 (modest_hbox_cell_renderer_append):
2793 * src/widgets/modest-vbox-cell-renderer.c:
2794 (modest_vbox_cell_renderer_append):
2795 Fix the last commit by doing an extra ref.
2797 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2799 * src/widgets/modest-hbox-cell-renderer.c:
2800 (modest_hbox_cell_renderer_append):
2801 * src/widgets/modest-vbox-cell-renderer.c:
2802 (modest_vbox_cell_renderer_append):
2803 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2804 to fix the build with Maemo Bora.
2805 However, there seems to be a remaining crash, probably due to reference
2808 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2810 * src/modest-tny-account.c:
2811 (modest_tny_account_new_for_local_folders):
2812 Use hildon_file_system_info_async_new() to get a better name for
2813 the memory card account, setting it as the account name.
2814 The timing seems to work, but this is probably
2815 not the best place to do this. See the TODO comment.
2816 * src/maemo/modest-main-window.c: (create_details_widget):
2817 * src/widgets/modest-folder-view.c: (text_cell_data):
2818 Use the tny account name instead of hardcoding a name.
2820 2007-05-30 Christian Kellner <ckellner@openismus.com>
2822 * src/modest-search.c: (modest_search):
2823 Correctly set part_search_func even if we have already parsed
2824 the query and thus a valid OgsTextSearcher object.
2826 2007-05-30 Christian Kellner <ckellner@openismus.com>
2829 Search and check for libogs.
2832 Incooparte the ogs build env.
2834 * src/modest-mime-part-search-stream.c:
2835 * src/modest-mime-part-search-stream.h:
2836 Removed since we do the real searching now in modest-search.c.
2838 * src/modest-search.c:
2839 * src/modest-search.h:
2840 Implement support for ogs. We use that if available and requested
2841 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2842 should now handle the corner case when the search term is spread
2843 across multiple reads.
2844 Also the logic in modest_search () was corrected to search all
2845 requested fields until one is found.
2847 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2849 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2851 * src/modest-init.h:
2852 * src/modest-init.c: Made modest_init_local_folders() take a
2853 path and be public so we can iniitialize maildir folders on
2856 * src/modest-local-folder-info.h:
2857 * src/modest-local-folder-info.c:
2858 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2860 * src/modest-tny-account.c:
2861 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2862 still means the standard local-folders path on the local volume.
2864 * src/modest-tny-account-store.c:
2865 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2866 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2867 all accounts when that happens.
2868 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2869 this too, so it shows up in the treeview.
2871 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2873 * src/maemo/modest-maemo-global-settings-dialog.c:
2874 (current_connection):
2875 * src/widgets/modest-global-settings-dialog.c:
2876 (current_connection_default):
2877 Use the enum values instead of 0, 1 and -1,
2878 to make the code clearer.
2880 * src/modest-account-mgr-helpers.c:
2881 (modest_account_mgr_get_connection_specific_smtp): Make this code
2884 * src/modest-runtime.h:
2885 * src/modest-runtime.c:
2886 Added modest_runtime_remove_all_send_queues().
2887 * src/maemo/modest-main-window.c:
2888 (on_account_store_connecting_finished): Recreate the send queues,
2889 using the appropriate transport accounts for this new connection.
2890 Some futher adapting might be needed if the old send queues are not
2891 automatically stopped at this point.
2893 * src/modest-tny-account-store.c: (get_server_accounts):
2894 Create the connection-specific transport accounts, so that they can
2895 be found later by their ID.
2897 * src/modest-tny-account.h:
2898 * src/modest-tny-account.c:
2899 Added modest_tny_account_new_from_server_account_name().
2900 modest_tny_account_new_from_server_account(): Do not create the
2901 send queues here, because they will be
2902 recreated anyway when the connection changes for the first time.
2904 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2906 * src/modest-local-folder-info.h:
2907 * src/modest-local-folder-info.c:
2908 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2909 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2910 tbox_folder): Take a modest account name instead of a server TnyAccount,
2911 so we can have per-modest-account rather than per-transport-account
2913 We must make sure that we change or recreate the exisitng send queues
2914 when the connection changes for connection-specific transport accounts.
2916 * src/modest-tny-account-store.c:
2917 (create_per_account_local_outbox_folders): Create outboxed per modest
2918 account, not per transport account.
2920 * src/modest-tny-account.h:
2921 * src/modest-tny-account.c:
2922 (modest_tny_account_get_special_folder): For outboxes, get the
2923 parent modest account name. The account is ignored for other folders.
2924 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2925 modest account name rather than a server TnyAccount.
2927 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2929 * src/modest-tny-account.c:
2930 (modest_tny_account_new_from_server_account):
2931 Call modest_runtime_get_send_queue() immediately after creating transport
2932 accounts, so that they start trying to send email from the outbox as soon
2933 as possible at startup. This is probably what we want.
2935 * src/modest-mail-operation.c: (update_account_thread):
2936 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2937 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2938 * src/modest-tny-send-queue.h:
2939 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2940 (modest_ui_actions_on_send):
2941 Added comments about how sending works, though it needs some more work.
2943 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2945 * src/modest-tny-account.c:
2946 (modest_tny_account_get_special_folder): Add TODO because this fails when
2947 the network is busy.
2948 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2949 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2950 Do not try to show this window when there is no active account. The UI
2951 specs does not tell us what to do in this case.
2953 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2957 * src/maemo/Makefile.am:
2958 * src/widgets/Makefile.am: Some dist fixes.
2960 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2962 * src/maemo/modest-connection-specific-smtp-window.c:
2963 (on_button_edit): Make the code clearer, to prevent a double free.
2965 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/modest-account-settings-dialog.c:
2968 (modest_account_settings_dialog_set_account_name),
2969 Check the connection-specific smtp servers checkbox if there are any.
2971 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2972 (modest_connection_specific_smtp_edit_window_init):
2973 Start with a suitable port number.
2975 * src/modest-account-mgr-helpers.h:
2976 * src/modest-account-mgr-helpers.c: Added
2977 modest_account_mgr_get_has_connection_specific_smtp().
2979 (modest_account_mgr_set_connection_specific_smtp),
2980 (modest_account_mgr_remove_connection_specific_smtp),
2981 (modest_account_mgr_get_has_connection_specific_smtp),
2982 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2983 connection-specific smtp server accounts in the account, rather than
2984 the server account conf dir.
2986 This fixes bug projects.maemo.org bug NB#58263 .
2988 * src/modest-tny-account-store.c:
2989 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2990 if there are no server accounts yet, to prevent an infinite loop when there
2991 are no accounts. Document that one must be called before the other.
2993 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2995 * src/modest-account-mgr-helpers.c:
2996 (modest_account_mgr_get_default_account): Make sure that at least
2997 one account is always the default, if there are any enabled accounts.
2998 This is just a sanity check that shouldn't be necessary.
3000 * src/modest-account-mgr-priv.c:
3001 (_modest_account_mgr_account_from_key): Unescape the conf key to
3002 get the real account name. For instance, this is an issue if a space
3003 was in the account name, which can happen because the account name
3004 is generated from the display name.
3005 (_modest_account_mgr_get_account_keyname): Always escape the
3007 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3008 Unescape the conf keys to get the real account names.
3010 For instance, previously the is-default radio button in the accounts
3011 list was not checked for any accounts at first. This fixes that,
3012 and might fix several similar bugs.
3014 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3016 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3017 Removed some debug printfs.
3019 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3021 Modest on-disk outbox directories are now here, for instance:
3022 $HOME/.modest/outboxes/<account-id-1>/outbox
3023 $HOME/.modest/outboxes/<account-id-2>/outbox
3025 $HOME/.modest/local-folders/outbox
3026 so we can have a separate outbox for each account.
3027 But they are shown as one outbox in the GtkTreeView, by using a
3028 TnyMergeFolder in a ModestTnySimpleFolderStore.
3031 * src/modest-tny-simple-folder-store.c:
3032 * src/modest-tny-simple-folder-store.h:
3033 Added ModestTnySimpleFolderStore, used to contain folders from
3034 other folder stores, such as other accounts.
3036 * src/modest-tny-outbox-account.h:
3037 * src/modest-tny-outbox-account.c:
3038 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3039 used for the per-account local outbox folders.
3041 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3042 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3043 only use this (internally) now for the non-outbox local folders.
3045 * src/modest-init.h:
3046 * src/modest-init.c: Added modest_init_one_local_folder(), for
3047 setting up the directory structure for each local folder.
3049 * src/modest-local-folder-info.c:
3050 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3051 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3053 * src/modest-local-folder-info.h:
3054 * src/modest-tny-account-store.c: (on_account_removed),
3055 (on_account_changed), (create_per_account_local_outbox_folders),
3056 (get_server_accounts), (modest_tny_account_store_get_accounts),
3057 (modest_tny_account_store_get_tny_account_by_account),
3058 (modest_tny_folder_store_is_virtual_local_folders):
3060 * src/modest-tny-account.h:
3061 * src/modest-tny-account.c:
3062 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3063 to create an on-disk per-account local outbox folder for each
3065 (create_per_account_local_outbox_folders): Create a local outbox folder
3066 for each transport account.
3067 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3068 for all local folders.
3070 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3071 instead of using g_object_get/set() directly. It is clearer.
3073 (modest_tny_folder_store_get_message_count),
3074 (modest_tny_folder_store_get_local_size
3075 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3076 because we now use these with non-acount folder stores.
3078 (modest_tny_account_get_special_folder),
3079 (modest_tny_account_new_from_server_account),
3080 (modest_tny_account_new_from_account):
3081 (recurse_folders): Adjust to the new outbox system.
3083 * src/modest-tny-folder.h:
3084 * src/modest-tny-folder.c:
3085 (modest_tny_folder_is_local_folder),
3086 (modest_tny_folder_get_local_folder_type),
3087 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3089 * src/widgets/modest-main-window.h:
3090 * src/maemo/modest-main-window.c: (create_details_widget),
3091 (modest_main_window_set_contents_style): Show details for any folder store,
3094 (modest_tny_folder_get_rules):
3095 Remove the const. C does not support constness enough for this.
3097 * src/modest-ui-actions.c:
3098 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3099 make all outboxes appear as one, in the usual local-folders tree node.
3101 (set_active_account_from_tny_account),
3102 (modest_ui_actions_on_folder_selection_changed):
3103 * src/widgets/modest-folder-view.c: (text_cell_data),
3104 (icon_cell_data), (filter_row),
3105 (add_account_folders_to_merged_folder),
3106 (add_account_folders_to_simple_folder_store), (),
3107 (get_cmp_rows_type_pos), (cmp_rows),
3108 (modest_folder_view_set_account_id_of_visible_server_account):
3109 Adjust to the new outbox system, using generic folder stores and folders
3110 in the GtkTreeModel.
3112 2007-05-23 Christian Kellner <ckellner@openismus.com>
3114 * src/modest-mail-operation.c:
3115 (modest_mail_operation_update_account):
3116 Use info->max_size instead of unintialized local var [small
3117 build fix]. (Added TODO to review that change since I don't
3120 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3122 * libmodest-dbus-client/libmodest-dbus-client.c:
3123 (libmodest_dbus_client_compose_mail): function added
3124 * src/dbus_api/modest-dbus-api.h:
3125 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3126 (on_compose_mail): Implementation of the SendAsMail functionality
3128 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3130 * src/modest-account-mgr.c:
3131 (modest_account_mgr_add_server_account): Set the secure-connection
3132 conf key for transport accounts as well as store accounts. I don't know
3133 why the if was there. For instance, this makes sure that we use SSL
3134 for the gmail preset from the easysetup wizard.
3136 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3138 * src/gnome/modest-main-window.c:
3139 (on_account_store_connecting_finished), (connect_signals):
3140 * src/maemo/modest-main-window.c:
3141 (on_account_store_connecting_finished), (connect_signals),
3142 (modest_main_window_new):
3143 Handle TnyAccountStore::connecting-finished instead of
3144 TnyDevice::connection-changed, because we cannot actually perform
3145 operations on accounts until TnyAccountStore has itself responded to
3146 the TnyDevice::connection-changed signal. This prevents a GError from
3148 Do not try to update at startup, because we (at least on scratchbox)
3149 already do an update at startup when the device goes online.
3150 This prevents a GError from tinymail.
3151 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3152 Added TODO about stopping simultaneous operations.
3154 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3156 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3157 * src/modest-mail-operation-queue.c:
3158 (modest_mail_operation_queue_remove):
3159 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3160 about where they happened.
3162 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3164 * src/modest-ui-actions.c:
3165 (modest_ui_actions_on_password_requested): Make sure that the remember
3166 output parameter is always TRUE.
3168 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3170 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3171 Show a OK/Cancel dialog if the error is a question, though we still do not
3172 know anything more about what we are asking the user.
3173 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3174 Fix an uninitialized variable (helper). This is a logic error, however.
3176 2007-05-21 Christian Kellner <ckellner@openismus.com>
3178 * src/modest-search.h:
3179 Correct bit shifting in the ModestSearchFlags enum.
3181 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3183 * src/modest-tny-account.c:
3184 (modest_tny_account_new_from_server_account): Do not use the lsub and
3185 check-all hard-coded IMAP options when using POP.
3187 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3189 * src/modest-tny-account.c:
3190 (modest_tny_account_new_from_server_account):
3191 Use NULL for the secure-auth method for POP when Password auth has been
3192 specified by the user, as we already do for IMAP. "auth=Login" causes
3193 an error from camel or the server.
3195 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3197 * src/maemo/modest-account-settings-dialog.c:
3198 (create_page_account_details),
3199 (modest_account_settings_dialog_set_account_name):
3200 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3201 for the leave-on-server checkbox, rathr than just the checkbox, when
3202 the protocol is not POP.
3204 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3206 * src/widgets/modest-account-view.c:
3207 * src/widgets/modest-account-view.h:
3208 Added modest_account_view_select_account() which will be useful later
3209 to asynchronously re-select the edited account.
3211 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3213 * src/maemo/modest-account-settings-dialog.c:
3214 (modest_account_settings_dialog_set_account_name):
3215 Automatically choose the port numbers based on the secure authentication
3216 methods, if they have not been chosen before.
3217 This fixes projects.maemo.org bug NB#56273 .
3219 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3221 * src/maemo/modest-main-window-ui.h:
3222 * src/modest-ui-actions.c:
3223 * src/modest-ui-actions.h:
3224 Connect the Tools/SMTP Servers menu item to
3225 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3226 SMTP servers dialog, as in the UI specification and saves changes when it
3227 is closed. This fixed projects.maemo.org bug NB#56305 .
3229 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3231 * src/maemo/modest-connection-specific-smtp-window.c:
3232 (modest_connection_specific_smtp_window_init):
3233 Use gtk_window_set_default_size() to make this window big enough, so
3234 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3236 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3238 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3239 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3240 (modest_connection_specific_smtp_edit_window_init),
3241 Do not try to connect to a combobox signal before the combobox exists.
3242 This fixes the cras in projects.maemo.org bug NB#56288 .
3243 (modest_connection_specific_smtp_edit_window_get_settings):
3244 Remove the server_account_name parameter which was being checked for NULL
3245 though it was not used.
3247 * src/maemo/modest-connection-specific-smtp-window.c:
3248 (modest_connection_specific_smtp_window_fill_with_connections),
3249 (on_button_edit), (modest_connection_specific_smtp_window_init):
3250 Correct the number of treemodel columns to prevent a warning.
3251 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3252 libconic does not work.
3254 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3256 * src/modest-tny-account.c:
3257 (modest_tny_account_new_from_server_account):
3258 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3259 SMTP when "None" was chosen by the user. However, with my SMTP server that
3260 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3263 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3265 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3266 to explain the memory management issue with the ID in the ModestPair.
3268 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3269 (add_sending_page), (modest_account_assistant_finalize):
3270 * src/gnome/modest-gnome-global-settings-dialog.c:
3271 (create_updating_page), (create_composing_page):
3272 * src/gnome/modest-msg-edit-window.c: (get_transports),
3273 (init_window), (modest_msg_edit_window_finalize),
3274 (modest_msg_edit_window_get_msg_data):
3275 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3276 * src/gnome/modest-transport-widget.c:
3277 (modest_transport_widget_finalize), (smtp_configuration):
3278 * src/maemo/modest-maemo-global-settings-dialog.c:
3279 (create_updating_page), (create_composing_page):
3280 * src/maemo/modest-msg-edit-window.c: (get_transports),
3281 (init_window), (modest_msg_edit_window_finalize),
3282 (modest_msg_edit_window_get_msg_data),
3283 (modest_msg_edit_window_free_msg_data):
3284 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3285 (modest_store_widget_finalize):
3286 * src/maemo/modest-transport-widget.c:
3287 (modest_transport_widget_finalize), (smtp_configuration):
3288 * src/modest-main.c: (send_mail):
3289 * src/widgets/modest-combo-box.h:
3290 * src/widgets/modest-global-settings-dialog-priv.h:
3291 * src/widgets/modest-global-settings-dialog.c:
3292 (modest_global_settings_dialog_finalize):
3293 * src/widgets/modest-msg-edit-window.h:
3294 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3295 as long as the combo box, to prevent use of freed memory for the ID.
3297 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3299 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3300 get_accounts(), to make this clearer. Do not check for the enabled gconf
3301 key, because we do not use this for server accounts (at least, not yet).
3302 This allows us to send email again.
3304 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3306 * src/maemo/modest-platform.c:
3307 (on_modest_conf_update_interval_changed), (modest_platform_init):
3308 Only respond to this particular key change. All these strcmp()s cannot be
3311 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3313 * src/maemo/modest-maemo-global-settings-dialog.c:
3314 (current_connection): Prevent a crash in scratchbox when
3315 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3316 * src/maemo/modest-platform.c:
3317 (on_modest_conf_update_interval_changed), (modest_platform_init):
3318 Get the update interval from gconf and reset it when the gconf key changes.
3320 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3322 * src/modest-protocol-info.c:
3323 * src/modest-protocol-info.h: Adde enum-specific get functions,
3324 instead of using a ModestProtocolType enum parameter.
3326 * src/gnome/modest-account-assistant.c:
3327 * src/gnome/modest-store-widget.c:
3328 * src/gnome/modest-store-widget.h:
3329 * src/gnome/modest-transport-widget.c:
3330 * src/gnome/modest-transport-widget.h:
3331 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3332 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3333 * src/maemo/easysetup/modest-easysetup-wizard.c:
3334 * src/maemo/modest-account-settings-dialog.c:
3335 * src/maemo/modest-account-settings-dialog.h:
3336 * src/maemo/modest-store-widget.c:
3337 * src/maemo/modest-store-widget.h:
3338 * src/maemo/modest-transport-widget.c:
3339 * src/maemo/modest-transport-widget.h:
3340 * src/modest-account-mgr-helpers.c:
3341 * src/modest-account-mgr-helpers.h:
3342 * src/modest-account-mgr.c:
3343 * src/modest-account-mgr.h:
3344 * src/modest-tny-account.c:
3345 * src/modest-tny-folder.c:
3346 * src/widgets/modest-account-view.c:
3347 * src/widgets/modest-retrieve-combo-box.c:
3348 * src/widgets/modest-retrieve-combo-box.h:
3349 * src/widgets/modest-secureauth-combo-box.c:
3350 * src/widgets/modest-serversecurity-combo-box.c:
3351 * src/widgets/modest-serversecurity-combo-box.h:
3352 * tests/check_account-mgr.c:
3353 Use the specific functions, and use the re-renamed enum values for GNOME too.
3355 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3357 * src/modest-pair.h:
3358 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3359 so we can get the second based on the first.
3361 * src/maemo/modest-account-settings-dialog.h:
3362 * src/maemo/modest-account-settings-dialog.c:
3363 Added get_supported_secure_authentication_methods(), though it is mostly
3364 commented-out for now until the necessary API is committed to tinymail.
3365 (modest_account_settings_dialog_set_account_name),
3366 (save_configuration): Request the supported authentication methods from the
3367 server, so we can choose a working method.
3369 * src/modest-tny-account-store.h:
3370 * src/modest-tny-account-store.c:
3371 (modest_tny_account_store_get_session): Rename from
3372 tny_account_store_get_session().
3374 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3376 * src/modest-protocol-info.h: Split the ModestProtocol enum
3377 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3378 There was no need to have these unrelated values in one enum.
3380 * src/: many files: Adapted to changed enum. This makes the code a bit
3381 clearer, and the compiler could catch some errors.
3383 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3385 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3386 Show the detailed internal camel error message when an error happens
3387 during the configuration, so that our testers can give us more clues.
3388 For instance, in projects.maemo.org bug NB#56910 .
3390 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3392 * src/modest-tny-account.c:
3393 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3394 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3396 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3398 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3399 * src/maemo/modest-account-settings-dialog.c:
3400 (modest_account_settings_dialog_set_account_name),
3401 (save_configuration): For the incoming secure authentication checkbox,
3402 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3403 the UI specification. PLAIN does not seem to be supported for most IMAP
3404 servers anyway, and I am not sure what it would mean.
3405 However, we probably need to discover which of the secure-authentication
3406 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3407 * src/modest-account-mgr-helpers.c:
3408 (modest_account_mgr_get_server_account_data):
3410 * src/modest-tny-account.c:
3411 (modest_tny_account_new_from_server_account):
3412 Use tny_account_set_mech() to set secure-authentication methods,
3413 with some special-casing for IMAP, based on my observations of how
3416 * src/modest-account-mgr-helpers.h:
3417 * src/modest-account-mgr.c:
3418 * src/modest-defs.h: Comment that the URI is only used for local folders.
3420 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3422 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3423 parameter const, just to be neat.
3424 * src/modest-text-utils.c: (modest_text_utils_inline):
3425 End g_strconcat() with NULL, as its documentation says. This is almost
3426 certainly the cause of my crash at startup on the device. Interestingly,
3427 valgrind doesn't tell us about these errors.
3429 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3431 * scripts/build-packages: Added more precise comments about how to use
3432 this script, though I still get this error:
3433 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3434 error building tinymail
3436 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3438 * src/maemo/modest-main-window.c: (on_account_update):
3439 Very slight cleanup, hoping to make it simpler to discover what causes
3440 a crash here sometimes.
3442 * src/modest-tny-account.c:
3443 (modest_tny_account_new_from_server_account): Set the port. Added
3444 comments about the options and a TODO comment because I need to find out
3445 how to specify the secure authentication method.
3447 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3449 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3450 changed CFlags paths form modest to libmodest
3452 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3454 * src/modest-account-mgr-helpers.c:
3455 (modest_account_mgr_get_server_account_data),
3456 (modest_account_mgr_free_server_account_data):
3457 * src/modest-account-mgr-helpers.h:
3458 * src/modest-account-mgr.c:
3459 (modest_account_mgr_add_server_account):
3460 * src/modest-defs.h:
3461 * src/modest-tny-account.c:
3462 (modest_tny_account_new_from_server_account):
3463 Determine the options for tny_camel_account_add_option() here,
3464 based on the settings, rather than storing them directly in gconf.
3466 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3468 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3469 Show a more friendly error dialog now that we expect (from the tinymail
3470 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3472 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3474 * src/maemo/modest-main-window.c: (on_account_update): Check that
3475 account_name is not NULL, to prevent a crash at startup that I am
3476 seeing on the N800. I do wonder why it is NULL.
3478 * src/maemo/easysetup/modest-easysetup-wizard.c:
3479 (create_page_user_details):
3480 * src/maemo/modest-account-settings-dialog.c:
3481 (create_page_user_details), (create_page_outgoing):
3482 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3483 (modest_connection_specific_smtp_edit_window_init):
3484 * src/modest-ui-actions.c:
3485 (modest_ui_actions_on_password_requested):
3486 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3487 might do something useful with the on-screen keyboard.
3489 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3491 * src/maemo/modest-main-window.c: (on_account_update):
3492 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3493 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3495 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3497 * src/modest-tny-account-store.c: (on_account_changed):
3498 Correct the signature of this signal handler.
3500 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3502 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3503 Show a HildonNote instead of a GtkDialog for Maemo.
3505 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3507 * src/widgets/modest-account-view.h:
3508 * src/widgets/modest-account-view.c: (on_account_changed),
3509 (on_account_removed). Added a boolean flag, set/unset by
3510 modest_account_view_block_conf_updates(),
3511 modest_account_view_unblock_conf_updates() to prevent unnecessary
3512 updates, but this is not very useful because the gconf notifications are
3513 so delays (maybe only on Maemo Bora).
3514 So auto-updating is turned off, and these functions do an explicit
3515 update when necessary.
3516 However, something else is still doing too much work when adding/removing
3517 accounts, probably in another part of the application.
3519 * src/maemo/modest-account-view-window.c:
3520 (on_delete_button_clicked), (on_edit_button_clicked),
3521 (on_new_button_clicked): Use the new functions.
3523 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3525 * src/modest-account-mgr-helpers.c:
3526 (modest_account_mgr_set_first_account_as_default):
3527 Sort the list of names alphabetically-by-title, so we choose the first one
3529 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3530 alphabetically by the title.
3532 This fixes projects.maemo.org bug NB#56418 .
3534 * src/modest-account-mgr-priv.c:
3535 (_modest_account_mgr_account_from_key):
3536 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3537 avoid a valgrind error, and possible random behaviour.
3539 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3541 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3542 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3543 tinymail documentation to say that this can be expected.
3544 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3545 pretty, and should not happen, but I would prefer to know when it does.
3547 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3549 * configure.ac: When using the older hildon version, probably on Bora,
3550 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3552 * src/widgets/modest-attachment-view.c:
3553 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3556 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3558 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3559 Implemented the prototype. Can be tested with
3560 tests/dbus_api/test_open_message:
3562 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3564 * src/modest-tny-account-store.c:
3565 (modest_tny_account_store_instance_init), (get_password):
3566 * src/modest-ui-actions.c:
3567 (modest_ui_actions_on_password_requested):
3568 Do not store the password in gconf, because this function is called
3569 for non-remembered passwords. Actually use the cached (in the hash map)
3570 password instead of releasing it.
3571 The password will now not be remembered if it is asked via the protected
3572 password dialog, as per the UI spec.
3574 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3576 * src/modest-defs.h:
3577 * src/modest-account-mgr-helpers.h:
3578 * src/modest-account-mgr-helpers.c:
3579 Added modest_server_account_get_username_has_succeeded(),
3580 modest_server_account_set_username_has_succeeded().
3581 (modest_server_account_set_username),
3582 Reset the has-succeeded flag if the username changes.
3584 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3585 * src/maemo/modest-connection-specific-smtp-window.c:
3586 (modest_connection_specific_smtp_window_save_server_accounts):
3587 Use modest_server_account_set_username() instead of using
3588 modest_conf_set_string() directly, so that the has-succeeded flag is always
3591 * src/modest-ui-actions.c:
3592 (modest_ui_actions_on_password_requested): Dim the username entry if
3593 the username has ever worked, as per the UI spec.
3595 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3597 * src/modest-tny-account-store.c: (get_password):
3598 * src/modest-ui-actions.c:
3599 (modest_ui_actions_on_password_requested):
3600 Allow the username to be changed too, though there is more work to
3601 be done on exactly how this behaves.
3603 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3605 * src/modest-account-mgr-helpers.h:
3606 * src/modest-account-mgr-helpers.c:
3607 Added modest_account_mgr_get_display_name(),
3608 modest_server_account_get_username(),
3609 modest_server_account_set_username(),
3610 modest_server_account_set_password(),
3611 modest_server_account_get_hostname() functions so we do not need to
3612 use the conf API directly.
3614 * src/maemo/modest-main-window.c: (connect_signals):
3615 Actually connect ot the ModestAccountStore::request-password signal,
3616 so that we show the dialog when the password is requested by Tinymail,
3617 for isntance if it is empty.
3619 * src/modest-marshal.list:
3620 * src/modest-tny-account-store.c:
3621 (modest_tny_account_store_class_init), (get_password),
3622 (modest_tny_account_store_alert):
3623 * src/modest-tny-account-store.h:
3624 * src/modest-ui-actions.h:
3625 * src/modest-ui-actions.c:
3626 (modest_ui_actions_on_password_requested):
3627 Change the signal parameters, so it is obvious that we are providing
3628 the non human-readable server name, and receiving both the username
3629 and password, though changing of the username is not yet implemented.
3630 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3631 for the GNOME version.
3633 This should fix the projects.maemo.org bug NB#56209, though it does not
3634 work on Bora, because the gconf_client_get() for the password fails
3635 immediately after we save it with gconf_client_set().
3637 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3640 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3641 caused an undefined symbol error:
3642 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3644 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3646 * src/modest-tny-account-store.c:
3647 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3648 using a GError instead of a string message, so we can translate it in
3651 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3653 * src/maemo/modest-address-book.c:
3654 (modest_address_book_check_names):
3655 * src/maemo/modest-msg-view-window.c:
3656 (modest_msg_view_window_clipboard_owner_change):
3657 * src/modest-init.c: (modest_init_init_ui):
3658 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3659 (update_folders_cb), (modest_mail_operation_update_account):
3660 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3661 (modest_ui_actions_on_msg_attachment_clicked),
3662 (modest_ui_actions_on_msg_recpt_activated):
3663 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3664 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3665 (modest_msg_view_search_next):
3666 * src/widgets/modest-recpt-editor.c:
3667 (modest_recpt_editor_on_button_release_event),
3668 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3669 g_message(). At this point we should only be seeing interesting errors on
3670 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3672 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3674 (modest_wizard_dialog_force_title_update):
3675 * src/maemo/easysetup/modest-wizard-dialog.h:
3676 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3677 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3678 can update the title when appropriate. Otherwise the title is wrong if the
3679 pages are added after adding the notebook to the dialog.
3680 This must be a problem in HildonWizardDialog too.
3681 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3683 * src/maemo/easysetup/modest-easysetup-wizard.c:
3684 (create_subsequent_customsetup_pages),
3685 (create_subsequent_easysetup_pages):
3686 Call modest_wizard_dialog_force_title_update() so that the title is
3687 correct even with GTK+ < 2.10.
3688 This fixes projects.maemo.org bug NB#56145 .
3690 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3692 * src/maemo/modest-platform.c:
3693 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3694 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3697 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3699 * src/widgets/modest-window.h:
3700 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3701 and modest_window_save_state(), which invokes it.
3703 * src/widgets/modest-window-mgr.h:
3704 * src/widgets/modest-window-mgr.c:
3705 Added modest_window_mgr_save_state_for_all_windows(), which calls
3706 the save_state vfunc on all registered windows, if implemented.
3708 * src/gnome/modest-msg-edit-window.c:
3709 * src/gnome/modest-msg-view-window.c:
3710 * src/maemo/modest-msg-edit-window.c:
3711 * src/maemo/modest-msg-view-window.c:
3712 * src/maemo/modest-main-window.c:
3713 Specify the existing save_settings functions as implementations of
3714 ModestWindow::save_state_func().
3716 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3717 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3718 enabling hibernation, for instance.
3720 We may need to do the same thing for restoring settings.
3723 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3725 * src/widgets/modest-window-mgr.c:
3726 * src/widgets/modest-window-mgr.h:
3727 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3728 modest_window_mgr_get_hibernation_is_prevented().
3730 * src/maemo/modest-main-window.c:
3731 (on_hildon_program_is_topmost_notify): Prevent hibernation
3732 (possible when the application goes to the background in the WM),
3733 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3735 * src/maemo/easysetup/modest-easysetup-wizard.c:
3736 (modest_easysetup_wizard_dialog_init):
3737 * src/maemo/modest-account-settings-dialog.c:
3738 (modest_account_settings_dialog_init):
3739 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3740 (modest_connection_specific_smtp_edit_window_init):
3741 * src/maemo/modest-connection-specific-smtp-window.c:
3742 (modest_connection_specific_smtp_window_init):
3743 * src/maemo/modest-signature-editor-dialog.c:
3744 (modest_signature_editor_dialog_init):
3745 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3746 prevent hibernation while any of these account settings dialogs are open.
3748 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3750 * src/maemo/Makefile.am:
3751 * src/maemo/modest-osso-state-saving.c:
3752 * src/maemo/modest-osso-state-saving.h: Added
3753 modest_osso_load_state() and modest_osso_save_state() though they do
3754 nothing now. They should iterate through all the open windows and load/save
3756 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3757 save state when closing.
3759 * src/maemo/modest-main-window.c:
3760 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3761 Add a notification handler for the HildonProgram::is-topmost property,
3762 so we can allow hibernation when the application goes into the background.
3763 But we still need to detect when the accounts setup windows are open so
3764 we can stop hibernation when they are open.
3765 To do this, I also added the main window the HildonProgram. This might have
3766 other side-effects/benefits, and should maybe be done for other windows.
3768 * src/maemo/modest-osso-autosave-callbacks.h:
3769 * src/maemo/modest-osso-autosave-callbacks.c:
3770 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3771 though it does not do anything yet, and we might never need this to do
3772 anything. For instance, we already save drafts.
3774 * src/maemo/modest-platform.c: (modest_platform_init):
3775 Specify the libosso auto-save callback.
3777 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3779 * src/maemo/modest-platform.c:
3780 (modest_platform_set_update_interval):
3781 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3782 aparently stays valid between application instances, so we can use this
3783 to remove and reset it later. According to a maemo-developers email from
3786 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3788 * configure.ac: Depend on libalarm for Maemo.
3790 * src/dbus_api/modest-dbus-api.h:
3791 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3792 (on_send_receive), (modest_dbus_req_handler):
3793 Handle a SEND_RECEIVE D-Bus method.
3795 * libmodest-dbus-client/libmodest-dbus-client.c:
3796 (libmodest_dbus_client_send_and_receive):
3797 * libmodest-dbus-client/libmodest-dbus-client.h:
3798 Add C convenience functions for calling the new D-Bus method.
3800 * src/modest-platform.h:
3801 * src/gnome/modest-platform.c:
3802 * src/maemo/modest-platform.c:
3803 Added modest_platform_set_update_interval(), which uses the
3804 alarmd API on Maemo.
3805 (modest_platform_init),
3806 Call modest_platform_set_update_interval(), using a hard-coded
3807 interval for now (until the global settings dialog is implemented),
3808 though I am not sure that this makes sense yet.
3810 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3812 * src/dbus_api/modest-dbus-callbacks.c:
3813 (modest_osso_cb_hw_state_handler):
3814 * src/dbus_api/modest-dbus-callbacks.h:
3815 * src/maemo/modest-platform.c: (modest_platform_init):
3816 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3817 in case this has some effect on the ability for Maemo to ping the
3820 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3822 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3823 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3824 warning. It is probably a logic error, but I need to fix the build.
3826 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3828 * src/modest-account-mgr.h:
3829 * src/modest-account-mgr.c:
3830 (modest_account_mgr_account_names): Add a gboolean enabled_only
3831 parameter, so we can get lists of onlt the enabled accounts.
3833 (modest_account_mgr_add_account),,
3834 (modest_account_mgr_account_with_display_name_exists):
3835 * src/maemo/modest-msg-edit-window.c: (get_transports):
3836 * src/modest-account-mgr-helpers.c:
3837 (modest_account_mgr_set_first_account_as_default):
3838 * src/modest-init.c: (init_default_account_maybe):
3839 * src/modest-tny-account-store.c: (get_accounts):
3840 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3841 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3842 * tests/check_account-mgr.c: (START_TEST):
3843 Provide the extra parameter, as appropriate.
3845 * src/widgets/modest-account-view.c: (update_account_view):
3846 Do not show disabled accounts (meaning that there is no way to
3847 enable/disable accounts in the UI (the feature is not in our UI
3848 specification), so we can use this internally only to mark unfinished
3849 or temporary account data.
3851 * src/maemo/easysetup/modest-easysetup-wizard.c:
3852 (create_account): Add boolean enable parameter, so we can specify FALSE
3853 to create the temporary account.
3854 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3855 (on_before_next): When finishing, when there is a temporary account, just
3857 Also, use a timeout to delay the showing of the dialog until gconf is likely
3858 to return correct information, due to a maemo gconf bug that is fixed in
3859 osso 1.1, but not yet in Bora.
3860 However, the dialog stays on screen after it is destroyed.
3862 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3863 for invalid data when cancelling. Use a hildon note instead of a dialog
3864 to complain about invalid data. Do not show the account-saved note if the
3865 account is disabled (a temporary account that will not really be saved for use
3868 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3870 * src/modest-account-mgr-helpers.h:
3871 * src/modest-account-mgr-helpers.c:
3872 Added modest_account_mgr_unset_default_account(),
3873 Added modest_account_mgr_set_first_account_as_default().
3875 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3876 If it was the default account, unset the default account name.
3878 * src/maemo/modest-account-view-window.c:
3879 (on_delete_button_clicked): If it was the default account,
3880 set the first remaining account as the default instead.
3882 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3883 a NULL account or a NULL default account, to prevent a crash. This should
3884 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3887 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3889 * src/widgets/modest-recpt-editor.c:
3890 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3891 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3892 TODO comment for this. This fixes the build.
3894 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3895 be the best place for it. This will in future update all auto-update accounts,
3896 rather than just the current/default account, when that gconf key exists.
3897 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3898 if there are no accounts, before calling do_send_receive().
3899 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3901 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3902 * src/maemo/modest-main-window-ui.h:
3903 * src/maemo/modest-main-window.c: (on_connection_changed),
3904 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3905 directly, becaue the signal handler does more.
3907 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3909 * src/modest-account-mgr-helpers.c:
3910 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3911 for the case that the account does not exist.
3913 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3914 (equivalent to the modest account name) rather than the tinymail account name
3915 (equivalent to the modest account title - human readable) to get the account data.
3916 Check for null account data to prevent the crash, and add a TODO comment saying that
3917 this needs fixing because it is using the server account name instead of the account name.
3919 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3921 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3922 * src/maemo/modest-account-settings-dialog.c: (show_error),
3924 Use hildon_note_new_information() for informative and error messages,
3925 which seems to be expected for Maemo applications (no documentation that I know of
3926 says this). I am surprised that there is no distinction between info and error
3929 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3931 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3932 it is easy to find where this is used.
3934 * src/maemo/easysetup/modest-easysetup-wizard.c:
3935 (create_page_welcome), (create_page_account_details),
3936 (create_page_user_details), (create_page_complete_easysetup),
3937 (create_page_custom_incoming), (create_page_custom_outgoing),
3938 (create_page_complete_custom):
3939 * src/maemo/modest-account-settings-dialog.c:
3940 (create_page_account_details), (create_page_user_details),
3941 (create_page_incoming), (create_page_outgoing):
3942 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3943 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3944 (modest_connection_specific_smtp_edit_window_init):
3945 * src/maemo/modest-connection-specific-smtp-window.c:
3946 (modest_connection_specific_smtp_window_init):
3947 * src/maemo/modest-signature-editor-dialog.c:
3948 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3949 and scrolling policy as per the Email Application Layout Guide, if I have
3952 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3954 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3955 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3956 which were empty, because these vfuncs have been removed from TnyAccountStore.
3957 This fixes the build.
3959 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3961 * src/maemo/modest-main-window.c:
3962 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3963 showing/hiding it. Added TODO because it probably should not be NULL.
3964 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3965 because unnecessary g_warnings() make degugging difficult.
3967 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3969 * src/maemo/modest-msg-edit-window.c:
3970 (modest_msg_edit_window_select_color),
3971 (modest_msg_edit_window_select_background_color): 2 const corrections and
3972 moving 2 #endifs before closing brackets, to fix the build.
3974 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3976 * src/maemo/easysetup/modest-easysetup-wizard.h:
3977 * src/maemo/easysetup/modest-easysetup-wizard.c:
3978 (modest_easysetup_wizard_dialog_finalize),
3979 (on_button_edit_advanced_settings), (create_page_complete_custom),
3980 (on_response), (create_account):
3981 Implement the Advanced Settings edit button, by saving the account information,
3982 for the Advanded Settings dialog to use directly from gconf, and removing it
3983 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3984 Bug #5533 in the projects.maemo.org bugzilla.
3986 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3988 * src/maemo/modest-msg-view-window.c:
3989 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3990 when opening a message window.
3992 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3994 * src/maemo/easysetup/modest-easysetup-wizard.c:
3995 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3998 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3999 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4000 gconf settings. I probably added more checks than necessary, but that is safer.
4002 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4003 variable to fix the build, but this seems to be used when it is still NULL.
4005 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4007 * src/modest-platform.h:
4008 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4009 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4010 * src/modest-main.c: Implement this function so we can avoid using
4011 maemo-specific API from cross-platform code.
4013 * src/modest-tny-account-store.c:
4014 (get_smtp_specific_transport_account_for_open_connection):
4015 * src/modest-ui-actions.c: (check_for_connection),
4016 (modest_ui_actions_on_item_not_found):
4017 Use modest_platform_connect_and_wait() and put #idefs around other
4018 maemo-specific code, because only maemo currently has a way to
4019 identify connection names.
4021 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4023 * src/modest-tny-account-store.h:
4024 * src/modest-tny-account-store.c:
4025 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4026 the connection-specific SMTP server settings in the configuration.
4028 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4030 * src/maemo/modest-main-window.c: (on_connection_changed),
4032 * src/modest-main.c: (main), (start_ui), (send_mail):
4033 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4034 that is what is intended.
4036 * src/modest-ui-actions.c: (action_send), (action_receive),
4037 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4038 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4039 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4040 SMTP server is used when it is specified.
4042 (modest_ui_actions_on_send_receive):
4043 Check that a connection is open before proceeding.
4044 Receive and then send, instead of vice-versa, as per the specification.
4046 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4048 * src/modest-mail-operation.c:
4049 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4050 though I guess it should be something other than NULL.
4052 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4054 * src/maemo/easysetup/modest-easysetup-wizard.c:
4055 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4056 combo twice, to avoid an g_warning and to make it visible again.
4057 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4058 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4059 (already intended) dereference when detaching, because we then recreate the menu.
4060 But I am not sure why the warning was happening, and it is possible that this is a memory
4063 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4065 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4066 and uri_parse_mailto() utility functions.
4067 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4069 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4071 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4073 * src/dbus_api/modest-dbus-api.h:
4074 * src/dbus_api/modest-dbus-callbacks.c:
4075 Use an idle callback to execute the modest code in the application's own thread.
4076 Remove the helloworld example method.
4077 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4078 parsed, and the open-message method is not implemented because this is not yet implemented in
4080 * libmodest-dbus-client/libmodest-dbus-client.c:
4081 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4082 (libmodest_dbus_client_open_message):
4083 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4085 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4086 body without crashing.
4088 * tests/dbus_api/Makefile.am:
4089 * tests/dbus_api/test_mail_to.c:
4090 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4092 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4094 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4095 Added file to fix the build. Sorry.
4097 * src/dbus_api/Makefile.am:
4098 * src/dbus_api/modest-dbus-api.h:
4099 * src/dbus_api/modest-dbus-callbacks.h:
4100 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4101 (modest_dbus_req_handler):
4102 Put constants in a separate header so it can be reused by the
4103 client library, without duplication
4105 * libmodest-dbus-client/Makefile.am:
4106 * libmodest-dbus-client/libmodest-dbus-client.c:
4107 (libmodest_dbus_client_call_helloworld),
4108 (libmodfest_dbus_client_send_mail),
4109 (libmodfest_dbus_client_mailto),
4110 (libmodfest_dbus_client_open_message):
4111 * libmodest-dbus-client/libmodest-dbus-client.h:
4112 (Partly) Implement a send_mail D-Bus method.
4114 * tests/dbus_api/Makefile.am:
4115 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4116 the send_email D-Bus method.
4118 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4122 * libmodest-dbus-client/Makefile.am:
4123 * libmodest-dbus-client/libmodest-dbus-client.c:
4124 * libmodest-dbus-client/libmodest-dbus-client.h:
4125 * tests/dbus_api/Makefile.am:
4126 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4127 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4129 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4131 * src/maemo/easysetup/modest-easysetup-wizard.c:
4132 (create_page_account_details):
4133 * src/maemo/modest-account-settings-dialog.c:
4134 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4135 widgets, because this might not be the default in future versions of the Maemo GTK+.
4136 However, I can not not get capitalization to work even in a simple test case.
4138 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4140 * src/maemo/easysetup/modest-easysetup-wizard.c:
4141 (create_page_custom_incoming), (create_page_custom_outgoing):
4142 * src/maemo/modest-account-settings-dialog.c:
4143 (create_page_account_details), (create_page_incoming),
4144 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4145 instead of using gtk_check_button_with_label(), so they are aligned like the other
4146 widgets, as per the UI spec.
4148 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4150 * src/maemo/easysetup/modest-easysetup-wizard.c:
4151 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4152 * src/widgets/modest-validating-entry.c:
4153 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4154 Modest prefix instead of an EasySetup prefix.
4156 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4158 * src/widgets/modest-validating-entry.h:
4159 * src/widgets/modest-validating-entry.c: (on_insert_text),
4160 Added easysetup_validating_entry_set_max_func(), used to set a callback
4161 to call when the max number of characters is reached. GtkEntry has a max-length
4162 already but is silent about it.
4164 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4165 (create_page_account_details), (create_page_user_details),
4167 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4168 (create_page_account_details), (create_page_user_details),
4169 (create_page_outgoing):
4170 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4171 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4172 the UI spec, when the user tries to enter more than the max number of characters.
4174 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4176 * src/maemo/easysetup/modest-easysetup-wizard.c:
4177 (create_page_user_details), (create_page_custom_incoming),
4178 (create_page_custom_outgoing):
4179 * src/maemo/modest-account-settings-dialog.c:
4180 (create_page_user_details), (create_page_incoming),
4181 (create_page_outgoing):
4182 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4183 (modest_connection_specific_smtp_edit_window_init):
4184 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4185 not appropriate. Bad Maemo-specific defaults!.
4187 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4189 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4190 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4191 (modest_signature_editor_dialog_set_settings):
4192 Disable the label and textview when the checkbox is disabled, and use the
4193 specified (UI spec) default signature text.
4195 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4197 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4198 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4200 * src/modest-defs.h:
4201 * src/modest-account-mgr-helpers.h:
4202 * src/modest-account-mgr-helpers.c:
4203 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4205 * src/maemo/Makefile.am:
4206 * src/maemo/modest-signature-editor-dialog.c:
4207 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4210 * src/maemo/modest-account-settings-dialog.h:
4211 * src/maemo/modest-account-settings-dialog.c:
4212 (modest_account_settings_dialog_finalize), (on_button_signature),
4213 (save_configuration): Use the new dialog when the Edit button is pressed, and
4214 save the changes if necessary, as per the UI spec.
4216 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4218 * src/maemo/Makefile.am:
4219 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4220 based on maemo-develoers email from Dirk.
4222 * src/maemo/easysetup/modest-easysetup-wizard.c:
4223 (create_page_welcome), (create_page_account_details),
4224 (create_page_user_details), (create_page_complete_easysetup),
4225 (create_page_custom_incoming), (create_page_custom_outgoing),
4226 (create_page_complete_custom),
4227 (modest_easysetup_wizard_dialog_init):
4228 * src/maemo/modest-account-settings-dialog.c:
4229 (create_page_account_details), (create_page_user_details),
4230 (create_page_incoming), (create_page_outgoing),
4231 (modest_account_settings_dialog_init):
4232 * src/maemo/modest-connection-specific-smtp-window.c:
4233 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4235 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4237 * src/maemo/easysetup/modest-easysetup-wizard.c:
4238 (create_page_account_details), (create_page_custom_outgoing),
4239 (create_page_complete_custom):
4240 * src/maemo/modest-account-settings-dialog.c:
4241 (create_page_user_details), (create_page_incoming),
4242 (create_page_outgoing):
4243 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4244 (modest_connection_specific_smtp_edit_window_init):
4245 Use the correct (UI spec) port min/max, and use horizontal separators,
4248 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4250 * src/maemo/easysetup/modest-easysetup-wizard.c:
4251 (set_default_custom_servernames):
4252 * src/maemo/modest-account-settings-dialog.c:
4253 (create_page_incoming), (on_combo_outgoing_security_changed),
4254 (on_combo_incoming_security_changed), (create_page_outgoing),
4255 (modest_account_settings_dialog_set_account_name),
4256 (save_configuration):
4257 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4258 (on_combo_security_changed),
4259 (modest_connection_specific_smtp_edit_window_init),
4260 (modest_connection_specific_smtp_edit_window_set_connection),
4261 (modest_connection_specific_smtp_edit_window_get_settings):
4262 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4265 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4268 * src/maemo/easysetup/modest-easysetup-wizard.c:
4269 (create_page_custom_outgoing), (create_page_complete_custom):
4270 * src/maemo/modest-account-settings-dialog.c:
4271 (create_page_user_details), (create_page_outgoing):
4272 * src/maemo/modest-account-view-window.c: (button_box_new):
4273 Use changed logical IDs as per the most recent UI spec:
4274 mcen_bd_emailsetup_edit -> mcen_bd_edit
4275 mcen_bd_emailsetup_delete -> mcen_bd_delete
4276 mcen_bd_emailsetup_close -> mcen_bd_close
4278 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4282 * src/dbus_api/Makefile.am:
4283 * src/dbus_api/modest-dbus-callbacks.c:
4284 * src/dbus_api/modest-dbus-callbacks.h:
4285 * src/maemo/modest-platform.c: (modest_platform_init):
4286 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4288 * tests/Makefile.am:
4289 * tests/dbus_api/Makefile.am:
4290 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4292 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4294 * src/maemo/modest-account-settings-dialog.c:
4295 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4296 Removed unnecessary includes.
4298 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4300 * src/maemo/easysetup/modest-easysetup-wizard.c:
4301 * src/maemo/modest-account-settings-dialog.c:
4302 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4303 * src/widgets/Makefile.am:
4304 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4305 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4306 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4307 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4308 * src/widgets/modest-secureauth-combo-box.c:
4309 * src/widgets/modest-secureauth-combo-box.h:
4310 * src/widgets/modest-serversecurity-combo-box.c:
4311 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4312 made the GObject names more consistent with the rest of the Modest code.
4314 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4316 * src/maemo/easysetup/Makefile.am:
4317 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4318 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4319 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4320 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4321 * src/maemo/easysetup/modest-easysetup-wizard.c:
4322 * src/maemo/easysetup/modest-validating-entry.c:
4323 * src/maemo/easysetup/modest-validating-entry.h:
4324 * src/maemo/modest-account-settings-dialog.c:
4325 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4326 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4327 widgets/ because they are used outside of easysetup too. After checking in,
4328 svn will allow me to rename them too.
4330 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4332 * src/gnome/modest-msg-edit-window.c:
4333 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4334 linker error, to fix the build on the GNOME platform.
4335 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4336 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4337 ifdefed out to avoid a warning.
4339 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4341 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4342 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4343 some alternative for GTK+ 2.6.
4345 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4347 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4349 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4350 specified for EmailAccountsDialog in UI spec.
4352 * src/maemo/easysetup/modest-easysetup-wizard.c:
4353 * src/maemo/easysetup/modest-easysetup-wizard.h:
4354 * src/maemo/modest-account-settings-dialog.c:
4355 * src/maemo/modest-account-settings-dialog.h:
4356 Reuse a member window widget for the connection-specific SMTP server accounts,
4357 so we can tell it to create/save the accounts only if we actually save changes.
4359 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4360 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4361 (modest_connection_specific_smtp_edit_window_get_settings):
4362 Return a struct instance for temporarily remembering the entered data.
4364 * src/maemo/modest-connection-specific-smtp-window.h:
4365 * src/maemo/modest-connection-specific-smtp-window.c:
4366 (modest_connection_specific_smtp_window_finalize),
4367 (modest_connection_specific_smtp_window_fill_with_connections),
4369 (modest_connection_specific_smtp_window_save_server_accounts),
4370 (update_model_server_names): Do not actually save data until asked,
4371 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4373 (on_selection_changed),
4374 (modest_connection_specific_smtp_window_init): Disable the edit
4375 button when nothing is selected.
4377 * src/modest-account-mgr-helpers.c:
4378 * src/modest-account-mgr-helpers.h:
4379 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4382 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4384 * src/modest-account-mgr-helpers.h:
4385 * src/modest-account-mgr-helpers.c:
4386 (modest_account_mgr_get_unused_account_name),
4387 (modest_account_mgr_get_unused_account_display_name): Added these
4388 utility functions, to avoid code duplication.
4390 * src/maemo/easysetup/modest-easysetup-wizard.c:
4391 (create_page_account_details), (create_account):
4392 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4393 (on_combo_security_changed),
4394 (modest_connection_specific_smtp_edit_window_init),
4395 (modest_connection_specific_smtp_edit_window_save_settings):
4396 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4397 * src/maemo/modest-connection-specific-smtp-window.c:
4398 (modest_connection_specific_smtp_window_finalize),
4399 (modest_connection_specific_smtp_window_fill_with_connections),
4400 (on_button_edit), (modest_connection_specific_smtp_window_init):
4401 * src/maemo/modest-connection-specific-smtp-window.h:
4402 Implementing saving of connection-specific server accounts.
4404 But I need to refactor this so we can save the data for each
4405 possible connection-specific account and only actually create the server accounts
4406 when the easysetup finished, or the OK button is pressed on the account settings
4409 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4411 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4412 (on_combo_security_changed):
4413 (modest_connection_specific_smtp_edit_window_init):
4414 Auto-fill the port number as in the account settings.
4416 (modest_connection_specific_smtp_edit_window_set_connection):
4417 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4418 * src/maemo/modest-connection-specific-smtp-window.c:
4419 (fill_with_connections), (on_button_edit),
4420 (modest_connection_specific_smtp_window_init):
4421 Turn the edit window into a dialog to simplify the code, and
4422 set a WM hint as in a GtkDialog, because only a popup can be on top of
4423 another window in Maemo, and popups usually have no WM decoration.
4425 * src/modest-defs.h:
4426 * src/modest-account-mgr-helpers.c:
4427 (modest_account_mgr_set_connection_specific_smtp),
4428 (modest_account_mgr_remove_connection_specific_smtp),
4429 (modest_account_mgr_get_connection_specific_smtp):
4430 * src/modest-account-mgr-helpers.h: Some functions to write the
4431 connection-specific SMTP server information. Not yet used.
4434 * src/widgets/modest-folder-view.c: (text_cell_data):
4435 Fix a warning about an uninitialized variable.
4436 (on_configuration_key_changed): Put an #ifdef around the use
4437 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4439 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4441 * src/maemo/modest-account-settings-dialog.h:
4442 * src/maemo/modest-account-settings-dialog.c:
4443 Added connect_for_modified() utility function to mark the new modified boolean.
4445 (create_page_account_details), (create_page_user_details),
4446 (create_page_incoming), (create_page_outgoing), (on_response),
4447 (modest_account_settings_dialog_init),
4448 (modest_account_settings_dialog_set_account_name):
4449 Only warn about unsaved changes when there are actually unsaved changes.
4451 * src/modest-account-mgr-helpers.c:
4452 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4453 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4454 to get the data from there in future.
4456 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4458 * src/modest-defs.h:
4460 * src/modest-account-mgr-helpers.h:
4461 * src/modest-account-mgr-helpers.c:
4462 Store the security account setting in a single conf key instead of using
4463 the options list, so that the list is left for just the to-be-removed camel hack,
4464 and because gconf_client_set_list() is failing for some reason.
4466 * src/modest-account-mgr.c:
4467 (modest_account_mgr_add_server_account):
4468 * src/maemo/modest-account-settings-dialog.c:
4469 (modest_account_settings_dialog_set_account_name),
4470 (save_configuration): Use the renamed functions.
4473 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4475 * src/widgets/Makefile.am:
4476 * src/widgets/modest-limit-retrieve-combo-box.c:
4477 * src/widgets/modest-limit-retrieve-combo-box.h:
4478 * src/widgets/modest-retrieve-combo-box.c:
4479 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4480 the account settings dialog.
4482 * src/modest-defs.h:
4483 * src/modest-account-mgr-helpers.h:
4484 * src/modest-account-mgr-helpers.c:
4485 (modest_server_account_get_option_secure_auth),
4486 (modest_server_account_set_option_secure_auth):
4487 * src/modest-account-mgr.c:
4488 (modest_account_mgr_add_server_account):
4489 Use the existing AUTH_MECH conf key for the secure-auth setting,
4490 instead of putting it in the list options, because this was actually used already.
4492 * src/maemo/modest-account-settings-dialog.c:
4493 (create_page_account_details),
4494 (modest_account_settings_dialog_set_account_name),
4495 (save_configuration):
4496 * src/maemo/modest-account-settings-dialog.h:
4497 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4498 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4500 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4502 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4503 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4504 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4506 * src/modest-defs.h:
4507 * src/maemo/modest-account-settings-dialog.c:
4508 (create_page_incoming), (on_combo_outgoing_security_changed),
4509 (on_combo_incoming_security_changed), (create_page_outgoing),
4510 (modest_account_settings_dialog_set_account_name),
4511 (save_configuration): Load/Save the port number, and change it when the
4512 security combo changes, to suitable defaults.
4514 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4516 * src/modest-account-mgr.c:
4517 (modest_account_mgr_add_server_account): Set the security and secure-auth
4518 options, and add a comment saying that the other camel-specific options should be
4521 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4523 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4525 * src/modest-tny-account-store.c: (account_list_free),
4526 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4527 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4530 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4532 * src/modest-protocol-info.c:
4533 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4534 is required by our UI spec. Maybe something in our implementation will use this eventually.
4535 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4536 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4537 instead of the previous 0 placeholder.
4539 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4540 secure-auth settings.
4541 * src/modest-account-mgr-helpers.h:
4542 * src/modest-account-mgr-helpers.c:
4543 (modest_server_account_data_get_option_secure_auth),
4544 (modest_server_account_set_option_secure_auth),
4545 (modest_server_account_data_get_option_security),
4546 (modest_server_account_set_option_security): Added this API for getting and setting the security
4547 and secure-auth settings.
4549 * src/maemo/modest-account-settings-dialog.h:
4550 * src/maemo/modest-account-settings-dialog.c:
4551 (modest_account_settings_dialog_finalize), (check_data),
4552 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4553 about changing titles.
4554 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4555 (save_configuration): Save the security and secure-auth settings.
4557 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4558 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4560 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4562 * src/modest-defs.h:
4563 * src/modest-account-mgr.c:
4564 (modest_account_mgr_add_server_account):
4565 Added and used defines for the options key and value pair strings,
4566 that are used so far, though they do not seem to correspond to anything in our
4567 UI specs or ModestProtocol enum.
4569 * src/modest-account-mgr-helpers.h:
4570 * src/modest-account-mgr-helpers.c:
4571 (compare_option_strings_for_name),
4572 (modest_server_account_data_get_option_value),
4573 (modest_server_account_data_get_option_bool),
4574 (modest_account_mgr_get_server_account_option):
4575 Added helper functions for parsing the options GSList.
4577 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4579 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4580 display name is based on the supplied account name.
4581 * src/modest-account-mgr.c:
4582 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4583 with an inefficient, but good-enough, implementation.
4585 * src/maemo/easysetup/modest-easysetup-wizard.c:
4586 (create_page_account_details), (on_before_next), (create_account):
4587 Check for existing display names rather than (non-user-visible) account names, and just
4588 create and set a unique account name at the end.
4590 * src/maemo/modest-account-settings-dialog.c:
4591 (modest_account_settings_dialog_init),
4592 (modest_account_settings_dialog_set_account_name),
4593 (create_page_incoming): Show the display name, instead of the account name.
4594 (on_response): Do some (not all) extra checks, as in the UI spec.
4595 (save_configuration): Save the display name if it was changed.
4597 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4599 * po/en_GB.po: Added needed logical ID and translation.
4600 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4601 (init_view): Made the is-default column clicking work.
4603 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4606 * src/maemo/easysetup/Makefile.am:
4607 * src/maemo/easysetup/modest-easysetup-wizard.c:
4608 (modest_easysetup_wizard_dialog_init):
4609 * src/maemo/easysetup/provider-data-test.keyfile:
4610 * src/maemo/easysetup/provider-data.keyfile:
4611 Moved the provider data file to the new modest-providers-data package and used it from there.
4613 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4615 * src/modest-local-folder-info.c:
4616 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4617 N_() was already used on the static strings, but this just marks it for translation without
4618 using the translation.
4620 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4622 * src/maemo/modest-account-settings-dialog.c:
4623 (create_page_incoming),
4624 (modest_account_settings_dialog_set_account_name):
4625 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4626 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4627 I will do this if nobody else gets there first.
4629 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4631 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4632 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4633 save the security stuff.
4635 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4637 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4638 Set the email address and user fullname, which I now see must be
4641 * src/maemo/modest-account-settings-dialog.h:
4642 * src/maemo/modest-account-settings-dialog.c:
4644 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4645 leave-on-server and authentication.
4646 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4649 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4652 * src/maemo/modest-account-settings-dialog.c:
4653 * src/maemo/modest-account-settings-dialog.h:
4654 Most (but not all) of the widgets are now present as specified by the UI spec.
4655 No changes are yet saved, and some details are not properly shown yet.
4657 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4659 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4661 * src/maemo/Makefile.am:
4662 * src/maemo/modest-account-settings-dialog.c:
4663 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4664 an existing account. Doesn't do much yet.
4666 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4667 Open the accounts settings dialog when Edit is clicked.
4669 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4671 * src/maemo/easysetup/Makefile.am:
4672 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4674 * src/maemo/easysetup/modest-easysetup-wizard.c:
4675 (modest_easysetup_wizard_dialog_init):
4676 Try to get the source directory from the build system,
4677 instead of hard-coding "./" into the source code, when opening our local
4678 copies of the configuration files.
4679 But this still fails when opening the wizard from the Accounts window,
4680 maybe because the working directory seems to change at runtime.
4681 So the wizard will fail the second time unless you copy the files into their
4682 proper locations - see the stdout warnings for the paths.
4684 (create_page_account_details),(on_before_next):
4685 Check for existing non-server accounts instead of server accounts,
4686 so the default account name is useful again, and to prevent trying to
4689 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4690 Show the wizard when New is clicked.
4692 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4693 (init_view): Show the column headers, and show the columns that are
4694 specified in the UI specs. However, something in Maemo's GTK+ prevents
4695 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4696 change the default account. This is despite unsetting the special properties.
4698 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4700 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4701 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4702 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4703 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4704 to make that clearer.
4705 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4707 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4709 * src/maemo/modest-account-view-window.c:
4710 (modest_account_view_window_init),
4711 (modest_account_view_window_new):
4712 Use the same buttons as specified in the
4713 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4714 the existing widgets, which never had a chance of working.
4715 Put the ModestAccountView treeview in a scrolled window.
4716 Do not repeat the initialization in both _init() and _new().
4718 * src/widgets/modest-account-view.c: (update_account_view):
4719 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4720 this widget and window shows no accounts.
4722 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4724 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4726 * src/maemo/easysetup/modest-easysetup-wizard.c:
4727 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4728 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4729 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4732 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4733 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4734 accounts exist yet, as in the UI spec.
4736 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4738 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4740 * src/maemo/Makefile.am:
4741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4742 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4743 New window for editing connection-specific smtp details.
4744 Not fully implemented.
4746 * src/maemo/modest-connection-specific-smtp-window.c:
4747 (modest_connection_specific_smtp_window_finalize) :
4748 unref the tree model.
4749 (on_button_edit): Show the edit window.
4751 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4753 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4756 * src/maemo/Makefile.am:
4757 * src/maemo/modest-connection-specific-smtp-window.c:
4758 * src/maemo/modest-connection-specific-smtp-window.h:
4759 New window for showing the list of connections, for connection-specific
4760 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4761 * src/maemo/easysetup/modest-easysetup-wizard.c:
4762 (create_page_custom_outgoing): Show the new window when the button is clicked.
4764 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4766 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4767 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4768 * src/maemo/modest-msg-edit-window.c:
4769 (modest_msg_edit_window_insert_image):
4770 * src/modest-conf.c: (modest_conf_key_escape):
4771 * src/modest-mail-operation.c:
4772 (modest_mail_operation_send_new_mail):
4773 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4774 (modest_ui_actions_on_new_account):
4775 * src/widgets/modest-attachment-view.c: (update_filename_request):
4776 * src/widgets/modest-mail-header-view.c:
4777 Corrected warnings that were breaking the build, by commenting out unused variables,
4778 and a function, and by including a header.
4780 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4782 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4783 so we can #ifdef around platform-specific code when necessary.
4784 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4785 to allow this to build for the GNOME platform too.
4787 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4789 * src/maemo/easysetup/modest-easysetup-wizard.c:
4790 Added util_increment_name() and used it in create_page_account_details()
4791 to make sure that the default account name is always a new name.
4793 (modest_easysetup_wizard_dialog_init),
4794 (set_default_custom_servernames): Some minor memory management fixes.
4796 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4800 * src/modest-runtime.c: (init_i18n): Restored the translation
4801 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4802 are defined in config.h, and the translations are installed.
4804 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4805 is defined for translation.
4807 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4809 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4811 * src/maemo/easysetup/modest-easysetup-wizard.c:
4812 (modest_easysetup_wizard_dialog_init):
4813 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4814 Use realistic paths (though they should use $prefix generically) to the
4815 mcc_mapping and provider-data.keyfile files which might work when they
4816 are installed by the future version of the operator-wizard package,
4817 and then fallback to paths in our source code, with an explanatory
4820 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4824 * src/maemo/Makefile.am:
4825 * src/maemo/easysetup/: Added files from the previously-exernal
4826 osso-modest-easysetup.
4827 * src/maemo/modest-main-window-ui.h:
4828 * src/modest-ui-actions.c:
4829 * src/modest-ui-actions.h:
4830 Added modest_ui_actions_on_new_account() as a signal handler for the
4831 New Account menu item. It shows the easysetup wizard.
4832 * po/en_GB.po: Added additional needed logical IDs and translations.