1 2007-06-01 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-retrieve-combo-box.c:
4 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
5 This fixes projects.maemo.org bug NB#58472 .
7 2007-06-01 Murray Cumming <murrayc@murrayc.com>
9 * src/maemo/easysetup/modest-easysetup-wizard.c:
10 (create_page_complete_easysetup):
11 (create_page_complete_custom): Correct the last commit,
12 putting the correct sentences in the correct pages.
14 2007-06-01 Murray Cumming <murrayc@murrayc.com>
16 * src/maemo/easysetup/modest-easysetup-wizard.c:
17 (create_page_complete_custom): Show the second sentence of text
18 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
21 2007-06-01 Murray Cumming <murrayc@murrayc.com>
23 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
24 Set the leave-on-server conf key by default. This fixes
25 projects.maemo.org bug NB#59258 .
27 2007-06-01 Murray Cumming <murrayc@murrayc.com>
29 * src/maemo/modest-account-view-window.c:
30 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
31 logical ID for the confirmation messages. Fixed projects.maemo.org bug
34 2007-06-01 Murray Cumming <murrayc@murrayc.com>
36 * src/maemo/easysetup/modest-easysetup-wizard.c:
37 (create_caption_new_with_asterisk):
38 * src/maemo/modest-account-settings-dialog.c:
39 (create_caption_new_with_asterisk):
40 Uncomment the code to add the asterisk, because they are no longer in the
41 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
42 (update_incoming_server_title): Add an asterisk here too.
44 2007-06-01 Murray Cumming <murrayc@murrayc.com>
46 * src/maemo/modest-maemo-global-settings-dialog.c:
47 (current_connection): Check that we are even connected before trying to
48 get the current connection name, to prevent a warning.
50 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
51 Change the comments because tny_maemo_conic_device_connect() is now meant to
53 * src/modest-mail-operation.c:
54 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
55 make sure we have a connection and fail if we can't connect.
57 2007-05-31 Murray Cumming <murrayc@murrayc.com>
59 * src/maemo/modest-main-window.c:
60 (on_account_store_connecting_finished): Do not try to get the
61 connection ID if we are not really connected. I am surprised that
62 this signal handler is called when we are not connected.
64 2007-05-31 Murray Cumming <murrayc@murrayc.com>
67 * src/modest-ui-actions.c:
68 (modest_ui_actions_get_msgs_full_error_handler):
69 Renamed an enum, added comments, added an enum
70 for retrieve-limit errors.
72 * src/modest-mail-operation.c: (foreach_add_item),
73 (internal_folder_observer_update), (update_account_thread),
74 (modest_mail_operation_get_msgs_full):
75 (modest_mail_operation_update_account),
76 Added comments about how this works, and some code that should
77 (but does not) check the retrieve-limit. See the TODO comment.
79 2007-05-31 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
82 Initialize help_id to fix the build. Warnings are good.
84 2007-05-31 Murray Cumming <murrayc@murrayc.com>
86 * src/widgets/modest-hbox-cell-renderer.c:
87 (modest_hbox_cell_renderer_append):
88 * src/widgets/modest-vbox-cell-renderer.c:
89 (modest_vbox_cell_renderer_append):
90 Fix the last commit by doing an extra ref.
92 2007-05-31 Murray Cumming <murrayc@murrayc.com>
94 * src/widgets/modest-hbox-cell-renderer.c:
95 (modest_hbox_cell_renderer_append):
96 * src/widgets/modest-vbox-cell-renderer.c:
97 (modest_vbox_cell_renderer_append):
98 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
99 to fix the build with Maemo Bora.
100 However, there seems to be a remaining crash, probably due to reference
103 2007-05-30 Murray Cumming <murrayc@murrayc.com>
105 * src/modest-tny-account.c:
106 (modest_tny_account_new_for_local_folders):
107 Use hildon_file_system_info_async_new() to get a better name for
108 the memory card account, setting it as the account name.
109 The timing seems to work, but this is probably
110 not the best place to do this. See the TODO comment.
111 * src/maemo/modest-main-window.c: (create_details_widget):
112 * src/widgets/modest-folder-view.c: (text_cell_data):
113 Use the tny account name instead of hardcoding a name.
115 2007-05-30 Christian Kellner <ckellner@openismus.com>
117 * src/modest-search.c: (modest_search):
118 Correctly set part_search_func even if we have already parsed
119 the query and thus a valid OgsTextSearcher object.
121 2007-05-30 Christian Kellner <ckellner@openismus.com>
124 Search and check for libogs.
127 Incooparte the ogs build env.
129 * src/modest-mime-part-search-stream.c:
130 * src/modest-mime-part-search-stream.h:
131 Removed since we do the real searching now in modest-search.c.
133 * src/modest-search.c:
134 * src/modest-search.h:
135 Implement support for ogs. We use that if available and requested
136 and fall back to modest_text_utils_utf8_strcmp (). The search logic
137 should now handle the corner case when the search term is spread
138 across multiple reads.
139 Also the logic in modest_search () was corrected to search all
140 requested fields until one is found.
142 2007-05-30 Murray Cumming <murrayc@murrayc.com>
144 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
147 * src/modest-init.c: Made modest_init_local_folders() take a
148 path and be public so we can iniitialize maildir folders on
151 * src/modest-local-folder-info.h:
152 * src/modest-local-folder-info.c:
153 (modest_local_folder_info_get_maildir_path): Add a path parameter.
155 * src/modest-tny-account.c:
156 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
157 still means the standard local-folders path on the local volume.
159 * src/modest-tny-account-store.c:
160 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
161 signal so we can detect mount/unmount of the MMC1 card, and do an update of
162 all accounts when that happens.
163 (get_server_accounts): If the MMC1 card is mounted, create a store account for
164 this too, so it shows up in the treeview.
166 2007-05-28 Murray Cumming <murrayc@murrayc.com>
168 * src/maemo/modest-maemo-global-settings-dialog.c:
169 (current_connection):
170 * src/widgets/modest-global-settings-dialog.c:
171 (current_connection_default):
172 Use the enum values instead of 0, 1 and -1,
173 to make the code clearer.
175 * src/modest-account-mgr-helpers.c:
176 (modest_account_mgr_get_connection_specific_smtp): Make this code
179 * src/modest-runtime.h:
180 * src/modest-runtime.c:
181 Added modest_runtime_remove_all_send_queues().
182 * src/maemo/modest-main-window.c:
183 (on_account_store_connecting_finished): Recreate the send queues,
184 using the appropriate transport accounts for this new connection.
185 Some futher adapting might be needed if the old send queues are not
186 automatically stopped at this point.
188 * src/modest-tny-account-store.c: (get_server_accounts):
189 Create the connection-specific transport accounts, so that they can
190 be found later by their ID.
192 * src/modest-tny-account.h:
193 * src/modest-tny-account.c:
194 Added modest_tny_account_new_from_server_account_name().
195 modest_tny_account_new_from_server_account(): Do not create the
196 send queues here, because they will be
197 recreated anyway when the connection changes for the first time.
199 2007-05-28 Murray Cumming <murrayc@murrayc.com>
201 * src/modest-local-folder-info.h:
202 * src/modest-local-folder-info.c:
203 (modest_per_account_local_outbox_folder_info_get_maildir_path),
204 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
205 tbox_folder): Take a modest account name instead of a server TnyAccount,
206 so we can have per-modest-account rather than per-transport-account
208 We must make sure that we change or recreate the exisitng send queues
209 when the connection changes for connection-specific transport accounts.
211 * src/modest-tny-account-store.c:
212 (create_per_account_local_outbox_folders): Create outboxed per modest
213 account, not per transport account.
215 * src/modest-tny-account.h:
216 * src/modest-tny-account.c:
217 (modest_tny_account_get_special_folder): For outboxes, get the
218 parent modest account name. The account is ignored for other folders.
219 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
220 modest account name rather than a server TnyAccount.
222 2007-05-25 Murray Cumming <murrayc@murrayc.com>
224 * src/modest-tny-account.c:
225 (modest_tny_account_new_from_server_account):
226 Call modest_runtime_get_send_queue() immediately after creating transport
227 accounts, so that they start trying to send email from the outbox as soon
228 as possible at startup. This is probably what we want.
230 * src/modest-mail-operation.c: (update_account_thread):
231 * src/modest-runtime.c: (modest_runtime_get_send_queue):
232 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
233 * src/modest-tny-send-queue.h:
234 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
235 (modest_ui_actions_on_send):
236 Added comments about how sending works, though it needs some more work.
238 2007-05-25 Murray Cumming <murrayc@murrayc.com>
240 * src/modest-tny-account.c:
241 (modest_tny_account_get_special_folder): Add TODO because this fails when
243 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
244 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
245 Do not try to show this window when there is no active account. The UI
246 specs does not tell us what to do in this case.
248 2007-05-24 Murray Cumming <murrayc@murrayc.com>
252 * src/maemo/Makefile.am:
253 * src/widgets/Makefile.am: Some dist fixes.
255 2007-05-24 Murray Cumming <murrayc@murrayc.com>
257 * src/maemo/modest-connection-specific-smtp-window.c:
258 (on_button_edit): Make the code clearer, to prevent a double free.
260 2007-05-24 Murray Cumming <murrayc@murrayc.com>
262 * src/maemo/modest-account-settings-dialog.c:
263 (modest_account_settings_dialog_set_account_name),
264 Check the connection-specific smtp servers checkbox if there are any.
266 * src/maemo/modest-connection-specific-smtp-edit-window.c:
267 (modest_connection_specific_smtp_edit_window_init):
268 Start with a suitable port number.
270 * src/modest-account-mgr-helpers.h:
271 * src/modest-account-mgr-helpers.c: Added
272 modest_account_mgr_get_has_connection_specific_smtp().
274 (modest_account_mgr_set_connection_specific_smtp),
275 (modest_account_mgr_remove_connection_specific_smtp),
276 (modest_account_mgr_get_has_connection_specific_smtp),
277 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
278 connection-specific smtp server accounts in the account, rather than
279 the server account conf dir.
281 This fixes bug projects.maemo.org bug NB#58263 .
283 * src/modest-tny-account-store.c:
284 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
285 if there are no server accounts yet, to prevent an infinite loop when there
286 are no accounts. Document that one must be called before the other.
288 2007-05-24 Murray Cumming <murrayc@murrayc.com>
290 * src/modest-account-mgr-helpers.c:
291 (modest_account_mgr_get_default_account): Make sure that at least
292 one account is always the default, if there are any enabled accounts.
293 This is just a sanity check that shouldn't be necessary.
295 * src/modest-account-mgr-priv.c:
296 (_modest_account_mgr_account_from_key): Unescape the conf key to
297 get the real account name. For instance, this is an issue if a space
298 was in the account name, which can happen because the account name
299 is generated from the display name.
300 (_modest_account_mgr_get_account_keyname): Always escape the
302 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
303 Unescape the conf keys to get the real account names.
305 For instance, previously the is-default radio button in the accounts
306 list was not checked for any accounts at first. This fixes that,
307 and might fix several similar bugs.
309 2007-05-23 Murray Cumming <murrayc@murrayc.com>
311 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
312 Removed some debug printfs.
314 2007-05-23 Murray Cumming <murrayc@murrayc.com>
316 Modest on-disk outbox directories are now here, for instance:
317 $HOME/.modest/outboxes/<account-id-1>/outbox
318 $HOME/.modest/outboxes/<account-id-2>/outbox
320 $HOME/.modest/local-folders/outbox
321 so we can have a separate outbox for each account.
322 But they are shown as one outbox in the GtkTreeView, by using a
323 TnyMergeFolder in a ModestTnySimpleFolderStore.
326 * src/modest-tny-simple-folder-store.c:
327 * src/modest-tny-simple-folder-store.h:
328 Added ModestTnySimpleFolderStore, used to contain folders from
329 other folder stores, such as other accounts.
331 * src/modest-tny-outbox-account.h:
332 * src/modest-tny-outbox-account.c:
333 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
334 used for the per-account local outbox folders.
336 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
337 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
338 only use this (internally) now for the non-outbox local folders.
341 * src/modest-init.c: Added modest_init_one_local_folder(), for
342 setting up the directory structure for each local folder.
344 * src/modest-local-folder-info.c:
345 (modest_per_account_local_outbox_folder_info_get_maildir_path),
346 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
348 * src/modest-local-folder-info.h:
349 * src/modest-tny-account-store.c: (on_account_removed),
350 (on_account_changed), (create_per_account_local_outbox_folders),
351 (get_server_accounts), (modest_tny_account_store_get_accounts),
352 (modest_tny_account_store_get_tny_account_by_account),
353 (modest_tny_folder_store_is_virtual_local_folders):
355 * src/modest-tny-account.h:
356 * src/modest-tny-account.c:
357 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
358 to create an on-disk per-account local outbox folder for each
360 (create_per_account_local_outbox_folders): Create a local outbox folder
361 for each transport account.
362 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
363 for all local folders.
365 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
366 instead of using g_object_get/set() directly. It is clearer.
368 (modest_tny_folder_store_get_message_count),
369 (modest_tny_folder_store_get_local_size
370 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
371 because we now use these with non-acount folder stores.
373 (modest_tny_account_get_special_folder),
374 (modest_tny_account_new_from_server_account),
375 (modest_tny_account_new_from_account):
376 (recurse_folders): Adjust to the new outbox system.
378 * src/modest-tny-folder.h:
379 * src/modest-tny-folder.c:
380 (modest_tny_folder_is_local_folder),
381 (modest_tny_folder_get_local_folder_type),
382 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
384 * src/widgets/modest-main-window.h:
385 * src/maemo/modest-main-window.c: (create_details_widget),
386 (modest_main_window_set_contents_style): Show details for any folder store,
389 (modest_tny_folder_get_rules):
390 Remove the const. C does not support constness enough for this.
392 * src/modest-ui-actions.c:
393 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
394 make all outboxes appear as one, in the usual local-folders tree node.
396 (set_active_account_from_tny_account),
397 (modest_ui_actions_on_folder_selection_changed):
398 * src/widgets/modest-folder-view.c: (text_cell_data),
399 (icon_cell_data), (filter_row),
400 (add_account_folders_to_merged_folder),
401 (add_account_folders_to_simple_folder_store), (),
402 (get_cmp_rows_type_pos), (cmp_rows),
403 (modest_folder_view_set_account_id_of_visible_server_account):
404 Adjust to the new outbox system, using generic folder stores and folders
407 2007-05-23 Christian Kellner <ckellner@openismus.com>
409 * src/modest-mail-operation.c:
410 (modest_mail_operation_update_account):
411 Use info->max_size instead of unintialized local var [small
412 build fix]. (Added TODO to review that change since I don't
415 2007-05-23 Marcus Bauer <marcusb@openismus.com>
417 * libmodest-dbus-client/libmodest-dbus-client.c:
418 (libmodest_dbus_client_compose_mail): function added
419 * src/dbus_api/modest-dbus-api.h:
420 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
421 (on_compose_mail): Implementation of the SendAsMail functionality
423 2007-05-22 Murray Cumming <murrayc@murrayc.com>
425 * src/modest-account-mgr.c:
426 (modest_account_mgr_add_server_account): Set the secure-connection
427 conf key for transport accounts as well as store accounts. I don't know
428 why the if was there. For instance, this makes sure that we use SSL
429 for the gmail preset from the easysetup wizard.
431 2007-05-22 Murray Cumming <murrayc@murrayc.com>
433 * src/gnome/modest-main-window.c:
434 (on_account_store_connecting_finished), (connect_signals):
435 * src/maemo/modest-main-window.c:
436 (on_account_store_connecting_finished), (connect_signals),
437 (modest_main_window_new):
438 Handle TnyAccountStore::connecting-finished instead of
439 TnyDevice::connection-changed, because we cannot actually perform
440 operations on accounts until TnyAccountStore has itself responded to
441 the TnyDevice::connection-changed signal. This prevents a GError from
443 Do not try to update at startup, because we (at least on scratchbox)
444 already do an update at startup when the device goes online.
445 This prevents a GError from tinymail.
446 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
447 Added TODO about stopping simultaneous operations.
449 2007-05-21 Murray Cumming <murrayc@murrayc.com>
451 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
452 * src/modest-mail-operation-queue.c:
453 (modest_mail_operation_queue_remove):
454 * src/modest-tny-account-store.c: When GErrors happen, give more clues
455 about where they happened.
457 2007-05-21 Murray Cumming <murrayc@murrayc.com>
459 * src/modest-ui-actions.c:
460 (modest_ui_actions_on_password_requested): Make sure that the remember
461 output parameter is always TRUE.
463 2007-05-21 Murray Cumming <murrayc@murrayc.com>
465 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
466 Show a OK/Cancel dialog if the error is a question, though we still do not
467 know anything more about what we are asking the user.
468 * src/widgets/modest-folder-view.c: (on_drag_data_received):
469 Fix an uninitialized variable (helper). This is a logic error, however.
471 2007-05-21 Christian Kellner <ckellner@openismus.com>
473 * src/modest-search.h:
474 Correct bit shifting in the ModestSearchFlags enum.
476 2007-05-21 Murray Cumming <murrayc@murrayc.com>
478 * src/modest-tny-account.c:
479 (modest_tny_account_new_from_server_account): Do not use the lsub and
480 check-all hard-coded IMAP options when using POP.
482 2007-05-21 Murray Cumming <murrayc@murrayc.com>
484 * src/modest-tny-account.c:
485 (modest_tny_account_new_from_server_account):
486 Use NULL for the secure-auth method for POP when Password auth has been
487 specified by the user, as we already do for IMAP. "auth=Login" causes
488 an error from camel or the server.
490 2007-05-17 Murray Cumming <murrayc@murrayc.com>
492 * src/maemo/modest-account-settings-dialog.c:
493 (create_page_account_details),
494 (modest_account_settings_dialog_set_account_name):
495 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
496 for the leave-on-server checkbox, rathr than just the checkbox, when
497 the protocol is not POP.
499 2007-05-17 Murray Cumming <murrayc@murrayc.com>
501 * src/widgets/modest-account-view.c:
502 * src/widgets/modest-account-view.h:
503 Added modest_account_view_select_account() which will be useful later
504 to asynchronously re-select the edited account.
506 2007-05-17 Murray Cumming <murrayc@murrayc.com>
508 * src/maemo/modest-account-settings-dialog.c:
509 (modest_account_settings_dialog_set_account_name):
510 Automatically choose the port numbers based on the secure authentication
511 methods, if they have not been chosen before.
512 This fixes projects.maemo.org bug NB#56273 .
514 2007-05-17 Murray Cumming <murrayc@murrayc.com>
516 * src/maemo/modest-main-window-ui.h:
517 * src/modest-ui-actions.c:
518 * src/modest-ui-actions.h:
519 Connect the Tools/SMTP Servers menu item to
520 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
521 SMTP servers dialog, as in the UI specification and saves changes when it
522 is closed. This fixed projects.maemo.org bug NB#56305 .
524 2007-05-17 Murray Cumming <murrayc@murrayc.com>
526 * src/maemo/modest-connection-specific-smtp-window.c:
527 (modest_connection_specific_smtp_window_init):
528 Use gtk_window_set_default_size() to make this window big enough, so
529 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
531 2007-05-17 Murray Cumming <murrayc@murrayc.com>
533 * src/maemo/modest-connection-specific-smtp-edit-window.h:
534 * src/maemo/modest-connection-specific-smtp-edit-window.c:
535 (modest_connection_specific_smtp_edit_window_init),
536 Do not try to connect to a combobox signal before the combobox exists.
537 This fixes the cras in projects.maemo.org bug NB#56288 .
538 (modest_connection_specific_smtp_edit_window_get_settings):
539 Remove the server_account_name parameter which was being checked for NULL
540 though it was not used.
542 * src/maemo/modest-connection-specific-smtp-window.c:
543 (modest_connection_specific_smtp_window_fill_with_connections),
544 (on_button_edit), (modest_connection_specific_smtp_window_init):
545 Correct the number of treemodel columns to prevent a warning.
546 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
547 libconic does not work.
549 2007-05-16 Murray Cumming <murrayc@murrayc.com>
551 * src/modest-tny-account.c:
552 (modest_tny_account_new_from_server_account):
553 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
554 SMTP when "None" was chosen by the user. However, with my SMTP server that
555 does not support ANONYMOUS, the emails do not leave the Outbox and I see
558 2007-05-16 Murray Cumming <murrayc@murrayc.com>
560 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
561 to explain the memory management issue with the ID in the ModestPair.
563 * src/gnome/modest-account-assistant.c: (add_receiving_page),
564 (add_sending_page), (modest_account_assistant_finalize):
565 * src/gnome/modest-gnome-global-settings-dialog.c:
566 (create_updating_page), (create_composing_page):
567 * src/gnome/modest-msg-edit-window.c: (get_transports),
568 (init_window), (modest_msg_edit_window_finalize),
569 (modest_msg_edit_window_get_msg_data):
570 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
571 * src/gnome/modest-transport-widget.c:
572 (modest_transport_widget_finalize), (smtp_configuration):
573 * src/maemo/modest-maemo-global-settings-dialog.c:
574 (create_updating_page), (create_composing_page):
575 * src/maemo/modest-msg-edit-window.c: (get_transports),
576 (init_window), (modest_msg_edit_window_finalize),
577 (modest_msg_edit_window_get_msg_data),
578 (modest_msg_edit_window_free_msg_data):
579 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
580 (modest_store_widget_finalize):
581 * src/maemo/modest-transport-widget.c:
582 (modest_transport_widget_finalize), (smtp_configuration):
583 * src/modest-main.c: (send_mail):
584 * src/widgets/modest-combo-box.h:
585 * src/widgets/modest-global-settings-dialog-priv.h:
586 * src/widgets/modest-global-settings-dialog.c:
587 (modest_global_settings_dialog_finalize):
588 * src/widgets/modest-msg-edit-window.h:
589 Whenever using modest_combo_box_new(), keep the ModestPairList alive
590 as long as the combo box, to prevent use of freed memory for the ID.
592 2007-05-15 Murray Cumming <murrayc@murrayc.com>
594 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
595 get_accounts(), to make this clearer. Do not check for the enabled gconf
596 key, because we do not use this for server accounts (at least, not yet).
597 This allows us to send email again.
599 2007-05-15 Murray Cumming <murrayc@murrayc.com>
601 * src/maemo/modest-platform.c:
602 (on_modest_conf_update_interval_changed), (modest_platform_init):
603 Only respond to this particular key change. All these strcmp()s cannot be
606 2007-05-15 Murray Cumming <murrayc@murrayc.com>
608 * src/maemo/modest-maemo-global-settings-dialog.c:
609 (current_connection): Prevent a crash in scratchbox when
610 ny_maemo_conic_device_get_current_iap_id() returns NULL.
611 * src/maemo/modest-platform.c:
612 (on_modest_conf_update_interval_changed), (modest_platform_init):
613 Get the update interval from gconf and reset it when the gconf key changes.
615 2007-05-15 Murray Cumming <murrayc@murrayc.com>
617 * src/modest-protocol-info.c:
618 * src/modest-protocol-info.h: Adde enum-specific get functions,
619 instead of using a ModestProtocolType enum parameter.
621 * src/gnome/modest-account-assistant.c:
622 * src/gnome/modest-store-widget.c:
623 * src/gnome/modest-store-widget.h:
624 * src/gnome/modest-transport-widget.c:
625 * src/gnome/modest-transport-widget.h:
626 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
627 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
628 * src/maemo/easysetup/modest-easysetup-wizard.c:
629 * src/maemo/modest-account-settings-dialog.c:
630 * src/maemo/modest-account-settings-dialog.h:
631 * src/maemo/modest-store-widget.c:
632 * src/maemo/modest-store-widget.h:
633 * src/maemo/modest-transport-widget.c:
634 * src/maemo/modest-transport-widget.h:
635 * src/modest-account-mgr-helpers.c:
636 * src/modest-account-mgr-helpers.h:
637 * src/modest-account-mgr.c:
638 * src/modest-account-mgr.h:
639 * src/modest-tny-account.c:
640 * src/modest-tny-folder.c:
641 * src/widgets/modest-account-view.c:
642 * src/widgets/modest-retrieve-combo-box.c:
643 * src/widgets/modest-retrieve-combo-box.h:
644 * src/widgets/modest-secureauth-combo-box.c:
645 * src/widgets/modest-serversecurity-combo-box.c:
646 * src/widgets/modest-serversecurity-combo-box.h:
647 * tests/check_account-mgr.c:
648 Use the specific functions, and use the re-renamed enum values for GNOME too.
650 2007-05-15 Murray Cumming <murrayc@murrayc.com>
653 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
654 so we can get the second based on the first.
656 * src/maemo/modest-account-settings-dialog.h:
657 * src/maemo/modest-account-settings-dialog.c:
658 Added get_supported_secure_authentication_methods(), though it is mostly
659 commented-out for now until the necessary API is committed to tinymail.
660 (modest_account_settings_dialog_set_account_name),
661 (save_configuration): Request the supported authentication methods from the
662 server, so we can choose a working method.
664 * src/modest-tny-account-store.h:
665 * src/modest-tny-account-store.c:
666 (modest_tny_account_store_get_session): Rename from
667 tny_account_store_get_session().
669 2007-05-14 Murray Cumming <murrayc@murrayc.com>
671 * src/modest-protocol-info.h: Split the ModestProtocol enum
672 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
673 There was no need to have these unrelated values in one enum.
675 * src/: many files: Adapted to changed enum. This makes the code a bit
676 clearer, and the compiler could catch some errors.
678 2007-05-14 Murray Cumming <murrayc@murrayc.com>
680 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
681 Show the detailed internal camel error message when an error happens
682 during the configuration, so that our testers can give us more clues.
683 For instance, in projects.maemo.org bug NB#56910 .
685 2007-05-14 Murray Cumming <murrayc@murrayc.com>
687 * src/modest-tny-account.c:
688 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
689 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
691 2007-05-14 Murray Cumming <murrayc@murrayc.com>
693 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
694 * src/maemo/modest-account-settings-dialog.c:
695 (modest_account_settings_dialog_set_account_name),
696 (save_configuration): For the incoming secure authentication checkbox,
697 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
698 the UI specification. PLAIN does not seem to be supported for most IMAP
699 servers anyway, and I am not sure what it would mean.
700 However, we probably need to discover which of the secure-authentication
701 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
702 * src/modest-account-mgr-helpers.c:
703 (modest_account_mgr_get_server_account_data):
705 * src/modest-tny-account.c:
706 (modest_tny_account_new_from_server_account):
707 Use tny_account_set_mech() to set secure-authentication methods,
708 with some special-casing for IMAP, based on my observations of how
711 * src/modest-account-mgr-helpers.h:
712 * src/modest-account-mgr.c:
713 * src/modest-defs.h: Comment that the URI is only used for local folders.
715 2007-05-11 Murray Cumming <murrayc@murrayc.com>
717 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
718 parameter const, just to be neat.
719 * src/modest-text-utils.c: (modest_text_utils_inline):
720 End g_strconcat() with NULL, as its documentation says. This is almost
721 certainly the cause of my crash at startup on the device. Interestingly,
722 valgrind doesn't tell us about these errors.
724 2007-05-11 Murray Cumming <murrayc@murrayc.com>
726 * scripts/build-packages: Added more precise comments about how to use
727 this script, though I still get this error:
728 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
729 error building tinymail
731 2007-05-11 Murray Cumming <murrayc@murrayc.com>
733 * src/maemo/modest-main-window.c: (on_account_update):
734 Very slight cleanup, hoping to make it simpler to discover what causes
735 a crash here sometimes.
737 * src/modest-tny-account.c:
738 (modest_tny_account_new_from_server_account): Set the port. Added
739 comments about the options and a TODO comment because I need to find out
740 how to specify the secure authentication method.
742 2007-05-11 Marcus Bauer <marcusb@openismus.com>
744 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
745 changed CFlags paths form modest to libmodest
747 2007-05-10 Murray Cumming <murrayc@murrayc.com>
749 * src/modest-account-mgr-helpers.c:
750 (modest_account_mgr_get_server_account_data),
751 (modest_account_mgr_free_server_account_data):
752 * src/modest-account-mgr-helpers.h:
753 * src/modest-account-mgr.c:
754 (modest_account_mgr_add_server_account):
756 * src/modest-tny-account.c:
757 (modest_tny_account_new_from_server_account):
758 Determine the options for tny_camel_account_add_option() here,
759 based on the settings, rather than storing them directly in gconf.
761 2007-05-10 Murray Cumming <murrayc@murrayc.com>
763 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
764 Show a more friendly error dialog now that we expect (from the tinymail
765 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
767 2007-05-10 Murray Cumming <murrayc@murrayc.com>
769 * src/maemo/modest-main-window.c: (on_account_update): Check that
770 account_name is not NULL, to prevent a crash at startup that I am
771 seeing on the N800. I do wonder why it is NULL.
773 * src/maemo/easysetup/modest-easysetup-wizard.c:
774 (create_page_user_details):
775 * src/maemo/modest-account-settings-dialog.c:
776 (create_page_user_details), (create_page_outgoing):
777 * src/maemo/modest-connection-specific-smtp-edit-window.c:
778 (modest_connection_specific_smtp_edit_window_init):
779 * src/modest-ui-actions.c:
780 (modest_ui_actions_on_password_requested):
781 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
782 might do something useful with the on-screen keyboard.
784 2007-05-10 Murray Cumming <murrayc@murrayc.com>
786 * src/maemo/modest-main-window.c: (on_account_update):
787 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
788 NULL, to avoid lots of warnings. However, it probably should not be NULL.
790 2007-05-09 Murray Cumming <murrayc@murrayc.com>
792 * src/modest-tny-account-store.c: (on_account_changed):
793 Correct the signature of this signal handler.
795 2007-05-09 Murray Cumming <murrayc@murrayc.com>
797 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
798 Show a HildonNote instead of a GtkDialog for Maemo.
800 2007-05-09 Murray Cumming <murrayc@murrayc.com>
802 * src/widgets/modest-account-view.h:
803 * src/widgets/modest-account-view.c: (on_account_changed),
804 (on_account_removed). Added a boolean flag, set/unset by
805 modest_account_view_block_conf_updates(),
806 modest_account_view_unblock_conf_updates() to prevent unnecessary
807 updates, but this is not very useful because the gconf notifications are
808 so delays (maybe only on Maemo Bora).
809 So auto-updating is turned off, and these functions do an explicit
810 update when necessary.
811 However, something else is still doing too much work when adding/removing
812 accounts, probably in another part of the application.
814 * src/maemo/modest-account-view-window.c:
815 (on_delete_button_clicked), (on_edit_button_clicked),
816 (on_new_button_clicked): Use the new functions.
818 2007-05-09 Murray Cumming <murrayc@murrayc.com>
820 * src/modest-account-mgr-helpers.c:
821 (modest_account_mgr_set_first_account_as_default):
822 Sort the list of names alphabetically-by-title, so we choose the first one
824 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
825 alphabetically by the title.
827 This fixes projects.maemo.org bug NB#56418 .
829 * src/modest-account-mgr-priv.c:
830 (_modest_account_mgr_account_from_key):
831 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
832 avoid a valgrind error, and possible random behaviour.
834 2007-05-09 Murray Cumming <murrayc@murrayc.com>
836 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
837 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
838 tinymail documentation to say that this can be expected.
839 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
840 pretty, and should not happen, but I would prefer to know when it does.
842 2007-05-09 Murray Cumming <murrayc@murrayc.com>
844 * configure.ac: When using the older hildon version, probably on Bora,
845 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
847 * src/widgets/modest-attachment-view.c:
848 (modest_attachment_view_set_part_default): Initialize variables, to fix the
851 2007-05-09 Marcus Bauer <marcusb@openismus.com>
853 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
854 Implemented the prototype. Can be tested with
855 tests/dbus_api/test_open_message:
857 2007-05-08 Murray Cumming <murrayc@murrayc.com>
859 * src/modest-tny-account-store.c:
860 (modest_tny_account_store_instance_init), (get_password):
861 * src/modest-ui-actions.c:
862 (modest_ui_actions_on_password_requested):
863 Do not store the password in gconf, because this function is called
864 for non-remembered passwords. Actually use the cached (in the hash map)
865 password instead of releasing it.
866 The password will now not be remembered if it is asked via the protected
867 password dialog, as per the UI spec.
869 2007-05-08 Murray Cumming <murrayc@murrayc.com>
872 * src/modest-account-mgr-helpers.h:
873 * src/modest-account-mgr-helpers.c:
874 Added modest_server_account_get_username_has_succeeded(),
875 modest_server_account_set_username_has_succeeded().
876 (modest_server_account_set_username),
877 Reset the has-succeeded flag if the username changes.
879 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
880 * src/maemo/modest-connection-specific-smtp-window.c:
881 (modest_connection_specific_smtp_window_save_server_accounts):
882 Use modest_server_account_set_username() instead of using
883 modest_conf_set_string() directly, so that the has-succeeded flag is always
886 * src/modest-ui-actions.c:
887 (modest_ui_actions_on_password_requested): Dim the username entry if
888 the username has ever worked, as per the UI spec.
890 2007-05-08 Murray Cumming <murrayc@murrayc.com>
892 * src/modest-tny-account-store.c: (get_password):
893 * src/modest-ui-actions.c:
894 (modest_ui_actions_on_password_requested):
895 Allow the username to be changed too, though there is more work to
896 be done on exactly how this behaves.
898 2007-05-08 Murray Cumming <murrayc@murrayc.com>
900 * src/modest-account-mgr-helpers.h:
901 * src/modest-account-mgr-helpers.c:
902 Added modest_account_mgr_get_display_name(),
903 modest_server_account_get_username(),
904 modest_server_account_set_username(),
905 modest_server_account_set_password(),
906 modest_server_account_get_hostname() functions so we do not need to
907 use the conf API directly.
909 * src/maemo/modest-main-window.c: (connect_signals):
910 Actually connect ot the ModestAccountStore::request-password signal,
911 so that we show the dialog when the password is requested by Tinymail,
912 for isntance if it is empty.
914 * src/modest-marshal.list:
915 * src/modest-tny-account-store.c:
916 (modest_tny_account_store_class_init), (get_password),
917 (modest_tny_account_store_alert):
918 * src/modest-tny-account-store.h:
919 * src/modest-ui-actions.h:
920 * src/modest-ui-actions.c:
921 (modest_ui_actions_on_password_requested):
922 Change the signal parameters, so it is obvious that we are providing
923 the non human-readable server name, and receiving both the username
924 and password, though changing of the username is not yet implemented.
925 Change the dialog UI to match the Maemo UI specifications, with #idfefing
926 for the GNOME version.
928 This should fix the projects.maemo.org bug NB#56209, though it does not
929 work on Bora, because the gconf_client_get() for the password fails
930 immediately after we save it with gconf_client_set().
932 2007-05-08 Murray Cumming <murrayc@murrayc.com>
935 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
936 caused an undefined symbol error:
937 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
939 2007-05-08 Murray Cumming <murrayc@murrayc.com>
941 * src/modest-tny-account-store.c:
942 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
943 using a GError instead of a string message, so we can translate it in
946 2007-05-08 Murray Cumming <murrayc@murrayc.com>
948 * src/maemo/modest-address-book.c:
949 (modest_address_book_check_names):
950 * src/maemo/modest-msg-view-window.c:
951 (modest_msg_view_window_clipboard_owner_change):
952 * src/modest-init.c: (modest_init_init_ui):
953 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
954 (update_folders_cb), (modest_mail_operation_update_account):
955 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
956 (modest_ui_actions_on_msg_attachment_clicked),
957 (modest_ui_actions_on_msg_recpt_activated):
958 * src/widgets/modest-header-view.c: (drag_data_get_cb):
959 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
960 (modest_msg_view_search_next):
961 * src/widgets/modest-recpt-editor.c:
962 (modest_recpt_editor_on_button_release_event),
963 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
964 g_message(). At this point we should only be seeing interesting errors on
965 stdout. Debugging messages could be #ifdefed-out if they are still useful.
967 2007-05-07 Murray Cumming <murrayc@murrayc.com>
969 (modest_wizard_dialog_force_title_update):
970 * src/maemo/easysetup/modest-wizard-dialog.h:
971 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
972 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
973 can update the title when appropriate. Otherwise the title is wrong if the
974 pages are added after adding the notebook to the dialog.
975 This must be a problem in HildonWizardDialog too.
976 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
978 * src/maemo/easysetup/modest-easysetup-wizard.c:
979 (create_subsequent_customsetup_pages),
980 (create_subsequent_easysetup_pages):
981 Call modest_wizard_dialog_force_title_update() so that the title is
982 correct even with GTK+ < 2.10.
983 This fixes projects.maemo.org bug NB#56145 .
985 2007-05-07 Murray Cumming <murrayc@murrayc.com>
987 * src/maemo/modest-platform.c:
988 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
989 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
992 2007-05-07 Murray Cumming <murrayc@murrayc.com>
994 * src/widgets/modest-window.h:
995 * src/widgets/modest-window.c: Added a save_state_func vfunc,
996 and modest_window_save_state(), which invokes it.
998 * src/widgets/modest-window-mgr.h:
999 * src/widgets/modest-window-mgr.c:
1000 Added modest_window_mgr_save_state_for_all_windows(), which calls
1001 the save_state vfunc on all registered windows, if implemented.
1003 * src/gnome/modest-msg-edit-window.c:
1004 * src/gnome/modest-msg-view-window.c:
1005 * src/maemo/modest-msg-edit-window.c:
1006 * src/maemo/modest-msg-view-window.c:
1007 * src/maemo/modest-main-window.c:
1008 Specify the existing save_settings functions as implementations of
1009 ModestWindow::save_state_func().
1011 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1012 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1013 enabling hibernation, for instance.
1015 We may need to do the same thing for restoring settings.
1018 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1020 * src/widgets/modest-window-mgr.c:
1021 * src/widgets/modest-window-mgr.h:
1022 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1023 modest_window_mgr_get_hibernation_is_prevented().
1025 * src/maemo/modest-main-window.c:
1026 (on_hildon_program_is_topmost_notify): Prevent hibernation
1027 (possible when the application goes to the background in the WM),
1028 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1030 * src/maemo/easysetup/modest-easysetup-wizard.c:
1031 (modest_easysetup_wizard_dialog_init):
1032 * src/maemo/modest-account-settings-dialog.c:
1033 (modest_account_settings_dialog_init):
1034 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1035 (modest_connection_specific_smtp_edit_window_init):
1036 * src/maemo/modest-connection-specific-smtp-window.c:
1037 (modest_connection_specific_smtp_window_init):
1038 * src/maemo/modest-signature-editor-dialog.c:
1039 (modest_signature_editor_dialog_init):
1040 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1041 prevent hibernation while any of these account settings dialogs are open.
1043 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1045 * src/maemo/Makefile.am:
1046 * src/maemo/modest-osso-state-saving.c:
1047 * src/maemo/modest-osso-state-saving.h: Added
1048 modest_osso_load_state() and modest_osso_save_state() though they do
1049 nothing now. They should iterate through all the open windows and load/save
1051 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1052 save state when closing.
1054 * src/maemo/modest-main-window.c:
1055 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1056 Add a notification handler for the HildonProgram::is-topmost property,
1057 so we can allow hibernation when the application goes into the background.
1058 But we still need to detect when the accounts setup windows are open so
1059 we can stop hibernation when they are open.
1060 To do this, I also added the main window the HildonProgram. This might have
1061 other side-effects/benefits, and should maybe be done for other windows.
1063 * src/maemo/modest-osso-autosave-callbacks.h:
1064 * src/maemo/modest-osso-autosave-callbacks.c:
1065 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1066 though it does not do anything yet, and we might never need this to do
1067 anything. For instance, we already save drafts.
1069 * src/maemo/modest-platform.c: (modest_platform_init):
1070 Specify the libosso auto-save callback.
1072 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1074 * src/maemo/modest-platform.c:
1075 (modest_platform_set_update_interval):
1076 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1077 aparently stays valid between application instances, so we can use this
1078 to remove and reset it later. According to a maemo-developers email from
1081 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1083 * configure.ac: Depend on libalarm for Maemo.
1085 * src/dbus_api/modest-dbus-api.h:
1086 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1087 (on_send_receive), (modest_dbus_req_handler):
1088 Handle a SEND_RECEIVE D-Bus method.
1090 * libmodest-dbus-client/libmodest-dbus-client.c:
1091 (libmodest_dbus_client_send_and_receive):
1092 * libmodest-dbus-client/libmodest-dbus-client.h:
1093 Add C convenience functions for calling the new D-Bus method.
1095 * src/modest-platform.h:
1096 * src/gnome/modest-platform.c:
1097 * src/maemo/modest-platform.c:
1098 Added modest_platform_set_update_interval(), which uses the
1099 alarmd API on Maemo.
1100 (modest_platform_init),
1101 Call modest_platform_set_update_interval(), using a hard-coded
1102 interval for now (until the global settings dialog is implemented),
1103 though I am not sure that this makes sense yet.
1105 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1107 * src/dbus_api/modest-dbus-callbacks.c:
1108 (modest_osso_cb_hw_state_handler):
1109 * src/dbus_api/modest-dbus-callbacks.h:
1110 * src/maemo/modest-platform.c: (modest_platform_init):
1111 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1112 in case this has some effect on the ability for Maemo to ping the
1115 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1117 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1118 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1119 warning. It is probably a logic error, but I need to fix the build.
1121 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1123 * src/modest-account-mgr.h:
1124 * src/modest-account-mgr.c:
1125 (modest_account_mgr_account_names): Add a gboolean enabled_only
1126 parameter, so we can get lists of onlt the enabled accounts.
1128 (modest_account_mgr_add_account),,
1129 (modest_account_mgr_account_with_display_name_exists):
1130 * src/maemo/modest-msg-edit-window.c: (get_transports):
1131 * src/modest-account-mgr-helpers.c:
1132 (modest_account_mgr_set_first_account_as_default):
1133 * src/modest-init.c: (init_default_account_maybe):
1134 * src/modest-tny-account-store.c: (get_accounts):
1135 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1136 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1137 * tests/check_account-mgr.c: (START_TEST):
1138 Provide the extra parameter, as appropriate.
1140 * src/widgets/modest-account-view.c: (update_account_view):
1141 Do not show disabled accounts (meaning that there is no way to
1142 enable/disable accounts in the UI (the feature is not in our UI
1143 specification), so we can use this internally only to mark unfinished
1144 or temporary account data.
1146 * src/maemo/easysetup/modest-easysetup-wizard.c:
1147 (create_account): Add boolean enable parameter, so we can specify FALSE
1148 to create the temporary account.
1149 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1150 (on_before_next): When finishing, when there is a temporary account, just
1152 Also, use a timeout to delay the showing of the dialog until gconf is likely
1153 to return correct information, due to a maemo gconf bug that is fixed in
1154 osso 1.1, but not yet in Bora.
1155 However, the dialog stays on screen after it is destroyed.
1157 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1158 for invalid data when cancelling. Use a hildon note instead of a dialog
1159 to complain about invalid data. Do not show the account-saved note if the
1160 account is disabled (a temporary account that will not really be saved for use
1163 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1165 * src/modest-account-mgr-helpers.h:
1166 * src/modest-account-mgr-helpers.c:
1167 Added modest_account_mgr_unset_default_account(),
1168 Added modest_account_mgr_set_first_account_as_default().
1170 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1171 If it was the default account, unset the default account name.
1173 * src/maemo/modest-account-view-window.c:
1174 (on_delete_button_clicked): If it was the default account,
1175 set the first remaining account as the default instead.
1177 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1178 a NULL account or a NULL default account, to prevent a crash. This should
1179 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1182 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1184 * src/widgets/modest-recpt-editor.c:
1185 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1186 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1187 TODO comment for this. This fixes the build.
1189 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1190 be the best place for it. This will in future update all auto-update accounts,
1191 rather than just the current/default account, when that gconf key exists.
1192 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1193 if there are no accounts, before calling do_send_receive().
1194 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1196 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1197 * src/maemo/modest-main-window-ui.h:
1198 * src/maemo/modest-main-window.c: (on_connection_changed),
1199 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1200 directly, becaue the signal handler does more.
1202 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1204 * src/modest-account-mgr-helpers.c:
1205 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1206 for the case that the account does not exist.
1208 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1209 (equivalent to the modest account name) rather than the tinymail account name
1210 (equivalent to the modest account title - human readable) to get the account data.
1211 Check for null account data to prevent the crash, and add a TODO comment saying that
1212 this needs fixing because it is using the server account name instead of the account name.
1214 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1216 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1217 * src/maemo/modest-account-settings-dialog.c: (show_error),
1219 Use hildon_note_new_information() for informative and error messages,
1220 which seems to be expected for Maemo applications (no documentation that I know of
1221 says this). I am surprised that there is no distinction between info and error
1224 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1226 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1227 it is easy to find where this is used.
1229 * src/maemo/easysetup/modest-easysetup-wizard.c:
1230 (create_page_welcome), (create_page_account_details),
1231 (create_page_user_details), (create_page_complete_easysetup),
1232 (create_page_custom_incoming), (create_page_custom_outgoing),
1233 (create_page_complete_custom):
1234 * src/maemo/modest-account-settings-dialog.c:
1235 (create_page_account_details), (create_page_user_details),
1236 (create_page_incoming), (create_page_outgoing):
1237 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1238 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1239 (modest_connection_specific_smtp_edit_window_init):
1240 * src/maemo/modest-connection-specific-smtp-window.c:
1241 (modest_connection_specific_smtp_window_init):
1242 * src/maemo/modest-signature-editor-dialog.c:
1243 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1244 and scrolling policy as per the Email Application Layout Guide, if I have
1247 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1249 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1250 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1251 which were empty, because these vfuncs have been removed from TnyAccountStore.
1252 This fixes the build.
1254 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1256 * src/maemo/modest-main-window.c:
1257 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1258 showing/hiding it. Added TODO because it probably should not be NULL.
1259 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1260 because unnecessary g_warnings() make degugging difficult.
1262 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1264 * src/maemo/modest-msg-edit-window.c:
1265 (modest_msg_edit_window_select_color),
1266 (modest_msg_edit_window_select_background_color): 2 const corrections and
1267 moving 2 #endifs before closing brackets, to fix the build.
1269 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1271 * src/maemo/easysetup/modest-easysetup-wizard.h:
1272 * src/maemo/easysetup/modest-easysetup-wizard.c:
1273 (modest_easysetup_wizard_dialog_finalize),
1274 (on_button_edit_advanced_settings), (create_page_complete_custom),
1275 (on_response), (create_account):
1276 Implement the Advanced Settings edit button, by saving the account information,
1277 for the Advanded Settings dialog to use directly from gconf, and removing it
1278 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1279 Bug #5533 in the projects.maemo.org bugzilla.
1281 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1283 * src/maemo/modest-msg-view-window.c:
1284 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1285 when opening a message window.
1287 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1289 * src/maemo/easysetup/modest-easysetup-wizard.c:
1290 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1293 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1294 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1295 gconf settings. I probably added more checks than necessary, but that is safer.
1297 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1298 variable to fix the build, but this seems to be used when it is still NULL.
1300 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1302 * src/modest-platform.h:
1303 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1304 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1305 * src/modest-main.c: Implement this function so we can avoid using
1306 maemo-specific API from cross-platform code.
1308 * src/modest-tny-account-store.c:
1309 (get_smtp_specific_transport_account_for_open_connection):
1310 * src/modest-ui-actions.c: (check_for_connection),
1311 (modest_ui_actions_on_item_not_found):
1312 Use modest_platform_connect_and_wait() and put #idefs around other
1313 maemo-specific code, because only maemo currently has a way to
1314 identify connection names.
1316 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1318 * src/modest-tny-account-store.h:
1319 * src/modest-tny-account-store.c:
1320 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1321 the connection-specific SMTP server settings in the configuration.
1323 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1325 * src/maemo/modest-main-window.c: (on_connection_changed),
1327 * src/modest-main.c: (main), (start_ui), (send_mail):
1328 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1329 that is what is intended.
1331 * src/modest-ui-actions.c: (action_send), (action_receive),
1332 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1333 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1334 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1335 SMTP server is used when it is specified.
1337 (modest_ui_actions_on_send_receive):
1338 Check that a connection is open before proceeding.
1339 Receive and then send, instead of vice-versa, as per the specification.
1341 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1343 * src/modest-mail-operation.c:
1344 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1345 though I guess it should be something other than NULL.
1347 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1349 * src/maemo/easysetup/modest-easysetup-wizard.c:
1350 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1351 combo twice, to avoid an g_warning and to make it visible again.
1352 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1353 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1354 (already intended) dereference when detaching, because we then recreate the menu.
1355 But I am not sure why the warning was happening, and it is possible that this is a memory
1358 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1360 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1361 and uri_parse_mailto() utility functions.
1362 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1364 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1366 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1368 * src/dbus_api/modest-dbus-api.h:
1369 * src/dbus_api/modest-dbus-callbacks.c:
1370 Use an idle callback to execute the modest code in the application's own thread.
1371 Remove the helloworld example method.
1372 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1373 parsed, and the open-message method is not implemented because this is not yet implemented in
1375 * libmodest-dbus-client/libmodest-dbus-client.c:
1376 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1377 (libmodest_dbus_client_open_message):
1378 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1380 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1381 body without crashing.
1383 * tests/dbus_api/Makefile.am:
1384 * tests/dbus_api/test_mail_to.c:
1385 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1387 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1389 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1390 Added file to fix the build. Sorry.
1392 * src/dbus_api/Makefile.am:
1393 * src/dbus_api/modest-dbus-api.h:
1394 * src/dbus_api/modest-dbus-callbacks.h:
1395 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1396 (modest_dbus_req_handler):
1397 Put constants in a separate header so it can be reused by the
1398 client library, without duplication
1400 * libmodest-dbus-client/Makefile.am:
1401 * libmodest-dbus-client/libmodest-dbus-client.c:
1402 (libmodest_dbus_client_call_helloworld),
1403 (libmodfest_dbus_client_send_mail),
1404 (libmodfest_dbus_client_mailto),
1405 (libmodfest_dbus_client_open_message):
1406 * libmodest-dbus-client/libmodest-dbus-client.h:
1407 (Partly) Implement a send_mail D-Bus method.
1409 * tests/dbus_api/Makefile.am:
1410 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1411 the send_email D-Bus method.
1413 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1417 * libmodest-dbus-client/Makefile.am:
1418 * libmodest-dbus-client/libmodest-dbus-client.c:
1419 * libmodest-dbus-client/libmodest-dbus-client.h:
1420 * tests/dbus_api/Makefile.am:
1421 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1422 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1424 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1426 * src/maemo/easysetup/modest-easysetup-wizard.c:
1427 (create_page_account_details):
1428 * src/maemo/modest-account-settings-dialog.c:
1429 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1430 widgets, because this might not be the default in future versions of the Maemo GTK+.
1431 However, I can not not get capitalization to work even in a simple test case.
1433 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1435 * src/maemo/easysetup/modest-easysetup-wizard.c:
1436 (create_page_custom_incoming), (create_page_custom_outgoing):
1437 * src/maemo/modest-account-settings-dialog.c:
1438 (create_page_account_details), (create_page_incoming),
1439 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1440 instead of using gtk_check_button_with_label(), so they are aligned like the other
1441 widgets, as per the UI spec.
1443 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1445 * src/maemo/easysetup/modest-easysetup-wizard.c:
1446 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1447 * src/widgets/modest-validating-entry.c:
1448 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1449 Modest prefix instead of an EasySetup prefix.
1451 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1453 * src/widgets/modest-validating-entry.h:
1454 * src/widgets/modest-validating-entry.c: (on_insert_text),
1455 Added easysetup_validating_entry_set_max_func(), used to set a callback
1456 to call when the max number of characters is reached. GtkEntry has a max-length
1457 already but is silent about it.
1459 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1460 (create_page_account_details), (create_page_user_details),
1462 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1463 (create_page_account_details), (create_page_user_details),
1464 (create_page_outgoing):
1465 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1466 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1467 the UI spec, when the user tries to enter more than the max number of characters.
1469 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1471 * src/maemo/easysetup/modest-easysetup-wizard.c:
1472 (create_page_user_details), (create_page_custom_incoming),
1473 (create_page_custom_outgoing):
1474 * src/maemo/modest-account-settings-dialog.c:
1475 (create_page_user_details), (create_page_incoming),
1476 (create_page_outgoing):
1477 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1478 (modest_connection_specific_smtp_edit_window_init):
1479 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1480 not appropriate. Bad Maemo-specific defaults!.
1482 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1484 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1485 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1486 (modest_signature_editor_dialog_set_settings):
1487 Disable the label and textview when the checkbox is disabled, and use the
1488 specified (UI spec) default signature text.
1490 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1492 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1493 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1495 * src/modest-defs.h:
1496 * src/modest-account-mgr-helpers.h:
1497 * src/modest-account-mgr-helpers.c:
1498 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1500 * src/maemo/Makefile.am:
1501 * src/maemo/modest-signature-editor-dialog.c:
1502 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1505 * src/maemo/modest-account-settings-dialog.h:
1506 * src/maemo/modest-account-settings-dialog.c:
1507 (modest_account_settings_dialog_finalize), (on_button_signature),
1508 (save_configuration): Use the new dialog when the Edit button is pressed, and
1509 save the changes if necessary, as per the UI spec.
1511 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1513 * src/maemo/Makefile.am:
1514 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1515 based on maemo-develoers email from Dirk.
1517 * src/maemo/easysetup/modest-easysetup-wizard.c:
1518 (create_page_welcome), (create_page_account_details),
1519 (create_page_user_details), (create_page_complete_easysetup),
1520 (create_page_custom_incoming), (create_page_custom_outgoing),
1521 (create_page_complete_custom),
1522 (modest_easysetup_wizard_dialog_init):
1523 * src/maemo/modest-account-settings-dialog.c:
1524 (create_page_account_details), (create_page_user_details),
1525 (create_page_incoming), (create_page_outgoing),
1526 (modest_account_settings_dialog_init):
1527 * src/maemo/modest-connection-specific-smtp-window.c:
1528 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1530 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1532 * src/maemo/easysetup/modest-easysetup-wizard.c:
1533 (create_page_account_details), (create_page_custom_outgoing),
1534 (create_page_complete_custom):
1535 * src/maemo/modest-account-settings-dialog.c:
1536 (create_page_user_details), (create_page_incoming),
1537 (create_page_outgoing):
1538 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1539 (modest_connection_specific_smtp_edit_window_init):
1540 Use the correct (UI spec) port min/max, and use horizontal separators,
1543 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1545 * src/maemo/easysetup/modest-easysetup-wizard.c:
1546 (set_default_custom_servernames):
1547 * src/maemo/modest-account-settings-dialog.c:
1548 (create_page_incoming), (on_combo_outgoing_security_changed),
1549 (on_combo_incoming_security_changed), (create_page_outgoing),
1550 (modest_account_settings_dialog_set_account_name),
1551 (save_configuration):
1552 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1553 (on_combo_security_changed),
1554 (modest_connection_specific_smtp_edit_window_init),
1555 (modest_connection_specific_smtp_edit_window_set_connection),
1556 (modest_connection_specific_smtp_edit_window_get_settings):
1557 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1560 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1563 * src/maemo/easysetup/modest-easysetup-wizard.c:
1564 (create_page_custom_outgoing), (create_page_complete_custom):
1565 * src/maemo/modest-account-settings-dialog.c:
1566 (create_page_user_details), (create_page_outgoing):
1567 * src/maemo/modest-account-view-window.c: (button_box_new):
1568 Use changed logical IDs as per the most recent UI spec:
1569 mcen_bd_emailsetup_edit -> mcen_bd_edit
1570 mcen_bd_emailsetup_delete -> mcen_bd_delete
1571 mcen_bd_emailsetup_close -> mcen_bd_close
1573 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1577 * src/dbus_api/Makefile.am:
1578 * src/dbus_api/modest-dbus-callbacks.c:
1579 * src/dbus_api/modest-dbus-callbacks.h:
1580 * src/maemo/modest-platform.c: (modest_platform_init):
1581 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1583 * tests/Makefile.am:
1584 * tests/dbus_api/Makefile.am:
1585 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1587 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1589 * src/maemo/modest-account-settings-dialog.c:
1590 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1591 Removed unnecessary includes.
1593 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1595 * src/maemo/easysetup/modest-easysetup-wizard.c:
1596 * src/maemo/modest-account-settings-dialog.c:
1597 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1598 * src/widgets/Makefile.am:
1599 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1600 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1601 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1602 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1603 * src/widgets/modest-secureauth-combo-box.c:
1604 * src/widgets/modest-secureauth-combo-box.h:
1605 * src/widgets/modest-serversecurity-combo-box.c:
1606 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1607 made the GObject names more consistent with the rest of the Modest code.
1609 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1611 * src/maemo/easysetup/Makefile.am:
1612 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1613 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1614 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1615 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1616 * src/maemo/easysetup/modest-easysetup-wizard.c:
1617 * src/maemo/easysetup/modest-validating-entry.c:
1618 * src/maemo/easysetup/modest-validating-entry.h:
1619 * src/maemo/modest-account-settings-dialog.c:
1620 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1621 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1622 widgets/ because they are used outside of easysetup too. After checking in,
1623 svn will allow me to rename them too.
1625 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1627 * src/gnome/modest-msg-edit-window.c:
1628 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1629 linker error, to fix the build on the GNOME platform.
1630 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1631 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1632 ifdefed out to avoid a warning.
1634 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1636 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1637 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1638 some alternative for GTK+ 2.6.
1640 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1642 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1644 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1645 specified for EmailAccountsDialog in UI spec.
1647 * src/maemo/easysetup/modest-easysetup-wizard.c:
1648 * src/maemo/easysetup/modest-easysetup-wizard.h:
1649 * src/maemo/modest-account-settings-dialog.c:
1650 * src/maemo/modest-account-settings-dialog.h:
1651 Reuse a member window widget for the connection-specific SMTP server accounts,
1652 so we can tell it to create/save the accounts only if we actually save changes.
1654 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1655 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1656 (modest_connection_specific_smtp_edit_window_get_settings):
1657 Return a struct instance for temporarily remembering the entered data.
1659 * src/maemo/modest-connection-specific-smtp-window.h:
1660 * src/maemo/modest-connection-specific-smtp-window.c:
1661 (modest_connection_specific_smtp_window_finalize),
1662 (modest_connection_specific_smtp_window_fill_with_connections),
1664 (modest_connection_specific_smtp_window_save_server_accounts),
1665 (update_model_server_names): Do not actually save data until asked,
1666 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1668 (on_selection_changed),
1669 (modest_connection_specific_smtp_window_init): Disable the edit
1670 button when nothing is selected.
1672 * src/modest-account-mgr-helpers.c:
1673 * src/modest-account-mgr-helpers.h:
1674 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1677 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1679 * src/modest-account-mgr-helpers.h:
1680 * src/modest-account-mgr-helpers.c:
1681 (modest_account_mgr_get_unused_account_name),
1682 (modest_account_mgr_get_unused_account_display_name): Added these
1683 utility functions, to avoid code duplication.
1685 * src/maemo/easysetup/modest-easysetup-wizard.c:
1686 (create_page_account_details), (create_account):
1687 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1688 (on_combo_security_changed),
1689 (modest_connection_specific_smtp_edit_window_init),
1690 (modest_connection_specific_smtp_edit_window_save_settings):
1691 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1692 * src/maemo/modest-connection-specific-smtp-window.c:
1693 (modest_connection_specific_smtp_window_finalize),
1694 (modest_connection_specific_smtp_window_fill_with_connections),
1695 (on_button_edit), (modest_connection_specific_smtp_window_init):
1696 * src/maemo/modest-connection-specific-smtp-window.h:
1697 Implementing saving of connection-specific server accounts.
1699 But I need to refactor this so we can save the data for each
1700 possible connection-specific account and only actually create the server accounts
1701 when the easysetup finished, or the OK button is pressed on the account settings
1704 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1706 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1707 (on_combo_security_changed):
1708 (modest_connection_specific_smtp_edit_window_init):
1709 Auto-fill the port number as in the account settings.
1711 (modest_connection_specific_smtp_edit_window_set_connection):
1712 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1713 * src/maemo/modest-connection-specific-smtp-window.c:
1714 (fill_with_connections), (on_button_edit),
1715 (modest_connection_specific_smtp_window_init):
1716 Turn the edit window into a dialog to simplify the code, and
1717 set a WM hint as in a GtkDialog, because only a popup can be on top of
1718 another window in Maemo, and popups usually have no WM decoration.
1720 * src/modest-defs.h:
1721 * src/modest-account-mgr-helpers.c:
1722 (modest_account_mgr_set_connection_specific_smtp),
1723 (modest_account_mgr_remove_connection_specific_smtp),
1724 (modest_account_mgr_get_connection_specific_smtp):
1725 * src/modest-account-mgr-helpers.h: Some functions to write the
1726 connection-specific SMTP server information. Not yet used.
1729 * src/widgets/modest-folder-view.c: (text_cell_data):
1730 Fix a warning about an uninitialized variable.
1731 (on_configuration_key_changed): Put an #ifdef around the use
1732 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1734 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1736 * src/maemo/modest-account-settings-dialog.h:
1737 * src/maemo/modest-account-settings-dialog.c:
1738 Added connect_for_modified() utility function to mark the new modified boolean.
1740 (create_page_account_details), (create_page_user_details),
1741 (create_page_incoming), (create_page_outgoing), (on_response),
1742 (modest_account_settings_dialog_init),
1743 (modest_account_settings_dialog_set_account_name):
1744 Only warn about unsaved changes when there are actually unsaved changes.
1746 * src/modest-account-mgr-helpers.c:
1747 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1748 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1749 to get the data from there in future.
1751 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1753 * src/modest-defs.h:
1755 * src/modest-account-mgr-helpers.h:
1756 * src/modest-account-mgr-helpers.c:
1757 Store the security account setting in a single conf key instead of using
1758 the options list, so that the list is left for just the to-be-removed camel hack,
1759 and because gconf_client_set_list() is failing for some reason.
1761 * src/modest-account-mgr.c:
1762 (modest_account_mgr_add_server_account):
1763 * src/maemo/modest-account-settings-dialog.c:
1764 (modest_account_settings_dialog_set_account_name),
1765 (save_configuration): Use the renamed functions.
1768 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1770 * src/widgets/Makefile.am:
1771 * src/widgets/modest-limit-retrieve-combo-box.c:
1772 * src/widgets/modest-limit-retrieve-combo-box.h:
1773 * src/widgets/modest-retrieve-combo-box.c:
1774 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1775 the account settings dialog.
1777 * src/modest-defs.h:
1778 * src/modest-account-mgr-helpers.h:
1779 * src/modest-account-mgr-helpers.c:
1780 (modest_server_account_get_option_secure_auth),
1781 (modest_server_account_set_option_secure_auth):
1782 * src/modest-account-mgr.c:
1783 (modest_account_mgr_add_server_account):
1784 Use the existing AUTH_MECH conf key for the secure-auth setting,
1785 instead of putting it in the list options, because this was actually used already.
1787 * src/maemo/modest-account-settings-dialog.c:
1788 (create_page_account_details),
1789 (modest_account_settings_dialog_set_account_name),
1790 (save_configuration):
1791 * src/maemo/modest-account-settings-dialog.h:
1792 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1793 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1795 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1797 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1798 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1799 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1801 * src/modest-defs.h:
1802 * src/maemo/modest-account-settings-dialog.c:
1803 (create_page_incoming), (on_combo_outgoing_security_changed),
1804 (on_combo_incoming_security_changed), (create_page_outgoing),
1805 (modest_account_settings_dialog_set_account_name),
1806 (save_configuration): Load/Save the port number, and change it when the
1807 security combo changes, to suitable defaults.
1809 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1811 * src/modest-account-mgr.c:
1812 (modest_account_mgr_add_server_account): Set the security and secure-auth
1813 options, and add a comment saying that the other camel-specific options should be
1816 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1818 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1820 * src/modest-tny-account-store.c: (account_list_free),
1821 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1822 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1825 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1827 * src/modest-protocol-info.c:
1828 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1829 is required by our UI spec. Maybe something in our implementation will use this eventually.
1830 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1831 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1832 instead of the previous 0 placeholder.
1834 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1835 secure-auth settings.
1836 * src/modest-account-mgr-helpers.h:
1837 * src/modest-account-mgr-helpers.c:
1838 (modest_server_account_data_get_option_secure_auth),
1839 (modest_server_account_set_option_secure_auth),
1840 (modest_server_account_data_get_option_security),
1841 (modest_server_account_set_option_security): Added this API for getting and setting the security
1842 and secure-auth settings.
1844 * src/maemo/modest-account-settings-dialog.h:
1845 * src/maemo/modest-account-settings-dialog.c:
1846 (modest_account_settings_dialog_finalize), (check_data),
1847 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1848 about changing titles.
1849 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1850 (save_configuration): Save the security and secure-auth settings.
1852 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1853 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1855 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1857 * src/modest-defs.h:
1858 * src/modest-account-mgr.c:
1859 (modest_account_mgr_add_server_account):
1860 Added and used defines for the options key and value pair strings,
1861 that are used so far, though they do not seem to correspond to anything in our
1862 UI specs or ModestProtocol enum.
1864 * src/modest-account-mgr-helpers.h:
1865 * src/modest-account-mgr-helpers.c:
1866 (compare_option_strings_for_name),
1867 (modest_server_account_data_get_option_value),
1868 (modest_server_account_data_get_option_bool),
1869 (modest_account_mgr_get_server_account_option):
1870 Added helper functions for parsing the options GSList.
1872 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1874 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1875 display name is based on the supplied account name.
1876 * src/modest-account-mgr.c:
1877 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1878 with an inefficient, but good-enough, implementation.
1880 * src/maemo/easysetup/modest-easysetup-wizard.c:
1881 (create_page_account_details), (on_before_next), (create_account):
1882 Check for existing display names rather than (non-user-visible) account names, and just
1883 create and set a unique account name at the end.
1885 * src/maemo/modest-account-settings-dialog.c:
1886 (modest_account_settings_dialog_init),
1887 (modest_account_settings_dialog_set_account_name),
1888 (create_page_incoming): Show the display name, instead of the account name.
1889 (on_response): Do some (not all) extra checks, as in the UI spec.
1890 (save_configuration): Save the display name if it was changed.
1892 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1894 * po/en_GB.po: Added needed logical ID and translation.
1895 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1896 (init_view): Made the is-default column clicking work.
1898 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1901 * src/maemo/easysetup/Makefile.am:
1902 * src/maemo/easysetup/modest-easysetup-wizard.c:
1903 (modest_easysetup_wizard_dialog_init):
1904 * src/maemo/easysetup/provider-data-test.keyfile:
1905 * src/maemo/easysetup/provider-data.keyfile:
1906 Moved the provider data file to the new modest-providers-data package and used it from there.
1908 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1910 * src/modest-local-folder-info.c:
1911 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1912 N_() was already used on the static strings, but this just marks it for translation without
1913 using the translation.
1915 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1917 * src/maemo/modest-account-settings-dialog.c:
1918 (create_page_incoming),
1919 (modest_account_settings_dialog_set_account_name):
1920 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1921 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1922 I will do this if nobody else gets there first.
1924 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1926 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1927 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1928 save the security stuff.
1930 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1932 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1933 Set the email address and user fullname, which I now see must be
1936 * src/maemo/modest-account-settings-dialog.h:
1937 * src/maemo/modest-account-settings-dialog.c:
1939 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1940 leave-on-server and authentication.
1941 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1944 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1947 * src/maemo/modest-account-settings-dialog.c:
1948 * src/maemo/modest-account-settings-dialog.h:
1949 Most (but not all) of the widgets are now present as specified by the UI spec.
1950 No changes are yet saved, and some details are not properly shown yet.
1952 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1954 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1956 * src/maemo/Makefile.am:
1957 * src/maemo/modest-account-settings-dialog.c:
1958 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1959 an existing account. Doesn't do much yet.
1961 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1962 Open the accounts settings dialog when Edit is clicked.
1964 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1966 * src/maemo/easysetup/Makefile.am:
1967 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1969 * src/maemo/easysetup/modest-easysetup-wizard.c:
1970 (modest_easysetup_wizard_dialog_init):
1971 Try to get the source directory from the build system,
1972 instead of hard-coding "./" into the source code, when opening our local
1973 copies of the configuration files.
1974 But this still fails when opening the wizard from the Accounts window,
1975 maybe because the working directory seems to change at runtime.
1976 So the wizard will fail the second time unless you copy the files into their
1977 proper locations - see the stdout warnings for the paths.
1979 (create_page_account_details),(on_before_next):
1980 Check for existing non-server accounts instead of server accounts,
1981 so the default account name is useful again, and to prevent trying to
1984 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1985 Show the wizard when New is clicked.
1987 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1988 (init_view): Show the column headers, and show the columns that are
1989 specified in the UI specs. However, something in Maemo's GTK+ prevents
1990 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1991 change the default account. This is despite unsetting the special properties.
1993 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1995 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1996 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1997 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1998 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1999 to make that clearer.
2000 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2002 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2004 * src/maemo/modest-account-view-window.c:
2005 (modest_account_view_window_init),
2006 (modest_account_view_window_new):
2007 Use the same buttons as specified in the
2008 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2009 the existing widgets, which never had a chance of working.
2010 Put the ModestAccountView treeview in a scrolled window.
2011 Do not repeat the initialization in both _init() and _new().
2013 * src/widgets/modest-account-view.c: (update_account_view):
2014 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2015 this widget and window shows no accounts.
2017 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2019 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2021 * src/maemo/easysetup/modest-easysetup-wizard.c:
2022 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2023 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2024 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2027 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2028 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2029 accounts exist yet, as in the UI spec.
2031 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2033 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2035 * src/maemo/Makefile.am:
2036 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2037 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2038 New window for editing connection-specific smtp details.
2039 Not fully implemented.
2041 * src/maemo/modest-connection-specific-smtp-window.c:
2042 (modest_connection_specific_smtp_window_finalize) :
2043 unref the tree model.
2044 (on_button_edit): Show the edit window.
2046 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2048 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2051 * src/maemo/Makefile.am:
2052 * src/maemo/modest-connection-specific-smtp-window.c:
2053 * src/maemo/modest-connection-specific-smtp-window.h:
2054 New window for showing the list of connections, for connection-specific
2055 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2056 * src/maemo/easysetup/modest-easysetup-wizard.c:
2057 (create_page_custom_outgoing): Show the new window when the button is clicked.
2059 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2061 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2062 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2063 * src/maemo/modest-msg-edit-window.c:
2064 (modest_msg_edit_window_insert_image):
2065 * src/modest-conf.c: (modest_conf_key_escape):
2066 * src/modest-mail-operation.c:
2067 (modest_mail_operation_send_new_mail):
2068 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2069 (modest_ui_actions_on_new_account):
2070 * src/widgets/modest-attachment-view.c: (update_filename_request):
2071 * src/widgets/modest-mail-header-view.c:
2072 Corrected warnings that were breaking the build, by commenting out unused variables,
2073 and a function, and by including a header.
2075 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2077 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2078 so we can #ifdef around platform-specific code when necessary.
2079 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2080 to allow this to build for the GNOME platform too.
2082 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2084 * src/maemo/easysetup/modest-easysetup-wizard.c:
2085 Added util_increment_name() and used it in create_page_account_details()
2086 to make sure that the default account name is always a new name.
2088 (modest_easysetup_wizard_dialog_init),
2089 (set_default_custom_servernames): Some minor memory management fixes.
2091 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2095 * src/modest-runtime.c: (init_i18n): Restored the translation
2096 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2097 are defined in config.h, and the translations are installed.
2099 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2100 is defined for translation.
2102 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2104 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2106 * src/maemo/easysetup/modest-easysetup-wizard.c:
2107 (modest_easysetup_wizard_dialog_init):
2108 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2109 Use realistic paths (though they should use $prefix generically) to the
2110 mcc_mapping and provider-data.keyfile files which might work when they
2111 are installed by the future version of the operator-wizard package,
2112 and then fallback to paths in our source code, with an explanatory
2115 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2119 * src/maemo/Makefile.am:
2120 * src/maemo/easysetup/: Added files from the previously-exernal
2121 osso-modest-easysetup.
2122 * src/maemo/modest-main-window-ui.h:
2123 * src/modest-ui-actions.c:
2124 * src/modest-ui-actions.h:
2125 Added modest_ui_actions_on_new_account() as a signal handler for the
2126 New Account menu item. It shows the easysetup wizard.
2127 * po/en_GB.po: Added additional needed logical IDs and translations.
2129 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2130 Apparently ChangeLog is not used for some vague Nokia legal reasons.