1 2007-06-12 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-api.h:
4 * src/dbus_api/modest-dbus-callbacks.c:
5 (on_idle_open_default_inbox), (on_open_default_inbox),
6 (modest_dbus_req_handler):
7 Added a new OpenDefaultInbox method.
9 * libmodest-dbus-client/libmodest-dbus-client.h:
10 * libmodest-dbus-client/libmodest-dbus-client.c:
11 Added libmodest_dbus_client_open_default_inbox() to call the new
12 dbus method. This should be useful to projects.maemo.org bug NB#57214,
13 though it should maybe be used by a new osso-email-interface function.
15 * tests/dbus_api/Makefile.am:
16 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
19 2007-06-12 Murray Cumming <murrayc@murrayc.com>
21 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
22 NULL, so that the signals get all the keys. This should not actually
23 change any behaviour because we currently update everything when anything
26 2007-06-12 Murray Cumming <murrayc@murrayc.com>
28 * src/widgets/modest-folder-view.c: (text_cell_data),
29 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
30 (find_inbox_iter): If tinymail tells us that the folder is
31 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
32 This causes the inbox to be selected at startup, fixing part of
33 projects.maemo.org bug NB#56305.
35 * src/modest-ui-dimming-rules.c:
36 (modest_ui_dimming_rules_on_tools_smtp_servers):
37 * src/modest-ui-dimming-rules.h: Added a callback function to dim
38 the SMTP servers menu item.
39 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
40 that the SMTP Servers menu item is dimmed when there are no accounts,
41 as a future version of the UI spec will require. This fixes
42 projects.maemo.org bug NB#56305.
44 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
46 * src/maemo/modest-maemo-utils.c:
47 (modest_maemo_utils_get_supported_secure_authentication_methods):
48 Added label to dialog instead of unreadable title
50 * src/maemo/modest-main-window.c: (sync_accounts_cb),
51 (modest_main_window_new):
52 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
55 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
56 * src/modest-account-mgr.h:
57 Added method to avoid code duplication
59 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
60 (modest_ui_actions_on_send_receive):
61 Use modest_account_mgr_has_accounts
63 2007-06-11 Murray Cumming <murrayc@murrayc.com>
65 * src/maemo/easysetup/modest-presets.c:
66 (modest_presets_get_info_server_security): Do not report secure auth
68 * src/modest-protocol-info.c: Use the defines for the gconf key names
69 for secure authentication. This was not working because we were writing
70 Password and reading password, and the check was case sensitive.
71 With this, gmail now works for receiving and sending when created via
74 2007-06-11 Murray Cumming <murrayc@murrayc.com>
76 * src/maemo/easysetup/modest-presets.c:
77 (modest_presets_get_info_server_security): Correct the key name for
78 SecureSmtp, because it seems to be case-sensitive.
79 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
80 Do not try to get the 0th notebook page if there are 0 pages, to
83 2007-06-11 Murray Cumming <murrayc@murrayc.com>
85 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
86 Prevent use of the new notification feature for now, because it currently
87 shows one dialog for each new email, which is annoying.
89 2007-06-11 Murray Cumming <murrayc@murrayc.com>
91 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
92 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
93 when no country was selected, so that we show the global ones.
94 * src/maemo/easysetup/modest-presets.c:
95 (modest_presets_get_providers): Return only the global providers, not
96 all providers when mmc=0 was requested.
98 2007-06-11 Murray Cumming <murrayc@murrayc.com>
100 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
101 (easysetup_provider_combo_box_fill): Remove debug code that showed the
102 provider ID in the combo.
104 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
105 Do not show the page numbers, because it would be confusing when we add
106 the 2 extra pages for the custom setup, when the user chooses the "Other"
107 provider. This fixes projects.maemo.org bug NB#59028
109 * src/modest-init.c: (modest_init_init_core),
110 (modest_init_local_folders):
112 * src/modest-tny-account.c:
113 (modest_tny_account_new_for_local_folders): Do not create default folders
114 for the memory card. This should fix projects.maemo.org bug NB#59328.
116 2007-06-11 Murray Cumming <murrayc@murrayc.com>
118 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
119 Free the changed_conf_keys string items. They are already freed in the
120 idle handler if that runs first.
122 2007-06-11 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-ui-actions.c:
125 (modest_ui_actions_on_password_requested): Check that the server name
126 is not NULL, because I just saw a password dialog with (null) as the
129 * src/modest-tny-folder.[h|c]: Added
130 modest_tny_folder_is_memory_card_folder().
131 * src/modest-ui-dimming-rules.c:
132 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
133 menu item for memory cards, as per the UI spec (section 7.4). This should
134 fix projects.maemo.org bug NB#59297.
136 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
138 * src/maemo/modest-main-window.c: (sync_accounts_cb):
139 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
140 is another problem with the code, see Murray's comment at line 772)
142 2007-06-08 Murray Cumming <murrayc@murrayc.com>
144 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
145 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
146 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
147 (load_from_file), (easysetup_country_combo_box_init),
148 (easysetup_country_combo_box_get_active_country_ids),
149 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
150 instead of just one ID, to avoid duplicate country names in the UI.
152 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
153 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
154 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
155 a single ID, avoiding duplicate providers.
156 * src/maemo/easysetup/modest-easysetup-wizard.c:
157 (on_combo_account_country): Adapt to use a list.
159 2007-06-08 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
162 keys changed in the last X seconds.
164 * src/modest-account-mgr.h:
165 * src/modest-account-mgr.c: (on_timeout_notify_changes),
166 (on_key_change), (modest_account_mgr_class_init),
167 (modest_account_mgr_init), (modest_account_mgr_finalize):
168 As the keys are changed, save them in a GSList* and signal that GSList*
169 further every X seconds, to batch changes, to allow us to do just one
170 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
171 bug NB#56941 and other (UI-blocking) delays when changing account settings.
173 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
174 changed signal signature.
176 * src/modest-conf.c: (modest_conf_set_list),
177 (modest_conf_on_change): Reenable notification.
179 (modest_conf_maemo_fake_on_change): Comment out the hack that
180 notified immediately instead of asynchronously.
182 * src/widgets/modest-account-view.h:
183 * src/widgets/modest-account-view.c:
184 (update_account_view): Select the previously-selected account ID,
185 if possible. This fixes projects.maemo.org bug NB#56933.
187 (on_account_changed), (on_account_removed),
188 (modest_account_view_select_account):
190 Remove the block/unblock functions
191 because they were not useful.
193 * src/maemo/modest-account-view-window.c:
194 (on_delete_button_clicked), (on_edit_button_clicked),
195 (on_new_button_clicked): Remove the use of the non-working block/unblock.
197 2007-06-08 Murray Cumming <murrayc@murrayc.com>
199 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
200 Improve the error dialog to show Incorrect Account Settings, which seems
201 clearer, and say that the internal error message (to be removed from the
202 dialog later) is often misleading.
203 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
205 * src/modest-tny-account.c:
206 (modest_tny_account_new_from_server_account): Uncomment the printf of the
207 URL because this is so useful for debugging on the device.
209 * src/widgets/modest-serversecurity-combo-box.c:
210 (modest_serversecurity_combo_box_fill): Correct a logical ID.
212 2007-06-08 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-mail-operation.c:
215 (modest_mail_operation_send_new_mail):
216 Added a comment about a nasty but apparently harmless message. Details
217 added to the wiki g_warnings() page.
219 2007-06-08 Murray Cumming <murrayc@murrayc.com>
221 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
222 (modest_tny_send_queue_class_init):
223 Do not use the priv struct because it is empty, to avoid g_warnings
224 about a non-existant priv struct.
226 * src/modest-tny-account-store.c:
227 (modest_tny_account_store_get_server_account),
228 (modest_tny_account_store_get_transport_account_for_open_connection
229 ): Do not try to get transport server accounts for local folders,
230 because they don't have any. This avoids a g_warning().
232 * src/maemo/modest-main-window.c:
233 (modest_main_window_notify_send_receive_initied),
234 (on_configuration_key_changed):
235 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
237 * src/modest-mail-operation.c:
238 (modest_mail_operation_update_account):
239 * src/modest-tny-account-store.h:
240 * src/modest-tny-account.c:
241 (modest_tny_account_get_special_folder),
242 (modest_tny_account_new_for_local_folders),
243 (modest_tny_account_new_for_per_account_local_outbox_folder):
244 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
245 * src/modest-tny-local-folders-account.c:
246 (add_account_folders_to_merged_folder):
247 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
248 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
249 (modest_ui_actions_on_send):
250 * src/widgets/modest-folder-view.c: (update_model):
251 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
252 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
253 modest_tny_account_store_get_tny_account_by_account() to
254 modest_tny_account_store_get_server_account() to make the code clearer.
256 2007-06-07 Marcus Bauer <marcusb@openismus.com>
258 * src/dbus_api/modest-dbus-api.h:
259 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
260 * src/maemo/modest-msg-edit-window.c:
261 (modest_msg_edit_window_attach_file_noninteractive):
262 added g_warning in case the file to be attached does not exist
263 * tests/dbus_api/test_compose_mail.c: (main):
264 removed obsolete comment, added generic files as test case
266 2007-06-07 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-tny-account-store.c: (get_server_accounts):
269 Create the local folders account only once, not once for each outbox, and
270 not only when there are some outboxes.
272 2007-06-07 Murray Cumming <murrayc@murrayc.com>
274 * src/widgets/modest-folder-view.c: (update_model): Comment out some
275 code that is causing a crash at startup. Sergio says that he is fixing this.
277 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
279 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
280 * src/maemo/modest-account-settings-dialog.c:
281 (create_page_outgoing),
282 (modest_account_settings_dialog_set_account_name),
283 (save_configuration):
284 - Fixed handling of the "Use secure authentication" toggle to comply with
285 the ui specification. See also projects.maemo.org bug NB#58400
287 - Restore the Secure connection setting combo correctly when loading
290 * src/maemo/modest-maemo-utils.c:
291 (on_camel_account_get_supported_secure_authentication),
292 (modest_maemo_utils_get_supported_secure_authentication_methods):
293 Fixed a crasher if operation is canceled
295 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
296 (modest_protocol_info_auth_is_secure):
297 * src/modest-protocol-info.h:
299 Added two new methods to determine if a protocol/auth method is secure/encrypted in
300 the sense of the "Use secure authentication" toggle.
302 2007-06-07 Murray Cumming <murrayc@murrayc.com>
304 * src/modest-tny-account-store.h:
305 * src/modest-tny-account-store.c:
306 Added modest_tny_account_store_get_local_folders_account().
308 * src/modest-tny-folder.h:
309 * src/modest-tny-folder.c:
310 (modest_tny_folder_get_account):
311 Added this replacement for tny_folder_get_account() which returns
312 the local-folders account for TnyMergeFolders, to avoid the
313 warning about the unimplemented get_account_func() vfunc().
315 (modest_tny_folder_get_rules),
316 * src/modest-ui-actions.c:
317 (modest_ui_actions_on_folder_selection_changed):
318 * src/modest-mail-operation.c:
319 (modest_mail_operation_remove_folder),
320 (modest_mail_operation_xfer_folder),
321 (modest_mail_operation_rename_folder),
322 (modest_mail_operation_get_msg),
323 (modest_mail_operation_get_msgs_full),
324 (modest_mail_operation_remove_msg),
325 (modest_mail_operation_xfer_msgs),
326 (modest_mail_operation_refresh_folder):
327 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
329 2007-06-07 Murray Cumming <murrayc@murrayc.com>
331 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
332 (modest_server_account_set_security):
333 * src/modest-defs.h: Add comments explaining that our
334 UI spec means TLS when it says Normal, so these do not look like errors.
336 * src/modest-tny-account.c:
337 (modest_tny_account_new_from_server_account): Use the new tinymail
338 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
339 for TLS. This should fix projects.maemo.org bug NB#58460.
341 2007-06-06 Murray Cumming <murrayc@murrayc.com>
343 * src/maemo/easysetup/modest-easysetup-wizard.c:
344 (create_account): Correct the position of the gconf sanity check warning.
345 (on_button_edit_advanced_settings): Show the dialog immediately, instead
346 of using the g_idle_add() hack, because this does not seem to be necessary
347 on osso 1.1. It might even work on Maemo Bora if the problems were actually
348 caused by something other than maemo's gconf.
349 This fixes projects.maemo.org bug #59022.
351 2007-06-06 Murray Cumming <murrayc@murrayc.com>
353 * src/modest-account-mgr-helpers.c:
354 (modest_account_mgr_get_default_account): Do not check that the account
355 exists if there is no default account (NULL), to fix a runtime warning.
357 2007-06-06 Murray Cumming <murrayc@murrayc.com>
359 * src/widgets/modest-folder-view.c: (update_model):
360 Do not unref the treemodel before we have finished with it.
361 This prevents a valgrind warning and an occasional crash at startup.
363 2007-06-06 Marcus Bauer <marcusb@openismus.com>
365 * libmodest-dbus-client/libmodest-dbus-client.h:
366 added libmodest_dbus_client_compose_mail()
367 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
369 added functions needed for SendAsMail() functionality
370 * src/maemo/modest-msg-edit-window.c:
371 (modest_msg_edit_window_attach_file_noninteractive):
372 non interactively attaching files to message edit window
373 * src/widgets/modest-msg-edit-window.h:
374 * tests/dbus_api/Makefile.am:
375 added test_compose_mail.c
376 * tests/dbus_api/test_compose_mail.c: (main):
378 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
380 * src/modest-account-view.c:
381 Fixed bug projects.maemo.org bug NB#59307
383 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
385 * src/maemo/easysetup/modest-easysetup-wizard.c:
386 (get_serverport_incoming), (on_before_next), (create_account):
387 * src/maemo/modest-account-settings-dialog.c:
388 (modest_account_settings_dialog_set_account_name):
389 * src/maemo/modest-maemo-utils.c:
390 (on_camel_account_get_supported_secure_authentication_status),
391 (on_camel_account_get_supported_secure_authentication),
392 (on_secure_auth_cancel),
393 (modest_maemo_utils_get_supported_secure_authentication_methods):
395 Implemented security authentication for settings and easysetup.
397 2007-06-05 Murray Cumming <murrayc@murrayc.com>
399 * src/maemo/modest-main-window.c: (create_details_widget):
400 Show the total size for memory card accounts too, instead of showing
401 the name again. Fixes bug projects.maemo.org bug NB#59307.
403 2007-06-05 Murray Cumming <murrayc@murrayc.com>
406 * src/modest-tny-simple-folder-store.c:
407 * src/modest-tny-simple-folder-store.h: Removed.
409 * src/modest-tny-local-folders-account.h
410 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
411 for the local-folders maildir, with an extra TnyMergedFolder containing
412 the folders of the per-account outbox store accounts.
413 * src/modest-tny-account-store.c: (get_server_accounts):
414 Add the outboxes to the special local folders account after creating it.
416 * src/modest-tny-account.c:
417 (modest_tny_account_new_for_local_folders): Create the derived
418 account when creating the main local-folders account.
420 * src/maemo/modest-main-window.c: (create_details_widget),
421 (modest_main_window_set_contents_style):
422 Adapted to the use of the derived account instead of the folder store.
424 * src/modest-ui-actions.c:
425 (modest_ui_actions_on_folder_selection_changed):
426 * src/modest-ui-dimming-rules.c:
427 (modest_ui_dimming_rules_on_new_folder):
428 * src/widgets/modest-folder-view.c: (text_cell_data),
429 (icon_cell_data), (filter_row), (update_model),
430 (get_cmp_rows_type_pos):
433 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
434 Do not get the priv struct, because no priv struct has been set,
435 to avoid a runtime warning.
437 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
438 #ifelse with #else, to fix a warning, to fix the build.
441 2007-06-05 Christian Kellner <ckellner@openismus.com>
443 * libmodest-dbus-client/libmodest-dbus-client.c:
444 Fix small typo in doc (why do you always see them
445 AFTER committing stuff?)
448 2007-06-05 Christian Kellner <ckellner@openismus.com>
450 * libmodest-dbus-client/libmodest-dbus-client.c:
451 (libmodest_dbus_client_search):
452 Initialize hit list with NULL. Also set folder list
453 to "" if NULL was supplied.
456 2007-06-03 Christian Kellner <ckellner@openismus.com>
458 * libmodest-dbus-client/libmodest-dbus-client.c:
459 (modest_search_hit_list_free):
460 Make it save to call it with NULL.
462 * src/dbus_api/modest-dbus-callbacks.c:
463 * src/modest-search.c:
464 Return full ModestSearchHits as the search result list not TnyHeader
465 since can't be around withouth the correspoding TnyFolder.
467 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
469 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
470 Added currently commented code to check for secure auth
472 * src/maemo/modest-account-settings-dialog.c: (on_response),
473 (save_configuration), (show_ok):
474 Fixed projects.maemo.org bugs NB #59248 and #59251
476 * src/maemo/modest-maemo-utils.c:
477 (on_camel_account_get_supported_secure_authentication_status),
478 (on_camel_account_get_supported_secure_authentication),
479 (modest_maemo_utils_get_supported_secure_authentication_methods):
480 * src/maemo/modest-maemo-utils.h:
481 Moved get_supported_secure_authentication() method here to be able
482 to use it from easysetup wizard.
484 * src/modest-pair.c: (on_pair_compare_as_string):
485 Should compare string with first part of pair and not
486 strcmp pairs which will crash.
488 * src/modest-protocol-info.c:
489 (modest_protocol_info_protocol_is_store):
490 * src/modest-protocol-info.h:
491 Added modest_protocol_info_get_auth_protocol_name()
493 2007-06-03 Armin Burgmeier <armin@openismus.com>
495 * src/modest-mail-operation.c:
496 (modest_mail_operation_get_msgs_full): Set priv->account also when
497 only retrieving a single message. This avoids a crash when canceling
500 (modest_mail_operation_notify_end): Do not explicitely remove the
501 operation from the queue but only emit the progress_changed signal.
502 The queue itself listens to that signal to remove the operation when
503 it is finished. This reduces coupling and removes a potential deadlock
504 when modest_mail_operation_notify_end() is called from the queue
505 itself. If that is a problem performance-wise, I would suggest to
506 implement a status-changed signal or something.
508 * src/modest-mail-operation-queue.c: Make sure to never call a
509 function from another file while the queue is locked. This (hopefully)
510 fixes another deadlock when exiting the application while retrieving
513 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
515 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
516 Fixed build if libogs is not available
518 2007-06-03 Christian Kellner <ckellner@openismus.com>
520 * libmodest-dbus-client/libmodest-dbus-client.h:
521 * libmodest-dbus-client/libmodest-dbus-client.c:
522 (libmodest_dbus_client_delete_message):
523 Implement deletion of messages (Client side).
525 (modest_search_hit_free),
526 (modest_search_hit_list_free):
527 Utility functions to free the result hits.
529 * src/dbus_api/modest-dbus-api.h:
530 * src/dbus_api/modest-dbus-callbacks.c:
532 (modest_dbus_req_handler):
533 Implement deletion of messages (Server side).
535 * tests/dbus_api/test_search.c: (main):
538 * tests/dbus_api/Makefile.am:
539 * tests/dbus_api/test_delete_message:
540 Add little test for the message deletion logic
542 2007-06-03 Armin Burgmeier <armin@openismus.com>
544 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
545 when the operation queue was not empty. projects.maemo.org bug
548 2007-06-03 Armin Burgmeier <armin@openismus.com>
550 * src/widgets/modest-account-view.c
551 (on_account_default_toggled): Toggle default account column
552 explicitely instead of waiting for gconf notification (which is
553 currently ignored). This should fix projects.maemo.org bug NB#56910
554 for now. It should probably be removed when gconf notifications are
557 2007-06-03 Christian Kellner <ckellner@openismus.com>
559 * libmodest-dbus-client/libmodest-dbus-client.c:
560 Removed debugging spew.
562 * src/dbus_api/modest-dbus-callbacks.c:
563 Added debugging info.
565 * src/modest-search.c:
566 (modest_search_all_accounts):
567 Use tny_account_store_get_accounts () on the account store
568 to get all accounts which is the way to get all accounts.
570 * tests/dbus_api/test_search.c: (main):
571 Make it possible to supply the search term on the command line.
573 2007-06-03 Christian Kellner <ckellner@openismus.com>
575 * libmodest-dbus-client/libmodest-dbus-client.c:
576 * libmodest-dbus-client/libmodest-dbus-client.h:
577 Implement searching for mesages over raw dbus. (Client side)
579 * src/dbus_api/Makefile.am:
580 * src/dbus_api/modest-dbus-api.h:
581 * src/dbus_api/modest-dbus-callbacks.c:
582 * src/dbus_api/modest-dbus-callbacks.h:
583 Search framework (Server side). Also implement on_idle_open_message().
585 * src/maemo/modest-platform.c: (modest_platform_init):
586 Prepare for raw dbus/osso rpc interaction.
588 * src/modest-search.h:
589 Changed minsize from unspecific guint to guint32.
591 * src/modest-search.c:
593 Added strange hack which magically made tnymail work.
595 (modest_search_folder),
596 (modest_search_account),
597 (modest_search_all_accounts):
598 Implement helper functions to search all accounts, specific account
601 * tests/dbus_api/Makefile.am:
602 * tests/dbus_api/test_open_message.c:
603 Read url to open from commandline.
605 * tests/dbus_api/test_search.c:
606 Implement small test for dbus search stuff
608 2007-06-02 Armin Burgmeier <armin@openismus.com>
610 * src/maemo/modest-account-settings-dialog.c: Changed window title to
611 include account type and account title. This fixes projects.maemo.org
614 * src/maemo/modest-account-view-window.c: Set a title for the window.
616 2007-06-02 Armin Burgmeier <armin@openismus.com>
618 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
619 incoming and outgoing server name based on email address and server
620 types as long as the names have not been edited manually. This fixes
621 projects.maemo.org bug NB#58671.
623 2007-06-02 Armin Burgmeier <armin@openismus.com>
625 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
626 server type cannot be changed in future to the incoming details page
627 when creating an account. This fixes projects.maemo.org bug NB#59029.
629 2007-06-02 Armin Burgmeier <armin@openismus.com>
631 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
632 and assigned max width chars so that they wrap instead of being
633 truncated. Fixes projects.maemo.org bug NB#56126.
635 2007-06-02 Armin Burgmeier <armin@openismus.com>
637 * src/maemo/modest-connection-specific-smtp-window.c: Add an
638 introductory note to the connection specific smtp servers dialog, as
639 section 8.12 of the email UI specification requires. This fixes
640 projects.maemo.org bug NB#59212.
642 2007-06-01 Murray Cumming <murrayc@murrayc.com>
644 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
645 Check for running mail operations, and offer to cancel them, as per the UI
646 spec. This fixes projects.maemo.org bug NB#59041 .
647 However, I suspect that tinymail may still use the network connection
648 in ways that we cannot detect or cancel. But it should at least adapt to
651 2007-06-01 Murray Cumming <murrayc@murrayc.com>
653 * src/modest-tny-account-store.c: (recreate_all_accounts),
654 (get_cached_accounts), (get_server_accounts): Do more sensible
655 ref-counting of the temporarily-cached outbox accounts list. This seems
656 to fix a crash when entering the password when the password was wrong.
658 2007-06-01 Murray Cumming <murrayc@murrayc.com>
660 * src/gnome/modest-main-window.c: (connect_signals):
661 * src/modest-tny-account-store.c: (get_password),
662 (modest_tny_account_store_alert): Added comments and clues and
663 commented-out code about how we currently fail to deal with connection
664 errors and wrong passwords, and how we should.
666 2007-06-01 Murray Cumming <murrayc@murrayc.com>
668 * src/widgets/modest-retrieve-combo-box.c:
669 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
670 This fixes projects.maemo.org bug NB#58472 .
672 2007-06-01 Murray Cumming <murrayc@murrayc.com>
674 * src/maemo/easysetup/modest-easysetup-wizard.c:
675 (create_page_complete_easysetup):
676 (create_page_complete_custom): Correct the last commit,
677 putting the correct sentences in the correct pages.
679 2007-06-01 Murray Cumming <murrayc@murrayc.com>
681 * src/maemo/easysetup/modest-easysetup-wizard.c:
682 (create_page_complete_custom): Show the second sentence of text
683 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
686 2007-06-01 Murray Cumming <murrayc@murrayc.com>
688 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
689 Set the leave-on-server conf key by default. This fixes
690 projects.maemo.org bug NB#59258 .
692 2007-06-01 Murray Cumming <murrayc@murrayc.com>
694 * src/maemo/modest-account-view-window.c:
695 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
696 logical ID for the confirmation messages. Fixed projects.maemo.org bug
699 2007-06-01 Murray Cumming <murrayc@murrayc.com>
701 * src/maemo/easysetup/modest-easysetup-wizard.c:
702 (create_caption_new_with_asterisk):
703 * src/maemo/modest-account-settings-dialog.c:
704 (create_caption_new_with_asterisk):
705 Uncomment the code to add the asterisk, because they are no longer in the
706 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
707 (update_incoming_server_title): Add an asterisk here too.
709 2007-06-01 Murray Cumming <murrayc@murrayc.com>
711 * src/maemo/modest-maemo-global-settings-dialog.c:
712 (current_connection): Check that we are even connected before trying to
713 get the current connection name, to prevent a warning.
715 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
716 Change the comments because tny_maemo_conic_device_connect() is now meant to
718 * src/modest-mail-operation.c:
719 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
720 make sure we have a connection and fail if we can't connect.
722 2007-05-31 Murray Cumming <murrayc@murrayc.com>
724 * src/maemo/modest-main-window.c:
725 (on_account_store_connecting_finished): Do not try to get the
726 connection ID if we are not really connected. I am surprised that
727 this signal handler is called when we are not connected.
729 2007-05-31 Murray Cumming <murrayc@murrayc.com>
731 * src/modest-error.h:
732 * src/modest-ui-actions.c:
733 (modest_ui_actions_get_msgs_full_error_handler):
734 Renamed an enum, added comments, added an enum
735 for retrieve-limit errors.
737 * src/modest-mail-operation.c: (foreach_add_item),
738 (internal_folder_observer_update), (update_account_thread),
739 (modest_mail_operation_get_msgs_full):
740 (modest_mail_operation_update_account),
741 Added comments about how this works, and some code that should
742 (but does not) check the retrieve-limit. See the TODO comment.
744 2007-05-31 Murray Cumming <murrayc@murrayc.com>
746 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
747 Initialize help_id to fix the build. Warnings are good.
749 2007-05-31 Murray Cumming <murrayc@murrayc.com>
751 * src/widgets/modest-hbox-cell-renderer.c:
752 (modest_hbox_cell_renderer_append):
753 * src/widgets/modest-vbox-cell-renderer.c:
754 (modest_vbox_cell_renderer_append):
755 Fix the last commit by doing an extra ref.
757 2007-05-31 Murray Cumming <murrayc@murrayc.com>
759 * src/widgets/modest-hbox-cell-renderer.c:
760 (modest_hbox_cell_renderer_append):
761 * src/widgets/modest-vbox-cell-renderer.c:
762 (modest_vbox_cell_renderer_append):
763 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
764 to fix the build with Maemo Bora.
765 However, there seems to be a remaining crash, probably due to reference
768 2007-05-30 Murray Cumming <murrayc@murrayc.com>
770 * src/modest-tny-account.c:
771 (modest_tny_account_new_for_local_folders):
772 Use hildon_file_system_info_async_new() to get a better name for
773 the memory card account, setting it as the account name.
774 The timing seems to work, but this is probably
775 not the best place to do this. See the TODO comment.
776 * src/maemo/modest-main-window.c: (create_details_widget):
777 * src/widgets/modest-folder-view.c: (text_cell_data):
778 Use the tny account name instead of hardcoding a name.
780 2007-05-30 Christian Kellner <ckellner@openismus.com>
782 * src/modest-search.c: (modest_search):
783 Correctly set part_search_func even if we have already parsed
784 the query and thus a valid OgsTextSearcher object.
786 2007-05-30 Christian Kellner <ckellner@openismus.com>
789 Search and check for libogs.
792 Incooparte the ogs build env.
794 * src/modest-mime-part-search-stream.c:
795 * src/modest-mime-part-search-stream.h:
796 Removed since we do the real searching now in modest-search.c.
798 * src/modest-search.c:
799 * src/modest-search.h:
800 Implement support for ogs. We use that if available and requested
801 and fall back to modest_text_utils_utf8_strcmp (). The search logic
802 should now handle the corner case when the search term is spread
803 across multiple reads.
804 Also the logic in modest_search () was corrected to search all
805 requested fields until one is found.
807 2007-05-30 Murray Cumming <murrayc@murrayc.com>
809 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
812 * src/modest-init.c: Made modest_init_local_folders() take a
813 path and be public so we can iniitialize maildir folders on
816 * src/modest-local-folder-info.h:
817 * src/modest-local-folder-info.c:
818 (modest_local_folder_info_get_maildir_path): Add a path parameter.
820 * src/modest-tny-account.c:
821 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
822 still means the standard local-folders path on the local volume.
824 * src/modest-tny-account-store.c:
825 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
826 signal so we can detect mount/unmount of the MMC1 card, and do an update of
827 all accounts when that happens.
828 (get_server_accounts): If the MMC1 card is mounted, create a store account for
829 this too, so it shows up in the treeview.
831 2007-05-28 Murray Cumming <murrayc@murrayc.com>
833 * src/maemo/modest-maemo-global-settings-dialog.c:
834 (current_connection):
835 * src/widgets/modest-global-settings-dialog.c:
836 (current_connection_default):
837 Use the enum values instead of 0, 1 and -1,
838 to make the code clearer.
840 * src/modest-account-mgr-helpers.c:
841 (modest_account_mgr_get_connection_specific_smtp): Make this code
844 * src/modest-runtime.h:
845 * src/modest-runtime.c:
846 Added modest_runtime_remove_all_send_queues().
847 * src/maemo/modest-main-window.c:
848 (on_account_store_connecting_finished): Recreate the send queues,
849 using the appropriate transport accounts for this new connection.
850 Some futher adapting might be needed if the old send queues are not
851 automatically stopped at this point.
853 * src/modest-tny-account-store.c: (get_server_accounts):
854 Create the connection-specific transport accounts, so that they can
855 be found later by their ID.
857 * src/modest-tny-account.h:
858 * src/modest-tny-account.c:
859 Added modest_tny_account_new_from_server_account_name().
860 modest_tny_account_new_from_server_account(): Do not create the
861 send queues here, because they will be
862 recreated anyway when the connection changes for the first time.
864 2007-05-28 Murray Cumming <murrayc@murrayc.com>
866 * src/modest-local-folder-info.h:
867 * src/modest-local-folder-info.c:
868 (modest_per_account_local_outbox_folder_info_get_maildir_path),
869 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
870 tbox_folder): Take a modest account name instead of a server TnyAccount,
871 so we can have per-modest-account rather than per-transport-account
873 We must make sure that we change or recreate the exisitng send queues
874 when the connection changes for connection-specific transport accounts.
876 * src/modest-tny-account-store.c:
877 (create_per_account_local_outbox_folders): Create outboxed per modest
878 account, not per transport account.
880 * src/modest-tny-account.h:
881 * src/modest-tny-account.c:
882 (modest_tny_account_get_special_folder): For outboxes, get the
883 parent modest account name. The account is ignored for other folders.
884 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
885 modest account name rather than a server TnyAccount.
887 2007-05-25 Murray Cumming <murrayc@murrayc.com>
889 * src/modest-tny-account.c:
890 (modest_tny_account_new_from_server_account):
891 Call modest_runtime_get_send_queue() immediately after creating transport
892 accounts, so that they start trying to send email from the outbox as soon
893 as possible at startup. This is probably what we want.
895 * src/modest-mail-operation.c: (update_account_thread):
896 * src/modest-runtime.c: (modest_runtime_get_send_queue):
897 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
898 * src/modest-tny-send-queue.h:
899 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
900 (modest_ui_actions_on_send):
901 Added comments about how sending works, though it needs some more work.
903 2007-05-25 Murray Cumming <murrayc@murrayc.com>
905 * src/modest-tny-account.c:
906 (modest_tny_account_get_special_folder): Add TODO because this fails when
908 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
909 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
910 Do not try to show this window when there is no active account. The UI
911 specs does not tell us what to do in this case.
913 2007-05-24 Murray Cumming <murrayc@murrayc.com>
917 * src/maemo/Makefile.am:
918 * src/widgets/Makefile.am: Some dist fixes.
920 2007-05-24 Murray Cumming <murrayc@murrayc.com>
922 * src/maemo/modest-connection-specific-smtp-window.c:
923 (on_button_edit): Make the code clearer, to prevent a double free.
925 2007-05-24 Murray Cumming <murrayc@murrayc.com>
927 * src/maemo/modest-account-settings-dialog.c:
928 (modest_account_settings_dialog_set_account_name),
929 Check the connection-specific smtp servers checkbox if there are any.
931 * src/maemo/modest-connection-specific-smtp-edit-window.c:
932 (modest_connection_specific_smtp_edit_window_init):
933 Start with a suitable port number.
935 * src/modest-account-mgr-helpers.h:
936 * src/modest-account-mgr-helpers.c: Added
937 modest_account_mgr_get_has_connection_specific_smtp().
939 (modest_account_mgr_set_connection_specific_smtp),
940 (modest_account_mgr_remove_connection_specific_smtp),
941 (modest_account_mgr_get_has_connection_specific_smtp),
942 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
943 connection-specific smtp server accounts in the account, rather than
944 the server account conf dir.
946 This fixes bug projects.maemo.org bug NB#58263 .
948 * src/modest-tny-account-store.c:
949 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
950 if there are no server accounts yet, to prevent an infinite loop when there
951 are no accounts. Document that one must be called before the other.
953 2007-05-24 Murray Cumming <murrayc@murrayc.com>
955 * src/modest-account-mgr-helpers.c:
956 (modest_account_mgr_get_default_account): Make sure that at least
957 one account is always the default, if there are any enabled accounts.
958 This is just a sanity check that shouldn't be necessary.
960 * src/modest-account-mgr-priv.c:
961 (_modest_account_mgr_account_from_key): Unescape the conf key to
962 get the real account name. For instance, this is an issue if a space
963 was in the account name, which can happen because the account name
964 is generated from the display name.
965 (_modest_account_mgr_get_account_keyname): Always escape the
967 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
968 Unescape the conf keys to get the real account names.
970 For instance, previously the is-default radio button in the accounts
971 list was not checked for any accounts at first. This fixes that,
972 and might fix several similar bugs.
974 2007-05-23 Murray Cumming <murrayc@murrayc.com>
976 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
977 Removed some debug printfs.
979 2007-05-23 Murray Cumming <murrayc@murrayc.com>
981 Modest on-disk outbox directories are now here, for instance:
982 $HOME/.modest/outboxes/<account-id-1>/outbox
983 $HOME/.modest/outboxes/<account-id-2>/outbox
985 $HOME/.modest/local-folders/outbox
986 so we can have a separate outbox for each account.
987 But they are shown as one outbox in the GtkTreeView, by using a
988 TnyMergeFolder in a ModestTnySimpleFolderStore.
991 * src/modest-tny-simple-folder-store.c:
992 * src/modest-tny-simple-folder-store.h:
993 Added ModestTnySimpleFolderStore, used to contain folders from
994 other folder stores, such as other accounts.
996 * src/modest-tny-outbox-account.h:
997 * src/modest-tny-outbox-account.c:
998 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
999 used for the per-account local outbox folders.
1001 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1002 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1003 only use this (internally) now for the non-outbox local folders.
1005 * src/modest-init.h:
1006 * src/modest-init.c: Added modest_init_one_local_folder(), for
1007 setting up the directory structure for each local folder.
1009 * src/modest-local-folder-info.c:
1010 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1011 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1013 * src/modest-local-folder-info.h:
1014 * src/modest-tny-account-store.c: (on_account_removed),
1015 (on_account_changed), (create_per_account_local_outbox_folders),
1016 (get_server_accounts), (modest_tny_account_store_get_accounts),
1017 (modest_tny_account_store_get_tny_account_by_account),
1018 (modest_tny_folder_store_is_virtual_local_folders):
1020 * src/modest-tny-account.h:
1021 * src/modest-tny-account.c:
1022 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1023 to create an on-disk per-account local outbox folder for each
1025 (create_per_account_local_outbox_folders): Create a local outbox folder
1026 for each transport account.
1027 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1028 for all local folders.
1030 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1031 instead of using g_object_get/set() directly. It is clearer.
1033 (modest_tny_folder_store_get_message_count),
1034 (modest_tny_folder_store_get_local_size
1035 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1036 because we now use these with non-acount folder stores.
1038 (modest_tny_account_get_special_folder),
1039 (modest_tny_account_new_from_server_account),
1040 (modest_tny_account_new_from_account):
1041 (recurse_folders): Adjust to the new outbox system.
1043 * src/modest-tny-folder.h:
1044 * src/modest-tny-folder.c:
1045 (modest_tny_folder_is_local_folder),
1046 (modest_tny_folder_get_local_folder_type),
1047 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1049 * src/widgets/modest-main-window.h:
1050 * src/maemo/modest-main-window.c: (create_details_widget),
1051 (modest_main_window_set_contents_style): Show details for any folder store,
1054 (modest_tny_folder_get_rules):
1055 Remove the const. C does not support constness enough for this.
1057 * src/modest-ui-actions.c:
1058 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1059 make all outboxes appear as one, in the usual local-folders tree node.
1061 (set_active_account_from_tny_account),
1062 (modest_ui_actions_on_folder_selection_changed):
1063 * src/widgets/modest-folder-view.c: (text_cell_data),
1064 (icon_cell_data), (filter_row),
1065 (add_account_folders_to_merged_folder),
1066 (add_account_folders_to_simple_folder_store), (),
1067 (get_cmp_rows_type_pos), (cmp_rows),
1068 (modest_folder_view_set_account_id_of_visible_server_account):
1069 Adjust to the new outbox system, using generic folder stores and folders
1070 in the GtkTreeModel.
1072 2007-05-23 Christian Kellner <ckellner@openismus.com>
1074 * src/modest-mail-operation.c:
1075 (modest_mail_operation_update_account):
1076 Use info->max_size instead of unintialized local var [small
1077 build fix]. (Added TODO to review that change since I don't
1080 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1082 * libmodest-dbus-client/libmodest-dbus-client.c:
1083 (libmodest_dbus_client_compose_mail): function added
1084 * src/dbus_api/modest-dbus-api.h:
1085 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1086 (on_compose_mail): Implementation of the SendAsMail functionality
1088 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1090 * src/modest-account-mgr.c:
1091 (modest_account_mgr_add_server_account): Set the secure-connection
1092 conf key for transport accounts as well as store accounts. I don't know
1093 why the if was there. For instance, this makes sure that we use SSL
1094 for the gmail preset from the easysetup wizard.
1096 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1098 * src/gnome/modest-main-window.c:
1099 (on_account_store_connecting_finished), (connect_signals):
1100 * src/maemo/modest-main-window.c:
1101 (on_account_store_connecting_finished), (connect_signals),
1102 (modest_main_window_new):
1103 Handle TnyAccountStore::connecting-finished instead of
1104 TnyDevice::connection-changed, because we cannot actually perform
1105 operations on accounts until TnyAccountStore has itself responded to
1106 the TnyDevice::connection-changed signal. This prevents a GError from
1108 Do not try to update at startup, because we (at least on scratchbox)
1109 already do an update at startup when the device goes online.
1110 This prevents a GError from tinymail.
1111 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1112 Added TODO about stopping simultaneous operations.
1114 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1116 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1117 * src/modest-mail-operation-queue.c:
1118 (modest_mail_operation_queue_remove):
1119 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1120 about where they happened.
1122 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1124 * src/modest-ui-actions.c:
1125 (modest_ui_actions_on_password_requested): Make sure that the remember
1126 output parameter is always TRUE.
1128 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1130 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1131 Show a OK/Cancel dialog if the error is a question, though we still do not
1132 know anything more about what we are asking the user.
1133 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1134 Fix an uninitialized variable (helper). This is a logic error, however.
1136 2007-05-21 Christian Kellner <ckellner@openismus.com>
1138 * src/modest-search.h:
1139 Correct bit shifting in the ModestSearchFlags enum.
1141 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1143 * src/modest-tny-account.c:
1144 (modest_tny_account_new_from_server_account): Do not use the lsub and
1145 check-all hard-coded IMAP options when using POP.
1147 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1149 * src/modest-tny-account.c:
1150 (modest_tny_account_new_from_server_account):
1151 Use NULL for the secure-auth method for POP when Password auth has been
1152 specified by the user, as we already do for IMAP. "auth=Login" causes
1153 an error from camel or the server.
1155 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1157 * src/maemo/modest-account-settings-dialog.c:
1158 (create_page_account_details),
1159 (modest_account_settings_dialog_set_account_name):
1160 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1161 for the leave-on-server checkbox, rathr than just the checkbox, when
1162 the protocol is not POP.
1164 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1166 * src/widgets/modest-account-view.c:
1167 * src/widgets/modest-account-view.h:
1168 Added modest_account_view_select_account() which will be useful later
1169 to asynchronously re-select the edited account.
1171 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1173 * src/maemo/modest-account-settings-dialog.c:
1174 (modest_account_settings_dialog_set_account_name):
1175 Automatically choose the port numbers based on the secure authentication
1176 methods, if they have not been chosen before.
1177 This fixes projects.maemo.org bug NB#56273 .
1179 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1181 * src/maemo/modest-main-window-ui.h:
1182 * src/modest-ui-actions.c:
1183 * src/modest-ui-actions.h:
1184 Connect the Tools/SMTP Servers menu item to
1185 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1186 SMTP servers dialog, as in the UI specification and saves changes when it
1187 is closed. This fixed projects.maemo.org bug NB#56305 .
1189 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1191 * src/maemo/modest-connection-specific-smtp-window.c:
1192 (modest_connection_specific_smtp_window_init):
1193 Use gtk_window_set_default_size() to make this window big enough, so
1194 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1196 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1198 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1199 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1200 (modest_connection_specific_smtp_edit_window_init),
1201 Do not try to connect to a combobox signal before the combobox exists.
1202 This fixes the cras in projects.maemo.org bug NB#56288 .
1203 (modest_connection_specific_smtp_edit_window_get_settings):
1204 Remove the server_account_name parameter which was being checked for NULL
1205 though it was not used.
1207 * src/maemo/modest-connection-specific-smtp-window.c:
1208 (modest_connection_specific_smtp_window_fill_with_connections),
1209 (on_button_edit), (modest_connection_specific_smtp_window_init):
1210 Correct the number of treemodel columns to prevent a warning.
1211 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1212 libconic does not work.
1214 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1216 * src/modest-tny-account.c:
1217 (modest_tny_account_new_from_server_account):
1218 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1219 SMTP when "None" was chosen by the user. However, with my SMTP server that
1220 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1223 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1225 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1226 to explain the memory management issue with the ID in the ModestPair.
1228 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1229 (add_sending_page), (modest_account_assistant_finalize):
1230 * src/gnome/modest-gnome-global-settings-dialog.c:
1231 (create_updating_page), (create_composing_page):
1232 * src/gnome/modest-msg-edit-window.c: (get_transports),
1233 (init_window), (modest_msg_edit_window_finalize),
1234 (modest_msg_edit_window_get_msg_data):
1235 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1236 * src/gnome/modest-transport-widget.c:
1237 (modest_transport_widget_finalize), (smtp_configuration):
1238 * src/maemo/modest-maemo-global-settings-dialog.c:
1239 (create_updating_page), (create_composing_page):
1240 * src/maemo/modest-msg-edit-window.c: (get_transports),
1241 (init_window), (modest_msg_edit_window_finalize),
1242 (modest_msg_edit_window_get_msg_data),
1243 (modest_msg_edit_window_free_msg_data):
1244 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1245 (modest_store_widget_finalize):
1246 * src/maemo/modest-transport-widget.c:
1247 (modest_transport_widget_finalize), (smtp_configuration):
1248 * src/modest-main.c: (send_mail):
1249 * src/widgets/modest-combo-box.h:
1250 * src/widgets/modest-global-settings-dialog-priv.h:
1251 * src/widgets/modest-global-settings-dialog.c:
1252 (modest_global_settings_dialog_finalize):
1253 * src/widgets/modest-msg-edit-window.h:
1254 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1255 as long as the combo box, to prevent use of freed memory for the ID.
1257 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1259 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1260 get_accounts(), to make this clearer. Do not check for the enabled gconf
1261 key, because we do not use this for server accounts (at least, not yet).
1262 This allows us to send email again.
1264 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1266 * src/maemo/modest-platform.c:
1267 (on_modest_conf_update_interval_changed), (modest_platform_init):
1268 Only respond to this particular key change. All these strcmp()s cannot be
1271 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1273 * src/maemo/modest-maemo-global-settings-dialog.c:
1274 (current_connection): Prevent a crash in scratchbox when
1275 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1276 * src/maemo/modest-platform.c:
1277 (on_modest_conf_update_interval_changed), (modest_platform_init):
1278 Get the update interval from gconf and reset it when the gconf key changes.
1280 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1282 * src/modest-protocol-info.c:
1283 * src/modest-protocol-info.h: Adde enum-specific get functions,
1284 instead of using a ModestProtocolType enum parameter.
1286 * src/gnome/modest-account-assistant.c:
1287 * src/gnome/modest-store-widget.c:
1288 * src/gnome/modest-store-widget.h:
1289 * src/gnome/modest-transport-widget.c:
1290 * src/gnome/modest-transport-widget.h:
1291 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1292 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1293 * src/maemo/easysetup/modest-easysetup-wizard.c:
1294 * src/maemo/modest-account-settings-dialog.c:
1295 * src/maemo/modest-account-settings-dialog.h:
1296 * src/maemo/modest-store-widget.c:
1297 * src/maemo/modest-store-widget.h:
1298 * src/maemo/modest-transport-widget.c:
1299 * src/maemo/modest-transport-widget.h:
1300 * src/modest-account-mgr-helpers.c:
1301 * src/modest-account-mgr-helpers.h:
1302 * src/modest-account-mgr.c:
1303 * src/modest-account-mgr.h:
1304 * src/modest-tny-account.c:
1305 * src/modest-tny-folder.c:
1306 * src/widgets/modest-account-view.c:
1307 * src/widgets/modest-retrieve-combo-box.c:
1308 * src/widgets/modest-retrieve-combo-box.h:
1309 * src/widgets/modest-secureauth-combo-box.c:
1310 * src/widgets/modest-serversecurity-combo-box.c:
1311 * src/widgets/modest-serversecurity-combo-box.h:
1312 * tests/check_account-mgr.c:
1313 Use the specific functions, and use the re-renamed enum values for GNOME too.
1315 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1317 * src/modest-pair.h:
1318 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1319 so we can get the second based on the first.
1321 * src/maemo/modest-account-settings-dialog.h:
1322 * src/maemo/modest-account-settings-dialog.c:
1323 Added get_supported_secure_authentication_methods(), though it is mostly
1324 commented-out for now until the necessary API is committed to tinymail.
1325 (modest_account_settings_dialog_set_account_name),
1326 (save_configuration): Request the supported authentication methods from the
1327 server, so we can choose a working method.
1329 * src/modest-tny-account-store.h:
1330 * src/modest-tny-account-store.c:
1331 (modest_tny_account_store_get_session): Rename from
1332 tny_account_store_get_session().
1334 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1336 * src/modest-protocol-info.h: Split the ModestProtocol enum
1337 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1338 There was no need to have these unrelated values in one enum.
1340 * src/: many files: Adapted to changed enum. This makes the code a bit
1341 clearer, and the compiler could catch some errors.
1343 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1345 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1346 Show the detailed internal camel error message when an error happens
1347 during the configuration, so that our testers can give us more clues.
1348 For instance, in projects.maemo.org bug NB#56910 .
1350 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1352 * src/modest-tny-account.c:
1353 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1354 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1356 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1358 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1359 * src/maemo/modest-account-settings-dialog.c:
1360 (modest_account_settings_dialog_set_account_name),
1361 (save_configuration): For the incoming secure authentication checkbox,
1362 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1363 the UI specification. PLAIN does not seem to be supported for most IMAP
1364 servers anyway, and I am not sure what it would mean.
1365 However, we probably need to discover which of the secure-authentication
1366 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1367 * src/modest-account-mgr-helpers.c:
1368 (modest_account_mgr_get_server_account_data):
1370 * src/modest-tny-account.c:
1371 (modest_tny_account_new_from_server_account):
1372 Use tny_account_set_mech() to set secure-authentication methods,
1373 with some special-casing for IMAP, based on my observations of how
1376 * src/modest-account-mgr-helpers.h:
1377 * src/modest-account-mgr.c:
1378 * src/modest-defs.h: Comment that the URI is only used for local folders.
1380 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1382 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1383 parameter const, just to be neat.
1384 * src/modest-text-utils.c: (modest_text_utils_inline):
1385 End g_strconcat() with NULL, as its documentation says. This is almost
1386 certainly the cause of my crash at startup on the device. Interestingly,
1387 valgrind doesn't tell us about these errors.
1389 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1391 * scripts/build-packages: Added more precise comments about how to use
1392 this script, though I still get this error:
1393 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1394 error building tinymail
1396 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1398 * src/maemo/modest-main-window.c: (on_account_update):
1399 Very slight cleanup, hoping to make it simpler to discover what causes
1400 a crash here sometimes.
1402 * src/modest-tny-account.c:
1403 (modest_tny_account_new_from_server_account): Set the port. Added
1404 comments about the options and a TODO comment because I need to find out
1405 how to specify the secure authentication method.
1407 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1409 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1410 changed CFlags paths form modest to libmodest
1412 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1414 * src/modest-account-mgr-helpers.c:
1415 (modest_account_mgr_get_server_account_data),
1416 (modest_account_mgr_free_server_account_data):
1417 * src/modest-account-mgr-helpers.h:
1418 * src/modest-account-mgr.c:
1419 (modest_account_mgr_add_server_account):
1420 * src/modest-defs.h:
1421 * src/modest-tny-account.c:
1422 (modest_tny_account_new_from_server_account):
1423 Determine the options for tny_camel_account_add_option() here,
1424 based on the settings, rather than storing them directly in gconf.
1426 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1428 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1429 Show a more friendly error dialog now that we expect (from the tinymail
1430 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1432 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1434 * src/maemo/modest-main-window.c: (on_account_update): Check that
1435 account_name is not NULL, to prevent a crash at startup that I am
1436 seeing on the N800. I do wonder why it is NULL.
1438 * src/maemo/easysetup/modest-easysetup-wizard.c:
1439 (create_page_user_details):
1440 * src/maemo/modest-account-settings-dialog.c:
1441 (create_page_user_details), (create_page_outgoing):
1442 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1443 (modest_connection_specific_smtp_edit_window_init):
1444 * src/modest-ui-actions.c:
1445 (modest_ui_actions_on_password_requested):
1446 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1447 might do something useful with the on-screen keyboard.
1449 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1451 * src/maemo/modest-main-window.c: (on_account_update):
1452 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1453 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1455 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1457 * src/modest-tny-account-store.c: (on_account_changed):
1458 Correct the signature of this signal handler.
1460 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1462 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1463 Show a HildonNote instead of a GtkDialog for Maemo.
1465 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1467 * src/widgets/modest-account-view.h:
1468 * src/widgets/modest-account-view.c: (on_account_changed),
1469 (on_account_removed). Added a boolean flag, set/unset by
1470 modest_account_view_block_conf_updates(),
1471 modest_account_view_unblock_conf_updates() to prevent unnecessary
1472 updates, but this is not very useful because the gconf notifications are
1473 so delays (maybe only on Maemo Bora).
1474 So auto-updating is turned off, and these functions do an explicit
1475 update when necessary.
1476 However, something else is still doing too much work when adding/removing
1477 accounts, probably in another part of the application.
1479 * src/maemo/modest-account-view-window.c:
1480 (on_delete_button_clicked), (on_edit_button_clicked),
1481 (on_new_button_clicked): Use the new functions.
1483 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1485 * src/modest-account-mgr-helpers.c:
1486 (modest_account_mgr_set_first_account_as_default):
1487 Sort the list of names alphabetically-by-title, so we choose the first one
1489 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1490 alphabetically by the title.
1492 This fixes projects.maemo.org bug NB#56418 .
1494 * src/modest-account-mgr-priv.c:
1495 (_modest_account_mgr_account_from_key):
1496 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1497 avoid a valgrind error, and possible random behaviour.
1499 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1501 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1502 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1503 tinymail documentation to say that this can be expected.
1504 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1505 pretty, and should not happen, but I would prefer to know when it does.
1507 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1509 * configure.ac: When using the older hildon version, probably on Bora,
1510 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1512 * src/widgets/modest-attachment-view.c:
1513 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1516 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1518 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1519 Implemented the prototype. Can be tested with
1520 tests/dbus_api/test_open_message:
1522 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1524 * src/modest-tny-account-store.c:
1525 (modest_tny_account_store_instance_init), (get_password):
1526 * src/modest-ui-actions.c:
1527 (modest_ui_actions_on_password_requested):
1528 Do not store the password in gconf, because this function is called
1529 for non-remembered passwords. Actually use the cached (in the hash map)
1530 password instead of releasing it.
1531 The password will now not be remembered if it is asked via the protected
1532 password dialog, as per the UI spec.
1534 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1536 * src/modest-defs.h:
1537 * src/modest-account-mgr-helpers.h:
1538 * src/modest-account-mgr-helpers.c:
1539 Added modest_server_account_get_username_has_succeeded(),
1540 modest_server_account_set_username_has_succeeded().
1541 (modest_server_account_set_username),
1542 Reset the has-succeeded flag if the username changes.
1544 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1545 * src/maemo/modest-connection-specific-smtp-window.c:
1546 (modest_connection_specific_smtp_window_save_server_accounts):
1547 Use modest_server_account_set_username() instead of using
1548 modest_conf_set_string() directly, so that the has-succeeded flag is always
1551 * src/modest-ui-actions.c:
1552 (modest_ui_actions_on_password_requested): Dim the username entry if
1553 the username has ever worked, as per the UI spec.
1555 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1557 * src/modest-tny-account-store.c: (get_password):
1558 * src/modest-ui-actions.c:
1559 (modest_ui_actions_on_password_requested):
1560 Allow the username to be changed too, though there is more work to
1561 be done on exactly how this behaves.
1563 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1565 * src/modest-account-mgr-helpers.h:
1566 * src/modest-account-mgr-helpers.c:
1567 Added modest_account_mgr_get_display_name(),
1568 modest_server_account_get_username(),
1569 modest_server_account_set_username(),
1570 modest_server_account_set_password(),
1571 modest_server_account_get_hostname() functions so we do not need to
1572 use the conf API directly.
1574 * src/maemo/modest-main-window.c: (connect_signals):
1575 Actually connect ot the ModestAccountStore::request-password signal,
1576 so that we show the dialog when the password is requested by Tinymail,
1577 for isntance if it is empty.
1579 * src/modest-marshal.list:
1580 * src/modest-tny-account-store.c:
1581 (modest_tny_account_store_class_init), (get_password),
1582 (modest_tny_account_store_alert):
1583 * src/modest-tny-account-store.h:
1584 * src/modest-ui-actions.h:
1585 * src/modest-ui-actions.c:
1586 (modest_ui_actions_on_password_requested):
1587 Change the signal parameters, so it is obvious that we are providing
1588 the non human-readable server name, and receiving both the username
1589 and password, though changing of the username is not yet implemented.
1590 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1591 for the GNOME version.
1593 This should fix the projects.maemo.org bug NB#56209, though it does not
1594 work on Bora, because the gconf_client_get() for the password fails
1595 immediately after we save it with gconf_client_set().
1597 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1600 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1601 caused an undefined symbol error:
1602 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1604 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1606 * src/modest-tny-account-store.c:
1607 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1608 using a GError instead of a string message, so we can translate it in
1611 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1613 * src/maemo/modest-address-book.c:
1614 (modest_address_book_check_names):
1615 * src/maemo/modest-msg-view-window.c:
1616 (modest_msg_view_window_clipboard_owner_change):
1617 * src/modest-init.c: (modest_init_init_ui):
1618 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1619 (update_folders_cb), (modest_mail_operation_update_account):
1620 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1621 (modest_ui_actions_on_msg_attachment_clicked),
1622 (modest_ui_actions_on_msg_recpt_activated):
1623 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1624 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1625 (modest_msg_view_search_next):
1626 * src/widgets/modest-recpt-editor.c:
1627 (modest_recpt_editor_on_button_release_event),
1628 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1629 g_message(). At this point we should only be seeing interesting errors on
1630 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1632 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1634 (modest_wizard_dialog_force_title_update):
1635 * src/maemo/easysetup/modest-wizard-dialog.h:
1636 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1637 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1638 can update the title when appropriate. Otherwise the title is wrong if the
1639 pages are added after adding the notebook to the dialog.
1640 This must be a problem in HildonWizardDialog too.
1641 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1643 * src/maemo/easysetup/modest-easysetup-wizard.c:
1644 (create_subsequent_customsetup_pages),
1645 (create_subsequent_easysetup_pages):
1646 Call modest_wizard_dialog_force_title_update() so that the title is
1647 correct even with GTK+ < 2.10.
1648 This fixes projects.maemo.org bug NB#56145 .
1650 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1652 * src/maemo/modest-platform.c:
1653 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1654 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1657 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1659 * src/widgets/modest-window.h:
1660 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1661 and modest_window_save_state(), which invokes it.
1663 * src/widgets/modest-window-mgr.h:
1664 * src/widgets/modest-window-mgr.c:
1665 Added modest_window_mgr_save_state_for_all_windows(), which calls
1666 the save_state vfunc on all registered windows, if implemented.
1668 * src/gnome/modest-msg-edit-window.c:
1669 * src/gnome/modest-msg-view-window.c:
1670 * src/maemo/modest-msg-edit-window.c:
1671 * src/maemo/modest-msg-view-window.c:
1672 * src/maemo/modest-main-window.c:
1673 Specify the existing save_settings functions as implementations of
1674 ModestWindow::save_state_func().
1676 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1677 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1678 enabling hibernation, for instance.
1680 We may need to do the same thing for restoring settings.
1683 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1685 * src/widgets/modest-window-mgr.c:
1686 * src/widgets/modest-window-mgr.h:
1687 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1688 modest_window_mgr_get_hibernation_is_prevented().
1690 * src/maemo/modest-main-window.c:
1691 (on_hildon_program_is_topmost_notify): Prevent hibernation
1692 (possible when the application goes to the background in the WM),
1693 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1695 * src/maemo/easysetup/modest-easysetup-wizard.c:
1696 (modest_easysetup_wizard_dialog_init):
1697 * src/maemo/modest-account-settings-dialog.c:
1698 (modest_account_settings_dialog_init):
1699 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1700 (modest_connection_specific_smtp_edit_window_init):
1701 * src/maemo/modest-connection-specific-smtp-window.c:
1702 (modest_connection_specific_smtp_window_init):
1703 * src/maemo/modest-signature-editor-dialog.c:
1704 (modest_signature_editor_dialog_init):
1705 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1706 prevent hibernation while any of these account settings dialogs are open.
1708 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1710 * src/maemo/Makefile.am:
1711 * src/maemo/modest-osso-state-saving.c:
1712 * src/maemo/modest-osso-state-saving.h: Added
1713 modest_osso_load_state() and modest_osso_save_state() though they do
1714 nothing now. They should iterate through all the open windows and load/save
1716 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1717 save state when closing.
1719 * src/maemo/modest-main-window.c:
1720 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1721 Add a notification handler for the HildonProgram::is-topmost property,
1722 so we can allow hibernation when the application goes into the background.
1723 But we still need to detect when the accounts setup windows are open so
1724 we can stop hibernation when they are open.
1725 To do this, I also added the main window the HildonProgram. This might have
1726 other side-effects/benefits, and should maybe be done for other windows.
1728 * src/maemo/modest-osso-autosave-callbacks.h:
1729 * src/maemo/modest-osso-autosave-callbacks.c:
1730 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1731 though it does not do anything yet, and we might never need this to do
1732 anything. For instance, we already save drafts.
1734 * src/maemo/modest-platform.c: (modest_platform_init):
1735 Specify the libosso auto-save callback.
1737 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1739 * src/maemo/modest-platform.c:
1740 (modest_platform_set_update_interval):
1741 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1742 aparently stays valid between application instances, so we can use this
1743 to remove and reset it later. According to a maemo-developers email from
1746 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1748 * configure.ac: Depend on libalarm for Maemo.
1750 * src/dbus_api/modest-dbus-api.h:
1751 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1752 (on_send_receive), (modest_dbus_req_handler):
1753 Handle a SEND_RECEIVE D-Bus method.
1755 * libmodest-dbus-client/libmodest-dbus-client.c:
1756 (libmodest_dbus_client_send_and_receive):
1757 * libmodest-dbus-client/libmodest-dbus-client.h:
1758 Add C convenience functions for calling the new D-Bus method.
1760 * src/modest-platform.h:
1761 * src/gnome/modest-platform.c:
1762 * src/maemo/modest-platform.c:
1763 Added modest_platform_set_update_interval(), which uses the
1764 alarmd API on Maemo.
1765 (modest_platform_init),
1766 Call modest_platform_set_update_interval(), using a hard-coded
1767 interval for now (until the global settings dialog is implemented),
1768 though I am not sure that this makes sense yet.
1770 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1772 * src/dbus_api/modest-dbus-callbacks.c:
1773 (modest_osso_cb_hw_state_handler):
1774 * src/dbus_api/modest-dbus-callbacks.h:
1775 * src/maemo/modest-platform.c: (modest_platform_init):
1776 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1777 in case this has some effect on the ability for Maemo to ping the
1780 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1782 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1783 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1784 warning. It is probably a logic error, but I need to fix the build.
1786 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1788 * src/modest-account-mgr.h:
1789 * src/modest-account-mgr.c:
1790 (modest_account_mgr_account_names): Add a gboolean enabled_only
1791 parameter, so we can get lists of onlt the enabled accounts.
1793 (modest_account_mgr_add_account),,
1794 (modest_account_mgr_account_with_display_name_exists):
1795 * src/maemo/modest-msg-edit-window.c: (get_transports):
1796 * src/modest-account-mgr-helpers.c:
1797 (modest_account_mgr_set_first_account_as_default):
1798 * src/modest-init.c: (init_default_account_maybe):
1799 * src/modest-tny-account-store.c: (get_accounts):
1800 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1801 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1802 * tests/check_account-mgr.c: (START_TEST):
1803 Provide the extra parameter, as appropriate.
1805 * src/widgets/modest-account-view.c: (update_account_view):
1806 Do not show disabled accounts (meaning that there is no way to
1807 enable/disable accounts in the UI (the feature is not in our UI
1808 specification), so we can use this internally only to mark unfinished
1809 or temporary account data.
1811 * src/maemo/easysetup/modest-easysetup-wizard.c:
1812 (create_account): Add boolean enable parameter, so we can specify FALSE
1813 to create the temporary account.
1814 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1815 (on_before_next): When finishing, when there is a temporary account, just
1817 Also, use a timeout to delay the showing of the dialog until gconf is likely
1818 to return correct information, due to a maemo gconf bug that is fixed in
1819 osso 1.1, but not yet in Bora.
1820 However, the dialog stays on screen after it is destroyed.
1822 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1823 for invalid data when cancelling. Use a hildon note instead of a dialog
1824 to complain about invalid data. Do not show the account-saved note if the
1825 account is disabled (a temporary account that will not really be saved for use
1828 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1830 * src/modest-account-mgr-helpers.h:
1831 * src/modest-account-mgr-helpers.c:
1832 Added modest_account_mgr_unset_default_account(),
1833 Added modest_account_mgr_set_first_account_as_default().
1835 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1836 If it was the default account, unset the default account name.
1838 * src/maemo/modest-account-view-window.c:
1839 (on_delete_button_clicked): If it was the default account,
1840 set the first remaining account as the default instead.
1842 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1843 a NULL account or a NULL default account, to prevent a crash. This should
1844 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1847 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1849 * src/widgets/modest-recpt-editor.c:
1850 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1851 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1852 TODO comment for this. This fixes the build.
1854 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1855 be the best place for it. This will in future update all auto-update accounts,
1856 rather than just the current/default account, when that gconf key exists.
1857 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1858 if there are no accounts, before calling do_send_receive().
1859 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1861 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1862 * src/maemo/modest-main-window-ui.h:
1863 * src/maemo/modest-main-window.c: (on_connection_changed),
1864 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1865 directly, becaue the signal handler does more.
1867 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1869 * src/modest-account-mgr-helpers.c:
1870 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1871 for the case that the account does not exist.
1873 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1874 (equivalent to the modest account name) rather than the tinymail account name
1875 (equivalent to the modest account title - human readable) to get the account data.
1876 Check for null account data to prevent the crash, and add a TODO comment saying that
1877 this needs fixing because it is using the server account name instead of the account name.
1879 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1881 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1882 * src/maemo/modest-account-settings-dialog.c: (show_error),
1884 Use hildon_note_new_information() for informative and error messages,
1885 which seems to be expected for Maemo applications (no documentation that I know of
1886 says this). I am surprised that there is no distinction between info and error
1889 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1891 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1892 it is easy to find where this is used.
1894 * src/maemo/easysetup/modest-easysetup-wizard.c:
1895 (create_page_welcome), (create_page_account_details),
1896 (create_page_user_details), (create_page_complete_easysetup),
1897 (create_page_custom_incoming), (create_page_custom_outgoing),
1898 (create_page_complete_custom):
1899 * src/maemo/modest-account-settings-dialog.c:
1900 (create_page_account_details), (create_page_user_details),
1901 (create_page_incoming), (create_page_outgoing):
1902 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1903 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1904 (modest_connection_specific_smtp_edit_window_init):
1905 * src/maemo/modest-connection-specific-smtp-window.c:
1906 (modest_connection_specific_smtp_window_init):
1907 * src/maemo/modest-signature-editor-dialog.c:
1908 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1909 and scrolling policy as per the Email Application Layout Guide, if I have
1912 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1914 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1915 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1916 which were empty, because these vfuncs have been removed from TnyAccountStore.
1917 This fixes the build.
1919 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1921 * src/maemo/modest-main-window.c:
1922 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1923 showing/hiding it. Added TODO because it probably should not be NULL.
1924 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1925 because unnecessary g_warnings() make degugging difficult.
1927 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1929 * src/maemo/modest-msg-edit-window.c:
1930 (modest_msg_edit_window_select_color),
1931 (modest_msg_edit_window_select_background_color): 2 const corrections and
1932 moving 2 #endifs before closing brackets, to fix the build.
1934 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1936 * src/maemo/easysetup/modest-easysetup-wizard.h:
1937 * src/maemo/easysetup/modest-easysetup-wizard.c:
1938 (modest_easysetup_wizard_dialog_finalize),
1939 (on_button_edit_advanced_settings), (create_page_complete_custom),
1940 (on_response), (create_account):
1941 Implement the Advanced Settings edit button, by saving the account information,
1942 for the Advanded Settings dialog to use directly from gconf, and removing it
1943 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1944 Bug #5533 in the projects.maemo.org bugzilla.
1946 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1948 * src/maemo/modest-msg-view-window.c:
1949 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1950 when opening a message window.
1952 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1954 * src/maemo/easysetup/modest-easysetup-wizard.c:
1955 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1958 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1959 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1960 gconf settings. I probably added more checks than necessary, but that is safer.
1962 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1963 variable to fix the build, but this seems to be used when it is still NULL.
1965 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1967 * src/modest-platform.h:
1968 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1969 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1970 * src/modest-main.c: Implement this function so we can avoid using
1971 maemo-specific API from cross-platform code.
1973 * src/modest-tny-account-store.c:
1974 (get_smtp_specific_transport_account_for_open_connection):
1975 * src/modest-ui-actions.c: (check_for_connection),
1976 (modest_ui_actions_on_item_not_found):
1977 Use modest_platform_connect_and_wait() and put #idefs around other
1978 maemo-specific code, because only maemo currently has a way to
1979 identify connection names.
1981 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1983 * src/modest-tny-account-store.h:
1984 * src/modest-tny-account-store.c:
1985 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1986 the connection-specific SMTP server settings in the configuration.
1988 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1990 * src/maemo/modest-main-window.c: (on_connection_changed),
1992 * src/modest-main.c: (main), (start_ui), (send_mail):
1993 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1994 that is what is intended.
1996 * src/modest-ui-actions.c: (action_send), (action_receive),
1997 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1998 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1999 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2000 SMTP server is used when it is specified.
2002 (modest_ui_actions_on_send_receive):
2003 Check that a connection is open before proceeding.
2004 Receive and then send, instead of vice-versa, as per the specification.
2006 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2008 * src/modest-mail-operation.c:
2009 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2010 though I guess it should be something other than NULL.
2012 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2014 * src/maemo/easysetup/modest-easysetup-wizard.c:
2015 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2016 combo twice, to avoid an g_warning and to make it visible again.
2017 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2018 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2019 (already intended) dereference when detaching, because we then recreate the menu.
2020 But I am not sure why the warning was happening, and it is possible that this is a memory
2023 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2025 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2026 and uri_parse_mailto() utility functions.
2027 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2029 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2031 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2033 * src/dbus_api/modest-dbus-api.h:
2034 * src/dbus_api/modest-dbus-callbacks.c:
2035 Use an idle callback to execute the modest code in the application's own thread.
2036 Remove the helloworld example method.
2037 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2038 parsed, and the open-message method is not implemented because this is not yet implemented in
2040 * libmodest-dbus-client/libmodest-dbus-client.c:
2041 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2042 (libmodest_dbus_client_open_message):
2043 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2045 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2046 body without crashing.
2048 * tests/dbus_api/Makefile.am:
2049 * tests/dbus_api/test_mail_to.c:
2050 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2052 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2054 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2055 Added file to fix the build. Sorry.
2057 * src/dbus_api/Makefile.am:
2058 * src/dbus_api/modest-dbus-api.h:
2059 * src/dbus_api/modest-dbus-callbacks.h:
2060 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2061 (modest_dbus_req_handler):
2062 Put constants in a separate header so it can be reused by the
2063 client library, without duplication
2065 * libmodest-dbus-client/Makefile.am:
2066 * libmodest-dbus-client/libmodest-dbus-client.c:
2067 (libmodest_dbus_client_call_helloworld),
2068 (libmodfest_dbus_client_send_mail),
2069 (libmodfest_dbus_client_mailto),
2070 (libmodfest_dbus_client_open_message):
2071 * libmodest-dbus-client/libmodest-dbus-client.h:
2072 (Partly) Implement a send_mail D-Bus method.
2074 * tests/dbus_api/Makefile.am:
2075 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2076 the send_email D-Bus method.
2078 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2082 * libmodest-dbus-client/Makefile.am:
2083 * libmodest-dbus-client/libmodest-dbus-client.c:
2084 * libmodest-dbus-client/libmodest-dbus-client.h:
2085 * tests/dbus_api/Makefile.am:
2086 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2087 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2089 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2091 * src/maemo/easysetup/modest-easysetup-wizard.c:
2092 (create_page_account_details):
2093 * src/maemo/modest-account-settings-dialog.c:
2094 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2095 widgets, because this might not be the default in future versions of the Maemo GTK+.
2096 However, I can not not get capitalization to work even in a simple test case.
2098 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/easysetup/modest-easysetup-wizard.c:
2101 (create_page_custom_incoming), (create_page_custom_outgoing):
2102 * src/maemo/modest-account-settings-dialog.c:
2103 (create_page_account_details), (create_page_incoming),
2104 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2105 instead of using gtk_check_button_with_label(), so they are aligned like the other
2106 widgets, as per the UI spec.
2108 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2110 * src/maemo/easysetup/modest-easysetup-wizard.c:
2111 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2112 * src/widgets/modest-validating-entry.c:
2113 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2114 Modest prefix instead of an EasySetup prefix.
2116 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2118 * src/widgets/modest-validating-entry.h:
2119 * src/widgets/modest-validating-entry.c: (on_insert_text),
2120 Added easysetup_validating_entry_set_max_func(), used to set a callback
2121 to call when the max number of characters is reached. GtkEntry has a max-length
2122 already but is silent about it.
2124 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2125 (create_page_account_details), (create_page_user_details),
2127 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2128 (create_page_account_details), (create_page_user_details),
2129 (create_page_outgoing):
2130 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2131 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2132 the UI spec, when the user tries to enter more than the max number of characters.
2134 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2136 * src/maemo/easysetup/modest-easysetup-wizard.c:
2137 (create_page_user_details), (create_page_custom_incoming),
2138 (create_page_custom_outgoing):
2139 * src/maemo/modest-account-settings-dialog.c:
2140 (create_page_user_details), (create_page_incoming),
2141 (create_page_outgoing):
2142 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2143 (modest_connection_specific_smtp_edit_window_init):
2144 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2145 not appropriate. Bad Maemo-specific defaults!.
2147 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2149 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2150 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2151 (modest_signature_editor_dialog_set_settings):
2152 Disable the label and textview when the checkbox is disabled, and use the
2153 specified (UI spec) default signature text.
2155 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2157 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2158 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2160 * src/modest-defs.h:
2161 * src/modest-account-mgr-helpers.h:
2162 * src/modest-account-mgr-helpers.c:
2163 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2165 * src/maemo/Makefile.am:
2166 * src/maemo/modest-signature-editor-dialog.c:
2167 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2170 * src/maemo/modest-account-settings-dialog.h:
2171 * src/maemo/modest-account-settings-dialog.c:
2172 (modest_account_settings_dialog_finalize), (on_button_signature),
2173 (save_configuration): Use the new dialog when the Edit button is pressed, and
2174 save the changes if necessary, as per the UI spec.
2176 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2178 * src/maemo/Makefile.am:
2179 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2180 based on maemo-develoers email from Dirk.
2182 * src/maemo/easysetup/modest-easysetup-wizard.c:
2183 (create_page_welcome), (create_page_account_details),
2184 (create_page_user_details), (create_page_complete_easysetup),
2185 (create_page_custom_incoming), (create_page_custom_outgoing),
2186 (create_page_complete_custom),
2187 (modest_easysetup_wizard_dialog_init):
2188 * src/maemo/modest-account-settings-dialog.c:
2189 (create_page_account_details), (create_page_user_details),
2190 (create_page_incoming), (create_page_outgoing),
2191 (modest_account_settings_dialog_init):
2192 * src/maemo/modest-connection-specific-smtp-window.c:
2193 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2195 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2197 * src/maemo/easysetup/modest-easysetup-wizard.c:
2198 (create_page_account_details), (create_page_custom_outgoing),
2199 (create_page_complete_custom):
2200 * src/maemo/modest-account-settings-dialog.c:
2201 (create_page_user_details), (create_page_incoming),
2202 (create_page_outgoing):
2203 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2204 (modest_connection_specific_smtp_edit_window_init):
2205 Use the correct (UI spec) port min/max, and use horizontal separators,
2208 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2210 * src/maemo/easysetup/modest-easysetup-wizard.c:
2211 (set_default_custom_servernames):
2212 * src/maemo/modest-account-settings-dialog.c:
2213 (create_page_incoming), (on_combo_outgoing_security_changed),
2214 (on_combo_incoming_security_changed), (create_page_outgoing),
2215 (modest_account_settings_dialog_set_account_name),
2216 (save_configuration):
2217 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2218 (on_combo_security_changed),
2219 (modest_connection_specific_smtp_edit_window_init),
2220 (modest_connection_specific_smtp_edit_window_set_connection),
2221 (modest_connection_specific_smtp_edit_window_get_settings):
2222 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2225 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2228 * src/maemo/easysetup/modest-easysetup-wizard.c:
2229 (create_page_custom_outgoing), (create_page_complete_custom):
2230 * src/maemo/modest-account-settings-dialog.c:
2231 (create_page_user_details), (create_page_outgoing):
2232 * src/maemo/modest-account-view-window.c: (button_box_new):
2233 Use changed logical IDs as per the most recent UI spec:
2234 mcen_bd_emailsetup_edit -> mcen_bd_edit
2235 mcen_bd_emailsetup_delete -> mcen_bd_delete
2236 mcen_bd_emailsetup_close -> mcen_bd_close
2238 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2242 * src/dbus_api/Makefile.am:
2243 * src/dbus_api/modest-dbus-callbacks.c:
2244 * src/dbus_api/modest-dbus-callbacks.h:
2245 * src/maemo/modest-platform.c: (modest_platform_init):
2246 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2248 * tests/Makefile.am:
2249 * tests/dbus_api/Makefile.am:
2250 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2252 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2254 * src/maemo/modest-account-settings-dialog.c:
2255 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2256 Removed unnecessary includes.
2258 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2260 * src/maemo/easysetup/modest-easysetup-wizard.c:
2261 * src/maemo/modest-account-settings-dialog.c:
2262 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2263 * src/widgets/Makefile.am:
2264 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2265 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2266 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2267 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2268 * src/widgets/modest-secureauth-combo-box.c:
2269 * src/widgets/modest-secureauth-combo-box.h:
2270 * src/widgets/modest-serversecurity-combo-box.c:
2271 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2272 made the GObject names more consistent with the rest of the Modest code.
2274 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2276 * src/maemo/easysetup/Makefile.am:
2277 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2278 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2279 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2280 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2281 * src/maemo/easysetup/modest-easysetup-wizard.c:
2282 * src/maemo/easysetup/modest-validating-entry.c:
2283 * src/maemo/easysetup/modest-validating-entry.h:
2284 * src/maemo/modest-account-settings-dialog.c:
2285 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2286 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2287 widgets/ because they are used outside of easysetup too. After checking in,
2288 svn will allow me to rename them too.
2290 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2292 * src/gnome/modest-msg-edit-window.c:
2293 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2294 linker error, to fix the build on the GNOME platform.
2295 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2296 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2297 ifdefed out to avoid a warning.
2299 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2301 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2302 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2303 some alternative for GTK+ 2.6.
2305 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2307 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2309 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2310 specified for EmailAccountsDialog in UI spec.
2312 * src/maemo/easysetup/modest-easysetup-wizard.c:
2313 * src/maemo/easysetup/modest-easysetup-wizard.h:
2314 * src/maemo/modest-account-settings-dialog.c:
2315 * src/maemo/modest-account-settings-dialog.h:
2316 Reuse a member window widget for the connection-specific SMTP server accounts,
2317 so we can tell it to create/save the accounts only if we actually save changes.
2319 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2320 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2321 (modest_connection_specific_smtp_edit_window_get_settings):
2322 Return a struct instance for temporarily remembering the entered data.
2324 * src/maemo/modest-connection-specific-smtp-window.h:
2325 * src/maemo/modest-connection-specific-smtp-window.c:
2326 (modest_connection_specific_smtp_window_finalize),
2327 (modest_connection_specific_smtp_window_fill_with_connections),
2329 (modest_connection_specific_smtp_window_save_server_accounts),
2330 (update_model_server_names): Do not actually save data until asked,
2331 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2333 (on_selection_changed),
2334 (modest_connection_specific_smtp_window_init): Disable the edit
2335 button when nothing is selected.
2337 * src/modest-account-mgr-helpers.c:
2338 * src/modest-account-mgr-helpers.h:
2339 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2342 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2344 * src/modest-account-mgr-helpers.h:
2345 * src/modest-account-mgr-helpers.c:
2346 (modest_account_mgr_get_unused_account_name),
2347 (modest_account_mgr_get_unused_account_display_name): Added these
2348 utility functions, to avoid code duplication.
2350 * src/maemo/easysetup/modest-easysetup-wizard.c:
2351 (create_page_account_details), (create_account):
2352 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2353 (on_combo_security_changed),
2354 (modest_connection_specific_smtp_edit_window_init),
2355 (modest_connection_specific_smtp_edit_window_save_settings):
2356 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2357 * src/maemo/modest-connection-specific-smtp-window.c:
2358 (modest_connection_specific_smtp_window_finalize),
2359 (modest_connection_specific_smtp_window_fill_with_connections),
2360 (on_button_edit), (modest_connection_specific_smtp_window_init):
2361 * src/maemo/modest-connection-specific-smtp-window.h:
2362 Implementing saving of connection-specific server accounts.
2364 But I need to refactor this so we can save the data for each
2365 possible connection-specific account and only actually create the server accounts
2366 when the easysetup finished, or the OK button is pressed on the account settings
2369 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2371 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2372 (on_combo_security_changed):
2373 (modest_connection_specific_smtp_edit_window_init):
2374 Auto-fill the port number as in the account settings.
2376 (modest_connection_specific_smtp_edit_window_set_connection):
2377 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2378 * src/maemo/modest-connection-specific-smtp-window.c:
2379 (fill_with_connections), (on_button_edit),
2380 (modest_connection_specific_smtp_window_init):
2381 Turn the edit window into a dialog to simplify the code, and
2382 set a WM hint as in a GtkDialog, because only a popup can be on top of
2383 another window in Maemo, and popups usually have no WM decoration.
2385 * src/modest-defs.h:
2386 * src/modest-account-mgr-helpers.c:
2387 (modest_account_mgr_set_connection_specific_smtp),
2388 (modest_account_mgr_remove_connection_specific_smtp),
2389 (modest_account_mgr_get_connection_specific_smtp):
2390 * src/modest-account-mgr-helpers.h: Some functions to write the
2391 connection-specific SMTP server information. Not yet used.
2394 * src/widgets/modest-folder-view.c: (text_cell_data):
2395 Fix a warning about an uninitialized variable.
2396 (on_configuration_key_changed): Put an #ifdef around the use
2397 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2399 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2401 * src/maemo/modest-account-settings-dialog.h:
2402 * src/maemo/modest-account-settings-dialog.c:
2403 Added connect_for_modified() utility function to mark the new modified boolean.
2405 (create_page_account_details), (create_page_user_details),
2406 (create_page_incoming), (create_page_outgoing), (on_response),
2407 (modest_account_settings_dialog_init),
2408 (modest_account_settings_dialog_set_account_name):
2409 Only warn about unsaved changes when there are actually unsaved changes.
2411 * src/modest-account-mgr-helpers.c:
2412 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2413 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2414 to get the data from there in future.
2416 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2418 * src/modest-defs.h:
2420 * src/modest-account-mgr-helpers.h:
2421 * src/modest-account-mgr-helpers.c:
2422 Store the security account setting in a single conf key instead of using
2423 the options list, so that the list is left for just the to-be-removed camel hack,
2424 and because gconf_client_set_list() is failing for some reason.
2426 * src/modest-account-mgr.c:
2427 (modest_account_mgr_add_server_account):
2428 * src/maemo/modest-account-settings-dialog.c:
2429 (modest_account_settings_dialog_set_account_name),
2430 (save_configuration): Use the renamed functions.
2433 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2435 * src/widgets/Makefile.am:
2436 * src/widgets/modest-limit-retrieve-combo-box.c:
2437 * src/widgets/modest-limit-retrieve-combo-box.h:
2438 * src/widgets/modest-retrieve-combo-box.c:
2439 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2440 the account settings dialog.
2442 * src/modest-defs.h:
2443 * src/modest-account-mgr-helpers.h:
2444 * src/modest-account-mgr-helpers.c:
2445 (modest_server_account_get_option_secure_auth),
2446 (modest_server_account_set_option_secure_auth):
2447 * src/modest-account-mgr.c:
2448 (modest_account_mgr_add_server_account):
2449 Use the existing AUTH_MECH conf key for the secure-auth setting,
2450 instead of putting it in the list options, because this was actually used already.
2452 * src/maemo/modest-account-settings-dialog.c:
2453 (create_page_account_details),
2454 (modest_account_settings_dialog_set_account_name),
2455 (save_configuration):
2456 * src/maemo/modest-account-settings-dialog.h:
2457 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2458 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2460 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2462 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2463 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2464 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2466 * src/modest-defs.h:
2467 * src/maemo/modest-account-settings-dialog.c:
2468 (create_page_incoming), (on_combo_outgoing_security_changed),
2469 (on_combo_incoming_security_changed), (create_page_outgoing),
2470 (modest_account_settings_dialog_set_account_name),
2471 (save_configuration): Load/Save the port number, and change it when the
2472 security combo changes, to suitable defaults.
2474 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2476 * src/modest-account-mgr.c:
2477 (modest_account_mgr_add_server_account): Set the security and secure-auth
2478 options, and add a comment saying that the other camel-specific options should be
2481 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2483 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2485 * src/modest-tny-account-store.c: (account_list_free),
2486 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2487 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2490 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2492 * src/modest-protocol-info.c:
2493 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2494 is required by our UI spec. Maybe something in our implementation will use this eventually.
2495 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2496 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2497 instead of the previous 0 placeholder.
2499 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2500 secure-auth settings.
2501 * src/modest-account-mgr-helpers.h:
2502 * src/modest-account-mgr-helpers.c:
2503 (modest_server_account_data_get_option_secure_auth),
2504 (modest_server_account_set_option_secure_auth),
2505 (modest_server_account_data_get_option_security),
2506 (modest_server_account_set_option_security): Added this API for getting and setting the security
2507 and secure-auth settings.
2509 * src/maemo/modest-account-settings-dialog.h:
2510 * src/maemo/modest-account-settings-dialog.c:
2511 (modest_account_settings_dialog_finalize), (check_data),
2512 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2513 about changing titles.
2514 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2515 (save_configuration): Save the security and secure-auth settings.
2517 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2518 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2520 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2522 * src/modest-defs.h:
2523 * src/modest-account-mgr.c:
2524 (modest_account_mgr_add_server_account):
2525 Added and used defines for the options key and value pair strings,
2526 that are used so far, though they do not seem to correspond to anything in our
2527 UI specs or ModestProtocol enum.
2529 * src/modest-account-mgr-helpers.h:
2530 * src/modest-account-mgr-helpers.c:
2531 (compare_option_strings_for_name),
2532 (modest_server_account_data_get_option_value),
2533 (modest_server_account_data_get_option_bool),
2534 (modest_account_mgr_get_server_account_option):
2535 Added helper functions for parsing the options GSList.
2537 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2539 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2540 display name is based on the supplied account name.
2541 * src/modest-account-mgr.c:
2542 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2543 with an inefficient, but good-enough, implementation.
2545 * src/maemo/easysetup/modest-easysetup-wizard.c:
2546 (create_page_account_details), (on_before_next), (create_account):
2547 Check for existing display names rather than (non-user-visible) account names, and just
2548 create and set a unique account name at the end.
2550 * src/maemo/modest-account-settings-dialog.c:
2551 (modest_account_settings_dialog_init),
2552 (modest_account_settings_dialog_set_account_name),
2553 (create_page_incoming): Show the display name, instead of the account name.
2554 (on_response): Do some (not all) extra checks, as in the UI spec.
2555 (save_configuration): Save the display name if it was changed.
2557 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2559 * po/en_GB.po: Added needed logical ID and translation.
2560 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2561 (init_view): Made the is-default column clicking work.
2563 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2566 * src/maemo/easysetup/Makefile.am:
2567 * src/maemo/easysetup/modest-easysetup-wizard.c:
2568 (modest_easysetup_wizard_dialog_init):
2569 * src/maemo/easysetup/provider-data-test.keyfile:
2570 * src/maemo/easysetup/provider-data.keyfile:
2571 Moved the provider data file to the new modest-providers-data package and used it from there.
2573 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2575 * src/modest-local-folder-info.c:
2576 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2577 N_() was already used on the static strings, but this just marks it for translation without
2578 using the translation.
2580 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2582 * src/maemo/modest-account-settings-dialog.c:
2583 (create_page_incoming),
2584 (modest_account_settings_dialog_set_account_name):
2585 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2586 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2587 I will do this if nobody else gets there first.
2589 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2591 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2592 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2593 save the security stuff.
2595 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2597 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2598 Set the email address and user fullname, which I now see must be
2601 * src/maemo/modest-account-settings-dialog.h:
2602 * src/maemo/modest-account-settings-dialog.c:
2604 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2605 leave-on-server and authentication.
2606 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2609 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2612 * src/maemo/modest-account-settings-dialog.c:
2613 * src/maemo/modest-account-settings-dialog.h:
2614 Most (but not all) of the widgets are now present as specified by the UI spec.
2615 No changes are yet saved, and some details are not properly shown yet.
2617 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2619 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2621 * src/maemo/Makefile.am:
2622 * src/maemo/modest-account-settings-dialog.c:
2623 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2624 an existing account. Doesn't do much yet.
2626 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2627 Open the accounts settings dialog when Edit is clicked.
2629 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2631 * src/maemo/easysetup/Makefile.am:
2632 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2634 * src/maemo/easysetup/modest-easysetup-wizard.c:
2635 (modest_easysetup_wizard_dialog_init):
2636 Try to get the source directory from the build system,
2637 instead of hard-coding "./" into the source code, when opening our local
2638 copies of the configuration files.
2639 But this still fails when opening the wizard from the Accounts window,
2640 maybe because the working directory seems to change at runtime.
2641 So the wizard will fail the second time unless you copy the files into their
2642 proper locations - see the stdout warnings for the paths.
2644 (create_page_account_details),(on_before_next):
2645 Check for existing non-server accounts instead of server accounts,
2646 so the default account name is useful again, and to prevent trying to
2649 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2650 Show the wizard when New is clicked.
2652 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2653 (init_view): Show the column headers, and show the columns that are
2654 specified in the UI specs. However, something in Maemo's GTK+ prevents
2655 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2656 change the default account. This is despite unsetting the special properties.
2658 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2660 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2661 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2662 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2663 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2664 to make that clearer.
2665 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2667 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2669 * src/maemo/modest-account-view-window.c:
2670 (modest_account_view_window_init),
2671 (modest_account_view_window_new):
2672 Use the same buttons as specified in the
2673 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2674 the existing widgets, which never had a chance of working.
2675 Put the ModestAccountView treeview in a scrolled window.
2676 Do not repeat the initialization in both _init() and _new().
2678 * src/widgets/modest-account-view.c: (update_account_view):
2679 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2680 this widget and window shows no accounts.
2682 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2684 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2686 * src/maemo/easysetup/modest-easysetup-wizard.c:
2687 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2688 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2689 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2692 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2693 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2694 accounts exist yet, as in the UI spec.
2696 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2698 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2700 * src/maemo/Makefile.am:
2701 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2702 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2703 New window for editing connection-specific smtp details.
2704 Not fully implemented.
2706 * src/maemo/modest-connection-specific-smtp-window.c:
2707 (modest_connection_specific_smtp_window_finalize) :
2708 unref the tree model.
2709 (on_button_edit): Show the edit window.
2711 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2713 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2716 * src/maemo/Makefile.am:
2717 * src/maemo/modest-connection-specific-smtp-window.c:
2718 * src/maemo/modest-connection-specific-smtp-window.h:
2719 New window for showing the list of connections, for connection-specific
2720 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2721 * src/maemo/easysetup/modest-easysetup-wizard.c:
2722 (create_page_custom_outgoing): Show the new window when the button is clicked.
2724 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2726 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2727 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2728 * src/maemo/modest-msg-edit-window.c:
2729 (modest_msg_edit_window_insert_image):
2730 * src/modest-conf.c: (modest_conf_key_escape):
2731 * src/modest-mail-operation.c:
2732 (modest_mail_operation_send_new_mail):
2733 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2734 (modest_ui_actions_on_new_account):
2735 * src/widgets/modest-attachment-view.c: (update_filename_request):
2736 * src/widgets/modest-mail-header-view.c:
2737 Corrected warnings that were breaking the build, by commenting out unused variables,
2738 and a function, and by including a header.
2740 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2742 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2743 so we can #ifdef around platform-specific code when necessary.
2744 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2745 to allow this to build for the GNOME platform too.
2747 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2749 * src/maemo/easysetup/modest-easysetup-wizard.c:
2750 Added util_increment_name() and used it in create_page_account_details()
2751 to make sure that the default account name is always a new name.
2753 (modest_easysetup_wizard_dialog_init),
2754 (set_default_custom_servernames): Some minor memory management fixes.
2756 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2760 * src/modest-runtime.c: (init_i18n): Restored the translation
2761 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2762 are defined in config.h, and the translations are installed.
2764 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2765 is defined for translation.
2767 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2769 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2771 * src/maemo/easysetup/modest-easysetup-wizard.c:
2772 (modest_easysetup_wizard_dialog_init):
2773 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2774 Use realistic paths (though they should use $prefix generically) to the
2775 mcc_mapping and provider-data.keyfile files which might work when they
2776 are installed by the future version of the operator-wizard package,
2777 and then fallback to paths in our source code, with an explanatory
2780 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2784 * src/maemo/Makefile.am:
2785 * src/maemo/easysetup/: Added files from the previously-exernal
2786 osso-modest-easysetup.
2787 * src/maemo/modest-main-window-ui.h:
2788 * src/modest-ui-actions.c:
2789 * src/modest-ui-actions.h:
2790 Added modest_ui_actions_on_new_account() as a signal handler for the
2791 New Account menu item. It shows the easysetup wizard.
2792 * po/en_GB.po: Added additional needed logical IDs and translations.
2794 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2795 Apparently ChangeLog is not used for some vague Nokia legal reasons.