1 2007-07-10 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-account-settings-dialog.c:
4 (show_error): Use the same implementation as in
5 modest-easysetup-wizard.c:
6 (on_entry_invalid_character): The logical ID contains a %s.
7 Guessed what it should be.
8 (on_entry_max), (check_data), (on_response): Adapt to
10 (create_page_account_details): Really call
11 modest_validating_entry_set_func() on the correct widgets.
12 * src/maemo/easysetup/modest-easysetup-wizard.c:
13 (on_entry_invalid_character): Fix the logical ID here too.
14 (create_page_account_details),
15 (create_page_user_details):
17 modest_validating_entry_set_func() on the correct widgets.
19 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
20 Do not try to use the account if it is NULL.
22 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
24 * src/modest-ui-actions.c: (create_move_to_dialog),
25 (modest_ui_actions_on_main_window_move_to),
26 (modest_ui_actions_on_msg_view_window_move_to):
27 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
28 (filter_row), (modest_folder_view_show_non_move_folders):
29 * src/widgets/modest-folder-view.h:
31 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
32 the Sent folder yet as it does not report the correct folder type.
34 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
36 * src/maemo/modest-msg-edit-window.c: (init_window):
39 2007-07-10 Murray Cumming <murrayc@murrayc.com>
41 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
42 Take a parent widget instead of a parent window, and
43 implement this with hildon_banner_show_information() instead.
44 Non-Maemo builds can just ifdef that there.
45 This fixed projects.maemo.org bug NB#62766.
47 (on_entry_invalid_character): Use show_error() again instead
48 of using hildon directly, and use the _CS() macro to use the correct
50 (create_account), (check_for_supported_auth_methods), (on_entry_max):
51 Pass a widget instead od a window to show_error().
53 2007-07-10 Murray Cumming <murrayc@murrayc.com>
55 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
56 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
57 This allows us to show the server name in the error message, fixing
58 projects.maemo.org bug NB#62904.
59 Also, use the appropriate logical ID message for the account protocol.
61 2007-07-10 Murray Cumming <murrayc@murrayc.com>
63 * src/modest-tny-account-store.c: (on_idle_wrong_password):
64 A compilation fix, though the build wasn't broken for me.
66 2007-07-09 Murray Cumming <murrayc@murrayc.com>
68 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
69 Do not try to unref a NULL folder store, to avoid a runtime warning.
70 This seems to happen sometimes when changing accounts settings.
72 2007-07-09 Murray Cumming <murrayc@murrayc.com>
74 * src/modest-tny-account-store.c:
75 (modest_tny_account_store_instance_init),
76 (modest_tny_account_store_finalize),
77 (on_account_settings_hide), (on_idle_wrong_password):
78 Use a GHashTable to ensure that we only show one account settings
79 dialog per modest account. This avoids us having a dialog open for
80 both the store and transport accounts, or due to repeated get_password()
81 calls that shouldn't happen anyway.
83 2007-07-09 Murray Cumming <murrayc@murrayc.com>
85 * src/maemo/modest-maemo-utils.c: (on_hide),
86 (modest_maemo_show_dialog_and_forget): Handle the response, because
87 the window is not even hidden by default.
89 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
90 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
91 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
92 which seems to prevent some modality problems.
94 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
95 Ignore user cancellation errors.
97 * src/modest-account-mgr-helpers.h:
98 * src/modest-account-mgr-helpers.c:
99 Added modest_server_account_get_password() and
100 modest_server_account_get_has_password() to avoid direct use of
103 * src/maemo/modest-account-settings-dialog.h:
104 * src/maemo/modest-account-settings-dialog.c:
105 (modest_account_settings_dialog_init): Store the notebook so we can
107 Added modest_account_settings_dialog_switch_to_user_info().
109 * src/modest-tny-account-store.c:
110 (get_password): When the password in the account settings is wrong (we think),
111 show the relevant page of the account settings dialog, in the mainloop.
112 However, we currently get many of these at once because cancel does not
114 (forget_password): Do not forget the password
115 from the account settings, because this causes side-effects when
116 tinymail seems to call it at strange time, maybe because of how we
117 are cancelling get_password().
118 (modest_tny_account_store_alert): Ignore user cancellations.
120 2007-07-09 Murray Cumming <murrayc@murrayc.com>
122 * src/maemo/modest-maemo-utils.h:
123 * src/maemo/modest-maemo-utils.c:
124 Added modest_maemo_show_information_note_and_forget() for use instead of
125 gtk_dialog_run() when the response is not needed, to avoid an extra
126 mainloop which could cause a hang.
128 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
129 Use the logical IDs for the error message, though they are not
130 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
131 because gtk_dialog_run() caused a hang here (the window did not close).
132 This fixes projects.maemo.org bug NB#62646.
134 2007-07-09 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-account-mgr-helpers.h:
137 * src/modest-account-mgr-helpers.c:
138 Added modest_account_mgr_get_store_protocol().
140 * src/maemo/modest-account-view-window.c:
141 (on_delete_button_clicked): Show different warning text depending on
142 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
143 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
146 2007-07-09 Murray Cumming <murrayc@murrayc.com>
148 * src/maemo/modest-msg-edit-window.c:
149 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
150 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
152 2007-07-07 Armin Burgmeier <armin@openismus.com>
154 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
155 ckdg_ib_maximum_characters_reached from correct package.
157 * src/modest-ui-actions.c: Show an error message when a folder could
158 not be created. Tinymail does not give us specific error codes about
159 what has gone wrong, so we assume that a folder with that name
160 already exists, though there might be other reasons.
162 2007-07-06 Murray Cumming <murrayc@murrayc.com>
164 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
165 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
166 give a more exact error message that can be partly translated.
168 2007-07-05 Murray Cumming <murrayc@murrayc.com>
170 * src/maemo/modest-address-book.c:
171 (select_email_addrs_for_contact): Specify a default window size for the
172 select-email-address dialog, so that it is probably big enough for the
173 title. This should fix projects.maemo.org bug NB#62277.
175 2007-07-05 Murray Cumming <murrayc@murrayc.com>
177 * src/maemo/easysetup/modest-easysetup-wizard.c:
178 (create_page_complete_easysetup): Use
179 gtk_widget_set_size() request to ensure that the text wraps
182 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
184 * src/maemo/easysetup/modest-easysetup-wizard.c:
185 (on_entry_invalid_character), (create_page_account_details),
186 (create_page_user_details):
187 Use new API of ModestValidatingEntry. But for some reason the banner is
188 not shown. I will have to investigate that further.
190 * src/widgets/modest-validating-entry.c: (on_insert_text),
191 (modest_validating_entry_set_func):
192 * src/widgets/modest-validating-entry.h:
193 Added a new callback function to be able to react to prevented
194 characters whitespaces to e.g show a banner.
196 2007-07-05 Armin Burgmeier <armin@openismus.com>
198 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
199 notification of HildonNumberEditor instead of remembering the port
200 number. Thanks to Johannes for pointing this out.
202 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
204 * src/maemo/easysetup/modest-easysetup-wizard.c:
205 Check if there are any user changes before showing a confirmation
206 dialog (projects.maemo.org NB#60946)
208 2007-07-05 Armin Burgmeier <armin@openismus.com>
210 * src/maemo/modest-account-settings-dialog.c: Remember custom port
211 number at the beginning of the dialog and set the modified flag at the
212 end if the port number has changed. This is necessary because
213 HildonNumberEditor does not support notification when the value has
216 2007-07-05 Murray Cumming <murrayc@murrayc.com>
218 * src/modest-ui-actions.c:
219 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
220 a connection before asking anything else. Correct the check for the destination
221 folder so that it succeeds when online.
222 This fixed projects.maemo.org bug NB#61645.
224 2007-07-05 Murray Cumming <murrayc@murrayc.com>
226 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
227 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
228 to fix projects.maemo.org bug NB#62439.
230 2007-07-05 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-tny-account.c: (on_connection_status_changed):
233 Really do not use tny_device_force_offline() here. See the previous comment.
235 2007-07-04 Murray Cumming <murrayc@murrayc.com>
237 * src/modest-tny-account.c: (on_connection_status_changed):
238 Do not use tny_device_force_offline() when tinymail says that something
239 went wrong with the connection. It seems to report this unnecessarily.
241 2007-07-04 Murray Cumming <murrayc@murrayc.com>
243 * src/maemo/modest-connection-specific-smtp-window.c:
244 (modest_connection_specific_smtp_window_init):
245 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
246 does not seem to have any effect in osso 1.1 (though it works in
247 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
249 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
251 * src/maemo/modest-connection-specific-smtp-window.c:
252 Fix UI specification problems with projects.meamo.org NB#60479
254 2007-07-04 Murray Cumming <murrayc@murrayc.com>
256 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
257 clue when this has failed, because the error dialog is not always shown
258 (at least in earlier version).
260 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
261 GError message, because the generic error dialog is not helpful.
263 'This message is not currently available (can't let a new connection go online)'
264 when trying to open an IMAP message.
266 (_modest_ui_actions_open): Offer a connection when some messages would
267 have to be downloaded and we are offline.
269 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
271 * src/widgets/modest-folder-view.c:
272 Don't check for MERGE type anymore as we use the correct type
274 NOTE: For the last two changes you need to update your tinymail copy
275 because of API changes!
277 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
279 * src/modest-tny-local-folders-account.c:
280 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
281 (see projects.maemo.org NB#61580)
283 2007-07-04 Murray Cumming <murrayc@murrayc.com>
285 * src/modest-tny-account.c: (on_connection_status_changed):
286 Commented out the call to modest_platform_connect_and_wait() because this
287 seems to always hang, and I would like to know if this is the only thing
288 that causes a hang when showing the connection dialog.
289 It is not very useful anyway.
291 2007-07-04 Murray Cumming <murrayc@murrayc.com>
293 * src/maemo/modest-msg-view-window.c:
294 (modest_msg_view_window_select_next_message):
296 * src/modest-platform.h:
297 * src/maemo/modest-platform.c:
298 Added modest_platform_connect_and_wait(), which calls
299 tny_maemo_conic_device_connect() always in the main thread, by calling it
300 in an idle handler and waiting for the idle handler to run. It should be
301 in the main thread because it uses GTK+ UI code. It just returns TRUE
302 if the device is already online.
304 There is some nasty code to ensure that subsequent calls to
305 modest_platform_connect_and_wait() just wait for the first one to finish,
306 by checking repeatedly in another idle handler. This is necessary,
307 because other threads (or even the main thread, via another idle handler)
308 can call modest_platform_connect_and_wait() while
309 modest_platform_connect_and_wait() is running.
311 (modest_platform_connect_and_wait_if_network_account),
312 (modest_platform_connect_and_wait_if_network_folderstore):
313 Convenience functions that calls modest_platform_connect_and_wait() if
314 the account or folder might want network access.
316 * src/modest-mail-operation.c:
317 (modest_mail_operation_update_account):
318 * src/modest-ui-actions.c: (download_uncached_messages),
319 (modest_ui_actions_on_rename_folder), (delete_folder),
320 (modest_ui_actions_on_main_window_move_to),
321 (modest_ui_actions_on_msg_view_window_move_to):
322 * src/widgets/modest-folder-view.c:
323 (drag_and_drop_from_folder_view):
324 Offer a connection if we are offline.
326 * src/modest-tny-account.c: (on_connection_status_changed):
327 Document this as only handling errors during network operations in progress,
328 and replace the idle code with a simple call to
329 modest_platform_connect_and_wait(), which does this instead.
331 2007-07-03 Murray Cumming <murrayc@murrayc.com>
333 * src/modest-tny-account.c:
334 (modest_tny_account_get_special_folder): (util_on_idle),
335 Handle the GError so we can see when tny_folder_store_get_folders()
336 fails, as it currently does while something else is connecting.
338 Added util_run_in_main_thread_and_wait()
339 which uses an idlen handler and mainloop to ensure that the function
340 is called in the main thread.
341 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
342 to make sure that we call attempt the connection in the mainloop only,
343 which might solve some hangs.
345 2007-07-03 Murray Cumming <murrayc@murrayc.com>
347 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
348 be found by their display name. This is never useful.
349 * src/modest-tny-account-store.c: (on_account_removed): Find the account
350 by its ID, instead of trying to use its ID as its display name.
352 * src/modest-tny-account-store.h:
353 * src/modest-tny-account.c:
354 (modest_tny_account_get_special_folder): Add a g_warning() when
355 tny_folder_store_get_folders() returns an empty list for the maildir.
357 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
358 Add a g_warning() when this returns NULL, because that it not allowed
361 2007-07-02 Armin Burgmeier <armin@openismus.com>
363 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
364 note when trying to cancel the wizard. This fixes projects.maemo.org
367 2007-07-02 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-tny-account.h:
370 * src/modest-tny-account.c:
371 (modest_tny_account_new_from_server_account),
372 (modest_tny_account_new_from_server_account_name),
373 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
374 because this must now be set before setting the proto. This is usd in
375 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
376 warning in camel_session_get_service() caused by
377 tny_camel_transport_account_prepare().
379 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
382 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
384 * src/maemo/modest-connection-specific-smtp-edit-window.c:
386 (modest_connection_specific_smtp_edit_window_init):
388 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
391 2007-06-29 Murray Cumming <murrayc@murrayc.com>
393 * src/modest-tny-account.c:
394 (modest_tny_account_new_from_server_account):
395 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
396 now uses to request a connection when it needs one, and which it uses
397 to tell us that something is wrong with the connection, so we can force
398 the accounts offline to prevent further problems.
401 * src/modest-init.c: (init_default_settings):
402 * src/modest-mail-operation.c:
403 (modest_mail_operation_update_account):
404 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
405 This should not be necessary anymore. Do not set the conf key that
406 determined this (it was always TRUE and not set anywhere else).
408 * src/modest-ui-actions.h: Remove unused and unimplemented
409 modest_ui_actions_on_online_toggle_toggled().
411 2007-06-29 Murray Cumming <murrayc@murrayc.com
413 * src/maemo/modest-main-window.c: (connect_signals):
414 Don't connect to delete_event twice. Maybe this was harmless.
416 2007-06-29 Murray Cumming <murrayc@murrayc.com
418 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
419 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
420 Debug output to give some more clue when a folder move is not allowed.
422 2007-06-28 Murray Cumming <murrayc@murrayc.com
424 * src/modest-tny-account.c: (on_modest_file_system_info),
425 (modest_tny_account_get_mmc_account_name):
426 Always call the callback, without checking whether the name has changed.
427 * src/widgets/modest-folder-view.c: (strings_are_equal),
428 (on_model_foreach_set_name), (on_get_mmc_account_name),
429 (text_cell_data): Compare the name here, and use the name from
430 the account rather than from the
431 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
432 if the name was changed after the account was added to the model.
433 That's a tinymail bug but not one that I want to fix now.
435 This finally fixes projects.maemo.org bug NB#59301.
437 2007-06-27 Armin Burgmeier <armin@openismus.com>
439 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
442 2007-06-27 Murray Cumming <murrayc@murrayc.com
444 * src/modest-tny-account.h:
445 * src/modest-tny-account.c:
446 Added modest_tny_account_get_mmc_account_name(), to set the memory
447 card name asynchronously for the given account and then notify.
448 (modest_tny_account_new_for_local_folders): Use this new function instead
449 of using hildon_file_system_info_async_new() directly.
451 * src/widgets/modest-folder-view.c: (text_cell_data):
452 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
453 gtk_tree_model_row_changed() when it is available.
455 This should fix projects.maemo.org bug NB#59301.
457 2007-06-27 Murray Cumming <murrayc@murrayc.com
459 * src/modest-mail-operation.c: (update_account_thread),
460 (get_msgs_full_thread): Fix typo failures in the revert
463 2007-06-27 Murray Cumming <murrayc@murrayc.com
465 * src/maemo/modest-maemo-global-settings-dialog.c:
466 (idle_select_default_focus):
467 * src/modest-mail-operation.c: (idle_notify_progress),
468 (idle_notify_progress_once), (set_last_updated_idle),
469 (update_account_thread), (get_msgs_full_thread):
470 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
471 * src/widgets/modest-header-view.c:
472 (idle_notify_headers_count_changed_destroy),
473 (idle_notify_headers_count_changed):
474 Reverted the additions of gdk_threads_enter/leave(), in case this
475 helps with a startup hang on the device.
477 2007-06-26 Armin Burgmeier <armin@openismus.com>
479 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
480 for supported secure authentication methods from server by
481 gtk_dialog_run(), saving CPU time and a potential race condition.
483 2007-06-26 Armin Burgmeier <armin@openismus.com>
485 * src/maemo/modest-maemo-utils.h:
486 * src/maemo/modest-maemo-utils.c: Added a
487 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
488 only error code to tell the calling code when the user canceled the
491 * src/maemo/modest-account-settings-dialog.h:
492 * src/maemo/modest-account-settings-dialog.c:
493 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
494 message if the retrieval of secure authentication methods was canceled
495 by the user. Perform the check before saving anything to configuration
496 to not end up with half-committed configuration changes, do not show
497 a "Saving to configuration failed" note when authentication methods
498 could not be retrieved.
500 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
503 2007-06-26 Murray Cumming <murrayc@murrayc.com>
505 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
506 Only return the first level of folders under accounts, because the
507 osso-global-search UI spec doesn't want the rest.
508 This fixed projects.maemo.org bug NB#61811.
510 2007-06-26 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-tny-account-store.c:
513 * src/modest-tny-account-store.h:
514 Added modest_tny_account_is_memory_card_account().
515 * src/maemo/modest-main-window.c: (create_details_widget):
516 Show the same information items for the memory card as we show for the
517 local-folders, to fix projects.maemo.org bug NB#59307.
519 2007-06-26 Murray Cumming <murrayc@murrayc.com>
521 * src/modest-tny-account-store.c: (get_password):
522 Added some checks for NULL to maybe prevent crashes, though I think
523 it was Philip's last commit that actually prevented the crash here
524 when creating a first new account.
525 But the new account is still not usable (no messages are shown)
526 until a restart of the application.
528 2007-06-26 Murray Cumming <murrayc@murrayc.com>
530 * src/maemo/modest-maemo-global-settings-dialog.c:
531 (idle_select_default_focus):
532 * src/modest-mail-operation.c: (idle_notify_progress),
533 (idle_notify_progress_once), (idle_notify_update_account_queue),
534 (set_last_updated_idle), (update_account_thread),
535 (notify_get_msgs_full), (get_msgs_full_destroyer),
536 (get_msgs_full_thread):
537 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
538 * src/widgets/modest-header-view.c:
539 (idle_notify_headers_count_changed_destroy),
540 (idle_notify_headers_count_changed):
541 Use gdk_threads_enter() and gdk_threads_enter_leave() in
542 all idle handlers, because some other thread could be blocking
543 the GDK lock, so that it can do GUI stuff.
545 2007-06-26 Murray Cumming <murrayc@murrayc.com>
547 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
548 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
549 (on_idle_send_receive), (on_idle_open_default_inbox):
550 * src/maemo/modest-msg-edit-window.c:
551 (modest_msg_edit_window_attach_file_noninteractive):
552 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
553 to prevent a hang. I don't quite understand why these are necessary,
554 beause we should already be in the main loop. I guess something outside
555 of the main loop is taking the lock.
557 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
558 we are really using URIs, and use files that are more likely to exist.
560 2007-06-26 Murray Cumming <murrayc@murrayc.com>
562 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
563 necessary because configure.ac now defines different variables.
565 2007-06-26 Murray Cumming <murrayc@murrayc.com>
567 * libmodest-dbus-client/libmodest-dbus-client.c:
568 * libmodest-dbus-client/libmodest-dbus-client.h:
569 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
570 libmodest_dbus_client_compose_mail() is what things actually use.
572 * src/dbus_api/modest-dbus-api.h:
573 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
574 * tests/dbus_api/Makefile.am:
575 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
578 2007-06-26 Murray Cumming <murrayc@murrayc.com>
580 * src/modest-init.c: (modest_init_local_folders):
581 For memory-card (or other non local-folders) maildir accounts,
582 always create an Archive folder, so that there is somewhere to put
583 messages. This should be less confusing, because the user does not need
584 to guess that the need to create a folder.
586 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
588 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
589 Fixed icon size by using (50, 50) which is the same as defined by
592 2007-06-25 Armin Burgmeier <armin@openismus.com>
594 * src/widgets/modest-window-mgr.c:
596 * configure.ac: Correctly recognize hildon-notify presence and fixed
597 the build without it being installed.
599 2007-06-25 Murray Cumming <murrayc@murrayc.com>
601 * libmodest-dbus-client/libmodest-dbus-client.c:
602 (libmodest_dbus_client_search): Fix the build. Sorry.
603 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
604 (reply_forward_cb): Initialize variables to fix the build.
606 * src/modest-tny-account-store.c:
607 (modest_tny_account_store_get_tny_account_by): Fix the account URI
608 comparison (a silly typo) so that email search results can be opened
609 when there are more than one account.
611 2007-06-25 Murray Cumming <murrayc@murrayc.com>
613 * libmodest-dbus-client/libmodest-dbus-client.c:
614 (libmodest_dbus_client_search),
615 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
616 instead of 1 second, because the search gets folders and messages from
617 the server, which can take a long time. When it times out,
618 osso-global-search will report no results.
620 We need to specify whether we should search only cached information
621 (maybe with a user preference), and the osso-email-search-plugin
622 API should really be improved to allow that option, and to allow results
623 to be delivered asynchronously in batches.
625 2007-06-25 Murray Cumming <murrayc@murrayc.com>
627 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
628 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
629 GTK_ICON_SIZE_DIALOG is probably the wrong size.
631 2007-06-25 Murray Cumming <murrayc@murrayc.com>
633 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
634 that is an empty string. D-Bus seems to give us these instead of NULL.
636 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
638 * src/dbus_api/modest-dbus-callbacks.c:
639 * src/maemo/easysetup/modest-easysetup-wizard.h:
640 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
641 * src/maemo/modest-connection-specific-smtp-edit-window.c:
642 (modest_connection_specific_smtp_edit_window_init):
643 * src/maemo/modest-maemo-global-settings-dialog.c:
645 * src/maemo/modest-maemo-utils.c:
646 (modest_maemo_utils_setup_images_filechooser):
647 * src/maemo/modest-main-window.c: (create_details_widget):
648 * src/maemo/modest-msg-edit-window.c:
649 (modest_msg_edit_window_attach_file_noninteractive),
650 (modest_msg_edit_window_color_button_change),
651 (modest_msg_edit_window_set_zoom):
652 * src/modest-mail-operation.c: (update_account_thread):
653 * src/modest-tny-account-store.c:
654 * src/modest-tny-account.c:
655 * src/widgets/modest-global-settings-dialog.c:
656 * src/widgets/modest-window.h:
660 2007-06-25 Murray Cumming <murrayc@murrayc.com>
662 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
663 * src/modest-search.c: (modest_search_folder),
664 (modest_search_all_accounts): Actually search only in the specified folder,
665 doing a simple match on the folder ID.
666 * src/modest-search.h: Added a folder field to the ModestSearch struct,
667 and added some documentation.
669 2007-06-22 Armin Burgmeier <armin@openismus.com>
671 * src/maemo/modest-maemo-utils.h:
672 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
673 modest_maemo_utils_get_supported_secure_authentication_methods.
675 * src/maemo/easysetup/modest-easysetup-wizard.c:
676 * src/maemo/modest-account-settings-dialog.c: Show correct error if
677 one occured, not just "Server does not support secure authentication".
679 2007-06-22 Murray Cumming <murrayc@murrayc.com>
681 * src/modest-tny-account-store.c: (get_password):
682 Restored the call to tny_account_set_user() because Philip seems to have
683 stopped this from crashing (by not using the freed string). It still does
684 not work, but now we can test it.
686 2007-06-22 Murray Cumming <murrayc@murrayc.com>
688 * src/maemo/modest-msg-edit-window.c: (init_window):
689 Comment out use of an uninitialzed GtkScrolledWindow variable,
690 to fix the build and stop a crash. Yet again.
692 2007-06-22 Murray Cumming <murrayc@murrayc.com>
694 * src/modest-tny-account-store.c: (get_password):
695 Remove the call to tny_account_set_user() because this actually crashes.
696 As mentioned in the last commit, it is known to not work anyway.
698 2007-06-22 Murray Cumming <murrayc@murrayc.com>
700 * src/modest-tny-account-store.c: (get_password):
701 Use tny_account_set_username() to tell tinymail that the username might
702 have changed too. But tinymail ignores this: see projects.maemo.org
704 * src/modest-ui-actions.c:
705 (modest_ui_actions_on_password_requested): Remove the useless attempt to
706 reset the connection when changing the username, and improve the comments.
707 Save the changed username to gconf at least, so it is used when Modest is
710 2007-06-21 Murray Cumming <murrayc@murrayc.com>
712 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
713 Do not use a query, so that we get all folders, including for POP and
714 local-folders. They work as search criteria too.
715 This fixes projects.maemo.org bug NB#57740.
717 2007-06-21 Murray Cumming <murrayc@murrayc.com>
719 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
720 Comment out the use of hildon_notification_set_sound() because it is
721 not declared, to fix the build. Warnings are serious, people.
723 2007-06-21 Armin Burgmeier <armin@openismus.com>
725 * src/maemo/modest-maemo-utils.h:
726 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
727 modest_maemo_utils_get_supported_secure_authentication_methods()
728 to query authentication methods for a specific user. This should fix
729 projects.maemo.org bug NB#61369.
731 * src/maemo/easysetup/modest-easysetup-wizard.c:
732 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
735 2007-06-21 Murray Cumming <murrayc@murrayc.com>
737 * libmodest-dbus-client/libmodest-dbus-client.h:
738 * libmodest-dbus-client/libmodest-dbus-client.c:
739 (modest_dbus_message_iter_get_search_hit),
740 (libmodest_dbus_client_search):
741 Reorganised and commented this.
742 Removed modest_search_hit_free() from the public API because it
745 Added libmodest_dbus_client_get_folders() and
746 modest_folder_result_list_free().
748 * src/dbus_api/modest-dbus-api.h:
749 * src/dbus_api/modest-dbus-callbacks.c:
750 (modest_dbus_req_filter): Commented. Moved most code to
751 on_dbus_method_search() and added on_dbus_method_get_folders().
753 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
754 of the extra D-Bus handler.
756 * tests/dbus_api/Makefile.am:
757 * tests/dbus_api/test_get_folders.c: New test for
758 libmodest_dbus_client_get_folders(). This seems to return an empty list
759 at the moment. That could be the same error that causes the message list
760 to be empty sometimes.
761 This should help with projects.maemo.org bug NB#57740.
763 2007-06-21 Armin Burgmeier <armin@openismus.com>
765 * src/modest-mail-operation.c: Do not call
766 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
767 notify the operation's end after having set the status to CANCELED for
768 the operation queue to listen on. This fixes a deadlock when there
769 were mail operations in the queue during its finalization.
771 * src/modest-singletons.c: Reordered uninitialization of the account
772 manager to happen after the mail operation queue was uninitialized
773 because the mail operation's in the queue might still try to access
774 the account manager (see modest_mail_operation_notify_end()). This
775 fixes a potential crash when terminating the application.
777 2007-06-21 Murray Cumming <murrayc@murrayc.com>
779 * src/modest-search.c:
780 (search_mime_part_and_child_parts): Moved some code here so we
781 can search recursively in child folders.
782 (modest_search_folder): Search in the message as a mime part, instead
783 of just its child mime parts.
784 (read_chunk), (search_mime_part_ogs):
785 Check how many bytes were read, to prevent an endless loop.
786 Searching in message bodies now works. This finishes the fix for
787 projects.maemo.org bug NB#61007.
789 2007-06-20 Murray Cumming <murrayc@murrayc.com>
791 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
792 Add a g_warning when the item is not a folder.
794 * src/modest-ui-dimming-rules.c:
795 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
796 when selected item is not a folder (for instance, an account), because
797 the UI spec only talks about folders.
798 I am not sure what the UI spec wants, so this might not totally fix
799 projects.maemo.org bug NB#60794.
801 2007-06-20 Murray Cumming <murrayc@murrayc.com>
803 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
804 (load_from_file): Sort the list. The unsorted list would be more noticeable
805 in non-English locales.
807 * src/maemo/modest-msg-edit-window.c:
808 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
809 warning and fix the build.
811 * src/maemo/modest-progress-bar-widget.c:
812 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
813 avoid a g_warning, and probably to avoid a crash.
815 2007-06-20 Murray Cumming <murrayc@murrayc.com>
817 * src/modest-search.c: (modest_search_folder): Check for a GError
818 when calling tny_folder_get_headers(), to show that this is not the cause
821 2007-06-20 Murray Cumming <murrayc@murrayc.com>
823 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
824 Actually set the body query instead of the subject query.
826 * src/modest-search.c: (search_mime_part_ogs),
827 (search_mime_part_strcmp): Remove extra space from the text/* regex,
828 which would probably cause it to fail if we got this far.
830 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
831 to simplify the code.
832 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
833 be causing search-in-body to fail.
835 2007-06-20 Murray Cumming <murrayc@murrayc.com>
837 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
839 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
840 Better debug message when the folder cannot be found.
841 This should help with fixing projects.maemo.org bug #61287.
842 * src/modest-search.c: (add_hit): Do not leak the furl string.
844 2007-06-20 Murray Cumming <murrayc@murrayc.com>
846 * src/modest-ui-actions.c:
847 (modest_ui_actions_on_folder_selection_changed):
848 Do not special-case TNY_MERGE_FOLDER here, because
849 modest_tny_folder_get_account() already does that. This fixes
850 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
851 shown when the Outbox was selected).
853 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
855 * libmodest-dbus-client/libmodest-dbus-client.c:
856 (_dbus_iter_get_string_or_null): Initialize the string variable in
857 case this helps with Dirk's crash.
859 2007-06-19 Murray Cumming <murrayc@murrayc.com>
861 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
862 though it is not implemented yet (this function is maybe not even used),
863 to avoid breaking ABI in future.
864 * libmodest-dbus-client/libmodest-dbus-client.c:
865 (get_attachments_string): Moved some code into this generic function.
866 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
867 sends email. It is maybe not used.
868 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
869 (on_send_mail): Use attachments.
871 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
872 * src/maemo/modest-msg-edit-window.c:
873 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
874 a filename before using it, to fix projects.maemo.org bug NB#58233.
876 2007-06-19 Murray Cumming <murrayc@murrayc.com>
878 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
879 Initialize the continue_download variable to fix the build, and probably
880 to fix randome behaviour.
882 2007-06-18 Armin Burgmeier <armin@openismus.com>
884 * src/modest-tny-send-queue.h:
885 * src/modest-tny-send-queue.c: Keep track of the status of messages in
886 the queue so we can later show it in the UI. Replaced
887 modest_tny_send_queue_msg_is_being_sent() by
888 modest_tny_send_queue_get_msg_status().
890 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
892 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
893 gpointer. This probably was not harmful, but just to be sure.
895 2007-06-18 Murray Cumming <murrayc@murrayc.com>
897 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
898 Fix the build, but leave the function broken on Bora, because
899 hildon_uri_action_get_service() does not exist.
900 osso_uri_action_get_service() does not exist either, it seems.
902 2007-06-18 Murray Cumming <murrayc@murrayc.com>
904 * src/modest-tny-account.c:
905 (modest_tny_account_new_from_server_account):
906 Uncommented the url debug output again, because it is useful for
907 debugging, as I said in the comment.
909 2007-06-18 Murray Cumming <murrayc@murrayc.com>
911 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
913 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
914 for Mameo Bora, to fix the build.
916 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
919 Fixed build with hildon < 0.99
921 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
922 Check if the selected account is busy instead of checking all accounts
924 * src/modest-account-mgr-priv.h:
925 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
926 (modest_account_mgr_init), (compare_account_name),
927 (modest_account_mgr_set_account_busy),
928 (modest_account_mgr_account_is_busy):
929 * src/modest-account-mgr.h:
930 Added busy information to the account manager. It possible to
931 set an account to busy or not busy now.
933 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
934 (modest_mail_operation_update_account),
935 (modest_mail_operation_notify_end):
936 Set the account to busy/not busy depending on the operation state.
938 * src/widgets/modest-account-view.c:
939 (modest_account_view_finalize), (get_last_updated_string),
940 (update_account_view), (on_account_busy_changed), (init_view):
941 Show string "Refreshing..." if the account is currently busy.
943 All this fixes projects.maemo.org bug NB#59711
945 2007-06-14 Armin Burgmeier <armin@openismus.com>
947 * src/widgets/modest-attachments-view.h:
948 * src/widgets/modest-attachments-view.c: Added
949 modest_attachments_view_has_attachments() and fixed coordinate
950 transformation in get_att_view_at_coords(). This fixes attachment
953 * src/widgets/modest-msg-view.c: Make use of
954 modest_attachments_view_has_attachments() to decide whether to show
955 attachments in the header.
957 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
959 * src/maemo/modest-connection-specific-smtp-edit-window.c:
960 (on_change), (on_combo_security_changed),
961 (modest_connection_specific_smtp_edit_window_init),
962 (modest_connection_specific_smtp_edit_window_set_connection),
963 (modest_connection_specific_smtp_edit_window_is_dirty):
964 * src/maemo/modest-connection-specific-smtp-edit-window.h:
965 * src/maemo/modest-connection-specific-smtp-window.c:
968 Show an comfirmation dialog for the smpt-edit-window if there are
969 unsaved changes and the user hits cancel.
970 (projects.maemo.org bug NB#60479)
972 2007-06-14 Armin Burgmeier <armin@openismus.com>
974 * src/maemo/easysetup/modest-easysetup-wizard.c:
975 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
976 address" info in banner instead of node, and select all the text as
977 per UI spec. This fixes projects.maemo.org bug NB#60550.
979 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
981 reviewed by: <delete if not using a buddy>
983 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
984 * src/modest-ui-actions.c: (folder_refreshed_cb):
986 2007-06-14 Murray Cumming <murrayc@murrayc.com>
988 * src/widgets/modest-folder-view.c: (filter_row):
989 Explictly filter out the per-account outbox accounts. I don't know why
990 these only sometimes show up, but now they should never show up in the UI.
991 This should fix projects.maemo.org bug NB#60160.
993 2007-06-14 Murray Cumming <murrayc@murrayc.com>
995 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
996 when the toolbar does not exist yet.
997 * src/modest-widget-memory.c: (save_settings_header_view):
998 Added g_warnings() to help us to discover when we are trying to set
999 an empty columns list in gconf.
1001 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1003 * src/modest-init.h:
1004 * src/modest-init.c:
1005 Added modest_init_get_default_header_view_column_ids().
1007 * src/modest-widget-memory.c: (restore_settings_header_view):
1008 Use the new function to get defaults, if the gconf key is empty,
1009 instead of not creating any columns. This seems to fix the
1010 empty right-hand pane problems.
1012 * src/widgets/modest-header-view.h: Improved documentation.
1014 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1016 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1017 Revert the use of the display name as the account name, because this
1018 is generally wrong and would break the code that follows.
1020 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1022 * src/maemo/easysetup/modest-easysetup-wizard.c:
1023 (check_for_supported_auth_methods), (on_before_next),
1026 More correct fix for projects.maemo.org bug NB# 58991
1027 Do not longer accept AUTH_PASSWORD as secure method and choose
1028 correct method when creating the account.
1030 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1032 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1033 Fixed projects.maemo.org bug NB# 58991
1035 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1037 * src/modest-init.c: (modest_init_init_core),
1038 (modest_init_local_folders): Fixed compilation errors.
1040 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1042 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1043 Remove unnecessary lib/include, though it is good in principle when needed.
1045 * src/modest-init.c: (modest_init_one_local_folder),
1046 (modest_init_local_folders):
1047 * src/modest-init.h: Initialize the .modest library for memory cards,
1048 instead of just doing nothing for them. This should allow us to create
1049 folders there, fixing projects.maemo.org bug NB#59297.
1051 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1053 * libmodest-dbus-client/libmodest-dbus-client.c:
1054 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1055 (libmodest_dbus_client_compose_mail),
1056 (libmodest_dbus_client_open_message),
1057 (libmodest_dbus_client_send_and_receive),
1058 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1060 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1061 (on_idle_open_message), (modest_dbus_req_handler),
1062 (search_result_to_message), (modest_dbus_req_filter):
1063 * src/modest-search.c: (add_hit), (modest_search_folder),
1064 (modest_search_all_accounts): Improved debug messages.
1066 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1068 * src/modest-tny-account-store.c:
1069 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1072 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1075 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1077 * src/modest-tny-account-store.c: (get_server_accounts):
1078 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1079 even when there are no accounts, so that the Outbox folder is always
1080 visible. This fixes projects.maemo.org bug NB#60158.
1082 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1084 * src/maemo/modest-main-window.c: (create_details_widget):
1085 Use the mcen_va_never logical ID.
1087 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1089 * src/dbus_api/modest-dbus-api.h:
1090 * src/dbus_api/modest-dbus-callbacks.c:
1091 (on_idle_open_default_inbox), (on_open_default_inbox),
1092 (modest_dbus_req_handler):
1093 Added a new OpenDefaultInbox method.
1095 * libmodest-dbus-client/libmodest-dbus-client.h:
1096 * libmodest-dbus-client/libmodest-dbus-client.c:
1097 Added libmodest_dbus_client_open_default_inbox() to call the new
1098 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1099 though it should maybe be used by a new osso-email-interface function.
1101 * tests/dbus_api/Makefile.am:
1102 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1105 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1107 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1108 NULL, so that the signals get all the keys. This should not actually
1109 change any behaviour because we currently update everything when anything
1112 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1114 * src/widgets/modest-folder-view.c: (text_cell_data),
1115 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1116 (find_inbox_iter): If tinymail tells us that the folder is
1117 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1118 This causes the inbox to be selected at startup, fixing part of
1119 projects.maemo.org bug NB#56305.
1121 * src/modest-ui-dimming-rules.c:
1122 (modest_ui_dimming_rules_on_tools_smtp_servers):
1123 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1124 the SMTP servers menu item.
1125 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1126 that the SMTP Servers menu item is dimmed when there are no accounts,
1127 as a future version of the UI spec will require. This fixes
1128 projects.maemo.org bug NB#56305.
1130 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1132 * src/maemo/modest-maemo-utils.c:
1133 (modest_maemo_utils_get_supported_secure_authentication_methods):
1134 Added label to dialog instead of unreadable title
1136 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1137 (modest_main_window_new):
1138 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1141 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1142 * src/modest-account-mgr.h:
1143 Added method to avoid code duplication
1145 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1146 (modest_ui_actions_on_send_receive):
1147 Use modest_account_mgr_has_accounts
1149 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1151 * src/maemo/easysetup/modest-presets.c:
1152 (modest_presets_get_info_server_security): Do not report secure auth
1154 * src/modest-protocol-info.c: Use the defines for the gconf key names
1155 for secure authentication. This was not working because we were writing
1156 Password and reading password, and the check was case sensitive.
1157 With this, gmail now works for receiving and sending when created via
1160 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1162 * src/maemo/easysetup/modest-presets.c:
1163 (modest_presets_get_info_server_security): Correct the key name for
1164 SecureSmtp, because it seems to be case-sensitive.
1165 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1166 Do not try to get the 0th notebook page if there are 0 pages, to
1167 avoid a g_warning().
1169 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1171 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1172 Prevent use of the new notification feature for now, because it currently
1173 shows one dialog for each new email, which is annoying.
1175 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1177 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1178 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1179 when no country was selected, so that we show the global ones.
1180 * src/maemo/easysetup/modest-presets.c:
1181 (modest_presets_get_providers): Return only the global providers, not
1182 all providers when mmc=0 was requested.
1184 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1186 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1187 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1188 provider ID in the combo.
1190 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1191 Do not show the page numbers, because it would be confusing when we add
1192 the 2 extra pages for the custom setup, when the user chooses the "Other"
1193 provider. This fixes projects.maemo.org bug NB#59028
1195 * src/modest-init.c: (modest_init_init_core),
1196 (modest_init_local_folders):
1197 * src/modest-init.h:
1198 * src/modest-tny-account.c:
1199 (modest_tny_account_new_for_local_folders): Do not create default folders
1200 for the memory card. This should fix projects.maemo.org bug NB#59328.
1202 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1204 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1205 Free the changed_conf_keys string items. They are already freed in the
1206 idle handler if that runs first.
1208 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-ui-actions.c:
1211 (modest_ui_actions_on_password_requested): Check that the server name
1212 is not NULL, because I just saw a password dialog with (null) as the
1215 * src/modest-tny-folder.[h|c]: Added
1216 modest_tny_folder_is_memory_card_folder().
1217 * src/modest-ui-dimming-rules.c:
1218 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1219 menu item for memory cards, as per the UI spec (section 7.4). This should
1220 fix projects.maemo.org bug NB#59297.
1222 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1224 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1225 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1226 is another problem with the code, see Murray's comment at line 772)
1228 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1230 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1231 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1232 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1233 (load_from_file), (easysetup_country_combo_box_init),
1234 (easysetup_country_combo_box_get_active_country_ids),
1235 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1236 instead of just one ID, to avoid duplicate country names in the UI.
1238 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1239 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1240 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1241 a single ID, avoiding duplicate providers.
1242 * src/maemo/easysetup/modest-easysetup-wizard.c:
1243 (on_combo_account_country): Adapt to use a list.
1245 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1247 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1248 keys changed in the last X seconds.
1250 * src/modest-account-mgr.h:
1251 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1252 (on_key_change), (modest_account_mgr_class_init),
1253 (modest_account_mgr_init), (modest_account_mgr_finalize):
1254 As the keys are changed, save them in a GSList* and signal that GSList*
1255 further every X seconds, to batch changes, to allow us to do just one
1256 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1257 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1259 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1260 changed signal signature.
1262 * src/modest-conf.c: (modest_conf_set_list),
1263 (modest_conf_on_change): Reenable notification.
1265 (modest_conf_maemo_fake_on_change): Comment out the hack that
1266 notified immediately instead of asynchronously.
1268 * src/widgets/modest-account-view.h:
1269 * src/widgets/modest-account-view.c:
1270 (update_account_view): Select the previously-selected account ID,
1271 if possible. This fixes projects.maemo.org bug NB#56933.
1273 (on_account_changed), (on_account_removed),
1274 (modest_account_view_select_account):
1276 Remove the block/unblock functions
1277 because they were not useful.
1279 * src/maemo/modest-account-view-window.c:
1280 (on_delete_button_clicked), (on_edit_button_clicked),
1281 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1283 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1285 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1286 Improve the error dialog to show Incorrect Account Settings, which seems
1287 clearer, and say that the internal error message (to be removed from the
1288 dialog later) is often misleading.
1289 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1291 * src/modest-tny-account.c:
1292 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1293 URL because this is so useful for debugging on the device.
1295 * src/widgets/modest-serversecurity-combo-box.c:
1296 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1298 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1300 * src/modest-mail-operation.c:
1301 (modest_mail_operation_send_new_mail):
1302 Added a comment about a nasty but apparently harmless message. Details
1303 added to the wiki g_warnings() page.
1305 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1307 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1308 (modest_tny_send_queue_class_init):
1309 Do not use the priv struct because it is empty, to avoid g_warnings
1310 about a non-existant priv struct.
1312 * src/modest-tny-account-store.c:
1313 (modest_tny_account_store_get_server_account),
1314 (modest_tny_account_store_get_transport_account_for_open_connection
1315 ): Do not try to get transport server accounts for local folders,
1316 because they don't have any. This avoids a g_warning().
1318 * src/maemo/modest-main-window.c:
1319 (modest_main_window_notify_send_receive_initied),
1320 (on_configuration_key_changed):
1321 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1322 * src/modest-defs.h:
1323 * src/modest-mail-operation.c:
1324 (modest_mail_operation_update_account):
1325 * src/modest-tny-account-store.h:
1326 * src/modest-tny-account.c:
1327 (modest_tny_account_get_special_folder),
1328 (modest_tny_account_new_for_local_folders),
1329 (modest_tny_account_new_for_per_account_local_outbox_folder):
1330 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1331 * src/modest-tny-local-folders-account.c:
1332 (add_account_folders_to_merged_folder):
1333 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1334 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1335 (modest_ui_actions_on_send):
1336 * src/widgets/modest-folder-view.c: (update_model):
1337 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1338 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1339 modest_tny_account_store_get_tny_account_by_account() to
1340 modest_tny_account_store_get_server_account() to make the code clearer.
1342 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1344 * src/dbus_api/modest-dbus-api.h:
1345 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1346 * src/maemo/modest-msg-edit-window.c:
1347 (modest_msg_edit_window_attach_file_noninteractive):
1348 added g_warning in case the file to be attached does not exist
1349 * tests/dbus_api/test_compose_mail.c: (main):
1350 removed obsolete comment, added generic files as test case
1352 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1354 * src/modest-tny-account-store.c: (get_server_accounts):
1355 Create the local folders account only once, not once for each outbox, and
1356 not only when there are some outboxes.
1358 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1360 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1361 code that is causing a crash at startup. Sergio says that he is fixing this.
1363 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1365 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1366 * src/maemo/modest-account-settings-dialog.c:
1367 (create_page_outgoing),
1368 (modest_account_settings_dialog_set_account_name),
1369 (save_configuration):
1370 - Fixed handling of the "Use secure authentication" toggle to comply with
1371 the ui specification. See also projects.maemo.org bug NB#58400
1373 - Restore the Secure connection setting combo correctly when loading
1376 * src/maemo/modest-maemo-utils.c:
1377 (on_camel_account_get_supported_secure_authentication),
1378 (modest_maemo_utils_get_supported_secure_authentication_methods):
1379 Fixed a crasher if operation is canceled
1381 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1382 (modest_protocol_info_auth_is_secure):
1383 * src/modest-protocol-info.h:
1385 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1386 the sense of the "Use secure authentication" toggle.
1388 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1390 * src/modest-tny-account-store.h:
1391 * src/modest-tny-account-store.c:
1392 Added modest_tny_account_store_get_local_folders_account().
1394 * src/modest-tny-folder.h:
1395 * src/modest-tny-folder.c:
1396 (modest_tny_folder_get_account):
1397 Added this replacement for tny_folder_get_account() which returns
1398 the local-folders account for TnyMergeFolders, to avoid the
1399 warning about the unimplemented get_account_func() vfunc().
1401 (modest_tny_folder_get_rules),
1402 * src/modest-ui-actions.c:
1403 (modest_ui_actions_on_folder_selection_changed):
1404 * src/modest-mail-operation.c:
1405 (modest_mail_operation_remove_folder),
1406 (modest_mail_operation_xfer_folder),
1407 (modest_mail_operation_rename_folder),
1408 (modest_mail_operation_get_msg),
1409 (modest_mail_operation_get_msgs_full),
1410 (modest_mail_operation_remove_msg),
1411 (modest_mail_operation_xfer_msgs),
1412 (modest_mail_operation_refresh_folder):
1413 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1415 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1417 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1418 (modest_server_account_set_security):
1419 * src/modest-defs.h: Add comments explaining that our
1420 UI spec means TLS when it says Normal, so these do not look like errors.
1422 * src/modest-tny-account.c:
1423 (modest_tny_account_new_from_server_account): Use the new tinymail
1424 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1425 for TLS. This should fix projects.maemo.org bug NB#58460.
1427 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1429 * src/maemo/easysetup/modest-easysetup-wizard.c:
1430 (create_account): Correct the position of the gconf sanity check warning.
1431 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1432 of using the g_idle_add() hack, because this does not seem to be necessary
1433 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1434 caused by something other than maemo's gconf.
1435 This fixes projects.maemo.org bug #59022.
1437 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1439 * src/modest-account-mgr-helpers.c:
1440 (modest_account_mgr_get_default_account): Do not check that the account
1441 exists if there is no default account (NULL), to fix a runtime warning.
1443 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1445 * src/widgets/modest-folder-view.c: (update_model):
1446 Do not unref the treemodel before we have finished with it.
1447 This prevents a valgrind warning and an occasional crash at startup.
1449 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1451 * libmodest-dbus-client/libmodest-dbus-client.h:
1452 added libmodest_dbus_client_compose_mail()
1453 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1455 added functions needed for SendAsMail() functionality
1456 * src/maemo/modest-msg-edit-window.c:
1457 (modest_msg_edit_window_attach_file_noninteractive):
1458 non interactively attaching files to message edit window
1459 * src/widgets/modest-msg-edit-window.h:
1460 * tests/dbus_api/Makefile.am:
1461 added test_compose_mail.c
1462 * tests/dbus_api/test_compose_mail.c: (main):
1464 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1466 * src/modest-account-view.c:
1467 Fixed bug projects.maemo.org bug NB#59307
1469 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1471 * src/maemo/easysetup/modest-easysetup-wizard.c:
1472 (get_serverport_incoming), (on_before_next), (create_account):
1473 * src/maemo/modest-account-settings-dialog.c:
1474 (modest_account_settings_dialog_set_account_name):
1475 * src/maemo/modest-maemo-utils.c:
1476 (on_camel_account_get_supported_secure_authentication_status),
1477 (on_camel_account_get_supported_secure_authentication),
1478 (on_secure_auth_cancel),
1479 (modest_maemo_utils_get_supported_secure_authentication_methods):
1481 Implemented security authentication for settings and easysetup.
1483 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1485 * src/maemo/modest-main-window.c: (create_details_widget):
1486 Show the total size for memory card accounts too, instead of showing
1487 the name again. Fixes bug projects.maemo.org bug NB#59307.
1489 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1492 * src/modest-tny-simple-folder-store.c:
1493 * src/modest-tny-simple-folder-store.h: Removed.
1495 * src/modest-tny-local-folders-account.h
1496 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1497 for the local-folders maildir, with an extra TnyMergedFolder containing
1498 the folders of the per-account outbox store accounts.
1499 * src/modest-tny-account-store.c: (get_server_accounts):
1500 Add the outboxes to the special local folders account after creating it.
1502 * src/modest-tny-account.c:
1503 (modest_tny_account_new_for_local_folders): Create the derived
1504 account when creating the main local-folders account.
1506 * src/maemo/modest-main-window.c: (create_details_widget),
1507 (modest_main_window_set_contents_style):
1508 Adapted to the use of the derived account instead of the folder store.
1510 * src/modest-ui-actions.c:
1511 (modest_ui_actions_on_folder_selection_changed):
1512 * src/modest-ui-dimming-rules.c:
1513 (modest_ui_dimming_rules_on_new_folder):
1514 * src/widgets/modest-folder-view.c: (text_cell_data),
1515 (icon_cell_data), (filter_row), (update_model),
1516 (get_cmp_rows_type_pos):
1519 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1520 Do not get the priv struct, because no priv struct has been set,
1521 to avoid a runtime warning.
1523 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1524 #ifelse with #else, to fix a warning, to fix the build.
1527 2007-06-05 Christian Kellner <ckellner@openismus.com>
1529 * libmodest-dbus-client/libmodest-dbus-client.c:
1530 Fix small typo in doc (why do you always see them
1531 AFTER committing stuff?)
1534 2007-06-05 Christian Kellner <ckellner@openismus.com>
1536 * libmodest-dbus-client/libmodest-dbus-client.c:
1537 (libmodest_dbus_client_search):
1538 Initialize hit list with NULL. Also set folder list
1539 to "" if NULL was supplied.
1542 2007-06-03 Christian Kellner <ckellner@openismus.com>
1544 * libmodest-dbus-client/libmodest-dbus-client.c:
1545 (modest_search_hit_list_free):
1546 Make it save to call it with NULL.
1548 * src/dbus_api/modest-dbus-callbacks.c:
1549 * src/modest-search.c:
1550 Return full ModestSearchHits as the search result list not TnyHeader
1551 since can't be around withouth the correspoding TnyFolder.
1553 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1555 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1556 Added currently commented code to check for secure auth
1558 * src/maemo/modest-account-settings-dialog.c: (on_response),
1559 (save_configuration), (show_ok):
1560 Fixed projects.maemo.org bugs NB #59248 and #59251
1562 * src/maemo/modest-maemo-utils.c:
1563 (on_camel_account_get_supported_secure_authentication_status),
1564 (on_camel_account_get_supported_secure_authentication),
1565 (modest_maemo_utils_get_supported_secure_authentication_methods):
1566 * src/maemo/modest-maemo-utils.h:
1567 Moved get_supported_secure_authentication() method here to be able
1568 to use it from easysetup wizard.
1570 * src/modest-pair.c: (on_pair_compare_as_string):
1571 Should compare string with first part of pair and not
1572 strcmp pairs which will crash.
1574 * src/modest-protocol-info.c:
1575 (modest_protocol_info_protocol_is_store):
1576 * src/modest-protocol-info.h:
1577 Added modest_protocol_info_get_auth_protocol_name()
1579 2007-06-03 Armin Burgmeier <armin@openismus.com>
1581 * src/modest-mail-operation.c:
1582 (modest_mail_operation_get_msgs_full): Set priv->account also when
1583 only retrieving a single message. This avoids a crash when canceling
1586 (modest_mail_operation_notify_end): Do not explicitely remove the
1587 operation from the queue but only emit the progress_changed signal.
1588 The queue itself listens to that signal to remove the operation when
1589 it is finished. This reduces coupling and removes a potential deadlock
1590 when modest_mail_operation_notify_end() is called from the queue
1591 itself. If that is a problem performance-wise, I would suggest to
1592 implement a status-changed signal or something.
1594 * src/modest-mail-operation-queue.c: Make sure to never call a
1595 function from another file while the queue is locked. This (hopefully)
1596 fixes another deadlock when exiting the application while retrieving
1599 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1601 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1602 Fixed build if libogs is not available
1604 2007-06-03 Christian Kellner <ckellner@openismus.com>
1606 * libmodest-dbus-client/libmodest-dbus-client.h:
1607 * libmodest-dbus-client/libmodest-dbus-client.c:
1608 (libmodest_dbus_client_delete_message):
1609 Implement deletion of messages (Client side).
1611 (modest_search_hit_free),
1612 (modest_search_hit_list_free):
1613 Utility functions to free the result hits.
1615 * src/dbus_api/modest-dbus-api.h:
1616 * src/dbus_api/modest-dbus-callbacks.c:
1617 (on_delete_message),
1618 (modest_dbus_req_handler):
1619 Implement deletion of messages (Server side).
1621 * tests/dbus_api/test_search.c: (main):
1624 * tests/dbus_api/Makefile.am:
1625 * tests/dbus_api/test_delete_message:
1626 Add little test for the message deletion logic
1628 2007-06-03 Armin Burgmeier <armin@openismus.com>
1630 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1631 when the operation queue was not empty. projects.maemo.org bug
1634 2007-06-03 Armin Burgmeier <armin@openismus.com>
1636 * src/widgets/modest-account-view.c
1637 (on_account_default_toggled): Toggle default account column
1638 explicitely instead of waiting for gconf notification (which is
1639 currently ignored). This should fix projects.maemo.org bug NB#56910
1640 for now. It should probably be removed when gconf notifications are
1643 2007-06-03 Christian Kellner <ckellner@openismus.com>
1645 * libmodest-dbus-client/libmodest-dbus-client.c:
1646 Removed debugging spew.
1648 * src/dbus_api/modest-dbus-callbacks.c:
1649 Added debugging info.
1651 * src/modest-search.c:
1652 (modest_search_all_accounts):
1653 Use tny_account_store_get_accounts () on the account store
1654 to get all accounts which is the way to get all accounts.
1656 * tests/dbus_api/test_search.c: (main):
1657 Make it possible to supply the search term on the command line.
1659 2007-06-03 Christian Kellner <ckellner@openismus.com>
1661 * libmodest-dbus-client/libmodest-dbus-client.c:
1662 * libmodest-dbus-client/libmodest-dbus-client.h:
1663 Implement searching for mesages over raw dbus. (Client side)
1665 * src/dbus_api/Makefile.am:
1666 * src/dbus_api/modest-dbus-api.h:
1667 * src/dbus_api/modest-dbus-callbacks.c:
1668 * src/dbus_api/modest-dbus-callbacks.h:
1669 Search framework (Server side). Also implement on_idle_open_message().
1671 * src/maemo/modest-platform.c: (modest_platform_init):
1672 Prepare for raw dbus/osso rpc interaction.
1674 * src/modest-search.h:
1675 Changed minsize from unspecific guint to guint32.
1677 * src/modest-search.c:
1679 Added strange hack which magically made tnymail work.
1681 (modest_search_folder),
1682 (modest_search_account),
1683 (modest_search_all_accounts):
1684 Implement helper functions to search all accounts, specific account
1687 * tests/dbus_api/Makefile.am:
1688 * tests/dbus_api/test_open_message.c:
1689 Read url to open from commandline.
1691 * tests/dbus_api/test_search.c:
1692 Implement small test for dbus search stuff
1694 2007-06-02 Armin Burgmeier <armin@openismus.com>
1696 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1697 include account type and account title. This fixes projects.maemo.org
1700 * src/maemo/modest-account-view-window.c: Set a title for the window.
1702 2007-06-02 Armin Burgmeier <armin@openismus.com>
1704 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1705 incoming and outgoing server name based on email address and server
1706 types as long as the names have not been edited manually. This fixes
1707 projects.maemo.org bug NB#58671.
1709 2007-06-02 Armin Burgmeier <armin@openismus.com>
1711 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1712 server type cannot be changed in future to the incoming details page
1713 when creating an account. This fixes projects.maemo.org bug NB#59029.
1715 2007-06-02 Armin Burgmeier <armin@openismus.com>
1717 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1718 and assigned max width chars so that they wrap instead of being
1719 truncated. Fixes projects.maemo.org bug NB#56126.
1721 2007-06-02 Armin Burgmeier <armin@openismus.com>
1723 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1724 introductory note to the connection specific smtp servers dialog, as
1725 section 8.12 of the email UI specification requires. This fixes
1726 projects.maemo.org bug NB#59212.
1728 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1730 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1731 Check for running mail operations, and offer to cancel them, as per the UI
1732 spec. This fixes projects.maemo.org bug NB#59041 .
1733 However, I suspect that tinymail may still use the network connection
1734 in ways that we cannot detect or cancel. But it should at least adapt to
1735 changes fairly well.
1737 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1739 * src/modest-tny-account-store.c: (recreate_all_accounts),
1740 (get_cached_accounts), (get_server_accounts): Do more sensible
1741 ref-counting of the temporarily-cached outbox accounts list. This seems
1742 to fix a crash when entering the password when the password was wrong.
1744 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1746 * src/gnome/modest-main-window.c: (connect_signals):
1747 * src/modest-tny-account-store.c: (get_password),
1748 (modest_tny_account_store_alert): Added comments and clues and
1749 commented-out code about how we currently fail to deal with connection
1750 errors and wrong passwords, and how we should.
1752 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1754 * src/widgets/modest-retrieve-combo-box.c:
1755 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1756 This fixes projects.maemo.org bug NB#58472 .
1758 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1760 * src/maemo/easysetup/modest-easysetup-wizard.c:
1761 (create_page_complete_easysetup):
1762 (create_page_complete_custom): Correct the last commit,
1763 putting the correct sentences in the correct pages.
1765 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1767 * src/maemo/easysetup/modest-easysetup-wizard.c:
1768 (create_page_complete_custom): Show the second sentence of text
1769 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1772 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1774 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1775 Set the leave-on-server conf key by default. This fixes
1776 projects.maemo.org bug NB#59258 .
1778 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1780 * src/maemo/modest-account-view-window.c:
1781 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1782 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1785 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1787 * src/maemo/easysetup/modest-easysetup-wizard.c:
1788 (create_caption_new_with_asterisk):
1789 * src/maemo/modest-account-settings-dialog.c:
1790 (create_caption_new_with_asterisk):
1791 Uncomment the code to add the asterisk, because they are no longer in the
1792 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1793 (update_incoming_server_title): Add an asterisk here too.
1795 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1797 * src/maemo/modest-maemo-global-settings-dialog.c:
1798 (current_connection): Check that we are even connected before trying to
1799 get the current connection name, to prevent a warning.
1801 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1802 Change the comments because tny_maemo_conic_device_connect() is now meant to
1804 * src/modest-mail-operation.c:
1805 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1806 make sure we have a connection and fail if we can't connect.
1808 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1810 * src/maemo/modest-main-window.c:
1811 (on_account_store_connecting_finished): Do not try to get the
1812 connection ID if we are not really connected. I am surprised that
1813 this signal handler is called when we are not connected.
1815 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1817 * src/modest-error.h:
1818 * src/modest-ui-actions.c:
1819 (modest_ui_actions_get_msgs_full_error_handler):
1820 Renamed an enum, added comments, added an enum
1821 for retrieve-limit errors.
1823 * src/modest-mail-operation.c: (foreach_add_item),
1824 (internal_folder_observer_update), (update_account_thread),
1825 (modest_mail_operation_get_msgs_full):
1826 (modest_mail_operation_update_account),
1827 Added comments about how this works, and some code that should
1828 (but does not) check the retrieve-limit. See the TODO comment.
1830 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1833 Initialize help_id to fix the build. Warnings are good.
1835 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1837 * src/widgets/modest-hbox-cell-renderer.c:
1838 (modest_hbox_cell_renderer_append):
1839 * src/widgets/modest-vbox-cell-renderer.c:
1840 (modest_vbox_cell_renderer_append):
1841 Fix the last commit by doing an extra ref.
1843 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1845 * src/widgets/modest-hbox-cell-renderer.c:
1846 (modest_hbox_cell_renderer_append):
1847 * src/widgets/modest-vbox-cell-renderer.c:
1848 (modest_vbox_cell_renderer_append):
1849 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1850 to fix the build with Maemo Bora.
1851 However, there seems to be a remaining crash, probably due to reference
1854 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1856 * src/modest-tny-account.c:
1857 (modest_tny_account_new_for_local_folders):
1858 Use hildon_file_system_info_async_new() to get a better name for
1859 the memory card account, setting it as the account name.
1860 The timing seems to work, but this is probably
1861 not the best place to do this. See the TODO comment.
1862 * src/maemo/modest-main-window.c: (create_details_widget):
1863 * src/widgets/modest-folder-view.c: (text_cell_data):
1864 Use the tny account name instead of hardcoding a name.
1866 2007-05-30 Christian Kellner <ckellner@openismus.com>
1868 * src/modest-search.c: (modest_search):
1869 Correctly set part_search_func even if we have already parsed
1870 the query and thus a valid OgsTextSearcher object.
1872 2007-05-30 Christian Kellner <ckellner@openismus.com>
1875 Search and check for libogs.
1878 Incooparte the ogs build env.
1880 * src/modest-mime-part-search-stream.c:
1881 * src/modest-mime-part-search-stream.h:
1882 Removed since we do the real searching now in modest-search.c.
1884 * src/modest-search.c:
1885 * src/modest-search.h:
1886 Implement support for ogs. We use that if available and requested
1887 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1888 should now handle the corner case when the search term is spread
1889 across multiple reads.
1890 Also the logic in modest_search () was corrected to search all
1891 requested fields until one is found.
1893 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1895 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1897 * src/modest-init.h:
1898 * src/modest-init.c: Made modest_init_local_folders() take a
1899 path and be public so we can iniitialize maildir folders on
1902 * src/modest-local-folder-info.h:
1903 * src/modest-local-folder-info.c:
1904 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1906 * src/modest-tny-account.c:
1907 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1908 still means the standard local-folders path on the local volume.
1910 * src/modest-tny-account-store.c:
1911 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1912 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1913 all accounts when that happens.
1914 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1915 this too, so it shows up in the treeview.
1917 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1919 * src/maemo/modest-maemo-global-settings-dialog.c:
1920 (current_connection):
1921 * src/widgets/modest-global-settings-dialog.c:
1922 (current_connection_default):
1923 Use the enum values instead of 0, 1 and -1,
1924 to make the code clearer.
1926 * src/modest-account-mgr-helpers.c:
1927 (modest_account_mgr_get_connection_specific_smtp): Make this code
1930 * src/modest-runtime.h:
1931 * src/modest-runtime.c:
1932 Added modest_runtime_remove_all_send_queues().
1933 * src/maemo/modest-main-window.c:
1934 (on_account_store_connecting_finished): Recreate the send queues,
1935 using the appropriate transport accounts for this new connection.
1936 Some futher adapting might be needed if the old send queues are not
1937 automatically stopped at this point.
1939 * src/modest-tny-account-store.c: (get_server_accounts):
1940 Create the connection-specific transport accounts, so that they can
1941 be found later by their ID.
1943 * src/modest-tny-account.h:
1944 * src/modest-tny-account.c:
1945 Added modest_tny_account_new_from_server_account_name().
1946 modest_tny_account_new_from_server_account(): Do not create the
1947 send queues here, because they will be
1948 recreated anyway when the connection changes for the first time.
1950 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1952 * src/modest-local-folder-info.h:
1953 * src/modest-local-folder-info.c:
1954 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1955 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1956 tbox_folder): Take a modest account name instead of a server TnyAccount,
1957 so we can have per-modest-account rather than per-transport-account
1959 We must make sure that we change or recreate the exisitng send queues
1960 when the connection changes for connection-specific transport accounts.
1962 * src/modest-tny-account-store.c:
1963 (create_per_account_local_outbox_folders): Create outboxed per modest
1964 account, not per transport account.
1966 * src/modest-tny-account.h:
1967 * src/modest-tny-account.c:
1968 (modest_tny_account_get_special_folder): For outboxes, get the
1969 parent modest account name. The account is ignored for other folders.
1970 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1971 modest account name rather than a server TnyAccount.
1973 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1975 * src/modest-tny-account.c:
1976 (modest_tny_account_new_from_server_account):
1977 Call modest_runtime_get_send_queue() immediately after creating transport
1978 accounts, so that they start trying to send email from the outbox as soon
1979 as possible at startup. This is probably what we want.
1981 * src/modest-mail-operation.c: (update_account_thread):
1982 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1983 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1984 * src/modest-tny-send-queue.h:
1985 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1986 (modest_ui_actions_on_send):
1987 Added comments about how sending works, though it needs some more work.
1989 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1991 * src/modest-tny-account.c:
1992 (modest_tny_account_get_special_folder): Add TODO because this fails when
1993 the network is busy.
1994 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1995 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1996 Do not try to show this window when there is no active account. The UI
1997 specs does not tell us what to do in this case.
1999 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2003 * src/maemo/Makefile.am:
2004 * src/widgets/Makefile.am: Some dist fixes.
2006 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2008 * src/maemo/modest-connection-specific-smtp-window.c:
2009 (on_button_edit): Make the code clearer, to prevent a double free.
2011 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2013 * src/maemo/modest-account-settings-dialog.c:
2014 (modest_account_settings_dialog_set_account_name),
2015 Check the connection-specific smtp servers checkbox if there are any.
2017 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2018 (modest_connection_specific_smtp_edit_window_init):
2019 Start with a suitable port number.
2021 * src/modest-account-mgr-helpers.h:
2022 * src/modest-account-mgr-helpers.c: Added
2023 modest_account_mgr_get_has_connection_specific_smtp().
2025 (modest_account_mgr_set_connection_specific_smtp),
2026 (modest_account_mgr_remove_connection_specific_smtp),
2027 (modest_account_mgr_get_has_connection_specific_smtp),
2028 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2029 connection-specific smtp server accounts in the account, rather than
2030 the server account conf dir.
2032 This fixes bug projects.maemo.org bug NB#58263 .
2034 * src/modest-tny-account-store.c:
2035 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2036 if there are no server accounts yet, to prevent an infinite loop when there
2037 are no accounts. Document that one must be called before the other.
2039 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2041 * src/modest-account-mgr-helpers.c:
2042 (modest_account_mgr_get_default_account): Make sure that at least
2043 one account is always the default, if there are any enabled accounts.
2044 This is just a sanity check that shouldn't be necessary.
2046 * src/modest-account-mgr-priv.c:
2047 (_modest_account_mgr_account_from_key): Unescape the conf key to
2048 get the real account name. For instance, this is an issue if a space
2049 was in the account name, which can happen because the account name
2050 is generated from the display name.
2051 (_modest_account_mgr_get_account_keyname): Always escape the
2053 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2054 Unescape the conf keys to get the real account names.
2056 For instance, previously the is-default radio button in the accounts
2057 list was not checked for any accounts at first. This fixes that,
2058 and might fix several similar bugs.
2060 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2062 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2063 Removed some debug printfs.
2065 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2067 Modest on-disk outbox directories are now here, for instance:
2068 $HOME/.modest/outboxes/<account-id-1>/outbox
2069 $HOME/.modest/outboxes/<account-id-2>/outbox
2071 $HOME/.modest/local-folders/outbox
2072 so we can have a separate outbox for each account.
2073 But they are shown as one outbox in the GtkTreeView, by using a
2074 TnyMergeFolder in a ModestTnySimpleFolderStore.
2077 * src/modest-tny-simple-folder-store.c:
2078 * src/modest-tny-simple-folder-store.h:
2079 Added ModestTnySimpleFolderStore, used to contain folders from
2080 other folder stores, such as other accounts.
2082 * src/modest-tny-outbox-account.h:
2083 * src/modest-tny-outbox-account.c:
2084 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2085 used for the per-account local outbox folders.
2087 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2088 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2089 only use this (internally) now for the non-outbox local folders.
2091 * src/modest-init.h:
2092 * src/modest-init.c: Added modest_init_one_local_folder(), for
2093 setting up the directory structure for each local folder.
2095 * src/modest-local-folder-info.c:
2096 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2097 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2099 * src/modest-local-folder-info.h:
2100 * src/modest-tny-account-store.c: (on_account_removed),
2101 (on_account_changed), (create_per_account_local_outbox_folders),
2102 (get_server_accounts), (modest_tny_account_store_get_accounts),
2103 (modest_tny_account_store_get_tny_account_by_account),
2104 (modest_tny_folder_store_is_virtual_local_folders):
2106 * src/modest-tny-account.h:
2107 * src/modest-tny-account.c:
2108 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2109 to create an on-disk per-account local outbox folder for each
2111 (create_per_account_local_outbox_folders): Create a local outbox folder
2112 for each transport account.
2113 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2114 for all local folders.
2116 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2117 instead of using g_object_get/set() directly. It is clearer.
2119 (modest_tny_folder_store_get_message_count),
2120 (modest_tny_folder_store_get_local_size
2121 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2122 because we now use these with non-acount folder stores.
2124 (modest_tny_account_get_special_folder),
2125 (modest_tny_account_new_from_server_account),
2126 (modest_tny_account_new_from_account):
2127 (recurse_folders): Adjust to the new outbox system.
2129 * src/modest-tny-folder.h:
2130 * src/modest-tny-folder.c:
2131 (modest_tny_folder_is_local_folder),
2132 (modest_tny_folder_get_local_folder_type),
2133 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2135 * src/widgets/modest-main-window.h:
2136 * src/maemo/modest-main-window.c: (create_details_widget),
2137 (modest_main_window_set_contents_style): Show details for any folder store,
2140 (modest_tny_folder_get_rules):
2141 Remove the const. C does not support constness enough for this.
2143 * src/modest-ui-actions.c:
2144 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2145 make all outboxes appear as one, in the usual local-folders tree node.
2147 (set_active_account_from_tny_account),
2148 (modest_ui_actions_on_folder_selection_changed):
2149 * src/widgets/modest-folder-view.c: (text_cell_data),
2150 (icon_cell_data), (filter_row),
2151 (add_account_folders_to_merged_folder),
2152 (add_account_folders_to_simple_folder_store), (),
2153 (get_cmp_rows_type_pos), (cmp_rows),
2154 (modest_folder_view_set_account_id_of_visible_server_account):
2155 Adjust to the new outbox system, using generic folder stores and folders
2156 in the GtkTreeModel.
2158 2007-05-23 Christian Kellner <ckellner@openismus.com>
2160 * src/modest-mail-operation.c:
2161 (modest_mail_operation_update_account):
2162 Use info->max_size instead of unintialized local var [small
2163 build fix]. (Added TODO to review that change since I don't
2166 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2168 * libmodest-dbus-client/libmodest-dbus-client.c:
2169 (libmodest_dbus_client_compose_mail): function added
2170 * src/dbus_api/modest-dbus-api.h:
2171 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2172 (on_compose_mail): Implementation of the SendAsMail functionality
2174 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2176 * src/modest-account-mgr.c:
2177 (modest_account_mgr_add_server_account): Set the secure-connection
2178 conf key for transport accounts as well as store accounts. I don't know
2179 why the if was there. For instance, this makes sure that we use SSL
2180 for the gmail preset from the easysetup wizard.
2182 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2184 * src/gnome/modest-main-window.c:
2185 (on_account_store_connecting_finished), (connect_signals):
2186 * src/maemo/modest-main-window.c:
2187 (on_account_store_connecting_finished), (connect_signals),
2188 (modest_main_window_new):
2189 Handle TnyAccountStore::connecting-finished instead of
2190 TnyDevice::connection-changed, because we cannot actually perform
2191 operations on accounts until TnyAccountStore has itself responded to
2192 the TnyDevice::connection-changed signal. This prevents a GError from
2194 Do not try to update at startup, because we (at least on scratchbox)
2195 already do an update at startup when the device goes online.
2196 This prevents a GError from tinymail.
2197 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2198 Added TODO about stopping simultaneous operations.
2200 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2202 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2203 * src/modest-mail-operation-queue.c:
2204 (modest_mail_operation_queue_remove):
2205 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2206 about where they happened.
2208 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2210 * src/modest-ui-actions.c:
2211 (modest_ui_actions_on_password_requested): Make sure that the remember
2212 output parameter is always TRUE.
2214 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2216 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2217 Show a OK/Cancel dialog if the error is a question, though we still do not
2218 know anything more about what we are asking the user.
2219 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2220 Fix an uninitialized variable (helper). This is a logic error, however.
2222 2007-05-21 Christian Kellner <ckellner@openismus.com>
2224 * src/modest-search.h:
2225 Correct bit shifting in the ModestSearchFlags enum.
2227 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2229 * src/modest-tny-account.c:
2230 (modest_tny_account_new_from_server_account): Do not use the lsub and
2231 check-all hard-coded IMAP options when using POP.
2233 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2235 * src/modest-tny-account.c:
2236 (modest_tny_account_new_from_server_account):
2237 Use NULL for the secure-auth method for POP when Password auth has been
2238 specified by the user, as we already do for IMAP. "auth=Login" causes
2239 an error from camel or the server.
2241 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2243 * src/maemo/modest-account-settings-dialog.c:
2244 (create_page_account_details),
2245 (modest_account_settings_dialog_set_account_name):
2246 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2247 for the leave-on-server checkbox, rathr than just the checkbox, when
2248 the protocol is not POP.
2250 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2252 * src/widgets/modest-account-view.c:
2253 * src/widgets/modest-account-view.h:
2254 Added modest_account_view_select_account() which will be useful later
2255 to asynchronously re-select the edited account.
2257 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2259 * src/maemo/modest-account-settings-dialog.c:
2260 (modest_account_settings_dialog_set_account_name):
2261 Automatically choose the port numbers based on the secure authentication
2262 methods, if they have not been chosen before.
2263 This fixes projects.maemo.org bug NB#56273 .
2265 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2267 * src/maemo/modest-main-window-ui.h:
2268 * src/modest-ui-actions.c:
2269 * src/modest-ui-actions.h:
2270 Connect the Tools/SMTP Servers menu item to
2271 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2272 SMTP servers dialog, as in the UI specification and saves changes when it
2273 is closed. This fixed projects.maemo.org bug NB#56305 .
2275 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2277 * src/maemo/modest-connection-specific-smtp-window.c:
2278 (modest_connection_specific_smtp_window_init):
2279 Use gtk_window_set_default_size() to make this window big enough, so
2280 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2282 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2284 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2285 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2286 (modest_connection_specific_smtp_edit_window_init),
2287 Do not try to connect to a combobox signal before the combobox exists.
2288 This fixes the cras in projects.maemo.org bug NB#56288 .
2289 (modest_connection_specific_smtp_edit_window_get_settings):
2290 Remove the server_account_name parameter which was being checked for NULL
2291 though it was not used.
2293 * src/maemo/modest-connection-specific-smtp-window.c:
2294 (modest_connection_specific_smtp_window_fill_with_connections),
2295 (on_button_edit), (modest_connection_specific_smtp_window_init):
2296 Correct the number of treemodel columns to prevent a warning.
2297 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2298 libconic does not work.
2300 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2302 * src/modest-tny-account.c:
2303 (modest_tny_account_new_from_server_account):
2304 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2305 SMTP when "None" was chosen by the user. However, with my SMTP server that
2306 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2309 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2311 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2312 to explain the memory management issue with the ID in the ModestPair.
2314 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2315 (add_sending_page), (modest_account_assistant_finalize):
2316 * src/gnome/modest-gnome-global-settings-dialog.c:
2317 (create_updating_page), (create_composing_page):
2318 * src/gnome/modest-msg-edit-window.c: (get_transports),
2319 (init_window), (modest_msg_edit_window_finalize),
2320 (modest_msg_edit_window_get_msg_data):
2321 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2322 * src/gnome/modest-transport-widget.c:
2323 (modest_transport_widget_finalize), (smtp_configuration):
2324 * src/maemo/modest-maemo-global-settings-dialog.c:
2325 (create_updating_page), (create_composing_page):
2326 * src/maemo/modest-msg-edit-window.c: (get_transports),
2327 (init_window), (modest_msg_edit_window_finalize),
2328 (modest_msg_edit_window_get_msg_data),
2329 (modest_msg_edit_window_free_msg_data):
2330 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2331 (modest_store_widget_finalize):
2332 * src/maemo/modest-transport-widget.c:
2333 (modest_transport_widget_finalize), (smtp_configuration):
2334 * src/modest-main.c: (send_mail):
2335 * src/widgets/modest-combo-box.h:
2336 * src/widgets/modest-global-settings-dialog-priv.h:
2337 * src/widgets/modest-global-settings-dialog.c:
2338 (modest_global_settings_dialog_finalize):
2339 * src/widgets/modest-msg-edit-window.h:
2340 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2341 as long as the combo box, to prevent use of freed memory for the ID.
2343 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2345 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2346 get_accounts(), to make this clearer. Do not check for the enabled gconf
2347 key, because we do not use this for server accounts (at least, not yet).
2348 This allows us to send email again.
2350 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2352 * src/maemo/modest-platform.c:
2353 (on_modest_conf_update_interval_changed), (modest_platform_init):
2354 Only respond to this particular key change. All these strcmp()s cannot be
2357 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2359 * src/maemo/modest-maemo-global-settings-dialog.c:
2360 (current_connection): Prevent a crash in scratchbox when
2361 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2362 * src/maemo/modest-platform.c:
2363 (on_modest_conf_update_interval_changed), (modest_platform_init):
2364 Get the update interval from gconf and reset it when the gconf key changes.
2366 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2368 * src/modest-protocol-info.c:
2369 * src/modest-protocol-info.h: Adde enum-specific get functions,
2370 instead of using a ModestProtocolType enum parameter.
2372 * src/gnome/modest-account-assistant.c:
2373 * src/gnome/modest-store-widget.c:
2374 * src/gnome/modest-store-widget.h:
2375 * src/gnome/modest-transport-widget.c:
2376 * src/gnome/modest-transport-widget.h:
2377 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2378 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2379 * src/maemo/easysetup/modest-easysetup-wizard.c:
2380 * src/maemo/modest-account-settings-dialog.c:
2381 * src/maemo/modest-account-settings-dialog.h:
2382 * src/maemo/modest-store-widget.c:
2383 * src/maemo/modest-store-widget.h:
2384 * src/maemo/modest-transport-widget.c:
2385 * src/maemo/modest-transport-widget.h:
2386 * src/modest-account-mgr-helpers.c:
2387 * src/modest-account-mgr-helpers.h:
2388 * src/modest-account-mgr.c:
2389 * src/modest-account-mgr.h:
2390 * src/modest-tny-account.c:
2391 * src/modest-tny-folder.c:
2392 * src/widgets/modest-account-view.c:
2393 * src/widgets/modest-retrieve-combo-box.c:
2394 * src/widgets/modest-retrieve-combo-box.h:
2395 * src/widgets/modest-secureauth-combo-box.c:
2396 * src/widgets/modest-serversecurity-combo-box.c:
2397 * src/widgets/modest-serversecurity-combo-box.h:
2398 * tests/check_account-mgr.c:
2399 Use the specific functions, and use the re-renamed enum values for GNOME too.
2401 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2403 * src/modest-pair.h:
2404 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2405 so we can get the second based on the first.
2407 * src/maemo/modest-account-settings-dialog.h:
2408 * src/maemo/modest-account-settings-dialog.c:
2409 Added get_supported_secure_authentication_methods(), though it is mostly
2410 commented-out for now until the necessary API is committed to tinymail.
2411 (modest_account_settings_dialog_set_account_name),
2412 (save_configuration): Request the supported authentication methods from the
2413 server, so we can choose a working method.
2415 * src/modest-tny-account-store.h:
2416 * src/modest-tny-account-store.c:
2417 (modest_tny_account_store_get_session): Rename from
2418 tny_account_store_get_session().
2420 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2422 * src/modest-protocol-info.h: Split the ModestProtocol enum
2423 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2424 There was no need to have these unrelated values in one enum.
2426 * src/: many files: Adapted to changed enum. This makes the code a bit
2427 clearer, and the compiler could catch some errors.
2429 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2431 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2432 Show the detailed internal camel error message when an error happens
2433 during the configuration, so that our testers can give us more clues.
2434 For instance, in projects.maemo.org bug NB#56910 .
2436 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2438 * src/modest-tny-account.c:
2439 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2440 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2442 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2444 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2445 * src/maemo/modest-account-settings-dialog.c:
2446 (modest_account_settings_dialog_set_account_name),
2447 (save_configuration): For the incoming secure authentication checkbox,
2448 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2449 the UI specification. PLAIN does not seem to be supported for most IMAP
2450 servers anyway, and I am not sure what it would mean.
2451 However, we probably need to discover which of the secure-authentication
2452 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2453 * src/modest-account-mgr-helpers.c:
2454 (modest_account_mgr_get_server_account_data):
2456 * src/modest-tny-account.c:
2457 (modest_tny_account_new_from_server_account):
2458 Use tny_account_set_mech() to set secure-authentication methods,
2459 with some special-casing for IMAP, based on my observations of how
2462 * src/modest-account-mgr-helpers.h:
2463 * src/modest-account-mgr.c:
2464 * src/modest-defs.h: Comment that the URI is only used for local folders.
2466 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2468 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2469 parameter const, just to be neat.
2470 * src/modest-text-utils.c: (modest_text_utils_inline):
2471 End g_strconcat() with NULL, as its documentation says. This is almost
2472 certainly the cause of my crash at startup on the device. Interestingly,
2473 valgrind doesn't tell us about these errors.
2475 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2477 * scripts/build-packages: Added more precise comments about how to use
2478 this script, though I still get this error:
2479 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2480 error building tinymail
2482 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2484 * src/maemo/modest-main-window.c: (on_account_update):
2485 Very slight cleanup, hoping to make it simpler to discover what causes
2486 a crash here sometimes.
2488 * src/modest-tny-account.c:
2489 (modest_tny_account_new_from_server_account): Set the port. Added
2490 comments about the options and a TODO comment because I need to find out
2491 how to specify the secure authentication method.
2493 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2495 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2496 changed CFlags paths form modest to libmodest
2498 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2500 * src/modest-account-mgr-helpers.c:
2501 (modest_account_mgr_get_server_account_data),
2502 (modest_account_mgr_free_server_account_data):
2503 * src/modest-account-mgr-helpers.h:
2504 * src/modest-account-mgr.c:
2505 (modest_account_mgr_add_server_account):
2506 * src/modest-defs.h:
2507 * src/modest-tny-account.c:
2508 (modest_tny_account_new_from_server_account):
2509 Determine the options for tny_camel_account_add_option() here,
2510 based on the settings, rather than storing them directly in gconf.
2512 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2514 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2515 Show a more friendly error dialog now that we expect (from the tinymail
2516 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2518 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2520 * src/maemo/modest-main-window.c: (on_account_update): Check that
2521 account_name is not NULL, to prevent a crash at startup that I am
2522 seeing on the N800. I do wonder why it is NULL.
2524 * src/maemo/easysetup/modest-easysetup-wizard.c:
2525 (create_page_user_details):
2526 * src/maemo/modest-account-settings-dialog.c:
2527 (create_page_user_details), (create_page_outgoing):
2528 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2529 (modest_connection_specific_smtp_edit_window_init):
2530 * src/modest-ui-actions.c:
2531 (modest_ui_actions_on_password_requested):
2532 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2533 might do something useful with the on-screen keyboard.
2535 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2537 * src/maemo/modest-main-window.c: (on_account_update):
2538 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2539 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2541 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2543 * src/modest-tny-account-store.c: (on_account_changed):
2544 Correct the signature of this signal handler.
2546 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2548 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2549 Show a HildonNote instead of a GtkDialog for Maemo.
2551 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2553 * src/widgets/modest-account-view.h:
2554 * src/widgets/modest-account-view.c: (on_account_changed),
2555 (on_account_removed). Added a boolean flag, set/unset by
2556 modest_account_view_block_conf_updates(),
2557 modest_account_view_unblock_conf_updates() to prevent unnecessary
2558 updates, but this is not very useful because the gconf notifications are
2559 so delays (maybe only on Maemo Bora).
2560 So auto-updating is turned off, and these functions do an explicit
2561 update when necessary.
2562 However, something else is still doing too much work when adding/removing
2563 accounts, probably in another part of the application.
2565 * src/maemo/modest-account-view-window.c:
2566 (on_delete_button_clicked), (on_edit_button_clicked),
2567 (on_new_button_clicked): Use the new functions.
2569 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2571 * src/modest-account-mgr-helpers.c:
2572 (modest_account_mgr_set_first_account_as_default):
2573 Sort the list of names alphabetically-by-title, so we choose the first one
2575 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2576 alphabetically by the title.
2578 This fixes projects.maemo.org bug NB#56418 .
2580 * src/modest-account-mgr-priv.c:
2581 (_modest_account_mgr_account_from_key):
2582 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2583 avoid a valgrind error, and possible random behaviour.
2585 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2587 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2588 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2589 tinymail documentation to say that this can be expected.
2590 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2591 pretty, and should not happen, but I would prefer to know when it does.
2593 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2595 * configure.ac: When using the older hildon version, probably on Bora,
2596 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2598 * src/widgets/modest-attachment-view.c:
2599 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2602 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2604 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2605 Implemented the prototype. Can be tested with
2606 tests/dbus_api/test_open_message:
2608 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2610 * src/modest-tny-account-store.c:
2611 (modest_tny_account_store_instance_init), (get_password):
2612 * src/modest-ui-actions.c:
2613 (modest_ui_actions_on_password_requested):
2614 Do not store the password in gconf, because this function is called
2615 for non-remembered passwords. Actually use the cached (in the hash map)
2616 password instead of releasing it.
2617 The password will now not be remembered if it is asked via the protected
2618 password dialog, as per the UI spec.
2620 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2622 * src/modest-defs.h:
2623 * src/modest-account-mgr-helpers.h:
2624 * src/modest-account-mgr-helpers.c:
2625 Added modest_server_account_get_username_has_succeeded(),
2626 modest_server_account_set_username_has_succeeded().
2627 (modest_server_account_set_username),
2628 Reset the has-succeeded flag if the username changes.
2630 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2631 * src/maemo/modest-connection-specific-smtp-window.c:
2632 (modest_connection_specific_smtp_window_save_server_accounts):
2633 Use modest_server_account_set_username() instead of using
2634 modest_conf_set_string() directly, so that the has-succeeded flag is always
2637 * src/modest-ui-actions.c:
2638 (modest_ui_actions_on_password_requested): Dim the username entry if
2639 the username has ever worked, as per the UI spec.
2641 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2643 * src/modest-tny-account-store.c: (get_password):
2644 * src/modest-ui-actions.c:
2645 (modest_ui_actions_on_password_requested):
2646 Allow the username to be changed too, though there is more work to
2647 be done on exactly how this behaves.
2649 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2651 * src/modest-account-mgr-helpers.h:
2652 * src/modest-account-mgr-helpers.c:
2653 Added modest_account_mgr_get_display_name(),
2654 modest_server_account_get_username(),
2655 modest_server_account_set_username(),
2656 modest_server_account_set_password(),
2657 modest_server_account_get_hostname() functions so we do not need to
2658 use the conf API directly.
2660 * src/maemo/modest-main-window.c: (connect_signals):
2661 Actually connect ot the ModestAccountStore::request-password signal,
2662 so that we show the dialog when the password is requested by Tinymail,
2663 for isntance if it is empty.
2665 * src/modest-marshal.list:
2666 * src/modest-tny-account-store.c:
2667 (modest_tny_account_store_class_init), (get_password),
2668 (modest_tny_account_store_alert):
2669 * src/modest-tny-account-store.h:
2670 * src/modest-ui-actions.h:
2671 * src/modest-ui-actions.c:
2672 (modest_ui_actions_on_password_requested):
2673 Change the signal parameters, so it is obvious that we are providing
2674 the non human-readable server name, and receiving both the username
2675 and password, though changing of the username is not yet implemented.
2676 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2677 for the GNOME version.
2679 This should fix the projects.maemo.org bug NB#56209, though it does not
2680 work on Bora, because the gconf_client_get() for the password fails
2681 immediately after we save it with gconf_client_set().
2683 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2686 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2687 caused an undefined symbol error:
2688 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2690 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2692 * src/modest-tny-account-store.c:
2693 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2694 using a GError instead of a string message, so we can translate it in
2697 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2699 * src/maemo/modest-address-book.c:
2700 (modest_address_book_check_names):
2701 * src/maemo/modest-msg-view-window.c:
2702 (modest_msg_view_window_clipboard_owner_change):
2703 * src/modest-init.c: (modest_init_init_ui):
2704 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2705 (update_folders_cb), (modest_mail_operation_update_account):
2706 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2707 (modest_ui_actions_on_msg_attachment_clicked),
2708 (modest_ui_actions_on_msg_recpt_activated):
2709 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2710 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2711 (modest_msg_view_search_next):
2712 * src/widgets/modest-recpt-editor.c:
2713 (modest_recpt_editor_on_button_release_event),
2714 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2715 g_message(). At this point we should only be seeing interesting errors on
2716 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2718 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2720 (modest_wizard_dialog_force_title_update):
2721 * src/maemo/easysetup/modest-wizard-dialog.h:
2722 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2723 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2724 can update the title when appropriate. Otherwise the title is wrong if the
2725 pages are added after adding the notebook to the dialog.
2726 This must be a problem in HildonWizardDialog too.
2727 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2729 * src/maemo/easysetup/modest-easysetup-wizard.c:
2730 (create_subsequent_customsetup_pages),
2731 (create_subsequent_easysetup_pages):
2732 Call modest_wizard_dialog_force_title_update() so that the title is
2733 correct even with GTK+ < 2.10.
2734 This fixes projects.maemo.org bug NB#56145 .
2736 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2738 * src/maemo/modest-platform.c:
2739 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2740 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2743 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2745 * src/widgets/modest-window.h:
2746 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2747 and modest_window_save_state(), which invokes it.
2749 * src/widgets/modest-window-mgr.h:
2750 * src/widgets/modest-window-mgr.c:
2751 Added modest_window_mgr_save_state_for_all_windows(), which calls
2752 the save_state vfunc on all registered windows, if implemented.
2754 * src/gnome/modest-msg-edit-window.c:
2755 * src/gnome/modest-msg-view-window.c:
2756 * src/maemo/modest-msg-edit-window.c:
2757 * src/maemo/modest-msg-view-window.c:
2758 * src/maemo/modest-main-window.c:
2759 Specify the existing save_settings functions as implementations of
2760 ModestWindow::save_state_func().
2762 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2763 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2764 enabling hibernation, for instance.
2766 We may need to do the same thing for restoring settings.
2769 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2771 * src/widgets/modest-window-mgr.c:
2772 * src/widgets/modest-window-mgr.h:
2773 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2774 modest_window_mgr_get_hibernation_is_prevented().
2776 * src/maemo/modest-main-window.c:
2777 (on_hildon_program_is_topmost_notify): Prevent hibernation
2778 (possible when the application goes to the background in the WM),
2779 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2781 * src/maemo/easysetup/modest-easysetup-wizard.c:
2782 (modest_easysetup_wizard_dialog_init):
2783 * src/maemo/modest-account-settings-dialog.c:
2784 (modest_account_settings_dialog_init):
2785 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2786 (modest_connection_specific_smtp_edit_window_init):
2787 * src/maemo/modest-connection-specific-smtp-window.c:
2788 (modest_connection_specific_smtp_window_init):
2789 * src/maemo/modest-signature-editor-dialog.c:
2790 (modest_signature_editor_dialog_init):
2791 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2792 prevent hibernation while any of these account settings dialogs are open.
2794 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2796 * src/maemo/Makefile.am:
2797 * src/maemo/modest-osso-state-saving.c:
2798 * src/maemo/modest-osso-state-saving.h: Added
2799 modest_osso_load_state() and modest_osso_save_state() though they do
2800 nothing now. They should iterate through all the open windows and load/save
2802 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2803 save state when closing.
2805 * src/maemo/modest-main-window.c:
2806 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2807 Add a notification handler for the HildonProgram::is-topmost property,
2808 so we can allow hibernation when the application goes into the background.
2809 But we still need to detect when the accounts setup windows are open so
2810 we can stop hibernation when they are open.
2811 To do this, I also added the main window the HildonProgram. This might have
2812 other side-effects/benefits, and should maybe be done for other windows.
2814 * src/maemo/modest-osso-autosave-callbacks.h:
2815 * src/maemo/modest-osso-autosave-callbacks.c:
2816 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2817 though it does not do anything yet, and we might never need this to do
2818 anything. For instance, we already save drafts.
2820 * src/maemo/modest-platform.c: (modest_platform_init):
2821 Specify the libosso auto-save callback.
2823 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2825 * src/maemo/modest-platform.c:
2826 (modest_platform_set_update_interval):
2827 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2828 aparently stays valid between application instances, so we can use this
2829 to remove and reset it later. According to a maemo-developers email from
2832 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2834 * configure.ac: Depend on libalarm for Maemo.
2836 * src/dbus_api/modest-dbus-api.h:
2837 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2838 (on_send_receive), (modest_dbus_req_handler):
2839 Handle a SEND_RECEIVE D-Bus method.
2841 * libmodest-dbus-client/libmodest-dbus-client.c:
2842 (libmodest_dbus_client_send_and_receive):
2843 * libmodest-dbus-client/libmodest-dbus-client.h:
2844 Add C convenience functions for calling the new D-Bus method.
2846 * src/modest-platform.h:
2847 * src/gnome/modest-platform.c:
2848 * src/maemo/modest-platform.c:
2849 Added modest_platform_set_update_interval(), which uses the
2850 alarmd API on Maemo.
2851 (modest_platform_init),
2852 Call modest_platform_set_update_interval(), using a hard-coded
2853 interval for now (until the global settings dialog is implemented),
2854 though I am not sure that this makes sense yet.
2856 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2858 * src/dbus_api/modest-dbus-callbacks.c:
2859 (modest_osso_cb_hw_state_handler):
2860 * src/dbus_api/modest-dbus-callbacks.h:
2861 * src/maemo/modest-platform.c: (modest_platform_init):
2862 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2863 in case this has some effect on the ability for Maemo to ping the
2866 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2868 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2869 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2870 warning. It is probably a logic error, but I need to fix the build.
2872 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2874 * src/modest-account-mgr.h:
2875 * src/modest-account-mgr.c:
2876 (modest_account_mgr_account_names): Add a gboolean enabled_only
2877 parameter, so we can get lists of onlt the enabled accounts.
2879 (modest_account_mgr_add_account),,
2880 (modest_account_mgr_account_with_display_name_exists):
2881 * src/maemo/modest-msg-edit-window.c: (get_transports):
2882 * src/modest-account-mgr-helpers.c:
2883 (modest_account_mgr_set_first_account_as_default):
2884 * src/modest-init.c: (init_default_account_maybe):
2885 * src/modest-tny-account-store.c: (get_accounts):
2886 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2887 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2888 * tests/check_account-mgr.c: (START_TEST):
2889 Provide the extra parameter, as appropriate.
2891 * src/widgets/modest-account-view.c: (update_account_view):
2892 Do not show disabled accounts (meaning that there is no way to
2893 enable/disable accounts in the UI (the feature is not in our UI
2894 specification), so we can use this internally only to mark unfinished
2895 or temporary account data.
2897 * src/maemo/easysetup/modest-easysetup-wizard.c:
2898 (create_account): Add boolean enable parameter, so we can specify FALSE
2899 to create the temporary account.
2900 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2901 (on_before_next): When finishing, when there is a temporary account, just
2903 Also, use a timeout to delay the showing of the dialog until gconf is likely
2904 to return correct information, due to a maemo gconf bug that is fixed in
2905 osso 1.1, but not yet in Bora.
2906 However, the dialog stays on screen after it is destroyed.
2908 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2909 for invalid data when cancelling. Use a hildon note instead of a dialog
2910 to complain about invalid data. Do not show the account-saved note if the
2911 account is disabled (a temporary account that will not really be saved for use
2914 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2916 * src/modest-account-mgr-helpers.h:
2917 * src/modest-account-mgr-helpers.c:
2918 Added modest_account_mgr_unset_default_account(),
2919 Added modest_account_mgr_set_first_account_as_default().
2921 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2922 If it was the default account, unset the default account name.
2924 * src/maemo/modest-account-view-window.c:
2925 (on_delete_button_clicked): If it was the default account,
2926 set the first remaining account as the default instead.
2928 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2929 a NULL account or a NULL default account, to prevent a crash. This should
2930 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2933 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2935 * src/widgets/modest-recpt-editor.c:
2936 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2937 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2938 TODO comment for this. This fixes the build.
2940 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2941 be the best place for it. This will in future update all auto-update accounts,
2942 rather than just the current/default account, when that gconf key exists.
2943 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2944 if there are no accounts, before calling do_send_receive().
2945 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2947 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2948 * src/maemo/modest-main-window-ui.h:
2949 * src/maemo/modest-main-window.c: (on_connection_changed),
2950 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2951 directly, becaue the signal handler does more.
2953 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2955 * src/modest-account-mgr-helpers.c:
2956 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2957 for the case that the account does not exist.
2959 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2960 (equivalent to the modest account name) rather than the tinymail account name
2961 (equivalent to the modest account title - human readable) to get the account data.
2962 Check for null account data to prevent the crash, and add a TODO comment saying that
2963 this needs fixing because it is using the server account name instead of the account name.
2965 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2968 * src/maemo/modest-account-settings-dialog.c: (show_error),
2970 Use hildon_note_new_information() for informative and error messages,
2971 which seems to be expected for Maemo applications (no documentation that I know of
2972 says this). I am surprised that there is no distinction between info and error
2975 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2977 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2978 it is easy to find where this is used.
2980 * src/maemo/easysetup/modest-easysetup-wizard.c:
2981 (create_page_welcome), (create_page_account_details),
2982 (create_page_user_details), (create_page_complete_easysetup),
2983 (create_page_custom_incoming), (create_page_custom_outgoing),
2984 (create_page_complete_custom):
2985 * src/maemo/modest-account-settings-dialog.c:
2986 (create_page_account_details), (create_page_user_details),
2987 (create_page_incoming), (create_page_outgoing):
2988 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2989 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2990 (modest_connection_specific_smtp_edit_window_init):
2991 * src/maemo/modest-connection-specific-smtp-window.c:
2992 (modest_connection_specific_smtp_window_init):
2993 * src/maemo/modest-signature-editor-dialog.c:
2994 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2995 and scrolling policy as per the Email Application Layout Guide, if I have
2998 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3000 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3001 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3002 which were empty, because these vfuncs have been removed from TnyAccountStore.
3003 This fixes the build.
3005 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3007 * src/maemo/modest-main-window.c:
3008 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3009 showing/hiding it. Added TODO because it probably should not be NULL.
3010 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3011 because unnecessary g_warnings() make degugging difficult.
3013 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3015 * src/maemo/modest-msg-edit-window.c:
3016 (modest_msg_edit_window_select_color),
3017 (modest_msg_edit_window_select_background_color): 2 const corrections and
3018 moving 2 #endifs before closing brackets, to fix the build.
3020 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3022 * src/maemo/easysetup/modest-easysetup-wizard.h:
3023 * src/maemo/easysetup/modest-easysetup-wizard.c:
3024 (modest_easysetup_wizard_dialog_finalize),
3025 (on_button_edit_advanced_settings), (create_page_complete_custom),
3026 (on_response), (create_account):
3027 Implement the Advanced Settings edit button, by saving the account information,
3028 for the Advanded Settings dialog to use directly from gconf, and removing it
3029 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3030 Bug #5533 in the projects.maemo.org bugzilla.
3032 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3034 * src/maemo/modest-msg-view-window.c:
3035 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3036 when opening a message window.
3038 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3040 * src/maemo/easysetup/modest-easysetup-wizard.c:
3041 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3044 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3045 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3046 gconf settings. I probably added more checks than necessary, but that is safer.
3048 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3049 variable to fix the build, but this seems to be used when it is still NULL.
3051 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3053 * src/modest-platform.h:
3054 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3055 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3056 * src/modest-main.c: Implement this function so we can avoid using
3057 maemo-specific API from cross-platform code.
3059 * src/modest-tny-account-store.c:
3060 (get_smtp_specific_transport_account_for_open_connection):
3061 * src/modest-ui-actions.c: (check_for_connection),
3062 (modest_ui_actions_on_item_not_found):
3063 Use modest_platform_connect_and_wait() and put #idefs around other
3064 maemo-specific code, because only maemo currently has a way to
3065 identify connection names.
3067 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3069 * src/modest-tny-account-store.h:
3070 * src/modest-tny-account-store.c:
3071 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3072 the connection-specific SMTP server settings in the configuration.
3074 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3076 * src/maemo/modest-main-window.c: (on_connection_changed),
3078 * src/modest-main.c: (main), (start_ui), (send_mail):
3079 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3080 that is what is intended.
3082 * src/modest-ui-actions.c: (action_send), (action_receive),
3083 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3084 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3085 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3086 SMTP server is used when it is specified.
3088 (modest_ui_actions_on_send_receive):
3089 Check that a connection is open before proceeding.
3090 Receive and then send, instead of vice-versa, as per the specification.
3092 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3094 * src/modest-mail-operation.c:
3095 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3096 though I guess it should be something other than NULL.
3098 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3100 * src/maemo/easysetup/modest-easysetup-wizard.c:
3101 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3102 combo twice, to avoid an g_warning and to make it visible again.
3103 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3104 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3105 (already intended) dereference when detaching, because we then recreate the menu.
3106 But I am not sure why the warning was happening, and it is possible that this is a memory
3109 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3111 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3112 and uri_parse_mailto() utility functions.
3113 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3115 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3117 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3119 * src/dbus_api/modest-dbus-api.h:
3120 * src/dbus_api/modest-dbus-callbacks.c:
3121 Use an idle callback to execute the modest code in the application's own thread.
3122 Remove the helloworld example method.
3123 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3124 parsed, and the open-message method is not implemented because this is not yet implemented in
3126 * libmodest-dbus-client/libmodest-dbus-client.c:
3127 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3128 (libmodest_dbus_client_open_message):
3129 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3131 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3132 body without crashing.
3134 * tests/dbus_api/Makefile.am:
3135 * tests/dbus_api/test_mail_to.c:
3136 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3138 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3140 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3141 Added file to fix the build. Sorry.
3143 * src/dbus_api/Makefile.am:
3144 * src/dbus_api/modest-dbus-api.h:
3145 * src/dbus_api/modest-dbus-callbacks.h:
3146 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3147 (modest_dbus_req_handler):
3148 Put constants in a separate header so it can be reused by the
3149 client library, without duplication
3151 * libmodest-dbus-client/Makefile.am:
3152 * libmodest-dbus-client/libmodest-dbus-client.c:
3153 (libmodest_dbus_client_call_helloworld),
3154 (libmodfest_dbus_client_send_mail),
3155 (libmodfest_dbus_client_mailto),
3156 (libmodfest_dbus_client_open_message):
3157 * libmodest-dbus-client/libmodest-dbus-client.h:
3158 (Partly) Implement a send_mail D-Bus method.
3160 * tests/dbus_api/Makefile.am:
3161 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3162 the send_email D-Bus method.
3164 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3168 * libmodest-dbus-client/Makefile.am:
3169 * libmodest-dbus-client/libmodest-dbus-client.c:
3170 * libmodest-dbus-client/libmodest-dbus-client.h:
3171 * tests/dbus_api/Makefile.am:
3172 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3173 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3175 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3177 * src/maemo/easysetup/modest-easysetup-wizard.c:
3178 (create_page_account_details):
3179 * src/maemo/modest-account-settings-dialog.c:
3180 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3181 widgets, because this might not be the default in future versions of the Maemo GTK+.
3182 However, I can not not get capitalization to work even in a simple test case.
3184 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3186 * src/maemo/easysetup/modest-easysetup-wizard.c:
3187 (create_page_custom_incoming), (create_page_custom_outgoing):
3188 * src/maemo/modest-account-settings-dialog.c:
3189 (create_page_account_details), (create_page_incoming),
3190 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3191 instead of using gtk_check_button_with_label(), so they are aligned like the other
3192 widgets, as per the UI spec.
3194 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3196 * src/maemo/easysetup/modest-easysetup-wizard.c:
3197 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3198 * src/widgets/modest-validating-entry.c:
3199 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3200 Modest prefix instead of an EasySetup prefix.
3202 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3204 * src/widgets/modest-validating-entry.h:
3205 * src/widgets/modest-validating-entry.c: (on_insert_text),
3206 Added easysetup_validating_entry_set_max_func(), used to set a callback
3207 to call when the max number of characters is reached. GtkEntry has a max-length
3208 already but is silent about it.
3210 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3211 (create_page_account_details), (create_page_user_details),
3213 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3214 (create_page_account_details), (create_page_user_details),
3215 (create_page_outgoing):
3216 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3217 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3218 the UI spec, when the user tries to enter more than the max number of characters.
3220 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3222 * src/maemo/easysetup/modest-easysetup-wizard.c:
3223 (create_page_user_details), (create_page_custom_incoming),
3224 (create_page_custom_outgoing):
3225 * src/maemo/modest-account-settings-dialog.c:
3226 (create_page_user_details), (create_page_incoming),
3227 (create_page_outgoing):
3228 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3229 (modest_connection_specific_smtp_edit_window_init):
3230 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3231 not appropriate. Bad Maemo-specific defaults!.
3233 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3235 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3236 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3237 (modest_signature_editor_dialog_set_settings):
3238 Disable the label and textview when the checkbox is disabled, and use the
3239 specified (UI spec) default signature text.
3241 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3243 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3244 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3246 * src/modest-defs.h:
3247 * src/modest-account-mgr-helpers.h:
3248 * src/modest-account-mgr-helpers.c:
3249 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3251 * src/maemo/Makefile.am:
3252 * src/maemo/modest-signature-editor-dialog.c:
3253 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3256 * src/maemo/modest-account-settings-dialog.h:
3257 * src/maemo/modest-account-settings-dialog.c:
3258 (modest_account_settings_dialog_finalize), (on_button_signature),
3259 (save_configuration): Use the new dialog when the Edit button is pressed, and
3260 save the changes if necessary, as per the UI spec.
3262 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3264 * src/maemo/Makefile.am:
3265 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3266 based on maemo-develoers email from Dirk.
3268 * src/maemo/easysetup/modest-easysetup-wizard.c:
3269 (create_page_welcome), (create_page_account_details),
3270 (create_page_user_details), (create_page_complete_easysetup),
3271 (create_page_custom_incoming), (create_page_custom_outgoing),
3272 (create_page_complete_custom),
3273 (modest_easysetup_wizard_dialog_init):
3274 * src/maemo/modest-account-settings-dialog.c:
3275 (create_page_account_details), (create_page_user_details),
3276 (create_page_incoming), (create_page_outgoing),
3277 (modest_account_settings_dialog_init):
3278 * src/maemo/modest-connection-specific-smtp-window.c:
3279 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3281 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3283 * src/maemo/easysetup/modest-easysetup-wizard.c:
3284 (create_page_account_details), (create_page_custom_outgoing),
3285 (create_page_complete_custom):
3286 * src/maemo/modest-account-settings-dialog.c:
3287 (create_page_user_details), (create_page_incoming),
3288 (create_page_outgoing):
3289 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3290 (modest_connection_specific_smtp_edit_window_init):
3291 Use the correct (UI spec) port min/max, and use horizontal separators,
3294 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3296 * src/maemo/easysetup/modest-easysetup-wizard.c:
3297 (set_default_custom_servernames):
3298 * src/maemo/modest-account-settings-dialog.c:
3299 (create_page_incoming), (on_combo_outgoing_security_changed),
3300 (on_combo_incoming_security_changed), (create_page_outgoing),
3301 (modest_account_settings_dialog_set_account_name),
3302 (save_configuration):
3303 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3304 (on_combo_security_changed),
3305 (modest_connection_specific_smtp_edit_window_init),
3306 (modest_connection_specific_smtp_edit_window_set_connection),
3307 (modest_connection_specific_smtp_edit_window_get_settings):
3308 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3311 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3314 * src/maemo/easysetup/modest-easysetup-wizard.c:
3315 (create_page_custom_outgoing), (create_page_complete_custom):
3316 * src/maemo/modest-account-settings-dialog.c:
3317 (create_page_user_details), (create_page_outgoing):
3318 * src/maemo/modest-account-view-window.c: (button_box_new):
3319 Use changed logical IDs as per the most recent UI spec:
3320 mcen_bd_emailsetup_edit -> mcen_bd_edit
3321 mcen_bd_emailsetup_delete -> mcen_bd_delete
3322 mcen_bd_emailsetup_close -> mcen_bd_close
3324 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3328 * src/dbus_api/Makefile.am:
3329 * src/dbus_api/modest-dbus-callbacks.c:
3330 * src/dbus_api/modest-dbus-callbacks.h:
3331 * src/maemo/modest-platform.c: (modest_platform_init):
3332 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3334 * tests/Makefile.am:
3335 * tests/dbus_api/Makefile.am:
3336 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3338 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3340 * src/maemo/modest-account-settings-dialog.c:
3341 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3342 Removed unnecessary includes.
3344 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3346 * src/maemo/easysetup/modest-easysetup-wizard.c:
3347 * src/maemo/modest-account-settings-dialog.c:
3348 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3349 * src/widgets/Makefile.am:
3350 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3351 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3352 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3353 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3354 * src/widgets/modest-secureauth-combo-box.c:
3355 * src/widgets/modest-secureauth-combo-box.h:
3356 * src/widgets/modest-serversecurity-combo-box.c:
3357 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3358 made the GObject names more consistent with the rest of the Modest code.
3360 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3362 * src/maemo/easysetup/Makefile.am:
3363 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3364 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3365 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3366 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3367 * src/maemo/easysetup/modest-easysetup-wizard.c:
3368 * src/maemo/easysetup/modest-validating-entry.c:
3369 * src/maemo/easysetup/modest-validating-entry.h:
3370 * src/maemo/modest-account-settings-dialog.c:
3371 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3372 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3373 widgets/ because they are used outside of easysetup too. After checking in,
3374 svn will allow me to rename them too.
3376 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3378 * src/gnome/modest-msg-edit-window.c:
3379 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3380 linker error, to fix the build on the GNOME platform.
3381 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3382 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3383 ifdefed out to avoid a warning.
3385 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3387 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3388 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3389 some alternative for GTK+ 2.6.
3391 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3393 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3395 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3396 specified for EmailAccountsDialog in UI spec.
3398 * src/maemo/easysetup/modest-easysetup-wizard.c:
3399 * src/maemo/easysetup/modest-easysetup-wizard.h:
3400 * src/maemo/modest-account-settings-dialog.c:
3401 * src/maemo/modest-account-settings-dialog.h:
3402 Reuse a member window widget for the connection-specific SMTP server accounts,
3403 so we can tell it to create/save the accounts only if we actually save changes.
3405 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3406 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3407 (modest_connection_specific_smtp_edit_window_get_settings):
3408 Return a struct instance for temporarily remembering the entered data.
3410 * src/maemo/modest-connection-specific-smtp-window.h:
3411 * src/maemo/modest-connection-specific-smtp-window.c:
3412 (modest_connection_specific_smtp_window_finalize),
3413 (modest_connection_specific_smtp_window_fill_with_connections),
3415 (modest_connection_specific_smtp_window_save_server_accounts),
3416 (update_model_server_names): Do not actually save data until asked,
3417 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3419 (on_selection_changed),
3420 (modest_connection_specific_smtp_window_init): Disable the edit
3421 button when nothing is selected.
3423 * src/modest-account-mgr-helpers.c:
3424 * src/modest-account-mgr-helpers.h:
3425 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3428 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3430 * src/modest-account-mgr-helpers.h:
3431 * src/modest-account-mgr-helpers.c:
3432 (modest_account_mgr_get_unused_account_name),
3433 (modest_account_mgr_get_unused_account_display_name): Added these
3434 utility functions, to avoid code duplication.
3436 * src/maemo/easysetup/modest-easysetup-wizard.c:
3437 (create_page_account_details), (create_account):
3438 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3439 (on_combo_security_changed),
3440 (modest_connection_specific_smtp_edit_window_init),
3441 (modest_connection_specific_smtp_edit_window_save_settings):
3442 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3443 * src/maemo/modest-connection-specific-smtp-window.c:
3444 (modest_connection_specific_smtp_window_finalize),
3445 (modest_connection_specific_smtp_window_fill_with_connections),
3446 (on_button_edit), (modest_connection_specific_smtp_window_init):
3447 * src/maemo/modest-connection-specific-smtp-window.h:
3448 Implementing saving of connection-specific server accounts.
3450 But I need to refactor this so we can save the data for each
3451 possible connection-specific account and only actually create the server accounts
3452 when the easysetup finished, or the OK button is pressed on the account settings
3455 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3457 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3458 (on_combo_security_changed):
3459 (modest_connection_specific_smtp_edit_window_init):
3460 Auto-fill the port number as in the account settings.
3462 (modest_connection_specific_smtp_edit_window_set_connection):
3463 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3464 * src/maemo/modest-connection-specific-smtp-window.c:
3465 (fill_with_connections), (on_button_edit),
3466 (modest_connection_specific_smtp_window_init):
3467 Turn the edit window into a dialog to simplify the code, and
3468 set a WM hint as in a GtkDialog, because only a popup can be on top of
3469 another window in Maemo, and popups usually have no WM decoration.
3471 * src/modest-defs.h:
3472 * src/modest-account-mgr-helpers.c:
3473 (modest_account_mgr_set_connection_specific_smtp),
3474 (modest_account_mgr_remove_connection_specific_smtp),
3475 (modest_account_mgr_get_connection_specific_smtp):
3476 * src/modest-account-mgr-helpers.h: Some functions to write the
3477 connection-specific SMTP server information. Not yet used.
3480 * src/widgets/modest-folder-view.c: (text_cell_data):
3481 Fix a warning about an uninitialized variable.
3482 (on_configuration_key_changed): Put an #ifdef around the use
3483 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3485 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3487 * src/maemo/modest-account-settings-dialog.h:
3488 * src/maemo/modest-account-settings-dialog.c:
3489 Added connect_for_modified() utility function to mark the new modified boolean.
3491 (create_page_account_details), (create_page_user_details),
3492 (create_page_incoming), (create_page_outgoing), (on_response),
3493 (modest_account_settings_dialog_init),
3494 (modest_account_settings_dialog_set_account_name):
3495 Only warn about unsaved changes when there are actually unsaved changes.
3497 * src/modest-account-mgr-helpers.c:
3498 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3499 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3500 to get the data from there in future.
3502 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3504 * src/modest-defs.h:
3506 * src/modest-account-mgr-helpers.h:
3507 * src/modest-account-mgr-helpers.c:
3508 Store the security account setting in a single conf key instead of using
3509 the options list, so that the list is left for just the to-be-removed camel hack,
3510 and because gconf_client_set_list() is failing for some reason.
3512 * src/modest-account-mgr.c:
3513 (modest_account_mgr_add_server_account):
3514 * src/maemo/modest-account-settings-dialog.c:
3515 (modest_account_settings_dialog_set_account_name),
3516 (save_configuration): Use the renamed functions.
3519 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3521 * src/widgets/Makefile.am:
3522 * src/widgets/modest-limit-retrieve-combo-box.c:
3523 * src/widgets/modest-limit-retrieve-combo-box.h:
3524 * src/widgets/modest-retrieve-combo-box.c:
3525 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3526 the account settings dialog.
3528 * src/modest-defs.h:
3529 * src/modest-account-mgr-helpers.h:
3530 * src/modest-account-mgr-helpers.c:
3531 (modest_server_account_get_option_secure_auth),
3532 (modest_server_account_set_option_secure_auth):
3533 * src/modest-account-mgr.c:
3534 (modest_account_mgr_add_server_account):
3535 Use the existing AUTH_MECH conf key for the secure-auth setting,
3536 instead of putting it in the list options, because this was actually used already.
3538 * src/maemo/modest-account-settings-dialog.c:
3539 (create_page_account_details),
3540 (modest_account_settings_dialog_set_account_name),
3541 (save_configuration):
3542 * src/maemo/modest-account-settings-dialog.h:
3543 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3544 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3546 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3548 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3549 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3550 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3552 * src/modest-defs.h:
3553 * src/maemo/modest-account-settings-dialog.c:
3554 (create_page_incoming), (on_combo_outgoing_security_changed),
3555 (on_combo_incoming_security_changed), (create_page_outgoing),
3556 (modest_account_settings_dialog_set_account_name),
3557 (save_configuration): Load/Save the port number, and change it when the
3558 security combo changes, to suitable defaults.
3560 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3562 * src/modest-account-mgr.c:
3563 (modest_account_mgr_add_server_account): Set the security and secure-auth
3564 options, and add a comment saying that the other camel-specific options should be
3567 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3569 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3571 * src/modest-tny-account-store.c: (account_list_free),
3572 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3573 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3576 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3578 * src/modest-protocol-info.c:
3579 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3580 is required by our UI spec. Maybe something in our implementation will use this eventually.
3581 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3582 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3583 instead of the previous 0 placeholder.
3585 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3586 secure-auth settings.
3587 * src/modest-account-mgr-helpers.h:
3588 * src/modest-account-mgr-helpers.c:
3589 (modest_server_account_data_get_option_secure_auth),
3590 (modest_server_account_set_option_secure_auth),
3591 (modest_server_account_data_get_option_security),
3592 (modest_server_account_set_option_security): Added this API for getting and setting the security
3593 and secure-auth settings.
3595 * src/maemo/modest-account-settings-dialog.h:
3596 * src/maemo/modest-account-settings-dialog.c:
3597 (modest_account_settings_dialog_finalize), (check_data),
3598 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3599 about changing titles.
3600 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3601 (save_configuration): Save the security and secure-auth settings.
3603 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3604 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3606 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3608 * src/modest-defs.h:
3609 * src/modest-account-mgr.c:
3610 (modest_account_mgr_add_server_account):
3611 Added and used defines for the options key and value pair strings,
3612 that are used so far, though they do not seem to correspond to anything in our
3613 UI specs or ModestProtocol enum.
3615 * src/modest-account-mgr-helpers.h:
3616 * src/modest-account-mgr-helpers.c:
3617 (compare_option_strings_for_name),
3618 (modest_server_account_data_get_option_value),
3619 (modest_server_account_data_get_option_bool),
3620 (modest_account_mgr_get_server_account_option):
3621 Added helper functions for parsing the options GSList.
3623 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3625 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3626 display name is based on the supplied account name.
3627 * src/modest-account-mgr.c:
3628 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3629 with an inefficient, but good-enough, implementation.
3631 * src/maemo/easysetup/modest-easysetup-wizard.c:
3632 (create_page_account_details), (on_before_next), (create_account):
3633 Check for existing display names rather than (non-user-visible) account names, and just
3634 create and set a unique account name at the end.
3636 * src/maemo/modest-account-settings-dialog.c:
3637 (modest_account_settings_dialog_init),
3638 (modest_account_settings_dialog_set_account_name),
3639 (create_page_incoming): Show the display name, instead of the account name.
3640 (on_response): Do some (not all) extra checks, as in the UI spec.
3641 (save_configuration): Save the display name if it was changed.
3643 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3645 * po/en_GB.po: Added needed logical ID and translation.
3646 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3647 (init_view): Made the is-default column clicking work.
3649 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3652 * src/maemo/easysetup/Makefile.am:
3653 * src/maemo/easysetup/modest-easysetup-wizard.c:
3654 (modest_easysetup_wizard_dialog_init):
3655 * src/maemo/easysetup/provider-data-test.keyfile:
3656 * src/maemo/easysetup/provider-data.keyfile:
3657 Moved the provider data file to the new modest-providers-data package and used it from there.
3659 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3661 * src/modest-local-folder-info.c:
3662 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3663 N_() was already used on the static strings, but this just marks it for translation without
3664 using the translation.
3666 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3668 * src/maemo/modest-account-settings-dialog.c:
3669 (create_page_incoming),
3670 (modest_account_settings_dialog_set_account_name):
3671 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3672 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3673 I will do this if nobody else gets there first.
3675 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3677 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3678 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3679 save the security stuff.
3681 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3683 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3684 Set the email address and user fullname, which I now see must be
3687 * src/maemo/modest-account-settings-dialog.h:
3688 * src/maemo/modest-account-settings-dialog.c:
3690 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3691 leave-on-server and authentication.
3692 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3695 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3698 * src/maemo/modest-account-settings-dialog.c:
3699 * src/maemo/modest-account-settings-dialog.h:
3700 Most (but not all) of the widgets are now present as specified by the UI spec.
3701 No changes are yet saved, and some details are not properly shown yet.
3703 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3705 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3707 * src/maemo/Makefile.am:
3708 * src/maemo/modest-account-settings-dialog.c:
3709 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3710 an existing account. Doesn't do much yet.
3712 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3713 Open the accounts settings dialog when Edit is clicked.
3715 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3717 * src/maemo/easysetup/Makefile.am:
3718 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3720 * src/maemo/easysetup/modest-easysetup-wizard.c:
3721 (modest_easysetup_wizard_dialog_init):
3722 Try to get the source directory from the build system,
3723 instead of hard-coding "./" into the source code, when opening our local
3724 copies of the configuration files.
3725 But this still fails when opening the wizard from the Accounts window,
3726 maybe because the working directory seems to change at runtime.
3727 So the wizard will fail the second time unless you copy the files into their
3728 proper locations - see the stdout warnings for the paths.
3730 (create_page_account_details),(on_before_next):
3731 Check for existing non-server accounts instead of server accounts,
3732 so the default account name is useful again, and to prevent trying to
3735 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3736 Show the wizard when New is clicked.
3738 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3739 (init_view): Show the column headers, and show the columns that are
3740 specified in the UI specs. However, something in Maemo's GTK+ prevents
3741 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3742 change the default account. This is despite unsetting the special properties.
3744 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3746 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3747 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3748 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3749 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3750 to make that clearer.
3751 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3753 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3755 * src/maemo/modest-account-view-window.c:
3756 (modest_account_view_window_init),
3757 (modest_account_view_window_new):
3758 Use the same buttons as specified in the
3759 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3760 the existing widgets, which never had a chance of working.
3761 Put the ModestAccountView treeview in a scrolled window.
3762 Do not repeat the initialization in both _init() and _new().
3764 * src/widgets/modest-account-view.c: (update_account_view):
3765 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3766 this widget and window shows no accounts.
3768 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3770 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3772 * src/maemo/easysetup/modest-easysetup-wizard.c:
3773 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3774 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3775 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3778 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3779 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3780 accounts exist yet, as in the UI spec.
3782 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3784 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3786 * src/maemo/Makefile.am:
3787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3788 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3789 New window for editing connection-specific smtp details.
3790 Not fully implemented.
3792 * src/maemo/modest-connection-specific-smtp-window.c:
3793 (modest_connection_specific_smtp_window_finalize) :
3794 unref the tree model.
3795 (on_button_edit): Show the edit window.
3797 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3799 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3802 * src/maemo/Makefile.am:
3803 * src/maemo/modest-connection-specific-smtp-window.c:
3804 * src/maemo/modest-connection-specific-smtp-window.h:
3805 New window for showing the list of connections, for connection-specific
3806 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3807 * src/maemo/easysetup/modest-easysetup-wizard.c:
3808 (create_page_custom_outgoing): Show the new window when the button is clicked.
3810 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3812 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3813 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3814 * src/maemo/modest-msg-edit-window.c:
3815 (modest_msg_edit_window_insert_image):
3816 * src/modest-conf.c: (modest_conf_key_escape):
3817 * src/modest-mail-operation.c:
3818 (modest_mail_operation_send_new_mail):
3819 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3820 (modest_ui_actions_on_new_account):
3821 * src/widgets/modest-attachment-view.c: (update_filename_request):
3822 * src/widgets/modest-mail-header-view.c:
3823 Corrected warnings that were breaking the build, by commenting out unused variables,
3824 and a function, and by including a header.
3826 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3828 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3829 so we can #ifdef around platform-specific code when necessary.
3830 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3831 to allow this to build for the GNOME platform too.
3833 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3835 * src/maemo/easysetup/modest-easysetup-wizard.c:
3836 Added util_increment_name() and used it in create_page_account_details()
3837 to make sure that the default account name is always a new name.
3839 (modest_easysetup_wizard_dialog_init),
3840 (set_default_custom_servernames): Some minor memory management fixes.
3842 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3846 * src/modest-runtime.c: (init_i18n): Restored the translation
3847 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3848 are defined in config.h, and the translations are installed.
3850 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3851 is defined for translation.
3853 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3855 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3857 * src/maemo/easysetup/modest-easysetup-wizard.c:
3858 (modest_easysetup_wizard_dialog_init):
3859 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3860 Use realistic paths (though they should use $prefix generically) to the
3861 mcc_mapping and provider-data.keyfile files which might work when they
3862 are installed by the future version of the operator-wizard package,
3863 and then fallback to paths in our source code, with an explanatory
3866 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3870 * src/maemo/Makefile.am:
3871 * src/maemo/easysetup/: Added files from the previously-exernal
3872 osso-modest-easysetup.
3873 * src/maemo/modest-main-window-ui.h:
3874 * src/modest-ui-actions.c:
3875 * src/modest-ui-actions.h:
3876 Added modest_ui_actions_on_new_account() as a signal handler for the
3877 New Account menu item. It shows the easysetup wizard.
3878 * po/en_GB.po: Added additional needed logical IDs and translations.