1 2007-08-16 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c:
4 (get_entered_account_title), (on_before_next), (entry_is_empty),
6 * src/maemo/modest-account-settings-dialog.c:
7 (get_entered_account_title), (on_button_signature), (check_data),
8 (save_configuration), (entry_is_empty):
9 Strip the account title of whitespace at the start and end before
10 using it or checking it. This means that an all-whitespace title
11 is not allowed, fixing projects.maemo.org bug NB#64977.
13 2007-08-15 Murray Cumming <murrayc@murrayc.com>
15 * src/modest-ui-actions.h:
16 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
17 to modest_run_account_setup_wizard() and made it public.
18 * src/dbus_api/modest-dbus-callbacks.c:
19 (check_and_offer_account_creation), (on_idle_mail_to),
20 (on_idle_compose_mail), (on_idle_open_default_inbox):
21 Offer account creation if necessary, fixing projects.maemo.org
24 2007-08-15 Murray Cumming <murrayc@murrayc.com>
26 * src/modest-ui-actions.c: (run_account_setup_wizard):
27 Return a gboolean to indicate success.
28 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
29 (modest_ui_actions_on_send): When offering account creation, only
30 give up (return) if account creation failed. Otherwise continue
31 with the original request. This fixed projects.maemo.org bug
34 2007-08-15 Murray Cumming <murrayc@murrayc.com>
36 * src/widgets/modest-recpt-editor.c:
37 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
38 to fix projects.maemo.org bug NB#63789.
40 2007-08-15 Murray Cumming <murrayc@murrayc.com>
42 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
43 (modest_tny_account_store_new): Properly detect the memory card at
44 startup, and add an account for it.
46 2007-08-14 Murray Cumming <murrayc@murrayc.com>
48 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
49 Commented out the MMC code again because it mistakenly detects
50 the card even when it isn't inserted.
52 2007-08-14 Murray Cumming <murrayc@murrayc.com>
54 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
55 Renabled the call to add_mmc_account() because I do not believe
56 it could be the cause of the mentioned hang (in scratchbox, where
57 there is no memory card), and because I have tested that it works
60 2007-08-14 Murray Cumming <murrayc@murrayc.com>
62 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
63 Comment out part of the last commit because it apparently causes
66 2007-08-14 Murray Cumming <murrayc@murrayc.com>
68 * src/modest-tny-account-store.c: Added the add_mmc_account()
69 function to save some copy/pasting.
70 (modest_tny_account_store_new): If the memory card is mounted,
71 create an account for it at the start, instead of waiting for the
72 user to unmount it and mount it.
74 2007-08-13 Murray Cumming <murrayc@murrayc.com>
76 * src/widgets/modest-account-view.c: (on_account_changed):
77 Do not try to use the human-readable TnyAccount name instead of the
78 ID of the modest account to get the transport account. And unref
79 the transport account. This prevents a g_warning(), and a possible
82 2007-08-13 Murray Cumming <murrayc@murrayc.com>
84 * src/maemo/modest-platform.c:
85 (modest_platform_set_update_interval): Handle the new
86 alarmd error to warn when alarmd is not running, as is the case in
87 scratchbox for me now because
88 "Module /usr/lib/alarmd/libretu.so initialization failed"
90 2007-08-13 Murray Cumming <murrayc@murrayc.com>
92 * src/widgets/modest-header-view-render.c:
93 (_modest_header_view_compact_header_cell_data):
94 NULL some strings after freeing them, trying to deal with
95 the double deletion found in projects.maemo.org bug 64183,
96 probably having no effect.
98 2007-08-13 Murray Cumming <murrayc@murrayc.com>
100 * src/maemo/modest-account-settings-dialog.c:
101 (create_page_incoming), (create_page_outgoing): Use a define
102 for the min and max port numbers.
104 (check_hildon_number_editor_and_warn_value_not_in_range),
105 (check_data): Do an extra check for an invalid port number, as needed
106 in projects.maemo.org bug #64275, when the number is cleared, but this
107 does not work due to bugs.maemo.org bug #1806.
109 2007-08-13 Murray Cumming <murrayc@murrayc.com>
111 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
112 Comment out the debug warning about the unexpected D-Bus methods.
113 They are just annoying now.
114 * src/maemo/modest-platform.c:
115 (modest_platform_set_update_interval): Correct the D-Bus path, instead
116 of using a file path, though it did not seem to break things before.
117 It might be needed now:
118 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
119 modest is not already running. This is the behaviour of the old client, and
120 Mox says it is what we should do for modest.
121 This closes projects.maemo.org bug NB#64327.
123 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
125 * src/modest-text-utils.c:
126 Fixed invalid jump due to incorrect string/pointer
128 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
131 2007-08-01 Murray Cumming <murrayc@murrayc.com>
133 * src/modest-account-mgr-helpers.h:
134 * src/modest-account-mgr-helpers.c:
135 Added modest_account_mgr_get_first_account_name(),
136 using code from modest_account_mgr_set_first_account_as_default().
138 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
139 (account_number_changed): Call set_at_least_one_account_visible() so that
140 the first account is visible when first added, without the user having to
142 I do wonder how this worked before.
144 2007-08-01 Murray Cumming <murrayc@murrayc.com>
146 * src/modest-tny-account-store.c: (show_password_warning_only),
147 (show_wrong_password), (request_password_and_wait), (get_password),
148 (modest_tny_account_store_alert): Remove the (incomplete anyway)
149 attempts to show UI only in the main context, which used g_idle_add()
150 and mainloops, because tinymail now guarantees that it only calls these
151 callbacks in the mainloop with the gdk lock. This makes everything much
154 2007-08-01 Murray Cumming <murrayc@murrayc.com>
156 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
157 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
158 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
159 error dialog, instead of ignoring it.
161 2007-08-01 Murray Cumming <murrayc@murrayc.com>
163 * src/maemo/modest-msg-view-window.c:
164 (modest_msg_view_window_get_header),
165 (modest_msg_view_window_last_message_selected):
166 Added comments to explain the use of priv->header_model.
167 * src/modest-ui-dimming-rules.c:
168 (modest_ui_dimming_rules_on_open_msg),
169 (modest_ui_dimming_rules_on_mark_as_read_msg),
170 (modest_ui_dimming_rules_on_mark_as_unread_msg),
171 (modest_ui_dimming_rules_on_remove_attachments),
172 (_invalid_attach_selected), (_selected_msg_marked_as):
173 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
174 and changed the parameter to a ModestMainWindow to make it clearer that
175 it never uses any other kind of window.
176 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
177 instead of the selected message.
178 I notice that much of the dimming code and the ModestMsgViewWindow code
179 hard-codes the assumption that the viewed message is always selected in
180 the header view. This does not seem wise or simple.
182 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
183 examine the actual message instead of whatever might be selected
184 in the header view. This stops the delete toolbar button and menu item
185 from being dimmed when opening a message view the search UI,
186 partially fixing projects.maemo.org bug NB#63811.
188 However, when actually deleting, I now get this warning:
189 "tny_header_set_flags: This is a header instance for a new message.
190 Only priority and attachment flags are supported"
192 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
194 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
196 Show account wizard if no accounts are defined while sending
197 (automatic sending after the account wizard finished does not
198 work because it takes some time until the account manager
199 synchronizes everything. (projects.maemo.org NB#62792)
201 2007-07-30 Murray Cumming <murrayc@murrayc.com>
203 * src/modest-tny-account-store.c: (on_account_removed),
204 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
205 account is removed from the View menu. We have TnyAccountStore
206 and ModestTnyAccountStore signals that seem very similar, but this
207 seems to work for now.
209 * src/maemo/modest-main-window.c:
210 (on_show_account_action_activated): Prevent dereference
211 of a NULL if the accoutn does not really exist, though that
212 should not happen anymore.
214 This fixes projects.maemo.org bug NB#64606.
216 2007-07-30 Murray Cumming <murrayc@murrayc.com>
218 * src/modest-ui-actions.c: (run_account_setup_wizard),
219 (modest_ui_actions_on_accounts): Revert a change that set these
220 to modal dialogs, freezing the UI when they show secondary dialogs.
221 This fixed projects.maemo.org bug NB#64519.
223 2007-07-27 Murray Cumming <murrayc@murrayc.com>
225 * src/widgets/modest-header-view-render.c:
226 (_modest_header_view_compact_header_cell_data):
227 Some checks and initialization to try to deal with a crash,
228 probably ineffective.
230 2007-07-27 Murray Cumming <murrayc@murrayc.com>
232 * src/maemo/modest-maemo-utils.c:
233 (modest_maemo_utils_get_supported_secure_authentication_methods):
234 Make sure that we have a connection, asking the user for one
236 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
237 Check for a connection before showing the wizard, because
238 the wizard needs a connection to check for server capabilities.
240 2007-07-27 Murray Cumming <murrayc@murrayc.com>
242 * src/maemo/modest-account-view-window.c:
243 (on_new_button_clicked): Remember the wizard dialog instance,
244 so we can just present it again if necessary. This prevents
245 multiple windows from appearing if you click again quickly on the
246 New button before the dialog appears, fixing projects.maemo.org
249 2007-07-27 Murray Cumming <murrayc@murrayc.com>
251 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
252 Offer a connection dialog if there is no connection when
253 starting modest. This should fix projects.maemo.org bug NB#61134.
255 2007-07-27 Murray Cumming <murrayc@murrayc.com>
257 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
258 Reverted my last commit. I was able to fix the build by doing
259 apt-get install wpeditor0 (replacing other wpeditor packages) and
260 an explicit apt-get install wpeditor-dev to upgrade the -dev
263 2007-07-27 Murray Cumming <murrayc@murrayc.com>
265 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
266 Commented out the use of wp_text_buffer_replace_image()
267 because it does not exist, to break the build. Added a TODO for it.
269 2007-07-26 Murray Cumming <murrayc@murrayc.com>
271 * src/modest-tny-account-store.c: (recreate_all_accounts):
272 Recreate them even if they were NULL before. I guess something
273 else was already creating them before, or this would never
275 (modest_tny_account_store_get_server_account): Make sure that
276 the tny accounts have been created before trying to find one.
277 This allows libmodest_dbus_client_compose_mail() to work
278 when the UI is not yet visible.
279 This is probably useful in other cases too.
281 (get_password): When the password is wrong after it is entered
282 in the protected password dialog, show an info banner (in an
283 idle handler) before showing the protected password dialog
286 2007-07-26 Murray Cumming <murrayc@murrayc.com>
288 * src/modest-ui-actions.h:
289 * src/modest-ui-actions.c: Added
290 modest_do_refresh_current_folder() containing some code from
291 modest_ui_actions_on_send_receive().
292 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
293 Call modest_do_refresh_current_folder() before refreshing the
294 requested account, as in modest_ui_actions_on_send_receive().
295 This is strange, but seems to be necessary to show new mails.
296 Now new emails are finally visible in the UI when downloaded
297 via the automatic update interval, fixing bug NB#57458.
298 This also works because bug NB#57458 has been fixed somehow.
300 2007-07-26 Murray Cumming <murrayc@murrayc.com>
302 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
303 printf more details when we get unhandled D-Bus methods, because
306 * src/modest-mail-operation.c: (update_account_thread):
307 Comment out the tny_camel_pop_store_account_reconnect(), because this
308 is apparently no longer needed, and it did not work before anyway.
309 See the comment in the code.
311 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
312 by checking the header flags. This fixes projects.maemo.org bug
315 2007-07-25 Murray Cumming <murrayc@murrayc.com>
317 * src/maemo/modest-maemo-utils.h:
318 * src/maemo/modest-maemo-utils.c: Added
319 modest_maemo_show_information_note_in_main_context_and_forget().
320 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
321 Use the new function to show simple error dialogs in the main
322 context, though question dialogs are still in the current context,
323 which is unfortunately usually not the main context. This should
326 2007-07-25 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-tny-account-store.c: (get_password):
329 Never save the entered username and password in gconf,
330 because the UI spec says we should not. This helps
331 slightly with projects.maemo.org bug NB#63671.
333 2007-07-25 Murray Cumming <murrayc@murrayc.com>
335 * src/widgets/modest-msg-edit-window.h:
336 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
337 Moved some code here to make it simpler.
338 (modest_msg_edit_window_attach_file_one): Renamed from
339 modest_msg_edit_window_attach_file_interactive().
340 (modest_msg_edit_window_offer_attach_file): Renamed from
341 modest_msg_edit_window_attach_file() and used
342 modest_msg_edit_window_attach_file_one() instead of
343 copy/pasting the code. The old code for one was not using
344 GnomeVFS. This allows use of smb:// URLs when using send-as
345 from external applications, fixing bug NB#63741.
347 (modest_msg_edit_window_insert_image),
348 (modest_msg_edit_window_add_attachment_clicked):
349 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
350 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
351 Adapted to the new function names.
353 2007-07-25 Murray Cumming <murrayc@murrayc.com>
355 (modest_platform_set_update_interval): Set the alarm recurrence
356 fields so that auto-update does not just happen the first time.
357 This should have fixed projects.maemo.org bug NB#63938.
359 When this happens you can see a printf when the D-Bus method is
361 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
363 However, I do not actually seem to get new POP messages even when
364 clicking the refresh button manually. A restart gets them.
365 This might be a problem in today's tinymail only.
367 2007-07-24 Murray Cumming <murrayc@murrayc.com>
369 * src/maemo/modest-maemo-global-settings-dialog.c:
370 (current_connection):
371 Avoid a crash (probably only in scratchbox) when strcmp()ing a
372 NULL when closing the dialog.
374 2007-07-24 Murray Cumming <murrayc@murrayc.com>
376 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
377 Remove the hacky send/receive that didn't work, and instead
378 refilter the treemodel to make the deleted email really vanish from
379 the UI (though the delete-from-menu code does has commented out
380 the code that does that). This fixes projects.maemo.org bug
383 2007-07-24 Murray Cumming <murrayc@murrayc.com>
385 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
386 Try a couple of tricks to force the treeview to update (
387 poke the folder, and do a send/receive refresh), but the deleted
388 email still appears with a strike-through instead of really being
391 2007-07-23 Murray Cumming <murrayc@murrayc.com>
393 * src/dbus_api/modest-dbus-callbacks.c:
394 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
395 because their ID is not human-readable (see the comment about
396 improvements needed to the osso-email-interface API) and
397 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
399 2007-07-23 Murray Cumming <murrayc@murrayc.com>
401 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
402 (add_folders_to_list), (on_dbus_method_get_folders),
403 (modest_dbus_req_filter):
404 * src/maemo/modest-maemo-utils.c:
405 (on_camel_account_get_supported_secure_authentication):
406 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
407 (on_header_view_focus_in):
408 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
409 * src/modest-formatter.c: (modest_formatter_create_body_part):
410 * src/modest-mail-operation.c: (recurse_folders),
411 (update_account_thread), (get_msgs_full_thread),
412 (modest_mail_operation_get_msgs_full),
413 (modest_mail_operation_xfer_msgs):
414 * src/modest-search.c: (search_mime_part_and_child_parts),
415 (modest_search_account), (modest_search_all_accounts):
416 * src/modest-tny-account.c:
417 (modest_tny_account_get_special_folder), (recurse_folders):
418 * src/modest-tny-local-folders-account.c:
419 (modest_tny_local_folders_account_query_passes):
420 * src/modest-tny-msg.c: (copy_mime_part),
421 (modest_tny_msg_find_body_part_from_mime_part):
422 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
423 (modest_tny_send_queue_try_to_send):
424 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
425 (_modest_ui_actions_open), (download_uncached_messages),
426 (reply_forward), (modest_ui_actions_on_copy),
427 (modest_ui_actions_on_details), (has_retrieved_msgs),
428 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
430 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
431 (_selected_msg_marked_as), (_msg_download_completed),
432 (_selected_msg_sent_in_progress):
433 * src/widgets/modest-attachments-view.c:
434 (modest_attachments_view_set_message):
435 * src/widgets/modest-msg-view.c: (find_cid_image):
436 * tests/check_folder-transfer.c: (find_folders):
437 * tests/check_update-account.c: (func):
438 * tests/dbus_api/test_get_folders.c: (main):
439 Checked all uses of tny_iterator_get_current(), making sure
440 that the object is unreferenced (3 or 4 places did not),
441 and adding checks for NULL.
443 2007-07-23 Murray Cumming <murrayc@murrayc.com>
445 * src/dbus_api/modest-dbus-callbacks.c:
446 (on_idle_open_default_inbox): Make sure that the application UI is
448 * src/maemo/easysetup/modest-easysetup-wizard.c:
449 (on_entry_invalid_character): Show the word whitespace instead
450 of (null) in the banner when whitespace was entered.
451 (show_error): Add a comment that this does not work in
452 Maemo Bora, though we do not know why.
454 2007-07-23 Murray Cumming <murrayc@murrayc.com>
456 * src/modest-tny-account.c:
457 (modest_tny_account_get_special_folder): Use an if instead of
458 an assert for when the parent account name is NULL, because this
459 might be causing a crash in projects.maemo.org bug 63192.
460 * src/modest-mail-operation.c:
461 (modest_mail_operation_send_new_mail_cb),
462 (modest_mail_operation_remove_folder): unref the folder that is
463 returned from modest_tny_account_get_special_folder().
465 2007-07-23 Murray Cumming <murrayc@murrayc.com>
467 * src/modest-ui-actions.c:
468 (modest_ui_actions_on_password_requested):
469 Show mail_ib_login_cancelled info banner when the user cancels
470 the protected password dialog, to fix projects.maemo.org
473 2007-07-23 Murray Cumming <murrayc@murrayc.com>
475 * src/maemo/modest-account-settings-dialog.c:
476 (create_page_outgoing): Put this page in a GtkScrolledWindow,
477 matching the UI mock-up in the UI spec, and allowing access
478 to all widgets even when the on-screen keyboard is active.
480 2007-07-23 Murray Cumming <murrayc@murrayc.com>
482 Reverted this previous commit from Johannes,
483 because the scrollbars are always visible and because
484 I think we only need it on onepage of the account
485 settings, not the account wizard.
486 (I wrote the wrong instructions in the bug.)
488 * src/maemo/easysetup/modest-easysetup-wizard.c:
489 Added scrollbars to account wizard dialog.
490 Fixed projects.maemo.org NB #62744
492 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
494 * src/maemo/easysetup/modest-easysetup-wizard.c:
495 (create_page_user_details):
496 Use auto-cap for name (projects.maemo.org NB#63716)
497 * src/widgets/modest-account-view.c: (on_account_busy_changed):
499 2007-07-22 Armin Burgmeier <armin@openismus.com>
501 * src/maemo/modest-ui-actions.c: Use current account instead of
502 default account for creating viewer windows, so that the viewer
503 window knows to which account the viewed message belongs.
505 * src/maemo/modest-msg-view-window.c: Destroy the window when the
506 corresponding account is deleted. This fixes projects.maemo.org bug
509 2007-07-18 Armin Burgmeier <armin@openismus.com>
511 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
512 the dialog close after entering an invalid port number and clicking
513 OK. This fixes projects.maemo.org bug NB#63602.
515 2007-07-18 Armin Burgmeier <armin@openismus.com>
517 * src/modest-tny-account-store.c:
518 (get_server_accounts): Set parent modest account name for each
519 connection-specific transport account so that special folders of such
520 an account can be looked up. This fixes a crash when changing account
521 settings. This might also be related to projects.maemo.org bug
524 2007-07-16 Armin Burgmeier <armin@openismus.com>
526 * src/modest-ui-actions.c: Added a button to create a folder to the
527 move-to dialog. This fixes projects.maemo.org bug NB#.
529 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
531 * src/maemo/easysetup/modest-easysetup-wizard.c:
532 Added scrollbars to account wizard dialog.
533 Fixed projects.maemo.org NB #62744
535 2007-07-16 Murray Cumming <murrayc@murrayc.com>
537 * src/widgets/modest-msg-view.h:
538 * src/widgets/modest-msg-view.c:
539 Added modest_msg_view_get_message_is_empty() but this needs
541 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
542 Check if there is any text in the message yet.
543 But this needs to be implemented properly.
544 (modest_msg_edit_window_toggle_find_toolbar):
545 * src/maemo/modest-msg-view-window.c:
546 (modest_msg_view_window_toggle_find_toolbar):
547 Show a banner warning if there is no text to search, when
548 trying to start a search. This partially fixes
549 projects.maemo.org bug NB#62350.
551 2007-07-13 Murray Cumming <murrayc@murrayc.com>
553 * src/modest-mail-operation.c: (update_account_thread):
554 Initialized num_new_headers to fix the build.
556 2007-07-13 Murray Cumming <murrayc@murrayc.com>
558 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
559 Ignore modest accounts whose server accounts don't exist in gconf.
560 This prevents us trying to create TnyAccount instances for those
561 server accounts when the server account has been removed from gconf,
562 but the parent modest account has not yet been removed from modest.
563 I don't know why this is only noticeable now. It was probably just
564 a harmeless g_warning() anyway.
566 2007-07-13 Murray Cumming <murrayc@murrayc.com>
568 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
569 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
571 2007-07-12 Armin Burgmeier <armin@openismus.com>
573 * src/maemo/modest-main-window.c: Make default account appear bold
574 in view, tools/send & receive and toolbar/send & receive SCM menus.
575 This fixes projects.maemo.org bug NB#59010.
577 2007-07-12 Murray Cumming <murrayc@murrayc.com>
579 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
580 Add a short-cut, by checking if the folder store is an account.
581 This ensures that the Sort menu item and toolbar is dimmed for
582 the local-folders account root item, fixing
583 projects.maemo.org bug NB#62545.
585 2007-07-12 Murray Cumming <murrayc@murrayc.com>
587 * src/modest-tny-account-store.c: (get_password):
588 Show the password dialog (via the signal) only in the mainloop, via
589 an idle handler that we wait for. This could theoretically prevent
590 hangs, though I worry that it could introduce some too.
592 2007-07-12 Murray Cumming <murrayc@murrayc.com>
594 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
595 * src/maemo/modest-platform.c:
596 (modest_platform_connect_and_wait):
597 Take a TnyAccount* parameter and try to set it to online
598 (a TnyCamel-only API), because tinymail sets accounts to offline
599 when the user cancels a password dialog, and doesn't ask again until
600 it has been set to online.
601 However, this is commented out because it causes a hang now.
603 (modest_platform_connect_and_wait_if_network_account):
604 * src/modest-mail-operation.c:
605 (modest_mail_operation_update_account):
606 * src/modest-platform.h:
607 * src/modest-ui-actions.c: (_modest_ui_actions_open),
608 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
610 2007-07-12 Armin Burgmeier <armin@openismus.com>
612 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
614 * src/modest-mail-operation.c:
615 * src/modest-ui-actions.c: Check for already existing folder before
616 querying the server, show error message from camel if the request
617 still fails. This fixes projects.maemo.org bug NB#58701.
619 2007-07-12 Murray Cumming <murrayc@murrayc.com>
621 * src/modest-tny-account-store.h:
622 * src/modest-tny-account-store.c:
623 Added modest_tny_account_store_forget_password_in_memory(),
624 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
625 when creating a new account, so that new passwords will be used, instead of
626 us thinking that it's a second request as a result of a failed password again.
628 2007-07-12 Murray Cumming <murrayc@murrayc.com>
630 * src/dbus_api/modest-dbus-callbacks.c:
631 (on_idle_open_message): If the message is in drafts then open it
632 in an edit window instead of a view window. This fixes
633 projects.maemo.org bug NB#63005.
635 2007-07-12 Murray Cumming <murrayc@murrayc.com>
637 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
638 Avoided a harmless g_warning().
640 2007-07-12 Murray Cumming <murrayc@murrayc.com>
642 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
643 Pass the modest account name, not the TnyAccount display name to
644 modest_msg_view_window_new() so that the reply feature works,
645 fixing projects.maemo.org bug NB#62892.
647 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
648 (modest_msg_view_window_new_with_header_model):
649 * src/maemo/modest-msg-view-window.c:
650 (modest_msg_view_window_new_with_header_model),
651 (modest_msg_view_window_new):
652 * src/modest-ui-actions.c: (reply_forward):
653 * src/widgets/modest-msg-view-window.h:
654 * src/widgets/modest-window.c: (modest_window_set_active_account):
655 Rename an account parameter to modest_account_name to make this clearer.
657 2007-07-11 Murray Cumming <murrayc@murrayc.com>
659 * src/modest-ui-actions.h:
660 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
661 modest_do_message_delete().
662 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
663 Call modest_do_message_delete(), hoping that this would cause messages
664 to be really deleted from search instead of just marked with strike through.
665 Does not seem to help.
667 2007-07-11 Armin Burgmeier <armin@openismus.com>
669 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
670 priv->reselect to FALSE prior to calling
671 modest_folder_view_select_first_inbox_or_local() to prevent endless
672 recursion and thus a crash on startup.
674 2007-07-11 Armin Burgmeier <armin@openismus.com>
676 * src/maemo/modest-account-settings-dialog.h: Include
677 <gtk/gtknotebook.h> to fix the build (at least for me).
679 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
680 Use "New FolderN" as default suggested name if "New folder" already
681 exists, with N being the first free number, though never exceed "New
682 folder99" in which case we just fall back to "New Folder" even though
683 it already exists. This fixes projects.maemo.org bug NB#58663.
685 2007-07-11 Murray Cumming <murrayc@murrayc.com>
687 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
688 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
689 projects.maemo.org bug NB#62778.
691 2007-07-11 Murray Cumming <murrayc@murrayc.com>
693 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
694 Ignore the wrong (for now) secure-smtp setting in the presets -
695 just default to requiring secure authentication for SMTP, because
698 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
700 * src/widgets/modest-folder-view.c: (filter_row)
701 Do not show drafts folder (see UI specs)
703 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
705 * src/modest-ui-actions.c:
706 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
707 place and also not necessary.
709 * src/widgets/modest-folder-view.c: (filter_row)
710 Guess folder type and hide Sent & Outbox if necessary.
711 Fixed project.maemo.org NB#57328
713 2007-07-11 Murray Cumming <murrayc@murrayc.com>
715 * src/modest-ui-actions.h:
716 * src/modest-ui-actions.c:
717 (modest_ui_actions_on_delete_message):
718 Move some code into a new
719 modest_ui_actions_refresh_message_window_after_delete()
720 function so we can use it from elsewhere.
722 * src/dbus_api/modest-dbus-callbacks.c:
723 (on_idle_delete_message), (on_delete_message): Used an idle
724 handler, as we do for the other D-Bus method handlers.
725 Call modest_ui_actions_refresh_message_window_after_delete()
726 if the deleted message was open in a window. This fixed
727 projects.maemo.org bug NB#62862.
729 2007-07-11 Murray Cumming <murrayc@murrayc.com>
731 * src/modest-main.c: (main): Only show the UI at the start if
732 the showui command line option was given. For instance,
733 run-standalone src/modest showui
734 Otherwise, we wait for the top_application D-Bus method to
735 be sent by hildon-desktop when the application is selected
737 This allows us to run without a UI when osso-global-search
738 uses our D-Bus methods.
740 2007-07-11 Murray Cumming <murrayc@murrayc.com>
742 * src/dbus_api/modest-dbus-api.h: Added a define for a
743 top-application D-Bus method.
744 * src/dbus_api/modest-dbus-callbacks.c:
745 (on_top_application),
746 (modest_dbus_req_handler): Handle the top-application D-Bus
747 method, which might be an undocumented D-Bus signal sent by
748 hildon-desktop when it starts the application from the menu.
749 But I am not sure and I need to test it on the device, because
750 my scratchbox does not have the application in the menu now.
751 This method shows the main window, so that it can be invisible
752 when started, for instance, just for email searching from
755 * src/maemo/modest-main-window.c: (restore_settings),
756 (modest_main_window_new): Do not show the window immediately
757 upon creation. We show it later.
758 * src/modest-widget-memory.c: (save_settings_paned):
759 Try (unsuccessfully) to avoid saving the paned position when
760 it is not even visible.
761 (restore_settings_paned): Do not allow a silly paned position.
762 This seems necessary when not showing the window at first.
764 * tests/dbus_api/Makefile.am:
765 * tests/dbus_api/test_top_application.c: (main): Test for the
768 2007-07-10 Murray Cumming <murrayc@murrayc.com>
770 * src/modest-ui-dimming-rules.c:
771 (modest_ui_dimming_rules_on_new_msg),
772 (modest_ui_dimming_rules_on_reply_msg),
773 (modest_ui_dimming_rules_on_delete_msg),
774 (modest_ui_dimming_rules_on_details),
775 (modest_ui_dimming_rules_on_view_window_move_to),
776 (modest_ui_dimming_rules_on_view_previous),
777 (modest_ui_dimming_rules_on_view_next),
778 (_invalid_folder_for_purge): Added checks before
779 casting the window. This looks like an actual
780 logic error in _invalid_folder_for_purge(), because it
781 tries to use a ModestMainWindow as a message window.
783 2007-07-10 Murray Cumming <murrayc@murrayc.com>
785 * src/maemo/modest-account-settings-dialog.c:
786 (show_error): Use the same implementation as in
787 modest-easysetup-wizard.c:
788 (on_entry_invalid_character): The logical ID contains a %s.
789 Guessed what it should be.
790 (on_entry_max), (check_data), (on_response): Adapt to
791 changed show_error().
792 (create_page_account_details): Really call
793 modest_validating_entry_set_func() on the correct widgets.
794 * src/maemo/easysetup/modest-easysetup-wizard.c:
795 (on_entry_invalid_character): Fix the logical ID here too.
796 (create_page_account_details),
797 (create_page_user_details):
799 modest_validating_entry_set_func() on the correct widgets.
801 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
802 Do not try to use the account if it is NULL.
804 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
806 * src/modest-ui-actions.c: (create_move_to_dialog),
807 (modest_ui_actions_on_main_window_move_to),
808 (modest_ui_actions_on_msg_view_window_move_to):
809 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
810 (filter_row), (modest_folder_view_show_non_move_folders):
811 * src/widgets/modest-folder-view.h:
813 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
814 the Sent folder yet as it does not report the correct folder type.
816 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
818 * src/maemo/modest-msg-edit-window.c: (init_window):
821 2007-07-10 Murray Cumming <murrayc@murrayc.com>
823 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
824 Take a parent widget instead of a parent window, and
825 implement this with hildon_banner_show_information() instead.
826 Non-Maemo builds can just ifdef that there.
827 This fixed projects.maemo.org bug NB#62766.
829 (on_entry_invalid_character): Use show_error() again instead
830 of using hildon directly, and use the _CS() macro to use the correct
832 (create_account), (check_for_supported_auth_methods), (on_entry_max):
833 Pass a widget instead od a window to show_error().
835 2007-07-10 Murray Cumming <murrayc@murrayc.com>
837 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
838 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
839 This allows us to show the server name in the error message, fixing
840 projects.maemo.org bug NB#62904.
841 Also, use the appropriate logical ID message for the account protocol.
843 2007-07-10 Murray Cumming <murrayc@murrayc.com>
845 * src/modest-tny-account-store.c: (on_idle_wrong_password):
846 A compilation fix, though the build wasn't broken for me.
848 2007-07-09 Murray Cumming <murrayc@murrayc.com>
850 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
851 Do not try to unref a NULL folder store, to avoid a runtime warning.
852 This seems to happen sometimes when changing accounts settings.
854 2007-07-09 Murray Cumming <murrayc@murrayc.com>
856 * src/modest-tny-account-store.c:
857 (modest_tny_account_store_instance_init),
858 (modest_tny_account_store_finalize),
859 (on_account_settings_hide), (on_idle_wrong_password):
860 Use a GHashTable to ensure that we only show one account settings
861 dialog per modest account. This avoids us having a dialog open for
862 both the store and transport accounts, or due to repeated get_password()
863 calls that shouldn't happen anyway.
865 2007-07-09 Murray Cumming <murrayc@murrayc.com>
867 * src/maemo/modest-maemo-utils.c: (on_hide),
868 (modest_maemo_show_dialog_and_forget): Handle the response, because
869 the window is not even hidden by default.
871 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
872 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
873 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
874 which seems to prevent some modality problems.
876 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
877 Ignore user cancellation errors.
879 * src/modest-account-mgr-helpers.h:
880 * src/modest-account-mgr-helpers.c:
881 Added modest_server_account_get_password() and
882 modest_server_account_get_has_password() to avoid direct use of
885 * src/maemo/modest-account-settings-dialog.h:
886 * src/maemo/modest-account-settings-dialog.c:
887 (modest_account_settings_dialog_init): Store the notebook so we can
889 Added modest_account_settings_dialog_switch_to_user_info().
891 * src/modest-tny-account-store.c:
892 (get_password): When the password in the account settings is wrong (we think),
893 show the relevant page of the account settings dialog, in the mainloop.
894 However, we currently get many of these at once because cancel does not
896 (forget_password): Do not forget the password
897 from the account settings, because this causes side-effects when
898 tinymail seems to call it at strange time, maybe because of how we
899 are cancelling get_password().
900 (modest_tny_account_store_alert): Ignore user cancellations.
902 2007-07-09 Murray Cumming <murrayc@murrayc.com>
904 * src/maemo/modest-maemo-utils.h:
905 * src/maemo/modest-maemo-utils.c:
906 Added modest_maemo_show_information_note_and_forget() for use instead of
907 gtk_dialog_run() when the response is not needed, to avoid an extra
908 mainloop which could cause a hang.
910 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
911 Use the logical IDs for the error message, though they are not
912 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
913 because gtk_dialog_run() caused a hang here (the window did not close).
914 This fixes projects.maemo.org bug NB#62646.
916 2007-07-09 Murray Cumming <murrayc@murrayc.com>
918 * src/modest-account-mgr-helpers.h:
919 * src/modest-account-mgr-helpers.c:
920 Added modest_account_mgr_get_store_protocol().
922 * src/maemo/modest-account-view-window.c:
923 (on_delete_button_clicked): Show different warning text depending on
924 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
925 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
928 2007-07-09 Murray Cumming <murrayc@murrayc.com>
930 * src/maemo/modest-msg-edit-window.c:
931 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
932 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
934 2007-07-07 Armin Burgmeier <armin@openismus.com>
936 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
937 ckdg_ib_maximum_characters_reached from correct package.
939 * src/modest-ui-actions.c: Show an error message when a folder could
940 not be created. Tinymail does not give us specific error codes about
941 what has gone wrong, so we assume that a folder with that name
942 already exists, though there might be other reasons.
944 2007-07-06 Murray Cumming <murrayc@murrayc.com>
946 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
947 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
948 give a more exact error message that can be partly translated.
950 2007-07-05 Murray Cumming <murrayc@murrayc.com>
952 * src/maemo/modest-address-book.c:
953 (select_email_addrs_for_contact): Specify a default window size for the
954 select-email-address dialog, so that it is probably big enough for the
955 title. This should fix projects.maemo.org bug NB#62277.
957 2007-07-05 Murray Cumming <murrayc@murrayc.com>
959 * src/maemo/easysetup/modest-easysetup-wizard.c:
960 (create_page_complete_easysetup): Use
961 gtk_widget_set_size() request to ensure that the text wraps
964 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
966 * src/maemo/easysetup/modest-easysetup-wizard.c:
967 (on_entry_invalid_character), (create_page_account_details),
968 (create_page_user_details):
969 Use new API of ModestValidatingEntry. But for some reason the banner is
970 not shown. I will have to investigate that further.
972 * src/widgets/modest-validating-entry.c: (on_insert_text),
973 (modest_validating_entry_set_func):
974 * src/widgets/modest-validating-entry.h:
975 Added a new callback function to be able to react to prevented
976 characters whitespaces to e.g show a banner.
978 2007-07-05 Armin Burgmeier <armin@openismus.com>
980 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
981 notification of HildonNumberEditor instead of remembering the port
982 number. Thanks to Johannes for pointing this out.
984 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
986 * src/maemo/easysetup/modest-easysetup-wizard.c:
987 Check if there are any user changes before showing a confirmation
988 dialog (projects.maemo.org NB#60946)
990 2007-07-05 Armin Burgmeier <armin@openismus.com>
992 * src/maemo/modest-account-settings-dialog.c: Remember custom port
993 number at the beginning of the dialog and set the modified flag at the
994 end if the port number has changed. This is necessary because
995 HildonNumberEditor does not support notification when the value has
998 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1000 * src/modest-ui-actions.c:
1001 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1002 a connection before asking anything else. Correct the check for the destination
1003 folder so that it succeeds when online.
1004 This fixed projects.maemo.org bug NB#61645.
1006 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1008 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1009 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1010 to fix projects.maemo.org bug NB#62439.
1012 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1014 * src/modest-tny-account.c: (on_connection_status_changed):
1015 Really do not use tny_device_force_offline() here. See the previous comment.
1017 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1019 * src/modest-tny-account.c: (on_connection_status_changed):
1020 Do not use tny_device_force_offline() when tinymail says that something
1021 went wrong with the connection. It seems to report this unnecessarily.
1023 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1025 * src/maemo/modest-connection-specific-smtp-window.c:
1026 (modest_connection_specific_smtp_window_init):
1027 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1028 does not seem to have any effect in osso 1.1 (though it works in
1029 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1031 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1033 * src/maemo/modest-connection-specific-smtp-window.c:
1034 Fix UI specification problems with projects.meamo.org NB#60479
1036 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1038 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1039 clue when this has failed, because the error dialog is not always shown
1040 (at least in earlier version).
1042 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1043 GError message, because the generic error dialog is not helpful.
1045 'This message is not currently available (can't let a new connection go online)'
1046 when trying to open an IMAP message.
1048 (_modest_ui_actions_open): Offer a connection when some messages would
1049 have to be downloaded and we are offline.
1051 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1053 * src/widgets/modest-folder-view.c:
1054 Don't check for MERGE type anymore as we use the correct type
1056 NOTE: For the last two changes you need to update your tinymail copy
1057 because of API changes!
1059 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1061 * src/modest-tny-local-folders-account.c:
1062 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1063 (see projects.maemo.org NB#61580)
1065 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1067 * src/modest-tny-account.c: (on_connection_status_changed):
1068 Commented out the call to modest_platform_connect_and_wait() because this
1069 seems to always hang, and I would like to know if this is the only thing
1070 that causes a hang when showing the connection dialog.
1071 It is not very useful anyway.
1073 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1075 * src/maemo/modest-msg-view-window.c:
1076 (modest_msg_view_window_select_next_message):
1078 * src/modest-platform.h:
1079 * src/maemo/modest-platform.c:
1080 Added modest_platform_connect_and_wait(), which calls
1081 tny_maemo_conic_device_connect() always in the main thread, by calling it
1082 in an idle handler and waiting for the idle handler to run. It should be
1083 in the main thread because it uses GTK+ UI code. It just returns TRUE
1084 if the device is already online.
1086 There is some nasty code to ensure that subsequent calls to
1087 modest_platform_connect_and_wait() just wait for the first one to finish,
1088 by checking repeatedly in another idle handler. This is necessary,
1089 because other threads (or even the main thread, via another idle handler)
1090 can call modest_platform_connect_and_wait() while
1091 modest_platform_connect_and_wait() is running.
1093 (modest_platform_connect_and_wait_if_network_account),
1094 (modest_platform_connect_and_wait_if_network_folderstore):
1095 Convenience functions that calls modest_platform_connect_and_wait() if
1096 the account or folder might want network access.
1098 * src/modest-mail-operation.c:
1099 (modest_mail_operation_update_account):
1100 * src/modest-ui-actions.c: (download_uncached_messages),
1101 (modest_ui_actions_on_rename_folder), (delete_folder),
1102 (modest_ui_actions_on_main_window_move_to),
1103 (modest_ui_actions_on_msg_view_window_move_to):
1104 * src/widgets/modest-folder-view.c:
1105 (drag_and_drop_from_folder_view):
1106 Offer a connection if we are offline.
1108 * src/modest-tny-account.c: (on_connection_status_changed):
1109 Document this as only handling errors during network operations in progress,
1110 and replace the idle code with a simple call to
1111 modest_platform_connect_and_wait(), which does this instead.
1113 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1115 * src/modest-tny-account.c:
1116 (modest_tny_account_get_special_folder): (util_on_idle),
1117 Handle the GError so we can see when tny_folder_store_get_folders()
1118 fails, as it currently does while something else is connecting.
1120 Added util_run_in_main_thread_and_wait()
1121 which uses an idlen handler and mainloop to ensure that the function
1122 is called in the main thread.
1123 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1124 to make sure that we call attempt the connection in the mainloop only,
1125 which might solve some hangs.
1127 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1129 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1130 be found by their display name. This is never useful.
1131 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1132 by its ID, instead of trying to use its ID as its display name.
1134 * src/modest-tny-account-store.h:
1135 * src/modest-tny-account.c:
1136 (modest_tny_account_get_special_folder): Add a g_warning() when
1137 tny_folder_store_get_folders() returns an empty list for the maildir.
1139 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1140 Add a g_warning() when this returns NULL, because that it not allowed
1143 2007-07-02 Armin Burgmeier <armin@openismus.com>
1145 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1146 note when trying to cancel the wizard. This fixes projects.maemo.org
1149 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1151 * src/modest-tny-account.h:
1152 * src/modest-tny-account.c:
1153 (modest_tny_account_new_from_server_account),
1154 (modest_tny_account_new_from_server_account_name),
1155 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1156 because this must now be set before setting the proto. This is usd in
1157 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1158 warning in camel_session_get_service() caused by
1159 tny_camel_transport_account_prepare().
1161 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1164 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1166 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1168 (modest_connection_specific_smtp_edit_window_init):
1170 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1171 of "changed" for now
1173 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1175 * src/modest-tny-account.c:
1176 (modest_tny_account_new_from_server_account):
1177 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1178 now uses to request a connection when it needs one, and which it uses
1179 to tell us that something is wrong with the connection, so we can force
1180 the accounts offline to prevent further problems.
1182 * src/modest-defs.h:
1183 * src/modest-init.c: (init_default_settings):
1184 * src/modest-mail-operation.c:
1185 (modest_mail_operation_update_account):
1186 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1187 This should not be necessary anymore. Do not set the conf key that
1188 determined this (it was always TRUE and not set anywhere else).
1190 * src/modest-ui-actions.h: Remove unused and unimplemented
1191 modest_ui_actions_on_online_toggle_toggled().
1193 2007-06-29 Murray Cumming <murrayc@murrayc.com
1195 * src/maemo/modest-main-window.c: (connect_signals):
1196 Don't connect to delete_event twice. Maybe this was harmless.
1198 2007-06-29 Murray Cumming <murrayc@murrayc.com
1200 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1201 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1202 Debug output to give some more clue when a folder move is not allowed.
1204 2007-06-28 Murray Cumming <murrayc@murrayc.com
1206 * src/modest-tny-account.c: (on_modest_file_system_info),
1207 (modest_tny_account_get_mmc_account_name):
1208 Always call the callback, without checking whether the name has changed.
1209 * src/widgets/modest-folder-view.c: (strings_are_equal),
1210 (on_model_foreach_set_name), (on_get_mmc_account_name),
1211 (text_cell_data): Compare the name here, and use the name from
1212 the account rather than from the
1213 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1214 if the name was changed after the account was added to the model.
1215 That's a tinymail bug but not one that I want to fix now.
1217 This finally fixes projects.maemo.org bug NB#59301.
1219 2007-06-27 Armin Burgmeier <armin@openismus.com>
1221 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1224 2007-06-27 Murray Cumming <murrayc@murrayc.com
1226 * src/modest-tny-account.h:
1227 * src/modest-tny-account.c:
1228 Added modest_tny_account_get_mmc_account_name(), to set the memory
1229 card name asynchronously for the given account and then notify.
1230 (modest_tny_account_new_for_local_folders): Use this new function instead
1231 of using hildon_file_system_info_async_new() directly.
1233 * src/widgets/modest-folder-view.c: (text_cell_data):
1234 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1235 gtk_tree_model_row_changed() when it is available.
1237 This should fix projects.maemo.org bug NB#59301.
1239 2007-06-27 Murray Cumming <murrayc@murrayc.com
1241 * src/modest-mail-operation.c: (update_account_thread),
1242 (get_msgs_full_thread): Fix typo failures in the revert
1245 2007-06-27 Murray Cumming <murrayc@murrayc.com
1247 * src/maemo/modest-maemo-global-settings-dialog.c:
1248 (idle_select_default_focus):
1249 * src/modest-mail-operation.c: (idle_notify_progress),
1250 (idle_notify_progress_once), (set_last_updated_idle),
1251 (update_account_thread), (get_msgs_full_thread):
1252 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1253 * src/widgets/modest-header-view.c:
1254 (idle_notify_headers_count_changed_destroy),
1255 (idle_notify_headers_count_changed):
1256 Reverted the additions of gdk_threads_enter/leave(), in case this
1257 helps with a startup hang on the device.
1259 2007-06-26 Armin Burgmeier <armin@openismus.com>
1261 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1262 for supported secure authentication methods from server by
1263 gtk_dialog_run(), saving CPU time and a potential race condition.
1265 2007-06-26 Armin Burgmeier <armin@openismus.com>
1267 * src/maemo/modest-maemo-utils.h:
1268 * src/maemo/modest-maemo-utils.c: Added a
1269 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1270 only error code to tell the calling code when the user canceled the
1273 * src/maemo/modest-account-settings-dialog.h:
1274 * src/maemo/modest-account-settings-dialog.c:
1275 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1276 message if the retrieval of secure authentication methods was canceled
1277 by the user. Perform the check before saving anything to configuration
1278 to not end up with half-committed configuration changes, do not show
1279 a "Saving to configuration failed" note when authentication methods
1280 could not be retrieved.
1282 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1285 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1287 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1288 Only return the first level of folders under accounts, because the
1289 osso-global-search UI spec doesn't want the rest.
1290 This fixed projects.maemo.org bug NB#61811.
1292 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1294 * src/modest-tny-account-store.c:
1295 * src/modest-tny-account-store.h:
1296 Added modest_tny_account_is_memory_card_account().
1297 * src/maemo/modest-main-window.c: (create_details_widget):
1298 Show the same information items for the memory card as we show for the
1299 local-folders, to fix projects.maemo.org bug NB#59307.
1301 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1303 * src/modest-tny-account-store.c: (get_password):
1304 Added some checks for NULL to maybe prevent crashes, though I think
1305 it was Philip's last commit that actually prevented the crash here
1306 when creating a first new account.
1307 But the new account is still not usable (no messages are shown)
1308 until a restart of the application.
1310 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1312 * src/maemo/modest-maemo-global-settings-dialog.c:
1313 (idle_select_default_focus):
1314 * src/modest-mail-operation.c: (idle_notify_progress),
1315 (idle_notify_progress_once), (idle_notify_update_account_queue),
1316 (set_last_updated_idle), (update_account_thread),
1317 (notify_get_msgs_full), (get_msgs_full_destroyer),
1318 (get_msgs_full_thread):
1319 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1320 * src/widgets/modest-header-view.c:
1321 (idle_notify_headers_count_changed_destroy),
1322 (idle_notify_headers_count_changed):
1323 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1324 all idle handlers, because some other thread could be blocking
1325 the GDK lock, so that it can do GUI stuff.
1327 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1329 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1330 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1331 (on_idle_send_receive), (on_idle_open_default_inbox):
1332 * src/maemo/modest-msg-edit-window.c:
1333 (modest_msg_edit_window_attach_file_noninteractive):
1334 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1335 to prevent a hang. I don't quite understand why these are necessary,
1336 beause we should already be in the main loop. I guess something outside
1337 of the main loop is taking the lock.
1339 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1340 we are really using URIs, and use files that are more likely to exist.
1342 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1344 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1345 necessary because configure.ac now defines different variables.
1347 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1349 * libmodest-dbus-client/libmodest-dbus-client.c:
1350 * libmodest-dbus-client/libmodest-dbus-client.h:
1351 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1352 libmodest_dbus_client_compose_mail() is what things actually use.
1354 * src/dbus_api/modest-dbus-api.h:
1355 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1356 * tests/dbus_api/Makefile.am:
1357 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1360 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1362 * src/modest-init.c: (modest_init_local_folders):
1363 For memory-card (or other non local-folders) maildir accounts,
1364 always create an Archive folder, so that there is somewhere to put
1365 messages. This should be less confusing, because the user does not need
1366 to guess that the need to create a folder.
1368 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1370 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1371 Fixed icon size by using (50, 50) which is the same as defined by
1374 2007-06-25 Armin Burgmeier <armin@openismus.com>
1376 * src/widgets/modest-window-mgr.c:
1377 * src/modest-init.c:
1378 * configure.ac: Correctly recognize hildon-notify presence and fixed
1379 the build without it being installed.
1381 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1383 * libmodest-dbus-client/libmodest-dbus-client.c:
1384 (libmodest_dbus_client_search): Fix the build. Sorry.
1385 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1386 (reply_forward_cb): Initialize variables to fix the build.
1388 * src/modest-tny-account-store.c:
1389 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1390 comparison (a silly typo) so that email search results can be opened
1391 when there are more than one account.
1393 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1395 * libmodest-dbus-client/libmodest-dbus-client.c:
1396 (libmodest_dbus_client_search),
1397 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1398 instead of 1 second, because the search gets folders and messages from
1399 the server, which can take a long time. When it times out,
1400 osso-global-search will report no results.
1402 We need to specify whether we should search only cached information
1403 (maybe with a user preference), and the osso-email-search-plugin
1404 API should really be improved to allow that option, and to allow results
1405 to be delivered asynchronously in batches.
1407 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1409 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1410 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1411 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1413 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1415 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1416 that is an empty string. D-Bus seems to give us these instead of NULL.
1418 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1420 * src/dbus_api/modest-dbus-callbacks.c:
1421 * src/maemo/easysetup/modest-easysetup-wizard.h:
1422 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1423 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1424 (modest_connection_specific_smtp_edit_window_init):
1425 * src/maemo/modest-maemo-global-settings-dialog.c:
1427 * src/maemo/modest-maemo-utils.c:
1428 (modest_maemo_utils_setup_images_filechooser):
1429 * src/maemo/modest-main-window.c: (create_details_widget):
1430 * src/maemo/modest-msg-edit-window.c:
1431 (modest_msg_edit_window_attach_file_noninteractive),
1432 (modest_msg_edit_window_color_button_change),
1433 (modest_msg_edit_window_set_zoom):
1434 * src/modest-mail-operation.c: (update_account_thread):
1435 * src/modest-tny-account-store.c:
1436 * src/modest-tny-account.c:
1437 * src/widgets/modest-global-settings-dialog.c:
1438 * src/widgets/modest-window.h:
1440 Fixed build on bora!
1442 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1444 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1445 * src/modest-search.c: (modest_search_folder),
1446 (modest_search_all_accounts): Actually search only in the specified folder,
1447 doing a simple match on the folder ID.
1448 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1449 and added some documentation.
1451 2007-06-22 Armin Burgmeier <armin@openismus.com>
1453 * src/maemo/modest-maemo-utils.h:
1454 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1455 modest_maemo_utils_get_supported_secure_authentication_methods.
1457 * src/maemo/easysetup/modest-easysetup-wizard.c:
1458 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1459 one occured, not just "Server does not support secure authentication".
1461 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1463 * src/modest-tny-account-store.c: (get_password):
1464 Restored the call to tny_account_set_user() because Philip seems to have
1465 stopped this from crashing (by not using the freed string). It still does
1466 not work, but now we can test it.
1468 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1470 * src/maemo/modest-msg-edit-window.c: (init_window):
1471 Comment out use of an uninitialzed GtkScrolledWindow variable,
1472 to fix the build and stop a crash. Yet again.
1474 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1476 * src/modest-tny-account-store.c: (get_password):
1477 Remove the call to tny_account_set_user() because this actually crashes.
1478 As mentioned in the last commit, it is known to not work anyway.
1480 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1482 * src/modest-tny-account-store.c: (get_password):
1483 Use tny_account_set_username() to tell tinymail that the username might
1484 have changed too. But tinymail ignores this: see projects.maemo.org
1486 * src/modest-ui-actions.c:
1487 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1488 reset the connection when changing the username, and improve the comments.
1489 Save the changed username to gconf at least, so it is used when Modest is
1492 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1494 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1495 Do not use a query, so that we get all folders, including for POP and
1496 local-folders. They work as search criteria too.
1497 This fixes projects.maemo.org bug NB#57740.
1499 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1501 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1502 Comment out the use of hildon_notification_set_sound() because it is
1503 not declared, to fix the build. Warnings are serious, people.
1505 2007-06-21 Armin Burgmeier <armin@openismus.com>
1507 * src/maemo/modest-maemo-utils.h:
1508 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1509 modest_maemo_utils_get_supported_secure_authentication_methods()
1510 to query authentication methods for a specific user. This should fix
1511 projects.maemo.org bug NB#61369.
1513 * src/maemo/easysetup/modest-easysetup-wizard.c:
1514 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1517 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1519 * libmodest-dbus-client/libmodest-dbus-client.h:
1520 * libmodest-dbus-client/libmodest-dbus-client.c:
1521 (modest_dbus_message_iter_get_search_hit),
1522 (libmodest_dbus_client_search):
1523 Reorganised and commented this.
1524 Removed modest_search_hit_free() from the public API because it
1527 Added libmodest_dbus_client_get_folders() and
1528 modest_folder_result_list_free().
1530 * src/dbus_api/modest-dbus-api.h:
1531 * src/dbus_api/modest-dbus-callbacks.c:
1532 (modest_dbus_req_filter): Commented. Moved most code to
1533 on_dbus_method_search() and added on_dbus_method_get_folders().
1535 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1536 of the extra D-Bus handler.
1538 * tests/dbus_api/Makefile.am:
1539 * tests/dbus_api/test_get_folders.c: New test for
1540 libmodest_dbus_client_get_folders(). This seems to return an empty list
1541 at the moment. That could be the same error that causes the message list
1542 to be empty sometimes.
1543 This should help with projects.maemo.org bug NB#57740.
1545 2007-06-21 Armin Burgmeier <armin@openismus.com>
1547 * src/modest-mail-operation.c: Do not call
1548 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1549 notify the operation's end after having set the status to CANCELED for
1550 the operation queue to listen on. This fixes a deadlock when there
1551 were mail operations in the queue during its finalization.
1553 * src/modest-singletons.c: Reordered uninitialization of the account
1554 manager to happen after the mail operation queue was uninitialized
1555 because the mail operation's in the queue might still try to access
1556 the account manager (see modest_mail_operation_notify_end()). This
1557 fixes a potential crash when terminating the application.
1559 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1561 * src/modest-search.c:
1562 (search_mime_part_and_child_parts): Moved some code here so we
1563 can search recursively in child folders.
1564 (modest_search_folder): Search in the message as a mime part, instead
1565 of just its child mime parts.
1566 (read_chunk), (search_mime_part_ogs):
1567 Check how many bytes were read, to prevent an endless loop.
1568 Searching in message bodies now works. This finishes the fix for
1569 projects.maemo.org bug NB#61007.
1571 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1573 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1574 Add a g_warning when the item is not a folder.
1576 * src/modest-ui-dimming-rules.c:
1577 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1578 when selected item is not a folder (for instance, an account), because
1579 the UI spec only talks about folders.
1580 I am not sure what the UI spec wants, so this might not totally fix
1581 projects.maemo.org bug NB#60794.
1583 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1585 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1586 (load_from_file): Sort the list. The unsorted list would be more noticeable
1587 in non-English locales.
1589 * src/maemo/modest-msg-edit-window.c:
1590 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1591 warning and fix the build.
1593 * src/maemo/modest-progress-bar-widget.c:
1594 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1595 avoid a g_warning, and probably to avoid a crash.
1597 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1599 * src/modest-search.c: (modest_search_folder): Check for a GError
1600 when calling tny_folder_get_headers(), to show that this is not the cause
1603 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1605 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1606 Actually set the body query instead of the subject query.
1608 * src/modest-search.c: (search_mime_part_ogs),
1609 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1610 which would probably cause it to fail if we got this far.
1612 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1613 to simplify the code.
1614 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1615 be causing search-in-body to fail.
1617 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1619 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1621 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1622 Better debug message when the folder cannot be found.
1623 This should help with fixing projects.maemo.org bug #61287.
1624 * src/modest-search.c: (add_hit): Do not leak the furl string.
1626 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1628 * src/modest-ui-actions.c:
1629 (modest_ui_actions_on_folder_selection_changed):
1630 Do not special-case TNY_MERGE_FOLDER here, because
1631 modest_tny_folder_get_account() already does that. This fixes
1632 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1633 shown when the Outbox was selected).
1635 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1637 * libmodest-dbus-client/libmodest-dbus-client.c:
1638 (_dbus_iter_get_string_or_null): Initialize the string variable in
1639 case this helps with Dirk's crash.
1641 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1643 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1644 though it is not implemented yet (this function is maybe not even used),
1645 to avoid breaking ABI in future.
1646 * libmodest-dbus-client/libmodest-dbus-client.c:
1647 (get_attachments_string): Moved some code into this generic function.
1648 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1649 sends email. It is maybe not used.
1650 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1651 (on_send_mail): Use attachments.
1653 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1654 * src/maemo/modest-msg-edit-window.c:
1655 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1656 a filename before using it, to fix projects.maemo.org bug NB#58233.
1658 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1660 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1661 Initialize the continue_download variable to fix the build, and probably
1662 to fix randome behaviour.
1664 2007-06-18 Armin Burgmeier <armin@openismus.com>
1666 * src/modest-tny-send-queue.h:
1667 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1668 the queue so we can later show it in the UI. Replaced
1669 modest_tny_send_queue_msg_is_being_sent() by
1670 modest_tny_send_queue_get_msg_status().
1672 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1674 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1675 gpointer. This probably was not harmful, but just to be sure.
1677 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1679 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1680 Fix the build, but leave the function broken on Bora, because
1681 hildon_uri_action_get_service() does not exist.
1682 osso_uri_action_get_service() does not exist either, it seems.
1684 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1686 * src/modest-tny-account.c:
1687 (modest_tny_account_new_from_server_account):
1688 Uncommented the url debug output again, because it is useful for
1689 debugging, as I said in the comment.
1691 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1693 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1695 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1696 for Mameo Bora, to fix the build.
1698 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1701 Fixed build with hildon < 0.99
1703 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1704 Check if the selected account is busy instead of checking all accounts
1706 * src/modest-account-mgr-priv.h:
1707 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1708 (modest_account_mgr_init), (compare_account_name),
1709 (modest_account_mgr_set_account_busy),
1710 (modest_account_mgr_account_is_busy):
1711 * src/modest-account-mgr.h:
1712 Added busy information to the account manager. It possible to
1713 set an account to busy or not busy now.
1715 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1716 (modest_mail_operation_update_account),
1717 (modest_mail_operation_notify_end):
1718 Set the account to busy/not busy depending on the operation state.
1720 * src/widgets/modest-account-view.c:
1721 (modest_account_view_finalize), (get_last_updated_string),
1722 (update_account_view), (on_account_busy_changed), (init_view):
1723 Show string "Refreshing..." if the account is currently busy.
1725 All this fixes projects.maemo.org bug NB#59711
1727 2007-06-14 Armin Burgmeier <armin@openismus.com>
1729 * src/widgets/modest-attachments-view.h:
1730 * src/widgets/modest-attachments-view.c: Added
1731 modest_attachments_view_has_attachments() and fixed coordinate
1732 transformation in get_att_view_at_coords(). This fixes attachment
1735 * src/widgets/modest-msg-view.c: Make use of
1736 modest_attachments_view_has_attachments() to decide whether to show
1737 attachments in the header.
1739 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1742 (on_change), (on_combo_security_changed),
1743 (modest_connection_specific_smtp_edit_window_init),
1744 (modest_connection_specific_smtp_edit_window_set_connection),
1745 (modest_connection_specific_smtp_edit_window_is_dirty):
1746 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1747 * src/maemo/modest-connection-specific-smtp-window.c:
1750 Show an comfirmation dialog for the smpt-edit-window if there are
1751 unsaved changes and the user hits cancel.
1752 (projects.maemo.org bug NB#60479)
1754 2007-06-14 Armin Burgmeier <armin@openismus.com>
1756 * src/maemo/easysetup/modest-easysetup-wizard.c:
1757 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1758 address" info in banner instead of node, and select all the text as
1759 per UI spec. This fixes projects.maemo.org bug NB#60550.
1761 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1763 reviewed by: <delete if not using a buddy>
1765 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1766 * src/modest-ui-actions.c: (folder_refreshed_cb):
1768 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1770 * src/widgets/modest-folder-view.c: (filter_row):
1771 Explictly filter out the per-account outbox accounts. I don't know why
1772 these only sometimes show up, but now they should never show up in the UI.
1773 This should fix projects.maemo.org bug NB#60160.
1775 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1777 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1778 when the toolbar does not exist yet.
1779 * src/modest-widget-memory.c: (save_settings_header_view):
1780 Added g_warnings() to help us to discover when we are trying to set
1781 an empty columns list in gconf.
1783 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1785 * src/modest-init.h:
1786 * src/modest-init.c:
1787 Added modest_init_get_default_header_view_column_ids().
1789 * src/modest-widget-memory.c: (restore_settings_header_view):
1790 Use the new function to get defaults, if the gconf key is empty,
1791 instead of not creating any columns. This seems to fix the
1792 empty right-hand pane problems.
1794 * src/widgets/modest-header-view.h: Improved documentation.
1796 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1798 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1799 Revert the use of the display name as the account name, because this
1800 is generally wrong and would break the code that follows.
1802 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1804 * src/maemo/easysetup/modest-easysetup-wizard.c:
1805 (check_for_supported_auth_methods), (on_before_next),
1808 More correct fix for projects.maemo.org bug NB# 58991
1809 Do not longer accept AUTH_PASSWORD as secure method and choose
1810 correct method when creating the account.
1812 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1814 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1815 Fixed projects.maemo.org bug NB# 58991
1817 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1819 * src/modest-init.c: (modest_init_init_core),
1820 (modest_init_local_folders): Fixed compilation errors.
1822 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1824 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1825 Remove unnecessary lib/include, though it is good in principle when needed.
1827 * src/modest-init.c: (modest_init_one_local_folder),
1828 (modest_init_local_folders):
1829 * src/modest-init.h: Initialize the .modest library for memory cards,
1830 instead of just doing nothing for them. This should allow us to create
1831 folders there, fixing projects.maemo.org bug NB#59297.
1833 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1835 * libmodest-dbus-client/libmodest-dbus-client.c:
1836 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1837 (libmodest_dbus_client_compose_mail),
1838 (libmodest_dbus_client_open_message),
1839 (libmodest_dbus_client_send_and_receive),
1840 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1842 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1843 (on_idle_open_message), (modest_dbus_req_handler),
1844 (search_result_to_message), (modest_dbus_req_filter):
1845 * src/modest-search.c: (add_hit), (modest_search_folder),
1846 (modest_search_all_accounts): Improved debug messages.
1848 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1850 * src/modest-tny-account-store.c:
1851 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1854 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1857 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1859 * src/modest-tny-account-store.c: (get_server_accounts):
1860 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1861 even when there are no accounts, so that the Outbox folder is always
1862 visible. This fixes projects.maemo.org bug NB#60158.
1864 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1866 * src/maemo/modest-main-window.c: (create_details_widget):
1867 Use the mcen_va_never logical ID.
1869 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1871 * src/dbus_api/modest-dbus-api.h:
1872 * src/dbus_api/modest-dbus-callbacks.c:
1873 (on_idle_open_default_inbox), (on_open_default_inbox),
1874 (modest_dbus_req_handler):
1875 Added a new OpenDefaultInbox method.
1877 * libmodest-dbus-client/libmodest-dbus-client.h:
1878 * libmodest-dbus-client/libmodest-dbus-client.c:
1879 Added libmodest_dbus_client_open_default_inbox() to call the new
1880 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1881 though it should maybe be used by a new osso-email-interface function.
1883 * tests/dbus_api/Makefile.am:
1884 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1887 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1889 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1890 NULL, so that the signals get all the keys. This should not actually
1891 change any behaviour because we currently update everything when anything
1894 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1896 * src/widgets/modest-folder-view.c: (text_cell_data),
1897 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1898 (find_inbox_iter): If tinymail tells us that the folder is
1899 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1900 This causes the inbox to be selected at startup, fixing part of
1901 projects.maemo.org bug NB#56305.
1903 * src/modest-ui-dimming-rules.c:
1904 (modest_ui_dimming_rules_on_tools_smtp_servers):
1905 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1906 the SMTP servers menu item.
1907 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1908 that the SMTP Servers menu item is dimmed when there are no accounts,
1909 as a future version of the UI spec will require. This fixes
1910 projects.maemo.org bug NB#56305.
1912 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1914 * src/maemo/modest-maemo-utils.c:
1915 (modest_maemo_utils_get_supported_secure_authentication_methods):
1916 Added label to dialog instead of unreadable title
1918 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1919 (modest_main_window_new):
1920 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1923 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1924 * src/modest-account-mgr.h:
1925 Added method to avoid code duplication
1927 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1928 (modest_ui_actions_on_send_receive):
1929 Use modest_account_mgr_has_accounts
1931 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1933 * src/maemo/easysetup/modest-presets.c:
1934 (modest_presets_get_info_server_security): Do not report secure auth
1936 * src/modest-protocol-info.c: Use the defines for the gconf key names
1937 for secure authentication. This was not working because we were writing
1938 Password and reading password, and the check was case sensitive.
1939 With this, gmail now works for receiving and sending when created via
1942 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1944 * src/maemo/easysetup/modest-presets.c:
1945 (modest_presets_get_info_server_security): Correct the key name for
1946 SecureSmtp, because it seems to be case-sensitive.
1947 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1948 Do not try to get the 0th notebook page if there are 0 pages, to
1949 avoid a g_warning().
1951 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1953 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1954 Prevent use of the new notification feature for now, because it currently
1955 shows one dialog for each new email, which is annoying.
1957 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1959 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1960 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1961 when no country was selected, so that we show the global ones.
1962 * src/maemo/easysetup/modest-presets.c:
1963 (modest_presets_get_providers): Return only the global providers, not
1964 all providers when mmc=0 was requested.
1966 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1968 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1969 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1970 provider ID in the combo.
1972 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1973 Do not show the page numbers, because it would be confusing when we add
1974 the 2 extra pages for the custom setup, when the user chooses the "Other"
1975 provider. This fixes projects.maemo.org bug NB#59028
1977 * src/modest-init.c: (modest_init_init_core),
1978 (modest_init_local_folders):
1979 * src/modest-init.h:
1980 * src/modest-tny-account.c:
1981 (modest_tny_account_new_for_local_folders): Do not create default folders
1982 for the memory card. This should fix projects.maemo.org bug NB#59328.
1984 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1986 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1987 Free the changed_conf_keys string items. They are already freed in the
1988 idle handler if that runs first.
1990 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1992 * src/modest-ui-actions.c:
1993 (modest_ui_actions_on_password_requested): Check that the server name
1994 is not NULL, because I just saw a password dialog with (null) as the
1997 * src/modest-tny-folder.[h|c]: Added
1998 modest_tny_folder_is_memory_card_folder().
1999 * src/modest-ui-dimming-rules.c:
2000 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2001 menu item for memory cards, as per the UI spec (section 7.4). This should
2002 fix projects.maemo.org bug NB#59297.
2004 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2006 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2007 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2008 is another problem with the code, see Murray's comment at line 772)
2010 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2012 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2013 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2014 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2015 (load_from_file), (easysetup_country_combo_box_init),
2016 (easysetup_country_combo_box_get_active_country_ids),
2017 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2018 instead of just one ID, to avoid duplicate country names in the UI.
2020 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2021 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2022 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2023 a single ID, avoiding duplicate providers.
2024 * src/maemo/easysetup/modest-easysetup-wizard.c:
2025 (on_combo_account_country): Adapt to use a list.
2027 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2029 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2030 keys changed in the last X seconds.
2032 * src/modest-account-mgr.h:
2033 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2034 (on_key_change), (modest_account_mgr_class_init),
2035 (modest_account_mgr_init), (modest_account_mgr_finalize):
2036 As the keys are changed, save them in a GSList* and signal that GSList*
2037 further every X seconds, to batch changes, to allow us to do just one
2038 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2039 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2041 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2042 changed signal signature.
2044 * src/modest-conf.c: (modest_conf_set_list),
2045 (modest_conf_on_change): Reenable notification.
2047 (modest_conf_maemo_fake_on_change): Comment out the hack that
2048 notified immediately instead of asynchronously.
2050 * src/widgets/modest-account-view.h:
2051 * src/widgets/modest-account-view.c:
2052 (update_account_view): Select the previously-selected account ID,
2053 if possible. This fixes projects.maemo.org bug NB#56933.
2055 (on_account_changed), (on_account_removed),
2056 (modest_account_view_select_account):
2058 Remove the block/unblock functions
2059 because they were not useful.
2061 * src/maemo/modest-account-view-window.c:
2062 (on_delete_button_clicked), (on_edit_button_clicked),
2063 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2065 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2067 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2068 Improve the error dialog to show Incorrect Account Settings, which seems
2069 clearer, and say that the internal error message (to be removed from the
2070 dialog later) is often misleading.
2071 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2073 * src/modest-tny-account.c:
2074 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2075 URL because this is so useful for debugging on the device.
2077 * src/widgets/modest-serversecurity-combo-box.c:
2078 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2080 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2082 * src/modest-mail-operation.c:
2083 (modest_mail_operation_send_new_mail):
2084 Added a comment about a nasty but apparently harmless message. Details
2085 added to the wiki g_warnings() page.
2087 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2089 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2090 (modest_tny_send_queue_class_init):
2091 Do not use the priv struct because it is empty, to avoid g_warnings
2092 about a non-existant priv struct.
2094 * src/modest-tny-account-store.c:
2095 (modest_tny_account_store_get_server_account),
2096 (modest_tny_account_store_get_transport_account_for_open_connection
2097 ): Do not try to get transport server accounts for local folders,
2098 because they don't have any. This avoids a g_warning().
2100 * src/maemo/modest-main-window.c:
2101 (modest_main_window_notify_send_receive_initied),
2102 (on_configuration_key_changed):
2103 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2104 * src/modest-defs.h:
2105 * src/modest-mail-operation.c:
2106 (modest_mail_operation_update_account):
2107 * src/modest-tny-account-store.h:
2108 * src/modest-tny-account.c:
2109 (modest_tny_account_get_special_folder),
2110 (modest_tny_account_new_for_local_folders),
2111 (modest_tny_account_new_for_per_account_local_outbox_folder):
2112 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2113 * src/modest-tny-local-folders-account.c:
2114 (add_account_folders_to_merged_folder):
2115 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2116 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2117 (modest_ui_actions_on_send):
2118 * src/widgets/modest-folder-view.c: (update_model):
2119 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2120 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2121 modest_tny_account_store_get_tny_account_by_account() to
2122 modest_tny_account_store_get_server_account() to make the code clearer.
2124 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2126 * src/dbus_api/modest-dbus-api.h:
2127 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2128 * src/maemo/modest-msg-edit-window.c:
2129 (modest_msg_edit_window_attach_file_noninteractive):
2130 added g_warning in case the file to be attached does not exist
2131 * tests/dbus_api/test_compose_mail.c: (main):
2132 removed obsolete comment, added generic files as test case
2134 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2136 * src/modest-tny-account-store.c: (get_server_accounts):
2137 Create the local folders account only once, not once for each outbox, and
2138 not only when there are some outboxes.
2140 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2142 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2143 code that is causing a crash at startup. Sergio says that he is fixing this.
2145 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2147 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2148 * src/maemo/modest-account-settings-dialog.c:
2149 (create_page_outgoing),
2150 (modest_account_settings_dialog_set_account_name),
2151 (save_configuration):
2152 - Fixed handling of the "Use secure authentication" toggle to comply with
2153 the ui specification. See also projects.maemo.org bug NB#58400
2155 - Restore the Secure connection setting combo correctly when loading
2158 * src/maemo/modest-maemo-utils.c:
2159 (on_camel_account_get_supported_secure_authentication),
2160 (modest_maemo_utils_get_supported_secure_authentication_methods):
2161 Fixed a crasher if operation is canceled
2163 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2164 (modest_protocol_info_auth_is_secure):
2165 * src/modest-protocol-info.h:
2167 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2168 the sense of the "Use secure authentication" toggle.
2170 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2172 * src/modest-tny-account-store.h:
2173 * src/modest-tny-account-store.c:
2174 Added modest_tny_account_store_get_local_folders_account().
2176 * src/modest-tny-folder.h:
2177 * src/modest-tny-folder.c:
2178 (modest_tny_folder_get_account):
2179 Added this replacement for tny_folder_get_account() which returns
2180 the local-folders account for TnyMergeFolders, to avoid the
2181 warning about the unimplemented get_account_func() vfunc().
2183 (modest_tny_folder_get_rules),
2184 * src/modest-ui-actions.c:
2185 (modest_ui_actions_on_folder_selection_changed):
2186 * src/modest-mail-operation.c:
2187 (modest_mail_operation_remove_folder),
2188 (modest_mail_operation_xfer_folder),
2189 (modest_mail_operation_rename_folder),
2190 (modest_mail_operation_get_msg),
2191 (modest_mail_operation_get_msgs_full),
2192 (modest_mail_operation_remove_msg),
2193 (modest_mail_operation_xfer_msgs),
2194 (modest_mail_operation_refresh_folder):
2195 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2197 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2199 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2200 (modest_server_account_set_security):
2201 * src/modest-defs.h: Add comments explaining that our
2202 UI spec means TLS when it says Normal, so these do not look like errors.
2204 * src/modest-tny-account.c:
2205 (modest_tny_account_new_from_server_account): Use the new tinymail
2206 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2207 for TLS. This should fix projects.maemo.org bug NB#58460.
2209 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2211 * src/maemo/easysetup/modest-easysetup-wizard.c:
2212 (create_account): Correct the position of the gconf sanity check warning.
2213 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2214 of using the g_idle_add() hack, because this does not seem to be necessary
2215 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2216 caused by something other than maemo's gconf.
2217 This fixes projects.maemo.org bug #59022.
2219 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2221 * src/modest-account-mgr-helpers.c:
2222 (modest_account_mgr_get_default_account): Do not check that the account
2223 exists if there is no default account (NULL), to fix a runtime warning.
2225 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2227 * src/widgets/modest-folder-view.c: (update_model):
2228 Do not unref the treemodel before we have finished with it.
2229 This prevents a valgrind warning and an occasional crash at startup.
2231 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2233 * libmodest-dbus-client/libmodest-dbus-client.h:
2234 added libmodest_dbus_client_compose_mail()
2235 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2237 added functions needed for SendAsMail() functionality
2238 * src/maemo/modest-msg-edit-window.c:
2239 (modest_msg_edit_window_attach_file_noninteractive):
2240 non interactively attaching files to message edit window
2241 * src/widgets/modest-msg-edit-window.h:
2242 * tests/dbus_api/Makefile.am:
2243 added test_compose_mail.c
2244 * tests/dbus_api/test_compose_mail.c: (main):
2246 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2248 * src/modest-account-view.c:
2249 Fixed bug projects.maemo.org bug NB#59307
2251 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2253 * src/maemo/easysetup/modest-easysetup-wizard.c:
2254 (get_serverport_incoming), (on_before_next), (create_account):
2255 * src/maemo/modest-account-settings-dialog.c:
2256 (modest_account_settings_dialog_set_account_name):
2257 * src/maemo/modest-maemo-utils.c:
2258 (on_camel_account_get_supported_secure_authentication_status),
2259 (on_camel_account_get_supported_secure_authentication),
2260 (on_secure_auth_cancel),
2261 (modest_maemo_utils_get_supported_secure_authentication_methods):
2263 Implemented security authentication for settings and easysetup.
2265 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2267 * src/maemo/modest-main-window.c: (create_details_widget):
2268 Show the total size for memory card accounts too, instead of showing
2269 the name again. Fixes bug projects.maemo.org bug NB#59307.
2271 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2274 * src/modest-tny-simple-folder-store.c:
2275 * src/modest-tny-simple-folder-store.h: Removed.
2277 * src/modest-tny-local-folders-account.h
2278 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2279 for the local-folders maildir, with an extra TnyMergedFolder containing
2280 the folders of the per-account outbox store accounts.
2281 * src/modest-tny-account-store.c: (get_server_accounts):
2282 Add the outboxes to the special local folders account after creating it.
2284 * src/modest-tny-account.c:
2285 (modest_tny_account_new_for_local_folders): Create the derived
2286 account when creating the main local-folders account.
2288 * src/maemo/modest-main-window.c: (create_details_widget),
2289 (modest_main_window_set_contents_style):
2290 Adapted to the use of the derived account instead of the folder store.
2292 * src/modest-ui-actions.c:
2293 (modest_ui_actions_on_folder_selection_changed):
2294 * src/modest-ui-dimming-rules.c:
2295 (modest_ui_dimming_rules_on_new_folder):
2296 * src/widgets/modest-folder-view.c: (text_cell_data),
2297 (icon_cell_data), (filter_row), (update_model),
2298 (get_cmp_rows_type_pos):
2301 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2302 Do not get the priv struct, because no priv struct has been set,
2303 to avoid a runtime warning.
2305 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2306 #ifelse with #else, to fix a warning, to fix the build.
2309 2007-06-05 Christian Kellner <ckellner@openismus.com>
2311 * libmodest-dbus-client/libmodest-dbus-client.c:
2312 Fix small typo in doc (why do you always see them
2313 AFTER committing stuff?)
2316 2007-06-05 Christian Kellner <ckellner@openismus.com>
2318 * libmodest-dbus-client/libmodest-dbus-client.c:
2319 (libmodest_dbus_client_search):
2320 Initialize hit list with NULL. Also set folder list
2321 to "" if NULL was supplied.
2324 2007-06-03 Christian Kellner <ckellner@openismus.com>
2326 * libmodest-dbus-client/libmodest-dbus-client.c:
2327 (modest_search_hit_list_free):
2328 Make it save to call it with NULL.
2330 * src/dbus_api/modest-dbus-callbacks.c:
2331 * src/modest-search.c:
2332 Return full ModestSearchHits as the search result list not TnyHeader
2333 since can't be around withouth the correspoding TnyFolder.
2335 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2337 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2338 Added currently commented code to check for secure auth
2340 * src/maemo/modest-account-settings-dialog.c: (on_response),
2341 (save_configuration), (show_ok):
2342 Fixed projects.maemo.org bugs NB #59248 and #59251
2344 * src/maemo/modest-maemo-utils.c:
2345 (on_camel_account_get_supported_secure_authentication_status),
2346 (on_camel_account_get_supported_secure_authentication),
2347 (modest_maemo_utils_get_supported_secure_authentication_methods):
2348 * src/maemo/modest-maemo-utils.h:
2349 Moved get_supported_secure_authentication() method here to be able
2350 to use it from easysetup wizard.
2352 * src/modest-pair.c: (on_pair_compare_as_string):
2353 Should compare string with first part of pair and not
2354 strcmp pairs which will crash.
2356 * src/modest-protocol-info.c:
2357 (modest_protocol_info_protocol_is_store):
2358 * src/modest-protocol-info.h:
2359 Added modest_protocol_info_get_auth_protocol_name()
2361 2007-06-03 Armin Burgmeier <armin@openismus.com>
2363 * src/modest-mail-operation.c:
2364 (modest_mail_operation_get_msgs_full): Set priv->account also when
2365 only retrieving a single message. This avoids a crash when canceling
2368 (modest_mail_operation_notify_end): Do not explicitely remove the
2369 operation from the queue but only emit the progress_changed signal.
2370 The queue itself listens to that signal to remove the operation when
2371 it is finished. This reduces coupling and removes a potential deadlock
2372 when modest_mail_operation_notify_end() is called from the queue
2373 itself. If that is a problem performance-wise, I would suggest to
2374 implement a status-changed signal or something.
2376 * src/modest-mail-operation-queue.c: Make sure to never call a
2377 function from another file while the queue is locked. This (hopefully)
2378 fixes another deadlock when exiting the application while retrieving
2381 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2383 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2384 Fixed build if libogs is not available
2386 2007-06-03 Christian Kellner <ckellner@openismus.com>
2388 * libmodest-dbus-client/libmodest-dbus-client.h:
2389 * libmodest-dbus-client/libmodest-dbus-client.c:
2390 (libmodest_dbus_client_delete_message):
2391 Implement deletion of messages (Client side).
2393 (modest_search_hit_free),
2394 (modest_search_hit_list_free):
2395 Utility functions to free the result hits.
2397 * src/dbus_api/modest-dbus-api.h:
2398 * src/dbus_api/modest-dbus-callbacks.c:
2399 (on_delete_message),
2400 (modest_dbus_req_handler):
2401 Implement deletion of messages (Server side).
2403 * tests/dbus_api/test_search.c: (main):
2406 * tests/dbus_api/Makefile.am:
2407 * tests/dbus_api/test_delete_message:
2408 Add little test for the message deletion logic
2410 2007-06-03 Armin Burgmeier <armin@openismus.com>
2412 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2413 when the operation queue was not empty. projects.maemo.org bug
2416 2007-06-03 Armin Burgmeier <armin@openismus.com>
2418 * src/widgets/modest-account-view.c
2419 (on_account_default_toggled): Toggle default account column
2420 explicitely instead of waiting for gconf notification (which is
2421 currently ignored). This should fix projects.maemo.org bug NB#56910
2422 for now. It should probably be removed when gconf notifications are
2425 2007-06-03 Christian Kellner <ckellner@openismus.com>
2427 * libmodest-dbus-client/libmodest-dbus-client.c:
2428 Removed debugging spew.
2430 * src/dbus_api/modest-dbus-callbacks.c:
2431 Added debugging info.
2433 * src/modest-search.c:
2434 (modest_search_all_accounts):
2435 Use tny_account_store_get_accounts () on the account store
2436 to get all accounts which is the way to get all accounts.
2438 * tests/dbus_api/test_search.c: (main):
2439 Make it possible to supply the search term on the command line.
2441 2007-06-03 Christian Kellner <ckellner@openismus.com>
2443 * libmodest-dbus-client/libmodest-dbus-client.c:
2444 * libmodest-dbus-client/libmodest-dbus-client.h:
2445 Implement searching for mesages over raw dbus. (Client side)
2447 * src/dbus_api/Makefile.am:
2448 * src/dbus_api/modest-dbus-api.h:
2449 * src/dbus_api/modest-dbus-callbacks.c:
2450 * src/dbus_api/modest-dbus-callbacks.h:
2451 Search framework (Server side). Also implement on_idle_open_message().
2453 * src/maemo/modest-platform.c: (modest_platform_init):
2454 Prepare for raw dbus/osso rpc interaction.
2456 * src/modest-search.h:
2457 Changed minsize from unspecific guint to guint32.
2459 * src/modest-search.c:
2461 Added strange hack which magically made tnymail work.
2463 (modest_search_folder),
2464 (modest_search_account),
2465 (modest_search_all_accounts):
2466 Implement helper functions to search all accounts, specific account
2469 * tests/dbus_api/Makefile.am:
2470 * tests/dbus_api/test_open_message.c:
2471 Read url to open from commandline.
2473 * tests/dbus_api/test_search.c:
2474 Implement small test for dbus search stuff
2476 2007-06-02 Armin Burgmeier <armin@openismus.com>
2478 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2479 include account type and account title. This fixes projects.maemo.org
2482 * src/maemo/modest-account-view-window.c: Set a title for the window.
2484 2007-06-02 Armin Burgmeier <armin@openismus.com>
2486 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2487 incoming and outgoing server name based on email address and server
2488 types as long as the names have not been edited manually. This fixes
2489 projects.maemo.org bug NB#58671.
2491 2007-06-02 Armin Burgmeier <armin@openismus.com>
2493 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2494 server type cannot be changed in future to the incoming details page
2495 when creating an account. This fixes projects.maemo.org bug NB#59029.
2497 2007-06-02 Armin Burgmeier <armin@openismus.com>
2499 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2500 and assigned max width chars so that they wrap instead of being
2501 truncated. Fixes projects.maemo.org bug NB#56126.
2503 2007-06-02 Armin Burgmeier <armin@openismus.com>
2505 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2506 introductory note to the connection specific smtp servers dialog, as
2507 section 8.12 of the email UI specification requires. This fixes
2508 projects.maemo.org bug NB#59212.
2510 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2512 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2513 Check for running mail operations, and offer to cancel them, as per the UI
2514 spec. This fixes projects.maemo.org bug NB#59041 .
2515 However, I suspect that tinymail may still use the network connection
2516 in ways that we cannot detect or cancel. But it should at least adapt to
2517 changes fairly well.
2519 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2521 * src/modest-tny-account-store.c: (recreate_all_accounts),
2522 (get_cached_accounts), (get_server_accounts): Do more sensible
2523 ref-counting of the temporarily-cached outbox accounts list. This seems
2524 to fix a crash when entering the password when the password was wrong.
2526 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2528 * src/gnome/modest-main-window.c: (connect_signals):
2529 * src/modest-tny-account-store.c: (get_password),
2530 (modest_tny_account_store_alert): Added comments and clues and
2531 commented-out code about how we currently fail to deal with connection
2532 errors and wrong passwords, and how we should.
2534 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2536 * src/widgets/modest-retrieve-combo-box.c:
2537 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2538 This fixes projects.maemo.org bug NB#58472 .
2540 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2542 * src/maemo/easysetup/modest-easysetup-wizard.c:
2543 (create_page_complete_easysetup):
2544 (create_page_complete_custom): Correct the last commit,
2545 putting the correct sentences in the correct pages.
2547 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2549 * src/maemo/easysetup/modest-easysetup-wizard.c:
2550 (create_page_complete_custom): Show the second sentence of text
2551 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2554 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2556 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2557 Set the leave-on-server conf key by default. This fixes
2558 projects.maemo.org bug NB#59258 .
2560 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2562 * src/maemo/modest-account-view-window.c:
2563 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2564 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2567 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2569 * src/maemo/easysetup/modest-easysetup-wizard.c:
2570 (create_caption_new_with_asterisk):
2571 * src/maemo/modest-account-settings-dialog.c:
2572 (create_caption_new_with_asterisk):
2573 Uncomment the code to add the asterisk, because they are no longer in the
2574 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2575 (update_incoming_server_title): Add an asterisk here too.
2577 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2579 * src/maemo/modest-maemo-global-settings-dialog.c:
2580 (current_connection): Check that we are even connected before trying to
2581 get the current connection name, to prevent a warning.
2583 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2584 Change the comments because tny_maemo_conic_device_connect() is now meant to
2586 * src/modest-mail-operation.c:
2587 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2588 make sure we have a connection and fail if we can't connect.
2590 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2592 * src/maemo/modest-main-window.c:
2593 (on_account_store_connecting_finished): Do not try to get the
2594 connection ID if we are not really connected. I am surprised that
2595 this signal handler is called when we are not connected.
2597 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2599 * src/modest-error.h:
2600 * src/modest-ui-actions.c:
2601 (modest_ui_actions_get_msgs_full_error_handler):
2602 Renamed an enum, added comments, added an enum
2603 for retrieve-limit errors.
2605 * src/modest-mail-operation.c: (foreach_add_item),
2606 (internal_folder_observer_update), (update_account_thread),
2607 (modest_mail_operation_get_msgs_full):
2608 (modest_mail_operation_update_account),
2609 Added comments about how this works, and some code that should
2610 (but does not) check the retrieve-limit. See the TODO comment.
2612 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2614 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2615 Initialize help_id to fix the build. Warnings are good.
2617 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2619 * src/widgets/modest-hbox-cell-renderer.c:
2620 (modest_hbox_cell_renderer_append):
2621 * src/widgets/modest-vbox-cell-renderer.c:
2622 (modest_vbox_cell_renderer_append):
2623 Fix the last commit by doing an extra ref.
2625 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2627 * src/widgets/modest-hbox-cell-renderer.c:
2628 (modest_hbox_cell_renderer_append):
2629 * src/widgets/modest-vbox-cell-renderer.c:
2630 (modest_vbox_cell_renderer_append):
2631 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2632 to fix the build with Maemo Bora.
2633 However, there seems to be a remaining crash, probably due to reference
2636 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2638 * src/modest-tny-account.c:
2639 (modest_tny_account_new_for_local_folders):
2640 Use hildon_file_system_info_async_new() to get a better name for
2641 the memory card account, setting it as the account name.
2642 The timing seems to work, but this is probably
2643 not the best place to do this. See the TODO comment.
2644 * src/maemo/modest-main-window.c: (create_details_widget):
2645 * src/widgets/modest-folder-view.c: (text_cell_data):
2646 Use the tny account name instead of hardcoding a name.
2648 2007-05-30 Christian Kellner <ckellner@openismus.com>
2650 * src/modest-search.c: (modest_search):
2651 Correctly set part_search_func even if we have already parsed
2652 the query and thus a valid OgsTextSearcher object.
2654 2007-05-30 Christian Kellner <ckellner@openismus.com>
2657 Search and check for libogs.
2660 Incooparte the ogs build env.
2662 * src/modest-mime-part-search-stream.c:
2663 * src/modest-mime-part-search-stream.h:
2664 Removed since we do the real searching now in modest-search.c.
2666 * src/modest-search.c:
2667 * src/modest-search.h:
2668 Implement support for ogs. We use that if available and requested
2669 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2670 should now handle the corner case when the search term is spread
2671 across multiple reads.
2672 Also the logic in modest_search () was corrected to search all
2673 requested fields until one is found.
2675 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2677 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2679 * src/modest-init.h:
2680 * src/modest-init.c: Made modest_init_local_folders() take a
2681 path and be public so we can iniitialize maildir folders on
2684 * src/modest-local-folder-info.h:
2685 * src/modest-local-folder-info.c:
2686 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2688 * src/modest-tny-account.c:
2689 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2690 still means the standard local-folders path on the local volume.
2692 * src/modest-tny-account-store.c:
2693 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2694 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2695 all accounts when that happens.
2696 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2697 this too, so it shows up in the treeview.
2699 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2701 * src/maemo/modest-maemo-global-settings-dialog.c:
2702 (current_connection):
2703 * src/widgets/modest-global-settings-dialog.c:
2704 (current_connection_default):
2705 Use the enum values instead of 0, 1 and -1,
2706 to make the code clearer.
2708 * src/modest-account-mgr-helpers.c:
2709 (modest_account_mgr_get_connection_specific_smtp): Make this code
2712 * src/modest-runtime.h:
2713 * src/modest-runtime.c:
2714 Added modest_runtime_remove_all_send_queues().
2715 * src/maemo/modest-main-window.c:
2716 (on_account_store_connecting_finished): Recreate the send queues,
2717 using the appropriate transport accounts for this new connection.
2718 Some futher adapting might be needed if the old send queues are not
2719 automatically stopped at this point.
2721 * src/modest-tny-account-store.c: (get_server_accounts):
2722 Create the connection-specific transport accounts, so that they can
2723 be found later by their ID.
2725 * src/modest-tny-account.h:
2726 * src/modest-tny-account.c:
2727 Added modest_tny_account_new_from_server_account_name().
2728 modest_tny_account_new_from_server_account(): Do not create the
2729 send queues here, because they will be
2730 recreated anyway when the connection changes for the first time.
2732 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2734 * src/modest-local-folder-info.h:
2735 * src/modest-local-folder-info.c:
2736 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2737 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2738 tbox_folder): Take a modest account name instead of a server TnyAccount,
2739 so we can have per-modest-account rather than per-transport-account
2741 We must make sure that we change or recreate the exisitng send queues
2742 when the connection changes for connection-specific transport accounts.
2744 * src/modest-tny-account-store.c:
2745 (create_per_account_local_outbox_folders): Create outboxed per modest
2746 account, not per transport account.
2748 * src/modest-tny-account.h:
2749 * src/modest-tny-account.c:
2750 (modest_tny_account_get_special_folder): For outboxes, get the
2751 parent modest account name. The account is ignored for other folders.
2752 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2753 modest account name rather than a server TnyAccount.
2755 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2757 * src/modest-tny-account.c:
2758 (modest_tny_account_new_from_server_account):
2759 Call modest_runtime_get_send_queue() immediately after creating transport
2760 accounts, so that they start trying to send email from the outbox as soon
2761 as possible at startup. This is probably what we want.
2763 * src/modest-mail-operation.c: (update_account_thread):
2764 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2765 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2766 * src/modest-tny-send-queue.h:
2767 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2768 (modest_ui_actions_on_send):
2769 Added comments about how sending works, though it needs some more work.
2771 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2773 * src/modest-tny-account.c:
2774 (modest_tny_account_get_special_folder): Add TODO because this fails when
2775 the network is busy.
2776 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2777 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2778 Do not try to show this window when there is no active account. The UI
2779 specs does not tell us what to do in this case.
2781 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2785 * src/maemo/Makefile.am:
2786 * src/widgets/Makefile.am: Some dist fixes.
2788 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2790 * src/maemo/modest-connection-specific-smtp-window.c:
2791 (on_button_edit): Make the code clearer, to prevent a double free.
2793 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2795 * src/maemo/modest-account-settings-dialog.c:
2796 (modest_account_settings_dialog_set_account_name),
2797 Check the connection-specific smtp servers checkbox if there are any.
2799 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2800 (modest_connection_specific_smtp_edit_window_init):
2801 Start with a suitable port number.
2803 * src/modest-account-mgr-helpers.h:
2804 * src/modest-account-mgr-helpers.c: Added
2805 modest_account_mgr_get_has_connection_specific_smtp().
2807 (modest_account_mgr_set_connection_specific_smtp),
2808 (modest_account_mgr_remove_connection_specific_smtp),
2809 (modest_account_mgr_get_has_connection_specific_smtp),
2810 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2811 connection-specific smtp server accounts in the account, rather than
2812 the server account conf dir.
2814 This fixes bug projects.maemo.org bug NB#58263 .
2816 * src/modest-tny-account-store.c:
2817 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2818 if there are no server accounts yet, to prevent an infinite loop when there
2819 are no accounts. Document that one must be called before the other.
2821 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2823 * src/modest-account-mgr-helpers.c:
2824 (modest_account_mgr_get_default_account): Make sure that at least
2825 one account is always the default, if there are any enabled accounts.
2826 This is just a sanity check that shouldn't be necessary.
2828 * src/modest-account-mgr-priv.c:
2829 (_modest_account_mgr_account_from_key): Unescape the conf key to
2830 get the real account name. For instance, this is an issue if a space
2831 was in the account name, which can happen because the account name
2832 is generated from the display name.
2833 (_modest_account_mgr_get_account_keyname): Always escape the
2835 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2836 Unescape the conf keys to get the real account names.
2838 For instance, previously the is-default radio button in the accounts
2839 list was not checked for any accounts at first. This fixes that,
2840 and might fix several similar bugs.
2842 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2844 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2845 Removed some debug printfs.
2847 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2849 Modest on-disk outbox directories are now here, for instance:
2850 $HOME/.modest/outboxes/<account-id-1>/outbox
2851 $HOME/.modest/outboxes/<account-id-2>/outbox
2853 $HOME/.modest/local-folders/outbox
2854 so we can have a separate outbox for each account.
2855 But they are shown as one outbox in the GtkTreeView, by using a
2856 TnyMergeFolder in a ModestTnySimpleFolderStore.
2859 * src/modest-tny-simple-folder-store.c:
2860 * src/modest-tny-simple-folder-store.h:
2861 Added ModestTnySimpleFolderStore, used to contain folders from
2862 other folder stores, such as other accounts.
2864 * src/modest-tny-outbox-account.h:
2865 * src/modest-tny-outbox-account.c:
2866 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2867 used for the per-account local outbox folders.
2869 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2870 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2871 only use this (internally) now for the non-outbox local folders.
2873 * src/modest-init.h:
2874 * src/modest-init.c: Added modest_init_one_local_folder(), for
2875 setting up the directory structure for each local folder.
2877 * src/modest-local-folder-info.c:
2878 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2879 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2881 * src/modest-local-folder-info.h:
2882 * src/modest-tny-account-store.c: (on_account_removed),
2883 (on_account_changed), (create_per_account_local_outbox_folders),
2884 (get_server_accounts), (modest_tny_account_store_get_accounts),
2885 (modest_tny_account_store_get_tny_account_by_account),
2886 (modest_tny_folder_store_is_virtual_local_folders):
2888 * src/modest-tny-account.h:
2889 * src/modest-tny-account.c:
2890 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2891 to create an on-disk per-account local outbox folder for each
2893 (create_per_account_local_outbox_folders): Create a local outbox folder
2894 for each transport account.
2895 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2896 for all local folders.
2898 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2899 instead of using g_object_get/set() directly. It is clearer.
2901 (modest_tny_folder_store_get_message_count),
2902 (modest_tny_folder_store_get_local_size
2903 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2904 because we now use these with non-acount folder stores.
2906 (modest_tny_account_get_special_folder),
2907 (modest_tny_account_new_from_server_account),
2908 (modest_tny_account_new_from_account):
2909 (recurse_folders): Adjust to the new outbox system.
2911 * src/modest-tny-folder.h:
2912 * src/modest-tny-folder.c:
2913 (modest_tny_folder_is_local_folder),
2914 (modest_tny_folder_get_local_folder_type),
2915 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2917 * src/widgets/modest-main-window.h:
2918 * src/maemo/modest-main-window.c: (create_details_widget),
2919 (modest_main_window_set_contents_style): Show details for any folder store,
2922 (modest_tny_folder_get_rules):
2923 Remove the const. C does not support constness enough for this.
2925 * src/modest-ui-actions.c:
2926 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2927 make all outboxes appear as one, in the usual local-folders tree node.
2929 (set_active_account_from_tny_account),
2930 (modest_ui_actions_on_folder_selection_changed):
2931 * src/widgets/modest-folder-view.c: (text_cell_data),
2932 (icon_cell_data), (filter_row),
2933 (add_account_folders_to_merged_folder),
2934 (add_account_folders_to_simple_folder_store), (),
2935 (get_cmp_rows_type_pos), (cmp_rows),
2936 (modest_folder_view_set_account_id_of_visible_server_account):
2937 Adjust to the new outbox system, using generic folder stores and folders
2938 in the GtkTreeModel.
2940 2007-05-23 Christian Kellner <ckellner@openismus.com>
2942 * src/modest-mail-operation.c:
2943 (modest_mail_operation_update_account):
2944 Use info->max_size instead of unintialized local var [small
2945 build fix]. (Added TODO to review that change since I don't
2948 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2950 * libmodest-dbus-client/libmodest-dbus-client.c:
2951 (libmodest_dbus_client_compose_mail): function added
2952 * src/dbus_api/modest-dbus-api.h:
2953 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2954 (on_compose_mail): Implementation of the SendAsMail functionality
2956 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2958 * src/modest-account-mgr.c:
2959 (modest_account_mgr_add_server_account): Set the secure-connection
2960 conf key for transport accounts as well as store accounts. I don't know
2961 why the if was there. For instance, this makes sure that we use SSL
2962 for the gmail preset from the easysetup wizard.
2964 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2966 * src/gnome/modest-main-window.c:
2967 (on_account_store_connecting_finished), (connect_signals):
2968 * src/maemo/modest-main-window.c:
2969 (on_account_store_connecting_finished), (connect_signals),
2970 (modest_main_window_new):
2971 Handle TnyAccountStore::connecting-finished instead of
2972 TnyDevice::connection-changed, because we cannot actually perform
2973 operations on accounts until TnyAccountStore has itself responded to
2974 the TnyDevice::connection-changed signal. This prevents a GError from
2976 Do not try to update at startup, because we (at least on scratchbox)
2977 already do an update at startup when the device goes online.
2978 This prevents a GError from tinymail.
2979 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2980 Added TODO about stopping simultaneous operations.
2982 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2984 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2985 * src/modest-mail-operation-queue.c:
2986 (modest_mail_operation_queue_remove):
2987 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2988 about where they happened.
2990 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2992 * src/modest-ui-actions.c:
2993 (modest_ui_actions_on_password_requested): Make sure that the remember
2994 output parameter is always TRUE.
2996 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2998 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2999 Show a OK/Cancel dialog if the error is a question, though we still do not
3000 know anything more about what we are asking the user.
3001 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3002 Fix an uninitialized variable (helper). This is a logic error, however.
3004 2007-05-21 Christian Kellner <ckellner@openismus.com>
3006 * src/modest-search.h:
3007 Correct bit shifting in the ModestSearchFlags enum.
3009 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3011 * src/modest-tny-account.c:
3012 (modest_tny_account_new_from_server_account): Do not use the lsub and
3013 check-all hard-coded IMAP options when using POP.
3015 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3017 * src/modest-tny-account.c:
3018 (modest_tny_account_new_from_server_account):
3019 Use NULL for the secure-auth method for POP when Password auth has been
3020 specified by the user, as we already do for IMAP. "auth=Login" causes
3021 an error from camel or the server.
3023 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3025 * src/maemo/modest-account-settings-dialog.c:
3026 (create_page_account_details),
3027 (modest_account_settings_dialog_set_account_name):
3028 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3029 for the leave-on-server checkbox, rathr than just the checkbox, when
3030 the protocol is not POP.
3032 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3034 * src/widgets/modest-account-view.c:
3035 * src/widgets/modest-account-view.h:
3036 Added modest_account_view_select_account() which will be useful later
3037 to asynchronously re-select the edited account.
3039 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3041 * src/maemo/modest-account-settings-dialog.c:
3042 (modest_account_settings_dialog_set_account_name):
3043 Automatically choose the port numbers based on the secure authentication
3044 methods, if they have not been chosen before.
3045 This fixes projects.maemo.org bug NB#56273 .
3047 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3049 * src/maemo/modest-main-window-ui.h:
3050 * src/modest-ui-actions.c:
3051 * src/modest-ui-actions.h:
3052 Connect the Tools/SMTP Servers menu item to
3053 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3054 SMTP servers dialog, as in the UI specification and saves changes when it
3055 is closed. This fixed projects.maemo.org bug NB#56305 .
3057 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3059 * src/maemo/modest-connection-specific-smtp-window.c:
3060 (modest_connection_specific_smtp_window_init):
3061 Use gtk_window_set_default_size() to make this window big enough, so
3062 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3064 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3066 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3067 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3068 (modest_connection_specific_smtp_edit_window_init),
3069 Do not try to connect to a combobox signal before the combobox exists.
3070 This fixes the cras in projects.maemo.org bug NB#56288 .
3071 (modest_connection_specific_smtp_edit_window_get_settings):
3072 Remove the server_account_name parameter which was being checked for NULL
3073 though it was not used.
3075 * src/maemo/modest-connection-specific-smtp-window.c:
3076 (modest_connection_specific_smtp_window_fill_with_connections),
3077 (on_button_edit), (modest_connection_specific_smtp_window_init):
3078 Correct the number of treemodel columns to prevent a warning.
3079 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3080 libconic does not work.
3082 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3084 * src/modest-tny-account.c:
3085 (modest_tny_account_new_from_server_account):
3086 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3087 SMTP when "None" was chosen by the user. However, with my SMTP server that
3088 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3091 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3093 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3094 to explain the memory management issue with the ID in the ModestPair.
3096 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3097 (add_sending_page), (modest_account_assistant_finalize):
3098 * src/gnome/modest-gnome-global-settings-dialog.c:
3099 (create_updating_page), (create_composing_page):
3100 * src/gnome/modest-msg-edit-window.c: (get_transports),
3101 (init_window), (modest_msg_edit_window_finalize),
3102 (modest_msg_edit_window_get_msg_data):
3103 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3104 * src/gnome/modest-transport-widget.c:
3105 (modest_transport_widget_finalize), (smtp_configuration):
3106 * src/maemo/modest-maemo-global-settings-dialog.c:
3107 (create_updating_page), (create_composing_page):
3108 * src/maemo/modest-msg-edit-window.c: (get_transports),
3109 (init_window), (modest_msg_edit_window_finalize),
3110 (modest_msg_edit_window_get_msg_data),
3111 (modest_msg_edit_window_free_msg_data):
3112 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3113 (modest_store_widget_finalize):
3114 * src/maemo/modest-transport-widget.c:
3115 (modest_transport_widget_finalize), (smtp_configuration):
3116 * src/modest-main.c: (send_mail):
3117 * src/widgets/modest-combo-box.h:
3118 * src/widgets/modest-global-settings-dialog-priv.h:
3119 * src/widgets/modest-global-settings-dialog.c:
3120 (modest_global_settings_dialog_finalize):
3121 * src/widgets/modest-msg-edit-window.h:
3122 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3123 as long as the combo box, to prevent use of freed memory for the ID.
3125 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3127 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3128 get_accounts(), to make this clearer. Do not check for the enabled gconf
3129 key, because we do not use this for server accounts (at least, not yet).
3130 This allows us to send email again.
3132 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3134 * src/maemo/modest-platform.c:
3135 (on_modest_conf_update_interval_changed), (modest_platform_init):
3136 Only respond to this particular key change. All these strcmp()s cannot be
3139 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3141 * src/maemo/modest-maemo-global-settings-dialog.c:
3142 (current_connection): Prevent a crash in scratchbox when
3143 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3144 * src/maemo/modest-platform.c:
3145 (on_modest_conf_update_interval_changed), (modest_platform_init):
3146 Get the update interval from gconf and reset it when the gconf key changes.
3148 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3150 * src/modest-protocol-info.c:
3151 * src/modest-protocol-info.h: Adde enum-specific get functions,
3152 instead of using a ModestProtocolType enum parameter.
3154 * src/gnome/modest-account-assistant.c:
3155 * src/gnome/modest-store-widget.c:
3156 * src/gnome/modest-store-widget.h:
3157 * src/gnome/modest-transport-widget.c:
3158 * src/gnome/modest-transport-widget.h:
3159 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3160 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3161 * src/maemo/easysetup/modest-easysetup-wizard.c:
3162 * src/maemo/modest-account-settings-dialog.c:
3163 * src/maemo/modest-account-settings-dialog.h:
3164 * src/maemo/modest-store-widget.c:
3165 * src/maemo/modest-store-widget.h:
3166 * src/maemo/modest-transport-widget.c:
3167 * src/maemo/modest-transport-widget.h:
3168 * src/modest-account-mgr-helpers.c:
3169 * src/modest-account-mgr-helpers.h:
3170 * src/modest-account-mgr.c:
3171 * src/modest-account-mgr.h:
3172 * src/modest-tny-account.c:
3173 * src/modest-tny-folder.c:
3174 * src/widgets/modest-account-view.c:
3175 * src/widgets/modest-retrieve-combo-box.c:
3176 * src/widgets/modest-retrieve-combo-box.h:
3177 * src/widgets/modest-secureauth-combo-box.c:
3178 * src/widgets/modest-serversecurity-combo-box.c:
3179 * src/widgets/modest-serversecurity-combo-box.h:
3180 * tests/check_account-mgr.c:
3181 Use the specific functions, and use the re-renamed enum values for GNOME too.
3183 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3185 * src/modest-pair.h:
3186 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3187 so we can get the second based on the first.
3189 * src/maemo/modest-account-settings-dialog.h:
3190 * src/maemo/modest-account-settings-dialog.c:
3191 Added get_supported_secure_authentication_methods(), though it is mostly
3192 commented-out for now until the necessary API is committed to tinymail.
3193 (modest_account_settings_dialog_set_account_name),
3194 (save_configuration): Request the supported authentication methods from the
3195 server, so we can choose a working method.
3197 * src/modest-tny-account-store.h:
3198 * src/modest-tny-account-store.c:
3199 (modest_tny_account_store_get_session): Rename from
3200 tny_account_store_get_session().
3202 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3204 * src/modest-protocol-info.h: Split the ModestProtocol enum
3205 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3206 There was no need to have these unrelated values in one enum.
3208 * src/: many files: Adapted to changed enum. This makes the code a bit
3209 clearer, and the compiler could catch some errors.
3211 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3213 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3214 Show the detailed internal camel error message when an error happens
3215 during the configuration, so that our testers can give us more clues.
3216 For instance, in projects.maemo.org bug NB#56910 .
3218 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3220 * src/modest-tny-account.c:
3221 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3222 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3224 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3226 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3227 * src/maemo/modest-account-settings-dialog.c:
3228 (modest_account_settings_dialog_set_account_name),
3229 (save_configuration): For the incoming secure authentication checkbox,
3230 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3231 the UI specification. PLAIN does not seem to be supported for most IMAP
3232 servers anyway, and I am not sure what it would mean.
3233 However, we probably need to discover which of the secure-authentication
3234 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3235 * src/modest-account-mgr-helpers.c:
3236 (modest_account_mgr_get_server_account_data):
3238 * src/modest-tny-account.c:
3239 (modest_tny_account_new_from_server_account):
3240 Use tny_account_set_mech() to set secure-authentication methods,
3241 with some special-casing for IMAP, based on my observations of how
3244 * src/modest-account-mgr-helpers.h:
3245 * src/modest-account-mgr.c:
3246 * src/modest-defs.h: Comment that the URI is only used for local folders.
3248 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3250 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3251 parameter const, just to be neat.
3252 * src/modest-text-utils.c: (modest_text_utils_inline):
3253 End g_strconcat() with NULL, as its documentation says. This is almost
3254 certainly the cause of my crash at startup on the device. Interestingly,
3255 valgrind doesn't tell us about these errors.
3257 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3259 * scripts/build-packages: Added more precise comments about how to use
3260 this script, though I still get this error:
3261 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3262 error building tinymail
3264 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3266 * src/maemo/modest-main-window.c: (on_account_update):
3267 Very slight cleanup, hoping to make it simpler to discover what causes
3268 a crash here sometimes.
3270 * src/modest-tny-account.c:
3271 (modest_tny_account_new_from_server_account): Set the port. Added
3272 comments about the options and a TODO comment because I need to find out
3273 how to specify the secure authentication method.
3275 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3277 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3278 changed CFlags paths form modest to libmodest
3280 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3282 * src/modest-account-mgr-helpers.c:
3283 (modest_account_mgr_get_server_account_data),
3284 (modest_account_mgr_free_server_account_data):
3285 * src/modest-account-mgr-helpers.h:
3286 * src/modest-account-mgr.c:
3287 (modest_account_mgr_add_server_account):
3288 * src/modest-defs.h:
3289 * src/modest-tny-account.c:
3290 (modest_tny_account_new_from_server_account):
3291 Determine the options for tny_camel_account_add_option() here,
3292 based on the settings, rather than storing them directly in gconf.
3294 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3296 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3297 Show a more friendly error dialog now that we expect (from the tinymail
3298 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3300 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3302 * src/maemo/modest-main-window.c: (on_account_update): Check that
3303 account_name is not NULL, to prevent a crash at startup that I am
3304 seeing on the N800. I do wonder why it is NULL.
3306 * src/maemo/easysetup/modest-easysetup-wizard.c:
3307 (create_page_user_details):
3308 * src/maemo/modest-account-settings-dialog.c:
3309 (create_page_user_details), (create_page_outgoing):
3310 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3311 (modest_connection_specific_smtp_edit_window_init):
3312 * src/modest-ui-actions.c:
3313 (modest_ui_actions_on_password_requested):
3314 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3315 might do something useful with the on-screen keyboard.
3317 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3319 * src/maemo/modest-main-window.c: (on_account_update):
3320 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3321 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3323 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3325 * src/modest-tny-account-store.c: (on_account_changed):
3326 Correct the signature of this signal handler.
3328 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3330 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3331 Show a HildonNote instead of a GtkDialog for Maemo.
3333 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3335 * src/widgets/modest-account-view.h:
3336 * src/widgets/modest-account-view.c: (on_account_changed),
3337 (on_account_removed). Added a boolean flag, set/unset by
3338 modest_account_view_block_conf_updates(),
3339 modest_account_view_unblock_conf_updates() to prevent unnecessary
3340 updates, but this is not very useful because the gconf notifications are
3341 so delays (maybe only on Maemo Bora).
3342 So auto-updating is turned off, and these functions do an explicit
3343 update when necessary.
3344 However, something else is still doing too much work when adding/removing
3345 accounts, probably in another part of the application.
3347 * src/maemo/modest-account-view-window.c:
3348 (on_delete_button_clicked), (on_edit_button_clicked),
3349 (on_new_button_clicked): Use the new functions.
3351 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3353 * src/modest-account-mgr-helpers.c:
3354 (modest_account_mgr_set_first_account_as_default):
3355 Sort the list of names alphabetically-by-title, so we choose the first one
3357 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3358 alphabetically by the title.
3360 This fixes projects.maemo.org bug NB#56418 .
3362 * src/modest-account-mgr-priv.c:
3363 (_modest_account_mgr_account_from_key):
3364 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3365 avoid a valgrind error, and possible random behaviour.
3367 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3369 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3370 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3371 tinymail documentation to say that this can be expected.
3372 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3373 pretty, and should not happen, but I would prefer to know when it does.
3375 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3377 * configure.ac: When using the older hildon version, probably on Bora,
3378 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3380 * src/widgets/modest-attachment-view.c:
3381 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3384 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3386 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3387 Implemented the prototype. Can be tested with
3388 tests/dbus_api/test_open_message:
3390 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3392 * src/modest-tny-account-store.c:
3393 (modest_tny_account_store_instance_init), (get_password):
3394 * src/modest-ui-actions.c:
3395 (modest_ui_actions_on_password_requested):
3396 Do not store the password in gconf, because this function is called
3397 for non-remembered passwords. Actually use the cached (in the hash map)
3398 password instead of releasing it.
3399 The password will now not be remembered if it is asked via the protected
3400 password dialog, as per the UI spec.
3402 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3404 * src/modest-defs.h:
3405 * src/modest-account-mgr-helpers.h:
3406 * src/modest-account-mgr-helpers.c:
3407 Added modest_server_account_get_username_has_succeeded(),
3408 modest_server_account_set_username_has_succeeded().
3409 (modest_server_account_set_username),
3410 Reset the has-succeeded flag if the username changes.
3412 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3413 * src/maemo/modest-connection-specific-smtp-window.c:
3414 (modest_connection_specific_smtp_window_save_server_accounts):
3415 Use modest_server_account_set_username() instead of using
3416 modest_conf_set_string() directly, so that the has-succeeded flag is always
3419 * src/modest-ui-actions.c:
3420 (modest_ui_actions_on_password_requested): Dim the username entry if
3421 the username has ever worked, as per the UI spec.
3423 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3425 * src/modest-tny-account-store.c: (get_password):
3426 * src/modest-ui-actions.c:
3427 (modest_ui_actions_on_password_requested):
3428 Allow the username to be changed too, though there is more work to
3429 be done on exactly how this behaves.
3431 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3433 * src/modest-account-mgr-helpers.h:
3434 * src/modest-account-mgr-helpers.c:
3435 Added modest_account_mgr_get_display_name(),
3436 modest_server_account_get_username(),
3437 modest_server_account_set_username(),
3438 modest_server_account_set_password(),
3439 modest_server_account_get_hostname() functions so we do not need to
3440 use the conf API directly.
3442 * src/maemo/modest-main-window.c: (connect_signals):
3443 Actually connect ot the ModestAccountStore::request-password signal,
3444 so that we show the dialog when the password is requested by Tinymail,
3445 for isntance if it is empty.
3447 * src/modest-marshal.list:
3448 * src/modest-tny-account-store.c:
3449 (modest_tny_account_store_class_init), (get_password),
3450 (modest_tny_account_store_alert):
3451 * src/modest-tny-account-store.h:
3452 * src/modest-ui-actions.h:
3453 * src/modest-ui-actions.c:
3454 (modest_ui_actions_on_password_requested):
3455 Change the signal parameters, so it is obvious that we are providing
3456 the non human-readable server name, and receiving both the username
3457 and password, though changing of the username is not yet implemented.
3458 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3459 for the GNOME version.
3461 This should fix the projects.maemo.org bug NB#56209, though it does not
3462 work on Bora, because the gconf_client_get() for the password fails
3463 immediately after we save it with gconf_client_set().
3465 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3468 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3469 caused an undefined symbol error:
3470 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3472 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3474 * src/modest-tny-account-store.c:
3475 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3476 using a GError instead of a string message, so we can translate it in
3479 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3481 * src/maemo/modest-address-book.c:
3482 (modest_address_book_check_names):
3483 * src/maemo/modest-msg-view-window.c:
3484 (modest_msg_view_window_clipboard_owner_change):
3485 * src/modest-init.c: (modest_init_init_ui):
3486 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3487 (update_folders_cb), (modest_mail_operation_update_account):
3488 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3489 (modest_ui_actions_on_msg_attachment_clicked),
3490 (modest_ui_actions_on_msg_recpt_activated):
3491 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3492 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3493 (modest_msg_view_search_next):
3494 * src/widgets/modest-recpt-editor.c:
3495 (modest_recpt_editor_on_button_release_event),
3496 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3497 g_message(). At this point we should only be seeing interesting errors on
3498 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3500 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3502 (modest_wizard_dialog_force_title_update):
3503 * src/maemo/easysetup/modest-wizard-dialog.h:
3504 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3505 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3506 can update the title when appropriate. Otherwise the title is wrong if the
3507 pages are added after adding the notebook to the dialog.
3508 This must be a problem in HildonWizardDialog too.
3509 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3511 * src/maemo/easysetup/modest-easysetup-wizard.c:
3512 (create_subsequent_customsetup_pages),
3513 (create_subsequent_easysetup_pages):
3514 Call modest_wizard_dialog_force_title_update() so that the title is
3515 correct even with GTK+ < 2.10.
3516 This fixes projects.maemo.org bug NB#56145 .
3518 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3520 * src/maemo/modest-platform.c:
3521 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3522 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3525 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3527 * src/widgets/modest-window.h:
3528 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3529 and modest_window_save_state(), which invokes it.
3531 * src/widgets/modest-window-mgr.h:
3532 * src/widgets/modest-window-mgr.c:
3533 Added modest_window_mgr_save_state_for_all_windows(), which calls
3534 the save_state vfunc on all registered windows, if implemented.
3536 * src/gnome/modest-msg-edit-window.c:
3537 * src/gnome/modest-msg-view-window.c:
3538 * src/maemo/modest-msg-edit-window.c:
3539 * src/maemo/modest-msg-view-window.c:
3540 * src/maemo/modest-main-window.c:
3541 Specify the existing save_settings functions as implementations of
3542 ModestWindow::save_state_func().
3544 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3545 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3546 enabling hibernation, for instance.
3548 We may need to do the same thing for restoring settings.
3551 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3553 * src/widgets/modest-window-mgr.c:
3554 * src/widgets/modest-window-mgr.h:
3555 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3556 modest_window_mgr_get_hibernation_is_prevented().
3558 * src/maemo/modest-main-window.c:
3559 (on_hildon_program_is_topmost_notify): Prevent hibernation
3560 (possible when the application goes to the background in the WM),
3561 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3563 * src/maemo/easysetup/modest-easysetup-wizard.c:
3564 (modest_easysetup_wizard_dialog_init):
3565 * src/maemo/modest-account-settings-dialog.c:
3566 (modest_account_settings_dialog_init):
3567 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3568 (modest_connection_specific_smtp_edit_window_init):
3569 * src/maemo/modest-connection-specific-smtp-window.c:
3570 (modest_connection_specific_smtp_window_init):
3571 * src/maemo/modest-signature-editor-dialog.c:
3572 (modest_signature_editor_dialog_init):
3573 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3574 prevent hibernation while any of these account settings dialogs are open.
3576 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3578 * src/maemo/Makefile.am:
3579 * src/maemo/modest-osso-state-saving.c:
3580 * src/maemo/modest-osso-state-saving.h: Added
3581 modest_osso_load_state() and modest_osso_save_state() though they do
3582 nothing now. They should iterate through all the open windows and load/save
3584 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3585 save state when closing.
3587 * src/maemo/modest-main-window.c:
3588 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3589 Add a notification handler for the HildonProgram::is-topmost property,
3590 so we can allow hibernation when the application goes into the background.
3591 But we still need to detect when the accounts setup windows are open so
3592 we can stop hibernation when they are open.
3593 To do this, I also added the main window the HildonProgram. This might have
3594 other side-effects/benefits, and should maybe be done for other windows.
3596 * src/maemo/modest-osso-autosave-callbacks.h:
3597 * src/maemo/modest-osso-autosave-callbacks.c:
3598 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3599 though it does not do anything yet, and we might never need this to do
3600 anything. For instance, we already save drafts.
3602 * src/maemo/modest-platform.c: (modest_platform_init):
3603 Specify the libosso auto-save callback.
3605 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3607 * src/maemo/modest-platform.c:
3608 (modest_platform_set_update_interval):
3609 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3610 aparently stays valid between application instances, so we can use this
3611 to remove and reset it later. According to a maemo-developers email from
3614 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3616 * configure.ac: Depend on libalarm for Maemo.
3618 * src/dbus_api/modest-dbus-api.h:
3619 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3620 (on_send_receive), (modest_dbus_req_handler):
3621 Handle a SEND_RECEIVE D-Bus method.
3623 * libmodest-dbus-client/libmodest-dbus-client.c:
3624 (libmodest_dbus_client_send_and_receive):
3625 * libmodest-dbus-client/libmodest-dbus-client.h:
3626 Add C convenience functions for calling the new D-Bus method.
3628 * src/modest-platform.h:
3629 * src/gnome/modest-platform.c:
3630 * src/maemo/modest-platform.c:
3631 Added modest_platform_set_update_interval(), which uses the
3632 alarmd API on Maemo.
3633 (modest_platform_init),
3634 Call modest_platform_set_update_interval(), using a hard-coded
3635 interval for now (until the global settings dialog is implemented),
3636 though I am not sure that this makes sense yet.
3638 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3640 * src/dbus_api/modest-dbus-callbacks.c:
3641 (modest_osso_cb_hw_state_handler):
3642 * src/dbus_api/modest-dbus-callbacks.h:
3643 * src/maemo/modest-platform.c: (modest_platform_init):
3644 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3645 in case this has some effect on the ability for Maemo to ping the
3648 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3650 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3651 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3652 warning. It is probably a logic error, but I need to fix the build.
3654 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3656 * src/modest-account-mgr.h:
3657 * src/modest-account-mgr.c:
3658 (modest_account_mgr_account_names): Add a gboolean enabled_only
3659 parameter, so we can get lists of onlt the enabled accounts.
3661 (modest_account_mgr_add_account),,
3662 (modest_account_mgr_account_with_display_name_exists):
3663 * src/maemo/modest-msg-edit-window.c: (get_transports):
3664 * src/modest-account-mgr-helpers.c:
3665 (modest_account_mgr_set_first_account_as_default):
3666 * src/modest-init.c: (init_default_account_maybe):
3667 * src/modest-tny-account-store.c: (get_accounts):
3668 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3669 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3670 * tests/check_account-mgr.c: (START_TEST):
3671 Provide the extra parameter, as appropriate.
3673 * src/widgets/modest-account-view.c: (update_account_view):
3674 Do not show disabled accounts (meaning that there is no way to
3675 enable/disable accounts in the UI (the feature is not in our UI
3676 specification), so we can use this internally only to mark unfinished
3677 or temporary account data.
3679 * src/maemo/easysetup/modest-easysetup-wizard.c:
3680 (create_account): Add boolean enable parameter, so we can specify FALSE
3681 to create the temporary account.
3682 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3683 (on_before_next): When finishing, when there is a temporary account, just
3685 Also, use a timeout to delay the showing of the dialog until gconf is likely
3686 to return correct information, due to a maemo gconf bug that is fixed in
3687 osso 1.1, but not yet in Bora.
3688 However, the dialog stays on screen after it is destroyed.
3690 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3691 for invalid data when cancelling. Use a hildon note instead of a dialog
3692 to complain about invalid data. Do not show the account-saved note if the
3693 account is disabled (a temporary account that will not really be saved for use
3696 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3698 * src/modest-account-mgr-helpers.h:
3699 * src/modest-account-mgr-helpers.c:
3700 Added modest_account_mgr_unset_default_account(),
3701 Added modest_account_mgr_set_first_account_as_default().
3703 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3704 If it was the default account, unset the default account name.
3706 * src/maemo/modest-account-view-window.c:
3707 (on_delete_button_clicked): If it was the default account,
3708 set the first remaining account as the default instead.
3710 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3711 a NULL account or a NULL default account, to prevent a crash. This should
3712 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3715 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3717 * src/widgets/modest-recpt-editor.c:
3718 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3719 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3720 TODO comment for this. This fixes the build.
3722 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3723 be the best place for it. This will in future update all auto-update accounts,
3724 rather than just the current/default account, when that gconf key exists.
3725 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3726 if there are no accounts, before calling do_send_receive().
3727 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3729 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3730 * src/maemo/modest-main-window-ui.h:
3731 * src/maemo/modest-main-window.c: (on_connection_changed),
3732 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3733 directly, becaue the signal handler does more.
3735 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3737 * src/modest-account-mgr-helpers.c:
3738 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3739 for the case that the account does not exist.
3741 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3742 (equivalent to the modest account name) rather than the tinymail account name
3743 (equivalent to the modest account title - human readable) to get the account data.
3744 Check for null account data to prevent the crash, and add a TODO comment saying that
3745 this needs fixing because it is using the server account name instead of the account name.
3747 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3749 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3750 * src/maemo/modest-account-settings-dialog.c: (show_error),
3752 Use hildon_note_new_information() for informative and error messages,
3753 which seems to be expected for Maemo applications (no documentation that I know of
3754 says this). I am surprised that there is no distinction between info and error
3757 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3759 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3760 it is easy to find where this is used.
3762 * src/maemo/easysetup/modest-easysetup-wizard.c:
3763 (create_page_welcome), (create_page_account_details),
3764 (create_page_user_details), (create_page_complete_easysetup),
3765 (create_page_custom_incoming), (create_page_custom_outgoing),
3766 (create_page_complete_custom):
3767 * src/maemo/modest-account-settings-dialog.c:
3768 (create_page_account_details), (create_page_user_details),
3769 (create_page_incoming), (create_page_outgoing):
3770 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3771 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3772 (modest_connection_specific_smtp_edit_window_init):
3773 * src/maemo/modest-connection-specific-smtp-window.c:
3774 (modest_connection_specific_smtp_window_init):
3775 * src/maemo/modest-signature-editor-dialog.c:
3776 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3777 and scrolling policy as per the Email Application Layout Guide, if I have
3780 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3782 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3783 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3784 which were empty, because these vfuncs have been removed from TnyAccountStore.
3785 This fixes the build.
3787 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3789 * src/maemo/modest-main-window.c:
3790 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3791 showing/hiding it. Added TODO because it probably should not be NULL.
3792 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3793 because unnecessary g_warnings() make degugging difficult.
3795 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3797 * src/maemo/modest-msg-edit-window.c:
3798 (modest_msg_edit_window_select_color),
3799 (modest_msg_edit_window_select_background_color): 2 const corrections and
3800 moving 2 #endifs before closing brackets, to fix the build.
3802 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3804 * src/maemo/easysetup/modest-easysetup-wizard.h:
3805 * src/maemo/easysetup/modest-easysetup-wizard.c:
3806 (modest_easysetup_wizard_dialog_finalize),
3807 (on_button_edit_advanced_settings), (create_page_complete_custom),
3808 (on_response), (create_account):
3809 Implement the Advanced Settings edit button, by saving the account information,
3810 for the Advanded Settings dialog to use directly from gconf, and removing it
3811 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3812 Bug #5533 in the projects.maemo.org bugzilla.
3814 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3816 * src/maemo/modest-msg-view-window.c:
3817 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3818 when opening a message window.
3820 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3822 * src/maemo/easysetup/modest-easysetup-wizard.c:
3823 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3826 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3827 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3828 gconf settings. I probably added more checks than necessary, but that is safer.
3830 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3831 variable to fix the build, but this seems to be used when it is still NULL.
3833 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3835 * src/modest-platform.h:
3836 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3837 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3838 * src/modest-main.c: Implement this function so we can avoid using
3839 maemo-specific API from cross-platform code.
3841 * src/modest-tny-account-store.c:
3842 (get_smtp_specific_transport_account_for_open_connection):
3843 * src/modest-ui-actions.c: (check_for_connection),
3844 (modest_ui_actions_on_item_not_found):
3845 Use modest_platform_connect_and_wait() and put #idefs around other
3846 maemo-specific code, because only maemo currently has a way to
3847 identify connection names.
3849 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3851 * src/modest-tny-account-store.h:
3852 * src/modest-tny-account-store.c:
3853 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3854 the connection-specific SMTP server settings in the configuration.
3856 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3858 * src/maemo/modest-main-window.c: (on_connection_changed),
3860 * src/modest-main.c: (main), (start_ui), (send_mail):
3861 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3862 that is what is intended.
3864 * src/modest-ui-actions.c: (action_send), (action_receive),
3865 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3866 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3867 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3868 SMTP server is used when it is specified.
3870 (modest_ui_actions_on_send_receive):
3871 Check that a connection is open before proceeding.
3872 Receive and then send, instead of vice-versa, as per the specification.
3874 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3876 * src/modest-mail-operation.c:
3877 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3878 though I guess it should be something other than NULL.
3880 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3882 * src/maemo/easysetup/modest-easysetup-wizard.c:
3883 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3884 combo twice, to avoid an g_warning and to make it visible again.
3885 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3886 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3887 (already intended) dereference when detaching, because we then recreate the menu.
3888 But I am not sure why the warning was happening, and it is possible that this is a memory
3891 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3893 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3894 and uri_parse_mailto() utility functions.
3895 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3897 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3899 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3901 * src/dbus_api/modest-dbus-api.h:
3902 * src/dbus_api/modest-dbus-callbacks.c:
3903 Use an idle callback to execute the modest code in the application's own thread.
3904 Remove the helloworld example method.
3905 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3906 parsed, and the open-message method is not implemented because this is not yet implemented in
3908 * libmodest-dbus-client/libmodest-dbus-client.c:
3909 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3910 (libmodest_dbus_client_open_message):
3911 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3913 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3914 body without crashing.
3916 * tests/dbus_api/Makefile.am:
3917 * tests/dbus_api/test_mail_to.c:
3918 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3920 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3922 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3923 Added file to fix the build. Sorry.
3925 * src/dbus_api/Makefile.am:
3926 * src/dbus_api/modest-dbus-api.h:
3927 * src/dbus_api/modest-dbus-callbacks.h:
3928 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3929 (modest_dbus_req_handler):
3930 Put constants in a separate header so it can be reused by the
3931 client library, without duplication
3933 * libmodest-dbus-client/Makefile.am:
3934 * libmodest-dbus-client/libmodest-dbus-client.c:
3935 (libmodest_dbus_client_call_helloworld),
3936 (libmodfest_dbus_client_send_mail),
3937 (libmodfest_dbus_client_mailto),
3938 (libmodfest_dbus_client_open_message):
3939 * libmodest-dbus-client/libmodest-dbus-client.h:
3940 (Partly) Implement a send_mail D-Bus method.
3942 * tests/dbus_api/Makefile.am:
3943 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3944 the send_email D-Bus method.
3946 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3950 * libmodest-dbus-client/Makefile.am:
3951 * libmodest-dbus-client/libmodest-dbus-client.c:
3952 * libmodest-dbus-client/libmodest-dbus-client.h:
3953 * tests/dbus_api/Makefile.am:
3954 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3955 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3957 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3959 * src/maemo/easysetup/modest-easysetup-wizard.c:
3960 (create_page_account_details):
3961 * src/maemo/modest-account-settings-dialog.c:
3962 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3963 widgets, because this might not be the default in future versions of the Maemo GTK+.
3964 However, I can not not get capitalization to work even in a simple test case.
3966 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3968 * src/maemo/easysetup/modest-easysetup-wizard.c:
3969 (create_page_custom_incoming), (create_page_custom_outgoing):
3970 * src/maemo/modest-account-settings-dialog.c:
3971 (create_page_account_details), (create_page_incoming),
3972 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3973 instead of using gtk_check_button_with_label(), so they are aligned like the other
3974 widgets, as per the UI spec.
3976 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3978 * src/maemo/easysetup/modest-easysetup-wizard.c:
3979 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3980 * src/widgets/modest-validating-entry.c:
3981 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3982 Modest prefix instead of an EasySetup prefix.
3984 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3986 * src/widgets/modest-validating-entry.h:
3987 * src/widgets/modest-validating-entry.c: (on_insert_text),
3988 Added easysetup_validating_entry_set_max_func(), used to set a callback
3989 to call when the max number of characters is reached. GtkEntry has a max-length
3990 already but is silent about it.
3992 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3993 (create_page_account_details), (create_page_user_details),
3995 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3996 (create_page_account_details), (create_page_user_details),
3997 (create_page_outgoing):
3998 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3999 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4000 the UI spec, when the user tries to enter more than the max number of characters.
4002 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4004 * src/maemo/easysetup/modest-easysetup-wizard.c:
4005 (create_page_user_details), (create_page_custom_incoming),
4006 (create_page_custom_outgoing):
4007 * src/maemo/modest-account-settings-dialog.c:
4008 (create_page_user_details), (create_page_incoming),
4009 (create_page_outgoing):
4010 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4011 (modest_connection_specific_smtp_edit_window_init):
4012 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4013 not appropriate. Bad Maemo-specific defaults!.
4015 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4017 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4018 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4019 (modest_signature_editor_dialog_set_settings):
4020 Disable the label and textview when the checkbox is disabled, and use the
4021 specified (UI spec) default signature text.
4023 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4025 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4026 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4028 * src/modest-defs.h:
4029 * src/modest-account-mgr-helpers.h:
4030 * src/modest-account-mgr-helpers.c:
4031 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4033 * src/maemo/Makefile.am:
4034 * src/maemo/modest-signature-editor-dialog.c:
4035 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4038 * src/maemo/modest-account-settings-dialog.h:
4039 * src/maemo/modest-account-settings-dialog.c:
4040 (modest_account_settings_dialog_finalize), (on_button_signature),
4041 (save_configuration): Use the new dialog when the Edit button is pressed, and
4042 save the changes if necessary, as per the UI spec.
4044 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4046 * src/maemo/Makefile.am:
4047 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4048 based on maemo-develoers email from Dirk.
4050 * src/maemo/easysetup/modest-easysetup-wizard.c:
4051 (create_page_welcome), (create_page_account_details),
4052 (create_page_user_details), (create_page_complete_easysetup),
4053 (create_page_custom_incoming), (create_page_custom_outgoing),
4054 (create_page_complete_custom),
4055 (modest_easysetup_wizard_dialog_init):
4056 * src/maemo/modest-account-settings-dialog.c:
4057 (create_page_account_details), (create_page_user_details),
4058 (create_page_incoming), (create_page_outgoing),
4059 (modest_account_settings_dialog_init):
4060 * src/maemo/modest-connection-specific-smtp-window.c:
4061 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4063 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4065 * src/maemo/easysetup/modest-easysetup-wizard.c:
4066 (create_page_account_details), (create_page_custom_outgoing),
4067 (create_page_complete_custom):
4068 * src/maemo/modest-account-settings-dialog.c:
4069 (create_page_user_details), (create_page_incoming),
4070 (create_page_outgoing):
4071 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4072 (modest_connection_specific_smtp_edit_window_init):
4073 Use the correct (UI spec) port min/max, and use horizontal separators,
4076 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4078 * src/maemo/easysetup/modest-easysetup-wizard.c:
4079 (set_default_custom_servernames):
4080 * src/maemo/modest-account-settings-dialog.c:
4081 (create_page_incoming), (on_combo_outgoing_security_changed),
4082 (on_combo_incoming_security_changed), (create_page_outgoing),
4083 (modest_account_settings_dialog_set_account_name),
4084 (save_configuration):
4085 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4086 (on_combo_security_changed),
4087 (modest_connection_specific_smtp_edit_window_init),
4088 (modest_connection_specific_smtp_edit_window_set_connection),
4089 (modest_connection_specific_smtp_edit_window_get_settings):
4090 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4093 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4096 * src/maemo/easysetup/modest-easysetup-wizard.c:
4097 (create_page_custom_outgoing), (create_page_complete_custom):
4098 * src/maemo/modest-account-settings-dialog.c:
4099 (create_page_user_details), (create_page_outgoing):
4100 * src/maemo/modest-account-view-window.c: (button_box_new):
4101 Use changed logical IDs as per the most recent UI spec:
4102 mcen_bd_emailsetup_edit -> mcen_bd_edit
4103 mcen_bd_emailsetup_delete -> mcen_bd_delete
4104 mcen_bd_emailsetup_close -> mcen_bd_close
4106 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4110 * src/dbus_api/Makefile.am:
4111 * src/dbus_api/modest-dbus-callbacks.c:
4112 * src/dbus_api/modest-dbus-callbacks.h:
4113 * src/maemo/modest-platform.c: (modest_platform_init):
4114 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4116 * tests/Makefile.am:
4117 * tests/dbus_api/Makefile.am:
4118 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4120 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4122 * src/maemo/modest-account-settings-dialog.c:
4123 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4124 Removed unnecessary includes.
4126 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4128 * src/maemo/easysetup/modest-easysetup-wizard.c:
4129 * src/maemo/modest-account-settings-dialog.c:
4130 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4131 * src/widgets/Makefile.am:
4132 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4133 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4134 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4135 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4136 * src/widgets/modest-secureauth-combo-box.c:
4137 * src/widgets/modest-secureauth-combo-box.h:
4138 * src/widgets/modest-serversecurity-combo-box.c:
4139 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4140 made the GObject names more consistent with the rest of the Modest code.
4142 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4144 * src/maemo/easysetup/Makefile.am:
4145 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4146 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4147 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4148 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4149 * src/maemo/easysetup/modest-easysetup-wizard.c:
4150 * src/maemo/easysetup/modest-validating-entry.c:
4151 * src/maemo/easysetup/modest-validating-entry.h:
4152 * src/maemo/modest-account-settings-dialog.c:
4153 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4154 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4155 widgets/ because they are used outside of easysetup too. After checking in,
4156 svn will allow me to rename them too.
4158 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4160 * src/gnome/modest-msg-edit-window.c:
4161 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4162 linker error, to fix the build on the GNOME platform.
4163 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4164 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4165 ifdefed out to avoid a warning.
4167 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4169 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4170 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4171 some alternative for GTK+ 2.6.
4173 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4175 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4177 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4178 specified for EmailAccountsDialog in UI spec.
4180 * src/maemo/easysetup/modest-easysetup-wizard.c:
4181 * src/maemo/easysetup/modest-easysetup-wizard.h:
4182 * src/maemo/modest-account-settings-dialog.c:
4183 * src/maemo/modest-account-settings-dialog.h:
4184 Reuse a member window widget for the connection-specific SMTP server accounts,
4185 so we can tell it to create/save the accounts only if we actually save changes.
4187 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4188 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4189 (modest_connection_specific_smtp_edit_window_get_settings):
4190 Return a struct instance for temporarily remembering the entered data.
4192 * src/maemo/modest-connection-specific-smtp-window.h:
4193 * src/maemo/modest-connection-specific-smtp-window.c:
4194 (modest_connection_specific_smtp_window_finalize),
4195 (modest_connection_specific_smtp_window_fill_with_connections),
4197 (modest_connection_specific_smtp_window_save_server_accounts),
4198 (update_model_server_names): Do not actually save data until asked,
4199 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4201 (on_selection_changed),
4202 (modest_connection_specific_smtp_window_init): Disable the edit
4203 button when nothing is selected.
4205 * src/modest-account-mgr-helpers.c:
4206 * src/modest-account-mgr-helpers.h:
4207 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4210 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4212 * src/modest-account-mgr-helpers.h:
4213 * src/modest-account-mgr-helpers.c:
4214 (modest_account_mgr_get_unused_account_name),
4215 (modest_account_mgr_get_unused_account_display_name): Added these
4216 utility functions, to avoid code duplication.
4218 * src/maemo/easysetup/modest-easysetup-wizard.c:
4219 (create_page_account_details), (create_account):
4220 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4221 (on_combo_security_changed),
4222 (modest_connection_specific_smtp_edit_window_init),
4223 (modest_connection_specific_smtp_edit_window_save_settings):
4224 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4225 * src/maemo/modest-connection-specific-smtp-window.c:
4226 (modest_connection_specific_smtp_window_finalize),
4227 (modest_connection_specific_smtp_window_fill_with_connections),
4228 (on_button_edit), (modest_connection_specific_smtp_window_init):
4229 * src/maemo/modest-connection-specific-smtp-window.h:
4230 Implementing saving of connection-specific server accounts.
4232 But I need to refactor this so we can save the data for each
4233 possible connection-specific account and only actually create the server accounts
4234 when the easysetup finished, or the OK button is pressed on the account settings
4237 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4239 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4240 (on_combo_security_changed):
4241 (modest_connection_specific_smtp_edit_window_init):
4242 Auto-fill the port number as in the account settings.
4244 (modest_connection_specific_smtp_edit_window_set_connection):
4245 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4246 * src/maemo/modest-connection-specific-smtp-window.c:
4247 (fill_with_connections), (on_button_edit),
4248 (modest_connection_specific_smtp_window_init):
4249 Turn the edit window into a dialog to simplify the code, and
4250 set a WM hint as in a GtkDialog, because only a popup can be on top of
4251 another window in Maemo, and popups usually have no WM decoration.
4253 * src/modest-defs.h:
4254 * src/modest-account-mgr-helpers.c:
4255 (modest_account_mgr_set_connection_specific_smtp),
4256 (modest_account_mgr_remove_connection_specific_smtp),
4257 (modest_account_mgr_get_connection_specific_smtp):
4258 * src/modest-account-mgr-helpers.h: Some functions to write the
4259 connection-specific SMTP server information. Not yet used.
4262 * src/widgets/modest-folder-view.c: (text_cell_data):
4263 Fix a warning about an uninitialized variable.
4264 (on_configuration_key_changed): Put an #ifdef around the use
4265 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4267 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4269 * src/maemo/modest-account-settings-dialog.h:
4270 * src/maemo/modest-account-settings-dialog.c:
4271 Added connect_for_modified() utility function to mark the new modified boolean.
4273 (create_page_account_details), (create_page_user_details),
4274 (create_page_incoming), (create_page_outgoing), (on_response),
4275 (modest_account_settings_dialog_init),
4276 (modest_account_settings_dialog_set_account_name):
4277 Only warn about unsaved changes when there are actually unsaved changes.
4279 * src/modest-account-mgr-helpers.c:
4280 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4281 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4282 to get the data from there in future.
4284 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4286 * src/modest-defs.h:
4288 * src/modest-account-mgr-helpers.h:
4289 * src/modest-account-mgr-helpers.c:
4290 Store the security account setting in a single conf key instead of using
4291 the options list, so that the list is left for just the to-be-removed camel hack,
4292 and because gconf_client_set_list() is failing for some reason.
4294 * src/modest-account-mgr.c:
4295 (modest_account_mgr_add_server_account):
4296 * src/maemo/modest-account-settings-dialog.c:
4297 (modest_account_settings_dialog_set_account_name),
4298 (save_configuration): Use the renamed functions.
4301 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4303 * src/widgets/Makefile.am:
4304 * src/widgets/modest-limit-retrieve-combo-box.c:
4305 * src/widgets/modest-limit-retrieve-combo-box.h:
4306 * src/widgets/modest-retrieve-combo-box.c:
4307 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4308 the account settings dialog.
4310 * src/modest-defs.h:
4311 * src/modest-account-mgr-helpers.h:
4312 * src/modest-account-mgr-helpers.c:
4313 (modest_server_account_get_option_secure_auth),
4314 (modest_server_account_set_option_secure_auth):
4315 * src/modest-account-mgr.c:
4316 (modest_account_mgr_add_server_account):
4317 Use the existing AUTH_MECH conf key for the secure-auth setting,
4318 instead of putting it in the list options, because this was actually used already.
4320 * src/maemo/modest-account-settings-dialog.c:
4321 (create_page_account_details),
4322 (modest_account_settings_dialog_set_account_name),
4323 (save_configuration):
4324 * src/maemo/modest-account-settings-dialog.h:
4325 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4326 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4328 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4330 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4331 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4332 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4334 * src/modest-defs.h:
4335 * src/maemo/modest-account-settings-dialog.c:
4336 (create_page_incoming), (on_combo_outgoing_security_changed),
4337 (on_combo_incoming_security_changed), (create_page_outgoing),
4338 (modest_account_settings_dialog_set_account_name),
4339 (save_configuration): Load/Save the port number, and change it when the
4340 security combo changes, to suitable defaults.
4342 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4344 * src/modest-account-mgr.c:
4345 (modest_account_mgr_add_server_account): Set the security and secure-auth
4346 options, and add a comment saying that the other camel-specific options should be
4349 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4351 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4353 * src/modest-tny-account-store.c: (account_list_free),
4354 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4355 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4358 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4360 * src/modest-protocol-info.c:
4361 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4362 is required by our UI spec. Maybe something in our implementation will use this eventually.
4363 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4364 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4365 instead of the previous 0 placeholder.
4367 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4368 secure-auth settings.
4369 * src/modest-account-mgr-helpers.h:
4370 * src/modest-account-mgr-helpers.c:
4371 (modest_server_account_data_get_option_secure_auth),
4372 (modest_server_account_set_option_secure_auth),
4373 (modest_server_account_data_get_option_security),
4374 (modest_server_account_set_option_security): Added this API for getting and setting the security
4375 and secure-auth settings.
4377 * src/maemo/modest-account-settings-dialog.h:
4378 * src/maemo/modest-account-settings-dialog.c:
4379 (modest_account_settings_dialog_finalize), (check_data),
4380 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4381 about changing titles.
4382 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4383 (save_configuration): Save the security and secure-auth settings.
4385 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4386 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4388 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4390 * src/modest-defs.h:
4391 * src/modest-account-mgr.c:
4392 (modest_account_mgr_add_server_account):
4393 Added and used defines for the options key and value pair strings,
4394 that are used so far, though they do not seem to correspond to anything in our
4395 UI specs or ModestProtocol enum.
4397 * src/modest-account-mgr-helpers.h:
4398 * src/modest-account-mgr-helpers.c:
4399 (compare_option_strings_for_name),
4400 (modest_server_account_data_get_option_value),
4401 (modest_server_account_data_get_option_bool),
4402 (modest_account_mgr_get_server_account_option):
4403 Added helper functions for parsing the options GSList.
4405 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4407 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4408 display name is based on the supplied account name.
4409 * src/modest-account-mgr.c:
4410 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4411 with an inefficient, but good-enough, implementation.
4413 * src/maemo/easysetup/modest-easysetup-wizard.c:
4414 (create_page_account_details), (on_before_next), (create_account):
4415 Check for existing display names rather than (non-user-visible) account names, and just
4416 create and set a unique account name at the end.
4418 * src/maemo/modest-account-settings-dialog.c:
4419 (modest_account_settings_dialog_init),
4420 (modest_account_settings_dialog_set_account_name),
4421 (create_page_incoming): Show the display name, instead of the account name.
4422 (on_response): Do some (not all) extra checks, as in the UI spec.
4423 (save_configuration): Save the display name if it was changed.
4425 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4427 * po/en_GB.po: Added needed logical ID and translation.
4428 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4429 (init_view): Made the is-default column clicking work.
4431 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4434 * src/maemo/easysetup/Makefile.am:
4435 * src/maemo/easysetup/modest-easysetup-wizard.c:
4436 (modest_easysetup_wizard_dialog_init):
4437 * src/maemo/easysetup/provider-data-test.keyfile:
4438 * src/maemo/easysetup/provider-data.keyfile:
4439 Moved the provider data file to the new modest-providers-data package and used it from there.
4441 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4443 * src/modest-local-folder-info.c:
4444 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4445 N_() was already used on the static strings, but this just marks it for translation without
4446 using the translation.
4448 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4450 * src/maemo/modest-account-settings-dialog.c:
4451 (create_page_incoming),
4452 (modest_account_settings_dialog_set_account_name):
4453 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4454 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4455 I will do this if nobody else gets there first.
4457 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4459 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4460 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4461 save the security stuff.
4463 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4465 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4466 Set the email address and user fullname, which I now see must be
4469 * src/maemo/modest-account-settings-dialog.h:
4470 * src/maemo/modest-account-settings-dialog.c:
4472 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4473 leave-on-server and authentication.
4474 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4477 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4480 * src/maemo/modest-account-settings-dialog.c:
4481 * src/maemo/modest-account-settings-dialog.h:
4482 Most (but not all) of the widgets are now present as specified by the UI spec.
4483 No changes are yet saved, and some details are not properly shown yet.
4485 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4487 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4489 * src/maemo/Makefile.am:
4490 * src/maemo/modest-account-settings-dialog.c:
4491 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4492 an existing account. Doesn't do much yet.
4494 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4495 Open the accounts settings dialog when Edit is clicked.
4497 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4499 * src/maemo/easysetup/Makefile.am:
4500 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4502 * src/maemo/easysetup/modest-easysetup-wizard.c:
4503 (modest_easysetup_wizard_dialog_init):
4504 Try to get the source directory from the build system,
4505 instead of hard-coding "./" into the source code, when opening our local
4506 copies of the configuration files.
4507 But this still fails when opening the wizard from the Accounts window,
4508 maybe because the working directory seems to change at runtime.
4509 So the wizard will fail the second time unless you copy the files into their
4510 proper locations - see the stdout warnings for the paths.
4512 (create_page_account_details),(on_before_next):
4513 Check for existing non-server accounts instead of server accounts,
4514 so the default account name is useful again, and to prevent trying to
4517 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4518 Show the wizard when New is clicked.
4520 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4521 (init_view): Show the column headers, and show the columns that are
4522 specified in the UI specs. However, something in Maemo's GTK+ prevents
4523 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4524 change the default account. This is despite unsetting the special properties.
4526 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4528 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4529 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4530 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4531 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4532 to make that clearer.
4533 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4535 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4537 * src/maemo/modest-account-view-window.c:
4538 (modest_account_view_window_init),
4539 (modest_account_view_window_new):
4540 Use the same buttons as specified in the
4541 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4542 the existing widgets, which never had a chance of working.
4543 Put the ModestAccountView treeview in a scrolled window.
4544 Do not repeat the initialization in both _init() and _new().
4546 * src/widgets/modest-account-view.c: (update_account_view):
4547 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4548 this widget and window shows no accounts.
4550 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4552 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4554 * src/maemo/easysetup/modest-easysetup-wizard.c:
4555 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4556 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4557 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4560 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4561 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4562 accounts exist yet, as in the UI spec.
4564 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4566 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4568 * src/maemo/Makefile.am:
4569 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4570 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4571 New window for editing connection-specific smtp details.
4572 Not fully implemented.
4574 * src/maemo/modest-connection-specific-smtp-window.c:
4575 (modest_connection_specific_smtp_window_finalize) :
4576 unref the tree model.
4577 (on_button_edit): Show the edit window.
4579 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4581 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4584 * src/maemo/Makefile.am:
4585 * src/maemo/modest-connection-specific-smtp-window.c:
4586 * src/maemo/modest-connection-specific-smtp-window.h:
4587 New window for showing the list of connections, for connection-specific
4588 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4589 * src/maemo/easysetup/modest-easysetup-wizard.c:
4590 (create_page_custom_outgoing): Show the new window when the button is clicked.
4592 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4594 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4595 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4596 * src/maemo/modest-msg-edit-window.c:
4597 (modest_msg_edit_window_insert_image):
4598 * src/modest-conf.c: (modest_conf_key_escape):
4599 * src/modest-mail-operation.c:
4600 (modest_mail_operation_send_new_mail):
4601 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4602 (modest_ui_actions_on_new_account):
4603 * src/widgets/modest-attachment-view.c: (update_filename_request):
4604 * src/widgets/modest-mail-header-view.c:
4605 Corrected warnings that were breaking the build, by commenting out unused variables,
4606 and a function, and by including a header.
4608 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4610 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4611 so we can #ifdef around platform-specific code when necessary.
4612 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4613 to allow this to build for the GNOME platform too.
4615 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4617 * src/maemo/easysetup/modest-easysetup-wizard.c:
4618 Added util_increment_name() and used it in create_page_account_details()
4619 to make sure that the default account name is always a new name.
4621 (modest_easysetup_wizard_dialog_init),
4622 (set_default_custom_servernames): Some minor memory management fixes.
4624 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4628 * src/modest-runtime.c: (init_i18n): Restored the translation
4629 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4630 are defined in config.h, and the translations are installed.
4632 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4633 is defined for translation.
4635 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4637 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4639 * src/maemo/easysetup/modest-easysetup-wizard.c:
4640 (modest_easysetup_wizard_dialog_init):
4641 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4642 Use realistic paths (though they should use $prefix generically) to the
4643 mcc_mapping and provider-data.keyfile files which might work when they
4644 are installed by the future version of the operator-wizard package,
4645 and then fallback to paths in our source code, with an explanatory
4648 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4652 * src/maemo/Makefile.am:
4653 * src/maemo/easysetup/: Added files from the previously-exernal
4654 osso-modest-easysetup.
4655 * src/maemo/modest-main-window-ui.h:
4656 * src/modest-ui-actions.c:
4657 * src/modest-ui-actions.h:
4658 Added modest_ui_actions_on_new_account() as a signal handler for the
4659 New Account menu item. It shows the easysetup wizard.
4660 * po/en_GB.po: Added additional needed logical IDs and translations.