git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/modest-main-window.c: (on_account_update): Check that
   4         account_name is not NULL, to prevent a crash at startup that I am
   5         seeing on the N800. I do wonder why it is NULL.
   6
   7         * src/maemo/easysetup/modest-easysetup-wizard.c:
   8         (create_page_user_details):
   9         * src/maemo/modest-account-settings-dialog.c:
  10         (create_page_user_details), (create_page_outgoing):
  11         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  12         (modest_connection_specific_smtp_edit_window_init):
  13         * src/modest-ui-actions.c:
  14         (modest_ui_actions_on_password_requested):
  15         Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
  16         might do something useful with the on-screen keyboard.
  17
  18 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  19
  20         * src/maemo/modest-main-window.c: (on_account_update):
  21         Avoid adding a menu item to priv->accounts_popup if accounts_popup is
  22         NULL, to avoid lots of warnings. However, it probably should not be NULL.
  23
  24 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  25
  26         * src/modest-tny-account-store.c: (on_account_changed):
  27         Correct the signature of this signal handler.
  28
  29 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  30
  31         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  32         Show a HildonNote instead of a GtkDialog for Maemo.
  33
  34 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  35
  36         * src/widgets/modest-account-view.h:
  37         * src/widgets/modest-account-view.c: (on_account_changed),
  38         (on_account_removed). Added a boolean flag, set/unset by
  39         modest_account_view_block_conf_updates(),
  40         modest_account_view_unblock_conf_updates() to prevent unnecessary
  41         updates, but this is not very useful because the gconf notifications are
  42         so delays (maybe only on Maemo Bora).
  43         So auto-updating is turned off, and these functions do an explicit
  44         update when necessary.
  45         However, something else is still doing too much work when adding/removing
  46         accounts, probably in another part of the application.
  47
  48         * src/maemo/modest-account-view-window.c:
  49         (on_delete_button_clicked), (on_edit_button_clicked),
  50         (on_new_button_clicked): Use the new functions.
  51
  52 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  53
  54         * src/modest-account-mgr-helpers.c:
  55         (modest_account_mgr_set_first_account_as_default):
  56         Sort the list of names alphabetically-by-title, so we choose the first one
  57         based on that.
  58         * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
  59         alphabetically by the title.
  60
  61         This fixes projects.maemo.org bug NB#56418 .
  62
  63         * src/modest-account-mgr-priv.c:
  64         (_modest_account_mgr_account_from_key):
  65         * src/modest-account-mgr.c: (on_key_change): Initialize variables to
  66         avoid a valgrind error, and possible random behaviour.
  67
  68 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  69
  70         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  71         Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
  72         tinymail documentation to say that this can be expected.
  73         Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
  74         pretty, and should not happen, but I would prefer to know when it does.
  75
  76 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  77
  78         * configure.ac: When using the older hildon version, probably on Bora,
  79         require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
  80         to fix the build.
  81         * src/widgets/modest-attachment-view.c:
  82         (modest_attachment_view_set_part_default): Initialize variables, to fix the
  83         build.
  84
  85 2007-05-09  Marcus Bauer  <marcusb@openismus.com>
  86
  87         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
  88         Implemented the prototype. Can be tested with
  89         tests/dbus_api/test_open_message:
  90
  91 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  92
  93         * src/modest-tny-account-store.c:
  94         (modest_tny_account_store_instance_init), (get_password):
  95         * src/modest-ui-actions.c:
  96         (modest_ui_actions_on_password_requested):
  97         Do not store the password in gconf, because this function is called
  98         for non-remembered passwords. Actually use the cached (in the hash map)
  99         password instead of releasing it.
 100         The password will now not be remembered if it is asked via the protected
 101         password dialog, as per the UI spec.
 102
 103 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 104
 105         * src/modest-defs.h:
 106         * src/modest-account-mgr-helpers.h:
 107         * src/modest-account-mgr-helpers.c:
 108         Added modest_server_account_get_username_has_succeeded(),
 109         modest_server_account_set_username_has_succeeded().
 110         (modest_server_account_set_username),
 111         Reset the has-succeeded flag if the username changes.
 112
 113         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 114         * src/maemo/modest-connection-specific-smtp-window.c:
 115         (modest_connection_specific_smtp_window_save_server_accounts):
 116         Use modest_server_account_set_username() instead of using
 117         modest_conf_set_string() directly, so that the has-succeeded flag is always
 118         reset.
 119
 120         * src/modest-ui-actions.c:
 121         (modest_ui_actions_on_password_requested): Dim the username entry if
 122         the username has ever worked, as per the UI spec.
 123
 124 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 125
 126         * src/modest-tny-account-store.c: (get_password):
 127         * src/modest-ui-actions.c:
 128         (modest_ui_actions_on_password_requested):
 129         Allow the username to be changed too, though there is more work to
 130         be done on exactly how this behaves.
 131
 132 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 133
 134         * src/modest-account-mgr-helpers.h:
 135         * src/modest-account-mgr-helpers.c:
 136         Added modest_account_mgr_get_display_name(),
 137         modest_server_account_get_username(),
 138         modest_server_account_set_username(),
 139         modest_server_account_set_password(),
 140         modest_server_account_get_hostname() functions so we do not need to
 141         use the conf API directly.
 142
 143         * src/maemo/modest-main-window.c: (connect_signals):
 144         Actually connect ot the ModestAccountStore::request-password signal,
 145         so that we show the dialog when the password is requested by Tinymail,
 146         for isntance if it is empty.
 147
 148         * src/modest-marshal.list:
 149         * src/modest-tny-account-store.c:
 150         (modest_tny_account_store_class_init), (get_password),
 151         (modest_tny_account_store_alert):
 152         * src/modest-tny-account-store.h:
 153         * src/modest-ui-actions.h:
 154         * src/modest-ui-actions.c:
 155         (modest_ui_actions_on_password_requested):
 156         Change the signal parameters, so it is obvious that we are providing
 157         the non human-readable server name, and receiving both the username
 158         and password, though changing of the username is not yet implemented.
 159         Change the dialog UI to match the Maemo UI specifications, with #idfefing
 160         for the GNOME version.
 161
 162         This should fix the projects.maemo.org bug NB#56209, though it does not
 163         work on Bora, because the gconf_client_get() for the password fails
 164         immediately after we save it with gconf_client_set().
 165
 166 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 167
 168         * configure.ac:
 169         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
 170         caused an undefined symbol error:
 171         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
 172
 173 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 174
 175         * src/modest-tny-account-store.c:
 176         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
 177         using a GError instead of a string message, so we can translate it in
 178         Modest.
 179
 180 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 181
 182         * src/maemo/modest-address-book.c:
 183         (modest_address_book_check_names):
 184         * src/maemo/modest-msg-view-window.c:
 185         (modest_msg_view_window_clipboard_owner_change):
 186         * src/modest-init.c: (modest_init_init_ui):
 187         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
 188         (update_folders_cb), (modest_mail_operation_update_account):
 189         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 190         (modest_ui_actions_on_msg_attachment_clicked),
 191         (modest_ui_actions_on_msg_recpt_activated):
 192         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 193         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 194         (modest_msg_view_search_next):
 195         * src/widgets/modest-recpt-editor.c:
 196         (modest_recpt_editor_on_button_release_event),
 197         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 198         g_message(). At this point we should only be seeing interesting errors on
 199         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 200
 201 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 202
 203         (modest_wizard_dialog_force_title_update):
 204         * src/maemo/easysetup/modest-wizard-dialog.h:
 205         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 206         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 207         can update the title when appropriate. Otherwise the title is wrong if the
 208         pages are added after adding the notebook to the dialog.
 209         This must be a problem in HildonWizardDialog too.
 210         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 211
 212         * src/maemo/easysetup/modest-easysetup-wizard.c:
 213         (create_subsequent_customsetup_pages),
 214         (create_subsequent_easysetup_pages):
 215         Call modest_wizard_dialog_force_title_update() so that the title is
 216         correct even with GTK+ < 2.10.
 217         This fixes projects.maemo.org bug NB#56145 .
 218
 219 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 220
 221         * src/maemo/modest-platform.c:
 222         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 223         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 224         from being shown.
 225
 226 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 227
 228         * src/widgets/modest-window.h:
 229         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 230         and modest_window_save_state(), which invokes it.
 231
 232         * src/widgets/modest-window-mgr.h:
 233         * src/widgets/modest-window-mgr.c:
 234         Added modest_window_mgr_save_state_for_all_windows(), which calls
 235         the save_state vfunc on all registered windows, if implemented.
 236
 237         * src/gnome/modest-msg-edit-window.c:
 238         * src/gnome/modest-msg-view-window.c:
 239         * src/maemo/modest-msg-edit-window.c:
 240         * src/maemo/modest-msg-view-window.c:
 241         * src/maemo/modest-main-window.c:
 242         Specify the existing save_settings functions as implementations of
 243         ModestWindow::save_state_func().
 244
 245         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 246         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 247         enabling hibernation, for instance.
 248
 249         We may need to do the same thing for restoring settings.
 250
 251
 252 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 253
 254         * src/widgets/modest-window-mgr.c:
 255         * src/widgets/modest-window-mgr.h:
 256         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 257         modest_window_mgr_get_hibernation_is_prevented().
 258
 259         * src/maemo/modest-main-window.c:
 260         (on_hildon_program_is_topmost_notify): Prevent hibernation
 261         (possible when the application goes to the background in the WM),
 262         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 263
 264         * src/maemo/easysetup/modest-easysetup-wizard.c:
 265         (modest_easysetup_wizard_dialog_init):
 266         * src/maemo/modest-account-settings-dialog.c:
 267         (modest_account_settings_dialog_init):
 268         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 269         (modest_connection_specific_smtp_edit_window_init):
 270         * src/maemo/modest-connection-specific-smtp-window.c:
 271         (modest_connection_specific_smtp_window_init):
 272         * src/maemo/modest-signature-editor-dialog.c:
 273         (modest_signature_editor_dialog_init):
 274         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 275         prevent hibernation while any of these account settings dialogs are open.
 276
 277 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 278
 279         * src/maemo/Makefile.am:
 280         * src/maemo/modest-osso-state-saving.c:
 281         * src/maemo/modest-osso-state-saving.h: Added
 282         modest_osso_load_state() and modest_osso_save_state() though they do
 283         nothing now. They should iterate through all the open windows and load/save
 284         their state.
 285         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 286         save state when closing.
 287
 288         * src/maemo/modest-main-window.c:
 289         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 290         Add a notification handler for the HildonProgram::is-topmost property,
 291         so we can allow hibernation when the application goes into the background.
 292         But we still need to detect when the accounts setup windows are open so
 293         we can stop hibernation when they are open.
 294         To do this, I also added the main window the HildonProgram. This might have
 295         other side-effects/benefits, and should maybe be done for other windows.
 296
 297         * src/maemo/modest-osso-autosave-callbacks.h:
 298         * src/maemo/modest-osso-autosave-callbacks.c:
 299         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 300         though it does not do anything yet, and we might never need this to do
 301         anything. For instance, we already save drafts.
 302
 303         * src/maemo/modest-platform.c: (modest_platform_init):
 304         Specify the libosso auto-save callback.
 305
 306 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 307
 308         * src/maemo/modest-platform.c:
 309         (modest_platform_set_update_interval):
 310         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 311         aparently stays valid between application instances, so we can use this
 312         to remove and reset it later. According to a maemo-developers email from
 313         David Weinehall.
 314
 315 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 316
 317         * configure.ac: Depend on libalarm for Maemo.
 318
 319         * src/dbus_api/modest-dbus-api.h:
 320         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 321         (on_send_receive), (modest_dbus_req_handler):
 322         Handle a SEND_RECEIVE D-Bus method.
 323
 324         * libmodest-dbus-client/libmodest-dbus-client.c:
 325         (libmodest_dbus_client_send_and_receive):
 326         * libmodest-dbus-client/libmodest-dbus-client.h:
 327         Add C convenience functions for calling the new D-Bus method.
 328
 329         * src/modest-platform.h:
 330         * src/gnome/modest-platform.c:
 331         * src/maemo/modest-platform.c:
 332         Added modest_platform_set_update_interval(), which uses the
 333         alarmd API on Maemo.
 334         (modest_platform_init),
 335         Call modest_platform_set_update_interval(), using a hard-coded
 336         interval for now (until the global settings dialog is implemented),
 337         though I am not sure that this makes sense yet.
 338
 339 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 340
 341         * src/dbus_api/modest-dbus-callbacks.c:
 342         (modest_osso_cb_hw_state_handler):
 343         * src/dbus_api/modest-dbus-callbacks.h:
 344         * src/maemo/modest-platform.c: (modest_platform_init):
 345         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 346         in case this has some effect on the ability for Maemo to ping the
 347         application.
 348
 349 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 350
 351         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 352         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 353         warning. It is probably a logic error, but I need to fix the build.
 354
 355 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 356
 357         * src/modest-account-mgr.h:
 358         * src/modest-account-mgr.c:
 359         (modest_account_mgr_account_names): Add a gboolean enabled_only
 360         parameter, so we can get lists of onlt the enabled accounts.
 361
 362         (modest_account_mgr_add_account),,
 363         (modest_account_mgr_account_with_display_name_exists):
 364         * src/maemo/modest-msg-edit-window.c: (get_transports):
 365         * src/modest-account-mgr-helpers.c:
 366         (modest_account_mgr_set_first_account_as_default):
 367         * src/modest-init.c: (init_default_account_maybe):
 368         * src/modest-tny-account-store.c: (get_accounts):
 369         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 370         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 371         * tests/check_account-mgr.c: (START_TEST):
 372         Provide the extra parameter, as appropriate.
 373
 374         * src/widgets/modest-account-view.c: (update_account_view):
 375         Do not show disabled accounts (meaning that there is no way to
 376         enable/disable accounts in the UI (the feature is not in our UI
 377         specification), so we can use this internally only to mark unfinished
 378         or temporary account data.
 379
 380         * src/maemo/easysetup/modest-easysetup-wizard.c:
 381         (create_account): Add boolean enable parameter, so we can specify FALSE
 382         to create the temporary account.
 383         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 384         (on_before_next): When finishing, when there is a temporary account, just
 385         set it as enabled.
 386         Also, use a timeout to delay the showing of the dialog until gconf is likely
 387         to return correct information, due to a maemo gconf bug that is fixed in
 388         osso 1.1, but not yet in Bora.
 389         However, the dialog stays on screen after it is destroyed.
 390
 391         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 392         for invalid data when cancelling. Use a hildon note instead of a dialog
 393         to complain about invalid data. Do not show the account-saved note if the
 394         account is disabled (a temporary account that will not really be saved for use
 395         until later.)
 396
 397 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 398
 399         * src/modest-account-mgr-helpers.h:
 400         * src/modest-account-mgr-helpers.c:
 401         Added modest_account_mgr_unset_default_account(),
 402         Added modest_account_mgr_set_first_account_as_default().
 403
 404         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 405         If it was the default account, unset the default account name.
 406
 407         * src/maemo/modest-account-view-window.c:
 408         (on_delete_button_clicked): If it was the default account,
 409         set the first remaining account as the default instead.
 410
 411         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 412         a NULL account or a NULL default account, to prevent a crash. This should
 413         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 414
 415
 416 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 417
 418         * src/widgets/modest-recpt-editor.c:
 419         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 420         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 421         TODO comment for this. This fixes the build.
 422
 423         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 424         be the best place for it. This will in future update all auto-update accounts,
 425         rather than just the current/default account, when that gconf key exists.
 426         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 427         if there are no accounts, before calling do_send_receive().
 428         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 429
 430         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 431         * src/maemo/modest-main-window-ui.h:
 432         * src/maemo/modest-main-window.c: (on_connection_changed),
 433         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 434         directly, becaue the signal handler does more.
 435
 436 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 437
 438         * src/modest-account-mgr-helpers.c:
 439         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 440         for the case that the account does not exist.
 441
 442         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 443         (equivalent to the modest account name) rather than the tinymail account name
 444         (equivalent to the modest account title - human readable) to get the account data.
 445         Check for null account data to prevent the crash, and add a TODO comment saying that
 446         this needs fixing because it is using the server account name instead of the account name.
 447
 448 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 449
 450         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 451         * src/maemo/modest-account-settings-dialog.c: (show_error),
 452         (show_ok):
 453         Use hildon_note_new_information() for informative and error messages,
 454         which seems to be expected for Maemo applications (no documentation that I know of
 455         says this). I am surprised that there is no distinction between info and error
 456         dialogs.
 457
 458 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 459
 460         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 461         it is easy to find where this is used.
 462
 463         * src/maemo/easysetup/modest-easysetup-wizard.c:
 464         (create_page_welcome), (create_page_account_details),
 465         (create_page_user_details), (create_page_complete_easysetup),
 466         (create_page_custom_incoming), (create_page_custom_outgoing),
 467         (create_page_complete_custom):
 468         * src/maemo/modest-account-settings-dialog.c:
 469         (create_page_account_details), (create_page_user_details),
 470         (create_page_incoming), (create_page_outgoing):
 471         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 472         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 473         (modest_connection_specific_smtp_edit_window_init):
 474         * src/maemo/modest-connection-specific-smtp-window.c:
 475         (modest_connection_specific_smtp_window_init):
 476         * src/maemo/modest-signature-editor-dialog.c:
 477         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 478         and scrolling policy as per the Email Application Layout Guide, if I have
 479         understood it.
 480
 481 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 482
 483         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 484         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 485         which were empty, because these vfuncs have been removed from TnyAccountStore.
 486         This fixes the build.
 487
 488 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 489
 490         * src/maemo/modest-main-window.c:
 491         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 492         showing/hiding it. Added TODO because it probably should not be NULL.
 493         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 494         because unnecessary g_warnings() make degugging difficult.
 495
 496 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 497
 498         * src/maemo/modest-msg-edit-window.c:
 499         (modest_msg_edit_window_select_color),
 500         (modest_msg_edit_window_select_background_color): 2 const corrections and
 501         moving 2 #endifs before closing brackets, to fix the build.
 502
 503 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 504
 505         * src/maemo/easysetup/modest-easysetup-wizard.h:
 506         * src/maemo/easysetup/modest-easysetup-wizard.c:
 507         (modest_easysetup_wizard_dialog_finalize),
 508         (on_button_edit_advanced_settings), (create_page_complete_custom),
 509         (on_response), (create_account):
 510         Implement the Advanced Settings edit button, by saving the account information,
 511         for the Advanded Settings dialog to use directly from gconf, and removing it
 512         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 513         Bug #5533 in the projects.maemo.org bugzilla.
 514
 515 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 516
 517         * src/maemo/modest-msg-view-window.c:
 518         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 519         when opening a message window.
 520
 521 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 522
 523         * src/maemo/easysetup/modest-easysetup-wizard.c:
 524         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 525         match the UI spec.
 526
 527         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 528         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 529         gconf settings. I probably added more checks than necessary, but that is safer.
 530
 531         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 532         variable to fix the build, but this seems to be used when it is still NULL.
 533
 534 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 535
 536         * src/modest-platform.h:
 537         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 538         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 539         * src/modest-main.c: Implement this function so we can avoid using
 540         maemo-specific API from cross-platform code.
 541         (main):
 542         * src/modest-tny-account-store.c:
 543         (get_smtp_specific_transport_account_for_open_connection):
 544         * src/modest-ui-actions.c: (check_for_connection),
 545         (modest_ui_actions_on_item_not_found):
 546         Use modest_platform_connect_and_wait() and put #idefs around other
 547         maemo-specific code, because only maemo currently has a way to
 548         identify connection names.
 549
 550 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 551
 552         * src/modest-tny-account-store.h:
 553         * src/modest-tny-account-store.c:
 554         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 555         the connection-specific SMTP server settings in the configuration.
 556
 557         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 558         (on_idle_mail_to):
 559         * src/maemo/modest-main-window.c: (on_connection_changed),
 560         (connect_signals):
 561         * src/modest-main.c: (main), (start_ui), (send_mail):
 562         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 563         that is what is intended.
 564
 565         * src/modest-ui-actions.c: (action_send), (action_receive),
 566         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 567         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 568         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 569         SMTP server is used when it is specified.
 570
 571         (modest_ui_actions_on_send_receive):
 572         Check that a connection is open before proceeding.
 573         Receive and then send, instead of vice-versa, as per the specification.
 574
 575 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 576
 577         * src/modest-mail-operation.c:
 578         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 579         though I guess it should be something other than NULL.
 580
 581 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 582
 583         * src/maemo/easysetup/modest-easysetup-wizard.c:
 584         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 585         combo twice, to avoid an g_warning and to make it visible again.
 586         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 587         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 588         (already intended) dereference when detaching, because we then recreate the menu.
 589         But I am not sure why the warning was happening, and it is possible that this is a memory
 590         leak.
 591
 592 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 593
 594         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 595         and uri_parse_mailto() utility functions.
 596         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 597         the mailto URI.
 598         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 599
 600 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 601
 602         * src/dbus_api/modest-dbus-api.h:
 603         * src/dbus_api/modest-dbus-callbacks.c:
 604         Use an idle callback to execute the modest code in the application's own thread.
 605         Remove the helloworld example method.
 606         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 607         parsed, and the open-message method is not implemented because this is not yet implemented in
 608         modest itself.
 609         * libmodest-dbus-client/libmodest-dbus-client.c:
 610         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 611         (libmodest_dbus_client_open_message):
 612         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 613
 614         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 615         body without crashing.
 616
 617         * tests/dbus_api/Makefile.am:
 618         * tests/dbus_api/test_mail_to.c:
 619         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 620
 621 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 622
 623         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 624         Added file to fix the build. Sorry.
 625
 626         * src/dbus_api/Makefile.am:
 627         * src/dbus_api/modest-dbus-api.h:
 628         * src/dbus_api/modest-dbus-callbacks.h:
 629         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 630         (modest_dbus_req_handler):
 631         Put constants in a separate header so it can be reused by the
 632         client library, without duplication
 633
 634         * libmodest-dbus-client/Makefile.am:
 635         * libmodest-dbus-client/libmodest-dbus-client.c:
 636         (libmodest_dbus_client_call_helloworld),
 637         (libmodfest_dbus_client_send_mail),
 638         (libmodfest_dbus_client_mailto),
 639         (libmodfest_dbus_client_open_message):
 640         * libmodest-dbus-client/libmodest-dbus-client.h:
 641         (Partly) Implement a send_mail D-Bus method.
 642
 643         * tests/dbus_api/Makefile.am:
 644         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 645         the send_email D-Bus method.
 646
 647 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 648
 649         * Makefile.am:
 650         * configure.ac:
 651         * libmodest-dbus-client/Makefile.am:
 652         * libmodest-dbus-client/libmodest-dbus-client.c:
 653         * libmodest-dbus-client/libmodest-dbus-client.h:
 654         * tests/dbus_api/Makefile.am:
 655         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 656         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 657
 658 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 659
 660         * src/maemo/easysetup/modest-easysetup-wizard.c:
 661         (create_page_account_details):
 662         * src/maemo/modest-account-settings-dialog.c:
 663         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 664         widgets, because this might not be the default in future versions of the Maemo GTK+.
 665         However, I can not not get capitalization to work even in a simple test case.
 666
 667 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 668
 669         * src/maemo/easysetup/modest-easysetup-wizard.c:
 670         (create_page_custom_incoming), (create_page_custom_outgoing):
 671         * src/maemo/modest-account-settings-dialog.c:
 672         (create_page_account_details), (create_page_incoming),
 673         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 674         instead of using gtk_check_button_with_label(), so they are aligned like the other
 675         widgets, as per the UI spec.
 676
 677 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 678
 679         * src/maemo/easysetup/modest-easysetup-wizard.c:
 680         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 681         * src/widgets/modest-validating-entry.c:
 682         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 683         Modest prefix instead of an EasySetup prefix.
 684
 685 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 686
 687         * src/widgets/modest-validating-entry.h:
 688         * src/widgets/modest-validating-entry.c: (on_insert_text),
 689         Added easysetup_validating_entry_set_max_func(), used to set a callback
 690         to call when the max number of characters is reached. GtkEntry has a max-length
 691         already but is silent about it.
 692
 693         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 694         (create_page_account_details), (create_page_user_details),
 695         (create_account):
 696         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 697         (create_page_account_details), (create_page_user_details),
 698         (create_page_outgoing):
 699         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 700         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 701         the UI spec, when the user tries to enter more than the max number of characters.
 702
 703 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 704
 705         * src/maemo/easysetup/modest-easysetup-wizard.c:
 706         (create_page_user_details), (create_page_custom_incoming),
 707         (create_page_custom_outgoing):
 708         * src/maemo/modest-account-settings-dialog.c:
 709         (create_page_user_details), (create_page_incoming),
 710         (create_page_outgoing):
 711         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 712         (modest_connection_specific_smtp_edit_window_init):
 713         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 714         not appropriate. Bad Maemo-specific defaults!.
 715
 716 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 717
 718         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 719         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 720         (modest_signature_editor_dialog_set_settings):
 721         Disable the label and textview when the checkbox is disabled, and use the
 722         specified (UI spec) default signature text.
 723
 724 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 725
 726         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 727         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 728
 729         * src/modest-defs.h:
 730         * src/modest-account-mgr-helpers.h:
 731         * src/modest-account-mgr-helpers.c:
 732         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 733
 734         * src/maemo/Makefile.am:
 735         * src/maemo/modest-signature-editor-dialog.c:
 736         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 737         as per the UI spec.
 738
 739         * src/maemo/modest-account-settings-dialog.h:
 740         * src/maemo/modest-account-settings-dialog.c:
 741         (modest_account_settings_dialog_finalize), (on_button_signature),
 742         (save_configuration): Use the new dialog when the Edit button is pressed, and
 743         save the changes if necessary, as per the UI spec.
 744
 745 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 746
 747         * src/maemo/Makefile.am:
 748         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 749         based on maemo-develoers email from Dirk.
 750
 751         * src/maemo/easysetup/modest-easysetup-wizard.c:
 752         (create_page_welcome), (create_page_account_details),
 753         (create_page_user_details), (create_page_complete_easysetup),
 754         (create_page_custom_incoming), (create_page_custom_outgoing),
 755         (create_page_complete_custom),
 756         (modest_easysetup_wizard_dialog_init):
 757         * src/maemo/modest-account-settings-dialog.c:
 758         (create_page_account_details), (create_page_user_details),
 759         (create_page_incoming), (create_page_outgoing),
 760         (modest_account_settings_dialog_init):
 761         * src/maemo/modest-connection-specific-smtp-window.c:
 762         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 763
 764 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 765
 766         * src/maemo/easysetup/modest-easysetup-wizard.c:
 767         (create_page_account_details), (create_page_custom_outgoing),
 768         (create_page_complete_custom):
 769         * src/maemo/modest-account-settings-dialog.c:
 770         (create_page_user_details), (create_page_incoming),
 771         (create_page_outgoing):
 772         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 773         (modest_connection_specific_smtp_edit_window_init):
 774         Use the correct (UI spec) port min/max, and use horizontal separators,
 775         as per the UI spec.
 776
 777 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 778
 779         * src/maemo/easysetup/modest-easysetup-wizard.c:
 780         (set_default_custom_servernames):
 781         * src/maemo/modest-account-settings-dialog.c:
 782         (create_page_incoming), (on_combo_outgoing_security_changed),
 783         (on_combo_incoming_security_changed), (create_page_outgoing),
 784         (modest_account_settings_dialog_set_account_name),
 785         (save_configuration):
 786         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 787         (on_combo_security_changed),
 788         (modest_connection_specific_smtp_edit_window_init),
 789         (modest_connection_specific_smtp_edit_window_set_connection),
 790         (modest_connection_specific_smtp_edit_window_get_settings):
 791         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 792         as per the UI spec.
 793
 794 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 795
 796         * po/en_GB.po:
 797         * src/maemo/easysetup/modest-easysetup-wizard.c:
 798         (create_page_custom_outgoing), (create_page_complete_custom):
 799         * src/maemo/modest-account-settings-dialog.c:
 800         (create_page_user_details), (create_page_outgoing):
 801         * src/maemo/modest-account-view-window.c: (button_box_new):
 802         Use changed logical IDs as per the most recent UI spec:
 803         mcen_bd_emailsetup_edit -> mcen_bd_edit
 804         mcen_bd_emailsetup_delete -> mcen_bd_delete
 805         mcen_bd_emailsetup_close -> mcen_bd_close
 806
 807 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 808
 809         * configure.ac:
 810         * src/Makefile.am:
 811         * src/dbus_api/Makefile.am:
 812         * src/dbus_api/modest-dbus-callbacks.c:
 813         * src/dbus_api/modest-dbus-callbacks.h:
 814         * src/maemo/modest-platform.c: (modest_platform_init):
 815         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 816         method.
 817         * tests/Makefile.am:
 818         * tests/dbus_api/Makefile.am:
 819         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 820
 821 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 822
 823         * src/maemo/modest-account-settings-dialog.c:
 824         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 825         Removed unnecessary includes.
 826
 827 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 828
 829         * src/maemo/easysetup/modest-easysetup-wizard.c:
 830         * src/maemo/modest-account-settings-dialog.c:
 831         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 832         * src/widgets/Makefile.am:
 833         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 834         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 835         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 836         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 837         * src/widgets/modest-secureauth-combo-box.c:
 838         * src/widgets/modest-secureauth-combo-box.h:
 839         * src/widgets/modest-serversecurity-combo-box.c:
 840         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 841         made the GObject names more consistent with the rest of the Modest code.
 842
 843 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 844
 845         * src/maemo/easysetup/Makefile.am:
 846         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 847         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 848         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 849         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 850         * src/maemo/easysetup/modest-easysetup-wizard.c:
 851         * src/maemo/easysetup/modest-validating-entry.c:
 852         * src/maemo/easysetup/modest-validating-entry.h:
 853         * src/maemo/modest-account-settings-dialog.c:
 854         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 855         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 856         widgets/ because they are used outside of easysetup too. After checking in,
 857         svn will allow me to rename them too.
 858
 859 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 860
 861         * src/gnome/modest-msg-edit-window.c:
 862         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 863         linker error, to fix the build on the GNOME platform.
 864         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 865         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 866         ifdefed out to avoid a warning.
 867
 868 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 869
 870         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 871         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 872         some alternative for GTK+ 2.6.
 873
 874 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 875
 876         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 877
 878         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 879         specified for EmailAccountsDialog in UI spec.
 880
 881         * src/maemo/easysetup/modest-easysetup-wizard.c:
 882         * src/maemo/easysetup/modest-easysetup-wizard.h:
 883         * src/maemo/modest-account-settings-dialog.c:
 884         * src/maemo/modest-account-settings-dialog.h:
 885         Reuse a member window widget for the connection-specific SMTP server accounts,
 886         so we can tell it to create/save the accounts only if we actually save changes.
 887
 888         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 889         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 890         (modest_connection_specific_smtp_edit_window_get_settings):
 891         Return a struct instance for temporarily remembering the entered data.
 892
 893         * src/maemo/modest-connection-specific-smtp-window.h:
 894         * src/maemo/modest-connection-specific-smtp-window.c:
 895         (modest_connection_specific_smtp_window_finalize),
 896         (modest_connection_specific_smtp_window_fill_with_connections),
 897         (on_button_edit),
 898         (modest_connection_specific_smtp_window_save_server_accounts),
 899         (update_model_server_names): Do not actually save data until asked,
 900         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 901
 902         (on_selection_changed),
 903         (modest_connection_specific_smtp_window_init): Disable the edit
 904         button when nothing is selected.
 905
 906         * src/modest-account-mgr-helpers.c:
 907         * src/modest-account-mgr-helpers.h:
 908         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 909         elsewhere.
 910
 911 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 912
 913         * src/modest-account-mgr-helpers.h:
 914         * src/modest-account-mgr-helpers.c:
 915         (modest_account_mgr_get_unused_account_name),
 916         (modest_account_mgr_get_unused_account_display_name): Added these
 917         utility functions, to avoid code duplication.
 918
 919         * src/maemo/easysetup/modest-easysetup-wizard.c:
 920         (create_page_account_details), (create_account):
 921         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 922         (on_combo_security_changed),
 923         (modest_connection_specific_smtp_edit_window_init),
 924         (modest_connection_specific_smtp_edit_window_save_settings):
 925         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 926         * src/maemo/modest-connection-specific-smtp-window.c:
 927         (modest_connection_specific_smtp_window_finalize),
 928         (modest_connection_specific_smtp_window_fill_with_connections),
 929         (on_button_edit), (modest_connection_specific_smtp_window_init):
 930         * src/maemo/modest-connection-specific-smtp-window.h:
 931         Implementing saving of connection-specific server accounts.
 932
 933         But I need to refactor this so we can save the data for each
 934         possible connection-specific account and only actually create the server accounts
 935         when the easysetup finished, or the OK button is pressed on the account settings
 936         dialog.
 937
 938 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 939
 940         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 941         (on_combo_security_changed):
 942         (modest_connection_specific_smtp_edit_window_init):
 943         Auto-fill the port number as in the account settings.
 944
 945         (modest_connection_specific_smtp_edit_window_set_connection):
 946         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 947         * src/maemo/modest-connection-specific-smtp-window.c:
 948         (fill_with_connections), (on_button_edit),
 949         (modest_connection_specific_smtp_window_init):
 950         Turn the edit window into a dialog to simplify the code, and
 951         set a WM hint as in a GtkDialog, because only a popup can be on top of
 952         another window in Maemo, and popups usually have no WM decoration.
 953
 954         * src/modest-defs.h:
 955         * src/modest-account-mgr-helpers.c:
 956         (modest_account_mgr_set_connection_specific_smtp),
 957         (modest_account_mgr_remove_connection_specific_smtp),
 958         (modest_account_mgr_get_connection_specific_smtp):
 959         * src/modest-account-mgr-helpers.h: Some functions to write the
 960         connection-specific SMTP server information. Not yet used.
 961
 962
 963         * src/widgets/modest-folder-view.c: (text_cell_data):
 964         Fix a warning about an uninitialized variable.
 965         (on_configuration_key_changed): Put an #ifdef around the use
 966         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 967
 968 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 969
 970         * src/maemo/modest-account-settings-dialog.h:
 971         * src/maemo/modest-account-settings-dialog.c:
 972         Added connect_for_modified() utility function to mark the new modified boolean.
 973
 974         (create_page_account_details), (create_page_user_details),
 975         (create_page_incoming), (create_page_outgoing), (on_response),
 976         (modest_account_settings_dialog_init),
 977         (modest_account_settings_dialog_set_account_name):
 978         Only warn about unsaved changes when there are actually unsaved changes.
 979
 980         * src/modest-account-mgr-helpers.c:
 981         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 982         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 983         to get the data from there in future.
 984
 985 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 986
 987         * src/modest-defs.h:
 988
 989         * src/modest-account-mgr-helpers.h:
 990         * src/modest-account-mgr-helpers.c:
 991         Store the security account setting in a single conf key instead of using
 992         the options list, so that the list is left for just the to-be-removed camel hack,
 993         and because gconf_client_set_list() is failing for some reason.
 994
 995         * src/modest-account-mgr.c:
 996         (modest_account_mgr_add_server_account):
 997         * src/maemo/modest-account-settings-dialog.c:
 998         (modest_account_settings_dialog_set_account_name),
 999         (save_configuration): Use the renamed functions.
1000
1001
1002 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1003
1004         * src/widgets/Makefile.am:
1005         * src/widgets/modest-limit-retrieve-combo-box.c:
1006         * src/widgets/modest-limit-retrieve-combo-box.h:
1007         * src/widgets/modest-retrieve-combo-box.c:
1008         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1009         the account settings dialog.
1010
1011         * src/modest-defs.h:
1012         * src/modest-account-mgr-helpers.h:
1013         * src/modest-account-mgr-helpers.c:
1014         (modest_server_account_get_option_secure_auth),
1015         (modest_server_account_set_option_secure_auth):
1016         * src/modest-account-mgr.c:
1017         (modest_account_mgr_add_server_account):
1018         Use the existing AUTH_MECH conf key for the secure-auth setting,
1019         instead of putting it in the list options, because this was actually used already.
1020
1021         * src/maemo/modest-account-settings-dialog.c:
1022         (create_page_account_details),
1023         (modest_account_settings_dialog_set_account_name),
1024         (save_configuration):
1025         * src/maemo/modest-account-settings-dialog.h:
1026         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1027         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1028
1029 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1030
1031         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1032         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1033         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1034
1035         * src/modest-defs.h:
1036         * src/maemo/modest-account-settings-dialog.c:
1037         (create_page_incoming), (on_combo_outgoing_security_changed),
1038         (on_combo_incoming_security_changed), (create_page_outgoing),
1039         (modest_account_settings_dialog_set_account_name),
1040         (save_configuration): Load/Save the port number, and change it when the
1041         security combo changes, to suitable defaults.
1042
1043 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1044
1045         * src/modest-account-mgr.c:
1046         (modest_account_mgr_add_server_account): Set the security and secure-auth
1047         options, and add a comment saying that the other camel-specific options should be
1048         removed in future.
1049
1050 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1051
1052         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1053         found by valgrind.
1054         * src/modest-tny-account-store.c: (account_list_free),
1055         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1056         cursor->data after unreffing it. But there is some strange stuff there so it might not be
1057         easy to fix.
1058
1059 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1060
1061         * src/modest-protocol-info.c:
1062         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1063         is required by our UI spec. Maybe something in our implementation will use this eventually.
1064         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1065         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1066         instead of the previous 0 placeholder.
1067
1068         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1069         secure-auth settings.
1070         * src/modest-account-mgr-helpers.h:
1071         * src/modest-account-mgr-helpers.c:
1072         (modest_server_account_data_get_option_secure_auth),
1073         (modest_server_account_set_option_secure_auth),
1074         (modest_server_account_data_get_option_security),
1075         (modest_server_account_set_option_security): Added this API for getting and setting the security
1076         and secure-auth settings.
1077
1078         * src/maemo/modest-account-settings-dialog.h:
1079         * src/maemo/modest-account-settings-dialog.c:
1080         (modest_account_settings_dialog_finalize), (check_data),
1081         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1082         about changing titles.
1083         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1084         (save_configuration): Save the security and secure-auth settings.
1085
1086         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1087         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1088
1089 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1090
1091         * src/modest-defs.h:
1092         * src/modest-account-mgr.c:
1093         (modest_account_mgr_add_server_account):
1094         Added and used defines for the options key and value pair strings,
1095         that are used so far, though they do not seem to correspond to anything in our
1096         UI specs or ModestProtocol enum.
1097
1098         * src/modest-account-mgr-helpers.h:
1099         * src/modest-account-mgr-helpers.c:
1100         (compare_option_strings_for_name),
1101         (modest_server_account_data_get_option_value),
1102         (modest_server_account_data_get_option_bool),
1103         (modest_account_mgr_get_server_account_option):
1104         Added helper functions for parsing the options GSList.
1105
1106 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1107
1108         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1109         display name is based on the supplied account name.
1110         * src/modest-account-mgr.c:
1111         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1112         with an inefficient, but good-enough, implementation.
1113
1114         * src/maemo/easysetup/modest-easysetup-wizard.c:
1115         (create_page_account_details), (on_before_next), (create_account):
1116         Check for existing display names rather than (non-user-visible) account names, and just
1117         create and set a unique account name at the end.
1118
1119         * src/maemo/modest-account-settings-dialog.c:
1120         (modest_account_settings_dialog_init),
1121         (modest_account_settings_dialog_set_account_name),
1122         (create_page_incoming): Show the display name, instead of the account name.
1123         (on_response): Do some (not all) extra checks, as in the UI spec.
1124         (save_configuration): Save the display name if it was changed.
1125
1126 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1127
1128         * po/en_GB.po: Added needed logical ID and translation.
1129         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1130         (init_view): Made the is-default column clicking work.
1131
1132 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1133
1134         * configure.ac:
1135         * src/maemo/easysetup/Makefile.am:
1136         * src/maemo/easysetup/modest-easysetup-wizard.c:
1137         (modest_easysetup_wizard_dialog_init):
1138         * src/maemo/easysetup/provider-data-test.keyfile:
1139         * src/maemo/easysetup/provider-data.keyfile:
1140         Moved the provider data file to the new modest-providers-data package and used it from there.
1141
1142 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1143
1144         * src/modest-local-folder-info.c:
1145         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1146         N_() was already used on the static strings, but this just marks it for translation without
1147         using the translation.
1148
1149 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1150
1151         * src/maemo/modest-account-settings-dialog.c:
1152         (create_page_incoming),
1153         (modest_account_settings_dialog_set_account_name):
1154         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1155         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1156         I will do this if nobody else gets there first.
1157
1158 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1159
1160         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1161         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1162         save the security stuff.
1163
1164 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1165
1166         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1167         Set the email address and user fullname, which I now see must be
1168         done separately.
1169
1170         * src/maemo/modest-account-settings-dialog.h:
1171         * src/maemo/modest-account-settings-dialog.c:
1172          (on_response),
1173         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1174         leave-on-server and authentication.
1175         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1176         how to do the rest.
1177
1178 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1179
1180
1181         * src/maemo/modest-account-settings-dialog.c:
1182         * src/maemo/modest-account-settings-dialog.h:
1183         Most (but not all) of the widgets are now present as specified by the UI spec.
1184         No changes are yet saved, and some details are not properly shown yet.
1185
1186         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1187
1188 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1189
1190         * src/maemo/Makefile.am:
1191         * src/maemo/modest-account-settings-dialog.c:
1192         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1193         an existing account. Doesn't do much yet.
1194
1195         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1196         Open the accounts settings dialog when Edit is clicked.
1197
1198 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1199
1200         * src/maemo/easysetup/Makefile.am:
1201         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1202         (load_from_file):
1203         * src/maemo/easysetup/modest-easysetup-wizard.c:
1204         (modest_easysetup_wizard_dialog_init):
1205         Try to get the source directory from the build system,
1206         instead of hard-coding "./" into the source code, when opening our local
1207         copies of the configuration files.
1208         But this still fails when opening the wizard from the Accounts window,
1209         maybe because the working directory seems to change at runtime.
1210         So the wizard will fail the second time unless you copy the files into their
1211         proper locations - see the stdout warnings for the paths.
1212
1213         (create_page_account_details),(on_before_next):
1214         Check for existing non-server accounts instead of server accounts,
1215         so the default account name is useful again, and to prevent trying to
1216         recreate accounts.
1217
1218         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1219         Show the wizard when New is clicked.
1220
1221         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1222         (init_view): Show the column headers, and show the columns that are
1223         specified in the UI specs. However, something in Maemo's GTK+ prevents
1224         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1225         change the default account. This is despite unsetting the special properties.
1226
1227 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1228
1229         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1230         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1231         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1232         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1233         to make that clearer.
1234         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1235
1236 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1237
1238         * src/maemo/modest-account-view-window.c:
1239         (modest_account_view_window_init),
1240         (modest_account_view_window_new):
1241         Use the same buttons as specified in the
1242         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1243         the existing widgets, which never had a chance of working.
1244         Put the ModestAccountView treeview in a scrolled window.
1245         Do not repeat the initialization in both _init() and _new().
1246
1247         * src/widgets/modest-account-view.c: (update_account_view):
1248         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1249         this widget and window shows no accounts.
1250
1251         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1252
1253 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1254
1255         * src/maemo/easysetup/modest-easysetup-wizard.c:
1256         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1257         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1258         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1259         which seems wrong.
1260
1261         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1262         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1263         accounts exist yet, as in the UI spec.
1264
1265         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1266
1267 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1268
1269         * src/maemo/Makefile.am:
1270         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1271         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1272         New window for editing connection-specific smtp details.
1273         Not fully implemented.
1274
1275         * src/maemo/modest-connection-specific-smtp-window.c:
1276         (modest_connection_specific_smtp_window_finalize) :
1277         unref the tree model.
1278         (on_button_edit): Show the edit window.
1279
1280 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1281
1282         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1283         error for me.
1284
1285         * src/maemo/Makefile.am:
1286         * src/maemo/modest-connection-specific-smtp-window.c:
1287         * src/maemo/modest-connection-specific-smtp-window.h:
1288         New window for showing the list of connections, for connection-specific
1289         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1290         * src/maemo/easysetup/modest-easysetup-wizard.c:
1291         (create_page_custom_outgoing): Show the new window when the button is clicked.
1292
1293 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1294
1295         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1296         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1297         * src/maemo/modest-msg-edit-window.c:
1298         (modest_msg_edit_window_insert_image):
1299         * src/modest-conf.c: (modest_conf_key_escape):
1300         * src/modest-mail-operation.c:
1301         (modest_mail_operation_send_new_mail):
1302         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1303         (modest_ui_actions_on_new_account):
1304         * src/widgets/modest-attachment-view.c: (update_filename_request):
1305         * src/widgets/modest-mail-header-view.c:
1306         Corrected warnings that were breaking the build, by commenting out unused variables,
1307         and a function, and by including a header.
1308
1309 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1310
1311         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1312         so we can #ifdef around platform-specific code when necessary.
1313         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1314         to allow this to build for the GNOME platform too.
1315
1316 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1317
1318         * src/maemo/easysetup/modest-easysetup-wizard.c:
1319         Added util_increment_name() and used it in create_page_account_details()
1320         to make sure that the default account name is always a new name.
1321
1322         (modest_easysetup_wizard_dialog_init),
1323         (set_default_custom_servernames): Some minor memory management fixes.
1324
1325 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1326
1327         * Makefile.am:
1328         * configure.ac:
1329         * src/modest-runtime.c: (init_i18n): Restored the translation
1330         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1331         are defined in config.h, and the translations are installed.
1332
1333         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1334         is defined for translation.
1335
1336 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1337
1338         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1339         (load_from_file):
1340         * src/maemo/easysetup/modest-easysetup-wizard.c:
1341         (modest_easysetup_wizard_dialog_init):
1342         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1343         Use realistic paths (though they should use $prefix generically) to the
1344         mcc_mapping and provider-data.keyfile files which might work when they
1345         are installed by the future version of the operator-wizard package,
1346         and then fallback to paths in our source code, with an explanatory
1347         warning.
1348
1349 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1350
1351         * configure.ac:
1352         * src/Makefile.am:
1353         * src/maemo/Makefile.am:
1354         * src/maemo/easysetup/: Added files from the previously-exernal
1355         osso-modest-easysetup.
1356         * src/maemo/modest-main-window-ui.h:
1357         * src/modest-ui-actions.c:
1358         * src/modest-ui-actions.h:
1359         Added modest_ui_actions_on_new_account() as a signal handler for the
1360         New Account menu item. It shows the easysetup wizard.
1361         * po/en_GB.po: Added additional needed logical IDs and translations.
1362
1363 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1364 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1365