1 2007-06-12 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (get_server_accounts):
4 Call modest_tny_local_folders_account_add_merged_outbox_folders()
5 even when there are no accounts, so that the Outbox folder is always
6 visible. This fixes projects.maemo.org bug NB#60158.
8 2007-06-12 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/modest-main-window.c: (create_details_widget):
11 Use the mcen_va_never logical ID.
13 2007-06-12 Murray Cumming <murrayc@murrayc.com>
15 * src/dbus_api/modest-dbus-api.h:
16 * src/dbus_api/modest-dbus-callbacks.c:
17 (on_idle_open_default_inbox), (on_open_default_inbox),
18 (modest_dbus_req_handler):
19 Added a new OpenDefaultInbox method.
21 * libmodest-dbus-client/libmodest-dbus-client.h:
22 * libmodest-dbus-client/libmodest-dbus-client.c:
23 Added libmodest_dbus_client_open_default_inbox() to call the new
24 dbus method. This should be useful to projects.maemo.org bug NB#57214,
25 though it should maybe be used by a new osso-email-interface function.
27 * tests/dbus_api/Makefile.am:
28 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
31 2007-06-12 Murray Cumming <murrayc@murrayc.com>
33 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
34 NULL, so that the signals get all the keys. This should not actually
35 change any behaviour because we currently update everything when anything
38 2007-06-12 Murray Cumming <murrayc@murrayc.com>
40 * src/widgets/modest-folder-view.c: (text_cell_data),
41 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
42 (find_inbox_iter): If tinymail tells us that the folder is
43 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
44 This causes the inbox to be selected at startup, fixing part of
45 projects.maemo.org bug NB#56305.
47 * src/modest-ui-dimming-rules.c:
48 (modest_ui_dimming_rules_on_tools_smtp_servers):
49 * src/modest-ui-dimming-rules.h: Added a callback function to dim
50 the SMTP servers menu item.
51 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
52 that the SMTP Servers menu item is dimmed when there are no accounts,
53 as a future version of the UI spec will require. This fixes
54 projects.maemo.org bug NB#56305.
56 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
58 * src/maemo/modest-maemo-utils.c:
59 (modest_maemo_utils_get_supported_secure_authentication_methods):
60 Added label to dialog instead of unreadable title
62 * src/maemo/modest-main-window.c: (sync_accounts_cb),
63 (modest_main_window_new):
64 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
67 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
68 * src/modest-account-mgr.h:
69 Added method to avoid code duplication
71 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
72 (modest_ui_actions_on_send_receive):
73 Use modest_account_mgr_has_accounts
75 2007-06-11 Murray Cumming <murrayc@murrayc.com>
77 * src/maemo/easysetup/modest-presets.c:
78 (modest_presets_get_info_server_security): Do not report secure auth
80 * src/modest-protocol-info.c: Use the defines for the gconf key names
81 for secure authentication. This was not working because we were writing
82 Password and reading password, and the check was case sensitive.
83 With this, gmail now works for receiving and sending when created via
86 2007-06-11 Murray Cumming <murrayc@murrayc.com>
88 * src/maemo/easysetup/modest-presets.c:
89 (modest_presets_get_info_server_security): Correct the key name for
90 SecureSmtp, because it seems to be case-sensitive.
91 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
92 Do not try to get the 0th notebook page if there are 0 pages, to
95 2007-06-11 Murray Cumming <murrayc@murrayc.com>
97 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
98 Prevent use of the new notification feature for now, because it currently
99 shows one dialog for each new email, which is annoying.
101 2007-06-11 Murray Cumming <murrayc@murrayc.com>
103 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
104 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
105 when no country was selected, so that we show the global ones.
106 * src/maemo/easysetup/modest-presets.c:
107 (modest_presets_get_providers): Return only the global providers, not
108 all providers when mmc=0 was requested.
110 2007-06-11 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
113 (easysetup_provider_combo_box_fill): Remove debug code that showed the
114 provider ID in the combo.
116 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
117 Do not show the page numbers, because it would be confusing when we add
118 the 2 extra pages for the custom setup, when the user chooses the "Other"
119 provider. This fixes projects.maemo.org bug NB#59028
121 * src/modest-init.c: (modest_init_init_core),
122 (modest_init_local_folders):
124 * src/modest-tny-account.c:
125 (modest_tny_account_new_for_local_folders): Do not create default folders
126 for the memory card. This should fix projects.maemo.org bug NB#59328.
128 2007-06-11 Murray Cumming <murrayc@murrayc.com>
130 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
131 Free the changed_conf_keys string items. They are already freed in the
132 idle handler if that runs first.
134 2007-06-11 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-ui-actions.c:
137 (modest_ui_actions_on_password_requested): Check that the server name
138 is not NULL, because I just saw a password dialog with (null) as the
141 * src/modest-tny-folder.[h|c]: Added
142 modest_tny_folder_is_memory_card_folder().
143 * src/modest-ui-dimming-rules.c:
144 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
145 menu item for memory cards, as per the UI spec (section 7.4). This should
146 fix projects.maemo.org bug NB#59297.
148 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
150 * src/maemo/modest-main-window.c: (sync_accounts_cb):
151 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
152 is another problem with the code, see Murray's comment at line 772)
154 2007-06-08 Murray Cumming <murrayc@murrayc.com>
156 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
157 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
158 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
159 (load_from_file), (easysetup_country_combo_box_init),
160 (easysetup_country_combo_box_get_active_country_ids),
161 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
162 instead of just one ID, to avoid duplicate country names in the UI.
164 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
165 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
166 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
167 a single ID, avoiding duplicate providers.
168 * src/maemo/easysetup/modest-easysetup-wizard.c:
169 (on_combo_account_country): Adapt to use a list.
171 2007-06-08 Murray Cumming <murrayc@murrayc.com>
173 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
174 keys changed in the last X seconds.
176 * src/modest-account-mgr.h:
177 * src/modest-account-mgr.c: (on_timeout_notify_changes),
178 (on_key_change), (modest_account_mgr_class_init),
179 (modest_account_mgr_init), (modest_account_mgr_finalize):
180 As the keys are changed, save them in a GSList* and signal that GSList*
181 further every X seconds, to batch changes, to allow us to do just one
182 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
183 bug NB#56941 and other (UI-blocking) delays when changing account settings.
185 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
186 changed signal signature.
188 * src/modest-conf.c: (modest_conf_set_list),
189 (modest_conf_on_change): Reenable notification.
191 (modest_conf_maemo_fake_on_change): Comment out the hack that
192 notified immediately instead of asynchronously.
194 * src/widgets/modest-account-view.h:
195 * src/widgets/modest-account-view.c:
196 (update_account_view): Select the previously-selected account ID,
197 if possible. This fixes projects.maemo.org bug NB#56933.
199 (on_account_changed), (on_account_removed),
200 (modest_account_view_select_account):
202 Remove the block/unblock functions
203 because they were not useful.
205 * src/maemo/modest-account-view-window.c:
206 (on_delete_button_clicked), (on_edit_button_clicked),
207 (on_new_button_clicked): Remove the use of the non-working block/unblock.
209 2007-06-08 Murray Cumming <murrayc@murrayc.com>
211 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
212 Improve the error dialog to show Incorrect Account Settings, which seems
213 clearer, and say that the internal error message (to be removed from the
214 dialog later) is often misleading.
215 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
217 * src/modest-tny-account.c:
218 (modest_tny_account_new_from_server_account): Uncomment the printf of the
219 URL because this is so useful for debugging on the device.
221 * src/widgets/modest-serversecurity-combo-box.c:
222 (modest_serversecurity_combo_box_fill): Correct a logical ID.
224 2007-06-08 Murray Cumming <murrayc@murrayc.com>
226 * src/modest-mail-operation.c:
227 (modest_mail_operation_send_new_mail):
228 Added a comment about a nasty but apparently harmless message. Details
229 added to the wiki g_warnings() page.
231 2007-06-08 Murray Cumming <murrayc@murrayc.com>
233 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
234 (modest_tny_send_queue_class_init):
235 Do not use the priv struct because it is empty, to avoid g_warnings
236 about a non-existant priv struct.
238 * src/modest-tny-account-store.c:
239 (modest_tny_account_store_get_server_account),
240 (modest_tny_account_store_get_transport_account_for_open_connection
241 ): Do not try to get transport server accounts for local folders,
242 because they don't have any. This avoids a g_warning().
244 * src/maemo/modest-main-window.c:
245 (modest_main_window_notify_send_receive_initied),
246 (on_configuration_key_changed):
247 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
249 * src/modest-mail-operation.c:
250 (modest_mail_operation_update_account):
251 * src/modest-tny-account-store.h:
252 * src/modest-tny-account.c:
253 (modest_tny_account_get_special_folder),
254 (modest_tny_account_new_for_local_folders),
255 (modest_tny_account_new_for_per_account_local_outbox_folder):
256 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
257 * src/modest-tny-local-folders-account.c:
258 (add_account_folders_to_merged_folder):
259 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
260 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
261 (modest_ui_actions_on_send):
262 * src/widgets/modest-folder-view.c: (update_model):
263 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
264 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
265 modest_tny_account_store_get_tny_account_by_account() to
266 modest_tny_account_store_get_server_account() to make the code clearer.
268 2007-06-07 Marcus Bauer <marcusb@openismus.com>
270 * src/dbus_api/modest-dbus-api.h:
271 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
272 * src/maemo/modest-msg-edit-window.c:
273 (modest_msg_edit_window_attach_file_noninteractive):
274 added g_warning in case the file to be attached does not exist
275 * tests/dbus_api/test_compose_mail.c: (main):
276 removed obsolete comment, added generic files as test case
278 2007-06-07 Murray Cumming <murrayc@murrayc.com>
280 * src/modest-tny-account-store.c: (get_server_accounts):
281 Create the local folders account only once, not once for each outbox, and
282 not only when there are some outboxes.
284 2007-06-07 Murray Cumming <murrayc@murrayc.com>
286 * src/widgets/modest-folder-view.c: (update_model): Comment out some
287 code that is causing a crash at startup. Sergio says that he is fixing this.
289 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
291 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
292 * src/maemo/modest-account-settings-dialog.c:
293 (create_page_outgoing),
294 (modest_account_settings_dialog_set_account_name),
295 (save_configuration):
296 - Fixed handling of the "Use secure authentication" toggle to comply with
297 the ui specification. See also projects.maemo.org bug NB#58400
299 - Restore the Secure connection setting combo correctly when loading
302 * src/maemo/modest-maemo-utils.c:
303 (on_camel_account_get_supported_secure_authentication),
304 (modest_maemo_utils_get_supported_secure_authentication_methods):
305 Fixed a crasher if operation is canceled
307 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
308 (modest_protocol_info_auth_is_secure):
309 * src/modest-protocol-info.h:
311 Added two new methods to determine if a protocol/auth method is secure/encrypted in
312 the sense of the "Use secure authentication" toggle.
314 2007-06-07 Murray Cumming <murrayc@murrayc.com>
316 * src/modest-tny-account-store.h:
317 * src/modest-tny-account-store.c:
318 Added modest_tny_account_store_get_local_folders_account().
320 * src/modest-tny-folder.h:
321 * src/modest-tny-folder.c:
322 (modest_tny_folder_get_account):
323 Added this replacement for tny_folder_get_account() which returns
324 the local-folders account for TnyMergeFolders, to avoid the
325 warning about the unimplemented get_account_func() vfunc().
327 (modest_tny_folder_get_rules),
328 * src/modest-ui-actions.c:
329 (modest_ui_actions_on_folder_selection_changed):
330 * src/modest-mail-operation.c:
331 (modest_mail_operation_remove_folder),
332 (modest_mail_operation_xfer_folder),
333 (modest_mail_operation_rename_folder),
334 (modest_mail_operation_get_msg),
335 (modest_mail_operation_get_msgs_full),
336 (modest_mail_operation_remove_msg),
337 (modest_mail_operation_xfer_msgs),
338 (modest_mail_operation_refresh_folder):
339 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
341 2007-06-07 Murray Cumming <murrayc@murrayc.com>
343 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
344 (modest_server_account_set_security):
345 * src/modest-defs.h: Add comments explaining that our
346 UI spec means TLS when it says Normal, so these do not look like errors.
348 * src/modest-tny-account.c:
349 (modest_tny_account_new_from_server_account): Use the new tinymail
350 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
351 for TLS. This should fix projects.maemo.org bug NB#58460.
353 2007-06-06 Murray Cumming <murrayc@murrayc.com>
355 * src/maemo/easysetup/modest-easysetup-wizard.c:
356 (create_account): Correct the position of the gconf sanity check warning.
357 (on_button_edit_advanced_settings): Show the dialog immediately, instead
358 of using the g_idle_add() hack, because this does not seem to be necessary
359 on osso 1.1. It might even work on Maemo Bora if the problems were actually
360 caused by something other than maemo's gconf.
361 This fixes projects.maemo.org bug #59022.
363 2007-06-06 Murray Cumming <murrayc@murrayc.com>
365 * src/modest-account-mgr-helpers.c:
366 (modest_account_mgr_get_default_account): Do not check that the account
367 exists if there is no default account (NULL), to fix a runtime warning.
369 2007-06-06 Murray Cumming <murrayc@murrayc.com>
371 * src/widgets/modest-folder-view.c: (update_model):
372 Do not unref the treemodel before we have finished with it.
373 This prevents a valgrind warning and an occasional crash at startup.
375 2007-06-06 Marcus Bauer <marcusb@openismus.com>
377 * libmodest-dbus-client/libmodest-dbus-client.h:
378 added libmodest_dbus_client_compose_mail()
379 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
381 added functions needed for SendAsMail() functionality
382 * src/maemo/modest-msg-edit-window.c:
383 (modest_msg_edit_window_attach_file_noninteractive):
384 non interactively attaching files to message edit window
385 * src/widgets/modest-msg-edit-window.h:
386 * tests/dbus_api/Makefile.am:
387 added test_compose_mail.c
388 * tests/dbus_api/test_compose_mail.c: (main):
390 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
392 * src/modest-account-view.c:
393 Fixed bug projects.maemo.org bug NB#59307
395 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
397 * src/maemo/easysetup/modest-easysetup-wizard.c:
398 (get_serverport_incoming), (on_before_next), (create_account):
399 * src/maemo/modest-account-settings-dialog.c:
400 (modest_account_settings_dialog_set_account_name):
401 * src/maemo/modest-maemo-utils.c:
402 (on_camel_account_get_supported_secure_authentication_status),
403 (on_camel_account_get_supported_secure_authentication),
404 (on_secure_auth_cancel),
405 (modest_maemo_utils_get_supported_secure_authentication_methods):
407 Implemented security authentication for settings and easysetup.
409 2007-06-05 Murray Cumming <murrayc@murrayc.com>
411 * src/maemo/modest-main-window.c: (create_details_widget):
412 Show the total size for memory card accounts too, instead of showing
413 the name again. Fixes bug projects.maemo.org bug NB#59307.
415 2007-06-05 Murray Cumming <murrayc@murrayc.com>
418 * src/modest-tny-simple-folder-store.c:
419 * src/modest-tny-simple-folder-store.h: Removed.
421 * src/modest-tny-local-folders-account.h
422 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
423 for the local-folders maildir, with an extra TnyMergedFolder containing
424 the folders of the per-account outbox store accounts.
425 * src/modest-tny-account-store.c: (get_server_accounts):
426 Add the outboxes to the special local folders account after creating it.
428 * src/modest-tny-account.c:
429 (modest_tny_account_new_for_local_folders): Create the derived
430 account when creating the main local-folders account.
432 * src/maemo/modest-main-window.c: (create_details_widget),
433 (modest_main_window_set_contents_style):
434 Adapted to the use of the derived account instead of the folder store.
436 * src/modest-ui-actions.c:
437 (modest_ui_actions_on_folder_selection_changed):
438 * src/modest-ui-dimming-rules.c:
439 (modest_ui_dimming_rules_on_new_folder):
440 * src/widgets/modest-folder-view.c: (text_cell_data),
441 (icon_cell_data), (filter_row), (update_model),
442 (get_cmp_rows_type_pos):
445 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
446 Do not get the priv struct, because no priv struct has been set,
447 to avoid a runtime warning.
449 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
450 #ifelse with #else, to fix a warning, to fix the build.
453 2007-06-05 Christian Kellner <ckellner@openismus.com>
455 * libmodest-dbus-client/libmodest-dbus-client.c:
456 Fix small typo in doc (why do you always see them
457 AFTER committing stuff?)
460 2007-06-05 Christian Kellner <ckellner@openismus.com>
462 * libmodest-dbus-client/libmodest-dbus-client.c:
463 (libmodest_dbus_client_search):
464 Initialize hit list with NULL. Also set folder list
465 to "" if NULL was supplied.
468 2007-06-03 Christian Kellner <ckellner@openismus.com>
470 * libmodest-dbus-client/libmodest-dbus-client.c:
471 (modest_search_hit_list_free):
472 Make it save to call it with NULL.
474 * src/dbus_api/modest-dbus-callbacks.c:
475 * src/modest-search.c:
476 Return full ModestSearchHits as the search result list not TnyHeader
477 since can't be around withouth the correspoding TnyFolder.
479 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
481 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
482 Added currently commented code to check for secure auth
484 * src/maemo/modest-account-settings-dialog.c: (on_response),
485 (save_configuration), (show_ok):
486 Fixed projects.maemo.org bugs NB #59248 and #59251
488 * src/maemo/modest-maemo-utils.c:
489 (on_camel_account_get_supported_secure_authentication_status),
490 (on_camel_account_get_supported_secure_authentication),
491 (modest_maemo_utils_get_supported_secure_authentication_methods):
492 * src/maemo/modest-maemo-utils.h:
493 Moved get_supported_secure_authentication() method here to be able
494 to use it from easysetup wizard.
496 * src/modest-pair.c: (on_pair_compare_as_string):
497 Should compare string with first part of pair and not
498 strcmp pairs which will crash.
500 * src/modest-protocol-info.c:
501 (modest_protocol_info_protocol_is_store):
502 * src/modest-protocol-info.h:
503 Added modest_protocol_info_get_auth_protocol_name()
505 2007-06-03 Armin Burgmeier <armin@openismus.com>
507 * src/modest-mail-operation.c:
508 (modest_mail_operation_get_msgs_full): Set priv->account also when
509 only retrieving a single message. This avoids a crash when canceling
512 (modest_mail_operation_notify_end): Do not explicitely remove the
513 operation from the queue but only emit the progress_changed signal.
514 The queue itself listens to that signal to remove the operation when
515 it is finished. This reduces coupling and removes a potential deadlock
516 when modest_mail_operation_notify_end() is called from the queue
517 itself. If that is a problem performance-wise, I would suggest to
518 implement a status-changed signal or something.
520 * src/modest-mail-operation-queue.c: Make sure to never call a
521 function from another file while the queue is locked. This (hopefully)
522 fixes another deadlock when exiting the application while retrieving
525 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
527 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
528 Fixed build if libogs is not available
530 2007-06-03 Christian Kellner <ckellner@openismus.com>
532 * libmodest-dbus-client/libmodest-dbus-client.h:
533 * libmodest-dbus-client/libmodest-dbus-client.c:
534 (libmodest_dbus_client_delete_message):
535 Implement deletion of messages (Client side).
537 (modest_search_hit_free),
538 (modest_search_hit_list_free):
539 Utility functions to free the result hits.
541 * src/dbus_api/modest-dbus-api.h:
542 * src/dbus_api/modest-dbus-callbacks.c:
544 (modest_dbus_req_handler):
545 Implement deletion of messages (Server side).
547 * tests/dbus_api/test_search.c: (main):
550 * tests/dbus_api/Makefile.am:
551 * tests/dbus_api/test_delete_message:
552 Add little test for the message deletion logic
554 2007-06-03 Armin Burgmeier <armin@openismus.com>
556 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
557 when the operation queue was not empty. projects.maemo.org bug
560 2007-06-03 Armin Burgmeier <armin@openismus.com>
562 * src/widgets/modest-account-view.c
563 (on_account_default_toggled): Toggle default account column
564 explicitely instead of waiting for gconf notification (which is
565 currently ignored). This should fix projects.maemo.org bug NB#56910
566 for now. It should probably be removed when gconf notifications are
569 2007-06-03 Christian Kellner <ckellner@openismus.com>
571 * libmodest-dbus-client/libmodest-dbus-client.c:
572 Removed debugging spew.
574 * src/dbus_api/modest-dbus-callbacks.c:
575 Added debugging info.
577 * src/modest-search.c:
578 (modest_search_all_accounts):
579 Use tny_account_store_get_accounts () on the account store
580 to get all accounts which is the way to get all accounts.
582 * tests/dbus_api/test_search.c: (main):
583 Make it possible to supply the search term on the command line.
585 2007-06-03 Christian Kellner <ckellner@openismus.com>
587 * libmodest-dbus-client/libmodest-dbus-client.c:
588 * libmodest-dbus-client/libmodest-dbus-client.h:
589 Implement searching for mesages over raw dbus. (Client side)
591 * src/dbus_api/Makefile.am:
592 * src/dbus_api/modest-dbus-api.h:
593 * src/dbus_api/modest-dbus-callbacks.c:
594 * src/dbus_api/modest-dbus-callbacks.h:
595 Search framework (Server side). Also implement on_idle_open_message().
597 * src/maemo/modest-platform.c: (modest_platform_init):
598 Prepare for raw dbus/osso rpc interaction.
600 * src/modest-search.h:
601 Changed minsize from unspecific guint to guint32.
603 * src/modest-search.c:
605 Added strange hack which magically made tnymail work.
607 (modest_search_folder),
608 (modest_search_account),
609 (modest_search_all_accounts):
610 Implement helper functions to search all accounts, specific account
613 * tests/dbus_api/Makefile.am:
614 * tests/dbus_api/test_open_message.c:
615 Read url to open from commandline.
617 * tests/dbus_api/test_search.c:
618 Implement small test for dbus search stuff
620 2007-06-02 Armin Burgmeier <armin@openismus.com>
622 * src/maemo/modest-account-settings-dialog.c: Changed window title to
623 include account type and account title. This fixes projects.maemo.org
626 * src/maemo/modest-account-view-window.c: Set a title for the window.
628 2007-06-02 Armin Burgmeier <armin@openismus.com>
630 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
631 incoming and outgoing server name based on email address and server
632 types as long as the names have not been edited manually. This fixes
633 projects.maemo.org bug NB#58671.
635 2007-06-02 Armin Burgmeier <armin@openismus.com>
637 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
638 server type cannot be changed in future to the incoming details page
639 when creating an account. This fixes projects.maemo.org bug NB#59029.
641 2007-06-02 Armin Burgmeier <armin@openismus.com>
643 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
644 and assigned max width chars so that they wrap instead of being
645 truncated. Fixes projects.maemo.org bug NB#56126.
647 2007-06-02 Armin Burgmeier <armin@openismus.com>
649 * src/maemo/modest-connection-specific-smtp-window.c: Add an
650 introductory note to the connection specific smtp servers dialog, as
651 section 8.12 of the email UI specification requires. This fixes
652 projects.maemo.org bug NB#59212.
654 2007-06-01 Murray Cumming <murrayc@murrayc.com>
656 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
657 Check for running mail operations, and offer to cancel them, as per the UI
658 spec. This fixes projects.maemo.org bug NB#59041 .
659 However, I suspect that tinymail may still use the network connection
660 in ways that we cannot detect or cancel. But it should at least adapt to
663 2007-06-01 Murray Cumming <murrayc@murrayc.com>
665 * src/modest-tny-account-store.c: (recreate_all_accounts),
666 (get_cached_accounts), (get_server_accounts): Do more sensible
667 ref-counting of the temporarily-cached outbox accounts list. This seems
668 to fix a crash when entering the password when the password was wrong.
670 2007-06-01 Murray Cumming <murrayc@murrayc.com>
672 * src/gnome/modest-main-window.c: (connect_signals):
673 * src/modest-tny-account-store.c: (get_password),
674 (modest_tny_account_store_alert): Added comments and clues and
675 commented-out code about how we currently fail to deal with connection
676 errors and wrong passwords, and how we should.
678 2007-06-01 Murray Cumming <murrayc@murrayc.com>
680 * src/widgets/modest-retrieve-combo-box.c:
681 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
682 This fixes projects.maemo.org bug NB#58472 .
684 2007-06-01 Murray Cumming <murrayc@murrayc.com>
686 * src/maemo/easysetup/modest-easysetup-wizard.c:
687 (create_page_complete_easysetup):
688 (create_page_complete_custom): Correct the last commit,
689 putting the correct sentences in the correct pages.
691 2007-06-01 Murray Cumming <murrayc@murrayc.com>
693 * src/maemo/easysetup/modest-easysetup-wizard.c:
694 (create_page_complete_custom): Show the second sentence of text
695 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
698 2007-06-01 Murray Cumming <murrayc@murrayc.com>
700 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
701 Set the leave-on-server conf key by default. This fixes
702 projects.maemo.org bug NB#59258 .
704 2007-06-01 Murray Cumming <murrayc@murrayc.com>
706 * src/maemo/modest-account-view-window.c:
707 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
708 logical ID for the confirmation messages. Fixed projects.maemo.org bug
711 2007-06-01 Murray Cumming <murrayc@murrayc.com>
713 * src/maemo/easysetup/modest-easysetup-wizard.c:
714 (create_caption_new_with_asterisk):
715 * src/maemo/modest-account-settings-dialog.c:
716 (create_caption_new_with_asterisk):
717 Uncomment the code to add the asterisk, because they are no longer in the
718 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
719 (update_incoming_server_title): Add an asterisk here too.
721 2007-06-01 Murray Cumming <murrayc@murrayc.com>
723 * src/maemo/modest-maemo-global-settings-dialog.c:
724 (current_connection): Check that we are even connected before trying to
725 get the current connection name, to prevent a warning.
727 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
728 Change the comments because tny_maemo_conic_device_connect() is now meant to
730 * src/modest-mail-operation.c:
731 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
732 make sure we have a connection and fail if we can't connect.
734 2007-05-31 Murray Cumming <murrayc@murrayc.com>
736 * src/maemo/modest-main-window.c:
737 (on_account_store_connecting_finished): Do not try to get the
738 connection ID if we are not really connected. I am surprised that
739 this signal handler is called when we are not connected.
741 2007-05-31 Murray Cumming <murrayc@murrayc.com>
743 * src/modest-error.h:
744 * src/modest-ui-actions.c:
745 (modest_ui_actions_get_msgs_full_error_handler):
746 Renamed an enum, added comments, added an enum
747 for retrieve-limit errors.
749 * src/modest-mail-operation.c: (foreach_add_item),
750 (internal_folder_observer_update), (update_account_thread),
751 (modest_mail_operation_get_msgs_full):
752 (modest_mail_operation_update_account),
753 Added comments about how this works, and some code that should
754 (but does not) check the retrieve-limit. See the TODO comment.
756 2007-05-31 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
759 Initialize help_id to fix the build. Warnings are good.
761 2007-05-31 Murray Cumming <murrayc@murrayc.com>
763 * src/widgets/modest-hbox-cell-renderer.c:
764 (modest_hbox_cell_renderer_append):
765 * src/widgets/modest-vbox-cell-renderer.c:
766 (modest_vbox_cell_renderer_append):
767 Fix the last commit by doing an extra ref.
769 2007-05-31 Murray Cumming <murrayc@murrayc.com>
771 * src/widgets/modest-hbox-cell-renderer.c:
772 (modest_hbox_cell_renderer_append):
773 * src/widgets/modest-vbox-cell-renderer.c:
774 (modest_vbox_cell_renderer_append):
775 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
776 to fix the build with Maemo Bora.
777 However, there seems to be a remaining crash, probably due to reference
780 2007-05-30 Murray Cumming <murrayc@murrayc.com>
782 * src/modest-tny-account.c:
783 (modest_tny_account_new_for_local_folders):
784 Use hildon_file_system_info_async_new() to get a better name for
785 the memory card account, setting it as the account name.
786 The timing seems to work, but this is probably
787 not the best place to do this. See the TODO comment.
788 * src/maemo/modest-main-window.c: (create_details_widget):
789 * src/widgets/modest-folder-view.c: (text_cell_data):
790 Use the tny account name instead of hardcoding a name.
792 2007-05-30 Christian Kellner <ckellner@openismus.com>
794 * src/modest-search.c: (modest_search):
795 Correctly set part_search_func even if we have already parsed
796 the query and thus a valid OgsTextSearcher object.
798 2007-05-30 Christian Kellner <ckellner@openismus.com>
801 Search and check for libogs.
804 Incooparte the ogs build env.
806 * src/modest-mime-part-search-stream.c:
807 * src/modest-mime-part-search-stream.h:
808 Removed since we do the real searching now in modest-search.c.
810 * src/modest-search.c:
811 * src/modest-search.h:
812 Implement support for ogs. We use that if available and requested
813 and fall back to modest_text_utils_utf8_strcmp (). The search logic
814 should now handle the corner case when the search term is spread
815 across multiple reads.
816 Also the logic in modest_search () was corrected to search all
817 requested fields until one is found.
819 2007-05-30 Murray Cumming <murrayc@murrayc.com>
821 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
824 * src/modest-init.c: Made modest_init_local_folders() take a
825 path and be public so we can iniitialize maildir folders on
828 * src/modest-local-folder-info.h:
829 * src/modest-local-folder-info.c:
830 (modest_local_folder_info_get_maildir_path): Add a path parameter.
832 * src/modest-tny-account.c:
833 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
834 still means the standard local-folders path on the local volume.
836 * src/modest-tny-account-store.c:
837 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
838 signal so we can detect mount/unmount of the MMC1 card, and do an update of
839 all accounts when that happens.
840 (get_server_accounts): If the MMC1 card is mounted, create a store account for
841 this too, so it shows up in the treeview.
843 2007-05-28 Murray Cumming <murrayc@murrayc.com>
845 * src/maemo/modest-maemo-global-settings-dialog.c:
846 (current_connection):
847 * src/widgets/modest-global-settings-dialog.c:
848 (current_connection_default):
849 Use the enum values instead of 0, 1 and -1,
850 to make the code clearer.
852 * src/modest-account-mgr-helpers.c:
853 (modest_account_mgr_get_connection_specific_smtp): Make this code
856 * src/modest-runtime.h:
857 * src/modest-runtime.c:
858 Added modest_runtime_remove_all_send_queues().
859 * src/maemo/modest-main-window.c:
860 (on_account_store_connecting_finished): Recreate the send queues,
861 using the appropriate transport accounts for this new connection.
862 Some futher adapting might be needed if the old send queues are not
863 automatically stopped at this point.
865 * src/modest-tny-account-store.c: (get_server_accounts):
866 Create the connection-specific transport accounts, so that they can
867 be found later by their ID.
869 * src/modest-tny-account.h:
870 * src/modest-tny-account.c:
871 Added modest_tny_account_new_from_server_account_name().
872 modest_tny_account_new_from_server_account(): Do not create the
873 send queues here, because they will be
874 recreated anyway when the connection changes for the first time.
876 2007-05-28 Murray Cumming <murrayc@murrayc.com>
878 * src/modest-local-folder-info.h:
879 * src/modest-local-folder-info.c:
880 (modest_per_account_local_outbox_folder_info_get_maildir_path),
881 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
882 tbox_folder): Take a modest account name instead of a server TnyAccount,
883 so we can have per-modest-account rather than per-transport-account
885 We must make sure that we change or recreate the exisitng send queues
886 when the connection changes for connection-specific transport accounts.
888 * src/modest-tny-account-store.c:
889 (create_per_account_local_outbox_folders): Create outboxed per modest
890 account, not per transport account.
892 * src/modest-tny-account.h:
893 * src/modest-tny-account.c:
894 (modest_tny_account_get_special_folder): For outboxes, get the
895 parent modest account name. The account is ignored for other folders.
896 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
897 modest account name rather than a server TnyAccount.
899 2007-05-25 Murray Cumming <murrayc@murrayc.com>
901 * src/modest-tny-account.c:
902 (modest_tny_account_new_from_server_account):
903 Call modest_runtime_get_send_queue() immediately after creating transport
904 accounts, so that they start trying to send email from the outbox as soon
905 as possible at startup. This is probably what we want.
907 * src/modest-mail-operation.c: (update_account_thread):
908 * src/modest-runtime.c: (modest_runtime_get_send_queue):
909 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
910 * src/modest-tny-send-queue.h:
911 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
912 (modest_ui_actions_on_send):
913 Added comments about how sending works, though it needs some more work.
915 2007-05-25 Murray Cumming <murrayc@murrayc.com>
917 * src/modest-tny-account.c:
918 (modest_tny_account_get_special_folder): Add TODO because this fails when
920 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
921 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
922 Do not try to show this window when there is no active account. The UI
923 specs does not tell us what to do in this case.
925 2007-05-24 Murray Cumming <murrayc@murrayc.com>
929 * src/maemo/Makefile.am:
930 * src/widgets/Makefile.am: Some dist fixes.
932 2007-05-24 Murray Cumming <murrayc@murrayc.com>
934 * src/maemo/modest-connection-specific-smtp-window.c:
935 (on_button_edit): Make the code clearer, to prevent a double free.
937 2007-05-24 Murray Cumming <murrayc@murrayc.com>
939 * src/maemo/modest-account-settings-dialog.c:
940 (modest_account_settings_dialog_set_account_name),
941 Check the connection-specific smtp servers checkbox if there are any.
943 * src/maemo/modest-connection-specific-smtp-edit-window.c:
944 (modest_connection_specific_smtp_edit_window_init):
945 Start with a suitable port number.
947 * src/modest-account-mgr-helpers.h:
948 * src/modest-account-mgr-helpers.c: Added
949 modest_account_mgr_get_has_connection_specific_smtp().
951 (modest_account_mgr_set_connection_specific_smtp),
952 (modest_account_mgr_remove_connection_specific_smtp),
953 (modest_account_mgr_get_has_connection_specific_smtp),
954 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
955 connection-specific smtp server accounts in the account, rather than
956 the server account conf dir.
958 This fixes bug projects.maemo.org bug NB#58263 .
960 * src/modest-tny-account-store.c:
961 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
962 if there are no server accounts yet, to prevent an infinite loop when there
963 are no accounts. Document that one must be called before the other.
965 2007-05-24 Murray Cumming <murrayc@murrayc.com>
967 * src/modest-account-mgr-helpers.c:
968 (modest_account_mgr_get_default_account): Make sure that at least
969 one account is always the default, if there are any enabled accounts.
970 This is just a sanity check that shouldn't be necessary.
972 * src/modest-account-mgr-priv.c:
973 (_modest_account_mgr_account_from_key): Unescape the conf key to
974 get the real account name. For instance, this is an issue if a space
975 was in the account name, which can happen because the account name
976 is generated from the display name.
977 (_modest_account_mgr_get_account_keyname): Always escape the
979 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
980 Unescape the conf keys to get the real account names.
982 For instance, previously the is-default radio button in the accounts
983 list was not checked for any accounts at first. This fixes that,
984 and might fix several similar bugs.
986 2007-05-23 Murray Cumming <murrayc@murrayc.com>
988 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
989 Removed some debug printfs.
991 2007-05-23 Murray Cumming <murrayc@murrayc.com>
993 Modest on-disk outbox directories are now here, for instance:
994 $HOME/.modest/outboxes/<account-id-1>/outbox
995 $HOME/.modest/outboxes/<account-id-2>/outbox
997 $HOME/.modest/local-folders/outbox
998 so we can have a separate outbox for each account.
999 But they are shown as one outbox in the GtkTreeView, by using a
1000 TnyMergeFolder in a ModestTnySimpleFolderStore.
1003 * src/modest-tny-simple-folder-store.c:
1004 * src/modest-tny-simple-folder-store.h:
1005 Added ModestTnySimpleFolderStore, used to contain folders from
1006 other folder stores, such as other accounts.
1008 * src/modest-tny-outbox-account.h:
1009 * src/modest-tny-outbox-account.c:
1010 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1011 used for the per-account local outbox folders.
1013 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1014 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1015 only use this (internally) now for the non-outbox local folders.
1017 * src/modest-init.h:
1018 * src/modest-init.c: Added modest_init_one_local_folder(), for
1019 setting up the directory structure for each local folder.
1021 * src/modest-local-folder-info.c:
1022 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1023 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1025 * src/modest-local-folder-info.h:
1026 * src/modest-tny-account-store.c: (on_account_removed),
1027 (on_account_changed), (create_per_account_local_outbox_folders),
1028 (get_server_accounts), (modest_tny_account_store_get_accounts),
1029 (modest_tny_account_store_get_tny_account_by_account),
1030 (modest_tny_folder_store_is_virtual_local_folders):
1032 * src/modest-tny-account.h:
1033 * src/modest-tny-account.c:
1034 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1035 to create an on-disk per-account local outbox folder for each
1037 (create_per_account_local_outbox_folders): Create a local outbox folder
1038 for each transport account.
1039 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1040 for all local folders.
1042 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1043 instead of using g_object_get/set() directly. It is clearer.
1045 (modest_tny_folder_store_get_message_count),
1046 (modest_tny_folder_store_get_local_size
1047 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1048 because we now use these with non-acount folder stores.
1050 (modest_tny_account_get_special_folder),
1051 (modest_tny_account_new_from_server_account),
1052 (modest_tny_account_new_from_account):
1053 (recurse_folders): Adjust to the new outbox system.
1055 * src/modest-tny-folder.h:
1056 * src/modest-tny-folder.c:
1057 (modest_tny_folder_is_local_folder),
1058 (modest_tny_folder_get_local_folder_type),
1059 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1061 * src/widgets/modest-main-window.h:
1062 * src/maemo/modest-main-window.c: (create_details_widget),
1063 (modest_main_window_set_contents_style): Show details for any folder store,
1066 (modest_tny_folder_get_rules):
1067 Remove the const. C does not support constness enough for this.
1069 * src/modest-ui-actions.c:
1070 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1071 make all outboxes appear as one, in the usual local-folders tree node.
1073 (set_active_account_from_tny_account),
1074 (modest_ui_actions_on_folder_selection_changed):
1075 * src/widgets/modest-folder-view.c: (text_cell_data),
1076 (icon_cell_data), (filter_row),
1077 (add_account_folders_to_merged_folder),
1078 (add_account_folders_to_simple_folder_store), (),
1079 (get_cmp_rows_type_pos), (cmp_rows),
1080 (modest_folder_view_set_account_id_of_visible_server_account):
1081 Adjust to the new outbox system, using generic folder stores and folders
1082 in the GtkTreeModel.
1084 2007-05-23 Christian Kellner <ckellner@openismus.com>
1086 * src/modest-mail-operation.c:
1087 (modest_mail_operation_update_account):
1088 Use info->max_size instead of unintialized local var [small
1089 build fix]. (Added TODO to review that change since I don't
1092 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1094 * libmodest-dbus-client/libmodest-dbus-client.c:
1095 (libmodest_dbus_client_compose_mail): function added
1096 * src/dbus_api/modest-dbus-api.h:
1097 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1098 (on_compose_mail): Implementation of the SendAsMail functionality
1100 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1102 * src/modest-account-mgr.c:
1103 (modest_account_mgr_add_server_account): Set the secure-connection
1104 conf key for transport accounts as well as store accounts. I don't know
1105 why the if was there. For instance, this makes sure that we use SSL
1106 for the gmail preset from the easysetup wizard.
1108 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1110 * src/gnome/modest-main-window.c:
1111 (on_account_store_connecting_finished), (connect_signals):
1112 * src/maemo/modest-main-window.c:
1113 (on_account_store_connecting_finished), (connect_signals),
1114 (modest_main_window_new):
1115 Handle TnyAccountStore::connecting-finished instead of
1116 TnyDevice::connection-changed, because we cannot actually perform
1117 operations on accounts until TnyAccountStore has itself responded to
1118 the TnyDevice::connection-changed signal. This prevents a GError from
1120 Do not try to update at startup, because we (at least on scratchbox)
1121 already do an update at startup when the device goes online.
1122 This prevents a GError from tinymail.
1123 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1124 Added TODO about stopping simultaneous operations.
1126 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1128 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1129 * src/modest-mail-operation-queue.c:
1130 (modest_mail_operation_queue_remove):
1131 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1132 about where they happened.
1134 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1136 * src/modest-ui-actions.c:
1137 (modest_ui_actions_on_password_requested): Make sure that the remember
1138 output parameter is always TRUE.
1140 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1142 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1143 Show a OK/Cancel dialog if the error is a question, though we still do not
1144 know anything more about what we are asking the user.
1145 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1146 Fix an uninitialized variable (helper). This is a logic error, however.
1148 2007-05-21 Christian Kellner <ckellner@openismus.com>
1150 * src/modest-search.h:
1151 Correct bit shifting in the ModestSearchFlags enum.
1153 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1155 * src/modest-tny-account.c:
1156 (modest_tny_account_new_from_server_account): Do not use the lsub and
1157 check-all hard-coded IMAP options when using POP.
1159 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1161 * src/modest-tny-account.c:
1162 (modest_tny_account_new_from_server_account):
1163 Use NULL for the secure-auth method for POP when Password auth has been
1164 specified by the user, as we already do for IMAP. "auth=Login" causes
1165 an error from camel or the server.
1167 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1169 * src/maemo/modest-account-settings-dialog.c:
1170 (create_page_account_details),
1171 (modest_account_settings_dialog_set_account_name):
1172 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1173 for the leave-on-server checkbox, rathr than just the checkbox, when
1174 the protocol is not POP.
1176 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1178 * src/widgets/modest-account-view.c:
1179 * src/widgets/modest-account-view.h:
1180 Added modest_account_view_select_account() which will be useful later
1181 to asynchronously re-select the edited account.
1183 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1185 * src/maemo/modest-account-settings-dialog.c:
1186 (modest_account_settings_dialog_set_account_name):
1187 Automatically choose the port numbers based on the secure authentication
1188 methods, if they have not been chosen before.
1189 This fixes projects.maemo.org bug NB#56273 .
1191 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1193 * src/maemo/modest-main-window-ui.h:
1194 * src/modest-ui-actions.c:
1195 * src/modest-ui-actions.h:
1196 Connect the Tools/SMTP Servers menu item to
1197 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1198 SMTP servers dialog, as in the UI specification and saves changes when it
1199 is closed. This fixed projects.maemo.org bug NB#56305 .
1201 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1203 * src/maemo/modest-connection-specific-smtp-window.c:
1204 (modest_connection_specific_smtp_window_init):
1205 Use gtk_window_set_default_size() to make this window big enough, so
1206 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1208 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1210 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1211 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1212 (modest_connection_specific_smtp_edit_window_init),
1213 Do not try to connect to a combobox signal before the combobox exists.
1214 This fixes the cras in projects.maemo.org bug NB#56288 .
1215 (modest_connection_specific_smtp_edit_window_get_settings):
1216 Remove the server_account_name parameter which was being checked for NULL
1217 though it was not used.
1219 * src/maemo/modest-connection-specific-smtp-window.c:
1220 (modest_connection_specific_smtp_window_fill_with_connections),
1221 (on_button_edit), (modest_connection_specific_smtp_window_init):
1222 Correct the number of treemodel columns to prevent a warning.
1223 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1224 libconic does not work.
1226 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1228 * src/modest-tny-account.c:
1229 (modest_tny_account_new_from_server_account):
1230 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1231 SMTP when "None" was chosen by the user. However, with my SMTP server that
1232 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1235 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1237 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1238 to explain the memory management issue with the ID in the ModestPair.
1240 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1241 (add_sending_page), (modest_account_assistant_finalize):
1242 * src/gnome/modest-gnome-global-settings-dialog.c:
1243 (create_updating_page), (create_composing_page):
1244 * src/gnome/modest-msg-edit-window.c: (get_transports),
1245 (init_window), (modest_msg_edit_window_finalize),
1246 (modest_msg_edit_window_get_msg_data):
1247 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1248 * src/gnome/modest-transport-widget.c:
1249 (modest_transport_widget_finalize), (smtp_configuration):
1250 * src/maemo/modest-maemo-global-settings-dialog.c:
1251 (create_updating_page), (create_composing_page):
1252 * src/maemo/modest-msg-edit-window.c: (get_transports),
1253 (init_window), (modest_msg_edit_window_finalize),
1254 (modest_msg_edit_window_get_msg_data),
1255 (modest_msg_edit_window_free_msg_data):
1256 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1257 (modest_store_widget_finalize):
1258 * src/maemo/modest-transport-widget.c:
1259 (modest_transport_widget_finalize), (smtp_configuration):
1260 * src/modest-main.c: (send_mail):
1261 * src/widgets/modest-combo-box.h:
1262 * src/widgets/modest-global-settings-dialog-priv.h:
1263 * src/widgets/modest-global-settings-dialog.c:
1264 (modest_global_settings_dialog_finalize):
1265 * src/widgets/modest-msg-edit-window.h:
1266 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1267 as long as the combo box, to prevent use of freed memory for the ID.
1269 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1271 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1272 get_accounts(), to make this clearer. Do not check for the enabled gconf
1273 key, because we do not use this for server accounts (at least, not yet).
1274 This allows us to send email again.
1276 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1278 * src/maemo/modest-platform.c:
1279 (on_modest_conf_update_interval_changed), (modest_platform_init):
1280 Only respond to this particular key change. All these strcmp()s cannot be
1283 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1285 * src/maemo/modest-maemo-global-settings-dialog.c:
1286 (current_connection): Prevent a crash in scratchbox when
1287 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1288 * src/maemo/modest-platform.c:
1289 (on_modest_conf_update_interval_changed), (modest_platform_init):
1290 Get the update interval from gconf and reset it when the gconf key changes.
1292 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1294 * src/modest-protocol-info.c:
1295 * src/modest-protocol-info.h: Adde enum-specific get functions,
1296 instead of using a ModestProtocolType enum parameter.
1298 * src/gnome/modest-account-assistant.c:
1299 * src/gnome/modest-store-widget.c:
1300 * src/gnome/modest-store-widget.h:
1301 * src/gnome/modest-transport-widget.c:
1302 * src/gnome/modest-transport-widget.h:
1303 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1304 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1305 * src/maemo/easysetup/modest-easysetup-wizard.c:
1306 * src/maemo/modest-account-settings-dialog.c:
1307 * src/maemo/modest-account-settings-dialog.h:
1308 * src/maemo/modest-store-widget.c:
1309 * src/maemo/modest-store-widget.h:
1310 * src/maemo/modest-transport-widget.c:
1311 * src/maemo/modest-transport-widget.h:
1312 * src/modest-account-mgr-helpers.c:
1313 * src/modest-account-mgr-helpers.h:
1314 * src/modest-account-mgr.c:
1315 * src/modest-account-mgr.h:
1316 * src/modest-tny-account.c:
1317 * src/modest-tny-folder.c:
1318 * src/widgets/modest-account-view.c:
1319 * src/widgets/modest-retrieve-combo-box.c:
1320 * src/widgets/modest-retrieve-combo-box.h:
1321 * src/widgets/modest-secureauth-combo-box.c:
1322 * src/widgets/modest-serversecurity-combo-box.c:
1323 * src/widgets/modest-serversecurity-combo-box.h:
1324 * tests/check_account-mgr.c:
1325 Use the specific functions, and use the re-renamed enum values for GNOME too.
1327 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1329 * src/modest-pair.h:
1330 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1331 so we can get the second based on the first.
1333 * src/maemo/modest-account-settings-dialog.h:
1334 * src/maemo/modest-account-settings-dialog.c:
1335 Added get_supported_secure_authentication_methods(), though it is mostly
1336 commented-out for now until the necessary API is committed to tinymail.
1337 (modest_account_settings_dialog_set_account_name),
1338 (save_configuration): Request the supported authentication methods from the
1339 server, so we can choose a working method.
1341 * src/modest-tny-account-store.h:
1342 * src/modest-tny-account-store.c:
1343 (modest_tny_account_store_get_session): Rename from
1344 tny_account_store_get_session().
1346 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1348 * src/modest-protocol-info.h: Split the ModestProtocol enum
1349 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1350 There was no need to have these unrelated values in one enum.
1352 * src/: many files: Adapted to changed enum. This makes the code a bit
1353 clearer, and the compiler could catch some errors.
1355 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1357 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1358 Show the detailed internal camel error message when an error happens
1359 during the configuration, so that our testers can give us more clues.
1360 For instance, in projects.maemo.org bug NB#56910 .
1362 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1364 * src/modest-tny-account.c:
1365 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1366 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1368 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1370 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1371 * src/maemo/modest-account-settings-dialog.c:
1372 (modest_account_settings_dialog_set_account_name),
1373 (save_configuration): For the incoming secure authentication checkbox,
1374 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1375 the UI specification. PLAIN does not seem to be supported for most IMAP
1376 servers anyway, and I am not sure what it would mean.
1377 However, we probably need to discover which of the secure-authentication
1378 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1379 * src/modest-account-mgr-helpers.c:
1380 (modest_account_mgr_get_server_account_data):
1382 * src/modest-tny-account.c:
1383 (modest_tny_account_new_from_server_account):
1384 Use tny_account_set_mech() to set secure-authentication methods,
1385 with some special-casing for IMAP, based on my observations of how
1388 * src/modest-account-mgr-helpers.h:
1389 * src/modest-account-mgr.c:
1390 * src/modest-defs.h: Comment that the URI is only used for local folders.
1392 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1394 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1395 parameter const, just to be neat.
1396 * src/modest-text-utils.c: (modest_text_utils_inline):
1397 End g_strconcat() with NULL, as its documentation says. This is almost
1398 certainly the cause of my crash at startup on the device. Interestingly,
1399 valgrind doesn't tell us about these errors.
1401 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1403 * scripts/build-packages: Added more precise comments about how to use
1404 this script, though I still get this error:
1405 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1406 error building tinymail
1408 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1410 * src/maemo/modest-main-window.c: (on_account_update):
1411 Very slight cleanup, hoping to make it simpler to discover what causes
1412 a crash here sometimes.
1414 * src/modest-tny-account.c:
1415 (modest_tny_account_new_from_server_account): Set the port. Added
1416 comments about the options and a TODO comment because I need to find out
1417 how to specify the secure authentication method.
1419 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1421 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1422 changed CFlags paths form modest to libmodest
1424 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1426 * src/modest-account-mgr-helpers.c:
1427 (modest_account_mgr_get_server_account_data),
1428 (modest_account_mgr_free_server_account_data):
1429 * src/modest-account-mgr-helpers.h:
1430 * src/modest-account-mgr.c:
1431 (modest_account_mgr_add_server_account):
1432 * src/modest-defs.h:
1433 * src/modest-tny-account.c:
1434 (modest_tny_account_new_from_server_account):
1435 Determine the options for tny_camel_account_add_option() here,
1436 based on the settings, rather than storing them directly in gconf.
1438 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1440 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1441 Show a more friendly error dialog now that we expect (from the tinymail
1442 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1444 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1446 * src/maemo/modest-main-window.c: (on_account_update): Check that
1447 account_name is not NULL, to prevent a crash at startup that I am
1448 seeing on the N800. I do wonder why it is NULL.
1450 * src/maemo/easysetup/modest-easysetup-wizard.c:
1451 (create_page_user_details):
1452 * src/maemo/modest-account-settings-dialog.c:
1453 (create_page_user_details), (create_page_outgoing):
1454 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1455 (modest_connection_specific_smtp_edit_window_init):
1456 * src/modest-ui-actions.c:
1457 (modest_ui_actions_on_password_requested):
1458 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1459 might do something useful with the on-screen keyboard.
1461 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1463 * src/maemo/modest-main-window.c: (on_account_update):
1464 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1465 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1467 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1469 * src/modest-tny-account-store.c: (on_account_changed):
1470 Correct the signature of this signal handler.
1472 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1474 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1475 Show a HildonNote instead of a GtkDialog for Maemo.
1477 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1479 * src/widgets/modest-account-view.h:
1480 * src/widgets/modest-account-view.c: (on_account_changed),
1481 (on_account_removed). Added a boolean flag, set/unset by
1482 modest_account_view_block_conf_updates(),
1483 modest_account_view_unblock_conf_updates() to prevent unnecessary
1484 updates, but this is not very useful because the gconf notifications are
1485 so delays (maybe only on Maemo Bora).
1486 So auto-updating is turned off, and these functions do an explicit
1487 update when necessary.
1488 However, something else is still doing too much work when adding/removing
1489 accounts, probably in another part of the application.
1491 * src/maemo/modest-account-view-window.c:
1492 (on_delete_button_clicked), (on_edit_button_clicked),
1493 (on_new_button_clicked): Use the new functions.
1495 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1497 * src/modest-account-mgr-helpers.c:
1498 (modest_account_mgr_set_first_account_as_default):
1499 Sort the list of names alphabetically-by-title, so we choose the first one
1501 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1502 alphabetically by the title.
1504 This fixes projects.maemo.org bug NB#56418 .
1506 * src/modest-account-mgr-priv.c:
1507 (_modest_account_mgr_account_from_key):
1508 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1509 avoid a valgrind error, and possible random behaviour.
1511 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1513 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1514 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1515 tinymail documentation to say that this can be expected.
1516 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1517 pretty, and should not happen, but I would prefer to know when it does.
1519 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1521 * configure.ac: When using the older hildon version, probably on Bora,
1522 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1524 * src/widgets/modest-attachment-view.c:
1525 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1528 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1530 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1531 Implemented the prototype. Can be tested with
1532 tests/dbus_api/test_open_message:
1534 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1536 * src/modest-tny-account-store.c:
1537 (modest_tny_account_store_instance_init), (get_password):
1538 * src/modest-ui-actions.c:
1539 (modest_ui_actions_on_password_requested):
1540 Do not store the password in gconf, because this function is called
1541 for non-remembered passwords. Actually use the cached (in the hash map)
1542 password instead of releasing it.
1543 The password will now not be remembered if it is asked via the protected
1544 password dialog, as per the UI spec.
1546 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1548 * src/modest-defs.h:
1549 * src/modest-account-mgr-helpers.h:
1550 * src/modest-account-mgr-helpers.c:
1551 Added modest_server_account_get_username_has_succeeded(),
1552 modest_server_account_set_username_has_succeeded().
1553 (modest_server_account_set_username),
1554 Reset the has-succeeded flag if the username changes.
1556 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1557 * src/maemo/modest-connection-specific-smtp-window.c:
1558 (modest_connection_specific_smtp_window_save_server_accounts):
1559 Use modest_server_account_set_username() instead of using
1560 modest_conf_set_string() directly, so that the has-succeeded flag is always
1563 * src/modest-ui-actions.c:
1564 (modest_ui_actions_on_password_requested): Dim the username entry if
1565 the username has ever worked, as per the UI spec.
1567 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1569 * src/modest-tny-account-store.c: (get_password):
1570 * src/modest-ui-actions.c:
1571 (modest_ui_actions_on_password_requested):
1572 Allow the username to be changed too, though there is more work to
1573 be done on exactly how this behaves.
1575 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1577 * src/modest-account-mgr-helpers.h:
1578 * src/modest-account-mgr-helpers.c:
1579 Added modest_account_mgr_get_display_name(),
1580 modest_server_account_get_username(),
1581 modest_server_account_set_username(),
1582 modest_server_account_set_password(),
1583 modest_server_account_get_hostname() functions so we do not need to
1584 use the conf API directly.
1586 * src/maemo/modest-main-window.c: (connect_signals):
1587 Actually connect ot the ModestAccountStore::request-password signal,
1588 so that we show the dialog when the password is requested by Tinymail,
1589 for isntance if it is empty.
1591 * src/modest-marshal.list:
1592 * src/modest-tny-account-store.c:
1593 (modest_tny_account_store_class_init), (get_password),
1594 (modest_tny_account_store_alert):
1595 * src/modest-tny-account-store.h:
1596 * src/modest-ui-actions.h:
1597 * src/modest-ui-actions.c:
1598 (modest_ui_actions_on_password_requested):
1599 Change the signal parameters, so it is obvious that we are providing
1600 the non human-readable server name, and receiving both the username
1601 and password, though changing of the username is not yet implemented.
1602 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1603 for the GNOME version.
1605 This should fix the projects.maemo.org bug NB#56209, though it does not
1606 work on Bora, because the gconf_client_get() for the password fails
1607 immediately after we save it with gconf_client_set().
1609 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1612 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1613 caused an undefined symbol error:
1614 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1616 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1618 * src/modest-tny-account-store.c:
1619 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1620 using a GError instead of a string message, so we can translate it in
1623 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1625 * src/maemo/modest-address-book.c:
1626 (modest_address_book_check_names):
1627 * src/maemo/modest-msg-view-window.c:
1628 (modest_msg_view_window_clipboard_owner_change):
1629 * src/modest-init.c: (modest_init_init_ui):
1630 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1631 (update_folders_cb), (modest_mail_operation_update_account):
1632 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1633 (modest_ui_actions_on_msg_attachment_clicked),
1634 (modest_ui_actions_on_msg_recpt_activated):
1635 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1636 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1637 (modest_msg_view_search_next):
1638 * src/widgets/modest-recpt-editor.c:
1639 (modest_recpt_editor_on_button_release_event),
1640 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1641 g_message(). At this point we should only be seeing interesting errors on
1642 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1644 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1646 (modest_wizard_dialog_force_title_update):
1647 * src/maemo/easysetup/modest-wizard-dialog.h:
1648 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1649 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1650 can update the title when appropriate. Otherwise the title is wrong if the
1651 pages are added after adding the notebook to the dialog.
1652 This must be a problem in HildonWizardDialog too.
1653 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1655 * src/maemo/easysetup/modest-easysetup-wizard.c:
1656 (create_subsequent_customsetup_pages),
1657 (create_subsequent_easysetup_pages):
1658 Call modest_wizard_dialog_force_title_update() so that the title is
1659 correct even with GTK+ < 2.10.
1660 This fixes projects.maemo.org bug NB#56145 .
1662 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1664 * src/maemo/modest-platform.c:
1665 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1666 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1669 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1671 * src/widgets/modest-window.h:
1672 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1673 and modest_window_save_state(), which invokes it.
1675 * src/widgets/modest-window-mgr.h:
1676 * src/widgets/modest-window-mgr.c:
1677 Added modest_window_mgr_save_state_for_all_windows(), which calls
1678 the save_state vfunc on all registered windows, if implemented.
1680 * src/gnome/modest-msg-edit-window.c:
1681 * src/gnome/modest-msg-view-window.c:
1682 * src/maemo/modest-msg-edit-window.c:
1683 * src/maemo/modest-msg-view-window.c:
1684 * src/maemo/modest-main-window.c:
1685 Specify the existing save_settings functions as implementations of
1686 ModestWindow::save_state_func().
1688 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1689 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1690 enabling hibernation, for instance.
1692 We may need to do the same thing for restoring settings.
1695 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1697 * src/widgets/modest-window-mgr.c:
1698 * src/widgets/modest-window-mgr.h:
1699 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1700 modest_window_mgr_get_hibernation_is_prevented().
1702 * src/maemo/modest-main-window.c:
1703 (on_hildon_program_is_topmost_notify): Prevent hibernation
1704 (possible when the application goes to the background in the WM),
1705 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1707 * src/maemo/easysetup/modest-easysetup-wizard.c:
1708 (modest_easysetup_wizard_dialog_init):
1709 * src/maemo/modest-account-settings-dialog.c:
1710 (modest_account_settings_dialog_init):
1711 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1712 (modest_connection_specific_smtp_edit_window_init):
1713 * src/maemo/modest-connection-specific-smtp-window.c:
1714 (modest_connection_specific_smtp_window_init):
1715 * src/maemo/modest-signature-editor-dialog.c:
1716 (modest_signature_editor_dialog_init):
1717 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1718 prevent hibernation while any of these account settings dialogs are open.
1720 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1722 * src/maemo/Makefile.am:
1723 * src/maemo/modest-osso-state-saving.c:
1724 * src/maemo/modest-osso-state-saving.h: Added
1725 modest_osso_load_state() and modest_osso_save_state() though they do
1726 nothing now. They should iterate through all the open windows and load/save
1728 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1729 save state when closing.
1731 * src/maemo/modest-main-window.c:
1732 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1733 Add a notification handler for the HildonProgram::is-topmost property,
1734 so we can allow hibernation when the application goes into the background.
1735 But we still need to detect when the accounts setup windows are open so
1736 we can stop hibernation when they are open.
1737 To do this, I also added the main window the HildonProgram. This might have
1738 other side-effects/benefits, and should maybe be done for other windows.
1740 * src/maemo/modest-osso-autosave-callbacks.h:
1741 * src/maemo/modest-osso-autosave-callbacks.c:
1742 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1743 though it does not do anything yet, and we might never need this to do
1744 anything. For instance, we already save drafts.
1746 * src/maemo/modest-platform.c: (modest_platform_init):
1747 Specify the libosso auto-save callback.
1749 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1751 * src/maemo/modest-platform.c:
1752 (modest_platform_set_update_interval):
1753 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1754 aparently stays valid between application instances, so we can use this
1755 to remove and reset it later. According to a maemo-developers email from
1758 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1760 * configure.ac: Depend on libalarm for Maemo.
1762 * src/dbus_api/modest-dbus-api.h:
1763 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1764 (on_send_receive), (modest_dbus_req_handler):
1765 Handle a SEND_RECEIVE D-Bus method.
1767 * libmodest-dbus-client/libmodest-dbus-client.c:
1768 (libmodest_dbus_client_send_and_receive):
1769 * libmodest-dbus-client/libmodest-dbus-client.h:
1770 Add C convenience functions for calling the new D-Bus method.
1772 * src/modest-platform.h:
1773 * src/gnome/modest-platform.c:
1774 * src/maemo/modest-platform.c:
1775 Added modest_platform_set_update_interval(), which uses the
1776 alarmd API on Maemo.
1777 (modest_platform_init),
1778 Call modest_platform_set_update_interval(), using a hard-coded
1779 interval for now (until the global settings dialog is implemented),
1780 though I am not sure that this makes sense yet.
1782 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1784 * src/dbus_api/modest-dbus-callbacks.c:
1785 (modest_osso_cb_hw_state_handler):
1786 * src/dbus_api/modest-dbus-callbacks.h:
1787 * src/maemo/modest-platform.c: (modest_platform_init):
1788 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1789 in case this has some effect on the ability for Maemo to ping the
1792 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1794 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1795 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1796 warning. It is probably a logic error, but I need to fix the build.
1798 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1800 * src/modest-account-mgr.h:
1801 * src/modest-account-mgr.c:
1802 (modest_account_mgr_account_names): Add a gboolean enabled_only
1803 parameter, so we can get lists of onlt the enabled accounts.
1805 (modest_account_mgr_add_account),,
1806 (modest_account_mgr_account_with_display_name_exists):
1807 * src/maemo/modest-msg-edit-window.c: (get_transports):
1808 * src/modest-account-mgr-helpers.c:
1809 (modest_account_mgr_set_first_account_as_default):
1810 * src/modest-init.c: (init_default_account_maybe):
1811 * src/modest-tny-account-store.c: (get_accounts):
1812 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1813 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1814 * tests/check_account-mgr.c: (START_TEST):
1815 Provide the extra parameter, as appropriate.
1817 * src/widgets/modest-account-view.c: (update_account_view):
1818 Do not show disabled accounts (meaning that there is no way to
1819 enable/disable accounts in the UI (the feature is not in our UI
1820 specification), so we can use this internally only to mark unfinished
1821 or temporary account data.
1823 * src/maemo/easysetup/modest-easysetup-wizard.c:
1824 (create_account): Add boolean enable parameter, so we can specify FALSE
1825 to create the temporary account.
1826 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1827 (on_before_next): When finishing, when there is a temporary account, just
1829 Also, use a timeout to delay the showing of the dialog until gconf is likely
1830 to return correct information, due to a maemo gconf bug that is fixed in
1831 osso 1.1, but not yet in Bora.
1832 However, the dialog stays on screen after it is destroyed.
1834 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1835 for invalid data when cancelling. Use a hildon note instead of a dialog
1836 to complain about invalid data. Do not show the account-saved note if the
1837 account is disabled (a temporary account that will not really be saved for use
1840 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1842 * src/modest-account-mgr-helpers.h:
1843 * src/modest-account-mgr-helpers.c:
1844 Added modest_account_mgr_unset_default_account(),
1845 Added modest_account_mgr_set_first_account_as_default().
1847 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1848 If it was the default account, unset the default account name.
1850 * src/maemo/modest-account-view-window.c:
1851 (on_delete_button_clicked): If it was the default account,
1852 set the first remaining account as the default instead.
1854 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1855 a NULL account or a NULL default account, to prevent a crash. This should
1856 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1859 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1861 * src/widgets/modest-recpt-editor.c:
1862 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1863 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1864 TODO comment for this. This fixes the build.
1866 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1867 be the best place for it. This will in future update all auto-update accounts,
1868 rather than just the current/default account, when that gconf key exists.
1869 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1870 if there are no accounts, before calling do_send_receive().
1871 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1873 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1874 * src/maemo/modest-main-window-ui.h:
1875 * src/maemo/modest-main-window.c: (on_connection_changed),
1876 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1877 directly, becaue the signal handler does more.
1879 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1881 * src/modest-account-mgr-helpers.c:
1882 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1883 for the case that the account does not exist.
1885 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1886 (equivalent to the modest account name) rather than the tinymail account name
1887 (equivalent to the modest account title - human readable) to get the account data.
1888 Check for null account data to prevent the crash, and add a TODO comment saying that
1889 this needs fixing because it is using the server account name instead of the account name.
1891 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1893 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1894 * src/maemo/modest-account-settings-dialog.c: (show_error),
1896 Use hildon_note_new_information() for informative and error messages,
1897 which seems to be expected for Maemo applications (no documentation that I know of
1898 says this). I am surprised that there is no distinction between info and error
1901 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1903 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1904 it is easy to find where this is used.
1906 * src/maemo/easysetup/modest-easysetup-wizard.c:
1907 (create_page_welcome), (create_page_account_details),
1908 (create_page_user_details), (create_page_complete_easysetup),
1909 (create_page_custom_incoming), (create_page_custom_outgoing),
1910 (create_page_complete_custom):
1911 * src/maemo/modest-account-settings-dialog.c:
1912 (create_page_account_details), (create_page_user_details),
1913 (create_page_incoming), (create_page_outgoing):
1914 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1915 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1916 (modest_connection_specific_smtp_edit_window_init):
1917 * src/maemo/modest-connection-specific-smtp-window.c:
1918 (modest_connection_specific_smtp_window_init):
1919 * src/maemo/modest-signature-editor-dialog.c:
1920 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1921 and scrolling policy as per the Email Application Layout Guide, if I have
1924 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1926 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1927 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1928 which were empty, because these vfuncs have been removed from TnyAccountStore.
1929 This fixes the build.
1931 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1933 * src/maemo/modest-main-window.c:
1934 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1935 showing/hiding it. Added TODO because it probably should not be NULL.
1936 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1937 because unnecessary g_warnings() make degugging difficult.
1939 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1941 * src/maemo/modest-msg-edit-window.c:
1942 (modest_msg_edit_window_select_color),
1943 (modest_msg_edit_window_select_background_color): 2 const corrections and
1944 moving 2 #endifs before closing brackets, to fix the build.
1946 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1948 * src/maemo/easysetup/modest-easysetup-wizard.h:
1949 * src/maemo/easysetup/modest-easysetup-wizard.c:
1950 (modest_easysetup_wizard_dialog_finalize),
1951 (on_button_edit_advanced_settings), (create_page_complete_custom),
1952 (on_response), (create_account):
1953 Implement the Advanced Settings edit button, by saving the account information,
1954 for the Advanded Settings dialog to use directly from gconf, and removing it
1955 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1956 Bug #5533 in the projects.maemo.org bugzilla.
1958 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1960 * src/maemo/modest-msg-view-window.c:
1961 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1962 when opening a message window.
1964 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1966 * src/maemo/easysetup/modest-easysetup-wizard.c:
1967 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1970 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1971 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1972 gconf settings. I probably added more checks than necessary, but that is safer.
1974 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1975 variable to fix the build, but this seems to be used when it is still NULL.
1977 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1979 * src/modest-platform.h:
1980 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1981 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1982 * src/modest-main.c: Implement this function so we can avoid using
1983 maemo-specific API from cross-platform code.
1985 * src/modest-tny-account-store.c:
1986 (get_smtp_specific_transport_account_for_open_connection):
1987 * src/modest-ui-actions.c: (check_for_connection),
1988 (modest_ui_actions_on_item_not_found):
1989 Use modest_platform_connect_and_wait() and put #idefs around other
1990 maemo-specific code, because only maemo currently has a way to
1991 identify connection names.
1993 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1995 * src/modest-tny-account-store.h:
1996 * src/modest-tny-account-store.c:
1997 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1998 the connection-specific SMTP server settings in the configuration.
2000 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2002 * src/maemo/modest-main-window.c: (on_connection_changed),
2004 * src/modest-main.c: (main), (start_ui), (send_mail):
2005 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2006 that is what is intended.
2008 * src/modest-ui-actions.c: (action_send), (action_receive),
2009 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2010 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2011 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2012 SMTP server is used when it is specified.
2014 (modest_ui_actions_on_send_receive):
2015 Check that a connection is open before proceeding.
2016 Receive and then send, instead of vice-versa, as per the specification.
2018 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2020 * src/modest-mail-operation.c:
2021 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2022 though I guess it should be something other than NULL.
2024 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2026 * src/maemo/easysetup/modest-easysetup-wizard.c:
2027 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2028 combo twice, to avoid an g_warning and to make it visible again.
2029 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2030 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2031 (already intended) dereference when detaching, because we then recreate the menu.
2032 But I am not sure why the warning was happening, and it is possible that this is a memory
2035 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2037 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2038 and uri_parse_mailto() utility functions.
2039 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2041 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2043 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2045 * src/dbus_api/modest-dbus-api.h:
2046 * src/dbus_api/modest-dbus-callbacks.c:
2047 Use an idle callback to execute the modest code in the application's own thread.
2048 Remove the helloworld example method.
2049 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2050 parsed, and the open-message method is not implemented because this is not yet implemented in
2052 * libmodest-dbus-client/libmodest-dbus-client.c:
2053 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2054 (libmodest_dbus_client_open_message):
2055 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2057 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2058 body without crashing.
2060 * tests/dbus_api/Makefile.am:
2061 * tests/dbus_api/test_mail_to.c:
2062 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2064 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2066 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2067 Added file to fix the build. Sorry.
2069 * src/dbus_api/Makefile.am:
2070 * src/dbus_api/modest-dbus-api.h:
2071 * src/dbus_api/modest-dbus-callbacks.h:
2072 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2073 (modest_dbus_req_handler):
2074 Put constants in a separate header so it can be reused by the
2075 client library, without duplication
2077 * libmodest-dbus-client/Makefile.am:
2078 * libmodest-dbus-client/libmodest-dbus-client.c:
2079 (libmodest_dbus_client_call_helloworld),
2080 (libmodfest_dbus_client_send_mail),
2081 (libmodfest_dbus_client_mailto),
2082 (libmodfest_dbus_client_open_message):
2083 * libmodest-dbus-client/libmodest-dbus-client.h:
2084 (Partly) Implement a send_mail D-Bus method.
2086 * tests/dbus_api/Makefile.am:
2087 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2088 the send_email D-Bus method.
2090 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2094 * libmodest-dbus-client/Makefile.am:
2095 * libmodest-dbus-client/libmodest-dbus-client.c:
2096 * libmodest-dbus-client/libmodest-dbus-client.h:
2097 * tests/dbus_api/Makefile.am:
2098 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2099 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2101 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2103 * src/maemo/easysetup/modest-easysetup-wizard.c:
2104 (create_page_account_details):
2105 * src/maemo/modest-account-settings-dialog.c:
2106 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2107 widgets, because this might not be the default in future versions of the Maemo GTK+.
2108 However, I can not not get capitalization to work even in a simple test case.
2110 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2112 * src/maemo/easysetup/modest-easysetup-wizard.c:
2113 (create_page_custom_incoming), (create_page_custom_outgoing):
2114 * src/maemo/modest-account-settings-dialog.c:
2115 (create_page_account_details), (create_page_incoming),
2116 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2117 instead of using gtk_check_button_with_label(), so they are aligned like the other
2118 widgets, as per the UI spec.
2120 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2122 * src/maemo/easysetup/modest-easysetup-wizard.c:
2123 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2124 * src/widgets/modest-validating-entry.c:
2125 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2126 Modest prefix instead of an EasySetup prefix.
2128 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2130 * src/widgets/modest-validating-entry.h:
2131 * src/widgets/modest-validating-entry.c: (on_insert_text),
2132 Added easysetup_validating_entry_set_max_func(), used to set a callback
2133 to call when the max number of characters is reached. GtkEntry has a max-length
2134 already but is silent about it.
2136 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2137 (create_page_account_details), (create_page_user_details),
2139 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2140 (create_page_account_details), (create_page_user_details),
2141 (create_page_outgoing):
2142 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2143 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2144 the UI spec, when the user tries to enter more than the max number of characters.
2146 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2148 * src/maemo/easysetup/modest-easysetup-wizard.c:
2149 (create_page_user_details), (create_page_custom_incoming),
2150 (create_page_custom_outgoing):
2151 * src/maemo/modest-account-settings-dialog.c:
2152 (create_page_user_details), (create_page_incoming),
2153 (create_page_outgoing):
2154 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2155 (modest_connection_specific_smtp_edit_window_init):
2156 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2157 not appropriate. Bad Maemo-specific defaults!.
2159 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2161 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2162 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2163 (modest_signature_editor_dialog_set_settings):
2164 Disable the label and textview when the checkbox is disabled, and use the
2165 specified (UI spec) default signature text.
2167 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2169 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2170 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2172 * src/modest-defs.h:
2173 * src/modest-account-mgr-helpers.h:
2174 * src/modest-account-mgr-helpers.c:
2175 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2177 * src/maemo/Makefile.am:
2178 * src/maemo/modest-signature-editor-dialog.c:
2179 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2182 * src/maemo/modest-account-settings-dialog.h:
2183 * src/maemo/modest-account-settings-dialog.c:
2184 (modest_account_settings_dialog_finalize), (on_button_signature),
2185 (save_configuration): Use the new dialog when the Edit button is pressed, and
2186 save the changes if necessary, as per the UI spec.
2188 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2190 * src/maemo/Makefile.am:
2191 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2192 based on maemo-develoers email from Dirk.
2194 * src/maemo/easysetup/modest-easysetup-wizard.c:
2195 (create_page_welcome), (create_page_account_details),
2196 (create_page_user_details), (create_page_complete_easysetup),
2197 (create_page_custom_incoming), (create_page_custom_outgoing),
2198 (create_page_complete_custom),
2199 (modest_easysetup_wizard_dialog_init):
2200 * src/maemo/modest-account-settings-dialog.c:
2201 (create_page_account_details), (create_page_user_details),
2202 (create_page_incoming), (create_page_outgoing),
2203 (modest_account_settings_dialog_init):
2204 * src/maemo/modest-connection-specific-smtp-window.c:
2205 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2207 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2209 * src/maemo/easysetup/modest-easysetup-wizard.c:
2210 (create_page_account_details), (create_page_custom_outgoing),
2211 (create_page_complete_custom):
2212 * src/maemo/modest-account-settings-dialog.c:
2213 (create_page_user_details), (create_page_incoming),
2214 (create_page_outgoing):
2215 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2216 (modest_connection_specific_smtp_edit_window_init):
2217 Use the correct (UI spec) port min/max, and use horizontal separators,
2220 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2222 * src/maemo/easysetup/modest-easysetup-wizard.c:
2223 (set_default_custom_servernames):
2224 * src/maemo/modest-account-settings-dialog.c:
2225 (create_page_incoming), (on_combo_outgoing_security_changed),
2226 (on_combo_incoming_security_changed), (create_page_outgoing),
2227 (modest_account_settings_dialog_set_account_name),
2228 (save_configuration):
2229 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2230 (on_combo_security_changed),
2231 (modest_connection_specific_smtp_edit_window_init),
2232 (modest_connection_specific_smtp_edit_window_set_connection),
2233 (modest_connection_specific_smtp_edit_window_get_settings):
2234 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2237 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2240 * src/maemo/easysetup/modest-easysetup-wizard.c:
2241 (create_page_custom_outgoing), (create_page_complete_custom):
2242 * src/maemo/modest-account-settings-dialog.c:
2243 (create_page_user_details), (create_page_outgoing):
2244 * src/maemo/modest-account-view-window.c: (button_box_new):
2245 Use changed logical IDs as per the most recent UI spec:
2246 mcen_bd_emailsetup_edit -> mcen_bd_edit
2247 mcen_bd_emailsetup_delete -> mcen_bd_delete
2248 mcen_bd_emailsetup_close -> mcen_bd_close
2250 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2254 * src/dbus_api/Makefile.am:
2255 * src/dbus_api/modest-dbus-callbacks.c:
2256 * src/dbus_api/modest-dbus-callbacks.h:
2257 * src/maemo/modest-platform.c: (modest_platform_init):
2258 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2260 * tests/Makefile.am:
2261 * tests/dbus_api/Makefile.am:
2262 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2264 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2266 * src/maemo/modest-account-settings-dialog.c:
2267 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2268 Removed unnecessary includes.
2270 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2272 * src/maemo/easysetup/modest-easysetup-wizard.c:
2273 * src/maemo/modest-account-settings-dialog.c:
2274 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2275 * src/widgets/Makefile.am:
2276 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2277 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2278 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2279 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2280 * src/widgets/modest-secureauth-combo-box.c:
2281 * src/widgets/modest-secureauth-combo-box.h:
2282 * src/widgets/modest-serversecurity-combo-box.c:
2283 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2284 made the GObject names more consistent with the rest of the Modest code.
2286 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2288 * src/maemo/easysetup/Makefile.am:
2289 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2290 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2291 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2292 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2293 * src/maemo/easysetup/modest-easysetup-wizard.c:
2294 * src/maemo/easysetup/modest-validating-entry.c:
2295 * src/maemo/easysetup/modest-validating-entry.h:
2296 * src/maemo/modest-account-settings-dialog.c:
2297 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2298 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2299 widgets/ because they are used outside of easysetup too. After checking in,
2300 svn will allow me to rename them too.
2302 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2304 * src/gnome/modest-msg-edit-window.c:
2305 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2306 linker error, to fix the build on the GNOME platform.
2307 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2308 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2309 ifdefed out to avoid a warning.
2311 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2313 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2314 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2315 some alternative for GTK+ 2.6.
2317 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2319 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2321 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2322 specified for EmailAccountsDialog in UI spec.
2324 * src/maemo/easysetup/modest-easysetup-wizard.c:
2325 * src/maemo/easysetup/modest-easysetup-wizard.h:
2326 * src/maemo/modest-account-settings-dialog.c:
2327 * src/maemo/modest-account-settings-dialog.h:
2328 Reuse a member window widget for the connection-specific SMTP server accounts,
2329 so we can tell it to create/save the accounts only if we actually save changes.
2331 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2332 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2333 (modest_connection_specific_smtp_edit_window_get_settings):
2334 Return a struct instance for temporarily remembering the entered data.
2336 * src/maemo/modest-connection-specific-smtp-window.h:
2337 * src/maemo/modest-connection-specific-smtp-window.c:
2338 (modest_connection_specific_smtp_window_finalize),
2339 (modest_connection_specific_smtp_window_fill_with_connections),
2341 (modest_connection_specific_smtp_window_save_server_accounts),
2342 (update_model_server_names): Do not actually save data until asked,
2343 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2345 (on_selection_changed),
2346 (modest_connection_specific_smtp_window_init): Disable the edit
2347 button when nothing is selected.
2349 * src/modest-account-mgr-helpers.c:
2350 * src/modest-account-mgr-helpers.h:
2351 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2354 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2356 * src/modest-account-mgr-helpers.h:
2357 * src/modest-account-mgr-helpers.c:
2358 (modest_account_mgr_get_unused_account_name),
2359 (modest_account_mgr_get_unused_account_display_name): Added these
2360 utility functions, to avoid code duplication.
2362 * src/maemo/easysetup/modest-easysetup-wizard.c:
2363 (create_page_account_details), (create_account):
2364 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2365 (on_combo_security_changed),
2366 (modest_connection_specific_smtp_edit_window_init),
2367 (modest_connection_specific_smtp_edit_window_save_settings):
2368 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2369 * src/maemo/modest-connection-specific-smtp-window.c:
2370 (modest_connection_specific_smtp_window_finalize),
2371 (modest_connection_specific_smtp_window_fill_with_connections),
2372 (on_button_edit), (modest_connection_specific_smtp_window_init):
2373 * src/maemo/modest-connection-specific-smtp-window.h:
2374 Implementing saving of connection-specific server accounts.
2376 But I need to refactor this so we can save the data for each
2377 possible connection-specific account and only actually create the server accounts
2378 when the easysetup finished, or the OK button is pressed on the account settings
2381 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2383 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2384 (on_combo_security_changed):
2385 (modest_connection_specific_smtp_edit_window_init):
2386 Auto-fill the port number as in the account settings.
2388 (modest_connection_specific_smtp_edit_window_set_connection):
2389 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2390 * src/maemo/modest-connection-specific-smtp-window.c:
2391 (fill_with_connections), (on_button_edit),
2392 (modest_connection_specific_smtp_window_init):
2393 Turn the edit window into a dialog to simplify the code, and
2394 set a WM hint as in a GtkDialog, because only a popup can be on top of
2395 another window in Maemo, and popups usually have no WM decoration.
2397 * src/modest-defs.h:
2398 * src/modest-account-mgr-helpers.c:
2399 (modest_account_mgr_set_connection_specific_smtp),
2400 (modest_account_mgr_remove_connection_specific_smtp),
2401 (modest_account_mgr_get_connection_specific_smtp):
2402 * src/modest-account-mgr-helpers.h: Some functions to write the
2403 connection-specific SMTP server information. Not yet used.
2406 * src/widgets/modest-folder-view.c: (text_cell_data):
2407 Fix a warning about an uninitialized variable.
2408 (on_configuration_key_changed): Put an #ifdef around the use
2409 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2411 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2413 * src/maemo/modest-account-settings-dialog.h:
2414 * src/maemo/modest-account-settings-dialog.c:
2415 Added connect_for_modified() utility function to mark the new modified boolean.
2417 (create_page_account_details), (create_page_user_details),
2418 (create_page_incoming), (create_page_outgoing), (on_response),
2419 (modest_account_settings_dialog_init),
2420 (modest_account_settings_dialog_set_account_name):
2421 Only warn about unsaved changes when there are actually unsaved changes.
2423 * src/modest-account-mgr-helpers.c:
2424 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2425 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2426 to get the data from there in future.
2428 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2430 * src/modest-defs.h:
2432 * src/modest-account-mgr-helpers.h:
2433 * src/modest-account-mgr-helpers.c:
2434 Store the security account setting in a single conf key instead of using
2435 the options list, so that the list is left for just the to-be-removed camel hack,
2436 and because gconf_client_set_list() is failing for some reason.
2438 * src/modest-account-mgr.c:
2439 (modest_account_mgr_add_server_account):
2440 * src/maemo/modest-account-settings-dialog.c:
2441 (modest_account_settings_dialog_set_account_name),
2442 (save_configuration): Use the renamed functions.
2445 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2447 * src/widgets/Makefile.am:
2448 * src/widgets/modest-limit-retrieve-combo-box.c:
2449 * src/widgets/modest-limit-retrieve-combo-box.h:
2450 * src/widgets/modest-retrieve-combo-box.c:
2451 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2452 the account settings dialog.
2454 * src/modest-defs.h:
2455 * src/modest-account-mgr-helpers.h:
2456 * src/modest-account-mgr-helpers.c:
2457 (modest_server_account_get_option_secure_auth),
2458 (modest_server_account_set_option_secure_auth):
2459 * src/modest-account-mgr.c:
2460 (modest_account_mgr_add_server_account):
2461 Use the existing AUTH_MECH conf key for the secure-auth setting,
2462 instead of putting it in the list options, because this was actually used already.
2464 * src/maemo/modest-account-settings-dialog.c:
2465 (create_page_account_details),
2466 (modest_account_settings_dialog_set_account_name),
2467 (save_configuration):
2468 * src/maemo/modest-account-settings-dialog.h:
2469 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2470 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2472 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2474 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2475 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2476 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2478 * src/modest-defs.h:
2479 * src/maemo/modest-account-settings-dialog.c:
2480 (create_page_incoming), (on_combo_outgoing_security_changed),
2481 (on_combo_incoming_security_changed), (create_page_outgoing),
2482 (modest_account_settings_dialog_set_account_name),
2483 (save_configuration): Load/Save the port number, and change it when the
2484 security combo changes, to suitable defaults.
2486 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2488 * src/modest-account-mgr.c:
2489 (modest_account_mgr_add_server_account): Set the security and secure-auth
2490 options, and add a comment saying that the other camel-specific options should be
2493 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2495 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2497 * src/modest-tny-account-store.c: (account_list_free),
2498 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2499 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2502 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2504 * src/modest-protocol-info.c:
2505 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2506 is required by our UI spec. Maybe something in our implementation will use this eventually.
2507 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2508 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2509 instead of the previous 0 placeholder.
2511 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2512 secure-auth settings.
2513 * src/modest-account-mgr-helpers.h:
2514 * src/modest-account-mgr-helpers.c:
2515 (modest_server_account_data_get_option_secure_auth),
2516 (modest_server_account_set_option_secure_auth),
2517 (modest_server_account_data_get_option_security),
2518 (modest_server_account_set_option_security): Added this API for getting and setting the security
2519 and secure-auth settings.
2521 * src/maemo/modest-account-settings-dialog.h:
2522 * src/maemo/modest-account-settings-dialog.c:
2523 (modest_account_settings_dialog_finalize), (check_data),
2524 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2525 about changing titles.
2526 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2527 (save_configuration): Save the security and secure-auth settings.
2529 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2530 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2532 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2534 * src/modest-defs.h:
2535 * src/modest-account-mgr.c:
2536 (modest_account_mgr_add_server_account):
2537 Added and used defines for the options key and value pair strings,
2538 that are used so far, though they do not seem to correspond to anything in our
2539 UI specs or ModestProtocol enum.
2541 * src/modest-account-mgr-helpers.h:
2542 * src/modest-account-mgr-helpers.c:
2543 (compare_option_strings_for_name),
2544 (modest_server_account_data_get_option_value),
2545 (modest_server_account_data_get_option_bool),
2546 (modest_account_mgr_get_server_account_option):
2547 Added helper functions for parsing the options GSList.
2549 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2551 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2552 display name is based on the supplied account name.
2553 * src/modest-account-mgr.c:
2554 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2555 with an inefficient, but good-enough, implementation.
2557 * src/maemo/easysetup/modest-easysetup-wizard.c:
2558 (create_page_account_details), (on_before_next), (create_account):
2559 Check for existing display names rather than (non-user-visible) account names, and just
2560 create and set a unique account name at the end.
2562 * src/maemo/modest-account-settings-dialog.c:
2563 (modest_account_settings_dialog_init),
2564 (modest_account_settings_dialog_set_account_name),
2565 (create_page_incoming): Show the display name, instead of the account name.
2566 (on_response): Do some (not all) extra checks, as in the UI spec.
2567 (save_configuration): Save the display name if it was changed.
2569 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2571 * po/en_GB.po: Added needed logical ID and translation.
2572 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2573 (init_view): Made the is-default column clicking work.
2575 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2578 * src/maemo/easysetup/Makefile.am:
2579 * src/maemo/easysetup/modest-easysetup-wizard.c:
2580 (modest_easysetup_wizard_dialog_init):
2581 * src/maemo/easysetup/provider-data-test.keyfile:
2582 * src/maemo/easysetup/provider-data.keyfile:
2583 Moved the provider data file to the new modest-providers-data package and used it from there.
2585 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2587 * src/modest-local-folder-info.c:
2588 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2589 N_() was already used on the static strings, but this just marks it for translation without
2590 using the translation.
2592 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2594 * src/maemo/modest-account-settings-dialog.c:
2595 (create_page_incoming),
2596 (modest_account_settings_dialog_set_account_name):
2597 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2598 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2599 I will do this if nobody else gets there first.
2601 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2603 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2604 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2605 save the security stuff.
2607 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2609 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2610 Set the email address and user fullname, which I now see must be
2613 * src/maemo/modest-account-settings-dialog.h:
2614 * src/maemo/modest-account-settings-dialog.c:
2616 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2617 leave-on-server and authentication.
2618 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2621 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2624 * src/maemo/modest-account-settings-dialog.c:
2625 * src/maemo/modest-account-settings-dialog.h:
2626 Most (but not all) of the widgets are now present as specified by the UI spec.
2627 No changes are yet saved, and some details are not properly shown yet.
2629 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2631 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2633 * src/maemo/Makefile.am:
2634 * src/maemo/modest-account-settings-dialog.c:
2635 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2636 an existing account. Doesn't do much yet.
2638 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2639 Open the accounts settings dialog when Edit is clicked.
2641 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2643 * src/maemo/easysetup/Makefile.am:
2644 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2646 * src/maemo/easysetup/modest-easysetup-wizard.c:
2647 (modest_easysetup_wizard_dialog_init):
2648 Try to get the source directory from the build system,
2649 instead of hard-coding "./" into the source code, when opening our local
2650 copies of the configuration files.
2651 But this still fails when opening the wizard from the Accounts window,
2652 maybe because the working directory seems to change at runtime.
2653 So the wizard will fail the second time unless you copy the files into their
2654 proper locations - see the stdout warnings for the paths.
2656 (create_page_account_details),(on_before_next):
2657 Check for existing non-server accounts instead of server accounts,
2658 so the default account name is useful again, and to prevent trying to
2661 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2662 Show the wizard when New is clicked.
2664 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2665 (init_view): Show the column headers, and show the columns that are
2666 specified in the UI specs. However, something in Maemo's GTK+ prevents
2667 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2668 change the default account. This is despite unsetting the special properties.
2670 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2672 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2673 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2674 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2675 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2676 to make that clearer.
2677 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2679 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2681 * src/maemo/modest-account-view-window.c:
2682 (modest_account_view_window_init),
2683 (modest_account_view_window_new):
2684 Use the same buttons as specified in the
2685 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2686 the existing widgets, which never had a chance of working.
2687 Put the ModestAccountView treeview in a scrolled window.
2688 Do not repeat the initialization in both _init() and _new().
2690 * src/widgets/modest-account-view.c: (update_account_view):
2691 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2692 this widget and window shows no accounts.
2694 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2696 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2698 * src/maemo/easysetup/modest-easysetup-wizard.c:
2699 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2700 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2701 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2704 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2705 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2706 accounts exist yet, as in the UI spec.
2708 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2710 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2712 * src/maemo/Makefile.am:
2713 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2714 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2715 New window for editing connection-specific smtp details.
2716 Not fully implemented.
2718 * src/maemo/modest-connection-specific-smtp-window.c:
2719 (modest_connection_specific_smtp_window_finalize) :
2720 unref the tree model.
2721 (on_button_edit): Show the edit window.
2723 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2725 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2728 * src/maemo/Makefile.am:
2729 * src/maemo/modest-connection-specific-smtp-window.c:
2730 * src/maemo/modest-connection-specific-smtp-window.h:
2731 New window for showing the list of connections, for connection-specific
2732 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2733 * src/maemo/easysetup/modest-easysetup-wizard.c:
2734 (create_page_custom_outgoing): Show the new window when the button is clicked.
2736 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2738 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2739 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2740 * src/maemo/modest-msg-edit-window.c:
2741 (modest_msg_edit_window_insert_image):
2742 * src/modest-conf.c: (modest_conf_key_escape):
2743 * src/modest-mail-operation.c:
2744 (modest_mail_operation_send_new_mail):
2745 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2746 (modest_ui_actions_on_new_account):
2747 * src/widgets/modest-attachment-view.c: (update_filename_request):
2748 * src/widgets/modest-mail-header-view.c:
2749 Corrected warnings that were breaking the build, by commenting out unused variables,
2750 and a function, and by including a header.
2752 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2754 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2755 so we can #ifdef around platform-specific code when necessary.
2756 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2757 to allow this to build for the GNOME platform too.
2759 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2761 * src/maemo/easysetup/modest-easysetup-wizard.c:
2762 Added util_increment_name() and used it in create_page_account_details()
2763 to make sure that the default account name is always a new name.
2765 (modest_easysetup_wizard_dialog_init),
2766 (set_default_custom_servernames): Some minor memory management fixes.
2768 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2772 * src/modest-runtime.c: (init_i18n): Restored the translation
2773 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2774 are defined in config.h, and the translations are installed.
2776 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2777 is defined for translation.
2779 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2781 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2783 * src/maemo/easysetup/modest-easysetup-wizard.c:
2784 (modest_easysetup_wizard_dialog_init):
2785 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2786 Use realistic paths (though they should use $prefix generically) to the
2787 mcc_mapping and provider-data.keyfile files which might work when they
2788 are installed by the future version of the operator-wizard package,
2789 and then fallback to paths in our source code, with an explanatory
2792 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2796 * src/maemo/Makefile.am:
2797 * src/maemo/easysetup/: Added files from the previously-exernal
2798 osso-modest-easysetup.
2799 * src/maemo/modest-main-window-ui.h:
2800 * src/modest-ui-actions.c:
2801 * src/modest-ui-actions.h:
2802 Added modest_ui_actions_on_new_account() as a signal handler for the
2803 New Account menu item. It shows the easysetup wizard.
2804 * po/en_GB.po: Added additional needed logical IDs and translations.
2806 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2807 Apparently ChangeLog is not used for some vague Nokia legal reasons.