2 2007-06-06 Marcus Bauer <marcusb@openismus.com>
4 * libmodest-dbus-client/libmodest-dbus-client.h:
5 added libmodest_dbus_client_compose_mail()
6 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
8 added functions needed for SendAsMail() functionality
9 * src/maemo/modest-msg-edit-window.c:
10 (modest_msg_edit_window_attach_file_noninteractive):
11 non interactively attaching files to message edit window
12 * src/widgets/modest-msg-edit-window.h:
13 * tests/dbus_api/Makefile.am:
14 added test_compose_mail.c
15 * tests/dbus_api/test_compose_mail.c: (main):
17 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
19 * src/modest-account-view.c:
20 Fixed bug projects.maemo.org bug NB#59307
22 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
24 * src/maemo/easysetup/modest-easysetup-wizard.c:
25 (get_serverport_incoming), (on_before_next), (create_account):
26 * src/maemo/modest-account-settings-dialog.c:
27 (modest_account_settings_dialog_set_account_name):
28 * src/maemo/modest-maemo-utils.c:
29 (on_camel_account_get_supported_secure_authentication_status),
30 (on_camel_account_get_supported_secure_authentication),
31 (on_secure_auth_cancel),
32 (modest_maemo_utils_get_supported_secure_authentication_methods):
34 Implemented security authentication for settings and easysetup.
36 2007-06-05 Murray Cumming <murrayc@murrayc.com>
38 * src/maemo/modest-main-window.c: (create_details_widget):
39 Show the total size for memory card accounts too, instead of showing
40 the name again. Fixes bug projects.maemo.org bug NB#59307.
42 2007-06-05 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-tny-simple-folder-store.c:
46 * src/modest-tny-simple-folder-store.h: Removed.
48 * src/modest-tny-local-folders-account.h
49 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
50 for the local-folders maildir, with an extra TnyMergedFolder containing
51 the folders of the per-account outbox store accounts.
52 * src/modest-tny-account-store.c: (get_server_accounts):
53 Add the outboxes to the special local folders account after creating it.
55 * src/modest-tny-account.c:
56 (modest_tny_account_new_for_local_folders): Create the derived
57 account when creating the main local-folders account.
59 * src/maemo/modest-main-window.c: (create_details_widget),
60 (modest_main_window_set_contents_style):
61 Adapted to the use of the derived account instead of the folder store.
63 * src/modest-ui-actions.c:
64 (modest_ui_actions_on_folder_selection_changed):
65 * src/modest-ui-dimming-rules.c:
66 (modest_ui_dimming_rules_on_new_folder):
67 * src/widgets/modest-folder-view.c: (text_cell_data),
68 (icon_cell_data), (filter_row), (update_model),
69 (get_cmp_rows_type_pos):
72 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
73 Do not get the priv struct, because no priv struct has been set,
74 to avoid a runtime warning.
76 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
77 #ifelse with #else, to fix a warning, to fix the build.
80 2007-06-05 Christian Kellner <ckellner@openismus.com>
82 * libmodest-dbus-client/libmodest-dbus-client.c:
83 Fix small typo in doc (why do you always see them
84 AFTER committing stuff?)
87 2007-06-05 Christian Kellner <ckellner@openismus.com>
89 * libmodest-dbus-client/libmodest-dbus-client.c:
90 (libmodest_dbus_client_search):
91 Initialize hit list with NULL. Also set folder list
92 to "" if NULL was supplied.
95 2007-06-03 Christian Kellner <ckellner@openismus.com>
97 * libmodest-dbus-client/libmodest-dbus-client.c:
98 (modest_search_hit_list_free):
99 Make it save to call it with NULL.
101 * src/dbus_api/modest-dbus-callbacks.c:
102 * src/modest-search.c:
103 Return full ModestSearchHits as the search result list not TnyHeader
104 since can't be around withouth the correspoding TnyFolder.
106 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
108 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
109 Added currently commented code to check for secure auth
111 * src/maemo/modest-account-settings-dialog.c: (on_response),
112 (save_configuration), (show_ok):
113 Fixed projects.maemo.org bugs NB #59248 and #59251
115 * src/maemo/modest-maemo-utils.c:
116 (on_camel_account_get_supported_secure_authentication_status),
117 (on_camel_account_get_supported_secure_authentication),
118 (modest_maemo_utils_get_supported_secure_authentication_methods):
119 * src/maemo/modest-maemo-utils.h:
120 Moved get_supported_secure_authentication() method here to be able
121 to use it from easysetup wizard.
123 * src/modest-pair.c: (on_pair_compare_as_string):
124 Should compare string with first part of pair and not
125 strcmp pairs which will crash.
127 * src/modest-protocol-info.c:
128 (modest_protocol_info_protocol_is_store):
129 * src/modest-protocol-info.h:
130 Added modest_protocol_info_get_auth_protocol_name()
132 2007-06-03 Armin Burgmeier <armin@openismus.com>
134 * src/modest-mail-operation.c:
135 (modest_mail_operation_get_msgs_full): Set priv->account also when
136 only retrieving a single message. This avoids a crash when canceling
139 (modest_mail_operation_notify_end): Do not explicitely remove the
140 operation from the queue but only emit the progress_changed signal.
141 The queue itself listens to that signal to remove the operation when
142 it is finished. This reduces coupling and removes a potential deadlock
143 when modest_mail_operation_notify_end() is called from the queue
144 itself. If that is a problem performance-wise, I would suggest to
145 implement a status-changed signal or something.
147 * src/modest-mail-operation-queue.c: Make sure to never call a
148 function from another file while the queue is locked. This (hopefully)
149 fixes another deadlock when exiting the application while retrieving
152 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
154 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
155 Fixed build if libogs is not available
157 2007-06-03 Christian Kellner <ckellner@openismus.com>
159 * libmodest-dbus-client/libmodest-dbus-client.h:
160 * libmodest-dbus-client/libmodest-dbus-client.c:
161 (libmodest_dbus_client_delete_message):
162 Implement deletion of messages (Client side).
164 (modest_search_hit_free),
165 (modest_search_hit_list_free):
166 Utility functions to free the result hits.
168 * src/dbus_api/modest-dbus-api.h:
169 * src/dbus_api/modest-dbus-callbacks.c:
171 (modest_dbus_req_handler):
172 Implement deletion of messages (Server side).
174 * tests/dbus_api/test_search.c: (main):
177 * tests/dbus_api/Makefile.am:
178 * tests/dbus_api/test_delete_message:
179 Add little test for the message deletion logic
181 2007-06-03 Armin Burgmeier <armin@openismus.com>
183 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
184 when the operation queue was not empty. projects.maemo.org bug
187 2007-06-03 Armin Burgmeier <armin@openismus.com>
189 * src/widgets/modest-account-view.c
190 (on_account_default_toggled): Toggle default account column
191 explicitely instead of waiting for gconf notification (which is
192 currently ignored). This should fix projects.maemo.org bug NB#56910
193 for now. It should probably be removed when gconf notifications are
196 2007-06-03 Christian Kellner <ckellner@openismus.com>
198 * libmodest-dbus-client/libmodest-dbus-client.c:
199 Removed debugging spew.
201 * src/dbus_api/modest-dbus-callbacks.c:
202 Added debugging info.
204 * src/modest-search.c:
205 (modest_search_all_accounts):
206 Use tny_account_store_get_accounts () on the account store
207 to get all accounts which is the way to get all accounts.
209 * tests/dbus_api/test_search.c: (main):
210 Make it possible to supply the search term on the command line.
212 2007-06-03 Christian Kellner <ckellner@openismus.com>
214 * libmodest-dbus-client/libmodest-dbus-client.c:
215 * libmodest-dbus-client/libmodest-dbus-client.h:
216 Implement searching for mesages over raw dbus. (Client side)
218 * src/dbus_api/Makefile.am:
219 * src/dbus_api/modest-dbus-api.h:
220 * src/dbus_api/modest-dbus-callbacks.c:
221 * src/dbus_api/modest-dbus-callbacks.h:
222 Search framework (Server side). Also implement on_idle_open_message().
224 * src/maemo/modest-platform.c: (modest_platform_init):
225 Prepare for raw dbus/osso rpc interaction.
227 * src/modest-search.h:
228 Changed minsize from unspecific guint to guint32.
230 * src/modest-search.c:
232 Added strange hack which magically made tnymail work.
234 (modest_search_folder),
235 (modest_search_account),
236 (modest_search_all_accounts):
237 Implement helper functions to search all accounts, specific account
240 * tests/dbus_api/Makefile.am:
241 * tests/dbus_api/test_open_message.c:
242 Read url to open from commandline.
244 * tests/dbus_api/test_search.c:
245 Implement small test for dbus search stuff
247 2007-06-02 Armin Burgmeier <armin@openismus.com>
249 * src/maemo/modest-account-settings-dialog.c: Changed window title to
250 include account type and account title. This fixes projects.maemo.org
253 * src/maemo/modest-account-view-window.c: Set a title for the window.
255 2007-06-02 Armin Burgmeier <armin@openismus.com>
257 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
258 incoming and outgoing server name based on email address and server
259 types as long as the names have not been edited manually. This fixes
260 projects.maemo.org bug NB#58671.
262 2007-06-02 Armin Burgmeier <armin@openismus.com>
264 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
265 server type cannot be changed in future to the incoming details page
266 when creating an account. This fixes projects.maemo.org bug NB#59029.
268 2007-06-02 Armin Burgmeier <armin@openismus.com>
270 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
271 and assigned max width chars so that they wrap instead of being
272 truncated. Fixes projects.maemo.org bug NB#56126.
274 2007-06-02 Armin Burgmeier <armin@openismus.com>
276 * src/maemo/modest-connection-specific-smtp-window.c: Add an
277 introductory note to the connection specific smtp servers dialog, as
278 section 8.12 of the email UI specification requires. This fixes
279 projects.maemo.org bug NB#59212.
281 2007-06-01 Murray Cumming <murrayc@murrayc.com>
283 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
284 Check for running mail operations, and offer to cancel them, as per the UI
285 spec. This fixes projects.maemo.org bug NB#59041 .
286 However, I suspect that tinymail may still use the network connection
287 in ways that we cannot detect or cancel. But it should at least adapt to
290 2007-06-01 Murray Cumming <murrayc@murrayc.com>
292 * src/modest-tny-account-store.c: (recreate_all_accounts),
293 (get_cached_accounts), (get_server_accounts): Do more sensible
294 ref-counting of the temporarily-cached outbox accounts list. This seems
295 to fix a crash when entering the password when the password was wrong.
297 2007-06-01 Murray Cumming <murrayc@murrayc.com>
299 * src/gnome/modest-main-window.c: (connect_signals):
300 * src/modest-tny-account-store.c: (get_password),
301 (modest_tny_account_store_alert): Added comments and clues and
302 commented-out code about how we currently fail to deal with connection
303 errors and wrong passwords, and how we should.
305 2007-06-01 Murray Cumming <murrayc@murrayc.com>
307 * src/widgets/modest-retrieve-combo-box.c:
308 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
309 This fixes projects.maemo.org bug NB#58472 .
311 2007-06-01 Murray Cumming <murrayc@murrayc.com>
313 * src/maemo/easysetup/modest-easysetup-wizard.c:
314 (create_page_complete_easysetup):
315 (create_page_complete_custom): Correct the last commit,
316 putting the correct sentences in the correct pages.
318 2007-06-01 Murray Cumming <murrayc@murrayc.com>
320 * src/maemo/easysetup/modest-easysetup-wizard.c:
321 (create_page_complete_custom): Show the second sentence of text
322 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
325 2007-06-01 Murray Cumming <murrayc@murrayc.com>
327 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
328 Set the leave-on-server conf key by default. This fixes
329 projects.maemo.org bug NB#59258 .
331 2007-06-01 Murray Cumming <murrayc@murrayc.com>
333 * src/maemo/modest-account-view-window.c:
334 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
335 logical ID for the confirmation messages. Fixed projects.maemo.org bug
338 2007-06-01 Murray Cumming <murrayc@murrayc.com>
340 * src/maemo/easysetup/modest-easysetup-wizard.c:
341 (create_caption_new_with_asterisk):
342 * src/maemo/modest-account-settings-dialog.c:
343 (create_caption_new_with_asterisk):
344 Uncomment the code to add the asterisk, because they are no longer in the
345 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
346 (update_incoming_server_title): Add an asterisk here too.
348 2007-06-01 Murray Cumming <murrayc@murrayc.com>
350 * src/maemo/modest-maemo-global-settings-dialog.c:
351 (current_connection): Check that we are even connected before trying to
352 get the current connection name, to prevent a warning.
354 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
355 Change the comments because tny_maemo_conic_device_connect() is now meant to
357 * src/modest-mail-operation.c:
358 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
359 make sure we have a connection and fail if we can't connect.
361 2007-05-31 Murray Cumming <murrayc@murrayc.com>
363 * src/maemo/modest-main-window.c:
364 (on_account_store_connecting_finished): Do not try to get the
365 connection ID if we are not really connected. I am surprised that
366 this signal handler is called when we are not connected.
368 2007-05-31 Murray Cumming <murrayc@murrayc.com>
370 * src/modest-error.h:
371 * src/modest-ui-actions.c:
372 (modest_ui_actions_get_msgs_full_error_handler):
373 Renamed an enum, added comments, added an enum
374 for retrieve-limit errors.
376 * src/modest-mail-operation.c: (foreach_add_item),
377 (internal_folder_observer_update), (update_account_thread),
378 (modest_mail_operation_get_msgs_full):
379 (modest_mail_operation_update_account),
380 Added comments about how this works, and some code that should
381 (but does not) check the retrieve-limit. See the TODO comment.
383 2007-05-31 Murray Cumming <murrayc@murrayc.com>
385 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
386 Initialize help_id to fix the build. Warnings are good.
388 2007-05-31 Murray Cumming <murrayc@murrayc.com>
390 * src/widgets/modest-hbox-cell-renderer.c:
391 (modest_hbox_cell_renderer_append):
392 * src/widgets/modest-vbox-cell-renderer.c:
393 (modest_vbox_cell_renderer_append):
394 Fix the last commit by doing an extra ref.
396 2007-05-31 Murray Cumming <murrayc@murrayc.com>
398 * src/widgets/modest-hbox-cell-renderer.c:
399 (modest_hbox_cell_renderer_append):
400 * src/widgets/modest-vbox-cell-renderer.c:
401 (modest_vbox_cell_renderer_append):
402 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
403 to fix the build with Maemo Bora.
404 However, there seems to be a remaining crash, probably due to reference
407 2007-05-30 Murray Cumming <murrayc@murrayc.com>
409 * src/modest-tny-account.c:
410 (modest_tny_account_new_for_local_folders):
411 Use hildon_file_system_info_async_new() to get a better name for
412 the memory card account, setting it as the account name.
413 The timing seems to work, but this is probably
414 not the best place to do this. See the TODO comment.
415 * src/maemo/modest-main-window.c: (create_details_widget):
416 * src/widgets/modest-folder-view.c: (text_cell_data):
417 Use the tny account name instead of hardcoding a name.
419 2007-05-30 Christian Kellner <ckellner@openismus.com>
421 * src/modest-search.c: (modest_search):
422 Correctly set part_search_func even if we have already parsed
423 the query and thus a valid OgsTextSearcher object.
425 2007-05-30 Christian Kellner <ckellner@openismus.com>
428 Search and check for libogs.
431 Incooparte the ogs build env.
433 * src/modest-mime-part-search-stream.c:
434 * src/modest-mime-part-search-stream.h:
435 Removed since we do the real searching now in modest-search.c.
437 * src/modest-search.c:
438 * src/modest-search.h:
439 Implement support for ogs. We use that if available and requested
440 and fall back to modest_text_utils_utf8_strcmp (). The search logic
441 should now handle the corner case when the search term is spread
442 across multiple reads.
443 Also the logic in modest_search () was corrected to search all
444 requested fields until one is found.
446 2007-05-30 Murray Cumming <murrayc@murrayc.com>
448 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
451 * src/modest-init.c: Made modest_init_local_folders() take a
452 path and be public so we can iniitialize maildir folders on
455 * src/modest-local-folder-info.h:
456 * src/modest-local-folder-info.c:
457 (modest_local_folder_info_get_maildir_path): Add a path parameter.
459 * src/modest-tny-account.c:
460 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
461 still means the standard local-folders path on the local volume.
463 * src/modest-tny-account-store.c:
464 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
465 signal so we can detect mount/unmount of the MMC1 card, and do an update of
466 all accounts when that happens.
467 (get_server_accounts): If the MMC1 card is mounted, create a store account for
468 this too, so it shows up in the treeview.
470 2007-05-28 Murray Cumming <murrayc@murrayc.com>
472 * src/maemo/modest-maemo-global-settings-dialog.c:
473 (current_connection):
474 * src/widgets/modest-global-settings-dialog.c:
475 (current_connection_default):
476 Use the enum values instead of 0, 1 and -1,
477 to make the code clearer.
479 * src/modest-account-mgr-helpers.c:
480 (modest_account_mgr_get_connection_specific_smtp): Make this code
483 * src/modest-runtime.h:
484 * src/modest-runtime.c:
485 Added modest_runtime_remove_all_send_queues().
486 * src/maemo/modest-main-window.c:
487 (on_account_store_connecting_finished): Recreate the send queues,
488 using the appropriate transport accounts for this new connection.
489 Some futher adapting might be needed if the old send queues are not
490 automatically stopped at this point.
492 * src/modest-tny-account-store.c: (get_server_accounts):
493 Create the connection-specific transport accounts, so that they can
494 be found later by their ID.
496 * src/modest-tny-account.h:
497 * src/modest-tny-account.c:
498 Added modest_tny_account_new_from_server_account_name().
499 modest_tny_account_new_from_server_account(): Do not create the
500 send queues here, because they will be
501 recreated anyway when the connection changes for the first time.
503 2007-05-28 Murray Cumming <murrayc@murrayc.com>
505 * src/modest-local-folder-info.h:
506 * src/modest-local-folder-info.c:
507 (modest_per_account_local_outbox_folder_info_get_maildir_path),
508 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
509 tbox_folder): Take a modest account name instead of a server TnyAccount,
510 so we can have per-modest-account rather than per-transport-account
512 We must make sure that we change or recreate the exisitng send queues
513 when the connection changes for connection-specific transport accounts.
515 * src/modest-tny-account-store.c:
516 (create_per_account_local_outbox_folders): Create outboxed per modest
517 account, not per transport account.
519 * src/modest-tny-account.h:
520 * src/modest-tny-account.c:
521 (modest_tny_account_get_special_folder): For outboxes, get the
522 parent modest account name. The account is ignored for other folders.
523 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
524 modest account name rather than a server TnyAccount.
526 2007-05-25 Murray Cumming <murrayc@murrayc.com>
528 * src/modest-tny-account.c:
529 (modest_tny_account_new_from_server_account):
530 Call modest_runtime_get_send_queue() immediately after creating transport
531 accounts, so that they start trying to send email from the outbox as soon
532 as possible at startup. This is probably what we want.
534 * src/modest-mail-operation.c: (update_account_thread):
535 * src/modest-runtime.c: (modest_runtime_get_send_queue):
536 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
537 * src/modest-tny-send-queue.h:
538 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
539 (modest_ui_actions_on_send):
540 Added comments about how sending works, though it needs some more work.
542 2007-05-25 Murray Cumming <murrayc@murrayc.com>
544 * src/modest-tny-account.c:
545 (modest_tny_account_get_special_folder): Add TODO because this fails when
547 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
548 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
549 Do not try to show this window when there is no active account. The UI
550 specs does not tell us what to do in this case.
552 2007-05-24 Murray Cumming <murrayc@murrayc.com>
556 * src/maemo/Makefile.am:
557 * src/widgets/Makefile.am: Some dist fixes.
559 2007-05-24 Murray Cumming <murrayc@murrayc.com>
561 * src/maemo/modest-connection-specific-smtp-window.c:
562 (on_button_edit): Make the code clearer, to prevent a double free.
564 2007-05-24 Murray Cumming <murrayc@murrayc.com>
566 * src/maemo/modest-account-settings-dialog.c:
567 (modest_account_settings_dialog_set_account_name),
568 Check the connection-specific smtp servers checkbox if there are any.
570 * src/maemo/modest-connection-specific-smtp-edit-window.c:
571 (modest_connection_specific_smtp_edit_window_init):
572 Start with a suitable port number.
574 * src/modest-account-mgr-helpers.h:
575 * src/modest-account-mgr-helpers.c: Added
576 modest_account_mgr_get_has_connection_specific_smtp().
578 (modest_account_mgr_set_connection_specific_smtp),
579 (modest_account_mgr_remove_connection_specific_smtp),
580 (modest_account_mgr_get_has_connection_specific_smtp),
581 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
582 connection-specific smtp server accounts in the account, rather than
583 the server account conf dir.
585 This fixes bug projects.maemo.org bug NB#58263 .
587 * src/modest-tny-account-store.c:
588 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
589 if there are no server accounts yet, to prevent an infinite loop when there
590 are no accounts. Document that one must be called before the other.
592 2007-05-24 Murray Cumming <murrayc@murrayc.com>
594 * src/modest-account-mgr-helpers.c:
595 (modest_account_mgr_get_default_account): Make sure that at least
596 one account is always the default, if there are any enabled accounts.
597 This is just a sanity check that shouldn't be necessary.
599 * src/modest-account-mgr-priv.c:
600 (_modest_account_mgr_account_from_key): Unescape the conf key to
601 get the real account name. For instance, this is an issue if a space
602 was in the account name, which can happen because the account name
603 is generated from the display name.
604 (_modest_account_mgr_get_account_keyname): Always escape the
606 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
607 Unescape the conf keys to get the real account names.
609 For instance, previously the is-default radio button in the accounts
610 list was not checked for any accounts at first. This fixes that,
611 and might fix several similar bugs.
613 2007-05-23 Murray Cumming <murrayc@murrayc.com>
615 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
616 Removed some debug printfs.
618 2007-05-23 Murray Cumming <murrayc@murrayc.com>
620 Modest on-disk outbox directories are now here, for instance:
621 $HOME/.modest/outboxes/<account-id-1>/outbox
622 $HOME/.modest/outboxes/<account-id-2>/outbox
624 $HOME/.modest/local-folders/outbox
625 so we can have a separate outbox for each account.
626 But they are shown as one outbox in the GtkTreeView, by using a
627 TnyMergeFolder in a ModestTnySimpleFolderStore.
630 * src/modest-tny-simple-folder-store.c:
631 * src/modest-tny-simple-folder-store.h:
632 Added ModestTnySimpleFolderStore, used to contain folders from
633 other folder stores, such as other accounts.
635 * src/modest-tny-outbox-account.h:
636 * src/modest-tny-outbox-account.c:
637 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
638 used for the per-account local outbox folders.
640 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
641 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
642 only use this (internally) now for the non-outbox local folders.
645 * src/modest-init.c: Added modest_init_one_local_folder(), for
646 setting up the directory structure for each local folder.
648 * src/modest-local-folder-info.c:
649 (modest_per_account_local_outbox_folder_info_get_maildir_path),
650 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
652 * src/modest-local-folder-info.h:
653 * src/modest-tny-account-store.c: (on_account_removed),
654 (on_account_changed), (create_per_account_local_outbox_folders),
655 (get_server_accounts), (modest_tny_account_store_get_accounts),
656 (modest_tny_account_store_get_tny_account_by_account),
657 (modest_tny_folder_store_is_virtual_local_folders):
659 * src/modest-tny-account.h:
660 * src/modest-tny-account.c:
661 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
662 to create an on-disk per-account local outbox folder for each
664 (create_per_account_local_outbox_folders): Create a local outbox folder
665 for each transport account.
666 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
667 for all local folders.
669 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
670 instead of using g_object_get/set() directly. It is clearer.
672 (modest_tny_folder_store_get_message_count),
673 (modest_tny_folder_store_get_local_size
674 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
675 because we now use these with non-acount folder stores.
677 (modest_tny_account_get_special_folder),
678 (modest_tny_account_new_from_server_account),
679 (modest_tny_account_new_from_account):
680 (recurse_folders): Adjust to the new outbox system.
682 * src/modest-tny-folder.h:
683 * src/modest-tny-folder.c:
684 (modest_tny_folder_is_local_folder),
685 (modest_tny_folder_get_local_folder_type),
686 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
688 * src/widgets/modest-main-window.h:
689 * src/maemo/modest-main-window.c: (create_details_widget),
690 (modest_main_window_set_contents_style): Show details for any folder store,
693 (modest_tny_folder_get_rules):
694 Remove the const. C does not support constness enough for this.
696 * src/modest-ui-actions.c:
697 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
698 make all outboxes appear as one, in the usual local-folders tree node.
700 (set_active_account_from_tny_account),
701 (modest_ui_actions_on_folder_selection_changed):
702 * src/widgets/modest-folder-view.c: (text_cell_data),
703 (icon_cell_data), (filter_row),
704 (add_account_folders_to_merged_folder),
705 (add_account_folders_to_simple_folder_store), (),
706 (get_cmp_rows_type_pos), (cmp_rows),
707 (modest_folder_view_set_account_id_of_visible_server_account):
708 Adjust to the new outbox system, using generic folder stores and folders
711 2007-05-23 Christian Kellner <ckellner@openismus.com>
713 * src/modest-mail-operation.c:
714 (modest_mail_operation_update_account):
715 Use info->max_size instead of unintialized local var [small
716 build fix]. (Added TODO to review that change since I don't
719 2007-05-23 Marcus Bauer <marcusb@openismus.com>
721 * libmodest-dbus-client/libmodest-dbus-client.c:
722 (libmodest_dbus_client_compose_mail): function added
723 * src/dbus_api/modest-dbus-api.h:
724 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
725 (on_compose_mail): Implementation of the SendAsMail functionality
727 2007-05-22 Murray Cumming <murrayc@murrayc.com>
729 * src/modest-account-mgr.c:
730 (modest_account_mgr_add_server_account): Set the secure-connection
731 conf key for transport accounts as well as store accounts. I don't know
732 why the if was there. For instance, this makes sure that we use SSL
733 for the gmail preset from the easysetup wizard.
735 2007-05-22 Murray Cumming <murrayc@murrayc.com>
737 * src/gnome/modest-main-window.c:
738 (on_account_store_connecting_finished), (connect_signals):
739 * src/maemo/modest-main-window.c:
740 (on_account_store_connecting_finished), (connect_signals),
741 (modest_main_window_new):
742 Handle TnyAccountStore::connecting-finished instead of
743 TnyDevice::connection-changed, because we cannot actually perform
744 operations on accounts until TnyAccountStore has itself responded to
745 the TnyDevice::connection-changed signal. This prevents a GError from
747 Do not try to update at startup, because we (at least on scratchbox)
748 already do an update at startup when the device goes online.
749 This prevents a GError from tinymail.
750 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
751 Added TODO about stopping simultaneous operations.
753 2007-05-21 Murray Cumming <murrayc@murrayc.com>
755 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
756 * src/modest-mail-operation-queue.c:
757 (modest_mail_operation_queue_remove):
758 * src/modest-tny-account-store.c: When GErrors happen, give more clues
759 about where they happened.
761 2007-05-21 Murray Cumming <murrayc@murrayc.com>
763 * src/modest-ui-actions.c:
764 (modest_ui_actions_on_password_requested): Make sure that the remember
765 output parameter is always TRUE.
767 2007-05-21 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
770 Show a OK/Cancel dialog if the error is a question, though we still do not
771 know anything more about what we are asking the user.
772 * src/widgets/modest-folder-view.c: (on_drag_data_received):
773 Fix an uninitialized variable (helper). This is a logic error, however.
775 2007-05-21 Christian Kellner <ckellner@openismus.com>
777 * src/modest-search.h:
778 Correct bit shifting in the ModestSearchFlags enum.
780 2007-05-21 Murray Cumming <murrayc@murrayc.com>
782 * src/modest-tny-account.c:
783 (modest_tny_account_new_from_server_account): Do not use the lsub and
784 check-all hard-coded IMAP options when using POP.
786 2007-05-21 Murray Cumming <murrayc@murrayc.com>
788 * src/modest-tny-account.c:
789 (modest_tny_account_new_from_server_account):
790 Use NULL for the secure-auth method for POP when Password auth has been
791 specified by the user, as we already do for IMAP. "auth=Login" causes
792 an error from camel or the server.
794 2007-05-17 Murray Cumming <murrayc@murrayc.com>
796 * src/maemo/modest-account-settings-dialog.c:
797 (create_page_account_details),
798 (modest_account_settings_dialog_set_account_name):
799 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
800 for the leave-on-server checkbox, rathr than just the checkbox, when
801 the protocol is not POP.
803 2007-05-17 Murray Cumming <murrayc@murrayc.com>
805 * src/widgets/modest-account-view.c:
806 * src/widgets/modest-account-view.h:
807 Added modest_account_view_select_account() which will be useful later
808 to asynchronously re-select the edited account.
810 2007-05-17 Murray Cumming <murrayc@murrayc.com>
812 * src/maemo/modest-account-settings-dialog.c:
813 (modest_account_settings_dialog_set_account_name):
814 Automatically choose the port numbers based on the secure authentication
815 methods, if they have not been chosen before.
816 This fixes projects.maemo.org bug NB#56273 .
818 2007-05-17 Murray Cumming <murrayc@murrayc.com>
820 * src/maemo/modest-main-window-ui.h:
821 * src/modest-ui-actions.c:
822 * src/modest-ui-actions.h:
823 Connect the Tools/SMTP Servers menu item to
824 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
825 SMTP servers dialog, as in the UI specification and saves changes when it
826 is closed. This fixed projects.maemo.org bug NB#56305 .
828 2007-05-17 Murray Cumming <murrayc@murrayc.com>
830 * src/maemo/modest-connection-specific-smtp-window.c:
831 (modest_connection_specific_smtp_window_init):
832 Use gtk_window_set_default_size() to make this window big enough, so
833 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
835 2007-05-17 Murray Cumming <murrayc@murrayc.com>
837 * src/maemo/modest-connection-specific-smtp-edit-window.h:
838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
839 (modest_connection_specific_smtp_edit_window_init),
840 Do not try to connect to a combobox signal before the combobox exists.
841 This fixes the cras in projects.maemo.org bug NB#56288 .
842 (modest_connection_specific_smtp_edit_window_get_settings):
843 Remove the server_account_name parameter which was being checked for NULL
844 though it was not used.
846 * src/maemo/modest-connection-specific-smtp-window.c:
847 (modest_connection_specific_smtp_window_fill_with_connections),
848 (on_button_edit), (modest_connection_specific_smtp_window_init):
849 Correct the number of treemodel columns to prevent a warning.
850 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
851 libconic does not work.
853 2007-05-16 Murray Cumming <murrayc@murrayc.com>
855 * src/modest-tny-account.c:
856 (modest_tny_account_new_from_server_account):
857 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
858 SMTP when "None" was chosen by the user. However, with my SMTP server that
859 does not support ANONYMOUS, the emails do not leave the Outbox and I see
862 2007-05-16 Murray Cumming <murrayc@murrayc.com>
864 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
865 to explain the memory management issue with the ID in the ModestPair.
867 * src/gnome/modest-account-assistant.c: (add_receiving_page),
868 (add_sending_page), (modest_account_assistant_finalize):
869 * src/gnome/modest-gnome-global-settings-dialog.c:
870 (create_updating_page), (create_composing_page):
871 * src/gnome/modest-msg-edit-window.c: (get_transports),
872 (init_window), (modest_msg_edit_window_finalize),
873 (modest_msg_edit_window_get_msg_data):
874 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
875 * src/gnome/modest-transport-widget.c:
876 (modest_transport_widget_finalize), (smtp_configuration):
877 * src/maemo/modest-maemo-global-settings-dialog.c:
878 (create_updating_page), (create_composing_page):
879 * src/maemo/modest-msg-edit-window.c: (get_transports),
880 (init_window), (modest_msg_edit_window_finalize),
881 (modest_msg_edit_window_get_msg_data),
882 (modest_msg_edit_window_free_msg_data):
883 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
884 (modest_store_widget_finalize):
885 * src/maemo/modest-transport-widget.c:
886 (modest_transport_widget_finalize), (smtp_configuration):
887 * src/modest-main.c: (send_mail):
888 * src/widgets/modest-combo-box.h:
889 * src/widgets/modest-global-settings-dialog-priv.h:
890 * src/widgets/modest-global-settings-dialog.c:
891 (modest_global_settings_dialog_finalize):
892 * src/widgets/modest-msg-edit-window.h:
893 Whenever using modest_combo_box_new(), keep the ModestPairList alive
894 as long as the combo box, to prevent use of freed memory for the ID.
896 2007-05-15 Murray Cumming <murrayc@murrayc.com>
898 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
899 get_accounts(), to make this clearer. Do not check for the enabled gconf
900 key, because we do not use this for server accounts (at least, not yet).
901 This allows us to send email again.
903 2007-05-15 Murray Cumming <murrayc@murrayc.com>
905 * src/maemo/modest-platform.c:
906 (on_modest_conf_update_interval_changed), (modest_platform_init):
907 Only respond to this particular key change. All these strcmp()s cannot be
910 2007-05-15 Murray Cumming <murrayc@murrayc.com>
912 * src/maemo/modest-maemo-global-settings-dialog.c:
913 (current_connection): Prevent a crash in scratchbox when
914 ny_maemo_conic_device_get_current_iap_id() returns NULL.
915 * src/maemo/modest-platform.c:
916 (on_modest_conf_update_interval_changed), (modest_platform_init):
917 Get the update interval from gconf and reset it when the gconf key changes.
919 2007-05-15 Murray Cumming <murrayc@murrayc.com>
921 * src/modest-protocol-info.c:
922 * src/modest-protocol-info.h: Adde enum-specific get functions,
923 instead of using a ModestProtocolType enum parameter.
925 * src/gnome/modest-account-assistant.c:
926 * src/gnome/modest-store-widget.c:
927 * src/gnome/modest-store-widget.h:
928 * src/gnome/modest-transport-widget.c:
929 * src/gnome/modest-transport-widget.h:
930 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
931 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
932 * src/maemo/easysetup/modest-easysetup-wizard.c:
933 * src/maemo/modest-account-settings-dialog.c:
934 * src/maemo/modest-account-settings-dialog.h:
935 * src/maemo/modest-store-widget.c:
936 * src/maemo/modest-store-widget.h:
937 * src/maemo/modest-transport-widget.c:
938 * src/maemo/modest-transport-widget.h:
939 * src/modest-account-mgr-helpers.c:
940 * src/modest-account-mgr-helpers.h:
941 * src/modest-account-mgr.c:
942 * src/modest-account-mgr.h:
943 * src/modest-tny-account.c:
944 * src/modest-tny-folder.c:
945 * src/widgets/modest-account-view.c:
946 * src/widgets/modest-retrieve-combo-box.c:
947 * src/widgets/modest-retrieve-combo-box.h:
948 * src/widgets/modest-secureauth-combo-box.c:
949 * src/widgets/modest-serversecurity-combo-box.c:
950 * src/widgets/modest-serversecurity-combo-box.h:
951 * tests/check_account-mgr.c:
952 Use the specific functions, and use the re-renamed enum values for GNOME too.
954 2007-05-15 Murray Cumming <murrayc@murrayc.com>
957 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
958 so we can get the second based on the first.
960 * src/maemo/modest-account-settings-dialog.h:
961 * src/maemo/modest-account-settings-dialog.c:
962 Added get_supported_secure_authentication_methods(), though it is mostly
963 commented-out for now until the necessary API is committed to tinymail.
964 (modest_account_settings_dialog_set_account_name),
965 (save_configuration): Request the supported authentication methods from the
966 server, so we can choose a working method.
968 * src/modest-tny-account-store.h:
969 * src/modest-tny-account-store.c:
970 (modest_tny_account_store_get_session): Rename from
971 tny_account_store_get_session().
973 2007-05-14 Murray Cumming <murrayc@murrayc.com>
975 * src/modest-protocol-info.h: Split the ModestProtocol enum
976 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
977 There was no need to have these unrelated values in one enum.
979 * src/: many files: Adapted to changed enum. This makes the code a bit
980 clearer, and the compiler could catch some errors.
982 2007-05-14 Murray Cumming <murrayc@murrayc.com>
984 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
985 Show the detailed internal camel error message when an error happens
986 during the configuration, so that our testers can give us more clues.
987 For instance, in projects.maemo.org bug NB#56910 .
989 2007-05-14 Murray Cumming <murrayc@murrayc.com>
991 * src/modest-tny-account.c:
992 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
993 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
995 2007-05-14 Murray Cumming <murrayc@murrayc.com>
997 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
998 * src/maemo/modest-account-settings-dialog.c:
999 (modest_account_settings_dialog_set_account_name),
1000 (save_configuration): For the incoming secure authentication checkbox,
1001 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1002 the UI specification. PLAIN does not seem to be supported for most IMAP
1003 servers anyway, and I am not sure what it would mean.
1004 However, we probably need to discover which of the secure-authentication
1005 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1006 * src/modest-account-mgr-helpers.c:
1007 (modest_account_mgr_get_server_account_data):
1009 * src/modest-tny-account.c:
1010 (modest_tny_account_new_from_server_account):
1011 Use tny_account_set_mech() to set secure-authentication methods,
1012 with some special-casing for IMAP, based on my observations of how
1015 * src/modest-account-mgr-helpers.h:
1016 * src/modest-account-mgr.c:
1017 * src/modest-defs.h: Comment that the URI is only used for local folders.
1019 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1021 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1022 parameter const, just to be neat.
1023 * src/modest-text-utils.c: (modest_text_utils_inline):
1024 End g_strconcat() with NULL, as its documentation says. This is almost
1025 certainly the cause of my crash at startup on the device. Interestingly,
1026 valgrind doesn't tell us about these errors.
1028 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1030 * scripts/build-packages: Added more precise comments about how to use
1031 this script, though I still get this error:
1032 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1033 error building tinymail
1035 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1037 * src/maemo/modest-main-window.c: (on_account_update):
1038 Very slight cleanup, hoping to make it simpler to discover what causes
1039 a crash here sometimes.
1041 * src/modest-tny-account.c:
1042 (modest_tny_account_new_from_server_account): Set the port. Added
1043 comments about the options and a TODO comment because I need to find out
1044 how to specify the secure authentication method.
1046 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1048 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1049 changed CFlags paths form modest to libmodest
1051 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1053 * src/modest-account-mgr-helpers.c:
1054 (modest_account_mgr_get_server_account_data),
1055 (modest_account_mgr_free_server_account_data):
1056 * src/modest-account-mgr-helpers.h:
1057 * src/modest-account-mgr.c:
1058 (modest_account_mgr_add_server_account):
1059 * src/modest-defs.h:
1060 * src/modest-tny-account.c:
1061 (modest_tny_account_new_from_server_account):
1062 Determine the options for tny_camel_account_add_option() here,
1063 based on the settings, rather than storing them directly in gconf.
1065 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1067 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1068 Show a more friendly error dialog now that we expect (from the tinymail
1069 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1071 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1073 * src/maemo/modest-main-window.c: (on_account_update): Check that
1074 account_name is not NULL, to prevent a crash at startup that I am
1075 seeing on the N800. I do wonder why it is NULL.
1077 * src/maemo/easysetup/modest-easysetup-wizard.c:
1078 (create_page_user_details):
1079 * src/maemo/modest-account-settings-dialog.c:
1080 (create_page_user_details), (create_page_outgoing):
1081 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1082 (modest_connection_specific_smtp_edit_window_init):
1083 * src/modest-ui-actions.c:
1084 (modest_ui_actions_on_password_requested):
1085 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1086 might do something useful with the on-screen keyboard.
1088 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1090 * src/maemo/modest-main-window.c: (on_account_update):
1091 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1092 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1094 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1096 * src/modest-tny-account-store.c: (on_account_changed):
1097 Correct the signature of this signal handler.
1099 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1101 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1102 Show a HildonNote instead of a GtkDialog for Maemo.
1104 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1106 * src/widgets/modest-account-view.h:
1107 * src/widgets/modest-account-view.c: (on_account_changed),
1108 (on_account_removed). Added a boolean flag, set/unset by
1109 modest_account_view_block_conf_updates(),
1110 modest_account_view_unblock_conf_updates() to prevent unnecessary
1111 updates, but this is not very useful because the gconf notifications are
1112 so delays (maybe only on Maemo Bora).
1113 So auto-updating is turned off, and these functions do an explicit
1114 update when necessary.
1115 However, something else is still doing too much work when adding/removing
1116 accounts, probably in another part of the application.
1118 * src/maemo/modest-account-view-window.c:
1119 (on_delete_button_clicked), (on_edit_button_clicked),
1120 (on_new_button_clicked): Use the new functions.
1122 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1124 * src/modest-account-mgr-helpers.c:
1125 (modest_account_mgr_set_first_account_as_default):
1126 Sort the list of names alphabetically-by-title, so we choose the first one
1128 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1129 alphabetically by the title.
1131 This fixes projects.maemo.org bug NB#56418 .
1133 * src/modest-account-mgr-priv.c:
1134 (_modest_account_mgr_account_from_key):
1135 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1136 avoid a valgrind error, and possible random behaviour.
1138 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1140 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1141 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1142 tinymail documentation to say that this can be expected.
1143 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1144 pretty, and should not happen, but I would prefer to know when it does.
1146 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1148 * configure.ac: When using the older hildon version, probably on Bora,
1149 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1151 * src/widgets/modest-attachment-view.c:
1152 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1155 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1157 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1158 Implemented the prototype. Can be tested with
1159 tests/dbus_api/test_open_message:
1161 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1163 * src/modest-tny-account-store.c:
1164 (modest_tny_account_store_instance_init), (get_password):
1165 * src/modest-ui-actions.c:
1166 (modest_ui_actions_on_password_requested):
1167 Do not store the password in gconf, because this function is called
1168 for non-remembered passwords. Actually use the cached (in the hash map)
1169 password instead of releasing it.
1170 The password will now not be remembered if it is asked via the protected
1171 password dialog, as per the UI spec.
1173 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1175 * src/modest-defs.h:
1176 * src/modest-account-mgr-helpers.h:
1177 * src/modest-account-mgr-helpers.c:
1178 Added modest_server_account_get_username_has_succeeded(),
1179 modest_server_account_set_username_has_succeeded().
1180 (modest_server_account_set_username),
1181 Reset the has-succeeded flag if the username changes.
1183 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1184 * src/maemo/modest-connection-specific-smtp-window.c:
1185 (modest_connection_specific_smtp_window_save_server_accounts):
1186 Use modest_server_account_set_username() instead of using
1187 modest_conf_set_string() directly, so that the has-succeeded flag is always
1190 * src/modest-ui-actions.c:
1191 (modest_ui_actions_on_password_requested): Dim the username entry if
1192 the username has ever worked, as per the UI spec.
1194 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1196 * src/modest-tny-account-store.c: (get_password):
1197 * src/modest-ui-actions.c:
1198 (modest_ui_actions_on_password_requested):
1199 Allow the username to be changed too, though there is more work to
1200 be done on exactly how this behaves.
1202 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1204 * src/modest-account-mgr-helpers.h:
1205 * src/modest-account-mgr-helpers.c:
1206 Added modest_account_mgr_get_display_name(),
1207 modest_server_account_get_username(),
1208 modest_server_account_set_username(),
1209 modest_server_account_set_password(),
1210 modest_server_account_get_hostname() functions so we do not need to
1211 use the conf API directly.
1213 * src/maemo/modest-main-window.c: (connect_signals):
1214 Actually connect ot the ModestAccountStore::request-password signal,
1215 so that we show the dialog when the password is requested by Tinymail,
1216 for isntance if it is empty.
1218 * src/modest-marshal.list:
1219 * src/modest-tny-account-store.c:
1220 (modest_tny_account_store_class_init), (get_password),
1221 (modest_tny_account_store_alert):
1222 * src/modest-tny-account-store.h:
1223 * src/modest-ui-actions.h:
1224 * src/modest-ui-actions.c:
1225 (modest_ui_actions_on_password_requested):
1226 Change the signal parameters, so it is obvious that we are providing
1227 the non human-readable server name, and receiving both the username
1228 and password, though changing of the username is not yet implemented.
1229 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1230 for the GNOME version.
1232 This should fix the projects.maemo.org bug NB#56209, though it does not
1233 work on Bora, because the gconf_client_get() for the password fails
1234 immediately after we save it with gconf_client_set().
1236 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1239 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1240 caused an undefined symbol error:
1241 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1243 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1245 * src/modest-tny-account-store.c:
1246 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1247 using a GError instead of a string message, so we can translate it in
1250 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1252 * src/maemo/modest-address-book.c:
1253 (modest_address_book_check_names):
1254 * src/maemo/modest-msg-view-window.c:
1255 (modest_msg_view_window_clipboard_owner_change):
1256 * src/modest-init.c: (modest_init_init_ui):
1257 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1258 (update_folders_cb), (modest_mail_operation_update_account):
1259 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1260 (modest_ui_actions_on_msg_attachment_clicked),
1261 (modest_ui_actions_on_msg_recpt_activated):
1262 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1263 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1264 (modest_msg_view_search_next):
1265 * src/widgets/modest-recpt-editor.c:
1266 (modest_recpt_editor_on_button_release_event),
1267 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1268 g_message(). At this point we should only be seeing interesting errors on
1269 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1271 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1273 (modest_wizard_dialog_force_title_update):
1274 * src/maemo/easysetup/modest-wizard-dialog.h:
1275 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1276 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1277 can update the title when appropriate. Otherwise the title is wrong if the
1278 pages are added after adding the notebook to the dialog.
1279 This must be a problem in HildonWizardDialog too.
1280 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1282 * src/maemo/easysetup/modest-easysetup-wizard.c:
1283 (create_subsequent_customsetup_pages),
1284 (create_subsequent_easysetup_pages):
1285 Call modest_wizard_dialog_force_title_update() so that the title is
1286 correct even with GTK+ < 2.10.
1287 This fixes projects.maemo.org bug NB#56145 .
1289 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1291 * src/maemo/modest-platform.c:
1292 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1293 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1296 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1298 * src/widgets/modest-window.h:
1299 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1300 and modest_window_save_state(), which invokes it.
1302 * src/widgets/modest-window-mgr.h:
1303 * src/widgets/modest-window-mgr.c:
1304 Added modest_window_mgr_save_state_for_all_windows(), which calls
1305 the save_state vfunc on all registered windows, if implemented.
1307 * src/gnome/modest-msg-edit-window.c:
1308 * src/gnome/modest-msg-view-window.c:
1309 * src/maemo/modest-msg-edit-window.c:
1310 * src/maemo/modest-msg-view-window.c:
1311 * src/maemo/modest-main-window.c:
1312 Specify the existing save_settings functions as implementations of
1313 ModestWindow::save_state_func().
1315 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1316 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1317 enabling hibernation, for instance.
1319 We may need to do the same thing for restoring settings.
1322 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1324 * src/widgets/modest-window-mgr.c:
1325 * src/widgets/modest-window-mgr.h:
1326 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1327 modest_window_mgr_get_hibernation_is_prevented().
1329 * src/maemo/modest-main-window.c:
1330 (on_hildon_program_is_topmost_notify): Prevent hibernation
1331 (possible when the application goes to the background in the WM),
1332 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1334 * src/maemo/easysetup/modest-easysetup-wizard.c:
1335 (modest_easysetup_wizard_dialog_init):
1336 * src/maemo/modest-account-settings-dialog.c:
1337 (modest_account_settings_dialog_init):
1338 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1339 (modest_connection_specific_smtp_edit_window_init):
1340 * src/maemo/modest-connection-specific-smtp-window.c:
1341 (modest_connection_specific_smtp_window_init):
1342 * src/maemo/modest-signature-editor-dialog.c:
1343 (modest_signature_editor_dialog_init):
1344 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1345 prevent hibernation while any of these account settings dialogs are open.
1347 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1349 * src/maemo/Makefile.am:
1350 * src/maemo/modest-osso-state-saving.c:
1351 * src/maemo/modest-osso-state-saving.h: Added
1352 modest_osso_load_state() and modest_osso_save_state() though they do
1353 nothing now. They should iterate through all the open windows and load/save
1355 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1356 save state when closing.
1358 * src/maemo/modest-main-window.c:
1359 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1360 Add a notification handler for the HildonProgram::is-topmost property,
1361 so we can allow hibernation when the application goes into the background.
1362 But we still need to detect when the accounts setup windows are open so
1363 we can stop hibernation when they are open.
1364 To do this, I also added the main window the HildonProgram. This might have
1365 other side-effects/benefits, and should maybe be done for other windows.
1367 * src/maemo/modest-osso-autosave-callbacks.h:
1368 * src/maemo/modest-osso-autosave-callbacks.c:
1369 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1370 though it does not do anything yet, and we might never need this to do
1371 anything. For instance, we already save drafts.
1373 * src/maemo/modest-platform.c: (modest_platform_init):
1374 Specify the libosso auto-save callback.
1376 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1378 * src/maemo/modest-platform.c:
1379 (modest_platform_set_update_interval):
1380 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1381 aparently stays valid between application instances, so we can use this
1382 to remove and reset it later. According to a maemo-developers email from
1385 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1387 * configure.ac: Depend on libalarm for Maemo.
1389 * src/dbus_api/modest-dbus-api.h:
1390 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1391 (on_send_receive), (modest_dbus_req_handler):
1392 Handle a SEND_RECEIVE D-Bus method.
1394 * libmodest-dbus-client/libmodest-dbus-client.c:
1395 (libmodest_dbus_client_send_and_receive):
1396 * libmodest-dbus-client/libmodest-dbus-client.h:
1397 Add C convenience functions for calling the new D-Bus method.
1399 * src/modest-platform.h:
1400 * src/gnome/modest-platform.c:
1401 * src/maemo/modest-platform.c:
1402 Added modest_platform_set_update_interval(), which uses the
1403 alarmd API on Maemo.
1404 (modest_platform_init),
1405 Call modest_platform_set_update_interval(), using a hard-coded
1406 interval for now (until the global settings dialog is implemented),
1407 though I am not sure that this makes sense yet.
1409 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1411 * src/dbus_api/modest-dbus-callbacks.c:
1412 (modest_osso_cb_hw_state_handler):
1413 * src/dbus_api/modest-dbus-callbacks.h:
1414 * src/maemo/modest-platform.c: (modest_platform_init):
1415 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1416 in case this has some effect on the ability for Maemo to ping the
1419 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1421 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1422 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1423 warning. It is probably a logic error, but I need to fix the build.
1425 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1427 * src/modest-account-mgr.h:
1428 * src/modest-account-mgr.c:
1429 (modest_account_mgr_account_names): Add a gboolean enabled_only
1430 parameter, so we can get lists of onlt the enabled accounts.
1432 (modest_account_mgr_add_account),,
1433 (modest_account_mgr_account_with_display_name_exists):
1434 * src/maemo/modest-msg-edit-window.c: (get_transports):
1435 * src/modest-account-mgr-helpers.c:
1436 (modest_account_mgr_set_first_account_as_default):
1437 * src/modest-init.c: (init_default_account_maybe):
1438 * src/modest-tny-account-store.c: (get_accounts):
1439 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1440 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1441 * tests/check_account-mgr.c: (START_TEST):
1442 Provide the extra parameter, as appropriate.
1444 * src/widgets/modest-account-view.c: (update_account_view):
1445 Do not show disabled accounts (meaning that there is no way to
1446 enable/disable accounts in the UI (the feature is not in our UI
1447 specification), so we can use this internally only to mark unfinished
1448 or temporary account data.
1450 * src/maemo/easysetup/modest-easysetup-wizard.c:
1451 (create_account): Add boolean enable parameter, so we can specify FALSE
1452 to create the temporary account.
1453 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1454 (on_before_next): When finishing, when there is a temporary account, just
1456 Also, use a timeout to delay the showing of the dialog until gconf is likely
1457 to return correct information, due to a maemo gconf bug that is fixed in
1458 osso 1.1, but not yet in Bora.
1459 However, the dialog stays on screen after it is destroyed.
1461 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1462 for invalid data when cancelling. Use a hildon note instead of a dialog
1463 to complain about invalid data. Do not show the account-saved note if the
1464 account is disabled (a temporary account that will not really be saved for use
1467 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1469 * src/modest-account-mgr-helpers.h:
1470 * src/modest-account-mgr-helpers.c:
1471 Added modest_account_mgr_unset_default_account(),
1472 Added modest_account_mgr_set_first_account_as_default().
1474 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1475 If it was the default account, unset the default account name.
1477 * src/maemo/modest-account-view-window.c:
1478 (on_delete_button_clicked): If it was the default account,
1479 set the first remaining account as the default instead.
1481 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1482 a NULL account or a NULL default account, to prevent a crash. This should
1483 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1486 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1488 * src/widgets/modest-recpt-editor.c:
1489 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1490 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1491 TODO comment for this. This fixes the build.
1493 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1494 be the best place for it. This will in future update all auto-update accounts,
1495 rather than just the current/default account, when that gconf key exists.
1496 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1497 if there are no accounts, before calling do_send_receive().
1498 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1500 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1501 * src/maemo/modest-main-window-ui.h:
1502 * src/maemo/modest-main-window.c: (on_connection_changed),
1503 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1504 directly, becaue the signal handler does more.
1506 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1508 * src/modest-account-mgr-helpers.c:
1509 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1510 for the case that the account does not exist.
1512 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1513 (equivalent to the modest account name) rather than the tinymail account name
1514 (equivalent to the modest account title - human readable) to get the account data.
1515 Check for null account data to prevent the crash, and add a TODO comment saying that
1516 this needs fixing because it is using the server account name instead of the account name.
1518 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1520 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1521 * src/maemo/modest-account-settings-dialog.c: (show_error),
1523 Use hildon_note_new_information() for informative and error messages,
1524 which seems to be expected for Maemo applications (no documentation that I know of
1525 says this). I am surprised that there is no distinction between info and error
1528 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1530 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1531 it is easy to find where this is used.
1533 * src/maemo/easysetup/modest-easysetup-wizard.c:
1534 (create_page_welcome), (create_page_account_details),
1535 (create_page_user_details), (create_page_complete_easysetup),
1536 (create_page_custom_incoming), (create_page_custom_outgoing),
1537 (create_page_complete_custom):
1538 * src/maemo/modest-account-settings-dialog.c:
1539 (create_page_account_details), (create_page_user_details),
1540 (create_page_incoming), (create_page_outgoing):
1541 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1542 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1543 (modest_connection_specific_smtp_edit_window_init):
1544 * src/maemo/modest-connection-specific-smtp-window.c:
1545 (modest_connection_specific_smtp_window_init):
1546 * src/maemo/modest-signature-editor-dialog.c:
1547 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1548 and scrolling policy as per the Email Application Layout Guide, if I have
1551 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1553 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1554 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1555 which were empty, because these vfuncs have been removed from TnyAccountStore.
1556 This fixes the build.
1558 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1560 * src/maemo/modest-main-window.c:
1561 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1562 showing/hiding it. Added TODO because it probably should not be NULL.
1563 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1564 because unnecessary g_warnings() make degugging difficult.
1566 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1568 * src/maemo/modest-msg-edit-window.c:
1569 (modest_msg_edit_window_select_color),
1570 (modest_msg_edit_window_select_background_color): 2 const corrections and
1571 moving 2 #endifs before closing brackets, to fix the build.
1573 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1575 * src/maemo/easysetup/modest-easysetup-wizard.h:
1576 * src/maemo/easysetup/modest-easysetup-wizard.c:
1577 (modest_easysetup_wizard_dialog_finalize),
1578 (on_button_edit_advanced_settings), (create_page_complete_custom),
1579 (on_response), (create_account):
1580 Implement the Advanced Settings edit button, by saving the account information,
1581 for the Advanded Settings dialog to use directly from gconf, and removing it
1582 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1583 Bug #5533 in the projects.maemo.org bugzilla.
1585 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1587 * src/maemo/modest-msg-view-window.c:
1588 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1589 when opening a message window.
1591 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/easysetup/modest-easysetup-wizard.c:
1594 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1597 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1598 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1599 gconf settings. I probably added more checks than necessary, but that is safer.
1601 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1602 variable to fix the build, but this seems to be used when it is still NULL.
1604 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1606 * src/modest-platform.h:
1607 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1608 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1609 * src/modest-main.c: Implement this function so we can avoid using
1610 maemo-specific API from cross-platform code.
1612 * src/modest-tny-account-store.c:
1613 (get_smtp_specific_transport_account_for_open_connection):
1614 * src/modest-ui-actions.c: (check_for_connection),
1615 (modest_ui_actions_on_item_not_found):
1616 Use modest_platform_connect_and_wait() and put #idefs around other
1617 maemo-specific code, because only maemo currently has a way to
1618 identify connection names.
1620 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1622 * src/modest-tny-account-store.h:
1623 * src/modest-tny-account-store.c:
1624 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1625 the connection-specific SMTP server settings in the configuration.
1627 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1629 * src/maemo/modest-main-window.c: (on_connection_changed),
1631 * src/modest-main.c: (main), (start_ui), (send_mail):
1632 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1633 that is what is intended.
1635 * src/modest-ui-actions.c: (action_send), (action_receive),
1636 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1637 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1638 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1639 SMTP server is used when it is specified.
1641 (modest_ui_actions_on_send_receive):
1642 Check that a connection is open before proceeding.
1643 Receive and then send, instead of vice-versa, as per the specification.
1645 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1647 * src/modest-mail-operation.c:
1648 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1649 though I guess it should be something other than NULL.
1651 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1653 * src/maemo/easysetup/modest-easysetup-wizard.c:
1654 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1655 combo twice, to avoid an g_warning and to make it visible again.
1656 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1657 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1658 (already intended) dereference when detaching, because we then recreate the menu.
1659 But I am not sure why the warning was happening, and it is possible that this is a memory
1662 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1664 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1665 and uri_parse_mailto() utility functions.
1666 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1668 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1670 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1672 * src/dbus_api/modest-dbus-api.h:
1673 * src/dbus_api/modest-dbus-callbacks.c:
1674 Use an idle callback to execute the modest code in the application's own thread.
1675 Remove the helloworld example method.
1676 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1677 parsed, and the open-message method is not implemented because this is not yet implemented in
1679 * libmodest-dbus-client/libmodest-dbus-client.c:
1680 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1681 (libmodest_dbus_client_open_message):
1682 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1684 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1685 body without crashing.
1687 * tests/dbus_api/Makefile.am:
1688 * tests/dbus_api/test_mail_to.c:
1689 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1691 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1693 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1694 Added file to fix the build. Sorry.
1696 * src/dbus_api/Makefile.am:
1697 * src/dbus_api/modest-dbus-api.h:
1698 * src/dbus_api/modest-dbus-callbacks.h:
1699 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1700 (modest_dbus_req_handler):
1701 Put constants in a separate header so it can be reused by the
1702 client library, without duplication
1704 * libmodest-dbus-client/Makefile.am:
1705 * libmodest-dbus-client/libmodest-dbus-client.c:
1706 (libmodest_dbus_client_call_helloworld),
1707 (libmodfest_dbus_client_send_mail),
1708 (libmodfest_dbus_client_mailto),
1709 (libmodfest_dbus_client_open_message):
1710 * libmodest-dbus-client/libmodest-dbus-client.h:
1711 (Partly) Implement a send_mail D-Bus method.
1713 * tests/dbus_api/Makefile.am:
1714 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1715 the send_email D-Bus method.
1717 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1721 * libmodest-dbus-client/Makefile.am:
1722 * libmodest-dbus-client/libmodest-dbus-client.c:
1723 * libmodest-dbus-client/libmodest-dbus-client.h:
1724 * tests/dbus_api/Makefile.am:
1725 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1726 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1728 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1730 * src/maemo/easysetup/modest-easysetup-wizard.c:
1731 (create_page_account_details):
1732 * src/maemo/modest-account-settings-dialog.c:
1733 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1734 widgets, because this might not be the default in future versions of the Maemo GTK+.
1735 However, I can not not get capitalization to work even in a simple test case.
1737 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1739 * src/maemo/easysetup/modest-easysetup-wizard.c:
1740 (create_page_custom_incoming), (create_page_custom_outgoing):
1741 * src/maemo/modest-account-settings-dialog.c:
1742 (create_page_account_details), (create_page_incoming),
1743 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1744 instead of using gtk_check_button_with_label(), so they are aligned like the other
1745 widgets, as per the UI spec.
1747 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1749 * src/maemo/easysetup/modest-easysetup-wizard.c:
1750 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1751 * src/widgets/modest-validating-entry.c:
1752 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1753 Modest prefix instead of an EasySetup prefix.
1755 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1757 * src/widgets/modest-validating-entry.h:
1758 * src/widgets/modest-validating-entry.c: (on_insert_text),
1759 Added easysetup_validating_entry_set_max_func(), used to set a callback
1760 to call when the max number of characters is reached. GtkEntry has a max-length
1761 already but is silent about it.
1763 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1764 (create_page_account_details), (create_page_user_details),
1766 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1767 (create_page_account_details), (create_page_user_details),
1768 (create_page_outgoing):
1769 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1770 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1771 the UI spec, when the user tries to enter more than the max number of characters.
1773 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1775 * src/maemo/easysetup/modest-easysetup-wizard.c:
1776 (create_page_user_details), (create_page_custom_incoming),
1777 (create_page_custom_outgoing):
1778 * src/maemo/modest-account-settings-dialog.c:
1779 (create_page_user_details), (create_page_incoming),
1780 (create_page_outgoing):
1781 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1782 (modest_connection_specific_smtp_edit_window_init):
1783 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1784 not appropriate. Bad Maemo-specific defaults!.
1786 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1788 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1789 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1790 (modest_signature_editor_dialog_set_settings):
1791 Disable the label and textview when the checkbox is disabled, and use the
1792 specified (UI spec) default signature text.
1794 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1796 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1797 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1799 * src/modest-defs.h:
1800 * src/modest-account-mgr-helpers.h:
1801 * src/modest-account-mgr-helpers.c:
1802 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1804 * src/maemo/Makefile.am:
1805 * src/maemo/modest-signature-editor-dialog.c:
1806 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1809 * src/maemo/modest-account-settings-dialog.h:
1810 * src/maemo/modest-account-settings-dialog.c:
1811 (modest_account_settings_dialog_finalize), (on_button_signature),
1812 (save_configuration): Use the new dialog when the Edit button is pressed, and
1813 save the changes if necessary, as per the UI spec.
1815 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1817 * src/maemo/Makefile.am:
1818 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1819 based on maemo-develoers email from Dirk.
1821 * src/maemo/easysetup/modest-easysetup-wizard.c:
1822 (create_page_welcome), (create_page_account_details),
1823 (create_page_user_details), (create_page_complete_easysetup),
1824 (create_page_custom_incoming), (create_page_custom_outgoing),
1825 (create_page_complete_custom),
1826 (modest_easysetup_wizard_dialog_init):
1827 * src/maemo/modest-account-settings-dialog.c:
1828 (create_page_account_details), (create_page_user_details),
1829 (create_page_incoming), (create_page_outgoing),
1830 (modest_account_settings_dialog_init):
1831 * src/maemo/modest-connection-specific-smtp-window.c:
1832 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1834 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1836 * src/maemo/easysetup/modest-easysetup-wizard.c:
1837 (create_page_account_details), (create_page_custom_outgoing),
1838 (create_page_complete_custom):
1839 * src/maemo/modest-account-settings-dialog.c:
1840 (create_page_user_details), (create_page_incoming),
1841 (create_page_outgoing):
1842 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1843 (modest_connection_specific_smtp_edit_window_init):
1844 Use the correct (UI spec) port min/max, and use horizontal separators,
1847 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1849 * src/maemo/easysetup/modest-easysetup-wizard.c:
1850 (set_default_custom_servernames):
1851 * src/maemo/modest-account-settings-dialog.c:
1852 (create_page_incoming), (on_combo_outgoing_security_changed),
1853 (on_combo_incoming_security_changed), (create_page_outgoing),
1854 (modest_account_settings_dialog_set_account_name),
1855 (save_configuration):
1856 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1857 (on_combo_security_changed),
1858 (modest_connection_specific_smtp_edit_window_init),
1859 (modest_connection_specific_smtp_edit_window_set_connection),
1860 (modest_connection_specific_smtp_edit_window_get_settings):
1861 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1864 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1867 * src/maemo/easysetup/modest-easysetup-wizard.c:
1868 (create_page_custom_outgoing), (create_page_complete_custom):
1869 * src/maemo/modest-account-settings-dialog.c:
1870 (create_page_user_details), (create_page_outgoing):
1871 * src/maemo/modest-account-view-window.c: (button_box_new):
1872 Use changed logical IDs as per the most recent UI spec:
1873 mcen_bd_emailsetup_edit -> mcen_bd_edit
1874 mcen_bd_emailsetup_delete -> mcen_bd_delete
1875 mcen_bd_emailsetup_close -> mcen_bd_close
1877 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1881 * src/dbus_api/Makefile.am:
1882 * src/dbus_api/modest-dbus-callbacks.c:
1883 * src/dbus_api/modest-dbus-callbacks.h:
1884 * src/maemo/modest-platform.c: (modest_platform_init):
1885 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1887 * tests/Makefile.am:
1888 * tests/dbus_api/Makefile.am:
1889 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1891 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1893 * src/maemo/modest-account-settings-dialog.c:
1894 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1895 Removed unnecessary includes.
1897 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1899 * src/maemo/easysetup/modest-easysetup-wizard.c:
1900 * src/maemo/modest-account-settings-dialog.c:
1901 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1902 * src/widgets/Makefile.am:
1903 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1904 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1905 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1906 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1907 * src/widgets/modest-secureauth-combo-box.c:
1908 * src/widgets/modest-secureauth-combo-box.h:
1909 * src/widgets/modest-serversecurity-combo-box.c:
1910 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1911 made the GObject names more consistent with the rest of the Modest code.
1913 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1915 * src/maemo/easysetup/Makefile.am:
1916 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1917 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1918 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1919 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1920 * src/maemo/easysetup/modest-easysetup-wizard.c:
1921 * src/maemo/easysetup/modest-validating-entry.c:
1922 * src/maemo/easysetup/modest-validating-entry.h:
1923 * src/maemo/modest-account-settings-dialog.c:
1924 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1925 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1926 widgets/ because they are used outside of easysetup too. After checking in,
1927 svn will allow me to rename them too.
1929 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1931 * src/gnome/modest-msg-edit-window.c:
1932 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1933 linker error, to fix the build on the GNOME platform.
1934 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1935 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1936 ifdefed out to avoid a warning.
1938 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1940 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1941 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1942 some alternative for GTK+ 2.6.
1944 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1946 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1948 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1949 specified for EmailAccountsDialog in UI spec.
1951 * src/maemo/easysetup/modest-easysetup-wizard.c:
1952 * src/maemo/easysetup/modest-easysetup-wizard.h:
1953 * src/maemo/modest-account-settings-dialog.c:
1954 * src/maemo/modest-account-settings-dialog.h:
1955 Reuse a member window widget for the connection-specific SMTP server accounts,
1956 so we can tell it to create/save the accounts only if we actually save changes.
1958 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1959 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1960 (modest_connection_specific_smtp_edit_window_get_settings):
1961 Return a struct instance for temporarily remembering the entered data.
1963 * src/maemo/modest-connection-specific-smtp-window.h:
1964 * src/maemo/modest-connection-specific-smtp-window.c:
1965 (modest_connection_specific_smtp_window_finalize),
1966 (modest_connection_specific_smtp_window_fill_with_connections),
1968 (modest_connection_specific_smtp_window_save_server_accounts),
1969 (update_model_server_names): Do not actually save data until asked,
1970 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1972 (on_selection_changed),
1973 (modest_connection_specific_smtp_window_init): Disable the edit
1974 button when nothing is selected.
1976 * src/modest-account-mgr-helpers.c:
1977 * src/modest-account-mgr-helpers.h:
1978 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1981 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1983 * src/modest-account-mgr-helpers.h:
1984 * src/modest-account-mgr-helpers.c:
1985 (modest_account_mgr_get_unused_account_name),
1986 (modest_account_mgr_get_unused_account_display_name): Added these
1987 utility functions, to avoid code duplication.
1989 * src/maemo/easysetup/modest-easysetup-wizard.c:
1990 (create_page_account_details), (create_account):
1991 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1992 (on_combo_security_changed),
1993 (modest_connection_specific_smtp_edit_window_init),
1994 (modest_connection_specific_smtp_edit_window_save_settings):
1995 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1996 * src/maemo/modest-connection-specific-smtp-window.c:
1997 (modest_connection_specific_smtp_window_finalize),
1998 (modest_connection_specific_smtp_window_fill_with_connections),
1999 (on_button_edit), (modest_connection_specific_smtp_window_init):
2000 * src/maemo/modest-connection-specific-smtp-window.h:
2001 Implementing saving of connection-specific server accounts.
2003 But I need to refactor this so we can save the data for each
2004 possible connection-specific account and only actually create the server accounts
2005 when the easysetup finished, or the OK button is pressed on the account settings
2008 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2010 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2011 (on_combo_security_changed):
2012 (modest_connection_specific_smtp_edit_window_init):
2013 Auto-fill the port number as in the account settings.
2015 (modest_connection_specific_smtp_edit_window_set_connection):
2016 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2017 * src/maemo/modest-connection-specific-smtp-window.c:
2018 (fill_with_connections), (on_button_edit),
2019 (modest_connection_specific_smtp_window_init):
2020 Turn the edit window into a dialog to simplify the code, and
2021 set a WM hint as in a GtkDialog, because only a popup can be on top of
2022 another window in Maemo, and popups usually have no WM decoration.
2024 * src/modest-defs.h:
2025 * src/modest-account-mgr-helpers.c:
2026 (modest_account_mgr_set_connection_specific_smtp),
2027 (modest_account_mgr_remove_connection_specific_smtp),
2028 (modest_account_mgr_get_connection_specific_smtp):
2029 * src/modest-account-mgr-helpers.h: Some functions to write the
2030 connection-specific SMTP server information. Not yet used.
2033 * src/widgets/modest-folder-view.c: (text_cell_data):
2034 Fix a warning about an uninitialized variable.
2035 (on_configuration_key_changed): Put an #ifdef around the use
2036 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2038 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2040 * src/maemo/modest-account-settings-dialog.h:
2041 * src/maemo/modest-account-settings-dialog.c:
2042 Added connect_for_modified() utility function to mark the new modified boolean.
2044 (create_page_account_details), (create_page_user_details),
2045 (create_page_incoming), (create_page_outgoing), (on_response),
2046 (modest_account_settings_dialog_init),
2047 (modest_account_settings_dialog_set_account_name):
2048 Only warn about unsaved changes when there are actually unsaved changes.
2050 * src/modest-account-mgr-helpers.c:
2051 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2052 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2053 to get the data from there in future.
2055 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2057 * src/modest-defs.h:
2059 * src/modest-account-mgr-helpers.h:
2060 * src/modest-account-mgr-helpers.c:
2061 Store the security account setting in a single conf key instead of using
2062 the options list, so that the list is left for just the to-be-removed camel hack,
2063 and because gconf_client_set_list() is failing for some reason.
2065 * src/modest-account-mgr.c:
2066 (modest_account_mgr_add_server_account):
2067 * src/maemo/modest-account-settings-dialog.c:
2068 (modest_account_settings_dialog_set_account_name),
2069 (save_configuration): Use the renamed functions.
2072 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2074 * src/widgets/Makefile.am:
2075 * src/widgets/modest-limit-retrieve-combo-box.c:
2076 * src/widgets/modest-limit-retrieve-combo-box.h:
2077 * src/widgets/modest-retrieve-combo-box.c:
2078 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2079 the account settings dialog.
2081 * src/modest-defs.h:
2082 * src/modest-account-mgr-helpers.h:
2083 * src/modest-account-mgr-helpers.c:
2084 (modest_server_account_get_option_secure_auth),
2085 (modest_server_account_set_option_secure_auth):
2086 * src/modest-account-mgr.c:
2087 (modest_account_mgr_add_server_account):
2088 Use the existing AUTH_MECH conf key for the secure-auth setting,
2089 instead of putting it in the list options, because this was actually used already.
2091 * src/maemo/modest-account-settings-dialog.c:
2092 (create_page_account_details),
2093 (modest_account_settings_dialog_set_account_name),
2094 (save_configuration):
2095 * src/maemo/modest-account-settings-dialog.h:
2096 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2097 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2099 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2101 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2102 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2103 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2105 * src/modest-defs.h:
2106 * src/maemo/modest-account-settings-dialog.c:
2107 (create_page_incoming), (on_combo_outgoing_security_changed),
2108 (on_combo_incoming_security_changed), (create_page_outgoing),
2109 (modest_account_settings_dialog_set_account_name),
2110 (save_configuration): Load/Save the port number, and change it when the
2111 security combo changes, to suitable defaults.
2113 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2115 * src/modest-account-mgr.c:
2116 (modest_account_mgr_add_server_account): Set the security and secure-auth
2117 options, and add a comment saying that the other camel-specific options should be
2120 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2122 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2124 * src/modest-tny-account-store.c: (account_list_free),
2125 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2126 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2129 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2131 * src/modest-protocol-info.c:
2132 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2133 is required by our UI spec. Maybe something in our implementation will use this eventually.
2134 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2135 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2136 instead of the previous 0 placeholder.
2138 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2139 secure-auth settings.
2140 * src/modest-account-mgr-helpers.h:
2141 * src/modest-account-mgr-helpers.c:
2142 (modest_server_account_data_get_option_secure_auth),
2143 (modest_server_account_set_option_secure_auth),
2144 (modest_server_account_data_get_option_security),
2145 (modest_server_account_set_option_security): Added this API for getting and setting the security
2146 and secure-auth settings.
2148 * src/maemo/modest-account-settings-dialog.h:
2149 * src/maemo/modest-account-settings-dialog.c:
2150 (modest_account_settings_dialog_finalize), (check_data),
2151 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2152 about changing titles.
2153 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2154 (save_configuration): Save the security and secure-auth settings.
2156 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2157 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2159 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2161 * src/modest-defs.h:
2162 * src/modest-account-mgr.c:
2163 (modest_account_mgr_add_server_account):
2164 Added and used defines for the options key and value pair strings,
2165 that are used so far, though they do not seem to correspond to anything in our
2166 UI specs or ModestProtocol enum.
2168 * src/modest-account-mgr-helpers.h:
2169 * src/modest-account-mgr-helpers.c:
2170 (compare_option_strings_for_name),
2171 (modest_server_account_data_get_option_value),
2172 (modest_server_account_data_get_option_bool),
2173 (modest_account_mgr_get_server_account_option):
2174 Added helper functions for parsing the options GSList.
2176 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2178 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2179 display name is based on the supplied account name.
2180 * src/modest-account-mgr.c:
2181 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2182 with an inefficient, but good-enough, implementation.
2184 * src/maemo/easysetup/modest-easysetup-wizard.c:
2185 (create_page_account_details), (on_before_next), (create_account):
2186 Check for existing display names rather than (non-user-visible) account names, and just
2187 create and set a unique account name at the end.
2189 * src/maemo/modest-account-settings-dialog.c:
2190 (modest_account_settings_dialog_init),
2191 (modest_account_settings_dialog_set_account_name),
2192 (create_page_incoming): Show the display name, instead of the account name.
2193 (on_response): Do some (not all) extra checks, as in the UI spec.
2194 (save_configuration): Save the display name if it was changed.
2196 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2198 * po/en_GB.po: Added needed logical ID and translation.
2199 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2200 (init_view): Made the is-default column clicking work.
2202 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2205 * src/maemo/easysetup/Makefile.am:
2206 * src/maemo/easysetup/modest-easysetup-wizard.c:
2207 (modest_easysetup_wizard_dialog_init):
2208 * src/maemo/easysetup/provider-data-test.keyfile:
2209 * src/maemo/easysetup/provider-data.keyfile:
2210 Moved the provider data file to the new modest-providers-data package and used it from there.
2212 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2214 * src/modest-local-folder-info.c:
2215 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2216 N_() was already used on the static strings, but this just marks it for translation without
2217 using the translation.
2219 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2221 * src/maemo/modest-account-settings-dialog.c:
2222 (create_page_incoming),
2223 (modest_account_settings_dialog_set_account_name):
2224 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2225 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2226 I will do this if nobody else gets there first.
2228 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2230 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2231 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2232 save the security stuff.
2234 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2236 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2237 Set the email address and user fullname, which I now see must be
2240 * src/maemo/modest-account-settings-dialog.h:
2241 * src/maemo/modest-account-settings-dialog.c:
2243 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2244 leave-on-server and authentication.
2245 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2248 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2251 * src/maemo/modest-account-settings-dialog.c:
2252 * src/maemo/modest-account-settings-dialog.h:
2253 Most (but not all) of the widgets are now present as specified by the UI spec.
2254 No changes are yet saved, and some details are not properly shown yet.
2256 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2258 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2260 * src/maemo/Makefile.am:
2261 * src/maemo/modest-account-settings-dialog.c:
2262 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2263 an existing account. Doesn't do much yet.
2265 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2266 Open the accounts settings dialog when Edit is clicked.
2268 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2270 * src/maemo/easysetup/Makefile.am:
2271 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2273 * src/maemo/easysetup/modest-easysetup-wizard.c:
2274 (modest_easysetup_wizard_dialog_init):
2275 Try to get the source directory from the build system,
2276 instead of hard-coding "./" into the source code, when opening our local
2277 copies of the configuration files.
2278 But this still fails when opening the wizard from the Accounts window,
2279 maybe because the working directory seems to change at runtime.
2280 So the wizard will fail the second time unless you copy the files into their
2281 proper locations - see the stdout warnings for the paths.
2283 (create_page_account_details),(on_before_next):
2284 Check for existing non-server accounts instead of server accounts,
2285 so the default account name is useful again, and to prevent trying to
2288 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2289 Show the wizard when New is clicked.
2291 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2292 (init_view): Show the column headers, and show the columns that are
2293 specified in the UI specs. However, something in Maemo's GTK+ prevents
2294 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2295 change the default account. This is despite unsetting the special properties.
2297 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2299 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2300 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2301 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2302 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2303 to make that clearer.
2304 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2306 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2308 * src/maemo/modest-account-view-window.c:
2309 (modest_account_view_window_init),
2310 (modest_account_view_window_new):
2311 Use the same buttons as specified in the
2312 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2313 the existing widgets, which never had a chance of working.
2314 Put the ModestAccountView treeview in a scrolled window.
2315 Do not repeat the initialization in both _init() and _new().
2317 * src/widgets/modest-account-view.c: (update_account_view):
2318 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2319 this widget and window shows no accounts.
2321 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2323 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2325 * src/maemo/easysetup/modest-easysetup-wizard.c:
2326 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2327 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2328 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2331 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2332 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2333 accounts exist yet, as in the UI spec.
2335 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2337 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2339 * src/maemo/Makefile.am:
2340 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2341 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2342 New window for editing connection-specific smtp details.
2343 Not fully implemented.
2345 * src/maemo/modest-connection-specific-smtp-window.c:
2346 (modest_connection_specific_smtp_window_finalize) :
2347 unref the tree model.
2348 (on_button_edit): Show the edit window.
2350 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2352 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2355 * src/maemo/Makefile.am:
2356 * src/maemo/modest-connection-specific-smtp-window.c:
2357 * src/maemo/modest-connection-specific-smtp-window.h:
2358 New window for showing the list of connections, for connection-specific
2359 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2360 * src/maemo/easysetup/modest-easysetup-wizard.c:
2361 (create_page_custom_outgoing): Show the new window when the button is clicked.
2363 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2365 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2366 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2367 * src/maemo/modest-msg-edit-window.c:
2368 (modest_msg_edit_window_insert_image):
2369 * src/modest-conf.c: (modest_conf_key_escape):
2370 * src/modest-mail-operation.c:
2371 (modest_mail_operation_send_new_mail):
2372 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2373 (modest_ui_actions_on_new_account):
2374 * src/widgets/modest-attachment-view.c: (update_filename_request):
2375 * src/widgets/modest-mail-header-view.c:
2376 Corrected warnings that were breaking the build, by commenting out unused variables,
2377 and a function, and by including a header.
2379 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2381 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2382 so we can #ifdef around platform-specific code when necessary.
2383 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2384 to allow this to build for the GNOME platform too.
2386 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2388 * src/maemo/easysetup/modest-easysetup-wizard.c:
2389 Added util_increment_name() and used it in create_page_account_details()
2390 to make sure that the default account name is always a new name.
2392 (modest_easysetup_wizard_dialog_init),
2393 (set_default_custom_servernames): Some minor memory management fixes.
2395 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2399 * src/modest-runtime.c: (init_i18n): Restored the translation
2400 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2401 are defined in config.h, and the translations are installed.
2403 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2404 is defined for translation.
2406 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2408 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2410 * src/maemo/easysetup/modest-easysetup-wizard.c:
2411 (modest_easysetup_wizard_dialog_init):
2412 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2413 Use realistic paths (though they should use $prefix generically) to the
2414 mcc_mapping and provider-data.keyfile files which might work when they
2415 are installed by the future version of the operator-wizard package,
2416 and then fallback to paths in our source code, with an explanatory
2419 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2423 * src/maemo/Makefile.am:
2424 * src/maemo/easysetup/: Added files from the previously-exernal
2425 osso-modest-easysetup.
2426 * src/maemo/modest-main-window-ui.h:
2427 * src/modest-ui-actions.c:
2428 * src/modest-ui-actions.h:
2429 Added modest_ui_actions_on_new_account() as a signal handler for the
2430 New Account menu item. It shows the easysetup wizard.
2431 * po/en_GB.po: Added additional needed logical IDs and translations.
2433 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2434 Apparently ChangeLog is not used for some vague Nokia legal reasons.