1 2007-08-24 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-platform.c:
4 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
5 english text for strings in the rename folder dialog, fixing
6 projects.maemo.org bug NB#66338.
8 2007-08-22 Armin Burgmeier <armin@openismus.com>
10 * src/widgets/modest-account-view.c: Fix for bora by using
11 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
12 latter seems not be used anymore.
14 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
17 * src/maemo/modest-main-window.c: Update menu items when the default
18 account changes so that the current default account is always bolded.
19 This fixes maemo.projects.org bug NB#66173.
21 2007-08-17 Murray Cumming <murrayc@murrayc.com>
23 * src/dbus_api/modest-dbus-callbacks.c:
24 (on_dbus_method_get_folders): Avoid trying to get the account name
25 when there are no accounts, to avoid critical g_warnings, fixing
26 projects.maemo.org bug NB#65574.
28 2007-08-17 Murray Cumming <murrayc@murrayc.com>
30 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
31 Use modest_account_mgr_get_signature() instead of accessing gconf
32 directly, to slightly simplify the code.
33 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
34 Append the signature also when opening via other applications,
35 fixing projects.maemo.org bug NB#65828.
37 2007-08-17 Murray Cumming <murrayc@murrayc.com>
39 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
40 Check for NULLs to prevent a crash when opening an email that is
41 an attachment in another email, fixing projects.maemo.org bug
44 2007-08-17 Murray Cumming <murrayc@murrayc.com>
46 * src/modest-ui-dimming-rules.c:
47 (modest_ui_dimming_rules_on_view_window_move_to):
48 Enable the Move To toolbar button for search results, fixing the
49 last part of projects.maemo.org bug NB#63807.
51 2007-08-17 Murray Cumming <murrayc@murrayc.com>
53 * src/dbus_api/modest-dbus-callbacks.c:
54 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
55 because this is called from idle handlers, to fix hangs afte the
57 (find_message_by_url): Added a TODO comment about a crash that
58 happens when tinymail was built with DBC checks.
60 2007-08-16 Murray Cumming <murrayc@murrayc.com>
62 * src/modest-search.c: (modest_search_folder):
63 * src/modest-search.h: Rename ModestSearch::before to start_date
64 and after to end_date, using the same names as the libogs struct
66 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
67 The start_date and end_date were swapped in the check. This
68 fixes date range searches, fixing projects.maemo.org bug NB#63407.
70 2007-08-16 Murray Cumming <murrayc@murrayc.com>
72 * src/maemo/modest-account-view-window.c:
73 Added (check_for_active_acount).
74 (on_delete_button_clicked), (on_edit_button_clicked):
75 When an account is doing something (such as refreshing),
76 show the same warning for account deletion as for account
77 editing, to fix projects.maemo.org bug NB#64588.
79 2007-08-16 Murray Cumming <murrayc@murrayc.com>
81 * src/widgets/modest-msg-view-window.h:
82 * src/gnome/modest-msg-view-window.c:
83 * src/maemo/modest-msg-view-window.c:
84 Added modest_msg_view_window_construct().
85 (modest_msg_view_window_new_with_header_model),
86 Added modest_msg_view_window_new_for_search_result),
87 Renamed modest_msg_view_window_new() to
88 modest_msg_view_window_new_for_attachment(),
89 and modest_msg_view_window_is_search_result(),
90 so we can explicitly know that the window is for an
91 attachment or a search result or a message from the list.
93 (modest_msg_view_window_view_attachment):
94 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
95 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
96 Use modest_msg_view_window_new_for_search_result().
98 * src/modest-ui-dimming-rules.c:
99 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
100 for search results, fixing projects.maemo.org bug NB#63811.
102 2007-08-16 Armin Burgmeier <armin@openismus.com>
104 * src/modest-ui-actions.c: Show a banner instead of a dialog when
105 renaming a folder fails, to stay consistent with what happens when
106 creating a folder fails.
108 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
109 slightly country loading from the mmc_mappings file, fixed a memory
112 2007-08-16 Murray Cumming <murrayc@murrayc.com>
114 * src/modest-tny-account-store.c: (volume_path_is_mounted):
115 Check the GnomeVFSVolume activation path instead of the device path,
116 so that the memory card is really really shown in the UI.
118 2007-08-16 Murray Cumming <murrayc@murrayc.com>
120 * src/maemo/easysetup/modest-easysetup-wizard.c:
121 (get_entered_account_title), (on_before_next), (entry_is_empty),
123 * src/maemo/modest-account-settings-dialog.c:
124 (get_entered_account_title), (on_button_signature), (check_data),
125 (save_configuration), (entry_is_empty):
126 Strip the account title of whitespace at the start and end before
127 using it or checking it. This means that an all-whitespace title
128 is not allowed, fixing projects.maemo.org bug NB#64977.
130 2007-08-15 Murray Cumming <murrayc@murrayc.com>
132 * src/modest-ui-actions.h:
133 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
134 to modest_run_account_setup_wizard() and made it public.
135 * src/dbus_api/modest-dbus-callbacks.c:
136 (check_and_offer_account_creation), (on_idle_mail_to),
137 (on_idle_compose_mail), (on_idle_open_default_inbox):
138 Offer account creation if necessary, fixing projects.maemo.org
141 2007-08-15 Murray Cumming <murrayc@murrayc.com>
143 * src/modest-ui-actions.c: (run_account_setup_wizard):
144 Return a gboolean to indicate success.
145 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
146 (modest_ui_actions_on_send): When offering account creation, only
147 give up (return) if account creation failed. Otherwise continue
148 with the original request. This fixed projects.maemo.org bug
151 2007-08-15 Murray Cumming <murrayc@murrayc.com>
153 * src/widgets/modest-recpt-editor.c:
154 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
155 to fix projects.maemo.org bug NB#63789.
157 2007-08-15 Murray Cumming <murrayc@murrayc.com>
159 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
160 (modest_tny_account_store_new): Properly detect the memory card at
161 startup, and add an account for it.
163 2007-08-14 Murray Cumming <murrayc@murrayc.com>
165 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
166 Commented out the MMC code again because it mistakenly detects
167 the card even when it isn't inserted.
169 2007-08-14 Murray Cumming <murrayc@murrayc.com>
171 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
172 Renabled the call to add_mmc_account() because I do not believe
173 it could be the cause of the mentioned hang (in scratchbox, where
174 there is no memory card), and because I have tested that it works
177 2007-08-14 Murray Cumming <murrayc@murrayc.com>
179 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
180 Comment out part of the last commit because it apparently causes
183 2007-08-14 Murray Cumming <murrayc@murrayc.com>
185 * src/modest-tny-account-store.c: Added the add_mmc_account()
186 function to save some copy/pasting.
187 (modest_tny_account_store_new): If the memory card is mounted,
188 create an account for it at the start, instead of waiting for the
189 user to unmount it and mount it.
191 2007-08-13 Murray Cumming <murrayc@murrayc.com>
193 * src/widgets/modest-account-view.c: (on_account_changed):
194 Do not try to use the human-readable TnyAccount name instead of the
195 ID of the modest account to get the transport account. And unref
196 the transport account. This prevents a g_warning(), and a possible
199 2007-08-13 Murray Cumming <murrayc@murrayc.com>
201 * src/maemo/modest-platform.c:
202 (modest_platform_set_update_interval): Handle the new
203 alarmd error to warn when alarmd is not running, as is the case in
204 scratchbox for me now because
205 "Module /usr/lib/alarmd/libretu.so initialization failed"
207 2007-08-13 Murray Cumming <murrayc@murrayc.com>
209 * src/widgets/modest-header-view-render.c:
210 (_modest_header_view_compact_header_cell_data):
211 NULL some strings after freeing them, trying to deal with
212 the double deletion found in projects.maemo.org bug 64183,
213 probably having no effect.
215 2007-08-13 Murray Cumming <murrayc@murrayc.com>
217 * src/maemo/modest-account-settings-dialog.c:
218 (create_page_incoming), (create_page_outgoing): Use a define
219 for the min and max port numbers.
221 (check_hildon_number_editor_and_warn_value_not_in_range),
222 (check_data): Do an extra check for an invalid port number, as needed
223 in projects.maemo.org bug #64275, when the number is cleared, but this
224 does not work due to bugs.maemo.org bug #1806.
226 2007-08-13 Murray Cumming <murrayc@murrayc.com>
228 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
229 Comment out the debug warning about the unexpected D-Bus methods.
230 They are just annoying now.
231 * src/maemo/modest-platform.c:
232 (modest_platform_set_update_interval): Correct the D-Bus path, instead
233 of using a file path, though it did not seem to break things before.
234 It might be needed now:
235 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
236 modest is not already running. This is the behaviour of the old client, and
237 Mox says it is what we should do for modest.
238 This closes projects.maemo.org bug NB#64327.
240 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
242 * src/modest-text-utils.c:
243 Fixed invalid jump due to incorrect string/pointer
245 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
248 2007-08-01 Murray Cumming <murrayc@murrayc.com>
250 * src/modest-account-mgr-helpers.h:
251 * src/modest-account-mgr-helpers.c:
252 Added modest_account_mgr_get_first_account_name(),
253 using code from modest_account_mgr_set_first_account_as_default().
255 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
256 (account_number_changed): Call set_at_least_one_account_visible() so that
257 the first account is visible when first added, without the user having to
259 I do wonder how this worked before.
261 2007-08-01 Murray Cumming <murrayc@murrayc.com>
263 * src/modest-tny-account-store.c: (show_password_warning_only),
264 (show_wrong_password), (request_password_and_wait), (get_password),
265 (modest_tny_account_store_alert): Remove the (incomplete anyway)
266 attempts to show UI only in the main context, which used g_idle_add()
267 and mainloops, because tinymail now guarantees that it only calls these
268 callbacks in the mainloop with the gdk lock. This makes everything much
271 2007-08-01 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
274 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
275 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
276 error dialog, instead of ignoring it.
278 2007-08-01 Murray Cumming <murrayc@murrayc.com>
280 * src/maemo/modest-msg-view-window.c:
281 (modest_msg_view_window_get_header),
282 (modest_msg_view_window_last_message_selected):
283 Added comments to explain the use of priv->header_model.
284 * src/modest-ui-dimming-rules.c:
285 (modest_ui_dimming_rules_on_open_msg),
286 (modest_ui_dimming_rules_on_mark_as_read_msg),
287 (modest_ui_dimming_rules_on_mark_as_unread_msg),
288 (modest_ui_dimming_rules_on_remove_attachments),
289 (_invalid_attach_selected), (_selected_msg_marked_as):
290 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
291 and changed the parameter to a ModestMainWindow to make it clearer that
292 it never uses any other kind of window.
293 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
294 instead of the selected message.
295 I notice that much of the dimming code and the ModestMsgViewWindow code
296 hard-codes the assumption that the viewed message is always selected in
297 the header view. This does not seem wise or simple.
299 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
300 examine the actual message instead of whatever might be selected
301 in the header view. This stops the delete toolbar button and menu item
302 from being dimmed when opening a message view the search UI,
303 partially fixing projects.maemo.org bug NB#63811.
305 However, when actually deleting, I now get this warning:
306 "tny_header_set_flags: This is a header instance for a new message.
307 Only priority and attachment flags are supported"
309 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
311 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
313 Show account wizard if no accounts are defined while sending
314 (automatic sending after the account wizard finished does not
315 work because it takes some time until the account manager
316 synchronizes everything. (projects.maemo.org NB#62792)
318 2007-07-30 Murray Cumming <murrayc@murrayc.com>
320 * src/modest-tny-account-store.c: (on_account_removed),
321 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
322 account is removed from the View menu. We have TnyAccountStore
323 and ModestTnyAccountStore signals that seem very similar, but this
324 seems to work for now.
326 * src/maemo/modest-main-window.c:
327 (on_show_account_action_activated): Prevent dereference
328 of a NULL if the accoutn does not really exist, though that
329 should not happen anymore.
331 This fixes projects.maemo.org bug NB#64606.
333 2007-07-30 Murray Cumming <murrayc@murrayc.com>
335 * src/modest-ui-actions.c: (run_account_setup_wizard),
336 (modest_ui_actions_on_accounts): Revert a change that set these
337 to modal dialogs, freezing the UI when they show secondary dialogs.
338 This fixed projects.maemo.org bug NB#64519.
340 2007-07-27 Murray Cumming <murrayc@murrayc.com>
342 * src/widgets/modest-header-view-render.c:
343 (_modest_header_view_compact_header_cell_data):
344 Some checks and initialization to try to deal with a crash,
345 probably ineffective.
347 2007-07-27 Murray Cumming <murrayc@murrayc.com>
349 * src/maemo/modest-maemo-utils.c:
350 (modest_maemo_utils_get_supported_secure_authentication_methods):
351 Make sure that we have a connection, asking the user for one
353 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
354 Check for a connection before showing the wizard, because
355 the wizard needs a connection to check for server capabilities.
357 2007-07-27 Murray Cumming <murrayc@murrayc.com>
359 * src/maemo/modest-account-view-window.c:
360 (on_new_button_clicked): Remember the wizard dialog instance,
361 so we can just present it again if necessary. This prevents
362 multiple windows from appearing if you click again quickly on the
363 New button before the dialog appears, fixing projects.maemo.org
366 2007-07-27 Murray Cumming <murrayc@murrayc.com>
368 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
369 Offer a connection dialog if there is no connection when
370 starting modest. This should fix projects.maemo.org bug NB#61134.
372 2007-07-27 Murray Cumming <murrayc@murrayc.com>
374 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
375 Reverted my last commit. I was able to fix the build by doing
376 apt-get install wpeditor0 (replacing other wpeditor packages) and
377 an explicit apt-get install wpeditor-dev to upgrade the -dev
380 2007-07-27 Murray Cumming <murrayc@murrayc.com>
382 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
383 Commented out the use of wp_text_buffer_replace_image()
384 because it does not exist, to break the build. Added a TODO for it.
386 2007-07-26 Murray Cumming <murrayc@murrayc.com>
388 * src/modest-tny-account-store.c: (recreate_all_accounts):
389 Recreate them even if they were NULL before. I guess something
390 else was already creating them before, or this would never
392 (modest_tny_account_store_get_server_account): Make sure that
393 the tny accounts have been created before trying to find one.
394 This allows libmodest_dbus_client_compose_mail() to work
395 when the UI is not yet visible.
396 This is probably useful in other cases too.
398 (get_password): When the password is wrong after it is entered
399 in the protected password dialog, show an info banner (in an
400 idle handler) before showing the protected password dialog
403 2007-07-26 Murray Cumming <murrayc@murrayc.com>
405 * src/modest-ui-actions.h:
406 * src/modest-ui-actions.c: Added
407 modest_do_refresh_current_folder() containing some code from
408 modest_ui_actions_on_send_receive().
409 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
410 Call modest_do_refresh_current_folder() before refreshing the
411 requested account, as in modest_ui_actions_on_send_receive().
412 This is strange, but seems to be necessary to show new mails.
413 Now new emails are finally visible in the UI when downloaded
414 via the automatic update interval, fixing bug NB#57458.
415 This also works because bug NB#57458 has been fixed somehow.
417 2007-07-26 Murray Cumming <murrayc@murrayc.com>
419 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
420 printf more details when we get unhandled D-Bus methods, because
423 * src/modest-mail-operation.c: (update_account_thread):
424 Comment out the tny_camel_pop_store_account_reconnect(), because this
425 is apparently no longer needed, and it did not work before anyway.
426 See the comment in the code.
428 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
429 by checking the header flags. This fixes projects.maemo.org bug
432 2007-07-25 Murray Cumming <murrayc@murrayc.com>
434 * src/maemo/modest-maemo-utils.h:
435 * src/maemo/modest-maemo-utils.c: Added
436 modest_maemo_show_information_note_in_main_context_and_forget().
437 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
438 Use the new function to show simple error dialogs in the main
439 context, though question dialogs are still in the current context,
440 which is unfortunately usually not the main context. This should
443 2007-07-25 Murray Cumming <murrayc@murrayc.com>
445 * src/modest-tny-account-store.c: (get_password):
446 Never save the entered username and password in gconf,
447 because the UI spec says we should not. This helps
448 slightly with projects.maemo.org bug NB#63671.
450 2007-07-25 Murray Cumming <murrayc@murrayc.com>
452 * src/widgets/modest-msg-edit-window.h:
453 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
454 Moved some code here to make it simpler.
455 (modest_msg_edit_window_attach_file_one): Renamed from
456 modest_msg_edit_window_attach_file_interactive().
457 (modest_msg_edit_window_offer_attach_file): Renamed from
458 modest_msg_edit_window_attach_file() and used
459 modest_msg_edit_window_attach_file_one() instead of
460 copy/pasting the code. The old code for one was not using
461 GnomeVFS. This allows use of smb:// URLs when using send-as
462 from external applications, fixing bug NB#63741.
464 (modest_msg_edit_window_insert_image),
465 (modest_msg_edit_window_add_attachment_clicked):
466 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
467 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
468 Adapted to the new function names.
470 2007-07-25 Murray Cumming <murrayc@murrayc.com>
472 (modest_platform_set_update_interval): Set the alarm recurrence
473 fields so that auto-update does not just happen the first time.
474 This should have fixed projects.maemo.org bug NB#63938.
476 When this happens you can see a printf when the D-Bus method is
478 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
480 However, I do not actually seem to get new POP messages even when
481 clicking the refresh button manually. A restart gets them.
482 This might be a problem in today's tinymail only.
484 2007-07-24 Murray Cumming <murrayc@murrayc.com>
486 * src/maemo/modest-maemo-global-settings-dialog.c:
487 (current_connection):
488 Avoid a crash (probably only in scratchbox) when strcmp()ing a
489 NULL when closing the dialog.
491 2007-07-24 Murray Cumming <murrayc@murrayc.com>
493 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
494 Remove the hacky send/receive that didn't work, and instead
495 refilter the treemodel to make the deleted email really vanish from
496 the UI (though the delete-from-menu code does has commented out
497 the code that does that). This fixes projects.maemo.org bug
500 2007-07-24 Murray Cumming <murrayc@murrayc.com>
502 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
503 Try a couple of tricks to force the treeview to update (
504 poke the folder, and do a send/receive refresh), but the deleted
505 email still appears with a strike-through instead of really being
508 2007-07-23 Murray Cumming <murrayc@murrayc.com>
510 * src/dbus_api/modest-dbus-callbacks.c:
511 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
512 because their ID is not human-readable (see the comment about
513 improvements needed to the osso-email-interface API) and
514 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
516 2007-07-23 Murray Cumming <murrayc@murrayc.com>
518 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
519 (add_folders_to_list), (on_dbus_method_get_folders),
520 (modest_dbus_req_filter):
521 * src/maemo/modest-maemo-utils.c:
522 (on_camel_account_get_supported_secure_authentication):
523 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
524 (on_header_view_focus_in):
525 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
526 * src/modest-formatter.c: (modest_formatter_create_body_part):
527 * src/modest-mail-operation.c: (recurse_folders),
528 (update_account_thread), (get_msgs_full_thread),
529 (modest_mail_operation_get_msgs_full),
530 (modest_mail_operation_xfer_msgs):
531 * src/modest-search.c: (search_mime_part_and_child_parts),
532 (modest_search_account), (modest_search_all_accounts):
533 * src/modest-tny-account.c:
534 (modest_tny_account_get_special_folder), (recurse_folders):
535 * src/modest-tny-local-folders-account.c:
536 (modest_tny_local_folders_account_query_passes):
537 * src/modest-tny-msg.c: (copy_mime_part),
538 (modest_tny_msg_find_body_part_from_mime_part):
539 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
540 (modest_tny_send_queue_try_to_send):
541 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
542 (_modest_ui_actions_open), (download_uncached_messages),
543 (reply_forward), (modest_ui_actions_on_copy),
544 (modest_ui_actions_on_details), (has_retrieved_msgs),
545 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
547 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
548 (_selected_msg_marked_as), (_msg_download_completed),
549 (_selected_msg_sent_in_progress):
550 * src/widgets/modest-attachments-view.c:
551 (modest_attachments_view_set_message):
552 * src/widgets/modest-msg-view.c: (find_cid_image):
553 * tests/check_folder-transfer.c: (find_folders):
554 * tests/check_update-account.c: (func):
555 * tests/dbus_api/test_get_folders.c: (main):
556 Checked all uses of tny_iterator_get_current(), making sure
557 that the object is unreferenced (3 or 4 places did not),
558 and adding checks for NULL.
560 2007-07-23 Murray Cumming <murrayc@murrayc.com>
562 * src/dbus_api/modest-dbus-callbacks.c:
563 (on_idle_open_default_inbox): Make sure that the application UI is
565 * src/maemo/easysetup/modest-easysetup-wizard.c:
566 (on_entry_invalid_character): Show the word whitespace instead
567 of (null) in the banner when whitespace was entered.
568 (show_error): Add a comment that this does not work in
569 Maemo Bora, though we do not know why.
571 2007-07-23 Murray Cumming <murrayc@murrayc.com>
573 * src/modest-tny-account.c:
574 (modest_tny_account_get_special_folder): Use an if instead of
575 an assert for when the parent account name is NULL, because this
576 might be causing a crash in projects.maemo.org bug 63192.
577 * src/modest-mail-operation.c:
578 (modest_mail_operation_send_new_mail_cb),
579 (modest_mail_operation_remove_folder): unref the folder that is
580 returned from modest_tny_account_get_special_folder().
582 2007-07-23 Murray Cumming <murrayc@murrayc.com>
584 * src/modest-ui-actions.c:
585 (modest_ui_actions_on_password_requested):
586 Show mail_ib_login_cancelled info banner when the user cancels
587 the protected password dialog, to fix projects.maemo.org
590 2007-07-23 Murray Cumming <murrayc@murrayc.com>
592 * src/maemo/modest-account-settings-dialog.c:
593 (create_page_outgoing): Put this page in a GtkScrolledWindow,
594 matching the UI mock-up in the UI spec, and allowing access
595 to all widgets even when the on-screen keyboard is active.
597 2007-07-23 Murray Cumming <murrayc@murrayc.com>
599 Reverted this previous commit from Johannes,
600 because the scrollbars are always visible and because
601 I think we only need it on onepage of the account
602 settings, not the account wizard.
603 (I wrote the wrong instructions in the bug.)
605 * src/maemo/easysetup/modest-easysetup-wizard.c:
606 Added scrollbars to account wizard dialog.
607 Fixed projects.maemo.org NB #62744
609 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
611 * src/maemo/easysetup/modest-easysetup-wizard.c:
612 (create_page_user_details):
613 Use auto-cap for name (projects.maemo.org NB#63716)
614 * src/widgets/modest-account-view.c: (on_account_busy_changed):
616 2007-07-22 Armin Burgmeier <armin@openismus.com>
618 * src/maemo/modest-ui-actions.c: Use current account instead of
619 default account for creating viewer windows, so that the viewer
620 window knows to which account the viewed message belongs.
622 * src/maemo/modest-msg-view-window.c: Destroy the window when the
623 corresponding account is deleted. This fixes projects.maemo.org bug
626 2007-07-18 Armin Burgmeier <armin@openismus.com>
628 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
629 the dialog close after entering an invalid port number and clicking
630 OK. This fixes projects.maemo.org bug NB#63602.
632 2007-07-18 Armin Burgmeier <armin@openismus.com>
634 * src/modest-tny-account-store.c:
635 (get_server_accounts): Set parent modest account name for each
636 connection-specific transport account so that special folders of such
637 an account can be looked up. This fixes a crash when changing account
638 settings. This might also be related to projects.maemo.org bug
641 2007-07-16 Armin Burgmeier <armin@openismus.com>
643 * src/modest-ui-actions.c: Added a button to create a folder to the
644 move-to dialog. This fixes projects.maemo.org bug NB#59863.
646 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
648 * src/maemo/easysetup/modest-easysetup-wizard.c:
649 Added scrollbars to account wizard dialog.
650 Fixed projects.maemo.org NB #62744
652 2007-07-16 Murray Cumming <murrayc@murrayc.com>
654 * src/widgets/modest-msg-view.h:
655 * src/widgets/modest-msg-view.c:
656 Added modest_msg_view_get_message_is_empty() but this needs
658 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
659 Check if there is any text in the message yet.
660 But this needs to be implemented properly.
661 (modest_msg_edit_window_toggle_find_toolbar):
662 * src/maemo/modest-msg-view-window.c:
663 (modest_msg_view_window_toggle_find_toolbar):
664 Show a banner warning if there is no text to search, when
665 trying to start a search. This partially fixes
666 projects.maemo.org bug NB#62350.
668 2007-07-13 Murray Cumming <murrayc@murrayc.com>
670 * src/modest-mail-operation.c: (update_account_thread):
671 Initialized num_new_headers to fix the build.
673 2007-07-13 Murray Cumming <murrayc@murrayc.com>
675 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
676 Ignore modest accounts whose server accounts don't exist in gconf.
677 This prevents us trying to create TnyAccount instances for those
678 server accounts when the server account has been removed from gconf,
679 but the parent modest account has not yet been removed from modest.
680 I don't know why this is only noticeable now. It was probably just
681 a harmeless g_warning() anyway.
683 2007-07-13 Murray Cumming <murrayc@murrayc.com>
685 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
686 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
688 2007-07-12 Armin Burgmeier <armin@openismus.com>
690 * src/maemo/modest-main-window.c: Make default account appear bold
691 in view, tools/send & receive and toolbar/send & receive SCM menus.
692 This fixes projects.maemo.org bug NB#59010.
694 2007-07-12 Murray Cumming <murrayc@murrayc.com>
696 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
697 Add a short-cut, by checking if the folder store is an account.
698 This ensures that the Sort menu item and toolbar is dimmed for
699 the local-folders account root item, fixing
700 projects.maemo.org bug NB#62545.
702 2007-07-12 Murray Cumming <murrayc@murrayc.com>
704 * src/modest-tny-account-store.c: (get_password):
705 Show the password dialog (via the signal) only in the mainloop, via
706 an idle handler that we wait for. This could theoretically prevent
707 hangs, though I worry that it could introduce some too.
709 2007-07-12 Murray Cumming <murrayc@murrayc.com>
711 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
712 * src/maemo/modest-platform.c:
713 (modest_platform_connect_and_wait):
714 Take a TnyAccount* parameter and try to set it to online
715 (a TnyCamel-only API), because tinymail sets accounts to offline
716 when the user cancels a password dialog, and doesn't ask again until
717 it has been set to online.
718 However, this is commented out because it causes a hang now.
720 (modest_platform_connect_and_wait_if_network_account):
721 * src/modest-mail-operation.c:
722 (modest_mail_operation_update_account):
723 * src/modest-platform.h:
724 * src/modest-ui-actions.c: (_modest_ui_actions_open),
725 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
727 2007-07-12 Armin Burgmeier <armin@openismus.com>
729 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
731 * src/modest-mail-operation.c:
732 * src/modest-ui-actions.c: Check for already existing folder before
733 querying the server, show error message from camel if the request
734 still fails. This fixes projects.maemo.org bug NB#58701.
736 2007-07-12 Murray Cumming <murrayc@murrayc.com>
738 * src/modest-tny-account-store.h:
739 * src/modest-tny-account-store.c:
740 Added modest_tny_account_store_forget_password_in_memory(),
741 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
742 when creating a new account, so that new passwords will be used, instead of
743 us thinking that it's a second request as a result of a failed password again.
745 2007-07-12 Murray Cumming <murrayc@murrayc.com>
747 * src/dbus_api/modest-dbus-callbacks.c:
748 (on_idle_open_message): If the message is in drafts then open it
749 in an edit window instead of a view window. This fixes
750 projects.maemo.org bug NB#63005.
752 2007-07-12 Murray Cumming <murrayc@murrayc.com>
754 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
755 Avoided a harmless g_warning().
757 2007-07-12 Murray Cumming <murrayc@murrayc.com>
759 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
760 Pass the modest account name, not the TnyAccount display name to
761 modest_msg_view_window_new() so that the reply feature works,
762 fixing projects.maemo.org bug NB#62892.
764 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
765 (modest_msg_view_window_new_with_header_model):
766 * src/maemo/modest-msg-view-window.c:
767 (modest_msg_view_window_new_with_header_model),
768 (modest_msg_view_window_new):
769 * src/modest-ui-actions.c: (reply_forward):
770 * src/widgets/modest-msg-view-window.h:
771 * src/widgets/modest-window.c: (modest_window_set_active_account):
772 Rename an account parameter to modest_account_name to make this clearer.
774 2007-07-11 Murray Cumming <murrayc@murrayc.com>
776 * src/modest-ui-actions.h:
777 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
778 modest_do_message_delete().
779 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
780 Call modest_do_message_delete(), hoping that this would cause messages
781 to be really deleted from search instead of just marked with strike through.
782 Does not seem to help.
784 2007-07-11 Armin Burgmeier <armin@openismus.com>
786 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
787 priv->reselect to FALSE prior to calling
788 modest_folder_view_select_first_inbox_or_local() to prevent endless
789 recursion and thus a crash on startup.
791 2007-07-11 Armin Burgmeier <armin@openismus.com>
793 * src/maemo/modest-account-settings-dialog.h: Include
794 <gtk/gtknotebook.h> to fix the build (at least for me).
796 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
797 Use "New FolderN" as default suggested name if "New folder" already
798 exists, with N being the first free number, though never exceed "New
799 folder99" in which case we just fall back to "New Folder" even though
800 it already exists. This fixes projects.maemo.org bug NB#58663.
802 2007-07-11 Murray Cumming <murrayc@murrayc.com>
804 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
805 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
806 projects.maemo.org bug NB#62778.
808 2007-07-11 Murray Cumming <murrayc@murrayc.com>
810 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
811 Ignore the wrong (for now) secure-smtp setting in the presets -
812 just default to requiring secure authentication for SMTP, because
815 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
817 * src/widgets/modest-folder-view.c: (filter_row)
818 Do not show drafts folder (see UI specs)
820 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
822 * src/modest-ui-actions.c:
823 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
824 place and also not necessary.
826 * src/widgets/modest-folder-view.c: (filter_row)
827 Guess folder type and hide Sent & Outbox if necessary.
828 Fixed project.maemo.org NB#57328
830 2007-07-11 Murray Cumming <murrayc@murrayc.com>
832 * src/modest-ui-actions.h:
833 * src/modest-ui-actions.c:
834 (modest_ui_actions_on_delete_message):
835 Move some code into a new
836 modest_ui_actions_refresh_message_window_after_delete()
837 function so we can use it from elsewhere.
839 * src/dbus_api/modest-dbus-callbacks.c:
840 (on_idle_delete_message), (on_delete_message): Used an idle
841 handler, as we do for the other D-Bus method handlers.
842 Call modest_ui_actions_refresh_message_window_after_delete()
843 if the deleted message was open in a window. This fixed
844 projects.maemo.org bug NB#62862.
846 2007-07-11 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-main.c: (main): Only show the UI at the start if
849 the showui command line option was given. For instance,
850 run-standalone src/modest showui
851 Otherwise, we wait for the top_application D-Bus method to
852 be sent by hildon-desktop when the application is selected
854 This allows us to run without a UI when osso-global-search
855 uses our D-Bus methods.
857 2007-07-11 Murray Cumming <murrayc@murrayc.com>
859 * src/dbus_api/modest-dbus-api.h: Added a define for a
860 top-application D-Bus method.
861 * src/dbus_api/modest-dbus-callbacks.c:
862 (on_top_application),
863 (modest_dbus_req_handler): Handle the top-application D-Bus
864 method, which might be an undocumented D-Bus signal sent by
865 hildon-desktop when it starts the application from the menu.
866 But I am not sure and I need to test it on the device, because
867 my scratchbox does not have the application in the menu now.
868 This method shows the main window, so that it can be invisible
869 when started, for instance, just for email searching from
872 * src/maemo/modest-main-window.c: (restore_settings),
873 (modest_main_window_new): Do not show the window immediately
874 upon creation. We show it later.
875 * src/modest-widget-memory.c: (save_settings_paned):
876 Try (unsuccessfully) to avoid saving the paned position when
877 it is not even visible.
878 (restore_settings_paned): Do not allow a silly paned position.
879 This seems necessary when not showing the window at first.
881 * tests/dbus_api/Makefile.am:
882 * tests/dbus_api/test_top_application.c: (main): Test for the
885 2007-07-10 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-ui-dimming-rules.c:
888 (modest_ui_dimming_rules_on_new_msg),
889 (modest_ui_dimming_rules_on_reply_msg),
890 (modest_ui_dimming_rules_on_delete_msg),
891 (modest_ui_dimming_rules_on_details),
892 (modest_ui_dimming_rules_on_view_window_move_to),
893 (modest_ui_dimming_rules_on_view_previous),
894 (modest_ui_dimming_rules_on_view_next),
895 (_invalid_folder_for_purge): Added checks before
896 casting the window. This looks like an actual
897 logic error in _invalid_folder_for_purge(), because it
898 tries to use a ModestMainWindow as a message window.
900 2007-07-10 Murray Cumming <murrayc@murrayc.com>
902 * src/maemo/modest-account-settings-dialog.c:
903 (show_error): Use the same implementation as in
904 modest-easysetup-wizard.c:
905 (on_entry_invalid_character): The logical ID contains a %s.
906 Guessed what it should be.
907 (on_entry_max), (check_data), (on_response): Adapt to
908 changed show_error().
909 (create_page_account_details): Really call
910 modest_validating_entry_set_func() on the correct widgets.
911 * src/maemo/easysetup/modest-easysetup-wizard.c:
912 (on_entry_invalid_character): Fix the logical ID here too.
913 (create_page_account_details),
914 (create_page_user_details):
916 modest_validating_entry_set_func() on the correct widgets.
918 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
919 Do not try to use the account if it is NULL.
921 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
923 * src/modest-ui-actions.c: (create_move_to_dialog),
924 (modest_ui_actions_on_main_window_move_to),
925 (modest_ui_actions_on_msg_view_window_move_to):
926 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
927 (filter_row), (modest_folder_view_show_non_move_folders):
928 * src/widgets/modest-folder-view.h:
930 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
931 the Sent folder yet as it does not report the correct folder type.
933 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
935 * src/maemo/modest-msg-edit-window.c: (init_window):
938 2007-07-10 Murray Cumming <murrayc@murrayc.com>
940 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
941 Take a parent widget instead of a parent window, and
942 implement this with hildon_banner_show_information() instead.
943 Non-Maemo builds can just ifdef that there.
944 This fixed projects.maemo.org bug NB#62766.
946 (on_entry_invalid_character): Use show_error() again instead
947 of using hildon directly, and use the _CS() macro to use the correct
949 (create_account), (check_for_supported_auth_methods), (on_entry_max):
950 Pass a widget instead od a window to show_error().
952 2007-07-10 Murray Cumming <murrayc@murrayc.com>
954 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
955 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
956 This allows us to show the server name in the error message, fixing
957 projects.maemo.org bug NB#62904.
958 Also, use the appropriate logical ID message for the account protocol.
960 2007-07-10 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-tny-account-store.c: (on_idle_wrong_password):
963 A compilation fix, though the build wasn't broken for me.
965 2007-07-09 Murray Cumming <murrayc@murrayc.com>
967 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
968 Do not try to unref a NULL folder store, to avoid a runtime warning.
969 This seems to happen sometimes when changing accounts settings.
971 2007-07-09 Murray Cumming <murrayc@murrayc.com>
973 * src/modest-tny-account-store.c:
974 (modest_tny_account_store_instance_init),
975 (modest_tny_account_store_finalize),
976 (on_account_settings_hide), (on_idle_wrong_password):
977 Use a GHashTable to ensure that we only show one account settings
978 dialog per modest account. This avoids us having a dialog open for
979 both the store and transport accounts, or due to repeated get_password()
980 calls that shouldn't happen anyway.
982 2007-07-09 Murray Cumming <murrayc@murrayc.com>
984 * src/maemo/modest-maemo-utils.c: (on_hide),
985 (modest_maemo_show_dialog_and_forget): Handle the response, because
986 the window is not even hidden by default.
988 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
989 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
990 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
991 which seems to prevent some modality problems.
993 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
994 Ignore user cancellation errors.
996 * src/modest-account-mgr-helpers.h:
997 * src/modest-account-mgr-helpers.c:
998 Added modest_server_account_get_password() and
999 modest_server_account_get_has_password() to avoid direct use of
1002 * src/maemo/modest-account-settings-dialog.h:
1003 * src/maemo/modest-account-settings-dialog.c:
1004 (modest_account_settings_dialog_init): Store the notebook so we can
1006 Added modest_account_settings_dialog_switch_to_user_info().
1008 * src/modest-tny-account-store.c:
1009 (get_password): When the password in the account settings is wrong (we think),
1010 show the relevant page of the account settings dialog, in the mainloop.
1011 However, we currently get many of these at once because cancel does not
1013 (forget_password): Do not forget the password
1014 from the account settings, because this causes side-effects when
1015 tinymail seems to call it at strange time, maybe because of how we
1016 are cancelling get_password().
1017 (modest_tny_account_store_alert): Ignore user cancellations.
1019 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1021 * src/maemo/modest-maemo-utils.h:
1022 * src/maemo/modest-maemo-utils.c:
1023 Added modest_maemo_show_information_note_and_forget() for use instead of
1024 gtk_dialog_run() when the response is not needed, to avoid an extra
1025 mainloop which could cause a hang.
1027 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1028 Use the logical IDs for the error message, though they are not
1029 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1030 because gtk_dialog_run() caused a hang here (the window did not close).
1031 This fixes projects.maemo.org bug NB#62646.
1033 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1035 * src/modest-account-mgr-helpers.h:
1036 * src/modest-account-mgr-helpers.c:
1037 Added modest_account_mgr_get_store_protocol().
1039 * src/maemo/modest-account-view-window.c:
1040 (on_delete_button_clicked): Show different warning text depending on
1041 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1042 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1045 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1047 * src/maemo/modest-msg-edit-window.c:
1048 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1049 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1051 2007-07-07 Armin Burgmeier <armin@openismus.com>
1053 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1054 ckdg_ib_maximum_characters_reached from correct package.
1056 * src/modest-ui-actions.c: Show an error message when a folder could
1057 not be created. Tinymail does not give us specific error codes about
1058 what has gone wrong, so we assume that a folder with that name
1059 already exists, though there might be other reasons.
1061 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1063 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1064 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1065 give a more exact error message that can be partly translated.
1067 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1069 * src/maemo/modest-address-book.c:
1070 (select_email_addrs_for_contact): Specify a default window size for the
1071 select-email-address dialog, so that it is probably big enough for the
1072 title. This should fix projects.maemo.org bug NB#62277.
1074 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1076 * src/maemo/easysetup/modest-easysetup-wizard.c:
1077 (create_page_complete_easysetup): Use
1078 gtk_widget_set_size() request to ensure that the text wraps
1081 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1083 * src/maemo/easysetup/modest-easysetup-wizard.c:
1084 (on_entry_invalid_character), (create_page_account_details),
1085 (create_page_user_details):
1086 Use new API of ModestValidatingEntry. But for some reason the banner is
1087 not shown. I will have to investigate that further.
1089 * src/widgets/modest-validating-entry.c: (on_insert_text),
1090 (modest_validating_entry_set_func):
1091 * src/widgets/modest-validating-entry.h:
1092 Added a new callback function to be able to react to prevented
1093 characters whitespaces to e.g show a banner.
1095 2007-07-05 Armin Burgmeier <armin@openismus.com>
1097 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1098 notification of HildonNumberEditor instead of remembering the port
1099 number. Thanks to Johannes for pointing this out.
1101 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1103 * src/maemo/easysetup/modest-easysetup-wizard.c:
1104 Check if there are any user changes before showing a confirmation
1105 dialog (projects.maemo.org NB#60946)
1107 2007-07-05 Armin Burgmeier <armin@openismus.com>
1109 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1110 number at the beginning of the dialog and set the modified flag at the
1111 end if the port number has changed. This is necessary because
1112 HildonNumberEditor does not support notification when the value has
1115 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1117 * src/modest-ui-actions.c:
1118 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1119 a connection before asking anything else. Correct the check for the destination
1120 folder so that it succeeds when online.
1121 This fixed projects.maemo.org bug NB#61645.
1123 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1125 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1126 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1127 to fix projects.maemo.org bug NB#62439.
1129 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1131 * src/modest-tny-account.c: (on_connection_status_changed):
1132 Really do not use tny_device_force_offline() here. See the previous comment.
1134 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1136 * src/modest-tny-account.c: (on_connection_status_changed):
1137 Do not use tny_device_force_offline() when tinymail says that something
1138 went wrong with the connection. It seems to report this unnecessarily.
1140 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1142 * src/maemo/modest-connection-specific-smtp-window.c:
1143 (modest_connection_specific_smtp_window_init):
1144 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1145 does not seem to have any effect in osso 1.1 (though it works in
1146 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1148 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1150 * src/maemo/modest-connection-specific-smtp-window.c:
1151 Fix UI specification problems with projects.meamo.org NB#60479
1153 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1155 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1156 clue when this has failed, because the error dialog is not always shown
1157 (at least in earlier version).
1159 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1160 GError message, because the generic error dialog is not helpful.
1162 'This message is not currently available (can't let a new connection go online)'
1163 when trying to open an IMAP message.
1165 (_modest_ui_actions_open): Offer a connection when some messages would
1166 have to be downloaded and we are offline.
1168 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1170 * src/widgets/modest-folder-view.c:
1171 Don't check for MERGE type anymore as we use the correct type
1173 NOTE: For the last two changes you need to update your tinymail copy
1174 because of API changes!
1176 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1178 * src/modest-tny-local-folders-account.c:
1179 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1180 (see projects.maemo.org NB#61580)
1182 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1184 * src/modest-tny-account.c: (on_connection_status_changed):
1185 Commented out the call to modest_platform_connect_and_wait() because this
1186 seems to always hang, and I would like to know if this is the only thing
1187 that causes a hang when showing the connection dialog.
1188 It is not very useful anyway.
1190 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1192 * src/maemo/modest-msg-view-window.c:
1193 (modest_msg_view_window_select_next_message):
1195 * src/modest-platform.h:
1196 * src/maemo/modest-platform.c:
1197 Added modest_platform_connect_and_wait(), which calls
1198 tny_maemo_conic_device_connect() always in the main thread, by calling it
1199 in an idle handler and waiting for the idle handler to run. It should be
1200 in the main thread because it uses GTK+ UI code. It just returns TRUE
1201 if the device is already online.
1203 There is some nasty code to ensure that subsequent calls to
1204 modest_platform_connect_and_wait() just wait for the first one to finish,
1205 by checking repeatedly in another idle handler. This is necessary,
1206 because other threads (or even the main thread, via another idle handler)
1207 can call modest_platform_connect_and_wait() while
1208 modest_platform_connect_and_wait() is running.
1210 (modest_platform_connect_and_wait_if_network_account),
1211 (modest_platform_connect_and_wait_if_network_folderstore):
1212 Convenience functions that calls modest_platform_connect_and_wait() if
1213 the account or folder might want network access.
1215 * src/modest-mail-operation.c:
1216 (modest_mail_operation_update_account):
1217 * src/modest-ui-actions.c: (download_uncached_messages),
1218 (modest_ui_actions_on_rename_folder), (delete_folder),
1219 (modest_ui_actions_on_main_window_move_to),
1220 (modest_ui_actions_on_msg_view_window_move_to):
1221 * src/widgets/modest-folder-view.c:
1222 (drag_and_drop_from_folder_view):
1223 Offer a connection if we are offline.
1225 * src/modest-tny-account.c: (on_connection_status_changed):
1226 Document this as only handling errors during network operations in progress,
1227 and replace the idle code with a simple call to
1228 modest_platform_connect_and_wait(), which does this instead.
1230 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1232 * src/modest-tny-account.c:
1233 (modest_tny_account_get_special_folder): (util_on_idle),
1234 Handle the GError so we can see when tny_folder_store_get_folders()
1235 fails, as it currently does while something else is connecting.
1237 Added util_run_in_main_thread_and_wait()
1238 which uses an idlen handler and mainloop to ensure that the function
1239 is called in the main thread.
1240 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1241 to make sure that we call attempt the connection in the mainloop only,
1242 which might solve some hangs.
1244 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1246 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1247 be found by their display name. This is never useful.
1248 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1249 by its ID, instead of trying to use its ID as its display name.
1251 * src/modest-tny-account-store.h:
1252 * src/modest-tny-account.c:
1253 (modest_tny_account_get_special_folder): Add a g_warning() when
1254 tny_folder_store_get_folders() returns an empty list for the maildir.
1256 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1257 Add a g_warning() when this returns NULL, because that it not allowed
1260 2007-07-02 Armin Burgmeier <armin@openismus.com>
1262 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1263 note when trying to cancel the wizard. This fixes projects.maemo.org
1266 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1268 * src/modest-tny-account.h:
1269 * src/modest-tny-account.c:
1270 (modest_tny_account_new_from_server_account),
1271 (modest_tny_account_new_from_server_account_name),
1272 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1273 because this must now be set before setting the proto. This is usd in
1274 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1275 warning in camel_session_get_service() caused by
1276 tny_camel_transport_account_prepare().
1278 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1281 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1283 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1285 (modest_connection_specific_smtp_edit_window_init):
1287 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1288 of "changed" for now
1290 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1292 * src/modest-tny-account.c:
1293 (modest_tny_account_new_from_server_account):
1294 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1295 now uses to request a connection when it needs one, and which it uses
1296 to tell us that something is wrong with the connection, so we can force
1297 the accounts offline to prevent further problems.
1299 * src/modest-defs.h:
1300 * src/modest-init.c: (init_default_settings):
1301 * src/modest-mail-operation.c:
1302 (modest_mail_operation_update_account):
1303 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1304 This should not be necessary anymore. Do not set the conf key that
1305 determined this (it was always TRUE and not set anywhere else).
1307 * src/modest-ui-actions.h: Remove unused and unimplemented
1308 modest_ui_actions_on_online_toggle_toggled().
1310 2007-06-29 Murray Cumming <murrayc@murrayc.com
1312 * src/maemo/modest-main-window.c: (connect_signals):
1313 Don't connect to delete_event twice. Maybe this was harmless.
1315 2007-06-29 Murray Cumming <murrayc@murrayc.com
1317 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1318 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1319 Debug output to give some more clue when a folder move is not allowed.
1321 2007-06-28 Murray Cumming <murrayc@murrayc.com
1323 * src/modest-tny-account.c: (on_modest_file_system_info),
1324 (modest_tny_account_get_mmc_account_name):
1325 Always call the callback, without checking whether the name has changed.
1326 * src/widgets/modest-folder-view.c: (strings_are_equal),
1327 (on_model_foreach_set_name), (on_get_mmc_account_name),
1328 (text_cell_data): Compare the name here, and use the name from
1329 the account rather than from the
1330 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1331 if the name was changed after the account was added to the model.
1332 That's a tinymail bug but not one that I want to fix now.
1334 This finally fixes projects.maemo.org bug NB#59301.
1336 2007-06-27 Armin Burgmeier <armin@openismus.com>
1338 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1341 2007-06-27 Murray Cumming <murrayc@murrayc.com
1343 * src/modest-tny-account.h:
1344 * src/modest-tny-account.c:
1345 Added modest_tny_account_get_mmc_account_name(), to set the memory
1346 card name asynchronously for the given account and then notify.
1347 (modest_tny_account_new_for_local_folders): Use this new function instead
1348 of using hildon_file_system_info_async_new() directly.
1350 * src/widgets/modest-folder-view.c: (text_cell_data):
1351 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1352 gtk_tree_model_row_changed() when it is available.
1354 This should fix projects.maemo.org bug NB#59301.
1356 2007-06-27 Murray Cumming <murrayc@murrayc.com
1358 * src/modest-mail-operation.c: (update_account_thread),
1359 (get_msgs_full_thread): Fix typo failures in the revert
1362 2007-06-27 Murray Cumming <murrayc@murrayc.com
1364 * src/maemo/modest-maemo-global-settings-dialog.c:
1365 (idle_select_default_focus):
1366 * src/modest-mail-operation.c: (idle_notify_progress),
1367 (idle_notify_progress_once), (set_last_updated_idle),
1368 (update_account_thread), (get_msgs_full_thread):
1369 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1370 * src/widgets/modest-header-view.c:
1371 (idle_notify_headers_count_changed_destroy),
1372 (idle_notify_headers_count_changed):
1373 Reverted the additions of gdk_threads_enter/leave(), in case this
1374 helps with a startup hang on the device.
1376 2007-06-26 Armin Burgmeier <armin@openismus.com>
1378 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1379 for supported secure authentication methods from server by
1380 gtk_dialog_run(), saving CPU time and a potential race condition.
1382 2007-06-26 Armin Burgmeier <armin@openismus.com>
1384 * src/maemo/modest-maemo-utils.h:
1385 * src/maemo/modest-maemo-utils.c: Added a
1386 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1387 only error code to tell the calling code when the user canceled the
1390 * src/maemo/modest-account-settings-dialog.h:
1391 * src/maemo/modest-account-settings-dialog.c:
1392 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1393 message if the retrieval of secure authentication methods was canceled
1394 by the user. Perform the check before saving anything to configuration
1395 to not end up with half-committed configuration changes, do not show
1396 a "Saving to configuration failed" note when authentication methods
1397 could not be retrieved.
1399 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1402 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1404 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1405 Only return the first level of folders under accounts, because the
1406 osso-global-search UI spec doesn't want the rest.
1407 This fixed projects.maemo.org bug NB#61811.
1409 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1411 * src/modest-tny-account-store.c:
1412 * src/modest-tny-account-store.h:
1413 Added modest_tny_account_is_memory_card_account().
1414 * src/maemo/modest-main-window.c: (create_details_widget):
1415 Show the same information items for the memory card as we show for the
1416 local-folders, to fix projects.maemo.org bug NB#59307.
1418 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1420 * src/modest-tny-account-store.c: (get_password):
1421 Added some checks for NULL to maybe prevent crashes, though I think
1422 it was Philip's last commit that actually prevented the crash here
1423 when creating a first new account.
1424 But the new account is still not usable (no messages are shown)
1425 until a restart of the application.
1427 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1429 * src/maemo/modest-maemo-global-settings-dialog.c:
1430 (idle_select_default_focus):
1431 * src/modest-mail-operation.c: (idle_notify_progress),
1432 (idle_notify_progress_once), (idle_notify_update_account_queue),
1433 (set_last_updated_idle), (update_account_thread),
1434 (notify_get_msgs_full), (get_msgs_full_destroyer),
1435 (get_msgs_full_thread):
1436 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1437 * src/widgets/modest-header-view.c:
1438 (idle_notify_headers_count_changed_destroy),
1439 (idle_notify_headers_count_changed):
1440 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1441 all idle handlers, because some other thread could be blocking
1442 the GDK lock, so that it can do GUI stuff.
1444 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1446 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1447 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1448 (on_idle_send_receive), (on_idle_open_default_inbox):
1449 * src/maemo/modest-msg-edit-window.c:
1450 (modest_msg_edit_window_attach_file_noninteractive):
1451 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1452 to prevent a hang. I don't quite understand why these are necessary,
1453 beause we should already be in the main loop. I guess something outside
1454 of the main loop is taking the lock.
1456 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1457 we are really using URIs, and use files that are more likely to exist.
1459 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1461 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1462 necessary because configure.ac now defines different variables.
1464 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1466 * libmodest-dbus-client/libmodest-dbus-client.c:
1467 * libmodest-dbus-client/libmodest-dbus-client.h:
1468 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1469 libmodest_dbus_client_compose_mail() is what things actually use.
1471 * src/dbus_api/modest-dbus-api.h:
1472 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1473 * tests/dbus_api/Makefile.am:
1474 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1477 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1479 * src/modest-init.c: (modest_init_local_folders):
1480 For memory-card (or other non local-folders) maildir accounts,
1481 always create an Archive folder, so that there is somewhere to put
1482 messages. This should be less confusing, because the user does not need
1483 to guess that the need to create a folder.
1485 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1487 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1488 Fixed icon size by using (50, 50) which is the same as defined by
1491 2007-06-25 Armin Burgmeier <armin@openismus.com>
1493 * src/widgets/modest-window-mgr.c:
1494 * src/modest-init.c:
1495 * configure.ac: Correctly recognize hildon-notify presence and fixed
1496 the build without it being installed.
1498 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1500 * libmodest-dbus-client/libmodest-dbus-client.c:
1501 (libmodest_dbus_client_search): Fix the build. Sorry.
1502 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1503 (reply_forward_cb): Initialize variables to fix the build.
1505 * src/modest-tny-account-store.c:
1506 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1507 comparison (a silly typo) so that email search results can be opened
1508 when there are more than one account.
1510 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1512 * libmodest-dbus-client/libmodest-dbus-client.c:
1513 (libmodest_dbus_client_search),
1514 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1515 instead of 1 second, because the search gets folders and messages from
1516 the server, which can take a long time. When it times out,
1517 osso-global-search will report no results.
1519 We need to specify whether we should search only cached information
1520 (maybe with a user preference), and the osso-email-search-plugin
1521 API should really be improved to allow that option, and to allow results
1522 to be delivered asynchronously in batches.
1524 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1526 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1527 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1528 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1530 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1532 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1533 that is an empty string. D-Bus seems to give us these instead of NULL.
1535 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1537 * src/dbus_api/modest-dbus-callbacks.c:
1538 * src/maemo/easysetup/modest-easysetup-wizard.h:
1539 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1540 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1541 (modest_connection_specific_smtp_edit_window_init):
1542 * src/maemo/modest-maemo-global-settings-dialog.c:
1544 * src/maemo/modest-maemo-utils.c:
1545 (modest_maemo_utils_setup_images_filechooser):
1546 * src/maemo/modest-main-window.c: (create_details_widget):
1547 * src/maemo/modest-msg-edit-window.c:
1548 (modest_msg_edit_window_attach_file_noninteractive),
1549 (modest_msg_edit_window_color_button_change),
1550 (modest_msg_edit_window_set_zoom):
1551 * src/modest-mail-operation.c: (update_account_thread):
1552 * src/modest-tny-account-store.c:
1553 * src/modest-tny-account.c:
1554 * src/widgets/modest-global-settings-dialog.c:
1555 * src/widgets/modest-window.h:
1557 Fixed build on bora!
1559 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1561 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1562 * src/modest-search.c: (modest_search_folder),
1563 (modest_search_all_accounts): Actually search only in the specified folder,
1564 doing a simple match on the folder ID.
1565 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1566 and added some documentation.
1568 2007-06-22 Armin Burgmeier <armin@openismus.com>
1570 * src/maemo/modest-maemo-utils.h:
1571 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1572 modest_maemo_utils_get_supported_secure_authentication_methods.
1574 * src/maemo/easysetup/modest-easysetup-wizard.c:
1575 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1576 one occured, not just "Server does not support secure authentication".
1578 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1580 * src/modest-tny-account-store.c: (get_password):
1581 Restored the call to tny_account_set_user() because Philip seems to have
1582 stopped this from crashing (by not using the freed string). It still does
1583 not work, but now we can test it.
1585 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1587 * src/maemo/modest-msg-edit-window.c: (init_window):
1588 Comment out use of an uninitialzed GtkScrolledWindow variable,
1589 to fix the build and stop a crash. Yet again.
1591 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1593 * src/modest-tny-account-store.c: (get_password):
1594 Remove the call to tny_account_set_user() because this actually crashes.
1595 As mentioned in the last commit, it is known to not work anyway.
1597 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1599 * src/modest-tny-account-store.c: (get_password):
1600 Use tny_account_set_username() to tell tinymail that the username might
1601 have changed too. But tinymail ignores this: see projects.maemo.org
1603 * src/modest-ui-actions.c:
1604 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1605 reset the connection when changing the username, and improve the comments.
1606 Save the changed username to gconf at least, so it is used when Modest is
1609 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1611 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1612 Do not use a query, so that we get all folders, including for POP and
1613 local-folders. They work as search criteria too.
1614 This fixes projects.maemo.org bug NB#57740.
1616 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1618 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1619 Comment out the use of hildon_notification_set_sound() because it is
1620 not declared, to fix the build. Warnings are serious, people.
1622 2007-06-21 Armin Burgmeier <armin@openismus.com>
1624 * src/maemo/modest-maemo-utils.h:
1625 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1626 modest_maemo_utils_get_supported_secure_authentication_methods()
1627 to query authentication methods for a specific user. This should fix
1628 projects.maemo.org bug NB#61369.
1630 * src/maemo/easysetup/modest-easysetup-wizard.c:
1631 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1634 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1636 * libmodest-dbus-client/libmodest-dbus-client.h:
1637 * libmodest-dbus-client/libmodest-dbus-client.c:
1638 (modest_dbus_message_iter_get_search_hit),
1639 (libmodest_dbus_client_search):
1640 Reorganised and commented this.
1641 Removed modest_search_hit_free() from the public API because it
1644 Added libmodest_dbus_client_get_folders() and
1645 modest_folder_result_list_free().
1647 * src/dbus_api/modest-dbus-api.h:
1648 * src/dbus_api/modest-dbus-callbacks.c:
1649 (modest_dbus_req_filter): Commented. Moved most code to
1650 on_dbus_method_search() and added on_dbus_method_get_folders().
1652 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1653 of the extra D-Bus handler.
1655 * tests/dbus_api/Makefile.am:
1656 * tests/dbus_api/test_get_folders.c: New test for
1657 libmodest_dbus_client_get_folders(). This seems to return an empty list
1658 at the moment. That could be the same error that causes the message list
1659 to be empty sometimes.
1660 This should help with projects.maemo.org bug NB#57740.
1662 2007-06-21 Armin Burgmeier <armin@openismus.com>
1664 * src/modest-mail-operation.c: Do not call
1665 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1666 notify the operation's end after having set the status to CANCELED for
1667 the operation queue to listen on. This fixes a deadlock when there
1668 were mail operations in the queue during its finalization.
1670 * src/modest-singletons.c: Reordered uninitialization of the account
1671 manager to happen after the mail operation queue was uninitialized
1672 because the mail operation's in the queue might still try to access
1673 the account manager (see modest_mail_operation_notify_end()). This
1674 fixes a potential crash when terminating the application.
1676 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1678 * src/modest-search.c:
1679 (search_mime_part_and_child_parts): Moved some code here so we
1680 can search recursively in child folders.
1681 (modest_search_folder): Search in the message as a mime part, instead
1682 of just its child mime parts.
1683 (read_chunk), (search_mime_part_ogs):
1684 Check how many bytes were read, to prevent an endless loop.
1685 Searching in message bodies now works. This finishes the fix for
1686 projects.maemo.org bug NB#61007.
1688 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1690 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1691 Add a g_warning when the item is not a folder.
1693 * src/modest-ui-dimming-rules.c:
1694 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1695 when selected item is not a folder (for instance, an account), because
1696 the UI spec only talks about folders.
1697 I am not sure what the UI spec wants, so this might not totally fix
1698 projects.maemo.org bug NB#60794.
1700 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1702 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1703 (load_from_file): Sort the list. The unsorted list would be more noticeable
1704 in non-English locales.
1706 * src/maemo/modest-msg-edit-window.c:
1707 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1708 warning and fix the build.
1710 * src/maemo/modest-progress-bar-widget.c:
1711 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1712 avoid a g_warning, and probably to avoid a crash.
1714 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1716 * src/modest-search.c: (modest_search_folder): Check for a GError
1717 when calling tny_folder_get_headers(), to show that this is not the cause
1720 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1722 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1723 Actually set the body query instead of the subject query.
1725 * src/modest-search.c: (search_mime_part_ogs),
1726 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1727 which would probably cause it to fail if we got this far.
1729 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1730 to simplify the code.
1731 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1732 be causing search-in-body to fail.
1734 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1736 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1738 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1739 Better debug message when the folder cannot be found.
1740 This should help with fixing projects.maemo.org bug #61287.
1741 * src/modest-search.c: (add_hit): Do not leak the furl string.
1743 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1745 * src/modest-ui-actions.c:
1746 (modest_ui_actions_on_folder_selection_changed):
1747 Do not special-case TNY_MERGE_FOLDER here, because
1748 modest_tny_folder_get_account() already does that. This fixes
1749 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1750 shown when the Outbox was selected).
1752 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1754 * libmodest-dbus-client/libmodest-dbus-client.c:
1755 (_dbus_iter_get_string_or_null): Initialize the string variable in
1756 case this helps with Dirk's crash.
1758 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1760 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1761 though it is not implemented yet (this function is maybe not even used),
1762 to avoid breaking ABI in future.
1763 * libmodest-dbus-client/libmodest-dbus-client.c:
1764 (get_attachments_string): Moved some code into this generic function.
1765 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1766 sends email. It is maybe not used.
1767 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1768 (on_send_mail): Use attachments.
1770 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1771 * src/maemo/modest-msg-edit-window.c:
1772 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1773 a filename before using it, to fix projects.maemo.org bug NB#58233.
1775 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1777 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1778 Initialize the continue_download variable to fix the build, and probably
1779 to fix randome behaviour.
1781 2007-06-18 Armin Burgmeier <armin@openismus.com>
1783 * src/modest-tny-send-queue.h:
1784 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1785 the queue so we can later show it in the UI. Replaced
1786 modest_tny_send_queue_msg_is_being_sent() by
1787 modest_tny_send_queue_get_msg_status().
1789 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1791 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1792 gpointer. This probably was not harmful, but just to be sure.
1794 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1796 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1797 Fix the build, but leave the function broken on Bora, because
1798 hildon_uri_action_get_service() does not exist.
1799 osso_uri_action_get_service() does not exist either, it seems.
1801 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1803 * src/modest-tny-account.c:
1804 (modest_tny_account_new_from_server_account):
1805 Uncommented the url debug output again, because it is useful for
1806 debugging, as I said in the comment.
1808 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1810 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1812 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1813 for Mameo Bora, to fix the build.
1815 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1818 Fixed build with hildon < 0.99
1820 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1821 Check if the selected account is busy instead of checking all accounts
1823 * src/modest-account-mgr-priv.h:
1824 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1825 (modest_account_mgr_init), (compare_account_name),
1826 (modest_account_mgr_set_account_busy),
1827 (modest_account_mgr_account_is_busy):
1828 * src/modest-account-mgr.h:
1829 Added busy information to the account manager. It possible to
1830 set an account to busy or not busy now.
1832 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1833 (modest_mail_operation_update_account),
1834 (modest_mail_operation_notify_end):
1835 Set the account to busy/not busy depending on the operation state.
1837 * src/widgets/modest-account-view.c:
1838 (modest_account_view_finalize), (get_last_updated_string),
1839 (update_account_view), (on_account_busy_changed), (init_view):
1840 Show string "Refreshing..." if the account is currently busy.
1842 All this fixes projects.maemo.org bug NB#59711
1844 2007-06-14 Armin Burgmeier <armin@openismus.com>
1846 * src/widgets/modest-attachments-view.h:
1847 * src/widgets/modest-attachments-view.c: Added
1848 modest_attachments_view_has_attachments() and fixed coordinate
1849 transformation in get_att_view_at_coords(). This fixes attachment
1852 * src/widgets/modest-msg-view.c: Make use of
1853 modest_attachments_view_has_attachments() to decide whether to show
1854 attachments in the header.
1856 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1858 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1859 (on_change), (on_combo_security_changed),
1860 (modest_connection_specific_smtp_edit_window_init),
1861 (modest_connection_specific_smtp_edit_window_set_connection),
1862 (modest_connection_specific_smtp_edit_window_is_dirty):
1863 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1864 * src/maemo/modest-connection-specific-smtp-window.c:
1867 Show an comfirmation dialog for the smpt-edit-window if there are
1868 unsaved changes and the user hits cancel.
1869 (projects.maemo.org bug NB#60479)
1871 2007-06-14 Armin Burgmeier <armin@openismus.com>
1873 * src/maemo/easysetup/modest-easysetup-wizard.c:
1874 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1875 address" info in banner instead of node, and select all the text as
1876 per UI spec. This fixes projects.maemo.org bug NB#60550.
1878 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1880 reviewed by: <delete if not using a buddy>
1882 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1883 * src/modest-ui-actions.c: (folder_refreshed_cb):
1885 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1887 * src/widgets/modest-folder-view.c: (filter_row):
1888 Explictly filter out the per-account outbox accounts. I don't know why
1889 these only sometimes show up, but now they should never show up in the UI.
1890 This should fix projects.maemo.org bug NB#60160.
1892 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1894 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1895 when the toolbar does not exist yet.
1896 * src/modest-widget-memory.c: (save_settings_header_view):
1897 Added g_warnings() to help us to discover when we are trying to set
1898 an empty columns list in gconf.
1900 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1902 * src/modest-init.h:
1903 * src/modest-init.c:
1904 Added modest_init_get_default_header_view_column_ids().
1906 * src/modest-widget-memory.c: (restore_settings_header_view):
1907 Use the new function to get defaults, if the gconf key is empty,
1908 instead of not creating any columns. This seems to fix the
1909 empty right-hand pane problems.
1911 * src/widgets/modest-header-view.h: Improved documentation.
1913 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1915 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1916 Revert the use of the display name as the account name, because this
1917 is generally wrong and would break the code that follows.
1919 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1921 * src/maemo/easysetup/modest-easysetup-wizard.c:
1922 (check_for_supported_auth_methods), (on_before_next),
1925 More correct fix for projects.maemo.org bug NB# 58991
1926 Do not longer accept AUTH_PASSWORD as secure method and choose
1927 correct method when creating the account.
1929 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1931 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1932 Fixed projects.maemo.org bug NB# 58991
1934 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1936 * src/modest-init.c: (modest_init_init_core),
1937 (modest_init_local_folders): Fixed compilation errors.
1939 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1941 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1942 Remove unnecessary lib/include, though it is good in principle when needed.
1944 * src/modest-init.c: (modest_init_one_local_folder),
1945 (modest_init_local_folders):
1946 * src/modest-init.h: Initialize the .modest library for memory cards,
1947 instead of just doing nothing for them. This should allow us to create
1948 folders there, fixing projects.maemo.org bug NB#59297.
1950 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1952 * libmodest-dbus-client/libmodest-dbus-client.c:
1953 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1954 (libmodest_dbus_client_compose_mail),
1955 (libmodest_dbus_client_open_message),
1956 (libmodest_dbus_client_send_and_receive),
1957 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1959 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1960 (on_idle_open_message), (modest_dbus_req_handler),
1961 (search_result_to_message), (modest_dbus_req_filter):
1962 * src/modest-search.c: (add_hit), (modest_search_folder),
1963 (modest_search_all_accounts): Improved debug messages.
1965 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1967 * src/modest-tny-account-store.c:
1968 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1971 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1974 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1976 * src/modest-tny-account-store.c: (get_server_accounts):
1977 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1978 even when there are no accounts, so that the Outbox folder is always
1979 visible. This fixes projects.maemo.org bug NB#60158.
1981 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1983 * src/maemo/modest-main-window.c: (create_details_widget):
1984 Use the mcen_va_never logical ID.
1986 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1988 * src/dbus_api/modest-dbus-api.h:
1989 * src/dbus_api/modest-dbus-callbacks.c:
1990 (on_idle_open_default_inbox), (on_open_default_inbox),
1991 (modest_dbus_req_handler):
1992 Added a new OpenDefaultInbox method.
1994 * libmodest-dbus-client/libmodest-dbus-client.h:
1995 * libmodest-dbus-client/libmodest-dbus-client.c:
1996 Added libmodest_dbus_client_open_default_inbox() to call the new
1997 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1998 though it should maybe be used by a new osso-email-interface function.
2000 * tests/dbus_api/Makefile.am:
2001 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2004 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2006 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2007 NULL, so that the signals get all the keys. This should not actually
2008 change any behaviour because we currently update everything when anything
2011 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2013 * src/widgets/modest-folder-view.c: (text_cell_data),
2014 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2015 (find_inbox_iter): If tinymail tells us that the folder is
2016 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2017 This causes the inbox to be selected at startup, fixing part of
2018 projects.maemo.org bug NB#56305.
2020 * src/modest-ui-dimming-rules.c:
2021 (modest_ui_dimming_rules_on_tools_smtp_servers):
2022 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2023 the SMTP servers menu item.
2024 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2025 that the SMTP Servers menu item is dimmed when there are no accounts,
2026 as a future version of the UI spec will require. This fixes
2027 projects.maemo.org bug NB#56305.
2029 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2031 * src/maemo/modest-maemo-utils.c:
2032 (modest_maemo_utils_get_supported_secure_authentication_methods):
2033 Added label to dialog instead of unreadable title
2035 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2036 (modest_main_window_new):
2037 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2040 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2041 * src/modest-account-mgr.h:
2042 Added method to avoid code duplication
2044 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2045 (modest_ui_actions_on_send_receive):
2046 Use modest_account_mgr_has_accounts
2048 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2050 * src/maemo/easysetup/modest-presets.c:
2051 (modest_presets_get_info_server_security): Do not report secure auth
2053 * src/modest-protocol-info.c: Use the defines for the gconf key names
2054 for secure authentication. This was not working because we were writing
2055 Password and reading password, and the check was case sensitive.
2056 With this, gmail now works for receiving and sending when created via
2059 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2061 * src/maemo/easysetup/modest-presets.c:
2062 (modest_presets_get_info_server_security): Correct the key name for
2063 SecureSmtp, because it seems to be case-sensitive.
2064 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2065 Do not try to get the 0th notebook page if there are 0 pages, to
2066 avoid a g_warning().
2068 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2070 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2071 Prevent use of the new notification feature for now, because it currently
2072 shows one dialog for each new email, which is annoying.
2074 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2076 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2077 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2078 when no country was selected, so that we show the global ones.
2079 * src/maemo/easysetup/modest-presets.c:
2080 (modest_presets_get_providers): Return only the global providers, not
2081 all providers when mmc=0 was requested.
2083 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2085 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2086 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2087 provider ID in the combo.
2089 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2090 Do not show the page numbers, because it would be confusing when we add
2091 the 2 extra pages for the custom setup, when the user chooses the "Other"
2092 provider. This fixes projects.maemo.org bug NB#59028
2094 * src/modest-init.c: (modest_init_init_core),
2095 (modest_init_local_folders):
2096 * src/modest-init.h:
2097 * src/modest-tny-account.c:
2098 (modest_tny_account_new_for_local_folders): Do not create default folders
2099 for the memory card. This should fix projects.maemo.org bug NB#59328.
2101 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2103 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2104 Free the changed_conf_keys string items. They are already freed in the
2105 idle handler if that runs first.
2107 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2109 * src/modest-ui-actions.c:
2110 (modest_ui_actions_on_password_requested): Check that the server name
2111 is not NULL, because I just saw a password dialog with (null) as the
2114 * src/modest-tny-folder.[h|c]: Added
2115 modest_tny_folder_is_memory_card_folder().
2116 * src/modest-ui-dimming-rules.c:
2117 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2118 menu item for memory cards, as per the UI spec (section 7.4). This should
2119 fix projects.maemo.org bug NB#59297.
2121 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2123 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2124 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2125 is another problem with the code, see Murray's comment at line 772)
2127 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2129 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2130 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2131 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2132 (load_from_file), (easysetup_country_combo_box_init),
2133 (easysetup_country_combo_box_get_active_country_ids),
2134 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2135 instead of just one ID, to avoid duplicate country names in the UI.
2137 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2138 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2139 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2140 a single ID, avoiding duplicate providers.
2141 * src/maemo/easysetup/modest-easysetup-wizard.c:
2142 (on_combo_account_country): Adapt to use a list.
2144 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2146 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2147 keys changed in the last X seconds.
2149 * src/modest-account-mgr.h:
2150 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2151 (on_key_change), (modest_account_mgr_class_init),
2152 (modest_account_mgr_init), (modest_account_mgr_finalize):
2153 As the keys are changed, save them in a GSList* and signal that GSList*
2154 further every X seconds, to batch changes, to allow us to do just one
2155 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2156 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2158 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2159 changed signal signature.
2161 * src/modest-conf.c: (modest_conf_set_list),
2162 (modest_conf_on_change): Reenable notification.
2164 (modest_conf_maemo_fake_on_change): Comment out the hack that
2165 notified immediately instead of asynchronously.
2167 * src/widgets/modest-account-view.h:
2168 * src/widgets/modest-account-view.c:
2169 (update_account_view): Select the previously-selected account ID,
2170 if possible. This fixes projects.maemo.org bug NB#56933.
2172 (on_account_changed), (on_account_removed),
2173 (modest_account_view_select_account):
2175 Remove the block/unblock functions
2176 because they were not useful.
2178 * src/maemo/modest-account-view-window.c:
2179 (on_delete_button_clicked), (on_edit_button_clicked),
2180 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2182 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2184 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2185 Improve the error dialog to show Incorrect Account Settings, which seems
2186 clearer, and say that the internal error message (to be removed from the
2187 dialog later) is often misleading.
2188 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2190 * src/modest-tny-account.c:
2191 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2192 URL because this is so useful for debugging on the device.
2194 * src/widgets/modest-serversecurity-combo-box.c:
2195 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2197 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2199 * src/modest-mail-operation.c:
2200 (modest_mail_operation_send_new_mail):
2201 Added a comment about a nasty but apparently harmless message. Details
2202 added to the wiki g_warnings() page.
2204 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2206 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2207 (modest_tny_send_queue_class_init):
2208 Do not use the priv struct because it is empty, to avoid g_warnings
2209 about a non-existant priv struct.
2211 * src/modest-tny-account-store.c:
2212 (modest_tny_account_store_get_server_account),
2213 (modest_tny_account_store_get_transport_account_for_open_connection
2214 ): Do not try to get transport server accounts for local folders,
2215 because they don't have any. This avoids a g_warning().
2217 * src/maemo/modest-main-window.c:
2218 (modest_main_window_notify_send_receive_initied),
2219 (on_configuration_key_changed):
2220 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2221 * src/modest-defs.h:
2222 * src/modest-mail-operation.c:
2223 (modest_mail_operation_update_account):
2224 * src/modest-tny-account-store.h:
2225 * src/modest-tny-account.c:
2226 (modest_tny_account_get_special_folder),
2227 (modest_tny_account_new_for_local_folders),
2228 (modest_tny_account_new_for_per_account_local_outbox_folder):
2229 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2230 * src/modest-tny-local-folders-account.c:
2231 (add_account_folders_to_merged_folder):
2232 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2233 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2234 (modest_ui_actions_on_send):
2235 * src/widgets/modest-folder-view.c: (update_model):
2236 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2237 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2238 modest_tny_account_store_get_tny_account_by_account() to
2239 modest_tny_account_store_get_server_account() to make the code clearer.
2241 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2243 * src/dbus_api/modest-dbus-api.h:
2244 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2245 * src/maemo/modest-msg-edit-window.c:
2246 (modest_msg_edit_window_attach_file_noninteractive):
2247 added g_warning in case the file to be attached does not exist
2248 * tests/dbus_api/test_compose_mail.c: (main):
2249 removed obsolete comment, added generic files as test case
2251 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2253 * src/modest-tny-account-store.c: (get_server_accounts):
2254 Create the local folders account only once, not once for each outbox, and
2255 not only when there are some outboxes.
2257 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2259 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2260 code that is causing a crash at startup. Sergio says that he is fixing this.
2262 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2264 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2265 * src/maemo/modest-account-settings-dialog.c:
2266 (create_page_outgoing),
2267 (modest_account_settings_dialog_set_account_name),
2268 (save_configuration):
2269 - Fixed handling of the "Use secure authentication" toggle to comply with
2270 the ui specification. See also projects.maemo.org bug NB#58400
2272 - Restore the Secure connection setting combo correctly when loading
2275 * src/maemo/modest-maemo-utils.c:
2276 (on_camel_account_get_supported_secure_authentication),
2277 (modest_maemo_utils_get_supported_secure_authentication_methods):
2278 Fixed a crasher if operation is canceled
2280 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2281 (modest_protocol_info_auth_is_secure):
2282 * src/modest-protocol-info.h:
2284 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2285 the sense of the "Use secure authentication" toggle.
2287 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2289 * src/modest-tny-account-store.h:
2290 * src/modest-tny-account-store.c:
2291 Added modest_tny_account_store_get_local_folders_account().
2293 * src/modest-tny-folder.h:
2294 * src/modest-tny-folder.c:
2295 (modest_tny_folder_get_account):
2296 Added this replacement for tny_folder_get_account() which returns
2297 the local-folders account for TnyMergeFolders, to avoid the
2298 warning about the unimplemented get_account_func() vfunc().
2300 (modest_tny_folder_get_rules),
2301 * src/modest-ui-actions.c:
2302 (modest_ui_actions_on_folder_selection_changed):
2303 * src/modest-mail-operation.c:
2304 (modest_mail_operation_remove_folder),
2305 (modest_mail_operation_xfer_folder),
2306 (modest_mail_operation_rename_folder),
2307 (modest_mail_operation_get_msg),
2308 (modest_mail_operation_get_msgs_full),
2309 (modest_mail_operation_remove_msg),
2310 (modest_mail_operation_xfer_msgs),
2311 (modest_mail_operation_refresh_folder):
2312 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2314 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2316 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2317 (modest_server_account_set_security):
2318 * src/modest-defs.h: Add comments explaining that our
2319 UI spec means TLS when it says Normal, so these do not look like errors.
2321 * src/modest-tny-account.c:
2322 (modest_tny_account_new_from_server_account): Use the new tinymail
2323 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2324 for TLS. This should fix projects.maemo.org bug NB#58460.
2326 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2328 * src/maemo/easysetup/modest-easysetup-wizard.c:
2329 (create_account): Correct the position of the gconf sanity check warning.
2330 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2331 of using the g_idle_add() hack, because this does not seem to be necessary
2332 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2333 caused by something other than maemo's gconf.
2334 This fixes projects.maemo.org bug #59022.
2336 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2338 * src/modest-account-mgr-helpers.c:
2339 (modest_account_mgr_get_default_account): Do not check that the account
2340 exists if there is no default account (NULL), to fix a runtime warning.
2342 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2344 * src/widgets/modest-folder-view.c: (update_model):
2345 Do not unref the treemodel before we have finished with it.
2346 This prevents a valgrind warning and an occasional crash at startup.
2348 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2350 * libmodest-dbus-client/libmodest-dbus-client.h:
2351 added libmodest_dbus_client_compose_mail()
2352 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2354 added functions needed for SendAsMail() functionality
2355 * src/maemo/modest-msg-edit-window.c:
2356 (modest_msg_edit_window_attach_file_noninteractive):
2357 non interactively attaching files to message edit window
2358 * src/widgets/modest-msg-edit-window.h:
2359 * tests/dbus_api/Makefile.am:
2360 added test_compose_mail.c
2361 * tests/dbus_api/test_compose_mail.c: (main):
2363 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2365 * src/modest-account-view.c:
2366 Fixed bug projects.maemo.org bug NB#59307
2368 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2370 * src/maemo/easysetup/modest-easysetup-wizard.c:
2371 (get_serverport_incoming), (on_before_next), (create_account):
2372 * src/maemo/modest-account-settings-dialog.c:
2373 (modest_account_settings_dialog_set_account_name):
2374 * src/maemo/modest-maemo-utils.c:
2375 (on_camel_account_get_supported_secure_authentication_status),
2376 (on_camel_account_get_supported_secure_authentication),
2377 (on_secure_auth_cancel),
2378 (modest_maemo_utils_get_supported_secure_authentication_methods):
2380 Implemented security authentication for settings and easysetup.
2382 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2384 * src/maemo/modest-main-window.c: (create_details_widget):
2385 Show the total size for memory card accounts too, instead of showing
2386 the name again. Fixes bug projects.maemo.org bug NB#59307.
2388 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2391 * src/modest-tny-simple-folder-store.c:
2392 * src/modest-tny-simple-folder-store.h: Removed.
2394 * src/modest-tny-local-folders-account.h
2395 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2396 for the local-folders maildir, with an extra TnyMergedFolder containing
2397 the folders of the per-account outbox store accounts.
2398 * src/modest-tny-account-store.c: (get_server_accounts):
2399 Add the outboxes to the special local folders account after creating it.
2401 * src/modest-tny-account.c:
2402 (modest_tny_account_new_for_local_folders): Create the derived
2403 account when creating the main local-folders account.
2405 * src/maemo/modest-main-window.c: (create_details_widget),
2406 (modest_main_window_set_contents_style):
2407 Adapted to the use of the derived account instead of the folder store.
2409 * src/modest-ui-actions.c:
2410 (modest_ui_actions_on_folder_selection_changed):
2411 * src/modest-ui-dimming-rules.c:
2412 (modest_ui_dimming_rules_on_new_folder):
2413 * src/widgets/modest-folder-view.c: (text_cell_data),
2414 (icon_cell_data), (filter_row), (update_model),
2415 (get_cmp_rows_type_pos):
2418 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2419 Do not get the priv struct, because no priv struct has been set,
2420 to avoid a runtime warning.
2422 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2423 #ifelse with #else, to fix a warning, to fix the build.
2426 2007-06-05 Christian Kellner <ckellner@openismus.com>
2428 * libmodest-dbus-client/libmodest-dbus-client.c:
2429 Fix small typo in doc (why do you always see them
2430 AFTER committing stuff?)
2433 2007-06-05 Christian Kellner <ckellner@openismus.com>
2435 * libmodest-dbus-client/libmodest-dbus-client.c:
2436 (libmodest_dbus_client_search):
2437 Initialize hit list with NULL. Also set folder list
2438 to "" if NULL was supplied.
2441 2007-06-03 Christian Kellner <ckellner@openismus.com>
2443 * libmodest-dbus-client/libmodest-dbus-client.c:
2444 (modest_search_hit_list_free):
2445 Make it save to call it with NULL.
2447 * src/dbus_api/modest-dbus-callbacks.c:
2448 * src/modest-search.c:
2449 Return full ModestSearchHits as the search result list not TnyHeader
2450 since can't be around withouth the correspoding TnyFolder.
2452 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2454 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2455 Added currently commented code to check for secure auth
2457 * src/maemo/modest-account-settings-dialog.c: (on_response),
2458 (save_configuration), (show_ok):
2459 Fixed projects.maemo.org bugs NB #59248 and #59251
2461 * src/maemo/modest-maemo-utils.c:
2462 (on_camel_account_get_supported_secure_authentication_status),
2463 (on_camel_account_get_supported_secure_authentication),
2464 (modest_maemo_utils_get_supported_secure_authentication_methods):
2465 * src/maemo/modest-maemo-utils.h:
2466 Moved get_supported_secure_authentication() method here to be able
2467 to use it from easysetup wizard.
2469 * src/modest-pair.c: (on_pair_compare_as_string):
2470 Should compare string with first part of pair and not
2471 strcmp pairs which will crash.
2473 * src/modest-protocol-info.c:
2474 (modest_protocol_info_protocol_is_store):
2475 * src/modest-protocol-info.h:
2476 Added modest_protocol_info_get_auth_protocol_name()
2478 2007-06-03 Armin Burgmeier <armin@openismus.com>
2480 * src/modest-mail-operation.c:
2481 (modest_mail_operation_get_msgs_full): Set priv->account also when
2482 only retrieving a single message. This avoids a crash when canceling
2485 (modest_mail_operation_notify_end): Do not explicitely remove the
2486 operation from the queue but only emit the progress_changed signal.
2487 The queue itself listens to that signal to remove the operation when
2488 it is finished. This reduces coupling and removes a potential deadlock
2489 when modest_mail_operation_notify_end() is called from the queue
2490 itself. If that is a problem performance-wise, I would suggest to
2491 implement a status-changed signal or something.
2493 * src/modest-mail-operation-queue.c: Make sure to never call a
2494 function from another file while the queue is locked. This (hopefully)
2495 fixes another deadlock when exiting the application while retrieving
2498 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2500 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2501 Fixed build if libogs is not available
2503 2007-06-03 Christian Kellner <ckellner@openismus.com>
2505 * libmodest-dbus-client/libmodest-dbus-client.h:
2506 * libmodest-dbus-client/libmodest-dbus-client.c:
2507 (libmodest_dbus_client_delete_message):
2508 Implement deletion of messages (Client side).
2510 (modest_search_hit_free),
2511 (modest_search_hit_list_free):
2512 Utility functions to free the result hits.
2514 * src/dbus_api/modest-dbus-api.h:
2515 * src/dbus_api/modest-dbus-callbacks.c:
2516 (on_delete_message),
2517 (modest_dbus_req_handler):
2518 Implement deletion of messages (Server side).
2520 * tests/dbus_api/test_search.c: (main):
2523 * tests/dbus_api/Makefile.am:
2524 * tests/dbus_api/test_delete_message:
2525 Add little test for the message deletion logic
2527 2007-06-03 Armin Burgmeier <armin@openismus.com>
2529 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2530 when the operation queue was not empty. projects.maemo.org bug
2533 2007-06-03 Armin Burgmeier <armin@openismus.com>
2535 * src/widgets/modest-account-view.c
2536 (on_account_default_toggled): Toggle default account column
2537 explicitely instead of waiting for gconf notification (which is
2538 currently ignored). This should fix projects.maemo.org bug NB#56910
2539 for now. It should probably be removed when gconf notifications are
2542 2007-06-03 Christian Kellner <ckellner@openismus.com>
2544 * libmodest-dbus-client/libmodest-dbus-client.c:
2545 Removed debugging spew.
2547 * src/dbus_api/modest-dbus-callbacks.c:
2548 Added debugging info.
2550 * src/modest-search.c:
2551 (modest_search_all_accounts):
2552 Use tny_account_store_get_accounts () on the account store
2553 to get all accounts which is the way to get all accounts.
2555 * tests/dbus_api/test_search.c: (main):
2556 Make it possible to supply the search term on the command line.
2558 2007-06-03 Christian Kellner <ckellner@openismus.com>
2560 * libmodest-dbus-client/libmodest-dbus-client.c:
2561 * libmodest-dbus-client/libmodest-dbus-client.h:
2562 Implement searching for mesages over raw dbus. (Client side)
2564 * src/dbus_api/Makefile.am:
2565 * src/dbus_api/modest-dbus-api.h:
2566 * src/dbus_api/modest-dbus-callbacks.c:
2567 * src/dbus_api/modest-dbus-callbacks.h:
2568 Search framework (Server side). Also implement on_idle_open_message().
2570 * src/maemo/modest-platform.c: (modest_platform_init):
2571 Prepare for raw dbus/osso rpc interaction.
2573 * src/modest-search.h:
2574 Changed minsize from unspecific guint to guint32.
2576 * src/modest-search.c:
2578 Added strange hack which magically made tnymail work.
2580 (modest_search_folder),
2581 (modest_search_account),
2582 (modest_search_all_accounts):
2583 Implement helper functions to search all accounts, specific account
2586 * tests/dbus_api/Makefile.am:
2587 * tests/dbus_api/test_open_message.c:
2588 Read url to open from commandline.
2590 * tests/dbus_api/test_search.c:
2591 Implement small test for dbus search stuff
2593 2007-06-02 Armin Burgmeier <armin@openismus.com>
2595 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2596 include account type and account title. This fixes projects.maemo.org
2599 * src/maemo/modest-account-view-window.c: Set a title for the window.
2601 2007-06-02 Armin Burgmeier <armin@openismus.com>
2603 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2604 incoming and outgoing server name based on email address and server
2605 types as long as the names have not been edited manually. This fixes
2606 projects.maemo.org bug NB#58671.
2608 2007-06-02 Armin Burgmeier <armin@openismus.com>
2610 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2611 server type cannot be changed in future to the incoming details page
2612 when creating an account. This fixes projects.maemo.org bug NB#59029.
2614 2007-06-02 Armin Burgmeier <armin@openismus.com>
2616 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2617 and assigned max width chars so that they wrap instead of being
2618 truncated. Fixes projects.maemo.org bug NB#56126.
2620 2007-06-02 Armin Burgmeier <armin@openismus.com>
2622 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2623 introductory note to the connection specific smtp servers dialog, as
2624 section 8.12 of the email UI specification requires. This fixes
2625 projects.maemo.org bug NB#59212.
2627 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2629 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2630 Check for running mail operations, and offer to cancel them, as per the UI
2631 spec. This fixes projects.maemo.org bug NB#59041 .
2632 However, I suspect that tinymail may still use the network connection
2633 in ways that we cannot detect or cancel. But it should at least adapt to
2634 changes fairly well.
2636 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2638 * src/modest-tny-account-store.c: (recreate_all_accounts),
2639 (get_cached_accounts), (get_server_accounts): Do more sensible
2640 ref-counting of the temporarily-cached outbox accounts list. This seems
2641 to fix a crash when entering the password when the password was wrong.
2643 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2645 * src/gnome/modest-main-window.c: (connect_signals):
2646 * src/modest-tny-account-store.c: (get_password),
2647 (modest_tny_account_store_alert): Added comments and clues and
2648 commented-out code about how we currently fail to deal with connection
2649 errors and wrong passwords, and how we should.
2651 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2653 * src/widgets/modest-retrieve-combo-box.c:
2654 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2655 This fixes projects.maemo.org bug NB#58472 .
2657 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/easysetup/modest-easysetup-wizard.c:
2660 (create_page_complete_easysetup):
2661 (create_page_complete_custom): Correct the last commit,
2662 putting the correct sentences in the correct pages.
2664 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2666 * src/maemo/easysetup/modest-easysetup-wizard.c:
2667 (create_page_complete_custom): Show the second sentence of text
2668 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2671 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2673 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2674 Set the leave-on-server conf key by default. This fixes
2675 projects.maemo.org bug NB#59258 .
2677 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2679 * src/maemo/modest-account-view-window.c:
2680 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2681 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2684 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2686 * src/maemo/easysetup/modest-easysetup-wizard.c:
2687 (create_caption_new_with_asterisk):
2688 * src/maemo/modest-account-settings-dialog.c:
2689 (create_caption_new_with_asterisk):
2690 Uncomment the code to add the asterisk, because they are no longer in the
2691 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2692 (update_incoming_server_title): Add an asterisk here too.
2694 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2696 * src/maemo/modest-maemo-global-settings-dialog.c:
2697 (current_connection): Check that we are even connected before trying to
2698 get the current connection name, to prevent a warning.
2700 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2701 Change the comments because tny_maemo_conic_device_connect() is now meant to
2703 * src/modest-mail-operation.c:
2704 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2705 make sure we have a connection and fail if we can't connect.
2707 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2709 * src/maemo/modest-main-window.c:
2710 (on_account_store_connecting_finished): Do not try to get the
2711 connection ID if we are not really connected. I am surprised that
2712 this signal handler is called when we are not connected.
2714 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2716 * src/modest-error.h:
2717 * src/modest-ui-actions.c:
2718 (modest_ui_actions_get_msgs_full_error_handler):
2719 Renamed an enum, added comments, added an enum
2720 for retrieve-limit errors.
2722 * src/modest-mail-operation.c: (foreach_add_item),
2723 (internal_folder_observer_update), (update_account_thread),
2724 (modest_mail_operation_get_msgs_full):
2725 (modest_mail_operation_update_account),
2726 Added comments about how this works, and some code that should
2727 (but does not) check the retrieve-limit. See the TODO comment.
2729 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2731 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2732 Initialize help_id to fix the build. Warnings are good.
2734 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2736 * src/widgets/modest-hbox-cell-renderer.c:
2737 (modest_hbox_cell_renderer_append):
2738 * src/widgets/modest-vbox-cell-renderer.c:
2739 (modest_vbox_cell_renderer_append):
2740 Fix the last commit by doing an extra ref.
2742 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2744 * src/widgets/modest-hbox-cell-renderer.c:
2745 (modest_hbox_cell_renderer_append):
2746 * src/widgets/modest-vbox-cell-renderer.c:
2747 (modest_vbox_cell_renderer_append):
2748 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2749 to fix the build with Maemo Bora.
2750 However, there seems to be a remaining crash, probably due to reference
2753 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2755 * src/modest-tny-account.c:
2756 (modest_tny_account_new_for_local_folders):
2757 Use hildon_file_system_info_async_new() to get a better name for
2758 the memory card account, setting it as the account name.
2759 The timing seems to work, but this is probably
2760 not the best place to do this. See the TODO comment.
2761 * src/maemo/modest-main-window.c: (create_details_widget):
2762 * src/widgets/modest-folder-view.c: (text_cell_data):
2763 Use the tny account name instead of hardcoding a name.
2765 2007-05-30 Christian Kellner <ckellner@openismus.com>
2767 * src/modest-search.c: (modest_search):
2768 Correctly set part_search_func even if we have already parsed
2769 the query and thus a valid OgsTextSearcher object.
2771 2007-05-30 Christian Kellner <ckellner@openismus.com>
2774 Search and check for libogs.
2777 Incooparte the ogs build env.
2779 * src/modest-mime-part-search-stream.c:
2780 * src/modest-mime-part-search-stream.h:
2781 Removed since we do the real searching now in modest-search.c.
2783 * src/modest-search.c:
2784 * src/modest-search.h:
2785 Implement support for ogs. We use that if available and requested
2786 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2787 should now handle the corner case when the search term is spread
2788 across multiple reads.
2789 Also the logic in modest_search () was corrected to search all
2790 requested fields until one is found.
2792 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2794 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2796 * src/modest-init.h:
2797 * src/modest-init.c: Made modest_init_local_folders() take a
2798 path and be public so we can iniitialize maildir folders on
2801 * src/modest-local-folder-info.h:
2802 * src/modest-local-folder-info.c:
2803 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2805 * src/modest-tny-account.c:
2806 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2807 still means the standard local-folders path on the local volume.
2809 * src/modest-tny-account-store.c:
2810 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2811 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2812 all accounts when that happens.
2813 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2814 this too, so it shows up in the treeview.
2816 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2818 * src/maemo/modest-maemo-global-settings-dialog.c:
2819 (current_connection):
2820 * src/widgets/modest-global-settings-dialog.c:
2821 (current_connection_default):
2822 Use the enum values instead of 0, 1 and -1,
2823 to make the code clearer.
2825 * src/modest-account-mgr-helpers.c:
2826 (modest_account_mgr_get_connection_specific_smtp): Make this code
2829 * src/modest-runtime.h:
2830 * src/modest-runtime.c:
2831 Added modest_runtime_remove_all_send_queues().
2832 * src/maemo/modest-main-window.c:
2833 (on_account_store_connecting_finished): Recreate the send queues,
2834 using the appropriate transport accounts for this new connection.
2835 Some futher adapting might be needed if the old send queues are not
2836 automatically stopped at this point.
2838 * src/modest-tny-account-store.c: (get_server_accounts):
2839 Create the connection-specific transport accounts, so that they can
2840 be found later by their ID.
2842 * src/modest-tny-account.h:
2843 * src/modest-tny-account.c:
2844 Added modest_tny_account_new_from_server_account_name().
2845 modest_tny_account_new_from_server_account(): Do not create the
2846 send queues here, because they will be
2847 recreated anyway when the connection changes for the first time.
2849 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2851 * src/modest-local-folder-info.h:
2852 * src/modest-local-folder-info.c:
2853 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2854 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2855 tbox_folder): Take a modest account name instead of a server TnyAccount,
2856 so we can have per-modest-account rather than per-transport-account
2858 We must make sure that we change or recreate the exisitng send queues
2859 when the connection changes for connection-specific transport accounts.
2861 * src/modest-tny-account-store.c:
2862 (create_per_account_local_outbox_folders): Create outboxed per modest
2863 account, not per transport account.
2865 * src/modest-tny-account.h:
2866 * src/modest-tny-account.c:
2867 (modest_tny_account_get_special_folder): For outboxes, get the
2868 parent modest account name. The account is ignored for other folders.
2869 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2870 modest account name rather than a server TnyAccount.
2872 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2874 * src/modest-tny-account.c:
2875 (modest_tny_account_new_from_server_account):
2876 Call modest_runtime_get_send_queue() immediately after creating transport
2877 accounts, so that they start trying to send email from the outbox as soon
2878 as possible at startup. This is probably what we want.
2880 * src/modest-mail-operation.c: (update_account_thread):
2881 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2882 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2883 * src/modest-tny-send-queue.h:
2884 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2885 (modest_ui_actions_on_send):
2886 Added comments about how sending works, though it needs some more work.
2888 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2890 * src/modest-tny-account.c:
2891 (modest_tny_account_get_special_folder): Add TODO because this fails when
2892 the network is busy.
2893 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2894 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2895 Do not try to show this window when there is no active account. The UI
2896 specs does not tell us what to do in this case.
2898 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2902 * src/maemo/Makefile.am:
2903 * src/widgets/Makefile.am: Some dist fixes.
2905 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2907 * src/maemo/modest-connection-specific-smtp-window.c:
2908 (on_button_edit): Make the code clearer, to prevent a double free.
2910 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2912 * src/maemo/modest-account-settings-dialog.c:
2913 (modest_account_settings_dialog_set_account_name),
2914 Check the connection-specific smtp servers checkbox if there are any.
2916 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2917 (modest_connection_specific_smtp_edit_window_init):
2918 Start with a suitable port number.
2920 * src/modest-account-mgr-helpers.h:
2921 * src/modest-account-mgr-helpers.c: Added
2922 modest_account_mgr_get_has_connection_specific_smtp().
2924 (modest_account_mgr_set_connection_specific_smtp),
2925 (modest_account_mgr_remove_connection_specific_smtp),
2926 (modest_account_mgr_get_has_connection_specific_smtp),
2927 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2928 connection-specific smtp server accounts in the account, rather than
2929 the server account conf dir.
2931 This fixes bug projects.maemo.org bug NB#58263 .
2933 * src/modest-tny-account-store.c:
2934 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2935 if there are no server accounts yet, to prevent an infinite loop when there
2936 are no accounts. Document that one must be called before the other.
2938 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2940 * src/modest-account-mgr-helpers.c:
2941 (modest_account_mgr_get_default_account): Make sure that at least
2942 one account is always the default, if there are any enabled accounts.
2943 This is just a sanity check that shouldn't be necessary.
2945 * src/modest-account-mgr-priv.c:
2946 (_modest_account_mgr_account_from_key): Unescape the conf key to
2947 get the real account name. For instance, this is an issue if a space
2948 was in the account name, which can happen because the account name
2949 is generated from the display name.
2950 (_modest_account_mgr_get_account_keyname): Always escape the
2952 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2953 Unescape the conf keys to get the real account names.
2955 For instance, previously the is-default radio button in the accounts
2956 list was not checked for any accounts at first. This fixes that,
2957 and might fix several similar bugs.
2959 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2961 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2962 Removed some debug printfs.
2964 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2966 Modest on-disk outbox directories are now here, for instance:
2967 $HOME/.modest/outboxes/<account-id-1>/outbox
2968 $HOME/.modest/outboxes/<account-id-2>/outbox
2970 $HOME/.modest/local-folders/outbox
2971 so we can have a separate outbox for each account.
2972 But they are shown as one outbox in the GtkTreeView, by using a
2973 TnyMergeFolder in a ModestTnySimpleFolderStore.
2976 * src/modest-tny-simple-folder-store.c:
2977 * src/modest-tny-simple-folder-store.h:
2978 Added ModestTnySimpleFolderStore, used to contain folders from
2979 other folder stores, such as other accounts.
2981 * src/modest-tny-outbox-account.h:
2982 * src/modest-tny-outbox-account.c:
2983 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2984 used for the per-account local outbox folders.
2986 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2987 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2988 only use this (internally) now for the non-outbox local folders.
2990 * src/modest-init.h:
2991 * src/modest-init.c: Added modest_init_one_local_folder(), for
2992 setting up the directory structure for each local folder.
2994 * src/modest-local-folder-info.c:
2995 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2996 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2998 * src/modest-local-folder-info.h:
2999 * src/modest-tny-account-store.c: (on_account_removed),
3000 (on_account_changed), (create_per_account_local_outbox_folders),
3001 (get_server_accounts), (modest_tny_account_store_get_accounts),
3002 (modest_tny_account_store_get_tny_account_by_account),
3003 (modest_tny_folder_store_is_virtual_local_folders):
3005 * src/modest-tny-account.h:
3006 * src/modest-tny-account.c:
3007 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3008 to create an on-disk per-account local outbox folder for each
3010 (create_per_account_local_outbox_folders): Create a local outbox folder
3011 for each transport account.
3012 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3013 for all local folders.
3015 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3016 instead of using g_object_get/set() directly. It is clearer.
3018 (modest_tny_folder_store_get_message_count),
3019 (modest_tny_folder_store_get_local_size
3020 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3021 because we now use these with non-acount folder stores.
3023 (modest_tny_account_get_special_folder),
3024 (modest_tny_account_new_from_server_account),
3025 (modest_tny_account_new_from_account):
3026 (recurse_folders): Adjust to the new outbox system.
3028 * src/modest-tny-folder.h:
3029 * src/modest-tny-folder.c:
3030 (modest_tny_folder_is_local_folder),
3031 (modest_tny_folder_get_local_folder_type),
3032 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3034 * src/widgets/modest-main-window.h:
3035 * src/maemo/modest-main-window.c: (create_details_widget),
3036 (modest_main_window_set_contents_style): Show details for any folder store,
3039 (modest_tny_folder_get_rules):
3040 Remove the const. C does not support constness enough for this.
3042 * src/modest-ui-actions.c:
3043 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3044 make all outboxes appear as one, in the usual local-folders tree node.
3046 (set_active_account_from_tny_account),
3047 (modest_ui_actions_on_folder_selection_changed):
3048 * src/widgets/modest-folder-view.c: (text_cell_data),
3049 (icon_cell_data), (filter_row),
3050 (add_account_folders_to_merged_folder),
3051 (add_account_folders_to_simple_folder_store), (),
3052 (get_cmp_rows_type_pos), (cmp_rows),
3053 (modest_folder_view_set_account_id_of_visible_server_account):
3054 Adjust to the new outbox system, using generic folder stores and folders
3055 in the GtkTreeModel.
3057 2007-05-23 Christian Kellner <ckellner@openismus.com>
3059 * src/modest-mail-operation.c:
3060 (modest_mail_operation_update_account):
3061 Use info->max_size instead of unintialized local var [small
3062 build fix]. (Added TODO to review that change since I don't
3065 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3067 * libmodest-dbus-client/libmodest-dbus-client.c:
3068 (libmodest_dbus_client_compose_mail): function added
3069 * src/dbus_api/modest-dbus-api.h:
3070 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3071 (on_compose_mail): Implementation of the SendAsMail functionality
3073 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3075 * src/modest-account-mgr.c:
3076 (modest_account_mgr_add_server_account): Set the secure-connection
3077 conf key for transport accounts as well as store accounts. I don't know
3078 why the if was there. For instance, this makes sure that we use SSL
3079 for the gmail preset from the easysetup wizard.
3081 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3083 * src/gnome/modest-main-window.c:
3084 (on_account_store_connecting_finished), (connect_signals):
3085 * src/maemo/modest-main-window.c:
3086 (on_account_store_connecting_finished), (connect_signals),
3087 (modest_main_window_new):
3088 Handle TnyAccountStore::connecting-finished instead of
3089 TnyDevice::connection-changed, because we cannot actually perform
3090 operations on accounts until TnyAccountStore has itself responded to
3091 the TnyDevice::connection-changed signal. This prevents a GError from
3093 Do not try to update at startup, because we (at least on scratchbox)
3094 already do an update at startup when the device goes online.
3095 This prevents a GError from tinymail.
3096 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3097 Added TODO about stopping simultaneous operations.
3099 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3101 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3102 * src/modest-mail-operation-queue.c:
3103 (modest_mail_operation_queue_remove):
3104 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3105 about where they happened.
3107 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3109 * src/modest-ui-actions.c:
3110 (modest_ui_actions_on_password_requested): Make sure that the remember
3111 output parameter is always TRUE.
3113 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3115 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3116 Show a OK/Cancel dialog if the error is a question, though we still do not
3117 know anything more about what we are asking the user.
3118 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3119 Fix an uninitialized variable (helper). This is a logic error, however.
3121 2007-05-21 Christian Kellner <ckellner@openismus.com>
3123 * src/modest-search.h:
3124 Correct bit shifting in the ModestSearchFlags enum.
3126 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3128 * src/modest-tny-account.c:
3129 (modest_tny_account_new_from_server_account): Do not use the lsub and
3130 check-all hard-coded IMAP options when using POP.
3132 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3134 * src/modest-tny-account.c:
3135 (modest_tny_account_new_from_server_account):
3136 Use NULL for the secure-auth method for POP when Password auth has been
3137 specified by the user, as we already do for IMAP. "auth=Login" causes
3138 an error from camel or the server.
3140 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3142 * src/maemo/modest-account-settings-dialog.c:
3143 (create_page_account_details),
3144 (modest_account_settings_dialog_set_account_name):
3145 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3146 for the leave-on-server checkbox, rathr than just the checkbox, when
3147 the protocol is not POP.
3149 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3151 * src/widgets/modest-account-view.c:
3152 * src/widgets/modest-account-view.h:
3153 Added modest_account_view_select_account() which will be useful later
3154 to asynchronously re-select the edited account.
3156 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3158 * src/maemo/modest-account-settings-dialog.c:
3159 (modest_account_settings_dialog_set_account_name):
3160 Automatically choose the port numbers based on the secure authentication
3161 methods, if they have not been chosen before.
3162 This fixes projects.maemo.org bug NB#56273 .
3164 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3166 * src/maemo/modest-main-window-ui.h:
3167 * src/modest-ui-actions.c:
3168 * src/modest-ui-actions.h:
3169 Connect the Tools/SMTP Servers menu item to
3170 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3171 SMTP servers dialog, as in the UI specification and saves changes when it
3172 is closed. This fixed projects.maemo.org bug NB#56305 .
3174 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3176 * src/maemo/modest-connection-specific-smtp-window.c:
3177 (modest_connection_specific_smtp_window_init):
3178 Use gtk_window_set_default_size() to make this window big enough, so
3179 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3181 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3183 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3184 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3185 (modest_connection_specific_smtp_edit_window_init),
3186 Do not try to connect to a combobox signal before the combobox exists.
3187 This fixes the cras in projects.maemo.org bug NB#56288 .
3188 (modest_connection_specific_smtp_edit_window_get_settings):
3189 Remove the server_account_name parameter which was being checked for NULL
3190 though it was not used.
3192 * src/maemo/modest-connection-specific-smtp-window.c:
3193 (modest_connection_specific_smtp_window_fill_with_connections),
3194 (on_button_edit), (modest_connection_specific_smtp_window_init):
3195 Correct the number of treemodel columns to prevent a warning.
3196 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3197 libconic does not work.
3199 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3201 * src/modest-tny-account.c:
3202 (modest_tny_account_new_from_server_account):
3203 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3204 SMTP when "None" was chosen by the user. However, with my SMTP server that
3205 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3208 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3210 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3211 to explain the memory management issue with the ID in the ModestPair.
3213 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3214 (add_sending_page), (modest_account_assistant_finalize):
3215 * src/gnome/modest-gnome-global-settings-dialog.c:
3216 (create_updating_page), (create_composing_page):
3217 * src/gnome/modest-msg-edit-window.c: (get_transports),
3218 (init_window), (modest_msg_edit_window_finalize),
3219 (modest_msg_edit_window_get_msg_data):
3220 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3221 * src/gnome/modest-transport-widget.c:
3222 (modest_transport_widget_finalize), (smtp_configuration):
3223 * src/maemo/modest-maemo-global-settings-dialog.c:
3224 (create_updating_page), (create_composing_page):
3225 * src/maemo/modest-msg-edit-window.c: (get_transports),
3226 (init_window), (modest_msg_edit_window_finalize),
3227 (modest_msg_edit_window_get_msg_data),
3228 (modest_msg_edit_window_free_msg_data):
3229 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3230 (modest_store_widget_finalize):
3231 * src/maemo/modest-transport-widget.c:
3232 (modest_transport_widget_finalize), (smtp_configuration):
3233 * src/modest-main.c: (send_mail):
3234 * src/widgets/modest-combo-box.h:
3235 * src/widgets/modest-global-settings-dialog-priv.h:
3236 * src/widgets/modest-global-settings-dialog.c:
3237 (modest_global_settings_dialog_finalize):
3238 * src/widgets/modest-msg-edit-window.h:
3239 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3240 as long as the combo box, to prevent use of freed memory for the ID.
3242 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3244 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3245 get_accounts(), to make this clearer. Do not check for the enabled gconf
3246 key, because we do not use this for server accounts (at least, not yet).
3247 This allows us to send email again.
3249 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3251 * src/maemo/modest-platform.c:
3252 (on_modest_conf_update_interval_changed), (modest_platform_init):
3253 Only respond to this particular key change. All these strcmp()s cannot be
3256 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3258 * src/maemo/modest-maemo-global-settings-dialog.c:
3259 (current_connection): Prevent a crash in scratchbox when
3260 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3261 * src/maemo/modest-platform.c:
3262 (on_modest_conf_update_interval_changed), (modest_platform_init):
3263 Get the update interval from gconf and reset it when the gconf key changes.
3265 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3267 * src/modest-protocol-info.c:
3268 * src/modest-protocol-info.h: Adde enum-specific get functions,
3269 instead of using a ModestProtocolType enum parameter.
3271 * src/gnome/modest-account-assistant.c:
3272 * src/gnome/modest-store-widget.c:
3273 * src/gnome/modest-store-widget.h:
3274 * src/gnome/modest-transport-widget.c:
3275 * src/gnome/modest-transport-widget.h:
3276 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3277 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3278 * src/maemo/easysetup/modest-easysetup-wizard.c:
3279 * src/maemo/modest-account-settings-dialog.c:
3280 * src/maemo/modest-account-settings-dialog.h:
3281 * src/maemo/modest-store-widget.c:
3282 * src/maemo/modest-store-widget.h:
3283 * src/maemo/modest-transport-widget.c:
3284 * src/maemo/modest-transport-widget.h:
3285 * src/modest-account-mgr-helpers.c:
3286 * src/modest-account-mgr-helpers.h:
3287 * src/modest-account-mgr.c:
3288 * src/modest-account-mgr.h:
3289 * src/modest-tny-account.c:
3290 * src/modest-tny-folder.c:
3291 * src/widgets/modest-account-view.c:
3292 * src/widgets/modest-retrieve-combo-box.c:
3293 * src/widgets/modest-retrieve-combo-box.h:
3294 * src/widgets/modest-secureauth-combo-box.c:
3295 * src/widgets/modest-serversecurity-combo-box.c:
3296 * src/widgets/modest-serversecurity-combo-box.h:
3297 * tests/check_account-mgr.c:
3298 Use the specific functions, and use the re-renamed enum values for GNOME too.
3300 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3302 * src/modest-pair.h:
3303 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3304 so we can get the second based on the first.
3306 * src/maemo/modest-account-settings-dialog.h:
3307 * src/maemo/modest-account-settings-dialog.c:
3308 Added get_supported_secure_authentication_methods(), though it is mostly
3309 commented-out for now until the necessary API is committed to tinymail.
3310 (modest_account_settings_dialog_set_account_name),
3311 (save_configuration): Request the supported authentication methods from the
3312 server, so we can choose a working method.
3314 * src/modest-tny-account-store.h:
3315 * src/modest-tny-account-store.c:
3316 (modest_tny_account_store_get_session): Rename from
3317 tny_account_store_get_session().
3319 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3321 * src/modest-protocol-info.h: Split the ModestProtocol enum
3322 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3323 There was no need to have these unrelated values in one enum.
3325 * src/: many files: Adapted to changed enum. This makes the code a bit
3326 clearer, and the compiler could catch some errors.
3328 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3330 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3331 Show the detailed internal camel error message when an error happens
3332 during the configuration, so that our testers can give us more clues.
3333 For instance, in projects.maemo.org bug NB#56910 .
3335 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3337 * src/modest-tny-account.c:
3338 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3339 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3341 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3343 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3344 * src/maemo/modest-account-settings-dialog.c:
3345 (modest_account_settings_dialog_set_account_name),
3346 (save_configuration): For the incoming secure authentication checkbox,
3347 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3348 the UI specification. PLAIN does not seem to be supported for most IMAP
3349 servers anyway, and I am not sure what it would mean.
3350 However, we probably need to discover which of the secure-authentication
3351 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3352 * src/modest-account-mgr-helpers.c:
3353 (modest_account_mgr_get_server_account_data):
3355 * src/modest-tny-account.c:
3356 (modest_tny_account_new_from_server_account):
3357 Use tny_account_set_mech() to set secure-authentication methods,
3358 with some special-casing for IMAP, based on my observations of how
3361 * src/modest-account-mgr-helpers.h:
3362 * src/modest-account-mgr.c:
3363 * src/modest-defs.h: Comment that the URI is only used for local folders.
3365 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3367 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3368 parameter const, just to be neat.
3369 * src/modest-text-utils.c: (modest_text_utils_inline):
3370 End g_strconcat() with NULL, as its documentation says. This is almost
3371 certainly the cause of my crash at startup on the device. Interestingly,
3372 valgrind doesn't tell us about these errors.
3374 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3376 * scripts/build-packages: Added more precise comments about how to use
3377 this script, though I still get this error:
3378 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3379 error building tinymail
3381 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3383 * src/maemo/modest-main-window.c: (on_account_update):
3384 Very slight cleanup, hoping to make it simpler to discover what causes
3385 a crash here sometimes.
3387 * src/modest-tny-account.c:
3388 (modest_tny_account_new_from_server_account): Set the port. Added
3389 comments about the options and a TODO comment because I need to find out
3390 how to specify the secure authentication method.
3392 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3394 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3395 changed CFlags paths form modest to libmodest
3397 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3399 * src/modest-account-mgr-helpers.c:
3400 (modest_account_mgr_get_server_account_data),
3401 (modest_account_mgr_free_server_account_data):
3402 * src/modest-account-mgr-helpers.h:
3403 * src/modest-account-mgr.c:
3404 (modest_account_mgr_add_server_account):
3405 * src/modest-defs.h:
3406 * src/modest-tny-account.c:
3407 (modest_tny_account_new_from_server_account):
3408 Determine the options for tny_camel_account_add_option() here,
3409 based on the settings, rather than storing them directly in gconf.
3411 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3413 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3414 Show a more friendly error dialog now that we expect (from the tinymail
3415 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3417 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3419 * src/maemo/modest-main-window.c: (on_account_update): Check that
3420 account_name is not NULL, to prevent a crash at startup that I am
3421 seeing on the N800. I do wonder why it is NULL.
3423 * src/maemo/easysetup/modest-easysetup-wizard.c:
3424 (create_page_user_details):
3425 * src/maemo/modest-account-settings-dialog.c:
3426 (create_page_user_details), (create_page_outgoing):
3427 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3428 (modest_connection_specific_smtp_edit_window_init):
3429 * src/modest-ui-actions.c:
3430 (modest_ui_actions_on_password_requested):
3431 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3432 might do something useful with the on-screen keyboard.
3434 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3436 * src/maemo/modest-main-window.c: (on_account_update):
3437 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3438 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3440 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3442 * src/modest-tny-account-store.c: (on_account_changed):
3443 Correct the signature of this signal handler.
3445 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3447 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3448 Show a HildonNote instead of a GtkDialog for Maemo.
3450 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3452 * src/widgets/modest-account-view.h:
3453 * src/widgets/modest-account-view.c: (on_account_changed),
3454 (on_account_removed). Added a boolean flag, set/unset by
3455 modest_account_view_block_conf_updates(),
3456 modest_account_view_unblock_conf_updates() to prevent unnecessary
3457 updates, but this is not very useful because the gconf notifications are
3458 so delays (maybe only on Maemo Bora).
3459 So auto-updating is turned off, and these functions do an explicit
3460 update when necessary.
3461 However, something else is still doing too much work when adding/removing
3462 accounts, probably in another part of the application.
3464 * src/maemo/modest-account-view-window.c:
3465 (on_delete_button_clicked), (on_edit_button_clicked),
3466 (on_new_button_clicked): Use the new functions.
3468 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3470 * src/modest-account-mgr-helpers.c:
3471 (modest_account_mgr_set_first_account_as_default):
3472 Sort the list of names alphabetically-by-title, so we choose the first one
3474 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3475 alphabetically by the title.
3477 This fixes projects.maemo.org bug NB#56418 .
3479 * src/modest-account-mgr-priv.c:
3480 (_modest_account_mgr_account_from_key):
3481 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3482 avoid a valgrind error, and possible random behaviour.
3484 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3486 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3487 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3488 tinymail documentation to say that this can be expected.
3489 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3490 pretty, and should not happen, but I would prefer to know when it does.
3492 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3494 * configure.ac: When using the older hildon version, probably on Bora,
3495 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3497 * src/widgets/modest-attachment-view.c:
3498 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3501 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3503 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3504 Implemented the prototype. Can be tested with
3505 tests/dbus_api/test_open_message:
3507 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3509 * src/modest-tny-account-store.c:
3510 (modest_tny_account_store_instance_init), (get_password):
3511 * src/modest-ui-actions.c:
3512 (modest_ui_actions_on_password_requested):
3513 Do not store the password in gconf, because this function is called
3514 for non-remembered passwords. Actually use the cached (in the hash map)
3515 password instead of releasing it.
3516 The password will now not be remembered if it is asked via the protected
3517 password dialog, as per the UI spec.
3519 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3521 * src/modest-defs.h:
3522 * src/modest-account-mgr-helpers.h:
3523 * src/modest-account-mgr-helpers.c:
3524 Added modest_server_account_get_username_has_succeeded(),
3525 modest_server_account_set_username_has_succeeded().
3526 (modest_server_account_set_username),
3527 Reset the has-succeeded flag if the username changes.
3529 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3530 * src/maemo/modest-connection-specific-smtp-window.c:
3531 (modest_connection_specific_smtp_window_save_server_accounts):
3532 Use modest_server_account_set_username() instead of using
3533 modest_conf_set_string() directly, so that the has-succeeded flag is always
3536 * src/modest-ui-actions.c:
3537 (modest_ui_actions_on_password_requested): Dim the username entry if
3538 the username has ever worked, as per the UI spec.
3540 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3542 * src/modest-tny-account-store.c: (get_password):
3543 * src/modest-ui-actions.c:
3544 (modest_ui_actions_on_password_requested):
3545 Allow the username to be changed too, though there is more work to
3546 be done on exactly how this behaves.
3548 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3550 * src/modest-account-mgr-helpers.h:
3551 * src/modest-account-mgr-helpers.c:
3552 Added modest_account_mgr_get_display_name(),
3553 modest_server_account_get_username(),
3554 modest_server_account_set_username(),
3555 modest_server_account_set_password(),
3556 modest_server_account_get_hostname() functions so we do not need to
3557 use the conf API directly.
3559 * src/maemo/modest-main-window.c: (connect_signals):
3560 Actually connect ot the ModestAccountStore::request-password signal,
3561 so that we show the dialog when the password is requested by Tinymail,
3562 for isntance if it is empty.
3564 * src/modest-marshal.list:
3565 * src/modest-tny-account-store.c:
3566 (modest_tny_account_store_class_init), (get_password),
3567 (modest_tny_account_store_alert):
3568 * src/modest-tny-account-store.h:
3569 * src/modest-ui-actions.h:
3570 * src/modest-ui-actions.c:
3571 (modest_ui_actions_on_password_requested):
3572 Change the signal parameters, so it is obvious that we are providing
3573 the non human-readable server name, and receiving both the username
3574 and password, though changing of the username is not yet implemented.
3575 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3576 for the GNOME version.
3578 This should fix the projects.maemo.org bug NB#56209, though it does not
3579 work on Bora, because the gconf_client_get() for the password fails
3580 immediately after we save it with gconf_client_set().
3582 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3585 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3586 caused an undefined symbol error:
3587 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3589 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3591 * src/modest-tny-account-store.c:
3592 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3593 using a GError instead of a string message, so we can translate it in
3596 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3598 * src/maemo/modest-address-book.c:
3599 (modest_address_book_check_names):
3600 * src/maemo/modest-msg-view-window.c:
3601 (modest_msg_view_window_clipboard_owner_change):
3602 * src/modest-init.c: (modest_init_init_ui):
3603 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3604 (update_folders_cb), (modest_mail_operation_update_account):
3605 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3606 (modest_ui_actions_on_msg_attachment_clicked),
3607 (modest_ui_actions_on_msg_recpt_activated):
3608 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3609 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3610 (modest_msg_view_search_next):
3611 * src/widgets/modest-recpt-editor.c:
3612 (modest_recpt_editor_on_button_release_event),
3613 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3614 g_message(). At this point we should only be seeing interesting errors on
3615 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3617 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3619 (modest_wizard_dialog_force_title_update):
3620 * src/maemo/easysetup/modest-wizard-dialog.h:
3621 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3622 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3623 can update the title when appropriate. Otherwise the title is wrong if the
3624 pages are added after adding the notebook to the dialog.
3625 This must be a problem in HildonWizardDialog too.
3626 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3628 * src/maemo/easysetup/modest-easysetup-wizard.c:
3629 (create_subsequent_customsetup_pages),
3630 (create_subsequent_easysetup_pages):
3631 Call modest_wizard_dialog_force_title_update() so that the title is
3632 correct even with GTK+ < 2.10.
3633 This fixes projects.maemo.org bug NB#56145 .
3635 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3637 * src/maemo/modest-platform.c:
3638 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3639 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3642 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3644 * src/widgets/modest-window.h:
3645 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3646 and modest_window_save_state(), which invokes it.
3648 * src/widgets/modest-window-mgr.h:
3649 * src/widgets/modest-window-mgr.c:
3650 Added modest_window_mgr_save_state_for_all_windows(), which calls
3651 the save_state vfunc on all registered windows, if implemented.
3653 * src/gnome/modest-msg-edit-window.c:
3654 * src/gnome/modest-msg-view-window.c:
3655 * src/maemo/modest-msg-edit-window.c:
3656 * src/maemo/modest-msg-view-window.c:
3657 * src/maemo/modest-main-window.c:
3658 Specify the existing save_settings functions as implementations of
3659 ModestWindow::save_state_func().
3661 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3662 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3663 enabling hibernation, for instance.
3665 We may need to do the same thing for restoring settings.
3668 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3670 * src/widgets/modest-window-mgr.c:
3671 * src/widgets/modest-window-mgr.h:
3672 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3673 modest_window_mgr_get_hibernation_is_prevented().
3675 * src/maemo/modest-main-window.c:
3676 (on_hildon_program_is_topmost_notify): Prevent hibernation
3677 (possible when the application goes to the background in the WM),
3678 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3680 * src/maemo/easysetup/modest-easysetup-wizard.c:
3681 (modest_easysetup_wizard_dialog_init):
3682 * src/maemo/modest-account-settings-dialog.c:
3683 (modest_account_settings_dialog_init):
3684 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3685 (modest_connection_specific_smtp_edit_window_init):
3686 * src/maemo/modest-connection-specific-smtp-window.c:
3687 (modest_connection_specific_smtp_window_init):
3688 * src/maemo/modest-signature-editor-dialog.c:
3689 (modest_signature_editor_dialog_init):
3690 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3691 prevent hibernation while any of these account settings dialogs are open.
3693 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3695 * src/maemo/Makefile.am:
3696 * src/maemo/modest-osso-state-saving.c:
3697 * src/maemo/modest-osso-state-saving.h: Added
3698 modest_osso_load_state() and modest_osso_save_state() though they do
3699 nothing now. They should iterate through all the open windows and load/save
3701 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3702 save state when closing.
3704 * src/maemo/modest-main-window.c:
3705 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3706 Add a notification handler for the HildonProgram::is-topmost property,
3707 so we can allow hibernation when the application goes into the background.
3708 But we still need to detect when the accounts setup windows are open so
3709 we can stop hibernation when they are open.
3710 To do this, I also added the main window the HildonProgram. This might have
3711 other side-effects/benefits, and should maybe be done for other windows.
3713 * src/maemo/modest-osso-autosave-callbacks.h:
3714 * src/maemo/modest-osso-autosave-callbacks.c:
3715 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3716 though it does not do anything yet, and we might never need this to do
3717 anything. For instance, we already save drafts.
3719 * src/maemo/modest-platform.c: (modest_platform_init):
3720 Specify the libosso auto-save callback.
3722 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3724 * src/maemo/modest-platform.c:
3725 (modest_platform_set_update_interval):
3726 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3727 aparently stays valid between application instances, so we can use this
3728 to remove and reset it later. According to a maemo-developers email from
3731 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3733 * configure.ac: Depend on libalarm for Maemo.
3735 * src/dbus_api/modest-dbus-api.h:
3736 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3737 (on_send_receive), (modest_dbus_req_handler):
3738 Handle a SEND_RECEIVE D-Bus method.
3740 * libmodest-dbus-client/libmodest-dbus-client.c:
3741 (libmodest_dbus_client_send_and_receive):
3742 * libmodest-dbus-client/libmodest-dbus-client.h:
3743 Add C convenience functions for calling the new D-Bus method.
3745 * src/modest-platform.h:
3746 * src/gnome/modest-platform.c:
3747 * src/maemo/modest-platform.c:
3748 Added modest_platform_set_update_interval(), which uses the
3749 alarmd API on Maemo.
3750 (modest_platform_init),
3751 Call modest_platform_set_update_interval(), using a hard-coded
3752 interval for now (until the global settings dialog is implemented),
3753 though I am not sure that this makes sense yet.
3755 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3757 * src/dbus_api/modest-dbus-callbacks.c:
3758 (modest_osso_cb_hw_state_handler):
3759 * src/dbus_api/modest-dbus-callbacks.h:
3760 * src/maemo/modest-platform.c: (modest_platform_init):
3761 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3762 in case this has some effect on the ability for Maemo to ping the
3765 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3767 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3768 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3769 warning. It is probably a logic error, but I need to fix the build.
3771 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3773 * src/modest-account-mgr.h:
3774 * src/modest-account-mgr.c:
3775 (modest_account_mgr_account_names): Add a gboolean enabled_only
3776 parameter, so we can get lists of onlt the enabled accounts.
3778 (modest_account_mgr_add_account),,
3779 (modest_account_mgr_account_with_display_name_exists):
3780 * src/maemo/modest-msg-edit-window.c: (get_transports):
3781 * src/modest-account-mgr-helpers.c:
3782 (modest_account_mgr_set_first_account_as_default):
3783 * src/modest-init.c: (init_default_account_maybe):
3784 * src/modest-tny-account-store.c: (get_accounts):
3785 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3786 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3787 * tests/check_account-mgr.c: (START_TEST):
3788 Provide the extra parameter, as appropriate.
3790 * src/widgets/modest-account-view.c: (update_account_view):
3791 Do not show disabled accounts (meaning that there is no way to
3792 enable/disable accounts in the UI (the feature is not in our UI
3793 specification), so we can use this internally only to mark unfinished
3794 or temporary account data.
3796 * src/maemo/easysetup/modest-easysetup-wizard.c:
3797 (create_account): Add boolean enable parameter, so we can specify FALSE
3798 to create the temporary account.
3799 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3800 (on_before_next): When finishing, when there is a temporary account, just
3802 Also, use a timeout to delay the showing of the dialog until gconf is likely
3803 to return correct information, due to a maemo gconf bug that is fixed in
3804 osso 1.1, but not yet in Bora.
3805 However, the dialog stays on screen after it is destroyed.
3807 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3808 for invalid data when cancelling. Use a hildon note instead of a dialog
3809 to complain about invalid data. Do not show the account-saved note if the
3810 account is disabled (a temporary account that will not really be saved for use
3813 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3815 * src/modest-account-mgr-helpers.h:
3816 * src/modest-account-mgr-helpers.c:
3817 Added modest_account_mgr_unset_default_account(),
3818 Added modest_account_mgr_set_first_account_as_default().
3820 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3821 If it was the default account, unset the default account name.
3823 * src/maemo/modest-account-view-window.c:
3824 (on_delete_button_clicked): If it was the default account,
3825 set the first remaining account as the default instead.
3827 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3828 a NULL account or a NULL default account, to prevent a crash. This should
3829 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3832 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3834 * src/widgets/modest-recpt-editor.c:
3835 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3836 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3837 TODO comment for this. This fixes the build.
3839 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3840 be the best place for it. This will in future update all auto-update accounts,
3841 rather than just the current/default account, when that gconf key exists.
3842 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3843 if there are no accounts, before calling do_send_receive().
3844 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3846 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3847 * src/maemo/modest-main-window-ui.h:
3848 * src/maemo/modest-main-window.c: (on_connection_changed),
3849 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3850 directly, becaue the signal handler does more.
3852 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3854 * src/modest-account-mgr-helpers.c:
3855 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3856 for the case that the account does not exist.
3858 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3859 (equivalent to the modest account name) rather than the tinymail account name
3860 (equivalent to the modest account title - human readable) to get the account data.
3861 Check for null account data to prevent the crash, and add a TODO comment saying that
3862 this needs fixing because it is using the server account name instead of the account name.
3864 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3866 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3867 * src/maemo/modest-account-settings-dialog.c: (show_error),
3869 Use hildon_note_new_information() for informative and error messages,
3870 which seems to be expected for Maemo applications (no documentation that I know of
3871 says this). I am surprised that there is no distinction between info and error
3874 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3876 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3877 it is easy to find where this is used.
3879 * src/maemo/easysetup/modest-easysetup-wizard.c:
3880 (create_page_welcome), (create_page_account_details),
3881 (create_page_user_details), (create_page_complete_easysetup),
3882 (create_page_custom_incoming), (create_page_custom_outgoing),
3883 (create_page_complete_custom):
3884 * src/maemo/modest-account-settings-dialog.c:
3885 (create_page_account_details), (create_page_user_details),
3886 (create_page_incoming), (create_page_outgoing):
3887 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3888 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3889 (modest_connection_specific_smtp_edit_window_init):
3890 * src/maemo/modest-connection-specific-smtp-window.c:
3891 (modest_connection_specific_smtp_window_init):
3892 * src/maemo/modest-signature-editor-dialog.c:
3893 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3894 and scrolling policy as per the Email Application Layout Guide, if I have
3897 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3899 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3900 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3901 which were empty, because these vfuncs have been removed from TnyAccountStore.
3902 This fixes the build.
3904 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3906 * src/maemo/modest-main-window.c:
3907 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3908 showing/hiding it. Added TODO because it probably should not be NULL.
3909 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3910 because unnecessary g_warnings() make degugging difficult.
3912 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3914 * src/maemo/modest-msg-edit-window.c:
3915 (modest_msg_edit_window_select_color),
3916 (modest_msg_edit_window_select_background_color): 2 const corrections and
3917 moving 2 #endifs before closing brackets, to fix the build.
3919 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3921 * src/maemo/easysetup/modest-easysetup-wizard.h:
3922 * src/maemo/easysetup/modest-easysetup-wizard.c:
3923 (modest_easysetup_wizard_dialog_finalize),
3924 (on_button_edit_advanced_settings), (create_page_complete_custom),
3925 (on_response), (create_account):
3926 Implement the Advanced Settings edit button, by saving the account information,
3927 for the Advanded Settings dialog to use directly from gconf, and removing it
3928 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3929 Bug #5533 in the projects.maemo.org bugzilla.
3931 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3933 * src/maemo/modest-msg-view-window.c:
3934 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3935 when opening a message window.
3937 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3939 * src/maemo/easysetup/modest-easysetup-wizard.c:
3940 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3943 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3944 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3945 gconf settings. I probably added more checks than necessary, but that is safer.
3947 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3948 variable to fix the build, but this seems to be used when it is still NULL.
3950 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3952 * src/modest-platform.h:
3953 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3954 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3955 * src/modest-main.c: Implement this function so we can avoid using
3956 maemo-specific API from cross-platform code.
3958 * src/modest-tny-account-store.c:
3959 (get_smtp_specific_transport_account_for_open_connection):
3960 * src/modest-ui-actions.c: (check_for_connection),
3961 (modest_ui_actions_on_item_not_found):
3962 Use modest_platform_connect_and_wait() and put #idefs around other
3963 maemo-specific code, because only maemo currently has a way to
3964 identify connection names.
3966 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3968 * src/modest-tny-account-store.h:
3969 * src/modest-tny-account-store.c:
3970 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3971 the connection-specific SMTP server settings in the configuration.
3973 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3975 * src/maemo/modest-main-window.c: (on_connection_changed),
3977 * src/modest-main.c: (main), (start_ui), (send_mail):
3978 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3979 that is what is intended.
3981 * src/modest-ui-actions.c: (action_send), (action_receive),
3982 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3983 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3984 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3985 SMTP server is used when it is specified.
3987 (modest_ui_actions_on_send_receive):
3988 Check that a connection is open before proceeding.
3989 Receive and then send, instead of vice-versa, as per the specification.
3991 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3993 * src/modest-mail-operation.c:
3994 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3995 though I guess it should be something other than NULL.
3997 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3999 * src/maemo/easysetup/modest-easysetup-wizard.c:
4000 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4001 combo twice, to avoid an g_warning and to make it visible again.
4002 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4003 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4004 (already intended) dereference when detaching, because we then recreate the menu.
4005 But I am not sure why the warning was happening, and it is possible that this is a memory
4008 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4010 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4011 and uri_parse_mailto() utility functions.
4012 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4014 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4016 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4018 * src/dbus_api/modest-dbus-api.h:
4019 * src/dbus_api/modest-dbus-callbacks.c:
4020 Use an idle callback to execute the modest code in the application's own thread.
4021 Remove the helloworld example method.
4022 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4023 parsed, and the open-message method is not implemented because this is not yet implemented in
4025 * libmodest-dbus-client/libmodest-dbus-client.c:
4026 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4027 (libmodest_dbus_client_open_message):
4028 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4030 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4031 body without crashing.
4033 * tests/dbus_api/Makefile.am:
4034 * tests/dbus_api/test_mail_to.c:
4035 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4037 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4039 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4040 Added file to fix the build. Sorry.
4042 * src/dbus_api/Makefile.am:
4043 * src/dbus_api/modest-dbus-api.h:
4044 * src/dbus_api/modest-dbus-callbacks.h:
4045 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4046 (modest_dbus_req_handler):
4047 Put constants in a separate header so it can be reused by the
4048 client library, without duplication
4050 * libmodest-dbus-client/Makefile.am:
4051 * libmodest-dbus-client/libmodest-dbus-client.c:
4052 (libmodest_dbus_client_call_helloworld),
4053 (libmodfest_dbus_client_send_mail),
4054 (libmodfest_dbus_client_mailto),
4055 (libmodfest_dbus_client_open_message):
4056 * libmodest-dbus-client/libmodest-dbus-client.h:
4057 (Partly) Implement a send_mail D-Bus method.
4059 * tests/dbus_api/Makefile.am:
4060 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4061 the send_email D-Bus method.
4063 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4067 * libmodest-dbus-client/Makefile.am:
4068 * libmodest-dbus-client/libmodest-dbus-client.c:
4069 * libmodest-dbus-client/libmodest-dbus-client.h:
4070 * tests/dbus_api/Makefile.am:
4071 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4072 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4074 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4076 * src/maemo/easysetup/modest-easysetup-wizard.c:
4077 (create_page_account_details):
4078 * src/maemo/modest-account-settings-dialog.c:
4079 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4080 widgets, because this might not be the default in future versions of the Maemo GTK+.
4081 However, I can not not get capitalization to work even in a simple test case.
4083 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4085 * src/maemo/easysetup/modest-easysetup-wizard.c:
4086 (create_page_custom_incoming), (create_page_custom_outgoing):
4087 * src/maemo/modest-account-settings-dialog.c:
4088 (create_page_account_details), (create_page_incoming),
4089 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4090 instead of using gtk_check_button_with_label(), so they are aligned like the other
4091 widgets, as per the UI spec.
4093 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4095 * src/maemo/easysetup/modest-easysetup-wizard.c:
4096 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4097 * src/widgets/modest-validating-entry.c:
4098 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4099 Modest prefix instead of an EasySetup prefix.
4101 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4103 * src/widgets/modest-validating-entry.h:
4104 * src/widgets/modest-validating-entry.c: (on_insert_text),
4105 Added easysetup_validating_entry_set_max_func(), used to set a callback
4106 to call when the max number of characters is reached. GtkEntry has a max-length
4107 already but is silent about it.
4109 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4110 (create_page_account_details), (create_page_user_details),
4112 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4113 (create_page_account_details), (create_page_user_details),
4114 (create_page_outgoing):
4115 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4116 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4117 the UI spec, when the user tries to enter more than the max number of characters.
4119 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4121 * src/maemo/easysetup/modest-easysetup-wizard.c:
4122 (create_page_user_details), (create_page_custom_incoming),
4123 (create_page_custom_outgoing):
4124 * src/maemo/modest-account-settings-dialog.c:
4125 (create_page_user_details), (create_page_incoming),
4126 (create_page_outgoing):
4127 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4128 (modest_connection_specific_smtp_edit_window_init):
4129 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4130 not appropriate. Bad Maemo-specific defaults!.
4132 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4134 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4135 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4136 (modest_signature_editor_dialog_set_settings):
4137 Disable the label and textview when the checkbox is disabled, and use the
4138 specified (UI spec) default signature text.
4140 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4142 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4143 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4145 * src/modest-defs.h:
4146 * src/modest-account-mgr-helpers.h:
4147 * src/modest-account-mgr-helpers.c:
4148 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4150 * src/maemo/Makefile.am:
4151 * src/maemo/modest-signature-editor-dialog.c:
4152 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4155 * src/maemo/modest-account-settings-dialog.h:
4156 * src/maemo/modest-account-settings-dialog.c:
4157 (modest_account_settings_dialog_finalize), (on_button_signature),
4158 (save_configuration): Use the new dialog when the Edit button is pressed, and
4159 save the changes if necessary, as per the UI spec.
4161 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4163 * src/maemo/Makefile.am:
4164 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4165 based on maemo-develoers email from Dirk.
4167 * src/maemo/easysetup/modest-easysetup-wizard.c:
4168 (create_page_welcome), (create_page_account_details),
4169 (create_page_user_details), (create_page_complete_easysetup),
4170 (create_page_custom_incoming), (create_page_custom_outgoing),
4171 (create_page_complete_custom),
4172 (modest_easysetup_wizard_dialog_init):
4173 * src/maemo/modest-account-settings-dialog.c:
4174 (create_page_account_details), (create_page_user_details),
4175 (create_page_incoming), (create_page_outgoing),
4176 (modest_account_settings_dialog_init):
4177 * src/maemo/modest-connection-specific-smtp-window.c:
4178 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4180 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4182 * src/maemo/easysetup/modest-easysetup-wizard.c:
4183 (create_page_account_details), (create_page_custom_outgoing),
4184 (create_page_complete_custom):
4185 * src/maemo/modest-account-settings-dialog.c:
4186 (create_page_user_details), (create_page_incoming),
4187 (create_page_outgoing):
4188 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4189 (modest_connection_specific_smtp_edit_window_init):
4190 Use the correct (UI spec) port min/max, and use horizontal separators,
4193 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4195 * src/maemo/easysetup/modest-easysetup-wizard.c:
4196 (set_default_custom_servernames):
4197 * src/maemo/modest-account-settings-dialog.c:
4198 (create_page_incoming), (on_combo_outgoing_security_changed),
4199 (on_combo_incoming_security_changed), (create_page_outgoing),
4200 (modest_account_settings_dialog_set_account_name),
4201 (save_configuration):
4202 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4203 (on_combo_security_changed),
4204 (modest_connection_specific_smtp_edit_window_init),
4205 (modest_connection_specific_smtp_edit_window_set_connection),
4206 (modest_connection_specific_smtp_edit_window_get_settings):
4207 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4210 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4213 * src/maemo/easysetup/modest-easysetup-wizard.c:
4214 (create_page_custom_outgoing), (create_page_complete_custom):
4215 * src/maemo/modest-account-settings-dialog.c:
4216 (create_page_user_details), (create_page_outgoing):
4217 * src/maemo/modest-account-view-window.c: (button_box_new):
4218 Use changed logical IDs as per the most recent UI spec:
4219 mcen_bd_emailsetup_edit -> mcen_bd_edit
4220 mcen_bd_emailsetup_delete -> mcen_bd_delete
4221 mcen_bd_emailsetup_close -> mcen_bd_close
4223 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4227 * src/dbus_api/Makefile.am:
4228 * src/dbus_api/modest-dbus-callbacks.c:
4229 * src/dbus_api/modest-dbus-callbacks.h:
4230 * src/maemo/modest-platform.c: (modest_platform_init):
4231 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4233 * tests/Makefile.am:
4234 * tests/dbus_api/Makefile.am:
4235 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4237 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4239 * src/maemo/modest-account-settings-dialog.c:
4240 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4241 Removed unnecessary includes.
4243 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4245 * src/maemo/easysetup/modest-easysetup-wizard.c:
4246 * src/maemo/modest-account-settings-dialog.c:
4247 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4248 * src/widgets/Makefile.am:
4249 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4250 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4251 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4252 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4253 * src/widgets/modest-secureauth-combo-box.c:
4254 * src/widgets/modest-secureauth-combo-box.h:
4255 * src/widgets/modest-serversecurity-combo-box.c:
4256 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4257 made the GObject names more consistent with the rest of the Modest code.
4259 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4261 * src/maemo/easysetup/Makefile.am:
4262 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4263 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4264 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4265 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4266 * src/maemo/easysetup/modest-easysetup-wizard.c:
4267 * src/maemo/easysetup/modest-validating-entry.c:
4268 * src/maemo/easysetup/modest-validating-entry.h:
4269 * src/maemo/modest-account-settings-dialog.c:
4270 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4271 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4272 widgets/ because they are used outside of easysetup too. After checking in,
4273 svn will allow me to rename them too.
4275 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4277 * src/gnome/modest-msg-edit-window.c:
4278 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4279 linker error, to fix the build on the GNOME platform.
4280 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4281 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4282 ifdefed out to avoid a warning.
4284 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4286 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4287 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4288 some alternative for GTK+ 2.6.
4290 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4292 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4294 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4295 specified for EmailAccountsDialog in UI spec.
4297 * src/maemo/easysetup/modest-easysetup-wizard.c:
4298 * src/maemo/easysetup/modest-easysetup-wizard.h:
4299 * src/maemo/modest-account-settings-dialog.c:
4300 * src/maemo/modest-account-settings-dialog.h:
4301 Reuse a member window widget for the connection-specific SMTP server accounts,
4302 so we can tell it to create/save the accounts only if we actually save changes.
4304 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4305 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4306 (modest_connection_specific_smtp_edit_window_get_settings):
4307 Return a struct instance for temporarily remembering the entered data.
4309 * src/maemo/modest-connection-specific-smtp-window.h:
4310 * src/maemo/modest-connection-specific-smtp-window.c:
4311 (modest_connection_specific_smtp_window_finalize),
4312 (modest_connection_specific_smtp_window_fill_with_connections),
4314 (modest_connection_specific_smtp_window_save_server_accounts),
4315 (update_model_server_names): Do not actually save data until asked,
4316 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4318 (on_selection_changed),
4319 (modest_connection_specific_smtp_window_init): Disable the edit
4320 button when nothing is selected.
4322 * src/modest-account-mgr-helpers.c:
4323 * src/modest-account-mgr-helpers.h:
4324 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4327 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4329 * src/modest-account-mgr-helpers.h:
4330 * src/modest-account-mgr-helpers.c:
4331 (modest_account_mgr_get_unused_account_name),
4332 (modest_account_mgr_get_unused_account_display_name): Added these
4333 utility functions, to avoid code duplication.
4335 * src/maemo/easysetup/modest-easysetup-wizard.c:
4336 (create_page_account_details), (create_account):
4337 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4338 (on_combo_security_changed),
4339 (modest_connection_specific_smtp_edit_window_init),
4340 (modest_connection_specific_smtp_edit_window_save_settings):
4341 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4342 * src/maemo/modest-connection-specific-smtp-window.c:
4343 (modest_connection_specific_smtp_window_finalize),
4344 (modest_connection_specific_smtp_window_fill_with_connections),
4345 (on_button_edit), (modest_connection_specific_smtp_window_init):
4346 * src/maemo/modest-connection-specific-smtp-window.h:
4347 Implementing saving of connection-specific server accounts.
4349 But I need to refactor this so we can save the data for each
4350 possible connection-specific account and only actually create the server accounts
4351 when the easysetup finished, or the OK button is pressed on the account settings
4354 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4356 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4357 (on_combo_security_changed):
4358 (modest_connection_specific_smtp_edit_window_init):
4359 Auto-fill the port number as in the account settings.
4361 (modest_connection_specific_smtp_edit_window_set_connection):
4362 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4363 * src/maemo/modest-connection-specific-smtp-window.c:
4364 (fill_with_connections), (on_button_edit),
4365 (modest_connection_specific_smtp_window_init):
4366 Turn the edit window into a dialog to simplify the code, and
4367 set a WM hint as in a GtkDialog, because only a popup can be on top of
4368 another window in Maemo, and popups usually have no WM decoration.
4370 * src/modest-defs.h:
4371 * src/modest-account-mgr-helpers.c:
4372 (modest_account_mgr_set_connection_specific_smtp),
4373 (modest_account_mgr_remove_connection_specific_smtp),
4374 (modest_account_mgr_get_connection_specific_smtp):
4375 * src/modest-account-mgr-helpers.h: Some functions to write the
4376 connection-specific SMTP server information. Not yet used.
4379 * src/widgets/modest-folder-view.c: (text_cell_data):
4380 Fix a warning about an uninitialized variable.
4381 (on_configuration_key_changed): Put an #ifdef around the use
4382 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4384 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4386 * src/maemo/modest-account-settings-dialog.h:
4387 * src/maemo/modest-account-settings-dialog.c:
4388 Added connect_for_modified() utility function to mark the new modified boolean.
4390 (create_page_account_details), (create_page_user_details),
4391 (create_page_incoming), (create_page_outgoing), (on_response),
4392 (modest_account_settings_dialog_init),
4393 (modest_account_settings_dialog_set_account_name):
4394 Only warn about unsaved changes when there are actually unsaved changes.
4396 * src/modest-account-mgr-helpers.c:
4397 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4398 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4399 to get the data from there in future.
4401 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4403 * src/modest-defs.h:
4405 * src/modest-account-mgr-helpers.h:
4406 * src/modest-account-mgr-helpers.c:
4407 Store the security account setting in a single conf key instead of using
4408 the options list, so that the list is left for just the to-be-removed camel hack,
4409 and because gconf_client_set_list() is failing for some reason.
4411 * src/modest-account-mgr.c:
4412 (modest_account_mgr_add_server_account):
4413 * src/maemo/modest-account-settings-dialog.c:
4414 (modest_account_settings_dialog_set_account_name),
4415 (save_configuration): Use the renamed functions.
4418 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4420 * src/widgets/Makefile.am:
4421 * src/widgets/modest-limit-retrieve-combo-box.c:
4422 * src/widgets/modest-limit-retrieve-combo-box.h:
4423 * src/widgets/modest-retrieve-combo-box.c:
4424 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4425 the account settings dialog.
4427 * src/modest-defs.h:
4428 * src/modest-account-mgr-helpers.h:
4429 * src/modest-account-mgr-helpers.c:
4430 (modest_server_account_get_option_secure_auth),
4431 (modest_server_account_set_option_secure_auth):
4432 * src/modest-account-mgr.c:
4433 (modest_account_mgr_add_server_account):
4434 Use the existing AUTH_MECH conf key for the secure-auth setting,
4435 instead of putting it in the list options, because this was actually used already.
4437 * src/maemo/modest-account-settings-dialog.c:
4438 (create_page_account_details),
4439 (modest_account_settings_dialog_set_account_name),
4440 (save_configuration):
4441 * src/maemo/modest-account-settings-dialog.h:
4442 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4443 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4445 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4447 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4448 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4449 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4451 * src/modest-defs.h:
4452 * src/maemo/modest-account-settings-dialog.c:
4453 (create_page_incoming), (on_combo_outgoing_security_changed),
4454 (on_combo_incoming_security_changed), (create_page_outgoing),
4455 (modest_account_settings_dialog_set_account_name),
4456 (save_configuration): Load/Save the port number, and change it when the
4457 security combo changes, to suitable defaults.
4459 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4461 * src/modest-account-mgr.c:
4462 (modest_account_mgr_add_server_account): Set the security and secure-auth
4463 options, and add a comment saying that the other camel-specific options should be
4466 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4468 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4470 * src/modest-tny-account-store.c: (account_list_free),
4471 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4472 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4475 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4477 * src/modest-protocol-info.c:
4478 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4479 is required by our UI spec. Maybe something in our implementation will use this eventually.
4480 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4481 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4482 instead of the previous 0 placeholder.
4484 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4485 secure-auth settings.
4486 * src/modest-account-mgr-helpers.h:
4487 * src/modest-account-mgr-helpers.c:
4488 (modest_server_account_data_get_option_secure_auth),
4489 (modest_server_account_set_option_secure_auth),
4490 (modest_server_account_data_get_option_security),
4491 (modest_server_account_set_option_security): Added this API for getting and setting the security
4492 and secure-auth settings.
4494 * src/maemo/modest-account-settings-dialog.h:
4495 * src/maemo/modest-account-settings-dialog.c:
4496 (modest_account_settings_dialog_finalize), (check_data),
4497 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4498 about changing titles.
4499 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4500 (save_configuration): Save the security and secure-auth settings.
4502 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4503 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4505 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4507 * src/modest-defs.h:
4508 * src/modest-account-mgr.c:
4509 (modest_account_mgr_add_server_account):
4510 Added and used defines for the options key and value pair strings,
4511 that are used so far, though they do not seem to correspond to anything in our
4512 UI specs or ModestProtocol enum.
4514 * src/modest-account-mgr-helpers.h:
4515 * src/modest-account-mgr-helpers.c:
4516 (compare_option_strings_for_name),
4517 (modest_server_account_data_get_option_value),
4518 (modest_server_account_data_get_option_bool),
4519 (modest_account_mgr_get_server_account_option):
4520 Added helper functions for parsing the options GSList.
4522 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4524 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4525 display name is based on the supplied account name.
4526 * src/modest-account-mgr.c:
4527 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4528 with an inefficient, but good-enough, implementation.
4530 * src/maemo/easysetup/modest-easysetup-wizard.c:
4531 (create_page_account_details), (on_before_next), (create_account):
4532 Check for existing display names rather than (non-user-visible) account names, and just
4533 create and set a unique account name at the end.
4535 * src/maemo/modest-account-settings-dialog.c:
4536 (modest_account_settings_dialog_init),
4537 (modest_account_settings_dialog_set_account_name),
4538 (create_page_incoming): Show the display name, instead of the account name.
4539 (on_response): Do some (not all) extra checks, as in the UI spec.
4540 (save_configuration): Save the display name if it was changed.
4542 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4544 * po/en_GB.po: Added needed logical ID and translation.
4545 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4546 (init_view): Made the is-default column clicking work.
4548 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4551 * src/maemo/easysetup/Makefile.am:
4552 * src/maemo/easysetup/modest-easysetup-wizard.c:
4553 (modest_easysetup_wizard_dialog_init):
4554 * src/maemo/easysetup/provider-data-test.keyfile:
4555 * src/maemo/easysetup/provider-data.keyfile:
4556 Moved the provider data file to the new modest-providers-data package and used it from there.
4558 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4560 * src/modest-local-folder-info.c:
4561 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4562 N_() was already used on the static strings, but this just marks it for translation without
4563 using the translation.
4565 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4567 * src/maemo/modest-account-settings-dialog.c:
4568 (create_page_incoming),
4569 (modest_account_settings_dialog_set_account_name):
4570 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4571 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4572 I will do this if nobody else gets there first.
4574 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4576 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4577 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4578 save the security stuff.
4580 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4582 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4583 Set the email address and user fullname, which I now see must be
4586 * src/maemo/modest-account-settings-dialog.h:
4587 * src/maemo/modest-account-settings-dialog.c:
4589 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4590 leave-on-server and authentication.
4591 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4594 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4597 * src/maemo/modest-account-settings-dialog.c:
4598 * src/maemo/modest-account-settings-dialog.h:
4599 Most (but not all) of the widgets are now present as specified by the UI spec.
4600 No changes are yet saved, and some details are not properly shown yet.
4602 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4604 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4606 * src/maemo/Makefile.am:
4607 * src/maemo/modest-account-settings-dialog.c:
4608 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4609 an existing account. Doesn't do much yet.
4611 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4612 Open the accounts settings dialog when Edit is clicked.
4614 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4616 * src/maemo/easysetup/Makefile.am:
4617 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4619 * src/maemo/easysetup/modest-easysetup-wizard.c:
4620 (modest_easysetup_wizard_dialog_init):
4621 Try to get the source directory from the build system,
4622 instead of hard-coding "./" into the source code, when opening our local
4623 copies of the configuration files.
4624 But this still fails when opening the wizard from the Accounts window,
4625 maybe because the working directory seems to change at runtime.
4626 So the wizard will fail the second time unless you copy the files into their
4627 proper locations - see the stdout warnings for the paths.
4629 (create_page_account_details),(on_before_next):
4630 Check for existing non-server accounts instead of server accounts,
4631 so the default account name is useful again, and to prevent trying to
4634 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4635 Show the wizard when New is clicked.
4637 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4638 (init_view): Show the column headers, and show the columns that are
4639 specified in the UI specs. However, something in Maemo's GTK+ prevents
4640 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4641 change the default account. This is despite unsetting the special properties.
4643 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4645 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4646 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4647 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4648 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4649 to make that clearer.
4650 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4652 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4654 * src/maemo/modest-account-view-window.c:
4655 (modest_account_view_window_init),
4656 (modest_account_view_window_new):
4657 Use the same buttons as specified in the
4658 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4659 the existing widgets, which never had a chance of working.
4660 Put the ModestAccountView treeview in a scrolled window.
4661 Do not repeat the initialization in both _init() and _new().
4663 * src/widgets/modest-account-view.c: (update_account_view):
4664 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4665 this widget and window shows no accounts.
4667 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4669 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4671 * src/maemo/easysetup/modest-easysetup-wizard.c:
4672 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4673 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4674 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4677 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4678 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4679 accounts exist yet, as in the UI spec.
4681 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4683 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4685 * src/maemo/Makefile.am:
4686 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4687 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4688 New window for editing connection-specific smtp details.
4689 Not fully implemented.
4691 * src/maemo/modest-connection-specific-smtp-window.c:
4692 (modest_connection_specific_smtp_window_finalize) :
4693 unref the tree model.
4694 (on_button_edit): Show the edit window.
4696 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4698 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4701 * src/maemo/Makefile.am:
4702 * src/maemo/modest-connection-specific-smtp-window.c:
4703 * src/maemo/modest-connection-specific-smtp-window.h:
4704 New window for showing the list of connections, for connection-specific
4705 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4706 * src/maemo/easysetup/modest-easysetup-wizard.c:
4707 (create_page_custom_outgoing): Show the new window when the button is clicked.
4709 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4711 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4712 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4713 * src/maemo/modest-msg-edit-window.c:
4714 (modest_msg_edit_window_insert_image):
4715 * src/modest-conf.c: (modest_conf_key_escape):
4716 * src/modest-mail-operation.c:
4717 (modest_mail_operation_send_new_mail):
4718 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4719 (modest_ui_actions_on_new_account):
4720 * src/widgets/modest-attachment-view.c: (update_filename_request):
4721 * src/widgets/modest-mail-header-view.c:
4722 Corrected warnings that were breaking the build, by commenting out unused variables,
4723 and a function, and by including a header.
4725 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4727 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4728 so we can #ifdef around platform-specific code when necessary.
4729 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4730 to allow this to build for the GNOME platform too.
4732 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4734 * src/maemo/easysetup/modest-easysetup-wizard.c:
4735 Added util_increment_name() and used it in create_page_account_details()
4736 to make sure that the default account name is always a new name.
4738 (modest_easysetup_wizard_dialog_init),
4739 (set_default_custom_servernames): Some minor memory management fixes.
4741 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4745 * src/modest-runtime.c: (init_i18n): Restored the translation
4746 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4747 are defined in config.h, and the translations are installed.
4749 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4750 is defined for translation.
4752 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4754 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4756 * src/maemo/easysetup/modest-easysetup-wizard.c:
4757 (modest_easysetup_wizard_dialog_init):
4758 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4759 Use realistic paths (though they should use $prefix generically) to the
4760 mcc_mapping and provider-data.keyfile files which might work when they
4761 are installed by the future version of the operator-wizard package,
4762 and then fallback to paths in our source code, with an explanatory
4765 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4769 * src/maemo/Makefile.am:
4770 * src/maemo/easysetup/: Added files from the previously-exernal
4771 osso-modest-easysetup.
4772 * src/maemo/modest-main-window-ui.h:
4773 * src/modest-ui-actions.c:
4774 * src/modest-ui-actions.h:
4775 Added modest_ui_actions_on_new_account() as a signal handler for the
4776 New Account menu item. It shows the easysetup wizard.
4777 * po/en_GB.po: Added additional needed logical IDs and translations.