git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/easysetup/modest-easysetup-wizard.h:
   4         * src/maemo/easysetup/modest-easysetup-wizard.c:
   5         (modest_easysetup_wizard_dialog_finalize),
   6         (on_button_edit_advanced_settings), (create_page_complete_custom),
   7         (on_response), (create_account):
   8         Implement the Advanced Settings edit button, by saving the account information,
   9         for the Advanded Settings dialog to use directly from gconf, and removing it
  10         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
  11         Bug #5533 in the projects.maemo.org bugzilla.
  12
  13 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  14
  15         * src/maemo/modest-msg-view-window.c:
  16         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
  17         when opening a message window.
  18
  19 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  20
  21         * src/maemo/easysetup/modest-easysetup-wizard.c:
  22         (create_page_custom_outgoing): Correct the position of the horizontal separator to
  23         match the UI spec.
  24
  25         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
  26         before showing/hiding them, to avoid a crash when clicking on folders when there are no
  27         gconf settings. I probably added more checks than necessary, but that is safer.
  28
  29         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
  30         variable to fix the build, but this seems to be used when it is still NULL.
  31
  32 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  33
  34         * src/modest-platform.h:
  35         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
  36         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
  37         * src/modest-main.c: Implement this function so we can avoid using
  38         maemo-specific API from cross-platform code.
  39         (main):
  40         * src/modest-tny-account-store.c:
  41         (get_smtp_specific_transport_account_for_open_connection):
  42         * src/modest-ui-actions.c: (check_for_connection),
  43         (modest_ui_actions_on_item_not_found):
  44         Use modest_platform_connect_and_wait() and put #idefs around other
  45         maemo-specific code, because only maemo currently has a way to
  46         identify connection names.
  47
  48 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  49
  50         * src/modest-tny-account-store.h:
  51         * src/modest-tny-account-store.c:
  52         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
  53         the connection-specific SMTP server settings in the configuration.
  54
  55         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
  56         (on_idle_mail_to):
  57         * src/maemo/modest-main-window.c: (on_connection_changed),
  58         (connect_signals):
  59         * src/modest-main.c: (main), (start_ui), (send_mail):
  60         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
  61         that is what is intended.
  62
  63         * src/modest-ui-actions.c: (action_send), (action_receive),
  64         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
  65         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
  66         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
  67         SMTP server is used when it is specified.
  68
  69         (modest_ui_actions_on_send_receive):
  70         Check that a connection is open before proceeding.
  71         Receive and then send, instead of vice-versa, as per the specification.
  72
  73 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
  74
  75         * src/modest-mail-operation.c:
  76         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
  77         though I guess it should be something other than NULL.
  78
  79 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
  80
  81         * src/maemo/easysetup/modest-easysetup-wizard.c:
  82         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
  83         combo twice, to avoid an g_warning and to make it visible again.
  84         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
  85         attached before detaching it, to avoid a g_warning, and add comment about the implicit
  86         (already intended) dereference when detaching, because we then recreate the menu.
  87         But I am not sure why the warning was happening, and it is possible that this is a memory
  88         leak.
  89
  90 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
  91
  92         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
  93         and uri_parse_mailto() utility functions.
  94         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
  95         the mailto URI.
  96         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
  97
  98 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  99
 100         * src/dbus_api/modest-dbus-api.h:
 101         * src/dbus_api/modest-dbus-callbacks.c:
 102         Use an idle callback to execute the modest code in the application's own thread.
 103         Remove the helloworld example method.
 104         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 105         parsed, and the open-message method is not implemented because this is not yet implemented in
 106         modest itself.
 107         * libmodest-dbus-client/libmodest-dbus-client.c:
 108         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 109         (libmodest_dbus_client_open_message):
 110         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 111
 112         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 113         body without crashing.
 114
 115         * tests/dbus_api/Makefile.am:
 116         * tests/dbus_api/test_mail_to.c:
 117         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 118
 119 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 120
 121         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 122         Added file to fix the build. Sorry.
 123
 124         * src/dbus_api/Makefile.am:
 125         * src/dbus_api/modest-dbus-api.h:
 126         * src/dbus_api/modest-dbus-callbacks.h:
 127         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 128         (modest_dbus_req_handler):
 129         Put constants in a separate header so it can be reused by the
 130         client library, without duplication
 131
 132         * libmodest-dbus-client/Makefile.am:
 133         * libmodest-dbus-client/libmodest-dbus-client.c:
 134         (libmodest_dbus_client_call_helloworld),
 135         (libmodfest_dbus_client_send_mail),
 136         (libmodfest_dbus_client_mailto),
 137         (libmodfest_dbus_client_open_message):
 138         * libmodest-dbus-client/libmodest-dbus-client.h:
 139         (Partly) Implement a send_mail D-Bus method.
 140
 141         * tests/dbus_api/Makefile.am:
 142         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 143         the send_email D-Bus method.
 144
 145 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 146
 147         * Makefile.am:
 148         * configure.ac:
 149         * libmodest-dbus-client/Makefile.am:
 150         * libmodest-dbus-client/libmodest-dbus-client.c:
 151         * libmodest-dbus-client/libmodest-dbus-client.h:
 152         * tests/dbus_api/Makefile.am:
 153         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 154         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 155
 156 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 157
 158         * src/maemo/easysetup/modest-easysetup-wizard.c:
 159         (create_page_account_details):
 160         * src/maemo/modest-account-settings-dialog.c:
 161         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 162         widgets, because this might not be the default in future versions of the Maemo GTK+.
 163         However, I can not not get capitalization to work even in a simple test case.
 164
 165 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 166
 167         * src/maemo/easysetup/modest-easysetup-wizard.c:
 168         (create_page_custom_incoming), (create_page_custom_outgoing):
 169         * src/maemo/modest-account-settings-dialog.c:
 170         (create_page_account_details), (create_page_incoming),
 171         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 172         instead of using gtk_check_button_with_label(), so they are aligned like the other
 173         widgets, as per the UI spec.
 174
 175 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 176
 177         * src/maemo/easysetup/modest-easysetup-wizard.c:
 178         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 179         * src/widgets/modest-validating-entry.c:
 180         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 181         Modest prefix instead of an EasySetup prefix.
 182
 183 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 184
 185         * src/widgets/modest-validating-entry.h:
 186         * src/widgets/modest-validating-entry.c: (on_insert_text),
 187         Added easysetup_validating_entry_set_max_func(), used to set a callback
 188         to call when the max number of characters is reached. GtkEntry has a max-length
 189         already but is silent about it.
 190
 191         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 192         (create_page_account_details), (create_page_user_details),
 193         (create_account):
 194         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 195         (create_page_account_details), (create_page_user_details),
 196         (create_page_outgoing):
 197         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 198         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 199         the UI spec, when the user tries to enter more than the max number of characters.
 200
 201 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 202
 203         * src/maemo/easysetup/modest-easysetup-wizard.c:
 204         (create_page_user_details), (create_page_custom_incoming),
 205         (create_page_custom_outgoing):
 206         * src/maemo/modest-account-settings-dialog.c:
 207         (create_page_user_details), (create_page_incoming),
 208         (create_page_outgoing):
 209         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 210         (modest_connection_specific_smtp_edit_window_init):
 211         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 212         not appropriate. Bad Maemo-specific defaults!.
 213
 214 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 215
 216         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 217         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 218         (modest_signature_editor_dialog_set_settings):
 219         Disable the label and textview when the checkbox is disabled, and use the
 220         specified (UI spec) default signature text.
 221
 222 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 223
 224         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 225         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 226
 227         * src/modest-defs.h:
 228         * src/modest-account-mgr-helpers.h:
 229         * src/modest-account-mgr-helpers.c:
 230         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 231
 232         * src/maemo/Makefile.am:
 233         * src/maemo/modest-signature-editor-dialog.c:
 234         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 235         as per the UI spec.
 236
 237         * src/maemo/modest-account-settings-dialog.h:
 238         * src/maemo/modest-account-settings-dialog.c:
 239         (modest_account_settings_dialog_finalize), (on_button_signature),
 240         (save_configuration): Use the new dialog when the Edit button is pressed, and
 241         save the changes if necessary, as per the UI spec.
 242
 243 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 244
 245         * src/maemo/Makefile.am:
 246         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 247         based on maemo-develoers email from Dirk.
 248
 249         * src/maemo/easysetup/modest-easysetup-wizard.c:
 250         (create_page_welcome), (create_page_account_details),
 251         (create_page_user_details), (create_page_complete_easysetup),
 252         (create_page_custom_incoming), (create_page_custom_outgoing),
 253         (create_page_complete_custom),
 254         (modest_easysetup_wizard_dialog_init):
 255         * src/maemo/modest-account-settings-dialog.c:
 256         (create_page_account_details), (create_page_user_details),
 257         (create_page_incoming), (create_page_outgoing),
 258         (modest_account_settings_dialog_init):
 259         * src/maemo/modest-connection-specific-smtp-window.c:
 260         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 261
 262 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 263
 264         * src/maemo/easysetup/modest-easysetup-wizard.c:
 265         (create_page_account_details), (create_page_custom_outgoing),
 266         (create_page_complete_custom):
 267         * src/maemo/modest-account-settings-dialog.c:
 268         (create_page_user_details), (create_page_incoming),
 269         (create_page_outgoing):
 270         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 271         (modest_connection_specific_smtp_edit_window_init):
 272         Use the correct (UI spec) port min/max, and use horizontal separators,
 273         as per the UI spec.
 274
 275 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 276
 277         * src/maemo/easysetup/modest-easysetup-wizard.c:
 278         (set_default_custom_servernames):
 279         * src/maemo/modest-account-settings-dialog.c:
 280         (create_page_incoming), (on_combo_outgoing_security_changed),
 281         (on_combo_incoming_security_changed), (create_page_outgoing),
 282         (modest_account_settings_dialog_set_account_name),
 283         (save_configuration):
 284         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 285         (on_combo_security_changed),
 286         (modest_connection_specific_smtp_edit_window_init),
 287         (modest_connection_specific_smtp_edit_window_set_connection),
 288         (modest_connection_specific_smtp_edit_window_get_settings):
 289         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 290         as per the UI spec.
 291
 292 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 293
 294         * po/en_GB.po:
 295         * src/maemo/easysetup/modest-easysetup-wizard.c:
 296         (create_page_custom_outgoing), (create_page_complete_custom):
 297         * src/maemo/modest-account-settings-dialog.c:
 298         (create_page_user_details), (create_page_outgoing):
 299         * src/maemo/modest-account-view-window.c: (button_box_new):
 300         Use changed logical IDs as per the most recent UI spec:
 301         mcen_bd_emailsetup_edit -> mcen_bd_edit
 302         mcen_bd_emailsetup_delete -> mcen_bd_delete
 303         mcen_bd_emailsetup_close -> mcen_bd_close
 304
 305 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 306
 307         * configure.ac:
 308         * src/Makefile.am:
 309         * src/dbus_api/Makefile.am:
 310         * src/dbus_api/modest-dbus-callbacks.c:
 311         * src/dbus_api/modest-dbus-callbacks.h:
 312         * src/maemo/modest-platform.c: (modest_platform_init):
 313         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 314         method.
 315         * tests/Makefile.am:
 316         * tests/dbus_api/Makefile.am:
 317         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 318
 319 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 320
 321         * src/maemo/modest-account-settings-dialog.c:
 322         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 323         Removed unnecessary includes.
 324
 325 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 326
 327         * src/maemo/easysetup/modest-easysetup-wizard.c:
 328         * src/maemo/modest-account-settings-dialog.c:
 329         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 330         * src/widgets/Makefile.am:
 331         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 332         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 333         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 334         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 335         * src/widgets/modest-secureauth-combo-box.c:
 336         * src/widgets/modest-secureauth-combo-box.h:
 337         * src/widgets/modest-serversecurity-combo-box.c:
 338         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 339         made the GObject names more consistent with the rest of the Modest code.
 340
 341 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 342
 343         * src/maemo/easysetup/Makefile.am:
 344         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 345         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 346         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 347         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 348         * src/maemo/easysetup/modest-easysetup-wizard.c:
 349         * src/maemo/easysetup/modest-validating-entry.c:
 350         * src/maemo/easysetup/modest-validating-entry.h:
 351         * src/maemo/modest-account-settings-dialog.c:
 352         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 353         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 354         widgets/ because they are used outside of easysetup too. After checking in,
 355         svn will allow me to rename them too.
 356
 357 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 358
 359         * src/gnome/modest-msg-edit-window.c:
 360         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 361         linker error, to fix the build on the GNOME platform.
 362         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 363         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 364         ifdefed out to avoid a warning.
 365
 366 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 367
 368         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 369         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 370         some alternative for GTK+ 2.6.
 371
 372 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 373
 374         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 375
 376         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 377         specified for EmailAccountsDialog in UI spec.
 378
 379         * src/maemo/easysetup/modest-easysetup-wizard.c:
 380         * src/maemo/easysetup/modest-easysetup-wizard.h:
 381         * src/maemo/modest-account-settings-dialog.c:
 382         * src/maemo/modest-account-settings-dialog.h:
 383         Reuse a member window widget for the connection-specific SMTP server accounts,
 384         so we can tell it to create/save the accounts only if we actually save changes.
 385
 386         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 387         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 388         (modest_connection_specific_smtp_edit_window_get_settings):
 389         Return a struct instance for temporarily remembering the entered data.
 390
 391         * src/maemo/modest-connection-specific-smtp-window.h:
 392         * src/maemo/modest-connection-specific-smtp-window.c:
 393         (modest_connection_specific_smtp_window_finalize),
 394         (modest_connection_specific_smtp_window_fill_with_connections),
 395         (on_button_edit),
 396         (modest_connection_specific_smtp_window_save_server_accounts),
 397         (update_model_server_names): Do not actually save data until asked,
 398         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 399
 400         (on_selection_changed),
 401         (modest_connection_specific_smtp_window_init): Disable the edit
 402         button when nothing is selected.
 403
 404         * src/modest-account-mgr-helpers.c:
 405         * src/modest-account-mgr-helpers.h:
 406         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 407         elsewhere.
 408
 409 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 410
 411         * src/modest-account-mgr-helpers.h:
 412         * src/modest-account-mgr-helpers.c:
 413         (modest_account_mgr_get_unused_account_name),
 414         (modest_account_mgr_get_unused_account_display_name): Added these
 415         utility functions, to avoid code duplication.
 416
 417         * src/maemo/easysetup/modest-easysetup-wizard.c:
 418         (create_page_account_details), (create_account):
 419         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 420         (on_combo_security_changed),
 421         (modest_connection_specific_smtp_edit_window_init),
 422         (modest_connection_specific_smtp_edit_window_save_settings):
 423         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 424         * src/maemo/modest-connection-specific-smtp-window.c:
 425         (modest_connection_specific_smtp_window_finalize),
 426         (modest_connection_specific_smtp_window_fill_with_connections),
 427         (on_button_edit), (modest_connection_specific_smtp_window_init):
 428         * src/maemo/modest-connection-specific-smtp-window.h:
 429         Implementing saving of connection-specific server accounts.
 430
 431         But I need to refactor this so we can save the data for each
 432         possible connection-specific account and only actually create the server accounts
 433         when the easysetup finished, or the OK button is pressed on the account settings
 434         dialog.
 435
 436 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 437
 438         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 439         (on_combo_security_changed):
 440         (modest_connection_specific_smtp_edit_window_init):
 441         Auto-fill the port number as in the account settings.
 442
 443         (modest_connection_specific_smtp_edit_window_set_connection):
 444         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 445         * src/maemo/modest-connection-specific-smtp-window.c:
 446         (fill_with_connections), (on_button_edit),
 447         (modest_connection_specific_smtp_window_init):
 448         Turn the edit window into a dialog to simplify the code, and
 449         set a WM hint as in a GtkDialog, because only a popup can be on top of
 450         another window in Maemo, and popups usually have no WM decoration.
 451
 452         * src/modest-defs.h:
 453         * src/modest-account-mgr-helpers.c:
 454         (modest_account_mgr_set_connection_specific_smtp),
 455         (modest_account_mgr_remove_connection_specific_smtp),
 456         (modest_account_mgr_get_connection_specific_smtp):
 457         * src/modest-account-mgr-helpers.h: Some functions to write the
 458         connection-specific SMTP server information. Not yet used.
 459
 460
 461         * src/widgets/modest-folder-view.c: (text_cell_data):
 462         Fix a warning about an uninitialized variable.
 463         (on_configuration_key_changed): Put an #ifdef around the use
 464         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 465
 466 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 467
 468         * src/maemo/modest-account-settings-dialog.h:
 469         * src/maemo/modest-account-settings-dialog.c:
 470         Added connect_for_modified() utility function to mark the new modified boolean.
 471
 472         (create_page_account_details), (create_page_user_details),
 473         (create_page_incoming), (create_page_outgoing), (on_response),
 474         (modest_account_settings_dialog_init),
 475         (modest_account_settings_dialog_set_account_name):
 476         Only warn about unsaved changes when there are actually unsaved changes.
 477
 478         * src/modest-account-mgr-helpers.c:
 479         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 480         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 481         to get the data from there in future.
 482
 483 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 484
 485         * src/modest-defs.h:
 486
 487         * src/modest-account-mgr-helpers.h:
 488         * src/modest-account-mgr-helpers.c:
 489         Store the security account setting in a single conf key instead of using
 490         the options list, so that the list is left for just the to-be-removed camel hack,
 491         and because gconf_client_set_list() is failing for some reason.
 492
 493         * src/modest-account-mgr.c:
 494         (modest_account_mgr_add_server_account):
 495         * src/maemo/modest-account-settings-dialog.c:
 496         (modest_account_settings_dialog_set_account_name),
 497         (save_configuration): Use the renamed functions.
 498
 499
 500 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 501
 502         * src/widgets/Makefile.am:
 503         * src/widgets/modest-limit-retrieve-combo-box.c:
 504         * src/widgets/modest-limit-retrieve-combo-box.h:
 505         * src/widgets/modest-retrieve-combo-box.c:
 506         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 507         the account settings dialog.
 508
 509         * src/modest-defs.h:
 510         * src/modest-account-mgr-helpers.h:
 511         * src/modest-account-mgr-helpers.c:
 512         (modest_server_account_get_option_secure_auth),
 513         (modest_server_account_set_option_secure_auth):
 514         * src/modest-account-mgr.c:
 515         (modest_account_mgr_add_server_account):
 516         Use the existing AUTH_MECH conf key for the secure-auth setting,
 517         instead of putting it in the list options, because this was actually used already.
 518
 519         * src/maemo/modest-account-settings-dialog.c:
 520         (create_page_account_details),
 521         (modest_account_settings_dialog_set_account_name),
 522         (save_configuration):
 523         * src/maemo/modest-account-settings-dialog.h:
 524         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 525         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 526
 527 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 528
 529         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 530         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 531         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 532
 533         * src/modest-defs.h:
 534         * src/maemo/modest-account-settings-dialog.c:
 535         (create_page_incoming), (on_combo_outgoing_security_changed),
 536         (on_combo_incoming_security_changed), (create_page_outgoing),
 537         (modest_account_settings_dialog_set_account_name),
 538         (save_configuration): Load/Save the port number, and change it when the
 539         security combo changes, to suitable defaults.
 540
 541 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 542
 543         * src/modest-account-mgr.c:
 544         (modest_account_mgr_add_server_account): Set the security and secure-auth
 545         options, and add a comment saying that the other camel-specific options should be
 546         removed in future.
 547
 548 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 549
 550         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 551         found by valgrind.
 552         * src/modest-tny-account-store.c: (account_list_free),
 553         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 554         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 555         easy to fix.
 556
 557 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 558
 559         * src/modest-protocol-info.c:
 560         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 561         is required by our UI spec. Maybe something in our implementation will use this eventually.
 562         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 563         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 564         instead of the previous 0 placeholder.
 565
 566         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 567         secure-auth settings.
 568         * src/modest-account-mgr-helpers.h:
 569         * src/modest-account-mgr-helpers.c:
 570         (modest_server_account_data_get_option_secure_auth),
 571         (modest_server_account_set_option_secure_auth),
 572         (modest_server_account_data_get_option_security),
 573         (modest_server_account_set_option_security): Added this API for getting and setting the security
 574         and secure-auth settings.
 575
 576         * src/maemo/modest-account-settings-dialog.h:
 577         * src/maemo/modest-account-settings-dialog.c:
 578         (modest_account_settings_dialog_finalize), (check_data),
 579         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 580         about changing titles.
 581         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 582         (save_configuration): Save the security and secure-auth settings.
 583
 584         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 585         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 586
 587 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 588
 589         * src/modest-defs.h:
 590         * src/modest-account-mgr.c:
 591         (modest_account_mgr_add_server_account):
 592         Added and used defines for the options key and value pair strings,
 593         that are used so far, though they do not seem to correspond to anything in our
 594         UI specs or ModestProtocol enum.
 595
 596         * src/modest-account-mgr-helpers.h:
 597         * src/modest-account-mgr-helpers.c:
 598         (compare_option_strings_for_name),
 599         (modest_server_account_data_get_option_value),
 600         (modest_server_account_data_get_option_bool),
 601         (modest_account_mgr_get_server_account_option):
 602         Added helper functions for parsing the options GSList.
 603
 604 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 605
 606         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 607         display name is based on the supplied account name.
 608         * src/modest-account-mgr.c:
 609         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 610         with an inefficient, but good-enough, implementation.
 611
 612         * src/maemo/easysetup/modest-easysetup-wizard.c:
 613         (create_page_account_details), (on_before_next), (create_account):
 614         Check for existing display names rather than (non-user-visible) account names, and just
 615         create and set a unique account name at the end.
 616
 617         * src/maemo/modest-account-settings-dialog.c:
 618         (modest_account_settings_dialog_init),
 619         (modest_account_settings_dialog_set_account_name),
 620         (create_page_incoming): Show the display name, instead of the account name.
 621         (on_response): Do some (not all) extra checks, as in the UI spec.
 622         (save_configuration): Save the display name if it was changed.
 623
 624 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 625
 626         * po/en_GB.po: Added needed logical ID and translation.
 627         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 628         (init_view): Made the is-default column clicking work.
 629
 630 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 631
 632         * configure.ac:
 633         * src/maemo/easysetup/Makefile.am:
 634         * src/maemo/easysetup/modest-easysetup-wizard.c:
 635         (modest_easysetup_wizard_dialog_init):
 636         * src/maemo/easysetup/provider-data-test.keyfile:
 637         * src/maemo/easysetup/provider-data.keyfile:
 638         Moved the provider data file to the new modest-providers-data package and used it from there.
 639
 640 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 641
 642         * src/modest-local-folder-info.c:
 643         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 644         N_() was already used on the static strings, but this just marks it for translation without
 645         using the translation.
 646
 647 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 648
 649         * src/maemo/modest-account-settings-dialog.c:
 650         (create_page_incoming),
 651         (modest_account_settings_dialog_set_account_name):
 652         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 653         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 654         I will do this if nobody else gets there first.
 655
 656 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 657
 658         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 659         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 660         save the security stuff.
 661
 662 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 663
 664         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 665         Set the email address and user fullname, which I now see must be
 666         done separately.
 667
 668         * src/maemo/modest-account-settings-dialog.h:
 669         * src/maemo/modest-account-settings-dialog.c:
 670          (on_response),
 671         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 672         leave-on-server and authentication.
 673         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 674         how to do the rest.
 675
 676 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 677
 678
 679         * src/maemo/modest-account-settings-dialog.c:
 680         * src/maemo/modest-account-settings-dialog.h:
 681         Most (but not all) of the widgets are now present as specified by the UI spec.
 682         No changes are yet saved, and some details are not properly shown yet.
 683
 684         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 685
 686 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 687
 688         * src/maemo/Makefile.am:
 689         * src/maemo/modest-account-settings-dialog.c:
 690         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 691         an existing account. Doesn't do much yet.
 692
 693         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 694         Open the accounts settings dialog when Edit is clicked.
 695
 696 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 697
 698         * src/maemo/easysetup/Makefile.am:
 699         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 700         (load_from_file):
 701         * src/maemo/easysetup/modest-easysetup-wizard.c:
 702         (modest_easysetup_wizard_dialog_init):
 703         Try to get the source directory from the build system,
 704         instead of hard-coding "./" into the source code, when opening our local
 705         copies of the configuration files.
 706         But this still fails when opening the wizard from the Accounts window,
 707         maybe because the working directory seems to change at runtime.
 708         So the wizard will fail the second time unless you copy the files into their
 709         proper locations - see the stdout warnings for the paths.
 710
 711         (create_page_account_details),(on_before_next):
 712         Check for existing non-server accounts instead of server accounts,
 713         so the default account name is useful again, and to prevent trying to
 714         recreate accounts.
 715
 716         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 717         Show the wizard when New is clicked.
 718
 719         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 720         (init_view): Show the column headers, and show the columns that are
 721         specified in the UI specs. However, something in Maemo's GTK+ prevents
 722         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 723         change the default account. This is despite unsetting the special properties.
 724
 725 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 726
 727         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 728         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 729         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 730         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 731         to make that clearer.
 732         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 733
 734 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 735
 736         * src/maemo/modest-account-view-window.c:
 737         (modest_account_view_window_init),
 738         (modest_account_view_window_new):
 739         Use the same buttons as specified in the
 740         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 741         the existing widgets, which never had a chance of working.
 742         Put the ModestAccountView treeview in a scrolled window.
 743         Do not repeat the initialization in both _init() and _new().
 744
 745         * src/widgets/modest-account-view.c: (update_account_view):
 746         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 747         this widget and window shows no accounts.
 748
 749         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 750
 751 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 752
 753         * src/maemo/easysetup/modest-easysetup-wizard.c:
 754         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 755         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 756         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 757         which seems wrong.
 758
 759         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 760         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 761         accounts exist yet, as in the UI spec.
 762
 763         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 764
 765 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 766
 767         * src/maemo/Makefile.am:
 768         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 769         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 770         New window for editing connection-specific smtp details.
 771         Not fully implemented.
 772
 773         * src/maemo/modest-connection-specific-smtp-window.c:
 774         (modest_connection_specific_smtp_window_finalize) :
 775         unref the tree model.
 776         (on_button_edit): Show the edit window.
 777
 778 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 779
 780         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 781         error for me.
 782
 783         * src/maemo/Makefile.am:
 784         * src/maemo/modest-connection-specific-smtp-window.c:
 785         * src/maemo/modest-connection-specific-smtp-window.h:
 786         New window for showing the list of connections, for connection-specific
 787         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 788         * src/maemo/easysetup/modest-easysetup-wizard.c:
 789         (create_page_custom_outgoing): Show the new window when the button is clicked.
 790
 791 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 792
 793         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 794         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 795         * src/maemo/modest-msg-edit-window.c:
 796         (modest_msg_edit_window_insert_image):
 797         * src/modest-conf.c: (modest_conf_key_escape):
 798         * src/modest-mail-operation.c:
 799         (modest_mail_operation_send_new_mail):
 800         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 801         (modest_ui_actions_on_new_account):
 802         * src/widgets/modest-attachment-view.c: (update_filename_request):
 803         * src/widgets/modest-mail-header-view.c:
 804         Corrected warnings that were breaking the build, by commenting out unused variables,
 805         and a function, and by including a header.
 806
 807 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 808
 809         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 810         so we can #ifdef around platform-specific code when necessary.
 811         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 812         to allow this to build for the GNOME platform too.
 813
 814 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 815
 816         * src/maemo/easysetup/modest-easysetup-wizard.c:
 817         Added util_increment_name() and used it in create_page_account_details()
 818         to make sure that the default account name is always a new name.
 819
 820         (modest_easysetup_wizard_dialog_init),
 821         (set_default_custom_servernames): Some minor memory management fixes.
 822
 823 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 824
 825         * Makefile.am:
 826         * configure.ac:
 827         * src/modest-runtime.c: (init_i18n): Restored the translation
 828         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 829         are defined in config.h, and the translations are installed.
 830
 831         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 832         is defined for translation.
 833
 834 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 835
 836         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 837         (load_from_file):
 838         * src/maemo/easysetup/modest-easysetup-wizard.c:
 839         (modest_easysetup_wizard_dialog_init):
 840         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 841         Use realistic paths (though they should use $prefix generically) to the
 842         mcc_mapping and provider-data.keyfile files which might work when they
 843         are installed by the future version of the operator-wizard package,
 844         and then fallback to paths in our source code, with an explanatory
 845         warning.
 846
 847 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 848
 849         * configure.ac:
 850         * src/Makefile.am:
 851         * src/maemo/Makefile.am:
 852         * src/maemo/easysetup/: Added files from the previously-exernal
 853         osso-modest-easysetup.
 854         * src/maemo/modest-main-window-ui.h:
 855         * src/modest-ui-actions.c:
 856         * src/modest-ui-actions.h:
 857         Added modest_ui_actions_on_new_account() as a signal handler for the
 858         New Account menu item. It shows the easysetup wizard.
 859         * po/en_GB.po: Added additional needed logical IDs and translations.
 860
 861 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 862 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 863