1 2007-07-05 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
4 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
5 to fix projects.maemo.org bug NB#62439.
7 2007-07-05 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-tny-account.c: (on_connection_status_changed):
10 Really do not use tny_device_force_offline() here. See the previous comment.
12 2007-07-04 Murray Cumming <murrayc@murrayc.com>
14 * src/modest-tny-account.c: (on_connection_status_changed):
15 Do not use tny_device_force_offline() when tinymail says that something
16 went wrong with the connection. It seems to report this unnecessarily.
18 2007-07-04 Murray Cumming <murrayc@murrayc.com>
20 * src/maemo/modest-connection-specific-smtp-window.c:
21 (modest_connection_specific_smtp_window_init):
22 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
23 does not seem to have any effect in osso 1.1 (though it works in
24 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
26 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
28 * src/maemo/modest-connection-specific-smtp-window.c:
29 Fix UI specification problems with projects.meamo.org NB#60479
31 2007-07-04 Murray Cumming <murrayc@murrayc.com>
33 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
34 clue when this has failed, because the error dialog is not always shown
35 (at least in earlier version).
37 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
38 GError message, because the generic error dialog is not helpful.
40 'This message is not currently available (can't let a new connection go online)'
41 when trying to open an IMAP message.
43 (_modest_ui_actions_open): Offer a connection when some messages would
44 have to be downloaded and we are offline.
46 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
48 * src/widgets/modest-folder-view.c:
49 Don't check for MERGE type anymore as we use the correct type
51 NOTE: For the last two changes you need to update your tinymail copy
52 because of API changes!
54 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
56 * src/modest-tny-local-folders-account.c:
57 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
58 (see projects.maemo.org NB#61580)
60 2007-07-04 Murray Cumming <murrayc@murrayc.com>
62 * src/modest-tny-account.c: (on_connection_status_changed):
63 Commented out the call to modest_platform_connect_and_wait() because this
64 seems to always hang, and I would like to know if this is the only thing
65 that causes a hang when showing the connection dialog.
66 It is not very useful anyway.
68 2007-07-04 Murray Cumming <murrayc@murrayc.com>
70 * src/maemo/modest-msg-view-window.c:
71 (modest_msg_view_window_select_next_message):
73 * src/modest-platform.h:
74 * src/maemo/modest-platform.c:
75 Added modest_platform_connect_and_wait(), which calls
76 tny_maemo_conic_device_connect() always in the main thread, by calling it
77 in an idle handler and waiting for the idle handler to run. It should be
78 in the main thread because it uses GTK+ UI code. It just returns TRUE
79 if the device is already online.
81 There is some nasty code to ensure that subsequent calls to
82 modest_platform_connect_and_wait() just wait for the first one to finish,
83 by checking repeatedly in another idle handler. This is necessary,
84 because other threads (or even the main thread, via another idle handler)
85 can call modest_platform_connect_and_wait() while
86 modest_platform_connect_and_wait() is running.
88 (modest_platform_connect_and_wait_if_network_account),
89 (modest_platform_connect_and_wait_if_network_folderstore):
90 Convenience functions that calls modest_platform_connect_and_wait() if
91 the account or folder might want network access.
93 * src/modest-mail-operation.c:
94 (modest_mail_operation_update_account):
95 * src/modest-ui-actions.c: (download_uncached_messages),
96 (modest_ui_actions_on_rename_folder), (delete_folder),
97 (modest_ui_actions_on_main_window_move_to),
98 (modest_ui_actions_on_msg_view_window_move_to):
99 * src/widgets/modest-folder-view.c:
100 (drag_and_drop_from_folder_view):
101 Offer a connection if we are offline.
103 * src/modest-tny-account.c: (on_connection_status_changed):
104 Document this as only handling errors during network operations in progress,
105 and replace the idle code with a simple call to
106 modest_platform_connect_and_wait(), which does this instead.
108 2007-07-03 Murray Cumming <murrayc@murrayc.com>
110 * src/modest-tny-account.c:
111 (modest_tny_account_get_special_folder): (util_on_idle),
112 Handle the GError so we can see when tny_folder_store_get_folders()
113 fails, as it currently does while something else is connecting.
115 Added util_run_in_main_thread_and_wait()
116 which uses an idlen handler and mainloop to ensure that the function
117 is called in the main thread.
118 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
119 to make sure that we call attempt the connection in the mainloop only,
120 which might solve some hangs.
122 2007-07-03 Murray Cumming <murrayc@murrayc.com>
124 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
125 be found by their display name. This is never useful.
126 * src/modest-tny-account-store.c: (on_account_removed): Find the account
127 by its ID, instead of trying to use its ID as its display name.
129 * src/modest-tny-account-store.h:
130 * src/modest-tny-account.c:
131 (modest_tny_account_get_special_folder): Add a g_warning() when
132 tny_folder_store_get_folders() returns an empty list for the maildir.
134 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
135 Add a g_warning() when this returns NULL, because that it not allowed
138 2007-07-02 Armin Burgmeier <armin@openismus.com>
140 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
141 note when trying to cancel the wizard. This fixes projects.maemo.org
144 2007-07-02 Murray Cumming <murrayc@murrayc.com>
146 * src/modest-tny-account.h:
147 * src/modest-tny-account.c:
148 (modest_tny_account_new_from_server_account),
149 (modest_tny_account_new_from_server_account_name),
150 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
151 because this must now be set before setting the proto. This is usd in
152 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
153 warning in camel_session_get_service() caused by
154 tny_camel_transport_account_prepare().
156 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
159 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
161 * src/maemo/modest-connection-specific-smtp-edit-window.c:
163 (modest_connection_specific_smtp_edit_window_init):
165 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
168 2007-06-29 Murray Cumming <murrayc@murrayc.com>
170 * src/modest-tny-account.c:
171 (modest_tny_account_new_from_server_account):
172 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
173 now uses to request a connection when it needs one, and which it uses
174 to tell us that something is wrong with the connection, so we can force
175 the accounts offline to prevent further problems.
178 * src/modest-init.c: (init_default_settings):
179 * src/modest-mail-operation.c:
180 (modest_mail_operation_update_account):
181 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
182 This should not be necessary anymore. Do not set the conf key that
183 determined this (it was always TRUE and not set anywhere else).
185 * src/modest-ui-actions.h: Remove unused and unimplemented
186 modest_ui_actions_on_online_toggle_toggled().
188 2007-06-29 Murray Cumming <murrayc@murrayc.com
190 * src/maemo/modest-main-window.c: (connect_signals):
191 Don't connect to delete_event twice. Maybe this was harmless.
193 2007-06-29 Murray Cumming <murrayc@murrayc.com
195 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
196 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
197 Debug output to give some more clue when a folder move is not allowed.
199 2007-06-28 Murray Cumming <murrayc@murrayc.com
201 * src/modest-tny-account.c: (on_modest_file_system_info),
202 (modest_tny_account_get_mmc_account_name):
203 Always call the callback, without checking whether the name has changed.
204 * src/widgets/modest-folder-view.c: (strings_are_equal),
205 (on_model_foreach_set_name), (on_get_mmc_account_name),
206 (text_cell_data): Compare the name here, and use the name from
207 the account rather than from the
208 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
209 if the name was changed after the account was added to the model.
210 That's a tinymail bug but not one that I want to fix now.
212 This finally fixes projects.maemo.org bug NB#59301.
214 2007-06-27 Armin Burgmeier <armin@openismus.com>
216 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
219 2007-06-27 Murray Cumming <murrayc@murrayc.com
221 * src/modest-tny-account.h:
222 * src/modest-tny-account.c:
223 Added modest_tny_account_get_mmc_account_name(), to set the memory
224 card name asynchronously for the given account and then notify.
225 (modest_tny_account_new_for_local_folders): Use this new function instead
226 of using hildon_file_system_info_async_new() directly.
228 * src/widgets/modest-folder-view.c: (text_cell_data):
229 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
230 gtk_tree_model_row_changed() when it is available.
232 This should fix projects.maemo.org bug NB#59301.
234 2007-06-27 Murray Cumming <murrayc@murrayc.com
236 * src/modest-mail-operation.c: (update_account_thread),
237 (get_msgs_full_thread): Fix typo failures in the revert
240 2007-06-27 Murray Cumming <murrayc@murrayc.com
242 * src/maemo/modest-maemo-global-settings-dialog.c:
243 (idle_select_default_focus):
244 * src/modest-mail-operation.c: (idle_notify_progress),
245 (idle_notify_progress_once), (set_last_updated_idle),
246 (update_account_thread), (get_msgs_full_thread):
247 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
248 * src/widgets/modest-header-view.c:
249 (idle_notify_headers_count_changed_destroy),
250 (idle_notify_headers_count_changed):
251 Reverted the additions of gdk_threads_enter/leave(), in case this
252 helps with a startup hang on the device.
254 2007-06-26 Armin Burgmeier <armin@openismus.com>
256 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
257 for supported secure authentication methods from server by
258 gtk_dialog_run(), saving CPU time and a potential race condition.
260 2007-06-26 Armin Burgmeier <armin@openismus.com>
262 * src/maemo/modest-maemo-utils.h:
263 * src/maemo/modest-maemo-utils.c: Added a
264 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
265 only error code to tell the calling code when the user canceled the
268 * src/maemo/modest-account-settings-dialog.h:
269 * src/maemo/modest-account-settings-dialog.c:
270 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
271 message if the retrieval of secure authentication methods was canceled
272 by the user. Perform the check before saving anything to configuration
273 to not end up with half-committed configuration changes, do not show
274 a "Saving to configuration failed" note when authentication methods
275 could not be retrieved.
277 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
280 2007-06-26 Murray Cumming <murrayc@murrayc.com>
282 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
283 Only return the first level of folders under accounts, because the
284 osso-global-search UI spec doesn't want the rest.
285 This fixed projects.maemo.org bug NB#61811.
287 2007-06-26 Murray Cumming <murrayc@murrayc.com>
289 * src/modest-tny-account-store.c:
290 * src/modest-tny-account-store.h:
291 Added modest_tny_account_is_memory_card_account().
292 * src/maemo/modest-main-window.c: (create_details_widget):
293 Show the same information items for the memory card as we show for the
294 local-folders, to fix projects.maemo.org bug NB#59307.
296 2007-06-26 Murray Cumming <murrayc@murrayc.com>
298 * src/modest-tny-account-store.c: (get_password):
299 Added some checks for NULL to maybe prevent crashes, though I think
300 it was Philip's last commit that actually prevented the crash here
301 when creating a first new account.
302 But the new account is still not usable (no messages are shown)
303 until a restart of the application.
305 2007-06-26 Murray Cumming <murrayc@murrayc.com>
307 * src/maemo/modest-maemo-global-settings-dialog.c:
308 (idle_select_default_focus):
309 * src/modest-mail-operation.c: (idle_notify_progress),
310 (idle_notify_progress_once), (idle_notify_update_account_queue),
311 (set_last_updated_idle), (update_account_thread),
312 (notify_get_msgs_full), (get_msgs_full_destroyer),
313 (get_msgs_full_thread):
314 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
315 * src/widgets/modest-header-view.c:
316 (idle_notify_headers_count_changed_destroy),
317 (idle_notify_headers_count_changed):
318 Use gdk_threads_enter() and gdk_threads_enter_leave() in
319 all idle handlers, because some other thread could be blocking
320 the GDK lock, so that it can do GUI stuff.
322 2007-06-26 Murray Cumming <murrayc@murrayc.com>
324 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
325 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
326 (on_idle_send_receive), (on_idle_open_default_inbox):
327 * src/maemo/modest-msg-edit-window.c:
328 (modest_msg_edit_window_attach_file_noninteractive):
329 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
330 to prevent a hang. I don't quite understand why these are necessary,
331 beause we should already be in the main loop. I guess something outside
332 of the main loop is taking the lock.
334 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
335 we are really using URIs, and use files that are more likely to exist.
337 2007-06-26 Murray Cumming <murrayc@murrayc.com>
339 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
340 necessary because configure.ac now defines different variables.
342 2007-06-26 Murray Cumming <murrayc@murrayc.com>
344 * libmodest-dbus-client/libmodest-dbus-client.c:
345 * libmodest-dbus-client/libmodest-dbus-client.h:
346 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
347 libmodest_dbus_client_compose_mail() is what things actually use.
349 * src/dbus_api/modest-dbus-api.h:
350 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
351 * tests/dbus_api/Makefile.am:
352 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
355 2007-06-26 Murray Cumming <murrayc@murrayc.com>
357 * src/modest-init.c: (modest_init_local_folders):
358 For memory-card (or other non local-folders) maildir accounts,
359 always create an Archive folder, so that there is somewhere to put
360 messages. This should be less confusing, because the user does not need
361 to guess that the need to create a folder.
363 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
365 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
366 Fixed icon size by using (50, 50) which is the same as defined by
369 2007-06-25 Armin Burgmeier <armin@openismus.com>
371 * src/widgets/modest-window-mgr.c:
373 * configure.ac: Correctly recognize hildon-notify presence and fixed
374 the build without it being installed.
376 2007-06-25 Murray Cumming <murrayc@murrayc.com>
378 * libmodest-dbus-client/libmodest-dbus-client.c:
379 (libmodest_dbus_client_search): Fix the build. Sorry.
380 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
381 (reply_forward_cb): Initialize variables to fix the build.
383 * src/modest-tny-account-store.c:
384 (modest_tny_account_store_get_tny_account_by): Fix the account URI
385 comparison (a silly typo) so that email search results can be opened
386 when there are more than one account.
388 2007-06-25 Murray Cumming <murrayc@murrayc.com>
390 * libmodest-dbus-client/libmodest-dbus-client.c:
391 (libmodest_dbus_client_search),
392 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
393 instead of 1 second, because the search gets folders and messages from
394 the server, which can take a long time. When it times out,
395 osso-global-search will report no results.
397 We need to specify whether we should search only cached information
398 (maybe with a user preference), and the osso-email-search-plugin
399 API should really be improved to allow that option, and to allow results
400 to be delivered asynchronously in batches.
402 2007-06-25 Murray Cumming <murrayc@murrayc.com>
404 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
405 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
406 GTK_ICON_SIZE_DIALOG is probably the wrong size.
408 2007-06-25 Murray Cumming <murrayc@murrayc.com>
410 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
411 that is an empty string. D-Bus seems to give us these instead of NULL.
413 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
415 * src/dbus_api/modest-dbus-callbacks.c:
416 * src/maemo/easysetup/modest-easysetup-wizard.h:
417 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
418 * src/maemo/modest-connection-specific-smtp-edit-window.c:
419 (modest_connection_specific_smtp_edit_window_init):
420 * src/maemo/modest-maemo-global-settings-dialog.c:
422 * src/maemo/modest-maemo-utils.c:
423 (modest_maemo_utils_setup_images_filechooser):
424 * src/maemo/modest-main-window.c: (create_details_widget):
425 * src/maemo/modest-msg-edit-window.c:
426 (modest_msg_edit_window_attach_file_noninteractive),
427 (modest_msg_edit_window_color_button_change),
428 (modest_msg_edit_window_set_zoom):
429 * src/modest-mail-operation.c: (update_account_thread):
430 * src/modest-tny-account-store.c:
431 * src/modest-tny-account.c:
432 * src/widgets/modest-global-settings-dialog.c:
433 * src/widgets/modest-window.h:
437 2007-06-25 Murray Cumming <murrayc@murrayc.com>
439 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
440 * src/modest-search.c: (modest_search_folder),
441 (modest_search_all_accounts): Actually search only in the specified folder,
442 doing a simple match on the folder ID.
443 * src/modest-search.h: Added a folder field to the ModestSearch struct,
444 and added some documentation.
446 2007-06-22 Armin Burgmeier <armin@openismus.com>
448 * src/maemo/modest-maemo-utils.h:
449 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
450 modest_maemo_utils_get_supported_secure_authentication_methods.
452 * src/maemo/easysetup/modest-easysetup-wizard.c:
453 * src/maemo/modest-account-settings-dialog.c: Show correct error if
454 one occured, not just "Server does not support secure authentication".
456 2007-06-22 Murray Cumming <murrayc@murrayc.com>
458 * src/modest-tny-account-store.c: (get_password):
459 Restored the call to tny_account_set_user() because Philip seems to have
460 stopped this from crashing (by not using the freed string). It still does
461 not work, but now we can test it.
463 2007-06-22 Murray Cumming <murrayc@murrayc.com>
465 * src/maemo/modest-msg-edit-window.c: (init_window):
466 Comment out use of an uninitialzed GtkScrolledWindow variable,
467 to fix the build and stop a crash. Yet again.
469 2007-06-22 Murray Cumming <murrayc@murrayc.com>
471 * src/modest-tny-account-store.c: (get_password):
472 Remove the call to tny_account_set_user() because this actually crashes.
473 As mentioned in the last commit, it is known to not work anyway.
475 2007-06-22 Murray Cumming <murrayc@murrayc.com>
477 * src/modest-tny-account-store.c: (get_password):
478 Use tny_account_set_username() to tell tinymail that the username might
479 have changed too. But tinymail ignores this: see projects.maemo.org
481 * src/modest-ui-actions.c:
482 (modest_ui_actions_on_password_requested): Remove the useless attempt to
483 reset the connection when changing the username, and improve the comments.
484 Save the changed username to gconf at least, so it is used when Modest is
487 2007-06-21 Murray Cumming <murrayc@murrayc.com>
489 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
490 Do not use a query, so that we get all folders, including for POP and
491 local-folders. They work as search criteria too.
492 This fixes projects.maemo.org bug NB#57740.
494 2007-06-21 Murray Cumming <murrayc@murrayc.com>
496 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
497 Comment out the use of hildon_notification_set_sound() because it is
498 not declared, to fix the build. Warnings are serious, people.
500 2007-06-21 Armin Burgmeier <armin@openismus.com>
502 * src/maemo/modest-maemo-utils.h:
503 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
504 modest_maemo_utils_get_supported_secure_authentication_methods()
505 to query authentication methods for a specific user. This should fix
506 projects.maemo.org bug NB#61369.
508 * src/maemo/easysetup/modest-easysetup-wizard.c:
509 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
512 2007-06-21 Murray Cumming <murrayc@murrayc.com>
514 * libmodest-dbus-client/libmodest-dbus-client.h:
515 * libmodest-dbus-client/libmodest-dbus-client.c:
516 (modest_dbus_message_iter_get_search_hit),
517 (libmodest_dbus_client_search):
518 Reorganised and commented this.
519 Removed modest_search_hit_free() from the public API because it
522 Added libmodest_dbus_client_get_folders() and
523 modest_folder_result_list_free().
525 * src/dbus_api/modest-dbus-api.h:
526 * src/dbus_api/modest-dbus-callbacks.c:
527 (modest_dbus_req_filter): Commented. Moved most code to
528 on_dbus_method_search() and added on_dbus_method_get_folders().
530 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
531 of the extra D-Bus handler.
533 * tests/dbus_api/Makefile.am:
534 * tests/dbus_api/test_get_folders.c: New test for
535 libmodest_dbus_client_get_folders(). This seems to return an empty list
536 at the moment. That could be the same error that causes the message list
537 to be empty sometimes.
538 This should help with projects.maemo.org bug NB#57740.
540 2007-06-21 Armin Burgmeier <armin@openismus.com>
542 * src/modest-mail-operation.c: Do not call
543 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
544 notify the operation's end after having set the status to CANCELED for
545 the operation queue to listen on. This fixes a deadlock when there
546 were mail operations in the queue during its finalization.
548 * src/modest-singletons.c: Reordered uninitialization of the account
549 manager to happen after the mail operation queue was uninitialized
550 because the mail operation's in the queue might still try to access
551 the account manager (see modest_mail_operation_notify_end()). This
552 fixes a potential crash when terminating the application.
554 2007-06-21 Murray Cumming <murrayc@murrayc.com>
556 * src/modest-search.c:
557 (search_mime_part_and_child_parts): Moved some code here so we
558 can search recursively in child folders.
559 (modest_search_folder): Search in the message as a mime part, instead
560 of just its child mime parts.
561 (read_chunk), (search_mime_part_ogs):
562 Check how many bytes were read, to prevent an endless loop.
563 Searching in message bodies now works. This finishes the fix for
564 projects.maemo.org bug NB#61007.
566 2007-06-20 Murray Cumming <murrayc@murrayc.com>
568 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
569 Add a g_warning when the item is not a folder.
571 * src/modest-ui-dimming-rules.c:
572 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
573 when selected item is not a folder (for instance, an account), because
574 the UI spec only talks about folders.
575 I am not sure what the UI spec wants, so this might not totally fix
576 projects.maemo.org bug NB#60794.
578 2007-06-20 Murray Cumming <murrayc@murrayc.com>
580 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
581 (load_from_file): Sort the list. The unsorted list would be more noticeable
582 in non-English locales.
584 * src/maemo/modest-msg-edit-window.c:
585 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
586 warning and fix the build.
588 * src/maemo/modest-progress-bar-widget.c:
589 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
590 avoid a g_warning, and probably to avoid a crash.
592 2007-06-20 Murray Cumming <murrayc@murrayc.com>
594 * src/modest-search.c: (modest_search_folder): Check for a GError
595 when calling tny_folder_get_headers(), to show that this is not the cause
598 2007-06-20 Murray Cumming <murrayc@murrayc.com>
600 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
601 Actually set the body query instead of the subject query.
603 * src/modest-search.c: (search_mime_part_ogs),
604 (search_mime_part_strcmp): Remove extra space from the text/* regex,
605 which would probably cause it to fail if we got this far.
607 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
608 to simplify the code.
609 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
610 be causing search-in-body to fail.
612 2007-06-20 Murray Cumming <murrayc@murrayc.com>
614 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
616 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
617 Better debug message when the folder cannot be found.
618 This should help with fixing projects.maemo.org bug #61287.
619 * src/modest-search.c: (add_hit): Do not leak the furl string.
621 2007-06-20 Murray Cumming <murrayc@murrayc.com>
623 * src/modest-ui-actions.c:
624 (modest_ui_actions_on_folder_selection_changed):
625 Do not special-case TNY_MERGE_FOLDER here, because
626 modest_tny_folder_get_account() already does that. This fixes
627 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
628 shown when the Outbox was selected).
630 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
632 * libmodest-dbus-client/libmodest-dbus-client.c:
633 (_dbus_iter_get_string_or_null): Initialize the string variable in
634 case this helps with Dirk's crash.
636 2007-06-19 Murray Cumming <murrayc@murrayc.com>
638 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
639 though it is not implemented yet (this function is maybe not even used),
640 to avoid breaking ABI in future.
641 * libmodest-dbus-client/libmodest-dbus-client.c:
642 (get_attachments_string): Moved some code into this generic function.
643 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
644 sends email. It is maybe not used.
645 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
646 (on_send_mail): Use attachments.
648 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
649 * src/maemo/modest-msg-edit-window.c:
650 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
651 a filename before using it, to fix projects.maemo.org bug NB#58233.
653 2007-06-19 Murray Cumming <murrayc@murrayc.com>
655 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
656 Initialize the continue_download variable to fix the build, and probably
657 to fix randome behaviour.
659 2007-06-18 Armin Burgmeier <armin@openismus.com>
661 * src/modest-tny-send-queue.h:
662 * src/modest-tny-send-queue.c: Keep track of the status of messages in
663 the queue so we can later show it in the UI. Replaced
664 modest_tny_send_queue_msg_is_being_sent() by
665 modest_tny_send_queue_get_msg_status().
667 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
669 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
670 gpointer. This probably was not harmful, but just to be sure.
672 2007-06-18 Murray Cumming <murrayc@murrayc.com>
674 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
675 Fix the build, but leave the function broken on Bora, because
676 hildon_uri_action_get_service() does not exist.
677 osso_uri_action_get_service() does not exist either, it seems.
679 2007-06-18 Murray Cumming <murrayc@murrayc.com>
681 * src/modest-tny-account.c:
682 (modest_tny_account_new_from_server_account):
683 Uncommented the url debug output again, because it is useful for
684 debugging, as I said in the comment.
686 2007-06-18 Murray Cumming <murrayc@murrayc.com>
688 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
690 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
691 for Mameo Bora, to fix the build.
693 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
696 Fixed build with hildon < 0.99
698 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
699 Check if the selected account is busy instead of checking all accounts
701 * src/modest-account-mgr-priv.h:
702 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
703 (modest_account_mgr_init), (compare_account_name),
704 (modest_account_mgr_set_account_busy),
705 (modest_account_mgr_account_is_busy):
706 * src/modest-account-mgr.h:
707 Added busy information to the account manager. It possible to
708 set an account to busy or not busy now.
710 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
711 (modest_mail_operation_update_account),
712 (modest_mail_operation_notify_end):
713 Set the account to busy/not busy depending on the operation state.
715 * src/widgets/modest-account-view.c:
716 (modest_account_view_finalize), (get_last_updated_string),
717 (update_account_view), (on_account_busy_changed), (init_view):
718 Show string "Refreshing..." if the account is currently busy.
720 All this fixes projects.maemo.org bug NB#59711
722 2007-06-14 Armin Burgmeier <armin@openismus.com>
724 * src/widgets/modest-attachments-view.h:
725 * src/widgets/modest-attachments-view.c: Added
726 modest_attachments_view_has_attachments() and fixed coordinate
727 transformation in get_att_view_at_coords(). This fixes attachment
730 * src/widgets/modest-msg-view.c: Make use of
731 modest_attachments_view_has_attachments() to decide whether to show
732 attachments in the header.
734 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
736 * src/maemo/modest-connection-specific-smtp-edit-window.c:
737 (on_change), (on_combo_security_changed),
738 (modest_connection_specific_smtp_edit_window_init),
739 (modest_connection_specific_smtp_edit_window_set_connection),
740 (modest_connection_specific_smtp_edit_window_is_dirty):
741 * src/maemo/modest-connection-specific-smtp-edit-window.h:
742 * src/maemo/modest-connection-specific-smtp-window.c:
745 Show an comfirmation dialog for the smpt-edit-window if there are
746 unsaved changes and the user hits cancel.
747 (projects.maemo.org bug NB#60479)
749 2007-06-14 Armin Burgmeier <armin@openismus.com>
751 * src/maemo/easysetup/modest-easysetup-wizard.c:
752 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
753 address" info in banner instead of node, and select all the text as
754 per UI spec. This fixes projects.maemo.org bug NB#60550.
756 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
758 reviewed by: <delete if not using a buddy>
760 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
761 * src/modest-ui-actions.c: (folder_refreshed_cb):
763 2007-06-14 Murray Cumming <murrayc@murrayc.com>
765 * src/widgets/modest-folder-view.c: (filter_row):
766 Explictly filter out the per-account outbox accounts. I don't know why
767 these only sometimes show up, but now they should never show up in the UI.
768 This should fix projects.maemo.org bug NB#60160.
770 2007-06-14 Murray Cumming <murrayc@murrayc.com>
772 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
773 when the toolbar does not exist yet.
774 * src/modest-widget-memory.c: (save_settings_header_view):
775 Added g_warnings() to help us to discover when we are trying to set
776 an empty columns list in gconf.
778 2007-06-14 Murray Cumming <murrayc@murrayc.com>
782 Added modest_init_get_default_header_view_column_ids().
784 * src/modest-widget-memory.c: (restore_settings_header_view):
785 Use the new function to get defaults, if the gconf key is empty,
786 instead of not creating any columns. This seems to fix the
787 empty right-hand pane problems.
789 * src/widgets/modest-header-view.h: Improved documentation.
791 2007-06-13 Murray Cumming <murrayc@murrayc.com>
793 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
794 Revert the use of the display name as the account name, because this
795 is generally wrong and would break the code that follows.
797 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
799 * src/maemo/easysetup/modest-easysetup-wizard.c:
800 (check_for_supported_auth_methods), (on_before_next),
803 More correct fix for projects.maemo.org bug NB# 58991
804 Do not longer accept AUTH_PASSWORD as secure method and choose
805 correct method when creating the account.
807 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
809 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
810 Fixed projects.maemo.org bug NB# 58991
812 2007-06-13 Murray Cumming <murrayc@murrayc.com>
814 * src/modest-init.c: (modest_init_init_core),
815 (modest_init_local_folders): Fixed compilation errors.
817 2007-06-13 Murray Cumming <murrayc@murrayc.com>
819 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
820 Remove unnecessary lib/include, though it is good in principle when needed.
822 * src/modest-init.c: (modest_init_one_local_folder),
823 (modest_init_local_folders):
824 * src/modest-init.h: Initialize the .modest library for memory cards,
825 instead of just doing nothing for them. This should allow us to create
826 folders there, fixing projects.maemo.org bug NB#59297.
828 2007-06-13 Murray Cumming <murrayc@murrayc.com>
830 * libmodest-dbus-client/libmodest-dbus-client.c:
831 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
832 (libmodest_dbus_client_compose_mail),
833 (libmodest_dbus_client_open_message),
834 (libmodest_dbus_client_send_and_receive),
835 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
837 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
838 (on_idle_open_message), (modest_dbus_req_handler),
839 (search_result_to_message), (modest_dbus_req_filter):
840 * src/modest-search.c: (add_hit), (modest_search_folder),
841 (modest_search_all_accounts): Improved debug messages.
843 * tests/dbus_api/test_open_message.c: (main): Improved comments.
845 * src/modest-tny-account-store.c:
846 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
849 2007-06-13 Murray Cumming <murrayc@murrayc.com>
852 2007-06-12 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-tny-account-store.c: (get_server_accounts):
855 Call modest_tny_local_folders_account_add_merged_outbox_folders()
856 even when there are no accounts, so that the Outbox folder is always
857 visible. This fixes projects.maemo.org bug NB#60158.
859 2007-06-12 Murray Cumming <murrayc@murrayc.com>
861 * src/maemo/modest-main-window.c: (create_details_widget):
862 Use the mcen_va_never logical ID.
864 2007-06-12 Murray Cumming <murrayc@murrayc.com>
866 * src/dbus_api/modest-dbus-api.h:
867 * src/dbus_api/modest-dbus-callbacks.c:
868 (on_idle_open_default_inbox), (on_open_default_inbox),
869 (modest_dbus_req_handler):
870 Added a new OpenDefaultInbox method.
872 * libmodest-dbus-client/libmodest-dbus-client.h:
873 * libmodest-dbus-client/libmodest-dbus-client.c:
874 Added libmodest_dbus_client_open_default_inbox() to call the new
875 dbus method. This should be useful to projects.maemo.org bug NB#57214,
876 though it should maybe be used by a new osso-email-interface function.
878 * tests/dbus_api/Makefile.am:
879 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
882 2007-06-12 Murray Cumming <murrayc@murrayc.com>
884 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
885 NULL, so that the signals get all the keys. This should not actually
886 change any behaviour because we currently update everything when anything
889 2007-06-12 Murray Cumming <murrayc@murrayc.com>
891 * src/widgets/modest-folder-view.c: (text_cell_data),
892 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
893 (find_inbox_iter): If tinymail tells us that the folder is
894 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
895 This causes the inbox to be selected at startup, fixing part of
896 projects.maemo.org bug NB#56305.
898 * src/modest-ui-dimming-rules.c:
899 (modest_ui_dimming_rules_on_tools_smtp_servers):
900 * src/modest-ui-dimming-rules.h: Added a callback function to dim
901 the SMTP servers menu item.
902 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
903 that the SMTP Servers menu item is dimmed when there are no accounts,
904 as a future version of the UI spec will require. This fixes
905 projects.maemo.org bug NB#56305.
907 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
909 * src/maemo/modest-maemo-utils.c:
910 (modest_maemo_utils_get_supported_secure_authentication_methods):
911 Added label to dialog instead of unreadable title
913 * src/maemo/modest-main-window.c: (sync_accounts_cb),
914 (modest_main_window_new):
915 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
918 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
919 * src/modest-account-mgr.h:
920 Added method to avoid code duplication
922 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
923 (modest_ui_actions_on_send_receive):
924 Use modest_account_mgr_has_accounts
926 2007-06-11 Murray Cumming <murrayc@murrayc.com>
928 * src/maemo/easysetup/modest-presets.c:
929 (modest_presets_get_info_server_security): Do not report secure auth
931 * src/modest-protocol-info.c: Use the defines for the gconf key names
932 for secure authentication. This was not working because we were writing
933 Password and reading password, and the check was case sensitive.
934 With this, gmail now works for receiving and sending when created via
937 2007-06-11 Murray Cumming <murrayc@murrayc.com>
939 * src/maemo/easysetup/modest-presets.c:
940 (modest_presets_get_info_server_security): Correct the key name for
941 SecureSmtp, because it seems to be case-sensitive.
942 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
943 Do not try to get the 0th notebook page if there are 0 pages, to
946 2007-06-11 Murray Cumming <murrayc@murrayc.com>
948 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
949 Prevent use of the new notification feature for now, because it currently
950 shows one dialog for each new email, which is annoying.
952 2007-06-11 Murray Cumming <murrayc@murrayc.com>
954 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
955 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
956 when no country was selected, so that we show the global ones.
957 * src/maemo/easysetup/modest-presets.c:
958 (modest_presets_get_providers): Return only the global providers, not
959 all providers when mmc=0 was requested.
961 2007-06-11 Murray Cumming <murrayc@murrayc.com>
963 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
964 (easysetup_provider_combo_box_fill): Remove debug code that showed the
965 provider ID in the combo.
967 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
968 Do not show the page numbers, because it would be confusing when we add
969 the 2 extra pages for the custom setup, when the user chooses the "Other"
970 provider. This fixes projects.maemo.org bug NB#59028
972 * src/modest-init.c: (modest_init_init_core),
973 (modest_init_local_folders):
975 * src/modest-tny-account.c:
976 (modest_tny_account_new_for_local_folders): Do not create default folders
977 for the memory card. This should fix projects.maemo.org bug NB#59328.
979 2007-06-11 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
982 Free the changed_conf_keys string items. They are already freed in the
983 idle handler if that runs first.
985 2007-06-11 Murray Cumming <murrayc@murrayc.com>
987 * src/modest-ui-actions.c:
988 (modest_ui_actions_on_password_requested): Check that the server name
989 is not NULL, because I just saw a password dialog with (null) as the
992 * src/modest-tny-folder.[h|c]: Added
993 modest_tny_folder_is_memory_card_folder().
994 * src/modest-ui-dimming-rules.c:
995 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
996 menu item for memory cards, as per the UI spec (section 7.4). This should
997 fix projects.maemo.org bug NB#59297.
999 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1001 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1002 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1003 is another problem with the code, see Murray's comment at line 772)
1005 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1007 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1008 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1009 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1010 (load_from_file), (easysetup_country_combo_box_init),
1011 (easysetup_country_combo_box_get_active_country_ids),
1012 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1013 instead of just one ID, to avoid duplicate country names in the UI.
1015 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1016 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1017 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1018 a single ID, avoiding duplicate providers.
1019 * src/maemo/easysetup/modest-easysetup-wizard.c:
1020 (on_combo_account_country): Adapt to use a list.
1022 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1024 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1025 keys changed in the last X seconds.
1027 * src/modest-account-mgr.h:
1028 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1029 (on_key_change), (modest_account_mgr_class_init),
1030 (modest_account_mgr_init), (modest_account_mgr_finalize):
1031 As the keys are changed, save them in a GSList* and signal that GSList*
1032 further every X seconds, to batch changes, to allow us to do just one
1033 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1034 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1036 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1037 changed signal signature.
1039 * src/modest-conf.c: (modest_conf_set_list),
1040 (modest_conf_on_change): Reenable notification.
1042 (modest_conf_maemo_fake_on_change): Comment out the hack that
1043 notified immediately instead of asynchronously.
1045 * src/widgets/modest-account-view.h:
1046 * src/widgets/modest-account-view.c:
1047 (update_account_view): Select the previously-selected account ID,
1048 if possible. This fixes projects.maemo.org bug NB#56933.
1050 (on_account_changed), (on_account_removed),
1051 (modest_account_view_select_account):
1053 Remove the block/unblock functions
1054 because they were not useful.
1056 * src/maemo/modest-account-view-window.c:
1057 (on_delete_button_clicked), (on_edit_button_clicked),
1058 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1060 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1062 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1063 Improve the error dialog to show Incorrect Account Settings, which seems
1064 clearer, and say that the internal error message (to be removed from the
1065 dialog later) is often misleading.
1066 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1068 * src/modest-tny-account.c:
1069 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1070 URL because this is so useful for debugging on the device.
1072 * src/widgets/modest-serversecurity-combo-box.c:
1073 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1075 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1077 * src/modest-mail-operation.c:
1078 (modest_mail_operation_send_new_mail):
1079 Added a comment about a nasty but apparently harmless message. Details
1080 added to the wiki g_warnings() page.
1082 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1084 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1085 (modest_tny_send_queue_class_init):
1086 Do not use the priv struct because it is empty, to avoid g_warnings
1087 about a non-existant priv struct.
1089 * src/modest-tny-account-store.c:
1090 (modest_tny_account_store_get_server_account),
1091 (modest_tny_account_store_get_transport_account_for_open_connection
1092 ): Do not try to get transport server accounts for local folders,
1093 because they don't have any. This avoids a g_warning().
1095 * src/maemo/modest-main-window.c:
1096 (modest_main_window_notify_send_receive_initied),
1097 (on_configuration_key_changed):
1098 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1099 * src/modest-defs.h:
1100 * src/modest-mail-operation.c:
1101 (modest_mail_operation_update_account):
1102 * src/modest-tny-account-store.h:
1103 * src/modest-tny-account.c:
1104 (modest_tny_account_get_special_folder),
1105 (modest_tny_account_new_for_local_folders),
1106 (modest_tny_account_new_for_per_account_local_outbox_folder):
1107 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1108 * src/modest-tny-local-folders-account.c:
1109 (add_account_folders_to_merged_folder):
1110 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1111 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1112 (modest_ui_actions_on_send):
1113 * src/widgets/modest-folder-view.c: (update_model):
1114 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1115 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1116 modest_tny_account_store_get_tny_account_by_account() to
1117 modest_tny_account_store_get_server_account() to make the code clearer.
1119 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1121 * src/dbus_api/modest-dbus-api.h:
1122 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1123 * src/maemo/modest-msg-edit-window.c:
1124 (modest_msg_edit_window_attach_file_noninteractive):
1125 added g_warning in case the file to be attached does not exist
1126 * tests/dbus_api/test_compose_mail.c: (main):
1127 removed obsolete comment, added generic files as test case
1129 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1131 * src/modest-tny-account-store.c: (get_server_accounts):
1132 Create the local folders account only once, not once for each outbox, and
1133 not only when there are some outboxes.
1135 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1137 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1138 code that is causing a crash at startup. Sergio says that he is fixing this.
1140 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1142 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1143 * src/maemo/modest-account-settings-dialog.c:
1144 (create_page_outgoing),
1145 (modest_account_settings_dialog_set_account_name),
1146 (save_configuration):
1147 - Fixed handling of the "Use secure authentication" toggle to comply with
1148 the ui specification. See also projects.maemo.org bug NB#58400
1150 - Restore the Secure connection setting combo correctly when loading
1153 * src/maemo/modest-maemo-utils.c:
1154 (on_camel_account_get_supported_secure_authentication),
1155 (modest_maemo_utils_get_supported_secure_authentication_methods):
1156 Fixed a crasher if operation is canceled
1158 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1159 (modest_protocol_info_auth_is_secure):
1160 * src/modest-protocol-info.h:
1162 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1163 the sense of the "Use secure authentication" toggle.
1165 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1167 * src/modest-tny-account-store.h:
1168 * src/modest-tny-account-store.c:
1169 Added modest_tny_account_store_get_local_folders_account().
1171 * src/modest-tny-folder.h:
1172 * src/modest-tny-folder.c:
1173 (modest_tny_folder_get_account):
1174 Added this replacement for tny_folder_get_account() which returns
1175 the local-folders account for TnyMergeFolders, to avoid the
1176 warning about the unimplemented get_account_func() vfunc().
1178 (modest_tny_folder_get_rules),
1179 * src/modest-ui-actions.c:
1180 (modest_ui_actions_on_folder_selection_changed):
1181 * src/modest-mail-operation.c:
1182 (modest_mail_operation_remove_folder),
1183 (modest_mail_operation_xfer_folder),
1184 (modest_mail_operation_rename_folder),
1185 (modest_mail_operation_get_msg),
1186 (modest_mail_operation_get_msgs_full),
1187 (modest_mail_operation_remove_msg),
1188 (modest_mail_operation_xfer_msgs),
1189 (modest_mail_operation_refresh_folder):
1190 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1192 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1194 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1195 (modest_server_account_set_security):
1196 * src/modest-defs.h: Add comments explaining that our
1197 UI spec means TLS when it says Normal, so these do not look like errors.
1199 * src/modest-tny-account.c:
1200 (modest_tny_account_new_from_server_account): Use the new tinymail
1201 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1202 for TLS. This should fix projects.maemo.org bug NB#58460.
1204 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1206 * src/maemo/easysetup/modest-easysetup-wizard.c:
1207 (create_account): Correct the position of the gconf sanity check warning.
1208 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1209 of using the g_idle_add() hack, because this does not seem to be necessary
1210 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1211 caused by something other than maemo's gconf.
1212 This fixes projects.maemo.org bug #59022.
1214 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1216 * src/modest-account-mgr-helpers.c:
1217 (modest_account_mgr_get_default_account): Do not check that the account
1218 exists if there is no default account (NULL), to fix a runtime warning.
1220 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1222 * src/widgets/modest-folder-view.c: (update_model):
1223 Do not unref the treemodel before we have finished with it.
1224 This prevents a valgrind warning and an occasional crash at startup.
1226 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1228 * libmodest-dbus-client/libmodest-dbus-client.h:
1229 added libmodest_dbus_client_compose_mail()
1230 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1232 added functions needed for SendAsMail() functionality
1233 * src/maemo/modest-msg-edit-window.c:
1234 (modest_msg_edit_window_attach_file_noninteractive):
1235 non interactively attaching files to message edit window
1236 * src/widgets/modest-msg-edit-window.h:
1237 * tests/dbus_api/Makefile.am:
1238 added test_compose_mail.c
1239 * tests/dbus_api/test_compose_mail.c: (main):
1241 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1243 * src/modest-account-view.c:
1244 Fixed bug projects.maemo.org bug NB#59307
1246 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1248 * src/maemo/easysetup/modest-easysetup-wizard.c:
1249 (get_serverport_incoming), (on_before_next), (create_account):
1250 * src/maemo/modest-account-settings-dialog.c:
1251 (modest_account_settings_dialog_set_account_name):
1252 * src/maemo/modest-maemo-utils.c:
1253 (on_camel_account_get_supported_secure_authentication_status),
1254 (on_camel_account_get_supported_secure_authentication),
1255 (on_secure_auth_cancel),
1256 (modest_maemo_utils_get_supported_secure_authentication_methods):
1258 Implemented security authentication for settings and easysetup.
1260 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1262 * src/maemo/modest-main-window.c: (create_details_widget):
1263 Show the total size for memory card accounts too, instead of showing
1264 the name again. Fixes bug projects.maemo.org bug NB#59307.
1266 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1269 * src/modest-tny-simple-folder-store.c:
1270 * src/modest-tny-simple-folder-store.h: Removed.
1272 * src/modest-tny-local-folders-account.h
1273 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1274 for the local-folders maildir, with an extra TnyMergedFolder containing
1275 the folders of the per-account outbox store accounts.
1276 * src/modest-tny-account-store.c: (get_server_accounts):
1277 Add the outboxes to the special local folders account after creating it.
1279 * src/modest-tny-account.c:
1280 (modest_tny_account_new_for_local_folders): Create the derived
1281 account when creating the main local-folders account.
1283 * src/maemo/modest-main-window.c: (create_details_widget),
1284 (modest_main_window_set_contents_style):
1285 Adapted to the use of the derived account instead of the folder store.
1287 * src/modest-ui-actions.c:
1288 (modest_ui_actions_on_folder_selection_changed):
1289 * src/modest-ui-dimming-rules.c:
1290 (modest_ui_dimming_rules_on_new_folder):
1291 * src/widgets/modest-folder-view.c: (text_cell_data),
1292 (icon_cell_data), (filter_row), (update_model),
1293 (get_cmp_rows_type_pos):
1296 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1297 Do not get the priv struct, because no priv struct has been set,
1298 to avoid a runtime warning.
1300 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1301 #ifelse with #else, to fix a warning, to fix the build.
1304 2007-06-05 Christian Kellner <ckellner@openismus.com>
1306 * libmodest-dbus-client/libmodest-dbus-client.c:
1307 Fix small typo in doc (why do you always see them
1308 AFTER committing stuff?)
1311 2007-06-05 Christian Kellner <ckellner@openismus.com>
1313 * libmodest-dbus-client/libmodest-dbus-client.c:
1314 (libmodest_dbus_client_search):
1315 Initialize hit list with NULL. Also set folder list
1316 to "" if NULL was supplied.
1319 2007-06-03 Christian Kellner <ckellner@openismus.com>
1321 * libmodest-dbus-client/libmodest-dbus-client.c:
1322 (modest_search_hit_list_free):
1323 Make it save to call it with NULL.
1325 * src/dbus_api/modest-dbus-callbacks.c:
1326 * src/modest-search.c:
1327 Return full ModestSearchHits as the search result list not TnyHeader
1328 since can't be around withouth the correspoding TnyFolder.
1330 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1332 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1333 Added currently commented code to check for secure auth
1335 * src/maemo/modest-account-settings-dialog.c: (on_response),
1336 (save_configuration), (show_ok):
1337 Fixed projects.maemo.org bugs NB #59248 and #59251
1339 * src/maemo/modest-maemo-utils.c:
1340 (on_camel_account_get_supported_secure_authentication_status),
1341 (on_camel_account_get_supported_secure_authentication),
1342 (modest_maemo_utils_get_supported_secure_authentication_methods):
1343 * src/maemo/modest-maemo-utils.h:
1344 Moved get_supported_secure_authentication() method here to be able
1345 to use it from easysetup wizard.
1347 * src/modest-pair.c: (on_pair_compare_as_string):
1348 Should compare string with first part of pair and not
1349 strcmp pairs which will crash.
1351 * src/modest-protocol-info.c:
1352 (modest_protocol_info_protocol_is_store):
1353 * src/modest-protocol-info.h:
1354 Added modest_protocol_info_get_auth_protocol_name()
1356 2007-06-03 Armin Burgmeier <armin@openismus.com>
1358 * src/modest-mail-operation.c:
1359 (modest_mail_operation_get_msgs_full): Set priv->account also when
1360 only retrieving a single message. This avoids a crash when canceling
1363 (modest_mail_operation_notify_end): Do not explicitely remove the
1364 operation from the queue but only emit the progress_changed signal.
1365 The queue itself listens to that signal to remove the operation when
1366 it is finished. This reduces coupling and removes a potential deadlock
1367 when modest_mail_operation_notify_end() is called from the queue
1368 itself. If that is a problem performance-wise, I would suggest to
1369 implement a status-changed signal or something.
1371 * src/modest-mail-operation-queue.c: Make sure to never call a
1372 function from another file while the queue is locked. This (hopefully)
1373 fixes another deadlock when exiting the application while retrieving
1376 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1378 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1379 Fixed build if libogs is not available
1381 2007-06-03 Christian Kellner <ckellner@openismus.com>
1383 * libmodest-dbus-client/libmodest-dbus-client.h:
1384 * libmodest-dbus-client/libmodest-dbus-client.c:
1385 (libmodest_dbus_client_delete_message):
1386 Implement deletion of messages (Client side).
1388 (modest_search_hit_free),
1389 (modest_search_hit_list_free):
1390 Utility functions to free the result hits.
1392 * src/dbus_api/modest-dbus-api.h:
1393 * src/dbus_api/modest-dbus-callbacks.c:
1394 (on_delete_message),
1395 (modest_dbus_req_handler):
1396 Implement deletion of messages (Server side).
1398 * tests/dbus_api/test_search.c: (main):
1401 * tests/dbus_api/Makefile.am:
1402 * tests/dbus_api/test_delete_message:
1403 Add little test for the message deletion logic
1405 2007-06-03 Armin Burgmeier <armin@openismus.com>
1407 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1408 when the operation queue was not empty. projects.maemo.org bug
1411 2007-06-03 Armin Burgmeier <armin@openismus.com>
1413 * src/widgets/modest-account-view.c
1414 (on_account_default_toggled): Toggle default account column
1415 explicitely instead of waiting for gconf notification (which is
1416 currently ignored). This should fix projects.maemo.org bug NB#56910
1417 for now. It should probably be removed when gconf notifications are
1420 2007-06-03 Christian Kellner <ckellner@openismus.com>
1422 * libmodest-dbus-client/libmodest-dbus-client.c:
1423 Removed debugging spew.
1425 * src/dbus_api/modest-dbus-callbacks.c:
1426 Added debugging info.
1428 * src/modest-search.c:
1429 (modest_search_all_accounts):
1430 Use tny_account_store_get_accounts () on the account store
1431 to get all accounts which is the way to get all accounts.
1433 * tests/dbus_api/test_search.c: (main):
1434 Make it possible to supply the search term on the command line.
1436 2007-06-03 Christian Kellner <ckellner@openismus.com>
1438 * libmodest-dbus-client/libmodest-dbus-client.c:
1439 * libmodest-dbus-client/libmodest-dbus-client.h:
1440 Implement searching for mesages over raw dbus. (Client side)
1442 * src/dbus_api/Makefile.am:
1443 * src/dbus_api/modest-dbus-api.h:
1444 * src/dbus_api/modest-dbus-callbacks.c:
1445 * src/dbus_api/modest-dbus-callbacks.h:
1446 Search framework (Server side). Also implement on_idle_open_message().
1448 * src/maemo/modest-platform.c: (modest_platform_init):
1449 Prepare for raw dbus/osso rpc interaction.
1451 * src/modest-search.h:
1452 Changed minsize from unspecific guint to guint32.
1454 * src/modest-search.c:
1456 Added strange hack which magically made tnymail work.
1458 (modest_search_folder),
1459 (modest_search_account),
1460 (modest_search_all_accounts):
1461 Implement helper functions to search all accounts, specific account
1464 * tests/dbus_api/Makefile.am:
1465 * tests/dbus_api/test_open_message.c:
1466 Read url to open from commandline.
1468 * tests/dbus_api/test_search.c:
1469 Implement small test for dbus search stuff
1471 2007-06-02 Armin Burgmeier <armin@openismus.com>
1473 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1474 include account type and account title. This fixes projects.maemo.org
1477 * src/maemo/modest-account-view-window.c: Set a title for the window.
1479 2007-06-02 Armin Burgmeier <armin@openismus.com>
1481 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1482 incoming and outgoing server name based on email address and server
1483 types as long as the names have not been edited manually. This fixes
1484 projects.maemo.org bug NB#58671.
1486 2007-06-02 Armin Burgmeier <armin@openismus.com>
1488 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1489 server type cannot be changed in future to the incoming details page
1490 when creating an account. This fixes projects.maemo.org bug NB#59029.
1492 2007-06-02 Armin Burgmeier <armin@openismus.com>
1494 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1495 and assigned max width chars so that they wrap instead of being
1496 truncated. Fixes projects.maemo.org bug NB#56126.
1498 2007-06-02 Armin Burgmeier <armin@openismus.com>
1500 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1501 introductory note to the connection specific smtp servers dialog, as
1502 section 8.12 of the email UI specification requires. This fixes
1503 projects.maemo.org bug NB#59212.
1505 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1507 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1508 Check for running mail operations, and offer to cancel them, as per the UI
1509 spec. This fixes projects.maemo.org bug NB#59041 .
1510 However, I suspect that tinymail may still use the network connection
1511 in ways that we cannot detect or cancel. But it should at least adapt to
1512 changes fairly well.
1514 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1516 * src/modest-tny-account-store.c: (recreate_all_accounts),
1517 (get_cached_accounts), (get_server_accounts): Do more sensible
1518 ref-counting of the temporarily-cached outbox accounts list. This seems
1519 to fix a crash when entering the password when the password was wrong.
1521 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1523 * src/gnome/modest-main-window.c: (connect_signals):
1524 * src/modest-tny-account-store.c: (get_password),
1525 (modest_tny_account_store_alert): Added comments and clues and
1526 commented-out code about how we currently fail to deal with connection
1527 errors and wrong passwords, and how we should.
1529 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1531 * src/widgets/modest-retrieve-combo-box.c:
1532 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1533 This fixes projects.maemo.org bug NB#58472 .
1535 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1537 * src/maemo/easysetup/modest-easysetup-wizard.c:
1538 (create_page_complete_easysetup):
1539 (create_page_complete_custom): Correct the last commit,
1540 putting the correct sentences in the correct pages.
1542 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1544 * src/maemo/easysetup/modest-easysetup-wizard.c:
1545 (create_page_complete_custom): Show the second sentence of text
1546 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1549 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1551 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1552 Set the leave-on-server conf key by default. This fixes
1553 projects.maemo.org bug NB#59258 .
1555 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1557 * src/maemo/modest-account-view-window.c:
1558 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1559 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1562 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1564 * src/maemo/easysetup/modest-easysetup-wizard.c:
1565 (create_caption_new_with_asterisk):
1566 * src/maemo/modest-account-settings-dialog.c:
1567 (create_caption_new_with_asterisk):
1568 Uncomment the code to add the asterisk, because they are no longer in the
1569 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1570 (update_incoming_server_title): Add an asterisk here too.
1572 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1574 * src/maemo/modest-maemo-global-settings-dialog.c:
1575 (current_connection): Check that we are even connected before trying to
1576 get the current connection name, to prevent a warning.
1578 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1579 Change the comments because tny_maemo_conic_device_connect() is now meant to
1581 * src/modest-mail-operation.c:
1582 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1583 make sure we have a connection and fail if we can't connect.
1585 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1587 * src/maemo/modest-main-window.c:
1588 (on_account_store_connecting_finished): Do not try to get the
1589 connection ID if we are not really connected. I am surprised that
1590 this signal handler is called when we are not connected.
1592 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1594 * src/modest-error.h:
1595 * src/modest-ui-actions.c:
1596 (modest_ui_actions_get_msgs_full_error_handler):
1597 Renamed an enum, added comments, added an enum
1598 for retrieve-limit errors.
1600 * src/modest-mail-operation.c: (foreach_add_item),
1601 (internal_folder_observer_update), (update_account_thread),
1602 (modest_mail_operation_get_msgs_full):
1603 (modest_mail_operation_update_account),
1604 Added comments about how this works, and some code that should
1605 (but does not) check the retrieve-limit. See the TODO comment.
1607 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1609 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1610 Initialize help_id to fix the build. Warnings are good.
1612 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1614 * src/widgets/modest-hbox-cell-renderer.c:
1615 (modest_hbox_cell_renderer_append):
1616 * src/widgets/modest-vbox-cell-renderer.c:
1617 (modest_vbox_cell_renderer_append):
1618 Fix the last commit by doing an extra ref.
1620 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1622 * src/widgets/modest-hbox-cell-renderer.c:
1623 (modest_hbox_cell_renderer_append):
1624 * src/widgets/modest-vbox-cell-renderer.c:
1625 (modest_vbox_cell_renderer_append):
1626 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1627 to fix the build with Maemo Bora.
1628 However, there seems to be a remaining crash, probably due to reference
1631 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1633 * src/modest-tny-account.c:
1634 (modest_tny_account_new_for_local_folders):
1635 Use hildon_file_system_info_async_new() to get a better name for
1636 the memory card account, setting it as the account name.
1637 The timing seems to work, but this is probably
1638 not the best place to do this. See the TODO comment.
1639 * src/maemo/modest-main-window.c: (create_details_widget):
1640 * src/widgets/modest-folder-view.c: (text_cell_data):
1641 Use the tny account name instead of hardcoding a name.
1643 2007-05-30 Christian Kellner <ckellner@openismus.com>
1645 * src/modest-search.c: (modest_search):
1646 Correctly set part_search_func even if we have already parsed
1647 the query and thus a valid OgsTextSearcher object.
1649 2007-05-30 Christian Kellner <ckellner@openismus.com>
1652 Search and check for libogs.
1655 Incooparte the ogs build env.
1657 * src/modest-mime-part-search-stream.c:
1658 * src/modest-mime-part-search-stream.h:
1659 Removed since we do the real searching now in modest-search.c.
1661 * src/modest-search.c:
1662 * src/modest-search.h:
1663 Implement support for ogs. We use that if available and requested
1664 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1665 should now handle the corner case when the search term is spread
1666 across multiple reads.
1667 Also the logic in modest_search () was corrected to search all
1668 requested fields until one is found.
1670 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1672 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1674 * src/modest-init.h:
1675 * src/modest-init.c: Made modest_init_local_folders() take a
1676 path and be public so we can iniitialize maildir folders on
1679 * src/modest-local-folder-info.h:
1680 * src/modest-local-folder-info.c:
1681 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1683 * src/modest-tny-account.c:
1684 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1685 still means the standard local-folders path on the local volume.
1687 * src/modest-tny-account-store.c:
1688 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1689 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1690 all accounts when that happens.
1691 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1692 this too, so it shows up in the treeview.
1694 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1696 * src/maemo/modest-maemo-global-settings-dialog.c:
1697 (current_connection):
1698 * src/widgets/modest-global-settings-dialog.c:
1699 (current_connection_default):
1700 Use the enum values instead of 0, 1 and -1,
1701 to make the code clearer.
1703 * src/modest-account-mgr-helpers.c:
1704 (modest_account_mgr_get_connection_specific_smtp): Make this code
1707 * src/modest-runtime.h:
1708 * src/modest-runtime.c:
1709 Added modest_runtime_remove_all_send_queues().
1710 * src/maemo/modest-main-window.c:
1711 (on_account_store_connecting_finished): Recreate the send queues,
1712 using the appropriate transport accounts for this new connection.
1713 Some futher adapting might be needed if the old send queues are not
1714 automatically stopped at this point.
1716 * src/modest-tny-account-store.c: (get_server_accounts):
1717 Create the connection-specific transport accounts, so that they can
1718 be found later by their ID.
1720 * src/modest-tny-account.h:
1721 * src/modest-tny-account.c:
1722 Added modest_tny_account_new_from_server_account_name().
1723 modest_tny_account_new_from_server_account(): Do not create the
1724 send queues here, because they will be
1725 recreated anyway when the connection changes for the first time.
1727 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1729 * src/modest-local-folder-info.h:
1730 * src/modest-local-folder-info.c:
1731 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1732 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1733 tbox_folder): Take a modest account name instead of a server TnyAccount,
1734 so we can have per-modest-account rather than per-transport-account
1736 We must make sure that we change or recreate the exisitng send queues
1737 when the connection changes for connection-specific transport accounts.
1739 * src/modest-tny-account-store.c:
1740 (create_per_account_local_outbox_folders): Create outboxed per modest
1741 account, not per transport account.
1743 * src/modest-tny-account.h:
1744 * src/modest-tny-account.c:
1745 (modest_tny_account_get_special_folder): For outboxes, get the
1746 parent modest account name. The account is ignored for other folders.
1747 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1748 modest account name rather than a server TnyAccount.
1750 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1752 * src/modest-tny-account.c:
1753 (modest_tny_account_new_from_server_account):
1754 Call modest_runtime_get_send_queue() immediately after creating transport
1755 accounts, so that they start trying to send email from the outbox as soon
1756 as possible at startup. This is probably what we want.
1758 * src/modest-mail-operation.c: (update_account_thread):
1759 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1760 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1761 * src/modest-tny-send-queue.h:
1762 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1763 (modest_ui_actions_on_send):
1764 Added comments about how sending works, though it needs some more work.
1766 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1768 * src/modest-tny-account.c:
1769 (modest_tny_account_get_special_folder): Add TODO because this fails when
1770 the network is busy.
1771 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1772 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1773 Do not try to show this window when there is no active account. The UI
1774 specs does not tell us what to do in this case.
1776 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1780 * src/maemo/Makefile.am:
1781 * src/widgets/Makefile.am: Some dist fixes.
1783 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1785 * src/maemo/modest-connection-specific-smtp-window.c:
1786 (on_button_edit): Make the code clearer, to prevent a double free.
1788 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1790 * src/maemo/modest-account-settings-dialog.c:
1791 (modest_account_settings_dialog_set_account_name),
1792 Check the connection-specific smtp servers checkbox if there are any.
1794 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1795 (modest_connection_specific_smtp_edit_window_init):
1796 Start with a suitable port number.
1798 * src/modest-account-mgr-helpers.h:
1799 * src/modest-account-mgr-helpers.c: Added
1800 modest_account_mgr_get_has_connection_specific_smtp().
1802 (modest_account_mgr_set_connection_specific_smtp),
1803 (modest_account_mgr_remove_connection_specific_smtp),
1804 (modest_account_mgr_get_has_connection_specific_smtp),
1805 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1806 connection-specific smtp server accounts in the account, rather than
1807 the server account conf dir.
1809 This fixes bug projects.maemo.org bug NB#58263 .
1811 * src/modest-tny-account-store.c:
1812 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1813 if there are no server accounts yet, to prevent an infinite loop when there
1814 are no accounts. Document that one must be called before the other.
1816 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1818 * src/modest-account-mgr-helpers.c:
1819 (modest_account_mgr_get_default_account): Make sure that at least
1820 one account is always the default, if there are any enabled accounts.
1821 This is just a sanity check that shouldn't be necessary.
1823 * src/modest-account-mgr-priv.c:
1824 (_modest_account_mgr_account_from_key): Unescape the conf key to
1825 get the real account name. For instance, this is an issue if a space
1826 was in the account name, which can happen because the account name
1827 is generated from the display name.
1828 (_modest_account_mgr_get_account_keyname): Always escape the
1830 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1831 Unescape the conf keys to get the real account names.
1833 For instance, previously the is-default radio button in the accounts
1834 list was not checked for any accounts at first. This fixes that,
1835 and might fix several similar bugs.
1837 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1839 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1840 Removed some debug printfs.
1842 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1844 Modest on-disk outbox directories are now here, for instance:
1845 $HOME/.modest/outboxes/<account-id-1>/outbox
1846 $HOME/.modest/outboxes/<account-id-2>/outbox
1848 $HOME/.modest/local-folders/outbox
1849 so we can have a separate outbox for each account.
1850 But they are shown as one outbox in the GtkTreeView, by using a
1851 TnyMergeFolder in a ModestTnySimpleFolderStore.
1854 * src/modest-tny-simple-folder-store.c:
1855 * src/modest-tny-simple-folder-store.h:
1856 Added ModestTnySimpleFolderStore, used to contain folders from
1857 other folder stores, such as other accounts.
1859 * src/modest-tny-outbox-account.h:
1860 * src/modest-tny-outbox-account.c:
1861 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1862 used for the per-account local outbox folders.
1864 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1865 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1866 only use this (internally) now for the non-outbox local folders.
1868 * src/modest-init.h:
1869 * src/modest-init.c: Added modest_init_one_local_folder(), for
1870 setting up the directory structure for each local folder.
1872 * src/modest-local-folder-info.c:
1873 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1874 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1876 * src/modest-local-folder-info.h:
1877 * src/modest-tny-account-store.c: (on_account_removed),
1878 (on_account_changed), (create_per_account_local_outbox_folders),
1879 (get_server_accounts), (modest_tny_account_store_get_accounts),
1880 (modest_tny_account_store_get_tny_account_by_account),
1881 (modest_tny_folder_store_is_virtual_local_folders):
1883 * src/modest-tny-account.h:
1884 * src/modest-tny-account.c:
1885 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1886 to create an on-disk per-account local outbox folder for each
1888 (create_per_account_local_outbox_folders): Create a local outbox folder
1889 for each transport account.
1890 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1891 for all local folders.
1893 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1894 instead of using g_object_get/set() directly. It is clearer.
1896 (modest_tny_folder_store_get_message_count),
1897 (modest_tny_folder_store_get_local_size
1898 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1899 because we now use these with non-acount folder stores.
1901 (modest_tny_account_get_special_folder),
1902 (modest_tny_account_new_from_server_account),
1903 (modest_tny_account_new_from_account):
1904 (recurse_folders): Adjust to the new outbox system.
1906 * src/modest-tny-folder.h:
1907 * src/modest-tny-folder.c:
1908 (modest_tny_folder_is_local_folder),
1909 (modest_tny_folder_get_local_folder_type),
1910 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1912 * src/widgets/modest-main-window.h:
1913 * src/maemo/modest-main-window.c: (create_details_widget),
1914 (modest_main_window_set_contents_style): Show details for any folder store,
1917 (modest_tny_folder_get_rules):
1918 Remove the const. C does not support constness enough for this.
1920 * src/modest-ui-actions.c:
1921 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1922 make all outboxes appear as one, in the usual local-folders tree node.
1924 (set_active_account_from_tny_account),
1925 (modest_ui_actions_on_folder_selection_changed):
1926 * src/widgets/modest-folder-view.c: (text_cell_data),
1927 (icon_cell_data), (filter_row),
1928 (add_account_folders_to_merged_folder),
1929 (add_account_folders_to_simple_folder_store), (),
1930 (get_cmp_rows_type_pos), (cmp_rows),
1931 (modest_folder_view_set_account_id_of_visible_server_account):
1932 Adjust to the new outbox system, using generic folder stores and folders
1933 in the GtkTreeModel.
1935 2007-05-23 Christian Kellner <ckellner@openismus.com>
1937 * src/modest-mail-operation.c:
1938 (modest_mail_operation_update_account):
1939 Use info->max_size instead of unintialized local var [small
1940 build fix]. (Added TODO to review that change since I don't
1943 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1945 * libmodest-dbus-client/libmodest-dbus-client.c:
1946 (libmodest_dbus_client_compose_mail): function added
1947 * src/dbus_api/modest-dbus-api.h:
1948 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1949 (on_compose_mail): Implementation of the SendAsMail functionality
1951 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1953 * src/modest-account-mgr.c:
1954 (modest_account_mgr_add_server_account): Set the secure-connection
1955 conf key for transport accounts as well as store accounts. I don't know
1956 why the if was there. For instance, this makes sure that we use SSL
1957 for the gmail preset from the easysetup wizard.
1959 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1961 * src/gnome/modest-main-window.c:
1962 (on_account_store_connecting_finished), (connect_signals):
1963 * src/maemo/modest-main-window.c:
1964 (on_account_store_connecting_finished), (connect_signals),
1965 (modest_main_window_new):
1966 Handle TnyAccountStore::connecting-finished instead of
1967 TnyDevice::connection-changed, because we cannot actually perform
1968 operations on accounts until TnyAccountStore has itself responded to
1969 the TnyDevice::connection-changed signal. This prevents a GError from
1971 Do not try to update at startup, because we (at least on scratchbox)
1972 already do an update at startup when the device goes online.
1973 This prevents a GError from tinymail.
1974 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1975 Added TODO about stopping simultaneous operations.
1977 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1979 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1980 * src/modest-mail-operation-queue.c:
1981 (modest_mail_operation_queue_remove):
1982 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1983 about where they happened.
1985 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-ui-actions.c:
1988 (modest_ui_actions_on_password_requested): Make sure that the remember
1989 output parameter is always TRUE.
1991 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1993 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1994 Show a OK/Cancel dialog if the error is a question, though we still do not
1995 know anything more about what we are asking the user.
1996 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1997 Fix an uninitialized variable (helper). This is a logic error, however.
1999 2007-05-21 Christian Kellner <ckellner@openismus.com>
2001 * src/modest-search.h:
2002 Correct bit shifting in the ModestSearchFlags enum.
2004 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2006 * src/modest-tny-account.c:
2007 (modest_tny_account_new_from_server_account): Do not use the lsub and
2008 check-all hard-coded IMAP options when using POP.
2010 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2012 * src/modest-tny-account.c:
2013 (modest_tny_account_new_from_server_account):
2014 Use NULL for the secure-auth method for POP when Password auth has been
2015 specified by the user, as we already do for IMAP. "auth=Login" causes
2016 an error from camel or the server.
2018 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2020 * src/maemo/modest-account-settings-dialog.c:
2021 (create_page_account_details),
2022 (modest_account_settings_dialog_set_account_name):
2023 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2024 for the leave-on-server checkbox, rathr than just the checkbox, when
2025 the protocol is not POP.
2027 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2029 * src/widgets/modest-account-view.c:
2030 * src/widgets/modest-account-view.h:
2031 Added modest_account_view_select_account() which will be useful later
2032 to asynchronously re-select the edited account.
2034 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2036 * src/maemo/modest-account-settings-dialog.c:
2037 (modest_account_settings_dialog_set_account_name):
2038 Automatically choose the port numbers based on the secure authentication
2039 methods, if they have not been chosen before.
2040 This fixes projects.maemo.org bug NB#56273 .
2042 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2044 * src/maemo/modest-main-window-ui.h:
2045 * src/modest-ui-actions.c:
2046 * src/modest-ui-actions.h:
2047 Connect the Tools/SMTP Servers menu item to
2048 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2049 SMTP servers dialog, as in the UI specification and saves changes when it
2050 is closed. This fixed projects.maemo.org bug NB#56305 .
2052 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2054 * src/maemo/modest-connection-specific-smtp-window.c:
2055 (modest_connection_specific_smtp_window_init):
2056 Use gtk_window_set_default_size() to make this window big enough, so
2057 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2059 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2061 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2062 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2063 (modest_connection_specific_smtp_edit_window_init),
2064 Do not try to connect to a combobox signal before the combobox exists.
2065 This fixes the cras in projects.maemo.org bug NB#56288 .
2066 (modest_connection_specific_smtp_edit_window_get_settings):
2067 Remove the server_account_name parameter which was being checked for NULL
2068 though it was not used.
2070 * src/maemo/modest-connection-specific-smtp-window.c:
2071 (modest_connection_specific_smtp_window_fill_with_connections),
2072 (on_button_edit), (modest_connection_specific_smtp_window_init):
2073 Correct the number of treemodel columns to prevent a warning.
2074 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2075 libconic does not work.
2077 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2079 * src/modest-tny-account.c:
2080 (modest_tny_account_new_from_server_account):
2081 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2082 SMTP when "None" was chosen by the user. However, with my SMTP server that
2083 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2086 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2088 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2089 to explain the memory management issue with the ID in the ModestPair.
2091 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2092 (add_sending_page), (modest_account_assistant_finalize):
2093 * src/gnome/modest-gnome-global-settings-dialog.c:
2094 (create_updating_page), (create_composing_page):
2095 * src/gnome/modest-msg-edit-window.c: (get_transports),
2096 (init_window), (modest_msg_edit_window_finalize),
2097 (modest_msg_edit_window_get_msg_data):
2098 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2099 * src/gnome/modest-transport-widget.c:
2100 (modest_transport_widget_finalize), (smtp_configuration):
2101 * src/maemo/modest-maemo-global-settings-dialog.c:
2102 (create_updating_page), (create_composing_page):
2103 * src/maemo/modest-msg-edit-window.c: (get_transports),
2104 (init_window), (modest_msg_edit_window_finalize),
2105 (modest_msg_edit_window_get_msg_data),
2106 (modest_msg_edit_window_free_msg_data):
2107 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2108 (modest_store_widget_finalize):
2109 * src/maemo/modest-transport-widget.c:
2110 (modest_transport_widget_finalize), (smtp_configuration):
2111 * src/modest-main.c: (send_mail):
2112 * src/widgets/modest-combo-box.h:
2113 * src/widgets/modest-global-settings-dialog-priv.h:
2114 * src/widgets/modest-global-settings-dialog.c:
2115 (modest_global_settings_dialog_finalize):
2116 * src/widgets/modest-msg-edit-window.h:
2117 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2118 as long as the combo box, to prevent use of freed memory for the ID.
2120 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2122 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2123 get_accounts(), to make this clearer. Do not check for the enabled gconf
2124 key, because we do not use this for server accounts (at least, not yet).
2125 This allows us to send email again.
2127 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2129 * src/maemo/modest-platform.c:
2130 (on_modest_conf_update_interval_changed), (modest_platform_init):
2131 Only respond to this particular key change. All these strcmp()s cannot be
2134 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2136 * src/maemo/modest-maemo-global-settings-dialog.c:
2137 (current_connection): Prevent a crash in scratchbox when
2138 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2139 * src/maemo/modest-platform.c:
2140 (on_modest_conf_update_interval_changed), (modest_platform_init):
2141 Get the update interval from gconf and reset it when the gconf key changes.
2143 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2145 * src/modest-protocol-info.c:
2146 * src/modest-protocol-info.h: Adde enum-specific get functions,
2147 instead of using a ModestProtocolType enum parameter.
2149 * src/gnome/modest-account-assistant.c:
2150 * src/gnome/modest-store-widget.c:
2151 * src/gnome/modest-store-widget.h:
2152 * src/gnome/modest-transport-widget.c:
2153 * src/gnome/modest-transport-widget.h:
2154 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2155 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2156 * src/maemo/easysetup/modest-easysetup-wizard.c:
2157 * src/maemo/modest-account-settings-dialog.c:
2158 * src/maemo/modest-account-settings-dialog.h:
2159 * src/maemo/modest-store-widget.c:
2160 * src/maemo/modest-store-widget.h:
2161 * src/maemo/modest-transport-widget.c:
2162 * src/maemo/modest-transport-widget.h:
2163 * src/modest-account-mgr-helpers.c:
2164 * src/modest-account-mgr-helpers.h:
2165 * src/modest-account-mgr.c:
2166 * src/modest-account-mgr.h:
2167 * src/modest-tny-account.c:
2168 * src/modest-tny-folder.c:
2169 * src/widgets/modest-account-view.c:
2170 * src/widgets/modest-retrieve-combo-box.c:
2171 * src/widgets/modest-retrieve-combo-box.h:
2172 * src/widgets/modest-secureauth-combo-box.c:
2173 * src/widgets/modest-serversecurity-combo-box.c:
2174 * src/widgets/modest-serversecurity-combo-box.h:
2175 * tests/check_account-mgr.c:
2176 Use the specific functions, and use the re-renamed enum values for GNOME too.
2178 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2180 * src/modest-pair.h:
2181 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2182 so we can get the second based on the first.
2184 * src/maemo/modest-account-settings-dialog.h:
2185 * src/maemo/modest-account-settings-dialog.c:
2186 Added get_supported_secure_authentication_methods(), though it is mostly
2187 commented-out for now until the necessary API is committed to tinymail.
2188 (modest_account_settings_dialog_set_account_name),
2189 (save_configuration): Request the supported authentication methods from the
2190 server, so we can choose a working method.
2192 * src/modest-tny-account-store.h:
2193 * src/modest-tny-account-store.c:
2194 (modest_tny_account_store_get_session): Rename from
2195 tny_account_store_get_session().
2197 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2199 * src/modest-protocol-info.h: Split the ModestProtocol enum
2200 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2201 There was no need to have these unrelated values in one enum.
2203 * src/: many files: Adapted to changed enum. This makes the code a bit
2204 clearer, and the compiler could catch some errors.
2206 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2208 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2209 Show the detailed internal camel error message when an error happens
2210 during the configuration, so that our testers can give us more clues.
2211 For instance, in projects.maemo.org bug NB#56910 .
2213 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2215 * src/modest-tny-account.c:
2216 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2217 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2219 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2221 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2222 * src/maemo/modest-account-settings-dialog.c:
2223 (modest_account_settings_dialog_set_account_name),
2224 (save_configuration): For the incoming secure authentication checkbox,
2225 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2226 the UI specification. PLAIN does not seem to be supported for most IMAP
2227 servers anyway, and I am not sure what it would mean.
2228 However, we probably need to discover which of the secure-authentication
2229 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2230 * src/modest-account-mgr-helpers.c:
2231 (modest_account_mgr_get_server_account_data):
2233 * src/modest-tny-account.c:
2234 (modest_tny_account_new_from_server_account):
2235 Use tny_account_set_mech() to set secure-authentication methods,
2236 with some special-casing for IMAP, based on my observations of how
2239 * src/modest-account-mgr-helpers.h:
2240 * src/modest-account-mgr.c:
2241 * src/modest-defs.h: Comment that the URI is only used for local folders.
2243 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2245 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2246 parameter const, just to be neat.
2247 * src/modest-text-utils.c: (modest_text_utils_inline):
2248 End g_strconcat() with NULL, as its documentation says. This is almost
2249 certainly the cause of my crash at startup on the device. Interestingly,
2250 valgrind doesn't tell us about these errors.
2252 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2254 * scripts/build-packages: Added more precise comments about how to use
2255 this script, though I still get this error:
2256 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2257 error building tinymail
2259 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2261 * src/maemo/modest-main-window.c: (on_account_update):
2262 Very slight cleanup, hoping to make it simpler to discover what causes
2263 a crash here sometimes.
2265 * src/modest-tny-account.c:
2266 (modest_tny_account_new_from_server_account): Set the port. Added
2267 comments about the options and a TODO comment because I need to find out
2268 how to specify the secure authentication method.
2270 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2272 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2273 changed CFlags paths form modest to libmodest
2275 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2277 * src/modest-account-mgr-helpers.c:
2278 (modest_account_mgr_get_server_account_data),
2279 (modest_account_mgr_free_server_account_data):
2280 * src/modest-account-mgr-helpers.h:
2281 * src/modest-account-mgr.c:
2282 (modest_account_mgr_add_server_account):
2283 * src/modest-defs.h:
2284 * src/modest-tny-account.c:
2285 (modest_tny_account_new_from_server_account):
2286 Determine the options for tny_camel_account_add_option() here,
2287 based on the settings, rather than storing them directly in gconf.
2289 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2291 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2292 Show a more friendly error dialog now that we expect (from the tinymail
2293 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2295 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2297 * src/maemo/modest-main-window.c: (on_account_update): Check that
2298 account_name is not NULL, to prevent a crash at startup that I am
2299 seeing on the N800. I do wonder why it is NULL.
2301 * src/maemo/easysetup/modest-easysetup-wizard.c:
2302 (create_page_user_details):
2303 * src/maemo/modest-account-settings-dialog.c:
2304 (create_page_user_details), (create_page_outgoing):
2305 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2306 (modest_connection_specific_smtp_edit_window_init):
2307 * src/modest-ui-actions.c:
2308 (modest_ui_actions_on_password_requested):
2309 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2310 might do something useful with the on-screen keyboard.
2312 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2314 * src/maemo/modest-main-window.c: (on_account_update):
2315 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2316 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2318 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2320 * src/modest-tny-account-store.c: (on_account_changed):
2321 Correct the signature of this signal handler.
2323 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2325 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2326 Show a HildonNote instead of a GtkDialog for Maemo.
2328 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2330 * src/widgets/modest-account-view.h:
2331 * src/widgets/modest-account-view.c: (on_account_changed),
2332 (on_account_removed). Added a boolean flag, set/unset by
2333 modest_account_view_block_conf_updates(),
2334 modest_account_view_unblock_conf_updates() to prevent unnecessary
2335 updates, but this is not very useful because the gconf notifications are
2336 so delays (maybe only on Maemo Bora).
2337 So auto-updating is turned off, and these functions do an explicit
2338 update when necessary.
2339 However, something else is still doing too much work when adding/removing
2340 accounts, probably in another part of the application.
2342 * src/maemo/modest-account-view-window.c:
2343 (on_delete_button_clicked), (on_edit_button_clicked),
2344 (on_new_button_clicked): Use the new functions.
2346 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2348 * src/modest-account-mgr-helpers.c:
2349 (modest_account_mgr_set_first_account_as_default):
2350 Sort the list of names alphabetically-by-title, so we choose the first one
2352 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2353 alphabetically by the title.
2355 This fixes projects.maemo.org bug NB#56418 .
2357 * src/modest-account-mgr-priv.c:
2358 (_modest_account_mgr_account_from_key):
2359 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2360 avoid a valgrind error, and possible random behaviour.
2362 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2364 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2365 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2366 tinymail documentation to say that this can be expected.
2367 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2368 pretty, and should not happen, but I would prefer to know when it does.
2370 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2372 * configure.ac: When using the older hildon version, probably on Bora,
2373 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2375 * src/widgets/modest-attachment-view.c:
2376 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2379 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2381 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2382 Implemented the prototype. Can be tested with
2383 tests/dbus_api/test_open_message:
2385 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2387 * src/modest-tny-account-store.c:
2388 (modest_tny_account_store_instance_init), (get_password):
2389 * src/modest-ui-actions.c:
2390 (modest_ui_actions_on_password_requested):
2391 Do not store the password in gconf, because this function is called
2392 for non-remembered passwords. Actually use the cached (in the hash map)
2393 password instead of releasing it.
2394 The password will now not be remembered if it is asked via the protected
2395 password dialog, as per the UI spec.
2397 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2399 * src/modest-defs.h:
2400 * src/modest-account-mgr-helpers.h:
2401 * src/modest-account-mgr-helpers.c:
2402 Added modest_server_account_get_username_has_succeeded(),
2403 modest_server_account_set_username_has_succeeded().
2404 (modest_server_account_set_username),
2405 Reset the has-succeeded flag if the username changes.
2407 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2408 * src/maemo/modest-connection-specific-smtp-window.c:
2409 (modest_connection_specific_smtp_window_save_server_accounts):
2410 Use modest_server_account_set_username() instead of using
2411 modest_conf_set_string() directly, so that the has-succeeded flag is always
2414 * src/modest-ui-actions.c:
2415 (modest_ui_actions_on_password_requested): Dim the username entry if
2416 the username has ever worked, as per the UI spec.
2418 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2420 * src/modest-tny-account-store.c: (get_password):
2421 * src/modest-ui-actions.c:
2422 (modest_ui_actions_on_password_requested):
2423 Allow the username to be changed too, though there is more work to
2424 be done on exactly how this behaves.
2426 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2428 * src/modest-account-mgr-helpers.h:
2429 * src/modest-account-mgr-helpers.c:
2430 Added modest_account_mgr_get_display_name(),
2431 modest_server_account_get_username(),
2432 modest_server_account_set_username(),
2433 modest_server_account_set_password(),
2434 modest_server_account_get_hostname() functions so we do not need to
2435 use the conf API directly.
2437 * src/maemo/modest-main-window.c: (connect_signals):
2438 Actually connect ot the ModestAccountStore::request-password signal,
2439 so that we show the dialog when the password is requested by Tinymail,
2440 for isntance if it is empty.
2442 * src/modest-marshal.list:
2443 * src/modest-tny-account-store.c:
2444 (modest_tny_account_store_class_init), (get_password),
2445 (modest_tny_account_store_alert):
2446 * src/modest-tny-account-store.h:
2447 * src/modest-ui-actions.h:
2448 * src/modest-ui-actions.c:
2449 (modest_ui_actions_on_password_requested):
2450 Change the signal parameters, so it is obvious that we are providing
2451 the non human-readable server name, and receiving both the username
2452 and password, though changing of the username is not yet implemented.
2453 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2454 for the GNOME version.
2456 This should fix the projects.maemo.org bug NB#56209, though it does not
2457 work on Bora, because the gconf_client_get() for the password fails
2458 immediately after we save it with gconf_client_set().
2460 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2463 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2464 caused an undefined symbol error:
2465 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2467 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2469 * src/modest-tny-account-store.c:
2470 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2471 using a GError instead of a string message, so we can translate it in
2474 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2476 * src/maemo/modest-address-book.c:
2477 (modest_address_book_check_names):
2478 * src/maemo/modest-msg-view-window.c:
2479 (modest_msg_view_window_clipboard_owner_change):
2480 * src/modest-init.c: (modest_init_init_ui):
2481 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2482 (update_folders_cb), (modest_mail_operation_update_account):
2483 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2484 (modest_ui_actions_on_msg_attachment_clicked),
2485 (modest_ui_actions_on_msg_recpt_activated):
2486 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2487 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2488 (modest_msg_view_search_next):
2489 * src/widgets/modest-recpt-editor.c:
2490 (modest_recpt_editor_on_button_release_event),
2491 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2492 g_message(). At this point we should only be seeing interesting errors on
2493 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2495 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2497 (modest_wizard_dialog_force_title_update):
2498 * src/maemo/easysetup/modest-wizard-dialog.h:
2499 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2500 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2501 can update the title when appropriate. Otherwise the title is wrong if the
2502 pages are added after adding the notebook to the dialog.
2503 This must be a problem in HildonWizardDialog too.
2504 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2506 * src/maemo/easysetup/modest-easysetup-wizard.c:
2507 (create_subsequent_customsetup_pages),
2508 (create_subsequent_easysetup_pages):
2509 Call modest_wizard_dialog_force_title_update() so that the title is
2510 correct even with GTK+ < 2.10.
2511 This fixes projects.maemo.org bug NB#56145 .
2513 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2515 * src/maemo/modest-platform.c:
2516 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2517 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2520 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2522 * src/widgets/modest-window.h:
2523 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2524 and modest_window_save_state(), which invokes it.
2526 * src/widgets/modest-window-mgr.h:
2527 * src/widgets/modest-window-mgr.c:
2528 Added modest_window_mgr_save_state_for_all_windows(), which calls
2529 the save_state vfunc on all registered windows, if implemented.
2531 * src/gnome/modest-msg-edit-window.c:
2532 * src/gnome/modest-msg-view-window.c:
2533 * src/maemo/modest-msg-edit-window.c:
2534 * src/maemo/modest-msg-view-window.c:
2535 * src/maemo/modest-main-window.c:
2536 Specify the existing save_settings functions as implementations of
2537 ModestWindow::save_state_func().
2539 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2540 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2541 enabling hibernation, for instance.
2543 We may need to do the same thing for restoring settings.
2546 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2548 * src/widgets/modest-window-mgr.c:
2549 * src/widgets/modest-window-mgr.h:
2550 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2551 modest_window_mgr_get_hibernation_is_prevented().
2553 * src/maemo/modest-main-window.c:
2554 (on_hildon_program_is_topmost_notify): Prevent hibernation
2555 (possible when the application goes to the background in the WM),
2556 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2558 * src/maemo/easysetup/modest-easysetup-wizard.c:
2559 (modest_easysetup_wizard_dialog_init):
2560 * src/maemo/modest-account-settings-dialog.c:
2561 (modest_account_settings_dialog_init):
2562 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2563 (modest_connection_specific_smtp_edit_window_init):
2564 * src/maemo/modest-connection-specific-smtp-window.c:
2565 (modest_connection_specific_smtp_window_init):
2566 * src/maemo/modest-signature-editor-dialog.c:
2567 (modest_signature_editor_dialog_init):
2568 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2569 prevent hibernation while any of these account settings dialogs are open.
2571 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2573 * src/maemo/Makefile.am:
2574 * src/maemo/modest-osso-state-saving.c:
2575 * src/maemo/modest-osso-state-saving.h: Added
2576 modest_osso_load_state() and modest_osso_save_state() though they do
2577 nothing now. They should iterate through all the open windows and load/save
2579 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2580 save state when closing.
2582 * src/maemo/modest-main-window.c:
2583 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2584 Add a notification handler for the HildonProgram::is-topmost property,
2585 so we can allow hibernation when the application goes into the background.
2586 But we still need to detect when the accounts setup windows are open so
2587 we can stop hibernation when they are open.
2588 To do this, I also added the main window the HildonProgram. This might have
2589 other side-effects/benefits, and should maybe be done for other windows.
2591 * src/maemo/modest-osso-autosave-callbacks.h:
2592 * src/maemo/modest-osso-autosave-callbacks.c:
2593 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2594 though it does not do anything yet, and we might never need this to do
2595 anything. For instance, we already save drafts.
2597 * src/maemo/modest-platform.c: (modest_platform_init):
2598 Specify the libosso auto-save callback.
2600 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2602 * src/maemo/modest-platform.c:
2603 (modest_platform_set_update_interval):
2604 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2605 aparently stays valid between application instances, so we can use this
2606 to remove and reset it later. According to a maemo-developers email from
2609 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2611 * configure.ac: Depend on libalarm for Maemo.
2613 * src/dbus_api/modest-dbus-api.h:
2614 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2615 (on_send_receive), (modest_dbus_req_handler):
2616 Handle a SEND_RECEIVE D-Bus method.
2618 * libmodest-dbus-client/libmodest-dbus-client.c:
2619 (libmodest_dbus_client_send_and_receive):
2620 * libmodest-dbus-client/libmodest-dbus-client.h:
2621 Add C convenience functions for calling the new D-Bus method.
2623 * src/modest-platform.h:
2624 * src/gnome/modest-platform.c:
2625 * src/maemo/modest-platform.c:
2626 Added modest_platform_set_update_interval(), which uses the
2627 alarmd API on Maemo.
2628 (modest_platform_init),
2629 Call modest_platform_set_update_interval(), using a hard-coded
2630 interval for now (until the global settings dialog is implemented),
2631 though I am not sure that this makes sense yet.
2633 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2635 * src/dbus_api/modest-dbus-callbacks.c:
2636 (modest_osso_cb_hw_state_handler):
2637 * src/dbus_api/modest-dbus-callbacks.h:
2638 * src/maemo/modest-platform.c: (modest_platform_init):
2639 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2640 in case this has some effect on the ability for Maemo to ping the
2643 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2645 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2646 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2647 warning. It is probably a logic error, but I need to fix the build.
2649 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2651 * src/modest-account-mgr.h:
2652 * src/modest-account-mgr.c:
2653 (modest_account_mgr_account_names): Add a gboolean enabled_only
2654 parameter, so we can get lists of onlt the enabled accounts.
2656 (modest_account_mgr_add_account),,
2657 (modest_account_mgr_account_with_display_name_exists):
2658 * src/maemo/modest-msg-edit-window.c: (get_transports):
2659 * src/modest-account-mgr-helpers.c:
2660 (modest_account_mgr_set_first_account_as_default):
2661 * src/modest-init.c: (init_default_account_maybe):
2662 * src/modest-tny-account-store.c: (get_accounts):
2663 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2664 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2665 * tests/check_account-mgr.c: (START_TEST):
2666 Provide the extra parameter, as appropriate.
2668 * src/widgets/modest-account-view.c: (update_account_view):
2669 Do not show disabled accounts (meaning that there is no way to
2670 enable/disable accounts in the UI (the feature is not in our UI
2671 specification), so we can use this internally only to mark unfinished
2672 or temporary account data.
2674 * src/maemo/easysetup/modest-easysetup-wizard.c:
2675 (create_account): Add boolean enable parameter, so we can specify FALSE
2676 to create the temporary account.
2677 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2678 (on_before_next): When finishing, when there is a temporary account, just
2680 Also, use a timeout to delay the showing of the dialog until gconf is likely
2681 to return correct information, due to a maemo gconf bug that is fixed in
2682 osso 1.1, but not yet in Bora.
2683 However, the dialog stays on screen after it is destroyed.
2685 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2686 for invalid data when cancelling. Use a hildon note instead of a dialog
2687 to complain about invalid data. Do not show the account-saved note if the
2688 account is disabled (a temporary account that will not really be saved for use
2691 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2693 * src/modest-account-mgr-helpers.h:
2694 * src/modest-account-mgr-helpers.c:
2695 Added modest_account_mgr_unset_default_account(),
2696 Added modest_account_mgr_set_first_account_as_default().
2698 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2699 If it was the default account, unset the default account name.
2701 * src/maemo/modest-account-view-window.c:
2702 (on_delete_button_clicked): If it was the default account,
2703 set the first remaining account as the default instead.
2705 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2706 a NULL account or a NULL default account, to prevent a crash. This should
2707 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2710 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2712 * src/widgets/modest-recpt-editor.c:
2713 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2714 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2715 TODO comment for this. This fixes the build.
2717 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2718 be the best place for it. This will in future update all auto-update accounts,
2719 rather than just the current/default account, when that gconf key exists.
2720 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2721 if there are no accounts, before calling do_send_receive().
2722 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2724 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2725 * src/maemo/modest-main-window-ui.h:
2726 * src/maemo/modest-main-window.c: (on_connection_changed),
2727 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2728 directly, becaue the signal handler does more.
2730 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2732 * src/modest-account-mgr-helpers.c:
2733 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2734 for the case that the account does not exist.
2736 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2737 (equivalent to the modest account name) rather than the tinymail account name
2738 (equivalent to the modest account title - human readable) to get the account data.
2739 Check for null account data to prevent the crash, and add a TODO comment saying that
2740 this needs fixing because it is using the server account name instead of the account name.
2742 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2744 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2745 * src/maemo/modest-account-settings-dialog.c: (show_error),
2747 Use hildon_note_new_information() for informative and error messages,
2748 which seems to be expected for Maemo applications (no documentation that I know of
2749 says this). I am surprised that there is no distinction between info and error
2752 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2754 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2755 it is easy to find where this is used.
2757 * src/maemo/easysetup/modest-easysetup-wizard.c:
2758 (create_page_welcome), (create_page_account_details),
2759 (create_page_user_details), (create_page_complete_easysetup),
2760 (create_page_custom_incoming), (create_page_custom_outgoing),
2761 (create_page_complete_custom):
2762 * src/maemo/modest-account-settings-dialog.c:
2763 (create_page_account_details), (create_page_user_details),
2764 (create_page_incoming), (create_page_outgoing):
2765 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2766 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2767 (modest_connection_specific_smtp_edit_window_init):
2768 * src/maemo/modest-connection-specific-smtp-window.c:
2769 (modest_connection_specific_smtp_window_init):
2770 * src/maemo/modest-signature-editor-dialog.c:
2771 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2772 and scrolling policy as per the Email Application Layout Guide, if I have
2775 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2777 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2778 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2779 which were empty, because these vfuncs have been removed from TnyAccountStore.
2780 This fixes the build.
2782 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2784 * src/maemo/modest-main-window.c:
2785 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2786 showing/hiding it. Added TODO because it probably should not be NULL.
2787 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2788 because unnecessary g_warnings() make degugging difficult.
2790 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2792 * src/maemo/modest-msg-edit-window.c:
2793 (modest_msg_edit_window_select_color),
2794 (modest_msg_edit_window_select_background_color): 2 const corrections and
2795 moving 2 #endifs before closing brackets, to fix the build.
2797 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2799 * src/maemo/easysetup/modest-easysetup-wizard.h:
2800 * src/maemo/easysetup/modest-easysetup-wizard.c:
2801 (modest_easysetup_wizard_dialog_finalize),
2802 (on_button_edit_advanced_settings), (create_page_complete_custom),
2803 (on_response), (create_account):
2804 Implement the Advanced Settings edit button, by saving the account information,
2805 for the Advanded Settings dialog to use directly from gconf, and removing it
2806 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2807 Bug #5533 in the projects.maemo.org bugzilla.
2809 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2811 * src/maemo/modest-msg-view-window.c:
2812 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2813 when opening a message window.
2815 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2817 * src/maemo/easysetup/modest-easysetup-wizard.c:
2818 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2821 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2822 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2823 gconf settings. I probably added more checks than necessary, but that is safer.
2825 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2826 variable to fix the build, but this seems to be used when it is still NULL.
2828 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2830 * src/modest-platform.h:
2831 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2832 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2833 * src/modest-main.c: Implement this function so we can avoid using
2834 maemo-specific API from cross-platform code.
2836 * src/modest-tny-account-store.c:
2837 (get_smtp_specific_transport_account_for_open_connection):
2838 * src/modest-ui-actions.c: (check_for_connection),
2839 (modest_ui_actions_on_item_not_found):
2840 Use modest_platform_connect_and_wait() and put #idefs around other
2841 maemo-specific code, because only maemo currently has a way to
2842 identify connection names.
2844 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2846 * src/modest-tny-account-store.h:
2847 * src/modest-tny-account-store.c:
2848 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2849 the connection-specific SMTP server settings in the configuration.
2851 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2853 * src/maemo/modest-main-window.c: (on_connection_changed),
2855 * src/modest-main.c: (main), (start_ui), (send_mail):
2856 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2857 that is what is intended.
2859 * src/modest-ui-actions.c: (action_send), (action_receive),
2860 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2861 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2862 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2863 SMTP server is used when it is specified.
2865 (modest_ui_actions_on_send_receive):
2866 Check that a connection is open before proceeding.
2867 Receive and then send, instead of vice-versa, as per the specification.
2869 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2871 * src/modest-mail-operation.c:
2872 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2873 though I guess it should be something other than NULL.
2875 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2877 * src/maemo/easysetup/modest-easysetup-wizard.c:
2878 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2879 combo twice, to avoid an g_warning and to make it visible again.
2880 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2881 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2882 (already intended) dereference when detaching, because we then recreate the menu.
2883 But I am not sure why the warning was happening, and it is possible that this is a memory
2886 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2888 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2889 and uri_parse_mailto() utility functions.
2890 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2892 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2894 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2896 * src/dbus_api/modest-dbus-api.h:
2897 * src/dbus_api/modest-dbus-callbacks.c:
2898 Use an idle callback to execute the modest code in the application's own thread.
2899 Remove the helloworld example method.
2900 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2901 parsed, and the open-message method is not implemented because this is not yet implemented in
2903 * libmodest-dbus-client/libmodest-dbus-client.c:
2904 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2905 (libmodest_dbus_client_open_message):
2906 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2908 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2909 body without crashing.
2911 * tests/dbus_api/Makefile.am:
2912 * tests/dbus_api/test_mail_to.c:
2913 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2915 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2917 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2918 Added file to fix the build. Sorry.
2920 * src/dbus_api/Makefile.am:
2921 * src/dbus_api/modest-dbus-api.h:
2922 * src/dbus_api/modest-dbus-callbacks.h:
2923 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2924 (modest_dbus_req_handler):
2925 Put constants in a separate header so it can be reused by the
2926 client library, without duplication
2928 * libmodest-dbus-client/Makefile.am:
2929 * libmodest-dbus-client/libmodest-dbus-client.c:
2930 (libmodest_dbus_client_call_helloworld),
2931 (libmodfest_dbus_client_send_mail),
2932 (libmodfest_dbus_client_mailto),
2933 (libmodfest_dbus_client_open_message):
2934 * libmodest-dbus-client/libmodest-dbus-client.h:
2935 (Partly) Implement a send_mail D-Bus method.
2937 * tests/dbus_api/Makefile.am:
2938 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2939 the send_email D-Bus method.
2941 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2945 * libmodest-dbus-client/Makefile.am:
2946 * libmodest-dbus-client/libmodest-dbus-client.c:
2947 * libmodest-dbus-client/libmodest-dbus-client.h:
2948 * tests/dbus_api/Makefile.am:
2949 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2950 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2952 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2954 * src/maemo/easysetup/modest-easysetup-wizard.c:
2955 (create_page_account_details):
2956 * src/maemo/modest-account-settings-dialog.c:
2957 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2958 widgets, because this might not be the default in future versions of the Maemo GTK+.
2959 However, I can not not get capitalization to work even in a simple test case.
2961 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2963 * src/maemo/easysetup/modest-easysetup-wizard.c:
2964 (create_page_custom_incoming), (create_page_custom_outgoing):
2965 * src/maemo/modest-account-settings-dialog.c:
2966 (create_page_account_details), (create_page_incoming),
2967 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2968 instead of using gtk_check_button_with_label(), so they are aligned like the other
2969 widgets, as per the UI spec.
2971 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2973 * src/maemo/easysetup/modest-easysetup-wizard.c:
2974 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2975 * src/widgets/modest-validating-entry.c:
2976 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2977 Modest prefix instead of an EasySetup prefix.
2979 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2981 * src/widgets/modest-validating-entry.h:
2982 * src/widgets/modest-validating-entry.c: (on_insert_text),
2983 Added easysetup_validating_entry_set_max_func(), used to set a callback
2984 to call when the max number of characters is reached. GtkEntry has a max-length
2985 already but is silent about it.
2987 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2988 (create_page_account_details), (create_page_user_details),
2990 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2991 (create_page_account_details), (create_page_user_details),
2992 (create_page_outgoing):
2993 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2994 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2995 the UI spec, when the user tries to enter more than the max number of characters.
2997 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2999 * src/maemo/easysetup/modest-easysetup-wizard.c:
3000 (create_page_user_details), (create_page_custom_incoming),
3001 (create_page_custom_outgoing):
3002 * src/maemo/modest-account-settings-dialog.c:
3003 (create_page_user_details), (create_page_incoming),
3004 (create_page_outgoing):
3005 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3006 (modest_connection_specific_smtp_edit_window_init):
3007 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3008 not appropriate. Bad Maemo-specific defaults!.
3010 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3012 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3013 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3014 (modest_signature_editor_dialog_set_settings):
3015 Disable the label and textview when the checkbox is disabled, and use the
3016 specified (UI spec) default signature text.
3018 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3020 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3021 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3023 * src/modest-defs.h:
3024 * src/modest-account-mgr-helpers.h:
3025 * src/modest-account-mgr-helpers.c:
3026 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3028 * src/maemo/Makefile.am:
3029 * src/maemo/modest-signature-editor-dialog.c:
3030 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3033 * src/maemo/modest-account-settings-dialog.h:
3034 * src/maemo/modest-account-settings-dialog.c:
3035 (modest_account_settings_dialog_finalize), (on_button_signature),
3036 (save_configuration): Use the new dialog when the Edit button is pressed, and
3037 save the changes if necessary, as per the UI spec.
3039 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3041 * src/maemo/Makefile.am:
3042 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3043 based on maemo-develoers email from Dirk.
3045 * src/maemo/easysetup/modest-easysetup-wizard.c:
3046 (create_page_welcome), (create_page_account_details),
3047 (create_page_user_details), (create_page_complete_easysetup),
3048 (create_page_custom_incoming), (create_page_custom_outgoing),
3049 (create_page_complete_custom),
3050 (modest_easysetup_wizard_dialog_init):
3051 * src/maemo/modest-account-settings-dialog.c:
3052 (create_page_account_details), (create_page_user_details),
3053 (create_page_incoming), (create_page_outgoing),
3054 (modest_account_settings_dialog_init):
3055 * src/maemo/modest-connection-specific-smtp-window.c:
3056 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3058 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3060 * src/maemo/easysetup/modest-easysetup-wizard.c:
3061 (create_page_account_details), (create_page_custom_outgoing),
3062 (create_page_complete_custom):
3063 * src/maemo/modest-account-settings-dialog.c:
3064 (create_page_user_details), (create_page_incoming),
3065 (create_page_outgoing):
3066 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3067 (modest_connection_specific_smtp_edit_window_init):
3068 Use the correct (UI spec) port min/max, and use horizontal separators,
3071 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3073 * src/maemo/easysetup/modest-easysetup-wizard.c:
3074 (set_default_custom_servernames):
3075 * src/maemo/modest-account-settings-dialog.c:
3076 (create_page_incoming), (on_combo_outgoing_security_changed),
3077 (on_combo_incoming_security_changed), (create_page_outgoing),
3078 (modest_account_settings_dialog_set_account_name),
3079 (save_configuration):
3080 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3081 (on_combo_security_changed),
3082 (modest_connection_specific_smtp_edit_window_init),
3083 (modest_connection_specific_smtp_edit_window_set_connection),
3084 (modest_connection_specific_smtp_edit_window_get_settings):
3085 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3088 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3091 * src/maemo/easysetup/modest-easysetup-wizard.c:
3092 (create_page_custom_outgoing), (create_page_complete_custom):
3093 * src/maemo/modest-account-settings-dialog.c:
3094 (create_page_user_details), (create_page_outgoing):
3095 * src/maemo/modest-account-view-window.c: (button_box_new):
3096 Use changed logical IDs as per the most recent UI spec:
3097 mcen_bd_emailsetup_edit -> mcen_bd_edit
3098 mcen_bd_emailsetup_delete -> mcen_bd_delete
3099 mcen_bd_emailsetup_close -> mcen_bd_close
3101 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3105 * src/dbus_api/Makefile.am:
3106 * src/dbus_api/modest-dbus-callbacks.c:
3107 * src/dbus_api/modest-dbus-callbacks.h:
3108 * src/maemo/modest-platform.c: (modest_platform_init):
3109 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3111 * tests/Makefile.am:
3112 * tests/dbus_api/Makefile.am:
3113 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3115 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3117 * src/maemo/modest-account-settings-dialog.c:
3118 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3119 Removed unnecessary includes.
3121 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3123 * src/maemo/easysetup/modest-easysetup-wizard.c:
3124 * src/maemo/modest-account-settings-dialog.c:
3125 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3126 * src/widgets/Makefile.am:
3127 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3128 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3129 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3130 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3131 * src/widgets/modest-secureauth-combo-box.c:
3132 * src/widgets/modest-secureauth-combo-box.h:
3133 * src/widgets/modest-serversecurity-combo-box.c:
3134 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3135 made the GObject names more consistent with the rest of the Modest code.
3137 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3139 * src/maemo/easysetup/Makefile.am:
3140 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3141 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3142 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3143 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3144 * src/maemo/easysetup/modest-easysetup-wizard.c:
3145 * src/maemo/easysetup/modest-validating-entry.c:
3146 * src/maemo/easysetup/modest-validating-entry.h:
3147 * src/maemo/modest-account-settings-dialog.c:
3148 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3149 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3150 widgets/ because they are used outside of easysetup too. After checking in,
3151 svn will allow me to rename them too.
3153 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3155 * src/gnome/modest-msg-edit-window.c:
3156 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3157 linker error, to fix the build on the GNOME platform.
3158 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3159 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3160 ifdefed out to avoid a warning.
3162 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3164 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3165 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3166 some alternative for GTK+ 2.6.
3168 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3170 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3172 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3173 specified for EmailAccountsDialog in UI spec.
3175 * src/maemo/easysetup/modest-easysetup-wizard.c:
3176 * src/maemo/easysetup/modest-easysetup-wizard.h:
3177 * src/maemo/modest-account-settings-dialog.c:
3178 * src/maemo/modest-account-settings-dialog.h:
3179 Reuse a member window widget for the connection-specific SMTP server accounts,
3180 so we can tell it to create/save the accounts only if we actually save changes.
3182 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3183 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3184 (modest_connection_specific_smtp_edit_window_get_settings):
3185 Return a struct instance for temporarily remembering the entered data.
3187 * src/maemo/modest-connection-specific-smtp-window.h:
3188 * src/maemo/modest-connection-specific-smtp-window.c:
3189 (modest_connection_specific_smtp_window_finalize),
3190 (modest_connection_specific_smtp_window_fill_with_connections),
3192 (modest_connection_specific_smtp_window_save_server_accounts),
3193 (update_model_server_names): Do not actually save data until asked,
3194 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3196 (on_selection_changed),
3197 (modest_connection_specific_smtp_window_init): Disable the edit
3198 button when nothing is selected.
3200 * src/modest-account-mgr-helpers.c:
3201 * src/modest-account-mgr-helpers.h:
3202 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3205 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3207 * src/modest-account-mgr-helpers.h:
3208 * src/modest-account-mgr-helpers.c:
3209 (modest_account_mgr_get_unused_account_name),
3210 (modest_account_mgr_get_unused_account_display_name): Added these
3211 utility functions, to avoid code duplication.
3213 * src/maemo/easysetup/modest-easysetup-wizard.c:
3214 (create_page_account_details), (create_account):
3215 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3216 (on_combo_security_changed),
3217 (modest_connection_specific_smtp_edit_window_init),
3218 (modest_connection_specific_smtp_edit_window_save_settings):
3219 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3220 * src/maemo/modest-connection-specific-smtp-window.c:
3221 (modest_connection_specific_smtp_window_finalize),
3222 (modest_connection_specific_smtp_window_fill_with_connections),
3223 (on_button_edit), (modest_connection_specific_smtp_window_init):
3224 * src/maemo/modest-connection-specific-smtp-window.h:
3225 Implementing saving of connection-specific server accounts.
3227 But I need to refactor this so we can save the data for each
3228 possible connection-specific account and only actually create the server accounts
3229 when the easysetup finished, or the OK button is pressed on the account settings
3232 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3234 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3235 (on_combo_security_changed):
3236 (modest_connection_specific_smtp_edit_window_init):
3237 Auto-fill the port number as in the account settings.
3239 (modest_connection_specific_smtp_edit_window_set_connection):
3240 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3241 * src/maemo/modest-connection-specific-smtp-window.c:
3242 (fill_with_connections), (on_button_edit),
3243 (modest_connection_specific_smtp_window_init):
3244 Turn the edit window into a dialog to simplify the code, and
3245 set a WM hint as in a GtkDialog, because only a popup can be on top of
3246 another window in Maemo, and popups usually have no WM decoration.
3248 * src/modest-defs.h:
3249 * src/modest-account-mgr-helpers.c:
3250 (modest_account_mgr_set_connection_specific_smtp),
3251 (modest_account_mgr_remove_connection_specific_smtp),
3252 (modest_account_mgr_get_connection_specific_smtp):
3253 * src/modest-account-mgr-helpers.h: Some functions to write the
3254 connection-specific SMTP server information. Not yet used.
3257 * src/widgets/modest-folder-view.c: (text_cell_data):
3258 Fix a warning about an uninitialized variable.
3259 (on_configuration_key_changed): Put an #ifdef around the use
3260 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3262 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3264 * src/maemo/modest-account-settings-dialog.h:
3265 * src/maemo/modest-account-settings-dialog.c:
3266 Added connect_for_modified() utility function to mark the new modified boolean.
3268 (create_page_account_details), (create_page_user_details),
3269 (create_page_incoming), (create_page_outgoing), (on_response),
3270 (modest_account_settings_dialog_init),
3271 (modest_account_settings_dialog_set_account_name):
3272 Only warn about unsaved changes when there are actually unsaved changes.
3274 * src/modest-account-mgr-helpers.c:
3275 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3276 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3277 to get the data from there in future.
3279 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3281 * src/modest-defs.h:
3283 * src/modest-account-mgr-helpers.h:
3284 * src/modest-account-mgr-helpers.c:
3285 Store the security account setting in a single conf key instead of using
3286 the options list, so that the list is left for just the to-be-removed camel hack,
3287 and because gconf_client_set_list() is failing for some reason.
3289 * src/modest-account-mgr.c:
3290 (modest_account_mgr_add_server_account):
3291 * src/maemo/modest-account-settings-dialog.c:
3292 (modest_account_settings_dialog_set_account_name),
3293 (save_configuration): Use the renamed functions.
3296 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3298 * src/widgets/Makefile.am:
3299 * src/widgets/modest-limit-retrieve-combo-box.c:
3300 * src/widgets/modest-limit-retrieve-combo-box.h:
3301 * src/widgets/modest-retrieve-combo-box.c:
3302 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3303 the account settings dialog.
3305 * src/modest-defs.h:
3306 * src/modest-account-mgr-helpers.h:
3307 * src/modest-account-mgr-helpers.c:
3308 (modest_server_account_get_option_secure_auth),
3309 (modest_server_account_set_option_secure_auth):
3310 * src/modest-account-mgr.c:
3311 (modest_account_mgr_add_server_account):
3312 Use the existing AUTH_MECH conf key for the secure-auth setting,
3313 instead of putting it in the list options, because this was actually used already.
3315 * src/maemo/modest-account-settings-dialog.c:
3316 (create_page_account_details),
3317 (modest_account_settings_dialog_set_account_name),
3318 (save_configuration):
3319 * src/maemo/modest-account-settings-dialog.h:
3320 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3321 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3323 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3325 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3326 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3327 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3329 * src/modest-defs.h:
3330 * src/maemo/modest-account-settings-dialog.c:
3331 (create_page_incoming), (on_combo_outgoing_security_changed),
3332 (on_combo_incoming_security_changed), (create_page_outgoing),
3333 (modest_account_settings_dialog_set_account_name),
3334 (save_configuration): Load/Save the port number, and change it when the
3335 security combo changes, to suitable defaults.
3337 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3339 * src/modest-account-mgr.c:
3340 (modest_account_mgr_add_server_account): Set the security and secure-auth
3341 options, and add a comment saying that the other camel-specific options should be
3344 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3346 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3348 * src/modest-tny-account-store.c: (account_list_free),
3349 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3350 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3353 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3355 * src/modest-protocol-info.c:
3356 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3357 is required by our UI spec. Maybe something in our implementation will use this eventually.
3358 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3359 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3360 instead of the previous 0 placeholder.
3362 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3363 secure-auth settings.
3364 * src/modest-account-mgr-helpers.h:
3365 * src/modest-account-mgr-helpers.c:
3366 (modest_server_account_data_get_option_secure_auth),
3367 (modest_server_account_set_option_secure_auth),
3368 (modest_server_account_data_get_option_security),
3369 (modest_server_account_set_option_security): Added this API for getting and setting the security
3370 and secure-auth settings.
3372 * src/maemo/modest-account-settings-dialog.h:
3373 * src/maemo/modest-account-settings-dialog.c:
3374 (modest_account_settings_dialog_finalize), (check_data),
3375 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3376 about changing titles.
3377 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3378 (save_configuration): Save the security and secure-auth settings.
3380 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3381 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3383 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3385 * src/modest-defs.h:
3386 * src/modest-account-mgr.c:
3387 (modest_account_mgr_add_server_account):
3388 Added and used defines for the options key and value pair strings,
3389 that are used so far, though they do not seem to correspond to anything in our
3390 UI specs or ModestProtocol enum.
3392 * src/modest-account-mgr-helpers.h:
3393 * src/modest-account-mgr-helpers.c:
3394 (compare_option_strings_for_name),
3395 (modest_server_account_data_get_option_value),
3396 (modest_server_account_data_get_option_bool),
3397 (modest_account_mgr_get_server_account_option):
3398 Added helper functions for parsing the options GSList.
3400 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3402 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3403 display name is based on the supplied account name.
3404 * src/modest-account-mgr.c:
3405 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3406 with an inefficient, but good-enough, implementation.
3408 * src/maemo/easysetup/modest-easysetup-wizard.c:
3409 (create_page_account_details), (on_before_next), (create_account):
3410 Check for existing display names rather than (non-user-visible) account names, and just
3411 create and set a unique account name at the end.
3413 * src/maemo/modest-account-settings-dialog.c:
3414 (modest_account_settings_dialog_init),
3415 (modest_account_settings_dialog_set_account_name),
3416 (create_page_incoming): Show the display name, instead of the account name.
3417 (on_response): Do some (not all) extra checks, as in the UI spec.
3418 (save_configuration): Save the display name if it was changed.
3420 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3422 * po/en_GB.po: Added needed logical ID and translation.
3423 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3424 (init_view): Made the is-default column clicking work.
3426 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3429 * src/maemo/easysetup/Makefile.am:
3430 * src/maemo/easysetup/modest-easysetup-wizard.c:
3431 (modest_easysetup_wizard_dialog_init):
3432 * src/maemo/easysetup/provider-data-test.keyfile:
3433 * src/maemo/easysetup/provider-data.keyfile:
3434 Moved the provider data file to the new modest-providers-data package and used it from there.
3436 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3438 * src/modest-local-folder-info.c:
3439 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3440 N_() was already used on the static strings, but this just marks it for translation without
3441 using the translation.
3443 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3445 * src/maemo/modest-account-settings-dialog.c:
3446 (create_page_incoming),
3447 (modest_account_settings_dialog_set_account_name):
3448 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3449 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3450 I will do this if nobody else gets there first.
3452 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3454 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3455 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3456 save the security stuff.
3458 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3460 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3461 Set the email address and user fullname, which I now see must be
3464 * src/maemo/modest-account-settings-dialog.h:
3465 * src/maemo/modest-account-settings-dialog.c:
3467 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3468 leave-on-server and authentication.
3469 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3472 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3475 * src/maemo/modest-account-settings-dialog.c:
3476 * src/maemo/modest-account-settings-dialog.h:
3477 Most (but not all) of the widgets are now present as specified by the UI spec.
3478 No changes are yet saved, and some details are not properly shown yet.
3480 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3482 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3484 * src/maemo/Makefile.am:
3485 * src/maemo/modest-account-settings-dialog.c:
3486 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3487 an existing account. Doesn't do much yet.
3489 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3490 Open the accounts settings dialog when Edit is clicked.
3492 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3494 * src/maemo/easysetup/Makefile.am:
3495 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3497 * src/maemo/easysetup/modest-easysetup-wizard.c:
3498 (modest_easysetup_wizard_dialog_init):
3499 Try to get the source directory from the build system,
3500 instead of hard-coding "./" into the source code, when opening our local
3501 copies of the configuration files.
3502 But this still fails when opening the wizard from the Accounts window,
3503 maybe because the working directory seems to change at runtime.
3504 So the wizard will fail the second time unless you copy the files into their
3505 proper locations - see the stdout warnings for the paths.
3507 (create_page_account_details),(on_before_next):
3508 Check for existing non-server accounts instead of server accounts,
3509 so the default account name is useful again, and to prevent trying to
3512 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3513 Show the wizard when New is clicked.
3515 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3516 (init_view): Show the column headers, and show the columns that are
3517 specified in the UI specs. However, something in Maemo's GTK+ prevents
3518 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3519 change the default account. This is despite unsetting the special properties.
3521 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3523 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3524 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3525 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3526 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3527 to make that clearer.
3528 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3530 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3532 * src/maemo/modest-account-view-window.c:
3533 (modest_account_view_window_init),
3534 (modest_account_view_window_new):
3535 Use the same buttons as specified in the
3536 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3537 the existing widgets, which never had a chance of working.
3538 Put the ModestAccountView treeview in a scrolled window.
3539 Do not repeat the initialization in both _init() and _new().
3541 * src/widgets/modest-account-view.c: (update_account_view):
3542 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3543 this widget and window shows no accounts.
3545 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3547 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3549 * src/maemo/easysetup/modest-easysetup-wizard.c:
3550 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3551 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3552 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3555 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3556 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3557 accounts exist yet, as in the UI spec.
3559 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3561 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3563 * src/maemo/Makefile.am:
3564 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3565 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3566 New window for editing connection-specific smtp details.
3567 Not fully implemented.
3569 * src/maemo/modest-connection-specific-smtp-window.c:
3570 (modest_connection_specific_smtp_window_finalize) :
3571 unref the tree model.
3572 (on_button_edit): Show the edit window.
3574 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3576 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3579 * src/maemo/Makefile.am:
3580 * src/maemo/modest-connection-specific-smtp-window.c:
3581 * src/maemo/modest-connection-specific-smtp-window.h:
3582 New window for showing the list of connections, for connection-specific
3583 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3584 * src/maemo/easysetup/modest-easysetup-wizard.c:
3585 (create_page_custom_outgoing): Show the new window when the button is clicked.
3587 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3589 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3590 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3591 * src/maemo/modest-msg-edit-window.c:
3592 (modest_msg_edit_window_insert_image):
3593 * src/modest-conf.c: (modest_conf_key_escape):
3594 * src/modest-mail-operation.c:
3595 (modest_mail_operation_send_new_mail):
3596 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3597 (modest_ui_actions_on_new_account):
3598 * src/widgets/modest-attachment-view.c: (update_filename_request):
3599 * src/widgets/modest-mail-header-view.c:
3600 Corrected warnings that were breaking the build, by commenting out unused variables,
3601 and a function, and by including a header.
3603 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3605 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3606 so we can #ifdef around platform-specific code when necessary.
3607 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3608 to allow this to build for the GNOME platform too.
3610 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3612 * src/maemo/easysetup/modest-easysetup-wizard.c:
3613 Added util_increment_name() and used it in create_page_account_details()
3614 to make sure that the default account name is always a new name.
3616 (modest_easysetup_wizard_dialog_init),
3617 (set_default_custom_servernames): Some minor memory management fixes.
3619 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3623 * src/modest-runtime.c: (init_i18n): Restored the translation
3624 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3625 are defined in config.h, and the translations are installed.
3627 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3628 is defined for translation.
3630 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3632 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3634 * src/maemo/easysetup/modest-easysetup-wizard.c:
3635 (modest_easysetup_wizard_dialog_init):
3636 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3637 Use realistic paths (though they should use $prefix generically) to the
3638 mcc_mapping and provider-data.keyfile files which might work when they
3639 are installed by the future version of the operator-wizard package,
3640 and then fallback to paths in our source code, with an explanatory
3643 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3647 * src/maemo/Makefile.am:
3648 * src/maemo/easysetup/: Added files from the previously-exernal
3649 osso-modest-easysetup.
3650 * src/maemo/modest-main-window-ui.h:
3651 * src/modest-ui-actions.c:
3652 * src/modest-ui-actions.h:
3653 Added modest_ui_actions_on_new_account() as a signal handler for the
3654 New Account menu item. It shows the easysetup wizard.
3655 * po/en_GB.po: Added additional needed logical IDs and translations.