1 2007-08-01 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-msg-view-window.c:
4 (modest_msg_view_window_get_header),
5 (modest_msg_view_window_last_message_selected):
6 Added comments to explain the use of priv->header_model.
7 * src/modest-ui-dimming-rules.c:
8 (modest_ui_dimming_rules_on_open_msg),
9 (modest_ui_dimming_rules_on_mark_as_read_msg),
10 (modest_ui_dimming_rules_on_mark_as_unread_msg),
11 (modest_ui_dimming_rules_on_remove_attachments),
12 (_invalid_attach_selected), (_selected_msg_marked_as):
13 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
14 and changed the parameter to a ModestMainWindow to make it clearer that
15 it never uses any other kind of window.
16 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
17 instead of the selected message.
18 I notice that much of the dimming code and the ModestMsgViewWindow code
19 hard-codes the assumption that the viewed message is always selected in
20 the header view. This does not seem wise or simple.
22 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
23 examine the actual message instead of whatever might be selected
24 in the header view. This stops the delete toolbar button and menu item
25 from being dimmed when opening a message view the search UI,
26 partially fixing projects.maemo.org bug NB#63811.
28 However, when actually deleting, I now get this warning:
29 "tny_header_set_flags: This is a header instance for a new message.
30 Only priority and attachment flags are supported"
32 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
34 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
36 Show account wizard if no accounts are defined while sending
37 (automatic sending after the account wizard finished does not
38 work because it takes some time until the account manager
39 synchronizes everything. (projects.maemo.org NB#62792)
41 2007-07-30 Murray Cumming <murrayc@murrayc.com>
43 * src/modest-tny-account-store.c: (on_account_removed),
44 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
45 account is removed from the View menu. We have TnyAccountStore
46 and ModestTnyAccountStore signals that seem very similar, but this
47 seems to work for now.
49 * src/maemo/modest-main-window.c:
50 (on_show_account_action_activated): Prevent dereference
51 of a NULL if the accoutn does not really exist, though that
52 should not happen anymore.
54 This fixes projects.maemo.org bug NB#64606.
56 2007-07-30 Murray Cumming <murrayc@murrayc.com>
58 * src/modest-ui-actions.c: (run_account_setup_wizard),
59 (modest_ui_actions_on_accounts): Revert a change that set these
60 to modal dialogs, freezing the UI when they show secondary dialogs.
61 This fixed projects.maemo.org bug NB#64519.
63 2007-07-27 Murray Cumming <murrayc@murrayc.com>
65 * src/widgets/modest-header-view-render.c:
66 (_modest_header_view_compact_header_cell_data):
67 Some checks and initialization to try to deal with a crash,
70 2007-07-27 Murray Cumming <murrayc@murrayc.com>
72 * src/maemo/modest-maemo-utils.c:
73 (modest_maemo_utils_get_supported_secure_authentication_methods):
74 Make sure that we have a connection, asking the user for one
76 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
77 Check for a connection before showing the wizard, because
78 the wizard needs a connection to check for server capabilities.
80 2007-07-27 Murray Cumming <murrayc@murrayc.com>
82 * src/maemo/modest-account-view-window.c:
83 (on_new_button_clicked): Remember the wizard dialog instance,
84 so we can just present it again if necessary. This prevents
85 multiple windows from appearing if you click again quickly on the
86 New button before the dialog appears, fixing projects.maemo.org
89 2007-07-27 Murray Cumming <murrayc@murrayc.com>
91 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
92 Offer a connection dialog if there is no connection when
93 starting modest. This should fix projects.maemo.org bug NB#61134.
95 2007-07-27 Murray Cumming <murrayc@murrayc.com>
97 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
98 Reverted my last commit. I was able to fix the build by doing
99 apt-get install wpeditor0 (replacing other wpeditor packages) and
100 an explicit apt-get install wpeditor-dev to upgrade the -dev
103 2007-07-27 Murray Cumming <murrayc@murrayc.com>
105 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
106 Commented out the use of wp_text_buffer_replace_image()
107 because it does not exist, to break the build. Added a TODO for it.
109 2007-07-26 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-tny-account-store.c: (recreate_all_accounts):
112 Recreate them even if they were NULL before. I guess something
113 else was already creating them before, or this would never
115 (modest_tny_account_store_get_server_account): Make sure that
116 the tny accounts have been created before trying to find one.
117 This allows libmodest_dbus_client_compose_mail() to work
118 when the UI is not yet visible.
119 This is probably useful in other cases too.
121 (get_password): When the password is wrong after it is entered
122 in the protected password dialog, show an info banner (in an
123 idle handler) before showing the protected password dialog
126 2007-07-26 Murray Cumming <murrayc@murrayc.com>
128 * src/modest-ui-actions.h:
129 * src/modest-ui-actions.c: Added
130 modest_do_refresh_current_folder() containing some code from
131 modest_ui_actions_on_send_receive().
132 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
133 Call modest_do_refresh_current_folder() before refreshing the
134 requested account, as in modest_ui_actions_on_send_receive().
135 This is strange, but seems to be necessary to show new mails.
136 Now new emails are finally visible in the UI when downloaded
137 via the automatic update interval, fixing bug NB#57458.
138 This also works because bug NB#57458 has been fixed somehow.
140 2007-07-26 Murray Cumming <murrayc@murrayc.com>
142 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
143 printf more details when we get unhandled D-Bus methods, because
146 * src/modest-mail-operation.c: (update_account_thread):
147 Comment out the tny_camel_pop_store_account_reconnect(), because this
148 is apparently no longer needed, and it did not work before anyway.
149 See the comment in the code.
151 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
152 by checking the header flags. This fixes projects.maemo.org bug
155 2007-07-25 Murray Cumming <murrayc@murrayc.com>
157 * src/maemo/modest-maemo-utils.h:
158 * src/maemo/modest-maemo-utils.c: Added
159 modest_maemo_show_information_note_in_main_context_and_forget().
160 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
161 Use the new function to show simple error dialogs in the main
162 context, though question dialogs are still in the current context,
163 which is unfortunately usually not the main context. This should
166 2007-07-25 Murray Cumming <murrayc@murrayc.com>
168 * src/modest-tny-account-store.c: (get_password):
169 Never save the entered username and password in gconf,
170 because the UI spec says we should not. This helps
171 slightly with projects.maemo.org bug NB#63671.
173 2007-07-25 Murray Cumming <murrayc@murrayc.com>
175 * src/widgets/modest-msg-edit-window.h:
176 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
177 Moved some code here to make it simpler.
178 (modest_msg_edit_window_attach_file_one): Renamed from
179 modest_msg_edit_window_attach_file_interactive().
180 (modest_msg_edit_window_offer_attach_file): Renamed from
181 modest_msg_edit_window_attach_file() and used
182 modest_msg_edit_window_attach_file_one() instead of
183 copy/pasting the code. The old code for one was not using
184 GnomeVFS. This allows use of smb:// URLs when using send-as
185 from external applications, fixing bug NB#63741.
187 (modest_msg_edit_window_insert_image),
188 (modest_msg_edit_window_add_attachment_clicked):
189 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
190 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
191 Adapted to the new function names.
193 2007-07-25 Murray Cumming <murrayc@murrayc.com>
195 (modest_platform_set_update_interval): Set the alarm recurrence
196 fields so that auto-update does not just happen the first time.
197 This should have fixed projects.maemo.org bug NB#63938.
199 When this happens you can see a printf when the D-Bus method is
201 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
203 However, I do not actually seem to get new POP messages even when
204 clicking the refresh button manually. A restart gets them.
205 This might be a problem in today's tinymail only.
207 2007-07-24 Murray Cumming <murrayc@murrayc.com>
209 * src/maemo/modest-maemo-global-settings-dialog.c:
210 (current_connection):
211 Avoid a crash (probably only in scratchbox) when strcmp()ing a
212 NULL when closing the dialog.
214 2007-07-24 Murray Cumming <murrayc@murrayc.com>
216 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
217 Remove the hacky send/receive that didn't work, and instead
218 refilter the treemodel to make the deleted email really vanish from
219 the UI (though the delete-from-menu code does has commented out
220 the code that does that). This fixes projects.maemo.org bug
223 2007-07-24 Murray Cumming <murrayc@murrayc.com>
225 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
226 Try a couple of tricks to force the treeview to update (
227 poke the folder, and do a send/receive refresh), but the deleted
228 email still appears with a strike-through instead of really being
231 2007-07-23 Murray Cumming <murrayc@murrayc.com>
233 * src/dbus_api/modest-dbus-callbacks.c:
234 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
235 because their ID is not human-readable (see the comment about
236 improvements needed to the osso-email-interface API) and
237 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
239 2007-07-23 Murray Cumming <murrayc@murrayc.com>
241 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
242 (add_folders_to_list), (on_dbus_method_get_folders),
243 (modest_dbus_req_filter):
244 * src/maemo/modest-maemo-utils.c:
245 (on_camel_account_get_supported_secure_authentication):
246 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
247 (on_header_view_focus_in):
248 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
249 * src/modest-formatter.c: (modest_formatter_create_body_part):
250 * src/modest-mail-operation.c: (recurse_folders),
251 (update_account_thread), (get_msgs_full_thread),
252 (modest_mail_operation_get_msgs_full),
253 (modest_mail_operation_xfer_msgs):
254 * src/modest-search.c: (search_mime_part_and_child_parts),
255 (modest_search_account), (modest_search_all_accounts):
256 * src/modest-tny-account.c:
257 (modest_tny_account_get_special_folder), (recurse_folders):
258 * src/modest-tny-local-folders-account.c:
259 (modest_tny_local_folders_account_query_passes):
260 * src/modest-tny-msg.c: (copy_mime_part),
261 (modest_tny_msg_find_body_part_from_mime_part):
262 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
263 (modest_tny_send_queue_try_to_send):
264 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
265 (_modest_ui_actions_open), (download_uncached_messages),
266 (reply_forward), (modest_ui_actions_on_copy),
267 (modest_ui_actions_on_details), (has_retrieved_msgs),
268 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
270 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
271 (_selected_msg_marked_as), (_msg_download_completed),
272 (_selected_msg_sent_in_progress):
273 * src/widgets/modest-attachments-view.c:
274 (modest_attachments_view_set_message):
275 * src/widgets/modest-msg-view.c: (find_cid_image):
276 * tests/check_folder-transfer.c: (find_folders):
277 * tests/check_update-account.c: (func):
278 * tests/dbus_api/test_get_folders.c: (main):
279 Checked all uses of tny_iterator_get_current(), making sure
280 that the object is unreferenced (3 or 4 places did not),
281 and adding checks for NULL.
283 2007-07-23 Murray Cumming <murrayc@murrayc.com>
285 * src/dbus_api/modest-dbus-callbacks.c:
286 (on_idle_open_default_inbox): Make sure that the application UI is
288 * src/maemo/easysetup/modest-easysetup-wizard.c:
289 (on_entry_invalid_character): Show the word whitespace instead
290 of (null) in the banner when whitespace was entered.
291 (show_error): Add a comment that this does not work in
292 Maemo Bora, though we do not know why.
294 2007-07-23 Murray Cumming <murrayc@murrayc.com>
296 * src/modest-tny-account.c:
297 (modest_tny_account_get_special_folder): Use an if instead of
298 an assert for when the parent account name is NULL, because this
299 might be causing a crash in projects.maemo.org bug 63192.
300 * src/modest-mail-operation.c:
301 (modest_mail_operation_send_new_mail_cb),
302 (modest_mail_operation_remove_folder): unref the folder that is
303 returned from modest_tny_account_get_special_folder().
305 2007-07-23 Murray Cumming <murrayc@murrayc.com>
307 * src/modest-ui-actions.c:
308 (modest_ui_actions_on_password_requested):
309 Show mail_ib_login_cancelled info banner when the user cancels
310 the protected password dialog, to fix projects.maemo.org
313 2007-07-23 Murray Cumming <murrayc@murrayc.com>
315 * src/maemo/modest-account-settings-dialog.c:
316 (create_page_outgoing): Put this page in a GtkScrolledWindow,
317 matching the UI mock-up in the UI spec, and allowing access
318 to all widgets even when the on-screen keyboard is active.
320 2007-07-23 Murray Cumming <murrayc@murrayc.com>
322 Reverted this previous commit from Johannes,
323 because the scrollbars are always visible and because
324 I think we only need it on onepage of the account
325 settings, not the account wizard.
326 (I wrote the wrong instructions in the bug.)
328 * src/maemo/easysetup/modest-easysetup-wizard.c:
329 Added scrollbars to account wizard dialog.
330 Fixed projects.maemo.org NB #62744
332 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
334 * src/maemo/easysetup/modest-easysetup-wizard.c:
335 (create_page_user_details):
336 Use auto-cap for name (projects.maemo.org NB#63716)
337 * src/widgets/modest-account-view.c: (on_account_busy_changed):
339 2007-07-22 Armin Burgmeier <armin@openismus.com>
341 * src/maemo/modest-ui-actions.c: Use current account instead of
342 default account for creating viewer windows, so that the viewer
343 window knows to which account the viewed message belongs.
345 * src/maemo/modest-msg-view-window.c: Destroy the window when the
346 corresponding account is deleted. This fixes projects.maemo.org bug
349 2007-07-18 Armin Burgmeier <armin@openismus.com>
351 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
352 the dialog close after entering an invalid port number and clicking
353 OK. This fixes projects.maemo.org bug NB#63602.
355 2007-07-18 Armin Burgmeier <armin@openismus.com>
357 * src/modest-tny-account-store.c:
358 (get_server_accounts): Set parent modest account name for each
359 connection-specific transport account so that special folders of such
360 an account can be looked up. This fixes a crash when changing account
361 settings. This might also be related to projects.maemo.org bug
364 2007-07-16 Armin Burgmeier <armin@openismus.com>
366 * src/modest-ui-actions.c: Added a button to create a folder to the
367 move-to dialog. This fixes projects.maemo.org bug NB#.
369 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
371 * src/maemo/easysetup/modest-easysetup-wizard.c:
372 Added scrollbars to account wizard dialog.
373 Fixed projects.maemo.org NB #62744
375 2007-07-16 Murray Cumming <murrayc@murrayc.com>
377 * src/widgets/modest-msg-view.h:
378 * src/widgets/modest-msg-view.c:
379 Added modest_msg_view_get_message_is_empty() but this needs
381 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
382 Check if there is any text in the message yet.
383 But this needs to be implemented properly.
384 (modest_msg_edit_window_toggle_find_toolbar):
385 * src/maemo/modest-msg-view-window.c:
386 (modest_msg_view_window_toggle_find_toolbar):
387 Show a banner warning if there is no text to search, when
388 trying to start a search. This partially fixes
389 projects.maemo.org bug NB#62350.
391 2007-07-13 Murray Cumming <murrayc@murrayc.com>
393 * src/modest-mail-operation.c: (update_account_thread):
394 Initialized num_new_headers to fix the build.
396 2007-07-13 Murray Cumming <murrayc@murrayc.com>
398 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
399 Ignore modest accounts whose server accounts don't exist in gconf.
400 This prevents us trying to create TnyAccount instances for those
401 server accounts when the server account has been removed from gconf,
402 but the parent modest account has not yet been removed from modest.
403 I don't know why this is only noticeable now. It was probably just
404 a harmeless g_warning() anyway.
406 2007-07-13 Murray Cumming <murrayc@murrayc.com>
408 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
409 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
411 2007-07-12 Armin Burgmeier <armin@openismus.com>
413 * src/maemo/modest-main-window.c: Make default account appear bold
414 in view, tools/send & receive and toolbar/send & receive SCM menus.
415 This fixes projects.maemo.org bug NB#59010.
417 2007-07-12 Murray Cumming <murrayc@murrayc.com>
419 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
420 Add a short-cut, by checking if the folder store is an account.
421 This ensures that the Sort menu item and toolbar is dimmed for
422 the local-folders account root item, fixing
423 projects.maemo.org bug NB#62545.
425 2007-07-12 Murray Cumming <murrayc@murrayc.com>
427 * src/modest-tny-account-store.c: (get_password):
428 Show the password dialog (via the signal) only in the mainloop, via
429 an idle handler that we wait for. This could theoretically prevent
430 hangs, though I worry that it could introduce some too.
432 2007-07-12 Murray Cumming <murrayc@murrayc.com>
434 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
435 * src/maemo/modest-platform.c:
436 (modest_platform_connect_and_wait):
437 Take a TnyAccount* parameter and try to set it to online
438 (a TnyCamel-only API), because tinymail sets accounts to offline
439 when the user cancels a password dialog, and doesn't ask again until
440 it has been set to online.
441 However, this is commented out because it causes a hang now.
443 (modest_platform_connect_and_wait_if_network_account):
444 * src/modest-mail-operation.c:
445 (modest_mail_operation_update_account):
446 * src/modest-platform.h:
447 * src/modest-ui-actions.c: (_modest_ui_actions_open),
448 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
450 2007-07-12 Armin Burgmeier <armin@openismus.com>
452 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
454 * src/modest-mail-operation.c:
455 * src/modest-ui-actions.c: Check for already existing folder before
456 querying the server, show error message from camel if the request
457 still fails. This fixes projects.maemo.org bug NB#58701.
459 2007-07-12 Murray Cumming <murrayc@murrayc.com>
461 * src/modest-tny-account-store.h:
462 * src/modest-tny-account-store.c:
463 Added modest_tny_account_store_forget_password_in_memory(),
464 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
465 when creating a new account, so that new passwords will be used, instead of
466 us thinking that it's a second request as a result of a failed password again.
468 2007-07-12 Murray Cumming <murrayc@murrayc.com>
470 * src/dbus_api/modest-dbus-callbacks.c:
471 (on_idle_open_message): If the message is in drafts then open it
472 in an edit window instead of a view window. This fixes
473 projects.maemo.org bug NB#63005.
475 2007-07-12 Murray Cumming <murrayc@murrayc.com>
477 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
478 Avoided a harmless g_warning().
480 2007-07-12 Murray Cumming <murrayc@murrayc.com>
482 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
483 Pass the modest account name, not the TnyAccount display name to
484 modest_msg_view_window_new() so that the reply feature works,
485 fixing projects.maemo.org bug NB#62892.
487 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
488 (modest_msg_view_window_new_with_header_model):
489 * src/maemo/modest-msg-view-window.c:
490 (modest_msg_view_window_new_with_header_model),
491 (modest_msg_view_window_new):
492 * src/modest-ui-actions.c: (reply_forward):
493 * src/widgets/modest-msg-view-window.h:
494 * src/widgets/modest-window.c: (modest_window_set_active_account):
495 Rename an account parameter to modest_account_name to make this clearer.
497 2007-07-11 Murray Cumming <murrayc@murrayc.com>
499 * src/modest-ui-actions.h:
500 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
501 modest_do_message_delete().
502 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
503 Call modest_do_message_delete(), hoping that this would cause messages
504 to be really deleted from search instead of just marked with strike through.
505 Does not seem to help.
507 2007-07-11 Armin Burgmeier <armin@openismus.com>
509 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
510 priv->reselect to FALSE prior to calling
511 modest_folder_view_select_first_inbox_or_local() to prevent endless
512 recursion and thus a crash on startup.
514 2007-07-11 Armin Burgmeier <armin@openismus.com>
516 * src/maemo/modest-account-settings-dialog.h: Include
517 <gtk/gtknotebook.h> to fix the build (at least for me).
519 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
520 Use "New FolderN" as default suggested name if "New folder" already
521 exists, with N being the first free number, though never exceed "New
522 folder99" in which case we just fall back to "New Folder" even though
523 it already exists. This fixes projects.maemo.org bug NB#58663.
525 2007-07-11 Murray Cumming <murrayc@murrayc.com>
527 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
528 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
529 projects.maemo.org bug NB#62778.
531 2007-07-11 Murray Cumming <murrayc@murrayc.com>
533 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
534 Ignore the wrong (for now) secure-smtp setting in the presets -
535 just default to requiring secure authentication for SMTP, because
538 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
540 * src/widgets/modest-folder-view.c: (filter_row)
541 Do not show drafts folder (see UI specs)
543 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
545 * src/modest-ui-actions.c:
546 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
547 place and also not necessary.
549 * src/widgets/modest-folder-view.c: (filter_row)
550 Guess folder type and hide Sent & Outbox if necessary.
551 Fixed project.maemo.org NB#57328
553 2007-07-11 Murray Cumming <murrayc@murrayc.com>
555 * src/modest-ui-actions.h:
556 * src/modest-ui-actions.c:
557 (modest_ui_actions_on_delete_message):
558 Move some code into a new
559 modest_ui_actions_refresh_message_window_after_delete()
560 function so we can use it from elsewhere.
562 * src/dbus_api/modest-dbus-callbacks.c:
563 (on_idle_delete_message), (on_delete_message): Used an idle
564 handler, as we do for the other D-Bus method handlers.
565 Call modest_ui_actions_refresh_message_window_after_delete()
566 if the deleted message was open in a window. This fixed
567 projects.maemo.org bug NB#62862.
569 2007-07-11 Murray Cumming <murrayc@murrayc.com>
571 * src/modest-main.c: (main): Only show the UI at the start if
572 the showui command line option was given. For instance,
573 run-standalone src/modest showui
574 Otherwise, we wait for the top_application D-Bus method to
575 be sent by hildon-desktop when the application is selected
577 This allows us to run without a UI when osso-global-search
578 uses our D-Bus methods.
580 2007-07-11 Murray Cumming <murrayc@murrayc.com>
582 * src/dbus_api/modest-dbus-api.h: Added a define for a
583 top-application D-Bus method.
584 * src/dbus_api/modest-dbus-callbacks.c:
585 (on_top_application),
586 (modest_dbus_req_handler): Handle the top-application D-Bus
587 method, which might be an undocumented D-Bus signal sent by
588 hildon-desktop when it starts the application from the menu.
589 But I am not sure and I need to test it on the device, because
590 my scratchbox does not have the application in the menu now.
591 This method shows the main window, so that it can be invisible
592 when started, for instance, just for email searching from
595 * src/maemo/modest-main-window.c: (restore_settings),
596 (modest_main_window_new): Do not show the window immediately
597 upon creation. We show it later.
598 * src/modest-widget-memory.c: (save_settings_paned):
599 Try (unsuccessfully) to avoid saving the paned position when
600 it is not even visible.
601 (restore_settings_paned): Do not allow a silly paned position.
602 This seems necessary when not showing the window at first.
604 * tests/dbus_api/Makefile.am:
605 * tests/dbus_api/test_top_application.c: (main): Test for the
608 2007-07-10 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-ui-dimming-rules.c:
611 (modest_ui_dimming_rules_on_new_msg),
612 (modest_ui_dimming_rules_on_reply_msg),
613 (modest_ui_dimming_rules_on_delete_msg),
614 (modest_ui_dimming_rules_on_details),
615 (modest_ui_dimming_rules_on_view_window_move_to),
616 (modest_ui_dimming_rules_on_view_previous),
617 (modest_ui_dimming_rules_on_view_next),
618 (_invalid_folder_for_purge): Added checks before
619 casting the window. This looks like an actual
620 logic error in _invalid_folder_for_purge(), because it
621 tries to use a ModestMainWindow as a message window.
623 2007-07-10 Murray Cumming <murrayc@murrayc.com>
625 * src/maemo/modest-account-settings-dialog.c:
626 (show_error): Use the same implementation as in
627 modest-easysetup-wizard.c:
628 (on_entry_invalid_character): The logical ID contains a %s.
629 Guessed what it should be.
630 (on_entry_max), (check_data), (on_response): Adapt to
631 changed show_error().
632 (create_page_account_details): Really call
633 modest_validating_entry_set_func() on the correct widgets.
634 * src/maemo/easysetup/modest-easysetup-wizard.c:
635 (on_entry_invalid_character): Fix the logical ID here too.
636 (create_page_account_details),
637 (create_page_user_details):
639 modest_validating_entry_set_func() on the correct widgets.
641 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
642 Do not try to use the account if it is NULL.
644 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
646 * src/modest-ui-actions.c: (create_move_to_dialog),
647 (modest_ui_actions_on_main_window_move_to),
648 (modest_ui_actions_on_msg_view_window_move_to):
649 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
650 (filter_row), (modest_folder_view_show_non_move_folders):
651 * src/widgets/modest-folder-view.h:
653 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
654 the Sent folder yet as it does not report the correct folder type.
656 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
658 * src/maemo/modest-msg-edit-window.c: (init_window):
661 2007-07-10 Murray Cumming <murrayc@murrayc.com>
663 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
664 Take a parent widget instead of a parent window, and
665 implement this with hildon_banner_show_information() instead.
666 Non-Maemo builds can just ifdef that there.
667 This fixed projects.maemo.org bug NB#62766.
669 (on_entry_invalid_character): Use show_error() again instead
670 of using hildon directly, and use the _CS() macro to use the correct
672 (create_account), (check_for_supported_auth_methods), (on_entry_max):
673 Pass a widget instead od a window to show_error().
675 2007-07-10 Murray Cumming <murrayc@murrayc.com>
677 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
678 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
679 This allows us to show the server name in the error message, fixing
680 projects.maemo.org bug NB#62904.
681 Also, use the appropriate logical ID message for the account protocol.
683 2007-07-10 Murray Cumming <murrayc@murrayc.com>
685 * src/modest-tny-account-store.c: (on_idle_wrong_password):
686 A compilation fix, though the build wasn't broken for me.
688 2007-07-09 Murray Cumming <murrayc@murrayc.com>
690 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
691 Do not try to unref a NULL folder store, to avoid a runtime warning.
692 This seems to happen sometimes when changing accounts settings.
694 2007-07-09 Murray Cumming <murrayc@murrayc.com>
696 * src/modest-tny-account-store.c:
697 (modest_tny_account_store_instance_init),
698 (modest_tny_account_store_finalize),
699 (on_account_settings_hide), (on_idle_wrong_password):
700 Use a GHashTable to ensure that we only show one account settings
701 dialog per modest account. This avoids us having a dialog open for
702 both the store and transport accounts, or due to repeated get_password()
703 calls that shouldn't happen anyway.
705 2007-07-09 Murray Cumming <murrayc@murrayc.com>
707 * src/maemo/modest-maemo-utils.c: (on_hide),
708 (modest_maemo_show_dialog_and_forget): Handle the response, because
709 the window is not even hidden by default.
711 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
712 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
713 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
714 which seems to prevent some modality problems.
716 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
717 Ignore user cancellation errors.
719 * src/modest-account-mgr-helpers.h:
720 * src/modest-account-mgr-helpers.c:
721 Added modest_server_account_get_password() and
722 modest_server_account_get_has_password() to avoid direct use of
725 * src/maemo/modest-account-settings-dialog.h:
726 * src/maemo/modest-account-settings-dialog.c:
727 (modest_account_settings_dialog_init): Store the notebook so we can
729 Added modest_account_settings_dialog_switch_to_user_info().
731 * src/modest-tny-account-store.c:
732 (get_password): When the password in the account settings is wrong (we think),
733 show the relevant page of the account settings dialog, in the mainloop.
734 However, we currently get many of these at once because cancel does not
736 (forget_password): Do not forget the password
737 from the account settings, because this causes side-effects when
738 tinymail seems to call it at strange time, maybe because of how we
739 are cancelling get_password().
740 (modest_tny_account_store_alert): Ignore user cancellations.
742 2007-07-09 Murray Cumming <murrayc@murrayc.com>
744 * src/maemo/modest-maemo-utils.h:
745 * src/maemo/modest-maemo-utils.c:
746 Added modest_maemo_show_information_note_and_forget() for use instead of
747 gtk_dialog_run() when the response is not needed, to avoid an extra
748 mainloop which could cause a hang.
750 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
751 Use the logical IDs for the error message, though they are not
752 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
753 because gtk_dialog_run() caused a hang here (the window did not close).
754 This fixes projects.maemo.org bug NB#62646.
756 2007-07-09 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-account-mgr-helpers.h:
759 * src/modest-account-mgr-helpers.c:
760 Added modest_account_mgr_get_store_protocol().
762 * src/maemo/modest-account-view-window.c:
763 (on_delete_button_clicked): Show different warning text depending on
764 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
765 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
768 2007-07-09 Murray Cumming <murrayc@murrayc.com>
770 * src/maemo/modest-msg-edit-window.c:
771 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
772 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
774 2007-07-07 Armin Burgmeier <armin@openismus.com>
776 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
777 ckdg_ib_maximum_characters_reached from correct package.
779 * src/modest-ui-actions.c: Show an error message when a folder could
780 not be created. Tinymail does not give us specific error codes about
781 what has gone wrong, so we assume that a folder with that name
782 already exists, though there might be other reasons.
784 2007-07-06 Murray Cumming <murrayc@murrayc.com>
786 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
787 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
788 give a more exact error message that can be partly translated.
790 2007-07-05 Murray Cumming <murrayc@murrayc.com>
792 * src/maemo/modest-address-book.c:
793 (select_email_addrs_for_contact): Specify a default window size for the
794 select-email-address dialog, so that it is probably big enough for the
795 title. This should fix projects.maemo.org bug NB#62277.
797 2007-07-05 Murray Cumming <murrayc@murrayc.com>
799 * src/maemo/easysetup/modest-easysetup-wizard.c:
800 (create_page_complete_easysetup): Use
801 gtk_widget_set_size() request to ensure that the text wraps
804 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
806 * src/maemo/easysetup/modest-easysetup-wizard.c:
807 (on_entry_invalid_character), (create_page_account_details),
808 (create_page_user_details):
809 Use new API of ModestValidatingEntry. But for some reason the banner is
810 not shown. I will have to investigate that further.
812 * src/widgets/modest-validating-entry.c: (on_insert_text),
813 (modest_validating_entry_set_func):
814 * src/widgets/modest-validating-entry.h:
815 Added a new callback function to be able to react to prevented
816 characters whitespaces to e.g show a banner.
818 2007-07-05 Armin Burgmeier <armin@openismus.com>
820 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
821 notification of HildonNumberEditor instead of remembering the port
822 number. Thanks to Johannes for pointing this out.
824 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
826 * src/maemo/easysetup/modest-easysetup-wizard.c:
827 Check if there are any user changes before showing a confirmation
828 dialog (projects.maemo.org NB#60946)
830 2007-07-05 Armin Burgmeier <armin@openismus.com>
832 * src/maemo/modest-account-settings-dialog.c: Remember custom port
833 number at the beginning of the dialog and set the modified flag at the
834 end if the port number has changed. This is necessary because
835 HildonNumberEditor does not support notification when the value has
838 2007-07-05 Murray Cumming <murrayc@murrayc.com>
840 * src/modest-ui-actions.c:
841 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
842 a connection before asking anything else. Correct the check for the destination
843 folder so that it succeeds when online.
844 This fixed projects.maemo.org bug NB#61645.
846 2007-07-05 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
849 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
850 to fix projects.maemo.org bug NB#62439.
852 2007-07-05 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-tny-account.c: (on_connection_status_changed):
855 Really do not use tny_device_force_offline() here. See the previous comment.
857 2007-07-04 Murray Cumming <murrayc@murrayc.com>
859 * src/modest-tny-account.c: (on_connection_status_changed):
860 Do not use tny_device_force_offline() when tinymail says that something
861 went wrong with the connection. It seems to report this unnecessarily.
863 2007-07-04 Murray Cumming <murrayc@murrayc.com>
865 * src/maemo/modest-connection-specific-smtp-window.c:
866 (modest_connection_specific_smtp_window_init):
867 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
868 does not seem to have any effect in osso 1.1 (though it works in
869 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
871 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
873 * src/maemo/modest-connection-specific-smtp-window.c:
874 Fix UI specification problems with projects.meamo.org NB#60479
876 2007-07-04 Murray Cumming <murrayc@murrayc.com>
878 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
879 clue when this has failed, because the error dialog is not always shown
880 (at least in earlier version).
882 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
883 GError message, because the generic error dialog is not helpful.
885 'This message is not currently available (can't let a new connection go online)'
886 when trying to open an IMAP message.
888 (_modest_ui_actions_open): Offer a connection when some messages would
889 have to be downloaded and we are offline.
891 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
893 * src/widgets/modest-folder-view.c:
894 Don't check for MERGE type anymore as we use the correct type
896 NOTE: For the last two changes you need to update your tinymail copy
897 because of API changes!
899 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
901 * src/modest-tny-local-folders-account.c:
902 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
903 (see projects.maemo.org NB#61580)
905 2007-07-04 Murray Cumming <murrayc@murrayc.com>
907 * src/modest-tny-account.c: (on_connection_status_changed):
908 Commented out the call to modest_platform_connect_and_wait() because this
909 seems to always hang, and I would like to know if this is the only thing
910 that causes a hang when showing the connection dialog.
911 It is not very useful anyway.
913 2007-07-04 Murray Cumming <murrayc@murrayc.com>
915 * src/maemo/modest-msg-view-window.c:
916 (modest_msg_view_window_select_next_message):
918 * src/modest-platform.h:
919 * src/maemo/modest-platform.c:
920 Added modest_platform_connect_and_wait(), which calls
921 tny_maemo_conic_device_connect() always in the main thread, by calling it
922 in an idle handler and waiting for the idle handler to run. It should be
923 in the main thread because it uses GTK+ UI code. It just returns TRUE
924 if the device is already online.
926 There is some nasty code to ensure that subsequent calls to
927 modest_platform_connect_and_wait() just wait for the first one to finish,
928 by checking repeatedly in another idle handler. This is necessary,
929 because other threads (or even the main thread, via another idle handler)
930 can call modest_platform_connect_and_wait() while
931 modest_platform_connect_and_wait() is running.
933 (modest_platform_connect_and_wait_if_network_account),
934 (modest_platform_connect_and_wait_if_network_folderstore):
935 Convenience functions that calls modest_platform_connect_and_wait() if
936 the account or folder might want network access.
938 * src/modest-mail-operation.c:
939 (modest_mail_operation_update_account):
940 * src/modest-ui-actions.c: (download_uncached_messages),
941 (modest_ui_actions_on_rename_folder), (delete_folder),
942 (modest_ui_actions_on_main_window_move_to),
943 (modest_ui_actions_on_msg_view_window_move_to):
944 * src/widgets/modest-folder-view.c:
945 (drag_and_drop_from_folder_view):
946 Offer a connection if we are offline.
948 * src/modest-tny-account.c: (on_connection_status_changed):
949 Document this as only handling errors during network operations in progress,
950 and replace the idle code with a simple call to
951 modest_platform_connect_and_wait(), which does this instead.
953 2007-07-03 Murray Cumming <murrayc@murrayc.com>
955 * src/modest-tny-account.c:
956 (modest_tny_account_get_special_folder): (util_on_idle),
957 Handle the GError so we can see when tny_folder_store_get_folders()
958 fails, as it currently does while something else is connecting.
960 Added util_run_in_main_thread_and_wait()
961 which uses an idlen handler and mainloop to ensure that the function
962 is called in the main thread.
963 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
964 to make sure that we call attempt the connection in the mainloop only,
965 which might solve some hangs.
967 2007-07-03 Murray Cumming <murrayc@murrayc.com>
969 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
970 be found by their display name. This is never useful.
971 * src/modest-tny-account-store.c: (on_account_removed): Find the account
972 by its ID, instead of trying to use its ID as its display name.
974 * src/modest-tny-account-store.h:
975 * src/modest-tny-account.c:
976 (modest_tny_account_get_special_folder): Add a g_warning() when
977 tny_folder_store_get_folders() returns an empty list for the maildir.
979 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
980 Add a g_warning() when this returns NULL, because that it not allowed
983 2007-07-02 Armin Burgmeier <armin@openismus.com>
985 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
986 note when trying to cancel the wizard. This fixes projects.maemo.org
989 2007-07-02 Murray Cumming <murrayc@murrayc.com>
991 * src/modest-tny-account.h:
992 * src/modest-tny-account.c:
993 (modest_tny_account_new_from_server_account),
994 (modest_tny_account_new_from_server_account_name),
995 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
996 because this must now be set before setting the proto. This is usd in
997 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
998 warning in camel_session_get_service() caused by
999 tny_camel_transport_account_prepare().
1001 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1004 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1006 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1008 (modest_connection_specific_smtp_edit_window_init):
1010 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1011 of "changed" for now
1013 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1015 * src/modest-tny-account.c:
1016 (modest_tny_account_new_from_server_account):
1017 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1018 now uses to request a connection when it needs one, and which it uses
1019 to tell us that something is wrong with the connection, so we can force
1020 the accounts offline to prevent further problems.
1022 * src/modest-defs.h:
1023 * src/modest-init.c: (init_default_settings):
1024 * src/modest-mail-operation.c:
1025 (modest_mail_operation_update_account):
1026 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1027 This should not be necessary anymore. Do not set the conf key that
1028 determined this (it was always TRUE and not set anywhere else).
1030 * src/modest-ui-actions.h: Remove unused and unimplemented
1031 modest_ui_actions_on_online_toggle_toggled().
1033 2007-06-29 Murray Cumming <murrayc@murrayc.com
1035 * src/maemo/modest-main-window.c: (connect_signals):
1036 Don't connect to delete_event twice. Maybe this was harmless.
1038 2007-06-29 Murray Cumming <murrayc@murrayc.com
1040 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1041 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1042 Debug output to give some more clue when a folder move is not allowed.
1044 2007-06-28 Murray Cumming <murrayc@murrayc.com
1046 * src/modest-tny-account.c: (on_modest_file_system_info),
1047 (modest_tny_account_get_mmc_account_name):
1048 Always call the callback, without checking whether the name has changed.
1049 * src/widgets/modest-folder-view.c: (strings_are_equal),
1050 (on_model_foreach_set_name), (on_get_mmc_account_name),
1051 (text_cell_data): Compare the name here, and use the name from
1052 the account rather than from the
1053 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1054 if the name was changed after the account was added to the model.
1055 That's a tinymail bug but not one that I want to fix now.
1057 This finally fixes projects.maemo.org bug NB#59301.
1059 2007-06-27 Armin Burgmeier <armin@openismus.com>
1061 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1064 2007-06-27 Murray Cumming <murrayc@murrayc.com
1066 * src/modest-tny-account.h:
1067 * src/modest-tny-account.c:
1068 Added modest_tny_account_get_mmc_account_name(), to set the memory
1069 card name asynchronously for the given account and then notify.
1070 (modest_tny_account_new_for_local_folders): Use this new function instead
1071 of using hildon_file_system_info_async_new() directly.
1073 * src/widgets/modest-folder-view.c: (text_cell_data):
1074 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1075 gtk_tree_model_row_changed() when it is available.
1077 This should fix projects.maemo.org bug NB#59301.
1079 2007-06-27 Murray Cumming <murrayc@murrayc.com
1081 * src/modest-mail-operation.c: (update_account_thread),
1082 (get_msgs_full_thread): Fix typo failures in the revert
1085 2007-06-27 Murray Cumming <murrayc@murrayc.com
1087 * src/maemo/modest-maemo-global-settings-dialog.c:
1088 (idle_select_default_focus):
1089 * src/modest-mail-operation.c: (idle_notify_progress),
1090 (idle_notify_progress_once), (set_last_updated_idle),
1091 (update_account_thread), (get_msgs_full_thread):
1092 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1093 * src/widgets/modest-header-view.c:
1094 (idle_notify_headers_count_changed_destroy),
1095 (idle_notify_headers_count_changed):
1096 Reverted the additions of gdk_threads_enter/leave(), in case this
1097 helps with a startup hang on the device.
1099 2007-06-26 Armin Burgmeier <armin@openismus.com>
1101 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1102 for supported secure authentication methods from server by
1103 gtk_dialog_run(), saving CPU time and a potential race condition.
1105 2007-06-26 Armin Burgmeier <armin@openismus.com>
1107 * src/maemo/modest-maemo-utils.h:
1108 * src/maemo/modest-maemo-utils.c: Added a
1109 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1110 only error code to tell the calling code when the user canceled the
1113 * src/maemo/modest-account-settings-dialog.h:
1114 * src/maemo/modest-account-settings-dialog.c:
1115 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1116 message if the retrieval of secure authentication methods was canceled
1117 by the user. Perform the check before saving anything to configuration
1118 to not end up with half-committed configuration changes, do not show
1119 a "Saving to configuration failed" note when authentication methods
1120 could not be retrieved.
1122 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1125 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1127 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1128 Only return the first level of folders under accounts, because the
1129 osso-global-search UI spec doesn't want the rest.
1130 This fixed projects.maemo.org bug NB#61811.
1132 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1134 * src/modest-tny-account-store.c:
1135 * src/modest-tny-account-store.h:
1136 Added modest_tny_account_is_memory_card_account().
1137 * src/maemo/modest-main-window.c: (create_details_widget):
1138 Show the same information items for the memory card as we show for the
1139 local-folders, to fix projects.maemo.org bug NB#59307.
1141 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1143 * src/modest-tny-account-store.c: (get_password):
1144 Added some checks for NULL to maybe prevent crashes, though I think
1145 it was Philip's last commit that actually prevented the crash here
1146 when creating a first new account.
1147 But the new account is still not usable (no messages are shown)
1148 until a restart of the application.
1150 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1152 * src/maemo/modest-maemo-global-settings-dialog.c:
1153 (idle_select_default_focus):
1154 * src/modest-mail-operation.c: (idle_notify_progress),
1155 (idle_notify_progress_once), (idle_notify_update_account_queue),
1156 (set_last_updated_idle), (update_account_thread),
1157 (notify_get_msgs_full), (get_msgs_full_destroyer),
1158 (get_msgs_full_thread):
1159 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1160 * src/widgets/modest-header-view.c:
1161 (idle_notify_headers_count_changed_destroy),
1162 (idle_notify_headers_count_changed):
1163 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1164 all idle handlers, because some other thread could be blocking
1165 the GDK lock, so that it can do GUI stuff.
1167 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1169 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1170 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1171 (on_idle_send_receive), (on_idle_open_default_inbox):
1172 * src/maemo/modest-msg-edit-window.c:
1173 (modest_msg_edit_window_attach_file_noninteractive):
1174 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1175 to prevent a hang. I don't quite understand why these are necessary,
1176 beause we should already be in the main loop. I guess something outside
1177 of the main loop is taking the lock.
1179 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1180 we are really using URIs, and use files that are more likely to exist.
1182 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1184 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1185 necessary because configure.ac now defines different variables.
1187 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1189 * libmodest-dbus-client/libmodest-dbus-client.c:
1190 * libmodest-dbus-client/libmodest-dbus-client.h:
1191 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1192 libmodest_dbus_client_compose_mail() is what things actually use.
1194 * src/dbus_api/modest-dbus-api.h:
1195 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1196 * tests/dbus_api/Makefile.am:
1197 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1200 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1202 * src/modest-init.c: (modest_init_local_folders):
1203 For memory-card (or other non local-folders) maildir accounts,
1204 always create an Archive folder, so that there is somewhere to put
1205 messages. This should be less confusing, because the user does not need
1206 to guess that the need to create a folder.
1208 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1210 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1211 Fixed icon size by using (50, 50) which is the same as defined by
1214 2007-06-25 Armin Burgmeier <armin@openismus.com>
1216 * src/widgets/modest-window-mgr.c:
1217 * src/modest-init.c:
1218 * configure.ac: Correctly recognize hildon-notify presence and fixed
1219 the build without it being installed.
1221 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1223 * libmodest-dbus-client/libmodest-dbus-client.c:
1224 (libmodest_dbus_client_search): Fix the build. Sorry.
1225 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1226 (reply_forward_cb): Initialize variables to fix the build.
1228 * src/modest-tny-account-store.c:
1229 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1230 comparison (a silly typo) so that email search results can be opened
1231 when there are more than one account.
1233 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1235 * libmodest-dbus-client/libmodest-dbus-client.c:
1236 (libmodest_dbus_client_search),
1237 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1238 instead of 1 second, because the search gets folders and messages from
1239 the server, which can take a long time. When it times out,
1240 osso-global-search will report no results.
1242 We need to specify whether we should search only cached information
1243 (maybe with a user preference), and the osso-email-search-plugin
1244 API should really be improved to allow that option, and to allow results
1245 to be delivered asynchronously in batches.
1247 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1249 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1250 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1251 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1253 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1255 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1256 that is an empty string. D-Bus seems to give us these instead of NULL.
1258 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1260 * src/dbus_api/modest-dbus-callbacks.c:
1261 * src/maemo/easysetup/modest-easysetup-wizard.h:
1262 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1263 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1264 (modest_connection_specific_smtp_edit_window_init):
1265 * src/maemo/modest-maemo-global-settings-dialog.c:
1267 * src/maemo/modest-maemo-utils.c:
1268 (modest_maemo_utils_setup_images_filechooser):
1269 * src/maemo/modest-main-window.c: (create_details_widget):
1270 * src/maemo/modest-msg-edit-window.c:
1271 (modest_msg_edit_window_attach_file_noninteractive),
1272 (modest_msg_edit_window_color_button_change),
1273 (modest_msg_edit_window_set_zoom):
1274 * src/modest-mail-operation.c: (update_account_thread):
1275 * src/modest-tny-account-store.c:
1276 * src/modest-tny-account.c:
1277 * src/widgets/modest-global-settings-dialog.c:
1278 * src/widgets/modest-window.h:
1280 Fixed build on bora!
1282 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1284 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1285 * src/modest-search.c: (modest_search_folder),
1286 (modest_search_all_accounts): Actually search only in the specified folder,
1287 doing a simple match on the folder ID.
1288 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1289 and added some documentation.
1291 2007-06-22 Armin Burgmeier <armin@openismus.com>
1293 * src/maemo/modest-maemo-utils.h:
1294 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1295 modest_maemo_utils_get_supported_secure_authentication_methods.
1297 * src/maemo/easysetup/modest-easysetup-wizard.c:
1298 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1299 one occured, not just "Server does not support secure authentication".
1301 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1303 * src/modest-tny-account-store.c: (get_password):
1304 Restored the call to tny_account_set_user() because Philip seems to have
1305 stopped this from crashing (by not using the freed string). It still does
1306 not work, but now we can test it.
1308 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1310 * src/maemo/modest-msg-edit-window.c: (init_window):
1311 Comment out use of an uninitialzed GtkScrolledWindow variable,
1312 to fix the build and stop a crash. Yet again.
1314 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1316 * src/modest-tny-account-store.c: (get_password):
1317 Remove the call to tny_account_set_user() because this actually crashes.
1318 As mentioned in the last commit, it is known to not work anyway.
1320 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1322 * src/modest-tny-account-store.c: (get_password):
1323 Use tny_account_set_username() to tell tinymail that the username might
1324 have changed too. But tinymail ignores this: see projects.maemo.org
1326 * src/modest-ui-actions.c:
1327 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1328 reset the connection when changing the username, and improve the comments.
1329 Save the changed username to gconf at least, so it is used when Modest is
1332 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1334 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1335 Do not use a query, so that we get all folders, including for POP and
1336 local-folders. They work as search criteria too.
1337 This fixes projects.maemo.org bug NB#57740.
1339 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1341 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1342 Comment out the use of hildon_notification_set_sound() because it is
1343 not declared, to fix the build. Warnings are serious, people.
1345 2007-06-21 Armin Burgmeier <armin@openismus.com>
1347 * src/maemo/modest-maemo-utils.h:
1348 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1349 modest_maemo_utils_get_supported_secure_authentication_methods()
1350 to query authentication methods for a specific user. This should fix
1351 projects.maemo.org bug NB#61369.
1353 * src/maemo/easysetup/modest-easysetup-wizard.c:
1354 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1357 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1359 * libmodest-dbus-client/libmodest-dbus-client.h:
1360 * libmodest-dbus-client/libmodest-dbus-client.c:
1361 (modest_dbus_message_iter_get_search_hit),
1362 (libmodest_dbus_client_search):
1363 Reorganised and commented this.
1364 Removed modest_search_hit_free() from the public API because it
1367 Added libmodest_dbus_client_get_folders() and
1368 modest_folder_result_list_free().
1370 * src/dbus_api/modest-dbus-api.h:
1371 * src/dbus_api/modest-dbus-callbacks.c:
1372 (modest_dbus_req_filter): Commented. Moved most code to
1373 on_dbus_method_search() and added on_dbus_method_get_folders().
1375 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1376 of the extra D-Bus handler.
1378 * tests/dbus_api/Makefile.am:
1379 * tests/dbus_api/test_get_folders.c: New test for
1380 libmodest_dbus_client_get_folders(). This seems to return an empty list
1381 at the moment. That could be the same error that causes the message list
1382 to be empty sometimes.
1383 This should help with projects.maemo.org bug NB#57740.
1385 2007-06-21 Armin Burgmeier <armin@openismus.com>
1387 * src/modest-mail-operation.c: Do not call
1388 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1389 notify the operation's end after having set the status to CANCELED for
1390 the operation queue to listen on. This fixes a deadlock when there
1391 were mail operations in the queue during its finalization.
1393 * src/modest-singletons.c: Reordered uninitialization of the account
1394 manager to happen after the mail operation queue was uninitialized
1395 because the mail operation's in the queue might still try to access
1396 the account manager (see modest_mail_operation_notify_end()). This
1397 fixes a potential crash when terminating the application.
1399 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1401 * src/modest-search.c:
1402 (search_mime_part_and_child_parts): Moved some code here so we
1403 can search recursively in child folders.
1404 (modest_search_folder): Search in the message as a mime part, instead
1405 of just its child mime parts.
1406 (read_chunk), (search_mime_part_ogs):
1407 Check how many bytes were read, to prevent an endless loop.
1408 Searching in message bodies now works. This finishes the fix for
1409 projects.maemo.org bug NB#61007.
1411 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1413 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1414 Add a g_warning when the item is not a folder.
1416 * src/modest-ui-dimming-rules.c:
1417 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1418 when selected item is not a folder (for instance, an account), because
1419 the UI spec only talks about folders.
1420 I am not sure what the UI spec wants, so this might not totally fix
1421 projects.maemo.org bug NB#60794.
1423 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1426 (load_from_file): Sort the list. The unsorted list would be more noticeable
1427 in non-English locales.
1429 * src/maemo/modest-msg-edit-window.c:
1430 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1431 warning and fix the build.
1433 * src/maemo/modest-progress-bar-widget.c:
1434 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1435 avoid a g_warning, and probably to avoid a crash.
1437 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1439 * src/modest-search.c: (modest_search_folder): Check for a GError
1440 when calling tny_folder_get_headers(), to show that this is not the cause
1443 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1445 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1446 Actually set the body query instead of the subject query.
1448 * src/modest-search.c: (search_mime_part_ogs),
1449 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1450 which would probably cause it to fail if we got this far.
1452 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1453 to simplify the code.
1454 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1455 be causing search-in-body to fail.
1457 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1459 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1461 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1462 Better debug message when the folder cannot be found.
1463 This should help with fixing projects.maemo.org bug #61287.
1464 * src/modest-search.c: (add_hit): Do not leak the furl string.
1466 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1468 * src/modest-ui-actions.c:
1469 (modest_ui_actions_on_folder_selection_changed):
1470 Do not special-case TNY_MERGE_FOLDER here, because
1471 modest_tny_folder_get_account() already does that. This fixes
1472 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1473 shown when the Outbox was selected).
1475 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1477 * libmodest-dbus-client/libmodest-dbus-client.c:
1478 (_dbus_iter_get_string_or_null): Initialize the string variable in
1479 case this helps with Dirk's crash.
1481 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1483 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1484 though it is not implemented yet (this function is maybe not even used),
1485 to avoid breaking ABI in future.
1486 * libmodest-dbus-client/libmodest-dbus-client.c:
1487 (get_attachments_string): Moved some code into this generic function.
1488 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1489 sends email. It is maybe not used.
1490 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1491 (on_send_mail): Use attachments.
1493 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1494 * src/maemo/modest-msg-edit-window.c:
1495 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1496 a filename before using it, to fix projects.maemo.org bug NB#58233.
1498 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1500 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1501 Initialize the continue_download variable to fix the build, and probably
1502 to fix randome behaviour.
1504 2007-06-18 Armin Burgmeier <armin@openismus.com>
1506 * src/modest-tny-send-queue.h:
1507 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1508 the queue so we can later show it in the UI. Replaced
1509 modest_tny_send_queue_msg_is_being_sent() by
1510 modest_tny_send_queue_get_msg_status().
1512 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1514 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1515 gpointer. This probably was not harmful, but just to be sure.
1517 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1519 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1520 Fix the build, but leave the function broken on Bora, because
1521 hildon_uri_action_get_service() does not exist.
1522 osso_uri_action_get_service() does not exist either, it seems.
1524 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1526 * src/modest-tny-account.c:
1527 (modest_tny_account_new_from_server_account):
1528 Uncommented the url debug output again, because it is useful for
1529 debugging, as I said in the comment.
1531 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1533 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1535 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1536 for Mameo Bora, to fix the build.
1538 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1541 Fixed build with hildon < 0.99
1543 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1544 Check if the selected account is busy instead of checking all accounts
1546 * src/modest-account-mgr-priv.h:
1547 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1548 (modest_account_mgr_init), (compare_account_name),
1549 (modest_account_mgr_set_account_busy),
1550 (modest_account_mgr_account_is_busy):
1551 * src/modest-account-mgr.h:
1552 Added busy information to the account manager. It possible to
1553 set an account to busy or not busy now.
1555 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1556 (modest_mail_operation_update_account),
1557 (modest_mail_operation_notify_end):
1558 Set the account to busy/not busy depending on the operation state.
1560 * src/widgets/modest-account-view.c:
1561 (modest_account_view_finalize), (get_last_updated_string),
1562 (update_account_view), (on_account_busy_changed), (init_view):
1563 Show string "Refreshing..." if the account is currently busy.
1565 All this fixes projects.maemo.org bug NB#59711
1567 2007-06-14 Armin Burgmeier <armin@openismus.com>
1569 * src/widgets/modest-attachments-view.h:
1570 * src/widgets/modest-attachments-view.c: Added
1571 modest_attachments_view_has_attachments() and fixed coordinate
1572 transformation in get_att_view_at_coords(). This fixes attachment
1575 * src/widgets/modest-msg-view.c: Make use of
1576 modest_attachments_view_has_attachments() to decide whether to show
1577 attachments in the header.
1579 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1581 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1582 (on_change), (on_combo_security_changed),
1583 (modest_connection_specific_smtp_edit_window_init),
1584 (modest_connection_specific_smtp_edit_window_set_connection),
1585 (modest_connection_specific_smtp_edit_window_is_dirty):
1586 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1587 * src/maemo/modest-connection-specific-smtp-window.c:
1590 Show an comfirmation dialog for the smpt-edit-window if there are
1591 unsaved changes and the user hits cancel.
1592 (projects.maemo.org bug NB#60479)
1594 2007-06-14 Armin Burgmeier <armin@openismus.com>
1596 * src/maemo/easysetup/modest-easysetup-wizard.c:
1597 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1598 address" info in banner instead of node, and select all the text as
1599 per UI spec. This fixes projects.maemo.org bug NB#60550.
1601 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1603 reviewed by: <delete if not using a buddy>
1605 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1606 * src/modest-ui-actions.c: (folder_refreshed_cb):
1608 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1610 * src/widgets/modest-folder-view.c: (filter_row):
1611 Explictly filter out the per-account outbox accounts. I don't know why
1612 these only sometimes show up, but now they should never show up in the UI.
1613 This should fix projects.maemo.org bug NB#60160.
1615 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1617 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1618 when the toolbar does not exist yet.
1619 * src/modest-widget-memory.c: (save_settings_header_view):
1620 Added g_warnings() to help us to discover when we are trying to set
1621 an empty columns list in gconf.
1623 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1625 * src/modest-init.h:
1626 * src/modest-init.c:
1627 Added modest_init_get_default_header_view_column_ids().
1629 * src/modest-widget-memory.c: (restore_settings_header_view):
1630 Use the new function to get defaults, if the gconf key is empty,
1631 instead of not creating any columns. This seems to fix the
1632 empty right-hand pane problems.
1634 * src/widgets/modest-header-view.h: Improved documentation.
1636 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1638 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1639 Revert the use of the display name as the account name, because this
1640 is generally wrong and would break the code that follows.
1642 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1644 * src/maemo/easysetup/modest-easysetup-wizard.c:
1645 (check_for_supported_auth_methods), (on_before_next),
1648 More correct fix for projects.maemo.org bug NB# 58991
1649 Do not longer accept AUTH_PASSWORD as secure method and choose
1650 correct method when creating the account.
1652 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1654 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1655 Fixed projects.maemo.org bug NB# 58991
1657 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1659 * src/modest-init.c: (modest_init_init_core),
1660 (modest_init_local_folders): Fixed compilation errors.
1662 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1664 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1665 Remove unnecessary lib/include, though it is good in principle when needed.
1667 * src/modest-init.c: (modest_init_one_local_folder),
1668 (modest_init_local_folders):
1669 * src/modest-init.h: Initialize the .modest library for memory cards,
1670 instead of just doing nothing for them. This should allow us to create
1671 folders there, fixing projects.maemo.org bug NB#59297.
1673 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1675 * libmodest-dbus-client/libmodest-dbus-client.c:
1676 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1677 (libmodest_dbus_client_compose_mail),
1678 (libmodest_dbus_client_open_message),
1679 (libmodest_dbus_client_send_and_receive),
1680 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1682 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1683 (on_idle_open_message), (modest_dbus_req_handler),
1684 (search_result_to_message), (modest_dbus_req_filter):
1685 * src/modest-search.c: (add_hit), (modest_search_folder),
1686 (modest_search_all_accounts): Improved debug messages.
1688 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1690 * src/modest-tny-account-store.c:
1691 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1694 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1697 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1699 * src/modest-tny-account-store.c: (get_server_accounts):
1700 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1701 even when there are no accounts, so that the Outbox folder is always
1702 visible. This fixes projects.maemo.org bug NB#60158.
1704 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1706 * src/maemo/modest-main-window.c: (create_details_widget):
1707 Use the mcen_va_never logical ID.
1709 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1711 * src/dbus_api/modest-dbus-api.h:
1712 * src/dbus_api/modest-dbus-callbacks.c:
1713 (on_idle_open_default_inbox), (on_open_default_inbox),
1714 (modest_dbus_req_handler):
1715 Added a new OpenDefaultInbox method.
1717 * libmodest-dbus-client/libmodest-dbus-client.h:
1718 * libmodest-dbus-client/libmodest-dbus-client.c:
1719 Added libmodest_dbus_client_open_default_inbox() to call the new
1720 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1721 though it should maybe be used by a new osso-email-interface function.
1723 * tests/dbus_api/Makefile.am:
1724 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1727 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1729 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1730 NULL, so that the signals get all the keys. This should not actually
1731 change any behaviour because we currently update everything when anything
1734 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1736 * src/widgets/modest-folder-view.c: (text_cell_data),
1737 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1738 (find_inbox_iter): If tinymail tells us that the folder is
1739 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1740 This causes the inbox to be selected at startup, fixing part of
1741 projects.maemo.org bug NB#56305.
1743 * src/modest-ui-dimming-rules.c:
1744 (modest_ui_dimming_rules_on_tools_smtp_servers):
1745 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1746 the SMTP servers menu item.
1747 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1748 that the SMTP Servers menu item is dimmed when there are no accounts,
1749 as a future version of the UI spec will require. This fixes
1750 projects.maemo.org bug NB#56305.
1752 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1754 * src/maemo/modest-maemo-utils.c:
1755 (modest_maemo_utils_get_supported_secure_authentication_methods):
1756 Added label to dialog instead of unreadable title
1758 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1759 (modest_main_window_new):
1760 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1763 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1764 * src/modest-account-mgr.h:
1765 Added method to avoid code duplication
1767 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1768 (modest_ui_actions_on_send_receive):
1769 Use modest_account_mgr_has_accounts
1771 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1773 * src/maemo/easysetup/modest-presets.c:
1774 (modest_presets_get_info_server_security): Do not report secure auth
1776 * src/modest-protocol-info.c: Use the defines for the gconf key names
1777 for secure authentication. This was not working because we were writing
1778 Password and reading password, and the check was case sensitive.
1779 With this, gmail now works for receiving and sending when created via
1782 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1784 * src/maemo/easysetup/modest-presets.c:
1785 (modest_presets_get_info_server_security): Correct the key name for
1786 SecureSmtp, because it seems to be case-sensitive.
1787 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1788 Do not try to get the 0th notebook page if there are 0 pages, to
1789 avoid a g_warning().
1791 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1793 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1794 Prevent use of the new notification feature for now, because it currently
1795 shows one dialog for each new email, which is annoying.
1797 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1799 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1800 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1801 when no country was selected, so that we show the global ones.
1802 * src/maemo/easysetup/modest-presets.c:
1803 (modest_presets_get_providers): Return only the global providers, not
1804 all providers when mmc=0 was requested.
1806 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1808 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1809 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1810 provider ID in the combo.
1812 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1813 Do not show the page numbers, because it would be confusing when we add
1814 the 2 extra pages for the custom setup, when the user chooses the "Other"
1815 provider. This fixes projects.maemo.org bug NB#59028
1817 * src/modest-init.c: (modest_init_init_core),
1818 (modest_init_local_folders):
1819 * src/modest-init.h:
1820 * src/modest-tny-account.c:
1821 (modest_tny_account_new_for_local_folders): Do not create default folders
1822 for the memory card. This should fix projects.maemo.org bug NB#59328.
1824 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1826 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1827 Free the changed_conf_keys string items. They are already freed in the
1828 idle handler if that runs first.
1830 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-ui-actions.c:
1833 (modest_ui_actions_on_password_requested): Check that the server name
1834 is not NULL, because I just saw a password dialog with (null) as the
1837 * src/modest-tny-folder.[h|c]: Added
1838 modest_tny_folder_is_memory_card_folder().
1839 * src/modest-ui-dimming-rules.c:
1840 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1841 menu item for memory cards, as per the UI spec (section 7.4). This should
1842 fix projects.maemo.org bug NB#59297.
1844 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1846 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1847 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1848 is another problem with the code, see Murray's comment at line 772)
1850 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1852 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1853 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1854 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1855 (load_from_file), (easysetup_country_combo_box_init),
1856 (easysetup_country_combo_box_get_active_country_ids),
1857 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1858 instead of just one ID, to avoid duplicate country names in the UI.
1860 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1861 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1862 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1863 a single ID, avoiding duplicate providers.
1864 * src/maemo/easysetup/modest-easysetup-wizard.c:
1865 (on_combo_account_country): Adapt to use a list.
1867 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1869 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1870 keys changed in the last X seconds.
1872 * src/modest-account-mgr.h:
1873 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1874 (on_key_change), (modest_account_mgr_class_init),
1875 (modest_account_mgr_init), (modest_account_mgr_finalize):
1876 As the keys are changed, save them in a GSList* and signal that GSList*
1877 further every X seconds, to batch changes, to allow us to do just one
1878 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1879 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1881 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1882 changed signal signature.
1884 * src/modest-conf.c: (modest_conf_set_list),
1885 (modest_conf_on_change): Reenable notification.
1887 (modest_conf_maemo_fake_on_change): Comment out the hack that
1888 notified immediately instead of asynchronously.
1890 * src/widgets/modest-account-view.h:
1891 * src/widgets/modest-account-view.c:
1892 (update_account_view): Select the previously-selected account ID,
1893 if possible. This fixes projects.maemo.org bug NB#56933.
1895 (on_account_changed), (on_account_removed),
1896 (modest_account_view_select_account):
1898 Remove the block/unblock functions
1899 because they were not useful.
1901 * src/maemo/modest-account-view-window.c:
1902 (on_delete_button_clicked), (on_edit_button_clicked),
1903 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1905 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1907 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1908 Improve the error dialog to show Incorrect Account Settings, which seems
1909 clearer, and say that the internal error message (to be removed from the
1910 dialog later) is often misleading.
1911 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1913 * src/modest-tny-account.c:
1914 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1915 URL because this is so useful for debugging on the device.
1917 * src/widgets/modest-serversecurity-combo-box.c:
1918 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1920 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1922 * src/modest-mail-operation.c:
1923 (modest_mail_operation_send_new_mail):
1924 Added a comment about a nasty but apparently harmless message. Details
1925 added to the wiki g_warnings() page.
1927 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1929 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1930 (modest_tny_send_queue_class_init):
1931 Do not use the priv struct because it is empty, to avoid g_warnings
1932 about a non-existant priv struct.
1934 * src/modest-tny-account-store.c:
1935 (modest_tny_account_store_get_server_account),
1936 (modest_tny_account_store_get_transport_account_for_open_connection
1937 ): Do not try to get transport server accounts for local folders,
1938 because they don't have any. This avoids a g_warning().
1940 * src/maemo/modest-main-window.c:
1941 (modest_main_window_notify_send_receive_initied),
1942 (on_configuration_key_changed):
1943 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1944 * src/modest-defs.h:
1945 * src/modest-mail-operation.c:
1946 (modest_mail_operation_update_account):
1947 * src/modest-tny-account-store.h:
1948 * src/modest-tny-account.c:
1949 (modest_tny_account_get_special_folder),
1950 (modest_tny_account_new_for_local_folders),
1951 (modest_tny_account_new_for_per_account_local_outbox_folder):
1952 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1953 * src/modest-tny-local-folders-account.c:
1954 (add_account_folders_to_merged_folder):
1955 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1956 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1957 (modest_ui_actions_on_send):
1958 * src/widgets/modest-folder-view.c: (update_model):
1959 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1960 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1961 modest_tny_account_store_get_tny_account_by_account() to
1962 modest_tny_account_store_get_server_account() to make the code clearer.
1964 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1966 * src/dbus_api/modest-dbus-api.h:
1967 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1968 * src/maemo/modest-msg-edit-window.c:
1969 (modest_msg_edit_window_attach_file_noninteractive):
1970 added g_warning in case the file to be attached does not exist
1971 * tests/dbus_api/test_compose_mail.c: (main):
1972 removed obsolete comment, added generic files as test case
1974 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1976 * src/modest-tny-account-store.c: (get_server_accounts):
1977 Create the local folders account only once, not once for each outbox, and
1978 not only when there are some outboxes.
1980 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1982 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1983 code that is causing a crash at startup. Sergio says that he is fixing this.
1985 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1987 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1988 * src/maemo/modest-account-settings-dialog.c:
1989 (create_page_outgoing),
1990 (modest_account_settings_dialog_set_account_name),
1991 (save_configuration):
1992 - Fixed handling of the "Use secure authentication" toggle to comply with
1993 the ui specification. See also projects.maemo.org bug NB#58400
1995 - Restore the Secure connection setting combo correctly when loading
1998 * src/maemo/modest-maemo-utils.c:
1999 (on_camel_account_get_supported_secure_authentication),
2000 (modest_maemo_utils_get_supported_secure_authentication_methods):
2001 Fixed a crasher if operation is canceled
2003 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2004 (modest_protocol_info_auth_is_secure):
2005 * src/modest-protocol-info.h:
2007 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2008 the sense of the "Use secure authentication" toggle.
2010 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2012 * src/modest-tny-account-store.h:
2013 * src/modest-tny-account-store.c:
2014 Added modest_tny_account_store_get_local_folders_account().
2016 * src/modest-tny-folder.h:
2017 * src/modest-tny-folder.c:
2018 (modest_tny_folder_get_account):
2019 Added this replacement for tny_folder_get_account() which returns
2020 the local-folders account for TnyMergeFolders, to avoid the
2021 warning about the unimplemented get_account_func() vfunc().
2023 (modest_tny_folder_get_rules),
2024 * src/modest-ui-actions.c:
2025 (modest_ui_actions_on_folder_selection_changed):
2026 * src/modest-mail-operation.c:
2027 (modest_mail_operation_remove_folder),
2028 (modest_mail_operation_xfer_folder),
2029 (modest_mail_operation_rename_folder),
2030 (modest_mail_operation_get_msg),
2031 (modest_mail_operation_get_msgs_full),
2032 (modest_mail_operation_remove_msg),
2033 (modest_mail_operation_xfer_msgs),
2034 (modest_mail_operation_refresh_folder):
2035 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2037 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2039 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2040 (modest_server_account_set_security):
2041 * src/modest-defs.h: Add comments explaining that our
2042 UI spec means TLS when it says Normal, so these do not look like errors.
2044 * src/modest-tny-account.c:
2045 (modest_tny_account_new_from_server_account): Use the new tinymail
2046 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2047 for TLS. This should fix projects.maemo.org bug NB#58460.
2049 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2051 * src/maemo/easysetup/modest-easysetup-wizard.c:
2052 (create_account): Correct the position of the gconf sanity check warning.
2053 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2054 of using the g_idle_add() hack, because this does not seem to be necessary
2055 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2056 caused by something other than maemo's gconf.
2057 This fixes projects.maemo.org bug #59022.
2059 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2061 * src/modest-account-mgr-helpers.c:
2062 (modest_account_mgr_get_default_account): Do not check that the account
2063 exists if there is no default account (NULL), to fix a runtime warning.
2065 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2067 * src/widgets/modest-folder-view.c: (update_model):
2068 Do not unref the treemodel before we have finished with it.
2069 This prevents a valgrind warning and an occasional crash at startup.
2071 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2073 * libmodest-dbus-client/libmodest-dbus-client.h:
2074 added libmodest_dbus_client_compose_mail()
2075 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2077 added functions needed for SendAsMail() functionality
2078 * src/maemo/modest-msg-edit-window.c:
2079 (modest_msg_edit_window_attach_file_noninteractive):
2080 non interactively attaching files to message edit window
2081 * src/widgets/modest-msg-edit-window.h:
2082 * tests/dbus_api/Makefile.am:
2083 added test_compose_mail.c
2084 * tests/dbus_api/test_compose_mail.c: (main):
2086 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2088 * src/modest-account-view.c:
2089 Fixed bug projects.maemo.org bug NB#59307
2091 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2093 * src/maemo/easysetup/modest-easysetup-wizard.c:
2094 (get_serverport_incoming), (on_before_next), (create_account):
2095 * src/maemo/modest-account-settings-dialog.c:
2096 (modest_account_settings_dialog_set_account_name):
2097 * src/maemo/modest-maemo-utils.c:
2098 (on_camel_account_get_supported_secure_authentication_status),
2099 (on_camel_account_get_supported_secure_authentication),
2100 (on_secure_auth_cancel),
2101 (modest_maemo_utils_get_supported_secure_authentication_methods):
2103 Implemented security authentication for settings and easysetup.
2105 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2107 * src/maemo/modest-main-window.c: (create_details_widget):
2108 Show the total size for memory card accounts too, instead of showing
2109 the name again. Fixes bug projects.maemo.org bug NB#59307.
2111 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2114 * src/modest-tny-simple-folder-store.c:
2115 * src/modest-tny-simple-folder-store.h: Removed.
2117 * src/modest-tny-local-folders-account.h
2118 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2119 for the local-folders maildir, with an extra TnyMergedFolder containing
2120 the folders of the per-account outbox store accounts.
2121 * src/modest-tny-account-store.c: (get_server_accounts):
2122 Add the outboxes to the special local folders account after creating it.
2124 * src/modest-tny-account.c:
2125 (modest_tny_account_new_for_local_folders): Create the derived
2126 account when creating the main local-folders account.
2128 * src/maemo/modest-main-window.c: (create_details_widget),
2129 (modest_main_window_set_contents_style):
2130 Adapted to the use of the derived account instead of the folder store.
2132 * src/modest-ui-actions.c:
2133 (modest_ui_actions_on_folder_selection_changed):
2134 * src/modest-ui-dimming-rules.c:
2135 (modest_ui_dimming_rules_on_new_folder):
2136 * src/widgets/modest-folder-view.c: (text_cell_data),
2137 (icon_cell_data), (filter_row), (update_model),
2138 (get_cmp_rows_type_pos):
2141 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2142 Do not get the priv struct, because no priv struct has been set,
2143 to avoid a runtime warning.
2145 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2146 #ifelse with #else, to fix a warning, to fix the build.
2149 2007-06-05 Christian Kellner <ckellner@openismus.com>
2151 * libmodest-dbus-client/libmodest-dbus-client.c:
2152 Fix small typo in doc (why do you always see them
2153 AFTER committing stuff?)
2156 2007-06-05 Christian Kellner <ckellner@openismus.com>
2158 * libmodest-dbus-client/libmodest-dbus-client.c:
2159 (libmodest_dbus_client_search):
2160 Initialize hit list with NULL. Also set folder list
2161 to "" if NULL was supplied.
2164 2007-06-03 Christian Kellner <ckellner@openismus.com>
2166 * libmodest-dbus-client/libmodest-dbus-client.c:
2167 (modest_search_hit_list_free):
2168 Make it save to call it with NULL.
2170 * src/dbus_api/modest-dbus-callbacks.c:
2171 * src/modest-search.c:
2172 Return full ModestSearchHits as the search result list not TnyHeader
2173 since can't be around withouth the correspoding TnyFolder.
2175 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2177 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2178 Added currently commented code to check for secure auth
2180 * src/maemo/modest-account-settings-dialog.c: (on_response),
2181 (save_configuration), (show_ok):
2182 Fixed projects.maemo.org bugs NB #59248 and #59251
2184 * src/maemo/modest-maemo-utils.c:
2185 (on_camel_account_get_supported_secure_authentication_status),
2186 (on_camel_account_get_supported_secure_authentication),
2187 (modest_maemo_utils_get_supported_secure_authentication_methods):
2188 * src/maemo/modest-maemo-utils.h:
2189 Moved get_supported_secure_authentication() method here to be able
2190 to use it from easysetup wizard.
2192 * src/modest-pair.c: (on_pair_compare_as_string):
2193 Should compare string with first part of pair and not
2194 strcmp pairs which will crash.
2196 * src/modest-protocol-info.c:
2197 (modest_protocol_info_protocol_is_store):
2198 * src/modest-protocol-info.h:
2199 Added modest_protocol_info_get_auth_protocol_name()
2201 2007-06-03 Armin Burgmeier <armin@openismus.com>
2203 * src/modest-mail-operation.c:
2204 (modest_mail_operation_get_msgs_full): Set priv->account also when
2205 only retrieving a single message. This avoids a crash when canceling
2208 (modest_mail_operation_notify_end): Do not explicitely remove the
2209 operation from the queue but only emit the progress_changed signal.
2210 The queue itself listens to that signal to remove the operation when
2211 it is finished. This reduces coupling and removes a potential deadlock
2212 when modest_mail_operation_notify_end() is called from the queue
2213 itself. If that is a problem performance-wise, I would suggest to
2214 implement a status-changed signal or something.
2216 * src/modest-mail-operation-queue.c: Make sure to never call a
2217 function from another file while the queue is locked. This (hopefully)
2218 fixes another deadlock when exiting the application while retrieving
2221 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2223 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2224 Fixed build if libogs is not available
2226 2007-06-03 Christian Kellner <ckellner@openismus.com>
2228 * libmodest-dbus-client/libmodest-dbus-client.h:
2229 * libmodest-dbus-client/libmodest-dbus-client.c:
2230 (libmodest_dbus_client_delete_message):
2231 Implement deletion of messages (Client side).
2233 (modest_search_hit_free),
2234 (modest_search_hit_list_free):
2235 Utility functions to free the result hits.
2237 * src/dbus_api/modest-dbus-api.h:
2238 * src/dbus_api/modest-dbus-callbacks.c:
2239 (on_delete_message),
2240 (modest_dbus_req_handler):
2241 Implement deletion of messages (Server side).
2243 * tests/dbus_api/test_search.c: (main):
2246 * tests/dbus_api/Makefile.am:
2247 * tests/dbus_api/test_delete_message:
2248 Add little test for the message deletion logic
2250 2007-06-03 Armin Burgmeier <armin@openismus.com>
2252 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2253 when the operation queue was not empty. projects.maemo.org bug
2256 2007-06-03 Armin Burgmeier <armin@openismus.com>
2258 * src/widgets/modest-account-view.c
2259 (on_account_default_toggled): Toggle default account column
2260 explicitely instead of waiting for gconf notification (which is
2261 currently ignored). This should fix projects.maemo.org bug NB#56910
2262 for now. It should probably be removed when gconf notifications are
2265 2007-06-03 Christian Kellner <ckellner@openismus.com>
2267 * libmodest-dbus-client/libmodest-dbus-client.c:
2268 Removed debugging spew.
2270 * src/dbus_api/modest-dbus-callbacks.c:
2271 Added debugging info.
2273 * src/modest-search.c:
2274 (modest_search_all_accounts):
2275 Use tny_account_store_get_accounts () on the account store
2276 to get all accounts which is the way to get all accounts.
2278 * tests/dbus_api/test_search.c: (main):
2279 Make it possible to supply the search term on the command line.
2281 2007-06-03 Christian Kellner <ckellner@openismus.com>
2283 * libmodest-dbus-client/libmodest-dbus-client.c:
2284 * libmodest-dbus-client/libmodest-dbus-client.h:
2285 Implement searching for mesages over raw dbus. (Client side)
2287 * src/dbus_api/Makefile.am:
2288 * src/dbus_api/modest-dbus-api.h:
2289 * src/dbus_api/modest-dbus-callbacks.c:
2290 * src/dbus_api/modest-dbus-callbacks.h:
2291 Search framework (Server side). Also implement on_idle_open_message().
2293 * src/maemo/modest-platform.c: (modest_platform_init):
2294 Prepare for raw dbus/osso rpc interaction.
2296 * src/modest-search.h:
2297 Changed minsize from unspecific guint to guint32.
2299 * src/modest-search.c:
2301 Added strange hack which magically made tnymail work.
2303 (modest_search_folder),
2304 (modest_search_account),
2305 (modest_search_all_accounts):
2306 Implement helper functions to search all accounts, specific account
2309 * tests/dbus_api/Makefile.am:
2310 * tests/dbus_api/test_open_message.c:
2311 Read url to open from commandline.
2313 * tests/dbus_api/test_search.c:
2314 Implement small test for dbus search stuff
2316 2007-06-02 Armin Burgmeier <armin@openismus.com>
2318 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2319 include account type and account title. This fixes projects.maemo.org
2322 * src/maemo/modest-account-view-window.c: Set a title for the window.
2324 2007-06-02 Armin Burgmeier <armin@openismus.com>
2326 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2327 incoming and outgoing server name based on email address and server
2328 types as long as the names have not been edited manually. This fixes
2329 projects.maemo.org bug NB#58671.
2331 2007-06-02 Armin Burgmeier <armin@openismus.com>
2333 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2334 server type cannot be changed in future to the incoming details page
2335 when creating an account. This fixes projects.maemo.org bug NB#59029.
2337 2007-06-02 Armin Burgmeier <armin@openismus.com>
2339 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2340 and assigned max width chars so that they wrap instead of being
2341 truncated. Fixes projects.maemo.org bug NB#56126.
2343 2007-06-02 Armin Burgmeier <armin@openismus.com>
2345 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2346 introductory note to the connection specific smtp servers dialog, as
2347 section 8.12 of the email UI specification requires. This fixes
2348 projects.maemo.org bug NB#59212.
2350 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2352 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2353 Check for running mail operations, and offer to cancel them, as per the UI
2354 spec. This fixes projects.maemo.org bug NB#59041 .
2355 However, I suspect that tinymail may still use the network connection
2356 in ways that we cannot detect or cancel. But it should at least adapt to
2357 changes fairly well.
2359 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2361 * src/modest-tny-account-store.c: (recreate_all_accounts),
2362 (get_cached_accounts), (get_server_accounts): Do more sensible
2363 ref-counting of the temporarily-cached outbox accounts list. This seems
2364 to fix a crash when entering the password when the password was wrong.
2366 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2368 * src/gnome/modest-main-window.c: (connect_signals):
2369 * src/modest-tny-account-store.c: (get_password),
2370 (modest_tny_account_store_alert): Added comments and clues and
2371 commented-out code about how we currently fail to deal with connection
2372 errors and wrong passwords, and how we should.
2374 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2376 * src/widgets/modest-retrieve-combo-box.c:
2377 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2378 This fixes projects.maemo.org bug NB#58472 .
2380 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2382 * src/maemo/easysetup/modest-easysetup-wizard.c:
2383 (create_page_complete_easysetup):
2384 (create_page_complete_custom): Correct the last commit,
2385 putting the correct sentences in the correct pages.
2387 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2389 * src/maemo/easysetup/modest-easysetup-wizard.c:
2390 (create_page_complete_custom): Show the second sentence of text
2391 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2394 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2396 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2397 Set the leave-on-server conf key by default. This fixes
2398 projects.maemo.org bug NB#59258 .
2400 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2402 * src/maemo/modest-account-view-window.c:
2403 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2404 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2407 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2409 * src/maemo/easysetup/modest-easysetup-wizard.c:
2410 (create_caption_new_with_asterisk):
2411 * src/maemo/modest-account-settings-dialog.c:
2412 (create_caption_new_with_asterisk):
2413 Uncomment the code to add the asterisk, because they are no longer in the
2414 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2415 (update_incoming_server_title): Add an asterisk here too.
2417 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2419 * src/maemo/modest-maemo-global-settings-dialog.c:
2420 (current_connection): Check that we are even connected before trying to
2421 get the current connection name, to prevent a warning.
2423 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2424 Change the comments because tny_maemo_conic_device_connect() is now meant to
2426 * src/modest-mail-operation.c:
2427 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2428 make sure we have a connection and fail if we can't connect.
2430 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2432 * src/maemo/modest-main-window.c:
2433 (on_account_store_connecting_finished): Do not try to get the
2434 connection ID if we are not really connected. I am surprised that
2435 this signal handler is called when we are not connected.
2437 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2439 * src/modest-error.h:
2440 * src/modest-ui-actions.c:
2441 (modest_ui_actions_get_msgs_full_error_handler):
2442 Renamed an enum, added comments, added an enum
2443 for retrieve-limit errors.
2445 * src/modest-mail-operation.c: (foreach_add_item),
2446 (internal_folder_observer_update), (update_account_thread),
2447 (modest_mail_operation_get_msgs_full):
2448 (modest_mail_operation_update_account),
2449 Added comments about how this works, and some code that should
2450 (but does not) check the retrieve-limit. See the TODO comment.
2452 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2454 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2455 Initialize help_id to fix the build. Warnings are good.
2457 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2459 * src/widgets/modest-hbox-cell-renderer.c:
2460 (modest_hbox_cell_renderer_append):
2461 * src/widgets/modest-vbox-cell-renderer.c:
2462 (modest_vbox_cell_renderer_append):
2463 Fix the last commit by doing an extra ref.
2465 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2467 * src/widgets/modest-hbox-cell-renderer.c:
2468 (modest_hbox_cell_renderer_append):
2469 * src/widgets/modest-vbox-cell-renderer.c:
2470 (modest_vbox_cell_renderer_append):
2471 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2472 to fix the build with Maemo Bora.
2473 However, there seems to be a remaining crash, probably due to reference
2476 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2478 * src/modest-tny-account.c:
2479 (modest_tny_account_new_for_local_folders):
2480 Use hildon_file_system_info_async_new() to get a better name for
2481 the memory card account, setting it as the account name.
2482 The timing seems to work, but this is probably
2483 not the best place to do this. See the TODO comment.
2484 * src/maemo/modest-main-window.c: (create_details_widget):
2485 * src/widgets/modest-folder-view.c: (text_cell_data):
2486 Use the tny account name instead of hardcoding a name.
2488 2007-05-30 Christian Kellner <ckellner@openismus.com>
2490 * src/modest-search.c: (modest_search):
2491 Correctly set part_search_func even if we have already parsed
2492 the query and thus a valid OgsTextSearcher object.
2494 2007-05-30 Christian Kellner <ckellner@openismus.com>
2497 Search and check for libogs.
2500 Incooparte the ogs build env.
2502 * src/modest-mime-part-search-stream.c:
2503 * src/modest-mime-part-search-stream.h:
2504 Removed since we do the real searching now in modest-search.c.
2506 * src/modest-search.c:
2507 * src/modest-search.h:
2508 Implement support for ogs. We use that if available and requested
2509 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2510 should now handle the corner case when the search term is spread
2511 across multiple reads.
2512 Also the logic in modest_search () was corrected to search all
2513 requested fields until one is found.
2515 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2517 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2519 * src/modest-init.h:
2520 * src/modest-init.c: Made modest_init_local_folders() take a
2521 path and be public so we can iniitialize maildir folders on
2524 * src/modest-local-folder-info.h:
2525 * src/modest-local-folder-info.c:
2526 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2528 * src/modest-tny-account.c:
2529 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2530 still means the standard local-folders path on the local volume.
2532 * src/modest-tny-account-store.c:
2533 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2534 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2535 all accounts when that happens.
2536 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2537 this too, so it shows up in the treeview.
2539 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2541 * src/maemo/modest-maemo-global-settings-dialog.c:
2542 (current_connection):
2543 * src/widgets/modest-global-settings-dialog.c:
2544 (current_connection_default):
2545 Use the enum values instead of 0, 1 and -1,
2546 to make the code clearer.
2548 * src/modest-account-mgr-helpers.c:
2549 (modest_account_mgr_get_connection_specific_smtp): Make this code
2552 * src/modest-runtime.h:
2553 * src/modest-runtime.c:
2554 Added modest_runtime_remove_all_send_queues().
2555 * src/maemo/modest-main-window.c:
2556 (on_account_store_connecting_finished): Recreate the send queues,
2557 using the appropriate transport accounts for this new connection.
2558 Some futher adapting might be needed if the old send queues are not
2559 automatically stopped at this point.
2561 * src/modest-tny-account-store.c: (get_server_accounts):
2562 Create the connection-specific transport accounts, so that they can
2563 be found later by their ID.
2565 * src/modest-tny-account.h:
2566 * src/modest-tny-account.c:
2567 Added modest_tny_account_new_from_server_account_name().
2568 modest_tny_account_new_from_server_account(): Do not create the
2569 send queues here, because they will be
2570 recreated anyway when the connection changes for the first time.
2572 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2574 * src/modest-local-folder-info.h:
2575 * src/modest-local-folder-info.c:
2576 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2577 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2578 tbox_folder): Take a modest account name instead of a server TnyAccount,
2579 so we can have per-modest-account rather than per-transport-account
2581 We must make sure that we change or recreate the exisitng send queues
2582 when the connection changes for connection-specific transport accounts.
2584 * src/modest-tny-account-store.c:
2585 (create_per_account_local_outbox_folders): Create outboxed per modest
2586 account, not per transport account.
2588 * src/modest-tny-account.h:
2589 * src/modest-tny-account.c:
2590 (modest_tny_account_get_special_folder): For outboxes, get the
2591 parent modest account name. The account is ignored for other folders.
2592 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2593 modest account name rather than a server TnyAccount.
2595 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2597 * src/modest-tny-account.c:
2598 (modest_tny_account_new_from_server_account):
2599 Call modest_runtime_get_send_queue() immediately after creating transport
2600 accounts, so that they start trying to send email from the outbox as soon
2601 as possible at startup. This is probably what we want.
2603 * src/modest-mail-operation.c: (update_account_thread):
2604 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2605 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2606 * src/modest-tny-send-queue.h:
2607 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2608 (modest_ui_actions_on_send):
2609 Added comments about how sending works, though it needs some more work.
2611 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2613 * src/modest-tny-account.c:
2614 (modest_tny_account_get_special_folder): Add TODO because this fails when
2615 the network is busy.
2616 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2617 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2618 Do not try to show this window when there is no active account. The UI
2619 specs does not tell us what to do in this case.
2621 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2625 * src/maemo/Makefile.am:
2626 * src/widgets/Makefile.am: Some dist fixes.
2628 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2630 * src/maemo/modest-connection-specific-smtp-window.c:
2631 (on_button_edit): Make the code clearer, to prevent a double free.
2633 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2635 * src/maemo/modest-account-settings-dialog.c:
2636 (modest_account_settings_dialog_set_account_name),
2637 Check the connection-specific smtp servers checkbox if there are any.
2639 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2640 (modest_connection_specific_smtp_edit_window_init):
2641 Start with a suitable port number.
2643 * src/modest-account-mgr-helpers.h:
2644 * src/modest-account-mgr-helpers.c: Added
2645 modest_account_mgr_get_has_connection_specific_smtp().
2647 (modest_account_mgr_set_connection_specific_smtp),
2648 (modest_account_mgr_remove_connection_specific_smtp),
2649 (modest_account_mgr_get_has_connection_specific_smtp),
2650 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2651 connection-specific smtp server accounts in the account, rather than
2652 the server account conf dir.
2654 This fixes bug projects.maemo.org bug NB#58263 .
2656 * src/modest-tny-account-store.c:
2657 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2658 if there are no server accounts yet, to prevent an infinite loop when there
2659 are no accounts. Document that one must be called before the other.
2661 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2663 * src/modest-account-mgr-helpers.c:
2664 (modest_account_mgr_get_default_account): Make sure that at least
2665 one account is always the default, if there are any enabled accounts.
2666 This is just a sanity check that shouldn't be necessary.
2668 * src/modest-account-mgr-priv.c:
2669 (_modest_account_mgr_account_from_key): Unescape the conf key to
2670 get the real account name. For instance, this is an issue if a space
2671 was in the account name, which can happen because the account name
2672 is generated from the display name.
2673 (_modest_account_mgr_get_account_keyname): Always escape the
2675 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2676 Unescape the conf keys to get the real account names.
2678 For instance, previously the is-default radio button in the accounts
2679 list was not checked for any accounts at first. This fixes that,
2680 and might fix several similar bugs.
2682 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2684 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2685 Removed some debug printfs.
2687 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2689 Modest on-disk outbox directories are now here, for instance:
2690 $HOME/.modest/outboxes/<account-id-1>/outbox
2691 $HOME/.modest/outboxes/<account-id-2>/outbox
2693 $HOME/.modest/local-folders/outbox
2694 so we can have a separate outbox for each account.
2695 But they are shown as one outbox in the GtkTreeView, by using a
2696 TnyMergeFolder in a ModestTnySimpleFolderStore.
2699 * src/modest-tny-simple-folder-store.c:
2700 * src/modest-tny-simple-folder-store.h:
2701 Added ModestTnySimpleFolderStore, used to contain folders from
2702 other folder stores, such as other accounts.
2704 * src/modest-tny-outbox-account.h:
2705 * src/modest-tny-outbox-account.c:
2706 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2707 used for the per-account local outbox folders.
2709 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2710 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2711 only use this (internally) now for the non-outbox local folders.
2713 * src/modest-init.h:
2714 * src/modest-init.c: Added modest_init_one_local_folder(), for
2715 setting up the directory structure for each local folder.
2717 * src/modest-local-folder-info.c:
2718 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2719 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2721 * src/modest-local-folder-info.h:
2722 * src/modest-tny-account-store.c: (on_account_removed),
2723 (on_account_changed), (create_per_account_local_outbox_folders),
2724 (get_server_accounts), (modest_tny_account_store_get_accounts),
2725 (modest_tny_account_store_get_tny_account_by_account),
2726 (modest_tny_folder_store_is_virtual_local_folders):
2728 * src/modest-tny-account.h:
2729 * src/modest-tny-account.c:
2730 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2731 to create an on-disk per-account local outbox folder for each
2733 (create_per_account_local_outbox_folders): Create a local outbox folder
2734 for each transport account.
2735 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2736 for all local folders.
2738 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2739 instead of using g_object_get/set() directly. It is clearer.
2741 (modest_tny_folder_store_get_message_count),
2742 (modest_tny_folder_store_get_local_size
2743 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2744 because we now use these with non-acount folder stores.
2746 (modest_tny_account_get_special_folder),
2747 (modest_tny_account_new_from_server_account),
2748 (modest_tny_account_new_from_account):
2749 (recurse_folders): Adjust to the new outbox system.
2751 * src/modest-tny-folder.h:
2752 * src/modest-tny-folder.c:
2753 (modest_tny_folder_is_local_folder),
2754 (modest_tny_folder_get_local_folder_type),
2755 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2757 * src/widgets/modest-main-window.h:
2758 * src/maemo/modest-main-window.c: (create_details_widget),
2759 (modest_main_window_set_contents_style): Show details for any folder store,
2762 (modest_tny_folder_get_rules):
2763 Remove the const. C does not support constness enough for this.
2765 * src/modest-ui-actions.c:
2766 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2767 make all outboxes appear as one, in the usual local-folders tree node.
2769 (set_active_account_from_tny_account),
2770 (modest_ui_actions_on_folder_selection_changed):
2771 * src/widgets/modest-folder-view.c: (text_cell_data),
2772 (icon_cell_data), (filter_row),
2773 (add_account_folders_to_merged_folder),
2774 (add_account_folders_to_simple_folder_store), (),
2775 (get_cmp_rows_type_pos), (cmp_rows),
2776 (modest_folder_view_set_account_id_of_visible_server_account):
2777 Adjust to the new outbox system, using generic folder stores and folders
2778 in the GtkTreeModel.
2780 2007-05-23 Christian Kellner <ckellner@openismus.com>
2782 * src/modest-mail-operation.c:
2783 (modest_mail_operation_update_account):
2784 Use info->max_size instead of unintialized local var [small
2785 build fix]. (Added TODO to review that change since I don't
2788 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2790 * libmodest-dbus-client/libmodest-dbus-client.c:
2791 (libmodest_dbus_client_compose_mail): function added
2792 * src/dbus_api/modest-dbus-api.h:
2793 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2794 (on_compose_mail): Implementation of the SendAsMail functionality
2796 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2798 * src/modest-account-mgr.c:
2799 (modest_account_mgr_add_server_account): Set the secure-connection
2800 conf key for transport accounts as well as store accounts. I don't know
2801 why the if was there. For instance, this makes sure that we use SSL
2802 for the gmail preset from the easysetup wizard.
2804 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2806 * src/gnome/modest-main-window.c:
2807 (on_account_store_connecting_finished), (connect_signals):
2808 * src/maemo/modest-main-window.c:
2809 (on_account_store_connecting_finished), (connect_signals),
2810 (modest_main_window_new):
2811 Handle TnyAccountStore::connecting-finished instead of
2812 TnyDevice::connection-changed, because we cannot actually perform
2813 operations on accounts until TnyAccountStore has itself responded to
2814 the TnyDevice::connection-changed signal. This prevents a GError from
2816 Do not try to update at startup, because we (at least on scratchbox)
2817 already do an update at startup when the device goes online.
2818 This prevents a GError from tinymail.
2819 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2820 Added TODO about stopping simultaneous operations.
2822 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2824 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2825 * src/modest-mail-operation-queue.c:
2826 (modest_mail_operation_queue_remove):
2827 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2828 about where they happened.
2830 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2832 * src/modest-ui-actions.c:
2833 (modest_ui_actions_on_password_requested): Make sure that the remember
2834 output parameter is always TRUE.
2836 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2838 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2839 Show a OK/Cancel dialog if the error is a question, though we still do not
2840 know anything more about what we are asking the user.
2841 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2842 Fix an uninitialized variable (helper). This is a logic error, however.
2844 2007-05-21 Christian Kellner <ckellner@openismus.com>
2846 * src/modest-search.h:
2847 Correct bit shifting in the ModestSearchFlags enum.
2849 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2851 * src/modest-tny-account.c:
2852 (modest_tny_account_new_from_server_account): Do not use the lsub and
2853 check-all hard-coded IMAP options when using POP.
2855 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2857 * src/modest-tny-account.c:
2858 (modest_tny_account_new_from_server_account):
2859 Use NULL for the secure-auth method for POP when Password auth has been
2860 specified by the user, as we already do for IMAP. "auth=Login" causes
2861 an error from camel or the server.
2863 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2865 * src/maemo/modest-account-settings-dialog.c:
2866 (create_page_account_details),
2867 (modest_account_settings_dialog_set_account_name):
2868 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2869 for the leave-on-server checkbox, rathr than just the checkbox, when
2870 the protocol is not POP.
2872 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2874 * src/widgets/modest-account-view.c:
2875 * src/widgets/modest-account-view.h:
2876 Added modest_account_view_select_account() which will be useful later
2877 to asynchronously re-select the edited account.
2879 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2881 * src/maemo/modest-account-settings-dialog.c:
2882 (modest_account_settings_dialog_set_account_name):
2883 Automatically choose the port numbers based on the secure authentication
2884 methods, if they have not been chosen before.
2885 This fixes projects.maemo.org bug NB#56273 .
2887 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2889 * src/maemo/modest-main-window-ui.h:
2890 * src/modest-ui-actions.c:
2891 * src/modest-ui-actions.h:
2892 Connect the Tools/SMTP Servers menu item to
2893 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2894 SMTP servers dialog, as in the UI specification and saves changes when it
2895 is closed. This fixed projects.maemo.org bug NB#56305 .
2897 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2899 * src/maemo/modest-connection-specific-smtp-window.c:
2900 (modest_connection_specific_smtp_window_init):
2901 Use gtk_window_set_default_size() to make this window big enough, so
2902 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2904 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2906 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2907 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2908 (modest_connection_specific_smtp_edit_window_init),
2909 Do not try to connect to a combobox signal before the combobox exists.
2910 This fixes the cras in projects.maemo.org bug NB#56288 .
2911 (modest_connection_specific_smtp_edit_window_get_settings):
2912 Remove the server_account_name parameter which was being checked for NULL
2913 though it was not used.
2915 * src/maemo/modest-connection-specific-smtp-window.c:
2916 (modest_connection_specific_smtp_window_fill_with_connections),
2917 (on_button_edit), (modest_connection_specific_smtp_window_init):
2918 Correct the number of treemodel columns to prevent a warning.
2919 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2920 libconic does not work.
2922 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2924 * src/modest-tny-account.c:
2925 (modest_tny_account_new_from_server_account):
2926 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2927 SMTP when "None" was chosen by the user. However, with my SMTP server that
2928 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2931 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2933 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2934 to explain the memory management issue with the ID in the ModestPair.
2936 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2937 (add_sending_page), (modest_account_assistant_finalize):
2938 * src/gnome/modest-gnome-global-settings-dialog.c:
2939 (create_updating_page), (create_composing_page):
2940 * src/gnome/modest-msg-edit-window.c: (get_transports),
2941 (init_window), (modest_msg_edit_window_finalize),
2942 (modest_msg_edit_window_get_msg_data):
2943 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2944 * src/gnome/modest-transport-widget.c:
2945 (modest_transport_widget_finalize), (smtp_configuration):
2946 * src/maemo/modest-maemo-global-settings-dialog.c:
2947 (create_updating_page), (create_composing_page):
2948 * src/maemo/modest-msg-edit-window.c: (get_transports),
2949 (init_window), (modest_msg_edit_window_finalize),
2950 (modest_msg_edit_window_get_msg_data),
2951 (modest_msg_edit_window_free_msg_data):
2952 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2953 (modest_store_widget_finalize):
2954 * src/maemo/modest-transport-widget.c:
2955 (modest_transport_widget_finalize), (smtp_configuration):
2956 * src/modest-main.c: (send_mail):
2957 * src/widgets/modest-combo-box.h:
2958 * src/widgets/modest-global-settings-dialog-priv.h:
2959 * src/widgets/modest-global-settings-dialog.c:
2960 (modest_global_settings_dialog_finalize):
2961 * src/widgets/modest-msg-edit-window.h:
2962 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2963 as long as the combo box, to prevent use of freed memory for the ID.
2965 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2967 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2968 get_accounts(), to make this clearer. Do not check for the enabled gconf
2969 key, because we do not use this for server accounts (at least, not yet).
2970 This allows us to send email again.
2972 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2974 * src/maemo/modest-platform.c:
2975 (on_modest_conf_update_interval_changed), (modest_platform_init):
2976 Only respond to this particular key change. All these strcmp()s cannot be
2979 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2981 * src/maemo/modest-maemo-global-settings-dialog.c:
2982 (current_connection): Prevent a crash in scratchbox when
2983 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2984 * src/maemo/modest-platform.c:
2985 (on_modest_conf_update_interval_changed), (modest_platform_init):
2986 Get the update interval from gconf and reset it when the gconf key changes.
2988 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2990 * src/modest-protocol-info.c:
2991 * src/modest-protocol-info.h: Adde enum-specific get functions,
2992 instead of using a ModestProtocolType enum parameter.
2994 * src/gnome/modest-account-assistant.c:
2995 * src/gnome/modest-store-widget.c:
2996 * src/gnome/modest-store-widget.h:
2997 * src/gnome/modest-transport-widget.c:
2998 * src/gnome/modest-transport-widget.h:
2999 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3000 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3001 * src/maemo/easysetup/modest-easysetup-wizard.c:
3002 * src/maemo/modest-account-settings-dialog.c:
3003 * src/maemo/modest-account-settings-dialog.h:
3004 * src/maemo/modest-store-widget.c:
3005 * src/maemo/modest-store-widget.h:
3006 * src/maemo/modest-transport-widget.c:
3007 * src/maemo/modest-transport-widget.h:
3008 * src/modest-account-mgr-helpers.c:
3009 * src/modest-account-mgr-helpers.h:
3010 * src/modest-account-mgr.c:
3011 * src/modest-account-mgr.h:
3012 * src/modest-tny-account.c:
3013 * src/modest-tny-folder.c:
3014 * src/widgets/modest-account-view.c:
3015 * src/widgets/modest-retrieve-combo-box.c:
3016 * src/widgets/modest-retrieve-combo-box.h:
3017 * src/widgets/modest-secureauth-combo-box.c:
3018 * src/widgets/modest-serversecurity-combo-box.c:
3019 * src/widgets/modest-serversecurity-combo-box.h:
3020 * tests/check_account-mgr.c:
3021 Use the specific functions, and use the re-renamed enum values for GNOME too.
3023 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3025 * src/modest-pair.h:
3026 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3027 so we can get the second based on the first.
3029 * src/maemo/modest-account-settings-dialog.h:
3030 * src/maemo/modest-account-settings-dialog.c:
3031 Added get_supported_secure_authentication_methods(), though it is mostly
3032 commented-out for now until the necessary API is committed to tinymail.
3033 (modest_account_settings_dialog_set_account_name),
3034 (save_configuration): Request the supported authentication methods from the
3035 server, so we can choose a working method.
3037 * src/modest-tny-account-store.h:
3038 * src/modest-tny-account-store.c:
3039 (modest_tny_account_store_get_session): Rename from
3040 tny_account_store_get_session().
3042 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3044 * src/modest-protocol-info.h: Split the ModestProtocol enum
3045 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3046 There was no need to have these unrelated values in one enum.
3048 * src/: many files: Adapted to changed enum. This makes the code a bit
3049 clearer, and the compiler could catch some errors.
3051 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3053 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3054 Show the detailed internal camel error message when an error happens
3055 during the configuration, so that our testers can give us more clues.
3056 For instance, in projects.maemo.org bug NB#56910 .
3058 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3060 * src/modest-tny-account.c:
3061 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3062 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3064 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3066 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3067 * src/maemo/modest-account-settings-dialog.c:
3068 (modest_account_settings_dialog_set_account_name),
3069 (save_configuration): For the incoming secure authentication checkbox,
3070 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3071 the UI specification. PLAIN does not seem to be supported for most IMAP
3072 servers anyway, and I am not sure what it would mean.
3073 However, we probably need to discover which of the secure-authentication
3074 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3075 * src/modest-account-mgr-helpers.c:
3076 (modest_account_mgr_get_server_account_data):
3078 * src/modest-tny-account.c:
3079 (modest_tny_account_new_from_server_account):
3080 Use tny_account_set_mech() to set secure-authentication methods,
3081 with some special-casing for IMAP, based on my observations of how
3084 * src/modest-account-mgr-helpers.h:
3085 * src/modest-account-mgr.c:
3086 * src/modest-defs.h: Comment that the URI is only used for local folders.
3088 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3090 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3091 parameter const, just to be neat.
3092 * src/modest-text-utils.c: (modest_text_utils_inline):
3093 End g_strconcat() with NULL, as its documentation says. This is almost
3094 certainly the cause of my crash at startup on the device. Interestingly,
3095 valgrind doesn't tell us about these errors.
3097 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3099 * scripts/build-packages: Added more precise comments about how to use
3100 this script, though I still get this error:
3101 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3102 error building tinymail
3104 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3106 * src/maemo/modest-main-window.c: (on_account_update):
3107 Very slight cleanup, hoping to make it simpler to discover what causes
3108 a crash here sometimes.
3110 * src/modest-tny-account.c:
3111 (modest_tny_account_new_from_server_account): Set the port. Added
3112 comments about the options and a TODO comment because I need to find out
3113 how to specify the secure authentication method.
3115 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3117 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3118 changed CFlags paths form modest to libmodest
3120 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3122 * src/modest-account-mgr-helpers.c:
3123 (modest_account_mgr_get_server_account_data),
3124 (modest_account_mgr_free_server_account_data):
3125 * src/modest-account-mgr-helpers.h:
3126 * src/modest-account-mgr.c:
3127 (modest_account_mgr_add_server_account):
3128 * src/modest-defs.h:
3129 * src/modest-tny-account.c:
3130 (modest_tny_account_new_from_server_account):
3131 Determine the options for tny_camel_account_add_option() here,
3132 based on the settings, rather than storing them directly in gconf.
3134 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3136 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3137 Show a more friendly error dialog now that we expect (from the tinymail
3138 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3140 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3142 * src/maemo/modest-main-window.c: (on_account_update): Check that
3143 account_name is not NULL, to prevent a crash at startup that I am
3144 seeing on the N800. I do wonder why it is NULL.
3146 * src/maemo/easysetup/modest-easysetup-wizard.c:
3147 (create_page_user_details):
3148 * src/maemo/modest-account-settings-dialog.c:
3149 (create_page_user_details), (create_page_outgoing):
3150 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3151 (modest_connection_specific_smtp_edit_window_init):
3152 * src/modest-ui-actions.c:
3153 (modest_ui_actions_on_password_requested):
3154 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3155 might do something useful with the on-screen keyboard.
3157 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3159 * src/maemo/modest-main-window.c: (on_account_update):
3160 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3161 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3163 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3165 * src/modest-tny-account-store.c: (on_account_changed):
3166 Correct the signature of this signal handler.
3168 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3170 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3171 Show a HildonNote instead of a GtkDialog for Maemo.
3173 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3175 * src/widgets/modest-account-view.h:
3176 * src/widgets/modest-account-view.c: (on_account_changed),
3177 (on_account_removed). Added a boolean flag, set/unset by
3178 modest_account_view_block_conf_updates(),
3179 modest_account_view_unblock_conf_updates() to prevent unnecessary
3180 updates, but this is not very useful because the gconf notifications are
3181 so delays (maybe only on Maemo Bora).
3182 So auto-updating is turned off, and these functions do an explicit
3183 update when necessary.
3184 However, something else is still doing too much work when adding/removing
3185 accounts, probably in another part of the application.
3187 * src/maemo/modest-account-view-window.c:
3188 (on_delete_button_clicked), (on_edit_button_clicked),
3189 (on_new_button_clicked): Use the new functions.
3191 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3193 * src/modest-account-mgr-helpers.c:
3194 (modest_account_mgr_set_first_account_as_default):
3195 Sort the list of names alphabetically-by-title, so we choose the first one
3197 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3198 alphabetically by the title.
3200 This fixes projects.maemo.org bug NB#56418 .
3202 * src/modest-account-mgr-priv.c:
3203 (_modest_account_mgr_account_from_key):
3204 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3205 avoid a valgrind error, and possible random behaviour.
3207 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3209 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3210 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3211 tinymail documentation to say that this can be expected.
3212 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3213 pretty, and should not happen, but I would prefer to know when it does.
3215 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3217 * configure.ac: When using the older hildon version, probably on Bora,
3218 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3220 * src/widgets/modest-attachment-view.c:
3221 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3224 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3226 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3227 Implemented the prototype. Can be tested with
3228 tests/dbus_api/test_open_message:
3230 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3232 * src/modest-tny-account-store.c:
3233 (modest_tny_account_store_instance_init), (get_password):
3234 * src/modest-ui-actions.c:
3235 (modest_ui_actions_on_password_requested):
3236 Do not store the password in gconf, because this function is called
3237 for non-remembered passwords. Actually use the cached (in the hash map)
3238 password instead of releasing it.
3239 The password will now not be remembered if it is asked via the protected
3240 password dialog, as per the UI spec.
3242 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3244 * src/modest-defs.h:
3245 * src/modest-account-mgr-helpers.h:
3246 * src/modest-account-mgr-helpers.c:
3247 Added modest_server_account_get_username_has_succeeded(),
3248 modest_server_account_set_username_has_succeeded().
3249 (modest_server_account_set_username),
3250 Reset the has-succeeded flag if the username changes.
3252 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3253 * src/maemo/modest-connection-specific-smtp-window.c:
3254 (modest_connection_specific_smtp_window_save_server_accounts):
3255 Use modest_server_account_set_username() instead of using
3256 modest_conf_set_string() directly, so that the has-succeeded flag is always
3259 * src/modest-ui-actions.c:
3260 (modest_ui_actions_on_password_requested): Dim the username entry if
3261 the username has ever worked, as per the UI spec.
3263 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3265 * src/modest-tny-account-store.c: (get_password):
3266 * src/modest-ui-actions.c:
3267 (modest_ui_actions_on_password_requested):
3268 Allow the username to be changed too, though there is more work to
3269 be done on exactly how this behaves.
3271 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3273 * src/modest-account-mgr-helpers.h:
3274 * src/modest-account-mgr-helpers.c:
3275 Added modest_account_mgr_get_display_name(),
3276 modest_server_account_get_username(),
3277 modest_server_account_set_username(),
3278 modest_server_account_set_password(),
3279 modest_server_account_get_hostname() functions so we do not need to
3280 use the conf API directly.
3282 * src/maemo/modest-main-window.c: (connect_signals):
3283 Actually connect ot the ModestAccountStore::request-password signal,
3284 so that we show the dialog when the password is requested by Tinymail,
3285 for isntance if it is empty.
3287 * src/modest-marshal.list:
3288 * src/modest-tny-account-store.c:
3289 (modest_tny_account_store_class_init), (get_password),
3290 (modest_tny_account_store_alert):
3291 * src/modest-tny-account-store.h:
3292 * src/modest-ui-actions.h:
3293 * src/modest-ui-actions.c:
3294 (modest_ui_actions_on_password_requested):
3295 Change the signal parameters, so it is obvious that we are providing
3296 the non human-readable server name, and receiving both the username
3297 and password, though changing of the username is not yet implemented.
3298 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3299 for the GNOME version.
3301 This should fix the projects.maemo.org bug NB#56209, though it does not
3302 work on Bora, because the gconf_client_get() for the password fails
3303 immediately after we save it with gconf_client_set().
3305 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3308 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3309 caused an undefined symbol error:
3310 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3312 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3314 * src/modest-tny-account-store.c:
3315 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3316 using a GError instead of a string message, so we can translate it in
3319 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3321 * src/maemo/modest-address-book.c:
3322 (modest_address_book_check_names):
3323 * src/maemo/modest-msg-view-window.c:
3324 (modest_msg_view_window_clipboard_owner_change):
3325 * src/modest-init.c: (modest_init_init_ui):
3326 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3327 (update_folders_cb), (modest_mail_operation_update_account):
3328 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3329 (modest_ui_actions_on_msg_attachment_clicked),
3330 (modest_ui_actions_on_msg_recpt_activated):
3331 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3332 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3333 (modest_msg_view_search_next):
3334 * src/widgets/modest-recpt-editor.c:
3335 (modest_recpt_editor_on_button_release_event),
3336 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3337 g_message(). At this point we should only be seeing interesting errors on
3338 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3340 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3342 (modest_wizard_dialog_force_title_update):
3343 * src/maemo/easysetup/modest-wizard-dialog.h:
3344 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3345 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3346 can update the title when appropriate. Otherwise the title is wrong if the
3347 pages are added after adding the notebook to the dialog.
3348 This must be a problem in HildonWizardDialog too.
3349 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3351 * src/maemo/easysetup/modest-easysetup-wizard.c:
3352 (create_subsequent_customsetup_pages),
3353 (create_subsequent_easysetup_pages):
3354 Call modest_wizard_dialog_force_title_update() so that the title is
3355 correct even with GTK+ < 2.10.
3356 This fixes projects.maemo.org bug NB#56145 .
3358 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3360 * src/maemo/modest-platform.c:
3361 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3362 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3365 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3367 * src/widgets/modest-window.h:
3368 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3369 and modest_window_save_state(), which invokes it.
3371 * src/widgets/modest-window-mgr.h:
3372 * src/widgets/modest-window-mgr.c:
3373 Added modest_window_mgr_save_state_for_all_windows(), which calls
3374 the save_state vfunc on all registered windows, if implemented.
3376 * src/gnome/modest-msg-edit-window.c:
3377 * src/gnome/modest-msg-view-window.c:
3378 * src/maemo/modest-msg-edit-window.c:
3379 * src/maemo/modest-msg-view-window.c:
3380 * src/maemo/modest-main-window.c:
3381 Specify the existing save_settings functions as implementations of
3382 ModestWindow::save_state_func().
3384 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3385 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3386 enabling hibernation, for instance.
3388 We may need to do the same thing for restoring settings.
3391 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3393 * src/widgets/modest-window-mgr.c:
3394 * src/widgets/modest-window-mgr.h:
3395 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3396 modest_window_mgr_get_hibernation_is_prevented().
3398 * src/maemo/modest-main-window.c:
3399 (on_hildon_program_is_topmost_notify): Prevent hibernation
3400 (possible when the application goes to the background in the WM),
3401 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3403 * src/maemo/easysetup/modest-easysetup-wizard.c:
3404 (modest_easysetup_wizard_dialog_init):
3405 * src/maemo/modest-account-settings-dialog.c:
3406 (modest_account_settings_dialog_init):
3407 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3408 (modest_connection_specific_smtp_edit_window_init):
3409 * src/maemo/modest-connection-specific-smtp-window.c:
3410 (modest_connection_specific_smtp_window_init):
3411 * src/maemo/modest-signature-editor-dialog.c:
3412 (modest_signature_editor_dialog_init):
3413 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3414 prevent hibernation while any of these account settings dialogs are open.
3416 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3418 * src/maemo/Makefile.am:
3419 * src/maemo/modest-osso-state-saving.c:
3420 * src/maemo/modest-osso-state-saving.h: Added
3421 modest_osso_load_state() and modest_osso_save_state() though they do
3422 nothing now. They should iterate through all the open windows and load/save
3424 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3425 save state when closing.
3427 * src/maemo/modest-main-window.c:
3428 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3429 Add a notification handler for the HildonProgram::is-topmost property,
3430 so we can allow hibernation when the application goes into the background.
3431 But we still need to detect when the accounts setup windows are open so
3432 we can stop hibernation when they are open.
3433 To do this, I also added the main window the HildonProgram. This might have
3434 other side-effects/benefits, and should maybe be done for other windows.
3436 * src/maemo/modest-osso-autosave-callbacks.h:
3437 * src/maemo/modest-osso-autosave-callbacks.c:
3438 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3439 though it does not do anything yet, and we might never need this to do
3440 anything. For instance, we already save drafts.
3442 * src/maemo/modest-platform.c: (modest_platform_init):
3443 Specify the libosso auto-save callback.
3445 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3447 * src/maemo/modest-platform.c:
3448 (modest_platform_set_update_interval):
3449 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3450 aparently stays valid between application instances, so we can use this
3451 to remove and reset it later. According to a maemo-developers email from
3454 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3456 * configure.ac: Depend on libalarm for Maemo.
3458 * src/dbus_api/modest-dbus-api.h:
3459 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3460 (on_send_receive), (modest_dbus_req_handler):
3461 Handle a SEND_RECEIVE D-Bus method.
3463 * libmodest-dbus-client/libmodest-dbus-client.c:
3464 (libmodest_dbus_client_send_and_receive):
3465 * libmodest-dbus-client/libmodest-dbus-client.h:
3466 Add C convenience functions for calling the new D-Bus method.
3468 * src/modest-platform.h:
3469 * src/gnome/modest-platform.c:
3470 * src/maemo/modest-platform.c:
3471 Added modest_platform_set_update_interval(), which uses the
3472 alarmd API on Maemo.
3473 (modest_platform_init),
3474 Call modest_platform_set_update_interval(), using a hard-coded
3475 interval for now (until the global settings dialog is implemented),
3476 though I am not sure that this makes sense yet.
3478 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3480 * src/dbus_api/modest-dbus-callbacks.c:
3481 (modest_osso_cb_hw_state_handler):
3482 * src/dbus_api/modest-dbus-callbacks.h:
3483 * src/maemo/modest-platform.c: (modest_platform_init):
3484 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3485 in case this has some effect on the ability for Maemo to ping the
3488 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3490 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3491 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3492 warning. It is probably a logic error, but I need to fix the build.
3494 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3496 * src/modest-account-mgr.h:
3497 * src/modest-account-mgr.c:
3498 (modest_account_mgr_account_names): Add a gboolean enabled_only
3499 parameter, so we can get lists of onlt the enabled accounts.
3501 (modest_account_mgr_add_account),,
3502 (modest_account_mgr_account_with_display_name_exists):
3503 * src/maemo/modest-msg-edit-window.c: (get_transports):
3504 * src/modest-account-mgr-helpers.c:
3505 (modest_account_mgr_set_first_account_as_default):
3506 * src/modest-init.c: (init_default_account_maybe):
3507 * src/modest-tny-account-store.c: (get_accounts):
3508 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3509 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3510 * tests/check_account-mgr.c: (START_TEST):
3511 Provide the extra parameter, as appropriate.
3513 * src/widgets/modest-account-view.c: (update_account_view):
3514 Do not show disabled accounts (meaning that there is no way to
3515 enable/disable accounts in the UI (the feature is not in our UI
3516 specification), so we can use this internally only to mark unfinished
3517 or temporary account data.
3519 * src/maemo/easysetup/modest-easysetup-wizard.c:
3520 (create_account): Add boolean enable parameter, so we can specify FALSE
3521 to create the temporary account.
3522 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3523 (on_before_next): When finishing, when there is a temporary account, just
3525 Also, use a timeout to delay the showing of the dialog until gconf is likely
3526 to return correct information, due to a maemo gconf bug that is fixed in
3527 osso 1.1, but not yet in Bora.
3528 However, the dialog stays on screen after it is destroyed.
3530 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3531 for invalid data when cancelling. Use a hildon note instead of a dialog
3532 to complain about invalid data. Do not show the account-saved note if the
3533 account is disabled (a temporary account that will not really be saved for use
3536 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3538 * src/modest-account-mgr-helpers.h:
3539 * src/modest-account-mgr-helpers.c:
3540 Added modest_account_mgr_unset_default_account(),
3541 Added modest_account_mgr_set_first_account_as_default().
3543 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3544 If it was the default account, unset the default account name.
3546 * src/maemo/modest-account-view-window.c:
3547 (on_delete_button_clicked): If it was the default account,
3548 set the first remaining account as the default instead.
3550 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3551 a NULL account or a NULL default account, to prevent a crash. This should
3552 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3555 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3557 * src/widgets/modest-recpt-editor.c:
3558 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3559 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3560 TODO comment for this. This fixes the build.
3562 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3563 be the best place for it. This will in future update all auto-update accounts,
3564 rather than just the current/default account, when that gconf key exists.
3565 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3566 if there are no accounts, before calling do_send_receive().
3567 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3569 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3570 * src/maemo/modest-main-window-ui.h:
3571 * src/maemo/modest-main-window.c: (on_connection_changed),
3572 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3573 directly, becaue the signal handler does more.
3575 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3577 * src/modest-account-mgr-helpers.c:
3578 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3579 for the case that the account does not exist.
3581 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3582 (equivalent to the modest account name) rather than the tinymail account name
3583 (equivalent to the modest account title - human readable) to get the account data.
3584 Check for null account data to prevent the crash, and add a TODO comment saying that
3585 this needs fixing because it is using the server account name instead of the account name.
3587 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3589 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3590 * src/maemo/modest-account-settings-dialog.c: (show_error),
3592 Use hildon_note_new_information() for informative and error messages,
3593 which seems to be expected for Maemo applications (no documentation that I know of
3594 says this). I am surprised that there is no distinction between info and error
3597 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3599 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3600 it is easy to find where this is used.
3602 * src/maemo/easysetup/modest-easysetup-wizard.c:
3603 (create_page_welcome), (create_page_account_details),
3604 (create_page_user_details), (create_page_complete_easysetup),
3605 (create_page_custom_incoming), (create_page_custom_outgoing),
3606 (create_page_complete_custom):
3607 * src/maemo/modest-account-settings-dialog.c:
3608 (create_page_account_details), (create_page_user_details),
3609 (create_page_incoming), (create_page_outgoing):
3610 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3611 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3612 (modest_connection_specific_smtp_edit_window_init):
3613 * src/maemo/modest-connection-specific-smtp-window.c:
3614 (modest_connection_specific_smtp_window_init):
3615 * src/maemo/modest-signature-editor-dialog.c:
3616 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3617 and scrolling policy as per the Email Application Layout Guide, if I have
3620 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3622 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3623 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3624 which were empty, because these vfuncs have been removed from TnyAccountStore.
3625 This fixes the build.
3627 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3629 * src/maemo/modest-main-window.c:
3630 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3631 showing/hiding it. Added TODO because it probably should not be NULL.
3632 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3633 because unnecessary g_warnings() make degugging difficult.
3635 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3637 * src/maemo/modest-msg-edit-window.c:
3638 (modest_msg_edit_window_select_color),
3639 (modest_msg_edit_window_select_background_color): 2 const corrections and
3640 moving 2 #endifs before closing brackets, to fix the build.
3642 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3644 * src/maemo/easysetup/modest-easysetup-wizard.h:
3645 * src/maemo/easysetup/modest-easysetup-wizard.c:
3646 (modest_easysetup_wizard_dialog_finalize),
3647 (on_button_edit_advanced_settings), (create_page_complete_custom),
3648 (on_response), (create_account):
3649 Implement the Advanced Settings edit button, by saving the account information,
3650 for the Advanded Settings dialog to use directly from gconf, and removing it
3651 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3652 Bug #5533 in the projects.maemo.org bugzilla.
3654 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3656 * src/maemo/modest-msg-view-window.c:
3657 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3658 when opening a message window.
3660 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3662 * src/maemo/easysetup/modest-easysetup-wizard.c:
3663 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3666 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3667 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3668 gconf settings. I probably added more checks than necessary, but that is safer.
3670 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3671 variable to fix the build, but this seems to be used when it is still NULL.
3673 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3675 * src/modest-platform.h:
3676 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3677 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3678 * src/modest-main.c: Implement this function so we can avoid using
3679 maemo-specific API from cross-platform code.
3681 * src/modest-tny-account-store.c:
3682 (get_smtp_specific_transport_account_for_open_connection):
3683 * src/modest-ui-actions.c: (check_for_connection),
3684 (modest_ui_actions_on_item_not_found):
3685 Use modest_platform_connect_and_wait() and put #idefs around other
3686 maemo-specific code, because only maemo currently has a way to
3687 identify connection names.
3689 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3691 * src/modest-tny-account-store.h:
3692 * src/modest-tny-account-store.c:
3693 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3694 the connection-specific SMTP server settings in the configuration.
3696 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3698 * src/maemo/modest-main-window.c: (on_connection_changed),
3700 * src/modest-main.c: (main), (start_ui), (send_mail):
3701 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3702 that is what is intended.
3704 * src/modest-ui-actions.c: (action_send), (action_receive),
3705 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3706 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3707 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3708 SMTP server is used when it is specified.
3710 (modest_ui_actions_on_send_receive):
3711 Check that a connection is open before proceeding.
3712 Receive and then send, instead of vice-versa, as per the specification.
3714 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3716 * src/modest-mail-operation.c:
3717 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3718 though I guess it should be something other than NULL.
3720 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3722 * src/maemo/easysetup/modest-easysetup-wizard.c:
3723 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3724 combo twice, to avoid an g_warning and to make it visible again.
3725 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3726 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3727 (already intended) dereference when detaching, because we then recreate the menu.
3728 But I am not sure why the warning was happening, and it is possible that this is a memory
3731 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3733 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3734 and uri_parse_mailto() utility functions.
3735 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3737 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3739 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3741 * src/dbus_api/modest-dbus-api.h:
3742 * src/dbus_api/modest-dbus-callbacks.c:
3743 Use an idle callback to execute the modest code in the application's own thread.
3744 Remove the helloworld example method.
3745 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3746 parsed, and the open-message method is not implemented because this is not yet implemented in
3748 * libmodest-dbus-client/libmodest-dbus-client.c:
3749 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3750 (libmodest_dbus_client_open_message):
3751 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3753 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3754 body without crashing.
3756 * tests/dbus_api/Makefile.am:
3757 * tests/dbus_api/test_mail_to.c:
3758 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3760 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3762 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3763 Added file to fix the build. Sorry.
3765 * src/dbus_api/Makefile.am:
3766 * src/dbus_api/modest-dbus-api.h:
3767 * src/dbus_api/modest-dbus-callbacks.h:
3768 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3769 (modest_dbus_req_handler):
3770 Put constants in a separate header so it can be reused by the
3771 client library, without duplication
3773 * libmodest-dbus-client/Makefile.am:
3774 * libmodest-dbus-client/libmodest-dbus-client.c:
3775 (libmodest_dbus_client_call_helloworld),
3776 (libmodfest_dbus_client_send_mail),
3777 (libmodfest_dbus_client_mailto),
3778 (libmodfest_dbus_client_open_message):
3779 * libmodest-dbus-client/libmodest-dbus-client.h:
3780 (Partly) Implement a send_mail D-Bus method.
3782 * tests/dbus_api/Makefile.am:
3783 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3784 the send_email D-Bus method.
3786 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3790 * libmodest-dbus-client/Makefile.am:
3791 * libmodest-dbus-client/libmodest-dbus-client.c:
3792 * libmodest-dbus-client/libmodest-dbus-client.h:
3793 * tests/dbus_api/Makefile.am:
3794 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3795 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3797 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3799 * src/maemo/easysetup/modest-easysetup-wizard.c:
3800 (create_page_account_details):
3801 * src/maemo/modest-account-settings-dialog.c:
3802 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3803 widgets, because this might not be the default in future versions of the Maemo GTK+.
3804 However, I can not not get capitalization to work even in a simple test case.
3806 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3808 * src/maemo/easysetup/modest-easysetup-wizard.c:
3809 (create_page_custom_incoming), (create_page_custom_outgoing):
3810 * src/maemo/modest-account-settings-dialog.c:
3811 (create_page_account_details), (create_page_incoming),
3812 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3813 instead of using gtk_check_button_with_label(), so they are aligned like the other
3814 widgets, as per the UI spec.
3816 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3818 * src/maemo/easysetup/modest-easysetup-wizard.c:
3819 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3820 * src/widgets/modest-validating-entry.c:
3821 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3822 Modest prefix instead of an EasySetup prefix.
3824 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3826 * src/widgets/modest-validating-entry.h:
3827 * src/widgets/modest-validating-entry.c: (on_insert_text),
3828 Added easysetup_validating_entry_set_max_func(), used to set a callback
3829 to call when the max number of characters is reached. GtkEntry has a max-length
3830 already but is silent about it.
3832 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3833 (create_page_account_details), (create_page_user_details),
3835 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3836 (create_page_account_details), (create_page_user_details),
3837 (create_page_outgoing):
3838 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3839 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3840 the UI spec, when the user tries to enter more than the max number of characters.
3842 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3844 * src/maemo/easysetup/modest-easysetup-wizard.c:
3845 (create_page_user_details), (create_page_custom_incoming),
3846 (create_page_custom_outgoing):
3847 * src/maemo/modest-account-settings-dialog.c:
3848 (create_page_user_details), (create_page_incoming),
3849 (create_page_outgoing):
3850 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3851 (modest_connection_specific_smtp_edit_window_init):
3852 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3853 not appropriate. Bad Maemo-specific defaults!.
3855 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3857 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3858 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3859 (modest_signature_editor_dialog_set_settings):
3860 Disable the label and textview when the checkbox is disabled, and use the
3861 specified (UI spec) default signature text.
3863 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3865 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3866 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3868 * src/modest-defs.h:
3869 * src/modest-account-mgr-helpers.h:
3870 * src/modest-account-mgr-helpers.c:
3871 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3873 * src/maemo/Makefile.am:
3874 * src/maemo/modest-signature-editor-dialog.c:
3875 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3878 * src/maemo/modest-account-settings-dialog.h:
3879 * src/maemo/modest-account-settings-dialog.c:
3880 (modest_account_settings_dialog_finalize), (on_button_signature),
3881 (save_configuration): Use the new dialog when the Edit button is pressed, and
3882 save the changes if necessary, as per the UI spec.
3884 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3886 * src/maemo/Makefile.am:
3887 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3888 based on maemo-develoers email from Dirk.
3890 * src/maemo/easysetup/modest-easysetup-wizard.c:
3891 (create_page_welcome), (create_page_account_details),
3892 (create_page_user_details), (create_page_complete_easysetup),
3893 (create_page_custom_incoming), (create_page_custom_outgoing),
3894 (create_page_complete_custom),
3895 (modest_easysetup_wizard_dialog_init):
3896 * src/maemo/modest-account-settings-dialog.c:
3897 (create_page_account_details), (create_page_user_details),
3898 (create_page_incoming), (create_page_outgoing),
3899 (modest_account_settings_dialog_init):
3900 * src/maemo/modest-connection-specific-smtp-window.c:
3901 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3903 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3905 * src/maemo/easysetup/modest-easysetup-wizard.c:
3906 (create_page_account_details), (create_page_custom_outgoing),
3907 (create_page_complete_custom):
3908 * src/maemo/modest-account-settings-dialog.c:
3909 (create_page_user_details), (create_page_incoming),
3910 (create_page_outgoing):
3911 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3912 (modest_connection_specific_smtp_edit_window_init):
3913 Use the correct (UI spec) port min/max, and use horizontal separators,
3916 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3918 * src/maemo/easysetup/modest-easysetup-wizard.c:
3919 (set_default_custom_servernames):
3920 * src/maemo/modest-account-settings-dialog.c:
3921 (create_page_incoming), (on_combo_outgoing_security_changed),
3922 (on_combo_incoming_security_changed), (create_page_outgoing),
3923 (modest_account_settings_dialog_set_account_name),
3924 (save_configuration):
3925 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3926 (on_combo_security_changed),
3927 (modest_connection_specific_smtp_edit_window_init),
3928 (modest_connection_specific_smtp_edit_window_set_connection),
3929 (modest_connection_specific_smtp_edit_window_get_settings):
3930 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3933 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3936 * src/maemo/easysetup/modest-easysetup-wizard.c:
3937 (create_page_custom_outgoing), (create_page_complete_custom):
3938 * src/maemo/modest-account-settings-dialog.c:
3939 (create_page_user_details), (create_page_outgoing):
3940 * src/maemo/modest-account-view-window.c: (button_box_new):
3941 Use changed logical IDs as per the most recent UI spec:
3942 mcen_bd_emailsetup_edit -> mcen_bd_edit
3943 mcen_bd_emailsetup_delete -> mcen_bd_delete
3944 mcen_bd_emailsetup_close -> mcen_bd_close
3946 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3950 * src/dbus_api/Makefile.am:
3951 * src/dbus_api/modest-dbus-callbacks.c:
3952 * src/dbus_api/modest-dbus-callbacks.h:
3953 * src/maemo/modest-platform.c: (modest_platform_init):
3954 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3956 * tests/Makefile.am:
3957 * tests/dbus_api/Makefile.am:
3958 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3960 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3962 * src/maemo/modest-account-settings-dialog.c:
3963 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3964 Removed unnecessary includes.
3966 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3968 * src/maemo/easysetup/modest-easysetup-wizard.c:
3969 * src/maemo/modest-account-settings-dialog.c:
3970 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3971 * src/widgets/Makefile.am:
3972 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3973 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3974 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3975 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3976 * src/widgets/modest-secureauth-combo-box.c:
3977 * src/widgets/modest-secureauth-combo-box.h:
3978 * src/widgets/modest-serversecurity-combo-box.c:
3979 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3980 made the GObject names more consistent with the rest of the Modest code.
3982 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3984 * src/maemo/easysetup/Makefile.am:
3985 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3986 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3987 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3988 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3989 * src/maemo/easysetup/modest-easysetup-wizard.c:
3990 * src/maemo/easysetup/modest-validating-entry.c:
3991 * src/maemo/easysetup/modest-validating-entry.h:
3992 * src/maemo/modest-account-settings-dialog.c:
3993 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3994 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3995 widgets/ because they are used outside of easysetup too. After checking in,
3996 svn will allow me to rename them too.
3998 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4000 * src/gnome/modest-msg-edit-window.c:
4001 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4002 linker error, to fix the build on the GNOME platform.
4003 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4004 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4005 ifdefed out to avoid a warning.
4007 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4009 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4010 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4011 some alternative for GTK+ 2.6.
4013 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4015 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4017 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4018 specified for EmailAccountsDialog in UI spec.
4020 * src/maemo/easysetup/modest-easysetup-wizard.c:
4021 * src/maemo/easysetup/modest-easysetup-wizard.h:
4022 * src/maemo/modest-account-settings-dialog.c:
4023 * src/maemo/modest-account-settings-dialog.h:
4024 Reuse a member window widget for the connection-specific SMTP server accounts,
4025 so we can tell it to create/save the accounts only if we actually save changes.
4027 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4028 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4029 (modest_connection_specific_smtp_edit_window_get_settings):
4030 Return a struct instance for temporarily remembering the entered data.
4032 * src/maemo/modest-connection-specific-smtp-window.h:
4033 * src/maemo/modest-connection-specific-smtp-window.c:
4034 (modest_connection_specific_smtp_window_finalize),
4035 (modest_connection_specific_smtp_window_fill_with_connections),
4037 (modest_connection_specific_smtp_window_save_server_accounts),
4038 (update_model_server_names): Do not actually save data until asked,
4039 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4041 (on_selection_changed),
4042 (modest_connection_specific_smtp_window_init): Disable the edit
4043 button when nothing is selected.
4045 * src/modest-account-mgr-helpers.c:
4046 * src/modest-account-mgr-helpers.h:
4047 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4050 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4052 * src/modest-account-mgr-helpers.h:
4053 * src/modest-account-mgr-helpers.c:
4054 (modest_account_mgr_get_unused_account_name),
4055 (modest_account_mgr_get_unused_account_display_name): Added these
4056 utility functions, to avoid code duplication.
4058 * src/maemo/easysetup/modest-easysetup-wizard.c:
4059 (create_page_account_details), (create_account):
4060 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4061 (on_combo_security_changed),
4062 (modest_connection_specific_smtp_edit_window_init),
4063 (modest_connection_specific_smtp_edit_window_save_settings):
4064 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4065 * src/maemo/modest-connection-specific-smtp-window.c:
4066 (modest_connection_specific_smtp_window_finalize),
4067 (modest_connection_specific_smtp_window_fill_with_connections),
4068 (on_button_edit), (modest_connection_specific_smtp_window_init):
4069 * src/maemo/modest-connection-specific-smtp-window.h:
4070 Implementing saving of connection-specific server accounts.
4072 But I need to refactor this so we can save the data for each
4073 possible connection-specific account and only actually create the server accounts
4074 when the easysetup finished, or the OK button is pressed on the account settings
4077 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4079 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4080 (on_combo_security_changed):
4081 (modest_connection_specific_smtp_edit_window_init):
4082 Auto-fill the port number as in the account settings.
4084 (modest_connection_specific_smtp_edit_window_set_connection):
4085 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4086 * src/maemo/modest-connection-specific-smtp-window.c:
4087 (fill_with_connections), (on_button_edit),
4088 (modest_connection_specific_smtp_window_init):
4089 Turn the edit window into a dialog to simplify the code, and
4090 set a WM hint as in a GtkDialog, because only a popup can be on top of
4091 another window in Maemo, and popups usually have no WM decoration.
4093 * src/modest-defs.h:
4094 * src/modest-account-mgr-helpers.c:
4095 (modest_account_mgr_set_connection_specific_smtp),
4096 (modest_account_mgr_remove_connection_specific_smtp),
4097 (modest_account_mgr_get_connection_specific_smtp):
4098 * src/modest-account-mgr-helpers.h: Some functions to write the
4099 connection-specific SMTP server information. Not yet used.
4102 * src/widgets/modest-folder-view.c: (text_cell_data):
4103 Fix a warning about an uninitialized variable.
4104 (on_configuration_key_changed): Put an #ifdef around the use
4105 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4107 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4109 * src/maemo/modest-account-settings-dialog.h:
4110 * src/maemo/modest-account-settings-dialog.c:
4111 Added connect_for_modified() utility function to mark the new modified boolean.
4113 (create_page_account_details), (create_page_user_details),
4114 (create_page_incoming), (create_page_outgoing), (on_response),
4115 (modest_account_settings_dialog_init),
4116 (modest_account_settings_dialog_set_account_name):
4117 Only warn about unsaved changes when there are actually unsaved changes.
4119 * src/modest-account-mgr-helpers.c:
4120 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4121 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4122 to get the data from there in future.
4124 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4126 * src/modest-defs.h:
4128 * src/modest-account-mgr-helpers.h:
4129 * src/modest-account-mgr-helpers.c:
4130 Store the security account setting in a single conf key instead of using
4131 the options list, so that the list is left for just the to-be-removed camel hack,
4132 and because gconf_client_set_list() is failing for some reason.
4134 * src/modest-account-mgr.c:
4135 (modest_account_mgr_add_server_account):
4136 * src/maemo/modest-account-settings-dialog.c:
4137 (modest_account_settings_dialog_set_account_name),
4138 (save_configuration): Use the renamed functions.
4141 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4143 * src/widgets/Makefile.am:
4144 * src/widgets/modest-limit-retrieve-combo-box.c:
4145 * src/widgets/modest-limit-retrieve-combo-box.h:
4146 * src/widgets/modest-retrieve-combo-box.c:
4147 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4148 the account settings dialog.
4150 * src/modest-defs.h:
4151 * src/modest-account-mgr-helpers.h:
4152 * src/modest-account-mgr-helpers.c:
4153 (modest_server_account_get_option_secure_auth),
4154 (modest_server_account_set_option_secure_auth):
4155 * src/modest-account-mgr.c:
4156 (modest_account_mgr_add_server_account):
4157 Use the existing AUTH_MECH conf key for the secure-auth setting,
4158 instead of putting it in the list options, because this was actually used already.
4160 * src/maemo/modest-account-settings-dialog.c:
4161 (create_page_account_details),
4162 (modest_account_settings_dialog_set_account_name),
4163 (save_configuration):
4164 * src/maemo/modest-account-settings-dialog.h:
4165 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4166 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4168 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4170 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4171 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4172 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4174 * src/modest-defs.h:
4175 * src/maemo/modest-account-settings-dialog.c:
4176 (create_page_incoming), (on_combo_outgoing_security_changed),
4177 (on_combo_incoming_security_changed), (create_page_outgoing),
4178 (modest_account_settings_dialog_set_account_name),
4179 (save_configuration): Load/Save the port number, and change it when the
4180 security combo changes, to suitable defaults.
4182 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4184 * src/modest-account-mgr.c:
4185 (modest_account_mgr_add_server_account): Set the security and secure-auth
4186 options, and add a comment saying that the other camel-specific options should be
4189 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4191 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4193 * src/modest-tny-account-store.c: (account_list_free),
4194 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4195 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4198 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4200 * src/modest-protocol-info.c:
4201 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4202 is required by our UI spec. Maybe something in our implementation will use this eventually.
4203 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4204 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4205 instead of the previous 0 placeholder.
4207 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4208 secure-auth settings.
4209 * src/modest-account-mgr-helpers.h:
4210 * src/modest-account-mgr-helpers.c:
4211 (modest_server_account_data_get_option_secure_auth),
4212 (modest_server_account_set_option_secure_auth),
4213 (modest_server_account_data_get_option_security),
4214 (modest_server_account_set_option_security): Added this API for getting and setting the security
4215 and secure-auth settings.
4217 * src/maemo/modest-account-settings-dialog.h:
4218 * src/maemo/modest-account-settings-dialog.c:
4219 (modest_account_settings_dialog_finalize), (check_data),
4220 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4221 about changing titles.
4222 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4223 (save_configuration): Save the security and secure-auth settings.
4225 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4226 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4228 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4230 * src/modest-defs.h:
4231 * src/modest-account-mgr.c:
4232 (modest_account_mgr_add_server_account):
4233 Added and used defines for the options key and value pair strings,
4234 that are used so far, though they do not seem to correspond to anything in our
4235 UI specs or ModestProtocol enum.
4237 * src/modest-account-mgr-helpers.h:
4238 * src/modest-account-mgr-helpers.c:
4239 (compare_option_strings_for_name),
4240 (modest_server_account_data_get_option_value),
4241 (modest_server_account_data_get_option_bool),
4242 (modest_account_mgr_get_server_account_option):
4243 Added helper functions for parsing the options GSList.
4245 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4247 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4248 display name is based on the supplied account name.
4249 * src/modest-account-mgr.c:
4250 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4251 with an inefficient, but good-enough, implementation.
4253 * src/maemo/easysetup/modest-easysetup-wizard.c:
4254 (create_page_account_details), (on_before_next), (create_account):
4255 Check for existing display names rather than (non-user-visible) account names, and just
4256 create and set a unique account name at the end.
4258 * src/maemo/modest-account-settings-dialog.c:
4259 (modest_account_settings_dialog_init),
4260 (modest_account_settings_dialog_set_account_name),
4261 (create_page_incoming): Show the display name, instead of the account name.
4262 (on_response): Do some (not all) extra checks, as in the UI spec.
4263 (save_configuration): Save the display name if it was changed.
4265 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4267 * po/en_GB.po: Added needed logical ID and translation.
4268 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4269 (init_view): Made the is-default column clicking work.
4271 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4274 * src/maemo/easysetup/Makefile.am:
4275 * src/maemo/easysetup/modest-easysetup-wizard.c:
4276 (modest_easysetup_wizard_dialog_init):
4277 * src/maemo/easysetup/provider-data-test.keyfile:
4278 * src/maemo/easysetup/provider-data.keyfile:
4279 Moved the provider data file to the new modest-providers-data package and used it from there.
4281 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4283 * src/modest-local-folder-info.c:
4284 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4285 N_() was already used on the static strings, but this just marks it for translation without
4286 using the translation.
4288 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4290 * src/maemo/modest-account-settings-dialog.c:
4291 (create_page_incoming),
4292 (modest_account_settings_dialog_set_account_name):
4293 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4294 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4295 I will do this if nobody else gets there first.
4297 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4299 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4300 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4301 save the security stuff.
4303 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4305 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4306 Set the email address and user fullname, which I now see must be
4309 * src/maemo/modest-account-settings-dialog.h:
4310 * src/maemo/modest-account-settings-dialog.c:
4312 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4313 leave-on-server and authentication.
4314 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4317 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4320 * src/maemo/modest-account-settings-dialog.c:
4321 * src/maemo/modest-account-settings-dialog.h:
4322 Most (but not all) of the widgets are now present as specified by the UI spec.
4323 No changes are yet saved, and some details are not properly shown yet.
4325 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4327 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4329 * src/maemo/Makefile.am:
4330 * src/maemo/modest-account-settings-dialog.c:
4331 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4332 an existing account. Doesn't do much yet.
4334 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4335 Open the accounts settings dialog when Edit is clicked.
4337 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4339 * src/maemo/easysetup/Makefile.am:
4340 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4342 * src/maemo/easysetup/modest-easysetup-wizard.c:
4343 (modest_easysetup_wizard_dialog_init):
4344 Try to get the source directory from the build system,
4345 instead of hard-coding "./" into the source code, when opening our local
4346 copies of the configuration files.
4347 But this still fails when opening the wizard from the Accounts window,
4348 maybe because the working directory seems to change at runtime.
4349 So the wizard will fail the second time unless you copy the files into their
4350 proper locations - see the stdout warnings for the paths.
4352 (create_page_account_details),(on_before_next):
4353 Check for existing non-server accounts instead of server accounts,
4354 so the default account name is useful again, and to prevent trying to
4357 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4358 Show the wizard when New is clicked.
4360 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4361 (init_view): Show the column headers, and show the columns that are
4362 specified in the UI specs. However, something in Maemo's GTK+ prevents
4363 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4364 change the default account. This is despite unsetting the special properties.
4366 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4368 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4369 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4370 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4371 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4372 to make that clearer.
4373 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4375 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4377 * src/maemo/modest-account-view-window.c:
4378 (modest_account_view_window_init),
4379 (modest_account_view_window_new):
4380 Use the same buttons as specified in the
4381 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4382 the existing widgets, which never had a chance of working.
4383 Put the ModestAccountView treeview in a scrolled window.
4384 Do not repeat the initialization in both _init() and _new().
4386 * src/widgets/modest-account-view.c: (update_account_view):
4387 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4388 this widget and window shows no accounts.
4390 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4392 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4394 * src/maemo/easysetup/modest-easysetup-wizard.c:
4395 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4396 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4397 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4400 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4401 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4402 accounts exist yet, as in the UI spec.
4404 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4406 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4408 * src/maemo/Makefile.am:
4409 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4410 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4411 New window for editing connection-specific smtp details.
4412 Not fully implemented.
4414 * src/maemo/modest-connection-specific-smtp-window.c:
4415 (modest_connection_specific_smtp_window_finalize) :
4416 unref the tree model.
4417 (on_button_edit): Show the edit window.
4419 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4421 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4424 * src/maemo/Makefile.am:
4425 * src/maemo/modest-connection-specific-smtp-window.c:
4426 * src/maemo/modest-connection-specific-smtp-window.h:
4427 New window for showing the list of connections, for connection-specific
4428 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4429 * src/maemo/easysetup/modest-easysetup-wizard.c:
4430 (create_page_custom_outgoing): Show the new window when the button is clicked.
4432 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4434 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4435 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4436 * src/maemo/modest-msg-edit-window.c:
4437 (modest_msg_edit_window_insert_image):
4438 * src/modest-conf.c: (modest_conf_key_escape):
4439 * src/modest-mail-operation.c:
4440 (modest_mail_operation_send_new_mail):
4441 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4442 (modest_ui_actions_on_new_account):
4443 * src/widgets/modest-attachment-view.c: (update_filename_request):
4444 * src/widgets/modest-mail-header-view.c:
4445 Corrected warnings that were breaking the build, by commenting out unused variables,
4446 and a function, and by including a header.
4448 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4450 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4451 so we can #ifdef around platform-specific code when necessary.
4452 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4453 to allow this to build for the GNOME platform too.
4455 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4457 * src/maemo/easysetup/modest-easysetup-wizard.c:
4458 Added util_increment_name() and used it in create_page_account_details()
4459 to make sure that the default account name is always a new name.
4461 (modest_easysetup_wizard_dialog_init),
4462 (set_default_custom_servernames): Some minor memory management fixes.
4464 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4468 * src/modest-runtime.c: (init_i18n): Restored the translation
4469 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4470 are defined in config.h, and the translations are installed.
4472 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4473 is defined for translation.
4475 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4477 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4479 * src/maemo/easysetup/modest-easysetup-wizard.c:
4480 (modest_easysetup_wizard_dialog_init):
4481 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4482 Use realistic paths (though they should use $prefix generically) to the
4483 mcc_mapping and provider-data.keyfile files which might work when they
4484 are installed by the future version of the operator-wizard package,
4485 and then fallback to paths in our source code, with an explanatory
4488 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4492 * src/maemo/Makefile.am:
4493 * src/maemo/easysetup/: Added files from the previously-exernal
4494 osso-modest-easysetup.
4495 * src/maemo/modest-main-window-ui.h:
4496 * src/modest-ui-actions.c:
4497 * src/modest-ui-actions.h:
4498 Added modest_ui_actions_on_new_account() as a signal handler for the
4499 New Account menu item. It shows the easysetup wizard.
4500 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob