1 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c:
4 (check_for_supported_auth_methods), (on_before_next),
7 More correct fix for projects.maemo.org bug NB# 58991
8 Do not longer accept AUTH_PASSWORD as secure method and choose
9 correct method when creating the account.
11 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
13 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
14 Fixed projects.maemo.org bug NB# 58991
16 2007-06-13 Murray Cumming <murrayc@murrayc.com>
18 * src/modest-init.c: (modest_init_init_core),
19 (modest_init_local_folders): Fixed compilation errors.
21 2007-06-13 Murray Cumming <murrayc@murrayc.com>
23 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
24 Remove unnecessary lib/include, though it is good in principle when needed.
26 * src/modest-init.c: (modest_init_one_local_folder),
27 (modest_init_local_folders):
28 * src/modest-init.h: Initialize the .modest library for memory cards,
29 instead of just doing nothing for them. This should allow us to create
30 folders there, fixing projects.maemo.org bug NB#59297.
32 2007-06-13 Murray Cumming <murrayc@murrayc.com>
34 * libmodest-dbus-client/libmodest-dbus-client.c:
35 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
36 (libmodest_dbus_client_compose_mail),
37 (libmodest_dbus_client_open_message),
38 (libmodest_dbus_client_send_and_receive),
39 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
41 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
42 (on_idle_open_message), (modest_dbus_req_handler),
43 (search_result_to_message), (modest_dbus_req_filter):
44 * src/modest-search.c: (add_hit), (modest_search_folder),
45 (modest_search_all_accounts): Improved debug messages.
47 * tests/dbus_api/test_open_message.c: (main): Improved comments.
49 * src/modest-tny-account-store.c:
50 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
53 2007-06-13 Murray Cumming <murrayc@murrayc.com>
56 2007-06-12 Murray Cumming <murrayc@murrayc.com>
58 * src/modest-tny-account-store.c: (get_server_accounts):
59 Call modest_tny_local_folders_account_add_merged_outbox_folders()
60 even when there are no accounts, so that the Outbox folder is always
61 visible. This fixes projects.maemo.org bug NB#60158.
63 2007-06-12 Murray Cumming <murrayc@murrayc.com>
65 * src/maemo/modest-main-window.c: (create_details_widget):
66 Use the mcen_va_never logical ID.
68 2007-06-12 Murray Cumming <murrayc@murrayc.com>
70 * src/dbus_api/modest-dbus-api.h:
71 * src/dbus_api/modest-dbus-callbacks.c:
72 (on_idle_open_default_inbox), (on_open_default_inbox),
73 (modest_dbus_req_handler):
74 Added a new OpenDefaultInbox method.
76 * libmodest-dbus-client/libmodest-dbus-client.h:
77 * libmodest-dbus-client/libmodest-dbus-client.c:
78 Added libmodest_dbus_client_open_default_inbox() to call the new
79 dbus method. This should be useful to projects.maemo.org bug NB#57214,
80 though it should maybe be used by a new osso-email-interface function.
82 * tests/dbus_api/Makefile.am:
83 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
86 2007-06-12 Murray Cumming <murrayc@murrayc.com>
88 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
89 NULL, so that the signals get all the keys. This should not actually
90 change any behaviour because we currently update everything when anything
93 2007-06-12 Murray Cumming <murrayc@murrayc.com>
95 * src/widgets/modest-folder-view.c: (text_cell_data),
96 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
97 (find_inbox_iter): If tinymail tells us that the folder is
98 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
99 This causes the inbox to be selected at startup, fixing part of
100 projects.maemo.org bug NB#56305.
102 * src/modest-ui-dimming-rules.c:
103 (modest_ui_dimming_rules_on_tools_smtp_servers):
104 * src/modest-ui-dimming-rules.h: Added a callback function to dim
105 the SMTP servers menu item.
106 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
107 that the SMTP Servers menu item is dimmed when there are no accounts,
108 as a future version of the UI spec will require. This fixes
109 projects.maemo.org bug NB#56305.
111 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
113 * src/maemo/modest-maemo-utils.c:
114 (modest_maemo_utils_get_supported_secure_authentication_methods):
115 Added label to dialog instead of unreadable title
117 * src/maemo/modest-main-window.c: (sync_accounts_cb),
118 (modest_main_window_new):
119 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
122 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
123 * src/modest-account-mgr.h:
124 Added method to avoid code duplication
126 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
127 (modest_ui_actions_on_send_receive):
128 Use modest_account_mgr_has_accounts
130 2007-06-11 Murray Cumming <murrayc@murrayc.com>
132 * src/maemo/easysetup/modest-presets.c:
133 (modest_presets_get_info_server_security): Do not report secure auth
135 * src/modest-protocol-info.c: Use the defines for the gconf key names
136 for secure authentication. This was not working because we were writing
137 Password and reading password, and the check was case sensitive.
138 With this, gmail now works for receiving and sending when created via
141 2007-06-11 Murray Cumming <murrayc@murrayc.com>
143 * src/maemo/easysetup/modest-presets.c:
144 (modest_presets_get_info_server_security): Correct the key name for
145 SecureSmtp, because it seems to be case-sensitive.
146 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
147 Do not try to get the 0th notebook page if there are 0 pages, to
150 2007-06-11 Murray Cumming <murrayc@murrayc.com>
152 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
153 Prevent use of the new notification feature for now, because it currently
154 shows one dialog for each new email, which is annoying.
156 2007-06-11 Murray Cumming <murrayc@murrayc.com>
158 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
159 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
160 when no country was selected, so that we show the global ones.
161 * src/maemo/easysetup/modest-presets.c:
162 (modest_presets_get_providers): Return only the global providers, not
163 all providers when mmc=0 was requested.
165 2007-06-11 Murray Cumming <murrayc@murrayc.com>
167 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
168 (easysetup_provider_combo_box_fill): Remove debug code that showed the
169 provider ID in the combo.
171 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
172 Do not show the page numbers, because it would be confusing when we add
173 the 2 extra pages for the custom setup, when the user chooses the "Other"
174 provider. This fixes projects.maemo.org bug NB#59028
176 * src/modest-init.c: (modest_init_init_core),
177 (modest_init_local_folders):
179 * src/modest-tny-account.c:
180 (modest_tny_account_new_for_local_folders): Do not create default folders
181 for the memory card. This should fix projects.maemo.org bug NB#59328.
183 2007-06-11 Murray Cumming <murrayc@murrayc.com>
185 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
186 Free the changed_conf_keys string items. They are already freed in the
187 idle handler if that runs first.
189 2007-06-11 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-ui-actions.c:
192 (modest_ui_actions_on_password_requested): Check that the server name
193 is not NULL, because I just saw a password dialog with (null) as the
196 * src/modest-tny-folder.[h|c]: Added
197 modest_tny_folder_is_memory_card_folder().
198 * src/modest-ui-dimming-rules.c:
199 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
200 menu item for memory cards, as per the UI spec (section 7.4). This should
201 fix projects.maemo.org bug NB#59297.
203 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
205 * src/maemo/modest-main-window.c: (sync_accounts_cb):
206 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
207 is another problem with the code, see Murray's comment at line 772)
209 2007-06-08 Murray Cumming <murrayc@murrayc.com>
211 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
212 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
213 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
214 (load_from_file), (easysetup_country_combo_box_init),
215 (easysetup_country_combo_box_get_active_country_ids),
216 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
217 instead of just one ID, to avoid duplicate country names in the UI.
219 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
220 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
221 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
222 a single ID, avoiding duplicate providers.
223 * src/maemo/easysetup/modest-easysetup-wizard.c:
224 (on_combo_account_country): Adapt to use a list.
226 2007-06-08 Murray Cumming <murrayc@murrayc.com>
228 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
229 keys changed in the last X seconds.
231 * src/modest-account-mgr.h:
232 * src/modest-account-mgr.c: (on_timeout_notify_changes),
233 (on_key_change), (modest_account_mgr_class_init),
234 (modest_account_mgr_init), (modest_account_mgr_finalize):
235 As the keys are changed, save them in a GSList* and signal that GSList*
236 further every X seconds, to batch changes, to allow us to do just one
237 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
238 bug NB#56941 and other (UI-blocking) delays when changing account settings.
240 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
241 changed signal signature.
243 * src/modest-conf.c: (modest_conf_set_list),
244 (modest_conf_on_change): Reenable notification.
246 (modest_conf_maemo_fake_on_change): Comment out the hack that
247 notified immediately instead of asynchronously.
249 * src/widgets/modest-account-view.h:
250 * src/widgets/modest-account-view.c:
251 (update_account_view): Select the previously-selected account ID,
252 if possible. This fixes projects.maemo.org bug NB#56933.
254 (on_account_changed), (on_account_removed),
255 (modest_account_view_select_account):
257 Remove the block/unblock functions
258 because they were not useful.
260 * src/maemo/modest-account-view-window.c:
261 (on_delete_button_clicked), (on_edit_button_clicked),
262 (on_new_button_clicked): Remove the use of the non-working block/unblock.
264 2007-06-08 Murray Cumming <murrayc@murrayc.com>
266 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
267 Improve the error dialog to show Incorrect Account Settings, which seems
268 clearer, and say that the internal error message (to be removed from the
269 dialog later) is often misleading.
270 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
272 * src/modest-tny-account.c:
273 (modest_tny_account_new_from_server_account): Uncomment the printf of the
274 URL because this is so useful for debugging on the device.
276 * src/widgets/modest-serversecurity-combo-box.c:
277 (modest_serversecurity_combo_box_fill): Correct a logical ID.
279 2007-06-08 Murray Cumming <murrayc@murrayc.com>
281 * src/modest-mail-operation.c:
282 (modest_mail_operation_send_new_mail):
283 Added a comment about a nasty but apparently harmless message. Details
284 added to the wiki g_warnings() page.
286 2007-06-08 Murray Cumming <murrayc@murrayc.com>
288 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
289 (modest_tny_send_queue_class_init):
290 Do not use the priv struct because it is empty, to avoid g_warnings
291 about a non-existant priv struct.
293 * src/modest-tny-account-store.c:
294 (modest_tny_account_store_get_server_account),
295 (modest_tny_account_store_get_transport_account_for_open_connection
296 ): Do not try to get transport server accounts for local folders,
297 because they don't have any. This avoids a g_warning().
299 * src/maemo/modest-main-window.c:
300 (modest_main_window_notify_send_receive_initied),
301 (on_configuration_key_changed):
302 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
304 * src/modest-mail-operation.c:
305 (modest_mail_operation_update_account):
306 * src/modest-tny-account-store.h:
307 * src/modest-tny-account.c:
308 (modest_tny_account_get_special_folder),
309 (modest_tny_account_new_for_local_folders),
310 (modest_tny_account_new_for_per_account_local_outbox_folder):
311 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
312 * src/modest-tny-local-folders-account.c:
313 (add_account_folders_to_merged_folder):
314 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
315 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
316 (modest_ui_actions_on_send):
317 * src/widgets/modest-folder-view.c: (update_model):
318 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
319 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
320 modest_tny_account_store_get_tny_account_by_account() to
321 modest_tny_account_store_get_server_account() to make the code clearer.
323 2007-06-07 Marcus Bauer <marcusb@openismus.com>
325 * src/dbus_api/modest-dbus-api.h:
326 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
327 * src/maemo/modest-msg-edit-window.c:
328 (modest_msg_edit_window_attach_file_noninteractive):
329 added g_warning in case the file to be attached does not exist
330 * tests/dbus_api/test_compose_mail.c: (main):
331 removed obsolete comment, added generic files as test case
333 2007-06-07 Murray Cumming <murrayc@murrayc.com>
335 * src/modest-tny-account-store.c: (get_server_accounts):
336 Create the local folders account only once, not once for each outbox, and
337 not only when there are some outboxes.
339 2007-06-07 Murray Cumming <murrayc@murrayc.com>
341 * src/widgets/modest-folder-view.c: (update_model): Comment out some
342 code that is causing a crash at startup. Sergio says that he is fixing this.
344 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
346 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
347 * src/maemo/modest-account-settings-dialog.c:
348 (create_page_outgoing),
349 (modest_account_settings_dialog_set_account_name),
350 (save_configuration):
351 - Fixed handling of the "Use secure authentication" toggle to comply with
352 the ui specification. See also projects.maemo.org bug NB#58400
354 - Restore the Secure connection setting combo correctly when loading
357 * src/maemo/modest-maemo-utils.c:
358 (on_camel_account_get_supported_secure_authentication),
359 (modest_maemo_utils_get_supported_secure_authentication_methods):
360 Fixed a crasher if operation is canceled
362 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
363 (modest_protocol_info_auth_is_secure):
364 * src/modest-protocol-info.h:
366 Added two new methods to determine if a protocol/auth method is secure/encrypted in
367 the sense of the "Use secure authentication" toggle.
369 2007-06-07 Murray Cumming <murrayc@murrayc.com>
371 * src/modest-tny-account-store.h:
372 * src/modest-tny-account-store.c:
373 Added modest_tny_account_store_get_local_folders_account().
375 * src/modest-tny-folder.h:
376 * src/modest-tny-folder.c:
377 (modest_tny_folder_get_account):
378 Added this replacement for tny_folder_get_account() which returns
379 the local-folders account for TnyMergeFolders, to avoid the
380 warning about the unimplemented get_account_func() vfunc().
382 (modest_tny_folder_get_rules),
383 * src/modest-ui-actions.c:
384 (modest_ui_actions_on_folder_selection_changed):
385 * src/modest-mail-operation.c:
386 (modest_mail_operation_remove_folder),
387 (modest_mail_operation_xfer_folder),
388 (modest_mail_operation_rename_folder),
389 (modest_mail_operation_get_msg),
390 (modest_mail_operation_get_msgs_full),
391 (modest_mail_operation_remove_msg),
392 (modest_mail_operation_xfer_msgs),
393 (modest_mail_operation_refresh_folder):
394 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
396 2007-06-07 Murray Cumming <murrayc@murrayc.com>
398 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
399 (modest_server_account_set_security):
400 * src/modest-defs.h: Add comments explaining that our
401 UI spec means TLS when it says Normal, so these do not look like errors.
403 * src/modest-tny-account.c:
404 (modest_tny_account_new_from_server_account): Use the new tinymail
405 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
406 for TLS. This should fix projects.maemo.org bug NB#58460.
408 2007-06-06 Murray Cumming <murrayc@murrayc.com>
410 * src/maemo/easysetup/modest-easysetup-wizard.c:
411 (create_account): Correct the position of the gconf sanity check warning.
412 (on_button_edit_advanced_settings): Show the dialog immediately, instead
413 of using the g_idle_add() hack, because this does not seem to be necessary
414 on osso 1.1. It might even work on Maemo Bora if the problems were actually
415 caused by something other than maemo's gconf.
416 This fixes projects.maemo.org bug #59022.
418 2007-06-06 Murray Cumming <murrayc@murrayc.com>
420 * src/modest-account-mgr-helpers.c:
421 (modest_account_mgr_get_default_account): Do not check that the account
422 exists if there is no default account (NULL), to fix a runtime warning.
424 2007-06-06 Murray Cumming <murrayc@murrayc.com>
426 * src/widgets/modest-folder-view.c: (update_model):
427 Do not unref the treemodel before we have finished with it.
428 This prevents a valgrind warning and an occasional crash at startup.
430 2007-06-06 Marcus Bauer <marcusb@openismus.com>
432 * libmodest-dbus-client/libmodest-dbus-client.h:
433 added libmodest_dbus_client_compose_mail()
434 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
436 added functions needed for SendAsMail() functionality
437 * src/maemo/modest-msg-edit-window.c:
438 (modest_msg_edit_window_attach_file_noninteractive):
439 non interactively attaching files to message edit window
440 * src/widgets/modest-msg-edit-window.h:
441 * tests/dbus_api/Makefile.am:
442 added test_compose_mail.c
443 * tests/dbus_api/test_compose_mail.c: (main):
445 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
447 * src/modest-account-view.c:
448 Fixed bug projects.maemo.org bug NB#59307
450 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
452 * src/maemo/easysetup/modest-easysetup-wizard.c:
453 (get_serverport_incoming), (on_before_next), (create_account):
454 * src/maemo/modest-account-settings-dialog.c:
455 (modest_account_settings_dialog_set_account_name):
456 * src/maemo/modest-maemo-utils.c:
457 (on_camel_account_get_supported_secure_authentication_status),
458 (on_camel_account_get_supported_secure_authentication),
459 (on_secure_auth_cancel),
460 (modest_maemo_utils_get_supported_secure_authentication_methods):
462 Implemented security authentication for settings and easysetup.
464 2007-06-05 Murray Cumming <murrayc@murrayc.com>
466 * src/maemo/modest-main-window.c: (create_details_widget):
467 Show the total size for memory card accounts too, instead of showing
468 the name again. Fixes bug projects.maemo.org bug NB#59307.
470 2007-06-05 Murray Cumming <murrayc@murrayc.com>
473 * src/modest-tny-simple-folder-store.c:
474 * src/modest-tny-simple-folder-store.h: Removed.
476 * src/modest-tny-local-folders-account.h
477 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
478 for the local-folders maildir, with an extra TnyMergedFolder containing
479 the folders of the per-account outbox store accounts.
480 * src/modest-tny-account-store.c: (get_server_accounts):
481 Add the outboxes to the special local folders account after creating it.
483 * src/modest-tny-account.c:
484 (modest_tny_account_new_for_local_folders): Create the derived
485 account when creating the main local-folders account.
487 * src/maemo/modest-main-window.c: (create_details_widget),
488 (modest_main_window_set_contents_style):
489 Adapted to the use of the derived account instead of the folder store.
491 * src/modest-ui-actions.c:
492 (modest_ui_actions_on_folder_selection_changed):
493 * src/modest-ui-dimming-rules.c:
494 (modest_ui_dimming_rules_on_new_folder):
495 * src/widgets/modest-folder-view.c: (text_cell_data),
496 (icon_cell_data), (filter_row), (update_model),
497 (get_cmp_rows_type_pos):
500 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
501 Do not get the priv struct, because no priv struct has been set,
502 to avoid a runtime warning.
504 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
505 #ifelse with #else, to fix a warning, to fix the build.
508 2007-06-05 Christian Kellner <ckellner@openismus.com>
510 * libmodest-dbus-client/libmodest-dbus-client.c:
511 Fix small typo in doc (why do you always see them
512 AFTER committing stuff?)
515 2007-06-05 Christian Kellner <ckellner@openismus.com>
517 * libmodest-dbus-client/libmodest-dbus-client.c:
518 (libmodest_dbus_client_search):
519 Initialize hit list with NULL. Also set folder list
520 to "" if NULL was supplied.
523 2007-06-03 Christian Kellner <ckellner@openismus.com>
525 * libmodest-dbus-client/libmodest-dbus-client.c:
526 (modest_search_hit_list_free):
527 Make it save to call it with NULL.
529 * src/dbus_api/modest-dbus-callbacks.c:
530 * src/modest-search.c:
531 Return full ModestSearchHits as the search result list not TnyHeader
532 since can't be around withouth the correspoding TnyFolder.
534 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
536 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
537 Added currently commented code to check for secure auth
539 * src/maemo/modest-account-settings-dialog.c: (on_response),
540 (save_configuration), (show_ok):
541 Fixed projects.maemo.org bugs NB #59248 and #59251
543 * src/maemo/modest-maemo-utils.c:
544 (on_camel_account_get_supported_secure_authentication_status),
545 (on_camel_account_get_supported_secure_authentication),
546 (modest_maemo_utils_get_supported_secure_authentication_methods):
547 * src/maemo/modest-maemo-utils.h:
548 Moved get_supported_secure_authentication() method here to be able
549 to use it from easysetup wizard.
551 * src/modest-pair.c: (on_pair_compare_as_string):
552 Should compare string with first part of pair and not
553 strcmp pairs which will crash.
555 * src/modest-protocol-info.c:
556 (modest_protocol_info_protocol_is_store):
557 * src/modest-protocol-info.h:
558 Added modest_protocol_info_get_auth_protocol_name()
560 2007-06-03 Armin Burgmeier <armin@openismus.com>
562 * src/modest-mail-operation.c:
563 (modest_mail_operation_get_msgs_full): Set priv->account also when
564 only retrieving a single message. This avoids a crash when canceling
567 (modest_mail_operation_notify_end): Do not explicitely remove the
568 operation from the queue but only emit the progress_changed signal.
569 The queue itself listens to that signal to remove the operation when
570 it is finished. This reduces coupling and removes a potential deadlock
571 when modest_mail_operation_notify_end() is called from the queue
572 itself. If that is a problem performance-wise, I would suggest to
573 implement a status-changed signal or something.
575 * src/modest-mail-operation-queue.c: Make sure to never call a
576 function from another file while the queue is locked. This (hopefully)
577 fixes another deadlock when exiting the application while retrieving
580 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
582 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
583 Fixed build if libogs is not available
585 2007-06-03 Christian Kellner <ckellner@openismus.com>
587 * libmodest-dbus-client/libmodest-dbus-client.h:
588 * libmodest-dbus-client/libmodest-dbus-client.c:
589 (libmodest_dbus_client_delete_message):
590 Implement deletion of messages (Client side).
592 (modest_search_hit_free),
593 (modest_search_hit_list_free):
594 Utility functions to free the result hits.
596 * src/dbus_api/modest-dbus-api.h:
597 * src/dbus_api/modest-dbus-callbacks.c:
599 (modest_dbus_req_handler):
600 Implement deletion of messages (Server side).
602 * tests/dbus_api/test_search.c: (main):
605 * tests/dbus_api/Makefile.am:
606 * tests/dbus_api/test_delete_message:
607 Add little test for the message deletion logic
609 2007-06-03 Armin Burgmeier <armin@openismus.com>
611 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
612 when the operation queue was not empty. projects.maemo.org bug
615 2007-06-03 Armin Burgmeier <armin@openismus.com>
617 * src/widgets/modest-account-view.c
618 (on_account_default_toggled): Toggle default account column
619 explicitely instead of waiting for gconf notification (which is
620 currently ignored). This should fix projects.maemo.org bug NB#56910
621 for now. It should probably be removed when gconf notifications are
624 2007-06-03 Christian Kellner <ckellner@openismus.com>
626 * libmodest-dbus-client/libmodest-dbus-client.c:
627 Removed debugging spew.
629 * src/dbus_api/modest-dbus-callbacks.c:
630 Added debugging info.
632 * src/modest-search.c:
633 (modest_search_all_accounts):
634 Use tny_account_store_get_accounts () on the account store
635 to get all accounts which is the way to get all accounts.
637 * tests/dbus_api/test_search.c: (main):
638 Make it possible to supply the search term on the command line.
640 2007-06-03 Christian Kellner <ckellner@openismus.com>
642 * libmodest-dbus-client/libmodest-dbus-client.c:
643 * libmodest-dbus-client/libmodest-dbus-client.h:
644 Implement searching for mesages over raw dbus. (Client side)
646 * src/dbus_api/Makefile.am:
647 * src/dbus_api/modest-dbus-api.h:
648 * src/dbus_api/modest-dbus-callbacks.c:
649 * src/dbus_api/modest-dbus-callbacks.h:
650 Search framework (Server side). Also implement on_idle_open_message().
652 * src/maemo/modest-platform.c: (modest_platform_init):
653 Prepare for raw dbus/osso rpc interaction.
655 * src/modest-search.h:
656 Changed minsize from unspecific guint to guint32.
658 * src/modest-search.c:
660 Added strange hack which magically made tnymail work.
662 (modest_search_folder),
663 (modest_search_account),
664 (modest_search_all_accounts):
665 Implement helper functions to search all accounts, specific account
668 * tests/dbus_api/Makefile.am:
669 * tests/dbus_api/test_open_message.c:
670 Read url to open from commandline.
672 * tests/dbus_api/test_search.c:
673 Implement small test for dbus search stuff
675 2007-06-02 Armin Burgmeier <armin@openismus.com>
677 * src/maemo/modest-account-settings-dialog.c: Changed window title to
678 include account type and account title. This fixes projects.maemo.org
681 * src/maemo/modest-account-view-window.c: Set a title for the window.
683 2007-06-02 Armin Burgmeier <armin@openismus.com>
685 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
686 incoming and outgoing server name based on email address and server
687 types as long as the names have not been edited manually. This fixes
688 projects.maemo.org bug NB#58671.
690 2007-06-02 Armin Burgmeier <armin@openismus.com>
692 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
693 server type cannot be changed in future to the incoming details page
694 when creating an account. This fixes projects.maemo.org bug NB#59029.
696 2007-06-02 Armin Burgmeier <armin@openismus.com>
698 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
699 and assigned max width chars so that they wrap instead of being
700 truncated. Fixes projects.maemo.org bug NB#56126.
702 2007-06-02 Armin Burgmeier <armin@openismus.com>
704 * src/maemo/modest-connection-specific-smtp-window.c: Add an
705 introductory note to the connection specific smtp servers dialog, as
706 section 8.12 of the email UI specification requires. This fixes
707 projects.maemo.org bug NB#59212.
709 2007-06-01 Murray Cumming <murrayc@murrayc.com>
711 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
712 Check for running mail operations, and offer to cancel them, as per the UI
713 spec. This fixes projects.maemo.org bug NB#59041 .
714 However, I suspect that tinymail may still use the network connection
715 in ways that we cannot detect or cancel. But it should at least adapt to
718 2007-06-01 Murray Cumming <murrayc@murrayc.com>
720 * src/modest-tny-account-store.c: (recreate_all_accounts),
721 (get_cached_accounts), (get_server_accounts): Do more sensible
722 ref-counting of the temporarily-cached outbox accounts list. This seems
723 to fix a crash when entering the password when the password was wrong.
725 2007-06-01 Murray Cumming <murrayc@murrayc.com>
727 * src/gnome/modest-main-window.c: (connect_signals):
728 * src/modest-tny-account-store.c: (get_password),
729 (modest_tny_account_store_alert): Added comments and clues and
730 commented-out code about how we currently fail to deal with connection
731 errors and wrong passwords, and how we should.
733 2007-06-01 Murray Cumming <murrayc@murrayc.com>
735 * src/widgets/modest-retrieve-combo-box.c:
736 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
737 This fixes projects.maemo.org bug NB#58472 .
739 2007-06-01 Murray Cumming <murrayc@murrayc.com>
741 * src/maemo/easysetup/modest-easysetup-wizard.c:
742 (create_page_complete_easysetup):
743 (create_page_complete_custom): Correct the last commit,
744 putting the correct sentences in the correct pages.
746 2007-06-01 Murray Cumming <murrayc@murrayc.com>
748 * src/maemo/easysetup/modest-easysetup-wizard.c:
749 (create_page_complete_custom): Show the second sentence of text
750 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
753 2007-06-01 Murray Cumming <murrayc@murrayc.com>
755 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
756 Set the leave-on-server conf key by default. This fixes
757 projects.maemo.org bug NB#59258 .
759 2007-06-01 Murray Cumming <murrayc@murrayc.com>
761 * src/maemo/modest-account-view-window.c:
762 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
763 logical ID for the confirmation messages. Fixed projects.maemo.org bug
766 2007-06-01 Murray Cumming <murrayc@murrayc.com>
768 * src/maemo/easysetup/modest-easysetup-wizard.c:
769 (create_caption_new_with_asterisk):
770 * src/maemo/modest-account-settings-dialog.c:
771 (create_caption_new_with_asterisk):
772 Uncomment the code to add the asterisk, because they are no longer in the
773 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
774 (update_incoming_server_title): Add an asterisk here too.
776 2007-06-01 Murray Cumming <murrayc@murrayc.com>
778 * src/maemo/modest-maemo-global-settings-dialog.c:
779 (current_connection): Check that we are even connected before trying to
780 get the current connection name, to prevent a warning.
782 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
783 Change the comments because tny_maemo_conic_device_connect() is now meant to
785 * src/modest-mail-operation.c:
786 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
787 make sure we have a connection and fail if we can't connect.
789 2007-05-31 Murray Cumming <murrayc@murrayc.com>
791 * src/maemo/modest-main-window.c:
792 (on_account_store_connecting_finished): Do not try to get the
793 connection ID if we are not really connected. I am surprised that
794 this signal handler is called when we are not connected.
796 2007-05-31 Murray Cumming <murrayc@murrayc.com>
798 * src/modest-error.h:
799 * src/modest-ui-actions.c:
800 (modest_ui_actions_get_msgs_full_error_handler):
801 Renamed an enum, added comments, added an enum
802 for retrieve-limit errors.
804 * src/modest-mail-operation.c: (foreach_add_item),
805 (internal_folder_observer_update), (update_account_thread),
806 (modest_mail_operation_get_msgs_full):
807 (modest_mail_operation_update_account),
808 Added comments about how this works, and some code that should
809 (but does not) check the retrieve-limit. See the TODO comment.
811 2007-05-31 Murray Cumming <murrayc@murrayc.com>
813 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
814 Initialize help_id to fix the build. Warnings are good.
816 2007-05-31 Murray Cumming <murrayc@murrayc.com>
818 * src/widgets/modest-hbox-cell-renderer.c:
819 (modest_hbox_cell_renderer_append):
820 * src/widgets/modest-vbox-cell-renderer.c:
821 (modest_vbox_cell_renderer_append):
822 Fix the last commit by doing an extra ref.
824 2007-05-31 Murray Cumming <murrayc@murrayc.com>
826 * src/widgets/modest-hbox-cell-renderer.c:
827 (modest_hbox_cell_renderer_append):
828 * src/widgets/modest-vbox-cell-renderer.c:
829 (modest_vbox_cell_renderer_append):
830 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
831 to fix the build with Maemo Bora.
832 However, there seems to be a remaining crash, probably due to reference
835 2007-05-30 Murray Cumming <murrayc@murrayc.com>
837 * src/modest-tny-account.c:
838 (modest_tny_account_new_for_local_folders):
839 Use hildon_file_system_info_async_new() to get a better name for
840 the memory card account, setting it as the account name.
841 The timing seems to work, but this is probably
842 not the best place to do this. See the TODO comment.
843 * src/maemo/modest-main-window.c: (create_details_widget):
844 * src/widgets/modest-folder-view.c: (text_cell_data):
845 Use the tny account name instead of hardcoding a name.
847 2007-05-30 Christian Kellner <ckellner@openismus.com>
849 * src/modest-search.c: (modest_search):
850 Correctly set part_search_func even if we have already parsed
851 the query and thus a valid OgsTextSearcher object.
853 2007-05-30 Christian Kellner <ckellner@openismus.com>
856 Search and check for libogs.
859 Incooparte the ogs build env.
861 * src/modest-mime-part-search-stream.c:
862 * src/modest-mime-part-search-stream.h:
863 Removed since we do the real searching now in modest-search.c.
865 * src/modest-search.c:
866 * src/modest-search.h:
867 Implement support for ogs. We use that if available and requested
868 and fall back to modest_text_utils_utf8_strcmp (). The search logic
869 should now handle the corner case when the search term is spread
870 across multiple reads.
871 Also the logic in modest_search () was corrected to search all
872 requested fields until one is found.
874 2007-05-30 Murray Cumming <murrayc@murrayc.com>
876 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
879 * src/modest-init.c: Made modest_init_local_folders() take a
880 path and be public so we can iniitialize maildir folders on
883 * src/modest-local-folder-info.h:
884 * src/modest-local-folder-info.c:
885 (modest_local_folder_info_get_maildir_path): Add a path parameter.
887 * src/modest-tny-account.c:
888 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
889 still means the standard local-folders path on the local volume.
891 * src/modest-tny-account-store.c:
892 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
893 signal so we can detect mount/unmount of the MMC1 card, and do an update of
894 all accounts when that happens.
895 (get_server_accounts): If the MMC1 card is mounted, create a store account for
896 this too, so it shows up in the treeview.
898 2007-05-28 Murray Cumming <murrayc@murrayc.com>
900 * src/maemo/modest-maemo-global-settings-dialog.c:
901 (current_connection):
902 * src/widgets/modest-global-settings-dialog.c:
903 (current_connection_default):
904 Use the enum values instead of 0, 1 and -1,
905 to make the code clearer.
907 * src/modest-account-mgr-helpers.c:
908 (modest_account_mgr_get_connection_specific_smtp): Make this code
911 * src/modest-runtime.h:
912 * src/modest-runtime.c:
913 Added modest_runtime_remove_all_send_queues().
914 * src/maemo/modest-main-window.c:
915 (on_account_store_connecting_finished): Recreate the send queues,
916 using the appropriate transport accounts for this new connection.
917 Some futher adapting might be needed if the old send queues are not
918 automatically stopped at this point.
920 * src/modest-tny-account-store.c: (get_server_accounts):
921 Create the connection-specific transport accounts, so that they can
922 be found later by their ID.
924 * src/modest-tny-account.h:
925 * src/modest-tny-account.c:
926 Added modest_tny_account_new_from_server_account_name().
927 modest_tny_account_new_from_server_account(): Do not create the
928 send queues here, because they will be
929 recreated anyway when the connection changes for the first time.
931 2007-05-28 Murray Cumming <murrayc@murrayc.com>
933 * src/modest-local-folder-info.h:
934 * src/modest-local-folder-info.c:
935 (modest_per_account_local_outbox_folder_info_get_maildir_path),
936 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
937 tbox_folder): Take a modest account name instead of a server TnyAccount,
938 so we can have per-modest-account rather than per-transport-account
940 We must make sure that we change or recreate the exisitng send queues
941 when the connection changes for connection-specific transport accounts.
943 * src/modest-tny-account-store.c:
944 (create_per_account_local_outbox_folders): Create outboxed per modest
945 account, not per transport account.
947 * src/modest-tny-account.h:
948 * src/modest-tny-account.c:
949 (modest_tny_account_get_special_folder): For outboxes, get the
950 parent modest account name. The account is ignored for other folders.
951 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
952 modest account name rather than a server TnyAccount.
954 2007-05-25 Murray Cumming <murrayc@murrayc.com>
956 * src/modest-tny-account.c:
957 (modest_tny_account_new_from_server_account):
958 Call modest_runtime_get_send_queue() immediately after creating transport
959 accounts, so that they start trying to send email from the outbox as soon
960 as possible at startup. This is probably what we want.
962 * src/modest-mail-operation.c: (update_account_thread):
963 * src/modest-runtime.c: (modest_runtime_get_send_queue):
964 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
965 * src/modest-tny-send-queue.h:
966 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
967 (modest_ui_actions_on_send):
968 Added comments about how sending works, though it needs some more work.
970 2007-05-25 Murray Cumming <murrayc@murrayc.com>
972 * src/modest-tny-account.c:
973 (modest_tny_account_get_special_folder): Add TODO because this fails when
975 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
976 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
977 Do not try to show this window when there is no active account. The UI
978 specs does not tell us what to do in this case.
980 2007-05-24 Murray Cumming <murrayc@murrayc.com>
984 * src/maemo/Makefile.am:
985 * src/widgets/Makefile.am: Some dist fixes.
987 2007-05-24 Murray Cumming <murrayc@murrayc.com>
989 * src/maemo/modest-connection-specific-smtp-window.c:
990 (on_button_edit): Make the code clearer, to prevent a double free.
992 2007-05-24 Murray Cumming <murrayc@murrayc.com>
994 * src/maemo/modest-account-settings-dialog.c:
995 (modest_account_settings_dialog_set_account_name),
996 Check the connection-specific smtp servers checkbox if there are any.
998 * src/maemo/modest-connection-specific-smtp-edit-window.c:
999 (modest_connection_specific_smtp_edit_window_init):
1000 Start with a suitable port number.
1002 * src/modest-account-mgr-helpers.h:
1003 * src/modest-account-mgr-helpers.c: Added
1004 modest_account_mgr_get_has_connection_specific_smtp().
1006 (modest_account_mgr_set_connection_specific_smtp),
1007 (modest_account_mgr_remove_connection_specific_smtp),
1008 (modest_account_mgr_get_has_connection_specific_smtp),
1009 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1010 connection-specific smtp server accounts in the account, rather than
1011 the server account conf dir.
1013 This fixes bug projects.maemo.org bug NB#58263 .
1015 * src/modest-tny-account-store.c:
1016 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1017 if there are no server accounts yet, to prevent an infinite loop when there
1018 are no accounts. Document that one must be called before the other.
1020 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1022 * src/modest-account-mgr-helpers.c:
1023 (modest_account_mgr_get_default_account): Make sure that at least
1024 one account is always the default, if there are any enabled accounts.
1025 This is just a sanity check that shouldn't be necessary.
1027 * src/modest-account-mgr-priv.c:
1028 (_modest_account_mgr_account_from_key): Unescape the conf key to
1029 get the real account name. For instance, this is an issue if a space
1030 was in the account name, which can happen because the account name
1031 is generated from the display name.
1032 (_modest_account_mgr_get_account_keyname): Always escape the
1034 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1035 Unescape the conf keys to get the real account names.
1037 For instance, previously the is-default radio button in the accounts
1038 list was not checked for any accounts at first. This fixes that,
1039 and might fix several similar bugs.
1041 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1043 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1044 Removed some debug printfs.
1046 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1048 Modest on-disk outbox directories are now here, for instance:
1049 $HOME/.modest/outboxes/<account-id-1>/outbox
1050 $HOME/.modest/outboxes/<account-id-2>/outbox
1052 $HOME/.modest/local-folders/outbox
1053 so we can have a separate outbox for each account.
1054 But they are shown as one outbox in the GtkTreeView, by using a
1055 TnyMergeFolder in a ModestTnySimpleFolderStore.
1058 * src/modest-tny-simple-folder-store.c:
1059 * src/modest-tny-simple-folder-store.h:
1060 Added ModestTnySimpleFolderStore, used to contain folders from
1061 other folder stores, such as other accounts.
1063 * src/modest-tny-outbox-account.h:
1064 * src/modest-tny-outbox-account.c:
1065 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1066 used for the per-account local outbox folders.
1068 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1069 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1070 only use this (internally) now for the non-outbox local folders.
1072 * src/modest-init.h:
1073 * src/modest-init.c: Added modest_init_one_local_folder(), for
1074 setting up the directory structure for each local folder.
1076 * src/modest-local-folder-info.c:
1077 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1078 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1080 * src/modest-local-folder-info.h:
1081 * src/modest-tny-account-store.c: (on_account_removed),
1082 (on_account_changed), (create_per_account_local_outbox_folders),
1083 (get_server_accounts), (modest_tny_account_store_get_accounts),
1084 (modest_tny_account_store_get_tny_account_by_account),
1085 (modest_tny_folder_store_is_virtual_local_folders):
1087 * src/modest-tny-account.h:
1088 * src/modest-tny-account.c:
1089 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1090 to create an on-disk per-account local outbox folder for each
1092 (create_per_account_local_outbox_folders): Create a local outbox folder
1093 for each transport account.
1094 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1095 for all local folders.
1097 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1098 instead of using g_object_get/set() directly. It is clearer.
1100 (modest_tny_folder_store_get_message_count),
1101 (modest_tny_folder_store_get_local_size
1102 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1103 because we now use these with non-acount folder stores.
1105 (modest_tny_account_get_special_folder),
1106 (modest_tny_account_new_from_server_account),
1107 (modest_tny_account_new_from_account):
1108 (recurse_folders): Adjust to the new outbox system.
1110 * src/modest-tny-folder.h:
1111 * src/modest-tny-folder.c:
1112 (modest_tny_folder_is_local_folder),
1113 (modest_tny_folder_get_local_folder_type),
1114 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1116 * src/widgets/modest-main-window.h:
1117 * src/maemo/modest-main-window.c: (create_details_widget),
1118 (modest_main_window_set_contents_style): Show details for any folder store,
1121 (modest_tny_folder_get_rules):
1122 Remove the const. C does not support constness enough for this.
1124 * src/modest-ui-actions.c:
1125 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1126 make all outboxes appear as one, in the usual local-folders tree node.
1128 (set_active_account_from_tny_account),
1129 (modest_ui_actions_on_folder_selection_changed):
1130 * src/widgets/modest-folder-view.c: (text_cell_data),
1131 (icon_cell_data), (filter_row),
1132 (add_account_folders_to_merged_folder),
1133 (add_account_folders_to_simple_folder_store), (),
1134 (get_cmp_rows_type_pos), (cmp_rows),
1135 (modest_folder_view_set_account_id_of_visible_server_account):
1136 Adjust to the new outbox system, using generic folder stores and folders
1137 in the GtkTreeModel.
1139 2007-05-23 Christian Kellner <ckellner@openismus.com>
1141 * src/modest-mail-operation.c:
1142 (modest_mail_operation_update_account):
1143 Use info->max_size instead of unintialized local var [small
1144 build fix]. (Added TODO to review that change since I don't
1147 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1149 * libmodest-dbus-client/libmodest-dbus-client.c:
1150 (libmodest_dbus_client_compose_mail): function added
1151 * src/dbus_api/modest-dbus-api.h:
1152 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1153 (on_compose_mail): Implementation of the SendAsMail functionality
1155 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1157 * src/modest-account-mgr.c:
1158 (modest_account_mgr_add_server_account): Set the secure-connection
1159 conf key for transport accounts as well as store accounts. I don't know
1160 why the if was there. For instance, this makes sure that we use SSL
1161 for the gmail preset from the easysetup wizard.
1163 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1165 * src/gnome/modest-main-window.c:
1166 (on_account_store_connecting_finished), (connect_signals):
1167 * src/maemo/modest-main-window.c:
1168 (on_account_store_connecting_finished), (connect_signals),
1169 (modest_main_window_new):
1170 Handle TnyAccountStore::connecting-finished instead of
1171 TnyDevice::connection-changed, because we cannot actually perform
1172 operations on accounts until TnyAccountStore has itself responded to
1173 the TnyDevice::connection-changed signal. This prevents a GError from
1175 Do not try to update at startup, because we (at least on scratchbox)
1176 already do an update at startup when the device goes online.
1177 This prevents a GError from tinymail.
1178 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1179 Added TODO about stopping simultaneous operations.
1181 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1183 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1184 * src/modest-mail-operation-queue.c:
1185 (modest_mail_operation_queue_remove):
1186 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1187 about where they happened.
1189 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1191 * src/modest-ui-actions.c:
1192 (modest_ui_actions_on_password_requested): Make sure that the remember
1193 output parameter is always TRUE.
1195 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1197 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1198 Show a OK/Cancel dialog if the error is a question, though we still do not
1199 know anything more about what we are asking the user.
1200 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1201 Fix an uninitialized variable (helper). This is a logic error, however.
1203 2007-05-21 Christian Kellner <ckellner@openismus.com>
1205 * src/modest-search.h:
1206 Correct bit shifting in the ModestSearchFlags enum.
1208 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-tny-account.c:
1211 (modest_tny_account_new_from_server_account): Do not use the lsub and
1212 check-all hard-coded IMAP options when using POP.
1214 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1216 * src/modest-tny-account.c:
1217 (modest_tny_account_new_from_server_account):
1218 Use NULL for the secure-auth method for POP when Password auth has been
1219 specified by the user, as we already do for IMAP. "auth=Login" causes
1220 an error from camel or the server.
1222 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1224 * src/maemo/modest-account-settings-dialog.c:
1225 (create_page_account_details),
1226 (modest_account_settings_dialog_set_account_name):
1227 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1228 for the leave-on-server checkbox, rathr than just the checkbox, when
1229 the protocol is not POP.
1231 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1233 * src/widgets/modest-account-view.c:
1234 * src/widgets/modest-account-view.h:
1235 Added modest_account_view_select_account() which will be useful later
1236 to asynchronously re-select the edited account.
1238 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1240 * src/maemo/modest-account-settings-dialog.c:
1241 (modest_account_settings_dialog_set_account_name):
1242 Automatically choose the port numbers based on the secure authentication
1243 methods, if they have not been chosen before.
1244 This fixes projects.maemo.org bug NB#56273 .
1246 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1248 * src/maemo/modest-main-window-ui.h:
1249 * src/modest-ui-actions.c:
1250 * src/modest-ui-actions.h:
1251 Connect the Tools/SMTP Servers menu item to
1252 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1253 SMTP servers dialog, as in the UI specification and saves changes when it
1254 is closed. This fixed projects.maemo.org bug NB#56305 .
1256 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1258 * src/maemo/modest-connection-specific-smtp-window.c:
1259 (modest_connection_specific_smtp_window_init):
1260 Use gtk_window_set_default_size() to make this window big enough, so
1261 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1263 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1265 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1266 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1267 (modest_connection_specific_smtp_edit_window_init),
1268 Do not try to connect to a combobox signal before the combobox exists.
1269 This fixes the cras in projects.maemo.org bug NB#56288 .
1270 (modest_connection_specific_smtp_edit_window_get_settings):
1271 Remove the server_account_name parameter which was being checked for NULL
1272 though it was not used.
1274 * src/maemo/modest-connection-specific-smtp-window.c:
1275 (modest_connection_specific_smtp_window_fill_with_connections),
1276 (on_button_edit), (modest_connection_specific_smtp_window_init):
1277 Correct the number of treemodel columns to prevent a warning.
1278 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1279 libconic does not work.
1281 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1283 * src/modest-tny-account.c:
1284 (modest_tny_account_new_from_server_account):
1285 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1286 SMTP when "None" was chosen by the user. However, with my SMTP server that
1287 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1290 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1292 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1293 to explain the memory management issue with the ID in the ModestPair.
1295 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1296 (add_sending_page), (modest_account_assistant_finalize):
1297 * src/gnome/modest-gnome-global-settings-dialog.c:
1298 (create_updating_page), (create_composing_page):
1299 * src/gnome/modest-msg-edit-window.c: (get_transports),
1300 (init_window), (modest_msg_edit_window_finalize),
1301 (modest_msg_edit_window_get_msg_data):
1302 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1303 * src/gnome/modest-transport-widget.c:
1304 (modest_transport_widget_finalize), (smtp_configuration):
1305 * src/maemo/modest-maemo-global-settings-dialog.c:
1306 (create_updating_page), (create_composing_page):
1307 * src/maemo/modest-msg-edit-window.c: (get_transports),
1308 (init_window), (modest_msg_edit_window_finalize),
1309 (modest_msg_edit_window_get_msg_data),
1310 (modest_msg_edit_window_free_msg_data):
1311 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1312 (modest_store_widget_finalize):
1313 * src/maemo/modest-transport-widget.c:
1314 (modest_transport_widget_finalize), (smtp_configuration):
1315 * src/modest-main.c: (send_mail):
1316 * src/widgets/modest-combo-box.h:
1317 * src/widgets/modest-global-settings-dialog-priv.h:
1318 * src/widgets/modest-global-settings-dialog.c:
1319 (modest_global_settings_dialog_finalize):
1320 * src/widgets/modest-msg-edit-window.h:
1321 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1322 as long as the combo box, to prevent use of freed memory for the ID.
1324 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1326 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1327 get_accounts(), to make this clearer. Do not check for the enabled gconf
1328 key, because we do not use this for server accounts (at least, not yet).
1329 This allows us to send email again.
1331 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1333 * src/maemo/modest-platform.c:
1334 (on_modest_conf_update_interval_changed), (modest_platform_init):
1335 Only respond to this particular key change. All these strcmp()s cannot be
1338 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1340 * src/maemo/modest-maemo-global-settings-dialog.c:
1341 (current_connection): Prevent a crash in scratchbox when
1342 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1343 * src/maemo/modest-platform.c:
1344 (on_modest_conf_update_interval_changed), (modest_platform_init):
1345 Get the update interval from gconf and reset it when the gconf key changes.
1347 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1349 * src/modest-protocol-info.c:
1350 * src/modest-protocol-info.h: Adde enum-specific get functions,
1351 instead of using a ModestProtocolType enum parameter.
1353 * src/gnome/modest-account-assistant.c:
1354 * src/gnome/modest-store-widget.c:
1355 * src/gnome/modest-store-widget.h:
1356 * src/gnome/modest-transport-widget.c:
1357 * src/gnome/modest-transport-widget.h:
1358 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1359 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1360 * src/maemo/easysetup/modest-easysetup-wizard.c:
1361 * src/maemo/modest-account-settings-dialog.c:
1362 * src/maemo/modest-account-settings-dialog.h:
1363 * src/maemo/modest-store-widget.c:
1364 * src/maemo/modest-store-widget.h:
1365 * src/maemo/modest-transport-widget.c:
1366 * src/maemo/modest-transport-widget.h:
1367 * src/modest-account-mgr-helpers.c:
1368 * src/modest-account-mgr-helpers.h:
1369 * src/modest-account-mgr.c:
1370 * src/modest-account-mgr.h:
1371 * src/modest-tny-account.c:
1372 * src/modest-tny-folder.c:
1373 * src/widgets/modest-account-view.c:
1374 * src/widgets/modest-retrieve-combo-box.c:
1375 * src/widgets/modest-retrieve-combo-box.h:
1376 * src/widgets/modest-secureauth-combo-box.c:
1377 * src/widgets/modest-serversecurity-combo-box.c:
1378 * src/widgets/modest-serversecurity-combo-box.h:
1379 * tests/check_account-mgr.c:
1380 Use the specific functions, and use the re-renamed enum values for GNOME too.
1382 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1384 * src/modest-pair.h:
1385 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1386 so we can get the second based on the first.
1388 * src/maemo/modest-account-settings-dialog.h:
1389 * src/maemo/modest-account-settings-dialog.c:
1390 Added get_supported_secure_authentication_methods(), though it is mostly
1391 commented-out for now until the necessary API is committed to tinymail.
1392 (modest_account_settings_dialog_set_account_name),
1393 (save_configuration): Request the supported authentication methods from the
1394 server, so we can choose a working method.
1396 * src/modest-tny-account-store.h:
1397 * src/modest-tny-account-store.c:
1398 (modest_tny_account_store_get_session): Rename from
1399 tny_account_store_get_session().
1401 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1403 * src/modest-protocol-info.h: Split the ModestProtocol enum
1404 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1405 There was no need to have these unrelated values in one enum.
1407 * src/: many files: Adapted to changed enum. This makes the code a bit
1408 clearer, and the compiler could catch some errors.
1410 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1412 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1413 Show the detailed internal camel error message when an error happens
1414 during the configuration, so that our testers can give us more clues.
1415 For instance, in projects.maemo.org bug NB#56910 .
1417 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1419 * src/modest-tny-account.c:
1420 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1421 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1423 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1426 * src/maemo/modest-account-settings-dialog.c:
1427 (modest_account_settings_dialog_set_account_name),
1428 (save_configuration): For the incoming secure authentication checkbox,
1429 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1430 the UI specification. PLAIN does not seem to be supported for most IMAP
1431 servers anyway, and I am not sure what it would mean.
1432 However, we probably need to discover which of the secure-authentication
1433 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1434 * src/modest-account-mgr-helpers.c:
1435 (modest_account_mgr_get_server_account_data):
1437 * src/modest-tny-account.c:
1438 (modest_tny_account_new_from_server_account):
1439 Use tny_account_set_mech() to set secure-authentication methods,
1440 with some special-casing for IMAP, based on my observations of how
1443 * src/modest-account-mgr-helpers.h:
1444 * src/modest-account-mgr.c:
1445 * src/modest-defs.h: Comment that the URI is only used for local folders.
1447 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1449 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1450 parameter const, just to be neat.
1451 * src/modest-text-utils.c: (modest_text_utils_inline):
1452 End g_strconcat() with NULL, as its documentation says. This is almost
1453 certainly the cause of my crash at startup on the device. Interestingly,
1454 valgrind doesn't tell us about these errors.
1456 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1458 * scripts/build-packages: Added more precise comments about how to use
1459 this script, though I still get this error:
1460 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1461 error building tinymail
1463 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1465 * src/maemo/modest-main-window.c: (on_account_update):
1466 Very slight cleanup, hoping to make it simpler to discover what causes
1467 a crash here sometimes.
1469 * src/modest-tny-account.c:
1470 (modest_tny_account_new_from_server_account): Set the port. Added
1471 comments about the options and a TODO comment because I need to find out
1472 how to specify the secure authentication method.
1474 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1476 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1477 changed CFlags paths form modest to libmodest
1479 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1481 * src/modest-account-mgr-helpers.c:
1482 (modest_account_mgr_get_server_account_data),
1483 (modest_account_mgr_free_server_account_data):
1484 * src/modest-account-mgr-helpers.h:
1485 * src/modest-account-mgr.c:
1486 (modest_account_mgr_add_server_account):
1487 * src/modest-defs.h:
1488 * src/modest-tny-account.c:
1489 (modest_tny_account_new_from_server_account):
1490 Determine the options for tny_camel_account_add_option() here,
1491 based on the settings, rather than storing them directly in gconf.
1493 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1495 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1496 Show a more friendly error dialog now that we expect (from the tinymail
1497 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1499 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1501 * src/maemo/modest-main-window.c: (on_account_update): Check that
1502 account_name is not NULL, to prevent a crash at startup that I am
1503 seeing on the N800. I do wonder why it is NULL.
1505 * src/maemo/easysetup/modest-easysetup-wizard.c:
1506 (create_page_user_details):
1507 * src/maemo/modest-account-settings-dialog.c:
1508 (create_page_user_details), (create_page_outgoing):
1509 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1510 (modest_connection_specific_smtp_edit_window_init):
1511 * src/modest-ui-actions.c:
1512 (modest_ui_actions_on_password_requested):
1513 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1514 might do something useful with the on-screen keyboard.
1516 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1518 * src/maemo/modest-main-window.c: (on_account_update):
1519 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1520 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1522 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1524 * src/modest-tny-account-store.c: (on_account_changed):
1525 Correct the signature of this signal handler.
1527 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1529 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1530 Show a HildonNote instead of a GtkDialog for Maemo.
1532 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1534 * src/widgets/modest-account-view.h:
1535 * src/widgets/modest-account-view.c: (on_account_changed),
1536 (on_account_removed). Added a boolean flag, set/unset by
1537 modest_account_view_block_conf_updates(),
1538 modest_account_view_unblock_conf_updates() to prevent unnecessary
1539 updates, but this is not very useful because the gconf notifications are
1540 so delays (maybe only on Maemo Bora).
1541 So auto-updating is turned off, and these functions do an explicit
1542 update when necessary.
1543 However, something else is still doing too much work when adding/removing
1544 accounts, probably in another part of the application.
1546 * src/maemo/modest-account-view-window.c:
1547 (on_delete_button_clicked), (on_edit_button_clicked),
1548 (on_new_button_clicked): Use the new functions.
1550 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1552 * src/modest-account-mgr-helpers.c:
1553 (modest_account_mgr_set_first_account_as_default):
1554 Sort the list of names alphabetically-by-title, so we choose the first one
1556 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1557 alphabetically by the title.
1559 This fixes projects.maemo.org bug NB#56418 .
1561 * src/modest-account-mgr-priv.c:
1562 (_modest_account_mgr_account_from_key):
1563 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1564 avoid a valgrind error, and possible random behaviour.
1566 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1568 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1569 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1570 tinymail documentation to say that this can be expected.
1571 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1572 pretty, and should not happen, but I would prefer to know when it does.
1574 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1576 * configure.ac: When using the older hildon version, probably on Bora,
1577 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1579 * src/widgets/modest-attachment-view.c:
1580 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1583 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1585 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1586 Implemented the prototype. Can be tested with
1587 tests/dbus_api/test_open_message:
1589 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1591 * src/modest-tny-account-store.c:
1592 (modest_tny_account_store_instance_init), (get_password):
1593 * src/modest-ui-actions.c:
1594 (modest_ui_actions_on_password_requested):
1595 Do not store the password in gconf, because this function is called
1596 for non-remembered passwords. Actually use the cached (in the hash map)
1597 password instead of releasing it.
1598 The password will now not be remembered if it is asked via the protected
1599 password dialog, as per the UI spec.
1601 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1603 * src/modest-defs.h:
1604 * src/modest-account-mgr-helpers.h:
1605 * src/modest-account-mgr-helpers.c:
1606 Added modest_server_account_get_username_has_succeeded(),
1607 modest_server_account_set_username_has_succeeded().
1608 (modest_server_account_set_username),
1609 Reset the has-succeeded flag if the username changes.
1611 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1612 * src/maemo/modest-connection-specific-smtp-window.c:
1613 (modest_connection_specific_smtp_window_save_server_accounts):
1614 Use modest_server_account_set_username() instead of using
1615 modest_conf_set_string() directly, so that the has-succeeded flag is always
1618 * src/modest-ui-actions.c:
1619 (modest_ui_actions_on_password_requested): Dim the username entry if
1620 the username has ever worked, as per the UI spec.
1622 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1624 * src/modest-tny-account-store.c: (get_password):
1625 * src/modest-ui-actions.c:
1626 (modest_ui_actions_on_password_requested):
1627 Allow the username to be changed too, though there is more work to
1628 be done on exactly how this behaves.
1630 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1632 * src/modest-account-mgr-helpers.h:
1633 * src/modest-account-mgr-helpers.c:
1634 Added modest_account_mgr_get_display_name(),
1635 modest_server_account_get_username(),
1636 modest_server_account_set_username(),
1637 modest_server_account_set_password(),
1638 modest_server_account_get_hostname() functions so we do not need to
1639 use the conf API directly.
1641 * src/maemo/modest-main-window.c: (connect_signals):
1642 Actually connect ot the ModestAccountStore::request-password signal,
1643 so that we show the dialog when the password is requested by Tinymail,
1644 for isntance if it is empty.
1646 * src/modest-marshal.list:
1647 * src/modest-tny-account-store.c:
1648 (modest_tny_account_store_class_init), (get_password),
1649 (modest_tny_account_store_alert):
1650 * src/modest-tny-account-store.h:
1651 * src/modest-ui-actions.h:
1652 * src/modest-ui-actions.c:
1653 (modest_ui_actions_on_password_requested):
1654 Change the signal parameters, so it is obvious that we are providing
1655 the non human-readable server name, and receiving both the username
1656 and password, though changing of the username is not yet implemented.
1657 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1658 for the GNOME version.
1660 This should fix the projects.maemo.org bug NB#56209, though it does not
1661 work on Bora, because the gconf_client_get() for the password fails
1662 immediately after we save it with gconf_client_set().
1664 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1667 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1668 caused an undefined symbol error:
1669 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1671 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1673 * src/modest-tny-account-store.c:
1674 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1675 using a GError instead of a string message, so we can translate it in
1678 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1680 * src/maemo/modest-address-book.c:
1681 (modest_address_book_check_names):
1682 * src/maemo/modest-msg-view-window.c:
1683 (modest_msg_view_window_clipboard_owner_change):
1684 * src/modest-init.c: (modest_init_init_ui):
1685 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1686 (update_folders_cb), (modest_mail_operation_update_account):
1687 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1688 (modest_ui_actions_on_msg_attachment_clicked),
1689 (modest_ui_actions_on_msg_recpt_activated):
1690 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1691 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1692 (modest_msg_view_search_next):
1693 * src/widgets/modest-recpt-editor.c:
1694 (modest_recpt_editor_on_button_release_event),
1695 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1696 g_message(). At this point we should only be seeing interesting errors on
1697 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1699 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1701 (modest_wizard_dialog_force_title_update):
1702 * src/maemo/easysetup/modest-wizard-dialog.h:
1703 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1704 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1705 can update the title when appropriate. Otherwise the title is wrong if the
1706 pages are added after adding the notebook to the dialog.
1707 This must be a problem in HildonWizardDialog too.
1708 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1710 * src/maemo/easysetup/modest-easysetup-wizard.c:
1711 (create_subsequent_customsetup_pages),
1712 (create_subsequent_easysetup_pages):
1713 Call modest_wizard_dialog_force_title_update() so that the title is
1714 correct even with GTK+ < 2.10.
1715 This fixes projects.maemo.org bug NB#56145 .
1717 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1719 * src/maemo/modest-platform.c:
1720 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1721 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1724 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1726 * src/widgets/modest-window.h:
1727 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1728 and modest_window_save_state(), which invokes it.
1730 * src/widgets/modest-window-mgr.h:
1731 * src/widgets/modest-window-mgr.c:
1732 Added modest_window_mgr_save_state_for_all_windows(), which calls
1733 the save_state vfunc on all registered windows, if implemented.
1735 * src/gnome/modest-msg-edit-window.c:
1736 * src/gnome/modest-msg-view-window.c:
1737 * src/maemo/modest-msg-edit-window.c:
1738 * src/maemo/modest-msg-view-window.c:
1739 * src/maemo/modest-main-window.c:
1740 Specify the existing save_settings functions as implementations of
1741 ModestWindow::save_state_func().
1743 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1744 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1745 enabling hibernation, for instance.
1747 We may need to do the same thing for restoring settings.
1750 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1752 * src/widgets/modest-window-mgr.c:
1753 * src/widgets/modest-window-mgr.h:
1754 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1755 modest_window_mgr_get_hibernation_is_prevented().
1757 * src/maemo/modest-main-window.c:
1758 (on_hildon_program_is_topmost_notify): Prevent hibernation
1759 (possible when the application goes to the background in the WM),
1760 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1762 * src/maemo/easysetup/modest-easysetup-wizard.c:
1763 (modest_easysetup_wizard_dialog_init):
1764 * src/maemo/modest-account-settings-dialog.c:
1765 (modest_account_settings_dialog_init):
1766 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1767 (modest_connection_specific_smtp_edit_window_init):
1768 * src/maemo/modest-connection-specific-smtp-window.c:
1769 (modest_connection_specific_smtp_window_init):
1770 * src/maemo/modest-signature-editor-dialog.c:
1771 (modest_signature_editor_dialog_init):
1772 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1773 prevent hibernation while any of these account settings dialogs are open.
1775 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1777 * src/maemo/Makefile.am:
1778 * src/maemo/modest-osso-state-saving.c:
1779 * src/maemo/modest-osso-state-saving.h: Added
1780 modest_osso_load_state() and modest_osso_save_state() though they do
1781 nothing now. They should iterate through all the open windows and load/save
1783 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1784 save state when closing.
1786 * src/maemo/modest-main-window.c:
1787 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1788 Add a notification handler for the HildonProgram::is-topmost property,
1789 so we can allow hibernation when the application goes into the background.
1790 But we still need to detect when the accounts setup windows are open so
1791 we can stop hibernation when they are open.
1792 To do this, I also added the main window the HildonProgram. This might have
1793 other side-effects/benefits, and should maybe be done for other windows.
1795 * src/maemo/modest-osso-autosave-callbacks.h:
1796 * src/maemo/modest-osso-autosave-callbacks.c:
1797 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1798 though it does not do anything yet, and we might never need this to do
1799 anything. For instance, we already save drafts.
1801 * src/maemo/modest-platform.c: (modest_platform_init):
1802 Specify the libosso auto-save callback.
1804 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1806 * src/maemo/modest-platform.c:
1807 (modest_platform_set_update_interval):
1808 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1809 aparently stays valid between application instances, so we can use this
1810 to remove and reset it later. According to a maemo-developers email from
1813 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1815 * configure.ac: Depend on libalarm for Maemo.
1817 * src/dbus_api/modest-dbus-api.h:
1818 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1819 (on_send_receive), (modest_dbus_req_handler):
1820 Handle a SEND_RECEIVE D-Bus method.
1822 * libmodest-dbus-client/libmodest-dbus-client.c:
1823 (libmodest_dbus_client_send_and_receive):
1824 * libmodest-dbus-client/libmodest-dbus-client.h:
1825 Add C convenience functions for calling the new D-Bus method.
1827 * src/modest-platform.h:
1828 * src/gnome/modest-platform.c:
1829 * src/maemo/modest-platform.c:
1830 Added modest_platform_set_update_interval(), which uses the
1831 alarmd API on Maemo.
1832 (modest_platform_init),
1833 Call modest_platform_set_update_interval(), using a hard-coded
1834 interval for now (until the global settings dialog is implemented),
1835 though I am not sure that this makes sense yet.
1837 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1839 * src/dbus_api/modest-dbus-callbacks.c:
1840 (modest_osso_cb_hw_state_handler):
1841 * src/dbus_api/modest-dbus-callbacks.h:
1842 * src/maemo/modest-platform.c: (modest_platform_init):
1843 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1844 in case this has some effect on the ability for Maemo to ping the
1847 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1849 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1850 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1851 warning. It is probably a logic error, but I need to fix the build.
1853 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1855 * src/modest-account-mgr.h:
1856 * src/modest-account-mgr.c:
1857 (modest_account_mgr_account_names): Add a gboolean enabled_only
1858 parameter, so we can get lists of onlt the enabled accounts.
1860 (modest_account_mgr_add_account),,
1861 (modest_account_mgr_account_with_display_name_exists):
1862 * src/maemo/modest-msg-edit-window.c: (get_transports):
1863 * src/modest-account-mgr-helpers.c:
1864 (modest_account_mgr_set_first_account_as_default):
1865 * src/modest-init.c: (init_default_account_maybe):
1866 * src/modest-tny-account-store.c: (get_accounts):
1867 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1868 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1869 * tests/check_account-mgr.c: (START_TEST):
1870 Provide the extra parameter, as appropriate.
1872 * src/widgets/modest-account-view.c: (update_account_view):
1873 Do not show disabled accounts (meaning that there is no way to
1874 enable/disable accounts in the UI (the feature is not in our UI
1875 specification), so we can use this internally only to mark unfinished
1876 or temporary account data.
1878 * src/maemo/easysetup/modest-easysetup-wizard.c:
1879 (create_account): Add boolean enable parameter, so we can specify FALSE
1880 to create the temporary account.
1881 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1882 (on_before_next): When finishing, when there is a temporary account, just
1884 Also, use a timeout to delay the showing of the dialog until gconf is likely
1885 to return correct information, due to a maemo gconf bug that is fixed in
1886 osso 1.1, but not yet in Bora.
1887 However, the dialog stays on screen after it is destroyed.
1889 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1890 for invalid data when cancelling. Use a hildon note instead of a dialog
1891 to complain about invalid data. Do not show the account-saved note if the
1892 account is disabled (a temporary account that will not really be saved for use
1895 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1897 * src/modest-account-mgr-helpers.h:
1898 * src/modest-account-mgr-helpers.c:
1899 Added modest_account_mgr_unset_default_account(),
1900 Added modest_account_mgr_set_first_account_as_default().
1902 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1903 If it was the default account, unset the default account name.
1905 * src/maemo/modest-account-view-window.c:
1906 (on_delete_button_clicked): If it was the default account,
1907 set the first remaining account as the default instead.
1909 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1910 a NULL account or a NULL default account, to prevent a crash. This should
1911 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1914 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1916 * src/widgets/modest-recpt-editor.c:
1917 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1918 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1919 TODO comment for this. This fixes the build.
1921 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1922 be the best place for it. This will in future update all auto-update accounts,
1923 rather than just the current/default account, when that gconf key exists.
1924 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1925 if there are no accounts, before calling do_send_receive().
1926 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1928 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1929 * src/maemo/modest-main-window-ui.h:
1930 * src/maemo/modest-main-window.c: (on_connection_changed),
1931 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1932 directly, becaue the signal handler does more.
1934 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1936 * src/modest-account-mgr-helpers.c:
1937 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1938 for the case that the account does not exist.
1940 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1941 (equivalent to the modest account name) rather than the tinymail account name
1942 (equivalent to the modest account title - human readable) to get the account data.
1943 Check for null account data to prevent the crash, and add a TODO comment saying that
1944 this needs fixing because it is using the server account name instead of the account name.
1946 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1948 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1949 * src/maemo/modest-account-settings-dialog.c: (show_error),
1951 Use hildon_note_new_information() for informative and error messages,
1952 which seems to be expected for Maemo applications (no documentation that I know of
1953 says this). I am surprised that there is no distinction between info and error
1956 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1958 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1959 it is easy to find where this is used.
1961 * src/maemo/easysetup/modest-easysetup-wizard.c:
1962 (create_page_welcome), (create_page_account_details),
1963 (create_page_user_details), (create_page_complete_easysetup),
1964 (create_page_custom_incoming), (create_page_custom_outgoing),
1965 (create_page_complete_custom):
1966 * src/maemo/modest-account-settings-dialog.c:
1967 (create_page_account_details), (create_page_user_details),
1968 (create_page_incoming), (create_page_outgoing):
1969 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1970 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1971 (modest_connection_specific_smtp_edit_window_init):
1972 * src/maemo/modest-connection-specific-smtp-window.c:
1973 (modest_connection_specific_smtp_window_init):
1974 * src/maemo/modest-signature-editor-dialog.c:
1975 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1976 and scrolling policy as per the Email Application Layout Guide, if I have
1979 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1981 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1982 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1983 which were empty, because these vfuncs have been removed from TnyAccountStore.
1984 This fixes the build.
1986 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1988 * src/maemo/modest-main-window.c:
1989 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1990 showing/hiding it. Added TODO because it probably should not be NULL.
1991 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1992 because unnecessary g_warnings() make degugging difficult.
1994 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1996 * src/maemo/modest-msg-edit-window.c:
1997 (modest_msg_edit_window_select_color),
1998 (modest_msg_edit_window_select_background_color): 2 const corrections and
1999 moving 2 #endifs before closing brackets, to fix the build.
2001 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2003 * src/maemo/easysetup/modest-easysetup-wizard.h:
2004 * src/maemo/easysetup/modest-easysetup-wizard.c:
2005 (modest_easysetup_wizard_dialog_finalize),
2006 (on_button_edit_advanced_settings), (create_page_complete_custom),
2007 (on_response), (create_account):
2008 Implement the Advanced Settings edit button, by saving the account information,
2009 for the Advanded Settings dialog to use directly from gconf, and removing it
2010 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2011 Bug #5533 in the projects.maemo.org bugzilla.
2013 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2015 * src/maemo/modest-msg-view-window.c:
2016 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2017 when opening a message window.
2019 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2021 * src/maemo/easysetup/modest-easysetup-wizard.c:
2022 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2025 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2026 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2027 gconf settings. I probably added more checks than necessary, but that is safer.
2029 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2030 variable to fix the build, but this seems to be used when it is still NULL.
2032 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2034 * src/modest-platform.h:
2035 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2036 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2037 * src/modest-main.c: Implement this function so we can avoid using
2038 maemo-specific API from cross-platform code.
2040 * src/modest-tny-account-store.c:
2041 (get_smtp_specific_transport_account_for_open_connection):
2042 * src/modest-ui-actions.c: (check_for_connection),
2043 (modest_ui_actions_on_item_not_found):
2044 Use modest_platform_connect_and_wait() and put #idefs around other
2045 maemo-specific code, because only maemo currently has a way to
2046 identify connection names.
2048 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2050 * src/modest-tny-account-store.h:
2051 * src/modest-tny-account-store.c:
2052 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2053 the connection-specific SMTP server settings in the configuration.
2055 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2057 * src/maemo/modest-main-window.c: (on_connection_changed),
2059 * src/modest-main.c: (main), (start_ui), (send_mail):
2060 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2061 that is what is intended.
2063 * src/modest-ui-actions.c: (action_send), (action_receive),
2064 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2065 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2066 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2067 SMTP server is used when it is specified.
2069 (modest_ui_actions_on_send_receive):
2070 Check that a connection is open before proceeding.
2071 Receive and then send, instead of vice-versa, as per the specification.
2073 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2075 * src/modest-mail-operation.c:
2076 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2077 though I guess it should be something other than NULL.
2079 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2081 * src/maemo/easysetup/modest-easysetup-wizard.c:
2082 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2083 combo twice, to avoid an g_warning and to make it visible again.
2084 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2085 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2086 (already intended) dereference when detaching, because we then recreate the menu.
2087 But I am not sure why the warning was happening, and it is possible that this is a memory
2090 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2092 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2093 and uri_parse_mailto() utility functions.
2094 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2096 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2098 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2100 * src/dbus_api/modest-dbus-api.h:
2101 * src/dbus_api/modest-dbus-callbacks.c:
2102 Use an idle callback to execute the modest code in the application's own thread.
2103 Remove the helloworld example method.
2104 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2105 parsed, and the open-message method is not implemented because this is not yet implemented in
2107 * libmodest-dbus-client/libmodest-dbus-client.c:
2108 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2109 (libmodest_dbus_client_open_message):
2110 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2112 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2113 body without crashing.
2115 * tests/dbus_api/Makefile.am:
2116 * tests/dbus_api/test_mail_to.c:
2117 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2119 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2121 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2122 Added file to fix the build. Sorry.
2124 * src/dbus_api/Makefile.am:
2125 * src/dbus_api/modest-dbus-api.h:
2126 * src/dbus_api/modest-dbus-callbacks.h:
2127 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2128 (modest_dbus_req_handler):
2129 Put constants in a separate header so it can be reused by the
2130 client library, without duplication
2132 * libmodest-dbus-client/Makefile.am:
2133 * libmodest-dbus-client/libmodest-dbus-client.c:
2134 (libmodest_dbus_client_call_helloworld),
2135 (libmodfest_dbus_client_send_mail),
2136 (libmodfest_dbus_client_mailto),
2137 (libmodfest_dbus_client_open_message):
2138 * libmodest-dbus-client/libmodest-dbus-client.h:
2139 (Partly) Implement a send_mail D-Bus method.
2141 * tests/dbus_api/Makefile.am:
2142 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2143 the send_email D-Bus method.
2145 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2149 * libmodest-dbus-client/Makefile.am:
2150 * libmodest-dbus-client/libmodest-dbus-client.c:
2151 * libmodest-dbus-client/libmodest-dbus-client.h:
2152 * tests/dbus_api/Makefile.am:
2153 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2154 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2156 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2158 * src/maemo/easysetup/modest-easysetup-wizard.c:
2159 (create_page_account_details):
2160 * src/maemo/modest-account-settings-dialog.c:
2161 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2162 widgets, because this might not be the default in future versions of the Maemo GTK+.
2163 However, I can not not get capitalization to work even in a simple test case.
2165 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2167 * src/maemo/easysetup/modest-easysetup-wizard.c:
2168 (create_page_custom_incoming), (create_page_custom_outgoing):
2169 * src/maemo/modest-account-settings-dialog.c:
2170 (create_page_account_details), (create_page_incoming),
2171 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2172 instead of using gtk_check_button_with_label(), so they are aligned like the other
2173 widgets, as per the UI spec.
2175 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2177 * src/maemo/easysetup/modest-easysetup-wizard.c:
2178 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2179 * src/widgets/modest-validating-entry.c:
2180 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2181 Modest prefix instead of an EasySetup prefix.
2183 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2185 * src/widgets/modest-validating-entry.h:
2186 * src/widgets/modest-validating-entry.c: (on_insert_text),
2187 Added easysetup_validating_entry_set_max_func(), used to set a callback
2188 to call when the max number of characters is reached. GtkEntry has a max-length
2189 already but is silent about it.
2191 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2192 (create_page_account_details), (create_page_user_details),
2194 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2195 (create_page_account_details), (create_page_user_details),
2196 (create_page_outgoing):
2197 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2198 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2199 the UI spec, when the user tries to enter more than the max number of characters.
2201 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2203 * src/maemo/easysetup/modest-easysetup-wizard.c:
2204 (create_page_user_details), (create_page_custom_incoming),
2205 (create_page_custom_outgoing):
2206 * src/maemo/modest-account-settings-dialog.c:
2207 (create_page_user_details), (create_page_incoming),
2208 (create_page_outgoing):
2209 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2210 (modest_connection_specific_smtp_edit_window_init):
2211 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2212 not appropriate. Bad Maemo-specific defaults!.
2214 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2216 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2217 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2218 (modest_signature_editor_dialog_set_settings):
2219 Disable the label and textview when the checkbox is disabled, and use the
2220 specified (UI spec) default signature text.
2222 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2224 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2225 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2227 * src/modest-defs.h:
2228 * src/modest-account-mgr-helpers.h:
2229 * src/modest-account-mgr-helpers.c:
2230 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2232 * src/maemo/Makefile.am:
2233 * src/maemo/modest-signature-editor-dialog.c:
2234 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2237 * src/maemo/modest-account-settings-dialog.h:
2238 * src/maemo/modest-account-settings-dialog.c:
2239 (modest_account_settings_dialog_finalize), (on_button_signature),
2240 (save_configuration): Use the new dialog when the Edit button is pressed, and
2241 save the changes if necessary, as per the UI spec.
2243 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2245 * src/maemo/Makefile.am:
2246 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2247 based on maemo-develoers email from Dirk.
2249 * src/maemo/easysetup/modest-easysetup-wizard.c:
2250 (create_page_welcome), (create_page_account_details),
2251 (create_page_user_details), (create_page_complete_easysetup),
2252 (create_page_custom_incoming), (create_page_custom_outgoing),
2253 (create_page_complete_custom),
2254 (modest_easysetup_wizard_dialog_init):
2255 * src/maemo/modest-account-settings-dialog.c:
2256 (create_page_account_details), (create_page_user_details),
2257 (create_page_incoming), (create_page_outgoing),
2258 (modest_account_settings_dialog_init):
2259 * src/maemo/modest-connection-specific-smtp-window.c:
2260 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2262 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2264 * src/maemo/easysetup/modest-easysetup-wizard.c:
2265 (create_page_account_details), (create_page_custom_outgoing),
2266 (create_page_complete_custom):
2267 * src/maemo/modest-account-settings-dialog.c:
2268 (create_page_user_details), (create_page_incoming),
2269 (create_page_outgoing):
2270 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2271 (modest_connection_specific_smtp_edit_window_init):
2272 Use the correct (UI spec) port min/max, and use horizontal separators,
2275 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2277 * src/maemo/easysetup/modest-easysetup-wizard.c:
2278 (set_default_custom_servernames):
2279 * src/maemo/modest-account-settings-dialog.c:
2280 (create_page_incoming), (on_combo_outgoing_security_changed),
2281 (on_combo_incoming_security_changed), (create_page_outgoing),
2282 (modest_account_settings_dialog_set_account_name),
2283 (save_configuration):
2284 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2285 (on_combo_security_changed),
2286 (modest_connection_specific_smtp_edit_window_init),
2287 (modest_connection_specific_smtp_edit_window_set_connection),
2288 (modest_connection_specific_smtp_edit_window_get_settings):
2289 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2292 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2295 * src/maemo/easysetup/modest-easysetup-wizard.c:
2296 (create_page_custom_outgoing), (create_page_complete_custom):
2297 * src/maemo/modest-account-settings-dialog.c:
2298 (create_page_user_details), (create_page_outgoing):
2299 * src/maemo/modest-account-view-window.c: (button_box_new):
2300 Use changed logical IDs as per the most recent UI spec:
2301 mcen_bd_emailsetup_edit -> mcen_bd_edit
2302 mcen_bd_emailsetup_delete -> mcen_bd_delete
2303 mcen_bd_emailsetup_close -> mcen_bd_close
2305 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2309 * src/dbus_api/Makefile.am:
2310 * src/dbus_api/modest-dbus-callbacks.c:
2311 * src/dbus_api/modest-dbus-callbacks.h:
2312 * src/maemo/modest-platform.c: (modest_platform_init):
2313 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2315 * tests/Makefile.am:
2316 * tests/dbus_api/Makefile.am:
2317 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2319 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2321 * src/maemo/modest-account-settings-dialog.c:
2322 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2323 Removed unnecessary includes.
2325 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2327 * src/maemo/easysetup/modest-easysetup-wizard.c:
2328 * src/maemo/modest-account-settings-dialog.c:
2329 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2330 * src/widgets/Makefile.am:
2331 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2332 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2333 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2334 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2335 * src/widgets/modest-secureauth-combo-box.c:
2336 * src/widgets/modest-secureauth-combo-box.h:
2337 * src/widgets/modest-serversecurity-combo-box.c:
2338 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2339 made the GObject names more consistent with the rest of the Modest code.
2341 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2343 * src/maemo/easysetup/Makefile.am:
2344 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2345 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2346 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2347 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2348 * src/maemo/easysetup/modest-easysetup-wizard.c:
2349 * src/maemo/easysetup/modest-validating-entry.c:
2350 * src/maemo/easysetup/modest-validating-entry.h:
2351 * src/maemo/modest-account-settings-dialog.c:
2352 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2353 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2354 widgets/ because they are used outside of easysetup too. After checking in,
2355 svn will allow me to rename them too.
2357 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2359 * src/gnome/modest-msg-edit-window.c:
2360 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2361 linker error, to fix the build on the GNOME platform.
2362 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2363 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2364 ifdefed out to avoid a warning.
2366 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2368 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2369 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2370 some alternative for GTK+ 2.6.
2372 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2374 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2376 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2377 specified for EmailAccountsDialog in UI spec.
2379 * src/maemo/easysetup/modest-easysetup-wizard.c:
2380 * src/maemo/easysetup/modest-easysetup-wizard.h:
2381 * src/maemo/modest-account-settings-dialog.c:
2382 * src/maemo/modest-account-settings-dialog.h:
2383 Reuse a member window widget for the connection-specific SMTP server accounts,
2384 so we can tell it to create/save the accounts only if we actually save changes.
2386 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2387 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2388 (modest_connection_specific_smtp_edit_window_get_settings):
2389 Return a struct instance for temporarily remembering the entered data.
2391 * src/maemo/modest-connection-specific-smtp-window.h:
2392 * src/maemo/modest-connection-specific-smtp-window.c:
2393 (modest_connection_specific_smtp_window_finalize),
2394 (modest_connection_specific_smtp_window_fill_with_connections),
2396 (modest_connection_specific_smtp_window_save_server_accounts),
2397 (update_model_server_names): Do not actually save data until asked,
2398 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2400 (on_selection_changed),
2401 (modest_connection_specific_smtp_window_init): Disable the edit
2402 button when nothing is selected.
2404 * src/modest-account-mgr-helpers.c:
2405 * src/modest-account-mgr-helpers.h:
2406 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2409 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2411 * src/modest-account-mgr-helpers.h:
2412 * src/modest-account-mgr-helpers.c:
2413 (modest_account_mgr_get_unused_account_name),
2414 (modest_account_mgr_get_unused_account_display_name): Added these
2415 utility functions, to avoid code duplication.
2417 * src/maemo/easysetup/modest-easysetup-wizard.c:
2418 (create_page_account_details), (create_account):
2419 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2420 (on_combo_security_changed),
2421 (modest_connection_specific_smtp_edit_window_init),
2422 (modest_connection_specific_smtp_edit_window_save_settings):
2423 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2424 * src/maemo/modest-connection-specific-smtp-window.c:
2425 (modest_connection_specific_smtp_window_finalize),
2426 (modest_connection_specific_smtp_window_fill_with_connections),
2427 (on_button_edit), (modest_connection_specific_smtp_window_init):
2428 * src/maemo/modest-connection-specific-smtp-window.h:
2429 Implementing saving of connection-specific server accounts.
2431 But I need to refactor this so we can save the data for each
2432 possible connection-specific account and only actually create the server accounts
2433 when the easysetup finished, or the OK button is pressed on the account settings
2436 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2438 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2439 (on_combo_security_changed):
2440 (modest_connection_specific_smtp_edit_window_init):
2441 Auto-fill the port number as in the account settings.
2443 (modest_connection_specific_smtp_edit_window_set_connection):
2444 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2445 * src/maemo/modest-connection-specific-smtp-window.c:
2446 (fill_with_connections), (on_button_edit),
2447 (modest_connection_specific_smtp_window_init):
2448 Turn the edit window into a dialog to simplify the code, and
2449 set a WM hint as in a GtkDialog, because only a popup can be on top of
2450 another window in Maemo, and popups usually have no WM decoration.
2452 * src/modest-defs.h:
2453 * src/modest-account-mgr-helpers.c:
2454 (modest_account_mgr_set_connection_specific_smtp),
2455 (modest_account_mgr_remove_connection_specific_smtp),
2456 (modest_account_mgr_get_connection_specific_smtp):
2457 * src/modest-account-mgr-helpers.h: Some functions to write the
2458 connection-specific SMTP server information. Not yet used.
2461 * src/widgets/modest-folder-view.c: (text_cell_data):
2462 Fix a warning about an uninitialized variable.
2463 (on_configuration_key_changed): Put an #ifdef around the use
2464 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2466 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2468 * src/maemo/modest-account-settings-dialog.h:
2469 * src/maemo/modest-account-settings-dialog.c:
2470 Added connect_for_modified() utility function to mark the new modified boolean.
2472 (create_page_account_details), (create_page_user_details),
2473 (create_page_incoming), (create_page_outgoing), (on_response),
2474 (modest_account_settings_dialog_init),
2475 (modest_account_settings_dialog_set_account_name):
2476 Only warn about unsaved changes when there are actually unsaved changes.
2478 * src/modest-account-mgr-helpers.c:
2479 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2480 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2481 to get the data from there in future.
2483 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2485 * src/modest-defs.h:
2487 * src/modest-account-mgr-helpers.h:
2488 * src/modest-account-mgr-helpers.c:
2489 Store the security account setting in a single conf key instead of using
2490 the options list, so that the list is left for just the to-be-removed camel hack,
2491 and because gconf_client_set_list() is failing for some reason.
2493 * src/modest-account-mgr.c:
2494 (modest_account_mgr_add_server_account):
2495 * src/maemo/modest-account-settings-dialog.c:
2496 (modest_account_settings_dialog_set_account_name),
2497 (save_configuration): Use the renamed functions.
2500 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2502 * src/widgets/Makefile.am:
2503 * src/widgets/modest-limit-retrieve-combo-box.c:
2504 * src/widgets/modest-limit-retrieve-combo-box.h:
2505 * src/widgets/modest-retrieve-combo-box.c:
2506 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2507 the account settings dialog.
2509 * src/modest-defs.h:
2510 * src/modest-account-mgr-helpers.h:
2511 * src/modest-account-mgr-helpers.c:
2512 (modest_server_account_get_option_secure_auth),
2513 (modest_server_account_set_option_secure_auth):
2514 * src/modest-account-mgr.c:
2515 (modest_account_mgr_add_server_account):
2516 Use the existing AUTH_MECH conf key for the secure-auth setting,
2517 instead of putting it in the list options, because this was actually used already.
2519 * src/maemo/modest-account-settings-dialog.c:
2520 (create_page_account_details),
2521 (modest_account_settings_dialog_set_account_name),
2522 (save_configuration):
2523 * src/maemo/modest-account-settings-dialog.h:
2524 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2525 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2527 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2529 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2530 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2531 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2533 * src/modest-defs.h:
2534 * src/maemo/modest-account-settings-dialog.c:
2535 (create_page_incoming), (on_combo_outgoing_security_changed),
2536 (on_combo_incoming_security_changed), (create_page_outgoing),
2537 (modest_account_settings_dialog_set_account_name),
2538 (save_configuration): Load/Save the port number, and change it when the
2539 security combo changes, to suitable defaults.
2541 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2543 * src/modest-account-mgr.c:
2544 (modest_account_mgr_add_server_account): Set the security and secure-auth
2545 options, and add a comment saying that the other camel-specific options should be
2548 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2550 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2552 * src/modest-tny-account-store.c: (account_list_free),
2553 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2554 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2557 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2559 * src/modest-protocol-info.c:
2560 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2561 is required by our UI spec. Maybe something in our implementation will use this eventually.
2562 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2563 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2564 instead of the previous 0 placeholder.
2566 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2567 secure-auth settings.
2568 * src/modest-account-mgr-helpers.h:
2569 * src/modest-account-mgr-helpers.c:
2570 (modest_server_account_data_get_option_secure_auth),
2571 (modest_server_account_set_option_secure_auth),
2572 (modest_server_account_data_get_option_security),
2573 (modest_server_account_set_option_security): Added this API for getting and setting the security
2574 and secure-auth settings.
2576 * src/maemo/modest-account-settings-dialog.h:
2577 * src/maemo/modest-account-settings-dialog.c:
2578 (modest_account_settings_dialog_finalize), (check_data),
2579 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2580 about changing titles.
2581 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2582 (save_configuration): Save the security and secure-auth settings.
2584 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2585 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2587 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2589 * src/modest-defs.h:
2590 * src/modest-account-mgr.c:
2591 (modest_account_mgr_add_server_account):
2592 Added and used defines for the options key and value pair strings,
2593 that are used so far, though they do not seem to correspond to anything in our
2594 UI specs or ModestProtocol enum.
2596 * src/modest-account-mgr-helpers.h:
2597 * src/modest-account-mgr-helpers.c:
2598 (compare_option_strings_for_name),
2599 (modest_server_account_data_get_option_value),
2600 (modest_server_account_data_get_option_bool),
2601 (modest_account_mgr_get_server_account_option):
2602 Added helper functions for parsing the options GSList.
2604 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2606 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2607 display name is based on the supplied account name.
2608 * src/modest-account-mgr.c:
2609 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2610 with an inefficient, but good-enough, implementation.
2612 * src/maemo/easysetup/modest-easysetup-wizard.c:
2613 (create_page_account_details), (on_before_next), (create_account):
2614 Check for existing display names rather than (non-user-visible) account names, and just
2615 create and set a unique account name at the end.
2617 * src/maemo/modest-account-settings-dialog.c:
2618 (modest_account_settings_dialog_init),
2619 (modest_account_settings_dialog_set_account_name),
2620 (create_page_incoming): Show the display name, instead of the account name.
2621 (on_response): Do some (not all) extra checks, as in the UI spec.
2622 (save_configuration): Save the display name if it was changed.
2624 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2626 * po/en_GB.po: Added needed logical ID and translation.
2627 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2628 (init_view): Made the is-default column clicking work.
2630 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2633 * src/maemo/easysetup/Makefile.am:
2634 * src/maemo/easysetup/modest-easysetup-wizard.c:
2635 (modest_easysetup_wizard_dialog_init):
2636 * src/maemo/easysetup/provider-data-test.keyfile:
2637 * src/maemo/easysetup/provider-data.keyfile:
2638 Moved the provider data file to the new modest-providers-data package and used it from there.
2640 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2642 * src/modest-local-folder-info.c:
2643 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2644 N_() was already used on the static strings, but this just marks it for translation without
2645 using the translation.
2647 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2649 * src/maemo/modest-account-settings-dialog.c:
2650 (create_page_incoming),
2651 (modest_account_settings_dialog_set_account_name):
2652 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2653 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2654 I will do this if nobody else gets there first.
2656 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2658 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2659 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2660 save the security stuff.
2662 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2664 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2665 Set the email address and user fullname, which I now see must be
2668 * src/maemo/modest-account-settings-dialog.h:
2669 * src/maemo/modest-account-settings-dialog.c:
2671 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2672 leave-on-server and authentication.
2673 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2676 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2679 * src/maemo/modest-account-settings-dialog.c:
2680 * src/maemo/modest-account-settings-dialog.h:
2681 Most (but not all) of the widgets are now present as specified by the UI spec.
2682 No changes are yet saved, and some details are not properly shown yet.
2684 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2686 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2688 * src/maemo/Makefile.am:
2689 * src/maemo/modest-account-settings-dialog.c:
2690 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2691 an existing account. Doesn't do much yet.
2693 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2694 Open the accounts settings dialog when Edit is clicked.
2696 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2698 * src/maemo/easysetup/Makefile.am:
2699 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2701 * src/maemo/easysetup/modest-easysetup-wizard.c:
2702 (modest_easysetup_wizard_dialog_init):
2703 Try to get the source directory from the build system,
2704 instead of hard-coding "./" into the source code, when opening our local
2705 copies of the configuration files.
2706 But this still fails when opening the wizard from the Accounts window,
2707 maybe because the working directory seems to change at runtime.
2708 So the wizard will fail the second time unless you copy the files into their
2709 proper locations - see the stdout warnings for the paths.
2711 (create_page_account_details),(on_before_next):
2712 Check for existing non-server accounts instead of server accounts,
2713 so the default account name is useful again, and to prevent trying to
2716 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2717 Show the wizard when New is clicked.
2719 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2720 (init_view): Show the column headers, and show the columns that are
2721 specified in the UI specs. However, something in Maemo's GTK+ prevents
2722 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2723 change the default account. This is despite unsetting the special properties.
2725 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2727 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2728 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2729 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2730 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2731 to make that clearer.
2732 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2734 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2736 * src/maemo/modest-account-view-window.c:
2737 (modest_account_view_window_init),
2738 (modest_account_view_window_new):
2739 Use the same buttons as specified in the
2740 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2741 the existing widgets, which never had a chance of working.
2742 Put the ModestAccountView treeview in a scrolled window.
2743 Do not repeat the initialization in both _init() and _new().
2745 * src/widgets/modest-account-view.c: (update_account_view):
2746 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2747 this widget and window shows no accounts.
2749 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2751 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2753 * src/maemo/easysetup/modest-easysetup-wizard.c:
2754 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2755 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2756 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2759 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2760 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2761 accounts exist yet, as in the UI spec.
2763 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2765 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2767 * src/maemo/Makefile.am:
2768 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2769 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2770 New window for editing connection-specific smtp details.
2771 Not fully implemented.
2773 * src/maemo/modest-connection-specific-smtp-window.c:
2774 (modest_connection_specific_smtp_window_finalize) :
2775 unref the tree model.
2776 (on_button_edit): Show the edit window.
2778 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2780 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2783 * src/maemo/Makefile.am:
2784 * src/maemo/modest-connection-specific-smtp-window.c:
2785 * src/maemo/modest-connection-specific-smtp-window.h:
2786 New window for showing the list of connections, for connection-specific
2787 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2788 * src/maemo/easysetup/modest-easysetup-wizard.c:
2789 (create_page_custom_outgoing): Show the new window when the button is clicked.
2791 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2793 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2794 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2795 * src/maemo/modest-msg-edit-window.c:
2796 (modest_msg_edit_window_insert_image):
2797 * src/modest-conf.c: (modest_conf_key_escape):
2798 * src/modest-mail-operation.c:
2799 (modest_mail_operation_send_new_mail):
2800 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2801 (modest_ui_actions_on_new_account):
2802 * src/widgets/modest-attachment-view.c: (update_filename_request):
2803 * src/widgets/modest-mail-header-view.c:
2804 Corrected warnings that were breaking the build, by commenting out unused variables,
2805 and a function, and by including a header.
2807 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2809 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2810 so we can #ifdef around platform-specific code when necessary.
2811 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2812 to allow this to build for the GNOME platform too.
2814 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2816 * src/maemo/easysetup/modest-easysetup-wizard.c:
2817 Added util_increment_name() and used it in create_page_account_details()
2818 to make sure that the default account name is always a new name.
2820 (modest_easysetup_wizard_dialog_init),
2821 (set_default_custom_servernames): Some minor memory management fixes.
2823 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2827 * src/modest-runtime.c: (init_i18n): Restored the translation
2828 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2829 are defined in config.h, and the translations are installed.
2831 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2832 is defined for translation.
2834 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2836 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2838 * src/maemo/easysetup/modest-easysetup-wizard.c:
2839 (modest_easysetup_wizard_dialog_init):
2840 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2841 Use realistic paths (though they should use $prefix generically) to the
2842 mcc_mapping and provider-data.keyfile files which might work when they
2843 are installed by the future version of the operator-wizard package,
2844 and then fallback to paths in our source code, with an explanatory
2847 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2851 * src/maemo/Makefile.am:
2852 * src/maemo/easysetup/: Added files from the previously-exernal
2853 osso-modest-easysetup.
2854 * src/maemo/modest-main-window-ui.h:
2855 * src/modest-ui-actions.c:
2856 * src/modest-ui-actions.h:
2857 Added modest_ui_actions_on_new_account() as a signal handler for the
2858 New Account menu item. It shows the easysetup wizard.
2859 * po/en_GB.po: Added additional needed logical IDs and translations.
2861 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2862 Apparently ChangeLog is not used for some vague Nokia legal reasons.