1 2007-07-13 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
4 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
6 2007-07-12 Armin Burgmeier <armin@openismus.com>
8 * src/maemo/modest-main-window.c: Make default account appear bold
9 in view, tools/send & receive and toolbar/send & receive SCM menus.
10 This fixes projects.maemo.org bug NB#59010.
12 2007-07-12 Murray Cumming <murrayc@murrayc.com>
14 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
15 Add a short-cut, by checking if the folder store is an account.
16 This ensures that the Sort menu item and toolbar is dimmed for
17 the local-folders account root item, fixing
18 projects.maemo.org bug NB#62545.
20 2007-07-12 Murray Cumming <murrayc@murrayc.com>
22 * src/modest-tny-account-store.c: (get_password):
23 Show the password dialog (via the signal) only in the mainloop, via
24 an idle handler that we wait for. This could theoretically prevent
25 hangs, though I worry that it could introduce some too.
27 2007-07-12 Murray Cumming <murrayc@murrayc.com>
29 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
30 * src/maemo/modest-platform.c:
31 (modest_platform_connect_and_wait):
32 Take a TnyAccount* parameter and try to set it to online
33 (a TnyCamel-only API), because tinymail sets accounts to offline
34 when the user cancels a password dialog, and doesn't ask again until
35 it has been set to online.
36 However, this is commented out because it causes a hang now.
38 (modest_platform_connect_and_wait_if_network_account):
39 * src/modest-mail-operation.c:
40 (modest_mail_operation_update_account):
41 * src/modest-platform.h:
42 * src/modest-ui-actions.c: (_modest_ui_actions_open),
43 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
45 2007-07-12 Armin Burgmeier <armin@openismus.com>
47 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
49 * src/modest-mail-operation.c:
50 * src/modest-ui-actions.c: Check for already existing folder before
51 querying the server, show error message from camel if the request
52 still fails. This fixes projects.maemo.org bug NB#58701.
54 2007-07-12 Murray Cumming <murrayc@murrayc.com>
56 * src/modest-tny-account-store.h:
57 * src/modest-tny-account-store.c:
58 Added modest_tny_account_store_forget_password_in_memory(),
59 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
60 when creating a new account, so that new passwords will be used, instead of
61 us thinking that it's a second request as a result of a failed password again.
63 2007-07-12 Murray Cumming <murrayc@murrayc.com>
65 * src/dbus_api/modest-dbus-callbacks.c:
66 (on_idle_open_message): If the message is in drafts then open it
67 in an edit window instead of a view window. This fixes
68 projects.maemo.org bug NB#63005.
70 2007-07-12 Murray Cumming <murrayc@murrayc.com>
72 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
73 Avoided a harmless g_warning().
75 2007-07-12 Murray Cumming <murrayc@murrayc.com>
77 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
78 Pass the modest account name, not the TnyAccount display name to
79 modest_msg_view_window_new() so that the reply feature works,
80 fixing projects.maemo.org bug NB#62892.
82 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
83 (modest_msg_view_window_new_with_header_model):
84 * src/maemo/modest-msg-view-window.c:
85 (modest_msg_view_window_new_with_header_model),
86 (modest_msg_view_window_new):
87 * src/modest-ui-actions.c: (reply_forward):
88 * src/widgets/modest-msg-view-window.h:
89 * src/widgets/modest-window.c: (modest_window_set_active_account):
90 Rename an account parameter to modest_account_name to make this clearer.
92 2007-07-11 Murray Cumming <murrayc@murrayc.com>
94 * src/modest-ui-actions.h:
95 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
96 modest_do_message_delete().
97 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
98 Call modest_do_message_delete(), hoping that this would cause messages
99 to be really deleted from search instead of just marked with strike through.
100 Does not seem to help.
102 2007-07-11 Armin Burgmeier <armin@openismus.com>
104 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
105 priv->reselect to FALSE prior to calling
106 modest_folder_view_select_first_inbox_or_local() to prevent endless
107 recursion and thus a crash on startup.
109 2007-07-11 Armin Burgmeier <armin@openismus.com>
111 * src/maemo/modest-account-settings-dialog.h: Include
112 <gtk/gtknotebook.h> to fix the build (at least for me).
114 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
115 Use "New FolderN" as default suggested name if "New folder" already
116 exists, with N being the first free number, though never exceed "New
117 folder99" in which case we just fall back to "New Folder" even though
118 it already exists. This fixes projects.maemo.org bug NB#58663.
120 2007-07-11 Murray Cumming <murrayc@murrayc.com>
122 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
123 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
124 projects.maemo.org bug NB#62778.
126 2007-07-11 Murray Cumming <murrayc@murrayc.com>
128 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
129 Ignore the wrong (for now) secure-smtp setting in the presets -
130 just default to requiring secure authentication for SMTP, because
133 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
135 * src/widgets/modest-folder-view.c: (filter_row)
136 Do not show drafts folder (see UI specs)
138 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
140 * src/modest-ui-actions.c:
141 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
142 place and also not necessary.
144 * src/widgets/modest-folder-view.c: (filter_row)
145 Guess folder type and hide Sent & Outbox if necessary.
146 Fixed project.maemo.org NB#57328
148 2007-07-11 Murray Cumming <murrayc@murrayc.com>
150 * src/modest-ui-actions.h:
151 * src/modest-ui-actions.c:
152 (modest_ui_actions_on_delete_message):
153 Move some code into a new
154 modest_ui_actions_refresh_message_window_after_delete()
155 function so we can use it from elsewhere.
157 * src/dbus_api/modest-dbus-callbacks.c:
158 (on_idle_delete_message), (on_delete_message): Used an idle
159 handler, as we do for the other D-Bus method handlers.
160 Call modest_ui_actions_refresh_message_window_after_delete()
161 if the deleted message was open in a window. This fixed
162 projects.maemo.org bug NB#62862.
164 2007-07-11 Murray Cumming <murrayc@murrayc.com>
166 * src/modest-main.c: (main): Only show the UI at the start if
167 the showui command line option was given. For instance,
168 run-standalone src/modest showui
169 Otherwise, we wait for the top_application D-Bus method to
170 be sent by hildon-desktop when the application is selected
172 This allows us to run without a UI when osso-global-search
173 uses our D-Bus methods.
175 2007-07-11 Murray Cumming <murrayc@murrayc.com>
177 * src/dbus_api/modest-dbus-api.h: Added a define for a
178 top-application D-Bus method.
179 * src/dbus_api/modest-dbus-callbacks.c:
180 (on_top_application),
181 (modest_dbus_req_handler): Handle the top-application D-Bus
182 method, which might be an undocumented D-Bus signal sent by
183 hildon-desktop when it starts the application from the menu.
184 But I am not sure and I need to test it on the device, because
185 my scratchbox does not have the application in the menu now.
186 This method shows the main window, so that it can be invisible
187 when started, for instance, just for email searching from
190 * src/maemo/modest-main-window.c: (restore_settings),
191 (modest_main_window_new): Do not show the window immediately
192 upon creation. We show it later.
193 * src/modest-widget-memory.c: (save_settings_paned):
194 Try (unsuccessfully) to avoid saving the paned position when
195 it is not even visible.
196 (restore_settings_paned): Do not allow a silly paned position.
197 This seems necessary when not showing the window at first.
199 * tests/dbus_api/Makefile.am:
200 * tests/dbus_api/test_top_application.c: (main): Test for the
203 2007-07-10 Murray Cumming <murrayc@murrayc.com>
205 * src/modest-ui-dimming-rules.c:
206 (modest_ui_dimming_rules_on_new_msg),
207 (modest_ui_dimming_rules_on_reply_msg),
208 (modest_ui_dimming_rules_on_delete_msg),
209 (modest_ui_dimming_rules_on_details),
210 (modest_ui_dimming_rules_on_view_window_move_to),
211 (modest_ui_dimming_rules_on_view_previous),
212 (modest_ui_dimming_rules_on_view_next),
213 (_invalid_folder_for_purge): Added checks before
214 casting the window. This looks like an actual
215 logic error in _invalid_folder_for_purge(), because it
216 tries to use a ModestMainWindow as a message window.
218 2007-07-10 Murray Cumming <murrayc@murrayc.com>
220 * src/maemo/modest-account-settings-dialog.c:
221 (show_error): Use the same implementation as in
222 modest-easysetup-wizard.c:
223 (on_entry_invalid_character): The logical ID contains a %s.
224 Guessed what it should be.
225 (on_entry_max), (check_data), (on_response): Adapt to
226 changed show_error().
227 (create_page_account_details): Really call
228 modest_validating_entry_set_func() on the correct widgets.
229 * src/maemo/easysetup/modest-easysetup-wizard.c:
230 (on_entry_invalid_character): Fix the logical ID here too.
231 (create_page_account_details),
232 (create_page_user_details):
234 modest_validating_entry_set_func() on the correct widgets.
236 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
237 Do not try to use the account if it is NULL.
239 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
241 * src/modest-ui-actions.c: (create_move_to_dialog),
242 (modest_ui_actions_on_main_window_move_to),
243 (modest_ui_actions_on_msg_view_window_move_to):
244 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
245 (filter_row), (modest_folder_view_show_non_move_folders):
246 * src/widgets/modest-folder-view.h:
248 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
249 the Sent folder yet as it does not report the correct folder type.
251 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
253 * src/maemo/modest-msg-edit-window.c: (init_window):
256 2007-07-10 Murray Cumming <murrayc@murrayc.com>
258 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
259 Take a parent widget instead of a parent window, and
260 implement this with hildon_banner_show_information() instead.
261 Non-Maemo builds can just ifdef that there.
262 This fixed projects.maemo.org bug NB#62766.
264 (on_entry_invalid_character): Use show_error() again instead
265 of using hildon directly, and use the _CS() macro to use the correct
267 (create_account), (check_for_supported_auth_methods), (on_entry_max):
268 Pass a widget instead od a window to show_error().
270 2007-07-10 Murray Cumming <murrayc@murrayc.com>
272 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
273 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
274 This allows us to show the server name in the error message, fixing
275 projects.maemo.org bug NB#62904.
276 Also, use the appropriate logical ID message for the account protocol.
278 2007-07-10 Murray Cumming <murrayc@murrayc.com>
280 * src/modest-tny-account-store.c: (on_idle_wrong_password):
281 A compilation fix, though the build wasn't broken for me.
283 2007-07-09 Murray Cumming <murrayc@murrayc.com>
285 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
286 Do not try to unref a NULL folder store, to avoid a runtime warning.
287 This seems to happen sometimes when changing accounts settings.
289 2007-07-09 Murray Cumming <murrayc@murrayc.com>
291 * src/modest-tny-account-store.c:
292 (modest_tny_account_store_instance_init),
293 (modest_tny_account_store_finalize),
294 (on_account_settings_hide), (on_idle_wrong_password):
295 Use a GHashTable to ensure that we only show one account settings
296 dialog per modest account. This avoids us having a dialog open for
297 both the store and transport accounts, or due to repeated get_password()
298 calls that shouldn't happen anyway.
300 2007-07-09 Murray Cumming <murrayc@murrayc.com>
302 * src/maemo/modest-maemo-utils.c: (on_hide),
303 (modest_maemo_show_dialog_and_forget): Handle the response, because
304 the window is not even hidden by default.
306 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
307 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
308 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
309 which seems to prevent some modality problems.
311 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
312 Ignore user cancellation errors.
314 * src/modest-account-mgr-helpers.h:
315 * src/modest-account-mgr-helpers.c:
316 Added modest_server_account_get_password() and
317 modest_server_account_get_has_password() to avoid direct use of
320 * src/maemo/modest-account-settings-dialog.h:
321 * src/maemo/modest-account-settings-dialog.c:
322 (modest_account_settings_dialog_init): Store the notebook so we can
324 Added modest_account_settings_dialog_switch_to_user_info().
326 * src/modest-tny-account-store.c:
327 (get_password): When the password in the account settings is wrong (we think),
328 show the relevant page of the account settings dialog, in the mainloop.
329 However, we currently get many of these at once because cancel does not
331 (forget_password): Do not forget the password
332 from the account settings, because this causes side-effects when
333 tinymail seems to call it at strange time, maybe because of how we
334 are cancelling get_password().
335 (modest_tny_account_store_alert): Ignore user cancellations.
337 2007-07-09 Murray Cumming <murrayc@murrayc.com>
339 * src/maemo/modest-maemo-utils.h:
340 * src/maemo/modest-maemo-utils.c:
341 Added modest_maemo_show_information_note_and_forget() for use instead of
342 gtk_dialog_run() when the response is not needed, to avoid an extra
343 mainloop which could cause a hang.
345 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
346 Use the logical IDs for the error message, though they are not
347 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
348 because gtk_dialog_run() caused a hang here (the window did not close).
349 This fixes projects.maemo.org bug NB#62646.
351 2007-07-09 Murray Cumming <murrayc@murrayc.com>
353 * src/modest-account-mgr-helpers.h:
354 * src/modest-account-mgr-helpers.c:
355 Added modest_account_mgr_get_store_protocol().
357 * src/maemo/modest-account-view-window.c:
358 (on_delete_button_clicked): Show different warning text depending on
359 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
360 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
363 2007-07-09 Murray Cumming <murrayc@murrayc.com>
365 * src/maemo/modest-msg-edit-window.c:
366 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
367 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
369 2007-07-07 Armin Burgmeier <armin@openismus.com>
371 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
372 ckdg_ib_maximum_characters_reached from correct package.
374 * src/modest-ui-actions.c: Show an error message when a folder could
375 not be created. Tinymail does not give us specific error codes about
376 what has gone wrong, so we assume that a folder with that name
377 already exists, though there might be other reasons.
379 2007-07-06 Murray Cumming <murrayc@murrayc.com>
381 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
382 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
383 give a more exact error message that can be partly translated.
385 2007-07-05 Murray Cumming <murrayc@murrayc.com>
387 * src/maemo/modest-address-book.c:
388 (select_email_addrs_for_contact): Specify a default window size for the
389 select-email-address dialog, so that it is probably big enough for the
390 title. This should fix projects.maemo.org bug NB#62277.
392 2007-07-05 Murray Cumming <murrayc@murrayc.com>
394 * src/maemo/easysetup/modest-easysetup-wizard.c:
395 (create_page_complete_easysetup): Use
396 gtk_widget_set_size() request to ensure that the text wraps
399 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
401 * src/maemo/easysetup/modest-easysetup-wizard.c:
402 (on_entry_invalid_character), (create_page_account_details),
403 (create_page_user_details):
404 Use new API of ModestValidatingEntry. But for some reason the banner is
405 not shown. I will have to investigate that further.
407 * src/widgets/modest-validating-entry.c: (on_insert_text),
408 (modest_validating_entry_set_func):
409 * src/widgets/modest-validating-entry.h:
410 Added a new callback function to be able to react to prevented
411 characters whitespaces to e.g show a banner.
413 2007-07-05 Armin Burgmeier <armin@openismus.com>
415 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
416 notification of HildonNumberEditor instead of remembering the port
417 number. Thanks to Johannes for pointing this out.
419 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
421 * src/maemo/easysetup/modest-easysetup-wizard.c:
422 Check if there are any user changes before showing a confirmation
423 dialog (projects.maemo.org NB#60946)
425 2007-07-05 Armin Burgmeier <armin@openismus.com>
427 * src/maemo/modest-account-settings-dialog.c: Remember custom port
428 number at the beginning of the dialog and set the modified flag at the
429 end if the port number has changed. This is necessary because
430 HildonNumberEditor does not support notification when the value has
433 2007-07-05 Murray Cumming <murrayc@murrayc.com>
435 * src/modest-ui-actions.c:
436 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
437 a connection before asking anything else. Correct the check for the destination
438 folder so that it succeeds when online.
439 This fixed projects.maemo.org bug NB#61645.
441 2007-07-05 Murray Cumming <murrayc@murrayc.com>
443 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
444 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
445 to fix projects.maemo.org bug NB#62439.
447 2007-07-05 Murray Cumming <murrayc@murrayc.com>
449 * src/modest-tny-account.c: (on_connection_status_changed):
450 Really do not use tny_device_force_offline() here. See the previous comment.
452 2007-07-04 Murray Cumming <murrayc@murrayc.com>
454 * src/modest-tny-account.c: (on_connection_status_changed):
455 Do not use tny_device_force_offline() when tinymail says that something
456 went wrong with the connection. It seems to report this unnecessarily.
458 2007-07-04 Murray Cumming <murrayc@murrayc.com>
460 * src/maemo/modest-connection-specific-smtp-window.c:
461 (modest_connection_specific_smtp_window_init):
462 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
463 does not seem to have any effect in osso 1.1 (though it works in
464 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
466 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
468 * src/maemo/modest-connection-specific-smtp-window.c:
469 Fix UI specification problems with projects.meamo.org NB#60479
471 2007-07-04 Murray Cumming <murrayc@murrayc.com>
473 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
474 clue when this has failed, because the error dialog is not always shown
475 (at least in earlier version).
477 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
478 GError message, because the generic error dialog is not helpful.
480 'This message is not currently available (can't let a new connection go online)'
481 when trying to open an IMAP message.
483 (_modest_ui_actions_open): Offer a connection when some messages would
484 have to be downloaded and we are offline.
486 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
488 * src/widgets/modest-folder-view.c:
489 Don't check for MERGE type anymore as we use the correct type
491 NOTE: For the last two changes you need to update your tinymail copy
492 because of API changes!
494 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
496 * src/modest-tny-local-folders-account.c:
497 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
498 (see projects.maemo.org NB#61580)
500 2007-07-04 Murray Cumming <murrayc@murrayc.com>
502 * src/modest-tny-account.c: (on_connection_status_changed):
503 Commented out the call to modest_platform_connect_and_wait() because this
504 seems to always hang, and I would like to know if this is the only thing
505 that causes a hang when showing the connection dialog.
506 It is not very useful anyway.
508 2007-07-04 Murray Cumming <murrayc@murrayc.com>
510 * src/maemo/modest-msg-view-window.c:
511 (modest_msg_view_window_select_next_message):
513 * src/modest-platform.h:
514 * src/maemo/modest-platform.c:
515 Added modest_platform_connect_and_wait(), which calls
516 tny_maemo_conic_device_connect() always in the main thread, by calling it
517 in an idle handler and waiting for the idle handler to run. It should be
518 in the main thread because it uses GTK+ UI code. It just returns TRUE
519 if the device is already online.
521 There is some nasty code to ensure that subsequent calls to
522 modest_platform_connect_and_wait() just wait for the first one to finish,
523 by checking repeatedly in another idle handler. This is necessary,
524 because other threads (or even the main thread, via another idle handler)
525 can call modest_platform_connect_and_wait() while
526 modest_platform_connect_and_wait() is running.
528 (modest_platform_connect_and_wait_if_network_account),
529 (modest_platform_connect_and_wait_if_network_folderstore):
530 Convenience functions that calls modest_platform_connect_and_wait() if
531 the account or folder might want network access.
533 * src/modest-mail-operation.c:
534 (modest_mail_operation_update_account):
535 * src/modest-ui-actions.c: (download_uncached_messages),
536 (modest_ui_actions_on_rename_folder), (delete_folder),
537 (modest_ui_actions_on_main_window_move_to),
538 (modest_ui_actions_on_msg_view_window_move_to):
539 * src/widgets/modest-folder-view.c:
540 (drag_and_drop_from_folder_view):
541 Offer a connection if we are offline.
543 * src/modest-tny-account.c: (on_connection_status_changed):
544 Document this as only handling errors during network operations in progress,
545 and replace the idle code with a simple call to
546 modest_platform_connect_and_wait(), which does this instead.
548 2007-07-03 Murray Cumming <murrayc@murrayc.com>
550 * src/modest-tny-account.c:
551 (modest_tny_account_get_special_folder): (util_on_idle),
552 Handle the GError so we can see when tny_folder_store_get_folders()
553 fails, as it currently does while something else is connecting.
555 Added util_run_in_main_thread_and_wait()
556 which uses an idlen handler and mainloop to ensure that the function
557 is called in the main thread.
558 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
559 to make sure that we call attempt the connection in the mainloop only,
560 which might solve some hangs.
562 2007-07-03 Murray Cumming <murrayc@murrayc.com>
564 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
565 be found by their display name. This is never useful.
566 * src/modest-tny-account-store.c: (on_account_removed): Find the account
567 by its ID, instead of trying to use its ID as its display name.
569 * src/modest-tny-account-store.h:
570 * src/modest-tny-account.c:
571 (modest_tny_account_get_special_folder): Add a g_warning() when
572 tny_folder_store_get_folders() returns an empty list for the maildir.
574 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
575 Add a g_warning() when this returns NULL, because that it not allowed
578 2007-07-02 Armin Burgmeier <armin@openismus.com>
580 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
581 note when trying to cancel the wizard. This fixes projects.maemo.org
584 2007-07-02 Murray Cumming <murrayc@murrayc.com>
586 * src/modest-tny-account.h:
587 * src/modest-tny-account.c:
588 (modest_tny_account_new_from_server_account),
589 (modest_tny_account_new_from_server_account_name),
590 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
591 because this must now be set before setting the proto. This is usd in
592 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
593 warning in camel_session_get_service() caused by
594 tny_camel_transport_account_prepare().
596 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
599 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
601 * src/maemo/modest-connection-specific-smtp-edit-window.c:
603 (modest_connection_specific_smtp_edit_window_init):
605 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
608 2007-06-29 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-tny-account.c:
611 (modest_tny_account_new_from_server_account):
612 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
613 now uses to request a connection when it needs one, and which it uses
614 to tell us that something is wrong with the connection, so we can force
615 the accounts offline to prevent further problems.
618 * src/modest-init.c: (init_default_settings):
619 * src/modest-mail-operation.c:
620 (modest_mail_operation_update_account):
621 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
622 This should not be necessary anymore. Do not set the conf key that
623 determined this (it was always TRUE and not set anywhere else).
625 * src/modest-ui-actions.h: Remove unused and unimplemented
626 modest_ui_actions_on_online_toggle_toggled().
628 2007-06-29 Murray Cumming <murrayc@murrayc.com
630 * src/maemo/modest-main-window.c: (connect_signals):
631 Don't connect to delete_event twice. Maybe this was harmless.
633 2007-06-29 Murray Cumming <murrayc@murrayc.com
635 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
636 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
637 Debug output to give some more clue when a folder move is not allowed.
639 2007-06-28 Murray Cumming <murrayc@murrayc.com
641 * src/modest-tny-account.c: (on_modest_file_system_info),
642 (modest_tny_account_get_mmc_account_name):
643 Always call the callback, without checking whether the name has changed.
644 * src/widgets/modest-folder-view.c: (strings_are_equal),
645 (on_model_foreach_set_name), (on_get_mmc_account_name),
646 (text_cell_data): Compare the name here, and use the name from
647 the account rather than from the
648 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
649 if the name was changed after the account was added to the model.
650 That's a tinymail bug but not one that I want to fix now.
652 This finally fixes projects.maemo.org bug NB#59301.
654 2007-06-27 Armin Burgmeier <armin@openismus.com>
656 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
659 2007-06-27 Murray Cumming <murrayc@murrayc.com
661 * src/modest-tny-account.h:
662 * src/modest-tny-account.c:
663 Added modest_tny_account_get_mmc_account_name(), to set the memory
664 card name asynchronously for the given account and then notify.
665 (modest_tny_account_new_for_local_folders): Use this new function instead
666 of using hildon_file_system_info_async_new() directly.
668 * src/widgets/modest-folder-view.c: (text_cell_data):
669 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
670 gtk_tree_model_row_changed() when it is available.
672 This should fix projects.maemo.org bug NB#59301.
674 2007-06-27 Murray Cumming <murrayc@murrayc.com
676 * src/modest-mail-operation.c: (update_account_thread),
677 (get_msgs_full_thread): Fix typo failures in the revert
680 2007-06-27 Murray Cumming <murrayc@murrayc.com
682 * src/maemo/modest-maemo-global-settings-dialog.c:
683 (idle_select_default_focus):
684 * src/modest-mail-operation.c: (idle_notify_progress),
685 (idle_notify_progress_once), (set_last_updated_idle),
686 (update_account_thread), (get_msgs_full_thread):
687 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
688 * src/widgets/modest-header-view.c:
689 (idle_notify_headers_count_changed_destroy),
690 (idle_notify_headers_count_changed):
691 Reverted the additions of gdk_threads_enter/leave(), in case this
692 helps with a startup hang on the device.
694 2007-06-26 Armin Burgmeier <armin@openismus.com>
696 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
697 for supported secure authentication methods from server by
698 gtk_dialog_run(), saving CPU time and a potential race condition.
700 2007-06-26 Armin Burgmeier <armin@openismus.com>
702 * src/maemo/modest-maemo-utils.h:
703 * src/maemo/modest-maemo-utils.c: Added a
704 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
705 only error code to tell the calling code when the user canceled the
708 * src/maemo/modest-account-settings-dialog.h:
709 * src/maemo/modest-account-settings-dialog.c:
710 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
711 message if the retrieval of secure authentication methods was canceled
712 by the user. Perform the check before saving anything to configuration
713 to not end up with half-committed configuration changes, do not show
714 a "Saving to configuration failed" note when authentication methods
715 could not be retrieved.
717 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
720 2007-06-26 Murray Cumming <murrayc@murrayc.com>
722 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
723 Only return the first level of folders under accounts, because the
724 osso-global-search UI spec doesn't want the rest.
725 This fixed projects.maemo.org bug NB#61811.
727 2007-06-26 Murray Cumming <murrayc@murrayc.com>
729 * src/modest-tny-account-store.c:
730 * src/modest-tny-account-store.h:
731 Added modest_tny_account_is_memory_card_account().
732 * src/maemo/modest-main-window.c: (create_details_widget):
733 Show the same information items for the memory card as we show for the
734 local-folders, to fix projects.maemo.org bug NB#59307.
736 2007-06-26 Murray Cumming <murrayc@murrayc.com>
738 * src/modest-tny-account-store.c: (get_password):
739 Added some checks for NULL to maybe prevent crashes, though I think
740 it was Philip's last commit that actually prevented the crash here
741 when creating a first new account.
742 But the new account is still not usable (no messages are shown)
743 until a restart of the application.
745 2007-06-26 Murray Cumming <murrayc@murrayc.com>
747 * src/maemo/modest-maemo-global-settings-dialog.c:
748 (idle_select_default_focus):
749 * src/modest-mail-operation.c: (idle_notify_progress),
750 (idle_notify_progress_once), (idle_notify_update_account_queue),
751 (set_last_updated_idle), (update_account_thread),
752 (notify_get_msgs_full), (get_msgs_full_destroyer),
753 (get_msgs_full_thread):
754 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
755 * src/widgets/modest-header-view.c:
756 (idle_notify_headers_count_changed_destroy),
757 (idle_notify_headers_count_changed):
758 Use gdk_threads_enter() and gdk_threads_enter_leave() in
759 all idle handlers, because some other thread could be blocking
760 the GDK lock, so that it can do GUI stuff.
762 2007-06-26 Murray Cumming <murrayc@murrayc.com>
764 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
765 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
766 (on_idle_send_receive), (on_idle_open_default_inbox):
767 * src/maemo/modest-msg-edit-window.c:
768 (modest_msg_edit_window_attach_file_noninteractive):
769 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
770 to prevent a hang. I don't quite understand why these are necessary,
771 beause we should already be in the main loop. I guess something outside
772 of the main loop is taking the lock.
774 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
775 we are really using URIs, and use files that are more likely to exist.
777 2007-06-26 Murray Cumming <murrayc@murrayc.com>
779 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
780 necessary because configure.ac now defines different variables.
782 2007-06-26 Murray Cumming <murrayc@murrayc.com>
784 * libmodest-dbus-client/libmodest-dbus-client.c:
785 * libmodest-dbus-client/libmodest-dbus-client.h:
786 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
787 libmodest_dbus_client_compose_mail() is what things actually use.
789 * src/dbus_api/modest-dbus-api.h:
790 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
791 * tests/dbus_api/Makefile.am:
792 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
795 2007-06-26 Murray Cumming <murrayc@murrayc.com>
797 * src/modest-init.c: (modest_init_local_folders):
798 For memory-card (or other non local-folders) maildir accounts,
799 always create an Archive folder, so that there is somewhere to put
800 messages. This should be less confusing, because the user does not need
801 to guess that the need to create a folder.
803 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
805 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
806 Fixed icon size by using (50, 50) which is the same as defined by
809 2007-06-25 Armin Burgmeier <armin@openismus.com>
811 * src/widgets/modest-window-mgr.c:
813 * configure.ac: Correctly recognize hildon-notify presence and fixed
814 the build without it being installed.
816 2007-06-25 Murray Cumming <murrayc@murrayc.com>
818 * libmodest-dbus-client/libmodest-dbus-client.c:
819 (libmodest_dbus_client_search): Fix the build. Sorry.
820 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
821 (reply_forward_cb): Initialize variables to fix the build.
823 * src/modest-tny-account-store.c:
824 (modest_tny_account_store_get_tny_account_by): Fix the account URI
825 comparison (a silly typo) so that email search results can be opened
826 when there are more than one account.
828 2007-06-25 Murray Cumming <murrayc@murrayc.com>
830 * libmodest-dbus-client/libmodest-dbus-client.c:
831 (libmodest_dbus_client_search),
832 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
833 instead of 1 second, because the search gets folders and messages from
834 the server, which can take a long time. When it times out,
835 osso-global-search will report no results.
837 We need to specify whether we should search only cached information
838 (maybe with a user preference), and the osso-email-search-plugin
839 API should really be improved to allow that option, and to allow results
840 to be delivered asynchronously in batches.
842 2007-06-25 Murray Cumming <murrayc@murrayc.com>
844 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
845 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
846 GTK_ICON_SIZE_DIALOG is probably the wrong size.
848 2007-06-25 Murray Cumming <murrayc@murrayc.com>
850 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
851 that is an empty string. D-Bus seems to give us these instead of NULL.
853 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
855 * src/dbus_api/modest-dbus-callbacks.c:
856 * src/maemo/easysetup/modest-easysetup-wizard.h:
857 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
858 * src/maemo/modest-connection-specific-smtp-edit-window.c:
859 (modest_connection_specific_smtp_edit_window_init):
860 * src/maemo/modest-maemo-global-settings-dialog.c:
862 * src/maemo/modest-maemo-utils.c:
863 (modest_maemo_utils_setup_images_filechooser):
864 * src/maemo/modest-main-window.c: (create_details_widget):
865 * src/maemo/modest-msg-edit-window.c:
866 (modest_msg_edit_window_attach_file_noninteractive),
867 (modest_msg_edit_window_color_button_change),
868 (modest_msg_edit_window_set_zoom):
869 * src/modest-mail-operation.c: (update_account_thread):
870 * src/modest-tny-account-store.c:
871 * src/modest-tny-account.c:
872 * src/widgets/modest-global-settings-dialog.c:
873 * src/widgets/modest-window.h:
877 2007-06-25 Murray Cumming <murrayc@murrayc.com>
879 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
880 * src/modest-search.c: (modest_search_folder),
881 (modest_search_all_accounts): Actually search only in the specified folder,
882 doing a simple match on the folder ID.
883 * src/modest-search.h: Added a folder field to the ModestSearch struct,
884 and added some documentation.
886 2007-06-22 Armin Burgmeier <armin@openismus.com>
888 * src/maemo/modest-maemo-utils.h:
889 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
890 modest_maemo_utils_get_supported_secure_authentication_methods.
892 * src/maemo/easysetup/modest-easysetup-wizard.c:
893 * src/maemo/modest-account-settings-dialog.c: Show correct error if
894 one occured, not just "Server does not support secure authentication".
896 2007-06-22 Murray Cumming <murrayc@murrayc.com>
898 * src/modest-tny-account-store.c: (get_password):
899 Restored the call to tny_account_set_user() because Philip seems to have
900 stopped this from crashing (by not using the freed string). It still does
901 not work, but now we can test it.
903 2007-06-22 Murray Cumming <murrayc@murrayc.com>
905 * src/maemo/modest-msg-edit-window.c: (init_window):
906 Comment out use of an uninitialzed GtkScrolledWindow variable,
907 to fix the build and stop a crash. Yet again.
909 2007-06-22 Murray Cumming <murrayc@murrayc.com>
911 * src/modest-tny-account-store.c: (get_password):
912 Remove the call to tny_account_set_user() because this actually crashes.
913 As mentioned in the last commit, it is known to not work anyway.
915 2007-06-22 Murray Cumming <murrayc@murrayc.com>
917 * src/modest-tny-account-store.c: (get_password):
918 Use tny_account_set_username() to tell tinymail that the username might
919 have changed too. But tinymail ignores this: see projects.maemo.org
921 * src/modest-ui-actions.c:
922 (modest_ui_actions_on_password_requested): Remove the useless attempt to
923 reset the connection when changing the username, and improve the comments.
924 Save the changed username to gconf at least, so it is used when Modest is
927 2007-06-21 Murray Cumming <murrayc@murrayc.com>
929 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
930 Do not use a query, so that we get all folders, including for POP and
931 local-folders. They work as search criteria too.
932 This fixes projects.maemo.org bug NB#57740.
934 2007-06-21 Murray Cumming <murrayc@murrayc.com>
936 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
937 Comment out the use of hildon_notification_set_sound() because it is
938 not declared, to fix the build. Warnings are serious, people.
940 2007-06-21 Armin Burgmeier <armin@openismus.com>
942 * src/maemo/modest-maemo-utils.h:
943 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
944 modest_maemo_utils_get_supported_secure_authentication_methods()
945 to query authentication methods for a specific user. This should fix
946 projects.maemo.org bug NB#61369.
948 * src/maemo/easysetup/modest-easysetup-wizard.c:
949 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
952 2007-06-21 Murray Cumming <murrayc@murrayc.com>
954 * libmodest-dbus-client/libmodest-dbus-client.h:
955 * libmodest-dbus-client/libmodest-dbus-client.c:
956 (modest_dbus_message_iter_get_search_hit),
957 (libmodest_dbus_client_search):
958 Reorganised and commented this.
959 Removed modest_search_hit_free() from the public API because it
962 Added libmodest_dbus_client_get_folders() and
963 modest_folder_result_list_free().
965 * src/dbus_api/modest-dbus-api.h:
966 * src/dbus_api/modest-dbus-callbacks.c:
967 (modest_dbus_req_filter): Commented. Moved most code to
968 on_dbus_method_search() and added on_dbus_method_get_folders().
970 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
971 of the extra D-Bus handler.
973 * tests/dbus_api/Makefile.am:
974 * tests/dbus_api/test_get_folders.c: New test for
975 libmodest_dbus_client_get_folders(). This seems to return an empty list
976 at the moment. That could be the same error that causes the message list
977 to be empty sometimes.
978 This should help with projects.maemo.org bug NB#57740.
980 2007-06-21 Armin Burgmeier <armin@openismus.com>
982 * src/modest-mail-operation.c: Do not call
983 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
984 notify the operation's end after having set the status to CANCELED for
985 the operation queue to listen on. This fixes a deadlock when there
986 were mail operations in the queue during its finalization.
988 * src/modest-singletons.c: Reordered uninitialization of the account
989 manager to happen after the mail operation queue was uninitialized
990 because the mail operation's in the queue might still try to access
991 the account manager (see modest_mail_operation_notify_end()). This
992 fixes a potential crash when terminating the application.
994 2007-06-21 Murray Cumming <murrayc@murrayc.com>
996 * src/modest-search.c:
997 (search_mime_part_and_child_parts): Moved some code here so we
998 can search recursively in child folders.
999 (modest_search_folder): Search in the message as a mime part, instead
1000 of just its child mime parts.
1001 (read_chunk), (search_mime_part_ogs):
1002 Check how many bytes were read, to prevent an endless loop.
1003 Searching in message bodies now works. This finishes the fix for
1004 projects.maemo.org bug NB#61007.
1006 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1008 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1009 Add a g_warning when the item is not a folder.
1011 * src/modest-ui-dimming-rules.c:
1012 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1013 when selected item is not a folder (for instance, an account), because
1014 the UI spec only talks about folders.
1015 I am not sure what the UI spec wants, so this might not totally fix
1016 projects.maemo.org bug NB#60794.
1018 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1020 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1021 (load_from_file): Sort the list. The unsorted list would be more noticeable
1022 in non-English locales.
1024 * src/maemo/modest-msg-edit-window.c:
1025 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1026 warning and fix the build.
1028 * src/maemo/modest-progress-bar-widget.c:
1029 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1030 avoid a g_warning, and probably to avoid a crash.
1032 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1034 * src/modest-search.c: (modest_search_folder): Check for a GError
1035 when calling tny_folder_get_headers(), to show that this is not the cause
1038 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1040 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1041 Actually set the body query instead of the subject query.
1043 * src/modest-search.c: (search_mime_part_ogs),
1044 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1045 which would probably cause it to fail if we got this far.
1047 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1048 to simplify the code.
1049 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1050 be causing search-in-body to fail.
1052 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1054 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1056 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1057 Better debug message when the folder cannot be found.
1058 This should help with fixing projects.maemo.org bug #61287.
1059 * src/modest-search.c: (add_hit): Do not leak the furl string.
1061 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1063 * src/modest-ui-actions.c:
1064 (modest_ui_actions_on_folder_selection_changed):
1065 Do not special-case TNY_MERGE_FOLDER here, because
1066 modest_tny_folder_get_account() already does that. This fixes
1067 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1068 shown when the Outbox was selected).
1070 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1072 * libmodest-dbus-client/libmodest-dbus-client.c:
1073 (_dbus_iter_get_string_or_null): Initialize the string variable in
1074 case this helps with Dirk's crash.
1076 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1078 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1079 though it is not implemented yet (this function is maybe not even used),
1080 to avoid breaking ABI in future.
1081 * libmodest-dbus-client/libmodest-dbus-client.c:
1082 (get_attachments_string): Moved some code into this generic function.
1083 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1084 sends email. It is maybe not used.
1085 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1086 (on_send_mail): Use attachments.
1088 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1089 * src/maemo/modest-msg-edit-window.c:
1090 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1091 a filename before using it, to fix projects.maemo.org bug NB#58233.
1093 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1095 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1096 Initialize the continue_download variable to fix the build, and probably
1097 to fix randome behaviour.
1099 2007-06-18 Armin Burgmeier <armin@openismus.com>
1101 * src/modest-tny-send-queue.h:
1102 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1103 the queue so we can later show it in the UI. Replaced
1104 modest_tny_send_queue_msg_is_being_sent() by
1105 modest_tny_send_queue_get_msg_status().
1107 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1109 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1110 gpointer. This probably was not harmful, but just to be sure.
1112 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1114 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1115 Fix the build, but leave the function broken on Bora, because
1116 hildon_uri_action_get_service() does not exist.
1117 osso_uri_action_get_service() does not exist either, it seems.
1119 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1121 * src/modest-tny-account.c:
1122 (modest_tny_account_new_from_server_account):
1123 Uncommented the url debug output again, because it is useful for
1124 debugging, as I said in the comment.
1126 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1128 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1130 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1131 for Mameo Bora, to fix the build.
1133 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1136 Fixed build with hildon < 0.99
1138 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1139 Check if the selected account is busy instead of checking all accounts
1141 * src/modest-account-mgr-priv.h:
1142 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1143 (modest_account_mgr_init), (compare_account_name),
1144 (modest_account_mgr_set_account_busy),
1145 (modest_account_mgr_account_is_busy):
1146 * src/modest-account-mgr.h:
1147 Added busy information to the account manager. It possible to
1148 set an account to busy or not busy now.
1150 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1151 (modest_mail_operation_update_account),
1152 (modest_mail_operation_notify_end):
1153 Set the account to busy/not busy depending on the operation state.
1155 * src/widgets/modest-account-view.c:
1156 (modest_account_view_finalize), (get_last_updated_string),
1157 (update_account_view), (on_account_busy_changed), (init_view):
1158 Show string "Refreshing..." if the account is currently busy.
1160 All this fixes projects.maemo.org bug NB#59711
1162 2007-06-14 Armin Burgmeier <armin@openismus.com>
1164 * src/widgets/modest-attachments-view.h:
1165 * src/widgets/modest-attachments-view.c: Added
1166 modest_attachments_view_has_attachments() and fixed coordinate
1167 transformation in get_att_view_at_coords(). This fixes attachment
1170 * src/widgets/modest-msg-view.c: Make use of
1171 modest_attachments_view_has_attachments() to decide whether to show
1172 attachments in the header.
1174 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1176 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1177 (on_change), (on_combo_security_changed),
1178 (modest_connection_specific_smtp_edit_window_init),
1179 (modest_connection_specific_smtp_edit_window_set_connection),
1180 (modest_connection_specific_smtp_edit_window_is_dirty):
1181 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1182 * src/maemo/modest-connection-specific-smtp-window.c:
1185 Show an comfirmation dialog for the smpt-edit-window if there are
1186 unsaved changes and the user hits cancel.
1187 (projects.maemo.org bug NB#60479)
1189 2007-06-14 Armin Burgmeier <armin@openismus.com>
1191 * src/maemo/easysetup/modest-easysetup-wizard.c:
1192 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1193 address" info in banner instead of node, and select all the text as
1194 per UI spec. This fixes projects.maemo.org bug NB#60550.
1196 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1198 reviewed by: <delete if not using a buddy>
1200 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1201 * src/modest-ui-actions.c: (folder_refreshed_cb):
1203 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1205 * src/widgets/modest-folder-view.c: (filter_row):
1206 Explictly filter out the per-account outbox accounts. I don't know why
1207 these only sometimes show up, but now they should never show up in the UI.
1208 This should fix projects.maemo.org bug NB#60160.
1210 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1212 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1213 when the toolbar does not exist yet.
1214 * src/modest-widget-memory.c: (save_settings_header_view):
1215 Added g_warnings() to help us to discover when we are trying to set
1216 an empty columns list in gconf.
1218 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1220 * src/modest-init.h:
1221 * src/modest-init.c:
1222 Added modest_init_get_default_header_view_column_ids().
1224 * src/modest-widget-memory.c: (restore_settings_header_view):
1225 Use the new function to get defaults, if the gconf key is empty,
1226 instead of not creating any columns. This seems to fix the
1227 empty right-hand pane problems.
1229 * src/widgets/modest-header-view.h: Improved documentation.
1231 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1233 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1234 Revert the use of the display name as the account name, because this
1235 is generally wrong and would break the code that follows.
1237 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1239 * src/maemo/easysetup/modest-easysetup-wizard.c:
1240 (check_for_supported_auth_methods), (on_before_next),
1243 More correct fix for projects.maemo.org bug NB# 58991
1244 Do not longer accept AUTH_PASSWORD as secure method and choose
1245 correct method when creating the account.
1247 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1249 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1250 Fixed projects.maemo.org bug NB# 58991
1252 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1254 * src/modest-init.c: (modest_init_init_core),
1255 (modest_init_local_folders): Fixed compilation errors.
1257 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1259 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1260 Remove unnecessary lib/include, though it is good in principle when needed.
1262 * src/modest-init.c: (modest_init_one_local_folder),
1263 (modest_init_local_folders):
1264 * src/modest-init.h: Initialize the .modest library for memory cards,
1265 instead of just doing nothing for them. This should allow us to create
1266 folders there, fixing projects.maemo.org bug NB#59297.
1268 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1270 * libmodest-dbus-client/libmodest-dbus-client.c:
1271 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1272 (libmodest_dbus_client_compose_mail),
1273 (libmodest_dbus_client_open_message),
1274 (libmodest_dbus_client_send_and_receive),
1275 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1277 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1278 (on_idle_open_message), (modest_dbus_req_handler),
1279 (search_result_to_message), (modest_dbus_req_filter):
1280 * src/modest-search.c: (add_hit), (modest_search_folder),
1281 (modest_search_all_accounts): Improved debug messages.
1283 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1285 * src/modest-tny-account-store.c:
1286 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1289 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1292 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1294 * src/modest-tny-account-store.c: (get_server_accounts):
1295 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1296 even when there are no accounts, so that the Outbox folder is always
1297 visible. This fixes projects.maemo.org bug NB#60158.
1299 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1301 * src/maemo/modest-main-window.c: (create_details_widget):
1302 Use the mcen_va_never logical ID.
1304 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1306 * src/dbus_api/modest-dbus-api.h:
1307 * src/dbus_api/modest-dbus-callbacks.c:
1308 (on_idle_open_default_inbox), (on_open_default_inbox),
1309 (modest_dbus_req_handler):
1310 Added a new OpenDefaultInbox method.
1312 * libmodest-dbus-client/libmodest-dbus-client.h:
1313 * libmodest-dbus-client/libmodest-dbus-client.c:
1314 Added libmodest_dbus_client_open_default_inbox() to call the new
1315 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1316 though it should maybe be used by a new osso-email-interface function.
1318 * tests/dbus_api/Makefile.am:
1319 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1322 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1324 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1325 NULL, so that the signals get all the keys. This should not actually
1326 change any behaviour because we currently update everything when anything
1329 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1331 * src/widgets/modest-folder-view.c: (text_cell_data),
1332 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1333 (find_inbox_iter): If tinymail tells us that the folder is
1334 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1335 This causes the inbox to be selected at startup, fixing part of
1336 projects.maemo.org bug NB#56305.
1338 * src/modest-ui-dimming-rules.c:
1339 (modest_ui_dimming_rules_on_tools_smtp_servers):
1340 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1341 the SMTP servers menu item.
1342 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1343 that the SMTP Servers menu item is dimmed when there are no accounts,
1344 as a future version of the UI spec will require. This fixes
1345 projects.maemo.org bug NB#56305.
1347 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1349 * src/maemo/modest-maemo-utils.c:
1350 (modest_maemo_utils_get_supported_secure_authentication_methods):
1351 Added label to dialog instead of unreadable title
1353 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1354 (modest_main_window_new):
1355 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1358 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1359 * src/modest-account-mgr.h:
1360 Added method to avoid code duplication
1362 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1363 (modest_ui_actions_on_send_receive):
1364 Use modest_account_mgr_has_accounts
1366 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1368 * src/maemo/easysetup/modest-presets.c:
1369 (modest_presets_get_info_server_security): Do not report secure auth
1371 * src/modest-protocol-info.c: Use the defines for the gconf key names
1372 for secure authentication. This was not working because we were writing
1373 Password and reading password, and the check was case sensitive.
1374 With this, gmail now works for receiving and sending when created via
1377 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1379 * src/maemo/easysetup/modest-presets.c:
1380 (modest_presets_get_info_server_security): Correct the key name for
1381 SecureSmtp, because it seems to be case-sensitive.
1382 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1383 Do not try to get the 0th notebook page if there are 0 pages, to
1384 avoid a g_warning().
1386 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1388 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1389 Prevent use of the new notification feature for now, because it currently
1390 shows one dialog for each new email, which is annoying.
1392 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1394 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1395 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1396 when no country was selected, so that we show the global ones.
1397 * src/maemo/easysetup/modest-presets.c:
1398 (modest_presets_get_providers): Return only the global providers, not
1399 all providers when mmc=0 was requested.
1401 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1403 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1404 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1405 provider ID in the combo.
1407 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1408 Do not show the page numbers, because it would be confusing when we add
1409 the 2 extra pages for the custom setup, when the user chooses the "Other"
1410 provider. This fixes projects.maemo.org bug NB#59028
1412 * src/modest-init.c: (modest_init_init_core),
1413 (modest_init_local_folders):
1414 * src/modest-init.h:
1415 * src/modest-tny-account.c:
1416 (modest_tny_account_new_for_local_folders): Do not create default folders
1417 for the memory card. This should fix projects.maemo.org bug NB#59328.
1419 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1421 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1422 Free the changed_conf_keys string items. They are already freed in the
1423 idle handler if that runs first.
1425 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1427 * src/modest-ui-actions.c:
1428 (modest_ui_actions_on_password_requested): Check that the server name
1429 is not NULL, because I just saw a password dialog with (null) as the
1432 * src/modest-tny-folder.[h|c]: Added
1433 modest_tny_folder_is_memory_card_folder().
1434 * src/modest-ui-dimming-rules.c:
1435 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1436 menu item for memory cards, as per the UI spec (section 7.4). This should
1437 fix projects.maemo.org bug NB#59297.
1439 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1441 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1442 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1443 is another problem with the code, see Murray's comment at line 772)
1445 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1447 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1448 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1449 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1450 (load_from_file), (easysetup_country_combo_box_init),
1451 (easysetup_country_combo_box_get_active_country_ids),
1452 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1453 instead of just one ID, to avoid duplicate country names in the UI.
1455 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1456 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1457 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1458 a single ID, avoiding duplicate providers.
1459 * src/maemo/easysetup/modest-easysetup-wizard.c:
1460 (on_combo_account_country): Adapt to use a list.
1462 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1464 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1465 keys changed in the last X seconds.
1467 * src/modest-account-mgr.h:
1468 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1469 (on_key_change), (modest_account_mgr_class_init),
1470 (modest_account_mgr_init), (modest_account_mgr_finalize):
1471 As the keys are changed, save them in a GSList* and signal that GSList*
1472 further every X seconds, to batch changes, to allow us to do just one
1473 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1474 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1476 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1477 changed signal signature.
1479 * src/modest-conf.c: (modest_conf_set_list),
1480 (modest_conf_on_change): Reenable notification.
1482 (modest_conf_maemo_fake_on_change): Comment out the hack that
1483 notified immediately instead of asynchronously.
1485 * src/widgets/modest-account-view.h:
1486 * src/widgets/modest-account-view.c:
1487 (update_account_view): Select the previously-selected account ID,
1488 if possible. This fixes projects.maemo.org bug NB#56933.
1490 (on_account_changed), (on_account_removed),
1491 (modest_account_view_select_account):
1493 Remove the block/unblock functions
1494 because they were not useful.
1496 * src/maemo/modest-account-view-window.c:
1497 (on_delete_button_clicked), (on_edit_button_clicked),
1498 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1500 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1502 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1503 Improve the error dialog to show Incorrect Account Settings, which seems
1504 clearer, and say that the internal error message (to be removed from the
1505 dialog later) is often misleading.
1506 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1508 * src/modest-tny-account.c:
1509 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1510 URL because this is so useful for debugging on the device.
1512 * src/widgets/modest-serversecurity-combo-box.c:
1513 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1515 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1517 * src/modest-mail-operation.c:
1518 (modest_mail_operation_send_new_mail):
1519 Added a comment about a nasty but apparently harmless message. Details
1520 added to the wiki g_warnings() page.
1522 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1524 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1525 (modest_tny_send_queue_class_init):
1526 Do not use the priv struct because it is empty, to avoid g_warnings
1527 about a non-existant priv struct.
1529 * src/modest-tny-account-store.c:
1530 (modest_tny_account_store_get_server_account),
1531 (modest_tny_account_store_get_transport_account_for_open_connection
1532 ): Do not try to get transport server accounts for local folders,
1533 because they don't have any. This avoids a g_warning().
1535 * src/maemo/modest-main-window.c:
1536 (modest_main_window_notify_send_receive_initied),
1537 (on_configuration_key_changed):
1538 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1539 * src/modest-defs.h:
1540 * src/modest-mail-operation.c:
1541 (modest_mail_operation_update_account):
1542 * src/modest-tny-account-store.h:
1543 * src/modest-tny-account.c:
1544 (modest_tny_account_get_special_folder),
1545 (modest_tny_account_new_for_local_folders),
1546 (modest_tny_account_new_for_per_account_local_outbox_folder):
1547 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1548 * src/modest-tny-local-folders-account.c:
1549 (add_account_folders_to_merged_folder):
1550 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1551 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1552 (modest_ui_actions_on_send):
1553 * src/widgets/modest-folder-view.c: (update_model):
1554 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1555 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1556 modest_tny_account_store_get_tny_account_by_account() to
1557 modest_tny_account_store_get_server_account() to make the code clearer.
1559 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1561 * src/dbus_api/modest-dbus-api.h:
1562 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1563 * src/maemo/modest-msg-edit-window.c:
1564 (modest_msg_edit_window_attach_file_noninteractive):
1565 added g_warning in case the file to be attached does not exist
1566 * tests/dbus_api/test_compose_mail.c: (main):
1567 removed obsolete comment, added generic files as test case
1569 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1571 * src/modest-tny-account-store.c: (get_server_accounts):
1572 Create the local folders account only once, not once for each outbox, and
1573 not only when there are some outboxes.
1575 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1577 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1578 code that is causing a crash at startup. Sergio says that he is fixing this.
1580 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1582 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1583 * src/maemo/modest-account-settings-dialog.c:
1584 (create_page_outgoing),
1585 (modest_account_settings_dialog_set_account_name),
1586 (save_configuration):
1587 - Fixed handling of the "Use secure authentication" toggle to comply with
1588 the ui specification. See also projects.maemo.org bug NB#58400
1590 - Restore the Secure connection setting combo correctly when loading
1593 * src/maemo/modest-maemo-utils.c:
1594 (on_camel_account_get_supported_secure_authentication),
1595 (modest_maemo_utils_get_supported_secure_authentication_methods):
1596 Fixed a crasher if operation is canceled
1598 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1599 (modest_protocol_info_auth_is_secure):
1600 * src/modest-protocol-info.h:
1602 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1603 the sense of the "Use secure authentication" toggle.
1605 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1607 * src/modest-tny-account-store.h:
1608 * src/modest-tny-account-store.c:
1609 Added modest_tny_account_store_get_local_folders_account().
1611 * src/modest-tny-folder.h:
1612 * src/modest-tny-folder.c:
1613 (modest_tny_folder_get_account):
1614 Added this replacement for tny_folder_get_account() which returns
1615 the local-folders account for TnyMergeFolders, to avoid the
1616 warning about the unimplemented get_account_func() vfunc().
1618 (modest_tny_folder_get_rules),
1619 * src/modest-ui-actions.c:
1620 (modest_ui_actions_on_folder_selection_changed):
1621 * src/modest-mail-operation.c:
1622 (modest_mail_operation_remove_folder),
1623 (modest_mail_operation_xfer_folder),
1624 (modest_mail_operation_rename_folder),
1625 (modest_mail_operation_get_msg),
1626 (modest_mail_operation_get_msgs_full),
1627 (modest_mail_operation_remove_msg),
1628 (modest_mail_operation_xfer_msgs),
1629 (modest_mail_operation_refresh_folder):
1630 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1632 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1634 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1635 (modest_server_account_set_security):
1636 * src/modest-defs.h: Add comments explaining that our
1637 UI spec means TLS when it says Normal, so these do not look like errors.
1639 * src/modest-tny-account.c:
1640 (modest_tny_account_new_from_server_account): Use the new tinymail
1641 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1642 for TLS. This should fix projects.maemo.org bug NB#58460.
1644 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1646 * src/maemo/easysetup/modest-easysetup-wizard.c:
1647 (create_account): Correct the position of the gconf sanity check warning.
1648 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1649 of using the g_idle_add() hack, because this does not seem to be necessary
1650 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1651 caused by something other than maemo's gconf.
1652 This fixes projects.maemo.org bug #59022.
1654 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1656 * src/modest-account-mgr-helpers.c:
1657 (modest_account_mgr_get_default_account): Do not check that the account
1658 exists if there is no default account (NULL), to fix a runtime warning.
1660 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1662 * src/widgets/modest-folder-view.c: (update_model):
1663 Do not unref the treemodel before we have finished with it.
1664 This prevents a valgrind warning and an occasional crash at startup.
1666 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1668 * libmodest-dbus-client/libmodest-dbus-client.h:
1669 added libmodest_dbus_client_compose_mail()
1670 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1672 added functions needed for SendAsMail() functionality
1673 * src/maemo/modest-msg-edit-window.c:
1674 (modest_msg_edit_window_attach_file_noninteractive):
1675 non interactively attaching files to message edit window
1676 * src/widgets/modest-msg-edit-window.h:
1677 * tests/dbus_api/Makefile.am:
1678 added test_compose_mail.c
1679 * tests/dbus_api/test_compose_mail.c: (main):
1681 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1683 * src/modest-account-view.c:
1684 Fixed bug projects.maemo.org bug NB#59307
1686 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1688 * src/maemo/easysetup/modest-easysetup-wizard.c:
1689 (get_serverport_incoming), (on_before_next), (create_account):
1690 * src/maemo/modest-account-settings-dialog.c:
1691 (modest_account_settings_dialog_set_account_name):
1692 * src/maemo/modest-maemo-utils.c:
1693 (on_camel_account_get_supported_secure_authentication_status),
1694 (on_camel_account_get_supported_secure_authentication),
1695 (on_secure_auth_cancel),
1696 (modest_maemo_utils_get_supported_secure_authentication_methods):
1698 Implemented security authentication for settings and easysetup.
1700 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1702 * src/maemo/modest-main-window.c: (create_details_widget):
1703 Show the total size for memory card accounts too, instead of showing
1704 the name again. Fixes bug projects.maemo.org bug NB#59307.
1706 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-tny-simple-folder-store.c:
1710 * src/modest-tny-simple-folder-store.h: Removed.
1712 * src/modest-tny-local-folders-account.h
1713 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1714 for the local-folders maildir, with an extra TnyMergedFolder containing
1715 the folders of the per-account outbox store accounts.
1716 * src/modest-tny-account-store.c: (get_server_accounts):
1717 Add the outboxes to the special local folders account after creating it.
1719 * src/modest-tny-account.c:
1720 (modest_tny_account_new_for_local_folders): Create the derived
1721 account when creating the main local-folders account.
1723 * src/maemo/modest-main-window.c: (create_details_widget),
1724 (modest_main_window_set_contents_style):
1725 Adapted to the use of the derived account instead of the folder store.
1727 * src/modest-ui-actions.c:
1728 (modest_ui_actions_on_folder_selection_changed):
1729 * src/modest-ui-dimming-rules.c:
1730 (modest_ui_dimming_rules_on_new_folder):
1731 * src/widgets/modest-folder-view.c: (text_cell_data),
1732 (icon_cell_data), (filter_row), (update_model),
1733 (get_cmp_rows_type_pos):
1736 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1737 Do not get the priv struct, because no priv struct has been set,
1738 to avoid a runtime warning.
1740 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1741 #ifelse with #else, to fix a warning, to fix the build.
1744 2007-06-05 Christian Kellner <ckellner@openismus.com>
1746 * libmodest-dbus-client/libmodest-dbus-client.c:
1747 Fix small typo in doc (why do you always see them
1748 AFTER committing stuff?)
1751 2007-06-05 Christian Kellner <ckellner@openismus.com>
1753 * libmodest-dbus-client/libmodest-dbus-client.c:
1754 (libmodest_dbus_client_search):
1755 Initialize hit list with NULL. Also set folder list
1756 to "" if NULL was supplied.
1759 2007-06-03 Christian Kellner <ckellner@openismus.com>
1761 * libmodest-dbus-client/libmodest-dbus-client.c:
1762 (modest_search_hit_list_free):
1763 Make it save to call it with NULL.
1765 * src/dbus_api/modest-dbus-callbacks.c:
1766 * src/modest-search.c:
1767 Return full ModestSearchHits as the search result list not TnyHeader
1768 since can't be around withouth the correspoding TnyFolder.
1770 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1772 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1773 Added currently commented code to check for secure auth
1775 * src/maemo/modest-account-settings-dialog.c: (on_response),
1776 (save_configuration), (show_ok):
1777 Fixed projects.maemo.org bugs NB #59248 and #59251
1779 * src/maemo/modest-maemo-utils.c:
1780 (on_camel_account_get_supported_secure_authentication_status),
1781 (on_camel_account_get_supported_secure_authentication),
1782 (modest_maemo_utils_get_supported_secure_authentication_methods):
1783 * src/maemo/modest-maemo-utils.h:
1784 Moved get_supported_secure_authentication() method here to be able
1785 to use it from easysetup wizard.
1787 * src/modest-pair.c: (on_pair_compare_as_string):
1788 Should compare string with first part of pair and not
1789 strcmp pairs which will crash.
1791 * src/modest-protocol-info.c:
1792 (modest_protocol_info_protocol_is_store):
1793 * src/modest-protocol-info.h:
1794 Added modest_protocol_info_get_auth_protocol_name()
1796 2007-06-03 Armin Burgmeier <armin@openismus.com>
1798 * src/modest-mail-operation.c:
1799 (modest_mail_operation_get_msgs_full): Set priv->account also when
1800 only retrieving a single message. This avoids a crash when canceling
1803 (modest_mail_operation_notify_end): Do not explicitely remove the
1804 operation from the queue but only emit the progress_changed signal.
1805 The queue itself listens to that signal to remove the operation when
1806 it is finished. This reduces coupling and removes a potential deadlock
1807 when modest_mail_operation_notify_end() is called from the queue
1808 itself. If that is a problem performance-wise, I would suggest to
1809 implement a status-changed signal or something.
1811 * src/modest-mail-operation-queue.c: Make sure to never call a
1812 function from another file while the queue is locked. This (hopefully)
1813 fixes another deadlock when exiting the application while retrieving
1816 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1818 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1819 Fixed build if libogs is not available
1821 2007-06-03 Christian Kellner <ckellner@openismus.com>
1823 * libmodest-dbus-client/libmodest-dbus-client.h:
1824 * libmodest-dbus-client/libmodest-dbus-client.c:
1825 (libmodest_dbus_client_delete_message):
1826 Implement deletion of messages (Client side).
1828 (modest_search_hit_free),
1829 (modest_search_hit_list_free):
1830 Utility functions to free the result hits.
1832 * src/dbus_api/modest-dbus-api.h:
1833 * src/dbus_api/modest-dbus-callbacks.c:
1834 (on_delete_message),
1835 (modest_dbus_req_handler):
1836 Implement deletion of messages (Server side).
1838 * tests/dbus_api/test_search.c: (main):
1841 * tests/dbus_api/Makefile.am:
1842 * tests/dbus_api/test_delete_message:
1843 Add little test for the message deletion logic
1845 2007-06-03 Armin Burgmeier <armin@openismus.com>
1847 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1848 when the operation queue was not empty. projects.maemo.org bug
1851 2007-06-03 Armin Burgmeier <armin@openismus.com>
1853 * src/widgets/modest-account-view.c
1854 (on_account_default_toggled): Toggle default account column
1855 explicitely instead of waiting for gconf notification (which is
1856 currently ignored). This should fix projects.maemo.org bug NB#56910
1857 for now. It should probably be removed when gconf notifications are
1860 2007-06-03 Christian Kellner <ckellner@openismus.com>
1862 * libmodest-dbus-client/libmodest-dbus-client.c:
1863 Removed debugging spew.
1865 * src/dbus_api/modest-dbus-callbacks.c:
1866 Added debugging info.
1868 * src/modest-search.c:
1869 (modest_search_all_accounts):
1870 Use tny_account_store_get_accounts () on the account store
1871 to get all accounts which is the way to get all accounts.
1873 * tests/dbus_api/test_search.c: (main):
1874 Make it possible to supply the search term on the command line.
1876 2007-06-03 Christian Kellner <ckellner@openismus.com>
1878 * libmodest-dbus-client/libmodest-dbus-client.c:
1879 * libmodest-dbus-client/libmodest-dbus-client.h:
1880 Implement searching for mesages over raw dbus. (Client side)
1882 * src/dbus_api/Makefile.am:
1883 * src/dbus_api/modest-dbus-api.h:
1884 * src/dbus_api/modest-dbus-callbacks.c:
1885 * src/dbus_api/modest-dbus-callbacks.h:
1886 Search framework (Server side). Also implement on_idle_open_message().
1888 * src/maemo/modest-platform.c: (modest_platform_init):
1889 Prepare for raw dbus/osso rpc interaction.
1891 * src/modest-search.h:
1892 Changed minsize from unspecific guint to guint32.
1894 * src/modest-search.c:
1896 Added strange hack which magically made tnymail work.
1898 (modest_search_folder),
1899 (modest_search_account),
1900 (modest_search_all_accounts):
1901 Implement helper functions to search all accounts, specific account
1904 * tests/dbus_api/Makefile.am:
1905 * tests/dbus_api/test_open_message.c:
1906 Read url to open from commandline.
1908 * tests/dbus_api/test_search.c:
1909 Implement small test for dbus search stuff
1911 2007-06-02 Armin Burgmeier <armin@openismus.com>
1913 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1914 include account type and account title. This fixes projects.maemo.org
1917 * src/maemo/modest-account-view-window.c: Set a title for the window.
1919 2007-06-02 Armin Burgmeier <armin@openismus.com>
1921 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1922 incoming and outgoing server name based on email address and server
1923 types as long as the names have not been edited manually. This fixes
1924 projects.maemo.org bug NB#58671.
1926 2007-06-02 Armin Burgmeier <armin@openismus.com>
1928 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1929 server type cannot be changed in future to the incoming details page
1930 when creating an account. This fixes projects.maemo.org bug NB#59029.
1932 2007-06-02 Armin Burgmeier <armin@openismus.com>
1934 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1935 and assigned max width chars so that they wrap instead of being
1936 truncated. Fixes projects.maemo.org bug NB#56126.
1938 2007-06-02 Armin Burgmeier <armin@openismus.com>
1940 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1941 introductory note to the connection specific smtp servers dialog, as
1942 section 8.12 of the email UI specification requires. This fixes
1943 projects.maemo.org bug NB#59212.
1945 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1947 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1948 Check for running mail operations, and offer to cancel them, as per the UI
1949 spec. This fixes projects.maemo.org bug NB#59041 .
1950 However, I suspect that tinymail may still use the network connection
1951 in ways that we cannot detect or cancel. But it should at least adapt to
1952 changes fairly well.
1954 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1956 * src/modest-tny-account-store.c: (recreate_all_accounts),
1957 (get_cached_accounts), (get_server_accounts): Do more sensible
1958 ref-counting of the temporarily-cached outbox accounts list. This seems
1959 to fix a crash when entering the password when the password was wrong.
1961 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1963 * src/gnome/modest-main-window.c: (connect_signals):
1964 * src/modest-tny-account-store.c: (get_password),
1965 (modest_tny_account_store_alert): Added comments and clues and
1966 commented-out code about how we currently fail to deal with connection
1967 errors and wrong passwords, and how we should.
1969 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1971 * src/widgets/modest-retrieve-combo-box.c:
1972 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1973 This fixes projects.maemo.org bug NB#58472 .
1975 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1977 * src/maemo/easysetup/modest-easysetup-wizard.c:
1978 (create_page_complete_easysetup):
1979 (create_page_complete_custom): Correct the last commit,
1980 putting the correct sentences in the correct pages.
1982 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1984 * src/maemo/easysetup/modest-easysetup-wizard.c:
1985 (create_page_complete_custom): Show the second sentence of text
1986 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1989 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1991 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1992 Set the leave-on-server conf key by default. This fixes
1993 projects.maemo.org bug NB#59258 .
1995 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1997 * src/maemo/modest-account-view-window.c:
1998 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1999 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2002 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2004 * src/maemo/easysetup/modest-easysetup-wizard.c:
2005 (create_caption_new_with_asterisk):
2006 * src/maemo/modest-account-settings-dialog.c:
2007 (create_caption_new_with_asterisk):
2008 Uncomment the code to add the asterisk, because they are no longer in the
2009 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2010 (update_incoming_server_title): Add an asterisk here too.
2012 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2014 * src/maemo/modest-maemo-global-settings-dialog.c:
2015 (current_connection): Check that we are even connected before trying to
2016 get the current connection name, to prevent a warning.
2018 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2019 Change the comments because tny_maemo_conic_device_connect() is now meant to
2021 * src/modest-mail-operation.c:
2022 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2023 make sure we have a connection and fail if we can't connect.
2025 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2027 * src/maemo/modest-main-window.c:
2028 (on_account_store_connecting_finished): Do not try to get the
2029 connection ID if we are not really connected. I am surprised that
2030 this signal handler is called when we are not connected.
2032 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2034 * src/modest-error.h:
2035 * src/modest-ui-actions.c:
2036 (modest_ui_actions_get_msgs_full_error_handler):
2037 Renamed an enum, added comments, added an enum
2038 for retrieve-limit errors.
2040 * src/modest-mail-operation.c: (foreach_add_item),
2041 (internal_folder_observer_update), (update_account_thread),
2042 (modest_mail_operation_get_msgs_full):
2043 (modest_mail_operation_update_account),
2044 Added comments about how this works, and some code that should
2045 (but does not) check the retrieve-limit. See the TODO comment.
2047 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2049 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2050 Initialize help_id to fix the build. Warnings are good.
2052 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2054 * src/widgets/modest-hbox-cell-renderer.c:
2055 (modest_hbox_cell_renderer_append):
2056 * src/widgets/modest-vbox-cell-renderer.c:
2057 (modest_vbox_cell_renderer_append):
2058 Fix the last commit by doing an extra ref.
2060 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2062 * src/widgets/modest-hbox-cell-renderer.c:
2063 (modest_hbox_cell_renderer_append):
2064 * src/widgets/modest-vbox-cell-renderer.c:
2065 (modest_vbox_cell_renderer_append):
2066 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2067 to fix the build with Maemo Bora.
2068 However, there seems to be a remaining crash, probably due to reference
2071 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2073 * src/modest-tny-account.c:
2074 (modest_tny_account_new_for_local_folders):
2075 Use hildon_file_system_info_async_new() to get a better name for
2076 the memory card account, setting it as the account name.
2077 The timing seems to work, but this is probably
2078 not the best place to do this. See the TODO comment.
2079 * src/maemo/modest-main-window.c: (create_details_widget):
2080 * src/widgets/modest-folder-view.c: (text_cell_data):
2081 Use the tny account name instead of hardcoding a name.
2083 2007-05-30 Christian Kellner <ckellner@openismus.com>
2085 * src/modest-search.c: (modest_search):
2086 Correctly set part_search_func even if we have already parsed
2087 the query and thus a valid OgsTextSearcher object.
2089 2007-05-30 Christian Kellner <ckellner@openismus.com>
2092 Search and check for libogs.
2095 Incooparte the ogs build env.
2097 * src/modest-mime-part-search-stream.c:
2098 * src/modest-mime-part-search-stream.h:
2099 Removed since we do the real searching now in modest-search.c.
2101 * src/modest-search.c:
2102 * src/modest-search.h:
2103 Implement support for ogs. We use that if available and requested
2104 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2105 should now handle the corner case when the search term is spread
2106 across multiple reads.
2107 Also the logic in modest_search () was corrected to search all
2108 requested fields until one is found.
2110 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2112 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2114 * src/modest-init.h:
2115 * src/modest-init.c: Made modest_init_local_folders() take a
2116 path and be public so we can iniitialize maildir folders on
2119 * src/modest-local-folder-info.h:
2120 * src/modest-local-folder-info.c:
2121 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2123 * src/modest-tny-account.c:
2124 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2125 still means the standard local-folders path on the local volume.
2127 * src/modest-tny-account-store.c:
2128 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2129 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2130 all accounts when that happens.
2131 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2132 this too, so it shows up in the treeview.
2134 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2136 * src/maemo/modest-maemo-global-settings-dialog.c:
2137 (current_connection):
2138 * src/widgets/modest-global-settings-dialog.c:
2139 (current_connection_default):
2140 Use the enum values instead of 0, 1 and -1,
2141 to make the code clearer.
2143 * src/modest-account-mgr-helpers.c:
2144 (modest_account_mgr_get_connection_specific_smtp): Make this code
2147 * src/modest-runtime.h:
2148 * src/modest-runtime.c:
2149 Added modest_runtime_remove_all_send_queues().
2150 * src/maemo/modest-main-window.c:
2151 (on_account_store_connecting_finished): Recreate the send queues,
2152 using the appropriate transport accounts for this new connection.
2153 Some futher adapting might be needed if the old send queues are not
2154 automatically stopped at this point.
2156 * src/modest-tny-account-store.c: (get_server_accounts):
2157 Create the connection-specific transport accounts, so that they can
2158 be found later by their ID.
2160 * src/modest-tny-account.h:
2161 * src/modest-tny-account.c:
2162 Added modest_tny_account_new_from_server_account_name().
2163 modest_tny_account_new_from_server_account(): Do not create the
2164 send queues here, because they will be
2165 recreated anyway when the connection changes for the first time.
2167 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2169 * src/modest-local-folder-info.h:
2170 * src/modest-local-folder-info.c:
2171 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2172 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2173 tbox_folder): Take a modest account name instead of a server TnyAccount,
2174 so we can have per-modest-account rather than per-transport-account
2176 We must make sure that we change or recreate the exisitng send queues
2177 when the connection changes for connection-specific transport accounts.
2179 * src/modest-tny-account-store.c:
2180 (create_per_account_local_outbox_folders): Create outboxed per modest
2181 account, not per transport account.
2183 * src/modest-tny-account.h:
2184 * src/modest-tny-account.c:
2185 (modest_tny_account_get_special_folder): For outboxes, get the
2186 parent modest account name. The account is ignored for other folders.
2187 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2188 modest account name rather than a server TnyAccount.
2190 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2192 * src/modest-tny-account.c:
2193 (modest_tny_account_new_from_server_account):
2194 Call modest_runtime_get_send_queue() immediately after creating transport
2195 accounts, so that they start trying to send email from the outbox as soon
2196 as possible at startup. This is probably what we want.
2198 * src/modest-mail-operation.c: (update_account_thread):
2199 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2200 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2201 * src/modest-tny-send-queue.h:
2202 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2203 (modest_ui_actions_on_send):
2204 Added comments about how sending works, though it needs some more work.
2206 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2208 * src/modest-tny-account.c:
2209 (modest_tny_account_get_special_folder): Add TODO because this fails when
2210 the network is busy.
2211 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2212 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2213 Do not try to show this window when there is no active account. The UI
2214 specs does not tell us what to do in this case.
2216 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2220 * src/maemo/Makefile.am:
2221 * src/widgets/Makefile.am: Some dist fixes.
2223 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2225 * src/maemo/modest-connection-specific-smtp-window.c:
2226 (on_button_edit): Make the code clearer, to prevent a double free.
2228 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2230 * src/maemo/modest-account-settings-dialog.c:
2231 (modest_account_settings_dialog_set_account_name),
2232 Check the connection-specific smtp servers checkbox if there are any.
2234 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2235 (modest_connection_specific_smtp_edit_window_init):
2236 Start with a suitable port number.
2238 * src/modest-account-mgr-helpers.h:
2239 * src/modest-account-mgr-helpers.c: Added
2240 modest_account_mgr_get_has_connection_specific_smtp().
2242 (modest_account_mgr_set_connection_specific_smtp),
2243 (modest_account_mgr_remove_connection_specific_smtp),
2244 (modest_account_mgr_get_has_connection_specific_smtp),
2245 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2246 connection-specific smtp server accounts in the account, rather than
2247 the server account conf dir.
2249 This fixes bug projects.maemo.org bug NB#58263 .
2251 * src/modest-tny-account-store.c:
2252 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2253 if there are no server accounts yet, to prevent an infinite loop when there
2254 are no accounts. Document that one must be called before the other.
2256 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2258 * src/modest-account-mgr-helpers.c:
2259 (modest_account_mgr_get_default_account): Make sure that at least
2260 one account is always the default, if there are any enabled accounts.
2261 This is just a sanity check that shouldn't be necessary.
2263 * src/modest-account-mgr-priv.c:
2264 (_modest_account_mgr_account_from_key): Unescape the conf key to
2265 get the real account name. For instance, this is an issue if a space
2266 was in the account name, which can happen because the account name
2267 is generated from the display name.
2268 (_modest_account_mgr_get_account_keyname): Always escape the
2270 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2271 Unescape the conf keys to get the real account names.
2273 For instance, previously the is-default radio button in the accounts
2274 list was not checked for any accounts at first. This fixes that,
2275 and might fix several similar bugs.
2277 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2279 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2280 Removed some debug printfs.
2282 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2284 Modest on-disk outbox directories are now here, for instance:
2285 $HOME/.modest/outboxes/<account-id-1>/outbox
2286 $HOME/.modest/outboxes/<account-id-2>/outbox
2288 $HOME/.modest/local-folders/outbox
2289 so we can have a separate outbox for each account.
2290 But they are shown as one outbox in the GtkTreeView, by using a
2291 TnyMergeFolder in a ModestTnySimpleFolderStore.
2294 * src/modest-tny-simple-folder-store.c:
2295 * src/modest-tny-simple-folder-store.h:
2296 Added ModestTnySimpleFolderStore, used to contain folders from
2297 other folder stores, such as other accounts.
2299 * src/modest-tny-outbox-account.h:
2300 * src/modest-tny-outbox-account.c:
2301 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2302 used for the per-account local outbox folders.
2304 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2305 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2306 only use this (internally) now for the non-outbox local folders.
2308 * src/modest-init.h:
2309 * src/modest-init.c: Added modest_init_one_local_folder(), for
2310 setting up the directory structure for each local folder.
2312 * src/modest-local-folder-info.c:
2313 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2314 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2316 * src/modest-local-folder-info.h:
2317 * src/modest-tny-account-store.c: (on_account_removed),
2318 (on_account_changed), (create_per_account_local_outbox_folders),
2319 (get_server_accounts), (modest_tny_account_store_get_accounts),
2320 (modest_tny_account_store_get_tny_account_by_account),
2321 (modest_tny_folder_store_is_virtual_local_folders):
2323 * src/modest-tny-account.h:
2324 * src/modest-tny-account.c:
2325 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2326 to create an on-disk per-account local outbox folder for each
2328 (create_per_account_local_outbox_folders): Create a local outbox folder
2329 for each transport account.
2330 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2331 for all local folders.
2333 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2334 instead of using g_object_get/set() directly. It is clearer.
2336 (modest_tny_folder_store_get_message_count),
2337 (modest_tny_folder_store_get_local_size
2338 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2339 because we now use these with non-acount folder stores.
2341 (modest_tny_account_get_special_folder),
2342 (modest_tny_account_new_from_server_account),
2343 (modest_tny_account_new_from_account):
2344 (recurse_folders): Adjust to the new outbox system.
2346 * src/modest-tny-folder.h:
2347 * src/modest-tny-folder.c:
2348 (modest_tny_folder_is_local_folder),
2349 (modest_tny_folder_get_local_folder_type),
2350 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2352 * src/widgets/modest-main-window.h:
2353 * src/maemo/modest-main-window.c: (create_details_widget),
2354 (modest_main_window_set_contents_style): Show details for any folder store,
2357 (modest_tny_folder_get_rules):
2358 Remove the const. C does not support constness enough for this.
2360 * src/modest-ui-actions.c:
2361 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2362 make all outboxes appear as one, in the usual local-folders tree node.
2364 (set_active_account_from_tny_account),
2365 (modest_ui_actions_on_folder_selection_changed):
2366 * src/widgets/modest-folder-view.c: (text_cell_data),
2367 (icon_cell_data), (filter_row),
2368 (add_account_folders_to_merged_folder),
2369 (add_account_folders_to_simple_folder_store), (),
2370 (get_cmp_rows_type_pos), (cmp_rows),
2371 (modest_folder_view_set_account_id_of_visible_server_account):
2372 Adjust to the new outbox system, using generic folder stores and folders
2373 in the GtkTreeModel.
2375 2007-05-23 Christian Kellner <ckellner@openismus.com>
2377 * src/modest-mail-operation.c:
2378 (modest_mail_operation_update_account):
2379 Use info->max_size instead of unintialized local var [small
2380 build fix]. (Added TODO to review that change since I don't
2383 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2385 * libmodest-dbus-client/libmodest-dbus-client.c:
2386 (libmodest_dbus_client_compose_mail): function added
2387 * src/dbus_api/modest-dbus-api.h:
2388 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2389 (on_compose_mail): Implementation of the SendAsMail functionality
2391 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2393 * src/modest-account-mgr.c:
2394 (modest_account_mgr_add_server_account): Set the secure-connection
2395 conf key for transport accounts as well as store accounts. I don't know
2396 why the if was there. For instance, this makes sure that we use SSL
2397 for the gmail preset from the easysetup wizard.
2399 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2401 * src/gnome/modest-main-window.c:
2402 (on_account_store_connecting_finished), (connect_signals):
2403 * src/maemo/modest-main-window.c:
2404 (on_account_store_connecting_finished), (connect_signals),
2405 (modest_main_window_new):
2406 Handle TnyAccountStore::connecting-finished instead of
2407 TnyDevice::connection-changed, because we cannot actually perform
2408 operations on accounts until TnyAccountStore has itself responded to
2409 the TnyDevice::connection-changed signal. This prevents a GError from
2411 Do not try to update at startup, because we (at least on scratchbox)
2412 already do an update at startup when the device goes online.
2413 This prevents a GError from tinymail.
2414 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2415 Added TODO about stopping simultaneous operations.
2417 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2419 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2420 * src/modest-mail-operation-queue.c:
2421 (modest_mail_operation_queue_remove):
2422 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2423 about where they happened.
2425 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2427 * src/modest-ui-actions.c:
2428 (modest_ui_actions_on_password_requested): Make sure that the remember
2429 output parameter is always TRUE.
2431 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2433 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2434 Show a OK/Cancel dialog if the error is a question, though we still do not
2435 know anything more about what we are asking the user.
2436 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2437 Fix an uninitialized variable (helper). This is a logic error, however.
2439 2007-05-21 Christian Kellner <ckellner@openismus.com>
2441 * src/modest-search.h:
2442 Correct bit shifting in the ModestSearchFlags enum.
2444 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2446 * src/modest-tny-account.c:
2447 (modest_tny_account_new_from_server_account): Do not use the lsub and
2448 check-all hard-coded IMAP options when using POP.
2450 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2452 * src/modest-tny-account.c:
2453 (modest_tny_account_new_from_server_account):
2454 Use NULL for the secure-auth method for POP when Password auth has been
2455 specified by the user, as we already do for IMAP. "auth=Login" causes
2456 an error from camel or the server.
2458 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2460 * src/maemo/modest-account-settings-dialog.c:
2461 (create_page_account_details),
2462 (modest_account_settings_dialog_set_account_name):
2463 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2464 for the leave-on-server checkbox, rathr than just the checkbox, when
2465 the protocol is not POP.
2467 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2469 * src/widgets/modest-account-view.c:
2470 * src/widgets/modest-account-view.h:
2471 Added modest_account_view_select_account() which will be useful later
2472 to asynchronously re-select the edited account.
2474 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2476 * src/maemo/modest-account-settings-dialog.c:
2477 (modest_account_settings_dialog_set_account_name):
2478 Automatically choose the port numbers based on the secure authentication
2479 methods, if they have not been chosen before.
2480 This fixes projects.maemo.org bug NB#56273 .
2482 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2484 * src/maemo/modest-main-window-ui.h:
2485 * src/modest-ui-actions.c:
2486 * src/modest-ui-actions.h:
2487 Connect the Tools/SMTP Servers menu item to
2488 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2489 SMTP servers dialog, as in the UI specification and saves changes when it
2490 is closed. This fixed projects.maemo.org bug NB#56305 .
2492 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2494 * src/maemo/modest-connection-specific-smtp-window.c:
2495 (modest_connection_specific_smtp_window_init):
2496 Use gtk_window_set_default_size() to make this window big enough, so
2497 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2499 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2501 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2502 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2503 (modest_connection_specific_smtp_edit_window_init),
2504 Do not try to connect to a combobox signal before the combobox exists.
2505 This fixes the cras in projects.maemo.org bug NB#56288 .
2506 (modest_connection_specific_smtp_edit_window_get_settings):
2507 Remove the server_account_name parameter which was being checked for NULL
2508 though it was not used.
2510 * src/maemo/modest-connection-specific-smtp-window.c:
2511 (modest_connection_specific_smtp_window_fill_with_connections),
2512 (on_button_edit), (modest_connection_specific_smtp_window_init):
2513 Correct the number of treemodel columns to prevent a warning.
2514 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2515 libconic does not work.
2517 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2519 * src/modest-tny-account.c:
2520 (modest_tny_account_new_from_server_account):
2521 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2522 SMTP when "None" was chosen by the user. However, with my SMTP server that
2523 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2526 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2528 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2529 to explain the memory management issue with the ID in the ModestPair.
2531 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2532 (add_sending_page), (modest_account_assistant_finalize):
2533 * src/gnome/modest-gnome-global-settings-dialog.c:
2534 (create_updating_page), (create_composing_page):
2535 * src/gnome/modest-msg-edit-window.c: (get_transports),
2536 (init_window), (modest_msg_edit_window_finalize),
2537 (modest_msg_edit_window_get_msg_data):
2538 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2539 * src/gnome/modest-transport-widget.c:
2540 (modest_transport_widget_finalize), (smtp_configuration):
2541 * src/maemo/modest-maemo-global-settings-dialog.c:
2542 (create_updating_page), (create_composing_page):
2543 * src/maemo/modest-msg-edit-window.c: (get_transports),
2544 (init_window), (modest_msg_edit_window_finalize),
2545 (modest_msg_edit_window_get_msg_data),
2546 (modest_msg_edit_window_free_msg_data):
2547 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2548 (modest_store_widget_finalize):
2549 * src/maemo/modest-transport-widget.c:
2550 (modest_transport_widget_finalize), (smtp_configuration):
2551 * src/modest-main.c: (send_mail):
2552 * src/widgets/modest-combo-box.h:
2553 * src/widgets/modest-global-settings-dialog-priv.h:
2554 * src/widgets/modest-global-settings-dialog.c:
2555 (modest_global_settings_dialog_finalize):
2556 * src/widgets/modest-msg-edit-window.h:
2557 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2558 as long as the combo box, to prevent use of freed memory for the ID.
2560 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2562 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2563 get_accounts(), to make this clearer. Do not check for the enabled gconf
2564 key, because we do not use this for server accounts (at least, not yet).
2565 This allows us to send email again.
2567 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2569 * src/maemo/modest-platform.c:
2570 (on_modest_conf_update_interval_changed), (modest_platform_init):
2571 Only respond to this particular key change. All these strcmp()s cannot be
2574 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2576 * src/maemo/modest-maemo-global-settings-dialog.c:
2577 (current_connection): Prevent a crash in scratchbox when
2578 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2579 * src/maemo/modest-platform.c:
2580 (on_modest_conf_update_interval_changed), (modest_platform_init):
2581 Get the update interval from gconf and reset it when the gconf key changes.
2583 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2585 * src/modest-protocol-info.c:
2586 * src/modest-protocol-info.h: Adde enum-specific get functions,
2587 instead of using a ModestProtocolType enum parameter.
2589 * src/gnome/modest-account-assistant.c:
2590 * src/gnome/modest-store-widget.c:
2591 * src/gnome/modest-store-widget.h:
2592 * src/gnome/modest-transport-widget.c:
2593 * src/gnome/modest-transport-widget.h:
2594 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2595 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2596 * src/maemo/easysetup/modest-easysetup-wizard.c:
2597 * src/maemo/modest-account-settings-dialog.c:
2598 * src/maemo/modest-account-settings-dialog.h:
2599 * src/maemo/modest-store-widget.c:
2600 * src/maemo/modest-store-widget.h:
2601 * src/maemo/modest-transport-widget.c:
2602 * src/maemo/modest-transport-widget.h:
2603 * src/modest-account-mgr-helpers.c:
2604 * src/modest-account-mgr-helpers.h:
2605 * src/modest-account-mgr.c:
2606 * src/modest-account-mgr.h:
2607 * src/modest-tny-account.c:
2608 * src/modest-tny-folder.c:
2609 * src/widgets/modest-account-view.c:
2610 * src/widgets/modest-retrieve-combo-box.c:
2611 * src/widgets/modest-retrieve-combo-box.h:
2612 * src/widgets/modest-secureauth-combo-box.c:
2613 * src/widgets/modest-serversecurity-combo-box.c:
2614 * src/widgets/modest-serversecurity-combo-box.h:
2615 * tests/check_account-mgr.c:
2616 Use the specific functions, and use the re-renamed enum values for GNOME too.
2618 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2620 * src/modest-pair.h:
2621 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2622 so we can get the second based on the first.
2624 * src/maemo/modest-account-settings-dialog.h:
2625 * src/maemo/modest-account-settings-dialog.c:
2626 Added get_supported_secure_authentication_methods(), though it is mostly
2627 commented-out for now until the necessary API is committed to tinymail.
2628 (modest_account_settings_dialog_set_account_name),
2629 (save_configuration): Request the supported authentication methods from the
2630 server, so we can choose a working method.
2632 * src/modest-tny-account-store.h:
2633 * src/modest-tny-account-store.c:
2634 (modest_tny_account_store_get_session): Rename from
2635 tny_account_store_get_session().
2637 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2639 * src/modest-protocol-info.h: Split the ModestProtocol enum
2640 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2641 There was no need to have these unrelated values in one enum.
2643 * src/: many files: Adapted to changed enum. This makes the code a bit
2644 clearer, and the compiler could catch some errors.
2646 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2648 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2649 Show the detailed internal camel error message when an error happens
2650 during the configuration, so that our testers can give us more clues.
2651 For instance, in projects.maemo.org bug NB#56910 .
2653 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2655 * src/modest-tny-account.c:
2656 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2657 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2659 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2661 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2662 * src/maemo/modest-account-settings-dialog.c:
2663 (modest_account_settings_dialog_set_account_name),
2664 (save_configuration): For the incoming secure authentication checkbox,
2665 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2666 the UI specification. PLAIN does not seem to be supported for most IMAP
2667 servers anyway, and I am not sure what it would mean.
2668 However, we probably need to discover which of the secure-authentication
2669 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2670 * src/modest-account-mgr-helpers.c:
2671 (modest_account_mgr_get_server_account_data):
2673 * src/modest-tny-account.c:
2674 (modest_tny_account_new_from_server_account):
2675 Use tny_account_set_mech() to set secure-authentication methods,
2676 with some special-casing for IMAP, based on my observations of how
2679 * src/modest-account-mgr-helpers.h:
2680 * src/modest-account-mgr.c:
2681 * src/modest-defs.h: Comment that the URI is only used for local folders.
2683 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2685 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2686 parameter const, just to be neat.
2687 * src/modest-text-utils.c: (modest_text_utils_inline):
2688 End g_strconcat() with NULL, as its documentation says. This is almost
2689 certainly the cause of my crash at startup on the device. Interestingly,
2690 valgrind doesn't tell us about these errors.
2692 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2694 * scripts/build-packages: Added more precise comments about how to use
2695 this script, though I still get this error:
2696 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2697 error building tinymail
2699 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2701 * src/maemo/modest-main-window.c: (on_account_update):
2702 Very slight cleanup, hoping to make it simpler to discover what causes
2703 a crash here sometimes.
2705 * src/modest-tny-account.c:
2706 (modest_tny_account_new_from_server_account): Set the port. Added
2707 comments about the options and a TODO comment because I need to find out
2708 how to specify the secure authentication method.
2710 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2712 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2713 changed CFlags paths form modest to libmodest
2715 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2717 * src/modest-account-mgr-helpers.c:
2718 (modest_account_mgr_get_server_account_data),
2719 (modest_account_mgr_free_server_account_data):
2720 * src/modest-account-mgr-helpers.h:
2721 * src/modest-account-mgr.c:
2722 (modest_account_mgr_add_server_account):
2723 * src/modest-defs.h:
2724 * src/modest-tny-account.c:
2725 (modest_tny_account_new_from_server_account):
2726 Determine the options for tny_camel_account_add_option() here,
2727 based on the settings, rather than storing them directly in gconf.
2729 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2731 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2732 Show a more friendly error dialog now that we expect (from the tinymail
2733 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2735 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2737 * src/maemo/modest-main-window.c: (on_account_update): Check that
2738 account_name is not NULL, to prevent a crash at startup that I am
2739 seeing on the N800. I do wonder why it is NULL.
2741 * src/maemo/easysetup/modest-easysetup-wizard.c:
2742 (create_page_user_details):
2743 * src/maemo/modest-account-settings-dialog.c:
2744 (create_page_user_details), (create_page_outgoing):
2745 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2746 (modest_connection_specific_smtp_edit_window_init):
2747 * src/modest-ui-actions.c:
2748 (modest_ui_actions_on_password_requested):
2749 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2750 might do something useful with the on-screen keyboard.
2752 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2754 * src/maemo/modest-main-window.c: (on_account_update):
2755 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2756 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2758 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2760 * src/modest-tny-account-store.c: (on_account_changed):
2761 Correct the signature of this signal handler.
2763 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2765 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2766 Show a HildonNote instead of a GtkDialog for Maemo.
2768 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2770 * src/widgets/modest-account-view.h:
2771 * src/widgets/modest-account-view.c: (on_account_changed),
2772 (on_account_removed). Added a boolean flag, set/unset by
2773 modest_account_view_block_conf_updates(),
2774 modest_account_view_unblock_conf_updates() to prevent unnecessary
2775 updates, but this is not very useful because the gconf notifications are
2776 so delays (maybe only on Maemo Bora).
2777 So auto-updating is turned off, and these functions do an explicit
2778 update when necessary.
2779 However, something else is still doing too much work when adding/removing
2780 accounts, probably in another part of the application.
2782 * src/maemo/modest-account-view-window.c:
2783 (on_delete_button_clicked), (on_edit_button_clicked),
2784 (on_new_button_clicked): Use the new functions.
2786 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2788 * src/modest-account-mgr-helpers.c:
2789 (modest_account_mgr_set_first_account_as_default):
2790 Sort the list of names alphabetically-by-title, so we choose the first one
2792 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2793 alphabetically by the title.
2795 This fixes projects.maemo.org bug NB#56418 .
2797 * src/modest-account-mgr-priv.c:
2798 (_modest_account_mgr_account_from_key):
2799 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2800 avoid a valgrind error, and possible random behaviour.
2802 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2804 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2805 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2806 tinymail documentation to say that this can be expected.
2807 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2808 pretty, and should not happen, but I would prefer to know when it does.
2810 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2812 * configure.ac: When using the older hildon version, probably on Bora,
2813 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2815 * src/widgets/modest-attachment-view.c:
2816 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2819 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2821 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2822 Implemented the prototype. Can be tested with
2823 tests/dbus_api/test_open_message:
2825 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2827 * src/modest-tny-account-store.c:
2828 (modest_tny_account_store_instance_init), (get_password):
2829 * src/modest-ui-actions.c:
2830 (modest_ui_actions_on_password_requested):
2831 Do not store the password in gconf, because this function is called
2832 for non-remembered passwords. Actually use the cached (in the hash map)
2833 password instead of releasing it.
2834 The password will now not be remembered if it is asked via the protected
2835 password dialog, as per the UI spec.
2837 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2839 * src/modest-defs.h:
2840 * src/modest-account-mgr-helpers.h:
2841 * src/modest-account-mgr-helpers.c:
2842 Added modest_server_account_get_username_has_succeeded(),
2843 modest_server_account_set_username_has_succeeded().
2844 (modest_server_account_set_username),
2845 Reset the has-succeeded flag if the username changes.
2847 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2848 * src/maemo/modest-connection-specific-smtp-window.c:
2849 (modest_connection_specific_smtp_window_save_server_accounts):
2850 Use modest_server_account_set_username() instead of using
2851 modest_conf_set_string() directly, so that the has-succeeded flag is always
2854 * src/modest-ui-actions.c:
2855 (modest_ui_actions_on_password_requested): Dim the username entry if
2856 the username has ever worked, as per the UI spec.
2858 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2860 * src/modest-tny-account-store.c: (get_password):
2861 * src/modest-ui-actions.c:
2862 (modest_ui_actions_on_password_requested):
2863 Allow the username to be changed too, though there is more work to
2864 be done on exactly how this behaves.
2866 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2868 * src/modest-account-mgr-helpers.h:
2869 * src/modest-account-mgr-helpers.c:
2870 Added modest_account_mgr_get_display_name(),
2871 modest_server_account_get_username(),
2872 modest_server_account_set_username(),
2873 modest_server_account_set_password(),
2874 modest_server_account_get_hostname() functions so we do not need to
2875 use the conf API directly.
2877 * src/maemo/modest-main-window.c: (connect_signals):
2878 Actually connect ot the ModestAccountStore::request-password signal,
2879 so that we show the dialog when the password is requested by Tinymail,
2880 for isntance if it is empty.
2882 * src/modest-marshal.list:
2883 * src/modest-tny-account-store.c:
2884 (modest_tny_account_store_class_init), (get_password),
2885 (modest_tny_account_store_alert):
2886 * src/modest-tny-account-store.h:
2887 * src/modest-ui-actions.h:
2888 * src/modest-ui-actions.c:
2889 (modest_ui_actions_on_password_requested):
2890 Change the signal parameters, so it is obvious that we are providing
2891 the non human-readable server name, and receiving both the username
2892 and password, though changing of the username is not yet implemented.
2893 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2894 for the GNOME version.
2896 This should fix the projects.maemo.org bug NB#56209, though it does not
2897 work on Bora, because the gconf_client_get() for the password fails
2898 immediately after we save it with gconf_client_set().
2900 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2903 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2904 caused an undefined symbol error:
2905 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2907 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2909 * src/modest-tny-account-store.c:
2910 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2911 using a GError instead of a string message, so we can translate it in
2914 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2916 * src/maemo/modest-address-book.c:
2917 (modest_address_book_check_names):
2918 * src/maemo/modest-msg-view-window.c:
2919 (modest_msg_view_window_clipboard_owner_change):
2920 * src/modest-init.c: (modest_init_init_ui):
2921 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2922 (update_folders_cb), (modest_mail_operation_update_account):
2923 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2924 (modest_ui_actions_on_msg_attachment_clicked),
2925 (modest_ui_actions_on_msg_recpt_activated):
2926 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2927 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2928 (modest_msg_view_search_next):
2929 * src/widgets/modest-recpt-editor.c:
2930 (modest_recpt_editor_on_button_release_event),
2931 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2932 g_message(). At this point we should only be seeing interesting errors on
2933 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2935 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2937 (modest_wizard_dialog_force_title_update):
2938 * src/maemo/easysetup/modest-wizard-dialog.h:
2939 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2940 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2941 can update the title when appropriate. Otherwise the title is wrong if the
2942 pages are added after adding the notebook to the dialog.
2943 This must be a problem in HildonWizardDialog too.
2944 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2946 * src/maemo/easysetup/modest-easysetup-wizard.c:
2947 (create_subsequent_customsetup_pages),
2948 (create_subsequent_easysetup_pages):
2949 Call modest_wizard_dialog_force_title_update() so that the title is
2950 correct even with GTK+ < 2.10.
2951 This fixes projects.maemo.org bug NB#56145 .
2953 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2955 * src/maemo/modest-platform.c:
2956 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2957 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2960 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2962 * src/widgets/modest-window.h:
2963 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2964 and modest_window_save_state(), which invokes it.
2966 * src/widgets/modest-window-mgr.h:
2967 * src/widgets/modest-window-mgr.c:
2968 Added modest_window_mgr_save_state_for_all_windows(), which calls
2969 the save_state vfunc on all registered windows, if implemented.
2971 * src/gnome/modest-msg-edit-window.c:
2972 * src/gnome/modest-msg-view-window.c:
2973 * src/maemo/modest-msg-edit-window.c:
2974 * src/maemo/modest-msg-view-window.c:
2975 * src/maemo/modest-main-window.c:
2976 Specify the existing save_settings functions as implementations of
2977 ModestWindow::save_state_func().
2979 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2980 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2981 enabling hibernation, for instance.
2983 We may need to do the same thing for restoring settings.
2986 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2988 * src/widgets/modest-window-mgr.c:
2989 * src/widgets/modest-window-mgr.h:
2990 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2991 modest_window_mgr_get_hibernation_is_prevented().
2993 * src/maemo/modest-main-window.c:
2994 (on_hildon_program_is_topmost_notify): Prevent hibernation
2995 (possible when the application goes to the background in the WM),
2996 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2998 * src/maemo/easysetup/modest-easysetup-wizard.c:
2999 (modest_easysetup_wizard_dialog_init):
3000 * src/maemo/modest-account-settings-dialog.c:
3001 (modest_account_settings_dialog_init):
3002 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3003 (modest_connection_specific_smtp_edit_window_init):
3004 * src/maemo/modest-connection-specific-smtp-window.c:
3005 (modest_connection_specific_smtp_window_init):
3006 * src/maemo/modest-signature-editor-dialog.c:
3007 (modest_signature_editor_dialog_init):
3008 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3009 prevent hibernation while any of these account settings dialogs are open.
3011 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3013 * src/maemo/Makefile.am:
3014 * src/maemo/modest-osso-state-saving.c:
3015 * src/maemo/modest-osso-state-saving.h: Added
3016 modest_osso_load_state() and modest_osso_save_state() though they do
3017 nothing now. They should iterate through all the open windows and load/save
3019 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3020 save state when closing.
3022 * src/maemo/modest-main-window.c:
3023 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3024 Add a notification handler for the HildonProgram::is-topmost property,
3025 so we can allow hibernation when the application goes into the background.
3026 But we still need to detect when the accounts setup windows are open so
3027 we can stop hibernation when they are open.
3028 To do this, I also added the main window the HildonProgram. This might have
3029 other side-effects/benefits, and should maybe be done for other windows.
3031 * src/maemo/modest-osso-autosave-callbacks.h:
3032 * src/maemo/modest-osso-autosave-callbacks.c:
3033 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3034 though it does not do anything yet, and we might never need this to do
3035 anything. For instance, we already save drafts.
3037 * src/maemo/modest-platform.c: (modest_platform_init):
3038 Specify the libosso auto-save callback.
3040 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3042 * src/maemo/modest-platform.c:
3043 (modest_platform_set_update_interval):
3044 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3045 aparently stays valid between application instances, so we can use this
3046 to remove and reset it later. According to a maemo-developers email from
3049 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3051 * configure.ac: Depend on libalarm for Maemo.
3053 * src/dbus_api/modest-dbus-api.h:
3054 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3055 (on_send_receive), (modest_dbus_req_handler):
3056 Handle a SEND_RECEIVE D-Bus method.
3058 * libmodest-dbus-client/libmodest-dbus-client.c:
3059 (libmodest_dbus_client_send_and_receive):
3060 * libmodest-dbus-client/libmodest-dbus-client.h:
3061 Add C convenience functions for calling the new D-Bus method.
3063 * src/modest-platform.h:
3064 * src/gnome/modest-platform.c:
3065 * src/maemo/modest-platform.c:
3066 Added modest_platform_set_update_interval(), which uses the
3067 alarmd API on Maemo.
3068 (modest_platform_init),
3069 Call modest_platform_set_update_interval(), using a hard-coded
3070 interval for now (until the global settings dialog is implemented),
3071 though I am not sure that this makes sense yet.
3073 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3075 * src/dbus_api/modest-dbus-callbacks.c:
3076 (modest_osso_cb_hw_state_handler):
3077 * src/dbus_api/modest-dbus-callbacks.h:
3078 * src/maemo/modest-platform.c: (modest_platform_init):
3079 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3080 in case this has some effect on the ability for Maemo to ping the
3083 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3085 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3086 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3087 warning. It is probably a logic error, but I need to fix the build.
3089 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3091 * src/modest-account-mgr.h:
3092 * src/modest-account-mgr.c:
3093 (modest_account_mgr_account_names): Add a gboolean enabled_only
3094 parameter, so we can get lists of onlt the enabled accounts.
3096 (modest_account_mgr_add_account),,
3097 (modest_account_mgr_account_with_display_name_exists):
3098 * src/maemo/modest-msg-edit-window.c: (get_transports):
3099 * src/modest-account-mgr-helpers.c:
3100 (modest_account_mgr_set_first_account_as_default):
3101 * src/modest-init.c: (init_default_account_maybe):
3102 * src/modest-tny-account-store.c: (get_accounts):
3103 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3104 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3105 * tests/check_account-mgr.c: (START_TEST):
3106 Provide the extra parameter, as appropriate.
3108 * src/widgets/modest-account-view.c: (update_account_view):
3109 Do not show disabled accounts (meaning that there is no way to
3110 enable/disable accounts in the UI (the feature is not in our UI
3111 specification), so we can use this internally only to mark unfinished
3112 or temporary account data.
3114 * src/maemo/easysetup/modest-easysetup-wizard.c:
3115 (create_account): Add boolean enable parameter, so we can specify FALSE
3116 to create the temporary account.
3117 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3118 (on_before_next): When finishing, when there is a temporary account, just
3120 Also, use a timeout to delay the showing of the dialog until gconf is likely
3121 to return correct information, due to a maemo gconf bug that is fixed in
3122 osso 1.1, but not yet in Bora.
3123 However, the dialog stays on screen after it is destroyed.
3125 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3126 for invalid data when cancelling. Use a hildon note instead of a dialog
3127 to complain about invalid data. Do not show the account-saved note if the
3128 account is disabled (a temporary account that will not really be saved for use
3131 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3133 * src/modest-account-mgr-helpers.h:
3134 * src/modest-account-mgr-helpers.c:
3135 Added modest_account_mgr_unset_default_account(),
3136 Added modest_account_mgr_set_first_account_as_default().
3138 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3139 If it was the default account, unset the default account name.
3141 * src/maemo/modest-account-view-window.c:
3142 (on_delete_button_clicked): If it was the default account,
3143 set the first remaining account as the default instead.
3145 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3146 a NULL account or a NULL default account, to prevent a crash. This should
3147 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3150 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3152 * src/widgets/modest-recpt-editor.c:
3153 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3154 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3155 TODO comment for this. This fixes the build.
3157 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3158 be the best place for it. This will in future update all auto-update accounts,
3159 rather than just the current/default account, when that gconf key exists.
3160 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3161 if there are no accounts, before calling do_send_receive().
3162 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3164 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3165 * src/maemo/modest-main-window-ui.h:
3166 * src/maemo/modest-main-window.c: (on_connection_changed),
3167 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3168 directly, becaue the signal handler does more.
3170 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3172 * src/modest-account-mgr-helpers.c:
3173 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3174 for the case that the account does not exist.
3176 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3177 (equivalent to the modest account name) rather than the tinymail account name
3178 (equivalent to the modest account title - human readable) to get the account data.
3179 Check for null account data to prevent the crash, and add a TODO comment saying that
3180 this needs fixing because it is using the server account name instead of the account name.
3182 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3184 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3185 * src/maemo/modest-account-settings-dialog.c: (show_error),
3187 Use hildon_note_new_information() for informative and error messages,
3188 which seems to be expected for Maemo applications (no documentation that I know of
3189 says this). I am surprised that there is no distinction between info and error
3192 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3194 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3195 it is easy to find where this is used.
3197 * src/maemo/easysetup/modest-easysetup-wizard.c:
3198 (create_page_welcome), (create_page_account_details),
3199 (create_page_user_details), (create_page_complete_easysetup),
3200 (create_page_custom_incoming), (create_page_custom_outgoing),
3201 (create_page_complete_custom):
3202 * src/maemo/modest-account-settings-dialog.c:
3203 (create_page_account_details), (create_page_user_details),
3204 (create_page_incoming), (create_page_outgoing):
3205 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3206 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3207 (modest_connection_specific_smtp_edit_window_init):
3208 * src/maemo/modest-connection-specific-smtp-window.c:
3209 (modest_connection_specific_smtp_window_init):
3210 * src/maemo/modest-signature-editor-dialog.c:
3211 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3212 and scrolling policy as per the Email Application Layout Guide, if I have
3215 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3217 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3218 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3219 which were empty, because these vfuncs have been removed from TnyAccountStore.
3220 This fixes the build.
3222 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3224 * src/maemo/modest-main-window.c:
3225 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3226 showing/hiding it. Added TODO because it probably should not be NULL.
3227 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3228 because unnecessary g_warnings() make degugging difficult.
3230 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3232 * src/maemo/modest-msg-edit-window.c:
3233 (modest_msg_edit_window_select_color),
3234 (modest_msg_edit_window_select_background_color): 2 const corrections and
3235 moving 2 #endifs before closing brackets, to fix the build.
3237 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3239 * src/maemo/easysetup/modest-easysetup-wizard.h:
3240 * src/maemo/easysetup/modest-easysetup-wizard.c:
3241 (modest_easysetup_wizard_dialog_finalize),
3242 (on_button_edit_advanced_settings), (create_page_complete_custom),
3243 (on_response), (create_account):
3244 Implement the Advanced Settings edit button, by saving the account information,
3245 for the Advanded Settings dialog to use directly from gconf, and removing it
3246 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3247 Bug #5533 in the projects.maemo.org bugzilla.
3249 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3251 * src/maemo/modest-msg-view-window.c:
3252 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3253 when opening a message window.
3255 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3257 * src/maemo/easysetup/modest-easysetup-wizard.c:
3258 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3261 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3262 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3263 gconf settings. I probably added more checks than necessary, but that is safer.
3265 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3266 variable to fix the build, but this seems to be used when it is still NULL.
3268 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3270 * src/modest-platform.h:
3271 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3272 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3273 * src/modest-main.c: Implement this function so we can avoid using
3274 maemo-specific API from cross-platform code.
3276 * src/modest-tny-account-store.c:
3277 (get_smtp_specific_transport_account_for_open_connection):
3278 * src/modest-ui-actions.c: (check_for_connection),
3279 (modest_ui_actions_on_item_not_found):
3280 Use modest_platform_connect_and_wait() and put #idefs around other
3281 maemo-specific code, because only maemo currently has a way to
3282 identify connection names.
3284 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3286 * src/modest-tny-account-store.h:
3287 * src/modest-tny-account-store.c:
3288 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3289 the connection-specific SMTP server settings in the configuration.
3291 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3293 * src/maemo/modest-main-window.c: (on_connection_changed),
3295 * src/modest-main.c: (main), (start_ui), (send_mail):
3296 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3297 that is what is intended.
3299 * src/modest-ui-actions.c: (action_send), (action_receive),
3300 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3301 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3302 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3303 SMTP server is used when it is specified.
3305 (modest_ui_actions_on_send_receive):
3306 Check that a connection is open before proceeding.
3307 Receive and then send, instead of vice-versa, as per the specification.
3309 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3311 * src/modest-mail-operation.c:
3312 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3313 though I guess it should be something other than NULL.
3315 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3317 * src/maemo/easysetup/modest-easysetup-wizard.c:
3318 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3319 combo twice, to avoid an g_warning and to make it visible again.
3320 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3321 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3322 (already intended) dereference when detaching, because we then recreate the menu.
3323 But I am not sure why the warning was happening, and it is possible that this is a memory
3326 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3328 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3329 and uri_parse_mailto() utility functions.
3330 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3332 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3334 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3336 * src/dbus_api/modest-dbus-api.h:
3337 * src/dbus_api/modest-dbus-callbacks.c:
3338 Use an idle callback to execute the modest code in the application's own thread.
3339 Remove the helloworld example method.
3340 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3341 parsed, and the open-message method is not implemented because this is not yet implemented in
3343 * libmodest-dbus-client/libmodest-dbus-client.c:
3344 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3345 (libmodest_dbus_client_open_message):
3346 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3348 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3349 body without crashing.
3351 * tests/dbus_api/Makefile.am:
3352 * tests/dbus_api/test_mail_to.c:
3353 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3355 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3357 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3358 Added file to fix the build. Sorry.
3360 * src/dbus_api/Makefile.am:
3361 * src/dbus_api/modest-dbus-api.h:
3362 * src/dbus_api/modest-dbus-callbacks.h:
3363 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3364 (modest_dbus_req_handler):
3365 Put constants in a separate header so it can be reused by the
3366 client library, without duplication
3368 * libmodest-dbus-client/Makefile.am:
3369 * libmodest-dbus-client/libmodest-dbus-client.c:
3370 (libmodest_dbus_client_call_helloworld),
3371 (libmodfest_dbus_client_send_mail),
3372 (libmodfest_dbus_client_mailto),
3373 (libmodfest_dbus_client_open_message):
3374 * libmodest-dbus-client/libmodest-dbus-client.h:
3375 (Partly) Implement a send_mail D-Bus method.
3377 * tests/dbus_api/Makefile.am:
3378 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3379 the send_email D-Bus method.
3381 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3385 * libmodest-dbus-client/Makefile.am:
3386 * libmodest-dbus-client/libmodest-dbus-client.c:
3387 * libmodest-dbus-client/libmodest-dbus-client.h:
3388 * tests/dbus_api/Makefile.am:
3389 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3390 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3392 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3394 * src/maemo/easysetup/modest-easysetup-wizard.c:
3395 (create_page_account_details):
3396 * src/maemo/modest-account-settings-dialog.c:
3397 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3398 widgets, because this might not be the default in future versions of the Maemo GTK+.
3399 However, I can not not get capitalization to work even in a simple test case.
3401 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3403 * src/maemo/easysetup/modest-easysetup-wizard.c:
3404 (create_page_custom_incoming), (create_page_custom_outgoing):
3405 * src/maemo/modest-account-settings-dialog.c:
3406 (create_page_account_details), (create_page_incoming),
3407 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3408 instead of using gtk_check_button_with_label(), so they are aligned like the other
3409 widgets, as per the UI spec.
3411 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3413 * src/maemo/easysetup/modest-easysetup-wizard.c:
3414 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3415 * src/widgets/modest-validating-entry.c:
3416 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3417 Modest prefix instead of an EasySetup prefix.
3419 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3421 * src/widgets/modest-validating-entry.h:
3422 * src/widgets/modest-validating-entry.c: (on_insert_text),
3423 Added easysetup_validating_entry_set_max_func(), used to set a callback
3424 to call when the max number of characters is reached. GtkEntry has a max-length
3425 already but is silent about it.
3427 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3428 (create_page_account_details), (create_page_user_details),
3430 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3431 (create_page_account_details), (create_page_user_details),
3432 (create_page_outgoing):
3433 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3434 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3435 the UI spec, when the user tries to enter more than the max number of characters.
3437 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3439 * src/maemo/easysetup/modest-easysetup-wizard.c:
3440 (create_page_user_details), (create_page_custom_incoming),
3441 (create_page_custom_outgoing):
3442 * src/maemo/modest-account-settings-dialog.c:
3443 (create_page_user_details), (create_page_incoming),
3444 (create_page_outgoing):
3445 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3446 (modest_connection_specific_smtp_edit_window_init):
3447 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3448 not appropriate. Bad Maemo-specific defaults!.
3450 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3452 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3453 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3454 (modest_signature_editor_dialog_set_settings):
3455 Disable the label and textview when the checkbox is disabled, and use the
3456 specified (UI spec) default signature text.
3458 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3460 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3461 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3463 * src/modest-defs.h:
3464 * src/modest-account-mgr-helpers.h:
3465 * src/modest-account-mgr-helpers.c:
3466 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3468 * src/maemo/Makefile.am:
3469 * src/maemo/modest-signature-editor-dialog.c:
3470 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3473 * src/maemo/modest-account-settings-dialog.h:
3474 * src/maemo/modest-account-settings-dialog.c:
3475 (modest_account_settings_dialog_finalize), (on_button_signature),
3476 (save_configuration): Use the new dialog when the Edit button is pressed, and
3477 save the changes if necessary, as per the UI spec.
3479 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3481 * src/maemo/Makefile.am:
3482 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3483 based on maemo-develoers email from Dirk.
3485 * src/maemo/easysetup/modest-easysetup-wizard.c:
3486 (create_page_welcome), (create_page_account_details),
3487 (create_page_user_details), (create_page_complete_easysetup),
3488 (create_page_custom_incoming), (create_page_custom_outgoing),
3489 (create_page_complete_custom),
3490 (modest_easysetup_wizard_dialog_init):
3491 * src/maemo/modest-account-settings-dialog.c:
3492 (create_page_account_details), (create_page_user_details),
3493 (create_page_incoming), (create_page_outgoing),
3494 (modest_account_settings_dialog_init):
3495 * src/maemo/modest-connection-specific-smtp-window.c:
3496 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3498 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3500 * src/maemo/easysetup/modest-easysetup-wizard.c:
3501 (create_page_account_details), (create_page_custom_outgoing),
3502 (create_page_complete_custom):
3503 * src/maemo/modest-account-settings-dialog.c:
3504 (create_page_user_details), (create_page_incoming),
3505 (create_page_outgoing):
3506 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3507 (modest_connection_specific_smtp_edit_window_init):
3508 Use the correct (UI spec) port min/max, and use horizontal separators,
3511 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3513 * src/maemo/easysetup/modest-easysetup-wizard.c:
3514 (set_default_custom_servernames):
3515 * src/maemo/modest-account-settings-dialog.c:
3516 (create_page_incoming), (on_combo_outgoing_security_changed),
3517 (on_combo_incoming_security_changed), (create_page_outgoing),
3518 (modest_account_settings_dialog_set_account_name),
3519 (save_configuration):
3520 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3521 (on_combo_security_changed),
3522 (modest_connection_specific_smtp_edit_window_init),
3523 (modest_connection_specific_smtp_edit_window_set_connection),
3524 (modest_connection_specific_smtp_edit_window_get_settings):
3525 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3528 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3531 * src/maemo/easysetup/modest-easysetup-wizard.c:
3532 (create_page_custom_outgoing), (create_page_complete_custom):
3533 * src/maemo/modest-account-settings-dialog.c:
3534 (create_page_user_details), (create_page_outgoing):
3535 * src/maemo/modest-account-view-window.c: (button_box_new):
3536 Use changed logical IDs as per the most recent UI spec:
3537 mcen_bd_emailsetup_edit -> mcen_bd_edit
3538 mcen_bd_emailsetup_delete -> mcen_bd_delete
3539 mcen_bd_emailsetup_close -> mcen_bd_close
3541 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3545 * src/dbus_api/Makefile.am:
3546 * src/dbus_api/modest-dbus-callbacks.c:
3547 * src/dbus_api/modest-dbus-callbacks.h:
3548 * src/maemo/modest-platform.c: (modest_platform_init):
3549 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3551 * tests/Makefile.am:
3552 * tests/dbus_api/Makefile.am:
3553 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3555 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3557 * src/maemo/modest-account-settings-dialog.c:
3558 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3559 Removed unnecessary includes.
3561 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3563 * src/maemo/easysetup/modest-easysetup-wizard.c:
3564 * src/maemo/modest-account-settings-dialog.c:
3565 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3566 * src/widgets/Makefile.am:
3567 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3568 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3569 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3570 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3571 * src/widgets/modest-secureauth-combo-box.c:
3572 * src/widgets/modest-secureauth-combo-box.h:
3573 * src/widgets/modest-serversecurity-combo-box.c:
3574 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3575 made the GObject names more consistent with the rest of the Modest code.
3577 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3579 * src/maemo/easysetup/Makefile.am:
3580 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3581 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3582 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3583 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3584 * src/maemo/easysetup/modest-easysetup-wizard.c:
3585 * src/maemo/easysetup/modest-validating-entry.c:
3586 * src/maemo/easysetup/modest-validating-entry.h:
3587 * src/maemo/modest-account-settings-dialog.c:
3588 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3589 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3590 widgets/ because they are used outside of easysetup too. After checking in,
3591 svn will allow me to rename them too.
3593 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3595 * src/gnome/modest-msg-edit-window.c:
3596 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3597 linker error, to fix the build on the GNOME platform.
3598 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3599 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3600 ifdefed out to avoid a warning.
3602 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3604 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3605 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3606 some alternative for GTK+ 2.6.
3608 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3610 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3612 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3613 specified for EmailAccountsDialog in UI spec.
3615 * src/maemo/easysetup/modest-easysetup-wizard.c:
3616 * src/maemo/easysetup/modest-easysetup-wizard.h:
3617 * src/maemo/modest-account-settings-dialog.c:
3618 * src/maemo/modest-account-settings-dialog.h:
3619 Reuse a member window widget for the connection-specific SMTP server accounts,
3620 so we can tell it to create/save the accounts only if we actually save changes.
3622 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3623 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3624 (modest_connection_specific_smtp_edit_window_get_settings):
3625 Return a struct instance for temporarily remembering the entered data.
3627 * src/maemo/modest-connection-specific-smtp-window.h:
3628 * src/maemo/modest-connection-specific-smtp-window.c:
3629 (modest_connection_specific_smtp_window_finalize),
3630 (modest_connection_specific_smtp_window_fill_with_connections),
3632 (modest_connection_specific_smtp_window_save_server_accounts),
3633 (update_model_server_names): Do not actually save data until asked,
3634 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3636 (on_selection_changed),
3637 (modest_connection_specific_smtp_window_init): Disable the edit
3638 button when nothing is selected.
3640 * src/modest-account-mgr-helpers.c:
3641 * src/modest-account-mgr-helpers.h:
3642 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3645 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3647 * src/modest-account-mgr-helpers.h:
3648 * src/modest-account-mgr-helpers.c:
3649 (modest_account_mgr_get_unused_account_name),
3650 (modest_account_mgr_get_unused_account_display_name): Added these
3651 utility functions, to avoid code duplication.
3653 * src/maemo/easysetup/modest-easysetup-wizard.c:
3654 (create_page_account_details), (create_account):
3655 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3656 (on_combo_security_changed),
3657 (modest_connection_specific_smtp_edit_window_init),
3658 (modest_connection_specific_smtp_edit_window_save_settings):
3659 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3660 * src/maemo/modest-connection-specific-smtp-window.c:
3661 (modest_connection_specific_smtp_window_finalize),
3662 (modest_connection_specific_smtp_window_fill_with_connections),
3663 (on_button_edit), (modest_connection_specific_smtp_window_init):
3664 * src/maemo/modest-connection-specific-smtp-window.h:
3665 Implementing saving of connection-specific server accounts.
3667 But I need to refactor this so we can save the data for each
3668 possible connection-specific account and only actually create the server accounts
3669 when the easysetup finished, or the OK button is pressed on the account settings
3672 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3674 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3675 (on_combo_security_changed):
3676 (modest_connection_specific_smtp_edit_window_init):
3677 Auto-fill the port number as in the account settings.
3679 (modest_connection_specific_smtp_edit_window_set_connection):
3680 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3681 * src/maemo/modest-connection-specific-smtp-window.c:
3682 (fill_with_connections), (on_button_edit),
3683 (modest_connection_specific_smtp_window_init):
3684 Turn the edit window into a dialog to simplify the code, and
3685 set a WM hint as in a GtkDialog, because only a popup can be on top of
3686 another window in Maemo, and popups usually have no WM decoration.
3688 * src/modest-defs.h:
3689 * src/modest-account-mgr-helpers.c:
3690 (modest_account_mgr_set_connection_specific_smtp),
3691 (modest_account_mgr_remove_connection_specific_smtp),
3692 (modest_account_mgr_get_connection_specific_smtp):
3693 * src/modest-account-mgr-helpers.h: Some functions to write the
3694 connection-specific SMTP server information. Not yet used.
3697 * src/widgets/modest-folder-view.c: (text_cell_data):
3698 Fix a warning about an uninitialized variable.
3699 (on_configuration_key_changed): Put an #ifdef around the use
3700 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3702 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3704 * src/maemo/modest-account-settings-dialog.h:
3705 * src/maemo/modest-account-settings-dialog.c:
3706 Added connect_for_modified() utility function to mark the new modified boolean.
3708 (create_page_account_details), (create_page_user_details),
3709 (create_page_incoming), (create_page_outgoing), (on_response),
3710 (modest_account_settings_dialog_init),
3711 (modest_account_settings_dialog_set_account_name):
3712 Only warn about unsaved changes when there are actually unsaved changes.
3714 * src/modest-account-mgr-helpers.c:
3715 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3716 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3717 to get the data from there in future.
3719 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3721 * src/modest-defs.h:
3723 * src/modest-account-mgr-helpers.h:
3724 * src/modest-account-mgr-helpers.c:
3725 Store the security account setting in a single conf key instead of using
3726 the options list, so that the list is left for just the to-be-removed camel hack,
3727 and because gconf_client_set_list() is failing for some reason.
3729 * src/modest-account-mgr.c:
3730 (modest_account_mgr_add_server_account):
3731 * src/maemo/modest-account-settings-dialog.c:
3732 (modest_account_settings_dialog_set_account_name),
3733 (save_configuration): Use the renamed functions.
3736 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3738 * src/widgets/Makefile.am:
3739 * src/widgets/modest-limit-retrieve-combo-box.c:
3740 * src/widgets/modest-limit-retrieve-combo-box.h:
3741 * src/widgets/modest-retrieve-combo-box.c:
3742 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3743 the account settings dialog.
3745 * src/modest-defs.h:
3746 * src/modest-account-mgr-helpers.h:
3747 * src/modest-account-mgr-helpers.c:
3748 (modest_server_account_get_option_secure_auth),
3749 (modest_server_account_set_option_secure_auth):
3750 * src/modest-account-mgr.c:
3751 (modest_account_mgr_add_server_account):
3752 Use the existing AUTH_MECH conf key for the secure-auth setting,
3753 instead of putting it in the list options, because this was actually used already.
3755 * src/maemo/modest-account-settings-dialog.c:
3756 (create_page_account_details),
3757 (modest_account_settings_dialog_set_account_name),
3758 (save_configuration):
3759 * src/maemo/modest-account-settings-dialog.h:
3760 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3761 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3763 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3765 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3766 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3767 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3769 * src/modest-defs.h:
3770 * src/maemo/modest-account-settings-dialog.c:
3771 (create_page_incoming), (on_combo_outgoing_security_changed),
3772 (on_combo_incoming_security_changed), (create_page_outgoing),
3773 (modest_account_settings_dialog_set_account_name),
3774 (save_configuration): Load/Save the port number, and change it when the
3775 security combo changes, to suitable defaults.
3777 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3779 * src/modest-account-mgr.c:
3780 (modest_account_mgr_add_server_account): Set the security and secure-auth
3781 options, and add a comment saying that the other camel-specific options should be
3784 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3786 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3788 * src/modest-tny-account-store.c: (account_list_free),
3789 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3790 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3793 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3795 * src/modest-protocol-info.c:
3796 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3797 is required by our UI spec. Maybe something in our implementation will use this eventually.
3798 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3799 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3800 instead of the previous 0 placeholder.
3802 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3803 secure-auth settings.
3804 * src/modest-account-mgr-helpers.h:
3805 * src/modest-account-mgr-helpers.c:
3806 (modest_server_account_data_get_option_secure_auth),
3807 (modest_server_account_set_option_secure_auth),
3808 (modest_server_account_data_get_option_security),
3809 (modest_server_account_set_option_security): Added this API for getting and setting the security
3810 and secure-auth settings.
3812 * src/maemo/modest-account-settings-dialog.h:
3813 * src/maemo/modest-account-settings-dialog.c:
3814 (modest_account_settings_dialog_finalize), (check_data),
3815 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3816 about changing titles.
3817 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3818 (save_configuration): Save the security and secure-auth settings.
3820 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3821 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3823 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3825 * src/modest-defs.h:
3826 * src/modest-account-mgr.c:
3827 (modest_account_mgr_add_server_account):
3828 Added and used defines for the options key and value pair strings,
3829 that are used so far, though they do not seem to correspond to anything in our
3830 UI specs or ModestProtocol enum.
3832 * src/modest-account-mgr-helpers.h:
3833 * src/modest-account-mgr-helpers.c:
3834 (compare_option_strings_for_name),
3835 (modest_server_account_data_get_option_value),
3836 (modest_server_account_data_get_option_bool),
3837 (modest_account_mgr_get_server_account_option):
3838 Added helper functions for parsing the options GSList.
3840 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3842 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3843 display name is based on the supplied account name.
3844 * src/modest-account-mgr.c:
3845 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3846 with an inefficient, but good-enough, implementation.
3848 * src/maemo/easysetup/modest-easysetup-wizard.c:
3849 (create_page_account_details), (on_before_next), (create_account):
3850 Check for existing display names rather than (non-user-visible) account names, and just
3851 create and set a unique account name at the end.
3853 * src/maemo/modest-account-settings-dialog.c:
3854 (modest_account_settings_dialog_init),
3855 (modest_account_settings_dialog_set_account_name),
3856 (create_page_incoming): Show the display name, instead of the account name.
3857 (on_response): Do some (not all) extra checks, as in the UI spec.
3858 (save_configuration): Save the display name if it was changed.
3860 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3862 * po/en_GB.po: Added needed logical ID and translation.
3863 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3864 (init_view): Made the is-default column clicking work.
3866 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3869 * src/maemo/easysetup/Makefile.am:
3870 * src/maemo/easysetup/modest-easysetup-wizard.c:
3871 (modest_easysetup_wizard_dialog_init):
3872 * src/maemo/easysetup/provider-data-test.keyfile:
3873 * src/maemo/easysetup/provider-data.keyfile:
3874 Moved the provider data file to the new modest-providers-data package and used it from there.
3876 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3878 * src/modest-local-folder-info.c:
3879 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3880 N_() was already used on the static strings, but this just marks it for translation without
3881 using the translation.
3883 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3885 * src/maemo/modest-account-settings-dialog.c:
3886 (create_page_incoming),
3887 (modest_account_settings_dialog_set_account_name):
3888 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3889 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3890 I will do this if nobody else gets there first.
3892 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3894 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3895 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3896 save the security stuff.
3898 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3900 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3901 Set the email address and user fullname, which I now see must be
3904 * src/maemo/modest-account-settings-dialog.h:
3905 * src/maemo/modest-account-settings-dialog.c:
3907 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3908 leave-on-server and authentication.
3909 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3912 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3915 * src/maemo/modest-account-settings-dialog.c:
3916 * src/maemo/modest-account-settings-dialog.h:
3917 Most (but not all) of the widgets are now present as specified by the UI spec.
3918 No changes are yet saved, and some details are not properly shown yet.
3920 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3922 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3924 * src/maemo/Makefile.am:
3925 * src/maemo/modest-account-settings-dialog.c:
3926 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3927 an existing account. Doesn't do much yet.
3929 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3930 Open the accounts settings dialog when Edit is clicked.
3932 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3934 * src/maemo/easysetup/Makefile.am:
3935 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3937 * src/maemo/easysetup/modest-easysetup-wizard.c:
3938 (modest_easysetup_wizard_dialog_init):
3939 Try to get the source directory from the build system,
3940 instead of hard-coding "./" into the source code, when opening our local
3941 copies of the configuration files.
3942 But this still fails when opening the wizard from the Accounts window,
3943 maybe because the working directory seems to change at runtime.
3944 So the wizard will fail the second time unless you copy the files into their
3945 proper locations - see the stdout warnings for the paths.
3947 (create_page_account_details),(on_before_next):
3948 Check for existing non-server accounts instead of server accounts,
3949 so the default account name is useful again, and to prevent trying to
3952 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3953 Show the wizard when New is clicked.
3955 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3956 (init_view): Show the column headers, and show the columns that are
3957 specified in the UI specs. However, something in Maemo's GTK+ prevents
3958 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3959 change the default account. This is despite unsetting the special properties.
3961 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3963 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3964 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3965 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3966 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3967 to make that clearer.
3968 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3970 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3972 * src/maemo/modest-account-view-window.c:
3973 (modest_account_view_window_init),
3974 (modest_account_view_window_new):
3975 Use the same buttons as specified in the
3976 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3977 the existing widgets, which never had a chance of working.
3978 Put the ModestAccountView treeview in a scrolled window.
3979 Do not repeat the initialization in both _init() and _new().
3981 * src/widgets/modest-account-view.c: (update_account_view):
3982 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3983 this widget and window shows no accounts.
3985 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3987 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3989 * src/maemo/easysetup/modest-easysetup-wizard.c:
3990 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3991 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3992 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3995 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3996 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3997 accounts exist yet, as in the UI spec.
3999 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4001 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4003 * src/maemo/Makefile.am:
4004 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4005 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4006 New window for editing connection-specific smtp details.
4007 Not fully implemented.
4009 * src/maemo/modest-connection-specific-smtp-window.c:
4010 (modest_connection_specific_smtp_window_finalize) :
4011 unref the tree model.
4012 (on_button_edit): Show the edit window.
4014 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4016 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4019 * src/maemo/Makefile.am:
4020 * src/maemo/modest-connection-specific-smtp-window.c:
4021 * src/maemo/modest-connection-specific-smtp-window.h:
4022 New window for showing the list of connections, for connection-specific
4023 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4024 * src/maemo/easysetup/modest-easysetup-wizard.c:
4025 (create_page_custom_outgoing): Show the new window when the button is clicked.
4027 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4029 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4030 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4031 * src/maemo/modest-msg-edit-window.c:
4032 (modest_msg_edit_window_insert_image):
4033 * src/modest-conf.c: (modest_conf_key_escape):
4034 * src/modest-mail-operation.c:
4035 (modest_mail_operation_send_new_mail):
4036 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4037 (modest_ui_actions_on_new_account):
4038 * src/widgets/modest-attachment-view.c: (update_filename_request):
4039 * src/widgets/modest-mail-header-view.c:
4040 Corrected warnings that were breaking the build, by commenting out unused variables,
4041 and a function, and by including a header.
4043 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4045 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4046 so we can #ifdef around platform-specific code when necessary.
4047 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4048 to allow this to build for the GNOME platform too.
4050 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4052 * src/maemo/easysetup/modest-easysetup-wizard.c:
4053 Added util_increment_name() and used it in create_page_account_details()
4054 to make sure that the default account name is always a new name.
4056 (modest_easysetup_wizard_dialog_init),
4057 (set_default_custom_servernames): Some minor memory management fixes.
4059 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4063 * src/modest-runtime.c: (init_i18n): Restored the translation
4064 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4065 are defined in config.h, and the translations are installed.
4067 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4068 is defined for translation.
4070 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4072 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4074 * src/maemo/easysetup/modest-easysetup-wizard.c:
4075 (modest_easysetup_wizard_dialog_init):
4076 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4077 Use realistic paths (though they should use $prefix generically) to the
4078 mcc_mapping and provider-data.keyfile files which might work when they
4079 are installed by the future version of the operator-wizard package,
4080 and then fallback to paths in our source code, with an explanatory
4083 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4087 * src/maemo/Makefile.am:
4088 * src/maemo/easysetup/: Added files from the previously-exernal
4089 osso-modest-easysetup.
4090 * src/maemo/modest-main-window-ui.h:
4091 * src/modest-ui-actions.c:
4092 * src/modest-ui-actions.h:
4093 Added modest_ui_actions_on_new_account() as a signal handler for the
4094 New Account menu item. It shows the easysetup wizard.
4095 * po/en_GB.po: Added additional needed logical IDs and translations.