2007-04-24 Murray Cumming <murrayc@murrayc.com>
[modest] / ChangeLog2
1 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
2
3         * src/maemo/easysetup/modest-easysetup-wizard.c:
4         (create_page_account_details):
5         * src/maemo/modest-account-settings-dialog.c:
6         (create_page_account_details): Explicitly set auto-capitalization mode for the title 
7         widgets, because this might not be the default in future versions of the Maemo GTK+. 
8         However, I can not not get capitalization to work even in a simple test case.
9
10 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
11
12         * src/maemo/easysetup/modest-easysetup-wizard.c:
13         (create_page_custom_incoming), (create_page_custom_outgoing):
14         * src/maemo/modest-account-settings-dialog.c:
15         (create_page_account_details), (create_page_incoming),
16         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons, 
17         instead of using gtk_check_button_with_label(), so they are aligned like the other 
18         widgets, as per the UI spec.
19
20 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
21
22         * src/maemo/easysetup/modest-easysetup-wizard.c:
23         * src/maemo/modest-connection-specific-smtp-edit-window.c:
24         * src/widgets/modest-validating-entry.c:
25         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a 
26         Modest prefix instead of an EasySetup prefix.
27
28 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
29
30         * src/widgets/modest-validating-entry.h:
31         * src/widgets/modest-validating-entry.c: (on_insert_text),
32         Added easysetup_validating_entry_set_max_func(), used to set a callback 
33         to call when the max number of characters is reached. GtkEntry has a max-length 
34         already but is silent about it.
35
36         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
37         (create_page_account_details), (create_page_user_details),
38         (create_account):
39         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
40         (create_page_account_details), (create_page_user_details),
41         (create_page_outgoing):
42         * src/modest-ui-actions.c: (modest_ui_actions_on_details): 
43         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per 
44         the UI spec, when the user tries to enter more than the max number of characters.
45
46 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
47
48         * src/maemo/easysetup/modest-easysetup-wizard.c:
49         (create_page_user_details), (create_page_custom_incoming),
50         (create_page_custom_outgoing):
51         * src/maemo/modest-account-settings-dialog.c:
52         (create_page_user_details), (create_page_incoming),
53         (create_page_outgoing):
54         * src/maemo/modest-connection-specific-smtp-edit-window.c:
55         (modest_connection_specific_smtp_edit_window_init):
56         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is 
57         not appropriate. Bad Maemo-specific defaults!.
58
59 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
60
61         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
62         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
63         (modest_signature_editor_dialog_set_settings): 
64         Disable the label and textview when the checkbox is disabled, and use the 
65         specified (UI spec) default signature text.
66
67 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
68
69         * src/maemo/modest-connection-specific-smtp-edit-window.c:
70         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
71         
72         * src/modest-defs.h:
73         * src/modest-account-mgr-helpers.h:
74         * src/modest-account-mgr-helpers.c:
75         Added modest_account_mgr_get/set_signature(), using new gconf keys.
76         
77         * src/maemo/Makefile.am:
78         * src/maemo/modest-signature-editor-dialog.c:
79         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures, 
80         as per the UI spec.
81         
82         * src/maemo/modest-account-settings-dialog.h:
83         * src/maemo/modest-account-settings-dialog.c:
84         (modest_account_settings_dialog_finalize), (on_button_signature),
85         (save_configuration): Use the new dialog when the Edit button is pressed, and 
86         save the changes if necessary, as per the UI spec.
87
88 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
89
90         * src/maemo/Makefile.am:
91         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing, 
92         based on maemo-develoers email from Dirk.
93         
94         * src/maemo/easysetup/modest-easysetup-wizard.c:
95         (create_page_welcome), (create_page_account_details),
96         (create_page_user_details), (create_page_complete_easysetup),
97         (create_page_custom_incoming), (create_page_custom_outgoing),
98         (create_page_complete_custom),
99         (modest_easysetup_wizard_dialog_init):
100         * src/maemo/modest-account-settings-dialog.c:
101         (create_page_account_details), (create_page_user_details),
102         (create_page_incoming), (create_page_outgoing),
103         (modest_account_settings_dialog_init):
104         * src/maemo/modest-connection-specific-smtp-window.c:
105         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
106
107 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
108
109         * src/maemo/easysetup/modest-easysetup-wizard.c:
110         (create_page_account_details), (create_page_custom_outgoing),
111         (create_page_complete_custom):
112         * src/maemo/modest-account-settings-dialog.c:
113         (create_page_user_details), (create_page_incoming),
114         (create_page_outgoing):
115         * src/maemo/modest-connection-specific-smtp-edit-window.c:
116         (modest_connection_specific_smtp_edit_window_init): 
117         Use the correct (UI spec) port min/max, and use horizontal separators, 
118         as per the UI spec.
119
120 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
121
122         * src/maemo/easysetup/modest-easysetup-wizard.c:
123         (set_default_custom_servernames):
124         * src/maemo/modest-account-settings-dialog.c:
125         (create_page_incoming), (on_combo_outgoing_security_changed),
126         (on_combo_incoming_security_changed), (create_page_outgoing),
127         (modest_account_settings_dialog_set_account_name),
128         (save_configuration):
129         * src/maemo/modest-connection-specific-smtp-edit-window.c:
130         (on_combo_security_changed),
131         (modest_connection_specific_smtp_edit_window_init),
132         (modest_connection_specific_smtp_edit_window_set_connection),
133         (modest_connection_specific_smtp_edit_window_get_settings): 
134         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
135         as per the UI spec.
136
137 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
138
139         * po/en_GB.po:
140         * src/maemo/easysetup/modest-easysetup-wizard.c:
141         (create_page_custom_outgoing), (create_page_complete_custom):
142         * src/maemo/modest-account-settings-dialog.c:
143         (create_page_user_details), (create_page_outgoing):
144         * src/maemo/modest-account-view-window.c: (button_box_new):
145         Use changed logical IDs as per the most recent UI spec:
146         mcen_bd_emailsetup_edit -> mcen_bd_edit
147         mcen_bd_emailsetup_delete -> mcen_bd_delete
148         mcen_bd_emailsetup_close -> mcen_bd_close
149
150 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
151
152         * configure.ac:
153         * src/Makefile.am:
154         * src/dbus_api/Makefile.am:
155         * src/dbus_api/modest-dbus-callbacks.c:
156         * src/dbus_api/modest-dbus-callbacks.h:
157         * src/maemo/modest-platform.c: (modest_platform_init):
158         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld 
159         method.
160         * tests/Makefile.am:
161         * tests/dbus_api/Makefile.am:
162         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
163
164 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
165
166         * src/maemo/modest-account-settings-dialog.c:
167         * src/maemo/modest-connection-specific-smtp-edit-window.c:
168         Removed unnecessary includes.
169
170 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
171
172         * src/maemo/easysetup/modest-easysetup-wizard.c:
173         * src/maemo/modest-account-settings-dialog.c:
174         * src/maemo/modest-connection-specific-smtp-edit-window.c:
175         * src/widgets/Makefile.am:
176         * src/widgets/modest-easysetup-secureauth-combo-box.c:
177         * src/widgets/modest-easysetup-secureauth-combo-box.h:
178         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
179         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
180         * src/widgets/modest-secureauth-combo-box.c:
181         * src/widgets/modest-secureauth-combo-box.h:
182         * src/widgets/modest-serversecurity-combo-box.c:
183         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and 
184         made the GObject names more consistent with the rest of the Modest code.
185
186 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
187
188         * src/maemo/easysetup/Makefile.am:
189         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
190         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
191         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
192         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
193         * src/maemo/easysetup/modest-easysetup-wizard.c:
194         * src/maemo/easysetup/modest-validating-entry.c:
195         * src/maemo/easysetup/modest-validating-entry.h:
196         * src/maemo/modest-account-settings-dialog.c:
197         * src/maemo/modest-connection-specific-smtp-edit-window.c:
198         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into 
199         widgets/ because they are used outside of easysetup too. After checking in, 
200         svn will allow me to rename them too.
201
202 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
203
204         * src/gnome/modest-msg-edit-window.c:
205         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a 
206         linker error, to fix the build on the GNOME platform.
207         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(), 
208         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
209         ifdefed out to avoid a warning.
210
211 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
212
213         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the 
214         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs 
215         some alternative for GTK+ 2.6.
216
217 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
218
219         * src/maemo/modest-address-book.c: Added include to avoid a warning.
220
221         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string, 
222         specified for EmailAccountsDialog in UI spec.
223         
224         * src/maemo/easysetup/modest-easysetup-wizard.c:
225         * src/maemo/easysetup/modest-easysetup-wizard.h:
226         * src/maemo/modest-account-settings-dialog.c:
227         * src/maemo/modest-account-settings-dialog.h:
228         Reuse a member window widget for the connection-specific SMTP server accounts, 
229         so we can tell it to create/save the accounts only if we actually save changes.
230
231         * src/maemo/modest-connection-specific-smtp-edit-window.h:      
232         * src/maemo/modest-connection-specific-smtp-edit-window.c:
233         (modest_connection_specific_smtp_edit_window_get_settings): 
234         Return a struct instance for temporarily remembering the entered data.
235
236         * src/maemo/modest-connection-specific-smtp-window.h:
237         * src/maemo/modest-connection-specific-smtp-window.c:
238         (modest_connection_specific_smtp_window_finalize),
239         (modest_connection_specific_smtp_window_fill_with_connections),
240         (on_button_edit),
241         (modest_connection_specific_smtp_window_save_server_accounts),
242         (update_model_server_names): Do not actually save data until asked, 
243         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
244         
245         (on_selection_changed),
246         (modest_connection_specific_smtp_window_init): Disable the edit 
247         button when nothing is selected.
248         
249         * src/modest-account-mgr-helpers.c:
250         * src/modest-account-mgr-helpers.h: 
251         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct 
252         elsewhere.
253
254 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
255
256         * src/modest-account-mgr-helpers.h:
257         * src/modest-account-mgr-helpers.c:
258         (modest_account_mgr_get_unused_account_name),
259         (modest_account_mgr_get_unused_account_display_name): Added these 
260         utility functions, to avoid code duplication.
261
262         * src/maemo/easysetup/modest-easysetup-wizard.c:
263         (create_page_account_details), (create_account):
264         * src/maemo/modest-connection-specific-smtp-edit-window.c:
265         (on_combo_security_changed),
266         (modest_connection_specific_smtp_edit_window_init),
267         (modest_connection_specific_smtp_edit_window_save_settings):
268         * src/maemo/modest-connection-specific-smtp-edit-window.h:
269         * src/maemo/modest-connection-specific-smtp-window.c:
270         (modest_connection_specific_smtp_window_finalize),
271         (modest_connection_specific_smtp_window_fill_with_connections),
272         (on_button_edit), (modest_connection_specific_smtp_window_init):
273         * src/maemo/modest-connection-specific-smtp-window.h:
274         Implementing saving of connection-specific server accounts.
275         
276         But I need to refactor this so we can save the data for each 
277         possible connection-specific account and only actually create the server accounts 
278         when the easysetup finished, or the OK button is pressed on the account settings 
279         dialog.
280
281 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
282
283         * src/maemo/modest-connection-specific-smtp-edit-window.c:
284         (on_combo_security_changed): 
285         (modest_connection_specific_smtp_edit_window_init):
286         Auto-fill the port number as in the account settings.
287         
288         (modest_connection_specific_smtp_edit_window_set_connection):
289         * src/maemo/modest-connection-specific-smtp-edit-window.h:
290         * src/maemo/modest-connection-specific-smtp-window.c:
291         (fill_with_connections), (on_button_edit),
292         (modest_connection_specific_smtp_window_init): 
293         Turn the edit window into a dialog to simplify the code, and 
294         set a WM hint as in a GtkDialog, because only a popup can be on top of 
295         another window in Maemo, and popups usually have no WM decoration.
296         
297         * src/modest-defs.h:
298         * src/modest-account-mgr-helpers.c:
299         (modest_account_mgr_set_connection_specific_smtp),
300         (modest_account_mgr_remove_connection_specific_smtp),
301         (modest_account_mgr_get_connection_specific_smtp):
302         * src/modest-account-mgr-helpers.h: Some functions to write the 
303         connection-specific SMTP server information. Not yet used.
304
305         
306         * src/widgets/modest-folder-view.c: (text_cell_data):
307         Fix a warning about an uninitialized variable.
308         (on_configuration_key_changed): Put an #ifdef around the use 
309         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
310
311 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
312
313         * src/maemo/modest-account-settings-dialog.h:
314         * src/maemo/modest-account-settings-dialog.c:
315         Added connect_for_modified() utility function to mark the new modified boolean.
316         
317         (create_page_account_details), (create_page_user_details),
318         (create_page_incoming), (create_page_outgoing), (on_response),
319         (modest_account_settings_dialog_init),
320         (modest_account_settings_dialog_set_account_name):
321         Only warn about unsaved changes when there are actually unsaved changes.
322         
323         * src/modest-account-mgr-helpers.c:
324         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information 
325         into the ModestServerAccountData struct. I do not use it yet, but someone might expect 
326         to get the data from there in future.
327
328 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
329
330         * src/modest-defs.h:
331
332         * src/modest-account-mgr-helpers.h:
333         * src/modest-account-mgr-helpers.c:
334         Store the security account setting in a single conf key instead of using 
335         the options list, so that the list is left for just the to-be-removed camel hack, 
336         and because gconf_client_set_list() is failing for some reason.
337
338         * src/modest-account-mgr.c:
339         (modest_account_mgr_add_server_account):
340         * src/maemo/modest-account-settings-dialog.c:
341         (modest_account_settings_dialog_set_account_name),
342         (save_configuration): Use the renamed functions.
343
344
345 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
346
347         * src/widgets/Makefile.am:
348         * src/widgets/modest-limit-retrieve-combo-box.c:
349         * src/widgets/modest-limit-retrieve-combo-box.h:
350         * src/widgets/modest-retrieve-combo-box.c:
351         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in 
352         the account settings dialog.
353         
354         * src/modest-defs.h:
355         * src/modest-account-mgr-helpers.h:
356         * src/modest-account-mgr-helpers.c:
357         (modest_server_account_get_option_secure_auth),
358         (modest_server_account_set_option_secure_auth):
359         * src/modest-account-mgr.c:
360         (modest_account_mgr_add_server_account):
361         Use the existing AUTH_MECH conf key for the secure-auth setting, 
362         instead of putting it in the list options, because this was actually used already.
363         
364         * src/maemo/modest-account-settings-dialog.c:
365         (create_page_account_details),
366         (modest_account_settings_dialog_set_account_name),
367         (save_configuration):
368         * src/maemo/modest-account-settings-dialog.h:
369         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
370         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
371
372 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
373
374         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
375         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
376         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
377
378         * src/modest-defs.h:
379         * src/maemo/modest-account-settings-dialog.c:
380         (create_page_incoming), (on_combo_outgoing_security_changed),
381         (on_combo_incoming_security_changed), (create_page_outgoing),
382         (modest_account_settings_dialog_set_account_name),
383         (save_configuration): Load/Save the port number, and change it when the 
384         security combo changes, to suitable defaults.
385
386 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
387
388         * src/modest-account-mgr.c:
389         (modest_account_mgr_add_server_account): Set the security and secure-auth 
390         options, and add a comment saying that the other camel-specific options should be 
391         removed in future.
392
393 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
394
395         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something, 
396         found by valgrind.
397         * src/modest-tny-account-store.c: (account_list_free),
398         (on_account_changed): Add a TODO comment about a valgrind error, caused by using 
399         cursor->data after unreffing it. But there is some strange stuff there so it might not be 
400         easy to fix.
401
402 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
403
404         * src/modest-protocol-info.c:
405         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it 
406         is required by our UI spec. Maybe something in our implementation will use this eventually.
407         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c: 
408         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value 
409         instead of the previous 0 placeholder.
410         
411         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and 
412         secure-auth settings.
413         * src/modest-account-mgr-helpers.h:
414         * src/modest-account-mgr-helpers.c:
415         (modest_server_account_data_get_option_secure_auth),
416         (modest_server_account_set_option_secure_auth),
417         (modest_server_account_data_get_option_security),
418         (modest_server_account_set_option_security): Added this API for getting and setting the security 
419         and secure-auth settings.
420         
421         * src/maemo/modest-account-settings-dialog.h:
422         * src/maemo/modest-account-settings-dialog.c:
423         (modest_account_settings_dialog_finalize), (check_data),
424         (on_response): Store the original title as well as the name, to avoid unnececessary warnings 
425         about changing titles.
426         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
427         (save_configuration): Save the security and secure-auth settings.
428
429         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this 
430         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
431
432 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
433
434         * src/modest-defs.h: 
435         * src/modest-account-mgr.c:
436         (modest_account_mgr_add_server_account):
437         Added and used defines for the options key and value pair strings, 
438         that are used so far, though they do not seem to correspond to anything in our 
439         UI specs or ModestProtocol enum.
440         
441         * src/modest-account-mgr-helpers.h:
442         * src/modest-account-mgr-helpers.c:
443         (compare_option_strings_for_name),
444         (modest_server_account_data_get_option_value),
445         (modest_server_account_data_get_option_bool),
446         (modest_account_mgr_get_server_account_option):
447         Added helper functions for parsing the options GSList.
448
449 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
450
451         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial 
452         display name is based on the supplied account name.
453         * src/modest-account-mgr.c:
454         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(), 
455         with an inefficient, but good-enough, implementation.
456         
457         * src/maemo/easysetup/modest-easysetup-wizard.c:
458         (create_page_account_details), (on_before_next), (create_account): 
459         Check for existing display names rather than (non-user-visible) account names, and just 
460         create and set a unique account name at the end.
461         
462         * src/maemo/modest-account-settings-dialog.c:
463         (modest_account_settings_dialog_init),
464         (modest_account_settings_dialog_set_account_name),
465         (create_page_incoming): Show the display name, instead of the account name.
466         (on_response): Do some (not all) extra checks, as in the UI spec.
467         (save_configuration): Save the display name if it was changed.
468
469 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
470
471         * po/en_GB.po: Added needed logical ID and translation.
472         * src/widgets/modest-account-view.c: (on_account_default_toggled),
473         (init_view): Made the is-default column clicking work.
474
475 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
476
477         * configure.ac:
478         * src/maemo/easysetup/Makefile.am:
479         * src/maemo/easysetup/modest-easysetup-wizard.c:
480         (modest_easysetup_wizard_dialog_init):
481         * src/maemo/easysetup/provider-data-test.keyfile:
482         * src/maemo/easysetup/provider-data.keyfile: 
483         Moved the provider data file to the new modest-providers-data package and used it from there.
484
485 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
486
487         * src/modest-local-folder-info.c:
488         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string. 
489         N_() was already used on the static strings, but this just marks it for translation without 
490         using the translation.
491
492 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
493
494         * src/maemo/modest-account-settings-dialog.c:
495         (create_page_incoming),
496         (modest_account_settings_dialog_set_account_name): 
497         Added comments about the need for new API in ModestAccountMgr to handle the authentication 
498         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
499         I will do this if nobody else gets there first.
500
501 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
502
503         * src/maemo/modest-account-settings-dialog.c: (save_configuration): 
504         Saved much of the incoming and outgoing data too, though I cannot yet see how to 
505         save the security stuff.
506
507 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
508
509         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): 
510         Set the email address and user fullname, which I now see must be 
511         done separately.
512         
513         * src/maemo/modest-account-settings-dialog.h:
514         * src/maemo/modest-account-settings-dialog.c:
515          (on_response),
516         (modest_account_settings_dialog_set_account_name): Show the email address, fullname, 
517         leave-on-server and authentication.
518         (save_configuration): Save most of the non-server-account specific stuff, but I don't see 
519         how to do the rest.
520
521 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
522
523
524         * src/maemo/modest-account-settings-dialog.c:
525         * src/maemo/modest-account-settings-dialog.h:
526         Most (but not all) of the widgets are now present as specified by the UI spec.
527         No changes are yet saved, and some details are not properly shown yet.
528         
529         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
530
531 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
532
533         * src/maemo/Makefile.am:
534         * src/maemo/modest-account-settings-dialog.c:
535         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit 
536         an existing account. Doesn't do much yet.
537         
538         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked): 
539         Open the accounts settings dialog when Edit is clicked.
540
541 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
542
543         * src/maemo/easysetup/Makefile.am:
544         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
545         (load_from_file): 
546         * src/maemo/easysetup/modest-easysetup-wizard.c:
547         (modest_easysetup_wizard_dialog_init):
548         Try to get the source directory from the build system,
549         instead of hard-coding "./" into the source code, when opening our local 
550         copies of the configuration files.
551         But this still fails when opening the wizard from the Accounts window, 
552         maybe because the working directory seems to change at runtime.
553         So the wizard will fail the second time unless you copy the files into their 
554         proper locations - see the stdout warnings for the paths.
555         
556         (create_page_account_details),(on_before_next): 
557         Check for existing non-server accounts instead of server accounts, 
558         so the default account name is useful again, and to prevent trying to 
559         recreate accounts.
560         
561         * src/maemo/modest-account-view-window.c: (on_new_button_clicked): 
562         Show the wizard when New is clicked.
563         
564         * src/widgets/modest-account-view.c: (on_account_default_toggled),
565         (init_view): Show the column headers, and show the columns that are 
566         specified in the UI specs. However, something in Maemo's GTK+ prevents 
567         us from handling the GtkCellRendererToggle::toggled signal, so we cannot 
568         change the default account. This is despite unsetting the special properties.
569
570 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
571
572         * docs/reference/modest-design.sgml: Corrected spelling mistake.
573         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): 
574         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
575         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation 
576         to make that clearer.
577         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
578
579 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
580
581         * src/maemo/modest-account-view-window.c:
582         (modest_account_view_window_init),
583         (modest_account_view_window_new):
584         Use the same buttons as specified in the 
585         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to 
586         the existing widgets, which never had a chance of working.
587         Put the ModestAccountView treeview in a scrolled window.
588         Do not repeat the initialization in both _init() and _new().
589         
590         * src/widgets/modest-account-view.c: (update_account_view):
591         Add a warning about modest_account_mgr_account_names() returning NULL, which is why 
592         this widget and window shows no accounts.
593         
594         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
595         
596 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
597
598         * src/maemo/easysetup/modest-easysetup-wizard.c:
599         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
600         (create_account): Do a sanity check, showing that modest_account_mgr_account_names() 
601         returns NULL after modest_account_mgr_add_server_account() returned TRUE, 
602         which seems wrong.
603         
604         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
605         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no 
606         accounts exist yet, as in the UI spec.
607         
608         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
609
610 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
611
612         * src/maemo/Makefile.am:
613         * src/maemo/modest-connection-specific-smtp-edit-window.c:
614         * src/maemo/modest-connection-specific-smtp-edit-window.h: 
615         New window for editing connection-specific smtp details.
616         Not fully implemented.
617
618         * src/maemo/modest-connection-specific-smtp-window.c:
619         (modest_connection_specific_smtp_window_finalize) :
620         unref the tree model.
621         (on_button_edit): Show the edit window.
622
623 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
624
625         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol 
626         error for me.
627         
628         * src/maemo/Makefile.am:
629         * src/maemo/modest-connection-specific-smtp-window.c:
630         * src/maemo/modest-connection-specific-smtp-window.h:
631         New window for showing the list of connections, for connection-specific 
632         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
633         * src/maemo/easysetup/modest-easysetup-wizard.c:
634         (create_page_custom_outgoing): Show the new window when the button is clicked.
635
636 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
637
638         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
639         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
640         * src/maemo/modest-msg-edit-window.c:
641         (modest_msg_edit_window_insert_image):
642         * src/modest-conf.c: (modest_conf_key_escape):
643         * src/modest-mail-operation.c:
644         (modest_mail_operation_send_new_mail):
645         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
646         (modest_ui_actions_on_new_account):
647         * src/widgets/modest-attachment-view.c: (update_filename_request):
648         * src/widgets/modest-mail-header-view.c: 
649         Corrected warnings that were breaking the build, by commenting out unused variables, 
650         and a function, and by including a header.
651
652 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
653
654         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h, 
655         so we can #ifdef around platform-specific code when necessary.
656         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO 
657         to allow this to build for the GNOME platform too.
658
659 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
660
661         * src/maemo/easysetup/modest-easysetup-wizard.c:
662         Added util_increment_name() and used it in create_page_account_details() 
663         to make sure that the default account name is always a new name.
664         
665         (modest_easysetup_wizard_dialog_init), 
666         (set_default_custom_servernames): Some minor memory management fixes.
667
668 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
669
670         * Makefile.am:
671         * configure.ac:
672         * src/modest-runtime.c: (init_i18n): Restored the translation 
673         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR 
674         are defined in config.h, and the translations are installed.
675         
676         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE 
677         is defined for translation.
678
679 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
680
681         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
682         (load_from_file):
683         * src/maemo/easysetup/modest-easysetup-wizard.c:
684         (modest_easysetup_wizard_dialog_init):
685         * src/maemo/easysetup/modest-presets.c: (modest_presets_new): 
686         Use realistic paths (though they should use $prefix generically) to the 
687         mcc_mapping and provider-data.keyfile files which might work when they 
688         are installed by the future version of the operator-wizard package, 
689         and then fallback to paths in our source code, with an explanatory 
690         warning.
691
692 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
693
694         * configure.ac:
695         * src/Makefile.am:
696         * src/maemo/Makefile.am:
697         * src/maemo/easysetup/: Added files from the previously-exernal 
698         osso-modest-easysetup.
699         * src/maemo/modest-main-window-ui.h:
700         * src/modest-ui-actions.c: 
701         * src/modest-ui-actions.h:
702         Added modest_ui_actions_on_new_account() as a signal handler for the 
703         New Account menu item. It shows the easysetup wizard.
704         * po/en_GB.po: Added additional needed logical IDs and translations.
705         
706 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
707 Apparently ChangeLog is not used for some vague Nokia legal reasons.
708