git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-tny-account-store.c:
   4         (modest_tny_account_store_instance_init), (get_password):
   5         * src/modest-ui-actions.c:
   6         (modest_ui_actions_on_password_requested):
   7         Do not store the password in gconf, because this function is called
   8         for non-remembered passwords. Actually use the cached (in the hash map)
   9         password instead of releasing it.
  10         The password will now not be remembered if it is asked via the protected
  11         password dialog, as per the UI spec.
  12
  13 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  14
  15         * src/modest-defs.h:
  16         * src/modest-account-mgr-helpers.h:
  17         * src/modest-account-mgr-helpers.c:
  18         Added modest_server_account_get_username_has_succeeded(),
  19         modest_server_account_set_username_has_succeeded().
  20         (modest_server_account_set_username),
  21         Reset the has-succeeded flag if the username changes.
  22
  23         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
  24         * src/maemo/modest-connection-specific-smtp-window.c:
  25         (modest_connection_specific_smtp_window_save_server_accounts):
  26         Use modest_server_account_set_username() instead of using
  27         modest_conf_set_string() directly, so that the has-succeeded flag is always
  28         reset.
  29
  30         * src/modest-ui-actions.c:
  31         (modest_ui_actions_on_password_requested): Dim the username entry if
  32         the username has ever worked, as per the UI spec.
  33
  34 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  35
  36         * src/modest-tny-account-store.c: (get_password):
  37         * src/modest-ui-actions.c:
  38         (modest_ui_actions_on_password_requested):
  39         Allow the username to be changed too, though there is more work to
  40         be done on exactly how this behaves.
  41
  42 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  43
  44         * src/modest-account-mgr-helpers.h:
  45         * src/modest-account-mgr-helpers.c:
  46         Added modest_account_mgr_get_display_name(),
  47         modest_server_account_get_username(),
  48         modest_server_account_set_username(),
  49         modest_server_account_set_password(),
  50         modest_server_account_get_hostname() functions so we do not need to
  51         use the conf API directly.
  52
  53         * src/maemo/modest-main-window.c: (connect_signals):
  54         Actually connect ot the ModestAccountStore::request-password signal,
  55         so that we show the dialog when the password is requested by Tinymail,
  56         for isntance if it is empty.
  57
  58         * src/modest-marshal.list:
  59         * src/modest-tny-account-store.c:
  60         (modest_tny_account_store_class_init), (get_password),
  61         (modest_tny_account_store_alert):
  62         * src/modest-tny-account-store.h:
  63         * src/modest-ui-actions.h:
  64         * src/modest-ui-actions.c:
  65         (modest_ui_actions_on_password_requested):
  66         Change the signal parameters, so it is obvious that we are providing
  67         the non human-readable server name, and receiving both the username
  68         and password, though changing of the username is not yet implemented.
  69         Change the dialog UI to match the Maemo UI specifications, with #idfefing
  70         for the GNOME version.
  71
  72         This should fix the projects.maemo.org bug NB#56209, though it does not
  73         work on Bora, because the gconf_client_get() for the password fails
  74         immediately after we save it with gconf_client_set().
  75
  76 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  77
  78         * configure.ac:
  79         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
  80         caused an undefined symbol error:
  81         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
  82
  83 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  84
  85         * src/modest-tny-account-store.c:
  86         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
  87         using a GError instead of a string message, so we can translate it in
  88         Modest.
  89
  90 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  91
  92         * src/maemo/modest-address-book.c:
  93         (modest_address_book_check_names):
  94         * src/maemo/modest-msg-view-window.c:
  95         (modest_msg_view_window_clipboard_owner_change):
  96         * src/modest-init.c: (modest_init_init_ui):
  97         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
  98         (update_folders_cb), (modest_mail_operation_update_account):
  99         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 100         (modest_ui_actions_on_msg_attachment_clicked),
 101         (modest_ui_actions_on_msg_recpt_activated):
 102         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 103         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 104         (modest_msg_view_search_next):
 105         * src/widgets/modest-recpt-editor.c:
 106         (modest_recpt_editor_on_button_release_event),
 107         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 108         g_message(). At this point we should only be seeing interesting errors on
 109         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 110
 111 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 112
 113         (modest_wizard_dialog_force_title_update):
 114         * src/maemo/easysetup/modest-wizard-dialog.h:
 115         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 116         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 117         can update the title when appropriate. Otherwise the title is wrong if the
 118         pages are added after adding the notebook to the dialog.
 119         This must be a problem in HildonWizardDialog too.
 120         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 121
 122         * src/maemo/easysetup/modest-easysetup-wizard.c:
 123         (create_subsequent_customsetup_pages),
 124         (create_subsequent_easysetup_pages):
 125         Call modest_wizard_dialog_force_title_update() so that the title is
 126         correct even with GTK+ < 2.10.
 127         This fixes projects.maemo.org bug NB#56145 .
 128
 129 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 130
 131         * src/maemo/modest-platform.c:
 132         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 133         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 134         from being shown.
 135
 136 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 137
 138         * src/widgets/modest-window.h:
 139         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 140         and modest_window_save_state(), which invokes it.
 141
 142         * src/widgets/modest-window-mgr.h:
 143         * src/widgets/modest-window-mgr.c:
 144         Added modest_window_mgr_save_state_for_all_windows(), which calls
 145         the save_state vfunc on all registered windows, if implemented.
 146
 147         * src/gnome/modest-msg-edit-window.c:
 148         * src/gnome/modest-msg-view-window.c:
 149         * src/maemo/modest-msg-edit-window.c:
 150         * src/maemo/modest-msg-view-window.c:
 151         * src/maemo/modest-main-window.c:
 152         Specify the existing save_settings functions as implementations of
 153         ModestWindow::save_state_func().
 154
 155         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 156         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 157         enabling hibernation, for instance.
 158
 159         We may need to do the same thing for restoring settings.
 160
 161
 162 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 163
 164         * src/widgets/modest-window-mgr.c:
 165         * src/widgets/modest-window-mgr.h:
 166         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 167         modest_window_mgr_get_hibernation_is_prevented().
 168
 169         * src/maemo/modest-main-window.c:
 170         (on_hildon_program_is_topmost_notify): Prevent hibernation
 171         (possible when the application goes to the background in the WM),
 172         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 173
 174         * src/maemo/easysetup/modest-easysetup-wizard.c:
 175         (modest_easysetup_wizard_dialog_init):
 176         * src/maemo/modest-account-settings-dialog.c:
 177         (modest_account_settings_dialog_init):
 178         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 179         (modest_connection_specific_smtp_edit_window_init):
 180         * src/maemo/modest-connection-specific-smtp-window.c:
 181         (modest_connection_specific_smtp_window_init):
 182         * src/maemo/modest-signature-editor-dialog.c:
 183         (modest_signature_editor_dialog_init):
 184         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 185         prevent hibernation while any of these account settings dialogs are open.
 186
 187 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 188
 189         * src/maemo/Makefile.am:
 190         * src/maemo/modest-osso-state-saving.c:
 191         * src/maemo/modest-osso-state-saving.h: Added
 192         modest_osso_load_state() and modest_osso_save_state() though they do
 193         nothing now. They should iterate through all the open windows and load/save
 194         their state.
 195         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 196         save state when closing.
 197
 198         * src/maemo/modest-main-window.c:
 199         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 200         Add a notification handler for the HildonProgram::is-topmost property,
 201         so we can allow hibernation when the application goes into the background.
 202         But we still need to detect when the accounts setup windows are open so
 203         we can stop hibernation when they are open.
 204         To do this, I also added the main window the HildonProgram. This might have
 205         other side-effects/benefits, and should maybe be done for other windows.
 206
 207         * src/maemo/modest-osso-autosave-callbacks.h:
 208         * src/maemo/modest-osso-autosave-callbacks.c:
 209         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 210         though it does not do anything yet, and we might never need this to do
 211         anything. For instance, we already save drafts.
 212
 213         * src/maemo/modest-platform.c: (modest_platform_init):
 214         Specify the libosso auto-save callback.
 215
 216 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 217
 218         * src/maemo/modest-platform.c:
 219         (modest_platform_set_update_interval):
 220         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 221         aparently stays valid between application instances, so we can use this
 222         to remove and reset it later. According to a maemo-developers email from
 223         David Weinehall.
 224
 225 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 226
 227         * configure.ac: Depend on libalarm for Maemo.
 228
 229         * src/dbus_api/modest-dbus-api.h:
 230         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 231         (on_send_receive), (modest_dbus_req_handler):
 232         Handle a SEND_RECEIVE D-Bus method.
 233
 234         * libmodest-dbus-client/libmodest-dbus-client.c:
 235         (libmodest_dbus_client_send_and_receive):
 236         * libmodest-dbus-client/libmodest-dbus-client.h:
 237         Add C convenience functions for calling the new D-Bus method.
 238
 239         * src/modest-platform.h:
 240         * src/gnome/modest-platform.c:
 241         * src/maemo/modest-platform.c:
 242         Added modest_platform_set_update_interval(), which uses the
 243         alarmd API on Maemo.
 244         (modest_platform_init),
 245         Call modest_platform_set_update_interval(), using a hard-coded
 246         interval for now (until the global settings dialog is implemented),
 247         though I am not sure that this makes sense yet.
 248
 249 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 250
 251         * src/dbus_api/modest-dbus-callbacks.c:
 252         (modest_osso_cb_hw_state_handler):
 253         * src/dbus_api/modest-dbus-callbacks.h:
 254         * src/maemo/modest-platform.c: (modest_platform_init):
 255         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 256         in case this has some effect on the ability for Maemo to ping the
 257         application.
 258
 259 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 260
 261         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 262         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 263         warning. It is probably a logic error, but I need to fix the build.
 264
 265 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 266
 267         * src/modest-account-mgr.h:
 268         * src/modest-account-mgr.c:
 269         (modest_account_mgr_account_names): Add a gboolean enabled_only
 270         parameter, so we can get lists of onlt the enabled accounts.
 271
 272         (modest_account_mgr_add_account),,
 273         (modest_account_mgr_account_with_display_name_exists):
 274         * src/maemo/modest-msg-edit-window.c: (get_transports):
 275         * src/modest-account-mgr-helpers.c:
 276         (modest_account_mgr_set_first_account_as_default):
 277         * src/modest-init.c: (init_default_account_maybe):
 278         * src/modest-tny-account-store.c: (get_accounts):
 279         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 280         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 281         * tests/check_account-mgr.c: (START_TEST):
 282         Provide the extra parameter, as appropriate.
 283
 284         * src/widgets/modest-account-view.c: (update_account_view):
 285         Do not show disabled accounts (meaning that there is no way to
 286         enable/disable accounts in the UI (the feature is not in our UI
 287         specification), so we can use this internally only to mark unfinished
 288         or temporary account data.
 289
 290         * src/maemo/easysetup/modest-easysetup-wizard.c:
 291         (create_account): Add boolean enable parameter, so we can specify FALSE
 292         to create the temporary account.
 293         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 294         (on_before_next): When finishing, when there is a temporary account, just
 295         set it as enabled.
 296         Also, use a timeout to delay the showing of the dialog until gconf is likely
 297         to return correct information, due to a maemo gconf bug that is fixed in
 298         osso 1.1, but not yet in Bora.
 299         However, the dialog stays on screen after it is destroyed.
 300
 301         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 302         for invalid data when cancelling. Use a hildon note instead of a dialog
 303         to complain about invalid data. Do not show the account-saved note if the
 304         account is disabled (a temporary account that will not really be saved for use
 305         until later.)
 306
 307 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 308
 309         * src/modest-account-mgr-helpers.h:
 310         * src/modest-account-mgr-helpers.c:
 311         Added modest_account_mgr_unset_default_account(),
 312         Added modest_account_mgr_set_first_account_as_default().
 313
 314         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 315         If it was the default account, unset the default account name.
 316
 317         * src/maemo/modest-account-view-window.c:
 318         (on_delete_button_clicked): If it was the default account,
 319         set the first remaining account as the default instead.
 320
 321         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 322         a NULL account or a NULL default account, to prevent a crash. This should
 323         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 324
 325
 326 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 327
 328         * src/widgets/modest-recpt-editor.c:
 329         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 330         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 331         TODO comment for this. This fixes the build.
 332
 333         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 334         be the best place for it. This will in future update all auto-update accounts,
 335         rather than just the current/default account, when that gconf key exists.
 336         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 337         if there are no accounts, before calling do_send_receive().
 338         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 339
 340         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 341         * src/maemo/modest-main-window-ui.h:
 342         * src/maemo/modest-main-window.c: (on_connection_changed),
 343         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 344         directly, becaue the signal handler does more.
 345
 346 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 347
 348         * src/modest-account-mgr-helpers.c:
 349         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 350         for the case that the account does not exist.
 351
 352         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 353         (equivalent to the modest account name) rather than the tinymail account name
 354         (equivalent to the modest account title - human readable) to get the account data.
 355         Check for null account data to prevent the crash, and add a TODO comment saying that
 356         this needs fixing because it is using the server account name instead of the account name.
 357
 358 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 359
 360         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 361         * src/maemo/modest-account-settings-dialog.c: (show_error),
 362         (show_ok):
 363         Use hildon_note_new_information() for informative and error messages,
 364         which seems to be expected for Maemo applications (no documentation that I know of
 365         says this). I am surprised that there is no distinction between info and error
 366         dialogs.
 367
 368 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 369
 370         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 371         it is easy to find where this is used.
 372
 373         * src/maemo/easysetup/modest-easysetup-wizard.c:
 374         (create_page_welcome), (create_page_account_details),
 375         (create_page_user_details), (create_page_complete_easysetup),
 376         (create_page_custom_incoming), (create_page_custom_outgoing),
 377         (create_page_complete_custom):
 378         * src/maemo/modest-account-settings-dialog.c:
 379         (create_page_account_details), (create_page_user_details),
 380         (create_page_incoming), (create_page_outgoing):
 381         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 382         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 383         (modest_connection_specific_smtp_edit_window_init):
 384         * src/maemo/modest-connection-specific-smtp-window.c:
 385         (modest_connection_specific_smtp_window_init):
 386         * src/maemo/modest-signature-editor-dialog.c:
 387         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 388         and scrolling policy as per the Email Application Layout Guide, if I have
 389         understood it.
 390
 391 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 392
 393         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 394         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 395         which were empty, because these vfuncs have been removed from TnyAccountStore.
 396         This fixes the build.
 397
 398 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 399
 400         * src/maemo/modest-main-window.c:
 401         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 402         showing/hiding it. Added TODO because it probably should not be NULL.
 403         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 404         because unnecessary g_warnings() make degugging difficult.
 405
 406 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 407
 408         * src/maemo/modest-msg-edit-window.c:
 409         (modest_msg_edit_window_select_color),
 410         (modest_msg_edit_window_select_background_color): 2 const corrections and
 411         moving 2 #endifs before closing brackets, to fix the build.
 412
 413 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 414
 415         * src/maemo/easysetup/modest-easysetup-wizard.h:
 416         * src/maemo/easysetup/modest-easysetup-wizard.c:
 417         (modest_easysetup_wizard_dialog_finalize),
 418         (on_button_edit_advanced_settings), (create_page_complete_custom),
 419         (on_response), (create_account):
 420         Implement the Advanced Settings edit button, by saving the account information,
 421         for the Advanded Settings dialog to use directly from gconf, and removing it
 422         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 423         Bug #5533 in the projects.maemo.org bugzilla.
 424
 425 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 426
 427         * src/maemo/modest-msg-view-window.c:
 428         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 429         when opening a message window.
 430
 431 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 432
 433         * src/maemo/easysetup/modest-easysetup-wizard.c:
 434         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 435         match the UI spec.
 436
 437         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 438         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 439         gconf settings. I probably added more checks than necessary, but that is safer.
 440
 441         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 442         variable to fix the build, but this seems to be used when it is still NULL.
 443
 444 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 445
 446         * src/modest-platform.h:
 447         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 448         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 449         * src/modest-main.c: Implement this function so we can avoid using
 450         maemo-specific API from cross-platform code.
 451         (main):
 452         * src/modest-tny-account-store.c:
 453         (get_smtp_specific_transport_account_for_open_connection):
 454         * src/modest-ui-actions.c: (check_for_connection),
 455         (modest_ui_actions_on_item_not_found):
 456         Use modest_platform_connect_and_wait() and put #idefs around other
 457         maemo-specific code, because only maemo currently has a way to
 458         identify connection names.
 459
 460 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 461
 462         * src/modest-tny-account-store.h:
 463         * src/modest-tny-account-store.c:
 464         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 465         the connection-specific SMTP server settings in the configuration.
 466
 467         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 468         (on_idle_mail_to):
 469         * src/maemo/modest-main-window.c: (on_connection_changed),
 470         (connect_signals):
 471         * src/modest-main.c: (main), (start_ui), (send_mail):
 472         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 473         that is what is intended.
 474
 475         * src/modest-ui-actions.c: (action_send), (action_receive),
 476         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 477         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 478         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 479         SMTP server is used when it is specified.
 480
 481         (modest_ui_actions_on_send_receive):
 482         Check that a connection is open before proceeding.
 483         Receive and then send, instead of vice-versa, as per the specification.
 484
 485 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 486
 487         * src/modest-mail-operation.c:
 488         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 489         though I guess it should be something other than NULL.
 490
 491 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 492
 493         * src/maemo/easysetup/modest-easysetup-wizard.c:
 494         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 495         combo twice, to avoid an g_warning and to make it visible again.
 496         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 497         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 498         (already intended) dereference when detaching, because we then recreate the menu.
 499         But I am not sure why the warning was happening, and it is possible that this is a memory
 500         leak.
 501
 502 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 503
 504         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 505         and uri_parse_mailto() utility functions.
 506         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 507         the mailto URI.
 508         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 509
 510 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 511
 512         * src/dbus_api/modest-dbus-api.h:
 513         * src/dbus_api/modest-dbus-callbacks.c:
 514         Use an idle callback to execute the modest code in the application's own thread.
 515         Remove the helloworld example method.
 516         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 517         parsed, and the open-message method is not implemented because this is not yet implemented in
 518         modest itself.
 519         * libmodest-dbus-client/libmodest-dbus-client.c:
 520         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 521         (libmodest_dbus_client_open_message):
 522         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 523
 524         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 525         body without crashing.
 526
 527         * tests/dbus_api/Makefile.am:
 528         * tests/dbus_api/test_mail_to.c:
 529         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 530
 531 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 532
 533         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 534         Added file to fix the build. Sorry.
 535
 536         * src/dbus_api/Makefile.am:
 537         * src/dbus_api/modest-dbus-api.h:
 538         * src/dbus_api/modest-dbus-callbacks.h:
 539         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 540         (modest_dbus_req_handler):
 541         Put constants in a separate header so it can be reused by the
 542         client library, without duplication
 543
 544         * libmodest-dbus-client/Makefile.am:
 545         * libmodest-dbus-client/libmodest-dbus-client.c:
 546         (libmodest_dbus_client_call_helloworld),
 547         (libmodfest_dbus_client_send_mail),
 548         (libmodfest_dbus_client_mailto),
 549         (libmodfest_dbus_client_open_message):
 550         * libmodest-dbus-client/libmodest-dbus-client.h:
 551         (Partly) Implement a send_mail D-Bus method.
 552
 553         * tests/dbus_api/Makefile.am:
 554         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 555         the send_email D-Bus method.
 556
 557 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 558
 559         * Makefile.am:
 560         * configure.ac:
 561         * libmodest-dbus-client/Makefile.am:
 562         * libmodest-dbus-client/libmodest-dbus-client.c:
 563         * libmodest-dbus-client/libmodest-dbus-client.h:
 564         * tests/dbus_api/Makefile.am:
 565         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 566         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 567
 568 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 569
 570         * src/maemo/easysetup/modest-easysetup-wizard.c:
 571         (create_page_account_details):
 572         * src/maemo/modest-account-settings-dialog.c:
 573         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 574         widgets, because this might not be the default in future versions of the Maemo GTK+.
 575         However, I can not not get capitalization to work even in a simple test case.
 576
 577 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 578
 579         * src/maemo/easysetup/modest-easysetup-wizard.c:
 580         (create_page_custom_incoming), (create_page_custom_outgoing):
 581         * src/maemo/modest-account-settings-dialog.c:
 582         (create_page_account_details), (create_page_incoming),
 583         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 584         instead of using gtk_check_button_with_label(), so they are aligned like the other
 585         widgets, as per the UI spec.
 586
 587 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 588
 589         * src/maemo/easysetup/modest-easysetup-wizard.c:
 590         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 591         * src/widgets/modest-validating-entry.c:
 592         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 593         Modest prefix instead of an EasySetup prefix.
 594
 595 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 596
 597         * src/widgets/modest-validating-entry.h:
 598         * src/widgets/modest-validating-entry.c: (on_insert_text),
 599         Added easysetup_validating_entry_set_max_func(), used to set a callback
 600         to call when the max number of characters is reached. GtkEntry has a max-length
 601         already but is silent about it.
 602
 603         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 604         (create_page_account_details), (create_page_user_details),
 605         (create_account):
 606         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 607         (create_page_account_details), (create_page_user_details),
 608         (create_page_outgoing):
 609         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 610         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 611         the UI spec, when the user tries to enter more than the max number of characters.
 612
 613 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 614
 615         * src/maemo/easysetup/modest-easysetup-wizard.c:
 616         (create_page_user_details), (create_page_custom_incoming),
 617         (create_page_custom_outgoing):
 618         * src/maemo/modest-account-settings-dialog.c:
 619         (create_page_user_details), (create_page_incoming),
 620         (create_page_outgoing):
 621         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 622         (modest_connection_specific_smtp_edit_window_init):
 623         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 624         not appropriate. Bad Maemo-specific defaults!.
 625
 626 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 627
 628         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 629         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 630         (modest_signature_editor_dialog_set_settings):
 631         Disable the label and textview when the checkbox is disabled, and use the
 632         specified (UI spec) default signature text.
 633
 634 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 635
 636         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 637         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 638
 639         * src/modest-defs.h:
 640         * src/modest-account-mgr-helpers.h:
 641         * src/modest-account-mgr-helpers.c:
 642         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 643
 644         * src/maemo/Makefile.am:
 645         * src/maemo/modest-signature-editor-dialog.c:
 646         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 647         as per the UI spec.
 648
 649         * src/maemo/modest-account-settings-dialog.h:
 650         * src/maemo/modest-account-settings-dialog.c:
 651         (modest_account_settings_dialog_finalize), (on_button_signature),
 652         (save_configuration): Use the new dialog when the Edit button is pressed, and
 653         save the changes if necessary, as per the UI spec.
 654
 655 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 656
 657         * src/maemo/Makefile.am:
 658         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 659         based on maemo-develoers email from Dirk.
 660
 661         * src/maemo/easysetup/modest-easysetup-wizard.c:
 662         (create_page_welcome), (create_page_account_details),
 663         (create_page_user_details), (create_page_complete_easysetup),
 664         (create_page_custom_incoming), (create_page_custom_outgoing),
 665         (create_page_complete_custom),
 666         (modest_easysetup_wizard_dialog_init):
 667         * src/maemo/modest-account-settings-dialog.c:
 668         (create_page_account_details), (create_page_user_details),
 669         (create_page_incoming), (create_page_outgoing),
 670         (modest_account_settings_dialog_init):
 671         * src/maemo/modest-connection-specific-smtp-window.c:
 672         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 673
 674 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 675
 676         * src/maemo/easysetup/modest-easysetup-wizard.c:
 677         (create_page_account_details), (create_page_custom_outgoing),
 678         (create_page_complete_custom):
 679         * src/maemo/modest-account-settings-dialog.c:
 680         (create_page_user_details), (create_page_incoming),
 681         (create_page_outgoing):
 682         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 683         (modest_connection_specific_smtp_edit_window_init):
 684         Use the correct (UI spec) port min/max, and use horizontal separators,
 685         as per the UI spec.
 686
 687 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 688
 689         * src/maemo/easysetup/modest-easysetup-wizard.c:
 690         (set_default_custom_servernames):
 691         * src/maemo/modest-account-settings-dialog.c:
 692         (create_page_incoming), (on_combo_outgoing_security_changed),
 693         (on_combo_incoming_security_changed), (create_page_outgoing),
 694         (modest_account_settings_dialog_set_account_name),
 695         (save_configuration):
 696         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 697         (on_combo_security_changed),
 698         (modest_connection_specific_smtp_edit_window_init),
 699         (modest_connection_specific_smtp_edit_window_set_connection),
 700         (modest_connection_specific_smtp_edit_window_get_settings):
 701         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 702         as per the UI spec.
 703
 704 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 705
 706         * po/en_GB.po:
 707         * src/maemo/easysetup/modest-easysetup-wizard.c:
 708         (create_page_custom_outgoing), (create_page_complete_custom):
 709         * src/maemo/modest-account-settings-dialog.c:
 710         (create_page_user_details), (create_page_outgoing):
 711         * src/maemo/modest-account-view-window.c: (button_box_new):
 712         Use changed logical IDs as per the most recent UI spec:
 713         mcen_bd_emailsetup_edit -> mcen_bd_edit
 714         mcen_bd_emailsetup_delete -> mcen_bd_delete
 715         mcen_bd_emailsetup_close -> mcen_bd_close
 716
 717 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 718
 719         * configure.ac:
 720         * src/Makefile.am:
 721         * src/dbus_api/Makefile.am:
 722         * src/dbus_api/modest-dbus-callbacks.c:
 723         * src/dbus_api/modest-dbus-callbacks.h:
 724         * src/maemo/modest-platform.c: (modest_platform_init):
 725         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 726         method.
 727         * tests/Makefile.am:
 728         * tests/dbus_api/Makefile.am:
 729         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 730
 731 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 732
 733         * src/maemo/modest-account-settings-dialog.c:
 734         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 735         Removed unnecessary includes.
 736
 737 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 738
 739         * src/maemo/easysetup/modest-easysetup-wizard.c:
 740         * src/maemo/modest-account-settings-dialog.c:
 741         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 742         * src/widgets/Makefile.am:
 743         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 744         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 745         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 746         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 747         * src/widgets/modest-secureauth-combo-box.c:
 748         * src/widgets/modest-secureauth-combo-box.h:
 749         * src/widgets/modest-serversecurity-combo-box.c:
 750         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 751         made the GObject names more consistent with the rest of the Modest code.
 752
 753 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 754
 755         * src/maemo/easysetup/Makefile.am:
 756         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 757         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 758         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 759         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 760         * src/maemo/easysetup/modest-easysetup-wizard.c:
 761         * src/maemo/easysetup/modest-validating-entry.c:
 762         * src/maemo/easysetup/modest-validating-entry.h:
 763         * src/maemo/modest-account-settings-dialog.c:
 764         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 765         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 766         widgets/ because they are used outside of easysetup too. After checking in,
 767         svn will allow me to rename them too.
 768
 769 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 770
 771         * src/gnome/modest-msg-edit-window.c:
 772         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 773         linker error, to fix the build on the GNOME platform.
 774         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 775         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 776         ifdefed out to avoid a warning.
 777
 778 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 779
 780         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 781         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 782         some alternative for GTK+ 2.6.
 783
 784 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 785
 786         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 787
 788         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 789         specified for EmailAccountsDialog in UI spec.
 790
 791         * src/maemo/easysetup/modest-easysetup-wizard.c:
 792         * src/maemo/easysetup/modest-easysetup-wizard.h:
 793         * src/maemo/modest-account-settings-dialog.c:
 794         * src/maemo/modest-account-settings-dialog.h:
 795         Reuse a member window widget for the connection-specific SMTP server accounts,
 796         so we can tell it to create/save the accounts only if we actually save changes.
 797
 798         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 799         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 800         (modest_connection_specific_smtp_edit_window_get_settings):
 801         Return a struct instance for temporarily remembering the entered data.
 802
 803         * src/maemo/modest-connection-specific-smtp-window.h:
 804         * src/maemo/modest-connection-specific-smtp-window.c:
 805         (modest_connection_specific_smtp_window_finalize),
 806         (modest_connection_specific_smtp_window_fill_with_connections),
 807         (on_button_edit),
 808         (modest_connection_specific_smtp_window_save_server_accounts),
 809         (update_model_server_names): Do not actually save data until asked,
 810         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 811
 812         (on_selection_changed),
 813         (modest_connection_specific_smtp_window_init): Disable the edit
 814         button when nothing is selected.
 815
 816         * src/modest-account-mgr-helpers.c:
 817         * src/modest-account-mgr-helpers.h:
 818         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 819         elsewhere.
 820
 821 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 822
 823         * src/modest-account-mgr-helpers.h:
 824         * src/modest-account-mgr-helpers.c:
 825         (modest_account_mgr_get_unused_account_name),
 826         (modest_account_mgr_get_unused_account_display_name): Added these
 827         utility functions, to avoid code duplication.
 828
 829         * src/maemo/easysetup/modest-easysetup-wizard.c:
 830         (create_page_account_details), (create_account):
 831         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 832         (on_combo_security_changed),
 833         (modest_connection_specific_smtp_edit_window_init),
 834         (modest_connection_specific_smtp_edit_window_save_settings):
 835         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 836         * src/maemo/modest-connection-specific-smtp-window.c:
 837         (modest_connection_specific_smtp_window_finalize),
 838         (modest_connection_specific_smtp_window_fill_with_connections),
 839         (on_button_edit), (modest_connection_specific_smtp_window_init):
 840         * src/maemo/modest-connection-specific-smtp-window.h:
 841         Implementing saving of connection-specific server accounts.
 842
 843         But I need to refactor this so we can save the data for each
 844         possible connection-specific account and only actually create the server accounts
 845         when the easysetup finished, or the OK button is pressed on the account settings
 846         dialog.
 847
 848 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 849
 850         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 851         (on_combo_security_changed):
 852         (modest_connection_specific_smtp_edit_window_init):
 853         Auto-fill the port number as in the account settings.
 854
 855         (modest_connection_specific_smtp_edit_window_set_connection):
 856         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 857         * src/maemo/modest-connection-specific-smtp-window.c:
 858         (fill_with_connections), (on_button_edit),
 859         (modest_connection_specific_smtp_window_init):
 860         Turn the edit window into a dialog to simplify the code, and
 861         set a WM hint as in a GtkDialog, because only a popup can be on top of
 862         another window in Maemo, and popups usually have no WM decoration.
 863
 864         * src/modest-defs.h:
 865         * src/modest-account-mgr-helpers.c:
 866         (modest_account_mgr_set_connection_specific_smtp),
 867         (modest_account_mgr_remove_connection_specific_smtp),
 868         (modest_account_mgr_get_connection_specific_smtp):
 869         * src/modest-account-mgr-helpers.h: Some functions to write the
 870         connection-specific SMTP server information. Not yet used.
 871
 872
 873         * src/widgets/modest-folder-view.c: (text_cell_data):
 874         Fix a warning about an uninitialized variable.
 875         (on_configuration_key_changed): Put an #ifdef around the use
 876         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 877
 878 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 879
 880         * src/maemo/modest-account-settings-dialog.h:
 881         * src/maemo/modest-account-settings-dialog.c:
 882         Added connect_for_modified() utility function to mark the new modified boolean.
 883
 884         (create_page_account_details), (create_page_user_details),
 885         (create_page_incoming), (create_page_outgoing), (on_response),
 886         (modest_account_settings_dialog_init),
 887         (modest_account_settings_dialog_set_account_name):
 888         Only warn about unsaved changes when there are actually unsaved changes.
 889
 890         * src/modest-account-mgr-helpers.c:
 891         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 892         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 893         to get the data from there in future.
 894
 895 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 896
 897         * src/modest-defs.h:
 898
 899         * src/modest-account-mgr-helpers.h:
 900         * src/modest-account-mgr-helpers.c:
 901         Store the security account setting in a single conf key instead of using
 902         the options list, so that the list is left for just the to-be-removed camel hack,
 903         and because gconf_client_set_list() is failing for some reason.
 904
 905         * src/modest-account-mgr.c:
 906         (modest_account_mgr_add_server_account):
 907         * src/maemo/modest-account-settings-dialog.c:
 908         (modest_account_settings_dialog_set_account_name),
 909         (save_configuration): Use the renamed functions.
 910
 911
 912 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 913
 914         * src/widgets/Makefile.am:
 915         * src/widgets/modest-limit-retrieve-combo-box.c:
 916         * src/widgets/modest-limit-retrieve-combo-box.h:
 917         * src/widgets/modest-retrieve-combo-box.c:
 918         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 919         the account settings dialog.
 920
 921         * src/modest-defs.h:
 922         * src/modest-account-mgr-helpers.h:
 923         * src/modest-account-mgr-helpers.c:
 924         (modest_server_account_get_option_secure_auth),
 925         (modest_server_account_set_option_secure_auth):
 926         * src/modest-account-mgr.c:
 927         (modest_account_mgr_add_server_account):
 928         Use the existing AUTH_MECH conf key for the secure-auth setting,
 929         instead of putting it in the list options, because this was actually used already.
 930
 931         * src/maemo/modest-account-settings-dialog.c:
 932         (create_page_account_details),
 933         (modest_account_settings_dialog_set_account_name),
 934         (save_configuration):
 935         * src/maemo/modest-account-settings-dialog.h:
 936         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 937         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 938
 939 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 940
 941         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 942         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 943         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 944
 945         * src/modest-defs.h:
 946         * src/maemo/modest-account-settings-dialog.c:
 947         (create_page_incoming), (on_combo_outgoing_security_changed),
 948         (on_combo_incoming_security_changed), (create_page_outgoing),
 949         (modest_account_settings_dialog_set_account_name),
 950         (save_configuration): Load/Save the port number, and change it when the
 951         security combo changes, to suitable defaults.
 952
 953 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 954
 955         * src/modest-account-mgr.c:
 956         (modest_account_mgr_add_server_account): Set the security and secure-auth
 957         options, and add a comment saying that the other camel-specific options should be
 958         removed in future.
 959
 960 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 961
 962         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 963         found by valgrind.
 964         * src/modest-tny-account-store.c: (account_list_free),
 965         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 966         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 967         easy to fix.
 968
 969 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 970
 971         * src/modest-protocol-info.c:
 972         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 973         is required by our UI spec. Maybe something in our implementation will use this eventually.
 974         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 975         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 976         instead of the previous 0 placeholder.
 977
 978         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 979         secure-auth settings.
 980         * src/modest-account-mgr-helpers.h:
 981         * src/modest-account-mgr-helpers.c:
 982         (modest_server_account_data_get_option_secure_auth),
 983         (modest_server_account_set_option_secure_auth),
 984         (modest_server_account_data_get_option_security),
 985         (modest_server_account_set_option_security): Added this API for getting and setting the security
 986         and secure-auth settings.
 987
 988         * src/maemo/modest-account-settings-dialog.h:
 989         * src/maemo/modest-account-settings-dialog.c:
 990         (modest_account_settings_dialog_finalize), (check_data),
 991         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 992         about changing titles.
 993         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 994         (save_configuration): Save the security and secure-auth settings.
 995
 996         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 997         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 998
 999 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1000
1001         * src/modest-defs.h:
1002         * src/modest-account-mgr.c:
1003         (modest_account_mgr_add_server_account):
1004         Added and used defines for the options key and value pair strings,
1005         that are used so far, though they do not seem to correspond to anything in our
1006         UI specs or ModestProtocol enum.
1007
1008         * src/modest-account-mgr-helpers.h:
1009         * src/modest-account-mgr-helpers.c:
1010         (compare_option_strings_for_name),
1011         (modest_server_account_data_get_option_value),
1012         (modest_server_account_data_get_option_bool),
1013         (modest_account_mgr_get_server_account_option):
1014         Added helper functions for parsing the options GSList.
1015
1016 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1017
1018         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1019         display name is based on the supplied account name.
1020         * src/modest-account-mgr.c:
1021         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1022         with an inefficient, but good-enough, implementation.
1023
1024         * src/maemo/easysetup/modest-easysetup-wizard.c:
1025         (create_page_account_details), (on_before_next), (create_account):
1026         Check for existing display names rather than (non-user-visible) account names, and just
1027         create and set a unique account name at the end.
1028
1029         * src/maemo/modest-account-settings-dialog.c:
1030         (modest_account_settings_dialog_init),
1031         (modest_account_settings_dialog_set_account_name),
1032         (create_page_incoming): Show the display name, instead of the account name.
1033         (on_response): Do some (not all) extra checks, as in the UI spec.
1034         (save_configuration): Save the display name if it was changed.
1035
1036 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1037
1038         * po/en_GB.po: Added needed logical ID and translation.
1039         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1040         (init_view): Made the is-default column clicking work.
1041
1042 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1043
1044         * configure.ac:
1045         * src/maemo/easysetup/Makefile.am:
1046         * src/maemo/easysetup/modest-easysetup-wizard.c:
1047         (modest_easysetup_wizard_dialog_init):
1048         * src/maemo/easysetup/provider-data-test.keyfile:
1049         * src/maemo/easysetup/provider-data.keyfile:
1050         Moved the provider data file to the new modest-providers-data package and used it from there.
1051
1052 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1053
1054         * src/modest-local-folder-info.c:
1055         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1056         N_() was already used on the static strings, but this just marks it for translation without
1057         using the translation.
1058
1059 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1060
1061         * src/maemo/modest-account-settings-dialog.c:
1062         (create_page_incoming),
1063         (modest_account_settings_dialog_set_account_name):
1064         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1065         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1066         I will do this if nobody else gets there first.
1067
1068 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1069
1070         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1071         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1072         save the security stuff.
1073
1074 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1075
1076         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1077         Set the email address and user fullname, which I now see must be
1078         done separately.
1079
1080         * src/maemo/modest-account-settings-dialog.h:
1081         * src/maemo/modest-account-settings-dialog.c:
1082          (on_response),
1083         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1084         leave-on-server and authentication.
1085         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1086         how to do the rest.
1087
1088 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1089
1090
1091         * src/maemo/modest-account-settings-dialog.c:
1092         * src/maemo/modest-account-settings-dialog.h:
1093         Most (but not all) of the widgets are now present as specified by the UI spec.
1094         No changes are yet saved, and some details are not properly shown yet.
1095
1096         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1097
1098 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1099
1100         * src/maemo/Makefile.am:
1101         * src/maemo/modest-account-settings-dialog.c:
1102         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1103         an existing account. Doesn't do much yet.
1104
1105         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1106         Open the accounts settings dialog when Edit is clicked.
1107
1108 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1109
1110         * src/maemo/easysetup/Makefile.am:
1111         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1112         (load_from_file):
1113         * src/maemo/easysetup/modest-easysetup-wizard.c:
1114         (modest_easysetup_wizard_dialog_init):
1115         Try to get the source directory from the build system,
1116         instead of hard-coding "./" into the source code, when opening our local
1117         copies of the configuration files.
1118         But this still fails when opening the wizard from the Accounts window,
1119         maybe because the working directory seems to change at runtime.
1120         So the wizard will fail the second time unless you copy the files into their
1121         proper locations - see the stdout warnings for the paths.
1122
1123         (create_page_account_details),(on_before_next):
1124         Check for existing non-server accounts instead of server accounts,
1125         so the default account name is useful again, and to prevent trying to
1126         recreate accounts.
1127
1128         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1129         Show the wizard when New is clicked.
1130
1131         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1132         (init_view): Show the column headers, and show the columns that are
1133         specified in the UI specs. However, something in Maemo's GTK+ prevents
1134         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1135         change the default account. This is despite unsetting the special properties.
1136
1137 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1138
1139         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1140         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1141         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1142         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1143         to make that clearer.
1144         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1145
1146 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1147
1148         * src/maemo/modest-account-view-window.c:
1149         (modest_account_view_window_init),
1150         (modest_account_view_window_new):
1151         Use the same buttons as specified in the
1152         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1153         the existing widgets, which never had a chance of working.
1154         Put the ModestAccountView treeview in a scrolled window.
1155         Do not repeat the initialization in both _init() and _new().
1156
1157         * src/widgets/modest-account-view.c: (update_account_view):
1158         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1159         this widget and window shows no accounts.
1160
1161         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1162
1163 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1164
1165         * src/maemo/easysetup/modest-easysetup-wizard.c:
1166         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1167         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1168         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1169         which seems wrong.
1170
1171         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1172         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1173         accounts exist yet, as in the UI spec.
1174
1175         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1176
1177 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1178
1179         * src/maemo/Makefile.am:
1180         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1181         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1182         New window for editing connection-specific smtp details.
1183         Not fully implemented.
1184
1185         * src/maemo/modest-connection-specific-smtp-window.c:
1186         (modest_connection_specific_smtp_window_finalize) :
1187         unref the tree model.
1188         (on_button_edit): Show the edit window.
1189
1190 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1191
1192         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1193         error for me.
1194
1195         * src/maemo/Makefile.am:
1196         * src/maemo/modest-connection-specific-smtp-window.c:
1197         * src/maemo/modest-connection-specific-smtp-window.h:
1198         New window for showing the list of connections, for connection-specific
1199         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1200         * src/maemo/easysetup/modest-easysetup-wizard.c:
1201         (create_page_custom_outgoing): Show the new window when the button is clicked.
1202
1203 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1204
1205         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1206         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1207         * src/maemo/modest-msg-edit-window.c:
1208         (modest_msg_edit_window_insert_image):
1209         * src/modest-conf.c: (modest_conf_key_escape):
1210         * src/modest-mail-operation.c:
1211         (modest_mail_operation_send_new_mail):
1212         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1213         (modest_ui_actions_on_new_account):
1214         * src/widgets/modest-attachment-view.c: (update_filename_request):
1215         * src/widgets/modest-mail-header-view.c:
1216         Corrected warnings that were breaking the build, by commenting out unused variables,
1217         and a function, and by including a header.
1218
1219 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1220
1221         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1222         so we can #ifdef around platform-specific code when necessary.
1223         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1224         to allow this to build for the GNOME platform too.
1225
1226 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1227
1228         * src/maemo/easysetup/modest-easysetup-wizard.c:
1229         Added util_increment_name() and used it in create_page_account_details()
1230         to make sure that the default account name is always a new name.
1231
1232         (modest_easysetup_wizard_dialog_init),
1233         (set_default_custom_servernames): Some minor memory management fixes.
1234
1235 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1236
1237         * Makefile.am:
1238         * configure.ac:
1239         * src/modest-runtime.c: (init_i18n): Restored the translation
1240         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1241         are defined in config.h, and the translations are installed.
1242
1243         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1244         is defined for translation.
1245
1246 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1247
1248         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1249         (load_from_file):
1250         * src/maemo/easysetup/modest-easysetup-wizard.c:
1251         (modest_easysetup_wizard_dialog_init):
1252         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1253         Use realistic paths (though they should use $prefix generically) to the
1254         mcc_mapping and provider-data.keyfile files which might work when they
1255         are installed by the future version of the operator-wizard package,
1256         and then fallback to paths in our source code, with an explanatory
1257         warning.
1258
1259 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1260
1261         * configure.ac:
1262         * src/Makefile.am:
1263         * src/maemo/Makefile.am:
1264         * src/maemo/easysetup/: Added files from the previously-exernal
1265         osso-modest-easysetup.
1266         * src/maemo/modest-main-window-ui.h:
1267         * src/modest-ui-actions.c:
1268         * src/modest-ui-actions.h:
1269         Added modest_ui_actions_on_new_account() as a signal handler for the
1270         New Account menu item. It shows the easysetup wizard.
1271         * po/en_GB.po: Added additional needed logical IDs and translations.
1272
1273 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1274 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1275