git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-tny-account-store.c:
   4         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
   5         using a GError instead of a string message, so we can translate it in
   6         Modest.
   7
   8
   9 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  10
  11         * src/maemo/modest-address-book.c:
  12         (modest_address_book_check_names):
  13         * src/maemo/modest-msg-view-window.c:
  14         (modest_msg_view_window_clipboard_owner_change):
  15         * src/modest-init.c: (modest_init_init_ui):
  16         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
  17         (update_folders_cb), (modest_mail_operation_update_account):
  18         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
  19         (modest_ui_actions_on_msg_attachment_clicked),
  20         (modest_ui_actions_on_msg_recpt_activated):
  21         * src/widgets/modest-header-view.c: (drag_data_get_cb):
  22         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
  23         (modest_msg_view_search_next):
  24         * src/widgets/modest-recpt-editor.c:
  25         (modest_recpt_editor_on_button_release_event),
  26         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
  27         g_message(). At this point we should only be seeing interesting errors on
  28         stdout. Debugging messages could be #ifdefed-out if they are still useful.
  29
  30 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  31
  32         (modest_wizard_dialog_force_title_update):
  33         * src/maemo/easysetup/modest-wizard-dialog.h:
  34         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
  35         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
  36         can update the title when appropriate. Otherwise the title is wrong if the
  37         pages are added after adding the notebook to the dialog.
  38         This must be a problem in HildonWizardDialog too.
  39         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
  40
  41         * src/maemo/easysetup/modest-easysetup-wizard.c:
  42         (create_subsequent_customsetup_pages),
  43         (create_subsequent_easysetup_pages):
  44         Call modest_wizard_dialog_force_title_update() so that the title is
  45         correct even with GTK+ < 2.10.
  46         This fixes projects.maemo.org bug NB#56145 .
  47
  48 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  49
  50         * src/maemo/modest-platform.c:
  51         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
  52         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
  53         from being shown.
  54
  55 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  56
  57         * src/widgets/modest-window.h:
  58         * src/widgets/modest-window.c: Added a save_state_func vfunc,
  59         and modest_window_save_state(), which invokes it.
  60
  61         * src/widgets/modest-window-mgr.h:
  62         * src/widgets/modest-window-mgr.c:
  63         Added modest_window_mgr_save_state_for_all_windows(), which calls
  64         the save_state vfunc on all registered windows, if implemented.
  65
  66         * src/gnome/modest-msg-edit-window.c:
  67         * src/gnome/modest-msg-view-window.c:
  68         * src/maemo/modest-msg-edit-window.c:
  69         * src/maemo/modest-msg-view-window.c:
  70         * src/maemo/modest-main-window.c:
  71         Specify the existing save_settings functions as implementations of
  72         ModestWindow::save_state_func().
  73
  74         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
  75         Call modest_window_mgr_save_state_for_all_windows(). This happens before
  76         enabling hibernation, for instance.
  77
  78         We may need to do the same thing for restoring settings.
  79
  80
  81 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  82
  83         * src/widgets/modest-window-mgr.c:
  84         * src/widgets/modest-window-mgr.h:
  85         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
  86         modest_window_mgr_get_hibernation_is_prevented().
  87
  88         * src/maemo/modest-main-window.c:
  89         (on_hildon_program_is_topmost_notify): Prevent hibernation
  90         (possible when the application goes to the background in the WM),
  91         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
  92
  93         * src/maemo/easysetup/modest-easysetup-wizard.c:
  94         (modest_easysetup_wizard_dialog_init):
  95         * src/maemo/modest-account-settings-dialog.c:
  96         (modest_account_settings_dialog_init):
  97         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  98         (modest_connection_specific_smtp_edit_window_init):
  99         * src/maemo/modest-connection-specific-smtp-window.c:
 100         (modest_connection_specific_smtp_window_init):
 101         * src/maemo/modest-signature-editor-dialog.c:
 102         (modest_signature_editor_dialog_init):
 103         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 104         prevent hibernation while any of these account settings dialogs are open.
 105
 106 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 107
 108         * src/maemo/Makefile.am:
 109         * src/maemo/modest-osso-state-saving.c:
 110         * src/maemo/modest-osso-state-saving.h: Added
 111         modest_osso_load_state() and modest_osso_save_state() though they do
 112         nothing now. They should iterate through all the open windows and load/save
 113         their state.
 114         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 115         save state when closing.
 116
 117         * src/maemo/modest-main-window.c:
 118         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 119         Add a notification handler for the HildonProgram::is-topmost property,
 120         so we can allow hibernation when the application goes into the background.
 121         But we still need to detect when the accounts setup windows are open so
 122         we can stop hibernation when they are open.
 123         To do this, I also added the main window the HildonProgram. This might have
 124         other side-effects/benefits, and should maybe be done for other windows.
 125
 126         * src/maemo/modest-osso-autosave-callbacks.h:
 127         * src/maemo/modest-osso-autosave-callbacks.c:
 128         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 129         though it does not do anything yet, and we might never need this to do
 130         anything. For instance, we already save drafts.
 131
 132         * src/maemo/modest-platform.c: (modest_platform_init):
 133         Specify the libosso auto-save callback.
 134
 135 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 136
 137         * src/maemo/modest-platform.c:
 138         (modest_platform_set_update_interval):
 139         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 140         aparently stays valid between application instances, so we can use this
 141         to remove and reset it later. According to a maemo-developers email from
 142         David Weinehall.
 143
 144 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 145
 146         * configure.ac: Depend on libalarm for Maemo.
 147
 148         * src/dbus_api/modest-dbus-api.h:
 149         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 150         (on_send_receive), (modest_dbus_req_handler):
 151         Handle a SEND_RECEIVE D-Bus method.
 152
 153         * libmodest-dbus-client/libmodest-dbus-client.c:
 154         (libmodest_dbus_client_send_and_receive):
 155         * libmodest-dbus-client/libmodest-dbus-client.h:
 156         Add C convenience functions for calling the new D-Bus method.
 157
 158         * src/modest-platform.h:
 159         * src/gnome/modest-platform.c:
 160         * src/maemo/modest-platform.c:
 161         Added modest_platform_set_update_interval(), which uses the
 162         alarmd API on Maemo.
 163         (modest_platform_init),
 164         Call modest_platform_set_update_interval(), using a hard-coded
 165         interval for now (until the global settings dialog is implemented),
 166         though I am not sure that this makes sense yet.
 167
 168 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 169
 170         * src/dbus_api/modest-dbus-callbacks.c:
 171         (modest_osso_cb_hw_state_handler):
 172         * src/dbus_api/modest-dbus-callbacks.h:
 173         * src/maemo/modest-platform.c: (modest_platform_init):
 174         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 175         in case this has some effect on the ability for Maemo to ping the
 176         application.
 177
 178 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 179
 180         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 181         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 182         warning. It is probably a logic error, but I need to fix the build.
 183
 184 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 185
 186         * src/modest-account-mgr.h:
 187         * src/modest-account-mgr.c:
 188         (modest_account_mgr_account_names): Add a gboolean enabled_only
 189         parameter, so we can get lists of onlt the enabled accounts.
 190
 191         (modest_account_mgr_add_account),,
 192         (modest_account_mgr_account_with_display_name_exists):
 193         * src/maemo/modest-msg-edit-window.c: (get_transports):
 194         * src/modest-account-mgr-helpers.c:
 195         (modest_account_mgr_set_first_account_as_default):
 196         * src/modest-init.c: (init_default_account_maybe):
 197         * src/modest-tny-account-store.c: (get_accounts):
 198         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 199         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 200         * tests/check_account-mgr.c: (START_TEST):
 201         Provide the extra parameter, as appropriate.
 202
 203         * src/widgets/modest-account-view.c: (update_account_view):
 204         Do not show disabled accounts (meaning that there is no way to
 205         enable/disable accounts in the UI (the feature is not in our UI
 206         specification), so we can use this internally only to mark unfinished
 207         or temporary account data.
 208
 209         * src/maemo/easysetup/modest-easysetup-wizard.c:
 210         (create_account): Add boolean enable parameter, so we can specify FALSE
 211         to create the temporary account.
 212         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 213         (on_before_next): When finishing, when there is a temporary account, just
 214         set it as enabled.
 215         Also, use a timeout to delay the showing of the dialog until gconf is likely
 216         to return correct information, due to a maemo gconf bug that is fixed in
 217         osso 1.1, but not yet in Bora.
 218         However, the dialog stays on screen after it is destroyed.
 219
 220         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 221         for invalid data when cancelling. Use a hildon note instead of a dialog
 222         to complain about invalid data. Do not show the account-saved note if the
 223         account is disabled (a temporary account that will not really be saved for use
 224         until later.)
 225
 226 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 227
 228         * src/modest-account-mgr-helpers.h:
 229         * src/modest-account-mgr-helpers.c:
 230         Added modest_account_mgr_unset_default_account(),
 231         Added modest_account_mgr_set_first_account_as_default().
 232
 233         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 234         If it was the default account, unset the default account name.
 235
 236         * src/maemo/modest-account-view-window.c:
 237         (on_delete_button_clicked): If it was the default account,
 238         set the first remaining account as the default instead.
 239
 240         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 241         a NULL account or a NULL default account, to prevent a crash. This should
 242         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 243
 244
 245 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 246
 247         * src/widgets/modest-recpt-editor.c:
 248         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 249         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 250         TODO comment for this. This fixes the build.
 251
 252         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 253         be the best place for it. This will in future update all auto-update accounts,
 254         rather than just the current/default account, when that gconf key exists.
 255         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 256         if there are no accounts, before calling do_send_receive().
 257         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 258
 259         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 260         * src/maemo/modest-main-window-ui.h:
 261         * src/maemo/modest-main-window.c: (on_connection_changed),
 262         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 263         directly, becaue the signal handler does more.
 264
 265 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 266
 267         * src/modest-account-mgr-helpers.c:
 268         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 269         for the case that the account does not exist.
 270
 271         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 272         (equivalent to the modest account name) rather than the tinymail account name
 273         (equivalent to the modest account title - human readable) to get the account data.
 274         Check for null account data to prevent the crash, and add a TODO comment saying that
 275         this needs fixing because it is using the server account name instead of the account name.
 276
 277 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 278
 279         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 280         * src/maemo/modest-account-settings-dialog.c: (show_error),
 281         (show_ok):
 282         Use hildon_note_new_information() for informative and error messages,
 283         which seems to be expected for Maemo applications (no documentation that I know of
 284         says this). I am surprised that there is no distinction between info and error
 285         dialogs.
 286
 287 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 288
 289         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 290         it is easy to find where this is used.
 291
 292         * src/maemo/easysetup/modest-easysetup-wizard.c:
 293         (create_page_welcome), (create_page_account_details),
 294         (create_page_user_details), (create_page_complete_easysetup),
 295         (create_page_custom_incoming), (create_page_custom_outgoing),
 296         (create_page_complete_custom):
 297         * src/maemo/modest-account-settings-dialog.c:
 298         (create_page_account_details), (create_page_user_details),
 299         (create_page_incoming), (create_page_outgoing):
 300         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 301         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 302         (modest_connection_specific_smtp_edit_window_init):
 303         * src/maemo/modest-connection-specific-smtp-window.c:
 304         (modest_connection_specific_smtp_window_init):
 305         * src/maemo/modest-signature-editor-dialog.c:
 306         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 307         and scrolling policy as per the Email Application Layout Guide, if I have
 308         understood it.
 309
 310 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 311
 312         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 313         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 314         which were empty, because these vfuncs have been removed from TnyAccountStore.
 315         This fixes the build.
 316
 317 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 318
 319         * src/maemo/modest-main-window.c:
 320         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 321         showing/hiding it. Added TODO because it probably should not be NULL.
 322         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 323         because unnecessary g_warnings() make degugging difficult.
 324
 325 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 326
 327         * src/maemo/modest-msg-edit-window.c:
 328         (modest_msg_edit_window_select_color),
 329         (modest_msg_edit_window_select_background_color): 2 const corrections and
 330         moving 2 #endifs before closing brackets, to fix the build.
 331
 332 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 333
 334         * src/maemo/easysetup/modest-easysetup-wizard.h:
 335         * src/maemo/easysetup/modest-easysetup-wizard.c:
 336         (modest_easysetup_wizard_dialog_finalize),
 337         (on_button_edit_advanced_settings), (create_page_complete_custom),
 338         (on_response), (create_account):
 339         Implement the Advanced Settings edit button, by saving the account information,
 340         for the Advanded Settings dialog to use directly from gconf, and removing it
 341         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 342         Bug #5533 in the projects.maemo.org bugzilla.
 343
 344 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 345
 346         * src/maemo/modest-msg-view-window.c:
 347         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 348         when opening a message window.
 349
 350 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 351
 352         * src/maemo/easysetup/modest-easysetup-wizard.c:
 353         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 354         match the UI spec.
 355
 356         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 357         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 358         gconf settings. I probably added more checks than necessary, but that is safer.
 359
 360         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 361         variable to fix the build, but this seems to be used when it is still NULL.
 362
 363 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 364
 365         * src/modest-platform.h:
 366         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 367         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 368         * src/modest-main.c: Implement this function so we can avoid using
 369         maemo-specific API from cross-platform code.
 370         (main):
 371         * src/modest-tny-account-store.c:
 372         (get_smtp_specific_transport_account_for_open_connection):
 373         * src/modest-ui-actions.c: (check_for_connection),
 374         (modest_ui_actions_on_item_not_found):
 375         Use modest_platform_connect_and_wait() and put #idefs around other
 376         maemo-specific code, because only maemo currently has a way to
 377         identify connection names.
 378
 379 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 380
 381         * src/modest-tny-account-store.h:
 382         * src/modest-tny-account-store.c:
 383         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 384         the connection-specific SMTP server settings in the configuration.
 385
 386         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 387         (on_idle_mail_to):
 388         * src/maemo/modest-main-window.c: (on_connection_changed),
 389         (connect_signals):
 390         * src/modest-main.c: (main), (start_ui), (send_mail):
 391         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 392         that is what is intended.
 393
 394         * src/modest-ui-actions.c: (action_send), (action_receive),
 395         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 396         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 397         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 398         SMTP server is used when it is specified.
 399
 400         (modest_ui_actions_on_send_receive):
 401         Check that a connection is open before proceeding.
 402         Receive and then send, instead of vice-versa, as per the specification.
 403
 404 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 405
 406         * src/modest-mail-operation.c:
 407         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 408         though I guess it should be something other than NULL.
 409
 410 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 411
 412         * src/maemo/easysetup/modest-easysetup-wizard.c:
 413         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 414         combo twice, to avoid an g_warning and to make it visible again.
 415         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 416         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 417         (already intended) dereference when detaching, because we then recreate the menu.
 418         But I am not sure why the warning was happening, and it is possible that this is a memory
 419         leak.
 420
 421 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 422
 423         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 424         and uri_parse_mailto() utility functions.
 425         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 426         the mailto URI.
 427         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 428
 429 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 430
 431         * src/dbus_api/modest-dbus-api.h:
 432         * src/dbus_api/modest-dbus-callbacks.c:
 433         Use an idle callback to execute the modest code in the application's own thread.
 434         Remove the helloworld example method.
 435         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 436         parsed, and the open-message method is not implemented because this is not yet implemented in
 437         modest itself.
 438         * libmodest-dbus-client/libmodest-dbus-client.c:
 439         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 440         (libmodest_dbus_client_open_message):
 441         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 442
 443         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 444         body without crashing.
 445
 446         * tests/dbus_api/Makefile.am:
 447         * tests/dbus_api/test_mail_to.c:
 448         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 449
 450 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 451
 452         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 453         Added file to fix the build. Sorry.
 454
 455         * src/dbus_api/Makefile.am:
 456         * src/dbus_api/modest-dbus-api.h:
 457         * src/dbus_api/modest-dbus-callbacks.h:
 458         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 459         (modest_dbus_req_handler):
 460         Put constants in a separate header so it can be reused by the
 461         client library, without duplication
 462
 463         * libmodest-dbus-client/Makefile.am:
 464         * libmodest-dbus-client/libmodest-dbus-client.c:
 465         (libmodest_dbus_client_call_helloworld),
 466         (libmodfest_dbus_client_send_mail),
 467         (libmodfest_dbus_client_mailto),
 468         (libmodfest_dbus_client_open_message):
 469         * libmodest-dbus-client/libmodest-dbus-client.h:
 470         (Partly) Implement a send_mail D-Bus method.
 471
 472         * tests/dbus_api/Makefile.am:
 473         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 474         the send_email D-Bus method.
 475
 476 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 477
 478         * Makefile.am:
 479         * configure.ac:
 480         * libmodest-dbus-client/Makefile.am:
 481         * libmodest-dbus-client/libmodest-dbus-client.c:
 482         * libmodest-dbus-client/libmodest-dbus-client.h:
 483         * tests/dbus_api/Makefile.am:
 484         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 485         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 486
 487 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 488
 489         * src/maemo/easysetup/modest-easysetup-wizard.c:
 490         (create_page_account_details):
 491         * src/maemo/modest-account-settings-dialog.c:
 492         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 493         widgets, because this might not be the default in future versions of the Maemo GTK+.
 494         However, I can not not get capitalization to work even in a simple test case.
 495
 496 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 497
 498         * src/maemo/easysetup/modest-easysetup-wizard.c:
 499         (create_page_custom_incoming), (create_page_custom_outgoing):
 500         * src/maemo/modest-account-settings-dialog.c:
 501         (create_page_account_details), (create_page_incoming),
 502         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 503         instead of using gtk_check_button_with_label(), so they are aligned like the other
 504         widgets, as per the UI spec.
 505
 506 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 507
 508         * src/maemo/easysetup/modest-easysetup-wizard.c:
 509         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 510         * src/widgets/modest-validating-entry.c:
 511         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 512         Modest prefix instead of an EasySetup prefix.
 513
 514 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 515
 516         * src/widgets/modest-validating-entry.h:
 517         * src/widgets/modest-validating-entry.c: (on_insert_text),
 518         Added easysetup_validating_entry_set_max_func(), used to set a callback
 519         to call when the max number of characters is reached. GtkEntry has a max-length
 520         already but is silent about it.
 521
 522         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 523         (create_page_account_details), (create_page_user_details),
 524         (create_account):
 525         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 526         (create_page_account_details), (create_page_user_details),
 527         (create_page_outgoing):
 528         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 529         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 530         the UI spec, when the user tries to enter more than the max number of characters.
 531
 532 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 533
 534         * src/maemo/easysetup/modest-easysetup-wizard.c:
 535         (create_page_user_details), (create_page_custom_incoming),
 536         (create_page_custom_outgoing):
 537         * src/maemo/modest-account-settings-dialog.c:
 538         (create_page_user_details), (create_page_incoming),
 539         (create_page_outgoing):
 540         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 541         (modest_connection_specific_smtp_edit_window_init):
 542         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 543         not appropriate. Bad Maemo-specific defaults!.
 544
 545 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 546
 547         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 548         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 549         (modest_signature_editor_dialog_set_settings):
 550         Disable the label and textview when the checkbox is disabled, and use the
 551         specified (UI spec) default signature text.
 552
 553 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 554
 555         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 556         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 557
 558         * src/modest-defs.h:
 559         * src/modest-account-mgr-helpers.h:
 560         * src/modest-account-mgr-helpers.c:
 561         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 562
 563         * src/maemo/Makefile.am:
 564         * src/maemo/modest-signature-editor-dialog.c:
 565         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 566         as per the UI spec.
 567
 568         * src/maemo/modest-account-settings-dialog.h:
 569         * src/maemo/modest-account-settings-dialog.c:
 570         (modest_account_settings_dialog_finalize), (on_button_signature),
 571         (save_configuration): Use the new dialog when the Edit button is pressed, and
 572         save the changes if necessary, as per the UI spec.
 573
 574 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 575
 576         * src/maemo/Makefile.am:
 577         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 578         based on maemo-develoers email from Dirk.
 579
 580         * src/maemo/easysetup/modest-easysetup-wizard.c:
 581         (create_page_welcome), (create_page_account_details),
 582         (create_page_user_details), (create_page_complete_easysetup),
 583         (create_page_custom_incoming), (create_page_custom_outgoing),
 584         (create_page_complete_custom),
 585         (modest_easysetup_wizard_dialog_init):
 586         * src/maemo/modest-account-settings-dialog.c:
 587         (create_page_account_details), (create_page_user_details),
 588         (create_page_incoming), (create_page_outgoing),
 589         (modest_account_settings_dialog_init):
 590         * src/maemo/modest-connection-specific-smtp-window.c:
 591         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 592
 593 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 594
 595         * src/maemo/easysetup/modest-easysetup-wizard.c:
 596         (create_page_account_details), (create_page_custom_outgoing),
 597         (create_page_complete_custom):
 598         * src/maemo/modest-account-settings-dialog.c:
 599         (create_page_user_details), (create_page_incoming),
 600         (create_page_outgoing):
 601         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 602         (modest_connection_specific_smtp_edit_window_init):
 603         Use the correct (UI spec) port min/max, and use horizontal separators,
 604         as per the UI spec.
 605
 606 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 607
 608         * src/maemo/easysetup/modest-easysetup-wizard.c:
 609         (set_default_custom_servernames):
 610         * src/maemo/modest-account-settings-dialog.c:
 611         (create_page_incoming), (on_combo_outgoing_security_changed),
 612         (on_combo_incoming_security_changed), (create_page_outgoing),
 613         (modest_account_settings_dialog_set_account_name),
 614         (save_configuration):
 615         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 616         (on_combo_security_changed),
 617         (modest_connection_specific_smtp_edit_window_init),
 618         (modest_connection_specific_smtp_edit_window_set_connection),
 619         (modest_connection_specific_smtp_edit_window_get_settings):
 620         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 621         as per the UI spec.
 622
 623 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 624
 625         * po/en_GB.po:
 626         * src/maemo/easysetup/modest-easysetup-wizard.c:
 627         (create_page_custom_outgoing), (create_page_complete_custom):
 628         * src/maemo/modest-account-settings-dialog.c:
 629         (create_page_user_details), (create_page_outgoing):
 630         * src/maemo/modest-account-view-window.c: (button_box_new):
 631         Use changed logical IDs as per the most recent UI spec:
 632         mcen_bd_emailsetup_edit -> mcen_bd_edit
 633         mcen_bd_emailsetup_delete -> mcen_bd_delete
 634         mcen_bd_emailsetup_close -> mcen_bd_close
 635
 636 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 637
 638         * configure.ac:
 639         * src/Makefile.am:
 640         * src/dbus_api/Makefile.am:
 641         * src/dbus_api/modest-dbus-callbacks.c:
 642         * src/dbus_api/modest-dbus-callbacks.h:
 643         * src/maemo/modest-platform.c: (modest_platform_init):
 644         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 645         method.
 646         * tests/Makefile.am:
 647         * tests/dbus_api/Makefile.am:
 648         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 649
 650 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 651
 652         * src/maemo/modest-account-settings-dialog.c:
 653         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 654         Removed unnecessary includes.
 655
 656 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 657
 658         * src/maemo/easysetup/modest-easysetup-wizard.c:
 659         * src/maemo/modest-account-settings-dialog.c:
 660         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 661         * src/widgets/Makefile.am:
 662         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 663         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 664         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 665         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 666         * src/widgets/modest-secureauth-combo-box.c:
 667         * src/widgets/modest-secureauth-combo-box.h:
 668         * src/widgets/modest-serversecurity-combo-box.c:
 669         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 670         made the GObject names more consistent with the rest of the Modest code.
 671
 672 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 673
 674         * src/maemo/easysetup/Makefile.am:
 675         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 676         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 677         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 678         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 679         * src/maemo/easysetup/modest-easysetup-wizard.c:
 680         * src/maemo/easysetup/modest-validating-entry.c:
 681         * src/maemo/easysetup/modest-validating-entry.h:
 682         * src/maemo/modest-account-settings-dialog.c:
 683         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 684         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 685         widgets/ because they are used outside of easysetup too. After checking in,
 686         svn will allow me to rename them too.
 687
 688 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 689
 690         * src/gnome/modest-msg-edit-window.c:
 691         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 692         linker error, to fix the build on the GNOME platform.
 693         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 694         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 695         ifdefed out to avoid a warning.
 696
 697 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 698
 699         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 700         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 701         some alternative for GTK+ 2.6.
 702
 703 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 704
 705         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 706
 707         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 708         specified for EmailAccountsDialog in UI spec.
 709
 710         * src/maemo/easysetup/modest-easysetup-wizard.c:
 711         * src/maemo/easysetup/modest-easysetup-wizard.h:
 712         * src/maemo/modest-account-settings-dialog.c:
 713         * src/maemo/modest-account-settings-dialog.h:
 714         Reuse a member window widget for the connection-specific SMTP server accounts,
 715         so we can tell it to create/save the accounts only if we actually save changes.
 716
 717         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 718         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 719         (modest_connection_specific_smtp_edit_window_get_settings):
 720         Return a struct instance for temporarily remembering the entered data.
 721
 722         * src/maemo/modest-connection-specific-smtp-window.h:
 723         * src/maemo/modest-connection-specific-smtp-window.c:
 724         (modest_connection_specific_smtp_window_finalize),
 725         (modest_connection_specific_smtp_window_fill_with_connections),
 726         (on_button_edit),
 727         (modest_connection_specific_smtp_window_save_server_accounts),
 728         (update_model_server_names): Do not actually save data until asked,
 729         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 730
 731         (on_selection_changed),
 732         (modest_connection_specific_smtp_window_init): Disable the edit
 733         button when nothing is selected.
 734
 735         * src/modest-account-mgr-helpers.c:
 736         * src/modest-account-mgr-helpers.h:
 737         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 738         elsewhere.
 739
 740 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 741
 742         * src/modest-account-mgr-helpers.h:
 743         * src/modest-account-mgr-helpers.c:
 744         (modest_account_mgr_get_unused_account_name),
 745         (modest_account_mgr_get_unused_account_display_name): Added these
 746         utility functions, to avoid code duplication.
 747
 748         * src/maemo/easysetup/modest-easysetup-wizard.c:
 749         (create_page_account_details), (create_account):
 750         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 751         (on_combo_security_changed),
 752         (modest_connection_specific_smtp_edit_window_init),
 753         (modest_connection_specific_smtp_edit_window_save_settings):
 754         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 755         * src/maemo/modest-connection-specific-smtp-window.c:
 756         (modest_connection_specific_smtp_window_finalize),
 757         (modest_connection_specific_smtp_window_fill_with_connections),
 758         (on_button_edit), (modest_connection_specific_smtp_window_init):
 759         * src/maemo/modest-connection-specific-smtp-window.h:
 760         Implementing saving of connection-specific server accounts.
 761
 762         But I need to refactor this so we can save the data for each
 763         possible connection-specific account and only actually create the server accounts
 764         when the easysetup finished, or the OK button is pressed on the account settings
 765         dialog.
 766
 767 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 768
 769         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 770         (on_combo_security_changed):
 771         (modest_connection_specific_smtp_edit_window_init):
 772         Auto-fill the port number as in the account settings.
 773
 774         (modest_connection_specific_smtp_edit_window_set_connection):
 775         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 776         * src/maemo/modest-connection-specific-smtp-window.c:
 777         (fill_with_connections), (on_button_edit),
 778         (modest_connection_specific_smtp_window_init):
 779         Turn the edit window into a dialog to simplify the code, and
 780         set a WM hint as in a GtkDialog, because only a popup can be on top of
 781         another window in Maemo, and popups usually have no WM decoration.
 782
 783         * src/modest-defs.h:
 784         * src/modest-account-mgr-helpers.c:
 785         (modest_account_mgr_set_connection_specific_smtp),
 786         (modest_account_mgr_remove_connection_specific_smtp),
 787         (modest_account_mgr_get_connection_specific_smtp):
 788         * src/modest-account-mgr-helpers.h: Some functions to write the
 789         connection-specific SMTP server information. Not yet used.
 790
 791
 792         * src/widgets/modest-folder-view.c: (text_cell_data):
 793         Fix a warning about an uninitialized variable.
 794         (on_configuration_key_changed): Put an #ifdef around the use
 795         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 796
 797 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 798
 799         * src/maemo/modest-account-settings-dialog.h:
 800         * src/maemo/modest-account-settings-dialog.c:
 801         Added connect_for_modified() utility function to mark the new modified boolean.
 802
 803         (create_page_account_details), (create_page_user_details),
 804         (create_page_incoming), (create_page_outgoing), (on_response),
 805         (modest_account_settings_dialog_init),
 806         (modest_account_settings_dialog_set_account_name):
 807         Only warn about unsaved changes when there are actually unsaved changes.
 808
 809         * src/modest-account-mgr-helpers.c:
 810         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 811         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 812         to get the data from there in future.
 813
 814 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 815
 816         * src/modest-defs.h:
 817
 818         * src/modest-account-mgr-helpers.h:
 819         * src/modest-account-mgr-helpers.c:
 820         Store the security account setting in a single conf key instead of using
 821         the options list, so that the list is left for just the to-be-removed camel hack,
 822         and because gconf_client_set_list() is failing for some reason.
 823
 824         * src/modest-account-mgr.c:
 825         (modest_account_mgr_add_server_account):
 826         * src/maemo/modest-account-settings-dialog.c:
 827         (modest_account_settings_dialog_set_account_name),
 828         (save_configuration): Use the renamed functions.
 829
 830
 831 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 832
 833         * src/widgets/Makefile.am:
 834         * src/widgets/modest-limit-retrieve-combo-box.c:
 835         * src/widgets/modest-limit-retrieve-combo-box.h:
 836         * src/widgets/modest-retrieve-combo-box.c:
 837         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 838         the account settings dialog.
 839
 840         * src/modest-defs.h:
 841         * src/modest-account-mgr-helpers.h:
 842         * src/modest-account-mgr-helpers.c:
 843         (modest_server_account_get_option_secure_auth),
 844         (modest_server_account_set_option_secure_auth):
 845         * src/modest-account-mgr.c:
 846         (modest_account_mgr_add_server_account):
 847         Use the existing AUTH_MECH conf key for the secure-auth setting,
 848         instead of putting it in the list options, because this was actually used already.
 849
 850         * src/maemo/modest-account-settings-dialog.c:
 851         (create_page_account_details),
 852         (modest_account_settings_dialog_set_account_name),
 853         (save_configuration):
 854         * src/maemo/modest-account-settings-dialog.h:
 855         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 856         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 857
 858 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 859
 860         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 861         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 862         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 863
 864         * src/modest-defs.h:
 865         * src/maemo/modest-account-settings-dialog.c:
 866         (create_page_incoming), (on_combo_outgoing_security_changed),
 867         (on_combo_incoming_security_changed), (create_page_outgoing),
 868         (modest_account_settings_dialog_set_account_name),
 869         (save_configuration): Load/Save the port number, and change it when the
 870         security combo changes, to suitable defaults.
 871
 872 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 873
 874         * src/modest-account-mgr.c:
 875         (modest_account_mgr_add_server_account): Set the security and secure-auth
 876         options, and add a comment saying that the other camel-specific options should be
 877         removed in future.
 878
 879 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 880
 881         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 882         found by valgrind.
 883         * src/modest-tny-account-store.c: (account_list_free),
 884         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 885         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 886         easy to fix.
 887
 888 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 889
 890         * src/modest-protocol-info.c:
 891         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 892         is required by our UI spec. Maybe something in our implementation will use this eventually.
 893         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 894         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 895         instead of the previous 0 placeholder.
 896
 897         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 898         secure-auth settings.
 899         * src/modest-account-mgr-helpers.h:
 900         * src/modest-account-mgr-helpers.c:
 901         (modest_server_account_data_get_option_secure_auth),
 902         (modest_server_account_set_option_secure_auth),
 903         (modest_server_account_data_get_option_security),
 904         (modest_server_account_set_option_security): Added this API for getting and setting the security
 905         and secure-auth settings.
 906
 907         * src/maemo/modest-account-settings-dialog.h:
 908         * src/maemo/modest-account-settings-dialog.c:
 909         (modest_account_settings_dialog_finalize), (check_data),
 910         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 911         about changing titles.
 912         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 913         (save_configuration): Save the security and secure-auth settings.
 914
 915         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 916         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 917
 918 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 919
 920         * src/modest-defs.h:
 921         * src/modest-account-mgr.c:
 922         (modest_account_mgr_add_server_account):
 923         Added and used defines for the options key and value pair strings,
 924         that are used so far, though they do not seem to correspond to anything in our
 925         UI specs or ModestProtocol enum.
 926
 927         * src/modest-account-mgr-helpers.h:
 928         * src/modest-account-mgr-helpers.c:
 929         (compare_option_strings_for_name),
 930         (modest_server_account_data_get_option_value),
 931         (modest_server_account_data_get_option_bool),
 932         (modest_account_mgr_get_server_account_option):
 933         Added helper functions for parsing the options GSList.
 934
 935 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 936
 937         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 938         display name is based on the supplied account name.
 939         * src/modest-account-mgr.c:
 940         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 941         with an inefficient, but good-enough, implementation.
 942
 943         * src/maemo/easysetup/modest-easysetup-wizard.c:
 944         (create_page_account_details), (on_before_next), (create_account):
 945         Check for existing display names rather than (non-user-visible) account names, and just
 946         create and set a unique account name at the end.
 947
 948         * src/maemo/modest-account-settings-dialog.c:
 949         (modest_account_settings_dialog_init),
 950         (modest_account_settings_dialog_set_account_name),
 951         (create_page_incoming): Show the display name, instead of the account name.
 952         (on_response): Do some (not all) extra checks, as in the UI spec.
 953         (save_configuration): Save the display name if it was changed.
 954
 955 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 956
 957         * po/en_GB.po: Added needed logical ID and translation.
 958         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 959         (init_view): Made the is-default column clicking work.
 960
 961 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 962
 963         * configure.ac:
 964         * src/maemo/easysetup/Makefile.am:
 965         * src/maemo/easysetup/modest-easysetup-wizard.c:
 966         (modest_easysetup_wizard_dialog_init):
 967         * src/maemo/easysetup/provider-data-test.keyfile:
 968         * src/maemo/easysetup/provider-data.keyfile:
 969         Moved the provider data file to the new modest-providers-data package and used it from there.
 970
 971 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 972
 973         * src/modest-local-folder-info.c:
 974         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 975         N_() was already used on the static strings, but this just marks it for translation without
 976         using the translation.
 977
 978 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 979
 980         * src/maemo/modest-account-settings-dialog.c:
 981         (create_page_incoming),
 982         (modest_account_settings_dialog_set_account_name):
 983         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 984         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 985         I will do this if nobody else gets there first.
 986
 987 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 988
 989         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 990         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 991         save the security stuff.
 992
 993 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 994
 995         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 996         Set the email address and user fullname, which I now see must be
 997         done separately.
 998
 999         * src/maemo/modest-account-settings-dialog.h:
1000         * src/maemo/modest-account-settings-dialog.c:
1001          (on_response),
1002         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1003         leave-on-server and authentication.
1004         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1005         how to do the rest.
1006
1007 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1008
1009
1010         * src/maemo/modest-account-settings-dialog.c:
1011         * src/maemo/modest-account-settings-dialog.h:
1012         Most (but not all) of the widgets are now present as specified by the UI spec.
1013         No changes are yet saved, and some details are not properly shown yet.
1014
1015         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1016
1017 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1018
1019         * src/maemo/Makefile.am:
1020         * src/maemo/modest-account-settings-dialog.c:
1021         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1022         an existing account. Doesn't do much yet.
1023
1024         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1025         Open the accounts settings dialog when Edit is clicked.
1026
1027 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1028
1029         * src/maemo/easysetup/Makefile.am:
1030         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1031         (load_from_file):
1032         * src/maemo/easysetup/modest-easysetup-wizard.c:
1033         (modest_easysetup_wizard_dialog_init):
1034         Try to get the source directory from the build system,
1035         instead of hard-coding "./" into the source code, when opening our local
1036         copies of the configuration files.
1037         But this still fails when opening the wizard from the Accounts window,
1038         maybe because the working directory seems to change at runtime.
1039         So the wizard will fail the second time unless you copy the files into their
1040         proper locations - see the stdout warnings for the paths.
1041
1042         (create_page_account_details),(on_before_next):
1043         Check for existing non-server accounts instead of server accounts,
1044         so the default account name is useful again, and to prevent trying to
1045         recreate accounts.
1046
1047         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1048         Show the wizard when New is clicked.
1049
1050         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1051         (init_view): Show the column headers, and show the columns that are
1052         specified in the UI specs. However, something in Maemo's GTK+ prevents
1053         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1054         change the default account. This is despite unsetting the special properties.
1055
1056 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1057
1058         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1059         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1060         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1061         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1062         to make that clearer.
1063         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1064
1065 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1066
1067         * src/maemo/modest-account-view-window.c:
1068         (modest_account_view_window_init),
1069         (modest_account_view_window_new):
1070         Use the same buttons as specified in the
1071         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1072         the existing widgets, which never had a chance of working.
1073         Put the ModestAccountView treeview in a scrolled window.
1074         Do not repeat the initialization in both _init() and _new().
1075
1076         * src/widgets/modest-account-view.c: (update_account_view):
1077         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1078         this widget and window shows no accounts.
1079
1080         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1081
1082 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1083
1084         * src/maemo/easysetup/modest-easysetup-wizard.c:
1085         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1086         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1087         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1088         which seems wrong.
1089
1090         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1091         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1092         accounts exist yet, as in the UI spec.
1093
1094         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1095
1096 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1097
1098         * src/maemo/Makefile.am:
1099         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1100         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1101         New window for editing connection-specific smtp details.
1102         Not fully implemented.
1103
1104         * src/maemo/modest-connection-specific-smtp-window.c:
1105         (modest_connection_specific_smtp_window_finalize) :
1106         unref the tree model.
1107         (on_button_edit): Show the edit window.
1108
1109 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1110
1111         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1112         error for me.
1113
1114         * src/maemo/Makefile.am:
1115         * src/maemo/modest-connection-specific-smtp-window.c:
1116         * src/maemo/modest-connection-specific-smtp-window.h:
1117         New window for showing the list of connections, for connection-specific
1118         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1119         * src/maemo/easysetup/modest-easysetup-wizard.c:
1120         (create_page_custom_outgoing): Show the new window when the button is clicked.
1121
1122 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1123
1124         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1125         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1126         * src/maemo/modest-msg-edit-window.c:
1127         (modest_msg_edit_window_insert_image):
1128         * src/modest-conf.c: (modest_conf_key_escape):
1129         * src/modest-mail-operation.c:
1130         (modest_mail_operation_send_new_mail):
1131         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1132         (modest_ui_actions_on_new_account):
1133         * src/widgets/modest-attachment-view.c: (update_filename_request):
1134         * src/widgets/modest-mail-header-view.c:
1135         Corrected warnings that were breaking the build, by commenting out unused variables,
1136         and a function, and by including a header.
1137
1138 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1139
1140         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1141         so we can #ifdef around platform-specific code when necessary.
1142         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1143         to allow this to build for the GNOME platform too.
1144
1145 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1146
1147         * src/maemo/easysetup/modest-easysetup-wizard.c:
1148         Added util_increment_name() and used it in create_page_account_details()
1149         to make sure that the default account name is always a new name.
1150
1151         (modest_easysetup_wizard_dialog_init),
1152         (set_default_custom_servernames): Some minor memory management fixes.
1153
1154 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1155
1156         * Makefile.am:
1157         * configure.ac:
1158         * src/modest-runtime.c: (init_i18n): Restored the translation
1159         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1160         are defined in config.h, and the translations are installed.
1161
1162         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1163         is defined for translation.
1164
1165 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1166
1167         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1168         (load_from_file):
1169         * src/maemo/easysetup/modest-easysetup-wizard.c:
1170         (modest_easysetup_wizard_dialog_init):
1171         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1172         Use realistic paths (though they should use $prefix generically) to the
1173         mcc_mapping and provider-data.keyfile files which might work when they
1174         are installed by the future version of the operator-wizard package,
1175         and then fallback to paths in our source code, with an explanatory
1176         warning.
1177
1178 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1179
1180         * configure.ac:
1181         * src/Makefile.am:
1182         * src/maemo/Makefile.am:
1183         * src/maemo/easysetup/: Added files from the previously-exernal
1184         osso-modest-easysetup.
1185         * src/maemo/modest-main-window-ui.h:
1186         * src/modest-ui-actions.c:
1187         * src/modest-ui-actions.h:
1188         Added modest_ui_actions_on_new_account() as a signal handler for the
1189         New Account menu item. It shows the easysetup wizard.
1190         * po/en_GB.po: Added additional needed logical IDs and translations.
1191
1192 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1193 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1194