1 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-platform.c:
4 (on_modest_conf_update_interval_changed), (modest_platform_init):
5 Only respond to this particular key change. All these strcmp()s cannot be
8 2007-05-15 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/modest-maemo-global-settings-dialog.c:
11 (current_connection): Prevent a crash in scratchbox when
12 ny_maemo_conic_device_get_current_iap_id() returns NULL.
13 * src/maemo/modest-platform.c:
14 (on_modest_conf_update_interval_changed), (modest_platform_init):
15 Get the update interval from gconf and reset it when the gconf key changes.
17 2007-05-15 Murray Cumming <murrayc@murrayc.com>
19 * src/modest-protocol-info.c:
20 * src/modest-protocol-info.h: Adde enum-specific get functions,
21 instead of using a ModestProtocolType enum parameter.
23 * src/gnome/modest-account-assistant.c:
24 * src/gnome/modest-store-widget.c:
25 * src/gnome/modest-store-widget.h:
26 * src/gnome/modest-transport-widget.c:
27 * src/gnome/modest-transport-widget.h:
28 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
29 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
30 * src/maemo/easysetup/modest-easysetup-wizard.c:
31 * src/maemo/modest-account-settings-dialog.c:
32 * src/maemo/modest-account-settings-dialog.h:
33 * src/maemo/modest-store-widget.c:
34 * src/maemo/modest-store-widget.h:
35 * src/maemo/modest-transport-widget.c:
36 * src/maemo/modest-transport-widget.h:
37 * src/modest-account-mgr-helpers.c:
38 * src/modest-account-mgr-helpers.h:
39 * src/modest-account-mgr.c:
40 * src/modest-account-mgr.h:
41 * src/modest-tny-account.c:
42 * src/modest-tny-folder.c:
43 * src/widgets/modest-account-view.c:
44 * src/widgets/modest-retrieve-combo-box.c:
45 * src/widgets/modest-retrieve-combo-box.h:
46 * src/widgets/modest-secureauth-combo-box.c:
47 * src/widgets/modest-serversecurity-combo-box.c:
48 * src/widgets/modest-serversecurity-combo-box.h:
49 * tests/check_account-mgr.c:
50 Use the specific functions, and use the re-renamed enum values for GNOME too.
52 2007-05-15 Murray Cumming <murrayc@murrayc.com>
55 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
56 so we can get the second based on the first.
58 * src/maemo/modest-account-settings-dialog.h:
59 * src/maemo/modest-account-settings-dialog.c:
60 Added get_supported_secure_authentication_methods(), though it is mostly
61 commented-out for now until the necessary API is committed to tinymail.
62 (modest_account_settings_dialog_set_account_name),
63 (save_configuration): Request the supported authentication methods from the
64 server, so we can choose a working method.
66 * src/modest-tny-account-store.h:
67 * src/modest-tny-account-store.c:
68 (modest_tny_account_store_get_session): Rename from
69 tny_account_store_get_session().
71 2007-05-14 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-protocol-info.h: Split the ModestProtocol enum
74 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
75 There was no need to have these unrelated values in one enum.
77 * src/: many files: Adapted to changed enum. This makes the code a bit
78 clearer, and the compiler could catch some errors.
80 2007-05-14 Murray Cumming <murrayc@murrayc.com>
82 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
83 Show the detailed internal camel error message when an error happens
84 during the configuration, so that our testers can give us more clues.
85 For instance, in projects.maemo.org bug NB#56910 .
87 2007-05-14 Murray Cumming <murrayc@murrayc.com>
89 * src/modest-tny-account.c:
90 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
91 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
93 2007-05-14 Murray Cumming <murrayc@murrayc.com>
95 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
96 * src/maemo/modest-account-settings-dialog.c:
97 (modest_account_settings_dialog_set_account_name),
98 (save_configuration): For the incoming secure authentication checkbox,
99 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
100 the UI specification. PLAIN does not seem to be supported for most IMAP
101 servers anyway, and I am not sure what it would mean.
102 However, we probably need to discover which of the secure-authentication
103 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
104 * src/modest-account-mgr-helpers.c:
105 (modest_account_mgr_get_server_account_data):
107 * src/modest-tny-account.c:
108 (modest_tny_account_new_from_server_account):
109 Use tny_account_set_mech() to set secure-authentication methods,
110 with some special-casing for IMAP, based on my observations of how
113 * src/modest-account-mgr-helpers.h:
114 * src/modest-account-mgr.c:
115 * src/modest-defs.h: Comment that the URI is only used for local folders.
117 2007-05-11 Murray Cumming <murrayc@murrayc.com>
119 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
120 parameter const, just to be neat.
121 * src/modest-text-utils.c: (modest_text_utils_inline):
122 End g_strconcat() with NULL, as its documentation says. This is almost
123 certainly the cause of my crash at startup on the device. Interestingly,
124 valgrind doesn't tell us about these errors.
126 2007-05-11 Murray Cumming <murrayc@murrayc.com>
128 * scripts/build-packages: Added more precise comments about how to use
129 this script, though I still get this error:
130 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
131 error building tinymail
133 2007-05-11 Murray Cumming <murrayc@murrayc.com>
135 * src/maemo/modest-main-window.c: (on_account_update):
136 Very slight cleanup, hoping to make it simpler to discover what causes
137 a crash here sometimes.
139 * src/modest-tny-account.c:
140 (modest_tny_account_new_from_server_account): Set the port. Added
141 comments about the options and a TODO comment because I need to find out
142 how to specify the secure authentication method.
144 2007-05-11 Marcus Bauer <marcusb@openismus.com>
146 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
147 changed CFlags paths form modest to libmodest
149 2007-05-10 Murray Cumming <murrayc@murrayc.com>
151 * src/modest-account-mgr-helpers.c:
152 (modest_account_mgr_get_server_account_data),
153 (modest_account_mgr_free_server_account_data):
154 * src/modest-account-mgr-helpers.h:
155 * src/modest-account-mgr.c:
156 (modest_account_mgr_add_server_account):
158 * src/modest-tny-account.c:
159 (modest_tny_account_new_from_server_account):
160 Determine the options for tny_camel_account_add_option() here,
161 based on the settings, rather than storing them directly in gconf.
163 2007-05-10 Murray Cumming <murrayc@murrayc.com>
165 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
166 Show a more friendly error dialog now that we expect (from the tinymail
167 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
169 2007-05-10 Murray Cumming <murrayc@murrayc.com>
171 * src/maemo/modest-main-window.c: (on_account_update): Check that
172 account_name is not NULL, to prevent a crash at startup that I am
173 seeing on the N800. I do wonder why it is NULL.
175 * src/maemo/easysetup/modest-easysetup-wizard.c:
176 (create_page_user_details):
177 * src/maemo/modest-account-settings-dialog.c:
178 (create_page_user_details), (create_page_outgoing):
179 * src/maemo/modest-connection-specific-smtp-edit-window.c:
180 (modest_connection_specific_smtp_edit_window_init):
181 * src/modest-ui-actions.c:
182 (modest_ui_actions_on_password_requested):
183 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
184 might do something useful with the on-screen keyboard.
186 2007-05-10 Murray Cumming <murrayc@murrayc.com>
188 * src/maemo/modest-main-window.c: (on_account_update):
189 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
190 NULL, to avoid lots of warnings. However, it probably should not be NULL.
192 2007-05-09 Murray Cumming <murrayc@murrayc.com>
194 * src/modest-tny-account-store.c: (on_account_changed):
195 Correct the signature of this signal handler.
197 2007-05-09 Murray Cumming <murrayc@murrayc.com>
199 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
200 Show a HildonNote instead of a GtkDialog for Maemo.
202 2007-05-09 Murray Cumming <murrayc@murrayc.com>
204 * src/widgets/modest-account-view.h:
205 * src/widgets/modest-account-view.c: (on_account_changed),
206 (on_account_removed). Added a boolean flag, set/unset by
207 modest_account_view_block_conf_updates(),
208 modest_account_view_unblock_conf_updates() to prevent unnecessary
209 updates, but this is not very useful because the gconf notifications are
210 so delays (maybe only on Maemo Bora).
211 So auto-updating is turned off, and these functions do an explicit
212 update when necessary.
213 However, something else is still doing too much work when adding/removing
214 accounts, probably in another part of the application.
216 * src/maemo/modest-account-view-window.c:
217 (on_delete_button_clicked), (on_edit_button_clicked),
218 (on_new_button_clicked): Use the new functions.
220 2007-05-09 Murray Cumming <murrayc@murrayc.com>
222 * src/modest-account-mgr-helpers.c:
223 (modest_account_mgr_set_first_account_as_default):
224 Sort the list of names alphabetically-by-title, so we choose the first one
226 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
227 alphabetically by the title.
229 This fixes projects.maemo.org bug NB#56418 .
231 * src/modest-account-mgr-priv.c:
232 (_modest_account_mgr_account_from_key):
233 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
234 avoid a valgrind error, and possible random behaviour.
236 2007-05-09 Murray Cumming <murrayc@murrayc.com>
238 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
239 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
240 tinymail documentation to say that this can be expected.
241 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
242 pretty, and should not happen, but I would prefer to know when it does.
244 2007-05-09 Murray Cumming <murrayc@murrayc.com>
246 * configure.ac: When using the older hildon version, probably on Bora,
247 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
249 * src/widgets/modest-attachment-view.c:
250 (modest_attachment_view_set_part_default): Initialize variables, to fix the
253 2007-05-09 Marcus Bauer <marcusb@openismus.com>
255 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
256 Implemented the prototype. Can be tested with
257 tests/dbus_api/test_open_message:
259 2007-05-08 Murray Cumming <murrayc@murrayc.com>
261 * src/modest-tny-account-store.c:
262 (modest_tny_account_store_instance_init), (get_password):
263 * src/modest-ui-actions.c:
264 (modest_ui_actions_on_password_requested):
265 Do not store the password in gconf, because this function is called
266 for non-remembered passwords. Actually use the cached (in the hash map)
267 password instead of releasing it.
268 The password will now not be remembered if it is asked via the protected
269 password dialog, as per the UI spec.
271 2007-05-08 Murray Cumming <murrayc@murrayc.com>
274 * src/modest-account-mgr-helpers.h:
275 * src/modest-account-mgr-helpers.c:
276 Added modest_server_account_get_username_has_succeeded(),
277 modest_server_account_set_username_has_succeeded().
278 (modest_server_account_set_username),
279 Reset the has-succeeded flag if the username changes.
281 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
282 * src/maemo/modest-connection-specific-smtp-window.c:
283 (modest_connection_specific_smtp_window_save_server_accounts):
284 Use modest_server_account_set_username() instead of using
285 modest_conf_set_string() directly, so that the has-succeeded flag is always
288 * src/modest-ui-actions.c:
289 (modest_ui_actions_on_password_requested): Dim the username entry if
290 the username has ever worked, as per the UI spec.
292 2007-05-08 Murray Cumming <murrayc@murrayc.com>
294 * src/modest-tny-account-store.c: (get_password):
295 * src/modest-ui-actions.c:
296 (modest_ui_actions_on_password_requested):
297 Allow the username to be changed too, though there is more work to
298 be done on exactly how this behaves.
300 2007-05-08 Murray Cumming <murrayc@murrayc.com>
302 * src/modest-account-mgr-helpers.h:
303 * src/modest-account-mgr-helpers.c:
304 Added modest_account_mgr_get_display_name(),
305 modest_server_account_get_username(),
306 modest_server_account_set_username(),
307 modest_server_account_set_password(),
308 modest_server_account_get_hostname() functions so we do not need to
309 use the conf API directly.
311 * src/maemo/modest-main-window.c: (connect_signals):
312 Actually connect ot the ModestAccountStore::request-password signal,
313 so that we show the dialog when the password is requested by Tinymail,
314 for isntance if it is empty.
316 * src/modest-marshal.list:
317 * src/modest-tny-account-store.c:
318 (modest_tny_account_store_class_init), (get_password),
319 (modest_tny_account_store_alert):
320 * src/modest-tny-account-store.h:
321 * src/modest-ui-actions.h:
322 * src/modest-ui-actions.c:
323 (modest_ui_actions_on_password_requested):
324 Change the signal parameters, so it is obvious that we are providing
325 the non human-readable server name, and receiving both the username
326 and password, though changing of the username is not yet implemented.
327 Change the dialog UI to match the Maemo UI specifications, with #idfefing
328 for the GNOME version.
330 This should fix the projects.maemo.org bug NB#56209, though it does not
331 work on Bora, because the gconf_client_get() for the password fails
332 immediately after we save it with gconf_client_set().
334 2007-05-08 Murray Cumming <murrayc@murrayc.com>
337 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
338 caused an undefined symbol error:
339 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
341 2007-05-08 Murray Cumming <murrayc@murrayc.com>
343 * src/modest-tny-account-store.c:
344 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
345 using a GError instead of a string message, so we can translate it in
348 2007-05-08 Murray Cumming <murrayc@murrayc.com>
350 * src/maemo/modest-address-book.c:
351 (modest_address_book_check_names):
352 * src/maemo/modest-msg-view-window.c:
353 (modest_msg_view_window_clipboard_owner_change):
354 * src/modest-init.c: (modest_init_init_ui):
355 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
356 (update_folders_cb), (modest_mail_operation_update_account):
357 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
358 (modest_ui_actions_on_msg_attachment_clicked),
359 (modest_ui_actions_on_msg_recpt_activated):
360 * src/widgets/modest-header-view.c: (drag_data_get_cb):
361 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
362 (modest_msg_view_search_next):
363 * src/widgets/modest-recpt-editor.c:
364 (modest_recpt_editor_on_button_release_event),
365 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
366 g_message(). At this point we should only be seeing interesting errors on
367 stdout. Debugging messages could be #ifdefed-out if they are still useful.
369 2007-05-07 Murray Cumming <murrayc@murrayc.com>
371 (modest_wizard_dialog_force_title_update):
372 * src/maemo/easysetup/modest-wizard-dialog.h:
373 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
374 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
375 can update the title when appropriate. Otherwise the title is wrong if the
376 pages are added after adding the notebook to the dialog.
377 This must be a problem in HildonWizardDialog too.
378 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
380 * src/maemo/easysetup/modest-easysetup-wizard.c:
381 (create_subsequent_customsetup_pages),
382 (create_subsequent_easysetup_pages):
383 Call modest_wizard_dialog_force_title_update() so that the title is
384 correct even with GTK+ < 2.10.
385 This fixes projects.maemo.org bug NB#56145 .
387 2007-05-07 Murray Cumming <murrayc@murrayc.com>
389 * src/maemo/modest-platform.c:
390 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
391 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
394 2007-05-07 Murray Cumming <murrayc@murrayc.com>
396 * src/widgets/modest-window.h:
397 * src/widgets/modest-window.c: Added a save_state_func vfunc,
398 and modest_window_save_state(), which invokes it.
400 * src/widgets/modest-window-mgr.h:
401 * src/widgets/modest-window-mgr.c:
402 Added modest_window_mgr_save_state_for_all_windows(), which calls
403 the save_state vfunc on all registered windows, if implemented.
405 * src/gnome/modest-msg-edit-window.c:
406 * src/gnome/modest-msg-view-window.c:
407 * src/maemo/modest-msg-edit-window.c:
408 * src/maemo/modest-msg-view-window.c:
409 * src/maemo/modest-main-window.c:
410 Specify the existing save_settings functions as implementations of
411 ModestWindow::save_state_func().
413 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
414 Call modest_window_mgr_save_state_for_all_windows(). This happens before
415 enabling hibernation, for instance.
417 We may need to do the same thing for restoring settings.
420 2007-05-07 Murray Cumming <murrayc@murrayc.com>
422 * src/widgets/modest-window-mgr.c:
423 * src/widgets/modest-window-mgr.h:
424 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
425 modest_window_mgr_get_hibernation_is_prevented().
427 * src/maemo/modest-main-window.c:
428 (on_hildon_program_is_topmost_notify): Prevent hibernation
429 (possible when the application goes to the background in the WM),
430 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
432 * src/maemo/easysetup/modest-easysetup-wizard.c:
433 (modest_easysetup_wizard_dialog_init):
434 * src/maemo/modest-account-settings-dialog.c:
435 (modest_account_settings_dialog_init):
436 * src/maemo/modest-connection-specific-smtp-edit-window.c:
437 (modest_connection_specific_smtp_edit_window_init):
438 * src/maemo/modest-connection-specific-smtp-window.c:
439 (modest_connection_specific_smtp_window_init):
440 * src/maemo/modest-signature-editor-dialog.c:
441 (modest_signature_editor_dialog_init):
442 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
443 prevent hibernation while any of these account settings dialogs are open.
445 2007-05-04 Murray Cumming <murrayc@murrayc.com>
447 * src/maemo/Makefile.am:
448 * src/maemo/modest-osso-state-saving.c:
449 * src/maemo/modest-osso-state-saving.h: Added
450 modest_osso_load_state() and modest_osso_save_state() though they do
451 nothing now. They should iterate through all the open windows and load/save
453 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
454 save state when closing.
456 * src/maemo/modest-main-window.c:
457 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
458 Add a notification handler for the HildonProgram::is-topmost property,
459 so we can allow hibernation when the application goes into the background.
460 But we still need to detect when the accounts setup windows are open so
461 we can stop hibernation when they are open.
462 To do this, I also added the main window the HildonProgram. This might have
463 other side-effects/benefits, and should maybe be done for other windows.
465 * src/maemo/modest-osso-autosave-callbacks.h:
466 * src/maemo/modest-osso-autosave-callbacks.c:
467 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
468 though it does not do anything yet, and we might never need this to do
469 anything. For instance, we already save drafts.
471 * src/maemo/modest-platform.c: (modest_platform_init):
472 Specify the libosso auto-save callback.
474 2007-05-03 Murray Cumming <murrayc@murrayc.com>
476 * src/maemo/modest-platform.c:
477 (modest_platform_set_update_interval):
478 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
479 aparently stays valid between application instances, so we can use this
480 to remove and reset it later. According to a maemo-developers email from
483 2007-05-03 Murray Cumming <murrayc@murrayc.com>
485 * configure.ac: Depend on libalarm for Maemo.
487 * src/dbus_api/modest-dbus-api.h:
488 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
489 (on_send_receive), (modest_dbus_req_handler):
490 Handle a SEND_RECEIVE D-Bus method.
492 * libmodest-dbus-client/libmodest-dbus-client.c:
493 (libmodest_dbus_client_send_and_receive):
494 * libmodest-dbus-client/libmodest-dbus-client.h:
495 Add C convenience functions for calling the new D-Bus method.
497 * src/modest-platform.h:
498 * src/gnome/modest-platform.c:
499 * src/maemo/modest-platform.c:
500 Added modest_platform_set_update_interval(), which uses the
502 (modest_platform_init),
503 Call modest_platform_set_update_interval(), using a hard-coded
504 interval for now (until the global settings dialog is implemented),
505 though I am not sure that this makes sense yet.
507 2007-05-02 Murray Cumming <murrayc@murrayc.com>
509 * src/dbus_api/modest-dbus-callbacks.c:
510 (modest_osso_cb_hw_state_handler):
511 * src/dbus_api/modest-dbus-callbacks.h:
512 * src/maemo/modest-platform.c: (modest_platform_init):
513 Registered (empty) callbacks for the osso hardware state D-Bus signals,
514 in case this has some effect on the ability for Maemo to ping the
517 2007-05-02 Murray Cumming <murrayc@murrayc.com>
519 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
520 Comment out an if() that checks a gchar for < 0, causing a build-breaking
521 warning. It is probably a logic error, but I need to fix the build.
523 2007-05-02 Murray Cumming <murrayc@murrayc.com>
525 * src/modest-account-mgr.h:
526 * src/modest-account-mgr.c:
527 (modest_account_mgr_account_names): Add a gboolean enabled_only
528 parameter, so we can get lists of onlt the enabled accounts.
530 (modest_account_mgr_add_account),,
531 (modest_account_mgr_account_with_display_name_exists):
532 * src/maemo/modest-msg-edit-window.c: (get_transports):
533 * src/modest-account-mgr-helpers.c:
534 (modest_account_mgr_set_first_account_as_default):
535 * src/modest-init.c: (init_default_account_maybe):
536 * src/modest-tny-account-store.c: (get_accounts):
537 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
538 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
539 * tests/check_account-mgr.c: (START_TEST):
540 Provide the extra parameter, as appropriate.
542 * src/widgets/modest-account-view.c: (update_account_view):
543 Do not show disabled accounts (meaning that there is no way to
544 enable/disable accounts in the UI (the feature is not in our UI
545 specification), so we can use this internally only to mark unfinished
546 or temporary account data.
548 * src/maemo/easysetup/modest-easysetup-wizard.c:
549 (create_account): Add boolean enable parameter, so we can specify FALSE
550 to create the temporary account.
551 (on_button_edit_advanced_settings): Create the temporary account as disabled.
552 (on_before_next): When finishing, when there is a temporary account, just
554 Also, use a timeout to delay the showing of the dialog until gconf is likely
555 to return correct information, due to a maemo gconf bug that is fixed in
556 osso 1.1, but not yet in Bora.
557 However, the dialog stays on screen after it is destroyed.
559 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
560 for invalid data when cancelling. Use a hildon note instead of a dialog
561 to complain about invalid data. Do not show the account-saved note if the
562 account is disabled (a temporary account that will not really be saved for use
565 2007-04-30 Murray Cumming <murrayc@murrayc.com>
567 * src/modest-account-mgr-helpers.h:
568 * src/modest-account-mgr-helpers.c:
569 Added modest_account_mgr_unset_default_account(),
570 Added modest_account_mgr_set_first_account_as_default().
572 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
573 If it was the default account, unset the default account name.
575 * src/maemo/modest-account-view-window.c:
576 (on_delete_button_clicked): If it was the default account,
577 set the first remaining account as the default instead.
579 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
580 a NULL account or a NULL default account, to prevent a crash. This should
581 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
584 2007-04-30 Murray Cumming <murrayc@murrayc.com>
586 * src/widgets/modest-recpt-editor.c:
587 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
588 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
589 TODO comment for this. This fixes the build.
591 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
592 be the best place for it. This will in future update all auto-update accounts,
593 rather than just the current/default account, when that gconf key exists.
594 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
595 if there are no accounts, before calling do_send_receive().
596 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
598 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
599 * src/maemo/modest-main-window-ui.h:
600 * src/maemo/modest-main-window.c: (on_connection_changed),
601 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
602 directly, becaue the signal handler does more.
604 2007-04-30 Murray Cumming <murrayc@murrayc.com>
606 * src/modest-account-mgr-helpers.c:
607 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
608 for the case that the account does not exist.
610 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
611 (equivalent to the modest account name) rather than the tinymail account name
612 (equivalent to the modest account title - human readable) to get the account data.
613 Check for null account data to prevent the crash, and add a TODO comment saying that
614 this needs fixing because it is using the server account name instead of the account name.
616 2007-04-29 Murray Cumming <murrayc@murrayc.com>
618 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
619 * src/maemo/modest-account-settings-dialog.c: (show_error),
621 Use hildon_note_new_information() for informative and error messages,
622 which seems to be expected for Maemo applications (no documentation that I know of
623 says this). I am surprised that there is no distinction between info and error
626 2007-04-29 Murray Cumming <murrayc@murrayc.com>
628 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
629 it is easy to find where this is used.
631 * src/maemo/easysetup/modest-easysetup-wizard.c:
632 (create_page_welcome), (create_page_account_details),
633 (create_page_user_details), (create_page_complete_easysetup),
634 (create_page_custom_incoming), (create_page_custom_outgoing),
635 (create_page_complete_custom):
636 * src/maemo/modest-account-settings-dialog.c:
637 (create_page_account_details), (create_page_user_details),
638 (create_page_incoming), (create_page_outgoing):
639 * src/maemo/modest-account-view-window.c: (window_vbox_new):
640 * src/maemo/modest-connection-specific-smtp-edit-window.c:
641 (modest_connection_specific_smtp_edit_window_init):
642 * src/maemo/modest-connection-specific-smtp-window.c:
643 (modest_connection_specific_smtp_window_init):
644 * src/maemo/modest-signature-editor-dialog.c:
645 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
646 and scrolling policy as per the Email Application Layout Guide, if I have
649 2007-04-27 Murray Cumming <murrayc@murrayc.com>
651 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
652 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
653 which were empty, because these vfuncs have been removed from TnyAccountStore.
654 This fixes the build.
656 2007-04-27 Murray Cumming <murrayc@murrayc.com>
658 * src/maemo/modest-main-window.c:
659 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
660 showing/hiding it. Added TODO because it probably should not be NULL.
661 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
662 because unnecessary g_warnings() make degugging difficult.
664 2007-04-27 Murray Cumming <murrayc@murrayc.com>
666 * src/maemo/modest-msg-edit-window.c:
667 (modest_msg_edit_window_select_color),
668 (modest_msg_edit_window_select_background_color): 2 const corrections and
669 moving 2 #endifs before closing brackets, to fix the build.
671 2007-04-27 Murray Cumming <murrayc@murrayc.com>
673 * src/maemo/easysetup/modest-easysetup-wizard.h:
674 * src/maemo/easysetup/modest-easysetup-wizard.c:
675 (modest_easysetup_wizard_dialog_finalize),
676 (on_button_edit_advanced_settings), (create_page_complete_custom),
677 (on_response), (create_account):
678 Implement the Advanced Settings edit button, by saving the account information,
679 for the Advanded Settings dialog to use directly from gconf, and removing it
680 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
681 Bug #5533 in the projects.maemo.org bugzilla.
683 2007-04-27 Murray Cumming <murrayc@murrayc.com>
685 * src/maemo/modest-msg-view-window.c:
686 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
687 when opening a message window.
689 2007-04-27 Murray Cumming <murrayc@murrayc.com>
691 * src/maemo/easysetup/modest-easysetup-wizard.c:
692 (create_page_custom_outgoing): Correct the position of the horizontal separator to
695 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
696 before showing/hiding them, to avoid a crash when clicking on folders when there are no
697 gconf settings. I probably added more checks than necessary, but that is safer.
699 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
700 variable to fix the build, but this seems to be used when it is still NULL.
702 2007-04-27 Murray Cumming <murrayc@murrayc.com>
704 * src/modest-platform.h:
705 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
706 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
707 * src/modest-main.c: Implement this function so we can avoid using
708 maemo-specific API from cross-platform code.
710 * src/modest-tny-account-store.c:
711 (get_smtp_specific_transport_account_for_open_connection):
712 * src/modest-ui-actions.c: (check_for_connection),
713 (modest_ui_actions_on_item_not_found):
714 Use modest_platform_connect_and_wait() and put #idefs around other
715 maemo-specific code, because only maemo currently has a way to
716 identify connection names.
718 2007-04-27 Murray Cumming <murrayc@murrayc.com>
720 * src/modest-tny-account-store.h:
721 * src/modest-tny-account-store.c:
722 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
723 the connection-specific SMTP server settings in the configuration.
725 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
727 * src/maemo/modest-main-window.c: (on_connection_changed),
729 * src/modest-main.c: (main), (start_ui), (send_mail):
730 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
731 that is what is intended.
733 * src/modest-ui-actions.c: (action_send), (action_receive),
734 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
735 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
736 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
737 SMTP server is used when it is specified.
739 (modest_ui_actions_on_send_receive):
740 Check that a connection is open before proceeding.
741 Receive and then send, instead of vice-versa, as per the specification.
743 2007-04-26 Murray Cumming <murrayc@murrayc.com>
745 * src/modest-mail-operation.c:
746 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
747 though I guess it should be something other than NULL.
749 2007-04-26 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/easysetup/modest-easysetup-wizard.c:
752 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
753 combo twice, to avoid an g_warning and to make it visible again.
754 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
755 attached before detaching it, to avoid a g_warning, and add comment about the implicit
756 (already intended) dereference when detaching, because we then recreate the menu.
757 But I am not sure why the warning was happening, and it is possible that this is a memory
760 2007-04-25 Murray Cumming <murrayc@murrayc.com>
762 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
763 and uri_parse_mailto() utility functions.
764 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
766 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
768 2007-04-24 Murray Cumming <murrayc@murrayc.com>
770 * src/dbus_api/modest-dbus-api.h:
771 * src/dbus_api/modest-dbus-callbacks.c:
772 Use an idle callback to execute the modest code in the application's own thread.
773 Remove the helloworld example method.
774 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
775 parsed, and the open-message method is not implemented because this is not yet implemented in
777 * libmodest-dbus-client/libmodest-dbus-client.c:
778 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
779 (libmodest_dbus_client_open_message):
780 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
782 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
783 body without crashing.
785 * tests/dbus_api/Makefile.am:
786 * tests/dbus_api/test_mail_to.c:
787 * tests/dbus_api/test_open_message.c: New tests for the new methods.
789 2007-04-24 Murray Cumming <murrayc@murrayc.com>
791 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
792 Added file to fix the build. Sorry.
794 * src/dbus_api/Makefile.am:
795 * src/dbus_api/modest-dbus-api.h:
796 * src/dbus_api/modest-dbus-callbacks.h:
797 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
798 (modest_dbus_req_handler):
799 Put constants in a separate header so it can be reused by the
800 client library, without duplication
802 * libmodest-dbus-client/Makefile.am:
803 * libmodest-dbus-client/libmodest-dbus-client.c:
804 (libmodest_dbus_client_call_helloworld),
805 (libmodfest_dbus_client_send_mail),
806 (libmodfest_dbus_client_mailto),
807 (libmodfest_dbus_client_open_message):
808 * libmodest-dbus-client/libmodest-dbus-client.h:
809 (Partly) Implement a send_mail D-Bus method.
811 * tests/dbus_api/Makefile.am:
812 * tests/dbus_api/test_send_mail.c: (main): Added a test for
813 the send_email D-Bus method.
815 2007-04-24 Murray Cumming <murrayc@murrayc.com>
819 * libmodest-dbus-client/Makefile.am:
820 * libmodest-dbus-client/libmodest-dbus-client.c:
821 * libmodest-dbus-client/libmodest-dbus-client.h:
822 * tests/dbus_api/Makefile.am:
823 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
824 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
826 2007-04-24 Murray Cumming <murrayc@murrayc.com>
828 * src/maemo/easysetup/modest-easysetup-wizard.c:
829 (create_page_account_details):
830 * src/maemo/modest-account-settings-dialog.c:
831 (create_page_account_details): Explicitly set auto-capitalization mode for the title
832 widgets, because this might not be the default in future versions of the Maemo GTK+.
833 However, I can not not get capitalization to work even in a simple test case.
835 2007-04-24 Murray Cumming <murrayc@murrayc.com>
837 * src/maemo/easysetup/modest-easysetup-wizard.c:
838 (create_page_custom_incoming), (create_page_custom_outgoing):
839 * src/maemo/modest-account-settings-dialog.c:
840 (create_page_account_details), (create_page_incoming),
841 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
842 instead of using gtk_check_button_with_label(), so they are aligned like the other
843 widgets, as per the UI spec.
845 2007-04-24 Murray Cumming <murrayc@murrayc.com>
847 * src/maemo/easysetup/modest-easysetup-wizard.c:
848 * src/maemo/modest-connection-specific-smtp-edit-window.c:
849 * src/widgets/modest-validating-entry.c:
850 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
851 Modest prefix instead of an EasySetup prefix.
853 2007-04-23 Murray Cumming <murrayc@murrayc.com>
855 * src/widgets/modest-validating-entry.h:
856 * src/widgets/modest-validating-entry.c: (on_insert_text),
857 Added easysetup_validating_entry_set_max_func(), used to set a callback
858 to call when the max number of characters is reached. GtkEntry has a max-length
859 already but is silent about it.
861 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
862 (create_page_account_details), (create_page_user_details),
864 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
865 (create_page_account_details), (create_page_user_details),
866 (create_page_outgoing):
867 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
868 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
869 the UI spec, when the user tries to enter more than the max number of characters.
871 2007-04-23 Murray Cumming <murrayc@murrayc.com>
873 * src/maemo/easysetup/modest-easysetup-wizard.c:
874 (create_page_user_details), (create_page_custom_incoming),
875 (create_page_custom_outgoing):
876 * src/maemo/modest-account-settings-dialog.c:
877 (create_page_user_details), (create_page_incoming),
878 (create_page_outgoing):
879 * src/maemo/modest-connection-specific-smtp-edit-window.c:
880 (modest_connection_specific_smtp_edit_window_init):
881 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
882 not appropriate. Bad Maemo-specific defaults!.
884 2007-04-23 Murray Cumming <murrayc@murrayc.com>
886 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
887 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
888 (modest_signature_editor_dialog_set_settings):
889 Disable the label and textview when the checkbox is disabled, and use the
890 specified (UI spec) default signature text.
892 2007-04-23 Murray Cumming <murrayc@murrayc.com>
894 * src/maemo/modest-connection-specific-smtp-edit-window.c:
895 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
898 * src/modest-account-mgr-helpers.h:
899 * src/modest-account-mgr-helpers.c:
900 Added modest_account_mgr_get/set_signature(), using new gconf keys.
902 * src/maemo/Makefile.am:
903 * src/maemo/modest-signature-editor-dialog.c:
904 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
907 * src/maemo/modest-account-settings-dialog.h:
908 * src/maemo/modest-account-settings-dialog.c:
909 (modest_account_settings_dialog_finalize), (on_button_signature),
910 (save_configuration): Use the new dialog when the Edit button is pressed, and
911 save the changes if necessary, as per the UI spec.
913 2007-04-23 Murray Cumming <murrayc@murrayc.com>
915 * src/maemo/Makefile.am:
916 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
917 based on maemo-develoers email from Dirk.
919 * src/maemo/easysetup/modest-easysetup-wizard.c:
920 (create_page_welcome), (create_page_account_details),
921 (create_page_user_details), (create_page_complete_easysetup),
922 (create_page_custom_incoming), (create_page_custom_outgoing),
923 (create_page_complete_custom),
924 (modest_easysetup_wizard_dialog_init):
925 * src/maemo/modest-account-settings-dialog.c:
926 (create_page_account_details), (create_page_user_details),
927 (create_page_incoming), (create_page_outgoing),
928 (modest_account_settings_dialog_init):
929 * src/maemo/modest-connection-specific-smtp-window.c:
930 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
932 2007-04-23 Murray Cumming <murrayc@murrayc.com>
934 * src/maemo/easysetup/modest-easysetup-wizard.c:
935 (create_page_account_details), (create_page_custom_outgoing),
936 (create_page_complete_custom):
937 * src/maemo/modest-account-settings-dialog.c:
938 (create_page_user_details), (create_page_incoming),
939 (create_page_outgoing):
940 * src/maemo/modest-connection-specific-smtp-edit-window.c:
941 (modest_connection_specific_smtp_edit_window_init):
942 Use the correct (UI spec) port min/max, and use horizontal separators,
945 2007-04-23 Murray Cumming <murrayc@murrayc.com>
947 * src/maemo/easysetup/modest-easysetup-wizard.c:
948 (set_default_custom_servernames):
949 * src/maemo/modest-account-settings-dialog.c:
950 (create_page_incoming), (on_combo_outgoing_security_changed),
951 (on_combo_incoming_security_changed), (create_page_outgoing),
952 (modest_account_settings_dialog_set_account_name),
953 (save_configuration):
954 * src/maemo/modest-connection-specific-smtp-edit-window.c:
955 (on_combo_security_changed),
956 (modest_connection_specific_smtp_edit_window_init),
957 (modest_connection_specific_smtp_edit_window_set_connection),
958 (modest_connection_specific_smtp_edit_window_get_settings):
959 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
962 2007-04-20 Murray Cumming <murrayc@murrayc.com>
965 * src/maemo/easysetup/modest-easysetup-wizard.c:
966 (create_page_custom_outgoing), (create_page_complete_custom):
967 * src/maemo/modest-account-settings-dialog.c:
968 (create_page_user_details), (create_page_outgoing):
969 * src/maemo/modest-account-view-window.c: (button_box_new):
970 Use changed logical IDs as per the most recent UI spec:
971 mcen_bd_emailsetup_edit -> mcen_bd_edit
972 mcen_bd_emailsetup_delete -> mcen_bd_delete
973 mcen_bd_emailsetup_close -> mcen_bd_close
975 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
979 * src/dbus_api/Makefile.am:
980 * src/dbus_api/modest-dbus-callbacks.c:
981 * src/dbus_api/modest-dbus-callbacks.h:
982 * src/maemo/modest-platform.c: (modest_platform_init):
983 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
986 * tests/dbus_api/Makefile.am:
987 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
989 2007-04-20 Murray Cumming <murrayc@murrayc.com>
991 * src/maemo/modest-account-settings-dialog.c:
992 * src/maemo/modest-connection-specific-smtp-edit-window.c:
993 Removed unnecessary includes.
995 2007-04-20 Murray Cumming <murrayc@murrayc.com>
997 * src/maemo/easysetup/modest-easysetup-wizard.c:
998 * src/maemo/modest-account-settings-dialog.c:
999 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1000 * src/widgets/Makefile.am:
1001 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1002 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1003 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1004 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1005 * src/widgets/modest-secureauth-combo-box.c:
1006 * src/widgets/modest-secureauth-combo-box.h:
1007 * src/widgets/modest-serversecurity-combo-box.c:
1008 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1009 made the GObject names more consistent with the rest of the Modest code.
1011 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1013 * src/maemo/easysetup/Makefile.am:
1014 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1015 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1016 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1017 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1018 * src/maemo/easysetup/modest-easysetup-wizard.c:
1019 * src/maemo/easysetup/modest-validating-entry.c:
1020 * src/maemo/easysetup/modest-validating-entry.h:
1021 * src/maemo/modest-account-settings-dialog.c:
1022 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1023 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1024 widgets/ because they are used outside of easysetup too. After checking in,
1025 svn will allow me to rename them too.
1027 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1029 * src/gnome/modest-msg-edit-window.c:
1030 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1031 linker error, to fix the build on the GNOME platform.
1032 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1033 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1034 ifdefed out to avoid a warning.
1036 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1038 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1039 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1040 some alternative for GTK+ 2.6.
1042 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1044 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1046 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1047 specified for EmailAccountsDialog in UI spec.
1049 * src/maemo/easysetup/modest-easysetup-wizard.c:
1050 * src/maemo/easysetup/modest-easysetup-wizard.h:
1051 * src/maemo/modest-account-settings-dialog.c:
1052 * src/maemo/modest-account-settings-dialog.h:
1053 Reuse a member window widget for the connection-specific SMTP server accounts,
1054 so we can tell it to create/save the accounts only if we actually save changes.
1056 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1057 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1058 (modest_connection_specific_smtp_edit_window_get_settings):
1059 Return a struct instance for temporarily remembering the entered data.
1061 * src/maemo/modest-connection-specific-smtp-window.h:
1062 * src/maemo/modest-connection-specific-smtp-window.c:
1063 (modest_connection_specific_smtp_window_finalize),
1064 (modest_connection_specific_smtp_window_fill_with_connections),
1066 (modest_connection_specific_smtp_window_save_server_accounts),
1067 (update_model_server_names): Do not actually save data until asked,
1068 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1070 (on_selection_changed),
1071 (modest_connection_specific_smtp_window_init): Disable the edit
1072 button when nothing is selected.
1074 * src/modest-account-mgr-helpers.c:
1075 * src/modest-account-mgr-helpers.h:
1076 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1079 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-account-mgr-helpers.h:
1082 * src/modest-account-mgr-helpers.c:
1083 (modest_account_mgr_get_unused_account_name),
1084 (modest_account_mgr_get_unused_account_display_name): Added these
1085 utility functions, to avoid code duplication.
1087 * src/maemo/easysetup/modest-easysetup-wizard.c:
1088 (create_page_account_details), (create_account):
1089 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1090 (on_combo_security_changed),
1091 (modest_connection_specific_smtp_edit_window_init),
1092 (modest_connection_specific_smtp_edit_window_save_settings):
1093 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1094 * src/maemo/modest-connection-specific-smtp-window.c:
1095 (modest_connection_specific_smtp_window_finalize),
1096 (modest_connection_specific_smtp_window_fill_with_connections),
1097 (on_button_edit), (modest_connection_specific_smtp_window_init):
1098 * src/maemo/modest-connection-specific-smtp-window.h:
1099 Implementing saving of connection-specific server accounts.
1101 But I need to refactor this so we can save the data for each
1102 possible connection-specific account and only actually create the server accounts
1103 when the easysetup finished, or the OK button is pressed on the account settings
1106 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1108 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1109 (on_combo_security_changed):
1110 (modest_connection_specific_smtp_edit_window_init):
1111 Auto-fill the port number as in the account settings.
1113 (modest_connection_specific_smtp_edit_window_set_connection):
1114 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1115 * src/maemo/modest-connection-specific-smtp-window.c:
1116 (fill_with_connections), (on_button_edit),
1117 (modest_connection_specific_smtp_window_init):
1118 Turn the edit window into a dialog to simplify the code, and
1119 set a WM hint as in a GtkDialog, because only a popup can be on top of
1120 another window in Maemo, and popups usually have no WM decoration.
1122 * src/modest-defs.h:
1123 * src/modest-account-mgr-helpers.c:
1124 (modest_account_mgr_set_connection_specific_smtp),
1125 (modest_account_mgr_remove_connection_specific_smtp),
1126 (modest_account_mgr_get_connection_specific_smtp):
1127 * src/modest-account-mgr-helpers.h: Some functions to write the
1128 connection-specific SMTP server information. Not yet used.
1131 * src/widgets/modest-folder-view.c: (text_cell_data):
1132 Fix a warning about an uninitialized variable.
1133 (on_configuration_key_changed): Put an #ifdef around the use
1134 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1136 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1138 * src/maemo/modest-account-settings-dialog.h:
1139 * src/maemo/modest-account-settings-dialog.c:
1140 Added connect_for_modified() utility function to mark the new modified boolean.
1142 (create_page_account_details), (create_page_user_details),
1143 (create_page_incoming), (create_page_outgoing), (on_response),
1144 (modest_account_settings_dialog_init),
1145 (modest_account_settings_dialog_set_account_name):
1146 Only warn about unsaved changes when there are actually unsaved changes.
1148 * src/modest-account-mgr-helpers.c:
1149 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1150 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1151 to get the data from there in future.
1153 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1155 * src/modest-defs.h:
1157 * src/modest-account-mgr-helpers.h:
1158 * src/modest-account-mgr-helpers.c:
1159 Store the security account setting in a single conf key instead of using
1160 the options list, so that the list is left for just the to-be-removed camel hack,
1161 and because gconf_client_set_list() is failing for some reason.
1163 * src/modest-account-mgr.c:
1164 (modest_account_mgr_add_server_account):
1165 * src/maemo/modest-account-settings-dialog.c:
1166 (modest_account_settings_dialog_set_account_name),
1167 (save_configuration): Use the renamed functions.
1170 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1172 * src/widgets/Makefile.am:
1173 * src/widgets/modest-limit-retrieve-combo-box.c:
1174 * src/widgets/modest-limit-retrieve-combo-box.h:
1175 * src/widgets/modest-retrieve-combo-box.c:
1176 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1177 the account settings dialog.
1179 * src/modest-defs.h:
1180 * src/modest-account-mgr-helpers.h:
1181 * src/modest-account-mgr-helpers.c:
1182 (modest_server_account_get_option_secure_auth),
1183 (modest_server_account_set_option_secure_auth):
1184 * src/modest-account-mgr.c:
1185 (modest_account_mgr_add_server_account):
1186 Use the existing AUTH_MECH conf key for the secure-auth setting,
1187 instead of putting it in the list options, because this was actually used already.
1189 * src/maemo/modest-account-settings-dialog.c:
1190 (create_page_account_details),
1191 (modest_account_settings_dialog_set_account_name),
1192 (save_configuration):
1193 * src/maemo/modest-account-settings-dialog.h:
1194 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1195 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1197 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1199 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1200 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1201 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1203 * src/modest-defs.h:
1204 * src/maemo/modest-account-settings-dialog.c:
1205 (create_page_incoming), (on_combo_outgoing_security_changed),
1206 (on_combo_incoming_security_changed), (create_page_outgoing),
1207 (modest_account_settings_dialog_set_account_name),
1208 (save_configuration): Load/Save the port number, and change it when the
1209 security combo changes, to suitable defaults.
1211 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1213 * src/modest-account-mgr.c:
1214 (modest_account_mgr_add_server_account): Set the security and secure-auth
1215 options, and add a comment saying that the other camel-specific options should be
1218 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1220 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1222 * src/modest-tny-account-store.c: (account_list_free),
1223 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1224 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1227 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1229 * src/modest-protocol-info.c:
1230 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1231 is required by our UI spec. Maybe something in our implementation will use this eventually.
1232 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1233 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1234 instead of the previous 0 placeholder.
1236 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1237 secure-auth settings.
1238 * src/modest-account-mgr-helpers.h:
1239 * src/modest-account-mgr-helpers.c:
1240 (modest_server_account_data_get_option_secure_auth),
1241 (modest_server_account_set_option_secure_auth),
1242 (modest_server_account_data_get_option_security),
1243 (modest_server_account_set_option_security): Added this API for getting and setting the security
1244 and secure-auth settings.
1246 * src/maemo/modest-account-settings-dialog.h:
1247 * src/maemo/modest-account-settings-dialog.c:
1248 (modest_account_settings_dialog_finalize), (check_data),
1249 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1250 about changing titles.
1251 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1252 (save_configuration): Save the security and secure-auth settings.
1254 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1255 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1257 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1259 * src/modest-defs.h:
1260 * src/modest-account-mgr.c:
1261 (modest_account_mgr_add_server_account):
1262 Added and used defines for the options key and value pair strings,
1263 that are used so far, though they do not seem to correspond to anything in our
1264 UI specs or ModestProtocol enum.
1266 * src/modest-account-mgr-helpers.h:
1267 * src/modest-account-mgr-helpers.c:
1268 (compare_option_strings_for_name),
1269 (modest_server_account_data_get_option_value),
1270 (modest_server_account_data_get_option_bool),
1271 (modest_account_mgr_get_server_account_option):
1272 Added helper functions for parsing the options GSList.
1274 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1276 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1277 display name is based on the supplied account name.
1278 * src/modest-account-mgr.c:
1279 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1280 with an inefficient, but good-enough, implementation.
1282 * src/maemo/easysetup/modest-easysetup-wizard.c:
1283 (create_page_account_details), (on_before_next), (create_account):
1284 Check for existing display names rather than (non-user-visible) account names, and just
1285 create and set a unique account name at the end.
1287 * src/maemo/modest-account-settings-dialog.c:
1288 (modest_account_settings_dialog_init),
1289 (modest_account_settings_dialog_set_account_name),
1290 (create_page_incoming): Show the display name, instead of the account name.
1291 (on_response): Do some (not all) extra checks, as in the UI spec.
1292 (save_configuration): Save the display name if it was changed.
1294 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1296 * po/en_GB.po: Added needed logical ID and translation.
1297 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1298 (init_view): Made the is-default column clicking work.
1300 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1303 * src/maemo/easysetup/Makefile.am:
1304 * src/maemo/easysetup/modest-easysetup-wizard.c:
1305 (modest_easysetup_wizard_dialog_init):
1306 * src/maemo/easysetup/provider-data-test.keyfile:
1307 * src/maemo/easysetup/provider-data.keyfile:
1308 Moved the provider data file to the new modest-providers-data package and used it from there.
1310 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1312 * src/modest-local-folder-info.c:
1313 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1314 N_() was already used on the static strings, but this just marks it for translation without
1315 using the translation.
1317 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1319 * src/maemo/modest-account-settings-dialog.c:
1320 (create_page_incoming),
1321 (modest_account_settings_dialog_set_account_name):
1322 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1323 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1324 I will do this if nobody else gets there first.
1326 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1328 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1329 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1330 save the security stuff.
1332 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1334 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1335 Set the email address and user fullname, which I now see must be
1338 * src/maemo/modest-account-settings-dialog.h:
1339 * src/maemo/modest-account-settings-dialog.c:
1341 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1342 leave-on-server and authentication.
1343 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1346 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1349 * src/maemo/modest-account-settings-dialog.c:
1350 * src/maemo/modest-account-settings-dialog.h:
1351 Most (but not all) of the widgets are now present as specified by the UI spec.
1352 No changes are yet saved, and some details are not properly shown yet.
1354 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1356 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1358 * src/maemo/Makefile.am:
1359 * src/maemo/modest-account-settings-dialog.c:
1360 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1361 an existing account. Doesn't do much yet.
1363 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1364 Open the accounts settings dialog when Edit is clicked.
1366 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1368 * src/maemo/easysetup/Makefile.am:
1369 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1371 * src/maemo/easysetup/modest-easysetup-wizard.c:
1372 (modest_easysetup_wizard_dialog_init):
1373 Try to get the source directory from the build system,
1374 instead of hard-coding "./" into the source code, when opening our local
1375 copies of the configuration files.
1376 But this still fails when opening the wizard from the Accounts window,
1377 maybe because the working directory seems to change at runtime.
1378 So the wizard will fail the second time unless you copy the files into their
1379 proper locations - see the stdout warnings for the paths.
1381 (create_page_account_details),(on_before_next):
1382 Check for existing non-server accounts instead of server accounts,
1383 so the default account name is useful again, and to prevent trying to
1386 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1387 Show the wizard when New is clicked.
1389 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1390 (init_view): Show the column headers, and show the columns that are
1391 specified in the UI specs. However, something in Maemo's GTK+ prevents
1392 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1393 change the default account. This is despite unsetting the special properties.
1395 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1397 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1398 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1399 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1400 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1401 to make that clearer.
1402 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1404 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1406 * src/maemo/modest-account-view-window.c:
1407 (modest_account_view_window_init),
1408 (modest_account_view_window_new):
1409 Use the same buttons as specified in the
1410 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1411 the existing widgets, which never had a chance of working.
1412 Put the ModestAccountView treeview in a scrolled window.
1413 Do not repeat the initialization in both _init() and _new().
1415 * src/widgets/modest-account-view.c: (update_account_view):
1416 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1417 this widget and window shows no accounts.
1419 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1421 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1423 * src/maemo/easysetup/modest-easysetup-wizard.c:
1424 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1425 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1426 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1429 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1430 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1431 accounts exist yet, as in the UI spec.
1433 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1435 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1437 * src/maemo/Makefile.am:
1438 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1439 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1440 New window for editing connection-specific smtp details.
1441 Not fully implemented.
1443 * src/maemo/modest-connection-specific-smtp-window.c:
1444 (modest_connection_specific_smtp_window_finalize) :
1445 unref the tree model.
1446 (on_button_edit): Show the edit window.
1448 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1450 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1453 * src/maemo/Makefile.am:
1454 * src/maemo/modest-connection-specific-smtp-window.c:
1455 * src/maemo/modest-connection-specific-smtp-window.h:
1456 New window for showing the list of connections, for connection-specific
1457 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1458 * src/maemo/easysetup/modest-easysetup-wizard.c:
1459 (create_page_custom_outgoing): Show the new window when the button is clicked.
1461 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1463 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1464 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1465 * src/maemo/modest-msg-edit-window.c:
1466 (modest_msg_edit_window_insert_image):
1467 * src/modest-conf.c: (modest_conf_key_escape):
1468 * src/modest-mail-operation.c:
1469 (modest_mail_operation_send_new_mail):
1470 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1471 (modest_ui_actions_on_new_account):
1472 * src/widgets/modest-attachment-view.c: (update_filename_request):
1473 * src/widgets/modest-mail-header-view.c:
1474 Corrected warnings that were breaking the build, by commenting out unused variables,
1475 and a function, and by including a header.
1477 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1479 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1480 so we can #ifdef around platform-specific code when necessary.
1481 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1482 to allow this to build for the GNOME platform too.
1484 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1486 * src/maemo/easysetup/modest-easysetup-wizard.c:
1487 Added util_increment_name() and used it in create_page_account_details()
1488 to make sure that the default account name is always a new name.
1490 (modest_easysetup_wizard_dialog_init),
1491 (set_default_custom_servernames): Some minor memory management fixes.
1493 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1497 * src/modest-runtime.c: (init_i18n): Restored the translation
1498 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1499 are defined in config.h, and the translations are installed.
1501 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1502 is defined for translation.
1504 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1506 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1508 * src/maemo/easysetup/modest-easysetup-wizard.c:
1509 (modest_easysetup_wizard_dialog_init):
1510 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1511 Use realistic paths (though they should use $prefix generically) to the
1512 mcc_mapping and provider-data.keyfile files which might work when they
1513 are installed by the future version of the operator-wizard package,
1514 and then fallback to paths in our source code, with an explanatory
1517 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1521 * src/maemo/Makefile.am:
1522 * src/maemo/easysetup/: Added files from the previously-exernal
1523 osso-modest-easysetup.
1524 * src/maemo/modest-main-window-ui.h:
1525 * src/modest-ui-actions.c:
1526 * src/modest-ui-actions.h:
1527 Added modest_ui_actions_on_new_account() as a signal handler for the
1528 New Account menu item. It shows the easysetup wizard.
1529 * po/en_GB.po: Added additional needed logical IDs and translations.
1531 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1532 Apparently ChangeLog is not used for some vague Nokia legal reasons.