1 2007-06-14 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c:
4 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
5 address" info in banner instead of node, and select all the text as
6 per UI spec. This fixes projects.maemo.org bug NB#60550.
8 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
10 reviewed by: <delete if not using a buddy>
12 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
13 * src/modest-ui-actions.c: (folder_refreshed_cb):
15 2007-06-14 Murray Cumming <murrayc@murrayc.com>
17 * src/widgets/modest-folder-view.c: (filter_row):
18 Explictly filter out the per-account outbox accounts. I don't know why
19 these only sometimes show up, but now they should never show up in the UI.
20 This should fix projects.maemo.org bug NB#60160.
22 2007-06-14 Murray Cumming <murrayc@murrayc.com>
24 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
25 when the toolbar does not exist yet.
26 * src/modest-widget-memory.c: (save_settings_header_view):
27 Added g_warnings() to help us to discover when we are trying to set
28 an empty columns list in gconf.
30 2007-06-14 Murray Cumming <murrayc@murrayc.com>
34 Added modest_init_get_default_header_view_column_ids().
36 * src/modest-widget-memory.c: (restore_settings_header_view):
37 Use the new function to get defaults, if the gconf key is empty,
38 instead of not creating any columns. This seems to fix the
39 empty right-hand pane problems.
41 * src/widgets/modest-header-view.h: Improved documentation.
43 2007-06-13 Murray Cumming <murrayc@murrayc.com>
45 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
46 Revert the use of the display name as the account name, because this
47 is generally wrong and would break the code that follows.
49 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
51 * src/maemo/easysetup/modest-easysetup-wizard.c:
52 (check_for_supported_auth_methods), (on_before_next),
55 More correct fix for projects.maemo.org bug NB# 58991
56 Do not longer accept AUTH_PASSWORD as secure method and choose
57 correct method when creating the account.
59 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
61 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
62 Fixed projects.maemo.org bug NB# 58991
64 2007-06-13 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-init.c: (modest_init_init_core),
67 (modest_init_local_folders): Fixed compilation errors.
69 2007-06-13 Murray Cumming <murrayc@murrayc.com>
71 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
72 Remove unnecessary lib/include, though it is good in principle when needed.
74 * src/modest-init.c: (modest_init_one_local_folder),
75 (modest_init_local_folders):
76 * src/modest-init.h: Initialize the .modest library for memory cards,
77 instead of just doing nothing for them. This should allow us to create
78 folders there, fixing projects.maemo.org bug NB#59297.
80 2007-06-13 Murray Cumming <murrayc@murrayc.com>
82 * libmodest-dbus-client/libmodest-dbus-client.c:
83 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
84 (libmodest_dbus_client_compose_mail),
85 (libmodest_dbus_client_open_message),
86 (libmodest_dbus_client_send_and_receive),
87 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
89 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
90 (on_idle_open_message), (modest_dbus_req_handler),
91 (search_result_to_message), (modest_dbus_req_filter):
92 * src/modest-search.c: (add_hit), (modest_search_folder),
93 (modest_search_all_accounts): Improved debug messages.
95 * tests/dbus_api/test_open_message.c: (main): Improved comments.
97 * src/modest-tny-account-store.c:
98 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
101 2007-06-13 Murray Cumming <murrayc@murrayc.com>
104 2007-06-12 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-tny-account-store.c: (get_server_accounts):
107 Call modest_tny_local_folders_account_add_merged_outbox_folders()
108 even when there are no accounts, so that the Outbox folder is always
109 visible. This fixes projects.maemo.org bug NB#60158.
111 2007-06-12 Murray Cumming <murrayc@murrayc.com>
113 * src/maemo/modest-main-window.c: (create_details_widget):
114 Use the mcen_va_never logical ID.
116 2007-06-12 Murray Cumming <murrayc@murrayc.com>
118 * src/dbus_api/modest-dbus-api.h:
119 * src/dbus_api/modest-dbus-callbacks.c:
120 (on_idle_open_default_inbox), (on_open_default_inbox),
121 (modest_dbus_req_handler):
122 Added a new OpenDefaultInbox method.
124 * libmodest-dbus-client/libmodest-dbus-client.h:
125 * libmodest-dbus-client/libmodest-dbus-client.c:
126 Added libmodest_dbus_client_open_default_inbox() to call the new
127 dbus method. This should be useful to projects.maemo.org bug NB#57214,
128 though it should maybe be used by a new osso-email-interface function.
130 * tests/dbus_api/Makefile.am:
131 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
134 2007-06-12 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
137 NULL, so that the signals get all the keys. This should not actually
138 change any behaviour because we currently update everything when anything
141 2007-06-12 Murray Cumming <murrayc@murrayc.com>
143 * src/widgets/modest-folder-view.c: (text_cell_data),
144 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
145 (find_inbox_iter): If tinymail tells us that the folder is
146 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
147 This causes the inbox to be selected at startup, fixing part of
148 projects.maemo.org bug NB#56305.
150 * src/modest-ui-dimming-rules.c:
151 (modest_ui_dimming_rules_on_tools_smtp_servers):
152 * src/modest-ui-dimming-rules.h: Added a callback function to dim
153 the SMTP servers menu item.
154 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
155 that the SMTP Servers menu item is dimmed when there are no accounts,
156 as a future version of the UI spec will require. This fixes
157 projects.maemo.org bug NB#56305.
159 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
161 * src/maemo/modest-maemo-utils.c:
162 (modest_maemo_utils_get_supported_secure_authentication_methods):
163 Added label to dialog instead of unreadable title
165 * src/maemo/modest-main-window.c: (sync_accounts_cb),
166 (modest_main_window_new):
167 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
170 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
171 * src/modest-account-mgr.h:
172 Added method to avoid code duplication
174 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
175 (modest_ui_actions_on_send_receive):
176 Use modest_account_mgr_has_accounts
178 2007-06-11 Murray Cumming <murrayc@murrayc.com>
180 * src/maemo/easysetup/modest-presets.c:
181 (modest_presets_get_info_server_security): Do not report secure auth
183 * src/modest-protocol-info.c: Use the defines for the gconf key names
184 for secure authentication. This was not working because we were writing
185 Password and reading password, and the check was case sensitive.
186 With this, gmail now works for receiving and sending when created via
189 2007-06-11 Murray Cumming <murrayc@murrayc.com>
191 * src/maemo/easysetup/modest-presets.c:
192 (modest_presets_get_info_server_security): Correct the key name for
193 SecureSmtp, because it seems to be case-sensitive.
194 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
195 Do not try to get the 0th notebook page if there are 0 pages, to
198 2007-06-11 Murray Cumming <murrayc@murrayc.com>
200 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
201 Prevent use of the new notification feature for now, because it currently
202 shows one dialog for each new email, which is annoying.
204 2007-06-11 Murray Cumming <murrayc@murrayc.com>
206 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
207 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
208 when no country was selected, so that we show the global ones.
209 * src/maemo/easysetup/modest-presets.c:
210 (modest_presets_get_providers): Return only the global providers, not
211 all providers when mmc=0 was requested.
213 2007-06-11 Murray Cumming <murrayc@murrayc.com>
215 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
216 (easysetup_provider_combo_box_fill): Remove debug code that showed the
217 provider ID in the combo.
219 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
220 Do not show the page numbers, because it would be confusing when we add
221 the 2 extra pages for the custom setup, when the user chooses the "Other"
222 provider. This fixes projects.maemo.org bug NB#59028
224 * src/modest-init.c: (modest_init_init_core),
225 (modest_init_local_folders):
227 * src/modest-tny-account.c:
228 (modest_tny_account_new_for_local_folders): Do not create default folders
229 for the memory card. This should fix projects.maemo.org bug NB#59328.
231 2007-06-11 Murray Cumming <murrayc@murrayc.com>
233 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
234 Free the changed_conf_keys string items. They are already freed in the
235 idle handler if that runs first.
237 2007-06-11 Murray Cumming <murrayc@murrayc.com>
239 * src/modest-ui-actions.c:
240 (modest_ui_actions_on_password_requested): Check that the server name
241 is not NULL, because I just saw a password dialog with (null) as the
244 * src/modest-tny-folder.[h|c]: Added
245 modest_tny_folder_is_memory_card_folder().
246 * src/modest-ui-dimming-rules.c:
247 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
248 menu item for memory cards, as per the UI spec (section 7.4). This should
249 fix projects.maemo.org bug NB#59297.
251 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
253 * src/maemo/modest-main-window.c: (sync_accounts_cb):
254 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
255 is another problem with the code, see Murray's comment at line 772)
257 2007-06-08 Murray Cumming <murrayc@murrayc.com>
259 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
260 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
261 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
262 (load_from_file), (easysetup_country_combo_box_init),
263 (easysetup_country_combo_box_get_active_country_ids),
264 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
265 instead of just one ID, to avoid duplicate country names in the UI.
267 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
268 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
269 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
270 a single ID, avoiding duplicate providers.
271 * src/maemo/easysetup/modest-easysetup-wizard.c:
272 (on_combo_account_country): Adapt to use a list.
274 2007-06-08 Murray Cumming <murrayc@murrayc.com>
276 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
277 keys changed in the last X seconds.
279 * src/modest-account-mgr.h:
280 * src/modest-account-mgr.c: (on_timeout_notify_changes),
281 (on_key_change), (modest_account_mgr_class_init),
282 (modest_account_mgr_init), (modest_account_mgr_finalize):
283 As the keys are changed, save them in a GSList* and signal that GSList*
284 further every X seconds, to batch changes, to allow us to do just one
285 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
286 bug NB#56941 and other (UI-blocking) delays when changing account settings.
288 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
289 changed signal signature.
291 * src/modest-conf.c: (modest_conf_set_list),
292 (modest_conf_on_change): Reenable notification.
294 (modest_conf_maemo_fake_on_change): Comment out the hack that
295 notified immediately instead of asynchronously.
297 * src/widgets/modest-account-view.h:
298 * src/widgets/modest-account-view.c:
299 (update_account_view): Select the previously-selected account ID,
300 if possible. This fixes projects.maemo.org bug NB#56933.
302 (on_account_changed), (on_account_removed),
303 (modest_account_view_select_account):
305 Remove the block/unblock functions
306 because they were not useful.
308 * src/maemo/modest-account-view-window.c:
309 (on_delete_button_clicked), (on_edit_button_clicked),
310 (on_new_button_clicked): Remove the use of the non-working block/unblock.
312 2007-06-08 Murray Cumming <murrayc@murrayc.com>
314 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
315 Improve the error dialog to show Incorrect Account Settings, which seems
316 clearer, and say that the internal error message (to be removed from the
317 dialog later) is often misleading.
318 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
320 * src/modest-tny-account.c:
321 (modest_tny_account_new_from_server_account): Uncomment the printf of the
322 URL because this is so useful for debugging on the device.
324 * src/widgets/modest-serversecurity-combo-box.c:
325 (modest_serversecurity_combo_box_fill): Correct a logical ID.
327 2007-06-08 Murray Cumming <murrayc@murrayc.com>
329 * src/modest-mail-operation.c:
330 (modest_mail_operation_send_new_mail):
331 Added a comment about a nasty but apparently harmless message. Details
332 added to the wiki g_warnings() page.
334 2007-06-08 Murray Cumming <murrayc@murrayc.com>
336 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
337 (modest_tny_send_queue_class_init):
338 Do not use the priv struct because it is empty, to avoid g_warnings
339 about a non-existant priv struct.
341 * src/modest-tny-account-store.c:
342 (modest_tny_account_store_get_server_account),
343 (modest_tny_account_store_get_transport_account_for_open_connection
344 ): Do not try to get transport server accounts for local folders,
345 because they don't have any. This avoids a g_warning().
347 * src/maemo/modest-main-window.c:
348 (modest_main_window_notify_send_receive_initied),
349 (on_configuration_key_changed):
350 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
352 * src/modest-mail-operation.c:
353 (modest_mail_operation_update_account):
354 * src/modest-tny-account-store.h:
355 * src/modest-tny-account.c:
356 (modest_tny_account_get_special_folder),
357 (modest_tny_account_new_for_local_folders),
358 (modest_tny_account_new_for_per_account_local_outbox_folder):
359 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
360 * src/modest-tny-local-folders-account.c:
361 (add_account_folders_to_merged_folder):
362 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
363 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
364 (modest_ui_actions_on_send):
365 * src/widgets/modest-folder-view.c: (update_model):
366 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
367 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
368 modest_tny_account_store_get_tny_account_by_account() to
369 modest_tny_account_store_get_server_account() to make the code clearer.
371 2007-06-07 Marcus Bauer <marcusb@openismus.com>
373 * src/dbus_api/modest-dbus-api.h:
374 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
375 * src/maemo/modest-msg-edit-window.c:
376 (modest_msg_edit_window_attach_file_noninteractive):
377 added g_warning in case the file to be attached does not exist
378 * tests/dbus_api/test_compose_mail.c: (main):
379 removed obsolete comment, added generic files as test case
381 2007-06-07 Murray Cumming <murrayc@murrayc.com>
383 * src/modest-tny-account-store.c: (get_server_accounts):
384 Create the local folders account only once, not once for each outbox, and
385 not only when there are some outboxes.
387 2007-06-07 Murray Cumming <murrayc@murrayc.com>
389 * src/widgets/modest-folder-view.c: (update_model): Comment out some
390 code that is causing a crash at startup. Sergio says that he is fixing this.
392 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
394 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
395 * src/maemo/modest-account-settings-dialog.c:
396 (create_page_outgoing),
397 (modest_account_settings_dialog_set_account_name),
398 (save_configuration):
399 - Fixed handling of the "Use secure authentication" toggle to comply with
400 the ui specification. See also projects.maemo.org bug NB#58400
402 - Restore the Secure connection setting combo correctly when loading
405 * src/maemo/modest-maemo-utils.c:
406 (on_camel_account_get_supported_secure_authentication),
407 (modest_maemo_utils_get_supported_secure_authentication_methods):
408 Fixed a crasher if operation is canceled
410 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
411 (modest_protocol_info_auth_is_secure):
412 * src/modest-protocol-info.h:
414 Added two new methods to determine if a protocol/auth method is secure/encrypted in
415 the sense of the "Use secure authentication" toggle.
417 2007-06-07 Murray Cumming <murrayc@murrayc.com>
419 * src/modest-tny-account-store.h:
420 * src/modest-tny-account-store.c:
421 Added modest_tny_account_store_get_local_folders_account().
423 * src/modest-tny-folder.h:
424 * src/modest-tny-folder.c:
425 (modest_tny_folder_get_account):
426 Added this replacement for tny_folder_get_account() which returns
427 the local-folders account for TnyMergeFolders, to avoid the
428 warning about the unimplemented get_account_func() vfunc().
430 (modest_tny_folder_get_rules),
431 * src/modest-ui-actions.c:
432 (modest_ui_actions_on_folder_selection_changed):
433 * src/modest-mail-operation.c:
434 (modest_mail_operation_remove_folder),
435 (modest_mail_operation_xfer_folder),
436 (modest_mail_operation_rename_folder),
437 (modest_mail_operation_get_msg),
438 (modest_mail_operation_get_msgs_full),
439 (modest_mail_operation_remove_msg),
440 (modest_mail_operation_xfer_msgs),
441 (modest_mail_operation_refresh_folder):
442 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
444 2007-06-07 Murray Cumming <murrayc@murrayc.com>
446 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
447 (modest_server_account_set_security):
448 * src/modest-defs.h: Add comments explaining that our
449 UI spec means TLS when it says Normal, so these do not look like errors.
451 * src/modest-tny-account.c:
452 (modest_tny_account_new_from_server_account): Use the new tinymail
453 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
454 for TLS. This should fix projects.maemo.org bug NB#58460.
456 2007-06-06 Murray Cumming <murrayc@murrayc.com>
458 * src/maemo/easysetup/modest-easysetup-wizard.c:
459 (create_account): Correct the position of the gconf sanity check warning.
460 (on_button_edit_advanced_settings): Show the dialog immediately, instead
461 of using the g_idle_add() hack, because this does not seem to be necessary
462 on osso 1.1. It might even work on Maemo Bora if the problems were actually
463 caused by something other than maemo's gconf.
464 This fixes projects.maemo.org bug #59022.
466 2007-06-06 Murray Cumming <murrayc@murrayc.com>
468 * src/modest-account-mgr-helpers.c:
469 (modest_account_mgr_get_default_account): Do not check that the account
470 exists if there is no default account (NULL), to fix a runtime warning.
472 2007-06-06 Murray Cumming <murrayc@murrayc.com>
474 * src/widgets/modest-folder-view.c: (update_model):
475 Do not unref the treemodel before we have finished with it.
476 This prevents a valgrind warning and an occasional crash at startup.
478 2007-06-06 Marcus Bauer <marcusb@openismus.com>
480 * libmodest-dbus-client/libmodest-dbus-client.h:
481 added libmodest_dbus_client_compose_mail()
482 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
484 added functions needed for SendAsMail() functionality
485 * src/maemo/modest-msg-edit-window.c:
486 (modest_msg_edit_window_attach_file_noninteractive):
487 non interactively attaching files to message edit window
488 * src/widgets/modest-msg-edit-window.h:
489 * tests/dbus_api/Makefile.am:
490 added test_compose_mail.c
491 * tests/dbus_api/test_compose_mail.c: (main):
493 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
495 * src/modest-account-view.c:
496 Fixed bug projects.maemo.org bug NB#59307
498 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
500 * src/maemo/easysetup/modest-easysetup-wizard.c:
501 (get_serverport_incoming), (on_before_next), (create_account):
502 * src/maemo/modest-account-settings-dialog.c:
503 (modest_account_settings_dialog_set_account_name):
504 * src/maemo/modest-maemo-utils.c:
505 (on_camel_account_get_supported_secure_authentication_status),
506 (on_camel_account_get_supported_secure_authentication),
507 (on_secure_auth_cancel),
508 (modest_maemo_utils_get_supported_secure_authentication_methods):
510 Implemented security authentication for settings and easysetup.
512 2007-06-05 Murray Cumming <murrayc@murrayc.com>
514 * src/maemo/modest-main-window.c: (create_details_widget):
515 Show the total size for memory card accounts too, instead of showing
516 the name again. Fixes bug projects.maemo.org bug NB#59307.
518 2007-06-05 Murray Cumming <murrayc@murrayc.com>
521 * src/modest-tny-simple-folder-store.c:
522 * src/modest-tny-simple-folder-store.h: Removed.
524 * src/modest-tny-local-folders-account.h
525 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
526 for the local-folders maildir, with an extra TnyMergedFolder containing
527 the folders of the per-account outbox store accounts.
528 * src/modest-tny-account-store.c: (get_server_accounts):
529 Add the outboxes to the special local folders account after creating it.
531 * src/modest-tny-account.c:
532 (modest_tny_account_new_for_local_folders): Create the derived
533 account when creating the main local-folders account.
535 * src/maemo/modest-main-window.c: (create_details_widget),
536 (modest_main_window_set_contents_style):
537 Adapted to the use of the derived account instead of the folder store.
539 * src/modest-ui-actions.c:
540 (modest_ui_actions_on_folder_selection_changed):
541 * src/modest-ui-dimming-rules.c:
542 (modest_ui_dimming_rules_on_new_folder):
543 * src/widgets/modest-folder-view.c: (text_cell_data),
544 (icon_cell_data), (filter_row), (update_model),
545 (get_cmp_rows_type_pos):
548 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
549 Do not get the priv struct, because no priv struct has been set,
550 to avoid a runtime warning.
552 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
553 #ifelse with #else, to fix a warning, to fix the build.
556 2007-06-05 Christian Kellner <ckellner@openismus.com>
558 * libmodest-dbus-client/libmodest-dbus-client.c:
559 Fix small typo in doc (why do you always see them
560 AFTER committing stuff?)
563 2007-06-05 Christian Kellner <ckellner@openismus.com>
565 * libmodest-dbus-client/libmodest-dbus-client.c:
566 (libmodest_dbus_client_search):
567 Initialize hit list with NULL. Also set folder list
568 to "" if NULL was supplied.
571 2007-06-03 Christian Kellner <ckellner@openismus.com>
573 * libmodest-dbus-client/libmodest-dbus-client.c:
574 (modest_search_hit_list_free):
575 Make it save to call it with NULL.
577 * src/dbus_api/modest-dbus-callbacks.c:
578 * src/modest-search.c:
579 Return full ModestSearchHits as the search result list not TnyHeader
580 since can't be around withouth the correspoding TnyFolder.
582 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
584 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
585 Added currently commented code to check for secure auth
587 * src/maemo/modest-account-settings-dialog.c: (on_response),
588 (save_configuration), (show_ok):
589 Fixed projects.maemo.org bugs NB #59248 and #59251
591 * src/maemo/modest-maemo-utils.c:
592 (on_camel_account_get_supported_secure_authentication_status),
593 (on_camel_account_get_supported_secure_authentication),
594 (modest_maemo_utils_get_supported_secure_authentication_methods):
595 * src/maemo/modest-maemo-utils.h:
596 Moved get_supported_secure_authentication() method here to be able
597 to use it from easysetup wizard.
599 * src/modest-pair.c: (on_pair_compare_as_string):
600 Should compare string with first part of pair and not
601 strcmp pairs which will crash.
603 * src/modest-protocol-info.c:
604 (modest_protocol_info_protocol_is_store):
605 * src/modest-protocol-info.h:
606 Added modest_protocol_info_get_auth_protocol_name()
608 2007-06-03 Armin Burgmeier <armin@openismus.com>
610 * src/modest-mail-operation.c:
611 (modest_mail_operation_get_msgs_full): Set priv->account also when
612 only retrieving a single message. This avoids a crash when canceling
615 (modest_mail_operation_notify_end): Do not explicitely remove the
616 operation from the queue but only emit the progress_changed signal.
617 The queue itself listens to that signal to remove the operation when
618 it is finished. This reduces coupling and removes a potential deadlock
619 when modest_mail_operation_notify_end() is called from the queue
620 itself. If that is a problem performance-wise, I would suggest to
621 implement a status-changed signal or something.
623 * src/modest-mail-operation-queue.c: Make sure to never call a
624 function from another file while the queue is locked. This (hopefully)
625 fixes another deadlock when exiting the application while retrieving
628 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
630 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
631 Fixed build if libogs is not available
633 2007-06-03 Christian Kellner <ckellner@openismus.com>
635 * libmodest-dbus-client/libmodest-dbus-client.h:
636 * libmodest-dbus-client/libmodest-dbus-client.c:
637 (libmodest_dbus_client_delete_message):
638 Implement deletion of messages (Client side).
640 (modest_search_hit_free),
641 (modest_search_hit_list_free):
642 Utility functions to free the result hits.
644 * src/dbus_api/modest-dbus-api.h:
645 * src/dbus_api/modest-dbus-callbacks.c:
647 (modest_dbus_req_handler):
648 Implement deletion of messages (Server side).
650 * tests/dbus_api/test_search.c: (main):
653 * tests/dbus_api/Makefile.am:
654 * tests/dbus_api/test_delete_message:
655 Add little test for the message deletion logic
657 2007-06-03 Armin Burgmeier <armin@openismus.com>
659 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
660 when the operation queue was not empty. projects.maemo.org bug
663 2007-06-03 Armin Burgmeier <armin@openismus.com>
665 * src/widgets/modest-account-view.c
666 (on_account_default_toggled): Toggle default account column
667 explicitely instead of waiting for gconf notification (which is
668 currently ignored). This should fix projects.maemo.org bug NB#56910
669 for now. It should probably be removed when gconf notifications are
672 2007-06-03 Christian Kellner <ckellner@openismus.com>
674 * libmodest-dbus-client/libmodest-dbus-client.c:
675 Removed debugging spew.
677 * src/dbus_api/modest-dbus-callbacks.c:
678 Added debugging info.
680 * src/modest-search.c:
681 (modest_search_all_accounts):
682 Use tny_account_store_get_accounts () on the account store
683 to get all accounts which is the way to get all accounts.
685 * tests/dbus_api/test_search.c: (main):
686 Make it possible to supply the search term on the command line.
688 2007-06-03 Christian Kellner <ckellner@openismus.com>
690 * libmodest-dbus-client/libmodest-dbus-client.c:
691 * libmodest-dbus-client/libmodest-dbus-client.h:
692 Implement searching for mesages over raw dbus. (Client side)
694 * src/dbus_api/Makefile.am:
695 * src/dbus_api/modest-dbus-api.h:
696 * src/dbus_api/modest-dbus-callbacks.c:
697 * src/dbus_api/modest-dbus-callbacks.h:
698 Search framework (Server side). Also implement on_idle_open_message().
700 * src/maemo/modest-platform.c: (modest_platform_init):
701 Prepare for raw dbus/osso rpc interaction.
703 * src/modest-search.h:
704 Changed minsize from unspecific guint to guint32.
706 * src/modest-search.c:
708 Added strange hack which magically made tnymail work.
710 (modest_search_folder),
711 (modest_search_account),
712 (modest_search_all_accounts):
713 Implement helper functions to search all accounts, specific account
716 * tests/dbus_api/Makefile.am:
717 * tests/dbus_api/test_open_message.c:
718 Read url to open from commandline.
720 * tests/dbus_api/test_search.c:
721 Implement small test for dbus search stuff
723 2007-06-02 Armin Burgmeier <armin@openismus.com>
725 * src/maemo/modest-account-settings-dialog.c: Changed window title to
726 include account type and account title. This fixes projects.maemo.org
729 * src/maemo/modest-account-view-window.c: Set a title for the window.
731 2007-06-02 Armin Burgmeier <armin@openismus.com>
733 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
734 incoming and outgoing server name based on email address and server
735 types as long as the names have not been edited manually. This fixes
736 projects.maemo.org bug NB#58671.
738 2007-06-02 Armin Burgmeier <armin@openismus.com>
740 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
741 server type cannot be changed in future to the incoming details page
742 when creating an account. This fixes projects.maemo.org bug NB#59029.
744 2007-06-02 Armin Burgmeier <armin@openismus.com>
746 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
747 and assigned max width chars so that they wrap instead of being
748 truncated. Fixes projects.maemo.org bug NB#56126.
750 2007-06-02 Armin Burgmeier <armin@openismus.com>
752 * src/maemo/modest-connection-specific-smtp-window.c: Add an
753 introductory note to the connection specific smtp servers dialog, as
754 section 8.12 of the email UI specification requires. This fixes
755 projects.maemo.org bug NB#59212.
757 2007-06-01 Murray Cumming <murrayc@murrayc.com>
759 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
760 Check for running mail operations, and offer to cancel them, as per the UI
761 spec. This fixes projects.maemo.org bug NB#59041 .
762 However, I suspect that tinymail may still use the network connection
763 in ways that we cannot detect or cancel. But it should at least adapt to
766 2007-06-01 Murray Cumming <murrayc@murrayc.com>
768 * src/modest-tny-account-store.c: (recreate_all_accounts),
769 (get_cached_accounts), (get_server_accounts): Do more sensible
770 ref-counting of the temporarily-cached outbox accounts list. This seems
771 to fix a crash when entering the password when the password was wrong.
773 2007-06-01 Murray Cumming <murrayc@murrayc.com>
775 * src/gnome/modest-main-window.c: (connect_signals):
776 * src/modest-tny-account-store.c: (get_password),
777 (modest_tny_account_store_alert): Added comments and clues and
778 commented-out code about how we currently fail to deal with connection
779 errors and wrong passwords, and how we should.
781 2007-06-01 Murray Cumming <murrayc@murrayc.com>
783 * src/widgets/modest-retrieve-combo-box.c:
784 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
785 This fixes projects.maemo.org bug NB#58472 .
787 2007-06-01 Murray Cumming <murrayc@murrayc.com>
789 * src/maemo/easysetup/modest-easysetup-wizard.c:
790 (create_page_complete_easysetup):
791 (create_page_complete_custom): Correct the last commit,
792 putting the correct sentences in the correct pages.
794 2007-06-01 Murray Cumming <murrayc@murrayc.com>
796 * src/maemo/easysetup/modest-easysetup-wizard.c:
797 (create_page_complete_custom): Show the second sentence of text
798 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
801 2007-06-01 Murray Cumming <murrayc@murrayc.com>
803 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
804 Set the leave-on-server conf key by default. This fixes
805 projects.maemo.org bug NB#59258 .
807 2007-06-01 Murray Cumming <murrayc@murrayc.com>
809 * src/maemo/modest-account-view-window.c:
810 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
811 logical ID for the confirmation messages. Fixed projects.maemo.org bug
814 2007-06-01 Murray Cumming <murrayc@murrayc.com>
816 * src/maemo/easysetup/modest-easysetup-wizard.c:
817 (create_caption_new_with_asterisk):
818 * src/maemo/modest-account-settings-dialog.c:
819 (create_caption_new_with_asterisk):
820 Uncomment the code to add the asterisk, because they are no longer in the
821 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
822 (update_incoming_server_title): Add an asterisk here too.
824 2007-06-01 Murray Cumming <murrayc@murrayc.com>
826 * src/maemo/modest-maemo-global-settings-dialog.c:
827 (current_connection): Check that we are even connected before trying to
828 get the current connection name, to prevent a warning.
830 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
831 Change the comments because tny_maemo_conic_device_connect() is now meant to
833 * src/modest-mail-operation.c:
834 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
835 make sure we have a connection and fail if we can't connect.
837 2007-05-31 Murray Cumming <murrayc@murrayc.com>
839 * src/maemo/modest-main-window.c:
840 (on_account_store_connecting_finished): Do not try to get the
841 connection ID if we are not really connected. I am surprised that
842 this signal handler is called when we are not connected.
844 2007-05-31 Murray Cumming <murrayc@murrayc.com>
846 * src/modest-error.h:
847 * src/modest-ui-actions.c:
848 (modest_ui_actions_get_msgs_full_error_handler):
849 Renamed an enum, added comments, added an enum
850 for retrieve-limit errors.
852 * src/modest-mail-operation.c: (foreach_add_item),
853 (internal_folder_observer_update), (update_account_thread),
854 (modest_mail_operation_get_msgs_full):
855 (modest_mail_operation_update_account),
856 Added comments about how this works, and some code that should
857 (but does not) check the retrieve-limit. See the TODO comment.
859 2007-05-31 Murray Cumming <murrayc@murrayc.com>
861 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
862 Initialize help_id to fix the build. Warnings are good.
864 2007-05-31 Murray Cumming <murrayc@murrayc.com>
866 * src/widgets/modest-hbox-cell-renderer.c:
867 (modest_hbox_cell_renderer_append):
868 * src/widgets/modest-vbox-cell-renderer.c:
869 (modest_vbox_cell_renderer_append):
870 Fix the last commit by doing an extra ref.
872 2007-05-31 Murray Cumming <murrayc@murrayc.com>
874 * src/widgets/modest-hbox-cell-renderer.c:
875 (modest_hbox_cell_renderer_append):
876 * src/widgets/modest-vbox-cell-renderer.c:
877 (modest_vbox_cell_renderer_append):
878 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
879 to fix the build with Maemo Bora.
880 However, there seems to be a remaining crash, probably due to reference
883 2007-05-30 Murray Cumming <murrayc@murrayc.com>
885 * src/modest-tny-account.c:
886 (modest_tny_account_new_for_local_folders):
887 Use hildon_file_system_info_async_new() to get a better name for
888 the memory card account, setting it as the account name.
889 The timing seems to work, but this is probably
890 not the best place to do this. See the TODO comment.
891 * src/maemo/modest-main-window.c: (create_details_widget):
892 * src/widgets/modest-folder-view.c: (text_cell_data):
893 Use the tny account name instead of hardcoding a name.
895 2007-05-30 Christian Kellner <ckellner@openismus.com>
897 * src/modest-search.c: (modest_search):
898 Correctly set part_search_func even if we have already parsed
899 the query and thus a valid OgsTextSearcher object.
901 2007-05-30 Christian Kellner <ckellner@openismus.com>
904 Search and check for libogs.
907 Incooparte the ogs build env.
909 * src/modest-mime-part-search-stream.c:
910 * src/modest-mime-part-search-stream.h:
911 Removed since we do the real searching now in modest-search.c.
913 * src/modest-search.c:
914 * src/modest-search.h:
915 Implement support for ogs. We use that if available and requested
916 and fall back to modest_text_utils_utf8_strcmp (). The search logic
917 should now handle the corner case when the search term is spread
918 across multiple reads.
919 Also the logic in modest_search () was corrected to search all
920 requested fields until one is found.
922 2007-05-30 Murray Cumming <murrayc@murrayc.com>
924 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
927 * src/modest-init.c: Made modest_init_local_folders() take a
928 path and be public so we can iniitialize maildir folders on
931 * src/modest-local-folder-info.h:
932 * src/modest-local-folder-info.c:
933 (modest_local_folder_info_get_maildir_path): Add a path parameter.
935 * src/modest-tny-account.c:
936 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
937 still means the standard local-folders path on the local volume.
939 * src/modest-tny-account-store.c:
940 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
941 signal so we can detect mount/unmount of the MMC1 card, and do an update of
942 all accounts when that happens.
943 (get_server_accounts): If the MMC1 card is mounted, create a store account for
944 this too, so it shows up in the treeview.
946 2007-05-28 Murray Cumming <murrayc@murrayc.com>
948 * src/maemo/modest-maemo-global-settings-dialog.c:
949 (current_connection):
950 * src/widgets/modest-global-settings-dialog.c:
951 (current_connection_default):
952 Use the enum values instead of 0, 1 and -1,
953 to make the code clearer.
955 * src/modest-account-mgr-helpers.c:
956 (modest_account_mgr_get_connection_specific_smtp): Make this code
959 * src/modest-runtime.h:
960 * src/modest-runtime.c:
961 Added modest_runtime_remove_all_send_queues().
962 * src/maemo/modest-main-window.c:
963 (on_account_store_connecting_finished): Recreate the send queues,
964 using the appropriate transport accounts for this new connection.
965 Some futher adapting might be needed if the old send queues are not
966 automatically stopped at this point.
968 * src/modest-tny-account-store.c: (get_server_accounts):
969 Create the connection-specific transport accounts, so that they can
970 be found later by their ID.
972 * src/modest-tny-account.h:
973 * src/modest-tny-account.c:
974 Added modest_tny_account_new_from_server_account_name().
975 modest_tny_account_new_from_server_account(): Do not create the
976 send queues here, because they will be
977 recreated anyway when the connection changes for the first time.
979 2007-05-28 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-local-folder-info.h:
982 * src/modest-local-folder-info.c:
983 (modest_per_account_local_outbox_folder_info_get_maildir_path),
984 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
985 tbox_folder): Take a modest account name instead of a server TnyAccount,
986 so we can have per-modest-account rather than per-transport-account
988 We must make sure that we change or recreate the exisitng send queues
989 when the connection changes for connection-specific transport accounts.
991 * src/modest-tny-account-store.c:
992 (create_per_account_local_outbox_folders): Create outboxed per modest
993 account, not per transport account.
995 * src/modest-tny-account.h:
996 * src/modest-tny-account.c:
997 (modest_tny_account_get_special_folder): For outboxes, get the
998 parent modest account name. The account is ignored for other folders.
999 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1000 modest account name rather than a server TnyAccount.
1002 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1004 * src/modest-tny-account.c:
1005 (modest_tny_account_new_from_server_account):
1006 Call modest_runtime_get_send_queue() immediately after creating transport
1007 accounts, so that they start trying to send email from the outbox as soon
1008 as possible at startup. This is probably what we want.
1010 * src/modest-mail-operation.c: (update_account_thread):
1011 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1012 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1013 * src/modest-tny-send-queue.h:
1014 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1015 (modest_ui_actions_on_send):
1016 Added comments about how sending works, though it needs some more work.
1018 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1020 * src/modest-tny-account.c:
1021 (modest_tny_account_get_special_folder): Add TODO because this fails when
1022 the network is busy.
1023 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1024 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1025 Do not try to show this window when there is no active account. The UI
1026 specs does not tell us what to do in this case.
1028 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1032 * src/maemo/Makefile.am:
1033 * src/widgets/Makefile.am: Some dist fixes.
1035 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1037 * src/maemo/modest-connection-specific-smtp-window.c:
1038 (on_button_edit): Make the code clearer, to prevent a double free.
1040 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1042 * src/maemo/modest-account-settings-dialog.c:
1043 (modest_account_settings_dialog_set_account_name),
1044 Check the connection-specific smtp servers checkbox if there are any.
1046 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1047 (modest_connection_specific_smtp_edit_window_init):
1048 Start with a suitable port number.
1050 * src/modest-account-mgr-helpers.h:
1051 * src/modest-account-mgr-helpers.c: Added
1052 modest_account_mgr_get_has_connection_specific_smtp().
1054 (modest_account_mgr_set_connection_specific_smtp),
1055 (modest_account_mgr_remove_connection_specific_smtp),
1056 (modest_account_mgr_get_has_connection_specific_smtp),
1057 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1058 connection-specific smtp server accounts in the account, rather than
1059 the server account conf dir.
1061 This fixes bug projects.maemo.org bug NB#58263 .
1063 * src/modest-tny-account-store.c:
1064 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1065 if there are no server accounts yet, to prevent an infinite loop when there
1066 are no accounts. Document that one must be called before the other.
1068 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1070 * src/modest-account-mgr-helpers.c:
1071 (modest_account_mgr_get_default_account): Make sure that at least
1072 one account is always the default, if there are any enabled accounts.
1073 This is just a sanity check that shouldn't be necessary.
1075 * src/modest-account-mgr-priv.c:
1076 (_modest_account_mgr_account_from_key): Unescape the conf key to
1077 get the real account name. For instance, this is an issue if a space
1078 was in the account name, which can happen because the account name
1079 is generated from the display name.
1080 (_modest_account_mgr_get_account_keyname): Always escape the
1082 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1083 Unescape the conf keys to get the real account names.
1085 For instance, previously the is-default radio button in the accounts
1086 list was not checked for any accounts at first. This fixes that,
1087 and might fix several similar bugs.
1089 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1091 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1092 Removed some debug printfs.
1094 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1096 Modest on-disk outbox directories are now here, for instance:
1097 $HOME/.modest/outboxes/<account-id-1>/outbox
1098 $HOME/.modest/outboxes/<account-id-2>/outbox
1100 $HOME/.modest/local-folders/outbox
1101 so we can have a separate outbox for each account.
1102 But they are shown as one outbox in the GtkTreeView, by using a
1103 TnyMergeFolder in a ModestTnySimpleFolderStore.
1106 * src/modest-tny-simple-folder-store.c:
1107 * src/modest-tny-simple-folder-store.h:
1108 Added ModestTnySimpleFolderStore, used to contain folders from
1109 other folder stores, such as other accounts.
1111 * src/modest-tny-outbox-account.h:
1112 * src/modest-tny-outbox-account.c:
1113 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1114 used for the per-account local outbox folders.
1116 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1117 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1118 only use this (internally) now for the non-outbox local folders.
1120 * src/modest-init.h:
1121 * src/modest-init.c: Added modest_init_one_local_folder(), for
1122 setting up the directory structure for each local folder.
1124 * src/modest-local-folder-info.c:
1125 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1126 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1128 * src/modest-local-folder-info.h:
1129 * src/modest-tny-account-store.c: (on_account_removed),
1130 (on_account_changed), (create_per_account_local_outbox_folders),
1131 (get_server_accounts), (modest_tny_account_store_get_accounts),
1132 (modest_tny_account_store_get_tny_account_by_account),
1133 (modest_tny_folder_store_is_virtual_local_folders):
1135 * src/modest-tny-account.h:
1136 * src/modest-tny-account.c:
1137 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1138 to create an on-disk per-account local outbox folder for each
1140 (create_per_account_local_outbox_folders): Create a local outbox folder
1141 for each transport account.
1142 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1143 for all local folders.
1145 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1146 instead of using g_object_get/set() directly. It is clearer.
1148 (modest_tny_folder_store_get_message_count),
1149 (modest_tny_folder_store_get_local_size
1150 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1151 because we now use these with non-acount folder stores.
1153 (modest_tny_account_get_special_folder),
1154 (modest_tny_account_new_from_server_account),
1155 (modest_tny_account_new_from_account):
1156 (recurse_folders): Adjust to the new outbox system.
1158 * src/modest-tny-folder.h:
1159 * src/modest-tny-folder.c:
1160 (modest_tny_folder_is_local_folder),
1161 (modest_tny_folder_get_local_folder_type),
1162 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1164 * src/widgets/modest-main-window.h:
1165 * src/maemo/modest-main-window.c: (create_details_widget),
1166 (modest_main_window_set_contents_style): Show details for any folder store,
1169 (modest_tny_folder_get_rules):
1170 Remove the const. C does not support constness enough for this.
1172 * src/modest-ui-actions.c:
1173 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1174 make all outboxes appear as one, in the usual local-folders tree node.
1176 (set_active_account_from_tny_account),
1177 (modest_ui_actions_on_folder_selection_changed):
1178 * src/widgets/modest-folder-view.c: (text_cell_data),
1179 (icon_cell_data), (filter_row),
1180 (add_account_folders_to_merged_folder),
1181 (add_account_folders_to_simple_folder_store), (),
1182 (get_cmp_rows_type_pos), (cmp_rows),
1183 (modest_folder_view_set_account_id_of_visible_server_account):
1184 Adjust to the new outbox system, using generic folder stores and folders
1185 in the GtkTreeModel.
1187 2007-05-23 Christian Kellner <ckellner@openismus.com>
1189 * src/modest-mail-operation.c:
1190 (modest_mail_operation_update_account):
1191 Use info->max_size instead of unintialized local var [small
1192 build fix]. (Added TODO to review that change since I don't
1195 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1197 * libmodest-dbus-client/libmodest-dbus-client.c:
1198 (libmodest_dbus_client_compose_mail): function added
1199 * src/dbus_api/modest-dbus-api.h:
1200 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1201 (on_compose_mail): Implementation of the SendAsMail functionality
1203 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1205 * src/modest-account-mgr.c:
1206 (modest_account_mgr_add_server_account): Set the secure-connection
1207 conf key for transport accounts as well as store accounts. I don't know
1208 why the if was there. For instance, this makes sure that we use SSL
1209 for the gmail preset from the easysetup wizard.
1211 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1213 * src/gnome/modest-main-window.c:
1214 (on_account_store_connecting_finished), (connect_signals):
1215 * src/maemo/modest-main-window.c:
1216 (on_account_store_connecting_finished), (connect_signals),
1217 (modest_main_window_new):
1218 Handle TnyAccountStore::connecting-finished instead of
1219 TnyDevice::connection-changed, because we cannot actually perform
1220 operations on accounts until TnyAccountStore has itself responded to
1221 the TnyDevice::connection-changed signal. This prevents a GError from
1223 Do not try to update at startup, because we (at least on scratchbox)
1224 already do an update at startup when the device goes online.
1225 This prevents a GError from tinymail.
1226 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1227 Added TODO about stopping simultaneous operations.
1229 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1231 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1232 * src/modest-mail-operation-queue.c:
1233 (modest_mail_operation_queue_remove):
1234 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1235 about where they happened.
1237 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1239 * src/modest-ui-actions.c:
1240 (modest_ui_actions_on_password_requested): Make sure that the remember
1241 output parameter is always TRUE.
1243 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1245 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1246 Show a OK/Cancel dialog if the error is a question, though we still do not
1247 know anything more about what we are asking the user.
1248 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1249 Fix an uninitialized variable (helper). This is a logic error, however.
1251 2007-05-21 Christian Kellner <ckellner@openismus.com>
1253 * src/modest-search.h:
1254 Correct bit shifting in the ModestSearchFlags enum.
1256 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1258 * src/modest-tny-account.c:
1259 (modest_tny_account_new_from_server_account): Do not use the lsub and
1260 check-all hard-coded IMAP options when using POP.
1262 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1264 * src/modest-tny-account.c:
1265 (modest_tny_account_new_from_server_account):
1266 Use NULL for the secure-auth method for POP when Password auth has been
1267 specified by the user, as we already do for IMAP. "auth=Login" causes
1268 an error from camel or the server.
1270 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1272 * src/maemo/modest-account-settings-dialog.c:
1273 (create_page_account_details),
1274 (modest_account_settings_dialog_set_account_name):
1275 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1276 for the leave-on-server checkbox, rathr than just the checkbox, when
1277 the protocol is not POP.
1279 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1281 * src/widgets/modest-account-view.c:
1282 * src/widgets/modest-account-view.h:
1283 Added modest_account_view_select_account() which will be useful later
1284 to asynchronously re-select the edited account.
1286 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1288 * src/maemo/modest-account-settings-dialog.c:
1289 (modest_account_settings_dialog_set_account_name):
1290 Automatically choose the port numbers based on the secure authentication
1291 methods, if they have not been chosen before.
1292 This fixes projects.maemo.org bug NB#56273 .
1294 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1296 * src/maemo/modest-main-window-ui.h:
1297 * src/modest-ui-actions.c:
1298 * src/modest-ui-actions.h:
1299 Connect the Tools/SMTP Servers menu item to
1300 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1301 SMTP servers dialog, as in the UI specification and saves changes when it
1302 is closed. This fixed projects.maemo.org bug NB#56305 .
1304 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1306 * src/maemo/modest-connection-specific-smtp-window.c:
1307 (modest_connection_specific_smtp_window_init):
1308 Use gtk_window_set_default_size() to make this window big enough, so
1309 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1311 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1313 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1314 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1315 (modest_connection_specific_smtp_edit_window_init),
1316 Do not try to connect to a combobox signal before the combobox exists.
1317 This fixes the cras in projects.maemo.org bug NB#56288 .
1318 (modest_connection_specific_smtp_edit_window_get_settings):
1319 Remove the server_account_name parameter which was being checked for NULL
1320 though it was not used.
1322 * src/maemo/modest-connection-specific-smtp-window.c:
1323 (modest_connection_specific_smtp_window_fill_with_connections),
1324 (on_button_edit), (modest_connection_specific_smtp_window_init):
1325 Correct the number of treemodel columns to prevent a warning.
1326 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1327 libconic does not work.
1329 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1331 * src/modest-tny-account.c:
1332 (modest_tny_account_new_from_server_account):
1333 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1334 SMTP when "None" was chosen by the user. However, with my SMTP server that
1335 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1338 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1340 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1341 to explain the memory management issue with the ID in the ModestPair.
1343 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1344 (add_sending_page), (modest_account_assistant_finalize):
1345 * src/gnome/modest-gnome-global-settings-dialog.c:
1346 (create_updating_page), (create_composing_page):
1347 * src/gnome/modest-msg-edit-window.c: (get_transports),
1348 (init_window), (modest_msg_edit_window_finalize),
1349 (modest_msg_edit_window_get_msg_data):
1350 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1351 * src/gnome/modest-transport-widget.c:
1352 (modest_transport_widget_finalize), (smtp_configuration):
1353 * src/maemo/modest-maemo-global-settings-dialog.c:
1354 (create_updating_page), (create_composing_page):
1355 * src/maemo/modest-msg-edit-window.c: (get_transports),
1356 (init_window), (modest_msg_edit_window_finalize),
1357 (modest_msg_edit_window_get_msg_data),
1358 (modest_msg_edit_window_free_msg_data):
1359 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1360 (modest_store_widget_finalize):
1361 * src/maemo/modest-transport-widget.c:
1362 (modest_transport_widget_finalize), (smtp_configuration):
1363 * src/modest-main.c: (send_mail):
1364 * src/widgets/modest-combo-box.h:
1365 * src/widgets/modest-global-settings-dialog-priv.h:
1366 * src/widgets/modest-global-settings-dialog.c:
1367 (modest_global_settings_dialog_finalize):
1368 * src/widgets/modest-msg-edit-window.h:
1369 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1370 as long as the combo box, to prevent use of freed memory for the ID.
1372 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1374 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1375 get_accounts(), to make this clearer. Do not check for the enabled gconf
1376 key, because we do not use this for server accounts (at least, not yet).
1377 This allows us to send email again.
1379 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1381 * src/maemo/modest-platform.c:
1382 (on_modest_conf_update_interval_changed), (modest_platform_init):
1383 Only respond to this particular key change. All these strcmp()s cannot be
1386 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1388 * src/maemo/modest-maemo-global-settings-dialog.c:
1389 (current_connection): Prevent a crash in scratchbox when
1390 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1391 * src/maemo/modest-platform.c:
1392 (on_modest_conf_update_interval_changed), (modest_platform_init):
1393 Get the update interval from gconf and reset it when the gconf key changes.
1395 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1397 * src/modest-protocol-info.c:
1398 * src/modest-protocol-info.h: Adde enum-specific get functions,
1399 instead of using a ModestProtocolType enum parameter.
1401 * src/gnome/modest-account-assistant.c:
1402 * src/gnome/modest-store-widget.c:
1403 * src/gnome/modest-store-widget.h:
1404 * src/gnome/modest-transport-widget.c:
1405 * src/gnome/modest-transport-widget.h:
1406 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1407 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1408 * src/maemo/easysetup/modest-easysetup-wizard.c:
1409 * src/maemo/modest-account-settings-dialog.c:
1410 * src/maemo/modest-account-settings-dialog.h:
1411 * src/maemo/modest-store-widget.c:
1412 * src/maemo/modest-store-widget.h:
1413 * src/maemo/modest-transport-widget.c:
1414 * src/maemo/modest-transport-widget.h:
1415 * src/modest-account-mgr-helpers.c:
1416 * src/modest-account-mgr-helpers.h:
1417 * src/modest-account-mgr.c:
1418 * src/modest-account-mgr.h:
1419 * src/modest-tny-account.c:
1420 * src/modest-tny-folder.c:
1421 * src/widgets/modest-account-view.c:
1422 * src/widgets/modest-retrieve-combo-box.c:
1423 * src/widgets/modest-retrieve-combo-box.h:
1424 * src/widgets/modest-secureauth-combo-box.c:
1425 * src/widgets/modest-serversecurity-combo-box.c:
1426 * src/widgets/modest-serversecurity-combo-box.h:
1427 * tests/check_account-mgr.c:
1428 Use the specific functions, and use the re-renamed enum values for GNOME too.
1430 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1432 * src/modest-pair.h:
1433 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1434 so we can get the second based on the first.
1436 * src/maemo/modest-account-settings-dialog.h:
1437 * src/maemo/modest-account-settings-dialog.c:
1438 Added get_supported_secure_authentication_methods(), though it is mostly
1439 commented-out for now until the necessary API is committed to tinymail.
1440 (modest_account_settings_dialog_set_account_name),
1441 (save_configuration): Request the supported authentication methods from the
1442 server, so we can choose a working method.
1444 * src/modest-tny-account-store.h:
1445 * src/modest-tny-account-store.c:
1446 (modest_tny_account_store_get_session): Rename from
1447 tny_account_store_get_session().
1449 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1451 * src/modest-protocol-info.h: Split the ModestProtocol enum
1452 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1453 There was no need to have these unrelated values in one enum.
1455 * src/: many files: Adapted to changed enum. This makes the code a bit
1456 clearer, and the compiler could catch some errors.
1458 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1460 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1461 Show the detailed internal camel error message when an error happens
1462 during the configuration, so that our testers can give us more clues.
1463 For instance, in projects.maemo.org bug NB#56910 .
1465 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1467 * src/modest-tny-account.c:
1468 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1469 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1471 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1473 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1474 * src/maemo/modest-account-settings-dialog.c:
1475 (modest_account_settings_dialog_set_account_name),
1476 (save_configuration): For the incoming secure authentication checkbox,
1477 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1478 the UI specification. PLAIN does not seem to be supported for most IMAP
1479 servers anyway, and I am not sure what it would mean.
1480 However, we probably need to discover which of the secure-authentication
1481 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1482 * src/modest-account-mgr-helpers.c:
1483 (modest_account_mgr_get_server_account_data):
1485 * src/modest-tny-account.c:
1486 (modest_tny_account_new_from_server_account):
1487 Use tny_account_set_mech() to set secure-authentication methods,
1488 with some special-casing for IMAP, based on my observations of how
1491 * src/modest-account-mgr-helpers.h:
1492 * src/modest-account-mgr.c:
1493 * src/modest-defs.h: Comment that the URI is only used for local folders.
1495 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1497 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1498 parameter const, just to be neat.
1499 * src/modest-text-utils.c: (modest_text_utils_inline):
1500 End g_strconcat() with NULL, as its documentation says. This is almost
1501 certainly the cause of my crash at startup on the device. Interestingly,
1502 valgrind doesn't tell us about these errors.
1504 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1506 * scripts/build-packages: Added more precise comments about how to use
1507 this script, though I still get this error:
1508 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1509 error building tinymail
1511 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1513 * src/maemo/modest-main-window.c: (on_account_update):
1514 Very slight cleanup, hoping to make it simpler to discover what causes
1515 a crash here sometimes.
1517 * src/modest-tny-account.c:
1518 (modest_tny_account_new_from_server_account): Set the port. Added
1519 comments about the options and a TODO comment because I need to find out
1520 how to specify the secure authentication method.
1522 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1524 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1525 changed CFlags paths form modest to libmodest
1527 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1529 * src/modest-account-mgr-helpers.c:
1530 (modest_account_mgr_get_server_account_data),
1531 (modest_account_mgr_free_server_account_data):
1532 * src/modest-account-mgr-helpers.h:
1533 * src/modest-account-mgr.c:
1534 (modest_account_mgr_add_server_account):
1535 * src/modest-defs.h:
1536 * src/modest-tny-account.c:
1537 (modest_tny_account_new_from_server_account):
1538 Determine the options for tny_camel_account_add_option() here,
1539 based on the settings, rather than storing them directly in gconf.
1541 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1543 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1544 Show a more friendly error dialog now that we expect (from the tinymail
1545 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1547 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1549 * src/maemo/modest-main-window.c: (on_account_update): Check that
1550 account_name is not NULL, to prevent a crash at startup that I am
1551 seeing on the N800. I do wonder why it is NULL.
1553 * src/maemo/easysetup/modest-easysetup-wizard.c:
1554 (create_page_user_details):
1555 * src/maemo/modest-account-settings-dialog.c:
1556 (create_page_user_details), (create_page_outgoing):
1557 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1558 (modest_connection_specific_smtp_edit_window_init):
1559 * src/modest-ui-actions.c:
1560 (modest_ui_actions_on_password_requested):
1561 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1562 might do something useful with the on-screen keyboard.
1564 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1566 * src/maemo/modest-main-window.c: (on_account_update):
1567 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1568 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1570 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1572 * src/modest-tny-account-store.c: (on_account_changed):
1573 Correct the signature of this signal handler.
1575 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1577 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1578 Show a HildonNote instead of a GtkDialog for Maemo.
1580 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1582 * src/widgets/modest-account-view.h:
1583 * src/widgets/modest-account-view.c: (on_account_changed),
1584 (on_account_removed). Added a boolean flag, set/unset by
1585 modest_account_view_block_conf_updates(),
1586 modest_account_view_unblock_conf_updates() to prevent unnecessary
1587 updates, but this is not very useful because the gconf notifications are
1588 so delays (maybe only on Maemo Bora).
1589 So auto-updating is turned off, and these functions do an explicit
1590 update when necessary.
1591 However, something else is still doing too much work when adding/removing
1592 accounts, probably in another part of the application.
1594 * src/maemo/modest-account-view-window.c:
1595 (on_delete_button_clicked), (on_edit_button_clicked),
1596 (on_new_button_clicked): Use the new functions.
1598 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1600 * src/modest-account-mgr-helpers.c:
1601 (modest_account_mgr_set_first_account_as_default):
1602 Sort the list of names alphabetically-by-title, so we choose the first one
1604 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1605 alphabetically by the title.
1607 This fixes projects.maemo.org bug NB#56418 .
1609 * src/modest-account-mgr-priv.c:
1610 (_modest_account_mgr_account_from_key):
1611 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1612 avoid a valgrind error, and possible random behaviour.
1614 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1616 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1617 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1618 tinymail documentation to say that this can be expected.
1619 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1620 pretty, and should not happen, but I would prefer to know when it does.
1622 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1624 * configure.ac: When using the older hildon version, probably on Bora,
1625 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1627 * src/widgets/modest-attachment-view.c:
1628 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1631 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1633 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1634 Implemented the prototype. Can be tested with
1635 tests/dbus_api/test_open_message:
1637 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1639 * src/modest-tny-account-store.c:
1640 (modest_tny_account_store_instance_init), (get_password):
1641 * src/modest-ui-actions.c:
1642 (modest_ui_actions_on_password_requested):
1643 Do not store the password in gconf, because this function is called
1644 for non-remembered passwords. Actually use the cached (in the hash map)
1645 password instead of releasing it.
1646 The password will now not be remembered if it is asked via the protected
1647 password dialog, as per the UI spec.
1649 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1651 * src/modest-defs.h:
1652 * src/modest-account-mgr-helpers.h:
1653 * src/modest-account-mgr-helpers.c:
1654 Added modest_server_account_get_username_has_succeeded(),
1655 modest_server_account_set_username_has_succeeded().
1656 (modest_server_account_set_username),
1657 Reset the has-succeeded flag if the username changes.
1659 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1660 * src/maemo/modest-connection-specific-smtp-window.c:
1661 (modest_connection_specific_smtp_window_save_server_accounts):
1662 Use modest_server_account_set_username() instead of using
1663 modest_conf_set_string() directly, so that the has-succeeded flag is always
1666 * src/modest-ui-actions.c:
1667 (modest_ui_actions_on_password_requested): Dim the username entry if
1668 the username has ever worked, as per the UI spec.
1670 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1672 * src/modest-tny-account-store.c: (get_password):
1673 * src/modest-ui-actions.c:
1674 (modest_ui_actions_on_password_requested):
1675 Allow the username to be changed too, though there is more work to
1676 be done on exactly how this behaves.
1678 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1680 * src/modest-account-mgr-helpers.h:
1681 * src/modest-account-mgr-helpers.c:
1682 Added modest_account_mgr_get_display_name(),
1683 modest_server_account_get_username(),
1684 modest_server_account_set_username(),
1685 modest_server_account_set_password(),
1686 modest_server_account_get_hostname() functions so we do not need to
1687 use the conf API directly.
1689 * src/maemo/modest-main-window.c: (connect_signals):
1690 Actually connect ot the ModestAccountStore::request-password signal,
1691 so that we show the dialog when the password is requested by Tinymail,
1692 for isntance if it is empty.
1694 * src/modest-marshal.list:
1695 * src/modest-tny-account-store.c:
1696 (modest_tny_account_store_class_init), (get_password),
1697 (modest_tny_account_store_alert):
1698 * src/modest-tny-account-store.h:
1699 * src/modest-ui-actions.h:
1700 * src/modest-ui-actions.c:
1701 (modest_ui_actions_on_password_requested):
1702 Change the signal parameters, so it is obvious that we are providing
1703 the non human-readable server name, and receiving both the username
1704 and password, though changing of the username is not yet implemented.
1705 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1706 for the GNOME version.
1708 This should fix the projects.maemo.org bug NB#56209, though it does not
1709 work on Bora, because the gconf_client_get() for the password fails
1710 immediately after we save it with gconf_client_set().
1712 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1715 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1716 caused an undefined symbol error:
1717 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1719 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1721 * src/modest-tny-account-store.c:
1722 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1723 using a GError instead of a string message, so we can translate it in
1726 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1728 * src/maemo/modest-address-book.c:
1729 (modest_address_book_check_names):
1730 * src/maemo/modest-msg-view-window.c:
1731 (modest_msg_view_window_clipboard_owner_change):
1732 * src/modest-init.c: (modest_init_init_ui):
1733 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1734 (update_folders_cb), (modest_mail_operation_update_account):
1735 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1736 (modest_ui_actions_on_msg_attachment_clicked),
1737 (modest_ui_actions_on_msg_recpt_activated):
1738 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1739 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1740 (modest_msg_view_search_next):
1741 * src/widgets/modest-recpt-editor.c:
1742 (modest_recpt_editor_on_button_release_event),
1743 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1744 g_message(). At this point we should only be seeing interesting errors on
1745 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1747 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1749 (modest_wizard_dialog_force_title_update):
1750 * src/maemo/easysetup/modest-wizard-dialog.h:
1751 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1752 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1753 can update the title when appropriate. Otherwise the title is wrong if the
1754 pages are added after adding the notebook to the dialog.
1755 This must be a problem in HildonWizardDialog too.
1756 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1758 * src/maemo/easysetup/modest-easysetup-wizard.c:
1759 (create_subsequent_customsetup_pages),
1760 (create_subsequent_easysetup_pages):
1761 Call modest_wizard_dialog_force_title_update() so that the title is
1762 correct even with GTK+ < 2.10.
1763 This fixes projects.maemo.org bug NB#56145 .
1765 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1767 * src/maemo/modest-platform.c:
1768 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1769 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1772 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1774 * src/widgets/modest-window.h:
1775 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1776 and modest_window_save_state(), which invokes it.
1778 * src/widgets/modest-window-mgr.h:
1779 * src/widgets/modest-window-mgr.c:
1780 Added modest_window_mgr_save_state_for_all_windows(), which calls
1781 the save_state vfunc on all registered windows, if implemented.
1783 * src/gnome/modest-msg-edit-window.c:
1784 * src/gnome/modest-msg-view-window.c:
1785 * src/maemo/modest-msg-edit-window.c:
1786 * src/maemo/modest-msg-view-window.c:
1787 * src/maemo/modest-main-window.c:
1788 Specify the existing save_settings functions as implementations of
1789 ModestWindow::save_state_func().
1791 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1792 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1793 enabling hibernation, for instance.
1795 We may need to do the same thing for restoring settings.
1798 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1800 * src/widgets/modest-window-mgr.c:
1801 * src/widgets/modest-window-mgr.h:
1802 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1803 modest_window_mgr_get_hibernation_is_prevented().
1805 * src/maemo/modest-main-window.c:
1806 (on_hildon_program_is_topmost_notify): Prevent hibernation
1807 (possible when the application goes to the background in the WM),
1808 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1810 * src/maemo/easysetup/modest-easysetup-wizard.c:
1811 (modest_easysetup_wizard_dialog_init):
1812 * src/maemo/modest-account-settings-dialog.c:
1813 (modest_account_settings_dialog_init):
1814 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1815 (modest_connection_specific_smtp_edit_window_init):
1816 * src/maemo/modest-connection-specific-smtp-window.c:
1817 (modest_connection_specific_smtp_window_init):
1818 * src/maemo/modest-signature-editor-dialog.c:
1819 (modest_signature_editor_dialog_init):
1820 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1821 prevent hibernation while any of these account settings dialogs are open.
1823 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1825 * src/maemo/Makefile.am:
1826 * src/maemo/modest-osso-state-saving.c:
1827 * src/maemo/modest-osso-state-saving.h: Added
1828 modest_osso_load_state() and modest_osso_save_state() though they do
1829 nothing now. They should iterate through all the open windows and load/save
1831 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1832 save state when closing.
1834 * src/maemo/modest-main-window.c:
1835 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1836 Add a notification handler for the HildonProgram::is-topmost property,
1837 so we can allow hibernation when the application goes into the background.
1838 But we still need to detect when the accounts setup windows are open so
1839 we can stop hibernation when they are open.
1840 To do this, I also added the main window the HildonProgram. This might have
1841 other side-effects/benefits, and should maybe be done for other windows.
1843 * src/maemo/modest-osso-autosave-callbacks.h:
1844 * src/maemo/modest-osso-autosave-callbacks.c:
1845 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1846 though it does not do anything yet, and we might never need this to do
1847 anything. For instance, we already save drafts.
1849 * src/maemo/modest-platform.c: (modest_platform_init):
1850 Specify the libosso auto-save callback.
1852 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1854 * src/maemo/modest-platform.c:
1855 (modest_platform_set_update_interval):
1856 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1857 aparently stays valid between application instances, so we can use this
1858 to remove and reset it later. According to a maemo-developers email from
1861 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1863 * configure.ac: Depend on libalarm for Maemo.
1865 * src/dbus_api/modest-dbus-api.h:
1866 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1867 (on_send_receive), (modest_dbus_req_handler):
1868 Handle a SEND_RECEIVE D-Bus method.
1870 * libmodest-dbus-client/libmodest-dbus-client.c:
1871 (libmodest_dbus_client_send_and_receive):
1872 * libmodest-dbus-client/libmodest-dbus-client.h:
1873 Add C convenience functions for calling the new D-Bus method.
1875 * src/modest-platform.h:
1876 * src/gnome/modest-platform.c:
1877 * src/maemo/modest-platform.c:
1878 Added modest_platform_set_update_interval(), which uses the
1879 alarmd API on Maemo.
1880 (modest_platform_init),
1881 Call modest_platform_set_update_interval(), using a hard-coded
1882 interval for now (until the global settings dialog is implemented),
1883 though I am not sure that this makes sense yet.
1885 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1887 * src/dbus_api/modest-dbus-callbacks.c:
1888 (modest_osso_cb_hw_state_handler):
1889 * src/dbus_api/modest-dbus-callbacks.h:
1890 * src/maemo/modest-platform.c: (modest_platform_init):
1891 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1892 in case this has some effect on the ability for Maemo to ping the
1895 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1897 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1898 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1899 warning. It is probably a logic error, but I need to fix the build.
1901 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1903 * src/modest-account-mgr.h:
1904 * src/modest-account-mgr.c:
1905 (modest_account_mgr_account_names): Add a gboolean enabled_only
1906 parameter, so we can get lists of onlt the enabled accounts.
1908 (modest_account_mgr_add_account),,
1909 (modest_account_mgr_account_with_display_name_exists):
1910 * src/maemo/modest-msg-edit-window.c: (get_transports):
1911 * src/modest-account-mgr-helpers.c:
1912 (modest_account_mgr_set_first_account_as_default):
1913 * src/modest-init.c: (init_default_account_maybe):
1914 * src/modest-tny-account-store.c: (get_accounts):
1915 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1916 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1917 * tests/check_account-mgr.c: (START_TEST):
1918 Provide the extra parameter, as appropriate.
1920 * src/widgets/modest-account-view.c: (update_account_view):
1921 Do not show disabled accounts (meaning that there is no way to
1922 enable/disable accounts in the UI (the feature is not in our UI
1923 specification), so we can use this internally only to mark unfinished
1924 or temporary account data.
1926 * src/maemo/easysetup/modest-easysetup-wizard.c:
1927 (create_account): Add boolean enable parameter, so we can specify FALSE
1928 to create the temporary account.
1929 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1930 (on_before_next): When finishing, when there is a temporary account, just
1932 Also, use a timeout to delay the showing of the dialog until gconf is likely
1933 to return correct information, due to a maemo gconf bug that is fixed in
1934 osso 1.1, but not yet in Bora.
1935 However, the dialog stays on screen after it is destroyed.
1937 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1938 for invalid data when cancelling. Use a hildon note instead of a dialog
1939 to complain about invalid data. Do not show the account-saved note if the
1940 account is disabled (a temporary account that will not really be saved for use
1943 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1945 * src/modest-account-mgr-helpers.h:
1946 * src/modest-account-mgr-helpers.c:
1947 Added modest_account_mgr_unset_default_account(),
1948 Added modest_account_mgr_set_first_account_as_default().
1950 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1951 If it was the default account, unset the default account name.
1953 * src/maemo/modest-account-view-window.c:
1954 (on_delete_button_clicked): If it was the default account,
1955 set the first remaining account as the default instead.
1957 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1958 a NULL account or a NULL default account, to prevent a crash. This should
1959 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1962 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1964 * src/widgets/modest-recpt-editor.c:
1965 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1966 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1967 TODO comment for this. This fixes the build.
1969 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1970 be the best place for it. This will in future update all auto-update accounts,
1971 rather than just the current/default account, when that gconf key exists.
1972 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1973 if there are no accounts, before calling do_send_receive().
1974 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1976 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1977 * src/maemo/modest-main-window-ui.h:
1978 * src/maemo/modest-main-window.c: (on_connection_changed),
1979 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1980 directly, becaue the signal handler does more.
1982 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1984 * src/modest-account-mgr-helpers.c:
1985 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1986 for the case that the account does not exist.
1988 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1989 (equivalent to the modest account name) rather than the tinymail account name
1990 (equivalent to the modest account title - human readable) to get the account data.
1991 Check for null account data to prevent the crash, and add a TODO comment saying that
1992 this needs fixing because it is using the server account name instead of the account name.
1994 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1996 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1997 * src/maemo/modest-account-settings-dialog.c: (show_error),
1999 Use hildon_note_new_information() for informative and error messages,
2000 which seems to be expected for Maemo applications (no documentation that I know of
2001 says this). I am surprised that there is no distinction between info and error
2004 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2006 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2007 it is easy to find where this is used.
2009 * src/maemo/easysetup/modest-easysetup-wizard.c:
2010 (create_page_welcome), (create_page_account_details),
2011 (create_page_user_details), (create_page_complete_easysetup),
2012 (create_page_custom_incoming), (create_page_custom_outgoing),
2013 (create_page_complete_custom):
2014 * src/maemo/modest-account-settings-dialog.c:
2015 (create_page_account_details), (create_page_user_details),
2016 (create_page_incoming), (create_page_outgoing):
2017 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2018 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2019 (modest_connection_specific_smtp_edit_window_init):
2020 * src/maemo/modest-connection-specific-smtp-window.c:
2021 (modest_connection_specific_smtp_window_init):
2022 * src/maemo/modest-signature-editor-dialog.c:
2023 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2024 and scrolling policy as per the Email Application Layout Guide, if I have
2027 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2029 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2030 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2031 which were empty, because these vfuncs have been removed from TnyAccountStore.
2032 This fixes the build.
2034 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2036 * src/maemo/modest-main-window.c:
2037 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2038 showing/hiding it. Added TODO because it probably should not be NULL.
2039 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2040 because unnecessary g_warnings() make degugging difficult.
2042 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2044 * src/maemo/modest-msg-edit-window.c:
2045 (modest_msg_edit_window_select_color),
2046 (modest_msg_edit_window_select_background_color): 2 const corrections and
2047 moving 2 #endifs before closing brackets, to fix the build.
2049 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2051 * src/maemo/easysetup/modest-easysetup-wizard.h:
2052 * src/maemo/easysetup/modest-easysetup-wizard.c:
2053 (modest_easysetup_wizard_dialog_finalize),
2054 (on_button_edit_advanced_settings), (create_page_complete_custom),
2055 (on_response), (create_account):
2056 Implement the Advanced Settings edit button, by saving the account information,
2057 for the Advanded Settings dialog to use directly from gconf, and removing it
2058 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2059 Bug #5533 in the projects.maemo.org bugzilla.
2061 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2063 * src/maemo/modest-msg-view-window.c:
2064 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2065 when opening a message window.
2067 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2069 * src/maemo/easysetup/modest-easysetup-wizard.c:
2070 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2073 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2074 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2075 gconf settings. I probably added more checks than necessary, but that is safer.
2077 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2078 variable to fix the build, but this seems to be used when it is still NULL.
2080 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2082 * src/modest-platform.h:
2083 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2084 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2085 * src/modest-main.c: Implement this function so we can avoid using
2086 maemo-specific API from cross-platform code.
2088 * src/modest-tny-account-store.c:
2089 (get_smtp_specific_transport_account_for_open_connection):
2090 * src/modest-ui-actions.c: (check_for_connection),
2091 (modest_ui_actions_on_item_not_found):
2092 Use modest_platform_connect_and_wait() and put #idefs around other
2093 maemo-specific code, because only maemo currently has a way to
2094 identify connection names.
2096 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2098 * src/modest-tny-account-store.h:
2099 * src/modest-tny-account-store.c:
2100 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2101 the connection-specific SMTP server settings in the configuration.
2103 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2105 * src/maemo/modest-main-window.c: (on_connection_changed),
2107 * src/modest-main.c: (main), (start_ui), (send_mail):
2108 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2109 that is what is intended.
2111 * src/modest-ui-actions.c: (action_send), (action_receive),
2112 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2113 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2114 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2115 SMTP server is used when it is specified.
2117 (modest_ui_actions_on_send_receive):
2118 Check that a connection is open before proceeding.
2119 Receive and then send, instead of vice-versa, as per the specification.
2121 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2123 * src/modest-mail-operation.c:
2124 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2125 though I guess it should be something other than NULL.
2127 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2129 * src/maemo/easysetup/modest-easysetup-wizard.c:
2130 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2131 combo twice, to avoid an g_warning and to make it visible again.
2132 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2133 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2134 (already intended) dereference when detaching, because we then recreate the menu.
2135 But I am not sure why the warning was happening, and it is possible that this is a memory
2138 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2140 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2141 and uri_parse_mailto() utility functions.
2142 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2144 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2146 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2148 * src/dbus_api/modest-dbus-api.h:
2149 * src/dbus_api/modest-dbus-callbacks.c:
2150 Use an idle callback to execute the modest code in the application's own thread.
2151 Remove the helloworld example method.
2152 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2153 parsed, and the open-message method is not implemented because this is not yet implemented in
2155 * libmodest-dbus-client/libmodest-dbus-client.c:
2156 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2157 (libmodest_dbus_client_open_message):
2158 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2160 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2161 body without crashing.
2163 * tests/dbus_api/Makefile.am:
2164 * tests/dbus_api/test_mail_to.c:
2165 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2167 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2169 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2170 Added file to fix the build. Sorry.
2172 * src/dbus_api/Makefile.am:
2173 * src/dbus_api/modest-dbus-api.h:
2174 * src/dbus_api/modest-dbus-callbacks.h:
2175 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2176 (modest_dbus_req_handler):
2177 Put constants in a separate header so it can be reused by the
2178 client library, without duplication
2180 * libmodest-dbus-client/Makefile.am:
2181 * libmodest-dbus-client/libmodest-dbus-client.c:
2182 (libmodest_dbus_client_call_helloworld),
2183 (libmodfest_dbus_client_send_mail),
2184 (libmodfest_dbus_client_mailto),
2185 (libmodfest_dbus_client_open_message):
2186 * libmodest-dbus-client/libmodest-dbus-client.h:
2187 (Partly) Implement a send_mail D-Bus method.
2189 * tests/dbus_api/Makefile.am:
2190 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2191 the send_email D-Bus method.
2193 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2197 * libmodest-dbus-client/Makefile.am:
2198 * libmodest-dbus-client/libmodest-dbus-client.c:
2199 * libmodest-dbus-client/libmodest-dbus-client.h:
2200 * tests/dbus_api/Makefile.am:
2201 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2202 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2204 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2206 * src/maemo/easysetup/modest-easysetup-wizard.c:
2207 (create_page_account_details):
2208 * src/maemo/modest-account-settings-dialog.c:
2209 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2210 widgets, because this might not be the default in future versions of the Maemo GTK+.
2211 However, I can not not get capitalization to work even in a simple test case.
2213 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2215 * src/maemo/easysetup/modest-easysetup-wizard.c:
2216 (create_page_custom_incoming), (create_page_custom_outgoing):
2217 * src/maemo/modest-account-settings-dialog.c:
2218 (create_page_account_details), (create_page_incoming),
2219 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2220 instead of using gtk_check_button_with_label(), so they are aligned like the other
2221 widgets, as per the UI spec.
2223 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2225 * src/maemo/easysetup/modest-easysetup-wizard.c:
2226 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2227 * src/widgets/modest-validating-entry.c:
2228 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2229 Modest prefix instead of an EasySetup prefix.
2231 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2233 * src/widgets/modest-validating-entry.h:
2234 * src/widgets/modest-validating-entry.c: (on_insert_text),
2235 Added easysetup_validating_entry_set_max_func(), used to set a callback
2236 to call when the max number of characters is reached. GtkEntry has a max-length
2237 already but is silent about it.
2239 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2240 (create_page_account_details), (create_page_user_details),
2242 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2243 (create_page_account_details), (create_page_user_details),
2244 (create_page_outgoing):
2245 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2246 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2247 the UI spec, when the user tries to enter more than the max number of characters.
2249 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2251 * src/maemo/easysetup/modest-easysetup-wizard.c:
2252 (create_page_user_details), (create_page_custom_incoming),
2253 (create_page_custom_outgoing):
2254 * src/maemo/modest-account-settings-dialog.c:
2255 (create_page_user_details), (create_page_incoming),
2256 (create_page_outgoing):
2257 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2258 (modest_connection_specific_smtp_edit_window_init):
2259 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2260 not appropriate. Bad Maemo-specific defaults!.
2262 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2264 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2265 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2266 (modest_signature_editor_dialog_set_settings):
2267 Disable the label and textview when the checkbox is disabled, and use the
2268 specified (UI spec) default signature text.
2270 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2272 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2273 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2275 * src/modest-defs.h:
2276 * src/modest-account-mgr-helpers.h:
2277 * src/modest-account-mgr-helpers.c:
2278 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2280 * src/maemo/Makefile.am:
2281 * src/maemo/modest-signature-editor-dialog.c:
2282 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2285 * src/maemo/modest-account-settings-dialog.h:
2286 * src/maemo/modest-account-settings-dialog.c:
2287 (modest_account_settings_dialog_finalize), (on_button_signature),
2288 (save_configuration): Use the new dialog when the Edit button is pressed, and
2289 save the changes if necessary, as per the UI spec.
2291 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2293 * src/maemo/Makefile.am:
2294 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2295 based on maemo-develoers email from Dirk.
2297 * src/maemo/easysetup/modest-easysetup-wizard.c:
2298 (create_page_welcome), (create_page_account_details),
2299 (create_page_user_details), (create_page_complete_easysetup),
2300 (create_page_custom_incoming), (create_page_custom_outgoing),
2301 (create_page_complete_custom),
2302 (modest_easysetup_wizard_dialog_init):
2303 * src/maemo/modest-account-settings-dialog.c:
2304 (create_page_account_details), (create_page_user_details),
2305 (create_page_incoming), (create_page_outgoing),
2306 (modest_account_settings_dialog_init):
2307 * src/maemo/modest-connection-specific-smtp-window.c:
2308 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2310 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2312 * src/maemo/easysetup/modest-easysetup-wizard.c:
2313 (create_page_account_details), (create_page_custom_outgoing),
2314 (create_page_complete_custom):
2315 * src/maemo/modest-account-settings-dialog.c:
2316 (create_page_user_details), (create_page_incoming),
2317 (create_page_outgoing):
2318 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2319 (modest_connection_specific_smtp_edit_window_init):
2320 Use the correct (UI spec) port min/max, and use horizontal separators,
2323 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2325 * src/maemo/easysetup/modest-easysetup-wizard.c:
2326 (set_default_custom_servernames):
2327 * src/maemo/modest-account-settings-dialog.c:
2328 (create_page_incoming), (on_combo_outgoing_security_changed),
2329 (on_combo_incoming_security_changed), (create_page_outgoing),
2330 (modest_account_settings_dialog_set_account_name),
2331 (save_configuration):
2332 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2333 (on_combo_security_changed),
2334 (modest_connection_specific_smtp_edit_window_init),
2335 (modest_connection_specific_smtp_edit_window_set_connection),
2336 (modest_connection_specific_smtp_edit_window_get_settings):
2337 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2340 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2343 * src/maemo/easysetup/modest-easysetup-wizard.c:
2344 (create_page_custom_outgoing), (create_page_complete_custom):
2345 * src/maemo/modest-account-settings-dialog.c:
2346 (create_page_user_details), (create_page_outgoing):
2347 * src/maemo/modest-account-view-window.c: (button_box_new):
2348 Use changed logical IDs as per the most recent UI spec:
2349 mcen_bd_emailsetup_edit -> mcen_bd_edit
2350 mcen_bd_emailsetup_delete -> mcen_bd_delete
2351 mcen_bd_emailsetup_close -> mcen_bd_close
2353 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2357 * src/dbus_api/Makefile.am:
2358 * src/dbus_api/modest-dbus-callbacks.c:
2359 * src/dbus_api/modest-dbus-callbacks.h:
2360 * src/maemo/modest-platform.c: (modest_platform_init):
2361 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2363 * tests/Makefile.am:
2364 * tests/dbus_api/Makefile.am:
2365 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2367 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2369 * src/maemo/modest-account-settings-dialog.c:
2370 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2371 Removed unnecessary includes.
2373 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2375 * src/maemo/easysetup/modest-easysetup-wizard.c:
2376 * src/maemo/modest-account-settings-dialog.c:
2377 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2378 * src/widgets/Makefile.am:
2379 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2380 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2381 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2382 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2383 * src/widgets/modest-secureauth-combo-box.c:
2384 * src/widgets/modest-secureauth-combo-box.h:
2385 * src/widgets/modest-serversecurity-combo-box.c:
2386 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2387 made the GObject names more consistent with the rest of the Modest code.
2389 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2391 * src/maemo/easysetup/Makefile.am:
2392 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2393 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2394 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2395 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2396 * src/maemo/easysetup/modest-easysetup-wizard.c:
2397 * src/maemo/easysetup/modest-validating-entry.c:
2398 * src/maemo/easysetup/modest-validating-entry.h:
2399 * src/maemo/modest-account-settings-dialog.c:
2400 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2401 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2402 widgets/ because they are used outside of easysetup too. After checking in,
2403 svn will allow me to rename them too.
2405 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2407 * src/gnome/modest-msg-edit-window.c:
2408 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2409 linker error, to fix the build on the GNOME platform.
2410 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2411 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2412 ifdefed out to avoid a warning.
2414 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2416 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2417 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2418 some alternative for GTK+ 2.6.
2420 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2422 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2424 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2425 specified for EmailAccountsDialog in UI spec.
2427 * src/maemo/easysetup/modest-easysetup-wizard.c:
2428 * src/maemo/easysetup/modest-easysetup-wizard.h:
2429 * src/maemo/modest-account-settings-dialog.c:
2430 * src/maemo/modest-account-settings-dialog.h:
2431 Reuse a member window widget for the connection-specific SMTP server accounts,
2432 so we can tell it to create/save the accounts only if we actually save changes.
2434 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2435 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2436 (modest_connection_specific_smtp_edit_window_get_settings):
2437 Return a struct instance for temporarily remembering the entered data.
2439 * src/maemo/modest-connection-specific-smtp-window.h:
2440 * src/maemo/modest-connection-specific-smtp-window.c:
2441 (modest_connection_specific_smtp_window_finalize),
2442 (modest_connection_specific_smtp_window_fill_with_connections),
2444 (modest_connection_specific_smtp_window_save_server_accounts),
2445 (update_model_server_names): Do not actually save data until asked,
2446 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2448 (on_selection_changed),
2449 (modest_connection_specific_smtp_window_init): Disable the edit
2450 button when nothing is selected.
2452 * src/modest-account-mgr-helpers.c:
2453 * src/modest-account-mgr-helpers.h:
2454 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2457 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2459 * src/modest-account-mgr-helpers.h:
2460 * src/modest-account-mgr-helpers.c:
2461 (modest_account_mgr_get_unused_account_name),
2462 (modest_account_mgr_get_unused_account_display_name): Added these
2463 utility functions, to avoid code duplication.
2465 * src/maemo/easysetup/modest-easysetup-wizard.c:
2466 (create_page_account_details), (create_account):
2467 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2468 (on_combo_security_changed),
2469 (modest_connection_specific_smtp_edit_window_init),
2470 (modest_connection_specific_smtp_edit_window_save_settings):
2471 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2472 * src/maemo/modest-connection-specific-smtp-window.c:
2473 (modest_connection_specific_smtp_window_finalize),
2474 (modest_connection_specific_smtp_window_fill_with_connections),
2475 (on_button_edit), (modest_connection_specific_smtp_window_init):
2476 * src/maemo/modest-connection-specific-smtp-window.h:
2477 Implementing saving of connection-specific server accounts.
2479 But I need to refactor this so we can save the data for each
2480 possible connection-specific account and only actually create the server accounts
2481 when the easysetup finished, or the OK button is pressed on the account settings
2484 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2486 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2487 (on_combo_security_changed):
2488 (modest_connection_specific_smtp_edit_window_init):
2489 Auto-fill the port number as in the account settings.
2491 (modest_connection_specific_smtp_edit_window_set_connection):
2492 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2493 * src/maemo/modest-connection-specific-smtp-window.c:
2494 (fill_with_connections), (on_button_edit),
2495 (modest_connection_specific_smtp_window_init):
2496 Turn the edit window into a dialog to simplify the code, and
2497 set a WM hint as in a GtkDialog, because only a popup can be on top of
2498 another window in Maemo, and popups usually have no WM decoration.
2500 * src/modest-defs.h:
2501 * src/modest-account-mgr-helpers.c:
2502 (modest_account_mgr_set_connection_specific_smtp),
2503 (modest_account_mgr_remove_connection_specific_smtp),
2504 (modest_account_mgr_get_connection_specific_smtp):
2505 * src/modest-account-mgr-helpers.h: Some functions to write the
2506 connection-specific SMTP server information. Not yet used.
2509 * src/widgets/modest-folder-view.c: (text_cell_data):
2510 Fix a warning about an uninitialized variable.
2511 (on_configuration_key_changed): Put an #ifdef around the use
2512 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2514 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2516 * src/maemo/modest-account-settings-dialog.h:
2517 * src/maemo/modest-account-settings-dialog.c:
2518 Added connect_for_modified() utility function to mark the new modified boolean.
2520 (create_page_account_details), (create_page_user_details),
2521 (create_page_incoming), (create_page_outgoing), (on_response),
2522 (modest_account_settings_dialog_init),
2523 (modest_account_settings_dialog_set_account_name):
2524 Only warn about unsaved changes when there are actually unsaved changes.
2526 * src/modest-account-mgr-helpers.c:
2527 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2528 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2529 to get the data from there in future.
2531 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2533 * src/modest-defs.h:
2535 * src/modest-account-mgr-helpers.h:
2536 * src/modest-account-mgr-helpers.c:
2537 Store the security account setting in a single conf key instead of using
2538 the options list, so that the list is left for just the to-be-removed camel hack,
2539 and because gconf_client_set_list() is failing for some reason.
2541 * src/modest-account-mgr.c:
2542 (modest_account_mgr_add_server_account):
2543 * src/maemo/modest-account-settings-dialog.c:
2544 (modest_account_settings_dialog_set_account_name),
2545 (save_configuration): Use the renamed functions.
2548 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2550 * src/widgets/Makefile.am:
2551 * src/widgets/modest-limit-retrieve-combo-box.c:
2552 * src/widgets/modest-limit-retrieve-combo-box.h:
2553 * src/widgets/modest-retrieve-combo-box.c:
2554 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2555 the account settings dialog.
2557 * src/modest-defs.h:
2558 * src/modest-account-mgr-helpers.h:
2559 * src/modest-account-mgr-helpers.c:
2560 (modest_server_account_get_option_secure_auth),
2561 (modest_server_account_set_option_secure_auth):
2562 * src/modest-account-mgr.c:
2563 (modest_account_mgr_add_server_account):
2564 Use the existing AUTH_MECH conf key for the secure-auth setting,
2565 instead of putting it in the list options, because this was actually used already.
2567 * src/maemo/modest-account-settings-dialog.c:
2568 (create_page_account_details),
2569 (modest_account_settings_dialog_set_account_name),
2570 (save_configuration):
2571 * src/maemo/modest-account-settings-dialog.h:
2572 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2573 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2575 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2577 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2578 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2579 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2581 * src/modest-defs.h:
2582 * src/maemo/modest-account-settings-dialog.c:
2583 (create_page_incoming), (on_combo_outgoing_security_changed),
2584 (on_combo_incoming_security_changed), (create_page_outgoing),
2585 (modest_account_settings_dialog_set_account_name),
2586 (save_configuration): Load/Save the port number, and change it when the
2587 security combo changes, to suitable defaults.
2589 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2591 * src/modest-account-mgr.c:
2592 (modest_account_mgr_add_server_account): Set the security and secure-auth
2593 options, and add a comment saying that the other camel-specific options should be
2596 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2598 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2600 * src/modest-tny-account-store.c: (account_list_free),
2601 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2602 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2605 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2607 * src/modest-protocol-info.c:
2608 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2609 is required by our UI spec. Maybe something in our implementation will use this eventually.
2610 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2611 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2612 instead of the previous 0 placeholder.
2614 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2615 secure-auth settings.
2616 * src/modest-account-mgr-helpers.h:
2617 * src/modest-account-mgr-helpers.c:
2618 (modest_server_account_data_get_option_secure_auth),
2619 (modest_server_account_set_option_secure_auth),
2620 (modest_server_account_data_get_option_security),
2621 (modest_server_account_set_option_security): Added this API for getting and setting the security
2622 and secure-auth settings.
2624 * src/maemo/modest-account-settings-dialog.h:
2625 * src/maemo/modest-account-settings-dialog.c:
2626 (modest_account_settings_dialog_finalize), (check_data),
2627 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2628 about changing titles.
2629 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2630 (save_configuration): Save the security and secure-auth settings.
2632 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2633 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2635 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2637 * src/modest-defs.h:
2638 * src/modest-account-mgr.c:
2639 (modest_account_mgr_add_server_account):
2640 Added and used defines for the options key and value pair strings,
2641 that are used so far, though they do not seem to correspond to anything in our
2642 UI specs or ModestProtocol enum.
2644 * src/modest-account-mgr-helpers.h:
2645 * src/modest-account-mgr-helpers.c:
2646 (compare_option_strings_for_name),
2647 (modest_server_account_data_get_option_value),
2648 (modest_server_account_data_get_option_bool),
2649 (modest_account_mgr_get_server_account_option):
2650 Added helper functions for parsing the options GSList.
2652 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2654 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2655 display name is based on the supplied account name.
2656 * src/modest-account-mgr.c:
2657 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2658 with an inefficient, but good-enough, implementation.
2660 * src/maemo/easysetup/modest-easysetup-wizard.c:
2661 (create_page_account_details), (on_before_next), (create_account):
2662 Check for existing display names rather than (non-user-visible) account names, and just
2663 create and set a unique account name at the end.
2665 * src/maemo/modest-account-settings-dialog.c:
2666 (modest_account_settings_dialog_init),
2667 (modest_account_settings_dialog_set_account_name),
2668 (create_page_incoming): Show the display name, instead of the account name.
2669 (on_response): Do some (not all) extra checks, as in the UI spec.
2670 (save_configuration): Save the display name if it was changed.
2672 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2674 * po/en_GB.po: Added needed logical ID and translation.
2675 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2676 (init_view): Made the is-default column clicking work.
2678 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2681 * src/maemo/easysetup/Makefile.am:
2682 * src/maemo/easysetup/modest-easysetup-wizard.c:
2683 (modest_easysetup_wizard_dialog_init):
2684 * src/maemo/easysetup/provider-data-test.keyfile:
2685 * src/maemo/easysetup/provider-data.keyfile:
2686 Moved the provider data file to the new modest-providers-data package and used it from there.
2688 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2690 * src/modest-local-folder-info.c:
2691 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2692 N_() was already used on the static strings, but this just marks it for translation without
2693 using the translation.
2695 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2697 * src/maemo/modest-account-settings-dialog.c:
2698 (create_page_incoming),
2699 (modest_account_settings_dialog_set_account_name):
2700 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2701 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2702 I will do this if nobody else gets there first.
2704 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2706 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2707 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2708 save the security stuff.
2710 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2712 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2713 Set the email address and user fullname, which I now see must be
2716 * src/maemo/modest-account-settings-dialog.h:
2717 * src/maemo/modest-account-settings-dialog.c:
2719 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2720 leave-on-server and authentication.
2721 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2724 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2727 * src/maemo/modest-account-settings-dialog.c:
2728 * src/maemo/modest-account-settings-dialog.h:
2729 Most (but not all) of the widgets are now present as specified by the UI spec.
2730 No changes are yet saved, and some details are not properly shown yet.
2732 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2734 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2736 * src/maemo/Makefile.am:
2737 * src/maemo/modest-account-settings-dialog.c:
2738 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2739 an existing account. Doesn't do much yet.
2741 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2742 Open the accounts settings dialog when Edit is clicked.
2744 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2746 * src/maemo/easysetup/Makefile.am:
2747 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2749 * src/maemo/easysetup/modest-easysetup-wizard.c:
2750 (modest_easysetup_wizard_dialog_init):
2751 Try to get the source directory from the build system,
2752 instead of hard-coding "./" into the source code, when opening our local
2753 copies of the configuration files.
2754 But this still fails when opening the wizard from the Accounts window,
2755 maybe because the working directory seems to change at runtime.
2756 So the wizard will fail the second time unless you copy the files into their
2757 proper locations - see the stdout warnings for the paths.
2759 (create_page_account_details),(on_before_next):
2760 Check for existing non-server accounts instead of server accounts,
2761 so the default account name is useful again, and to prevent trying to
2764 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2765 Show the wizard when New is clicked.
2767 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2768 (init_view): Show the column headers, and show the columns that are
2769 specified in the UI specs. However, something in Maemo's GTK+ prevents
2770 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2771 change the default account. This is despite unsetting the special properties.
2773 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2775 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2776 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2777 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2778 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2779 to make that clearer.
2780 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2782 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2784 * src/maemo/modest-account-view-window.c:
2785 (modest_account_view_window_init),
2786 (modest_account_view_window_new):
2787 Use the same buttons as specified in the
2788 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2789 the existing widgets, which never had a chance of working.
2790 Put the ModestAccountView treeview in a scrolled window.
2791 Do not repeat the initialization in both _init() and _new().
2793 * src/widgets/modest-account-view.c: (update_account_view):
2794 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2795 this widget and window shows no accounts.
2797 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2799 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2801 * src/maemo/easysetup/modest-easysetup-wizard.c:
2802 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2803 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2804 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2807 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2808 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2809 accounts exist yet, as in the UI spec.
2811 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2813 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2815 * src/maemo/Makefile.am:
2816 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2817 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2818 New window for editing connection-specific smtp details.
2819 Not fully implemented.
2821 * src/maemo/modest-connection-specific-smtp-window.c:
2822 (modest_connection_specific_smtp_window_finalize) :
2823 unref the tree model.
2824 (on_button_edit): Show the edit window.
2826 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2828 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2831 * src/maemo/Makefile.am:
2832 * src/maemo/modest-connection-specific-smtp-window.c:
2833 * src/maemo/modest-connection-specific-smtp-window.h:
2834 New window for showing the list of connections, for connection-specific
2835 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2836 * src/maemo/easysetup/modest-easysetup-wizard.c:
2837 (create_page_custom_outgoing): Show the new window when the button is clicked.
2839 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2841 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2842 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2843 * src/maemo/modest-msg-edit-window.c:
2844 (modest_msg_edit_window_insert_image):
2845 * src/modest-conf.c: (modest_conf_key_escape):
2846 * src/modest-mail-operation.c:
2847 (modest_mail_operation_send_new_mail):
2848 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2849 (modest_ui_actions_on_new_account):
2850 * src/widgets/modest-attachment-view.c: (update_filename_request):
2851 * src/widgets/modest-mail-header-view.c:
2852 Corrected warnings that were breaking the build, by commenting out unused variables,
2853 and a function, and by including a header.
2855 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2857 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2858 so we can #ifdef around platform-specific code when necessary.
2859 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2860 to allow this to build for the GNOME platform too.
2862 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2864 * src/maemo/easysetup/modest-easysetup-wizard.c:
2865 Added util_increment_name() and used it in create_page_account_details()
2866 to make sure that the default account name is always a new name.
2868 (modest_easysetup_wizard_dialog_init),
2869 (set_default_custom_servernames): Some minor memory management fixes.
2871 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2875 * src/modest-runtime.c: (init_i18n): Restored the translation
2876 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2877 are defined in config.h, and the translations are installed.
2879 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2880 is defined for translation.
2882 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2884 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2886 * src/maemo/easysetup/modest-easysetup-wizard.c:
2887 (modest_easysetup_wizard_dialog_init):
2888 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2889 Use realistic paths (though they should use $prefix generically) to the
2890 mcc_mapping and provider-data.keyfile files which might work when they
2891 are installed by the future version of the operator-wizard package,
2892 and then fallback to paths in our source code, with an explanatory
2895 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2899 * src/maemo/Makefile.am:
2900 * src/maemo/easysetup/: Added files from the previously-exernal
2901 osso-modest-easysetup.
2902 * src/maemo/modest-main-window-ui.h:
2903 * src/modest-ui-actions.c:
2904 * src/modest-ui-actions.h:
2905 Added modest_ui_actions_on_new_account() as a signal handler for the
2906 New Account menu item. It shows the easysetup wizard.
2907 * po/en_GB.po: Added additional needed logical IDs and translations.
2909 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2910 Apparently ChangeLog is not used for some vague Nokia legal reasons.