1 2007-08-29 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c:
4 (check_first_supported_auth_method), (on_before_next),
6 * src/maemo/modest-account-settings-dialog.c: (check_data):
7 Some cleanup, to make the code clearer.
9 2007-08-29 Murray Cumming <murrayc@murrayc.com>
11 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
12 Use the mail_ni_ssl_certificate_error ("Secure connection failed")
13 logical ID when the secure authentication method is not supported by
14 the server, as requested by Mox on the wiki, though I hate not
15 giving the user the clue.
17 2007-08-29 Murray Cumming <murrayc@murrayc.com>
19 * src/modest-search.c: (modest_search_all_accounts):
20 * src/modest-platform.h:
21 * src/maemo/modest-platform.c: Moved and renamed
22 check_and_wait_for_account_is_online() to
23 modest_platform_check_and_wait_for_account_is_online() so it
24 can be used in more places.
26 2007-08-29 Murray Cumming <murrayc@murrayc.com>
28 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
29 Removed the sleep(1) experiment because it does not seem to help,
30 and I should not have checked the experiment in anyway.
31 The problem is maybe in the TnyAccount connected state - I will
32 investigate that instead.
34 2007-08-28 Murray Cumming <murrayc@murrayc.com>
36 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
37 Added a sleep(1) in case it helps with bug #66769.
39 2007-08-28 Murray Cumming <murrayc@murrayc.com>
41 * src/modest-search.c: (on_timeout_check_account_is_online),
42 (check_and_wait_for_account_is_online):
43 It is OK for local-folder and mmc accounts to be used when they
44 are in the _INIT folder, instead of waiting for them to change
46 For POP and IMAP, wait from them to stop being _INIT, rather than
47 waiting from them to be _CONNECTED, because that seems to be
48 the status that causes the problems.
50 2007-08-28 Murray Cumming <murrayc@murrayc.com>
52 * src/modest-search.c: (check_and_wait_for_account_is_online):
53 Actually pass the account to the timeout callback.
55 2007-08-28 Murray Cumming <murrayc@murrayc.com>
57 * src/modest-search.c: (on_timeout_check_account_is_online):
58 Added some debug output to help me debug a problem on the N800.
59 (check_and_wait_for_account_is_online): Fail immediately if the
61 modest_search_all_accounts(): Try the search even if the account does
62 not seem to be online, because this can work sometimes, and should work
63 with the cache if there is no active libconic connection.
65 2007-08-27 Armin Burgmeier <armin@openismus.com>
67 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
68 observe outbox for added messages to assign them a status. Previously,
69 this was done in modest_tny_send_queue_add(), but the message id might
70 not yet be known at that point. This reduces warnings when sending
71 mail, though I am not sure how this even worked before.
73 2007-08-27 Murray Cumming <murrayc@murrayc.com>
75 * src/maemo/modest-account-settings-dialog.c:
76 (modest_account_settings_dialog_init):
77 * src/maemo/modest-connection-specific-smtp-edit-window.c:
78 (modest_connection_specific_smtp_edit_window_init):
79 * src/maemo/modest-connection-specific-smtp-window.c:
80 (modest_connection_specific_smtp_window_init):
81 * src/maemo/modest-maemo-utils.c:
82 (modest_maemo_utils_get_supported_secure_authentication_methods):
83 * src/maemo/modest-platform.c:
84 (modest_platform_run_folder_name_dialog):
85 * src/maemo/modest-signature-editor-dialog.c:
86 (modest_signature_editor_dialog_init):
87 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
88 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
89 * src/widgets/modest-global-settings-dialog.c:
90 (modest_global_settings_dialog_init):
91 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
93 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
94 GTK_STOCK_EDIT with mcen_bd_edit, and
95 GTK_STOCK_CLOSE with mcen_bd_close,
96 to fix projects.maemo.org bug NB#64995.
97 I strongly believe that Maemo's GTK+ should have the wanted translations
98 instead of duplicating this in each application and complicating the code.
100 2007-08-27 Armin Burgmeier <armin@openismus.com>
102 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
103 recursion when entering text in the subject field.
105 2007-08-27 Murray Cumming <murrayc@murrayc.com>
107 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
108 which checks every second, 10 times, to wait until the account is online
109 so that we can use it, if the account is in the process of going online.
110 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
111 so that searching works even when the application was not yet started before.
112 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
114 2007-08-24 Armin Burgmeier <armin@openismus.com>
116 * src/modest-widget-memory.c: Always show the default account when the
117 application is started, as stated in the UI spec. This fixes
118 projects.maemo.org bug NB#66630.
120 2007-08-24 Armin Burgmeier <armin@openismus.com>
122 * src/maemo/modest-platform.c:
123 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
124 english text for strings in the rename folder dialog, fixing
125 projects.maemo.org bug NB#66338.
127 2007-08-22 Armin Burgmeier <armin@openismus.com>
129 * src/widgets/modest-account-view.c: Fix for bora by using
130 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
131 latter seems not be used anymore.
133 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
136 * src/maemo/modest-main-window.c: Update menu items when the default
137 account changes so that the current default account is always bolded.
138 This fixes maemo.projects.org bug NB#66173.
140 2007-08-17 Murray Cumming <murrayc@murrayc.com>
142 * src/dbus_api/modest-dbus-callbacks.c:
143 (on_dbus_method_get_folders): Avoid trying to get the account name
144 when there are no accounts, to avoid critical g_warnings, fixing
145 projects.maemo.org bug NB#65574.
147 2007-08-17 Murray Cumming <murrayc@murrayc.com>
149 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
150 Use modest_account_mgr_get_signature() instead of accessing gconf
151 directly, to slightly simplify the code.
152 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
153 Append the signature also when opening via other applications,
154 fixing projects.maemo.org bug NB#65828.
156 2007-08-17 Murray Cumming <murrayc@murrayc.com>
158 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
159 Check for NULLs to prevent a crash when opening an email that is
160 an attachment in another email, fixing projects.maemo.org bug
163 2007-08-17 Murray Cumming <murrayc@murrayc.com>
165 * src/modest-ui-dimming-rules.c:
166 (modest_ui_dimming_rules_on_view_window_move_to):
167 Enable the Move To toolbar button for search results, fixing the
168 last part of projects.maemo.org bug NB#63807.
170 2007-08-17 Murray Cumming <murrayc@murrayc.com>
172 * src/dbus_api/modest-dbus-callbacks.c:
173 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
174 because this is called from idle handlers, to fix hangs afte the
176 (find_message_by_url): Added a TODO comment about a crash that
177 happens when tinymail was built with DBC checks.
179 2007-08-16 Murray Cumming <murrayc@murrayc.com>
181 * src/modest-search.c: (modest_search_folder):
182 * src/modest-search.h: Rename ModestSearch::before to start_date
183 and after to end_date, using the same names as the libogs struct
185 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
186 The start_date and end_date were swapped in the check. This
187 fixes date range searches, fixing projects.maemo.org bug NB#63407.
189 2007-08-16 Murray Cumming <murrayc@murrayc.com>
191 * src/maemo/modest-account-view-window.c:
192 Added (check_for_active_acount).
193 (on_delete_button_clicked), (on_edit_button_clicked):
194 When an account is doing something (such as refreshing),
195 show the same warning for account deletion as for account
196 editing, to fix projects.maemo.org bug NB#64588.
198 2007-08-16 Murray Cumming <murrayc@murrayc.com>
200 * src/widgets/modest-msg-view-window.h:
201 * src/gnome/modest-msg-view-window.c:
202 * src/maemo/modest-msg-view-window.c:
203 Added modest_msg_view_window_construct().
204 (modest_msg_view_window_new_with_header_model),
205 Added modest_msg_view_window_new_for_search_result),
206 Renamed modest_msg_view_window_new() to
207 modest_msg_view_window_new_for_attachment(),
208 and modest_msg_view_window_is_search_result(),
209 so we can explicitly know that the window is for an
210 attachment or a search result or a message from the list.
212 (modest_msg_view_window_view_attachment):
213 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
214 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
215 Use modest_msg_view_window_new_for_search_result().
217 * src/modest-ui-dimming-rules.c:
218 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
219 for search results, fixing projects.maemo.org bug NB#63811.
221 2007-08-16 Armin Burgmeier <armin@openismus.com>
223 * src/modest-ui-actions.c: Show a banner instead of a dialog when
224 renaming a folder fails, to stay consistent with what happens when
225 creating a folder fails.
227 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
228 slightly country loading from the mmc_mappings file, fixed a memory
231 2007-08-16 Murray Cumming <murrayc@murrayc.com>
233 * src/modest-tny-account-store.c: (volume_path_is_mounted):
234 Check the GnomeVFSVolume activation path instead of the device path,
235 so that the memory card is really really shown in the UI.
237 2007-08-16 Murray Cumming <murrayc@murrayc.com>
239 * src/maemo/easysetup/modest-easysetup-wizard.c:
240 (get_entered_account_title), (on_before_next), (entry_is_empty),
242 * src/maemo/modest-account-settings-dialog.c:
243 (get_entered_account_title), (on_button_signature), (check_data),
244 (save_configuration), (entry_is_empty):
245 Strip the account title of whitespace at the start and end before
246 using it or checking it. This means that an all-whitespace title
247 is not allowed, fixing projects.maemo.org bug NB#64977.
249 2007-08-15 Murray Cumming <murrayc@murrayc.com>
251 * src/modest-ui-actions.h:
252 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
253 to modest_run_account_setup_wizard() and made it public.
254 * src/dbus_api/modest-dbus-callbacks.c:
255 (check_and_offer_account_creation), (on_idle_mail_to),
256 (on_idle_compose_mail), (on_idle_open_default_inbox):
257 Offer account creation if necessary, fixing projects.maemo.org
260 2007-08-15 Murray Cumming <murrayc@murrayc.com>
262 * src/modest-ui-actions.c: (run_account_setup_wizard):
263 Return a gboolean to indicate success.
264 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
265 (modest_ui_actions_on_send): When offering account creation, only
266 give up (return) if account creation failed. Otherwise continue
267 with the original request. This fixed projects.maemo.org bug
270 2007-08-15 Murray Cumming <murrayc@murrayc.com>
272 * src/widgets/modest-recpt-editor.c:
273 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
274 to fix projects.maemo.org bug NB#63789.
276 2007-08-15 Murray Cumming <murrayc@murrayc.com>
278 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
279 (modest_tny_account_store_new): Properly detect the memory card at
280 startup, and add an account for it.
282 2007-08-14 Murray Cumming <murrayc@murrayc.com>
284 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
285 Commented out the MMC code again because it mistakenly detects
286 the card even when it isn't inserted.
288 2007-08-14 Murray Cumming <murrayc@murrayc.com>
290 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
291 Renabled the call to add_mmc_account() because I do not believe
292 it could be the cause of the mentioned hang (in scratchbox, where
293 there is no memory card), and because I have tested that it works
296 2007-08-14 Murray Cumming <murrayc@murrayc.com>
298 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
299 Comment out part of the last commit because it apparently causes
302 2007-08-14 Murray Cumming <murrayc@murrayc.com>
304 * src/modest-tny-account-store.c: Added the add_mmc_account()
305 function to save some copy/pasting.
306 (modest_tny_account_store_new): If the memory card is mounted,
307 create an account for it at the start, instead of waiting for the
308 user to unmount it and mount it.
310 2007-08-13 Murray Cumming <murrayc@murrayc.com>
312 * src/widgets/modest-account-view.c: (on_account_changed):
313 Do not try to use the human-readable TnyAccount name instead of the
314 ID of the modest account to get the transport account. And unref
315 the transport account. This prevents a g_warning(), and a possible
318 2007-08-13 Murray Cumming <murrayc@murrayc.com>
320 * src/maemo/modest-platform.c:
321 (modest_platform_set_update_interval): Handle the new
322 alarmd error to warn when alarmd is not running, as is the case in
323 scratchbox for me now because
324 "Module /usr/lib/alarmd/libretu.so initialization failed"
326 2007-08-13 Murray Cumming <murrayc@murrayc.com>
328 * src/widgets/modest-header-view-render.c:
329 (_modest_header_view_compact_header_cell_data):
330 NULL some strings after freeing them, trying to deal with
331 the double deletion found in projects.maemo.org bug 64183,
332 probably having no effect.
334 2007-08-13 Murray Cumming <murrayc@murrayc.com>
336 * src/maemo/modest-account-settings-dialog.c:
337 (create_page_incoming), (create_page_outgoing): Use a define
338 for the min and max port numbers.
340 (check_hildon_number_editor_and_warn_value_not_in_range),
341 (check_data): Do an extra check for an invalid port number, as needed
342 in projects.maemo.org bug #64275, when the number is cleared, but this
343 does not work due to bugs.maemo.org bug #1806.
345 2007-08-13 Murray Cumming <murrayc@murrayc.com>
347 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
348 Comment out the debug warning about the unexpected D-Bus methods.
349 They are just annoying now.
350 * src/maemo/modest-platform.c:
351 (modest_platform_set_update_interval): Correct the D-Bus path, instead
352 of using a file path, though it did not seem to break things before.
353 It might be needed now:
354 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
355 modest is not already running. This is the behaviour of the old client, and
356 Mox says it is what we should do for modest.
357 This closes projects.maemo.org bug NB#64327.
359 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
361 * src/modest-text-utils.c:
362 Fixed invalid jump due to incorrect string/pointer
364 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
367 2007-08-01 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-account-mgr-helpers.h:
370 * src/modest-account-mgr-helpers.c:
371 Added modest_account_mgr_get_first_account_name(),
372 using code from modest_account_mgr_set_first_account_as_default().
374 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
375 (account_number_changed): Call set_at_least_one_account_visible() so that
376 the first account is visible when first added, without the user having to
378 I do wonder how this worked before.
380 2007-08-01 Murray Cumming <murrayc@murrayc.com>
382 * src/modest-tny-account-store.c: (show_password_warning_only),
383 (show_wrong_password), (request_password_and_wait), (get_password),
384 (modest_tny_account_store_alert): Remove the (incomplete anyway)
385 attempts to show UI only in the main context, which used g_idle_add()
386 and mainloops, because tinymail now guarantees that it only calls these
387 callbacks in the mainloop with the gdk lock. This makes everything much
390 2007-08-01 Murray Cumming <murrayc@murrayc.com>
392 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
393 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
394 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
395 error dialog, instead of ignoring it.
397 2007-08-01 Murray Cumming <murrayc@murrayc.com>
399 * src/maemo/modest-msg-view-window.c:
400 (modest_msg_view_window_get_header),
401 (modest_msg_view_window_last_message_selected):
402 Added comments to explain the use of priv->header_model.
403 * src/modest-ui-dimming-rules.c:
404 (modest_ui_dimming_rules_on_open_msg),
405 (modest_ui_dimming_rules_on_mark_as_read_msg),
406 (modest_ui_dimming_rules_on_mark_as_unread_msg),
407 (modest_ui_dimming_rules_on_remove_attachments),
408 (_invalid_attach_selected), (_selected_msg_marked_as):
409 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
410 and changed the parameter to a ModestMainWindow to make it clearer that
411 it never uses any other kind of window.
412 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
413 instead of the selected message.
414 I notice that much of the dimming code and the ModestMsgViewWindow code
415 hard-codes the assumption that the viewed message is always selected in
416 the header view. This does not seem wise or simple.
418 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
419 examine the actual message instead of whatever might be selected
420 in the header view. This stops the delete toolbar button and menu item
421 from being dimmed when opening a message view the search UI,
422 partially fixing projects.maemo.org bug NB#63811.
424 However, when actually deleting, I now get this warning:
425 "tny_header_set_flags: This is a header instance for a new message.
426 Only priority and attachment flags are supported"
428 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
430 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
432 Show account wizard if no accounts are defined while sending
433 (automatic sending after the account wizard finished does not
434 work because it takes some time until the account manager
435 synchronizes everything. (projects.maemo.org NB#62792)
437 2007-07-30 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-tny-account-store.c: (on_account_removed),
440 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
441 account is removed from the View menu. We have TnyAccountStore
442 and ModestTnyAccountStore signals that seem very similar, but this
443 seems to work for now.
445 * src/maemo/modest-main-window.c:
446 (on_show_account_action_activated): Prevent dereference
447 of a NULL if the accoutn does not really exist, though that
448 should not happen anymore.
450 This fixes projects.maemo.org bug NB#64606.
452 2007-07-30 Murray Cumming <murrayc@murrayc.com>
454 * src/modest-ui-actions.c: (run_account_setup_wizard),
455 (modest_ui_actions_on_accounts): Revert a change that set these
456 to modal dialogs, freezing the UI when they show secondary dialogs.
457 This fixed projects.maemo.org bug NB#64519.
459 2007-07-27 Murray Cumming <murrayc@murrayc.com>
461 * src/widgets/modest-header-view-render.c:
462 (_modest_header_view_compact_header_cell_data):
463 Some checks and initialization to try to deal with a crash,
464 probably ineffective.
466 2007-07-27 Murray Cumming <murrayc@murrayc.com>
468 * src/maemo/modest-maemo-utils.c:
469 (modest_maemo_utils_get_supported_secure_authentication_methods):
470 Make sure that we have a connection, asking the user for one
472 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
473 Check for a connection before showing the wizard, because
474 the wizard needs a connection to check for server capabilities.
476 2007-07-27 Murray Cumming <murrayc@murrayc.com>
478 * src/maemo/modest-account-view-window.c:
479 (on_new_button_clicked): Remember the wizard dialog instance,
480 so we can just present it again if necessary. This prevents
481 multiple windows from appearing if you click again quickly on the
482 New button before the dialog appears, fixing projects.maemo.org
485 2007-07-27 Murray Cumming <murrayc@murrayc.com>
487 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
488 Offer a connection dialog if there is no connection when
489 starting modest. This should fix projects.maemo.org bug NB#61134.
491 2007-07-27 Murray Cumming <murrayc@murrayc.com>
493 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
494 Reverted my last commit. I was able to fix the build by doing
495 apt-get install wpeditor0 (replacing other wpeditor packages) and
496 an explicit apt-get install wpeditor-dev to upgrade the -dev
499 2007-07-27 Murray Cumming <murrayc@murrayc.com>
501 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
502 Commented out the use of wp_text_buffer_replace_image()
503 because it does not exist, to break the build. Added a TODO for it.
505 2007-07-26 Murray Cumming <murrayc@murrayc.com>
507 * src/modest-tny-account-store.c: (recreate_all_accounts):
508 Recreate them even if they were NULL before. I guess something
509 else was already creating them before, or this would never
511 (modest_tny_account_store_get_server_account): Make sure that
512 the tny accounts have been created before trying to find one.
513 This allows libmodest_dbus_client_compose_mail() to work
514 when the UI is not yet visible.
515 This is probably useful in other cases too.
517 (get_password): When the password is wrong after it is entered
518 in the protected password dialog, show an info banner (in an
519 idle handler) before showing the protected password dialog
522 2007-07-26 Murray Cumming <murrayc@murrayc.com>
524 * src/modest-ui-actions.h:
525 * src/modest-ui-actions.c: Added
526 modest_do_refresh_current_folder() containing some code from
527 modest_ui_actions_on_send_receive().
528 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
529 Call modest_do_refresh_current_folder() before refreshing the
530 requested account, as in modest_ui_actions_on_send_receive().
531 This is strange, but seems to be necessary to show new mails.
532 Now new emails are finally visible in the UI when downloaded
533 via the automatic update interval, fixing bug NB#57458.
534 This also works because bug NB#57458 has been fixed somehow.
536 2007-07-26 Murray Cumming <murrayc@murrayc.com>
538 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
539 printf more details when we get unhandled D-Bus methods, because
542 * src/modest-mail-operation.c: (update_account_thread):
543 Comment out the tny_camel_pop_store_account_reconnect(), because this
544 is apparently no longer needed, and it did not work before anyway.
545 See the comment in the code.
547 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
548 by checking the header flags. This fixes projects.maemo.org bug
551 2007-07-25 Murray Cumming <murrayc@murrayc.com>
553 * src/maemo/modest-maemo-utils.h:
554 * src/maemo/modest-maemo-utils.c: Added
555 modest_maemo_show_information_note_in_main_context_and_forget().
556 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
557 Use the new function to show simple error dialogs in the main
558 context, though question dialogs are still in the current context,
559 which is unfortunately usually not the main context. This should
562 2007-07-25 Murray Cumming <murrayc@murrayc.com>
564 * src/modest-tny-account-store.c: (get_password):
565 Never save the entered username and password in gconf,
566 because the UI spec says we should not. This helps
567 slightly with projects.maemo.org bug NB#63671.
569 2007-07-25 Murray Cumming <murrayc@murrayc.com>
571 * src/widgets/modest-msg-edit-window.h:
572 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
573 Moved some code here to make it simpler.
574 (modest_msg_edit_window_attach_file_one): Renamed from
575 modest_msg_edit_window_attach_file_interactive().
576 (modest_msg_edit_window_offer_attach_file): Renamed from
577 modest_msg_edit_window_attach_file() and used
578 modest_msg_edit_window_attach_file_one() instead of
579 copy/pasting the code. The old code for one was not using
580 GnomeVFS. This allows use of smb:// URLs when using send-as
581 from external applications, fixing bug NB#63741.
583 (modest_msg_edit_window_insert_image),
584 (modest_msg_edit_window_add_attachment_clicked):
585 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
586 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
587 Adapted to the new function names.
589 2007-07-25 Murray Cumming <murrayc@murrayc.com>
591 (modest_platform_set_update_interval): Set the alarm recurrence
592 fields so that auto-update does not just happen the first time.
593 This should have fixed projects.maemo.org bug NB#63938.
595 When this happens you can see a printf when the D-Bus method is
597 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
599 However, I do not actually seem to get new POP messages even when
600 clicking the refresh button manually. A restart gets them.
601 This might be a problem in today's tinymail only.
603 2007-07-24 Murray Cumming <murrayc@murrayc.com>
605 * src/maemo/modest-maemo-global-settings-dialog.c:
606 (current_connection):
607 Avoid a crash (probably only in scratchbox) when strcmp()ing a
608 NULL when closing the dialog.
610 2007-07-24 Murray Cumming <murrayc@murrayc.com>
612 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
613 Remove the hacky send/receive that didn't work, and instead
614 refilter the treemodel to make the deleted email really vanish from
615 the UI (though the delete-from-menu code does has commented out
616 the code that does that). This fixes projects.maemo.org bug
619 2007-07-24 Murray Cumming <murrayc@murrayc.com>
621 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
622 Try a couple of tricks to force the treeview to update (
623 poke the folder, and do a send/receive refresh), but the deleted
624 email still appears with a strike-through instead of really being
627 2007-07-23 Murray Cumming <murrayc@murrayc.com>
629 * src/dbus_api/modest-dbus-callbacks.c:
630 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
631 because their ID is not human-readable (see the comment about
632 improvements needed to the osso-email-interface API) and
633 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
635 2007-07-23 Murray Cumming <murrayc@murrayc.com>
637 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
638 (add_folders_to_list), (on_dbus_method_get_folders),
639 (modest_dbus_req_filter):
640 * src/maemo/modest-maemo-utils.c:
641 (on_camel_account_get_supported_secure_authentication):
642 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
643 (on_header_view_focus_in):
644 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
645 * src/modest-formatter.c: (modest_formatter_create_body_part):
646 * src/modest-mail-operation.c: (recurse_folders),
647 (update_account_thread), (get_msgs_full_thread),
648 (modest_mail_operation_get_msgs_full),
649 (modest_mail_operation_xfer_msgs):
650 * src/modest-search.c: (search_mime_part_and_child_parts),
651 (modest_search_account), (modest_search_all_accounts):
652 * src/modest-tny-account.c:
653 (modest_tny_account_get_special_folder), (recurse_folders):
654 * src/modest-tny-local-folders-account.c:
655 (modest_tny_local_folders_account_query_passes):
656 * src/modest-tny-msg.c: (copy_mime_part),
657 (modest_tny_msg_find_body_part_from_mime_part):
658 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
659 (modest_tny_send_queue_try_to_send):
660 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
661 (_modest_ui_actions_open), (download_uncached_messages),
662 (reply_forward), (modest_ui_actions_on_copy),
663 (modest_ui_actions_on_details), (has_retrieved_msgs),
664 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
666 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
667 (_selected_msg_marked_as), (_msg_download_completed),
668 (_selected_msg_sent_in_progress):
669 * src/widgets/modest-attachments-view.c:
670 (modest_attachments_view_set_message):
671 * src/widgets/modest-msg-view.c: (find_cid_image):
672 * tests/check_folder-transfer.c: (find_folders):
673 * tests/check_update-account.c: (func):
674 * tests/dbus_api/test_get_folders.c: (main):
675 Checked all uses of tny_iterator_get_current(), making sure
676 that the object is unreferenced (3 or 4 places did not),
677 and adding checks for NULL.
679 2007-07-23 Murray Cumming <murrayc@murrayc.com>
681 * src/dbus_api/modest-dbus-callbacks.c:
682 (on_idle_open_default_inbox): Make sure that the application UI is
684 * src/maemo/easysetup/modest-easysetup-wizard.c:
685 (on_entry_invalid_character): Show the word whitespace instead
686 of (null) in the banner when whitespace was entered.
687 (show_error): Add a comment that this does not work in
688 Maemo Bora, though we do not know why.
690 2007-07-23 Murray Cumming <murrayc@murrayc.com>
692 * src/modest-tny-account.c:
693 (modest_tny_account_get_special_folder): Use an if instead of
694 an assert for when the parent account name is NULL, because this
695 might be causing a crash in projects.maemo.org bug 63192.
696 * src/modest-mail-operation.c:
697 (modest_mail_operation_send_new_mail_cb),
698 (modest_mail_operation_remove_folder): unref the folder that is
699 returned from modest_tny_account_get_special_folder().
701 2007-07-23 Murray Cumming <murrayc@murrayc.com>
703 * src/modest-ui-actions.c:
704 (modest_ui_actions_on_password_requested):
705 Show mail_ib_login_cancelled info banner when the user cancels
706 the protected password dialog, to fix projects.maemo.org
709 2007-07-23 Murray Cumming <murrayc@murrayc.com>
711 * src/maemo/modest-account-settings-dialog.c:
712 (create_page_outgoing): Put this page in a GtkScrolledWindow,
713 matching the UI mock-up in the UI spec, and allowing access
714 to all widgets even when the on-screen keyboard is active.
716 2007-07-23 Murray Cumming <murrayc@murrayc.com>
718 Reverted this previous commit from Johannes,
719 because the scrollbars are always visible and because
720 I think we only need it on onepage of the account
721 settings, not the account wizard.
722 (I wrote the wrong instructions in the bug.)
724 * src/maemo/easysetup/modest-easysetup-wizard.c:
725 Added scrollbars to account wizard dialog.
726 Fixed projects.maemo.org NB #62744
728 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
730 * src/maemo/easysetup/modest-easysetup-wizard.c:
731 (create_page_user_details):
732 Use auto-cap for name (projects.maemo.org NB#63716)
733 * src/widgets/modest-account-view.c: (on_account_busy_changed):
735 2007-07-22 Armin Burgmeier <armin@openismus.com>
737 * src/maemo/modest-ui-actions.c: Use current account instead of
738 default account for creating viewer windows, so that the viewer
739 window knows to which account the viewed message belongs.
741 * src/maemo/modest-msg-view-window.c: Destroy the window when the
742 corresponding account is deleted. This fixes projects.maemo.org bug
745 2007-07-18 Armin Burgmeier <armin@openismus.com>
747 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
748 the dialog close after entering an invalid port number and clicking
749 OK. This fixes projects.maemo.org bug NB#63602.
751 2007-07-18 Armin Burgmeier <armin@openismus.com>
753 * src/modest-tny-account-store.c:
754 (get_server_accounts): Set parent modest account name for each
755 connection-specific transport account so that special folders of such
756 an account can be looked up. This fixes a crash when changing account
757 settings. This might also be related to projects.maemo.org bug
760 2007-07-16 Armin Burgmeier <armin@openismus.com>
762 * src/modest-ui-actions.c: Added a button to create a folder to the
763 move-to dialog. This fixes projects.maemo.org bug NB#59863.
765 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
767 * src/maemo/easysetup/modest-easysetup-wizard.c:
768 Added scrollbars to account wizard dialog.
769 Fixed projects.maemo.org NB #62744
771 2007-07-16 Murray Cumming <murrayc@murrayc.com>
773 * src/widgets/modest-msg-view.h:
774 * src/widgets/modest-msg-view.c:
775 Added modest_msg_view_get_message_is_empty() but this needs
777 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
778 Check if there is any text in the message yet.
779 But this needs to be implemented properly.
780 (modest_msg_edit_window_toggle_find_toolbar):
781 * src/maemo/modest-msg-view-window.c:
782 (modest_msg_view_window_toggle_find_toolbar):
783 Show a banner warning if there is no text to search, when
784 trying to start a search. This partially fixes
785 projects.maemo.org bug NB#62350.
787 2007-07-13 Murray Cumming <murrayc@murrayc.com>
789 * src/modest-mail-operation.c: (update_account_thread):
790 Initialized num_new_headers to fix the build.
792 2007-07-13 Murray Cumming <murrayc@murrayc.com>
794 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
795 Ignore modest accounts whose server accounts don't exist in gconf.
796 This prevents us trying to create TnyAccount instances for those
797 server accounts when the server account has been removed from gconf,
798 but the parent modest account has not yet been removed from modest.
799 I don't know why this is only noticeable now. It was probably just
800 a harmeless g_warning() anyway.
802 2007-07-13 Murray Cumming <murrayc@murrayc.com>
804 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
805 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
807 2007-07-12 Armin Burgmeier <armin@openismus.com>
809 * src/maemo/modest-main-window.c: Make default account appear bold
810 in view, tools/send & receive and toolbar/send & receive SCM menus.
811 This fixes projects.maemo.org bug NB#59010.
813 2007-07-12 Murray Cumming <murrayc@murrayc.com>
815 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
816 Add a short-cut, by checking if the folder store is an account.
817 This ensures that the Sort menu item and toolbar is dimmed for
818 the local-folders account root item, fixing
819 projects.maemo.org bug NB#62545.
821 2007-07-12 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-tny-account-store.c: (get_password):
824 Show the password dialog (via the signal) only in the mainloop, via
825 an idle handler that we wait for. This could theoretically prevent
826 hangs, though I worry that it could introduce some too.
828 2007-07-12 Murray Cumming <murrayc@murrayc.com>
830 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
831 * src/maemo/modest-platform.c:
832 (modest_platform_connect_and_wait):
833 Take a TnyAccount* parameter and try to set it to online
834 (a TnyCamel-only API), because tinymail sets accounts to offline
835 when the user cancels a password dialog, and doesn't ask again until
836 it has been set to online.
837 However, this is commented out because it causes a hang now.
839 (modest_platform_connect_and_wait_if_network_account):
840 * src/modest-mail-operation.c:
841 (modest_mail_operation_update_account):
842 * src/modest-platform.h:
843 * src/modest-ui-actions.c: (_modest_ui_actions_open),
844 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
846 2007-07-12 Armin Burgmeier <armin@openismus.com>
848 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
850 * src/modest-mail-operation.c:
851 * src/modest-ui-actions.c: Check for already existing folder before
852 querying the server, show error message from camel if the request
853 still fails. This fixes projects.maemo.org bug NB#58701.
855 2007-07-12 Murray Cumming <murrayc@murrayc.com>
857 * src/modest-tny-account-store.h:
858 * src/modest-tny-account-store.c:
859 Added modest_tny_account_store_forget_password_in_memory(),
860 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
861 when creating a new account, so that new passwords will be used, instead of
862 us thinking that it's a second request as a result of a failed password again.
864 2007-07-12 Murray Cumming <murrayc@murrayc.com>
866 * src/dbus_api/modest-dbus-callbacks.c:
867 (on_idle_open_message): If the message is in drafts then open it
868 in an edit window instead of a view window. This fixes
869 projects.maemo.org bug NB#63005.
871 2007-07-12 Murray Cumming <murrayc@murrayc.com>
873 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
874 Avoided a harmless g_warning().
876 2007-07-12 Murray Cumming <murrayc@murrayc.com>
878 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
879 Pass the modest account name, not the TnyAccount display name to
880 modest_msg_view_window_new() so that the reply feature works,
881 fixing projects.maemo.org bug NB#62892.
883 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
884 (modest_msg_view_window_new_with_header_model):
885 * src/maemo/modest-msg-view-window.c:
886 (modest_msg_view_window_new_with_header_model),
887 (modest_msg_view_window_new):
888 * src/modest-ui-actions.c: (reply_forward):
889 * src/widgets/modest-msg-view-window.h:
890 * src/widgets/modest-window.c: (modest_window_set_active_account):
891 Rename an account parameter to modest_account_name to make this clearer.
893 2007-07-11 Murray Cumming <murrayc@murrayc.com>
895 * src/modest-ui-actions.h:
896 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
897 modest_do_message_delete().
898 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
899 Call modest_do_message_delete(), hoping that this would cause messages
900 to be really deleted from search instead of just marked with strike through.
901 Does not seem to help.
903 2007-07-11 Armin Burgmeier <armin@openismus.com>
905 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
906 priv->reselect to FALSE prior to calling
907 modest_folder_view_select_first_inbox_or_local() to prevent endless
908 recursion and thus a crash on startup.
910 2007-07-11 Armin Burgmeier <armin@openismus.com>
912 * src/maemo/modest-account-settings-dialog.h: Include
913 <gtk/gtknotebook.h> to fix the build (at least for me).
915 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
916 Use "New FolderN" as default suggested name if "New folder" already
917 exists, with N being the first free number, though never exceed "New
918 folder99" in which case we just fall back to "New Folder" even though
919 it already exists. This fixes projects.maemo.org bug NB#58663.
921 2007-07-11 Murray Cumming <murrayc@murrayc.com>
923 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
924 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
925 projects.maemo.org bug NB#62778.
927 2007-07-11 Murray Cumming <murrayc@murrayc.com>
929 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
930 Ignore the wrong (for now) secure-smtp setting in the presets -
931 just default to requiring secure authentication for SMTP, because
934 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
936 * src/widgets/modest-folder-view.c: (filter_row)
937 Do not show drafts folder (see UI specs)
939 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
941 * src/modest-ui-actions.c:
942 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
943 place and also not necessary.
945 * src/widgets/modest-folder-view.c: (filter_row)
946 Guess folder type and hide Sent & Outbox if necessary.
947 Fixed project.maemo.org NB#57328
949 2007-07-11 Murray Cumming <murrayc@murrayc.com>
951 * src/modest-ui-actions.h:
952 * src/modest-ui-actions.c:
953 (modest_ui_actions_on_delete_message):
954 Move some code into a new
955 modest_ui_actions_refresh_message_window_after_delete()
956 function so we can use it from elsewhere.
958 * src/dbus_api/modest-dbus-callbacks.c:
959 (on_idle_delete_message), (on_delete_message): Used an idle
960 handler, as we do for the other D-Bus method handlers.
961 Call modest_ui_actions_refresh_message_window_after_delete()
962 if the deleted message was open in a window. This fixed
963 projects.maemo.org bug NB#62862.
965 2007-07-11 Murray Cumming <murrayc@murrayc.com>
967 * src/modest-main.c: (main): Only show the UI at the start if
968 the showui command line option was given. For instance,
969 run-standalone src/modest showui
970 Otherwise, we wait for the top_application D-Bus method to
971 be sent by hildon-desktop when the application is selected
973 This allows us to run without a UI when osso-global-search
974 uses our D-Bus methods.
976 2007-07-11 Murray Cumming <murrayc@murrayc.com>
978 * src/dbus_api/modest-dbus-api.h: Added a define for a
979 top-application D-Bus method.
980 * src/dbus_api/modest-dbus-callbacks.c:
981 (on_top_application),
982 (modest_dbus_req_handler): Handle the top-application D-Bus
983 method, which might be an undocumented D-Bus signal sent by
984 hildon-desktop when it starts the application from the menu.
985 But I am not sure and I need to test it on the device, because
986 my scratchbox does not have the application in the menu now.
987 This method shows the main window, so that it can be invisible
988 when started, for instance, just for email searching from
991 * src/maemo/modest-main-window.c: (restore_settings),
992 (modest_main_window_new): Do not show the window immediately
993 upon creation. We show it later.
994 * src/modest-widget-memory.c: (save_settings_paned):
995 Try (unsuccessfully) to avoid saving the paned position when
996 it is not even visible.
997 (restore_settings_paned): Do not allow a silly paned position.
998 This seems necessary when not showing the window at first.
1000 * tests/dbus_api/Makefile.am:
1001 * tests/dbus_api/test_top_application.c: (main): Test for the
1004 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1006 * src/modest-ui-dimming-rules.c:
1007 (modest_ui_dimming_rules_on_new_msg),
1008 (modest_ui_dimming_rules_on_reply_msg),
1009 (modest_ui_dimming_rules_on_delete_msg),
1010 (modest_ui_dimming_rules_on_details),
1011 (modest_ui_dimming_rules_on_view_window_move_to),
1012 (modest_ui_dimming_rules_on_view_previous),
1013 (modest_ui_dimming_rules_on_view_next),
1014 (_invalid_folder_for_purge): Added checks before
1015 casting the window. This looks like an actual
1016 logic error in _invalid_folder_for_purge(), because it
1017 tries to use a ModestMainWindow as a message window.
1019 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1021 * src/maemo/modest-account-settings-dialog.c:
1022 (show_error): Use the same implementation as in
1023 modest-easysetup-wizard.c:
1024 (on_entry_invalid_character): The logical ID contains a %s.
1025 Guessed what it should be.
1026 (on_entry_max), (check_data), (on_response): Adapt to
1027 changed show_error().
1028 (create_page_account_details): Really call
1029 modest_validating_entry_set_func() on the correct widgets.
1030 * src/maemo/easysetup/modest-easysetup-wizard.c:
1031 (on_entry_invalid_character): Fix the logical ID here too.
1032 (create_page_account_details),
1033 (create_page_user_details):
1035 modest_validating_entry_set_func() on the correct widgets.
1037 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1038 Do not try to use the account if it is NULL.
1040 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1042 * src/modest-ui-actions.c: (create_move_to_dialog),
1043 (modest_ui_actions_on_main_window_move_to),
1044 (modest_ui_actions_on_msg_view_window_move_to):
1045 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
1046 (filter_row), (modest_folder_view_show_non_move_folders):
1047 * src/widgets/modest-folder-view.h:
1049 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
1050 the Sent folder yet as it does not report the correct folder type.
1052 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1054 * src/maemo/modest-msg-edit-window.c: (init_window):
1057 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1059 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1060 Take a parent widget instead of a parent window, and
1061 implement this with hildon_banner_show_information() instead.
1062 Non-Maemo builds can just ifdef that there.
1063 This fixed projects.maemo.org bug NB#62766.
1065 (on_entry_invalid_character): Use show_error() again instead
1066 of using hildon directly, and use the _CS() macro to use the correct
1068 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1069 Pass a widget instead od a window to show_error().
1071 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1073 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1074 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1075 This allows us to show the server name in the error message, fixing
1076 projects.maemo.org bug NB#62904.
1077 Also, use the appropriate logical ID message for the account protocol.
1079 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1082 A compilation fix, though the build wasn't broken for me.
1084 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1086 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1087 Do not try to unref a NULL folder store, to avoid a runtime warning.
1088 This seems to happen sometimes when changing accounts settings.
1090 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1092 * src/modest-tny-account-store.c:
1093 (modest_tny_account_store_instance_init),
1094 (modest_tny_account_store_finalize),
1095 (on_account_settings_hide), (on_idle_wrong_password):
1096 Use a GHashTable to ensure that we only show one account settings
1097 dialog per modest account. This avoids us having a dialog open for
1098 both the store and transport accounts, or due to repeated get_password()
1099 calls that shouldn't happen anyway.
1101 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1103 * src/maemo/modest-maemo-utils.c: (on_hide),
1104 (modest_maemo_show_dialog_and_forget): Handle the response, because
1105 the window is not even hidden by default.
1107 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1108 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1109 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1110 which seems to prevent some modality problems.
1112 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1113 Ignore user cancellation errors.
1115 * src/modest-account-mgr-helpers.h:
1116 * src/modest-account-mgr-helpers.c:
1117 Added modest_server_account_get_password() and
1118 modest_server_account_get_has_password() to avoid direct use of
1121 * src/maemo/modest-account-settings-dialog.h:
1122 * src/maemo/modest-account-settings-dialog.c:
1123 (modest_account_settings_dialog_init): Store the notebook so we can
1125 Added modest_account_settings_dialog_switch_to_user_info().
1127 * src/modest-tny-account-store.c:
1128 (get_password): When the password in the account settings is wrong (we think),
1129 show the relevant page of the account settings dialog, in the mainloop.
1130 However, we currently get many of these at once because cancel does not
1132 (forget_password): Do not forget the password
1133 from the account settings, because this causes side-effects when
1134 tinymail seems to call it at strange time, maybe because of how we
1135 are cancelling get_password().
1136 (modest_tny_account_store_alert): Ignore user cancellations.
1138 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1140 * src/maemo/modest-maemo-utils.h:
1141 * src/maemo/modest-maemo-utils.c:
1142 Added modest_maemo_show_information_note_and_forget() for use instead of
1143 gtk_dialog_run() when the response is not needed, to avoid an extra
1144 mainloop which could cause a hang.
1146 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1147 Use the logical IDs for the error message, though they are not
1148 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1149 because gtk_dialog_run() caused a hang here (the window did not close).
1150 This fixes projects.maemo.org bug NB#62646.
1152 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1154 * src/modest-account-mgr-helpers.h:
1155 * src/modest-account-mgr-helpers.c:
1156 Added modest_account_mgr_get_store_protocol().
1158 * src/maemo/modest-account-view-window.c:
1159 (on_delete_button_clicked): Show different warning text depending on
1160 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1161 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1164 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1166 * src/maemo/modest-msg-edit-window.c:
1167 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1168 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1170 2007-07-07 Armin Burgmeier <armin@openismus.com>
1172 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1173 ckdg_ib_maximum_characters_reached from correct package.
1175 * src/modest-ui-actions.c: Show an error message when a folder could
1176 not be created. Tinymail does not give us specific error codes about
1177 what has gone wrong, so we assume that a folder with that name
1178 already exists, though there might be other reasons.
1180 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1182 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1183 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1184 give a more exact error message that can be partly translated.
1186 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1188 * src/maemo/modest-address-book.c:
1189 (select_email_addrs_for_contact): Specify a default window size for the
1190 select-email-address dialog, so that it is probably big enough for the
1191 title. This should fix projects.maemo.org bug NB#62277.
1193 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1195 * src/maemo/easysetup/modest-easysetup-wizard.c:
1196 (create_page_complete_easysetup): Use
1197 gtk_widget_set_size() request to ensure that the text wraps
1200 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1202 * src/maemo/easysetup/modest-easysetup-wizard.c:
1203 (on_entry_invalid_character), (create_page_account_details),
1204 (create_page_user_details):
1205 Use new API of ModestValidatingEntry. But for some reason the banner is
1206 not shown. I will have to investigate that further.
1208 * src/widgets/modest-validating-entry.c: (on_insert_text),
1209 (modest_validating_entry_set_func):
1210 * src/widgets/modest-validating-entry.h:
1211 Added a new callback function to be able to react to prevented
1212 characters whitespaces to e.g show a banner.
1214 2007-07-05 Armin Burgmeier <armin@openismus.com>
1216 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1217 notification of HildonNumberEditor instead of remembering the port
1218 number. Thanks to Johannes for pointing this out.
1220 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1222 * src/maemo/easysetup/modest-easysetup-wizard.c:
1223 Check if there are any user changes before showing a confirmation
1224 dialog (projects.maemo.org NB#60946)
1226 2007-07-05 Armin Burgmeier <armin@openismus.com>
1228 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1229 number at the beginning of the dialog and set the modified flag at the
1230 end if the port number has changed. This is necessary because
1231 HildonNumberEditor does not support notification when the value has
1234 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1236 * src/modest-ui-actions.c:
1237 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1238 a connection before asking anything else. Correct the check for the destination
1239 folder so that it succeeds when online.
1240 This fixed projects.maemo.org bug NB#61645.
1242 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1244 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1245 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1246 to fix projects.maemo.org bug NB#62439.
1248 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1250 * src/modest-tny-account.c: (on_connection_status_changed):
1251 Really do not use tny_device_force_offline() here. See the previous comment.
1253 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1255 * src/modest-tny-account.c: (on_connection_status_changed):
1256 Do not use tny_device_force_offline() when tinymail says that something
1257 went wrong with the connection. It seems to report this unnecessarily.
1259 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1261 * src/maemo/modest-connection-specific-smtp-window.c:
1262 (modest_connection_specific_smtp_window_init):
1263 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1264 does not seem to have any effect in osso 1.1 (though it works in
1265 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1267 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1269 * src/maemo/modest-connection-specific-smtp-window.c:
1270 Fix UI specification problems with projects.meamo.org NB#60479
1272 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1274 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1275 clue when this has failed, because the error dialog is not always shown
1276 (at least in earlier version).
1278 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1279 GError message, because the generic error dialog is not helpful.
1281 'This message is not currently available (can't let a new connection go online)'
1282 when trying to open an IMAP message.
1284 (_modest_ui_actions_open): Offer a connection when some messages would
1285 have to be downloaded and we are offline.
1287 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1289 * src/widgets/modest-folder-view.c:
1290 Don't check for MERGE type anymore as we use the correct type
1292 NOTE: For the last two changes you need to update your tinymail copy
1293 because of API changes!
1295 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1297 * src/modest-tny-local-folders-account.c:
1298 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1299 (see projects.maemo.org NB#61580)
1301 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1303 * src/modest-tny-account.c: (on_connection_status_changed):
1304 Commented out the call to modest_platform_connect_and_wait() because this
1305 seems to always hang, and I would like to know if this is the only thing
1306 that causes a hang when showing the connection dialog.
1307 It is not very useful anyway.
1309 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1311 * src/maemo/modest-msg-view-window.c:
1312 (modest_msg_view_window_select_next_message):
1314 * src/modest-platform.h:
1315 * src/maemo/modest-platform.c:
1316 Added modest_platform_connect_and_wait(), which calls
1317 tny_maemo_conic_device_connect() always in the main thread, by calling it
1318 in an idle handler and waiting for the idle handler to run. It should be
1319 in the main thread because it uses GTK+ UI code. It just returns TRUE
1320 if the device is already online.
1322 There is some nasty code to ensure that subsequent calls to
1323 modest_platform_connect_and_wait() just wait for the first one to finish,
1324 by checking repeatedly in another idle handler. This is necessary,
1325 because other threads (or even the main thread, via another idle handler)
1326 can call modest_platform_connect_and_wait() while
1327 modest_platform_connect_and_wait() is running.
1329 (modest_platform_connect_and_wait_if_network_account),
1330 (modest_platform_connect_and_wait_if_network_folderstore):
1331 Convenience functions that calls modest_platform_connect_and_wait() if
1332 the account or folder might want network access.
1334 * src/modest-mail-operation.c:
1335 (modest_mail_operation_update_account):
1336 * src/modest-ui-actions.c: (download_uncached_messages),
1337 (modest_ui_actions_on_rename_folder), (delete_folder),
1338 (modest_ui_actions_on_main_window_move_to),
1339 (modest_ui_actions_on_msg_view_window_move_to):
1340 * src/widgets/modest-folder-view.c:
1341 (drag_and_drop_from_folder_view):
1342 Offer a connection if we are offline.
1344 * src/modest-tny-account.c: (on_connection_status_changed):
1345 Document this as only handling errors during network operations in progress,
1346 and replace the idle code with a simple call to
1347 modest_platform_connect_and_wait(), which does this instead.
1349 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1351 * src/modest-tny-account.c:
1352 (modest_tny_account_get_special_folder): (util_on_idle),
1353 Handle the GError so we can see when tny_folder_store_get_folders()
1354 fails, as it currently does while something else is connecting.
1356 Added util_run_in_main_thread_and_wait()
1357 which uses an idlen handler and mainloop to ensure that the function
1358 is called in the main thread.
1359 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1360 to make sure that we call attempt the connection in the mainloop only,
1361 which might solve some hangs.
1363 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1365 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1366 be found by their display name. This is never useful.
1367 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1368 by its ID, instead of trying to use its ID as its display name.
1370 * src/modest-tny-account-store.h:
1371 * src/modest-tny-account.c:
1372 (modest_tny_account_get_special_folder): Add a g_warning() when
1373 tny_folder_store_get_folders() returns an empty list for the maildir.
1375 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1376 Add a g_warning() when this returns NULL, because that it not allowed
1379 2007-07-02 Armin Burgmeier <armin@openismus.com>
1381 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1382 note when trying to cancel the wizard. This fixes projects.maemo.org
1385 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1387 * src/modest-tny-account.h:
1388 * src/modest-tny-account.c:
1389 (modest_tny_account_new_from_server_account),
1390 (modest_tny_account_new_from_server_account_name),
1391 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1392 because this must now be set before setting the proto. This is usd in
1393 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1394 warning in camel_session_get_service() caused by
1395 tny_camel_transport_account_prepare().
1397 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1400 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1402 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1404 (modest_connection_specific_smtp_edit_window_init):
1406 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1407 of "changed" for now
1409 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1411 * src/modest-tny-account.c:
1412 (modest_tny_account_new_from_server_account):
1413 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1414 now uses to request a connection when it needs one, and which it uses
1415 to tell us that something is wrong with the connection, so we can force
1416 the accounts offline to prevent further problems.
1418 * src/modest-defs.h:
1419 * src/modest-init.c: (init_default_settings):
1420 * src/modest-mail-operation.c:
1421 (modest_mail_operation_update_account):
1422 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1423 This should not be necessary anymore. Do not set the conf key that
1424 determined this (it was always TRUE and not set anywhere else).
1426 * src/modest-ui-actions.h: Remove unused and unimplemented
1427 modest_ui_actions_on_online_toggle_toggled().
1429 2007-06-29 Murray Cumming <murrayc@murrayc.com
1431 * src/maemo/modest-main-window.c: (connect_signals):
1432 Don't connect to delete_event twice. Maybe this was harmless.
1434 2007-06-29 Murray Cumming <murrayc@murrayc.com
1436 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1437 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1438 Debug output to give some more clue when a folder move is not allowed.
1440 2007-06-28 Murray Cumming <murrayc@murrayc.com
1442 * src/modest-tny-account.c: (on_modest_file_system_info),
1443 (modest_tny_account_get_mmc_account_name):
1444 Always call the callback, without checking whether the name has changed.
1445 * src/widgets/modest-folder-view.c: (strings_are_equal),
1446 (on_model_foreach_set_name), (on_get_mmc_account_name),
1447 (text_cell_data): Compare the name here, and use the name from
1448 the account rather than from the
1449 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1450 if the name was changed after the account was added to the model.
1451 That's a tinymail bug but not one that I want to fix now.
1453 This finally fixes projects.maemo.org bug NB#59301.
1455 2007-06-27 Armin Burgmeier <armin@openismus.com>
1457 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1460 2007-06-27 Murray Cumming <murrayc@murrayc.com
1462 * src/modest-tny-account.h:
1463 * src/modest-tny-account.c:
1464 Added modest_tny_account_get_mmc_account_name(), to set the memory
1465 card name asynchronously for the given account and then notify.
1466 (modest_tny_account_new_for_local_folders): Use this new function instead
1467 of using hildon_file_system_info_async_new() directly.
1469 * src/widgets/modest-folder-view.c: (text_cell_data):
1470 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1471 gtk_tree_model_row_changed() when it is available.
1473 This should fix projects.maemo.org bug NB#59301.
1475 2007-06-27 Murray Cumming <murrayc@murrayc.com
1477 * src/modest-mail-operation.c: (update_account_thread),
1478 (get_msgs_full_thread): Fix typo failures in the revert
1481 2007-06-27 Murray Cumming <murrayc@murrayc.com
1483 * src/maemo/modest-maemo-global-settings-dialog.c:
1484 (idle_select_default_focus):
1485 * src/modest-mail-operation.c: (idle_notify_progress),
1486 (idle_notify_progress_once), (set_last_updated_idle),
1487 (update_account_thread), (get_msgs_full_thread):
1488 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1489 * src/widgets/modest-header-view.c:
1490 (idle_notify_headers_count_changed_destroy),
1491 (idle_notify_headers_count_changed):
1492 Reverted the additions of gdk_threads_enter/leave(), in case this
1493 helps with a startup hang on the device.
1495 2007-06-26 Armin Burgmeier <armin@openismus.com>
1497 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1498 for supported secure authentication methods from server by
1499 gtk_dialog_run(), saving CPU time and a potential race condition.
1501 2007-06-26 Armin Burgmeier <armin@openismus.com>
1503 * src/maemo/modest-maemo-utils.h:
1504 * src/maemo/modest-maemo-utils.c: Added a
1505 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1506 only error code to tell the calling code when the user canceled the
1509 * src/maemo/modest-account-settings-dialog.h:
1510 * src/maemo/modest-account-settings-dialog.c:
1511 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1512 message if the retrieval of secure authentication methods was canceled
1513 by the user. Perform the check before saving anything to configuration
1514 to not end up with half-committed configuration changes, do not show
1515 a "Saving to configuration failed" note when authentication methods
1516 could not be retrieved.
1518 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1521 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1523 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1524 Only return the first level of folders under accounts, because the
1525 osso-global-search UI spec doesn't want the rest.
1526 This fixed projects.maemo.org bug NB#61811.
1528 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1530 * src/modest-tny-account-store.c:
1531 * src/modest-tny-account-store.h:
1532 Added modest_tny_account_is_memory_card_account().
1533 * src/maemo/modest-main-window.c: (create_details_widget):
1534 Show the same information items for the memory card as we show for the
1535 local-folders, to fix projects.maemo.org bug NB#59307.
1537 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1539 * src/modest-tny-account-store.c: (get_password):
1540 Added some checks for NULL to maybe prevent crashes, though I think
1541 it was Philip's last commit that actually prevented the crash here
1542 when creating a first new account.
1543 But the new account is still not usable (no messages are shown)
1544 until a restart of the application.
1546 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1548 * src/maemo/modest-maemo-global-settings-dialog.c:
1549 (idle_select_default_focus):
1550 * src/modest-mail-operation.c: (idle_notify_progress),
1551 (idle_notify_progress_once), (idle_notify_update_account_queue),
1552 (set_last_updated_idle), (update_account_thread),
1553 (notify_get_msgs_full), (get_msgs_full_destroyer),
1554 (get_msgs_full_thread):
1555 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1556 * src/widgets/modest-header-view.c:
1557 (idle_notify_headers_count_changed_destroy),
1558 (idle_notify_headers_count_changed):
1559 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1560 all idle handlers, because some other thread could be blocking
1561 the GDK lock, so that it can do GUI stuff.
1563 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1565 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1566 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1567 (on_idle_send_receive), (on_idle_open_default_inbox):
1568 * src/maemo/modest-msg-edit-window.c:
1569 (modest_msg_edit_window_attach_file_noninteractive):
1570 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1571 to prevent a hang. I don't quite understand why these are necessary,
1572 beause we should already be in the main loop. I guess something outside
1573 of the main loop is taking the lock.
1575 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1576 we are really using URIs, and use files that are more likely to exist.
1578 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1580 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1581 necessary because configure.ac now defines different variables.
1583 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1585 * libmodest-dbus-client/libmodest-dbus-client.c:
1586 * libmodest-dbus-client/libmodest-dbus-client.h:
1587 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1588 libmodest_dbus_client_compose_mail() is what things actually use.
1590 * src/dbus_api/modest-dbus-api.h:
1591 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1592 * tests/dbus_api/Makefile.am:
1593 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1596 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1598 * src/modest-init.c: (modest_init_local_folders):
1599 For memory-card (or other non local-folders) maildir accounts,
1600 always create an Archive folder, so that there is somewhere to put
1601 messages. This should be less confusing, because the user does not need
1602 to guess that the need to create a folder.
1604 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1606 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1607 Fixed icon size by using (50, 50) which is the same as defined by
1610 2007-06-25 Armin Burgmeier <armin@openismus.com>
1612 * src/widgets/modest-window-mgr.c:
1613 * src/modest-init.c:
1614 * configure.ac: Correctly recognize hildon-notify presence and fixed
1615 the build without it being installed.
1617 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1619 * libmodest-dbus-client/libmodest-dbus-client.c:
1620 (libmodest_dbus_client_search): Fix the build. Sorry.
1621 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1622 (reply_forward_cb): Initialize variables to fix the build.
1624 * src/modest-tny-account-store.c:
1625 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1626 comparison (a silly typo) so that email search results can be opened
1627 when there are more than one account.
1629 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1631 * libmodest-dbus-client/libmodest-dbus-client.c:
1632 (libmodest_dbus_client_search),
1633 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1634 instead of 1 second, because the search gets folders and messages from
1635 the server, which can take a long time. When it times out,
1636 osso-global-search will report no results.
1638 We need to specify whether we should search only cached information
1639 (maybe with a user preference), and the osso-email-search-plugin
1640 API should really be improved to allow that option, and to allow results
1641 to be delivered asynchronously in batches.
1643 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1645 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1646 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1647 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1649 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1651 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1652 that is an empty string. D-Bus seems to give us these instead of NULL.
1654 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1656 * src/dbus_api/modest-dbus-callbacks.c:
1657 * src/maemo/easysetup/modest-easysetup-wizard.h:
1658 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1659 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1660 (modest_connection_specific_smtp_edit_window_init):
1661 * src/maemo/modest-maemo-global-settings-dialog.c:
1663 * src/maemo/modest-maemo-utils.c:
1664 (modest_maemo_utils_setup_images_filechooser):
1665 * src/maemo/modest-main-window.c: (create_details_widget):
1666 * src/maemo/modest-msg-edit-window.c:
1667 (modest_msg_edit_window_attach_file_noninteractive),
1668 (modest_msg_edit_window_color_button_change),
1669 (modest_msg_edit_window_set_zoom):
1670 * src/modest-mail-operation.c: (update_account_thread):
1671 * src/modest-tny-account-store.c:
1672 * src/modest-tny-account.c:
1673 * src/widgets/modest-global-settings-dialog.c:
1674 * src/widgets/modest-window.h:
1676 Fixed build on bora!
1678 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1680 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1681 * src/modest-search.c: (modest_search_folder),
1682 (modest_search_all_accounts): Actually search only in the specified folder,
1683 doing a simple match on the folder ID.
1684 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1685 and added some documentation.
1687 2007-06-22 Armin Burgmeier <armin@openismus.com>
1689 * src/maemo/modest-maemo-utils.h:
1690 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1691 modest_maemo_utils_get_supported_secure_authentication_methods.
1693 * src/maemo/easysetup/modest-easysetup-wizard.c:
1694 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1695 one occured, not just "Server does not support secure authentication".
1697 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1699 * src/modest-tny-account-store.c: (get_password):
1700 Restored the call to tny_account_set_user() because Philip seems to have
1701 stopped this from crashing (by not using the freed string). It still does
1702 not work, but now we can test it.
1704 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1706 * src/maemo/modest-msg-edit-window.c: (init_window):
1707 Comment out use of an uninitialzed GtkScrolledWindow variable,
1708 to fix the build and stop a crash. Yet again.
1710 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1712 * src/modest-tny-account-store.c: (get_password):
1713 Remove the call to tny_account_set_user() because this actually crashes.
1714 As mentioned in the last commit, it is known to not work anyway.
1716 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1718 * src/modest-tny-account-store.c: (get_password):
1719 Use tny_account_set_username() to tell tinymail that the username might
1720 have changed too. But tinymail ignores this: see projects.maemo.org
1722 * src/modest-ui-actions.c:
1723 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1724 reset the connection when changing the username, and improve the comments.
1725 Save the changed username to gconf at least, so it is used when Modest is
1728 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1730 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1731 Do not use a query, so that we get all folders, including for POP and
1732 local-folders. They work as search criteria too.
1733 This fixes projects.maemo.org bug NB#57740.
1735 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1737 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1738 Comment out the use of hildon_notification_set_sound() because it is
1739 not declared, to fix the build. Warnings are serious, people.
1741 2007-06-21 Armin Burgmeier <armin@openismus.com>
1743 * src/maemo/modest-maemo-utils.h:
1744 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1745 modest_maemo_utils_get_supported_secure_authentication_methods()
1746 to query authentication methods for a specific user. This should fix
1747 projects.maemo.org bug NB#61369.
1749 * src/maemo/easysetup/modest-easysetup-wizard.c:
1750 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1753 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1755 * libmodest-dbus-client/libmodest-dbus-client.h:
1756 * libmodest-dbus-client/libmodest-dbus-client.c:
1757 (modest_dbus_message_iter_get_search_hit),
1758 (libmodest_dbus_client_search):
1759 Reorganised and commented this.
1760 Removed modest_search_hit_free() from the public API because it
1763 Added libmodest_dbus_client_get_folders() and
1764 modest_folder_result_list_free().
1766 * src/dbus_api/modest-dbus-api.h:
1767 * src/dbus_api/modest-dbus-callbacks.c:
1768 (modest_dbus_req_filter): Commented. Moved most code to
1769 on_dbus_method_search() and added on_dbus_method_get_folders().
1771 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1772 of the extra D-Bus handler.
1774 * tests/dbus_api/Makefile.am:
1775 * tests/dbus_api/test_get_folders.c: New test for
1776 libmodest_dbus_client_get_folders(). This seems to return an empty list
1777 at the moment. That could be the same error that causes the message list
1778 to be empty sometimes.
1779 This should help with projects.maemo.org bug NB#57740.
1781 2007-06-21 Armin Burgmeier <armin@openismus.com>
1783 * src/modest-mail-operation.c: Do not call
1784 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1785 notify the operation's end after having set the status to CANCELED for
1786 the operation queue to listen on. This fixes a deadlock when there
1787 were mail operations in the queue during its finalization.
1789 * src/modest-singletons.c: Reordered uninitialization of the account
1790 manager to happen after the mail operation queue was uninitialized
1791 because the mail operation's in the queue might still try to access
1792 the account manager (see modest_mail_operation_notify_end()). This
1793 fixes a potential crash when terminating the application.
1795 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1797 * src/modest-search.c:
1798 (search_mime_part_and_child_parts): Moved some code here so we
1799 can search recursively in child folders.
1800 (modest_search_folder): Search in the message as a mime part, instead
1801 of just its child mime parts.
1802 (read_chunk), (search_mime_part_ogs):
1803 Check how many bytes were read, to prevent an endless loop.
1804 Searching in message bodies now works. This finishes the fix for
1805 projects.maemo.org bug NB#61007.
1807 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1809 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1810 Add a g_warning when the item is not a folder.
1812 * src/modest-ui-dimming-rules.c:
1813 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1814 when selected item is not a folder (for instance, an account), because
1815 the UI spec only talks about folders.
1816 I am not sure what the UI spec wants, so this might not totally fix
1817 projects.maemo.org bug NB#60794.
1819 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1821 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1822 (load_from_file): Sort the list. The unsorted list would be more noticeable
1823 in non-English locales.
1825 * src/maemo/modest-msg-edit-window.c:
1826 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1827 warning and fix the build.
1829 * src/maemo/modest-progress-bar-widget.c:
1830 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1831 avoid a g_warning, and probably to avoid a crash.
1833 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1835 * src/modest-search.c: (modest_search_folder): Check for a GError
1836 when calling tny_folder_get_headers(), to show that this is not the cause
1839 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1841 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1842 Actually set the body query instead of the subject query.
1844 * src/modest-search.c: (search_mime_part_ogs),
1845 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1846 which would probably cause it to fail if we got this far.
1848 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1849 to simplify the code.
1850 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1851 be causing search-in-body to fail.
1853 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1855 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1857 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1858 Better debug message when the folder cannot be found.
1859 This should help with fixing projects.maemo.org bug #61287.
1860 * src/modest-search.c: (add_hit): Do not leak the furl string.
1862 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1864 * src/modest-ui-actions.c:
1865 (modest_ui_actions_on_folder_selection_changed):
1866 Do not special-case TNY_MERGE_FOLDER here, because
1867 modest_tny_folder_get_account() already does that. This fixes
1868 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1869 shown when the Outbox was selected).
1871 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1873 * libmodest-dbus-client/libmodest-dbus-client.c:
1874 (_dbus_iter_get_string_or_null): Initialize the string variable in
1875 case this helps with Dirk's crash.
1877 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1879 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1880 though it is not implemented yet (this function is maybe not even used),
1881 to avoid breaking ABI in future.
1882 * libmodest-dbus-client/libmodest-dbus-client.c:
1883 (get_attachments_string): Moved some code into this generic function.
1884 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1885 sends email. It is maybe not used.
1886 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1887 (on_send_mail): Use attachments.
1889 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1890 * src/maemo/modest-msg-edit-window.c:
1891 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1892 a filename before using it, to fix projects.maemo.org bug NB#58233.
1894 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1896 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1897 Initialize the continue_download variable to fix the build, and probably
1898 to fix randome behaviour.
1900 2007-06-18 Armin Burgmeier <armin@openismus.com>
1902 * src/modest-tny-send-queue.h:
1903 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1904 the queue so we can later show it in the UI. Replaced
1905 modest_tny_send_queue_msg_is_being_sent() by
1906 modest_tny_send_queue_get_msg_status().
1908 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1910 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1911 gpointer. This probably was not harmful, but just to be sure.
1913 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1915 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1916 Fix the build, but leave the function broken on Bora, because
1917 hildon_uri_action_get_service() does not exist.
1918 osso_uri_action_get_service() does not exist either, it seems.
1920 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1922 * src/modest-tny-account.c:
1923 (modest_tny_account_new_from_server_account):
1924 Uncommented the url debug output again, because it is useful for
1925 debugging, as I said in the comment.
1927 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1929 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1931 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1932 for Mameo Bora, to fix the build.
1934 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1937 Fixed build with hildon < 0.99
1939 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1940 Check if the selected account is busy instead of checking all accounts
1942 * src/modest-account-mgr-priv.h:
1943 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1944 (modest_account_mgr_init), (compare_account_name),
1945 (modest_account_mgr_set_account_busy),
1946 (modest_account_mgr_account_is_busy):
1947 * src/modest-account-mgr.h:
1948 Added busy information to the account manager. It possible to
1949 set an account to busy or not busy now.
1951 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1952 (modest_mail_operation_update_account),
1953 (modest_mail_operation_notify_end):
1954 Set the account to busy/not busy depending on the operation state.
1956 * src/widgets/modest-account-view.c:
1957 (modest_account_view_finalize), (get_last_updated_string),
1958 (update_account_view), (on_account_busy_changed), (init_view):
1959 Show string "Refreshing..." if the account is currently busy.
1961 All this fixes projects.maemo.org bug NB#59711
1963 2007-06-14 Armin Burgmeier <armin@openismus.com>
1965 * src/widgets/modest-attachments-view.h:
1966 * src/widgets/modest-attachments-view.c: Added
1967 modest_attachments_view_has_attachments() and fixed coordinate
1968 transformation in get_att_view_at_coords(). This fixes attachment
1971 * src/widgets/modest-msg-view.c: Make use of
1972 modest_attachments_view_has_attachments() to decide whether to show
1973 attachments in the header.
1975 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1977 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1978 (on_change), (on_combo_security_changed),
1979 (modest_connection_specific_smtp_edit_window_init),
1980 (modest_connection_specific_smtp_edit_window_set_connection),
1981 (modest_connection_specific_smtp_edit_window_is_dirty):
1982 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1983 * src/maemo/modest-connection-specific-smtp-window.c:
1986 Show an comfirmation dialog for the smpt-edit-window if there are
1987 unsaved changes and the user hits cancel.
1988 (projects.maemo.org bug NB#60479)
1990 2007-06-14 Armin Burgmeier <armin@openismus.com>
1992 * src/maemo/easysetup/modest-easysetup-wizard.c:
1993 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1994 address" info in banner instead of node, and select all the text as
1995 per UI spec. This fixes projects.maemo.org bug NB#60550.
1997 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1999 reviewed by: <delete if not using a buddy>
2001 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
2002 * src/modest-ui-actions.c: (folder_refreshed_cb):
2004 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2006 * src/widgets/modest-folder-view.c: (filter_row):
2007 Explictly filter out the per-account outbox accounts. I don't know why
2008 these only sometimes show up, but now they should never show up in the UI.
2009 This should fix projects.maemo.org bug NB#60160.
2011 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2013 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
2014 when the toolbar does not exist yet.
2015 * src/modest-widget-memory.c: (save_settings_header_view):
2016 Added g_warnings() to help us to discover when we are trying to set
2017 an empty columns list in gconf.
2019 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2021 * src/modest-init.h:
2022 * src/modest-init.c:
2023 Added modest_init_get_default_header_view_column_ids().
2025 * src/modest-widget-memory.c: (restore_settings_header_view):
2026 Use the new function to get defaults, if the gconf key is empty,
2027 instead of not creating any columns. This seems to fix the
2028 empty right-hand pane problems.
2030 * src/widgets/modest-header-view.h: Improved documentation.
2032 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2034 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2035 Revert the use of the display name as the account name, because this
2036 is generally wrong and would break the code that follows.
2038 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2040 * src/maemo/easysetup/modest-easysetup-wizard.c:
2041 (check_for_supported_auth_methods), (on_before_next),
2044 More correct fix for projects.maemo.org bug NB# 58991
2045 Do not longer accept AUTH_PASSWORD as secure method and choose
2046 correct method when creating the account.
2048 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2050 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2051 Fixed projects.maemo.org bug NB# 58991
2053 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2055 * src/modest-init.c: (modest_init_init_core),
2056 (modest_init_local_folders): Fixed compilation errors.
2058 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2060 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2061 Remove unnecessary lib/include, though it is good in principle when needed.
2063 * src/modest-init.c: (modest_init_one_local_folder),
2064 (modest_init_local_folders):
2065 * src/modest-init.h: Initialize the .modest library for memory cards,
2066 instead of just doing nothing for them. This should allow us to create
2067 folders there, fixing projects.maemo.org bug NB#59297.
2069 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2071 * libmodest-dbus-client/libmodest-dbus-client.c:
2072 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2073 (libmodest_dbus_client_compose_mail),
2074 (libmodest_dbus_client_open_message),
2075 (libmodest_dbus_client_send_and_receive),
2076 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2078 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2079 (on_idle_open_message), (modest_dbus_req_handler),
2080 (search_result_to_message), (modest_dbus_req_filter):
2081 * src/modest-search.c: (add_hit), (modest_search_folder),
2082 (modest_search_all_accounts): Improved debug messages.
2084 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2086 * src/modest-tny-account-store.c:
2087 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2090 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2093 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2095 * src/modest-tny-account-store.c: (get_server_accounts):
2096 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2097 even when there are no accounts, so that the Outbox folder is always
2098 visible. This fixes projects.maemo.org bug NB#60158.
2100 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2102 * src/maemo/modest-main-window.c: (create_details_widget):
2103 Use the mcen_va_never logical ID.
2105 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2107 * src/dbus_api/modest-dbus-api.h:
2108 * src/dbus_api/modest-dbus-callbacks.c:
2109 (on_idle_open_default_inbox), (on_open_default_inbox),
2110 (modest_dbus_req_handler):
2111 Added a new OpenDefaultInbox method.
2113 * libmodest-dbus-client/libmodest-dbus-client.h:
2114 * libmodest-dbus-client/libmodest-dbus-client.c:
2115 Added libmodest_dbus_client_open_default_inbox() to call the new
2116 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2117 though it should maybe be used by a new osso-email-interface function.
2119 * tests/dbus_api/Makefile.am:
2120 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2123 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2125 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2126 NULL, so that the signals get all the keys. This should not actually
2127 change any behaviour because we currently update everything when anything
2130 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2132 * src/widgets/modest-folder-view.c: (text_cell_data),
2133 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2134 (find_inbox_iter): If tinymail tells us that the folder is
2135 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2136 This causes the inbox to be selected at startup, fixing part of
2137 projects.maemo.org bug NB#56305.
2139 * src/modest-ui-dimming-rules.c:
2140 (modest_ui_dimming_rules_on_tools_smtp_servers):
2141 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2142 the SMTP servers menu item.
2143 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2144 that the SMTP Servers menu item is dimmed when there are no accounts,
2145 as a future version of the UI spec will require. This fixes
2146 projects.maemo.org bug NB#56305.
2148 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2150 * src/maemo/modest-maemo-utils.c:
2151 (modest_maemo_utils_get_supported_secure_authentication_methods):
2152 Added label to dialog instead of unreadable title
2154 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2155 (modest_main_window_new):
2156 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2159 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2160 * src/modest-account-mgr.h:
2161 Added method to avoid code duplication
2163 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2164 (modest_ui_actions_on_send_receive):
2165 Use modest_account_mgr_has_accounts
2167 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2169 * src/maemo/easysetup/modest-presets.c:
2170 (modest_presets_get_info_server_security): Do not report secure auth
2172 * src/modest-protocol-info.c: Use the defines for the gconf key names
2173 for secure authentication. This was not working because we were writing
2174 Password and reading password, and the check was case sensitive.
2175 With this, gmail now works for receiving and sending when created via
2178 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2180 * src/maemo/easysetup/modest-presets.c:
2181 (modest_presets_get_info_server_security): Correct the key name for
2182 SecureSmtp, because it seems to be case-sensitive.
2183 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2184 Do not try to get the 0th notebook page if there are 0 pages, to
2185 avoid a g_warning().
2187 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2189 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2190 Prevent use of the new notification feature for now, because it currently
2191 shows one dialog for each new email, which is annoying.
2193 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2195 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2196 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2197 when no country was selected, so that we show the global ones.
2198 * src/maemo/easysetup/modest-presets.c:
2199 (modest_presets_get_providers): Return only the global providers, not
2200 all providers when mmc=0 was requested.
2202 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2204 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2205 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2206 provider ID in the combo.
2208 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2209 Do not show the page numbers, because it would be confusing when we add
2210 the 2 extra pages for the custom setup, when the user chooses the "Other"
2211 provider. This fixes projects.maemo.org bug NB#59028
2213 * src/modest-init.c: (modest_init_init_core),
2214 (modest_init_local_folders):
2215 * src/modest-init.h:
2216 * src/modest-tny-account.c:
2217 (modest_tny_account_new_for_local_folders): Do not create default folders
2218 for the memory card. This should fix projects.maemo.org bug NB#59328.
2220 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2222 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2223 Free the changed_conf_keys string items. They are already freed in the
2224 idle handler if that runs first.
2226 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2228 * src/modest-ui-actions.c:
2229 (modest_ui_actions_on_password_requested): Check that the server name
2230 is not NULL, because I just saw a password dialog with (null) as the
2233 * src/modest-tny-folder.[h|c]: Added
2234 modest_tny_folder_is_memory_card_folder().
2235 * src/modest-ui-dimming-rules.c:
2236 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2237 menu item for memory cards, as per the UI spec (section 7.4). This should
2238 fix projects.maemo.org bug NB#59297.
2240 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2242 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2243 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2244 is another problem with the code, see Murray's comment at line 772)
2246 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2248 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2249 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2250 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2251 (load_from_file), (easysetup_country_combo_box_init),
2252 (easysetup_country_combo_box_get_active_country_ids),
2253 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2254 instead of just one ID, to avoid duplicate country names in the UI.
2256 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2257 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2258 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2259 a single ID, avoiding duplicate providers.
2260 * src/maemo/easysetup/modest-easysetup-wizard.c:
2261 (on_combo_account_country): Adapt to use a list.
2263 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2265 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2266 keys changed in the last X seconds.
2268 * src/modest-account-mgr.h:
2269 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2270 (on_key_change), (modest_account_mgr_class_init),
2271 (modest_account_mgr_init), (modest_account_mgr_finalize):
2272 As the keys are changed, save them in a GSList* and signal that GSList*
2273 further every X seconds, to batch changes, to allow us to do just one
2274 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2275 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2277 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2278 changed signal signature.
2280 * src/modest-conf.c: (modest_conf_set_list),
2281 (modest_conf_on_change): Reenable notification.
2283 (modest_conf_maemo_fake_on_change): Comment out the hack that
2284 notified immediately instead of asynchronously.
2286 * src/widgets/modest-account-view.h:
2287 * src/widgets/modest-account-view.c:
2288 (update_account_view): Select the previously-selected account ID,
2289 if possible. This fixes projects.maemo.org bug NB#56933.
2291 (on_account_changed), (on_account_removed),
2292 (modest_account_view_select_account):
2294 Remove the block/unblock functions
2295 because they were not useful.
2297 * src/maemo/modest-account-view-window.c:
2298 (on_delete_button_clicked), (on_edit_button_clicked),
2299 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2301 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2303 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2304 Improve the error dialog to show Incorrect Account Settings, which seems
2305 clearer, and say that the internal error message (to be removed from the
2306 dialog later) is often misleading.
2307 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2309 * src/modest-tny-account.c:
2310 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2311 URL because this is so useful for debugging on the device.
2313 * src/widgets/modest-serversecurity-combo-box.c:
2314 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2316 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2318 * src/modest-mail-operation.c:
2319 (modest_mail_operation_send_new_mail):
2320 Added a comment about a nasty but apparently harmless message. Details
2321 added to the wiki g_warnings() page.
2323 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2325 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2326 (modest_tny_send_queue_class_init):
2327 Do not use the priv struct because it is empty, to avoid g_warnings
2328 about a non-existant priv struct.
2330 * src/modest-tny-account-store.c:
2331 (modest_tny_account_store_get_server_account),
2332 (modest_tny_account_store_get_transport_account_for_open_connection
2333 ): Do not try to get transport server accounts for local folders,
2334 because they don't have any. This avoids a g_warning().
2336 * src/maemo/modest-main-window.c:
2337 (modest_main_window_notify_send_receive_initied),
2338 (on_configuration_key_changed):
2339 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2340 * src/modest-defs.h:
2341 * src/modest-mail-operation.c:
2342 (modest_mail_operation_update_account):
2343 * src/modest-tny-account-store.h:
2344 * src/modest-tny-account.c:
2345 (modest_tny_account_get_special_folder),
2346 (modest_tny_account_new_for_local_folders),
2347 (modest_tny_account_new_for_per_account_local_outbox_folder):
2348 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2349 * src/modest-tny-local-folders-account.c:
2350 (add_account_folders_to_merged_folder):
2351 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2352 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2353 (modest_ui_actions_on_send):
2354 * src/widgets/modest-folder-view.c: (update_model):
2355 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2356 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2357 modest_tny_account_store_get_tny_account_by_account() to
2358 modest_tny_account_store_get_server_account() to make the code clearer.
2360 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2362 * src/dbus_api/modest-dbus-api.h:
2363 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2364 * src/maemo/modest-msg-edit-window.c:
2365 (modest_msg_edit_window_attach_file_noninteractive):
2366 added g_warning in case the file to be attached does not exist
2367 * tests/dbus_api/test_compose_mail.c: (main):
2368 removed obsolete comment, added generic files as test case
2370 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2372 * src/modest-tny-account-store.c: (get_server_accounts):
2373 Create the local folders account only once, not once for each outbox, and
2374 not only when there are some outboxes.
2376 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2378 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2379 code that is causing a crash at startup. Sergio says that he is fixing this.
2381 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2383 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2384 * src/maemo/modest-account-settings-dialog.c:
2385 (create_page_outgoing),
2386 (modest_account_settings_dialog_set_account_name),
2387 (save_configuration):
2388 - Fixed handling of the "Use secure authentication" toggle to comply with
2389 the ui specification. See also projects.maemo.org bug NB#58400
2391 - Restore the Secure connection setting combo correctly when loading
2394 * src/maemo/modest-maemo-utils.c:
2395 (on_camel_account_get_supported_secure_authentication),
2396 (modest_maemo_utils_get_supported_secure_authentication_methods):
2397 Fixed a crasher if operation is canceled
2399 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2400 (modest_protocol_info_auth_is_secure):
2401 * src/modest-protocol-info.h:
2403 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2404 the sense of the "Use secure authentication" toggle.
2406 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2408 * src/modest-tny-account-store.h:
2409 * src/modest-tny-account-store.c:
2410 Added modest_tny_account_store_get_local_folders_account().
2412 * src/modest-tny-folder.h:
2413 * src/modest-tny-folder.c:
2414 (modest_tny_folder_get_account):
2415 Added this replacement for tny_folder_get_account() which returns
2416 the local-folders account for TnyMergeFolders, to avoid the
2417 warning about the unimplemented get_account_func() vfunc().
2419 (modest_tny_folder_get_rules),
2420 * src/modest-ui-actions.c:
2421 (modest_ui_actions_on_folder_selection_changed):
2422 * src/modest-mail-operation.c:
2423 (modest_mail_operation_remove_folder),
2424 (modest_mail_operation_xfer_folder),
2425 (modest_mail_operation_rename_folder),
2426 (modest_mail_operation_get_msg),
2427 (modest_mail_operation_get_msgs_full),
2428 (modest_mail_operation_remove_msg),
2429 (modest_mail_operation_xfer_msgs),
2430 (modest_mail_operation_refresh_folder):
2431 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2433 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2435 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2436 (modest_server_account_set_security):
2437 * src/modest-defs.h: Add comments explaining that our
2438 UI spec means TLS when it says Normal, so these do not look like errors.
2440 * src/modest-tny-account.c:
2441 (modest_tny_account_new_from_server_account): Use the new tinymail
2442 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2443 for TLS. This should fix projects.maemo.org bug NB#58460.
2445 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2447 * src/maemo/easysetup/modest-easysetup-wizard.c:
2448 (create_account): Correct the position of the gconf sanity check warning.
2449 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2450 of using the g_idle_add() hack, because this does not seem to be necessary
2451 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2452 caused by something other than maemo's gconf.
2453 This fixes projects.maemo.org bug #59022.
2455 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2457 * src/modest-account-mgr-helpers.c:
2458 (modest_account_mgr_get_default_account): Do not check that the account
2459 exists if there is no default account (NULL), to fix a runtime warning.
2461 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2463 * src/widgets/modest-folder-view.c: (update_model):
2464 Do not unref the treemodel before we have finished with it.
2465 This prevents a valgrind warning and an occasional crash at startup.
2467 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2469 * libmodest-dbus-client/libmodest-dbus-client.h:
2470 added libmodest_dbus_client_compose_mail()
2471 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2473 added functions needed for SendAsMail() functionality
2474 * src/maemo/modest-msg-edit-window.c:
2475 (modest_msg_edit_window_attach_file_noninteractive):
2476 non interactively attaching files to message edit window
2477 * src/widgets/modest-msg-edit-window.h:
2478 * tests/dbus_api/Makefile.am:
2479 added test_compose_mail.c
2480 * tests/dbus_api/test_compose_mail.c: (main):
2482 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2484 * src/modest-account-view.c:
2485 Fixed bug projects.maemo.org bug NB#59307
2487 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2489 * src/maemo/easysetup/modest-easysetup-wizard.c:
2490 (get_serverport_incoming), (on_before_next), (create_account):
2491 * src/maemo/modest-account-settings-dialog.c:
2492 (modest_account_settings_dialog_set_account_name):
2493 * src/maemo/modest-maemo-utils.c:
2494 (on_camel_account_get_supported_secure_authentication_status),
2495 (on_camel_account_get_supported_secure_authentication),
2496 (on_secure_auth_cancel),
2497 (modest_maemo_utils_get_supported_secure_authentication_methods):
2499 Implemented security authentication for settings and easysetup.
2501 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2503 * src/maemo/modest-main-window.c: (create_details_widget):
2504 Show the total size for memory card accounts too, instead of showing
2505 the name again. Fixes bug projects.maemo.org bug NB#59307.
2507 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2510 * src/modest-tny-simple-folder-store.c:
2511 * src/modest-tny-simple-folder-store.h: Removed.
2513 * src/modest-tny-local-folders-account.h
2514 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2515 for the local-folders maildir, with an extra TnyMergedFolder containing
2516 the folders of the per-account outbox store accounts.
2517 * src/modest-tny-account-store.c: (get_server_accounts):
2518 Add the outboxes to the special local folders account after creating it.
2520 * src/modest-tny-account.c:
2521 (modest_tny_account_new_for_local_folders): Create the derived
2522 account when creating the main local-folders account.
2524 * src/maemo/modest-main-window.c: (create_details_widget),
2525 (modest_main_window_set_contents_style):
2526 Adapted to the use of the derived account instead of the folder store.
2528 * src/modest-ui-actions.c:
2529 (modest_ui_actions_on_folder_selection_changed):
2530 * src/modest-ui-dimming-rules.c:
2531 (modest_ui_dimming_rules_on_new_folder):
2532 * src/widgets/modest-folder-view.c: (text_cell_data),
2533 (icon_cell_data), (filter_row), (update_model),
2534 (get_cmp_rows_type_pos):
2537 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2538 Do not get the priv struct, because no priv struct has been set,
2539 to avoid a runtime warning.
2541 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2542 #ifelse with #else, to fix a warning, to fix the build.
2545 2007-06-05 Christian Kellner <ckellner@openismus.com>
2547 * libmodest-dbus-client/libmodest-dbus-client.c:
2548 Fix small typo in doc (why do you always see them
2549 AFTER committing stuff?)
2552 2007-06-05 Christian Kellner <ckellner@openismus.com>
2554 * libmodest-dbus-client/libmodest-dbus-client.c:
2555 (libmodest_dbus_client_search):
2556 Initialize hit list with NULL. Also set folder list
2557 to "" if NULL was supplied.
2560 2007-06-03 Christian Kellner <ckellner@openismus.com>
2562 * libmodest-dbus-client/libmodest-dbus-client.c:
2563 (modest_search_hit_list_free):
2564 Make it save to call it with NULL.
2566 * src/dbus_api/modest-dbus-callbacks.c:
2567 * src/modest-search.c:
2568 Return full ModestSearchHits as the search result list not TnyHeader
2569 since can't be around withouth the correspoding TnyFolder.
2571 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2573 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2574 Added currently commented code to check for secure auth
2576 * src/maemo/modest-account-settings-dialog.c: (on_response),
2577 (save_configuration), (show_ok):
2578 Fixed projects.maemo.org bugs NB #59248 and #59251
2580 * src/maemo/modest-maemo-utils.c:
2581 (on_camel_account_get_supported_secure_authentication_status),
2582 (on_camel_account_get_supported_secure_authentication),
2583 (modest_maemo_utils_get_supported_secure_authentication_methods):
2584 * src/maemo/modest-maemo-utils.h:
2585 Moved get_supported_secure_authentication() method here to be able
2586 to use it from easysetup wizard.
2588 * src/modest-pair.c: (on_pair_compare_as_string):
2589 Should compare string with first part of pair and not
2590 strcmp pairs which will crash.
2592 * src/modest-protocol-info.c:
2593 (modest_protocol_info_protocol_is_store):
2594 * src/modest-protocol-info.h:
2595 Added modest_protocol_info_get_auth_protocol_name()
2597 2007-06-03 Armin Burgmeier <armin@openismus.com>
2599 * src/modest-mail-operation.c:
2600 (modest_mail_operation_get_msgs_full): Set priv->account also when
2601 only retrieving a single message. This avoids a crash when canceling
2604 (modest_mail_operation_notify_end): Do not explicitely remove the
2605 operation from the queue but only emit the progress_changed signal.
2606 The queue itself listens to that signal to remove the operation when
2607 it is finished. This reduces coupling and removes a potential deadlock
2608 when modest_mail_operation_notify_end() is called from the queue
2609 itself. If that is a problem performance-wise, I would suggest to
2610 implement a status-changed signal or something.
2612 * src/modest-mail-operation-queue.c: Make sure to never call a
2613 function from another file while the queue is locked. This (hopefully)
2614 fixes another deadlock when exiting the application while retrieving
2617 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2619 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2620 Fixed build if libogs is not available
2622 2007-06-03 Christian Kellner <ckellner@openismus.com>
2624 * libmodest-dbus-client/libmodest-dbus-client.h:
2625 * libmodest-dbus-client/libmodest-dbus-client.c:
2626 (libmodest_dbus_client_delete_message):
2627 Implement deletion of messages (Client side).
2629 (modest_search_hit_free),
2630 (modest_search_hit_list_free):
2631 Utility functions to free the result hits.
2633 * src/dbus_api/modest-dbus-api.h:
2634 * src/dbus_api/modest-dbus-callbacks.c:
2635 (on_delete_message),
2636 (modest_dbus_req_handler):
2637 Implement deletion of messages (Server side).
2639 * tests/dbus_api/test_search.c: (main):
2642 * tests/dbus_api/Makefile.am:
2643 * tests/dbus_api/test_delete_message:
2644 Add little test for the message deletion logic
2646 2007-06-03 Armin Burgmeier <armin@openismus.com>
2648 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2649 when the operation queue was not empty. projects.maemo.org bug
2652 2007-06-03 Armin Burgmeier <armin@openismus.com>
2654 * src/widgets/modest-account-view.c
2655 (on_account_default_toggled): Toggle default account column
2656 explicitely instead of waiting for gconf notification (which is
2657 currently ignored). This should fix projects.maemo.org bug NB#56910
2658 for now. It should probably be removed when gconf notifications are
2661 2007-06-03 Christian Kellner <ckellner@openismus.com>
2663 * libmodest-dbus-client/libmodest-dbus-client.c:
2664 Removed debugging spew.
2666 * src/dbus_api/modest-dbus-callbacks.c:
2667 Added debugging info.
2669 * src/modest-search.c:
2670 (modest_search_all_accounts):
2671 Use tny_account_store_get_accounts () on the account store
2672 to get all accounts which is the way to get all accounts.
2674 * tests/dbus_api/test_search.c: (main):
2675 Make it possible to supply the search term on the command line.
2677 2007-06-03 Christian Kellner <ckellner@openismus.com>
2679 * libmodest-dbus-client/libmodest-dbus-client.c:
2680 * libmodest-dbus-client/libmodest-dbus-client.h:
2681 Implement searching for mesages over raw dbus. (Client side)
2683 * src/dbus_api/Makefile.am:
2684 * src/dbus_api/modest-dbus-api.h:
2685 * src/dbus_api/modest-dbus-callbacks.c:
2686 * src/dbus_api/modest-dbus-callbacks.h:
2687 Search framework (Server side). Also implement on_idle_open_message().
2689 * src/maemo/modest-platform.c: (modest_platform_init):
2690 Prepare for raw dbus/osso rpc interaction.
2692 * src/modest-search.h:
2693 Changed minsize from unspecific guint to guint32.
2695 * src/modest-search.c:
2697 Added strange hack which magically made tnymail work.
2699 (modest_search_folder),
2700 (modest_search_account),
2701 (modest_search_all_accounts):
2702 Implement helper functions to search all accounts, specific account
2705 * tests/dbus_api/Makefile.am:
2706 * tests/dbus_api/test_open_message.c:
2707 Read url to open from commandline.
2709 * tests/dbus_api/test_search.c:
2710 Implement small test for dbus search stuff
2712 2007-06-02 Armin Burgmeier <armin@openismus.com>
2714 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2715 include account type and account title. This fixes projects.maemo.org
2718 * src/maemo/modest-account-view-window.c: Set a title for the window.
2720 2007-06-02 Armin Burgmeier <armin@openismus.com>
2722 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2723 incoming and outgoing server name based on email address and server
2724 types as long as the names have not been edited manually. This fixes
2725 projects.maemo.org bug NB#58671.
2727 2007-06-02 Armin Burgmeier <armin@openismus.com>
2729 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2730 server type cannot be changed in future to the incoming details page
2731 when creating an account. This fixes projects.maemo.org bug NB#59029.
2733 2007-06-02 Armin Burgmeier <armin@openismus.com>
2735 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2736 and assigned max width chars so that they wrap instead of being
2737 truncated. Fixes projects.maemo.org bug NB#56126.
2739 2007-06-02 Armin Burgmeier <armin@openismus.com>
2741 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2742 introductory note to the connection specific smtp servers dialog, as
2743 section 8.12 of the email UI specification requires. This fixes
2744 projects.maemo.org bug NB#59212.
2746 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2748 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2749 Check for running mail operations, and offer to cancel them, as per the UI
2750 spec. This fixes projects.maemo.org bug NB#59041 .
2751 However, I suspect that tinymail may still use the network connection
2752 in ways that we cannot detect or cancel. But it should at least adapt to
2753 changes fairly well.
2755 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2757 * src/modest-tny-account-store.c: (recreate_all_accounts),
2758 (get_cached_accounts), (get_server_accounts): Do more sensible
2759 ref-counting of the temporarily-cached outbox accounts list. This seems
2760 to fix a crash when entering the password when the password was wrong.
2762 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2764 * src/gnome/modest-main-window.c: (connect_signals):
2765 * src/modest-tny-account-store.c: (get_password),
2766 (modest_tny_account_store_alert): Added comments and clues and
2767 commented-out code about how we currently fail to deal with connection
2768 errors and wrong passwords, and how we should.
2770 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2772 * src/widgets/modest-retrieve-combo-box.c:
2773 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2774 This fixes projects.maemo.org bug NB#58472 .
2776 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2778 * src/maemo/easysetup/modest-easysetup-wizard.c:
2779 (create_page_complete_easysetup):
2780 (create_page_complete_custom): Correct the last commit,
2781 putting the correct sentences in the correct pages.
2783 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2785 * src/maemo/easysetup/modest-easysetup-wizard.c:
2786 (create_page_complete_custom): Show the second sentence of text
2787 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2790 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2792 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2793 Set the leave-on-server conf key by default. This fixes
2794 projects.maemo.org bug NB#59258 .
2796 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2798 * src/maemo/modest-account-view-window.c:
2799 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2800 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2803 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2805 * src/maemo/easysetup/modest-easysetup-wizard.c:
2806 (create_caption_new_with_asterisk):
2807 * src/maemo/modest-account-settings-dialog.c:
2808 (create_caption_new_with_asterisk):
2809 Uncomment the code to add the asterisk, because they are no longer in the
2810 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2811 (update_incoming_server_title): Add an asterisk here too.
2813 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2815 * src/maemo/modest-maemo-global-settings-dialog.c:
2816 (current_connection): Check that we are even connected before trying to
2817 get the current connection name, to prevent a warning.
2819 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2820 Change the comments because tny_maemo_conic_device_connect() is now meant to
2822 * src/modest-mail-operation.c:
2823 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2824 make sure we have a connection and fail if we can't connect.
2826 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2828 * src/maemo/modest-main-window.c:
2829 (on_account_store_connecting_finished): Do not try to get the
2830 connection ID if we are not really connected. I am surprised that
2831 this signal handler is called when we are not connected.
2833 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2835 * src/modest-error.h:
2836 * src/modest-ui-actions.c:
2837 (modest_ui_actions_get_msgs_full_error_handler):
2838 Renamed an enum, added comments, added an enum
2839 for retrieve-limit errors.
2841 * src/modest-mail-operation.c: (foreach_add_item),
2842 (internal_folder_observer_update), (update_account_thread),
2843 (modest_mail_operation_get_msgs_full):
2844 (modest_mail_operation_update_account),
2845 Added comments about how this works, and some code that should
2846 (but does not) check the retrieve-limit. See the TODO comment.
2848 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2850 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2851 Initialize help_id to fix the build. Warnings are good.
2853 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2855 * src/widgets/modest-hbox-cell-renderer.c:
2856 (modest_hbox_cell_renderer_append):
2857 * src/widgets/modest-vbox-cell-renderer.c:
2858 (modest_vbox_cell_renderer_append):
2859 Fix the last commit by doing an extra ref.
2861 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2863 * src/widgets/modest-hbox-cell-renderer.c:
2864 (modest_hbox_cell_renderer_append):
2865 * src/widgets/modest-vbox-cell-renderer.c:
2866 (modest_vbox_cell_renderer_append):
2867 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2868 to fix the build with Maemo Bora.
2869 However, there seems to be a remaining crash, probably due to reference
2872 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2874 * src/modest-tny-account.c:
2875 (modest_tny_account_new_for_local_folders):
2876 Use hildon_file_system_info_async_new() to get a better name for
2877 the memory card account, setting it as the account name.
2878 The timing seems to work, but this is probably
2879 not the best place to do this. See the TODO comment.
2880 * src/maemo/modest-main-window.c: (create_details_widget):
2881 * src/widgets/modest-folder-view.c: (text_cell_data):
2882 Use the tny account name instead of hardcoding a name.
2884 2007-05-30 Christian Kellner <ckellner@openismus.com>
2886 * src/modest-search.c: (modest_search):
2887 Correctly set part_search_func even if we have already parsed
2888 the query and thus a valid OgsTextSearcher object.
2890 2007-05-30 Christian Kellner <ckellner@openismus.com>
2893 Search and check for libogs.
2896 Incooparte the ogs build env.
2898 * src/modest-mime-part-search-stream.c:
2899 * src/modest-mime-part-search-stream.h:
2900 Removed since we do the real searching now in modest-search.c.
2902 * src/modest-search.c:
2903 * src/modest-search.h:
2904 Implement support for ogs. We use that if available and requested
2905 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2906 should now handle the corner case when the search term is spread
2907 across multiple reads.
2908 Also the logic in modest_search () was corrected to search all
2909 requested fields until one is found.
2911 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2913 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2915 * src/modest-init.h:
2916 * src/modest-init.c: Made modest_init_local_folders() take a
2917 path and be public so we can iniitialize maildir folders on
2920 * src/modest-local-folder-info.h:
2921 * src/modest-local-folder-info.c:
2922 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2924 * src/modest-tny-account.c:
2925 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2926 still means the standard local-folders path on the local volume.
2928 * src/modest-tny-account-store.c:
2929 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2930 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2931 all accounts when that happens.
2932 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2933 this too, so it shows up in the treeview.
2935 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2937 * src/maemo/modest-maemo-global-settings-dialog.c:
2938 (current_connection):
2939 * src/widgets/modest-global-settings-dialog.c:
2940 (current_connection_default):
2941 Use the enum values instead of 0, 1 and -1,
2942 to make the code clearer.
2944 * src/modest-account-mgr-helpers.c:
2945 (modest_account_mgr_get_connection_specific_smtp): Make this code
2948 * src/modest-runtime.h:
2949 * src/modest-runtime.c:
2950 Added modest_runtime_remove_all_send_queues().
2951 * src/maemo/modest-main-window.c:
2952 (on_account_store_connecting_finished): Recreate the send queues,
2953 using the appropriate transport accounts for this new connection.
2954 Some futher adapting might be needed if the old send queues are not
2955 automatically stopped at this point.
2957 * src/modest-tny-account-store.c: (get_server_accounts):
2958 Create the connection-specific transport accounts, so that they can
2959 be found later by their ID.
2961 * src/modest-tny-account.h:
2962 * src/modest-tny-account.c:
2963 Added modest_tny_account_new_from_server_account_name().
2964 modest_tny_account_new_from_server_account(): Do not create the
2965 send queues here, because they will be
2966 recreated anyway when the connection changes for the first time.
2968 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2970 * src/modest-local-folder-info.h:
2971 * src/modest-local-folder-info.c:
2972 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2973 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2974 tbox_folder): Take a modest account name instead of a server TnyAccount,
2975 so we can have per-modest-account rather than per-transport-account
2977 We must make sure that we change or recreate the exisitng send queues
2978 when the connection changes for connection-specific transport accounts.
2980 * src/modest-tny-account-store.c:
2981 (create_per_account_local_outbox_folders): Create outboxed per modest
2982 account, not per transport account.
2984 * src/modest-tny-account.h:
2985 * src/modest-tny-account.c:
2986 (modest_tny_account_get_special_folder): For outboxes, get the
2987 parent modest account name. The account is ignored for other folders.
2988 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2989 modest account name rather than a server TnyAccount.
2991 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2993 * src/modest-tny-account.c:
2994 (modest_tny_account_new_from_server_account):
2995 Call modest_runtime_get_send_queue() immediately after creating transport
2996 accounts, so that they start trying to send email from the outbox as soon
2997 as possible at startup. This is probably what we want.
2999 * src/modest-mail-operation.c: (update_account_thread):
3000 * src/modest-runtime.c: (modest_runtime_get_send_queue):
3001 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
3002 * src/modest-tny-send-queue.h:
3003 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
3004 (modest_ui_actions_on_send):
3005 Added comments about how sending works, though it needs some more work.
3007 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3009 * src/modest-tny-account.c:
3010 (modest_tny_account_get_special_folder): Add TODO because this fails when
3011 the network is busy.
3012 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
3013 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
3014 Do not try to show this window when there is no active account. The UI
3015 specs does not tell us what to do in this case.
3017 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3021 * src/maemo/Makefile.am:
3022 * src/widgets/Makefile.am: Some dist fixes.
3024 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3026 * src/maemo/modest-connection-specific-smtp-window.c:
3027 (on_button_edit): Make the code clearer, to prevent a double free.
3029 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3031 * src/maemo/modest-account-settings-dialog.c:
3032 (modest_account_settings_dialog_set_account_name),
3033 Check the connection-specific smtp servers checkbox if there are any.
3035 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3036 (modest_connection_specific_smtp_edit_window_init):
3037 Start with a suitable port number.
3039 * src/modest-account-mgr-helpers.h:
3040 * src/modest-account-mgr-helpers.c: Added
3041 modest_account_mgr_get_has_connection_specific_smtp().
3043 (modest_account_mgr_set_connection_specific_smtp),
3044 (modest_account_mgr_remove_connection_specific_smtp),
3045 (modest_account_mgr_get_has_connection_specific_smtp),
3046 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
3047 connection-specific smtp server accounts in the account, rather than
3048 the server account conf dir.
3050 This fixes bug projects.maemo.org bug NB#58263 .
3052 * src/modest-tny-account-store.c:
3053 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
3054 if there are no server accounts yet, to prevent an infinite loop when there
3055 are no accounts. Document that one must be called before the other.
3057 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3059 * src/modest-account-mgr-helpers.c:
3060 (modest_account_mgr_get_default_account): Make sure that at least
3061 one account is always the default, if there are any enabled accounts.
3062 This is just a sanity check that shouldn't be necessary.
3064 * src/modest-account-mgr-priv.c:
3065 (_modest_account_mgr_account_from_key): Unescape the conf key to
3066 get the real account name. For instance, this is an issue if a space
3067 was in the account name, which can happen because the account name
3068 is generated from the display name.
3069 (_modest_account_mgr_get_account_keyname): Always escape the
3071 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3072 Unescape the conf keys to get the real account names.
3074 For instance, previously the is-default radio button in the accounts
3075 list was not checked for any accounts at first. This fixes that,
3076 and might fix several similar bugs.
3078 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3080 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3081 Removed some debug printfs.
3083 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3085 Modest on-disk outbox directories are now here, for instance:
3086 $HOME/.modest/outboxes/<account-id-1>/outbox
3087 $HOME/.modest/outboxes/<account-id-2>/outbox
3089 $HOME/.modest/local-folders/outbox
3090 so we can have a separate outbox for each account.
3091 But they are shown as one outbox in the GtkTreeView, by using a
3092 TnyMergeFolder in a ModestTnySimpleFolderStore.
3095 * src/modest-tny-simple-folder-store.c:
3096 * src/modest-tny-simple-folder-store.h:
3097 Added ModestTnySimpleFolderStore, used to contain folders from
3098 other folder stores, such as other accounts.
3100 * src/modest-tny-outbox-account.h:
3101 * src/modest-tny-outbox-account.c:
3102 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3103 used for the per-account local outbox folders.
3105 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3106 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3107 only use this (internally) now for the non-outbox local folders.
3109 * src/modest-init.h:
3110 * src/modest-init.c: Added modest_init_one_local_folder(), for
3111 setting up the directory structure for each local folder.
3113 * src/modest-local-folder-info.c:
3114 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3115 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3117 * src/modest-local-folder-info.h:
3118 * src/modest-tny-account-store.c: (on_account_removed),
3119 (on_account_changed), (create_per_account_local_outbox_folders),
3120 (get_server_accounts), (modest_tny_account_store_get_accounts),
3121 (modest_tny_account_store_get_tny_account_by_account),
3122 (modest_tny_folder_store_is_virtual_local_folders):
3124 * src/modest-tny-account.h:
3125 * src/modest-tny-account.c:
3126 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3127 to create an on-disk per-account local outbox folder for each
3129 (create_per_account_local_outbox_folders): Create a local outbox folder
3130 for each transport account.
3131 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3132 for all local folders.
3134 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3135 instead of using g_object_get/set() directly. It is clearer.
3137 (modest_tny_folder_store_get_message_count),
3138 (modest_tny_folder_store_get_local_size
3139 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3140 because we now use these with non-acount folder stores.
3142 (modest_tny_account_get_special_folder),
3143 (modest_tny_account_new_from_server_account),
3144 (modest_tny_account_new_from_account):
3145 (recurse_folders): Adjust to the new outbox system.
3147 * src/modest-tny-folder.h:
3148 * src/modest-tny-folder.c:
3149 (modest_tny_folder_is_local_folder),
3150 (modest_tny_folder_get_local_folder_type),
3151 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3153 * src/widgets/modest-main-window.h:
3154 * src/maemo/modest-main-window.c: (create_details_widget),
3155 (modest_main_window_set_contents_style): Show details for any folder store,
3158 (modest_tny_folder_get_rules):
3159 Remove the const. C does not support constness enough for this.
3161 * src/modest-ui-actions.c:
3162 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3163 make all outboxes appear as one, in the usual local-folders tree node.
3165 (set_active_account_from_tny_account),
3166 (modest_ui_actions_on_folder_selection_changed):
3167 * src/widgets/modest-folder-view.c: (text_cell_data),
3168 (icon_cell_data), (filter_row),
3169 (add_account_folders_to_merged_folder),
3170 (add_account_folders_to_simple_folder_store), (),
3171 (get_cmp_rows_type_pos), (cmp_rows),
3172 (modest_folder_view_set_account_id_of_visible_server_account):
3173 Adjust to the new outbox system, using generic folder stores and folders
3174 in the GtkTreeModel.
3176 2007-05-23 Christian Kellner <ckellner@openismus.com>
3178 * src/modest-mail-operation.c:
3179 (modest_mail_operation_update_account):
3180 Use info->max_size instead of unintialized local var [small
3181 build fix]. (Added TODO to review that change since I don't
3184 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3186 * libmodest-dbus-client/libmodest-dbus-client.c:
3187 (libmodest_dbus_client_compose_mail): function added
3188 * src/dbus_api/modest-dbus-api.h:
3189 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3190 (on_compose_mail): Implementation of the SendAsMail functionality
3192 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3194 * src/modest-account-mgr.c:
3195 (modest_account_mgr_add_server_account): Set the secure-connection
3196 conf key for transport accounts as well as store accounts. I don't know
3197 why the if was there. For instance, this makes sure that we use SSL
3198 for the gmail preset from the easysetup wizard.
3200 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3202 * src/gnome/modest-main-window.c:
3203 (on_account_store_connecting_finished), (connect_signals):
3204 * src/maemo/modest-main-window.c:
3205 (on_account_store_connecting_finished), (connect_signals),
3206 (modest_main_window_new):
3207 Handle TnyAccountStore::connecting-finished instead of
3208 TnyDevice::connection-changed, because we cannot actually perform
3209 operations on accounts until TnyAccountStore has itself responded to
3210 the TnyDevice::connection-changed signal. This prevents a GError from
3212 Do not try to update at startup, because we (at least on scratchbox)
3213 already do an update at startup when the device goes online.
3214 This prevents a GError from tinymail.
3215 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3216 Added TODO about stopping simultaneous operations.
3218 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3220 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3221 * src/modest-mail-operation-queue.c:
3222 (modest_mail_operation_queue_remove):
3223 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3224 about where they happened.
3226 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3228 * src/modest-ui-actions.c:
3229 (modest_ui_actions_on_password_requested): Make sure that the remember
3230 output parameter is always TRUE.
3232 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3234 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3235 Show a OK/Cancel dialog if the error is a question, though we still do not
3236 know anything more about what we are asking the user.
3237 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3238 Fix an uninitialized variable (helper). This is a logic error, however.
3240 2007-05-21 Christian Kellner <ckellner@openismus.com>
3242 * src/modest-search.h:
3243 Correct bit shifting in the ModestSearchFlags enum.
3245 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3247 * src/modest-tny-account.c:
3248 (modest_tny_account_new_from_server_account): Do not use the lsub and
3249 check-all hard-coded IMAP options when using POP.
3251 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3253 * src/modest-tny-account.c:
3254 (modest_tny_account_new_from_server_account):
3255 Use NULL for the secure-auth method for POP when Password auth has been
3256 specified by the user, as we already do for IMAP. "auth=Login" causes
3257 an error from camel or the server.
3259 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3261 * src/maemo/modest-account-settings-dialog.c:
3262 (create_page_account_details),
3263 (modest_account_settings_dialog_set_account_name):
3264 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3265 for the leave-on-server checkbox, rathr than just the checkbox, when
3266 the protocol is not POP.
3268 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3270 * src/widgets/modest-account-view.c:
3271 * src/widgets/modest-account-view.h:
3272 Added modest_account_view_select_account() which will be useful later
3273 to asynchronously re-select the edited account.
3275 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3277 * src/maemo/modest-account-settings-dialog.c:
3278 (modest_account_settings_dialog_set_account_name):
3279 Automatically choose the port numbers based on the secure authentication
3280 methods, if they have not been chosen before.
3281 This fixes projects.maemo.org bug NB#56273 .
3283 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3285 * src/maemo/modest-main-window-ui.h:
3286 * src/modest-ui-actions.c:
3287 * src/modest-ui-actions.h:
3288 Connect the Tools/SMTP Servers menu item to
3289 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3290 SMTP servers dialog, as in the UI specification and saves changes when it
3291 is closed. This fixed projects.maemo.org bug NB#56305 .
3293 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3295 * src/maemo/modest-connection-specific-smtp-window.c:
3296 (modest_connection_specific_smtp_window_init):
3297 Use gtk_window_set_default_size() to make this window big enough, so
3298 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3300 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3302 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3303 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3304 (modest_connection_specific_smtp_edit_window_init),
3305 Do not try to connect to a combobox signal before the combobox exists.
3306 This fixes the cras in projects.maemo.org bug NB#56288 .
3307 (modest_connection_specific_smtp_edit_window_get_settings):
3308 Remove the server_account_name parameter which was being checked for NULL
3309 though it was not used.
3311 * src/maemo/modest-connection-specific-smtp-window.c:
3312 (modest_connection_specific_smtp_window_fill_with_connections),
3313 (on_button_edit), (modest_connection_specific_smtp_window_init):
3314 Correct the number of treemodel columns to prevent a warning.
3315 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3316 libconic does not work.
3318 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3320 * src/modest-tny-account.c:
3321 (modest_tny_account_new_from_server_account):
3322 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3323 SMTP when "None" was chosen by the user. However, with my SMTP server that
3324 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3327 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3329 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3330 to explain the memory management issue with the ID in the ModestPair.
3332 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3333 (add_sending_page), (modest_account_assistant_finalize):
3334 * src/gnome/modest-gnome-global-settings-dialog.c:
3335 (create_updating_page), (create_composing_page):
3336 * src/gnome/modest-msg-edit-window.c: (get_transports),
3337 (init_window), (modest_msg_edit_window_finalize),
3338 (modest_msg_edit_window_get_msg_data):
3339 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3340 * src/gnome/modest-transport-widget.c:
3341 (modest_transport_widget_finalize), (smtp_configuration):
3342 * src/maemo/modest-maemo-global-settings-dialog.c:
3343 (create_updating_page), (create_composing_page):
3344 * src/maemo/modest-msg-edit-window.c: (get_transports),
3345 (init_window), (modest_msg_edit_window_finalize),
3346 (modest_msg_edit_window_get_msg_data),
3347 (modest_msg_edit_window_free_msg_data):
3348 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3349 (modest_store_widget_finalize):
3350 * src/maemo/modest-transport-widget.c:
3351 (modest_transport_widget_finalize), (smtp_configuration):
3352 * src/modest-main.c: (send_mail):
3353 * src/widgets/modest-combo-box.h:
3354 * src/widgets/modest-global-settings-dialog-priv.h:
3355 * src/widgets/modest-global-settings-dialog.c:
3356 (modest_global_settings_dialog_finalize):
3357 * src/widgets/modest-msg-edit-window.h:
3358 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3359 as long as the combo box, to prevent use of freed memory for the ID.
3361 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3363 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3364 get_accounts(), to make this clearer. Do not check for the enabled gconf
3365 key, because we do not use this for server accounts (at least, not yet).
3366 This allows us to send email again.
3368 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3370 * src/maemo/modest-platform.c:
3371 (on_modest_conf_update_interval_changed), (modest_platform_init):
3372 Only respond to this particular key change. All these strcmp()s cannot be
3375 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3377 * src/maemo/modest-maemo-global-settings-dialog.c:
3378 (current_connection): Prevent a crash in scratchbox when
3379 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3380 * src/maemo/modest-platform.c:
3381 (on_modest_conf_update_interval_changed), (modest_platform_init):
3382 Get the update interval from gconf and reset it when the gconf key changes.
3384 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3386 * src/modest-protocol-info.c:
3387 * src/modest-protocol-info.h: Adde enum-specific get functions,
3388 instead of using a ModestProtocolType enum parameter.
3390 * src/gnome/modest-account-assistant.c:
3391 * src/gnome/modest-store-widget.c:
3392 * src/gnome/modest-store-widget.h:
3393 * src/gnome/modest-transport-widget.c:
3394 * src/gnome/modest-transport-widget.h:
3395 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3396 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3397 * src/maemo/easysetup/modest-easysetup-wizard.c:
3398 * src/maemo/modest-account-settings-dialog.c:
3399 * src/maemo/modest-account-settings-dialog.h:
3400 * src/maemo/modest-store-widget.c:
3401 * src/maemo/modest-store-widget.h:
3402 * src/maemo/modest-transport-widget.c:
3403 * src/maemo/modest-transport-widget.h:
3404 * src/modest-account-mgr-helpers.c:
3405 * src/modest-account-mgr-helpers.h:
3406 * src/modest-account-mgr.c:
3407 * src/modest-account-mgr.h:
3408 * src/modest-tny-account.c:
3409 * src/modest-tny-folder.c:
3410 * src/widgets/modest-account-view.c:
3411 * src/widgets/modest-retrieve-combo-box.c:
3412 * src/widgets/modest-retrieve-combo-box.h:
3413 * src/widgets/modest-secureauth-combo-box.c:
3414 * src/widgets/modest-serversecurity-combo-box.c:
3415 * src/widgets/modest-serversecurity-combo-box.h:
3416 * tests/check_account-mgr.c:
3417 Use the specific functions, and use the re-renamed enum values for GNOME too.
3419 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3421 * src/modest-pair.h:
3422 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3423 so we can get the second based on the first.
3425 * src/maemo/modest-account-settings-dialog.h:
3426 * src/maemo/modest-account-settings-dialog.c:
3427 Added get_supported_secure_authentication_methods(), though it is mostly
3428 commented-out for now until the necessary API is committed to tinymail.
3429 (modest_account_settings_dialog_set_account_name),
3430 (save_configuration): Request the supported authentication methods from the
3431 server, so we can choose a working method.
3433 * src/modest-tny-account-store.h:
3434 * src/modest-tny-account-store.c:
3435 (modest_tny_account_store_get_session): Rename from
3436 tny_account_store_get_session().
3438 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3440 * src/modest-protocol-info.h: Split the ModestProtocol enum
3441 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3442 There was no need to have these unrelated values in one enum.
3444 * src/: many files: Adapted to changed enum. This makes the code a bit
3445 clearer, and the compiler could catch some errors.
3447 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3449 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3450 Show the detailed internal camel error message when an error happens
3451 during the configuration, so that our testers can give us more clues.
3452 For instance, in projects.maemo.org bug NB#56910 .
3454 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3456 * src/modest-tny-account.c:
3457 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3458 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3460 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3462 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3463 * src/maemo/modest-account-settings-dialog.c:
3464 (modest_account_settings_dialog_set_account_name),
3465 (save_configuration): For the incoming secure authentication checkbox,
3466 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3467 the UI specification. PLAIN does not seem to be supported for most IMAP
3468 servers anyway, and I am not sure what it would mean.
3469 However, we probably need to discover which of the secure-authentication
3470 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3471 * src/modest-account-mgr-helpers.c:
3472 (modest_account_mgr_get_server_account_data):
3474 * src/modest-tny-account.c:
3475 (modest_tny_account_new_from_server_account):
3476 Use tny_account_set_mech() to set secure-authentication methods,
3477 with some special-casing for IMAP, based on my observations of how
3480 * src/modest-account-mgr-helpers.h:
3481 * src/modest-account-mgr.c:
3482 * src/modest-defs.h: Comment that the URI is only used for local folders.
3484 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3486 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3487 parameter const, just to be neat.
3488 * src/modest-text-utils.c: (modest_text_utils_inline):
3489 End g_strconcat() with NULL, as its documentation says. This is almost
3490 certainly the cause of my crash at startup on the device. Interestingly,
3491 valgrind doesn't tell us about these errors.
3493 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3495 * scripts/build-packages: Added more precise comments about how to use
3496 this script, though I still get this error:
3497 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3498 error building tinymail
3500 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3502 * src/maemo/modest-main-window.c: (on_account_update):
3503 Very slight cleanup, hoping to make it simpler to discover what causes
3504 a crash here sometimes.
3506 * src/modest-tny-account.c:
3507 (modest_tny_account_new_from_server_account): Set the port. Added
3508 comments about the options and a TODO comment because I need to find out
3509 how to specify the secure authentication method.
3511 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3513 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3514 changed CFlags paths form modest to libmodest
3516 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3518 * src/modest-account-mgr-helpers.c:
3519 (modest_account_mgr_get_server_account_data),
3520 (modest_account_mgr_free_server_account_data):
3521 * src/modest-account-mgr-helpers.h:
3522 * src/modest-account-mgr.c:
3523 (modest_account_mgr_add_server_account):
3524 * src/modest-defs.h:
3525 * src/modest-tny-account.c:
3526 (modest_tny_account_new_from_server_account):
3527 Determine the options for tny_camel_account_add_option() here,
3528 based on the settings, rather than storing them directly in gconf.
3530 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3532 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3533 Show a more friendly error dialog now that we expect (from the tinymail
3534 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3536 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3538 * src/maemo/modest-main-window.c: (on_account_update): Check that
3539 account_name is not NULL, to prevent a crash at startup that I am
3540 seeing on the N800. I do wonder why it is NULL.
3542 * src/maemo/easysetup/modest-easysetup-wizard.c:
3543 (create_page_user_details):
3544 * src/maemo/modest-account-settings-dialog.c:
3545 (create_page_user_details), (create_page_outgoing):
3546 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3547 (modest_connection_specific_smtp_edit_window_init):
3548 * src/modest-ui-actions.c:
3549 (modest_ui_actions_on_password_requested):
3550 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3551 might do something useful with the on-screen keyboard.
3553 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3555 * src/maemo/modest-main-window.c: (on_account_update):
3556 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3557 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3559 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3561 * src/modest-tny-account-store.c: (on_account_changed):
3562 Correct the signature of this signal handler.
3564 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3566 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3567 Show a HildonNote instead of a GtkDialog for Maemo.
3569 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3571 * src/widgets/modest-account-view.h:
3572 * src/widgets/modest-account-view.c: (on_account_changed),
3573 (on_account_removed). Added a boolean flag, set/unset by
3574 modest_account_view_block_conf_updates(),
3575 modest_account_view_unblock_conf_updates() to prevent unnecessary
3576 updates, but this is not very useful because the gconf notifications are
3577 so delays (maybe only on Maemo Bora).
3578 So auto-updating is turned off, and these functions do an explicit
3579 update when necessary.
3580 However, something else is still doing too much work when adding/removing
3581 accounts, probably in another part of the application.
3583 * src/maemo/modest-account-view-window.c:
3584 (on_delete_button_clicked), (on_edit_button_clicked),
3585 (on_new_button_clicked): Use the new functions.
3587 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3589 * src/modest-account-mgr-helpers.c:
3590 (modest_account_mgr_set_first_account_as_default):
3591 Sort the list of names alphabetically-by-title, so we choose the first one
3593 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3594 alphabetically by the title.
3596 This fixes projects.maemo.org bug NB#56418 .
3598 * src/modest-account-mgr-priv.c:
3599 (_modest_account_mgr_account_from_key):
3600 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3601 avoid a valgrind error, and possible random behaviour.
3603 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3605 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3606 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3607 tinymail documentation to say that this can be expected.
3608 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3609 pretty, and should not happen, but I would prefer to know when it does.
3611 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3613 * configure.ac: When using the older hildon version, probably on Bora,
3614 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3616 * src/widgets/modest-attachment-view.c:
3617 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3620 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3622 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3623 Implemented the prototype. Can be tested with
3624 tests/dbus_api/test_open_message:
3626 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3628 * src/modest-tny-account-store.c:
3629 (modest_tny_account_store_instance_init), (get_password):
3630 * src/modest-ui-actions.c:
3631 (modest_ui_actions_on_password_requested):
3632 Do not store the password in gconf, because this function is called
3633 for non-remembered passwords. Actually use the cached (in the hash map)
3634 password instead of releasing it.
3635 The password will now not be remembered if it is asked via the protected
3636 password dialog, as per the UI spec.
3638 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3640 * src/modest-defs.h:
3641 * src/modest-account-mgr-helpers.h:
3642 * src/modest-account-mgr-helpers.c:
3643 Added modest_server_account_get_username_has_succeeded(),
3644 modest_server_account_set_username_has_succeeded().
3645 (modest_server_account_set_username),
3646 Reset the has-succeeded flag if the username changes.
3648 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3649 * src/maemo/modest-connection-specific-smtp-window.c:
3650 (modest_connection_specific_smtp_window_save_server_accounts):
3651 Use modest_server_account_set_username() instead of using
3652 modest_conf_set_string() directly, so that the has-succeeded flag is always
3655 * src/modest-ui-actions.c:
3656 (modest_ui_actions_on_password_requested): Dim the username entry if
3657 the username has ever worked, as per the UI spec.
3659 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3661 * src/modest-tny-account-store.c: (get_password):
3662 * src/modest-ui-actions.c:
3663 (modest_ui_actions_on_password_requested):
3664 Allow the username to be changed too, though there is more work to
3665 be done on exactly how this behaves.
3667 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3669 * src/modest-account-mgr-helpers.h:
3670 * src/modest-account-mgr-helpers.c:
3671 Added modest_account_mgr_get_display_name(),
3672 modest_server_account_get_username(),
3673 modest_server_account_set_username(),
3674 modest_server_account_set_password(),
3675 modest_server_account_get_hostname() functions so we do not need to
3676 use the conf API directly.
3678 * src/maemo/modest-main-window.c: (connect_signals):
3679 Actually connect ot the ModestAccountStore::request-password signal,
3680 so that we show the dialog when the password is requested by Tinymail,
3681 for isntance if it is empty.
3683 * src/modest-marshal.list:
3684 * src/modest-tny-account-store.c:
3685 (modest_tny_account_store_class_init), (get_password),
3686 (modest_tny_account_store_alert):
3687 * src/modest-tny-account-store.h:
3688 * src/modest-ui-actions.h:
3689 * src/modest-ui-actions.c:
3690 (modest_ui_actions_on_password_requested):
3691 Change the signal parameters, so it is obvious that we are providing
3692 the non human-readable server name, and receiving both the username
3693 and password, though changing of the username is not yet implemented.
3694 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3695 for the GNOME version.
3697 This should fix the projects.maemo.org bug NB#56209, though it does not
3698 work on Bora, because the gconf_client_get() for the password fails
3699 immediately after we save it with gconf_client_set().
3701 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3704 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3705 caused an undefined symbol error:
3706 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3708 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3710 * src/modest-tny-account-store.c:
3711 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3712 using a GError instead of a string message, so we can translate it in
3715 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3717 * src/maemo/modest-address-book.c:
3718 (modest_address_book_check_names):
3719 * src/maemo/modest-msg-view-window.c:
3720 (modest_msg_view_window_clipboard_owner_change):
3721 * src/modest-init.c: (modest_init_init_ui):
3722 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3723 (update_folders_cb), (modest_mail_operation_update_account):
3724 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3725 (modest_ui_actions_on_msg_attachment_clicked),
3726 (modest_ui_actions_on_msg_recpt_activated):
3727 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3728 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3729 (modest_msg_view_search_next):
3730 * src/widgets/modest-recpt-editor.c:
3731 (modest_recpt_editor_on_button_release_event),
3732 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3733 g_message(). At this point we should only be seeing interesting errors on
3734 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3736 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3738 (modest_wizard_dialog_force_title_update):
3739 * src/maemo/easysetup/modest-wizard-dialog.h:
3740 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3741 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3742 can update the title when appropriate. Otherwise the title is wrong if the
3743 pages are added after adding the notebook to the dialog.
3744 This must be a problem in HildonWizardDialog too.
3745 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3747 * src/maemo/easysetup/modest-easysetup-wizard.c:
3748 (create_subsequent_customsetup_pages),
3749 (create_subsequent_easysetup_pages):
3750 Call modest_wizard_dialog_force_title_update() so that the title is
3751 correct even with GTK+ < 2.10.
3752 This fixes projects.maemo.org bug NB#56145 .
3754 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3756 * src/maemo/modest-platform.c:
3757 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3758 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3761 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3763 * src/widgets/modest-window.h:
3764 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3765 and modest_window_save_state(), which invokes it.
3767 * src/widgets/modest-window-mgr.h:
3768 * src/widgets/modest-window-mgr.c:
3769 Added modest_window_mgr_save_state_for_all_windows(), which calls
3770 the save_state vfunc on all registered windows, if implemented.
3772 * src/gnome/modest-msg-edit-window.c:
3773 * src/gnome/modest-msg-view-window.c:
3774 * src/maemo/modest-msg-edit-window.c:
3775 * src/maemo/modest-msg-view-window.c:
3776 * src/maemo/modest-main-window.c:
3777 Specify the existing save_settings functions as implementations of
3778 ModestWindow::save_state_func().
3780 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3781 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3782 enabling hibernation, for instance.
3784 We may need to do the same thing for restoring settings.
3787 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3789 * src/widgets/modest-window-mgr.c:
3790 * src/widgets/modest-window-mgr.h:
3791 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3792 modest_window_mgr_get_hibernation_is_prevented().
3794 * src/maemo/modest-main-window.c:
3795 (on_hildon_program_is_topmost_notify): Prevent hibernation
3796 (possible when the application goes to the background in the WM),
3797 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3799 * src/maemo/easysetup/modest-easysetup-wizard.c:
3800 (modest_easysetup_wizard_dialog_init):
3801 * src/maemo/modest-account-settings-dialog.c:
3802 (modest_account_settings_dialog_init):
3803 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3804 (modest_connection_specific_smtp_edit_window_init):
3805 * src/maemo/modest-connection-specific-smtp-window.c:
3806 (modest_connection_specific_smtp_window_init):
3807 * src/maemo/modest-signature-editor-dialog.c:
3808 (modest_signature_editor_dialog_init):
3809 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3810 prevent hibernation while any of these account settings dialogs are open.
3812 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3814 * src/maemo/Makefile.am:
3815 * src/maemo/modest-osso-state-saving.c:
3816 * src/maemo/modest-osso-state-saving.h: Added
3817 modest_osso_load_state() and modest_osso_save_state() though they do
3818 nothing now. They should iterate through all the open windows and load/save
3820 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3821 save state when closing.
3823 * src/maemo/modest-main-window.c:
3824 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3825 Add a notification handler for the HildonProgram::is-topmost property,
3826 so we can allow hibernation when the application goes into the background.
3827 But we still need to detect when the accounts setup windows are open so
3828 we can stop hibernation when they are open.
3829 To do this, I also added the main window the HildonProgram. This might have
3830 other side-effects/benefits, and should maybe be done for other windows.
3832 * src/maemo/modest-osso-autosave-callbacks.h:
3833 * src/maemo/modest-osso-autosave-callbacks.c:
3834 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3835 though it does not do anything yet, and we might never need this to do
3836 anything. For instance, we already save drafts.
3838 * src/maemo/modest-platform.c: (modest_platform_init):
3839 Specify the libosso auto-save callback.
3841 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3843 * src/maemo/modest-platform.c:
3844 (modest_platform_set_update_interval):
3845 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3846 aparently stays valid between application instances, so we can use this
3847 to remove and reset it later. According to a maemo-developers email from
3850 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3852 * configure.ac: Depend on libalarm for Maemo.
3854 * src/dbus_api/modest-dbus-api.h:
3855 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3856 (on_send_receive), (modest_dbus_req_handler):
3857 Handle a SEND_RECEIVE D-Bus method.
3859 * libmodest-dbus-client/libmodest-dbus-client.c:
3860 (libmodest_dbus_client_send_and_receive):
3861 * libmodest-dbus-client/libmodest-dbus-client.h:
3862 Add C convenience functions for calling the new D-Bus method.
3864 * src/modest-platform.h:
3865 * src/gnome/modest-platform.c:
3866 * src/maemo/modest-platform.c:
3867 Added modest_platform_set_update_interval(), which uses the
3868 alarmd API on Maemo.
3869 (modest_platform_init),
3870 Call modest_platform_set_update_interval(), using a hard-coded
3871 interval for now (until the global settings dialog is implemented),
3872 though I am not sure that this makes sense yet.
3874 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3876 * src/dbus_api/modest-dbus-callbacks.c:
3877 (modest_osso_cb_hw_state_handler):
3878 * src/dbus_api/modest-dbus-callbacks.h:
3879 * src/maemo/modest-platform.c: (modest_platform_init):
3880 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3881 in case this has some effect on the ability for Maemo to ping the
3884 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3886 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3887 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3888 warning. It is probably a logic error, but I need to fix the build.
3890 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3892 * src/modest-account-mgr.h:
3893 * src/modest-account-mgr.c:
3894 (modest_account_mgr_account_names): Add a gboolean enabled_only
3895 parameter, so we can get lists of onlt the enabled accounts.
3897 (modest_account_mgr_add_account),,
3898 (modest_account_mgr_account_with_display_name_exists):
3899 * src/maemo/modest-msg-edit-window.c: (get_transports):
3900 * src/modest-account-mgr-helpers.c:
3901 (modest_account_mgr_set_first_account_as_default):
3902 * src/modest-init.c: (init_default_account_maybe):
3903 * src/modest-tny-account-store.c: (get_accounts):
3904 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3905 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3906 * tests/check_account-mgr.c: (START_TEST):
3907 Provide the extra parameter, as appropriate.
3909 * src/widgets/modest-account-view.c: (update_account_view):
3910 Do not show disabled accounts (meaning that there is no way to
3911 enable/disable accounts in the UI (the feature is not in our UI
3912 specification), so we can use this internally only to mark unfinished
3913 or temporary account data.
3915 * src/maemo/easysetup/modest-easysetup-wizard.c:
3916 (create_account): Add boolean enable parameter, so we can specify FALSE
3917 to create the temporary account.
3918 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3919 (on_before_next): When finishing, when there is a temporary account, just
3921 Also, use a timeout to delay the showing of the dialog until gconf is likely
3922 to return correct information, due to a maemo gconf bug that is fixed in
3923 osso 1.1, but not yet in Bora.
3924 However, the dialog stays on screen after it is destroyed.
3926 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3927 for invalid data when cancelling. Use a hildon note instead of a dialog
3928 to complain about invalid data. Do not show the account-saved note if the
3929 account is disabled (a temporary account that will not really be saved for use
3932 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3934 * src/modest-account-mgr-helpers.h:
3935 * src/modest-account-mgr-helpers.c:
3936 Added modest_account_mgr_unset_default_account(),
3937 Added modest_account_mgr_set_first_account_as_default().
3939 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3940 If it was the default account, unset the default account name.
3942 * src/maemo/modest-account-view-window.c:
3943 (on_delete_button_clicked): If it was the default account,
3944 set the first remaining account as the default instead.
3946 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3947 a NULL account or a NULL default account, to prevent a crash. This should
3948 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3951 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3953 * src/widgets/modest-recpt-editor.c:
3954 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3955 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3956 TODO comment for this. This fixes the build.
3958 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3959 be the best place for it. This will in future update all auto-update accounts,
3960 rather than just the current/default account, when that gconf key exists.
3961 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3962 if there are no accounts, before calling do_send_receive().
3963 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3965 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3966 * src/maemo/modest-main-window-ui.h:
3967 * src/maemo/modest-main-window.c: (on_connection_changed),
3968 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3969 directly, becaue the signal handler does more.
3971 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3973 * src/modest-account-mgr-helpers.c:
3974 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3975 for the case that the account does not exist.
3977 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3978 (equivalent to the modest account name) rather than the tinymail account name
3979 (equivalent to the modest account title - human readable) to get the account data.
3980 Check for null account data to prevent the crash, and add a TODO comment saying that
3981 this needs fixing because it is using the server account name instead of the account name.
3983 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3985 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3986 * src/maemo/modest-account-settings-dialog.c: (show_error),
3988 Use hildon_note_new_information() for informative and error messages,
3989 which seems to be expected for Maemo applications (no documentation that I know of
3990 says this). I am surprised that there is no distinction between info and error
3993 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3995 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3996 it is easy to find where this is used.
3998 * src/maemo/easysetup/modest-easysetup-wizard.c:
3999 (create_page_welcome), (create_page_account_details),
4000 (create_page_user_details), (create_page_complete_easysetup),
4001 (create_page_custom_incoming), (create_page_custom_outgoing),
4002 (create_page_complete_custom):
4003 * src/maemo/modest-account-settings-dialog.c:
4004 (create_page_account_details), (create_page_user_details),
4005 (create_page_incoming), (create_page_outgoing):
4006 * src/maemo/modest-account-view-window.c: (window_vbox_new):
4007 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4008 (modest_connection_specific_smtp_edit_window_init):
4009 * src/maemo/modest-connection-specific-smtp-window.c:
4010 (modest_connection_specific_smtp_window_init):
4011 * src/maemo/modest-signature-editor-dialog.c:
4012 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
4013 and scrolling policy as per the Email Application Layout Guide, if I have
4016 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4018 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
4019 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
4020 which were empty, because these vfuncs have been removed from TnyAccountStore.
4021 This fixes the build.
4023 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4025 * src/maemo/modest-main-window.c:
4026 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
4027 showing/hiding it. Added TODO because it probably should not be NULL.
4028 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
4029 because unnecessary g_warnings() make degugging difficult.
4031 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4033 * src/maemo/modest-msg-edit-window.c:
4034 (modest_msg_edit_window_select_color),
4035 (modest_msg_edit_window_select_background_color): 2 const corrections and
4036 moving 2 #endifs before closing brackets, to fix the build.
4038 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4040 * src/maemo/easysetup/modest-easysetup-wizard.h:
4041 * src/maemo/easysetup/modest-easysetup-wizard.c:
4042 (modest_easysetup_wizard_dialog_finalize),
4043 (on_button_edit_advanced_settings), (create_page_complete_custom),
4044 (on_response), (create_account):
4045 Implement the Advanced Settings edit button, by saving the account information,
4046 for the Advanded Settings dialog to use directly from gconf, and removing it
4047 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
4048 Bug #5533 in the projects.maemo.org bugzilla.
4050 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4052 * src/maemo/modest-msg-view-window.c:
4053 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
4054 when opening a message window.
4056 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4058 * src/maemo/easysetup/modest-easysetup-wizard.c:
4059 (create_page_custom_outgoing): Correct the position of the horizontal separator to
4062 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
4063 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4064 gconf settings. I probably added more checks than necessary, but that is safer.
4066 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4067 variable to fix the build, but this seems to be used when it is still NULL.
4069 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4071 * src/modest-platform.h:
4072 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4073 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4074 * src/modest-main.c: Implement this function so we can avoid using
4075 maemo-specific API from cross-platform code.
4077 * src/modest-tny-account-store.c:
4078 (get_smtp_specific_transport_account_for_open_connection):
4079 * src/modest-ui-actions.c: (check_for_connection),
4080 (modest_ui_actions_on_item_not_found):
4081 Use modest_platform_connect_and_wait() and put #idefs around other
4082 maemo-specific code, because only maemo currently has a way to
4083 identify connection names.
4085 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4087 * src/modest-tny-account-store.h:
4088 * src/modest-tny-account-store.c:
4089 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4090 the connection-specific SMTP server settings in the configuration.
4092 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4094 * src/maemo/modest-main-window.c: (on_connection_changed),
4096 * src/modest-main.c: (main), (start_ui), (send_mail):
4097 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4098 that is what is intended.
4100 * src/modest-ui-actions.c: (action_send), (action_receive),
4101 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4102 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4103 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4104 SMTP server is used when it is specified.
4106 (modest_ui_actions_on_send_receive):
4107 Check that a connection is open before proceeding.
4108 Receive and then send, instead of vice-versa, as per the specification.
4110 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4112 * src/modest-mail-operation.c:
4113 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4114 though I guess it should be something other than NULL.
4116 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4118 * src/maemo/easysetup/modest-easysetup-wizard.c:
4119 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4120 combo twice, to avoid an g_warning and to make it visible again.
4121 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4122 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4123 (already intended) dereference when detaching, because we then recreate the menu.
4124 But I am not sure why the warning was happening, and it is possible that this is a memory
4127 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4129 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4130 and uri_parse_mailto() utility functions.
4131 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4133 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4135 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4137 * src/dbus_api/modest-dbus-api.h:
4138 * src/dbus_api/modest-dbus-callbacks.c:
4139 Use an idle callback to execute the modest code in the application's own thread.
4140 Remove the helloworld example method.
4141 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4142 parsed, and the open-message method is not implemented because this is not yet implemented in
4144 * libmodest-dbus-client/libmodest-dbus-client.c:
4145 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4146 (libmodest_dbus_client_open_message):
4147 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4149 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4150 body without crashing.
4152 * tests/dbus_api/Makefile.am:
4153 * tests/dbus_api/test_mail_to.c:
4154 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4156 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4158 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4159 Added file to fix the build. Sorry.
4161 * src/dbus_api/Makefile.am:
4162 * src/dbus_api/modest-dbus-api.h:
4163 * src/dbus_api/modest-dbus-callbacks.h:
4164 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4165 (modest_dbus_req_handler):
4166 Put constants in a separate header so it can be reused by the
4167 client library, without duplication
4169 * libmodest-dbus-client/Makefile.am:
4170 * libmodest-dbus-client/libmodest-dbus-client.c:
4171 (libmodest_dbus_client_call_helloworld),
4172 (libmodfest_dbus_client_send_mail),
4173 (libmodfest_dbus_client_mailto),
4174 (libmodfest_dbus_client_open_message):
4175 * libmodest-dbus-client/libmodest-dbus-client.h:
4176 (Partly) Implement a send_mail D-Bus method.
4178 * tests/dbus_api/Makefile.am:
4179 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4180 the send_email D-Bus method.
4182 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4186 * libmodest-dbus-client/Makefile.am:
4187 * libmodest-dbus-client/libmodest-dbus-client.c:
4188 * libmodest-dbus-client/libmodest-dbus-client.h:
4189 * tests/dbus_api/Makefile.am:
4190 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4191 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4193 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4195 * src/maemo/easysetup/modest-easysetup-wizard.c:
4196 (create_page_account_details):
4197 * src/maemo/modest-account-settings-dialog.c:
4198 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4199 widgets, because this might not be the default in future versions of the Maemo GTK+.
4200 However, I can not not get capitalization to work even in a simple test case.
4202 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4204 * src/maemo/easysetup/modest-easysetup-wizard.c:
4205 (create_page_custom_incoming), (create_page_custom_outgoing):
4206 * src/maemo/modest-account-settings-dialog.c:
4207 (create_page_account_details), (create_page_incoming),
4208 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4209 instead of using gtk_check_button_with_label(), so they are aligned like the other
4210 widgets, as per the UI spec.
4212 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4214 * src/maemo/easysetup/modest-easysetup-wizard.c:
4215 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4216 * src/widgets/modest-validating-entry.c:
4217 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4218 Modest prefix instead of an EasySetup prefix.
4220 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4222 * src/widgets/modest-validating-entry.h:
4223 * src/widgets/modest-validating-entry.c: (on_insert_text),
4224 Added easysetup_validating_entry_set_max_func(), used to set a callback
4225 to call when the max number of characters is reached. GtkEntry has a max-length
4226 already but is silent about it.
4228 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4229 (create_page_account_details), (create_page_user_details),
4231 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4232 (create_page_account_details), (create_page_user_details),
4233 (create_page_outgoing):
4234 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4235 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4236 the UI spec, when the user tries to enter more than the max number of characters.
4238 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4240 * src/maemo/easysetup/modest-easysetup-wizard.c:
4241 (create_page_user_details), (create_page_custom_incoming),
4242 (create_page_custom_outgoing):
4243 * src/maemo/modest-account-settings-dialog.c:
4244 (create_page_user_details), (create_page_incoming),
4245 (create_page_outgoing):
4246 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4247 (modest_connection_specific_smtp_edit_window_init):
4248 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4249 not appropriate. Bad Maemo-specific defaults!.
4251 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4253 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4254 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4255 (modest_signature_editor_dialog_set_settings):
4256 Disable the label and textview when the checkbox is disabled, and use the
4257 specified (UI spec) default signature text.
4259 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4261 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4262 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4264 * src/modest-defs.h:
4265 * src/modest-account-mgr-helpers.h:
4266 * src/modest-account-mgr-helpers.c:
4267 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4269 * src/maemo/Makefile.am:
4270 * src/maemo/modest-signature-editor-dialog.c:
4271 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4274 * src/maemo/modest-account-settings-dialog.h:
4275 * src/maemo/modest-account-settings-dialog.c:
4276 (modest_account_settings_dialog_finalize), (on_button_signature),
4277 (save_configuration): Use the new dialog when the Edit button is pressed, and
4278 save the changes if necessary, as per the UI spec.
4280 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4282 * src/maemo/Makefile.am:
4283 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4284 based on maemo-develoers email from Dirk.
4286 * src/maemo/easysetup/modest-easysetup-wizard.c:
4287 (create_page_welcome), (create_page_account_details),
4288 (create_page_user_details), (create_page_complete_easysetup),
4289 (create_page_custom_incoming), (create_page_custom_outgoing),
4290 (create_page_complete_custom),
4291 (modest_easysetup_wizard_dialog_init):
4292 * src/maemo/modest-account-settings-dialog.c:
4293 (create_page_account_details), (create_page_user_details),
4294 (create_page_incoming), (create_page_outgoing),
4295 (modest_account_settings_dialog_init):
4296 * src/maemo/modest-connection-specific-smtp-window.c:
4297 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4299 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4301 * src/maemo/easysetup/modest-easysetup-wizard.c:
4302 (create_page_account_details), (create_page_custom_outgoing),
4303 (create_page_complete_custom):
4304 * src/maemo/modest-account-settings-dialog.c:
4305 (create_page_user_details), (create_page_incoming),
4306 (create_page_outgoing):
4307 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4308 (modest_connection_specific_smtp_edit_window_init):
4309 Use the correct (UI spec) port min/max, and use horizontal separators,
4312 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4314 * src/maemo/easysetup/modest-easysetup-wizard.c:
4315 (set_default_custom_servernames):
4316 * src/maemo/modest-account-settings-dialog.c:
4317 (create_page_incoming), (on_combo_outgoing_security_changed),
4318 (on_combo_incoming_security_changed), (create_page_outgoing),
4319 (modest_account_settings_dialog_set_account_name),
4320 (save_configuration):
4321 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4322 (on_combo_security_changed),
4323 (modest_connection_specific_smtp_edit_window_init),
4324 (modest_connection_specific_smtp_edit_window_set_connection),
4325 (modest_connection_specific_smtp_edit_window_get_settings):
4326 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4329 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4332 * src/maemo/easysetup/modest-easysetup-wizard.c:
4333 (create_page_custom_outgoing), (create_page_complete_custom):
4334 * src/maemo/modest-account-settings-dialog.c:
4335 (create_page_user_details), (create_page_outgoing):
4336 * src/maemo/modest-account-view-window.c: (button_box_new):
4337 Use changed logical IDs as per the most recent UI spec:
4338 mcen_bd_emailsetup_edit -> mcen_bd_edit
4339 mcen_bd_emailsetup_delete -> mcen_bd_delete
4340 mcen_bd_emailsetup_close -> mcen_bd_close
4342 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4346 * src/dbus_api/Makefile.am:
4347 * src/dbus_api/modest-dbus-callbacks.c:
4348 * src/dbus_api/modest-dbus-callbacks.h:
4349 * src/maemo/modest-platform.c: (modest_platform_init):
4350 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4352 * tests/Makefile.am:
4353 * tests/dbus_api/Makefile.am:
4354 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4356 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4358 * src/maemo/modest-account-settings-dialog.c:
4359 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4360 Removed unnecessary includes.
4362 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4364 * src/maemo/easysetup/modest-easysetup-wizard.c:
4365 * src/maemo/modest-account-settings-dialog.c:
4366 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4367 * src/widgets/Makefile.am:
4368 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4369 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4370 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4371 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4372 * src/widgets/modest-secureauth-combo-box.c:
4373 * src/widgets/modest-secureauth-combo-box.h:
4374 * src/widgets/modest-serversecurity-combo-box.c:
4375 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4376 made the GObject names more consistent with the rest of the Modest code.
4378 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4380 * src/maemo/easysetup/Makefile.am:
4381 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4382 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4383 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4384 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4385 * src/maemo/easysetup/modest-easysetup-wizard.c:
4386 * src/maemo/easysetup/modest-validating-entry.c:
4387 * src/maemo/easysetup/modest-validating-entry.h:
4388 * src/maemo/modest-account-settings-dialog.c:
4389 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4390 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4391 widgets/ because they are used outside of easysetup too. After checking in,
4392 svn will allow me to rename them too.
4394 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4396 * src/gnome/modest-msg-edit-window.c:
4397 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4398 linker error, to fix the build on the GNOME platform.
4399 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4400 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4401 ifdefed out to avoid a warning.
4403 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4405 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4406 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4407 some alternative for GTK+ 2.6.
4409 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4411 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4413 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4414 specified for EmailAccountsDialog in UI spec.
4416 * src/maemo/easysetup/modest-easysetup-wizard.c:
4417 * src/maemo/easysetup/modest-easysetup-wizard.h:
4418 * src/maemo/modest-account-settings-dialog.c:
4419 * src/maemo/modest-account-settings-dialog.h:
4420 Reuse a member window widget for the connection-specific SMTP server accounts,
4421 so we can tell it to create/save the accounts only if we actually save changes.
4423 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4424 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4425 (modest_connection_specific_smtp_edit_window_get_settings):
4426 Return a struct instance for temporarily remembering the entered data.
4428 * src/maemo/modest-connection-specific-smtp-window.h:
4429 * src/maemo/modest-connection-specific-smtp-window.c:
4430 (modest_connection_specific_smtp_window_finalize),
4431 (modest_connection_specific_smtp_window_fill_with_connections),
4433 (modest_connection_specific_smtp_window_save_server_accounts),
4434 (update_model_server_names): Do not actually save data until asked,
4435 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4437 (on_selection_changed),
4438 (modest_connection_specific_smtp_window_init): Disable the edit
4439 button when nothing is selected.
4441 * src/modest-account-mgr-helpers.c:
4442 * src/modest-account-mgr-helpers.h:
4443 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4446 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4448 * src/modest-account-mgr-helpers.h:
4449 * src/modest-account-mgr-helpers.c:
4450 (modest_account_mgr_get_unused_account_name),
4451 (modest_account_mgr_get_unused_account_display_name): Added these
4452 utility functions, to avoid code duplication.
4454 * src/maemo/easysetup/modest-easysetup-wizard.c:
4455 (create_page_account_details), (create_account):
4456 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4457 (on_combo_security_changed),
4458 (modest_connection_specific_smtp_edit_window_init),
4459 (modest_connection_specific_smtp_edit_window_save_settings):
4460 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4461 * src/maemo/modest-connection-specific-smtp-window.c:
4462 (modest_connection_specific_smtp_window_finalize),
4463 (modest_connection_specific_smtp_window_fill_with_connections),
4464 (on_button_edit), (modest_connection_specific_smtp_window_init):
4465 * src/maemo/modest-connection-specific-smtp-window.h:
4466 Implementing saving of connection-specific server accounts.
4468 But I need to refactor this so we can save the data for each
4469 possible connection-specific account and only actually create the server accounts
4470 when the easysetup finished, or the OK button is pressed on the account settings
4473 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4475 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4476 (on_combo_security_changed):
4477 (modest_connection_specific_smtp_edit_window_init):
4478 Auto-fill the port number as in the account settings.
4480 (modest_connection_specific_smtp_edit_window_set_connection):
4481 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4482 * src/maemo/modest-connection-specific-smtp-window.c:
4483 (fill_with_connections), (on_button_edit),
4484 (modest_connection_specific_smtp_window_init):
4485 Turn the edit window into a dialog to simplify the code, and
4486 set a WM hint as in a GtkDialog, because only a popup can be on top of
4487 another window in Maemo, and popups usually have no WM decoration.
4489 * src/modest-defs.h:
4490 * src/modest-account-mgr-helpers.c:
4491 (modest_account_mgr_set_connection_specific_smtp),
4492 (modest_account_mgr_remove_connection_specific_smtp),
4493 (modest_account_mgr_get_connection_specific_smtp):
4494 * src/modest-account-mgr-helpers.h: Some functions to write the
4495 connection-specific SMTP server information. Not yet used.
4498 * src/widgets/modest-folder-view.c: (text_cell_data):
4499 Fix a warning about an uninitialized variable.
4500 (on_configuration_key_changed): Put an #ifdef around the use
4501 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4503 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4505 * src/maemo/modest-account-settings-dialog.h:
4506 * src/maemo/modest-account-settings-dialog.c:
4507 Added connect_for_modified() utility function to mark the new modified boolean.
4509 (create_page_account_details), (create_page_user_details),
4510 (create_page_incoming), (create_page_outgoing), (on_response),
4511 (modest_account_settings_dialog_init),
4512 (modest_account_settings_dialog_set_account_name):
4513 Only warn about unsaved changes when there are actually unsaved changes.
4515 * src/modest-account-mgr-helpers.c:
4516 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4517 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4518 to get the data from there in future.
4520 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4522 * src/modest-defs.h:
4524 * src/modest-account-mgr-helpers.h:
4525 * src/modest-account-mgr-helpers.c:
4526 Store the security account setting in a single conf key instead of using
4527 the options list, so that the list is left for just the to-be-removed camel hack,
4528 and because gconf_client_set_list() is failing for some reason.
4530 * src/modest-account-mgr.c:
4531 (modest_account_mgr_add_server_account):
4532 * src/maemo/modest-account-settings-dialog.c:
4533 (modest_account_settings_dialog_set_account_name),
4534 (save_configuration): Use the renamed functions.
4537 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4539 * src/widgets/Makefile.am:
4540 * src/widgets/modest-limit-retrieve-combo-box.c:
4541 * src/widgets/modest-limit-retrieve-combo-box.h:
4542 * src/widgets/modest-retrieve-combo-box.c:
4543 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4544 the account settings dialog.
4546 * src/modest-defs.h:
4547 * src/modest-account-mgr-helpers.h:
4548 * src/modest-account-mgr-helpers.c:
4549 (modest_server_account_get_option_secure_auth),
4550 (modest_server_account_set_option_secure_auth):
4551 * src/modest-account-mgr.c:
4552 (modest_account_mgr_add_server_account):
4553 Use the existing AUTH_MECH conf key for the secure-auth setting,
4554 instead of putting it in the list options, because this was actually used already.
4556 * src/maemo/modest-account-settings-dialog.c:
4557 (create_page_account_details),
4558 (modest_account_settings_dialog_set_account_name),
4559 (save_configuration):
4560 * src/maemo/modest-account-settings-dialog.h:
4561 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4562 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4564 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4566 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4567 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4568 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4570 * src/modest-defs.h:
4571 * src/maemo/modest-account-settings-dialog.c:
4572 (create_page_incoming), (on_combo_outgoing_security_changed),
4573 (on_combo_incoming_security_changed), (create_page_outgoing),
4574 (modest_account_settings_dialog_set_account_name),
4575 (save_configuration): Load/Save the port number, and change it when the
4576 security combo changes, to suitable defaults.
4578 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4580 * src/modest-account-mgr.c:
4581 (modest_account_mgr_add_server_account): Set the security and secure-auth
4582 options, and add a comment saying that the other camel-specific options should be
4585 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4587 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4589 * src/modest-tny-account-store.c: (account_list_free),
4590 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4591 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4594 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4596 * src/modest-protocol-info.c:
4597 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4598 is required by our UI spec. Maybe something in our implementation will use this eventually.
4599 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4600 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4601 instead of the previous 0 placeholder.
4603 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4604 secure-auth settings.
4605 * src/modest-account-mgr-helpers.h:
4606 * src/modest-account-mgr-helpers.c:
4607 (modest_server_account_data_get_option_secure_auth),
4608 (modest_server_account_set_option_secure_auth),
4609 (modest_server_account_data_get_option_security),
4610 (modest_server_account_set_option_security): Added this API for getting and setting the security
4611 and secure-auth settings.
4613 * src/maemo/modest-account-settings-dialog.h:
4614 * src/maemo/modest-account-settings-dialog.c:
4615 (modest_account_settings_dialog_finalize), (check_data),
4616 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4617 about changing titles.
4618 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4619 (save_configuration): Save the security and secure-auth settings.
4621 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4622 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4624 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4626 * src/modest-defs.h:
4627 * src/modest-account-mgr.c:
4628 (modest_account_mgr_add_server_account):
4629 Added and used defines for the options key and value pair strings,
4630 that are used so far, though they do not seem to correspond to anything in our
4631 UI specs or ModestProtocol enum.
4633 * src/modest-account-mgr-helpers.h:
4634 * src/modest-account-mgr-helpers.c:
4635 (compare_option_strings_for_name),
4636 (modest_server_account_data_get_option_value),
4637 (modest_server_account_data_get_option_bool),
4638 (modest_account_mgr_get_server_account_option):
4639 Added helper functions for parsing the options GSList.
4641 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4643 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4644 display name is based on the supplied account name.
4645 * src/modest-account-mgr.c:
4646 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4647 with an inefficient, but good-enough, implementation.
4649 * src/maemo/easysetup/modest-easysetup-wizard.c:
4650 (create_page_account_details), (on_before_next), (create_account):
4651 Check for existing display names rather than (non-user-visible) account names, and just
4652 create and set a unique account name at the end.
4654 * src/maemo/modest-account-settings-dialog.c:
4655 (modest_account_settings_dialog_init),
4656 (modest_account_settings_dialog_set_account_name),
4657 (create_page_incoming): Show the display name, instead of the account name.
4658 (on_response): Do some (not all) extra checks, as in the UI spec.
4659 (save_configuration): Save the display name if it was changed.
4661 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4663 * po/en_GB.po: Added needed logical ID and translation.
4664 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4665 (init_view): Made the is-default column clicking work.
4667 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4670 * src/maemo/easysetup/Makefile.am:
4671 * src/maemo/easysetup/modest-easysetup-wizard.c:
4672 (modest_easysetup_wizard_dialog_init):
4673 * src/maemo/easysetup/provider-data-test.keyfile:
4674 * src/maemo/easysetup/provider-data.keyfile:
4675 Moved the provider data file to the new modest-providers-data package and used it from there.
4677 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4679 * src/modest-local-folder-info.c:
4680 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4681 N_() was already used on the static strings, but this just marks it for translation without
4682 using the translation.
4684 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4686 * src/maemo/modest-account-settings-dialog.c:
4687 (create_page_incoming),
4688 (modest_account_settings_dialog_set_account_name):
4689 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4690 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4691 I will do this if nobody else gets there first.
4693 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4695 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4696 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4697 save the security stuff.
4699 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4701 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4702 Set the email address and user fullname, which I now see must be
4705 * src/maemo/modest-account-settings-dialog.h:
4706 * src/maemo/modest-account-settings-dialog.c:
4708 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4709 leave-on-server and authentication.
4710 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4713 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4716 * src/maemo/modest-account-settings-dialog.c:
4717 * src/maemo/modest-account-settings-dialog.h:
4718 Most (but not all) of the widgets are now present as specified by the UI spec.
4719 No changes are yet saved, and some details are not properly shown yet.
4721 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4723 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4725 * src/maemo/Makefile.am:
4726 * src/maemo/modest-account-settings-dialog.c:
4727 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4728 an existing account. Doesn't do much yet.
4730 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4731 Open the accounts settings dialog when Edit is clicked.
4733 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4735 * src/maemo/easysetup/Makefile.am:
4736 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4738 * src/maemo/easysetup/modest-easysetup-wizard.c:
4739 (modest_easysetup_wizard_dialog_init):
4740 Try to get the source directory from the build system,
4741 instead of hard-coding "./" into the source code, when opening our local
4742 copies of the configuration files.
4743 But this still fails when opening the wizard from the Accounts window,
4744 maybe because the working directory seems to change at runtime.
4745 So the wizard will fail the second time unless you copy the files into their
4746 proper locations - see the stdout warnings for the paths.
4748 (create_page_account_details),(on_before_next):
4749 Check for existing non-server accounts instead of server accounts,
4750 so the default account name is useful again, and to prevent trying to
4753 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4754 Show the wizard when New is clicked.
4756 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4757 (init_view): Show the column headers, and show the columns that are
4758 specified in the UI specs. However, something in Maemo's GTK+ prevents
4759 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4760 change the default account. This is despite unsetting the special properties.
4762 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4764 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4765 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4766 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4767 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4768 to make that clearer.
4769 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4771 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4773 * src/maemo/modest-account-view-window.c:
4774 (modest_account_view_window_init),
4775 (modest_account_view_window_new):
4776 Use the same buttons as specified in the
4777 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4778 the existing widgets, which never had a chance of working.
4779 Put the ModestAccountView treeview in a scrolled window.
4780 Do not repeat the initialization in both _init() and _new().
4782 * src/widgets/modest-account-view.c: (update_account_view):
4783 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4784 this widget and window shows no accounts.
4786 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4788 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4790 * src/maemo/easysetup/modest-easysetup-wizard.c:
4791 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4792 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4793 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4796 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4797 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4798 accounts exist yet, as in the UI spec.
4800 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4802 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4804 * src/maemo/Makefile.am:
4805 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4806 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4807 New window for editing connection-specific smtp details.
4808 Not fully implemented.
4810 * src/maemo/modest-connection-specific-smtp-window.c:
4811 (modest_connection_specific_smtp_window_finalize) :
4812 unref the tree model.
4813 (on_button_edit): Show the edit window.
4815 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4817 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4820 * src/maemo/Makefile.am:
4821 * src/maemo/modest-connection-specific-smtp-window.c:
4822 * src/maemo/modest-connection-specific-smtp-window.h:
4823 New window for showing the list of connections, for connection-specific
4824 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4825 * src/maemo/easysetup/modest-easysetup-wizard.c:
4826 (create_page_custom_outgoing): Show the new window when the button is clicked.
4828 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4830 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4831 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4832 * src/maemo/modest-msg-edit-window.c:
4833 (modest_msg_edit_window_insert_image):
4834 * src/modest-conf.c: (modest_conf_key_escape):
4835 * src/modest-mail-operation.c:
4836 (modest_mail_operation_send_new_mail):
4837 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4838 (modest_ui_actions_on_new_account):
4839 * src/widgets/modest-attachment-view.c: (update_filename_request):
4840 * src/widgets/modest-mail-header-view.c:
4841 Corrected warnings that were breaking the build, by commenting out unused variables,
4842 and a function, and by including a header.
4844 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4846 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4847 so we can #ifdef around platform-specific code when necessary.
4848 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4849 to allow this to build for the GNOME platform too.
4851 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4853 * src/maemo/easysetup/modest-easysetup-wizard.c:
4854 Added util_increment_name() and used it in create_page_account_details()
4855 to make sure that the default account name is always a new name.
4857 (modest_easysetup_wizard_dialog_init),
4858 (set_default_custom_servernames): Some minor memory management fixes.
4860 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4864 * src/modest-runtime.c: (init_i18n): Restored the translation
4865 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4866 are defined in config.h, and the translations are installed.
4868 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4869 is defined for translation.
4871 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4873 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4875 * src/maemo/easysetup/modest-easysetup-wizard.c:
4876 (modest_easysetup_wizard_dialog_init):
4877 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4878 Use realistic paths (though they should use $prefix generically) to the
4879 mcc_mapping and provider-data.keyfile files which might work when they
4880 are installed by the future version of the operator-wizard package,
4881 and then fallback to paths in our source code, with an explanatory
4884 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4888 * src/maemo/Makefile.am:
4889 * src/maemo/easysetup/: Added files from the previously-exernal
4890 osso-modest-easysetup.
4891 * src/maemo/modest-main-window-ui.h:
4892 * src/modest-ui-actions.c:
4893 * src/modest-ui-actions.h:
4894 Added modest_ui_actions_on_new_account() as a signal handler for the
4895 New Account menu item. It shows the easysetup wizard.
4896 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob