1 2007-05-30 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account.c:
4 (modest_tny_account_new_for_local_folders):
5 Use hildon_file_system_info_async_new() to get a better name for
6 the memory card account, setting it as the account name.
7 The timing seems to work, but this is probably
8 not the best place to do this. See the TODO comment.
9 * src/maemo/modest-main-window.c: (create_details_widget):
10 * src/widgets/modest-folder-view.c: (text_cell_data):
11 Use the tny account name instead of hardcoding a name.
13 2007-05-30 Christian Kellner <ckellner@openismus.com>
15 * src/modest-search.c: (modest_search):
16 Correctly set part_search_func even if we have already parsed
17 the query and thus a valid OgsTextSearcher object.
19 2007-05-30 Christian Kellner <ckellner@openismus.com>
22 Search and check for libogs.
25 Incooparte the ogs build env.
27 * src/modest-mime-part-search-stream.c:
28 * src/modest-mime-part-search-stream.h:
29 Removed since we do the real searching now in modest-search.c.
31 * src/modest-search.c:
32 * src/modest-search.h:
33 Implement support for ogs. We use that if available and requested
34 and fall back to modest_text_utils_utf8_strcmp (). The search logic
35 should now handle the corner case when the search term is spread
36 across multiple reads.
37 Also the logic in modest_search () was corrected to search all
38 requested fields until one is found.
40 2007-05-30 Murray Cumming <murrayc@murrayc.com>
42 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
45 * src/modest-init.c: Made modest_init_local_folders() take a
46 path and be public so we can iniitialize maildir folders on
49 * src/modest-local-folder-info.h:
50 * src/modest-local-folder-info.c:
51 (modest_local_folder_info_get_maildir_path): Add a path parameter.
53 * src/modest-tny-account.c:
54 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
55 still means the standard local-folders path on the local volume.
57 * src/modest-tny-account-store.c:
58 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
59 signal so we can detect mount/unmount of the MMC1 card, and do an update of
60 all accounts when that happens.
61 (get_server_accounts): If the MMC1 card is mounted, create a store account for
62 this too, so it shows up in the treeview.
64 2007-05-28 Murray Cumming <murrayc@murrayc.com>
66 * src/maemo/modest-maemo-global-settings-dialog.c:
68 * src/widgets/modest-global-settings-dialog.c:
69 (current_connection_default):
70 Use the enum values instead of 0, 1 and -1,
71 to make the code clearer.
73 * src/modest-account-mgr-helpers.c:
74 (modest_account_mgr_get_connection_specific_smtp): Make this code
77 * src/modest-runtime.h:
78 * src/modest-runtime.c:
79 Added modest_runtime_remove_all_send_queues().
80 * src/maemo/modest-main-window.c:
81 (on_account_store_connecting_finished): Recreate the send queues,
82 using the appropriate transport accounts for this new connection.
83 Some futher adapting might be needed if the old send queues are not
84 automatically stopped at this point.
86 * src/modest-tny-account-store.c: (get_server_accounts):
87 Create the connection-specific transport accounts, so that they can
88 be found later by their ID.
90 * src/modest-tny-account.h:
91 * src/modest-tny-account.c:
92 Added modest_tny_account_new_from_server_account_name().
93 modest_tny_account_new_from_server_account(): Do not create the
94 send queues here, because they will be
95 recreated anyway when the connection changes for the first time.
97 2007-05-28 Murray Cumming <murrayc@murrayc.com>
99 * src/modest-local-folder-info.h:
100 * src/modest-local-folder-info.c:
101 (modest_per_account_local_outbox_folder_info_get_maildir_path),
102 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
103 tbox_folder): Take a modest account name instead of a server TnyAccount,
104 so we can have per-modest-account rather than per-transport-account
106 We must make sure that we change or recreate the exisitng send queues
107 when the connection changes for connection-specific transport accounts.
109 * src/modest-tny-account-store.c:
110 (create_per_account_local_outbox_folders): Create outboxed per modest
111 account, not per transport account.
113 * src/modest-tny-account.h:
114 * src/modest-tny-account.c:
115 (modest_tny_account_get_special_folder): For outboxes, get the
116 parent modest account name. The account is ignored for other folders.
117 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
118 modest account name rather than a server TnyAccount.
120 2007-05-25 Murray Cumming <murrayc@murrayc.com>
122 * src/modest-tny-account.c:
123 (modest_tny_account_new_from_server_account):
124 Call modest_runtime_get_send_queue() immediately after creating transport
125 accounts, so that they start trying to send email from the outbox as soon
126 as possible at startup. This is probably what we want.
128 * src/modest-mail-operation.c: (update_account_thread):
129 * src/modest-runtime.c: (modest_runtime_get_send_queue):
130 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
131 * src/modest-tny-send-queue.h:
132 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
133 (modest_ui_actions_on_send):
134 Added comments about how sending works, though it needs some more work.
136 2007-05-25 Murray Cumming <murrayc@murrayc.com>
138 * src/modest-tny-account.c:
139 (modest_tny_account_get_special_folder): Add TODO because this fails when
141 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
142 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
143 Do not try to show this window when there is no active account. The UI
144 specs does not tell us what to do in this case.
146 2007-05-24 Murray Cumming <murrayc@murrayc.com>
150 * src/maemo/Makefile.am:
151 * src/widgets/Makefile.am: Some dist fixes.
153 2007-05-24 Murray Cumming <murrayc@murrayc.com>
155 * src/maemo/modest-connection-specific-smtp-window.c:
156 (on_button_edit): Make the code clearer, to prevent a double free.
158 2007-05-24 Murray Cumming <murrayc@murrayc.com>
160 * src/maemo/modest-account-settings-dialog.c:
161 (modest_account_settings_dialog_set_account_name),
162 Check the connection-specific smtp servers checkbox if there are any.
164 * src/maemo/modest-connection-specific-smtp-edit-window.c:
165 (modest_connection_specific_smtp_edit_window_init):
166 Start with a suitable port number.
168 * src/modest-account-mgr-helpers.h:
169 * src/modest-account-mgr-helpers.c: Added
170 modest_account_mgr_get_has_connection_specific_smtp().
172 (modest_account_mgr_set_connection_specific_smtp),
173 (modest_account_mgr_remove_connection_specific_smtp),
174 (modest_account_mgr_get_has_connection_specific_smtp),
175 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
176 connection-specific smtp server accounts in the account, rather than
177 the server account conf dir.
179 This fixes bug projects.maemo.org bug NB#58263 .
181 * src/modest-tny-account-store.c:
182 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
183 if there are no server accounts yet, to prevent an infinite loop when there
184 are no accounts. Document that one must be called before the other.
186 2007-05-24 Murray Cumming <murrayc@murrayc.com>
188 * src/modest-account-mgr-helpers.c:
189 (modest_account_mgr_get_default_account): Make sure that at least
190 one account is always the default, if there are any enabled accounts.
191 This is just a sanity check that shouldn't be necessary.
193 * src/modest-account-mgr-priv.c:
194 (_modest_account_mgr_account_from_key): Unescape the conf key to
195 get the real account name. For instance, this is an issue if a space
196 was in the account name, which can happen because the account name
197 is generated from the display name.
198 (_modest_account_mgr_get_account_keyname): Always escape the
200 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
201 Unescape the conf keys to get the real account names.
203 For instance, previously the is-default radio button in the accounts
204 list was not checked for any accounts at first. This fixes that,
205 and might fix several similar bugs.
207 2007-05-23 Murray Cumming <murrayc@murrayc.com>
209 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
210 Removed some debug printfs.
212 2007-05-23 Murray Cumming <murrayc@murrayc.com>
214 Modest on-disk outbox directories are now here, for instance:
215 $HOME/.modest/outboxes/<account-id-1>/outbox
216 $HOME/.modest/outboxes/<account-id-2>/outbox
218 $HOME/.modest/local-folders/outbox
219 so we can have a separate outbox for each account.
220 But they are shown as one outbox in the GtkTreeView, by using a
221 TnyMergeFolder in a ModestTnySimpleFolderStore.
224 * src/modest-tny-simple-folder-store.c:
225 * src/modest-tny-simple-folder-store.h:
226 Added ModestTnySimpleFolderStore, used to contain folders from
227 other folder stores, such as other accounts.
229 * src/modest-tny-outbox-account.h:
230 * src/modest-tny-outbox-account.c:
231 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
232 used for the per-account local outbox folders.
234 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
235 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
236 only use this (internally) now for the non-outbox local folders.
239 * src/modest-init.c: Added modest_init_one_local_folder(), for
240 setting up the directory structure for each local folder.
242 * src/modest-local-folder-info.c:
243 (modest_per_account_local_outbox_folder_info_get_maildir_path),
244 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
246 * src/modest-local-folder-info.h:
247 * src/modest-tny-account-store.c: (on_account_removed),
248 (on_account_changed), (create_per_account_local_outbox_folders),
249 (get_server_accounts), (modest_tny_account_store_get_accounts),
250 (modest_tny_account_store_get_tny_account_by_account),
251 (modest_tny_folder_store_is_virtual_local_folders):
253 * src/modest-tny-account.h:
254 * src/modest-tny-account.c:
255 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
256 to create an on-disk per-account local outbox folder for each
258 (create_per_account_local_outbox_folders): Create a local outbox folder
259 for each transport account.
260 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
261 for all local folders.
263 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
264 instead of using g_object_get/set() directly. It is clearer.
266 (modest_tny_folder_store_get_message_count),
267 (modest_tny_folder_store_get_local_size
268 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
269 because we now use these with non-acount folder stores.
271 (modest_tny_account_get_special_folder),
272 (modest_tny_account_new_from_server_account),
273 (modest_tny_account_new_from_account):
274 (recurse_folders): Adjust to the new outbox system.
276 * src/modest-tny-folder.h:
277 * src/modest-tny-folder.c:
278 (modest_tny_folder_is_local_folder),
279 (modest_tny_folder_get_local_folder_type),
280 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
282 * src/widgets/modest-main-window.h:
283 * src/maemo/modest-main-window.c: (create_details_widget),
284 (modest_main_window_set_contents_style): Show details for any folder store,
287 (modest_tny_folder_get_rules):
288 Remove the const. C does not support constness enough for this.
290 * src/modest-ui-actions.c:
291 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
292 make all outboxes appear as one, in the usual local-folders tree node.
294 (set_active_account_from_tny_account),
295 (modest_ui_actions_on_folder_selection_changed):
296 * src/widgets/modest-folder-view.c: (text_cell_data),
297 (icon_cell_data), (filter_row),
298 (add_account_folders_to_merged_folder),
299 (add_account_folders_to_simple_folder_store), (),
300 (get_cmp_rows_type_pos), (cmp_rows),
301 (modest_folder_view_set_account_id_of_visible_server_account):
302 Adjust to the new outbox system, using generic folder stores and folders
305 2007-05-23 Christian Kellner <ckellner@openismus.com>
307 * src/modest-mail-operation.c:
308 (modest_mail_operation_update_account):
309 Use info->max_size instead of unintialized local var [small
310 build fix]. (Added TODO to review that change since I don't
313 2007-05-23 Marcus Bauer <marcusb@openismus.com>
315 * libmodest-dbus-client/libmodest-dbus-client.c:
316 (libmodest_dbus_client_compose_mail): function added
317 * src/dbus_api/modest-dbus-api.h:
318 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
319 (on_compose_mail): Implementation of the SendAsMail functionality
321 2007-05-22 Murray Cumming <murrayc@murrayc.com>
323 * src/modest-account-mgr.c:
324 (modest_account_mgr_add_server_account): Set the secure-connection
325 conf key for transport accounts as well as store accounts. I don't know
326 why the if was there. For instance, this makes sure that we use SSL
327 for the gmail preset from the easysetup wizard.
329 2007-05-22 Murray Cumming <murrayc@murrayc.com>
331 * src/gnome/modest-main-window.c:
332 (on_account_store_connecting_finished), (connect_signals):
333 * src/maemo/modest-main-window.c:
334 (on_account_store_connecting_finished), (connect_signals),
335 (modest_main_window_new):
336 Handle TnyAccountStore::connecting-finished instead of
337 TnyDevice::connection-changed, because we cannot actually perform
338 operations on accounts until TnyAccountStore has itself responded to
339 the TnyDevice::connection-changed signal. This prevents a GError from
341 Do not try to update at startup, because we (at least on scratchbox)
342 already do an update at startup when the device goes online.
343 This prevents a GError from tinymail.
344 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
345 Added TODO about stopping simultaneous operations.
347 2007-05-21 Murray Cumming <murrayc@murrayc.com>
349 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
350 * src/modest-mail-operation-queue.c:
351 (modest_mail_operation_queue_remove):
352 * src/modest-tny-account-store.c: When GErrors happen, give more clues
353 about where they happened.
355 2007-05-21 Murray Cumming <murrayc@murrayc.com>
357 * src/modest-ui-actions.c:
358 (modest_ui_actions_on_password_requested): Make sure that the remember
359 output parameter is always TRUE.
361 2007-05-21 Murray Cumming <murrayc@murrayc.com>
363 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
364 Show a OK/Cancel dialog if the error is a question, though we still do not
365 know anything more about what we are asking the user.
366 * src/widgets/modest-folder-view.c: (on_drag_data_received):
367 Fix an uninitialized variable (helper). This is a logic error, however.
369 2007-05-21 Christian Kellner <ckellner@openismus.com>
371 * src/modest-search.h:
372 Correct bit shifting in the ModestSearchFlags enum.
374 2007-05-21 Murray Cumming <murrayc@murrayc.com>
376 * src/modest-tny-account.c:
377 (modest_tny_account_new_from_server_account): Do not use the lsub and
378 check-all hard-coded IMAP options when using POP.
380 2007-05-21 Murray Cumming <murrayc@murrayc.com>
382 * src/modest-tny-account.c:
383 (modest_tny_account_new_from_server_account):
384 Use NULL for the secure-auth method for POP when Password auth has been
385 specified by the user, as we already do for IMAP. "auth=Login" causes
386 an error from camel or the server.
388 2007-05-17 Murray Cumming <murrayc@murrayc.com>
390 * src/maemo/modest-account-settings-dialog.c:
391 (create_page_account_details),
392 (modest_account_settings_dialog_set_account_name):
393 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
394 for the leave-on-server checkbox, rathr than just the checkbox, when
395 the protocol is not POP.
397 2007-05-17 Murray Cumming <murrayc@murrayc.com>
399 * src/widgets/modest-account-view.c:
400 * src/widgets/modest-account-view.h:
401 Added modest_account_view_select_account() which will be useful later
402 to asynchronously re-select the edited account.
404 2007-05-17 Murray Cumming <murrayc@murrayc.com>
406 * src/maemo/modest-account-settings-dialog.c:
407 (modest_account_settings_dialog_set_account_name):
408 Automatically choose the port numbers based on the secure authentication
409 methods, if they have not been chosen before.
410 This fixes projects.maemo.org bug NB#56273 .
412 2007-05-17 Murray Cumming <murrayc@murrayc.com>
414 * src/maemo/modest-main-window-ui.h:
415 * src/modest-ui-actions.c:
416 * src/modest-ui-actions.h:
417 Connect the Tools/SMTP Servers menu item to
418 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
419 SMTP servers dialog, as in the UI specification and saves changes when it
420 is closed. This fixed projects.maemo.org bug NB#56305 .
422 2007-05-17 Murray Cumming <murrayc@murrayc.com>
424 * src/maemo/modest-connection-specific-smtp-window.c:
425 (modest_connection_specific_smtp_window_init):
426 Use gtk_window_set_default_size() to make this window big enough, so
427 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
429 2007-05-17 Murray Cumming <murrayc@murrayc.com>
431 * src/maemo/modest-connection-specific-smtp-edit-window.h:
432 * src/maemo/modest-connection-specific-smtp-edit-window.c:
433 (modest_connection_specific_smtp_edit_window_init),
434 Do not try to connect to a combobox signal before the combobox exists.
435 This fixes the cras in projects.maemo.org bug NB#56288 .
436 (modest_connection_specific_smtp_edit_window_get_settings):
437 Remove the server_account_name parameter which was being checked for NULL
438 though it was not used.
440 * src/maemo/modest-connection-specific-smtp-window.c:
441 (modest_connection_specific_smtp_window_fill_with_connections),
442 (on_button_edit), (modest_connection_specific_smtp_window_init):
443 Correct the number of treemodel columns to prevent a warning.
444 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
445 libconic does not work.
447 2007-05-16 Murray Cumming <murrayc@murrayc.com>
449 * src/modest-tny-account.c:
450 (modest_tny_account_new_from_server_account):
451 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
452 SMTP when "None" was chosen by the user. However, with my SMTP server that
453 does not support ANONYMOUS, the emails do not leave the Outbox and I see
456 2007-05-16 Murray Cumming <murrayc@murrayc.com>
458 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
459 to explain the memory management issue with the ID in the ModestPair.
461 * src/gnome/modest-account-assistant.c: (add_receiving_page),
462 (add_sending_page), (modest_account_assistant_finalize):
463 * src/gnome/modest-gnome-global-settings-dialog.c:
464 (create_updating_page), (create_composing_page):
465 * src/gnome/modest-msg-edit-window.c: (get_transports),
466 (init_window), (modest_msg_edit_window_finalize),
467 (modest_msg_edit_window_get_msg_data):
468 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
469 * src/gnome/modest-transport-widget.c:
470 (modest_transport_widget_finalize), (smtp_configuration):
471 * src/maemo/modest-maemo-global-settings-dialog.c:
472 (create_updating_page), (create_composing_page):
473 * src/maemo/modest-msg-edit-window.c: (get_transports),
474 (init_window), (modest_msg_edit_window_finalize),
475 (modest_msg_edit_window_get_msg_data),
476 (modest_msg_edit_window_free_msg_data):
477 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
478 (modest_store_widget_finalize):
479 * src/maemo/modest-transport-widget.c:
480 (modest_transport_widget_finalize), (smtp_configuration):
481 * src/modest-main.c: (send_mail):
482 * src/widgets/modest-combo-box.h:
483 * src/widgets/modest-global-settings-dialog-priv.h:
484 * src/widgets/modest-global-settings-dialog.c:
485 (modest_global_settings_dialog_finalize):
486 * src/widgets/modest-msg-edit-window.h:
487 Whenever using modest_combo_box_new(), keep the ModestPairList alive
488 as long as the combo box, to prevent use of freed memory for the ID.
490 2007-05-15 Murray Cumming <murrayc@murrayc.com>
492 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
493 get_accounts(), to make this clearer. Do not check for the enabled gconf
494 key, because we do not use this for server accounts (at least, not yet).
495 This allows us to send email again.
497 2007-05-15 Murray Cumming <murrayc@murrayc.com>
499 * src/maemo/modest-platform.c:
500 (on_modest_conf_update_interval_changed), (modest_platform_init):
501 Only respond to this particular key change. All these strcmp()s cannot be
504 2007-05-15 Murray Cumming <murrayc@murrayc.com>
506 * src/maemo/modest-maemo-global-settings-dialog.c:
507 (current_connection): Prevent a crash in scratchbox when
508 ny_maemo_conic_device_get_current_iap_id() returns NULL.
509 * src/maemo/modest-platform.c:
510 (on_modest_conf_update_interval_changed), (modest_platform_init):
511 Get the update interval from gconf and reset it when the gconf key changes.
513 2007-05-15 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-protocol-info.c:
516 * src/modest-protocol-info.h: Adde enum-specific get functions,
517 instead of using a ModestProtocolType enum parameter.
519 * src/gnome/modest-account-assistant.c:
520 * src/gnome/modest-store-widget.c:
521 * src/gnome/modest-store-widget.h:
522 * src/gnome/modest-transport-widget.c:
523 * src/gnome/modest-transport-widget.h:
524 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
525 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
526 * src/maemo/easysetup/modest-easysetup-wizard.c:
527 * src/maemo/modest-account-settings-dialog.c:
528 * src/maemo/modest-account-settings-dialog.h:
529 * src/maemo/modest-store-widget.c:
530 * src/maemo/modest-store-widget.h:
531 * src/maemo/modest-transport-widget.c:
532 * src/maemo/modest-transport-widget.h:
533 * src/modest-account-mgr-helpers.c:
534 * src/modest-account-mgr-helpers.h:
535 * src/modest-account-mgr.c:
536 * src/modest-account-mgr.h:
537 * src/modest-tny-account.c:
538 * src/modest-tny-folder.c:
539 * src/widgets/modest-account-view.c:
540 * src/widgets/modest-retrieve-combo-box.c:
541 * src/widgets/modest-retrieve-combo-box.h:
542 * src/widgets/modest-secureauth-combo-box.c:
543 * src/widgets/modest-serversecurity-combo-box.c:
544 * src/widgets/modest-serversecurity-combo-box.h:
545 * tests/check_account-mgr.c:
546 Use the specific functions, and use the re-renamed enum values for GNOME too.
548 2007-05-15 Murray Cumming <murrayc@murrayc.com>
551 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
552 so we can get the second based on the first.
554 * src/maemo/modest-account-settings-dialog.h:
555 * src/maemo/modest-account-settings-dialog.c:
556 Added get_supported_secure_authentication_methods(), though it is mostly
557 commented-out for now until the necessary API is committed to tinymail.
558 (modest_account_settings_dialog_set_account_name),
559 (save_configuration): Request the supported authentication methods from the
560 server, so we can choose a working method.
562 * src/modest-tny-account-store.h:
563 * src/modest-tny-account-store.c:
564 (modest_tny_account_store_get_session): Rename from
565 tny_account_store_get_session().
567 2007-05-14 Murray Cumming <murrayc@murrayc.com>
569 * src/modest-protocol-info.h: Split the ModestProtocol enum
570 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
571 There was no need to have these unrelated values in one enum.
573 * src/: many files: Adapted to changed enum. This makes the code a bit
574 clearer, and the compiler could catch some errors.
576 2007-05-14 Murray Cumming <murrayc@murrayc.com>
578 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
579 Show the detailed internal camel error message when an error happens
580 during the configuration, so that our testers can give us more clues.
581 For instance, in projects.maemo.org bug NB#56910 .
583 2007-05-14 Murray Cumming <murrayc@murrayc.com>
585 * src/modest-tny-account.c:
586 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
587 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
589 2007-05-14 Murray Cumming <murrayc@murrayc.com>
591 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
592 * src/maemo/modest-account-settings-dialog.c:
593 (modest_account_settings_dialog_set_account_name),
594 (save_configuration): For the incoming secure authentication checkbox,
595 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
596 the UI specification. PLAIN does not seem to be supported for most IMAP
597 servers anyway, and I am not sure what it would mean.
598 However, we probably need to discover which of the secure-authentication
599 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
600 * src/modest-account-mgr-helpers.c:
601 (modest_account_mgr_get_server_account_data):
603 * src/modest-tny-account.c:
604 (modest_tny_account_new_from_server_account):
605 Use tny_account_set_mech() to set secure-authentication methods,
606 with some special-casing for IMAP, based on my observations of how
609 * src/modest-account-mgr-helpers.h:
610 * src/modest-account-mgr.c:
611 * src/modest-defs.h: Comment that the URI is only used for local folders.
613 2007-05-11 Murray Cumming <murrayc@murrayc.com>
615 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
616 parameter const, just to be neat.
617 * src/modest-text-utils.c: (modest_text_utils_inline):
618 End g_strconcat() with NULL, as its documentation says. This is almost
619 certainly the cause of my crash at startup on the device. Interestingly,
620 valgrind doesn't tell us about these errors.
622 2007-05-11 Murray Cumming <murrayc@murrayc.com>
624 * scripts/build-packages: Added more precise comments about how to use
625 this script, though I still get this error:
626 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
627 error building tinymail
629 2007-05-11 Murray Cumming <murrayc@murrayc.com>
631 * src/maemo/modest-main-window.c: (on_account_update):
632 Very slight cleanup, hoping to make it simpler to discover what causes
633 a crash here sometimes.
635 * src/modest-tny-account.c:
636 (modest_tny_account_new_from_server_account): Set the port. Added
637 comments about the options and a TODO comment because I need to find out
638 how to specify the secure authentication method.
640 2007-05-11 Marcus Bauer <marcusb@openismus.com>
642 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
643 changed CFlags paths form modest to libmodest
645 2007-05-10 Murray Cumming <murrayc@murrayc.com>
647 * src/modest-account-mgr-helpers.c:
648 (modest_account_mgr_get_server_account_data),
649 (modest_account_mgr_free_server_account_data):
650 * src/modest-account-mgr-helpers.h:
651 * src/modest-account-mgr.c:
652 (modest_account_mgr_add_server_account):
654 * src/modest-tny-account.c:
655 (modest_tny_account_new_from_server_account):
656 Determine the options for tny_camel_account_add_option() here,
657 based on the settings, rather than storing them directly in gconf.
659 2007-05-10 Murray Cumming <murrayc@murrayc.com>
661 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
662 Show a more friendly error dialog now that we expect (from the tinymail
663 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
665 2007-05-10 Murray Cumming <murrayc@murrayc.com>
667 * src/maemo/modest-main-window.c: (on_account_update): Check that
668 account_name is not NULL, to prevent a crash at startup that I am
669 seeing on the N800. I do wonder why it is NULL.
671 * src/maemo/easysetup/modest-easysetup-wizard.c:
672 (create_page_user_details):
673 * src/maemo/modest-account-settings-dialog.c:
674 (create_page_user_details), (create_page_outgoing):
675 * src/maemo/modest-connection-specific-smtp-edit-window.c:
676 (modest_connection_specific_smtp_edit_window_init):
677 * src/modest-ui-actions.c:
678 (modest_ui_actions_on_password_requested):
679 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
680 might do something useful with the on-screen keyboard.
682 2007-05-10 Murray Cumming <murrayc@murrayc.com>
684 * src/maemo/modest-main-window.c: (on_account_update):
685 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
686 NULL, to avoid lots of warnings. However, it probably should not be NULL.
688 2007-05-09 Murray Cumming <murrayc@murrayc.com>
690 * src/modest-tny-account-store.c: (on_account_changed):
691 Correct the signature of this signal handler.
693 2007-05-09 Murray Cumming <murrayc@murrayc.com>
695 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
696 Show a HildonNote instead of a GtkDialog for Maemo.
698 2007-05-09 Murray Cumming <murrayc@murrayc.com>
700 * src/widgets/modest-account-view.h:
701 * src/widgets/modest-account-view.c: (on_account_changed),
702 (on_account_removed). Added a boolean flag, set/unset by
703 modest_account_view_block_conf_updates(),
704 modest_account_view_unblock_conf_updates() to prevent unnecessary
705 updates, but this is not very useful because the gconf notifications are
706 so delays (maybe only on Maemo Bora).
707 So auto-updating is turned off, and these functions do an explicit
708 update when necessary.
709 However, something else is still doing too much work when adding/removing
710 accounts, probably in another part of the application.
712 * src/maemo/modest-account-view-window.c:
713 (on_delete_button_clicked), (on_edit_button_clicked),
714 (on_new_button_clicked): Use the new functions.
716 2007-05-09 Murray Cumming <murrayc@murrayc.com>
718 * src/modest-account-mgr-helpers.c:
719 (modest_account_mgr_set_first_account_as_default):
720 Sort the list of names alphabetically-by-title, so we choose the first one
722 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
723 alphabetically by the title.
725 This fixes projects.maemo.org bug NB#56418 .
727 * src/modest-account-mgr-priv.c:
728 (_modest_account_mgr_account_from_key):
729 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
730 avoid a valgrind error, and possible random behaviour.
732 2007-05-09 Murray Cumming <murrayc@murrayc.com>
734 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
735 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
736 tinymail documentation to say that this can be expected.
737 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
738 pretty, and should not happen, but I would prefer to know when it does.
740 2007-05-09 Murray Cumming <murrayc@murrayc.com>
742 * configure.ac: When using the older hildon version, probably on Bora,
743 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
745 * src/widgets/modest-attachment-view.c:
746 (modest_attachment_view_set_part_default): Initialize variables, to fix the
749 2007-05-09 Marcus Bauer <marcusb@openismus.com>
751 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
752 Implemented the prototype. Can be tested with
753 tests/dbus_api/test_open_message:
755 2007-05-08 Murray Cumming <murrayc@murrayc.com>
757 * src/modest-tny-account-store.c:
758 (modest_tny_account_store_instance_init), (get_password):
759 * src/modest-ui-actions.c:
760 (modest_ui_actions_on_password_requested):
761 Do not store the password in gconf, because this function is called
762 for non-remembered passwords. Actually use the cached (in the hash map)
763 password instead of releasing it.
764 The password will now not be remembered if it is asked via the protected
765 password dialog, as per the UI spec.
767 2007-05-08 Murray Cumming <murrayc@murrayc.com>
770 * src/modest-account-mgr-helpers.h:
771 * src/modest-account-mgr-helpers.c:
772 Added modest_server_account_get_username_has_succeeded(),
773 modest_server_account_set_username_has_succeeded().
774 (modest_server_account_set_username),
775 Reset the has-succeeded flag if the username changes.
777 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
778 * src/maemo/modest-connection-specific-smtp-window.c:
779 (modest_connection_specific_smtp_window_save_server_accounts):
780 Use modest_server_account_set_username() instead of using
781 modest_conf_set_string() directly, so that the has-succeeded flag is always
784 * src/modest-ui-actions.c:
785 (modest_ui_actions_on_password_requested): Dim the username entry if
786 the username has ever worked, as per the UI spec.
788 2007-05-08 Murray Cumming <murrayc@murrayc.com>
790 * src/modest-tny-account-store.c: (get_password):
791 * src/modest-ui-actions.c:
792 (modest_ui_actions_on_password_requested):
793 Allow the username to be changed too, though there is more work to
794 be done on exactly how this behaves.
796 2007-05-08 Murray Cumming <murrayc@murrayc.com>
798 * src/modest-account-mgr-helpers.h:
799 * src/modest-account-mgr-helpers.c:
800 Added modest_account_mgr_get_display_name(),
801 modest_server_account_get_username(),
802 modest_server_account_set_username(),
803 modest_server_account_set_password(),
804 modest_server_account_get_hostname() functions so we do not need to
805 use the conf API directly.
807 * src/maemo/modest-main-window.c: (connect_signals):
808 Actually connect ot the ModestAccountStore::request-password signal,
809 so that we show the dialog when the password is requested by Tinymail,
810 for isntance if it is empty.
812 * src/modest-marshal.list:
813 * src/modest-tny-account-store.c:
814 (modest_tny_account_store_class_init), (get_password),
815 (modest_tny_account_store_alert):
816 * src/modest-tny-account-store.h:
817 * src/modest-ui-actions.h:
818 * src/modest-ui-actions.c:
819 (modest_ui_actions_on_password_requested):
820 Change the signal parameters, so it is obvious that we are providing
821 the non human-readable server name, and receiving both the username
822 and password, though changing of the username is not yet implemented.
823 Change the dialog UI to match the Maemo UI specifications, with #idfefing
824 for the GNOME version.
826 This should fix the projects.maemo.org bug NB#56209, though it does not
827 work on Bora, because the gconf_client_get() for the password fails
828 immediately after we save it with gconf_client_set().
830 2007-05-08 Murray Cumming <murrayc@murrayc.com>
833 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
834 caused an undefined symbol error:
835 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
837 2007-05-08 Murray Cumming <murrayc@murrayc.com>
839 * src/modest-tny-account-store.c:
840 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
841 using a GError instead of a string message, so we can translate it in
844 2007-05-08 Murray Cumming <murrayc@murrayc.com>
846 * src/maemo/modest-address-book.c:
847 (modest_address_book_check_names):
848 * src/maemo/modest-msg-view-window.c:
849 (modest_msg_view_window_clipboard_owner_change):
850 * src/modest-init.c: (modest_init_init_ui):
851 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
852 (update_folders_cb), (modest_mail_operation_update_account):
853 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
854 (modest_ui_actions_on_msg_attachment_clicked),
855 (modest_ui_actions_on_msg_recpt_activated):
856 * src/widgets/modest-header-view.c: (drag_data_get_cb):
857 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
858 (modest_msg_view_search_next):
859 * src/widgets/modest-recpt-editor.c:
860 (modest_recpt_editor_on_button_release_event),
861 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
862 g_message(). At this point we should only be seeing interesting errors on
863 stdout. Debugging messages could be #ifdefed-out if they are still useful.
865 2007-05-07 Murray Cumming <murrayc@murrayc.com>
867 (modest_wizard_dialog_force_title_update):
868 * src/maemo/easysetup/modest-wizard-dialog.h:
869 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
870 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
871 can update the title when appropriate. Otherwise the title is wrong if the
872 pages are added after adding the notebook to the dialog.
873 This must be a problem in HildonWizardDialog too.
874 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
876 * src/maemo/easysetup/modest-easysetup-wizard.c:
877 (create_subsequent_customsetup_pages),
878 (create_subsequent_easysetup_pages):
879 Call modest_wizard_dialog_force_title_update() so that the title is
880 correct even with GTK+ < 2.10.
881 This fixes projects.maemo.org bug NB#56145 .
883 2007-05-07 Murray Cumming <murrayc@murrayc.com>
885 * src/maemo/modest-platform.c:
886 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
887 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
890 2007-05-07 Murray Cumming <murrayc@murrayc.com>
892 * src/widgets/modest-window.h:
893 * src/widgets/modest-window.c: Added a save_state_func vfunc,
894 and modest_window_save_state(), which invokes it.
896 * src/widgets/modest-window-mgr.h:
897 * src/widgets/modest-window-mgr.c:
898 Added modest_window_mgr_save_state_for_all_windows(), which calls
899 the save_state vfunc on all registered windows, if implemented.
901 * src/gnome/modest-msg-edit-window.c:
902 * src/gnome/modest-msg-view-window.c:
903 * src/maemo/modest-msg-edit-window.c:
904 * src/maemo/modest-msg-view-window.c:
905 * src/maemo/modest-main-window.c:
906 Specify the existing save_settings functions as implementations of
907 ModestWindow::save_state_func().
909 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
910 Call modest_window_mgr_save_state_for_all_windows(). This happens before
911 enabling hibernation, for instance.
913 We may need to do the same thing for restoring settings.
916 2007-05-07 Murray Cumming <murrayc@murrayc.com>
918 * src/widgets/modest-window-mgr.c:
919 * src/widgets/modest-window-mgr.h:
920 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
921 modest_window_mgr_get_hibernation_is_prevented().
923 * src/maemo/modest-main-window.c:
924 (on_hildon_program_is_topmost_notify): Prevent hibernation
925 (possible when the application goes to the background in the WM),
926 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
928 * src/maemo/easysetup/modest-easysetup-wizard.c:
929 (modest_easysetup_wizard_dialog_init):
930 * src/maemo/modest-account-settings-dialog.c:
931 (modest_account_settings_dialog_init):
932 * src/maemo/modest-connection-specific-smtp-edit-window.c:
933 (modest_connection_specific_smtp_edit_window_init):
934 * src/maemo/modest-connection-specific-smtp-window.c:
935 (modest_connection_specific_smtp_window_init):
936 * src/maemo/modest-signature-editor-dialog.c:
937 (modest_signature_editor_dialog_init):
938 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
939 prevent hibernation while any of these account settings dialogs are open.
941 2007-05-04 Murray Cumming <murrayc@murrayc.com>
943 * src/maemo/Makefile.am:
944 * src/maemo/modest-osso-state-saving.c:
945 * src/maemo/modest-osso-state-saving.h: Added
946 modest_osso_load_state() and modest_osso_save_state() though they do
947 nothing now. They should iterate through all the open windows and load/save
949 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
950 save state when closing.
952 * src/maemo/modest-main-window.c:
953 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
954 Add a notification handler for the HildonProgram::is-topmost property,
955 so we can allow hibernation when the application goes into the background.
956 But we still need to detect when the accounts setup windows are open so
957 we can stop hibernation when they are open.
958 To do this, I also added the main window the HildonProgram. This might have
959 other side-effects/benefits, and should maybe be done for other windows.
961 * src/maemo/modest-osso-autosave-callbacks.h:
962 * src/maemo/modest-osso-autosave-callbacks.c:
963 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
964 though it does not do anything yet, and we might never need this to do
965 anything. For instance, we already save drafts.
967 * src/maemo/modest-platform.c: (modest_platform_init):
968 Specify the libosso auto-save callback.
970 2007-05-03 Murray Cumming <murrayc@murrayc.com>
972 * src/maemo/modest-platform.c:
973 (modest_platform_set_update_interval):
974 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
975 aparently stays valid between application instances, so we can use this
976 to remove and reset it later. According to a maemo-developers email from
979 2007-05-03 Murray Cumming <murrayc@murrayc.com>
981 * configure.ac: Depend on libalarm for Maemo.
983 * src/dbus_api/modest-dbus-api.h:
984 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
985 (on_send_receive), (modest_dbus_req_handler):
986 Handle a SEND_RECEIVE D-Bus method.
988 * libmodest-dbus-client/libmodest-dbus-client.c:
989 (libmodest_dbus_client_send_and_receive):
990 * libmodest-dbus-client/libmodest-dbus-client.h:
991 Add C convenience functions for calling the new D-Bus method.
993 * src/modest-platform.h:
994 * src/gnome/modest-platform.c:
995 * src/maemo/modest-platform.c:
996 Added modest_platform_set_update_interval(), which uses the
998 (modest_platform_init),
999 Call modest_platform_set_update_interval(), using a hard-coded
1000 interval for now (until the global settings dialog is implemented),
1001 though I am not sure that this makes sense yet.
1003 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1005 * src/dbus_api/modest-dbus-callbacks.c:
1006 (modest_osso_cb_hw_state_handler):
1007 * src/dbus_api/modest-dbus-callbacks.h:
1008 * src/maemo/modest-platform.c: (modest_platform_init):
1009 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1010 in case this has some effect on the ability for Maemo to ping the
1013 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1015 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1016 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1017 warning. It is probably a logic error, but I need to fix the build.
1019 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1021 * src/modest-account-mgr.h:
1022 * src/modest-account-mgr.c:
1023 (modest_account_mgr_account_names): Add a gboolean enabled_only
1024 parameter, so we can get lists of onlt the enabled accounts.
1026 (modest_account_mgr_add_account),,
1027 (modest_account_mgr_account_with_display_name_exists):
1028 * src/maemo/modest-msg-edit-window.c: (get_transports):
1029 * src/modest-account-mgr-helpers.c:
1030 (modest_account_mgr_set_first_account_as_default):
1031 * src/modest-init.c: (init_default_account_maybe):
1032 * src/modest-tny-account-store.c: (get_accounts):
1033 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1034 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1035 * tests/check_account-mgr.c: (START_TEST):
1036 Provide the extra parameter, as appropriate.
1038 * src/widgets/modest-account-view.c: (update_account_view):
1039 Do not show disabled accounts (meaning that there is no way to
1040 enable/disable accounts in the UI (the feature is not in our UI
1041 specification), so we can use this internally only to mark unfinished
1042 or temporary account data.
1044 * src/maemo/easysetup/modest-easysetup-wizard.c:
1045 (create_account): Add boolean enable parameter, so we can specify FALSE
1046 to create the temporary account.
1047 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1048 (on_before_next): When finishing, when there is a temporary account, just
1050 Also, use a timeout to delay the showing of the dialog until gconf is likely
1051 to return correct information, due to a maemo gconf bug that is fixed in
1052 osso 1.1, but not yet in Bora.
1053 However, the dialog stays on screen after it is destroyed.
1055 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1056 for invalid data when cancelling. Use a hildon note instead of a dialog
1057 to complain about invalid data. Do not show the account-saved note if the
1058 account is disabled (a temporary account that will not really be saved for use
1061 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1063 * src/modest-account-mgr-helpers.h:
1064 * src/modest-account-mgr-helpers.c:
1065 Added modest_account_mgr_unset_default_account(),
1066 Added modest_account_mgr_set_first_account_as_default().
1068 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1069 If it was the default account, unset the default account name.
1071 * src/maemo/modest-account-view-window.c:
1072 (on_delete_button_clicked): If it was the default account,
1073 set the first remaining account as the default instead.
1075 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1076 a NULL account or a NULL default account, to prevent a crash. This should
1077 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1080 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1082 * src/widgets/modest-recpt-editor.c:
1083 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1084 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1085 TODO comment for this. This fixes the build.
1087 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1088 be the best place for it. This will in future update all auto-update accounts,
1089 rather than just the current/default account, when that gconf key exists.
1090 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1091 if there are no accounts, before calling do_send_receive().
1092 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1094 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1095 * src/maemo/modest-main-window-ui.h:
1096 * src/maemo/modest-main-window.c: (on_connection_changed),
1097 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1098 directly, becaue the signal handler does more.
1100 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1102 * src/modest-account-mgr-helpers.c:
1103 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1104 for the case that the account does not exist.
1106 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1107 (equivalent to the modest account name) rather than the tinymail account name
1108 (equivalent to the modest account title - human readable) to get the account data.
1109 Check for null account data to prevent the crash, and add a TODO comment saying that
1110 this needs fixing because it is using the server account name instead of the account name.
1112 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1114 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1115 * src/maemo/modest-account-settings-dialog.c: (show_error),
1117 Use hildon_note_new_information() for informative and error messages,
1118 which seems to be expected for Maemo applications (no documentation that I know of
1119 says this). I am surprised that there is no distinction between info and error
1122 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1124 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1125 it is easy to find where this is used.
1127 * src/maemo/easysetup/modest-easysetup-wizard.c:
1128 (create_page_welcome), (create_page_account_details),
1129 (create_page_user_details), (create_page_complete_easysetup),
1130 (create_page_custom_incoming), (create_page_custom_outgoing),
1131 (create_page_complete_custom):
1132 * src/maemo/modest-account-settings-dialog.c:
1133 (create_page_account_details), (create_page_user_details),
1134 (create_page_incoming), (create_page_outgoing):
1135 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1136 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1137 (modest_connection_specific_smtp_edit_window_init):
1138 * src/maemo/modest-connection-specific-smtp-window.c:
1139 (modest_connection_specific_smtp_window_init):
1140 * src/maemo/modest-signature-editor-dialog.c:
1141 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1142 and scrolling policy as per the Email Application Layout Guide, if I have
1145 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1147 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1148 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1149 which were empty, because these vfuncs have been removed from TnyAccountStore.
1150 This fixes the build.
1152 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1154 * src/maemo/modest-main-window.c:
1155 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1156 showing/hiding it. Added TODO because it probably should not be NULL.
1157 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1158 because unnecessary g_warnings() make degugging difficult.
1160 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1162 * src/maemo/modest-msg-edit-window.c:
1163 (modest_msg_edit_window_select_color),
1164 (modest_msg_edit_window_select_background_color): 2 const corrections and
1165 moving 2 #endifs before closing brackets, to fix the build.
1167 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1169 * src/maemo/easysetup/modest-easysetup-wizard.h:
1170 * src/maemo/easysetup/modest-easysetup-wizard.c:
1171 (modest_easysetup_wizard_dialog_finalize),
1172 (on_button_edit_advanced_settings), (create_page_complete_custom),
1173 (on_response), (create_account):
1174 Implement the Advanced Settings edit button, by saving the account information,
1175 for the Advanded Settings dialog to use directly from gconf, and removing it
1176 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1177 Bug #5533 in the projects.maemo.org bugzilla.
1179 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1181 * src/maemo/modest-msg-view-window.c:
1182 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1183 when opening a message window.
1185 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1187 * src/maemo/easysetup/modest-easysetup-wizard.c:
1188 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1191 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1192 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1193 gconf settings. I probably added more checks than necessary, but that is safer.
1195 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1196 variable to fix the build, but this seems to be used when it is still NULL.
1198 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1200 * src/modest-platform.h:
1201 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1202 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1203 * src/modest-main.c: Implement this function so we can avoid using
1204 maemo-specific API from cross-platform code.
1206 * src/modest-tny-account-store.c:
1207 (get_smtp_specific_transport_account_for_open_connection):
1208 * src/modest-ui-actions.c: (check_for_connection),
1209 (modest_ui_actions_on_item_not_found):
1210 Use modest_platform_connect_and_wait() and put #idefs around other
1211 maemo-specific code, because only maemo currently has a way to
1212 identify connection names.
1214 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1216 * src/modest-tny-account-store.h:
1217 * src/modest-tny-account-store.c:
1218 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1219 the connection-specific SMTP server settings in the configuration.
1221 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1223 * src/maemo/modest-main-window.c: (on_connection_changed),
1225 * src/modest-main.c: (main), (start_ui), (send_mail):
1226 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1227 that is what is intended.
1229 * src/modest-ui-actions.c: (action_send), (action_receive),
1230 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1231 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1232 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1233 SMTP server is used when it is specified.
1235 (modest_ui_actions_on_send_receive):
1236 Check that a connection is open before proceeding.
1237 Receive and then send, instead of vice-versa, as per the specification.
1239 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1241 * src/modest-mail-operation.c:
1242 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1243 though I guess it should be something other than NULL.
1245 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1247 * src/maemo/easysetup/modest-easysetup-wizard.c:
1248 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1249 combo twice, to avoid an g_warning and to make it visible again.
1250 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1251 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1252 (already intended) dereference when detaching, because we then recreate the menu.
1253 But I am not sure why the warning was happening, and it is possible that this is a memory
1256 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1258 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1259 and uri_parse_mailto() utility functions.
1260 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1262 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1264 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1266 * src/dbus_api/modest-dbus-api.h:
1267 * src/dbus_api/modest-dbus-callbacks.c:
1268 Use an idle callback to execute the modest code in the application's own thread.
1269 Remove the helloworld example method.
1270 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1271 parsed, and the open-message method is not implemented because this is not yet implemented in
1273 * libmodest-dbus-client/libmodest-dbus-client.c:
1274 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1275 (libmodest_dbus_client_open_message):
1276 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1278 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1279 body without crashing.
1281 * tests/dbus_api/Makefile.am:
1282 * tests/dbus_api/test_mail_to.c:
1283 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1285 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1287 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1288 Added file to fix the build. Sorry.
1290 * src/dbus_api/Makefile.am:
1291 * src/dbus_api/modest-dbus-api.h:
1292 * src/dbus_api/modest-dbus-callbacks.h:
1293 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1294 (modest_dbus_req_handler):
1295 Put constants in a separate header so it can be reused by the
1296 client library, without duplication
1298 * libmodest-dbus-client/Makefile.am:
1299 * libmodest-dbus-client/libmodest-dbus-client.c:
1300 (libmodest_dbus_client_call_helloworld),
1301 (libmodfest_dbus_client_send_mail),
1302 (libmodfest_dbus_client_mailto),
1303 (libmodfest_dbus_client_open_message):
1304 * libmodest-dbus-client/libmodest-dbus-client.h:
1305 (Partly) Implement a send_mail D-Bus method.
1307 * tests/dbus_api/Makefile.am:
1308 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1309 the send_email D-Bus method.
1311 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1315 * libmodest-dbus-client/Makefile.am:
1316 * libmodest-dbus-client/libmodest-dbus-client.c:
1317 * libmodest-dbus-client/libmodest-dbus-client.h:
1318 * tests/dbus_api/Makefile.am:
1319 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1320 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1322 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1324 * src/maemo/easysetup/modest-easysetup-wizard.c:
1325 (create_page_account_details):
1326 * src/maemo/modest-account-settings-dialog.c:
1327 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1328 widgets, because this might not be the default in future versions of the Maemo GTK+.
1329 However, I can not not get capitalization to work even in a simple test case.
1331 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1333 * src/maemo/easysetup/modest-easysetup-wizard.c:
1334 (create_page_custom_incoming), (create_page_custom_outgoing):
1335 * src/maemo/modest-account-settings-dialog.c:
1336 (create_page_account_details), (create_page_incoming),
1337 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1338 instead of using gtk_check_button_with_label(), so they are aligned like the other
1339 widgets, as per the UI spec.
1341 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1343 * src/maemo/easysetup/modest-easysetup-wizard.c:
1344 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1345 * src/widgets/modest-validating-entry.c:
1346 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1347 Modest prefix instead of an EasySetup prefix.
1349 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1351 * src/widgets/modest-validating-entry.h:
1352 * src/widgets/modest-validating-entry.c: (on_insert_text),
1353 Added easysetup_validating_entry_set_max_func(), used to set a callback
1354 to call when the max number of characters is reached. GtkEntry has a max-length
1355 already but is silent about it.
1357 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1358 (create_page_account_details), (create_page_user_details),
1360 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1361 (create_page_account_details), (create_page_user_details),
1362 (create_page_outgoing):
1363 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1364 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1365 the UI spec, when the user tries to enter more than the max number of characters.
1367 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1369 * src/maemo/easysetup/modest-easysetup-wizard.c:
1370 (create_page_user_details), (create_page_custom_incoming),
1371 (create_page_custom_outgoing):
1372 * src/maemo/modest-account-settings-dialog.c:
1373 (create_page_user_details), (create_page_incoming),
1374 (create_page_outgoing):
1375 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1376 (modest_connection_specific_smtp_edit_window_init):
1377 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1378 not appropriate. Bad Maemo-specific defaults!.
1380 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1382 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1383 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1384 (modest_signature_editor_dialog_set_settings):
1385 Disable the label and textview when the checkbox is disabled, and use the
1386 specified (UI spec) default signature text.
1388 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1390 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1391 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1393 * src/modest-defs.h:
1394 * src/modest-account-mgr-helpers.h:
1395 * src/modest-account-mgr-helpers.c:
1396 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1398 * src/maemo/Makefile.am:
1399 * src/maemo/modest-signature-editor-dialog.c:
1400 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1403 * src/maemo/modest-account-settings-dialog.h:
1404 * src/maemo/modest-account-settings-dialog.c:
1405 (modest_account_settings_dialog_finalize), (on_button_signature),
1406 (save_configuration): Use the new dialog when the Edit button is pressed, and
1407 save the changes if necessary, as per the UI spec.
1409 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1411 * src/maemo/Makefile.am:
1412 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1413 based on maemo-develoers email from Dirk.
1415 * src/maemo/easysetup/modest-easysetup-wizard.c:
1416 (create_page_welcome), (create_page_account_details),
1417 (create_page_user_details), (create_page_complete_easysetup),
1418 (create_page_custom_incoming), (create_page_custom_outgoing),
1419 (create_page_complete_custom),
1420 (modest_easysetup_wizard_dialog_init):
1421 * src/maemo/modest-account-settings-dialog.c:
1422 (create_page_account_details), (create_page_user_details),
1423 (create_page_incoming), (create_page_outgoing),
1424 (modest_account_settings_dialog_init):
1425 * src/maemo/modest-connection-specific-smtp-window.c:
1426 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1428 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1430 * src/maemo/easysetup/modest-easysetup-wizard.c:
1431 (create_page_account_details), (create_page_custom_outgoing),
1432 (create_page_complete_custom):
1433 * src/maemo/modest-account-settings-dialog.c:
1434 (create_page_user_details), (create_page_incoming),
1435 (create_page_outgoing):
1436 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1437 (modest_connection_specific_smtp_edit_window_init):
1438 Use the correct (UI spec) port min/max, and use horizontal separators,
1441 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1443 * src/maemo/easysetup/modest-easysetup-wizard.c:
1444 (set_default_custom_servernames):
1445 * src/maemo/modest-account-settings-dialog.c:
1446 (create_page_incoming), (on_combo_outgoing_security_changed),
1447 (on_combo_incoming_security_changed), (create_page_outgoing),
1448 (modest_account_settings_dialog_set_account_name),
1449 (save_configuration):
1450 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1451 (on_combo_security_changed),
1452 (modest_connection_specific_smtp_edit_window_init),
1453 (modest_connection_specific_smtp_edit_window_set_connection),
1454 (modest_connection_specific_smtp_edit_window_get_settings):
1455 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1458 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1461 * src/maemo/easysetup/modest-easysetup-wizard.c:
1462 (create_page_custom_outgoing), (create_page_complete_custom):
1463 * src/maemo/modest-account-settings-dialog.c:
1464 (create_page_user_details), (create_page_outgoing):
1465 * src/maemo/modest-account-view-window.c: (button_box_new):
1466 Use changed logical IDs as per the most recent UI spec:
1467 mcen_bd_emailsetup_edit -> mcen_bd_edit
1468 mcen_bd_emailsetup_delete -> mcen_bd_delete
1469 mcen_bd_emailsetup_close -> mcen_bd_close
1471 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1475 * src/dbus_api/Makefile.am:
1476 * src/dbus_api/modest-dbus-callbacks.c:
1477 * src/dbus_api/modest-dbus-callbacks.h:
1478 * src/maemo/modest-platform.c: (modest_platform_init):
1479 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1481 * tests/Makefile.am:
1482 * tests/dbus_api/Makefile.am:
1483 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1485 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1487 * src/maemo/modest-account-settings-dialog.c:
1488 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1489 Removed unnecessary includes.
1491 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1493 * src/maemo/easysetup/modest-easysetup-wizard.c:
1494 * src/maemo/modest-account-settings-dialog.c:
1495 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1496 * src/widgets/Makefile.am:
1497 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1498 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1499 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1500 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1501 * src/widgets/modest-secureauth-combo-box.c:
1502 * src/widgets/modest-secureauth-combo-box.h:
1503 * src/widgets/modest-serversecurity-combo-box.c:
1504 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1505 made the GObject names more consistent with the rest of the Modest code.
1507 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1509 * src/maemo/easysetup/Makefile.am:
1510 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1511 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1512 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1513 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1514 * src/maemo/easysetup/modest-easysetup-wizard.c:
1515 * src/maemo/easysetup/modest-validating-entry.c:
1516 * src/maemo/easysetup/modest-validating-entry.h:
1517 * src/maemo/modest-account-settings-dialog.c:
1518 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1519 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1520 widgets/ because they are used outside of easysetup too. After checking in,
1521 svn will allow me to rename them too.
1523 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1525 * src/gnome/modest-msg-edit-window.c:
1526 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1527 linker error, to fix the build on the GNOME platform.
1528 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1529 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1530 ifdefed out to avoid a warning.
1532 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1534 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1535 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1536 some alternative for GTK+ 2.6.
1538 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1540 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1542 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1543 specified for EmailAccountsDialog in UI spec.
1545 * src/maemo/easysetup/modest-easysetup-wizard.c:
1546 * src/maemo/easysetup/modest-easysetup-wizard.h:
1547 * src/maemo/modest-account-settings-dialog.c:
1548 * src/maemo/modest-account-settings-dialog.h:
1549 Reuse a member window widget for the connection-specific SMTP server accounts,
1550 so we can tell it to create/save the accounts only if we actually save changes.
1552 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1553 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1554 (modest_connection_specific_smtp_edit_window_get_settings):
1555 Return a struct instance for temporarily remembering the entered data.
1557 * src/maemo/modest-connection-specific-smtp-window.h:
1558 * src/maemo/modest-connection-specific-smtp-window.c:
1559 (modest_connection_specific_smtp_window_finalize),
1560 (modest_connection_specific_smtp_window_fill_with_connections),
1562 (modest_connection_specific_smtp_window_save_server_accounts),
1563 (update_model_server_names): Do not actually save data until asked,
1564 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1566 (on_selection_changed),
1567 (modest_connection_specific_smtp_window_init): Disable the edit
1568 button when nothing is selected.
1570 * src/modest-account-mgr-helpers.c:
1571 * src/modest-account-mgr-helpers.h:
1572 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1575 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1577 * src/modest-account-mgr-helpers.h:
1578 * src/modest-account-mgr-helpers.c:
1579 (modest_account_mgr_get_unused_account_name),
1580 (modest_account_mgr_get_unused_account_display_name): Added these
1581 utility functions, to avoid code duplication.
1583 * src/maemo/easysetup/modest-easysetup-wizard.c:
1584 (create_page_account_details), (create_account):
1585 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1586 (on_combo_security_changed),
1587 (modest_connection_specific_smtp_edit_window_init),
1588 (modest_connection_specific_smtp_edit_window_save_settings):
1589 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1590 * src/maemo/modest-connection-specific-smtp-window.c:
1591 (modest_connection_specific_smtp_window_finalize),
1592 (modest_connection_specific_smtp_window_fill_with_connections),
1593 (on_button_edit), (modest_connection_specific_smtp_window_init):
1594 * src/maemo/modest-connection-specific-smtp-window.h:
1595 Implementing saving of connection-specific server accounts.
1597 But I need to refactor this so we can save the data for each
1598 possible connection-specific account and only actually create the server accounts
1599 when the easysetup finished, or the OK button is pressed on the account settings
1602 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1604 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1605 (on_combo_security_changed):
1606 (modest_connection_specific_smtp_edit_window_init):
1607 Auto-fill the port number as in the account settings.
1609 (modest_connection_specific_smtp_edit_window_set_connection):
1610 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1611 * src/maemo/modest-connection-specific-smtp-window.c:
1612 (fill_with_connections), (on_button_edit),
1613 (modest_connection_specific_smtp_window_init):
1614 Turn the edit window into a dialog to simplify the code, and
1615 set a WM hint as in a GtkDialog, because only a popup can be on top of
1616 another window in Maemo, and popups usually have no WM decoration.
1618 * src/modest-defs.h:
1619 * src/modest-account-mgr-helpers.c:
1620 (modest_account_mgr_set_connection_specific_smtp),
1621 (modest_account_mgr_remove_connection_specific_smtp),
1622 (modest_account_mgr_get_connection_specific_smtp):
1623 * src/modest-account-mgr-helpers.h: Some functions to write the
1624 connection-specific SMTP server information. Not yet used.
1627 * src/widgets/modest-folder-view.c: (text_cell_data):
1628 Fix a warning about an uninitialized variable.
1629 (on_configuration_key_changed): Put an #ifdef around the use
1630 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1632 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1634 * src/maemo/modest-account-settings-dialog.h:
1635 * src/maemo/modest-account-settings-dialog.c:
1636 Added connect_for_modified() utility function to mark the new modified boolean.
1638 (create_page_account_details), (create_page_user_details),
1639 (create_page_incoming), (create_page_outgoing), (on_response),
1640 (modest_account_settings_dialog_init),
1641 (modest_account_settings_dialog_set_account_name):
1642 Only warn about unsaved changes when there are actually unsaved changes.
1644 * src/modest-account-mgr-helpers.c:
1645 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1646 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1647 to get the data from there in future.
1649 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1651 * src/modest-defs.h:
1653 * src/modest-account-mgr-helpers.h:
1654 * src/modest-account-mgr-helpers.c:
1655 Store the security account setting in a single conf key instead of using
1656 the options list, so that the list is left for just the to-be-removed camel hack,
1657 and because gconf_client_set_list() is failing for some reason.
1659 * src/modest-account-mgr.c:
1660 (modest_account_mgr_add_server_account):
1661 * src/maemo/modest-account-settings-dialog.c:
1662 (modest_account_settings_dialog_set_account_name),
1663 (save_configuration): Use the renamed functions.
1666 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1668 * src/widgets/Makefile.am:
1669 * src/widgets/modest-limit-retrieve-combo-box.c:
1670 * src/widgets/modest-limit-retrieve-combo-box.h:
1671 * src/widgets/modest-retrieve-combo-box.c:
1672 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1673 the account settings dialog.
1675 * src/modest-defs.h:
1676 * src/modest-account-mgr-helpers.h:
1677 * src/modest-account-mgr-helpers.c:
1678 (modest_server_account_get_option_secure_auth),
1679 (modest_server_account_set_option_secure_auth):
1680 * src/modest-account-mgr.c:
1681 (modest_account_mgr_add_server_account):
1682 Use the existing AUTH_MECH conf key for the secure-auth setting,
1683 instead of putting it in the list options, because this was actually used already.
1685 * src/maemo/modest-account-settings-dialog.c:
1686 (create_page_account_details),
1687 (modest_account_settings_dialog_set_account_name),
1688 (save_configuration):
1689 * src/maemo/modest-account-settings-dialog.h:
1690 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1691 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1693 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1695 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1696 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1697 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1699 * src/modest-defs.h:
1700 * src/maemo/modest-account-settings-dialog.c:
1701 (create_page_incoming), (on_combo_outgoing_security_changed),
1702 (on_combo_incoming_security_changed), (create_page_outgoing),
1703 (modest_account_settings_dialog_set_account_name),
1704 (save_configuration): Load/Save the port number, and change it when the
1705 security combo changes, to suitable defaults.
1707 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-account-mgr.c:
1710 (modest_account_mgr_add_server_account): Set the security and secure-auth
1711 options, and add a comment saying that the other camel-specific options should be
1714 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1716 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1718 * src/modest-tny-account-store.c: (account_list_free),
1719 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1720 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1723 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1725 * src/modest-protocol-info.c:
1726 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1727 is required by our UI spec. Maybe something in our implementation will use this eventually.
1728 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1729 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1730 instead of the previous 0 placeholder.
1732 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1733 secure-auth settings.
1734 * src/modest-account-mgr-helpers.h:
1735 * src/modest-account-mgr-helpers.c:
1736 (modest_server_account_data_get_option_secure_auth),
1737 (modest_server_account_set_option_secure_auth),
1738 (modest_server_account_data_get_option_security),
1739 (modest_server_account_set_option_security): Added this API for getting and setting the security
1740 and secure-auth settings.
1742 * src/maemo/modest-account-settings-dialog.h:
1743 * src/maemo/modest-account-settings-dialog.c:
1744 (modest_account_settings_dialog_finalize), (check_data),
1745 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1746 about changing titles.
1747 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1748 (save_configuration): Save the security and secure-auth settings.
1750 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1751 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1753 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1755 * src/modest-defs.h:
1756 * src/modest-account-mgr.c:
1757 (modest_account_mgr_add_server_account):
1758 Added and used defines for the options key and value pair strings,
1759 that are used so far, though they do not seem to correspond to anything in our
1760 UI specs or ModestProtocol enum.
1762 * src/modest-account-mgr-helpers.h:
1763 * src/modest-account-mgr-helpers.c:
1764 (compare_option_strings_for_name),
1765 (modest_server_account_data_get_option_value),
1766 (modest_server_account_data_get_option_bool),
1767 (modest_account_mgr_get_server_account_option):
1768 Added helper functions for parsing the options GSList.
1770 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1772 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1773 display name is based on the supplied account name.
1774 * src/modest-account-mgr.c:
1775 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1776 with an inefficient, but good-enough, implementation.
1778 * src/maemo/easysetup/modest-easysetup-wizard.c:
1779 (create_page_account_details), (on_before_next), (create_account):
1780 Check for existing display names rather than (non-user-visible) account names, and just
1781 create and set a unique account name at the end.
1783 * src/maemo/modest-account-settings-dialog.c:
1784 (modest_account_settings_dialog_init),
1785 (modest_account_settings_dialog_set_account_name),
1786 (create_page_incoming): Show the display name, instead of the account name.
1787 (on_response): Do some (not all) extra checks, as in the UI spec.
1788 (save_configuration): Save the display name if it was changed.
1790 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1792 * po/en_GB.po: Added needed logical ID and translation.
1793 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1794 (init_view): Made the is-default column clicking work.
1796 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1799 * src/maemo/easysetup/Makefile.am:
1800 * src/maemo/easysetup/modest-easysetup-wizard.c:
1801 (modest_easysetup_wizard_dialog_init):
1802 * src/maemo/easysetup/provider-data-test.keyfile:
1803 * src/maemo/easysetup/provider-data.keyfile:
1804 Moved the provider data file to the new modest-providers-data package and used it from there.
1806 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1808 * src/modest-local-folder-info.c:
1809 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1810 N_() was already used on the static strings, but this just marks it for translation without
1811 using the translation.
1813 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1815 * src/maemo/modest-account-settings-dialog.c:
1816 (create_page_incoming),
1817 (modest_account_settings_dialog_set_account_name):
1818 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1819 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1820 I will do this if nobody else gets there first.
1822 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1824 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1825 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1826 save the security stuff.
1828 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1830 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1831 Set the email address and user fullname, which I now see must be
1834 * src/maemo/modest-account-settings-dialog.h:
1835 * src/maemo/modest-account-settings-dialog.c:
1837 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1838 leave-on-server and authentication.
1839 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1842 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1845 * src/maemo/modest-account-settings-dialog.c:
1846 * src/maemo/modest-account-settings-dialog.h:
1847 Most (but not all) of the widgets are now present as specified by the UI spec.
1848 No changes are yet saved, and some details are not properly shown yet.
1850 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1852 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1854 * src/maemo/Makefile.am:
1855 * src/maemo/modest-account-settings-dialog.c:
1856 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1857 an existing account. Doesn't do much yet.
1859 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1860 Open the accounts settings dialog when Edit is clicked.
1862 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1864 * src/maemo/easysetup/Makefile.am:
1865 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1867 * src/maemo/easysetup/modest-easysetup-wizard.c:
1868 (modest_easysetup_wizard_dialog_init):
1869 Try to get the source directory from the build system,
1870 instead of hard-coding "./" into the source code, when opening our local
1871 copies of the configuration files.
1872 But this still fails when opening the wizard from the Accounts window,
1873 maybe because the working directory seems to change at runtime.
1874 So the wizard will fail the second time unless you copy the files into their
1875 proper locations - see the stdout warnings for the paths.
1877 (create_page_account_details),(on_before_next):
1878 Check for existing non-server accounts instead of server accounts,
1879 so the default account name is useful again, and to prevent trying to
1882 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1883 Show the wizard when New is clicked.
1885 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1886 (init_view): Show the column headers, and show the columns that are
1887 specified in the UI specs. However, something in Maemo's GTK+ prevents
1888 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1889 change the default account. This is despite unsetting the special properties.
1891 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1893 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1894 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1895 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1896 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1897 to make that clearer.
1898 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1900 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1902 * src/maemo/modest-account-view-window.c:
1903 (modest_account_view_window_init),
1904 (modest_account_view_window_new):
1905 Use the same buttons as specified in the
1906 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1907 the existing widgets, which never had a chance of working.
1908 Put the ModestAccountView treeview in a scrolled window.
1909 Do not repeat the initialization in both _init() and _new().
1911 * src/widgets/modest-account-view.c: (update_account_view):
1912 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1913 this widget and window shows no accounts.
1915 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1917 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1919 * src/maemo/easysetup/modest-easysetup-wizard.c:
1920 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1921 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1922 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1925 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1926 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1927 accounts exist yet, as in the UI spec.
1929 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1931 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1933 * src/maemo/Makefile.am:
1934 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1935 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1936 New window for editing connection-specific smtp details.
1937 Not fully implemented.
1939 * src/maemo/modest-connection-specific-smtp-window.c:
1940 (modest_connection_specific_smtp_window_finalize) :
1941 unref the tree model.
1942 (on_button_edit): Show the edit window.
1944 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1946 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1949 * src/maemo/Makefile.am:
1950 * src/maemo/modest-connection-specific-smtp-window.c:
1951 * src/maemo/modest-connection-specific-smtp-window.h:
1952 New window for showing the list of connections, for connection-specific
1953 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1954 * src/maemo/easysetup/modest-easysetup-wizard.c:
1955 (create_page_custom_outgoing): Show the new window when the button is clicked.
1957 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1959 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1960 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1961 * src/maemo/modest-msg-edit-window.c:
1962 (modest_msg_edit_window_insert_image):
1963 * src/modest-conf.c: (modest_conf_key_escape):
1964 * src/modest-mail-operation.c:
1965 (modest_mail_operation_send_new_mail):
1966 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1967 (modest_ui_actions_on_new_account):
1968 * src/widgets/modest-attachment-view.c: (update_filename_request):
1969 * src/widgets/modest-mail-header-view.c:
1970 Corrected warnings that were breaking the build, by commenting out unused variables,
1971 and a function, and by including a header.
1973 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1975 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1976 so we can #ifdef around platform-specific code when necessary.
1977 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1978 to allow this to build for the GNOME platform too.
1980 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1982 * src/maemo/easysetup/modest-easysetup-wizard.c:
1983 Added util_increment_name() and used it in create_page_account_details()
1984 to make sure that the default account name is always a new name.
1986 (modest_easysetup_wizard_dialog_init),
1987 (set_default_custom_servernames): Some minor memory management fixes.
1989 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1993 * src/modest-runtime.c: (init_i18n): Restored the translation
1994 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1995 are defined in config.h, and the translations are installed.
1997 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1998 is defined for translation.
2000 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2002 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2004 * src/maemo/easysetup/modest-easysetup-wizard.c:
2005 (modest_easysetup_wizard_dialog_init):
2006 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2007 Use realistic paths (though they should use $prefix generically) to the
2008 mcc_mapping and provider-data.keyfile files which might work when they
2009 are installed by the future version of the operator-wizard package,
2010 and then fallback to paths in our source code, with an explanatory
2013 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2017 * src/maemo/Makefile.am:
2018 * src/maemo/easysetup/: Added files from the previously-exernal
2019 osso-modest-easysetup.
2020 * src/maemo/modest-main-window-ui.h:
2021 * src/modest-ui-actions.c:
2022 * src/modest-ui-actions.h:
2023 Added modest_ui_actions_on_new_account() as a signal handler for the
2024 New Account menu item. It shows the easysetup wizard.
2025 * po/en_GB.po: Added additional needed logical IDs and translations.
2027 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2028 Apparently ChangeLog is not used for some vague Nokia legal reasons.