1 2007-06-01 Murray Cumming <murrayc@murrayc.com>
4 * src/maemo/easysetup/modest-easysetup-wizard.c:
5 (create_page_complete_easysetup):
6 (create_page_complete_custom): Correct the last commit,
7 putting the correct sentences in the correct pages.
9 2007-06-01 Murray Cumming <murrayc@murrayc.com>
11 * src/maemo/easysetup/modest-easysetup-wizard.c:
12 (create_page_complete_custom): Show the second sentence of text
13 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
16 2007-06-01 Murray Cumming <murrayc@murrayc.com>
18 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
19 Set the leave-on-server conf key by default. This fixes
20 projects.maemo.org bug NB#59258 .
22 2007-06-01 Murray Cumming <murrayc@murrayc.com>
24 * src/maemo/modest-account-view-window.c:
25 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
26 logical ID for the confirmation messages. Fixed projects.maemo.org bug
29 2007-06-01 Murray Cumming <murrayc@murrayc.com>
31 * src/maemo/easysetup/modest-easysetup-wizard.c:
32 (create_caption_new_with_asterisk):
33 * src/maemo/modest-account-settings-dialog.c:
34 (create_caption_new_with_asterisk):
35 Uncomment the code to add the asterisk, because they are no longer in the
36 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
37 (update_incoming_server_title): Add an asterisk here too.
39 2007-06-01 Murray Cumming <murrayc@murrayc.com>
41 * src/maemo/modest-maemo-global-settings-dialog.c:
42 (current_connection): Check that we are even connected before trying to
43 get the current connection name, to prevent a warning.
45 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
46 Change the comments because tny_maemo_conic_device_connect() is now meant to
48 * src/modest-mail-operation.c:
49 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
50 make sure we have a connection and fail if we can't connect.
52 2007-05-31 Murray Cumming <murrayc@murrayc.com>
54 * src/maemo/modest-main-window.c:
55 (on_account_store_connecting_finished): Do not try to get the
56 connection ID if we are not really connected. I am surprised that
57 this signal handler is called when we are not connected.
59 2007-05-31 Murray Cumming <murrayc@murrayc.com>
62 * src/modest-ui-actions.c:
63 (modest_ui_actions_get_msgs_full_error_handler):
64 Renamed an enum, added comments, added an enum
65 for retrieve-limit errors.
67 * src/modest-mail-operation.c: (foreach_add_item),
68 (internal_folder_observer_update), (update_account_thread),
69 (modest_mail_operation_get_msgs_full):
70 (modest_mail_operation_update_account),
71 Added comments about how this works, and some code that should
72 (but does not) check the retrieve-limit. See the TODO comment.
74 2007-05-31 Murray Cumming <murrayc@murrayc.com>
76 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
77 Initialize help_id to fix the build. Warnings are good.
79 2007-05-31 Murray Cumming <murrayc@murrayc.com>
81 * src/widgets/modest-hbox-cell-renderer.c:
82 (modest_hbox_cell_renderer_append):
83 * src/widgets/modest-vbox-cell-renderer.c:
84 (modest_vbox_cell_renderer_append):
85 Fix the last commit by doing an extra ref.
87 2007-05-31 Murray Cumming <murrayc@murrayc.com>
89 * src/widgets/modest-hbox-cell-renderer.c:
90 (modest_hbox_cell_renderer_append):
91 * src/widgets/modest-vbox-cell-renderer.c:
92 (modest_vbox_cell_renderer_append):
93 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
94 to fix the build with Maemo Bora.
95 However, there seems to be a remaining crash, probably due to reference
98 2007-05-30 Murray Cumming <murrayc@murrayc.com>
100 * src/modest-tny-account.c:
101 (modest_tny_account_new_for_local_folders):
102 Use hildon_file_system_info_async_new() to get a better name for
103 the memory card account, setting it as the account name.
104 The timing seems to work, but this is probably
105 not the best place to do this. See the TODO comment.
106 * src/maemo/modest-main-window.c: (create_details_widget):
107 * src/widgets/modest-folder-view.c: (text_cell_data):
108 Use the tny account name instead of hardcoding a name.
110 2007-05-30 Christian Kellner <ckellner@openismus.com>
112 * src/modest-search.c: (modest_search):
113 Correctly set part_search_func even if we have already parsed
114 the query and thus a valid OgsTextSearcher object.
116 2007-05-30 Christian Kellner <ckellner@openismus.com>
119 Search and check for libogs.
122 Incooparte the ogs build env.
124 * src/modest-mime-part-search-stream.c:
125 * src/modest-mime-part-search-stream.h:
126 Removed since we do the real searching now in modest-search.c.
128 * src/modest-search.c:
129 * src/modest-search.h:
130 Implement support for ogs. We use that if available and requested
131 and fall back to modest_text_utils_utf8_strcmp (). The search logic
132 should now handle the corner case when the search term is spread
133 across multiple reads.
134 Also the logic in modest_search () was corrected to search all
135 requested fields until one is found.
137 2007-05-30 Murray Cumming <murrayc@murrayc.com>
139 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
142 * src/modest-init.c: Made modest_init_local_folders() take a
143 path and be public so we can iniitialize maildir folders on
146 * src/modest-local-folder-info.h:
147 * src/modest-local-folder-info.c:
148 (modest_local_folder_info_get_maildir_path): Add a path parameter.
150 * src/modest-tny-account.c:
151 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
152 still means the standard local-folders path on the local volume.
154 * src/modest-tny-account-store.c:
155 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
156 signal so we can detect mount/unmount of the MMC1 card, and do an update of
157 all accounts when that happens.
158 (get_server_accounts): If the MMC1 card is mounted, create a store account for
159 this too, so it shows up in the treeview.
161 2007-05-28 Murray Cumming <murrayc@murrayc.com>
163 * src/maemo/modest-maemo-global-settings-dialog.c:
164 (current_connection):
165 * src/widgets/modest-global-settings-dialog.c:
166 (current_connection_default):
167 Use the enum values instead of 0, 1 and -1,
168 to make the code clearer.
170 * src/modest-account-mgr-helpers.c:
171 (modest_account_mgr_get_connection_specific_smtp): Make this code
174 * src/modest-runtime.h:
175 * src/modest-runtime.c:
176 Added modest_runtime_remove_all_send_queues().
177 * src/maemo/modest-main-window.c:
178 (on_account_store_connecting_finished): Recreate the send queues,
179 using the appropriate transport accounts for this new connection.
180 Some futher adapting might be needed if the old send queues are not
181 automatically stopped at this point.
183 * src/modest-tny-account-store.c: (get_server_accounts):
184 Create the connection-specific transport accounts, so that they can
185 be found later by their ID.
187 * src/modest-tny-account.h:
188 * src/modest-tny-account.c:
189 Added modest_tny_account_new_from_server_account_name().
190 modest_tny_account_new_from_server_account(): Do not create the
191 send queues here, because they will be
192 recreated anyway when the connection changes for the first time.
194 2007-05-28 Murray Cumming <murrayc@murrayc.com>
196 * src/modest-local-folder-info.h:
197 * src/modest-local-folder-info.c:
198 (modest_per_account_local_outbox_folder_info_get_maildir_path),
199 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
200 tbox_folder): Take a modest account name instead of a server TnyAccount,
201 so we can have per-modest-account rather than per-transport-account
203 We must make sure that we change or recreate the exisitng send queues
204 when the connection changes for connection-specific transport accounts.
206 * src/modest-tny-account-store.c:
207 (create_per_account_local_outbox_folders): Create outboxed per modest
208 account, not per transport account.
210 * src/modest-tny-account.h:
211 * src/modest-tny-account.c:
212 (modest_tny_account_get_special_folder): For outboxes, get the
213 parent modest account name. The account is ignored for other folders.
214 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
215 modest account name rather than a server TnyAccount.
217 2007-05-25 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-tny-account.c:
220 (modest_tny_account_new_from_server_account):
221 Call modest_runtime_get_send_queue() immediately after creating transport
222 accounts, so that they start trying to send email from the outbox as soon
223 as possible at startup. This is probably what we want.
225 * src/modest-mail-operation.c: (update_account_thread):
226 * src/modest-runtime.c: (modest_runtime_get_send_queue):
227 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
228 * src/modest-tny-send-queue.h:
229 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
230 (modest_ui_actions_on_send):
231 Added comments about how sending works, though it needs some more work.
233 2007-05-25 Murray Cumming <murrayc@murrayc.com>
235 * src/modest-tny-account.c:
236 (modest_tny_account_get_special_folder): Add TODO because this fails when
238 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
239 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
240 Do not try to show this window when there is no active account. The UI
241 specs does not tell us what to do in this case.
243 2007-05-24 Murray Cumming <murrayc@murrayc.com>
247 * src/maemo/Makefile.am:
248 * src/widgets/Makefile.am: Some dist fixes.
250 2007-05-24 Murray Cumming <murrayc@murrayc.com>
252 * src/maemo/modest-connection-specific-smtp-window.c:
253 (on_button_edit): Make the code clearer, to prevent a double free.
255 2007-05-24 Murray Cumming <murrayc@murrayc.com>
257 * src/maemo/modest-account-settings-dialog.c:
258 (modest_account_settings_dialog_set_account_name),
259 Check the connection-specific smtp servers checkbox if there are any.
261 * src/maemo/modest-connection-specific-smtp-edit-window.c:
262 (modest_connection_specific_smtp_edit_window_init):
263 Start with a suitable port number.
265 * src/modest-account-mgr-helpers.h:
266 * src/modest-account-mgr-helpers.c: Added
267 modest_account_mgr_get_has_connection_specific_smtp().
269 (modest_account_mgr_set_connection_specific_smtp),
270 (modest_account_mgr_remove_connection_specific_smtp),
271 (modest_account_mgr_get_has_connection_specific_smtp),
272 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
273 connection-specific smtp server accounts in the account, rather than
274 the server account conf dir.
276 This fixes bug projects.maemo.org bug NB#58263 .
278 * src/modest-tny-account-store.c:
279 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
280 if there are no server accounts yet, to prevent an infinite loop when there
281 are no accounts. Document that one must be called before the other.
283 2007-05-24 Murray Cumming <murrayc@murrayc.com>
285 * src/modest-account-mgr-helpers.c:
286 (modest_account_mgr_get_default_account): Make sure that at least
287 one account is always the default, if there are any enabled accounts.
288 This is just a sanity check that shouldn't be necessary.
290 * src/modest-account-mgr-priv.c:
291 (_modest_account_mgr_account_from_key): Unescape the conf key to
292 get the real account name. For instance, this is an issue if a space
293 was in the account name, which can happen because the account name
294 is generated from the display name.
295 (_modest_account_mgr_get_account_keyname): Always escape the
297 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
298 Unescape the conf keys to get the real account names.
300 For instance, previously the is-default radio button in the accounts
301 list was not checked for any accounts at first. This fixes that,
302 and might fix several similar bugs.
304 2007-05-23 Murray Cumming <murrayc@murrayc.com>
306 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
307 Removed some debug printfs.
309 2007-05-23 Murray Cumming <murrayc@murrayc.com>
311 Modest on-disk outbox directories are now here, for instance:
312 $HOME/.modest/outboxes/<account-id-1>/outbox
313 $HOME/.modest/outboxes/<account-id-2>/outbox
315 $HOME/.modest/local-folders/outbox
316 so we can have a separate outbox for each account.
317 But they are shown as one outbox in the GtkTreeView, by using a
318 TnyMergeFolder in a ModestTnySimpleFolderStore.
321 * src/modest-tny-simple-folder-store.c:
322 * src/modest-tny-simple-folder-store.h:
323 Added ModestTnySimpleFolderStore, used to contain folders from
324 other folder stores, such as other accounts.
326 * src/modest-tny-outbox-account.h:
327 * src/modest-tny-outbox-account.c:
328 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
329 used for the per-account local outbox folders.
331 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
332 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
333 only use this (internally) now for the non-outbox local folders.
336 * src/modest-init.c: Added modest_init_one_local_folder(), for
337 setting up the directory structure for each local folder.
339 * src/modest-local-folder-info.c:
340 (modest_per_account_local_outbox_folder_info_get_maildir_path),
341 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
343 * src/modest-local-folder-info.h:
344 * src/modest-tny-account-store.c: (on_account_removed),
345 (on_account_changed), (create_per_account_local_outbox_folders),
346 (get_server_accounts), (modest_tny_account_store_get_accounts),
347 (modest_tny_account_store_get_tny_account_by_account),
348 (modest_tny_folder_store_is_virtual_local_folders):
350 * src/modest-tny-account.h:
351 * src/modest-tny-account.c:
352 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
353 to create an on-disk per-account local outbox folder for each
355 (create_per_account_local_outbox_folders): Create a local outbox folder
356 for each transport account.
357 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
358 for all local folders.
360 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
361 instead of using g_object_get/set() directly. It is clearer.
363 (modest_tny_folder_store_get_message_count),
364 (modest_tny_folder_store_get_local_size
365 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
366 because we now use these with non-acount folder stores.
368 (modest_tny_account_get_special_folder),
369 (modest_tny_account_new_from_server_account),
370 (modest_tny_account_new_from_account):
371 (recurse_folders): Adjust to the new outbox system.
373 * src/modest-tny-folder.h:
374 * src/modest-tny-folder.c:
375 (modest_tny_folder_is_local_folder),
376 (modest_tny_folder_get_local_folder_type),
377 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
379 * src/widgets/modest-main-window.h:
380 * src/maemo/modest-main-window.c: (create_details_widget),
381 (modest_main_window_set_contents_style): Show details for any folder store,
384 (modest_tny_folder_get_rules):
385 Remove the const. C does not support constness enough for this.
387 * src/modest-ui-actions.c:
388 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
389 make all outboxes appear as one, in the usual local-folders tree node.
391 (set_active_account_from_tny_account),
392 (modest_ui_actions_on_folder_selection_changed):
393 * src/widgets/modest-folder-view.c: (text_cell_data),
394 (icon_cell_data), (filter_row),
395 (add_account_folders_to_merged_folder),
396 (add_account_folders_to_simple_folder_store), (),
397 (get_cmp_rows_type_pos), (cmp_rows),
398 (modest_folder_view_set_account_id_of_visible_server_account):
399 Adjust to the new outbox system, using generic folder stores and folders
402 2007-05-23 Christian Kellner <ckellner@openismus.com>
404 * src/modest-mail-operation.c:
405 (modest_mail_operation_update_account):
406 Use info->max_size instead of unintialized local var [small
407 build fix]. (Added TODO to review that change since I don't
410 2007-05-23 Marcus Bauer <marcusb@openismus.com>
412 * libmodest-dbus-client/libmodest-dbus-client.c:
413 (libmodest_dbus_client_compose_mail): function added
414 * src/dbus_api/modest-dbus-api.h:
415 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
416 (on_compose_mail): Implementation of the SendAsMail functionality
418 2007-05-22 Murray Cumming <murrayc@murrayc.com>
420 * src/modest-account-mgr.c:
421 (modest_account_mgr_add_server_account): Set the secure-connection
422 conf key for transport accounts as well as store accounts. I don't know
423 why the if was there. For instance, this makes sure that we use SSL
424 for the gmail preset from the easysetup wizard.
426 2007-05-22 Murray Cumming <murrayc@murrayc.com>
428 * src/gnome/modest-main-window.c:
429 (on_account_store_connecting_finished), (connect_signals):
430 * src/maemo/modest-main-window.c:
431 (on_account_store_connecting_finished), (connect_signals),
432 (modest_main_window_new):
433 Handle TnyAccountStore::connecting-finished instead of
434 TnyDevice::connection-changed, because we cannot actually perform
435 operations on accounts until TnyAccountStore has itself responded to
436 the TnyDevice::connection-changed signal. This prevents a GError from
438 Do not try to update at startup, because we (at least on scratchbox)
439 already do an update at startup when the device goes online.
440 This prevents a GError from tinymail.
441 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
442 Added TODO about stopping simultaneous operations.
444 2007-05-21 Murray Cumming <murrayc@murrayc.com>
446 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
447 * src/modest-mail-operation-queue.c:
448 (modest_mail_operation_queue_remove):
449 * src/modest-tny-account-store.c: When GErrors happen, give more clues
450 about where they happened.
452 2007-05-21 Murray Cumming <murrayc@murrayc.com>
454 * src/modest-ui-actions.c:
455 (modest_ui_actions_on_password_requested): Make sure that the remember
456 output parameter is always TRUE.
458 2007-05-21 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
461 Show a OK/Cancel dialog if the error is a question, though we still do not
462 know anything more about what we are asking the user.
463 * src/widgets/modest-folder-view.c: (on_drag_data_received):
464 Fix an uninitialized variable (helper). This is a logic error, however.
466 2007-05-21 Christian Kellner <ckellner@openismus.com>
468 * src/modest-search.h:
469 Correct bit shifting in the ModestSearchFlags enum.
471 2007-05-21 Murray Cumming <murrayc@murrayc.com>
473 * src/modest-tny-account.c:
474 (modest_tny_account_new_from_server_account): Do not use the lsub and
475 check-all hard-coded IMAP options when using POP.
477 2007-05-21 Murray Cumming <murrayc@murrayc.com>
479 * src/modest-tny-account.c:
480 (modest_tny_account_new_from_server_account):
481 Use NULL for the secure-auth method for POP when Password auth has been
482 specified by the user, as we already do for IMAP. "auth=Login" causes
483 an error from camel or the server.
485 2007-05-17 Murray Cumming <murrayc@murrayc.com>
487 * src/maemo/modest-account-settings-dialog.c:
488 (create_page_account_details),
489 (modest_account_settings_dialog_set_account_name):
490 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
491 for the leave-on-server checkbox, rathr than just the checkbox, when
492 the protocol is not POP.
494 2007-05-17 Murray Cumming <murrayc@murrayc.com>
496 * src/widgets/modest-account-view.c:
497 * src/widgets/modest-account-view.h:
498 Added modest_account_view_select_account() which will be useful later
499 to asynchronously re-select the edited account.
501 2007-05-17 Murray Cumming <murrayc@murrayc.com>
503 * src/maemo/modest-account-settings-dialog.c:
504 (modest_account_settings_dialog_set_account_name):
505 Automatically choose the port numbers based on the secure authentication
506 methods, if they have not been chosen before.
507 This fixes projects.maemo.org bug NB#56273 .
509 2007-05-17 Murray Cumming <murrayc@murrayc.com>
511 * src/maemo/modest-main-window-ui.h:
512 * src/modest-ui-actions.c:
513 * src/modest-ui-actions.h:
514 Connect the Tools/SMTP Servers menu item to
515 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
516 SMTP servers dialog, as in the UI specification and saves changes when it
517 is closed. This fixed projects.maemo.org bug NB#56305 .
519 2007-05-17 Murray Cumming <murrayc@murrayc.com>
521 * src/maemo/modest-connection-specific-smtp-window.c:
522 (modest_connection_specific_smtp_window_init):
523 Use gtk_window_set_default_size() to make this window big enough, so
524 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
526 2007-05-17 Murray Cumming <murrayc@murrayc.com>
528 * src/maemo/modest-connection-specific-smtp-edit-window.h:
529 * src/maemo/modest-connection-specific-smtp-edit-window.c:
530 (modest_connection_specific_smtp_edit_window_init),
531 Do not try to connect to a combobox signal before the combobox exists.
532 This fixes the cras in projects.maemo.org bug NB#56288 .
533 (modest_connection_specific_smtp_edit_window_get_settings):
534 Remove the server_account_name parameter which was being checked for NULL
535 though it was not used.
537 * src/maemo/modest-connection-specific-smtp-window.c:
538 (modest_connection_specific_smtp_window_fill_with_connections),
539 (on_button_edit), (modest_connection_specific_smtp_window_init):
540 Correct the number of treemodel columns to prevent a warning.
541 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
542 libconic does not work.
544 2007-05-16 Murray Cumming <murrayc@murrayc.com>
546 * src/modest-tny-account.c:
547 (modest_tny_account_new_from_server_account):
548 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
549 SMTP when "None" was chosen by the user. However, with my SMTP server that
550 does not support ANONYMOUS, the emails do not leave the Outbox and I see
553 2007-05-16 Murray Cumming <murrayc@murrayc.com>
555 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
556 to explain the memory management issue with the ID in the ModestPair.
558 * src/gnome/modest-account-assistant.c: (add_receiving_page),
559 (add_sending_page), (modest_account_assistant_finalize):
560 * src/gnome/modest-gnome-global-settings-dialog.c:
561 (create_updating_page), (create_composing_page):
562 * src/gnome/modest-msg-edit-window.c: (get_transports),
563 (init_window), (modest_msg_edit_window_finalize),
564 (modest_msg_edit_window_get_msg_data):
565 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
566 * src/gnome/modest-transport-widget.c:
567 (modest_transport_widget_finalize), (smtp_configuration):
568 * src/maemo/modest-maemo-global-settings-dialog.c:
569 (create_updating_page), (create_composing_page):
570 * src/maemo/modest-msg-edit-window.c: (get_transports),
571 (init_window), (modest_msg_edit_window_finalize),
572 (modest_msg_edit_window_get_msg_data),
573 (modest_msg_edit_window_free_msg_data):
574 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
575 (modest_store_widget_finalize):
576 * src/maemo/modest-transport-widget.c:
577 (modest_transport_widget_finalize), (smtp_configuration):
578 * src/modest-main.c: (send_mail):
579 * src/widgets/modest-combo-box.h:
580 * src/widgets/modest-global-settings-dialog-priv.h:
581 * src/widgets/modest-global-settings-dialog.c:
582 (modest_global_settings_dialog_finalize):
583 * src/widgets/modest-msg-edit-window.h:
584 Whenever using modest_combo_box_new(), keep the ModestPairList alive
585 as long as the combo box, to prevent use of freed memory for the ID.
587 2007-05-15 Murray Cumming <murrayc@murrayc.com>
589 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
590 get_accounts(), to make this clearer. Do not check for the enabled gconf
591 key, because we do not use this for server accounts (at least, not yet).
592 This allows us to send email again.
594 2007-05-15 Murray Cumming <murrayc@murrayc.com>
596 * src/maemo/modest-platform.c:
597 (on_modest_conf_update_interval_changed), (modest_platform_init):
598 Only respond to this particular key change. All these strcmp()s cannot be
601 2007-05-15 Murray Cumming <murrayc@murrayc.com>
603 * src/maemo/modest-maemo-global-settings-dialog.c:
604 (current_connection): Prevent a crash in scratchbox when
605 ny_maemo_conic_device_get_current_iap_id() returns NULL.
606 * src/maemo/modest-platform.c:
607 (on_modest_conf_update_interval_changed), (modest_platform_init):
608 Get the update interval from gconf and reset it when the gconf key changes.
610 2007-05-15 Murray Cumming <murrayc@murrayc.com>
612 * src/modest-protocol-info.c:
613 * src/modest-protocol-info.h: Adde enum-specific get functions,
614 instead of using a ModestProtocolType enum parameter.
616 * src/gnome/modest-account-assistant.c:
617 * src/gnome/modest-store-widget.c:
618 * src/gnome/modest-store-widget.h:
619 * src/gnome/modest-transport-widget.c:
620 * src/gnome/modest-transport-widget.h:
621 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
622 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
623 * src/maemo/easysetup/modest-easysetup-wizard.c:
624 * src/maemo/modest-account-settings-dialog.c:
625 * src/maemo/modest-account-settings-dialog.h:
626 * src/maemo/modest-store-widget.c:
627 * src/maemo/modest-store-widget.h:
628 * src/maemo/modest-transport-widget.c:
629 * src/maemo/modest-transport-widget.h:
630 * src/modest-account-mgr-helpers.c:
631 * src/modest-account-mgr-helpers.h:
632 * src/modest-account-mgr.c:
633 * src/modest-account-mgr.h:
634 * src/modest-tny-account.c:
635 * src/modest-tny-folder.c:
636 * src/widgets/modest-account-view.c:
637 * src/widgets/modest-retrieve-combo-box.c:
638 * src/widgets/modest-retrieve-combo-box.h:
639 * src/widgets/modest-secureauth-combo-box.c:
640 * src/widgets/modest-serversecurity-combo-box.c:
641 * src/widgets/modest-serversecurity-combo-box.h:
642 * tests/check_account-mgr.c:
643 Use the specific functions, and use the re-renamed enum values for GNOME too.
645 2007-05-15 Murray Cumming <murrayc@murrayc.com>
648 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
649 so we can get the second based on the first.
651 * src/maemo/modest-account-settings-dialog.h:
652 * src/maemo/modest-account-settings-dialog.c:
653 Added get_supported_secure_authentication_methods(), though it is mostly
654 commented-out for now until the necessary API is committed to tinymail.
655 (modest_account_settings_dialog_set_account_name),
656 (save_configuration): Request the supported authentication methods from the
657 server, so we can choose a working method.
659 * src/modest-tny-account-store.h:
660 * src/modest-tny-account-store.c:
661 (modest_tny_account_store_get_session): Rename from
662 tny_account_store_get_session().
664 2007-05-14 Murray Cumming <murrayc@murrayc.com>
666 * src/modest-protocol-info.h: Split the ModestProtocol enum
667 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
668 There was no need to have these unrelated values in one enum.
670 * src/: many files: Adapted to changed enum. This makes the code a bit
671 clearer, and the compiler could catch some errors.
673 2007-05-14 Murray Cumming <murrayc@murrayc.com>
675 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
676 Show the detailed internal camel error message when an error happens
677 during the configuration, so that our testers can give us more clues.
678 For instance, in projects.maemo.org bug NB#56910 .
680 2007-05-14 Murray Cumming <murrayc@murrayc.com>
682 * src/modest-tny-account.c:
683 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
684 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
686 2007-05-14 Murray Cumming <murrayc@murrayc.com>
688 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
689 * src/maemo/modest-account-settings-dialog.c:
690 (modest_account_settings_dialog_set_account_name),
691 (save_configuration): For the incoming secure authentication checkbox,
692 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
693 the UI specification. PLAIN does not seem to be supported for most IMAP
694 servers anyway, and I am not sure what it would mean.
695 However, we probably need to discover which of the secure-authentication
696 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
697 * src/modest-account-mgr-helpers.c:
698 (modest_account_mgr_get_server_account_data):
700 * src/modest-tny-account.c:
701 (modest_tny_account_new_from_server_account):
702 Use tny_account_set_mech() to set secure-authentication methods,
703 with some special-casing for IMAP, based on my observations of how
706 * src/modest-account-mgr-helpers.h:
707 * src/modest-account-mgr.c:
708 * src/modest-defs.h: Comment that the URI is only used for local folders.
710 2007-05-11 Murray Cumming <murrayc@murrayc.com>
712 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
713 parameter const, just to be neat.
714 * src/modest-text-utils.c: (modest_text_utils_inline):
715 End g_strconcat() with NULL, as its documentation says. This is almost
716 certainly the cause of my crash at startup on the device. Interestingly,
717 valgrind doesn't tell us about these errors.
719 2007-05-11 Murray Cumming <murrayc@murrayc.com>
721 * scripts/build-packages: Added more precise comments about how to use
722 this script, though I still get this error:
723 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
724 error building tinymail
726 2007-05-11 Murray Cumming <murrayc@murrayc.com>
728 * src/maemo/modest-main-window.c: (on_account_update):
729 Very slight cleanup, hoping to make it simpler to discover what causes
730 a crash here sometimes.
732 * src/modest-tny-account.c:
733 (modest_tny_account_new_from_server_account): Set the port. Added
734 comments about the options and a TODO comment because I need to find out
735 how to specify the secure authentication method.
737 2007-05-11 Marcus Bauer <marcusb@openismus.com>
739 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
740 changed CFlags paths form modest to libmodest
742 2007-05-10 Murray Cumming <murrayc@murrayc.com>
744 * src/modest-account-mgr-helpers.c:
745 (modest_account_mgr_get_server_account_data),
746 (modest_account_mgr_free_server_account_data):
747 * src/modest-account-mgr-helpers.h:
748 * src/modest-account-mgr.c:
749 (modest_account_mgr_add_server_account):
751 * src/modest-tny-account.c:
752 (modest_tny_account_new_from_server_account):
753 Determine the options for tny_camel_account_add_option() here,
754 based on the settings, rather than storing them directly in gconf.
756 2007-05-10 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
759 Show a more friendly error dialog now that we expect (from the tinymail
760 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
762 2007-05-10 Murray Cumming <murrayc@murrayc.com>
764 * src/maemo/modest-main-window.c: (on_account_update): Check that
765 account_name is not NULL, to prevent a crash at startup that I am
766 seeing on the N800. I do wonder why it is NULL.
768 * src/maemo/easysetup/modest-easysetup-wizard.c:
769 (create_page_user_details):
770 * src/maemo/modest-account-settings-dialog.c:
771 (create_page_user_details), (create_page_outgoing):
772 * src/maemo/modest-connection-specific-smtp-edit-window.c:
773 (modest_connection_specific_smtp_edit_window_init):
774 * src/modest-ui-actions.c:
775 (modest_ui_actions_on_password_requested):
776 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
777 might do something useful with the on-screen keyboard.
779 2007-05-10 Murray Cumming <murrayc@murrayc.com>
781 * src/maemo/modest-main-window.c: (on_account_update):
782 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
783 NULL, to avoid lots of warnings. However, it probably should not be NULL.
785 2007-05-09 Murray Cumming <murrayc@murrayc.com>
787 * src/modest-tny-account-store.c: (on_account_changed):
788 Correct the signature of this signal handler.
790 2007-05-09 Murray Cumming <murrayc@murrayc.com>
792 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
793 Show a HildonNote instead of a GtkDialog for Maemo.
795 2007-05-09 Murray Cumming <murrayc@murrayc.com>
797 * src/widgets/modest-account-view.h:
798 * src/widgets/modest-account-view.c: (on_account_changed),
799 (on_account_removed). Added a boolean flag, set/unset by
800 modest_account_view_block_conf_updates(),
801 modest_account_view_unblock_conf_updates() to prevent unnecessary
802 updates, but this is not very useful because the gconf notifications are
803 so delays (maybe only on Maemo Bora).
804 So auto-updating is turned off, and these functions do an explicit
805 update when necessary.
806 However, something else is still doing too much work when adding/removing
807 accounts, probably in another part of the application.
809 * src/maemo/modest-account-view-window.c:
810 (on_delete_button_clicked), (on_edit_button_clicked),
811 (on_new_button_clicked): Use the new functions.
813 2007-05-09 Murray Cumming <murrayc@murrayc.com>
815 * src/modest-account-mgr-helpers.c:
816 (modest_account_mgr_set_first_account_as_default):
817 Sort the list of names alphabetically-by-title, so we choose the first one
819 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
820 alphabetically by the title.
822 This fixes projects.maemo.org bug NB#56418 .
824 * src/modest-account-mgr-priv.c:
825 (_modest_account_mgr_account_from_key):
826 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
827 avoid a valgrind error, and possible random behaviour.
829 2007-05-09 Murray Cumming <murrayc@murrayc.com>
831 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
832 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
833 tinymail documentation to say that this can be expected.
834 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
835 pretty, and should not happen, but I would prefer to know when it does.
837 2007-05-09 Murray Cumming <murrayc@murrayc.com>
839 * configure.ac: When using the older hildon version, probably on Bora,
840 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
842 * src/widgets/modest-attachment-view.c:
843 (modest_attachment_view_set_part_default): Initialize variables, to fix the
846 2007-05-09 Marcus Bauer <marcusb@openismus.com>
848 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
849 Implemented the prototype. Can be tested with
850 tests/dbus_api/test_open_message:
852 2007-05-08 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-tny-account-store.c:
855 (modest_tny_account_store_instance_init), (get_password):
856 * src/modest-ui-actions.c:
857 (modest_ui_actions_on_password_requested):
858 Do not store the password in gconf, because this function is called
859 for non-remembered passwords. Actually use the cached (in the hash map)
860 password instead of releasing it.
861 The password will now not be remembered if it is asked via the protected
862 password dialog, as per the UI spec.
864 2007-05-08 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-account-mgr-helpers.h:
868 * src/modest-account-mgr-helpers.c:
869 Added modest_server_account_get_username_has_succeeded(),
870 modest_server_account_set_username_has_succeeded().
871 (modest_server_account_set_username),
872 Reset the has-succeeded flag if the username changes.
874 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
875 * src/maemo/modest-connection-specific-smtp-window.c:
876 (modest_connection_specific_smtp_window_save_server_accounts):
877 Use modest_server_account_set_username() instead of using
878 modest_conf_set_string() directly, so that the has-succeeded flag is always
881 * src/modest-ui-actions.c:
882 (modest_ui_actions_on_password_requested): Dim the username entry if
883 the username has ever worked, as per the UI spec.
885 2007-05-08 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-tny-account-store.c: (get_password):
888 * src/modest-ui-actions.c:
889 (modest_ui_actions_on_password_requested):
890 Allow the username to be changed too, though there is more work to
891 be done on exactly how this behaves.
893 2007-05-08 Murray Cumming <murrayc@murrayc.com>
895 * src/modest-account-mgr-helpers.h:
896 * src/modest-account-mgr-helpers.c:
897 Added modest_account_mgr_get_display_name(),
898 modest_server_account_get_username(),
899 modest_server_account_set_username(),
900 modest_server_account_set_password(),
901 modest_server_account_get_hostname() functions so we do not need to
902 use the conf API directly.
904 * src/maemo/modest-main-window.c: (connect_signals):
905 Actually connect ot the ModestAccountStore::request-password signal,
906 so that we show the dialog when the password is requested by Tinymail,
907 for isntance if it is empty.
909 * src/modest-marshal.list:
910 * src/modest-tny-account-store.c:
911 (modest_tny_account_store_class_init), (get_password),
912 (modest_tny_account_store_alert):
913 * src/modest-tny-account-store.h:
914 * src/modest-ui-actions.h:
915 * src/modest-ui-actions.c:
916 (modest_ui_actions_on_password_requested):
917 Change the signal parameters, so it is obvious that we are providing
918 the non human-readable server name, and receiving both the username
919 and password, though changing of the username is not yet implemented.
920 Change the dialog UI to match the Maemo UI specifications, with #idfefing
921 for the GNOME version.
923 This should fix the projects.maemo.org bug NB#56209, though it does not
924 work on Bora, because the gconf_client_get() for the password fails
925 immediately after we save it with gconf_client_set().
927 2007-05-08 Murray Cumming <murrayc@murrayc.com>
930 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
931 caused an undefined symbol error:
932 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
934 2007-05-08 Murray Cumming <murrayc@murrayc.com>
936 * src/modest-tny-account-store.c:
937 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
938 using a GError instead of a string message, so we can translate it in
941 2007-05-08 Murray Cumming <murrayc@murrayc.com>
943 * src/maemo/modest-address-book.c:
944 (modest_address_book_check_names):
945 * src/maemo/modest-msg-view-window.c:
946 (modest_msg_view_window_clipboard_owner_change):
947 * src/modest-init.c: (modest_init_init_ui):
948 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
949 (update_folders_cb), (modest_mail_operation_update_account):
950 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
951 (modest_ui_actions_on_msg_attachment_clicked),
952 (modest_ui_actions_on_msg_recpt_activated):
953 * src/widgets/modest-header-view.c: (drag_data_get_cb):
954 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
955 (modest_msg_view_search_next):
956 * src/widgets/modest-recpt-editor.c:
957 (modest_recpt_editor_on_button_release_event),
958 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
959 g_message(). At this point we should only be seeing interesting errors on
960 stdout. Debugging messages could be #ifdefed-out if they are still useful.
962 2007-05-07 Murray Cumming <murrayc@murrayc.com>
964 (modest_wizard_dialog_force_title_update):
965 * src/maemo/easysetup/modest-wizard-dialog.h:
966 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
967 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
968 can update the title when appropriate. Otherwise the title is wrong if the
969 pages are added after adding the notebook to the dialog.
970 This must be a problem in HildonWizardDialog too.
971 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
973 * src/maemo/easysetup/modest-easysetup-wizard.c:
974 (create_subsequent_customsetup_pages),
975 (create_subsequent_easysetup_pages):
976 Call modest_wizard_dialog_force_title_update() so that the title is
977 correct even with GTK+ < 2.10.
978 This fixes projects.maemo.org bug NB#56145 .
980 2007-05-07 Murray Cumming <murrayc@murrayc.com>
982 * src/maemo/modest-platform.c:
983 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
984 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
987 2007-05-07 Murray Cumming <murrayc@murrayc.com>
989 * src/widgets/modest-window.h:
990 * src/widgets/modest-window.c: Added a save_state_func vfunc,
991 and modest_window_save_state(), which invokes it.
993 * src/widgets/modest-window-mgr.h:
994 * src/widgets/modest-window-mgr.c:
995 Added modest_window_mgr_save_state_for_all_windows(), which calls
996 the save_state vfunc on all registered windows, if implemented.
998 * src/gnome/modest-msg-edit-window.c:
999 * src/gnome/modest-msg-view-window.c:
1000 * src/maemo/modest-msg-edit-window.c:
1001 * src/maemo/modest-msg-view-window.c:
1002 * src/maemo/modest-main-window.c:
1003 Specify the existing save_settings functions as implementations of
1004 ModestWindow::save_state_func().
1006 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1007 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1008 enabling hibernation, for instance.
1010 We may need to do the same thing for restoring settings.
1013 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1015 * src/widgets/modest-window-mgr.c:
1016 * src/widgets/modest-window-mgr.h:
1017 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1018 modest_window_mgr_get_hibernation_is_prevented().
1020 * src/maemo/modest-main-window.c:
1021 (on_hildon_program_is_topmost_notify): Prevent hibernation
1022 (possible when the application goes to the background in the WM),
1023 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1025 * src/maemo/easysetup/modest-easysetup-wizard.c:
1026 (modest_easysetup_wizard_dialog_init):
1027 * src/maemo/modest-account-settings-dialog.c:
1028 (modest_account_settings_dialog_init):
1029 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1030 (modest_connection_specific_smtp_edit_window_init):
1031 * src/maemo/modest-connection-specific-smtp-window.c:
1032 (modest_connection_specific_smtp_window_init):
1033 * src/maemo/modest-signature-editor-dialog.c:
1034 (modest_signature_editor_dialog_init):
1035 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1036 prevent hibernation while any of these account settings dialogs are open.
1038 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1040 * src/maemo/Makefile.am:
1041 * src/maemo/modest-osso-state-saving.c:
1042 * src/maemo/modest-osso-state-saving.h: Added
1043 modest_osso_load_state() and modest_osso_save_state() though they do
1044 nothing now. They should iterate through all the open windows and load/save
1046 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1047 save state when closing.
1049 * src/maemo/modest-main-window.c:
1050 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1051 Add a notification handler for the HildonProgram::is-topmost property,
1052 so we can allow hibernation when the application goes into the background.
1053 But we still need to detect when the accounts setup windows are open so
1054 we can stop hibernation when they are open.
1055 To do this, I also added the main window the HildonProgram. This might have
1056 other side-effects/benefits, and should maybe be done for other windows.
1058 * src/maemo/modest-osso-autosave-callbacks.h:
1059 * src/maemo/modest-osso-autosave-callbacks.c:
1060 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1061 though it does not do anything yet, and we might never need this to do
1062 anything. For instance, we already save drafts.
1064 * src/maemo/modest-platform.c: (modest_platform_init):
1065 Specify the libosso auto-save callback.
1067 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1069 * src/maemo/modest-platform.c:
1070 (modest_platform_set_update_interval):
1071 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1072 aparently stays valid between application instances, so we can use this
1073 to remove and reset it later. According to a maemo-developers email from
1076 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1078 * configure.ac: Depend on libalarm for Maemo.
1080 * src/dbus_api/modest-dbus-api.h:
1081 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1082 (on_send_receive), (modest_dbus_req_handler):
1083 Handle a SEND_RECEIVE D-Bus method.
1085 * libmodest-dbus-client/libmodest-dbus-client.c:
1086 (libmodest_dbus_client_send_and_receive):
1087 * libmodest-dbus-client/libmodest-dbus-client.h:
1088 Add C convenience functions for calling the new D-Bus method.
1090 * src/modest-platform.h:
1091 * src/gnome/modest-platform.c:
1092 * src/maemo/modest-platform.c:
1093 Added modest_platform_set_update_interval(), which uses the
1094 alarmd API on Maemo.
1095 (modest_platform_init),
1096 Call modest_platform_set_update_interval(), using a hard-coded
1097 interval for now (until the global settings dialog is implemented),
1098 though I am not sure that this makes sense yet.
1100 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1102 * src/dbus_api/modest-dbus-callbacks.c:
1103 (modest_osso_cb_hw_state_handler):
1104 * src/dbus_api/modest-dbus-callbacks.h:
1105 * src/maemo/modest-platform.c: (modest_platform_init):
1106 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1107 in case this has some effect on the ability for Maemo to ping the
1110 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1112 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1113 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1114 warning. It is probably a logic error, but I need to fix the build.
1116 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1118 * src/modest-account-mgr.h:
1119 * src/modest-account-mgr.c:
1120 (modest_account_mgr_account_names): Add a gboolean enabled_only
1121 parameter, so we can get lists of onlt the enabled accounts.
1123 (modest_account_mgr_add_account),,
1124 (modest_account_mgr_account_with_display_name_exists):
1125 * src/maemo/modest-msg-edit-window.c: (get_transports):
1126 * src/modest-account-mgr-helpers.c:
1127 (modest_account_mgr_set_first_account_as_default):
1128 * src/modest-init.c: (init_default_account_maybe):
1129 * src/modest-tny-account-store.c: (get_accounts):
1130 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1131 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1132 * tests/check_account-mgr.c: (START_TEST):
1133 Provide the extra parameter, as appropriate.
1135 * src/widgets/modest-account-view.c: (update_account_view):
1136 Do not show disabled accounts (meaning that there is no way to
1137 enable/disable accounts in the UI (the feature is not in our UI
1138 specification), so we can use this internally only to mark unfinished
1139 or temporary account data.
1141 * src/maemo/easysetup/modest-easysetup-wizard.c:
1142 (create_account): Add boolean enable parameter, so we can specify FALSE
1143 to create the temporary account.
1144 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1145 (on_before_next): When finishing, when there is a temporary account, just
1147 Also, use a timeout to delay the showing of the dialog until gconf is likely
1148 to return correct information, due to a maemo gconf bug that is fixed in
1149 osso 1.1, but not yet in Bora.
1150 However, the dialog stays on screen after it is destroyed.
1152 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1153 for invalid data when cancelling. Use a hildon note instead of a dialog
1154 to complain about invalid data. Do not show the account-saved note if the
1155 account is disabled (a temporary account that will not really be saved for use
1158 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1160 * src/modest-account-mgr-helpers.h:
1161 * src/modest-account-mgr-helpers.c:
1162 Added modest_account_mgr_unset_default_account(),
1163 Added modest_account_mgr_set_first_account_as_default().
1165 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1166 If it was the default account, unset the default account name.
1168 * src/maemo/modest-account-view-window.c:
1169 (on_delete_button_clicked): If it was the default account,
1170 set the first remaining account as the default instead.
1172 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1173 a NULL account or a NULL default account, to prevent a crash. This should
1174 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1177 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1179 * src/widgets/modest-recpt-editor.c:
1180 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1181 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1182 TODO comment for this. This fixes the build.
1184 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1185 be the best place for it. This will in future update all auto-update accounts,
1186 rather than just the current/default account, when that gconf key exists.
1187 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1188 if there are no accounts, before calling do_send_receive().
1189 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1191 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1192 * src/maemo/modest-main-window-ui.h:
1193 * src/maemo/modest-main-window.c: (on_connection_changed),
1194 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1195 directly, becaue the signal handler does more.
1197 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1199 * src/modest-account-mgr-helpers.c:
1200 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1201 for the case that the account does not exist.
1203 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1204 (equivalent to the modest account name) rather than the tinymail account name
1205 (equivalent to the modest account title - human readable) to get the account data.
1206 Check for null account data to prevent the crash, and add a TODO comment saying that
1207 this needs fixing because it is using the server account name instead of the account name.
1209 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1211 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1212 * src/maemo/modest-account-settings-dialog.c: (show_error),
1214 Use hildon_note_new_information() for informative and error messages,
1215 which seems to be expected for Maemo applications (no documentation that I know of
1216 says this). I am surprised that there is no distinction between info and error
1219 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1221 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1222 it is easy to find where this is used.
1224 * src/maemo/easysetup/modest-easysetup-wizard.c:
1225 (create_page_welcome), (create_page_account_details),
1226 (create_page_user_details), (create_page_complete_easysetup),
1227 (create_page_custom_incoming), (create_page_custom_outgoing),
1228 (create_page_complete_custom):
1229 * src/maemo/modest-account-settings-dialog.c:
1230 (create_page_account_details), (create_page_user_details),
1231 (create_page_incoming), (create_page_outgoing):
1232 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1233 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1234 (modest_connection_specific_smtp_edit_window_init):
1235 * src/maemo/modest-connection-specific-smtp-window.c:
1236 (modest_connection_specific_smtp_window_init):
1237 * src/maemo/modest-signature-editor-dialog.c:
1238 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1239 and scrolling policy as per the Email Application Layout Guide, if I have
1242 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1244 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1245 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1246 which were empty, because these vfuncs have been removed from TnyAccountStore.
1247 This fixes the build.
1249 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1251 * src/maemo/modest-main-window.c:
1252 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1253 showing/hiding it. Added TODO because it probably should not be NULL.
1254 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1255 because unnecessary g_warnings() make degugging difficult.
1257 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1259 * src/maemo/modest-msg-edit-window.c:
1260 (modest_msg_edit_window_select_color),
1261 (modest_msg_edit_window_select_background_color): 2 const corrections and
1262 moving 2 #endifs before closing brackets, to fix the build.
1264 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1266 * src/maemo/easysetup/modest-easysetup-wizard.h:
1267 * src/maemo/easysetup/modest-easysetup-wizard.c:
1268 (modest_easysetup_wizard_dialog_finalize),
1269 (on_button_edit_advanced_settings), (create_page_complete_custom),
1270 (on_response), (create_account):
1271 Implement the Advanced Settings edit button, by saving the account information,
1272 for the Advanded Settings dialog to use directly from gconf, and removing it
1273 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1274 Bug #5533 in the projects.maemo.org bugzilla.
1276 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1278 * src/maemo/modest-msg-view-window.c:
1279 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1280 when opening a message window.
1282 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1284 * src/maemo/easysetup/modest-easysetup-wizard.c:
1285 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1288 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1289 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1290 gconf settings. I probably added more checks than necessary, but that is safer.
1292 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1293 variable to fix the build, but this seems to be used when it is still NULL.
1295 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1297 * src/modest-platform.h:
1298 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1299 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1300 * src/modest-main.c: Implement this function so we can avoid using
1301 maemo-specific API from cross-platform code.
1303 * src/modest-tny-account-store.c:
1304 (get_smtp_specific_transport_account_for_open_connection):
1305 * src/modest-ui-actions.c: (check_for_connection),
1306 (modest_ui_actions_on_item_not_found):
1307 Use modest_platform_connect_and_wait() and put #idefs around other
1308 maemo-specific code, because only maemo currently has a way to
1309 identify connection names.
1311 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1313 * src/modest-tny-account-store.h:
1314 * src/modest-tny-account-store.c:
1315 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1316 the connection-specific SMTP server settings in the configuration.
1318 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1320 * src/maemo/modest-main-window.c: (on_connection_changed),
1322 * src/modest-main.c: (main), (start_ui), (send_mail):
1323 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1324 that is what is intended.
1326 * src/modest-ui-actions.c: (action_send), (action_receive),
1327 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1328 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1329 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1330 SMTP server is used when it is specified.
1332 (modest_ui_actions_on_send_receive):
1333 Check that a connection is open before proceeding.
1334 Receive and then send, instead of vice-versa, as per the specification.
1336 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1338 * src/modest-mail-operation.c:
1339 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1340 though I guess it should be something other than NULL.
1342 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1344 * src/maemo/easysetup/modest-easysetup-wizard.c:
1345 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1346 combo twice, to avoid an g_warning and to make it visible again.
1347 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1348 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1349 (already intended) dereference when detaching, because we then recreate the menu.
1350 But I am not sure why the warning was happening, and it is possible that this is a memory
1353 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1355 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1356 and uri_parse_mailto() utility functions.
1357 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1359 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1361 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1363 * src/dbus_api/modest-dbus-api.h:
1364 * src/dbus_api/modest-dbus-callbacks.c:
1365 Use an idle callback to execute the modest code in the application's own thread.
1366 Remove the helloworld example method.
1367 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1368 parsed, and the open-message method is not implemented because this is not yet implemented in
1370 * libmodest-dbus-client/libmodest-dbus-client.c:
1371 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1372 (libmodest_dbus_client_open_message):
1373 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1375 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1376 body without crashing.
1378 * tests/dbus_api/Makefile.am:
1379 * tests/dbus_api/test_mail_to.c:
1380 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1382 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1384 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1385 Added file to fix the build. Sorry.
1387 * src/dbus_api/Makefile.am:
1388 * src/dbus_api/modest-dbus-api.h:
1389 * src/dbus_api/modest-dbus-callbacks.h:
1390 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1391 (modest_dbus_req_handler):
1392 Put constants in a separate header so it can be reused by the
1393 client library, without duplication
1395 * libmodest-dbus-client/Makefile.am:
1396 * libmodest-dbus-client/libmodest-dbus-client.c:
1397 (libmodest_dbus_client_call_helloworld),
1398 (libmodfest_dbus_client_send_mail),
1399 (libmodfest_dbus_client_mailto),
1400 (libmodfest_dbus_client_open_message):
1401 * libmodest-dbus-client/libmodest-dbus-client.h:
1402 (Partly) Implement a send_mail D-Bus method.
1404 * tests/dbus_api/Makefile.am:
1405 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1406 the send_email D-Bus method.
1408 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1412 * libmodest-dbus-client/Makefile.am:
1413 * libmodest-dbus-client/libmodest-dbus-client.c:
1414 * libmodest-dbus-client/libmodest-dbus-client.h:
1415 * tests/dbus_api/Makefile.am:
1416 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1417 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1419 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1421 * src/maemo/easysetup/modest-easysetup-wizard.c:
1422 (create_page_account_details):
1423 * src/maemo/modest-account-settings-dialog.c:
1424 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1425 widgets, because this might not be the default in future versions of the Maemo GTK+.
1426 However, I can not not get capitalization to work even in a simple test case.
1428 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1430 * src/maemo/easysetup/modest-easysetup-wizard.c:
1431 (create_page_custom_incoming), (create_page_custom_outgoing):
1432 * src/maemo/modest-account-settings-dialog.c:
1433 (create_page_account_details), (create_page_incoming),
1434 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1435 instead of using gtk_check_button_with_label(), so they are aligned like the other
1436 widgets, as per the UI spec.
1438 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1440 * src/maemo/easysetup/modest-easysetup-wizard.c:
1441 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1442 * src/widgets/modest-validating-entry.c:
1443 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1444 Modest prefix instead of an EasySetup prefix.
1446 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1448 * src/widgets/modest-validating-entry.h:
1449 * src/widgets/modest-validating-entry.c: (on_insert_text),
1450 Added easysetup_validating_entry_set_max_func(), used to set a callback
1451 to call when the max number of characters is reached. GtkEntry has a max-length
1452 already but is silent about it.
1454 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1455 (create_page_account_details), (create_page_user_details),
1457 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1458 (create_page_account_details), (create_page_user_details),
1459 (create_page_outgoing):
1460 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1461 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1462 the UI spec, when the user tries to enter more than the max number of characters.
1464 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1466 * src/maemo/easysetup/modest-easysetup-wizard.c:
1467 (create_page_user_details), (create_page_custom_incoming),
1468 (create_page_custom_outgoing):
1469 * src/maemo/modest-account-settings-dialog.c:
1470 (create_page_user_details), (create_page_incoming),
1471 (create_page_outgoing):
1472 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1473 (modest_connection_specific_smtp_edit_window_init):
1474 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1475 not appropriate. Bad Maemo-specific defaults!.
1477 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1479 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1480 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1481 (modest_signature_editor_dialog_set_settings):
1482 Disable the label and textview when the checkbox is disabled, and use the
1483 specified (UI spec) default signature text.
1485 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1487 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1488 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1490 * src/modest-defs.h:
1491 * src/modest-account-mgr-helpers.h:
1492 * src/modest-account-mgr-helpers.c:
1493 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1495 * src/maemo/Makefile.am:
1496 * src/maemo/modest-signature-editor-dialog.c:
1497 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1500 * src/maemo/modest-account-settings-dialog.h:
1501 * src/maemo/modest-account-settings-dialog.c:
1502 (modest_account_settings_dialog_finalize), (on_button_signature),
1503 (save_configuration): Use the new dialog when the Edit button is pressed, and
1504 save the changes if necessary, as per the UI spec.
1506 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1508 * src/maemo/Makefile.am:
1509 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1510 based on maemo-develoers email from Dirk.
1512 * src/maemo/easysetup/modest-easysetup-wizard.c:
1513 (create_page_welcome), (create_page_account_details),
1514 (create_page_user_details), (create_page_complete_easysetup),
1515 (create_page_custom_incoming), (create_page_custom_outgoing),
1516 (create_page_complete_custom),
1517 (modest_easysetup_wizard_dialog_init):
1518 * src/maemo/modest-account-settings-dialog.c:
1519 (create_page_account_details), (create_page_user_details),
1520 (create_page_incoming), (create_page_outgoing),
1521 (modest_account_settings_dialog_init):
1522 * src/maemo/modest-connection-specific-smtp-window.c:
1523 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1525 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1527 * src/maemo/easysetup/modest-easysetup-wizard.c:
1528 (create_page_account_details), (create_page_custom_outgoing),
1529 (create_page_complete_custom):
1530 * src/maemo/modest-account-settings-dialog.c:
1531 (create_page_user_details), (create_page_incoming),
1532 (create_page_outgoing):
1533 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1534 (modest_connection_specific_smtp_edit_window_init):
1535 Use the correct (UI spec) port min/max, and use horizontal separators,
1538 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1540 * src/maemo/easysetup/modest-easysetup-wizard.c:
1541 (set_default_custom_servernames):
1542 * src/maemo/modest-account-settings-dialog.c:
1543 (create_page_incoming), (on_combo_outgoing_security_changed),
1544 (on_combo_incoming_security_changed), (create_page_outgoing),
1545 (modest_account_settings_dialog_set_account_name),
1546 (save_configuration):
1547 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1548 (on_combo_security_changed),
1549 (modest_connection_specific_smtp_edit_window_init),
1550 (modest_connection_specific_smtp_edit_window_set_connection),
1551 (modest_connection_specific_smtp_edit_window_get_settings):
1552 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1555 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1558 * src/maemo/easysetup/modest-easysetup-wizard.c:
1559 (create_page_custom_outgoing), (create_page_complete_custom):
1560 * src/maemo/modest-account-settings-dialog.c:
1561 (create_page_user_details), (create_page_outgoing):
1562 * src/maemo/modest-account-view-window.c: (button_box_new):
1563 Use changed logical IDs as per the most recent UI spec:
1564 mcen_bd_emailsetup_edit -> mcen_bd_edit
1565 mcen_bd_emailsetup_delete -> mcen_bd_delete
1566 mcen_bd_emailsetup_close -> mcen_bd_close
1568 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1572 * src/dbus_api/Makefile.am:
1573 * src/dbus_api/modest-dbus-callbacks.c:
1574 * src/dbus_api/modest-dbus-callbacks.h:
1575 * src/maemo/modest-platform.c: (modest_platform_init):
1576 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1578 * tests/Makefile.am:
1579 * tests/dbus_api/Makefile.am:
1580 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1582 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1584 * src/maemo/modest-account-settings-dialog.c:
1585 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1586 Removed unnecessary includes.
1588 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1590 * src/maemo/easysetup/modest-easysetup-wizard.c:
1591 * src/maemo/modest-account-settings-dialog.c:
1592 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1593 * src/widgets/Makefile.am:
1594 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1595 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1596 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1597 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1598 * src/widgets/modest-secureauth-combo-box.c:
1599 * src/widgets/modest-secureauth-combo-box.h:
1600 * src/widgets/modest-serversecurity-combo-box.c:
1601 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1602 made the GObject names more consistent with the rest of the Modest code.
1604 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1606 * src/maemo/easysetup/Makefile.am:
1607 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1608 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1609 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1610 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1611 * src/maemo/easysetup/modest-easysetup-wizard.c:
1612 * src/maemo/easysetup/modest-validating-entry.c:
1613 * src/maemo/easysetup/modest-validating-entry.h:
1614 * src/maemo/modest-account-settings-dialog.c:
1615 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1616 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1617 widgets/ because they are used outside of easysetup too. After checking in,
1618 svn will allow me to rename them too.
1620 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1622 * src/gnome/modest-msg-edit-window.c:
1623 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1624 linker error, to fix the build on the GNOME platform.
1625 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1626 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1627 ifdefed out to avoid a warning.
1629 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1631 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1632 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1633 some alternative for GTK+ 2.6.
1635 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1637 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1639 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1640 specified for EmailAccountsDialog in UI spec.
1642 * src/maemo/easysetup/modest-easysetup-wizard.c:
1643 * src/maemo/easysetup/modest-easysetup-wizard.h:
1644 * src/maemo/modest-account-settings-dialog.c:
1645 * src/maemo/modest-account-settings-dialog.h:
1646 Reuse a member window widget for the connection-specific SMTP server accounts,
1647 so we can tell it to create/save the accounts only if we actually save changes.
1649 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1650 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1651 (modest_connection_specific_smtp_edit_window_get_settings):
1652 Return a struct instance for temporarily remembering the entered data.
1654 * src/maemo/modest-connection-specific-smtp-window.h:
1655 * src/maemo/modest-connection-specific-smtp-window.c:
1656 (modest_connection_specific_smtp_window_finalize),
1657 (modest_connection_specific_smtp_window_fill_with_connections),
1659 (modest_connection_specific_smtp_window_save_server_accounts),
1660 (update_model_server_names): Do not actually save data until asked,
1661 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1663 (on_selection_changed),
1664 (modest_connection_specific_smtp_window_init): Disable the edit
1665 button when nothing is selected.
1667 * src/modest-account-mgr-helpers.c:
1668 * src/modest-account-mgr-helpers.h:
1669 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1672 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1674 * src/modest-account-mgr-helpers.h:
1675 * src/modest-account-mgr-helpers.c:
1676 (modest_account_mgr_get_unused_account_name),
1677 (modest_account_mgr_get_unused_account_display_name): Added these
1678 utility functions, to avoid code duplication.
1680 * src/maemo/easysetup/modest-easysetup-wizard.c:
1681 (create_page_account_details), (create_account):
1682 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1683 (on_combo_security_changed),
1684 (modest_connection_specific_smtp_edit_window_init),
1685 (modest_connection_specific_smtp_edit_window_save_settings):
1686 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1687 * src/maemo/modest-connection-specific-smtp-window.c:
1688 (modest_connection_specific_smtp_window_finalize),
1689 (modest_connection_specific_smtp_window_fill_with_connections),
1690 (on_button_edit), (modest_connection_specific_smtp_window_init):
1691 * src/maemo/modest-connection-specific-smtp-window.h:
1692 Implementing saving of connection-specific server accounts.
1694 But I need to refactor this so we can save the data for each
1695 possible connection-specific account and only actually create the server accounts
1696 when the easysetup finished, or the OK button is pressed on the account settings
1699 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1701 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1702 (on_combo_security_changed):
1703 (modest_connection_specific_smtp_edit_window_init):
1704 Auto-fill the port number as in the account settings.
1706 (modest_connection_specific_smtp_edit_window_set_connection):
1707 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1708 * src/maemo/modest-connection-specific-smtp-window.c:
1709 (fill_with_connections), (on_button_edit),
1710 (modest_connection_specific_smtp_window_init):
1711 Turn the edit window into a dialog to simplify the code, and
1712 set a WM hint as in a GtkDialog, because only a popup can be on top of
1713 another window in Maemo, and popups usually have no WM decoration.
1715 * src/modest-defs.h:
1716 * src/modest-account-mgr-helpers.c:
1717 (modest_account_mgr_set_connection_specific_smtp),
1718 (modest_account_mgr_remove_connection_specific_smtp),
1719 (modest_account_mgr_get_connection_specific_smtp):
1720 * src/modest-account-mgr-helpers.h: Some functions to write the
1721 connection-specific SMTP server information. Not yet used.
1724 * src/widgets/modest-folder-view.c: (text_cell_data):
1725 Fix a warning about an uninitialized variable.
1726 (on_configuration_key_changed): Put an #ifdef around the use
1727 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1729 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1731 * src/maemo/modest-account-settings-dialog.h:
1732 * src/maemo/modest-account-settings-dialog.c:
1733 Added connect_for_modified() utility function to mark the new modified boolean.
1735 (create_page_account_details), (create_page_user_details),
1736 (create_page_incoming), (create_page_outgoing), (on_response),
1737 (modest_account_settings_dialog_init),
1738 (modest_account_settings_dialog_set_account_name):
1739 Only warn about unsaved changes when there are actually unsaved changes.
1741 * src/modest-account-mgr-helpers.c:
1742 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1743 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1744 to get the data from there in future.
1746 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1748 * src/modest-defs.h:
1750 * src/modest-account-mgr-helpers.h:
1751 * src/modest-account-mgr-helpers.c:
1752 Store the security account setting in a single conf key instead of using
1753 the options list, so that the list is left for just the to-be-removed camel hack,
1754 and because gconf_client_set_list() is failing for some reason.
1756 * src/modest-account-mgr.c:
1757 (modest_account_mgr_add_server_account):
1758 * src/maemo/modest-account-settings-dialog.c:
1759 (modest_account_settings_dialog_set_account_name),
1760 (save_configuration): Use the renamed functions.
1763 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1765 * src/widgets/Makefile.am:
1766 * src/widgets/modest-limit-retrieve-combo-box.c:
1767 * src/widgets/modest-limit-retrieve-combo-box.h:
1768 * src/widgets/modest-retrieve-combo-box.c:
1769 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1770 the account settings dialog.
1772 * src/modest-defs.h:
1773 * src/modest-account-mgr-helpers.h:
1774 * src/modest-account-mgr-helpers.c:
1775 (modest_server_account_get_option_secure_auth),
1776 (modest_server_account_set_option_secure_auth):
1777 * src/modest-account-mgr.c:
1778 (modest_account_mgr_add_server_account):
1779 Use the existing AUTH_MECH conf key for the secure-auth setting,
1780 instead of putting it in the list options, because this was actually used already.
1782 * src/maemo/modest-account-settings-dialog.c:
1783 (create_page_account_details),
1784 (modest_account_settings_dialog_set_account_name),
1785 (save_configuration):
1786 * src/maemo/modest-account-settings-dialog.h:
1787 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1788 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1790 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1792 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1793 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1794 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1796 * src/modest-defs.h:
1797 * src/maemo/modest-account-settings-dialog.c:
1798 (create_page_incoming), (on_combo_outgoing_security_changed),
1799 (on_combo_incoming_security_changed), (create_page_outgoing),
1800 (modest_account_settings_dialog_set_account_name),
1801 (save_configuration): Load/Save the port number, and change it when the
1802 security combo changes, to suitable defaults.
1804 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1806 * src/modest-account-mgr.c:
1807 (modest_account_mgr_add_server_account): Set the security and secure-auth
1808 options, and add a comment saying that the other camel-specific options should be
1811 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1813 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1815 * src/modest-tny-account-store.c: (account_list_free),
1816 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1817 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1820 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1822 * src/modest-protocol-info.c:
1823 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1824 is required by our UI spec. Maybe something in our implementation will use this eventually.
1825 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1826 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1827 instead of the previous 0 placeholder.
1829 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1830 secure-auth settings.
1831 * src/modest-account-mgr-helpers.h:
1832 * src/modest-account-mgr-helpers.c:
1833 (modest_server_account_data_get_option_secure_auth),
1834 (modest_server_account_set_option_secure_auth),
1835 (modest_server_account_data_get_option_security),
1836 (modest_server_account_set_option_security): Added this API for getting and setting the security
1837 and secure-auth settings.
1839 * src/maemo/modest-account-settings-dialog.h:
1840 * src/maemo/modest-account-settings-dialog.c:
1841 (modest_account_settings_dialog_finalize), (check_data),
1842 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1843 about changing titles.
1844 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1845 (save_configuration): Save the security and secure-auth settings.
1847 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1848 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1850 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1852 * src/modest-defs.h:
1853 * src/modest-account-mgr.c:
1854 (modest_account_mgr_add_server_account):
1855 Added and used defines for the options key and value pair strings,
1856 that are used so far, though they do not seem to correspond to anything in our
1857 UI specs or ModestProtocol enum.
1859 * src/modest-account-mgr-helpers.h:
1860 * src/modest-account-mgr-helpers.c:
1861 (compare_option_strings_for_name),
1862 (modest_server_account_data_get_option_value),
1863 (modest_server_account_data_get_option_bool),
1864 (modest_account_mgr_get_server_account_option):
1865 Added helper functions for parsing the options GSList.
1867 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1869 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1870 display name is based on the supplied account name.
1871 * src/modest-account-mgr.c:
1872 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1873 with an inefficient, but good-enough, implementation.
1875 * src/maemo/easysetup/modest-easysetup-wizard.c:
1876 (create_page_account_details), (on_before_next), (create_account):
1877 Check for existing display names rather than (non-user-visible) account names, and just
1878 create and set a unique account name at the end.
1880 * src/maemo/modest-account-settings-dialog.c:
1881 (modest_account_settings_dialog_init),
1882 (modest_account_settings_dialog_set_account_name),
1883 (create_page_incoming): Show the display name, instead of the account name.
1884 (on_response): Do some (not all) extra checks, as in the UI spec.
1885 (save_configuration): Save the display name if it was changed.
1887 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1889 * po/en_GB.po: Added needed logical ID and translation.
1890 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1891 (init_view): Made the is-default column clicking work.
1893 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1896 * src/maemo/easysetup/Makefile.am:
1897 * src/maemo/easysetup/modest-easysetup-wizard.c:
1898 (modest_easysetup_wizard_dialog_init):
1899 * src/maemo/easysetup/provider-data-test.keyfile:
1900 * src/maemo/easysetup/provider-data.keyfile:
1901 Moved the provider data file to the new modest-providers-data package and used it from there.
1903 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1905 * src/modest-local-folder-info.c:
1906 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1907 N_() was already used on the static strings, but this just marks it for translation without
1908 using the translation.
1910 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1912 * src/maemo/modest-account-settings-dialog.c:
1913 (create_page_incoming),
1914 (modest_account_settings_dialog_set_account_name):
1915 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1916 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1917 I will do this if nobody else gets there first.
1919 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1921 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1922 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1923 save the security stuff.
1925 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1927 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1928 Set the email address and user fullname, which I now see must be
1931 * src/maemo/modest-account-settings-dialog.h:
1932 * src/maemo/modest-account-settings-dialog.c:
1934 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1935 leave-on-server and authentication.
1936 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1939 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1942 * src/maemo/modest-account-settings-dialog.c:
1943 * src/maemo/modest-account-settings-dialog.h:
1944 Most (but not all) of the widgets are now present as specified by the UI spec.
1945 No changes are yet saved, and some details are not properly shown yet.
1947 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1949 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1951 * src/maemo/Makefile.am:
1952 * src/maemo/modest-account-settings-dialog.c:
1953 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1954 an existing account. Doesn't do much yet.
1956 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1957 Open the accounts settings dialog when Edit is clicked.
1959 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1961 * src/maemo/easysetup/Makefile.am:
1962 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1964 * src/maemo/easysetup/modest-easysetup-wizard.c:
1965 (modest_easysetup_wizard_dialog_init):
1966 Try to get the source directory from the build system,
1967 instead of hard-coding "./" into the source code, when opening our local
1968 copies of the configuration files.
1969 But this still fails when opening the wizard from the Accounts window,
1970 maybe because the working directory seems to change at runtime.
1971 So the wizard will fail the second time unless you copy the files into their
1972 proper locations - see the stdout warnings for the paths.
1974 (create_page_account_details),(on_before_next):
1975 Check for existing non-server accounts instead of server accounts,
1976 so the default account name is useful again, and to prevent trying to
1979 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1980 Show the wizard when New is clicked.
1982 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1983 (init_view): Show the column headers, and show the columns that are
1984 specified in the UI specs. However, something in Maemo's GTK+ prevents
1985 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1986 change the default account. This is despite unsetting the special properties.
1988 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1990 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1991 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1992 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1993 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1994 to make that clearer.
1995 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1997 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/modest-account-view-window.c:
2000 (modest_account_view_window_init),
2001 (modest_account_view_window_new):
2002 Use the same buttons as specified in the
2003 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2004 the existing widgets, which never had a chance of working.
2005 Put the ModestAccountView treeview in a scrolled window.
2006 Do not repeat the initialization in both _init() and _new().
2008 * src/widgets/modest-account-view.c: (update_account_view):
2009 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2010 this widget and window shows no accounts.
2012 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2014 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2016 * src/maemo/easysetup/modest-easysetup-wizard.c:
2017 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2018 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2019 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2022 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2023 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2024 accounts exist yet, as in the UI spec.
2026 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2028 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2030 * src/maemo/Makefile.am:
2031 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2032 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2033 New window for editing connection-specific smtp details.
2034 Not fully implemented.
2036 * src/maemo/modest-connection-specific-smtp-window.c:
2037 (modest_connection_specific_smtp_window_finalize) :
2038 unref the tree model.
2039 (on_button_edit): Show the edit window.
2041 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2043 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2046 * src/maemo/Makefile.am:
2047 * src/maemo/modest-connection-specific-smtp-window.c:
2048 * src/maemo/modest-connection-specific-smtp-window.h:
2049 New window for showing the list of connections, for connection-specific
2050 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2051 * src/maemo/easysetup/modest-easysetup-wizard.c:
2052 (create_page_custom_outgoing): Show the new window when the button is clicked.
2054 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2056 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2057 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2058 * src/maemo/modest-msg-edit-window.c:
2059 (modest_msg_edit_window_insert_image):
2060 * src/modest-conf.c: (modest_conf_key_escape):
2061 * src/modest-mail-operation.c:
2062 (modest_mail_operation_send_new_mail):
2063 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2064 (modest_ui_actions_on_new_account):
2065 * src/widgets/modest-attachment-view.c: (update_filename_request):
2066 * src/widgets/modest-mail-header-view.c:
2067 Corrected warnings that were breaking the build, by commenting out unused variables,
2068 and a function, and by including a header.
2070 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2072 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2073 so we can #ifdef around platform-specific code when necessary.
2074 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2075 to allow this to build for the GNOME platform too.
2077 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2079 * src/maemo/easysetup/modest-easysetup-wizard.c:
2080 Added util_increment_name() and used it in create_page_account_details()
2081 to make sure that the default account name is always a new name.
2083 (modest_easysetup_wizard_dialog_init),
2084 (set_default_custom_servernames): Some minor memory management fixes.
2086 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2090 * src/modest-runtime.c: (init_i18n): Restored the translation
2091 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2092 are defined in config.h, and the translations are installed.
2094 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2095 is defined for translation.
2097 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2099 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2101 * src/maemo/easysetup/modest-easysetup-wizard.c:
2102 (modest_easysetup_wizard_dialog_init):
2103 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2104 Use realistic paths (though they should use $prefix generically) to the
2105 mcc_mapping and provider-data.keyfile files which might work when they
2106 are installed by the future version of the operator-wizard package,
2107 and then fallback to paths in our source code, with an explanatory
2110 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/Makefile.am:
2115 * src/maemo/easysetup/: Added files from the previously-exernal
2116 osso-modest-easysetup.
2117 * src/maemo/modest-main-window-ui.h:
2118 * src/modest-ui-actions.c:
2119 * src/modest-ui-actions.h:
2120 Added modest_ui_actions_on_new_account() as a signal handler for the
2121 New Account menu item. It shows the easysetup wizard.
2122 * po/en_GB.po: Added additional needed logical IDs and translations.
2124 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2125 Apparently ChangeLog is not used for some vague Nokia legal reasons.