1 2007-06-03 Christian Kellner <ckellner@openismus.com>
3 * libmodest-dbus-client/libmodest-dbus-client.c:
4 * libmodest-dbus-client/libmodest-dbus-client.h:
5 Implement searching for mesages over raw dbus. (Client side)
7 * src/dbus_api/Makefile.am:
8 * src/dbus_api/modest-dbus-api.h:
9 * src/dbus_api/modest-dbus-callbacks.c:
10 * src/dbus_api/modest-dbus-callbacks.h:
11 Search framework (Server side). Also implement on_idle_open_message().
13 * src/maemo/modest-platform.c: (modest_platform_init):
14 Prepare for raw dbus/osso rpc interaction.
16 * src/modest-search.h:
17 Changed minsize from unspecific guint to guint32.
19 * src/modest-search.c:
21 Added strange hack which magically made tnymail work.
23 (modest_search_folder),
24 (modest_search_account),
25 (modest_search_all_accounts):
26 Implement helper functions to search all accounts, specific account
29 * tests/dbus_api/Makefile.am:
30 * tests/dbus_api/test_open_message.c:
31 Read url to open from commandline.
33 * tests/dbus_api/test_search.c:
34 Implement small test for dbus search stuff
36 2007-06-02 Armin Burgmeier <armin@openismus.com>
38 * src/maemo/modest-account-settings-dialog.c: Changed window title to
39 include account type and account title. This fixes projects.maemo.org
42 * src/maemo/modest-account-view-window.c: Set a title for the window.
44 2007-06-02 Armin Burgmeier <armin@openismus.com>
46 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
47 incoming and outgoing server name based on email address and server
48 types as long as the names have not been edited manually. This fixes
49 projects.maemo.org bug NB#58671.
51 2007-06-02 Armin Burgmeier <armin@openismus.com>
53 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
54 server type cannot be changed in future to the incoming details page
55 when creating an account. This fixes projects.maemo.org bug NB#59029.
57 2007-06-02 Armin Burgmeier <armin@openismus.com>
59 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
60 and assigned max width chars so that they wrap instead of being
61 truncated. Fixes projects.maemo.org bug NB#56126.
63 2007-06-02 Armin Burgmeier <armin@openismus.com>
65 * src/maemo/modest-connection-specific-smtp-window.c: Add an
66 introductory note to the connection specific smtp servers dialog, as
67 section 8.12 of the email UI specification requires. This fixes
68 projects.maemo.org bug NB#59212.
70 2007-06-01 Murray Cumming <murrayc@murrayc.com>
72 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
73 Check for running mail operations, and offer to cancel them, as per the UI
74 spec. This fixes projects.maemo.org bug NB#59041 .
75 However, I suspect that tinymail may still use the network connection
76 in ways that we cannot detect or cancel. But it should at least adapt to
79 2007-06-01 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-tny-account-store.c: (recreate_all_accounts),
82 (get_cached_accounts), (get_server_accounts): Do more sensible
83 ref-counting of the temporarily-cached outbox accounts list. This seems
84 to fix a crash when entering the password when the password was wrong.
86 2007-06-01 Murray Cumming <murrayc@murrayc.com>
88 * src/gnome/modest-main-window.c: (connect_signals):
89 * src/modest-tny-account-store.c: (get_password),
90 (modest_tny_account_store_alert): Added comments and clues and
91 commented-out code about how we currently fail to deal with connection
92 errors and wrong passwords, and how we should.
94 2007-06-01 Murray Cumming <murrayc@murrayc.com>
96 * src/widgets/modest-retrieve-combo-box.c:
97 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
98 This fixes projects.maemo.org bug NB#58472 .
100 2007-06-01 Murray Cumming <murrayc@murrayc.com>
102 * src/maemo/easysetup/modest-easysetup-wizard.c:
103 (create_page_complete_easysetup):
104 (create_page_complete_custom): Correct the last commit,
105 putting the correct sentences in the correct pages.
107 2007-06-01 Murray Cumming <murrayc@murrayc.com>
109 * src/maemo/easysetup/modest-easysetup-wizard.c:
110 (create_page_complete_custom): Show the second sentence of text
111 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
114 2007-06-01 Murray Cumming <murrayc@murrayc.com>
116 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
117 Set the leave-on-server conf key by default. This fixes
118 projects.maemo.org bug NB#59258 .
120 2007-06-01 Murray Cumming <murrayc@murrayc.com>
122 * src/maemo/modest-account-view-window.c:
123 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
124 logical ID for the confirmation messages. Fixed projects.maemo.org bug
127 2007-06-01 Murray Cumming <murrayc@murrayc.com>
129 * src/maemo/easysetup/modest-easysetup-wizard.c:
130 (create_caption_new_with_asterisk):
131 * src/maemo/modest-account-settings-dialog.c:
132 (create_caption_new_with_asterisk):
133 Uncomment the code to add the asterisk, because they are no longer in the
134 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
135 (update_incoming_server_title): Add an asterisk here too.
137 2007-06-01 Murray Cumming <murrayc@murrayc.com>
139 * src/maemo/modest-maemo-global-settings-dialog.c:
140 (current_connection): Check that we are even connected before trying to
141 get the current connection name, to prevent a warning.
143 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
144 Change the comments because tny_maemo_conic_device_connect() is now meant to
146 * src/modest-mail-operation.c:
147 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
148 make sure we have a connection and fail if we can't connect.
150 2007-05-31 Murray Cumming <murrayc@murrayc.com>
152 * src/maemo/modest-main-window.c:
153 (on_account_store_connecting_finished): Do not try to get the
154 connection ID if we are not really connected. I am surprised that
155 this signal handler is called when we are not connected.
157 2007-05-31 Murray Cumming <murrayc@murrayc.com>
159 * src/modest-error.h:
160 * src/modest-ui-actions.c:
161 (modest_ui_actions_get_msgs_full_error_handler):
162 Renamed an enum, added comments, added an enum
163 for retrieve-limit errors.
165 * src/modest-mail-operation.c: (foreach_add_item),
166 (internal_folder_observer_update), (update_account_thread),
167 (modest_mail_operation_get_msgs_full):
168 (modest_mail_operation_update_account),
169 Added comments about how this works, and some code that should
170 (but does not) check the retrieve-limit. See the TODO comment.
172 2007-05-31 Murray Cumming <murrayc@murrayc.com>
174 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
175 Initialize help_id to fix the build. Warnings are good.
177 2007-05-31 Murray Cumming <murrayc@murrayc.com>
179 * src/widgets/modest-hbox-cell-renderer.c:
180 (modest_hbox_cell_renderer_append):
181 * src/widgets/modest-vbox-cell-renderer.c:
182 (modest_vbox_cell_renderer_append):
183 Fix the last commit by doing an extra ref.
185 2007-05-31 Murray Cumming <murrayc@murrayc.com>
187 * src/widgets/modest-hbox-cell-renderer.c:
188 (modest_hbox_cell_renderer_append):
189 * src/widgets/modest-vbox-cell-renderer.c:
190 (modest_vbox_cell_renderer_append):
191 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
192 to fix the build with Maemo Bora.
193 However, there seems to be a remaining crash, probably due to reference
196 2007-05-30 Murray Cumming <murrayc@murrayc.com>
198 * src/modest-tny-account.c:
199 (modest_tny_account_new_for_local_folders):
200 Use hildon_file_system_info_async_new() to get a better name for
201 the memory card account, setting it as the account name.
202 The timing seems to work, but this is probably
203 not the best place to do this. See the TODO comment.
204 * src/maemo/modest-main-window.c: (create_details_widget):
205 * src/widgets/modest-folder-view.c: (text_cell_data):
206 Use the tny account name instead of hardcoding a name.
208 2007-05-30 Christian Kellner <ckellner@openismus.com>
210 * src/modest-search.c: (modest_search):
211 Correctly set part_search_func even if we have already parsed
212 the query and thus a valid OgsTextSearcher object.
214 2007-05-30 Christian Kellner <ckellner@openismus.com>
217 Search and check for libogs.
220 Incooparte the ogs build env.
222 * src/modest-mime-part-search-stream.c:
223 * src/modest-mime-part-search-stream.h:
224 Removed since we do the real searching now in modest-search.c.
226 * src/modest-search.c:
227 * src/modest-search.h:
228 Implement support for ogs. We use that if available and requested
229 and fall back to modest_text_utils_utf8_strcmp (). The search logic
230 should now handle the corner case when the search term is spread
231 across multiple reads.
232 Also the logic in modest_search () was corrected to search all
233 requested fields until one is found.
235 2007-05-30 Murray Cumming <murrayc@murrayc.com>
237 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
240 * src/modest-init.c: Made modest_init_local_folders() take a
241 path and be public so we can iniitialize maildir folders on
244 * src/modest-local-folder-info.h:
245 * src/modest-local-folder-info.c:
246 (modest_local_folder_info_get_maildir_path): Add a path parameter.
248 * src/modest-tny-account.c:
249 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
250 still means the standard local-folders path on the local volume.
252 * src/modest-tny-account-store.c:
253 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
254 signal so we can detect mount/unmount of the MMC1 card, and do an update of
255 all accounts when that happens.
256 (get_server_accounts): If the MMC1 card is mounted, create a store account for
257 this too, so it shows up in the treeview.
259 2007-05-28 Murray Cumming <murrayc@murrayc.com>
261 * src/maemo/modest-maemo-global-settings-dialog.c:
262 (current_connection):
263 * src/widgets/modest-global-settings-dialog.c:
264 (current_connection_default):
265 Use the enum values instead of 0, 1 and -1,
266 to make the code clearer.
268 * src/modest-account-mgr-helpers.c:
269 (modest_account_mgr_get_connection_specific_smtp): Make this code
272 * src/modest-runtime.h:
273 * src/modest-runtime.c:
274 Added modest_runtime_remove_all_send_queues().
275 * src/maemo/modest-main-window.c:
276 (on_account_store_connecting_finished): Recreate the send queues,
277 using the appropriate transport accounts for this new connection.
278 Some futher adapting might be needed if the old send queues are not
279 automatically stopped at this point.
281 * src/modest-tny-account-store.c: (get_server_accounts):
282 Create the connection-specific transport accounts, so that they can
283 be found later by their ID.
285 * src/modest-tny-account.h:
286 * src/modest-tny-account.c:
287 Added modest_tny_account_new_from_server_account_name().
288 modest_tny_account_new_from_server_account(): Do not create the
289 send queues here, because they will be
290 recreated anyway when the connection changes for the first time.
292 2007-05-28 Murray Cumming <murrayc@murrayc.com>
294 * src/modest-local-folder-info.h:
295 * src/modest-local-folder-info.c:
296 (modest_per_account_local_outbox_folder_info_get_maildir_path),
297 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
298 tbox_folder): Take a modest account name instead of a server TnyAccount,
299 so we can have per-modest-account rather than per-transport-account
301 We must make sure that we change or recreate the exisitng send queues
302 when the connection changes for connection-specific transport accounts.
304 * src/modest-tny-account-store.c:
305 (create_per_account_local_outbox_folders): Create outboxed per modest
306 account, not per transport account.
308 * src/modest-tny-account.h:
309 * src/modest-tny-account.c:
310 (modest_tny_account_get_special_folder): For outboxes, get the
311 parent modest account name. The account is ignored for other folders.
312 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
313 modest account name rather than a server TnyAccount.
315 2007-05-25 Murray Cumming <murrayc@murrayc.com>
317 * src/modest-tny-account.c:
318 (modest_tny_account_new_from_server_account):
319 Call modest_runtime_get_send_queue() immediately after creating transport
320 accounts, so that they start trying to send email from the outbox as soon
321 as possible at startup. This is probably what we want.
323 * src/modest-mail-operation.c: (update_account_thread):
324 * src/modest-runtime.c: (modest_runtime_get_send_queue):
325 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
326 * src/modest-tny-send-queue.h:
327 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
328 (modest_ui_actions_on_send):
329 Added comments about how sending works, though it needs some more work.
331 2007-05-25 Murray Cumming <murrayc@murrayc.com>
333 * src/modest-tny-account.c:
334 (modest_tny_account_get_special_folder): Add TODO because this fails when
336 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
337 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
338 Do not try to show this window when there is no active account. The UI
339 specs does not tell us what to do in this case.
341 2007-05-24 Murray Cumming <murrayc@murrayc.com>
345 * src/maemo/Makefile.am:
346 * src/widgets/Makefile.am: Some dist fixes.
348 2007-05-24 Murray Cumming <murrayc@murrayc.com>
350 * src/maemo/modest-connection-specific-smtp-window.c:
351 (on_button_edit): Make the code clearer, to prevent a double free.
353 2007-05-24 Murray Cumming <murrayc@murrayc.com>
355 * src/maemo/modest-account-settings-dialog.c:
356 (modest_account_settings_dialog_set_account_name),
357 Check the connection-specific smtp servers checkbox if there are any.
359 * src/maemo/modest-connection-specific-smtp-edit-window.c:
360 (modest_connection_specific_smtp_edit_window_init):
361 Start with a suitable port number.
363 * src/modest-account-mgr-helpers.h:
364 * src/modest-account-mgr-helpers.c: Added
365 modest_account_mgr_get_has_connection_specific_smtp().
367 (modest_account_mgr_set_connection_specific_smtp),
368 (modest_account_mgr_remove_connection_specific_smtp),
369 (modest_account_mgr_get_has_connection_specific_smtp),
370 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
371 connection-specific smtp server accounts in the account, rather than
372 the server account conf dir.
374 This fixes bug projects.maemo.org bug NB#58263 .
376 * src/modest-tny-account-store.c:
377 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
378 if there are no server accounts yet, to prevent an infinite loop when there
379 are no accounts. Document that one must be called before the other.
381 2007-05-24 Murray Cumming <murrayc@murrayc.com>
383 * src/modest-account-mgr-helpers.c:
384 (modest_account_mgr_get_default_account): Make sure that at least
385 one account is always the default, if there are any enabled accounts.
386 This is just a sanity check that shouldn't be necessary.
388 * src/modest-account-mgr-priv.c:
389 (_modest_account_mgr_account_from_key): Unescape the conf key to
390 get the real account name. For instance, this is an issue if a space
391 was in the account name, which can happen because the account name
392 is generated from the display name.
393 (_modest_account_mgr_get_account_keyname): Always escape the
395 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
396 Unescape the conf keys to get the real account names.
398 For instance, previously the is-default radio button in the accounts
399 list was not checked for any accounts at first. This fixes that,
400 and might fix several similar bugs.
402 2007-05-23 Murray Cumming <murrayc@murrayc.com>
404 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
405 Removed some debug printfs.
407 2007-05-23 Murray Cumming <murrayc@murrayc.com>
409 Modest on-disk outbox directories are now here, for instance:
410 $HOME/.modest/outboxes/<account-id-1>/outbox
411 $HOME/.modest/outboxes/<account-id-2>/outbox
413 $HOME/.modest/local-folders/outbox
414 so we can have a separate outbox for each account.
415 But they are shown as one outbox in the GtkTreeView, by using a
416 TnyMergeFolder in a ModestTnySimpleFolderStore.
419 * src/modest-tny-simple-folder-store.c:
420 * src/modest-tny-simple-folder-store.h:
421 Added ModestTnySimpleFolderStore, used to contain folders from
422 other folder stores, such as other accounts.
424 * src/modest-tny-outbox-account.h:
425 * src/modest-tny-outbox-account.c:
426 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
427 used for the per-account local outbox folders.
429 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
430 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
431 only use this (internally) now for the non-outbox local folders.
434 * src/modest-init.c: Added modest_init_one_local_folder(), for
435 setting up the directory structure for each local folder.
437 * src/modest-local-folder-info.c:
438 (modest_per_account_local_outbox_folder_info_get_maildir_path),
439 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
441 * src/modest-local-folder-info.h:
442 * src/modest-tny-account-store.c: (on_account_removed),
443 (on_account_changed), (create_per_account_local_outbox_folders),
444 (get_server_accounts), (modest_tny_account_store_get_accounts),
445 (modest_tny_account_store_get_tny_account_by_account),
446 (modest_tny_folder_store_is_virtual_local_folders):
448 * src/modest-tny-account.h:
449 * src/modest-tny-account.c:
450 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
451 to create an on-disk per-account local outbox folder for each
453 (create_per_account_local_outbox_folders): Create a local outbox folder
454 for each transport account.
455 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
456 for all local folders.
458 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
459 instead of using g_object_get/set() directly. It is clearer.
461 (modest_tny_folder_store_get_message_count),
462 (modest_tny_folder_store_get_local_size
463 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
464 because we now use these with non-acount folder stores.
466 (modest_tny_account_get_special_folder),
467 (modest_tny_account_new_from_server_account),
468 (modest_tny_account_new_from_account):
469 (recurse_folders): Adjust to the new outbox system.
471 * src/modest-tny-folder.h:
472 * src/modest-tny-folder.c:
473 (modest_tny_folder_is_local_folder),
474 (modest_tny_folder_get_local_folder_type),
475 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
477 * src/widgets/modest-main-window.h:
478 * src/maemo/modest-main-window.c: (create_details_widget),
479 (modest_main_window_set_contents_style): Show details for any folder store,
482 (modest_tny_folder_get_rules):
483 Remove the const. C does not support constness enough for this.
485 * src/modest-ui-actions.c:
486 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
487 make all outboxes appear as one, in the usual local-folders tree node.
489 (set_active_account_from_tny_account),
490 (modest_ui_actions_on_folder_selection_changed):
491 * src/widgets/modest-folder-view.c: (text_cell_data),
492 (icon_cell_data), (filter_row),
493 (add_account_folders_to_merged_folder),
494 (add_account_folders_to_simple_folder_store), (),
495 (get_cmp_rows_type_pos), (cmp_rows),
496 (modest_folder_view_set_account_id_of_visible_server_account):
497 Adjust to the new outbox system, using generic folder stores and folders
500 2007-05-23 Christian Kellner <ckellner@openismus.com>
502 * src/modest-mail-operation.c:
503 (modest_mail_operation_update_account):
504 Use info->max_size instead of unintialized local var [small
505 build fix]. (Added TODO to review that change since I don't
508 2007-05-23 Marcus Bauer <marcusb@openismus.com>
510 * libmodest-dbus-client/libmodest-dbus-client.c:
511 (libmodest_dbus_client_compose_mail): function added
512 * src/dbus_api/modest-dbus-api.h:
513 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
514 (on_compose_mail): Implementation of the SendAsMail functionality
516 2007-05-22 Murray Cumming <murrayc@murrayc.com>
518 * src/modest-account-mgr.c:
519 (modest_account_mgr_add_server_account): Set the secure-connection
520 conf key for transport accounts as well as store accounts. I don't know
521 why the if was there. For instance, this makes sure that we use SSL
522 for the gmail preset from the easysetup wizard.
524 2007-05-22 Murray Cumming <murrayc@murrayc.com>
526 * src/gnome/modest-main-window.c:
527 (on_account_store_connecting_finished), (connect_signals):
528 * src/maemo/modest-main-window.c:
529 (on_account_store_connecting_finished), (connect_signals),
530 (modest_main_window_new):
531 Handle TnyAccountStore::connecting-finished instead of
532 TnyDevice::connection-changed, because we cannot actually perform
533 operations on accounts until TnyAccountStore has itself responded to
534 the TnyDevice::connection-changed signal. This prevents a GError from
536 Do not try to update at startup, because we (at least on scratchbox)
537 already do an update at startup when the device goes online.
538 This prevents a GError from tinymail.
539 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
540 Added TODO about stopping simultaneous operations.
542 2007-05-21 Murray Cumming <murrayc@murrayc.com>
544 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
545 * src/modest-mail-operation-queue.c:
546 (modest_mail_operation_queue_remove):
547 * src/modest-tny-account-store.c: When GErrors happen, give more clues
548 about where they happened.
550 2007-05-21 Murray Cumming <murrayc@murrayc.com>
552 * src/modest-ui-actions.c:
553 (modest_ui_actions_on_password_requested): Make sure that the remember
554 output parameter is always TRUE.
556 2007-05-21 Murray Cumming <murrayc@murrayc.com>
558 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
559 Show a OK/Cancel dialog if the error is a question, though we still do not
560 know anything more about what we are asking the user.
561 * src/widgets/modest-folder-view.c: (on_drag_data_received):
562 Fix an uninitialized variable (helper). This is a logic error, however.
564 2007-05-21 Christian Kellner <ckellner@openismus.com>
566 * src/modest-search.h:
567 Correct bit shifting in the ModestSearchFlags enum.
569 2007-05-21 Murray Cumming <murrayc@murrayc.com>
571 * src/modest-tny-account.c:
572 (modest_tny_account_new_from_server_account): Do not use the lsub and
573 check-all hard-coded IMAP options when using POP.
575 2007-05-21 Murray Cumming <murrayc@murrayc.com>
577 * src/modest-tny-account.c:
578 (modest_tny_account_new_from_server_account):
579 Use NULL for the secure-auth method for POP when Password auth has been
580 specified by the user, as we already do for IMAP. "auth=Login" causes
581 an error from camel or the server.
583 2007-05-17 Murray Cumming <murrayc@murrayc.com>
585 * src/maemo/modest-account-settings-dialog.c:
586 (create_page_account_details),
587 (modest_account_settings_dialog_set_account_name):
588 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
589 for the leave-on-server checkbox, rathr than just the checkbox, when
590 the protocol is not POP.
592 2007-05-17 Murray Cumming <murrayc@murrayc.com>
594 * src/widgets/modest-account-view.c:
595 * src/widgets/modest-account-view.h:
596 Added modest_account_view_select_account() which will be useful later
597 to asynchronously re-select the edited account.
599 2007-05-17 Murray Cumming <murrayc@murrayc.com>
601 * src/maemo/modest-account-settings-dialog.c:
602 (modest_account_settings_dialog_set_account_name):
603 Automatically choose the port numbers based on the secure authentication
604 methods, if they have not been chosen before.
605 This fixes projects.maemo.org bug NB#56273 .
607 2007-05-17 Murray Cumming <murrayc@murrayc.com>
609 * src/maemo/modest-main-window-ui.h:
610 * src/modest-ui-actions.c:
611 * src/modest-ui-actions.h:
612 Connect the Tools/SMTP Servers menu item to
613 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
614 SMTP servers dialog, as in the UI specification and saves changes when it
615 is closed. This fixed projects.maemo.org bug NB#56305 .
617 2007-05-17 Murray Cumming <murrayc@murrayc.com>
619 * src/maemo/modest-connection-specific-smtp-window.c:
620 (modest_connection_specific_smtp_window_init):
621 Use gtk_window_set_default_size() to make this window big enough, so
622 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
624 2007-05-17 Murray Cumming <murrayc@murrayc.com>
626 * src/maemo/modest-connection-specific-smtp-edit-window.h:
627 * src/maemo/modest-connection-specific-smtp-edit-window.c:
628 (modest_connection_specific_smtp_edit_window_init),
629 Do not try to connect to a combobox signal before the combobox exists.
630 This fixes the cras in projects.maemo.org bug NB#56288 .
631 (modest_connection_specific_smtp_edit_window_get_settings):
632 Remove the server_account_name parameter which was being checked for NULL
633 though it was not used.
635 * src/maemo/modest-connection-specific-smtp-window.c:
636 (modest_connection_specific_smtp_window_fill_with_connections),
637 (on_button_edit), (modest_connection_specific_smtp_window_init):
638 Correct the number of treemodel columns to prevent a warning.
639 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
640 libconic does not work.
642 2007-05-16 Murray Cumming <murrayc@murrayc.com>
644 * src/modest-tny-account.c:
645 (modest_tny_account_new_from_server_account):
646 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
647 SMTP when "None" was chosen by the user. However, with my SMTP server that
648 does not support ANONYMOUS, the emails do not leave the Outbox and I see
651 2007-05-16 Murray Cumming <murrayc@murrayc.com>
653 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
654 to explain the memory management issue with the ID in the ModestPair.
656 * src/gnome/modest-account-assistant.c: (add_receiving_page),
657 (add_sending_page), (modest_account_assistant_finalize):
658 * src/gnome/modest-gnome-global-settings-dialog.c:
659 (create_updating_page), (create_composing_page):
660 * src/gnome/modest-msg-edit-window.c: (get_transports),
661 (init_window), (modest_msg_edit_window_finalize),
662 (modest_msg_edit_window_get_msg_data):
663 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
664 * src/gnome/modest-transport-widget.c:
665 (modest_transport_widget_finalize), (smtp_configuration):
666 * src/maemo/modest-maemo-global-settings-dialog.c:
667 (create_updating_page), (create_composing_page):
668 * src/maemo/modest-msg-edit-window.c: (get_transports),
669 (init_window), (modest_msg_edit_window_finalize),
670 (modest_msg_edit_window_get_msg_data),
671 (modest_msg_edit_window_free_msg_data):
672 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
673 (modest_store_widget_finalize):
674 * src/maemo/modest-transport-widget.c:
675 (modest_transport_widget_finalize), (smtp_configuration):
676 * src/modest-main.c: (send_mail):
677 * src/widgets/modest-combo-box.h:
678 * src/widgets/modest-global-settings-dialog-priv.h:
679 * src/widgets/modest-global-settings-dialog.c:
680 (modest_global_settings_dialog_finalize):
681 * src/widgets/modest-msg-edit-window.h:
682 Whenever using modest_combo_box_new(), keep the ModestPairList alive
683 as long as the combo box, to prevent use of freed memory for the ID.
685 2007-05-15 Murray Cumming <murrayc@murrayc.com>
687 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
688 get_accounts(), to make this clearer. Do not check for the enabled gconf
689 key, because we do not use this for server accounts (at least, not yet).
690 This allows us to send email again.
692 2007-05-15 Murray Cumming <murrayc@murrayc.com>
694 * src/maemo/modest-platform.c:
695 (on_modest_conf_update_interval_changed), (modest_platform_init):
696 Only respond to this particular key change. All these strcmp()s cannot be
699 2007-05-15 Murray Cumming <murrayc@murrayc.com>
701 * src/maemo/modest-maemo-global-settings-dialog.c:
702 (current_connection): Prevent a crash in scratchbox when
703 ny_maemo_conic_device_get_current_iap_id() returns NULL.
704 * src/maemo/modest-platform.c:
705 (on_modest_conf_update_interval_changed), (modest_platform_init):
706 Get the update interval from gconf and reset it when the gconf key changes.
708 2007-05-15 Murray Cumming <murrayc@murrayc.com>
710 * src/modest-protocol-info.c:
711 * src/modest-protocol-info.h: Adde enum-specific get functions,
712 instead of using a ModestProtocolType enum parameter.
714 * src/gnome/modest-account-assistant.c:
715 * src/gnome/modest-store-widget.c:
716 * src/gnome/modest-store-widget.h:
717 * src/gnome/modest-transport-widget.c:
718 * src/gnome/modest-transport-widget.h:
719 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
720 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
721 * src/maemo/easysetup/modest-easysetup-wizard.c:
722 * src/maemo/modest-account-settings-dialog.c:
723 * src/maemo/modest-account-settings-dialog.h:
724 * src/maemo/modest-store-widget.c:
725 * src/maemo/modest-store-widget.h:
726 * src/maemo/modest-transport-widget.c:
727 * src/maemo/modest-transport-widget.h:
728 * src/modest-account-mgr-helpers.c:
729 * src/modest-account-mgr-helpers.h:
730 * src/modest-account-mgr.c:
731 * src/modest-account-mgr.h:
732 * src/modest-tny-account.c:
733 * src/modest-tny-folder.c:
734 * src/widgets/modest-account-view.c:
735 * src/widgets/modest-retrieve-combo-box.c:
736 * src/widgets/modest-retrieve-combo-box.h:
737 * src/widgets/modest-secureauth-combo-box.c:
738 * src/widgets/modest-serversecurity-combo-box.c:
739 * src/widgets/modest-serversecurity-combo-box.h:
740 * tests/check_account-mgr.c:
741 Use the specific functions, and use the re-renamed enum values for GNOME too.
743 2007-05-15 Murray Cumming <murrayc@murrayc.com>
746 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
747 so we can get the second based on the first.
749 * src/maemo/modest-account-settings-dialog.h:
750 * src/maemo/modest-account-settings-dialog.c:
751 Added get_supported_secure_authentication_methods(), though it is mostly
752 commented-out for now until the necessary API is committed to tinymail.
753 (modest_account_settings_dialog_set_account_name),
754 (save_configuration): Request the supported authentication methods from the
755 server, so we can choose a working method.
757 * src/modest-tny-account-store.h:
758 * src/modest-tny-account-store.c:
759 (modest_tny_account_store_get_session): Rename from
760 tny_account_store_get_session().
762 2007-05-14 Murray Cumming <murrayc@murrayc.com>
764 * src/modest-protocol-info.h: Split the ModestProtocol enum
765 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
766 There was no need to have these unrelated values in one enum.
768 * src/: many files: Adapted to changed enum. This makes the code a bit
769 clearer, and the compiler could catch some errors.
771 2007-05-14 Murray Cumming <murrayc@murrayc.com>
773 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
774 Show the detailed internal camel error message when an error happens
775 during the configuration, so that our testers can give us more clues.
776 For instance, in projects.maemo.org bug NB#56910 .
778 2007-05-14 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-tny-account.c:
781 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
782 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
784 2007-05-14 Murray Cumming <murrayc@murrayc.com>
786 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
787 * src/maemo/modest-account-settings-dialog.c:
788 (modest_account_settings_dialog_set_account_name),
789 (save_configuration): For the incoming secure authentication checkbox,
790 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
791 the UI specification. PLAIN does not seem to be supported for most IMAP
792 servers anyway, and I am not sure what it would mean.
793 However, we probably need to discover which of the secure-authentication
794 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
795 * src/modest-account-mgr-helpers.c:
796 (modest_account_mgr_get_server_account_data):
798 * src/modest-tny-account.c:
799 (modest_tny_account_new_from_server_account):
800 Use tny_account_set_mech() to set secure-authentication methods,
801 with some special-casing for IMAP, based on my observations of how
804 * src/modest-account-mgr-helpers.h:
805 * src/modest-account-mgr.c:
806 * src/modest-defs.h: Comment that the URI is only used for local folders.
808 2007-05-11 Murray Cumming <murrayc@murrayc.com>
810 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
811 parameter const, just to be neat.
812 * src/modest-text-utils.c: (modest_text_utils_inline):
813 End g_strconcat() with NULL, as its documentation says. This is almost
814 certainly the cause of my crash at startup on the device. Interestingly,
815 valgrind doesn't tell us about these errors.
817 2007-05-11 Murray Cumming <murrayc@murrayc.com>
819 * scripts/build-packages: Added more precise comments about how to use
820 this script, though I still get this error:
821 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
822 error building tinymail
824 2007-05-11 Murray Cumming <murrayc@murrayc.com>
826 * src/maemo/modest-main-window.c: (on_account_update):
827 Very slight cleanup, hoping to make it simpler to discover what causes
828 a crash here sometimes.
830 * src/modest-tny-account.c:
831 (modest_tny_account_new_from_server_account): Set the port. Added
832 comments about the options and a TODO comment because I need to find out
833 how to specify the secure authentication method.
835 2007-05-11 Marcus Bauer <marcusb@openismus.com>
837 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
838 changed CFlags paths form modest to libmodest
840 2007-05-10 Murray Cumming <murrayc@murrayc.com>
842 * src/modest-account-mgr-helpers.c:
843 (modest_account_mgr_get_server_account_data),
844 (modest_account_mgr_free_server_account_data):
845 * src/modest-account-mgr-helpers.h:
846 * src/modest-account-mgr.c:
847 (modest_account_mgr_add_server_account):
849 * src/modest-tny-account.c:
850 (modest_tny_account_new_from_server_account):
851 Determine the options for tny_camel_account_add_option() here,
852 based on the settings, rather than storing them directly in gconf.
854 2007-05-10 Murray Cumming <murrayc@murrayc.com>
856 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
857 Show a more friendly error dialog now that we expect (from the tinymail
858 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
860 2007-05-10 Murray Cumming <murrayc@murrayc.com>
862 * src/maemo/modest-main-window.c: (on_account_update): Check that
863 account_name is not NULL, to prevent a crash at startup that I am
864 seeing on the N800. I do wonder why it is NULL.
866 * src/maemo/easysetup/modest-easysetup-wizard.c:
867 (create_page_user_details):
868 * src/maemo/modest-account-settings-dialog.c:
869 (create_page_user_details), (create_page_outgoing):
870 * src/maemo/modest-connection-specific-smtp-edit-window.c:
871 (modest_connection_specific_smtp_edit_window_init):
872 * src/modest-ui-actions.c:
873 (modest_ui_actions_on_password_requested):
874 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
875 might do something useful with the on-screen keyboard.
877 2007-05-10 Murray Cumming <murrayc@murrayc.com>
879 * src/maemo/modest-main-window.c: (on_account_update):
880 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
881 NULL, to avoid lots of warnings. However, it probably should not be NULL.
883 2007-05-09 Murray Cumming <murrayc@murrayc.com>
885 * src/modest-tny-account-store.c: (on_account_changed):
886 Correct the signature of this signal handler.
888 2007-05-09 Murray Cumming <murrayc@murrayc.com>
890 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
891 Show a HildonNote instead of a GtkDialog for Maemo.
893 2007-05-09 Murray Cumming <murrayc@murrayc.com>
895 * src/widgets/modest-account-view.h:
896 * src/widgets/modest-account-view.c: (on_account_changed),
897 (on_account_removed). Added a boolean flag, set/unset by
898 modest_account_view_block_conf_updates(),
899 modest_account_view_unblock_conf_updates() to prevent unnecessary
900 updates, but this is not very useful because the gconf notifications are
901 so delays (maybe only on Maemo Bora).
902 So auto-updating is turned off, and these functions do an explicit
903 update when necessary.
904 However, something else is still doing too much work when adding/removing
905 accounts, probably in another part of the application.
907 * src/maemo/modest-account-view-window.c:
908 (on_delete_button_clicked), (on_edit_button_clicked),
909 (on_new_button_clicked): Use the new functions.
911 2007-05-09 Murray Cumming <murrayc@murrayc.com>
913 * src/modest-account-mgr-helpers.c:
914 (modest_account_mgr_set_first_account_as_default):
915 Sort the list of names alphabetically-by-title, so we choose the first one
917 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
918 alphabetically by the title.
920 This fixes projects.maemo.org bug NB#56418 .
922 * src/modest-account-mgr-priv.c:
923 (_modest_account_mgr_account_from_key):
924 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
925 avoid a valgrind error, and possible random behaviour.
927 2007-05-09 Murray Cumming <murrayc@murrayc.com>
929 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
930 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
931 tinymail documentation to say that this can be expected.
932 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
933 pretty, and should not happen, but I would prefer to know when it does.
935 2007-05-09 Murray Cumming <murrayc@murrayc.com>
937 * configure.ac: When using the older hildon version, probably on Bora,
938 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
940 * src/widgets/modest-attachment-view.c:
941 (modest_attachment_view_set_part_default): Initialize variables, to fix the
944 2007-05-09 Marcus Bauer <marcusb@openismus.com>
946 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
947 Implemented the prototype. Can be tested with
948 tests/dbus_api/test_open_message:
950 2007-05-08 Murray Cumming <murrayc@murrayc.com>
952 * src/modest-tny-account-store.c:
953 (modest_tny_account_store_instance_init), (get_password):
954 * src/modest-ui-actions.c:
955 (modest_ui_actions_on_password_requested):
956 Do not store the password in gconf, because this function is called
957 for non-remembered passwords. Actually use the cached (in the hash map)
958 password instead of releasing it.
959 The password will now not be remembered if it is asked via the protected
960 password dialog, as per the UI spec.
962 2007-05-08 Murray Cumming <murrayc@murrayc.com>
965 * src/modest-account-mgr-helpers.h:
966 * src/modest-account-mgr-helpers.c:
967 Added modest_server_account_get_username_has_succeeded(),
968 modest_server_account_set_username_has_succeeded().
969 (modest_server_account_set_username),
970 Reset the has-succeeded flag if the username changes.
972 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
973 * src/maemo/modest-connection-specific-smtp-window.c:
974 (modest_connection_specific_smtp_window_save_server_accounts):
975 Use modest_server_account_set_username() instead of using
976 modest_conf_set_string() directly, so that the has-succeeded flag is always
979 * src/modest-ui-actions.c:
980 (modest_ui_actions_on_password_requested): Dim the username entry if
981 the username has ever worked, as per the UI spec.
983 2007-05-08 Murray Cumming <murrayc@murrayc.com>
985 * src/modest-tny-account-store.c: (get_password):
986 * src/modest-ui-actions.c:
987 (modest_ui_actions_on_password_requested):
988 Allow the username to be changed too, though there is more work to
989 be done on exactly how this behaves.
991 2007-05-08 Murray Cumming <murrayc@murrayc.com>
993 * src/modest-account-mgr-helpers.h:
994 * src/modest-account-mgr-helpers.c:
995 Added modest_account_mgr_get_display_name(),
996 modest_server_account_get_username(),
997 modest_server_account_set_username(),
998 modest_server_account_set_password(),
999 modest_server_account_get_hostname() functions so we do not need to
1000 use the conf API directly.
1002 * src/maemo/modest-main-window.c: (connect_signals):
1003 Actually connect ot the ModestAccountStore::request-password signal,
1004 so that we show the dialog when the password is requested by Tinymail,
1005 for isntance if it is empty.
1007 * src/modest-marshal.list:
1008 * src/modest-tny-account-store.c:
1009 (modest_tny_account_store_class_init), (get_password),
1010 (modest_tny_account_store_alert):
1011 * src/modest-tny-account-store.h:
1012 * src/modest-ui-actions.h:
1013 * src/modest-ui-actions.c:
1014 (modest_ui_actions_on_password_requested):
1015 Change the signal parameters, so it is obvious that we are providing
1016 the non human-readable server name, and receiving both the username
1017 and password, though changing of the username is not yet implemented.
1018 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1019 for the GNOME version.
1021 This should fix the projects.maemo.org bug NB#56209, though it does not
1022 work on Bora, because the gconf_client_get() for the password fails
1023 immediately after we save it with gconf_client_set().
1025 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1028 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1029 caused an undefined symbol error:
1030 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1032 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1034 * src/modest-tny-account-store.c:
1035 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1036 using a GError instead of a string message, so we can translate it in
1039 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1041 * src/maemo/modest-address-book.c:
1042 (modest_address_book_check_names):
1043 * src/maemo/modest-msg-view-window.c:
1044 (modest_msg_view_window_clipboard_owner_change):
1045 * src/modest-init.c: (modest_init_init_ui):
1046 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1047 (update_folders_cb), (modest_mail_operation_update_account):
1048 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1049 (modest_ui_actions_on_msg_attachment_clicked),
1050 (modest_ui_actions_on_msg_recpt_activated):
1051 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1052 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1053 (modest_msg_view_search_next):
1054 * src/widgets/modest-recpt-editor.c:
1055 (modest_recpt_editor_on_button_release_event),
1056 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1057 g_message(). At this point we should only be seeing interesting errors on
1058 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1060 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1062 (modest_wizard_dialog_force_title_update):
1063 * src/maemo/easysetup/modest-wizard-dialog.h:
1064 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1065 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1066 can update the title when appropriate. Otherwise the title is wrong if the
1067 pages are added after adding the notebook to the dialog.
1068 This must be a problem in HildonWizardDialog too.
1069 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1071 * src/maemo/easysetup/modest-easysetup-wizard.c:
1072 (create_subsequent_customsetup_pages),
1073 (create_subsequent_easysetup_pages):
1074 Call modest_wizard_dialog_force_title_update() so that the title is
1075 correct even with GTK+ < 2.10.
1076 This fixes projects.maemo.org bug NB#56145 .
1078 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1080 * src/maemo/modest-platform.c:
1081 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1082 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1085 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1087 * src/widgets/modest-window.h:
1088 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1089 and modest_window_save_state(), which invokes it.
1091 * src/widgets/modest-window-mgr.h:
1092 * src/widgets/modest-window-mgr.c:
1093 Added modest_window_mgr_save_state_for_all_windows(), which calls
1094 the save_state vfunc on all registered windows, if implemented.
1096 * src/gnome/modest-msg-edit-window.c:
1097 * src/gnome/modest-msg-view-window.c:
1098 * src/maemo/modest-msg-edit-window.c:
1099 * src/maemo/modest-msg-view-window.c:
1100 * src/maemo/modest-main-window.c:
1101 Specify the existing save_settings functions as implementations of
1102 ModestWindow::save_state_func().
1104 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1105 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1106 enabling hibernation, for instance.
1108 We may need to do the same thing for restoring settings.
1111 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1113 * src/widgets/modest-window-mgr.c:
1114 * src/widgets/modest-window-mgr.h:
1115 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1116 modest_window_mgr_get_hibernation_is_prevented().
1118 * src/maemo/modest-main-window.c:
1119 (on_hildon_program_is_topmost_notify): Prevent hibernation
1120 (possible when the application goes to the background in the WM),
1121 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1123 * src/maemo/easysetup/modest-easysetup-wizard.c:
1124 (modest_easysetup_wizard_dialog_init):
1125 * src/maemo/modest-account-settings-dialog.c:
1126 (modest_account_settings_dialog_init):
1127 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1128 (modest_connection_specific_smtp_edit_window_init):
1129 * src/maemo/modest-connection-specific-smtp-window.c:
1130 (modest_connection_specific_smtp_window_init):
1131 * src/maemo/modest-signature-editor-dialog.c:
1132 (modest_signature_editor_dialog_init):
1133 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1134 prevent hibernation while any of these account settings dialogs are open.
1136 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1138 * src/maemo/Makefile.am:
1139 * src/maemo/modest-osso-state-saving.c:
1140 * src/maemo/modest-osso-state-saving.h: Added
1141 modest_osso_load_state() and modest_osso_save_state() though they do
1142 nothing now. They should iterate through all the open windows and load/save
1144 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1145 save state when closing.
1147 * src/maemo/modest-main-window.c:
1148 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1149 Add a notification handler for the HildonProgram::is-topmost property,
1150 so we can allow hibernation when the application goes into the background.
1151 But we still need to detect when the accounts setup windows are open so
1152 we can stop hibernation when they are open.
1153 To do this, I also added the main window the HildonProgram. This might have
1154 other side-effects/benefits, and should maybe be done for other windows.
1156 * src/maemo/modest-osso-autosave-callbacks.h:
1157 * src/maemo/modest-osso-autosave-callbacks.c:
1158 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1159 though it does not do anything yet, and we might never need this to do
1160 anything. For instance, we already save drafts.
1162 * src/maemo/modest-platform.c: (modest_platform_init):
1163 Specify the libosso auto-save callback.
1165 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1167 * src/maemo/modest-platform.c:
1168 (modest_platform_set_update_interval):
1169 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1170 aparently stays valid between application instances, so we can use this
1171 to remove and reset it later. According to a maemo-developers email from
1174 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1176 * configure.ac: Depend on libalarm for Maemo.
1178 * src/dbus_api/modest-dbus-api.h:
1179 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1180 (on_send_receive), (modest_dbus_req_handler):
1181 Handle a SEND_RECEIVE D-Bus method.
1183 * libmodest-dbus-client/libmodest-dbus-client.c:
1184 (libmodest_dbus_client_send_and_receive):
1185 * libmodest-dbus-client/libmodest-dbus-client.h:
1186 Add C convenience functions for calling the new D-Bus method.
1188 * src/modest-platform.h:
1189 * src/gnome/modest-platform.c:
1190 * src/maemo/modest-platform.c:
1191 Added modest_platform_set_update_interval(), which uses the
1192 alarmd API on Maemo.
1193 (modest_platform_init),
1194 Call modest_platform_set_update_interval(), using a hard-coded
1195 interval for now (until the global settings dialog is implemented),
1196 though I am not sure that this makes sense yet.
1198 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1200 * src/dbus_api/modest-dbus-callbacks.c:
1201 (modest_osso_cb_hw_state_handler):
1202 * src/dbus_api/modest-dbus-callbacks.h:
1203 * src/maemo/modest-platform.c: (modest_platform_init):
1204 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1205 in case this has some effect on the ability for Maemo to ping the
1208 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1211 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1212 warning. It is probably a logic error, but I need to fix the build.
1214 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1216 * src/modest-account-mgr.h:
1217 * src/modest-account-mgr.c:
1218 (modest_account_mgr_account_names): Add a gboolean enabled_only
1219 parameter, so we can get lists of onlt the enabled accounts.
1221 (modest_account_mgr_add_account),,
1222 (modest_account_mgr_account_with_display_name_exists):
1223 * src/maemo/modest-msg-edit-window.c: (get_transports):
1224 * src/modest-account-mgr-helpers.c:
1225 (modest_account_mgr_set_first_account_as_default):
1226 * src/modest-init.c: (init_default_account_maybe):
1227 * src/modest-tny-account-store.c: (get_accounts):
1228 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1229 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1230 * tests/check_account-mgr.c: (START_TEST):
1231 Provide the extra parameter, as appropriate.
1233 * src/widgets/modest-account-view.c: (update_account_view):
1234 Do not show disabled accounts (meaning that there is no way to
1235 enable/disable accounts in the UI (the feature is not in our UI
1236 specification), so we can use this internally only to mark unfinished
1237 or temporary account data.
1239 * src/maemo/easysetup/modest-easysetup-wizard.c:
1240 (create_account): Add boolean enable parameter, so we can specify FALSE
1241 to create the temporary account.
1242 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1243 (on_before_next): When finishing, when there is a temporary account, just
1245 Also, use a timeout to delay the showing of the dialog until gconf is likely
1246 to return correct information, due to a maemo gconf bug that is fixed in
1247 osso 1.1, but not yet in Bora.
1248 However, the dialog stays on screen after it is destroyed.
1250 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1251 for invalid data when cancelling. Use a hildon note instead of a dialog
1252 to complain about invalid data. Do not show the account-saved note if the
1253 account is disabled (a temporary account that will not really be saved for use
1256 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1258 * src/modest-account-mgr-helpers.h:
1259 * src/modest-account-mgr-helpers.c:
1260 Added modest_account_mgr_unset_default_account(),
1261 Added modest_account_mgr_set_first_account_as_default().
1263 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1264 If it was the default account, unset the default account name.
1266 * src/maemo/modest-account-view-window.c:
1267 (on_delete_button_clicked): If it was the default account,
1268 set the first remaining account as the default instead.
1270 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1271 a NULL account or a NULL default account, to prevent a crash. This should
1272 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1275 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1277 * src/widgets/modest-recpt-editor.c:
1278 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1279 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1280 TODO comment for this. This fixes the build.
1282 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1283 be the best place for it. This will in future update all auto-update accounts,
1284 rather than just the current/default account, when that gconf key exists.
1285 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1286 if there are no accounts, before calling do_send_receive().
1287 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1289 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1290 * src/maemo/modest-main-window-ui.h:
1291 * src/maemo/modest-main-window.c: (on_connection_changed),
1292 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1293 directly, becaue the signal handler does more.
1295 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1297 * src/modest-account-mgr-helpers.c:
1298 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1299 for the case that the account does not exist.
1301 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1302 (equivalent to the modest account name) rather than the tinymail account name
1303 (equivalent to the modest account title - human readable) to get the account data.
1304 Check for null account data to prevent the crash, and add a TODO comment saying that
1305 this needs fixing because it is using the server account name instead of the account name.
1307 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1309 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1310 * src/maemo/modest-account-settings-dialog.c: (show_error),
1312 Use hildon_note_new_information() for informative and error messages,
1313 which seems to be expected for Maemo applications (no documentation that I know of
1314 says this). I am surprised that there is no distinction between info and error
1317 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1319 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1320 it is easy to find where this is used.
1322 * src/maemo/easysetup/modest-easysetup-wizard.c:
1323 (create_page_welcome), (create_page_account_details),
1324 (create_page_user_details), (create_page_complete_easysetup),
1325 (create_page_custom_incoming), (create_page_custom_outgoing),
1326 (create_page_complete_custom):
1327 * src/maemo/modest-account-settings-dialog.c:
1328 (create_page_account_details), (create_page_user_details),
1329 (create_page_incoming), (create_page_outgoing):
1330 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1331 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1332 (modest_connection_specific_smtp_edit_window_init):
1333 * src/maemo/modest-connection-specific-smtp-window.c:
1334 (modest_connection_specific_smtp_window_init):
1335 * src/maemo/modest-signature-editor-dialog.c:
1336 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1337 and scrolling policy as per the Email Application Layout Guide, if I have
1340 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1342 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1343 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1344 which were empty, because these vfuncs have been removed from TnyAccountStore.
1345 This fixes the build.
1347 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1349 * src/maemo/modest-main-window.c:
1350 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1351 showing/hiding it. Added TODO because it probably should not be NULL.
1352 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1353 because unnecessary g_warnings() make degugging difficult.
1355 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1357 * src/maemo/modest-msg-edit-window.c:
1358 (modest_msg_edit_window_select_color),
1359 (modest_msg_edit_window_select_background_color): 2 const corrections and
1360 moving 2 #endifs before closing brackets, to fix the build.
1362 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1364 * src/maemo/easysetup/modest-easysetup-wizard.h:
1365 * src/maemo/easysetup/modest-easysetup-wizard.c:
1366 (modest_easysetup_wizard_dialog_finalize),
1367 (on_button_edit_advanced_settings), (create_page_complete_custom),
1368 (on_response), (create_account):
1369 Implement the Advanced Settings edit button, by saving the account information,
1370 for the Advanded Settings dialog to use directly from gconf, and removing it
1371 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1372 Bug #5533 in the projects.maemo.org bugzilla.
1374 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1376 * src/maemo/modest-msg-view-window.c:
1377 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1378 when opening a message window.
1380 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1382 * src/maemo/easysetup/modest-easysetup-wizard.c:
1383 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1386 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1387 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1388 gconf settings. I probably added more checks than necessary, but that is safer.
1390 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1391 variable to fix the build, but this seems to be used when it is still NULL.
1393 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1395 * src/modest-platform.h:
1396 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1397 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1398 * src/modest-main.c: Implement this function so we can avoid using
1399 maemo-specific API from cross-platform code.
1401 * src/modest-tny-account-store.c:
1402 (get_smtp_specific_transport_account_for_open_connection):
1403 * src/modest-ui-actions.c: (check_for_connection),
1404 (modest_ui_actions_on_item_not_found):
1405 Use modest_platform_connect_and_wait() and put #idefs around other
1406 maemo-specific code, because only maemo currently has a way to
1407 identify connection names.
1409 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1411 * src/modest-tny-account-store.h:
1412 * src/modest-tny-account-store.c:
1413 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1414 the connection-specific SMTP server settings in the configuration.
1416 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1418 * src/maemo/modest-main-window.c: (on_connection_changed),
1420 * src/modest-main.c: (main), (start_ui), (send_mail):
1421 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1422 that is what is intended.
1424 * src/modest-ui-actions.c: (action_send), (action_receive),
1425 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1426 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1427 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1428 SMTP server is used when it is specified.
1430 (modest_ui_actions_on_send_receive):
1431 Check that a connection is open before proceeding.
1432 Receive and then send, instead of vice-versa, as per the specification.
1434 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1436 * src/modest-mail-operation.c:
1437 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1438 though I guess it should be something other than NULL.
1440 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1442 * src/maemo/easysetup/modest-easysetup-wizard.c:
1443 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1444 combo twice, to avoid an g_warning and to make it visible again.
1445 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1446 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1447 (already intended) dereference when detaching, because we then recreate the menu.
1448 But I am not sure why the warning was happening, and it is possible that this is a memory
1451 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1453 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1454 and uri_parse_mailto() utility functions.
1455 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1457 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1459 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1461 * src/dbus_api/modest-dbus-api.h:
1462 * src/dbus_api/modest-dbus-callbacks.c:
1463 Use an idle callback to execute the modest code in the application's own thread.
1464 Remove the helloworld example method.
1465 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1466 parsed, and the open-message method is not implemented because this is not yet implemented in
1468 * libmodest-dbus-client/libmodest-dbus-client.c:
1469 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1470 (libmodest_dbus_client_open_message):
1471 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1473 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1474 body without crashing.
1476 * tests/dbus_api/Makefile.am:
1477 * tests/dbus_api/test_mail_to.c:
1478 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1480 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1482 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1483 Added file to fix the build. Sorry.
1485 * src/dbus_api/Makefile.am:
1486 * src/dbus_api/modest-dbus-api.h:
1487 * src/dbus_api/modest-dbus-callbacks.h:
1488 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1489 (modest_dbus_req_handler):
1490 Put constants in a separate header so it can be reused by the
1491 client library, without duplication
1493 * libmodest-dbus-client/Makefile.am:
1494 * libmodest-dbus-client/libmodest-dbus-client.c:
1495 (libmodest_dbus_client_call_helloworld),
1496 (libmodfest_dbus_client_send_mail),
1497 (libmodfest_dbus_client_mailto),
1498 (libmodfest_dbus_client_open_message):
1499 * libmodest-dbus-client/libmodest-dbus-client.h:
1500 (Partly) Implement a send_mail D-Bus method.
1502 * tests/dbus_api/Makefile.am:
1503 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1504 the send_email D-Bus method.
1506 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1510 * libmodest-dbus-client/Makefile.am:
1511 * libmodest-dbus-client/libmodest-dbus-client.c:
1512 * libmodest-dbus-client/libmodest-dbus-client.h:
1513 * tests/dbus_api/Makefile.am:
1514 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1515 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1517 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1519 * src/maemo/easysetup/modest-easysetup-wizard.c:
1520 (create_page_account_details):
1521 * src/maemo/modest-account-settings-dialog.c:
1522 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1523 widgets, because this might not be the default in future versions of the Maemo GTK+.
1524 However, I can not not get capitalization to work even in a simple test case.
1526 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1528 * src/maemo/easysetup/modest-easysetup-wizard.c:
1529 (create_page_custom_incoming), (create_page_custom_outgoing):
1530 * src/maemo/modest-account-settings-dialog.c:
1531 (create_page_account_details), (create_page_incoming),
1532 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1533 instead of using gtk_check_button_with_label(), so they are aligned like the other
1534 widgets, as per the UI spec.
1536 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1538 * src/maemo/easysetup/modest-easysetup-wizard.c:
1539 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1540 * src/widgets/modest-validating-entry.c:
1541 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1542 Modest prefix instead of an EasySetup prefix.
1544 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1546 * src/widgets/modest-validating-entry.h:
1547 * src/widgets/modest-validating-entry.c: (on_insert_text),
1548 Added easysetup_validating_entry_set_max_func(), used to set a callback
1549 to call when the max number of characters is reached. GtkEntry has a max-length
1550 already but is silent about it.
1552 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1553 (create_page_account_details), (create_page_user_details),
1555 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1556 (create_page_account_details), (create_page_user_details),
1557 (create_page_outgoing):
1558 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1559 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1560 the UI spec, when the user tries to enter more than the max number of characters.
1562 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1564 * src/maemo/easysetup/modest-easysetup-wizard.c:
1565 (create_page_user_details), (create_page_custom_incoming),
1566 (create_page_custom_outgoing):
1567 * src/maemo/modest-account-settings-dialog.c:
1568 (create_page_user_details), (create_page_incoming),
1569 (create_page_outgoing):
1570 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1571 (modest_connection_specific_smtp_edit_window_init):
1572 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1573 not appropriate. Bad Maemo-specific defaults!.
1575 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1577 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1578 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1579 (modest_signature_editor_dialog_set_settings):
1580 Disable the label and textview when the checkbox is disabled, and use the
1581 specified (UI spec) default signature text.
1583 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1585 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1586 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1588 * src/modest-defs.h:
1589 * src/modest-account-mgr-helpers.h:
1590 * src/modest-account-mgr-helpers.c:
1591 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1593 * src/maemo/Makefile.am:
1594 * src/maemo/modest-signature-editor-dialog.c:
1595 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1598 * src/maemo/modest-account-settings-dialog.h:
1599 * src/maemo/modest-account-settings-dialog.c:
1600 (modest_account_settings_dialog_finalize), (on_button_signature),
1601 (save_configuration): Use the new dialog when the Edit button is pressed, and
1602 save the changes if necessary, as per the UI spec.
1604 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1606 * src/maemo/Makefile.am:
1607 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1608 based on maemo-develoers email from Dirk.
1610 * src/maemo/easysetup/modest-easysetup-wizard.c:
1611 (create_page_welcome), (create_page_account_details),
1612 (create_page_user_details), (create_page_complete_easysetup),
1613 (create_page_custom_incoming), (create_page_custom_outgoing),
1614 (create_page_complete_custom),
1615 (modest_easysetup_wizard_dialog_init):
1616 * src/maemo/modest-account-settings-dialog.c:
1617 (create_page_account_details), (create_page_user_details),
1618 (create_page_incoming), (create_page_outgoing),
1619 (modest_account_settings_dialog_init):
1620 * src/maemo/modest-connection-specific-smtp-window.c:
1621 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1623 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1625 * src/maemo/easysetup/modest-easysetup-wizard.c:
1626 (create_page_account_details), (create_page_custom_outgoing),
1627 (create_page_complete_custom):
1628 * src/maemo/modest-account-settings-dialog.c:
1629 (create_page_user_details), (create_page_incoming),
1630 (create_page_outgoing):
1631 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1632 (modest_connection_specific_smtp_edit_window_init):
1633 Use the correct (UI spec) port min/max, and use horizontal separators,
1636 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1638 * src/maemo/easysetup/modest-easysetup-wizard.c:
1639 (set_default_custom_servernames):
1640 * src/maemo/modest-account-settings-dialog.c:
1641 (create_page_incoming), (on_combo_outgoing_security_changed),
1642 (on_combo_incoming_security_changed), (create_page_outgoing),
1643 (modest_account_settings_dialog_set_account_name),
1644 (save_configuration):
1645 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1646 (on_combo_security_changed),
1647 (modest_connection_specific_smtp_edit_window_init),
1648 (modest_connection_specific_smtp_edit_window_set_connection),
1649 (modest_connection_specific_smtp_edit_window_get_settings):
1650 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1653 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1656 * src/maemo/easysetup/modest-easysetup-wizard.c:
1657 (create_page_custom_outgoing), (create_page_complete_custom):
1658 * src/maemo/modest-account-settings-dialog.c:
1659 (create_page_user_details), (create_page_outgoing):
1660 * src/maemo/modest-account-view-window.c: (button_box_new):
1661 Use changed logical IDs as per the most recent UI spec:
1662 mcen_bd_emailsetup_edit -> mcen_bd_edit
1663 mcen_bd_emailsetup_delete -> mcen_bd_delete
1664 mcen_bd_emailsetup_close -> mcen_bd_close
1666 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1670 * src/dbus_api/Makefile.am:
1671 * src/dbus_api/modest-dbus-callbacks.c:
1672 * src/dbus_api/modest-dbus-callbacks.h:
1673 * src/maemo/modest-platform.c: (modest_platform_init):
1674 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1676 * tests/Makefile.am:
1677 * tests/dbus_api/Makefile.am:
1678 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1680 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1682 * src/maemo/modest-account-settings-dialog.c:
1683 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1684 Removed unnecessary includes.
1686 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1688 * src/maemo/easysetup/modest-easysetup-wizard.c:
1689 * src/maemo/modest-account-settings-dialog.c:
1690 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1691 * src/widgets/Makefile.am:
1692 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1693 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1694 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1695 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1696 * src/widgets/modest-secureauth-combo-box.c:
1697 * src/widgets/modest-secureauth-combo-box.h:
1698 * src/widgets/modest-serversecurity-combo-box.c:
1699 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1700 made the GObject names more consistent with the rest of the Modest code.
1702 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1704 * src/maemo/easysetup/Makefile.am:
1705 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1706 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1707 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1708 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1709 * src/maemo/easysetup/modest-easysetup-wizard.c:
1710 * src/maemo/easysetup/modest-validating-entry.c:
1711 * src/maemo/easysetup/modest-validating-entry.h:
1712 * src/maemo/modest-account-settings-dialog.c:
1713 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1714 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1715 widgets/ because they are used outside of easysetup too. After checking in,
1716 svn will allow me to rename them too.
1718 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1720 * src/gnome/modest-msg-edit-window.c:
1721 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1722 linker error, to fix the build on the GNOME platform.
1723 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1724 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1725 ifdefed out to avoid a warning.
1727 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1729 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1730 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1731 some alternative for GTK+ 2.6.
1733 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1735 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1737 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1738 specified for EmailAccountsDialog in UI spec.
1740 * src/maemo/easysetup/modest-easysetup-wizard.c:
1741 * src/maemo/easysetup/modest-easysetup-wizard.h:
1742 * src/maemo/modest-account-settings-dialog.c:
1743 * src/maemo/modest-account-settings-dialog.h:
1744 Reuse a member window widget for the connection-specific SMTP server accounts,
1745 so we can tell it to create/save the accounts only if we actually save changes.
1747 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1748 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1749 (modest_connection_specific_smtp_edit_window_get_settings):
1750 Return a struct instance for temporarily remembering the entered data.
1752 * src/maemo/modest-connection-specific-smtp-window.h:
1753 * src/maemo/modest-connection-specific-smtp-window.c:
1754 (modest_connection_specific_smtp_window_finalize),
1755 (modest_connection_specific_smtp_window_fill_with_connections),
1757 (modest_connection_specific_smtp_window_save_server_accounts),
1758 (update_model_server_names): Do not actually save data until asked,
1759 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1761 (on_selection_changed),
1762 (modest_connection_specific_smtp_window_init): Disable the edit
1763 button when nothing is selected.
1765 * src/modest-account-mgr-helpers.c:
1766 * src/modest-account-mgr-helpers.h:
1767 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1770 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1772 * src/modest-account-mgr-helpers.h:
1773 * src/modest-account-mgr-helpers.c:
1774 (modest_account_mgr_get_unused_account_name),
1775 (modest_account_mgr_get_unused_account_display_name): Added these
1776 utility functions, to avoid code duplication.
1778 * src/maemo/easysetup/modest-easysetup-wizard.c:
1779 (create_page_account_details), (create_account):
1780 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1781 (on_combo_security_changed),
1782 (modest_connection_specific_smtp_edit_window_init),
1783 (modest_connection_specific_smtp_edit_window_save_settings):
1784 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1785 * src/maemo/modest-connection-specific-smtp-window.c:
1786 (modest_connection_specific_smtp_window_finalize),
1787 (modest_connection_specific_smtp_window_fill_with_connections),
1788 (on_button_edit), (modest_connection_specific_smtp_window_init):
1789 * src/maemo/modest-connection-specific-smtp-window.h:
1790 Implementing saving of connection-specific server accounts.
1792 But I need to refactor this so we can save the data for each
1793 possible connection-specific account and only actually create the server accounts
1794 when the easysetup finished, or the OK button is pressed on the account settings
1797 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1799 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1800 (on_combo_security_changed):
1801 (modest_connection_specific_smtp_edit_window_init):
1802 Auto-fill the port number as in the account settings.
1804 (modest_connection_specific_smtp_edit_window_set_connection):
1805 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1806 * src/maemo/modest-connection-specific-smtp-window.c:
1807 (fill_with_connections), (on_button_edit),
1808 (modest_connection_specific_smtp_window_init):
1809 Turn the edit window into a dialog to simplify the code, and
1810 set a WM hint as in a GtkDialog, because only a popup can be on top of
1811 another window in Maemo, and popups usually have no WM decoration.
1813 * src/modest-defs.h:
1814 * src/modest-account-mgr-helpers.c:
1815 (modest_account_mgr_set_connection_specific_smtp),
1816 (modest_account_mgr_remove_connection_specific_smtp),
1817 (modest_account_mgr_get_connection_specific_smtp):
1818 * src/modest-account-mgr-helpers.h: Some functions to write the
1819 connection-specific SMTP server information. Not yet used.
1822 * src/widgets/modest-folder-view.c: (text_cell_data):
1823 Fix a warning about an uninitialized variable.
1824 (on_configuration_key_changed): Put an #ifdef around the use
1825 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1827 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1829 * src/maemo/modest-account-settings-dialog.h:
1830 * src/maemo/modest-account-settings-dialog.c:
1831 Added connect_for_modified() utility function to mark the new modified boolean.
1833 (create_page_account_details), (create_page_user_details),
1834 (create_page_incoming), (create_page_outgoing), (on_response),
1835 (modest_account_settings_dialog_init),
1836 (modest_account_settings_dialog_set_account_name):
1837 Only warn about unsaved changes when there are actually unsaved changes.
1839 * src/modest-account-mgr-helpers.c:
1840 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1841 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1842 to get the data from there in future.
1844 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1846 * src/modest-defs.h:
1848 * src/modest-account-mgr-helpers.h:
1849 * src/modest-account-mgr-helpers.c:
1850 Store the security account setting in a single conf key instead of using
1851 the options list, so that the list is left for just the to-be-removed camel hack,
1852 and because gconf_client_set_list() is failing for some reason.
1854 * src/modest-account-mgr.c:
1855 (modest_account_mgr_add_server_account):
1856 * src/maemo/modest-account-settings-dialog.c:
1857 (modest_account_settings_dialog_set_account_name),
1858 (save_configuration): Use the renamed functions.
1861 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1863 * src/widgets/Makefile.am:
1864 * src/widgets/modest-limit-retrieve-combo-box.c:
1865 * src/widgets/modest-limit-retrieve-combo-box.h:
1866 * src/widgets/modest-retrieve-combo-box.c:
1867 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1868 the account settings dialog.
1870 * src/modest-defs.h:
1871 * src/modest-account-mgr-helpers.h:
1872 * src/modest-account-mgr-helpers.c:
1873 (modest_server_account_get_option_secure_auth),
1874 (modest_server_account_set_option_secure_auth):
1875 * src/modest-account-mgr.c:
1876 (modest_account_mgr_add_server_account):
1877 Use the existing AUTH_MECH conf key for the secure-auth setting,
1878 instead of putting it in the list options, because this was actually used already.
1880 * src/maemo/modest-account-settings-dialog.c:
1881 (create_page_account_details),
1882 (modest_account_settings_dialog_set_account_name),
1883 (save_configuration):
1884 * src/maemo/modest-account-settings-dialog.h:
1885 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1886 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1888 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1890 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1891 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1892 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1894 * src/modest-defs.h:
1895 * src/maemo/modest-account-settings-dialog.c:
1896 (create_page_incoming), (on_combo_outgoing_security_changed),
1897 (on_combo_incoming_security_changed), (create_page_outgoing),
1898 (modest_account_settings_dialog_set_account_name),
1899 (save_configuration): Load/Save the port number, and change it when the
1900 security combo changes, to suitable defaults.
1902 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1904 * src/modest-account-mgr.c:
1905 (modest_account_mgr_add_server_account): Set the security and secure-auth
1906 options, and add a comment saying that the other camel-specific options should be
1909 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1911 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1913 * src/modest-tny-account-store.c: (account_list_free),
1914 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1915 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1918 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1920 * src/modest-protocol-info.c:
1921 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1922 is required by our UI spec. Maybe something in our implementation will use this eventually.
1923 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1924 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1925 instead of the previous 0 placeholder.
1927 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1928 secure-auth settings.
1929 * src/modest-account-mgr-helpers.h:
1930 * src/modest-account-mgr-helpers.c:
1931 (modest_server_account_data_get_option_secure_auth),
1932 (modest_server_account_set_option_secure_auth),
1933 (modest_server_account_data_get_option_security),
1934 (modest_server_account_set_option_security): Added this API for getting and setting the security
1935 and secure-auth settings.
1937 * src/maemo/modest-account-settings-dialog.h:
1938 * src/maemo/modest-account-settings-dialog.c:
1939 (modest_account_settings_dialog_finalize), (check_data),
1940 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1941 about changing titles.
1942 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1943 (save_configuration): Save the security and secure-auth settings.
1945 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1946 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1948 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1950 * src/modest-defs.h:
1951 * src/modest-account-mgr.c:
1952 (modest_account_mgr_add_server_account):
1953 Added and used defines for the options key and value pair strings,
1954 that are used so far, though they do not seem to correspond to anything in our
1955 UI specs or ModestProtocol enum.
1957 * src/modest-account-mgr-helpers.h:
1958 * src/modest-account-mgr-helpers.c:
1959 (compare_option_strings_for_name),
1960 (modest_server_account_data_get_option_value),
1961 (modest_server_account_data_get_option_bool),
1962 (modest_account_mgr_get_server_account_option):
1963 Added helper functions for parsing the options GSList.
1965 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1967 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1968 display name is based on the supplied account name.
1969 * src/modest-account-mgr.c:
1970 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1971 with an inefficient, but good-enough, implementation.
1973 * src/maemo/easysetup/modest-easysetup-wizard.c:
1974 (create_page_account_details), (on_before_next), (create_account):
1975 Check for existing display names rather than (non-user-visible) account names, and just
1976 create and set a unique account name at the end.
1978 * src/maemo/modest-account-settings-dialog.c:
1979 (modest_account_settings_dialog_init),
1980 (modest_account_settings_dialog_set_account_name),
1981 (create_page_incoming): Show the display name, instead of the account name.
1982 (on_response): Do some (not all) extra checks, as in the UI spec.
1983 (save_configuration): Save the display name if it was changed.
1985 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1987 * po/en_GB.po: Added needed logical ID and translation.
1988 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1989 (init_view): Made the is-default column clicking work.
1991 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1994 * src/maemo/easysetup/Makefile.am:
1995 * src/maemo/easysetup/modest-easysetup-wizard.c:
1996 (modest_easysetup_wizard_dialog_init):
1997 * src/maemo/easysetup/provider-data-test.keyfile:
1998 * src/maemo/easysetup/provider-data.keyfile:
1999 Moved the provider data file to the new modest-providers-data package and used it from there.
2001 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2003 * src/modest-local-folder-info.c:
2004 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2005 N_() was already used on the static strings, but this just marks it for translation without
2006 using the translation.
2008 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2010 * src/maemo/modest-account-settings-dialog.c:
2011 (create_page_incoming),
2012 (modest_account_settings_dialog_set_account_name):
2013 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2014 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2015 I will do this if nobody else gets there first.
2017 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2019 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2020 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2021 save the security stuff.
2023 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2025 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2026 Set the email address and user fullname, which I now see must be
2029 * src/maemo/modest-account-settings-dialog.h:
2030 * src/maemo/modest-account-settings-dialog.c:
2032 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2033 leave-on-server and authentication.
2034 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2037 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2040 * src/maemo/modest-account-settings-dialog.c:
2041 * src/maemo/modest-account-settings-dialog.h:
2042 Most (but not all) of the widgets are now present as specified by the UI spec.
2043 No changes are yet saved, and some details are not properly shown yet.
2045 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2047 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2049 * src/maemo/Makefile.am:
2050 * src/maemo/modest-account-settings-dialog.c:
2051 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2052 an existing account. Doesn't do much yet.
2054 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2055 Open the accounts settings dialog when Edit is clicked.
2057 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2059 * src/maemo/easysetup/Makefile.am:
2060 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2062 * src/maemo/easysetup/modest-easysetup-wizard.c:
2063 (modest_easysetup_wizard_dialog_init):
2064 Try to get the source directory from the build system,
2065 instead of hard-coding "./" into the source code, when opening our local
2066 copies of the configuration files.
2067 But this still fails when opening the wizard from the Accounts window,
2068 maybe because the working directory seems to change at runtime.
2069 So the wizard will fail the second time unless you copy the files into their
2070 proper locations - see the stdout warnings for the paths.
2072 (create_page_account_details),(on_before_next):
2073 Check for existing non-server accounts instead of server accounts,
2074 so the default account name is useful again, and to prevent trying to
2077 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2078 Show the wizard when New is clicked.
2080 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2081 (init_view): Show the column headers, and show the columns that are
2082 specified in the UI specs. However, something in Maemo's GTK+ prevents
2083 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2084 change the default account. This is despite unsetting the special properties.
2086 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2088 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2089 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2090 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2091 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2092 to make that clearer.
2093 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2095 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2097 * src/maemo/modest-account-view-window.c:
2098 (modest_account_view_window_init),
2099 (modest_account_view_window_new):
2100 Use the same buttons as specified in the
2101 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2102 the existing widgets, which never had a chance of working.
2103 Put the ModestAccountView treeview in a scrolled window.
2104 Do not repeat the initialization in both _init() and _new().
2106 * src/widgets/modest-account-view.c: (update_account_view):
2107 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2108 this widget and window shows no accounts.
2110 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2112 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/easysetup/modest-easysetup-wizard.c:
2115 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2116 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2117 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2120 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2121 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2122 accounts exist yet, as in the UI spec.
2124 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2126 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2128 * src/maemo/Makefile.am:
2129 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2130 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2131 New window for editing connection-specific smtp details.
2132 Not fully implemented.
2134 * src/maemo/modest-connection-specific-smtp-window.c:
2135 (modest_connection_specific_smtp_window_finalize) :
2136 unref the tree model.
2137 (on_button_edit): Show the edit window.
2139 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2141 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2144 * src/maemo/Makefile.am:
2145 * src/maemo/modest-connection-specific-smtp-window.c:
2146 * src/maemo/modest-connection-specific-smtp-window.h:
2147 New window for showing the list of connections, for connection-specific
2148 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2149 * src/maemo/easysetup/modest-easysetup-wizard.c:
2150 (create_page_custom_outgoing): Show the new window when the button is clicked.
2152 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2154 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2155 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2156 * src/maemo/modest-msg-edit-window.c:
2157 (modest_msg_edit_window_insert_image):
2158 * src/modest-conf.c: (modest_conf_key_escape):
2159 * src/modest-mail-operation.c:
2160 (modest_mail_operation_send_new_mail):
2161 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2162 (modest_ui_actions_on_new_account):
2163 * src/widgets/modest-attachment-view.c: (update_filename_request):
2164 * src/widgets/modest-mail-header-view.c:
2165 Corrected warnings that were breaking the build, by commenting out unused variables,
2166 and a function, and by including a header.
2168 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2170 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2171 so we can #ifdef around platform-specific code when necessary.
2172 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2173 to allow this to build for the GNOME platform too.
2175 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2177 * src/maemo/easysetup/modest-easysetup-wizard.c:
2178 Added util_increment_name() and used it in create_page_account_details()
2179 to make sure that the default account name is always a new name.
2181 (modest_easysetup_wizard_dialog_init),
2182 (set_default_custom_servernames): Some minor memory management fixes.
2184 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2188 * src/modest-runtime.c: (init_i18n): Restored the translation
2189 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2190 are defined in config.h, and the translations are installed.
2192 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2193 is defined for translation.
2195 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2197 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2199 * src/maemo/easysetup/modest-easysetup-wizard.c:
2200 (modest_easysetup_wizard_dialog_init):
2201 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2202 Use realistic paths (though they should use $prefix generically) to the
2203 mcc_mapping and provider-data.keyfile files which might work when they
2204 are installed by the future version of the operator-wizard package,
2205 and then fallback to paths in our source code, with an explanatory
2208 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2212 * src/maemo/Makefile.am:
2213 * src/maemo/easysetup/: Added files from the previously-exernal
2214 osso-modest-easysetup.
2215 * src/maemo/modest-main-window-ui.h:
2216 * src/modest-ui-actions.c:
2217 * src/modest-ui-actions.h:
2218 Added modest_ui_actions_on_new_account() as a signal handler for the
2219 New Account menu item. It shows the easysetup wizard.
2220 * po/en_GB.po: Added additional needed logical IDs and translations.
2222 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2223 Apparently ChangeLog is not used for some vague Nokia legal reasons.
projects / modest / blob