1 2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
3 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4 (load_from_file): Sort the list. The unsorted list would be more noticeable
5 in non-English locales.
7 * src/maemo/modest-msg-edit-window.c:
8 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
9 warning and fix the build.
11 * src/maemo/modest-progress-bar-widget.c:
12 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
13 avoid a g_warning, and probably to avoid a crash.
15 2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
17 * src/modest-search.c: (modest_search_folder): Check for a GError
18 when calling tny_folder_get_headers(), to show that this is not the cause
21 2007-06-20 Murray Cumming <murrayc@murrayc.com>
23 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
24 Actually set the body query instead of the subject query.
26 * src/modest-search.c: (search_mime_part_ogs),
27 (search_mime_part_strcmp): Remove extra space from the text/* regex,
28 which would probably cause it to fail if we got this far.
30 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
32 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
33 be causing search-in-body to fail.
35 2007-06-20 Murray Cumming <murrayc@murrayc.com>
37 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
39 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
40 Better debug message when the folder cannot be found.
41 This should help with fixing projects.maemo.org bug #61287.
42 * src/modest-search.c: (add_hit): Do not leak the furl string.
44 2007-06-20 Murray Cumming <murrayc@murrayc.com>
46 * src/modest-ui-actions.c:
47 (modest_ui_actions_on_folder_selection_changed):
48 Do not special-case TNY_MERGE_FOLDER here, because
49 modest_tny_folder_get_account() already does that. This fixes
50 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
51 shown when the Outbox was selected).
53 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
55 * libmodest-dbus-client/libmodest-dbus-client.c:
56 (_dbus_iter_get_string_or_null): Initialize the string variable in
57 case this helps with Dirk's crash.
59 2007-06-19 Murray Cumming <murrayc@murrayc.com>
61 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
62 though it is not implemented yet (this function is maybe not even used),
63 to avoid breaking ABI in future.
64 * libmodest-dbus-client/libmodest-dbus-client.c:
65 (get_attachments_string): Moved some code into this generic function.
66 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
67 sends email. It is maybe not used.
68 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
69 (on_send_mail): Use attachments.
71 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
72 * src/maemo/modest-msg-edit-window.c:
73 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
74 a filename before using it, to fix projects.maemo.org bug NB#58233.
76 2007-06-19 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
79 Initialize the continue_download variable to fix the build, and probably
80 to fix randome behaviour.
82 2007-06-18 Armin Burgmeier <armin@openismus.com>
84 * src/modest-tny-send-queue.h:
85 * src/modest-tny-send-queue.c: Keep track of the status of messages in
86 the queue so we can later show it in the UI. Replaced
87 modest_tny_send_queue_msg_is_being_sent() by
88 modest_tny_send_queue_get_msg_status().
90 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
92 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
93 gpointer. This probably was not harmful, but just to be sure.
95 2007-06-18 Murray Cumming <murrayc@murrayc.com>
97 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
98 Fix the build, but leave the function broken on Bora, because
99 hildon_uri_action_get_service() does not exist.
100 osso_uri_action_get_service() does not exist either, it seems.
102 2007-06-18 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-tny-account.c:
105 (modest_tny_account_new_from_server_account):
106 Uncommented the url debug output again, because it is useful for
107 debugging, as I said in the comment.
109 2007-06-18 Murray Cumming <murrayc@murrayc.com>
111 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
113 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
114 for Mameo Bora, to fix the build.
116 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
119 Fixed build with hildon < 0.99
121 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
122 Check if the selected account is busy instead of checking all accounts
124 * src/modest-account-mgr-priv.h:
125 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
126 (modest_account_mgr_init), (compare_account_name),
127 (modest_account_mgr_set_account_busy),
128 (modest_account_mgr_account_is_busy):
129 * src/modest-account-mgr.h:
130 Added busy information to the account manager. It possible to
131 set an account to busy or not busy now.
133 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
134 (modest_mail_operation_update_account),
135 (modest_mail_operation_notify_end):
136 Set the account to busy/not busy depending on the operation state.
138 * src/widgets/modest-account-view.c:
139 (modest_account_view_finalize), (get_last_updated_string),
140 (update_account_view), (on_account_busy_changed), (init_view):
141 Show string "Refreshing..." if the account is currently busy.
143 All this fixes projects.maemo.org bug NB#59711
145 2007-06-14 Armin Burgmeier <armin@openismus.com>
147 * src/widgets/modest-attachments-view.h:
148 * src/widgets/modest-attachments-view.c: Added
149 modest_attachments_view_has_attachments() and fixed coordinate
150 transformation in get_att_view_at_coords(). This fixes attachment
153 * src/widgets/modest-msg-view.c: Make use of
154 modest_attachments_view_has_attachments() to decide whether to show
155 attachments in the header.
157 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
159 * src/maemo/modest-connection-specific-smtp-edit-window.c:
160 (on_change), (on_combo_security_changed),
161 (modest_connection_specific_smtp_edit_window_init),
162 (modest_connection_specific_smtp_edit_window_set_connection),
163 (modest_connection_specific_smtp_edit_window_is_dirty):
164 * src/maemo/modest-connection-specific-smtp-edit-window.h:
165 * src/maemo/modest-connection-specific-smtp-window.c:
168 Show an comfirmation dialog for the smpt-edit-window if there are
169 unsaved changes and the user hits cancel.
170 (projects.maemo.org bug NB#60479)
172 2007-06-14 Armin Burgmeier <armin@openismus.com>
174 * src/maemo/easysetup/modest-easysetup-wizard.c:
175 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
176 address" info in banner instead of node, and select all the text as
177 per UI spec. This fixes projects.maemo.org bug NB#60550.
179 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
181 reviewed by: <delete if not using a buddy>
183 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
184 * src/modest-ui-actions.c: (folder_refreshed_cb):
186 2007-06-14 Murray Cumming <murrayc@murrayc.com>
188 * src/widgets/modest-folder-view.c: (filter_row):
189 Explictly filter out the per-account outbox accounts. I don't know why
190 these only sometimes show up, but now they should never show up in the UI.
191 This should fix projects.maemo.org bug NB#60160.
193 2007-06-14 Murray Cumming <murrayc@murrayc.com>
195 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
196 when the toolbar does not exist yet.
197 * src/modest-widget-memory.c: (save_settings_header_view):
198 Added g_warnings() to help us to discover when we are trying to set
199 an empty columns list in gconf.
201 2007-06-14 Murray Cumming <murrayc@murrayc.com>
205 Added modest_init_get_default_header_view_column_ids().
207 * src/modest-widget-memory.c: (restore_settings_header_view):
208 Use the new function to get defaults, if the gconf key is empty,
209 instead of not creating any columns. This seems to fix the
210 empty right-hand pane problems.
212 * src/widgets/modest-header-view.h: Improved documentation.
214 2007-06-13 Murray Cumming <murrayc@murrayc.com>
216 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
217 Revert the use of the display name as the account name, because this
218 is generally wrong and would break the code that follows.
220 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
222 * src/maemo/easysetup/modest-easysetup-wizard.c:
223 (check_for_supported_auth_methods), (on_before_next),
226 More correct fix for projects.maemo.org bug NB# 58991
227 Do not longer accept AUTH_PASSWORD as secure method and choose
228 correct method when creating the account.
230 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
232 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
233 Fixed projects.maemo.org bug NB# 58991
235 2007-06-13 Murray Cumming <murrayc@murrayc.com>
237 * src/modest-init.c: (modest_init_init_core),
238 (modest_init_local_folders): Fixed compilation errors.
240 2007-06-13 Murray Cumming <murrayc@murrayc.com>
242 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
243 Remove unnecessary lib/include, though it is good in principle when needed.
245 * src/modest-init.c: (modest_init_one_local_folder),
246 (modest_init_local_folders):
247 * src/modest-init.h: Initialize the .modest library for memory cards,
248 instead of just doing nothing for them. This should allow us to create
249 folders there, fixing projects.maemo.org bug NB#59297.
251 2007-06-13 Murray Cumming <murrayc@murrayc.com>
253 * libmodest-dbus-client/libmodest-dbus-client.c:
254 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
255 (libmodest_dbus_client_compose_mail),
256 (libmodest_dbus_client_open_message),
257 (libmodest_dbus_client_send_and_receive),
258 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
260 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
261 (on_idle_open_message), (modest_dbus_req_handler),
262 (search_result_to_message), (modest_dbus_req_filter):
263 * src/modest-search.c: (add_hit), (modest_search_folder),
264 (modest_search_all_accounts): Improved debug messages.
266 * tests/dbus_api/test_open_message.c: (main): Improved comments.
268 * src/modest-tny-account-store.c:
269 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
272 2007-06-13 Murray Cumming <murrayc@murrayc.com>
275 2007-06-12 Murray Cumming <murrayc@murrayc.com>
277 * src/modest-tny-account-store.c: (get_server_accounts):
278 Call modest_tny_local_folders_account_add_merged_outbox_folders()
279 even when there are no accounts, so that the Outbox folder is always
280 visible. This fixes projects.maemo.org bug NB#60158.
282 2007-06-12 Murray Cumming <murrayc@murrayc.com>
284 * src/maemo/modest-main-window.c: (create_details_widget):
285 Use the mcen_va_never logical ID.
287 2007-06-12 Murray Cumming <murrayc@murrayc.com>
289 * src/dbus_api/modest-dbus-api.h:
290 * src/dbus_api/modest-dbus-callbacks.c:
291 (on_idle_open_default_inbox), (on_open_default_inbox),
292 (modest_dbus_req_handler):
293 Added a new OpenDefaultInbox method.
295 * libmodest-dbus-client/libmodest-dbus-client.h:
296 * libmodest-dbus-client/libmodest-dbus-client.c:
297 Added libmodest_dbus_client_open_default_inbox() to call the new
298 dbus method. This should be useful to projects.maemo.org bug NB#57214,
299 though it should maybe be used by a new osso-email-interface function.
301 * tests/dbus_api/Makefile.am:
302 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
305 2007-06-12 Murray Cumming <murrayc@murrayc.com>
307 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
308 NULL, so that the signals get all the keys. This should not actually
309 change any behaviour because we currently update everything when anything
312 2007-06-12 Murray Cumming <murrayc@murrayc.com>
314 * src/widgets/modest-folder-view.c: (text_cell_data),
315 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
316 (find_inbox_iter): If tinymail tells us that the folder is
317 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
318 This causes the inbox to be selected at startup, fixing part of
319 projects.maemo.org bug NB#56305.
321 * src/modest-ui-dimming-rules.c:
322 (modest_ui_dimming_rules_on_tools_smtp_servers):
323 * src/modest-ui-dimming-rules.h: Added a callback function to dim
324 the SMTP servers menu item.
325 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
326 that the SMTP Servers menu item is dimmed when there are no accounts,
327 as a future version of the UI spec will require. This fixes
328 projects.maemo.org bug NB#56305.
330 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
332 * src/maemo/modest-maemo-utils.c:
333 (modest_maemo_utils_get_supported_secure_authentication_methods):
334 Added label to dialog instead of unreadable title
336 * src/maemo/modest-main-window.c: (sync_accounts_cb),
337 (modest_main_window_new):
338 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
341 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
342 * src/modest-account-mgr.h:
343 Added method to avoid code duplication
345 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
346 (modest_ui_actions_on_send_receive):
347 Use modest_account_mgr_has_accounts
349 2007-06-11 Murray Cumming <murrayc@murrayc.com>
351 * src/maemo/easysetup/modest-presets.c:
352 (modest_presets_get_info_server_security): Do not report secure auth
354 * src/modest-protocol-info.c: Use the defines for the gconf key names
355 for secure authentication. This was not working because we were writing
356 Password and reading password, and the check was case sensitive.
357 With this, gmail now works for receiving and sending when created via
360 2007-06-11 Murray Cumming <murrayc@murrayc.com>
362 * src/maemo/easysetup/modest-presets.c:
363 (modest_presets_get_info_server_security): Correct the key name for
364 SecureSmtp, because it seems to be case-sensitive.
365 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
366 Do not try to get the 0th notebook page if there are 0 pages, to
369 2007-06-11 Murray Cumming <murrayc@murrayc.com>
371 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
372 Prevent use of the new notification feature for now, because it currently
373 shows one dialog for each new email, which is annoying.
375 2007-06-11 Murray Cumming <murrayc@murrayc.com>
377 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
378 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
379 when no country was selected, so that we show the global ones.
380 * src/maemo/easysetup/modest-presets.c:
381 (modest_presets_get_providers): Return only the global providers, not
382 all providers when mmc=0 was requested.
384 2007-06-11 Murray Cumming <murrayc@murrayc.com>
386 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
387 (easysetup_provider_combo_box_fill): Remove debug code that showed the
388 provider ID in the combo.
390 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
391 Do not show the page numbers, because it would be confusing when we add
392 the 2 extra pages for the custom setup, when the user chooses the "Other"
393 provider. This fixes projects.maemo.org bug NB#59028
395 * src/modest-init.c: (modest_init_init_core),
396 (modest_init_local_folders):
398 * src/modest-tny-account.c:
399 (modest_tny_account_new_for_local_folders): Do not create default folders
400 for the memory card. This should fix projects.maemo.org bug NB#59328.
402 2007-06-11 Murray Cumming <murrayc@murrayc.com>
404 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
405 Free the changed_conf_keys string items. They are already freed in the
406 idle handler if that runs first.
408 2007-06-11 Murray Cumming <murrayc@murrayc.com>
410 * src/modest-ui-actions.c:
411 (modest_ui_actions_on_password_requested): Check that the server name
412 is not NULL, because I just saw a password dialog with (null) as the
415 * src/modest-tny-folder.[h|c]: Added
416 modest_tny_folder_is_memory_card_folder().
417 * src/modest-ui-dimming-rules.c:
418 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
419 menu item for memory cards, as per the UI spec (section 7.4). This should
420 fix projects.maemo.org bug NB#59297.
422 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
424 * src/maemo/modest-main-window.c: (sync_accounts_cb):
425 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
426 is another problem with the code, see Murray's comment at line 772)
428 2007-06-08 Murray Cumming <murrayc@murrayc.com>
430 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
431 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
432 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
433 (load_from_file), (easysetup_country_combo_box_init),
434 (easysetup_country_combo_box_get_active_country_ids),
435 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
436 instead of just one ID, to avoid duplicate country names in the UI.
438 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
439 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
440 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
441 a single ID, avoiding duplicate providers.
442 * src/maemo/easysetup/modest-easysetup-wizard.c:
443 (on_combo_account_country): Adapt to use a list.
445 2007-06-08 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
448 keys changed in the last X seconds.
450 * src/modest-account-mgr.h:
451 * src/modest-account-mgr.c: (on_timeout_notify_changes),
452 (on_key_change), (modest_account_mgr_class_init),
453 (modest_account_mgr_init), (modest_account_mgr_finalize):
454 As the keys are changed, save them in a GSList* and signal that GSList*
455 further every X seconds, to batch changes, to allow us to do just one
456 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
457 bug NB#56941 and other (UI-blocking) delays when changing account settings.
459 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
460 changed signal signature.
462 * src/modest-conf.c: (modest_conf_set_list),
463 (modest_conf_on_change): Reenable notification.
465 (modest_conf_maemo_fake_on_change): Comment out the hack that
466 notified immediately instead of asynchronously.
468 * src/widgets/modest-account-view.h:
469 * src/widgets/modest-account-view.c:
470 (update_account_view): Select the previously-selected account ID,
471 if possible. This fixes projects.maemo.org bug NB#56933.
473 (on_account_changed), (on_account_removed),
474 (modest_account_view_select_account):
476 Remove the block/unblock functions
477 because they were not useful.
479 * src/maemo/modest-account-view-window.c:
480 (on_delete_button_clicked), (on_edit_button_clicked),
481 (on_new_button_clicked): Remove the use of the non-working block/unblock.
483 2007-06-08 Murray Cumming <murrayc@murrayc.com>
485 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
486 Improve the error dialog to show Incorrect Account Settings, which seems
487 clearer, and say that the internal error message (to be removed from the
488 dialog later) is often misleading.
489 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
491 * src/modest-tny-account.c:
492 (modest_tny_account_new_from_server_account): Uncomment the printf of the
493 URL because this is so useful for debugging on the device.
495 * src/widgets/modest-serversecurity-combo-box.c:
496 (modest_serversecurity_combo_box_fill): Correct a logical ID.
498 2007-06-08 Murray Cumming <murrayc@murrayc.com>
500 * src/modest-mail-operation.c:
501 (modest_mail_operation_send_new_mail):
502 Added a comment about a nasty but apparently harmless message. Details
503 added to the wiki g_warnings() page.
505 2007-06-08 Murray Cumming <murrayc@murrayc.com>
507 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
508 (modest_tny_send_queue_class_init):
509 Do not use the priv struct because it is empty, to avoid g_warnings
510 about a non-existant priv struct.
512 * src/modest-tny-account-store.c:
513 (modest_tny_account_store_get_server_account),
514 (modest_tny_account_store_get_transport_account_for_open_connection
515 ): Do not try to get transport server accounts for local folders,
516 because they don't have any. This avoids a g_warning().
518 * src/maemo/modest-main-window.c:
519 (modest_main_window_notify_send_receive_initied),
520 (on_configuration_key_changed):
521 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
523 * src/modest-mail-operation.c:
524 (modest_mail_operation_update_account):
525 * src/modest-tny-account-store.h:
526 * src/modest-tny-account.c:
527 (modest_tny_account_get_special_folder),
528 (modest_tny_account_new_for_local_folders),
529 (modest_tny_account_new_for_per_account_local_outbox_folder):
530 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
531 * src/modest-tny-local-folders-account.c:
532 (add_account_folders_to_merged_folder):
533 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
534 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
535 (modest_ui_actions_on_send):
536 * src/widgets/modest-folder-view.c: (update_model):
537 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
538 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
539 modest_tny_account_store_get_tny_account_by_account() to
540 modest_tny_account_store_get_server_account() to make the code clearer.
542 2007-06-07 Marcus Bauer <marcusb@openismus.com>
544 * src/dbus_api/modest-dbus-api.h:
545 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
546 * src/maemo/modest-msg-edit-window.c:
547 (modest_msg_edit_window_attach_file_noninteractive):
548 added g_warning in case the file to be attached does not exist
549 * tests/dbus_api/test_compose_mail.c: (main):
550 removed obsolete comment, added generic files as test case
552 2007-06-07 Murray Cumming <murrayc@murrayc.com>
554 * src/modest-tny-account-store.c: (get_server_accounts):
555 Create the local folders account only once, not once for each outbox, and
556 not only when there are some outboxes.
558 2007-06-07 Murray Cumming <murrayc@murrayc.com>
560 * src/widgets/modest-folder-view.c: (update_model): Comment out some
561 code that is causing a crash at startup. Sergio says that he is fixing this.
563 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
565 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
566 * src/maemo/modest-account-settings-dialog.c:
567 (create_page_outgoing),
568 (modest_account_settings_dialog_set_account_name),
569 (save_configuration):
570 - Fixed handling of the "Use secure authentication" toggle to comply with
571 the ui specification. See also projects.maemo.org bug NB#58400
573 - Restore the Secure connection setting combo correctly when loading
576 * src/maemo/modest-maemo-utils.c:
577 (on_camel_account_get_supported_secure_authentication),
578 (modest_maemo_utils_get_supported_secure_authentication_methods):
579 Fixed a crasher if operation is canceled
581 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
582 (modest_protocol_info_auth_is_secure):
583 * src/modest-protocol-info.h:
585 Added two new methods to determine if a protocol/auth method is secure/encrypted in
586 the sense of the "Use secure authentication" toggle.
588 2007-06-07 Murray Cumming <murrayc@murrayc.com>
590 * src/modest-tny-account-store.h:
591 * src/modest-tny-account-store.c:
592 Added modest_tny_account_store_get_local_folders_account().
594 * src/modest-tny-folder.h:
595 * src/modest-tny-folder.c:
596 (modest_tny_folder_get_account):
597 Added this replacement for tny_folder_get_account() which returns
598 the local-folders account for TnyMergeFolders, to avoid the
599 warning about the unimplemented get_account_func() vfunc().
601 (modest_tny_folder_get_rules),
602 * src/modest-ui-actions.c:
603 (modest_ui_actions_on_folder_selection_changed):
604 * src/modest-mail-operation.c:
605 (modest_mail_operation_remove_folder),
606 (modest_mail_operation_xfer_folder),
607 (modest_mail_operation_rename_folder),
608 (modest_mail_operation_get_msg),
609 (modest_mail_operation_get_msgs_full),
610 (modest_mail_operation_remove_msg),
611 (modest_mail_operation_xfer_msgs),
612 (modest_mail_operation_refresh_folder):
613 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
615 2007-06-07 Murray Cumming <murrayc@murrayc.com>
617 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
618 (modest_server_account_set_security):
619 * src/modest-defs.h: Add comments explaining that our
620 UI spec means TLS when it says Normal, so these do not look like errors.
622 * src/modest-tny-account.c:
623 (modest_tny_account_new_from_server_account): Use the new tinymail
624 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
625 for TLS. This should fix projects.maemo.org bug NB#58460.
627 2007-06-06 Murray Cumming <murrayc@murrayc.com>
629 * src/maemo/easysetup/modest-easysetup-wizard.c:
630 (create_account): Correct the position of the gconf sanity check warning.
631 (on_button_edit_advanced_settings): Show the dialog immediately, instead
632 of using the g_idle_add() hack, because this does not seem to be necessary
633 on osso 1.1. It might even work on Maemo Bora if the problems were actually
634 caused by something other than maemo's gconf.
635 This fixes projects.maemo.org bug #59022.
637 2007-06-06 Murray Cumming <murrayc@murrayc.com>
639 * src/modest-account-mgr-helpers.c:
640 (modest_account_mgr_get_default_account): Do not check that the account
641 exists if there is no default account (NULL), to fix a runtime warning.
643 2007-06-06 Murray Cumming <murrayc@murrayc.com>
645 * src/widgets/modest-folder-view.c: (update_model):
646 Do not unref the treemodel before we have finished with it.
647 This prevents a valgrind warning and an occasional crash at startup.
649 2007-06-06 Marcus Bauer <marcusb@openismus.com>
651 * libmodest-dbus-client/libmodest-dbus-client.h:
652 added libmodest_dbus_client_compose_mail()
653 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
655 added functions needed for SendAsMail() functionality
656 * src/maemo/modest-msg-edit-window.c:
657 (modest_msg_edit_window_attach_file_noninteractive):
658 non interactively attaching files to message edit window
659 * src/widgets/modest-msg-edit-window.h:
660 * tests/dbus_api/Makefile.am:
661 added test_compose_mail.c
662 * tests/dbus_api/test_compose_mail.c: (main):
664 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
666 * src/modest-account-view.c:
667 Fixed bug projects.maemo.org bug NB#59307
669 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
671 * src/maemo/easysetup/modest-easysetup-wizard.c:
672 (get_serverport_incoming), (on_before_next), (create_account):
673 * src/maemo/modest-account-settings-dialog.c:
674 (modest_account_settings_dialog_set_account_name):
675 * src/maemo/modest-maemo-utils.c:
676 (on_camel_account_get_supported_secure_authentication_status),
677 (on_camel_account_get_supported_secure_authentication),
678 (on_secure_auth_cancel),
679 (modest_maemo_utils_get_supported_secure_authentication_methods):
681 Implemented security authentication for settings and easysetup.
683 2007-06-05 Murray Cumming <murrayc@murrayc.com>
685 * src/maemo/modest-main-window.c: (create_details_widget):
686 Show the total size for memory card accounts too, instead of showing
687 the name again. Fixes bug projects.maemo.org bug NB#59307.
689 2007-06-05 Murray Cumming <murrayc@murrayc.com>
692 * src/modest-tny-simple-folder-store.c:
693 * src/modest-tny-simple-folder-store.h: Removed.
695 * src/modest-tny-local-folders-account.h
696 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
697 for the local-folders maildir, with an extra TnyMergedFolder containing
698 the folders of the per-account outbox store accounts.
699 * src/modest-tny-account-store.c: (get_server_accounts):
700 Add the outboxes to the special local folders account after creating it.
702 * src/modest-tny-account.c:
703 (modest_tny_account_new_for_local_folders): Create the derived
704 account when creating the main local-folders account.
706 * src/maemo/modest-main-window.c: (create_details_widget),
707 (modest_main_window_set_contents_style):
708 Adapted to the use of the derived account instead of the folder store.
710 * src/modest-ui-actions.c:
711 (modest_ui_actions_on_folder_selection_changed):
712 * src/modest-ui-dimming-rules.c:
713 (modest_ui_dimming_rules_on_new_folder):
714 * src/widgets/modest-folder-view.c: (text_cell_data),
715 (icon_cell_data), (filter_row), (update_model),
716 (get_cmp_rows_type_pos):
719 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
720 Do not get the priv struct, because no priv struct has been set,
721 to avoid a runtime warning.
723 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
724 #ifelse with #else, to fix a warning, to fix the build.
727 2007-06-05 Christian Kellner <ckellner@openismus.com>
729 * libmodest-dbus-client/libmodest-dbus-client.c:
730 Fix small typo in doc (why do you always see them
731 AFTER committing stuff?)
734 2007-06-05 Christian Kellner <ckellner@openismus.com>
736 * libmodest-dbus-client/libmodest-dbus-client.c:
737 (libmodest_dbus_client_search):
738 Initialize hit list with NULL. Also set folder list
739 to "" if NULL was supplied.
742 2007-06-03 Christian Kellner <ckellner@openismus.com>
744 * libmodest-dbus-client/libmodest-dbus-client.c:
745 (modest_search_hit_list_free):
746 Make it save to call it with NULL.
748 * src/dbus_api/modest-dbus-callbacks.c:
749 * src/modest-search.c:
750 Return full ModestSearchHits as the search result list not TnyHeader
751 since can't be around withouth the correspoding TnyFolder.
753 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
755 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
756 Added currently commented code to check for secure auth
758 * src/maemo/modest-account-settings-dialog.c: (on_response),
759 (save_configuration), (show_ok):
760 Fixed projects.maemo.org bugs NB #59248 and #59251
762 * src/maemo/modest-maemo-utils.c:
763 (on_camel_account_get_supported_secure_authentication_status),
764 (on_camel_account_get_supported_secure_authentication),
765 (modest_maemo_utils_get_supported_secure_authentication_methods):
766 * src/maemo/modest-maemo-utils.h:
767 Moved get_supported_secure_authentication() method here to be able
768 to use it from easysetup wizard.
770 * src/modest-pair.c: (on_pair_compare_as_string):
771 Should compare string with first part of pair and not
772 strcmp pairs which will crash.
774 * src/modest-protocol-info.c:
775 (modest_protocol_info_protocol_is_store):
776 * src/modest-protocol-info.h:
777 Added modest_protocol_info_get_auth_protocol_name()
779 2007-06-03 Armin Burgmeier <armin@openismus.com>
781 * src/modest-mail-operation.c:
782 (modest_mail_operation_get_msgs_full): Set priv->account also when
783 only retrieving a single message. This avoids a crash when canceling
786 (modest_mail_operation_notify_end): Do not explicitely remove the
787 operation from the queue but only emit the progress_changed signal.
788 The queue itself listens to that signal to remove the operation when
789 it is finished. This reduces coupling and removes a potential deadlock
790 when modest_mail_operation_notify_end() is called from the queue
791 itself. If that is a problem performance-wise, I would suggest to
792 implement a status-changed signal or something.
794 * src/modest-mail-operation-queue.c: Make sure to never call a
795 function from another file while the queue is locked. This (hopefully)
796 fixes another deadlock when exiting the application while retrieving
799 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
801 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
802 Fixed build if libogs is not available
804 2007-06-03 Christian Kellner <ckellner@openismus.com>
806 * libmodest-dbus-client/libmodest-dbus-client.h:
807 * libmodest-dbus-client/libmodest-dbus-client.c:
808 (libmodest_dbus_client_delete_message):
809 Implement deletion of messages (Client side).
811 (modest_search_hit_free),
812 (modest_search_hit_list_free):
813 Utility functions to free the result hits.
815 * src/dbus_api/modest-dbus-api.h:
816 * src/dbus_api/modest-dbus-callbacks.c:
818 (modest_dbus_req_handler):
819 Implement deletion of messages (Server side).
821 * tests/dbus_api/test_search.c: (main):
824 * tests/dbus_api/Makefile.am:
825 * tests/dbus_api/test_delete_message:
826 Add little test for the message deletion logic
828 2007-06-03 Armin Burgmeier <armin@openismus.com>
830 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
831 when the operation queue was not empty. projects.maemo.org bug
834 2007-06-03 Armin Burgmeier <armin@openismus.com>
836 * src/widgets/modest-account-view.c
837 (on_account_default_toggled): Toggle default account column
838 explicitely instead of waiting for gconf notification (which is
839 currently ignored). This should fix projects.maemo.org bug NB#56910
840 for now. It should probably be removed when gconf notifications are
843 2007-06-03 Christian Kellner <ckellner@openismus.com>
845 * libmodest-dbus-client/libmodest-dbus-client.c:
846 Removed debugging spew.
848 * src/dbus_api/modest-dbus-callbacks.c:
849 Added debugging info.
851 * src/modest-search.c:
852 (modest_search_all_accounts):
853 Use tny_account_store_get_accounts () on the account store
854 to get all accounts which is the way to get all accounts.
856 * tests/dbus_api/test_search.c: (main):
857 Make it possible to supply the search term on the command line.
859 2007-06-03 Christian Kellner <ckellner@openismus.com>
861 * libmodest-dbus-client/libmodest-dbus-client.c:
862 * libmodest-dbus-client/libmodest-dbus-client.h:
863 Implement searching for mesages over raw dbus. (Client side)
865 * src/dbus_api/Makefile.am:
866 * src/dbus_api/modest-dbus-api.h:
867 * src/dbus_api/modest-dbus-callbacks.c:
868 * src/dbus_api/modest-dbus-callbacks.h:
869 Search framework (Server side). Also implement on_idle_open_message().
871 * src/maemo/modest-platform.c: (modest_platform_init):
872 Prepare for raw dbus/osso rpc interaction.
874 * src/modest-search.h:
875 Changed minsize from unspecific guint to guint32.
877 * src/modest-search.c:
879 Added strange hack which magically made tnymail work.
881 (modest_search_folder),
882 (modest_search_account),
883 (modest_search_all_accounts):
884 Implement helper functions to search all accounts, specific account
887 * tests/dbus_api/Makefile.am:
888 * tests/dbus_api/test_open_message.c:
889 Read url to open from commandline.
891 * tests/dbus_api/test_search.c:
892 Implement small test for dbus search stuff
894 2007-06-02 Armin Burgmeier <armin@openismus.com>
896 * src/maemo/modest-account-settings-dialog.c: Changed window title to
897 include account type and account title. This fixes projects.maemo.org
900 * src/maemo/modest-account-view-window.c: Set a title for the window.
902 2007-06-02 Armin Burgmeier <armin@openismus.com>
904 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
905 incoming and outgoing server name based on email address and server
906 types as long as the names have not been edited manually. This fixes
907 projects.maemo.org bug NB#58671.
909 2007-06-02 Armin Burgmeier <armin@openismus.com>
911 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
912 server type cannot be changed in future to the incoming details page
913 when creating an account. This fixes projects.maemo.org bug NB#59029.
915 2007-06-02 Armin Burgmeier <armin@openismus.com>
917 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
918 and assigned max width chars so that they wrap instead of being
919 truncated. Fixes projects.maemo.org bug NB#56126.
921 2007-06-02 Armin Burgmeier <armin@openismus.com>
923 * src/maemo/modest-connection-specific-smtp-window.c: Add an
924 introductory note to the connection specific smtp servers dialog, as
925 section 8.12 of the email UI specification requires. This fixes
926 projects.maemo.org bug NB#59212.
928 2007-06-01 Murray Cumming <murrayc@murrayc.com>
930 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
931 Check for running mail operations, and offer to cancel them, as per the UI
932 spec. This fixes projects.maemo.org bug NB#59041 .
933 However, I suspect that tinymail may still use the network connection
934 in ways that we cannot detect or cancel. But it should at least adapt to
937 2007-06-01 Murray Cumming <murrayc@murrayc.com>
939 * src/modest-tny-account-store.c: (recreate_all_accounts),
940 (get_cached_accounts), (get_server_accounts): Do more sensible
941 ref-counting of the temporarily-cached outbox accounts list. This seems
942 to fix a crash when entering the password when the password was wrong.
944 2007-06-01 Murray Cumming <murrayc@murrayc.com>
946 * src/gnome/modest-main-window.c: (connect_signals):
947 * src/modest-tny-account-store.c: (get_password),
948 (modest_tny_account_store_alert): Added comments and clues and
949 commented-out code about how we currently fail to deal with connection
950 errors and wrong passwords, and how we should.
952 2007-06-01 Murray Cumming <murrayc@murrayc.com>
954 * src/widgets/modest-retrieve-combo-box.c:
955 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
956 This fixes projects.maemo.org bug NB#58472 .
958 2007-06-01 Murray Cumming <murrayc@murrayc.com>
960 * src/maemo/easysetup/modest-easysetup-wizard.c:
961 (create_page_complete_easysetup):
962 (create_page_complete_custom): Correct the last commit,
963 putting the correct sentences in the correct pages.
965 2007-06-01 Murray Cumming <murrayc@murrayc.com>
967 * src/maemo/easysetup/modest-easysetup-wizard.c:
968 (create_page_complete_custom): Show the second sentence of text
969 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
972 2007-06-01 Murray Cumming <murrayc@murrayc.com>
974 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
975 Set the leave-on-server conf key by default. This fixes
976 projects.maemo.org bug NB#59258 .
978 2007-06-01 Murray Cumming <murrayc@murrayc.com>
980 * src/maemo/modest-account-view-window.c:
981 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
982 logical ID for the confirmation messages. Fixed projects.maemo.org bug
985 2007-06-01 Murray Cumming <murrayc@murrayc.com>
987 * src/maemo/easysetup/modest-easysetup-wizard.c:
988 (create_caption_new_with_asterisk):
989 * src/maemo/modest-account-settings-dialog.c:
990 (create_caption_new_with_asterisk):
991 Uncomment the code to add the asterisk, because they are no longer in the
992 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
993 (update_incoming_server_title): Add an asterisk here too.
995 2007-06-01 Murray Cumming <murrayc@murrayc.com>
997 * src/maemo/modest-maemo-global-settings-dialog.c:
998 (current_connection): Check that we are even connected before trying to
999 get the current connection name, to prevent a warning.
1001 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1002 Change the comments because tny_maemo_conic_device_connect() is now meant to
1004 * src/modest-mail-operation.c:
1005 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1006 make sure we have a connection and fail if we can't connect.
1008 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1010 * src/maemo/modest-main-window.c:
1011 (on_account_store_connecting_finished): Do not try to get the
1012 connection ID if we are not really connected. I am surprised that
1013 this signal handler is called when we are not connected.
1015 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1017 * src/modest-error.h:
1018 * src/modest-ui-actions.c:
1019 (modest_ui_actions_get_msgs_full_error_handler):
1020 Renamed an enum, added comments, added an enum
1021 for retrieve-limit errors.
1023 * src/modest-mail-operation.c: (foreach_add_item),
1024 (internal_folder_observer_update), (update_account_thread),
1025 (modest_mail_operation_get_msgs_full):
1026 (modest_mail_operation_update_account),
1027 Added comments about how this works, and some code that should
1028 (but does not) check the retrieve-limit. See the TODO comment.
1030 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1032 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1033 Initialize help_id to fix the build. Warnings are good.
1035 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1037 * src/widgets/modest-hbox-cell-renderer.c:
1038 (modest_hbox_cell_renderer_append):
1039 * src/widgets/modest-vbox-cell-renderer.c:
1040 (modest_vbox_cell_renderer_append):
1041 Fix the last commit by doing an extra ref.
1043 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1045 * src/widgets/modest-hbox-cell-renderer.c:
1046 (modest_hbox_cell_renderer_append):
1047 * src/widgets/modest-vbox-cell-renderer.c:
1048 (modest_vbox_cell_renderer_append):
1049 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1050 to fix the build with Maemo Bora.
1051 However, there seems to be a remaining crash, probably due to reference
1054 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1056 * src/modest-tny-account.c:
1057 (modest_tny_account_new_for_local_folders):
1058 Use hildon_file_system_info_async_new() to get a better name for
1059 the memory card account, setting it as the account name.
1060 The timing seems to work, but this is probably
1061 not the best place to do this. See the TODO comment.
1062 * src/maemo/modest-main-window.c: (create_details_widget):
1063 * src/widgets/modest-folder-view.c: (text_cell_data):
1064 Use the tny account name instead of hardcoding a name.
1066 2007-05-30 Christian Kellner <ckellner@openismus.com>
1068 * src/modest-search.c: (modest_search):
1069 Correctly set part_search_func even if we have already parsed
1070 the query and thus a valid OgsTextSearcher object.
1072 2007-05-30 Christian Kellner <ckellner@openismus.com>
1075 Search and check for libogs.
1078 Incooparte the ogs build env.
1080 * src/modest-mime-part-search-stream.c:
1081 * src/modest-mime-part-search-stream.h:
1082 Removed since we do the real searching now in modest-search.c.
1084 * src/modest-search.c:
1085 * src/modest-search.h:
1086 Implement support for ogs. We use that if available and requested
1087 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1088 should now handle the corner case when the search term is spread
1089 across multiple reads.
1090 Also the logic in modest_search () was corrected to search all
1091 requested fields until one is found.
1093 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1095 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1097 * src/modest-init.h:
1098 * src/modest-init.c: Made modest_init_local_folders() take a
1099 path and be public so we can iniitialize maildir folders on
1102 * src/modest-local-folder-info.h:
1103 * src/modest-local-folder-info.c:
1104 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1106 * src/modest-tny-account.c:
1107 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1108 still means the standard local-folders path on the local volume.
1110 * src/modest-tny-account-store.c:
1111 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1112 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1113 all accounts when that happens.
1114 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1115 this too, so it shows up in the treeview.
1117 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1119 * src/maemo/modest-maemo-global-settings-dialog.c:
1120 (current_connection):
1121 * src/widgets/modest-global-settings-dialog.c:
1122 (current_connection_default):
1123 Use the enum values instead of 0, 1 and -1,
1124 to make the code clearer.
1126 * src/modest-account-mgr-helpers.c:
1127 (modest_account_mgr_get_connection_specific_smtp): Make this code
1130 * src/modest-runtime.h:
1131 * src/modest-runtime.c:
1132 Added modest_runtime_remove_all_send_queues().
1133 * src/maemo/modest-main-window.c:
1134 (on_account_store_connecting_finished): Recreate the send queues,
1135 using the appropriate transport accounts for this new connection.
1136 Some futher adapting might be needed if the old send queues are not
1137 automatically stopped at this point.
1139 * src/modest-tny-account-store.c: (get_server_accounts):
1140 Create the connection-specific transport accounts, so that they can
1141 be found later by their ID.
1143 * src/modest-tny-account.h:
1144 * src/modest-tny-account.c:
1145 Added modest_tny_account_new_from_server_account_name().
1146 modest_tny_account_new_from_server_account(): Do not create the
1147 send queues here, because they will be
1148 recreated anyway when the connection changes for the first time.
1150 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1152 * src/modest-local-folder-info.h:
1153 * src/modest-local-folder-info.c:
1154 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1155 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1156 tbox_folder): Take a modest account name instead of a server TnyAccount,
1157 so we can have per-modest-account rather than per-transport-account
1159 We must make sure that we change or recreate the exisitng send queues
1160 when the connection changes for connection-specific transport accounts.
1162 * src/modest-tny-account-store.c:
1163 (create_per_account_local_outbox_folders): Create outboxed per modest
1164 account, not per transport account.
1166 * src/modest-tny-account.h:
1167 * src/modest-tny-account.c:
1168 (modest_tny_account_get_special_folder): For outboxes, get the
1169 parent modest account name. The account is ignored for other folders.
1170 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1171 modest account name rather than a server TnyAccount.
1173 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1175 * src/modest-tny-account.c:
1176 (modest_tny_account_new_from_server_account):
1177 Call modest_runtime_get_send_queue() immediately after creating transport
1178 accounts, so that they start trying to send email from the outbox as soon
1179 as possible at startup. This is probably what we want.
1181 * src/modest-mail-operation.c: (update_account_thread):
1182 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1183 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1184 * src/modest-tny-send-queue.h:
1185 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1186 (modest_ui_actions_on_send):
1187 Added comments about how sending works, though it needs some more work.
1189 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1191 * src/modest-tny-account.c:
1192 (modest_tny_account_get_special_folder): Add TODO because this fails when
1193 the network is busy.
1194 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1195 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1196 Do not try to show this window when there is no active account. The UI
1197 specs does not tell us what to do in this case.
1199 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1203 * src/maemo/Makefile.am:
1204 * src/widgets/Makefile.am: Some dist fixes.
1206 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1208 * src/maemo/modest-connection-specific-smtp-window.c:
1209 (on_button_edit): Make the code clearer, to prevent a double free.
1211 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1213 * src/maemo/modest-account-settings-dialog.c:
1214 (modest_account_settings_dialog_set_account_name),
1215 Check the connection-specific smtp servers checkbox if there are any.
1217 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1218 (modest_connection_specific_smtp_edit_window_init):
1219 Start with a suitable port number.
1221 * src/modest-account-mgr-helpers.h:
1222 * src/modest-account-mgr-helpers.c: Added
1223 modest_account_mgr_get_has_connection_specific_smtp().
1225 (modest_account_mgr_set_connection_specific_smtp),
1226 (modest_account_mgr_remove_connection_specific_smtp),
1227 (modest_account_mgr_get_has_connection_specific_smtp),
1228 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1229 connection-specific smtp server accounts in the account, rather than
1230 the server account conf dir.
1232 This fixes bug projects.maemo.org bug NB#58263 .
1234 * src/modest-tny-account-store.c:
1235 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1236 if there are no server accounts yet, to prevent an infinite loop when there
1237 are no accounts. Document that one must be called before the other.
1239 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1241 * src/modest-account-mgr-helpers.c:
1242 (modest_account_mgr_get_default_account): Make sure that at least
1243 one account is always the default, if there are any enabled accounts.
1244 This is just a sanity check that shouldn't be necessary.
1246 * src/modest-account-mgr-priv.c:
1247 (_modest_account_mgr_account_from_key): Unescape the conf key to
1248 get the real account name. For instance, this is an issue if a space
1249 was in the account name, which can happen because the account name
1250 is generated from the display name.
1251 (_modest_account_mgr_get_account_keyname): Always escape the
1253 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1254 Unescape the conf keys to get the real account names.
1256 For instance, previously the is-default radio button in the accounts
1257 list was not checked for any accounts at first. This fixes that,
1258 and might fix several similar bugs.
1260 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1262 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1263 Removed some debug printfs.
1265 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1267 Modest on-disk outbox directories are now here, for instance:
1268 $HOME/.modest/outboxes/<account-id-1>/outbox
1269 $HOME/.modest/outboxes/<account-id-2>/outbox
1271 $HOME/.modest/local-folders/outbox
1272 so we can have a separate outbox for each account.
1273 But they are shown as one outbox in the GtkTreeView, by using a
1274 TnyMergeFolder in a ModestTnySimpleFolderStore.
1277 * src/modest-tny-simple-folder-store.c:
1278 * src/modest-tny-simple-folder-store.h:
1279 Added ModestTnySimpleFolderStore, used to contain folders from
1280 other folder stores, such as other accounts.
1282 * src/modest-tny-outbox-account.h:
1283 * src/modest-tny-outbox-account.c:
1284 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1285 used for the per-account local outbox folders.
1287 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1288 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1289 only use this (internally) now for the non-outbox local folders.
1291 * src/modest-init.h:
1292 * src/modest-init.c: Added modest_init_one_local_folder(), for
1293 setting up the directory structure for each local folder.
1295 * src/modest-local-folder-info.c:
1296 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1297 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1299 * src/modest-local-folder-info.h:
1300 * src/modest-tny-account-store.c: (on_account_removed),
1301 (on_account_changed), (create_per_account_local_outbox_folders),
1302 (get_server_accounts), (modest_tny_account_store_get_accounts),
1303 (modest_tny_account_store_get_tny_account_by_account),
1304 (modest_tny_folder_store_is_virtual_local_folders):
1306 * src/modest-tny-account.h:
1307 * src/modest-tny-account.c:
1308 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1309 to create an on-disk per-account local outbox folder for each
1311 (create_per_account_local_outbox_folders): Create a local outbox folder
1312 for each transport account.
1313 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1314 for all local folders.
1316 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1317 instead of using g_object_get/set() directly. It is clearer.
1319 (modest_tny_folder_store_get_message_count),
1320 (modest_tny_folder_store_get_local_size
1321 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1322 because we now use these with non-acount folder stores.
1324 (modest_tny_account_get_special_folder),
1325 (modest_tny_account_new_from_server_account),
1326 (modest_tny_account_new_from_account):
1327 (recurse_folders): Adjust to the new outbox system.
1329 * src/modest-tny-folder.h:
1330 * src/modest-tny-folder.c:
1331 (modest_tny_folder_is_local_folder),
1332 (modest_tny_folder_get_local_folder_type),
1333 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1335 * src/widgets/modest-main-window.h:
1336 * src/maemo/modest-main-window.c: (create_details_widget),
1337 (modest_main_window_set_contents_style): Show details for any folder store,
1340 (modest_tny_folder_get_rules):
1341 Remove the const. C does not support constness enough for this.
1343 * src/modest-ui-actions.c:
1344 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1345 make all outboxes appear as one, in the usual local-folders tree node.
1347 (set_active_account_from_tny_account),
1348 (modest_ui_actions_on_folder_selection_changed):
1349 * src/widgets/modest-folder-view.c: (text_cell_data),
1350 (icon_cell_data), (filter_row),
1351 (add_account_folders_to_merged_folder),
1352 (add_account_folders_to_simple_folder_store), (),
1353 (get_cmp_rows_type_pos), (cmp_rows),
1354 (modest_folder_view_set_account_id_of_visible_server_account):
1355 Adjust to the new outbox system, using generic folder stores and folders
1356 in the GtkTreeModel.
1358 2007-05-23 Christian Kellner <ckellner@openismus.com>
1360 * src/modest-mail-operation.c:
1361 (modest_mail_operation_update_account):
1362 Use info->max_size instead of unintialized local var [small
1363 build fix]. (Added TODO to review that change since I don't
1366 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1368 * libmodest-dbus-client/libmodest-dbus-client.c:
1369 (libmodest_dbus_client_compose_mail): function added
1370 * src/dbus_api/modest-dbus-api.h:
1371 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1372 (on_compose_mail): Implementation of the SendAsMail functionality
1374 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1376 * src/modest-account-mgr.c:
1377 (modest_account_mgr_add_server_account): Set the secure-connection
1378 conf key for transport accounts as well as store accounts. I don't know
1379 why the if was there. For instance, this makes sure that we use SSL
1380 for the gmail preset from the easysetup wizard.
1382 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1384 * src/gnome/modest-main-window.c:
1385 (on_account_store_connecting_finished), (connect_signals):
1386 * src/maemo/modest-main-window.c:
1387 (on_account_store_connecting_finished), (connect_signals),
1388 (modest_main_window_new):
1389 Handle TnyAccountStore::connecting-finished instead of
1390 TnyDevice::connection-changed, because we cannot actually perform
1391 operations on accounts until TnyAccountStore has itself responded to
1392 the TnyDevice::connection-changed signal. This prevents a GError from
1394 Do not try to update at startup, because we (at least on scratchbox)
1395 already do an update at startup when the device goes online.
1396 This prevents a GError from tinymail.
1397 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1398 Added TODO about stopping simultaneous operations.
1400 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1402 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1403 * src/modest-mail-operation-queue.c:
1404 (modest_mail_operation_queue_remove):
1405 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1406 about where they happened.
1408 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1410 * src/modest-ui-actions.c:
1411 (modest_ui_actions_on_password_requested): Make sure that the remember
1412 output parameter is always TRUE.
1414 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1416 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1417 Show a OK/Cancel dialog if the error is a question, though we still do not
1418 know anything more about what we are asking the user.
1419 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1420 Fix an uninitialized variable (helper). This is a logic error, however.
1422 2007-05-21 Christian Kellner <ckellner@openismus.com>
1424 * src/modest-search.h:
1425 Correct bit shifting in the ModestSearchFlags enum.
1427 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1429 * src/modest-tny-account.c:
1430 (modest_tny_account_new_from_server_account): Do not use the lsub and
1431 check-all hard-coded IMAP options when using POP.
1433 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1435 * src/modest-tny-account.c:
1436 (modest_tny_account_new_from_server_account):
1437 Use NULL for the secure-auth method for POP when Password auth has been
1438 specified by the user, as we already do for IMAP. "auth=Login" causes
1439 an error from camel or the server.
1441 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1443 * src/maemo/modest-account-settings-dialog.c:
1444 (create_page_account_details),
1445 (modest_account_settings_dialog_set_account_name):
1446 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1447 for the leave-on-server checkbox, rathr than just the checkbox, when
1448 the protocol is not POP.
1450 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1452 * src/widgets/modest-account-view.c:
1453 * src/widgets/modest-account-view.h:
1454 Added modest_account_view_select_account() which will be useful later
1455 to asynchronously re-select the edited account.
1457 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1459 * src/maemo/modest-account-settings-dialog.c:
1460 (modest_account_settings_dialog_set_account_name):
1461 Automatically choose the port numbers based on the secure authentication
1462 methods, if they have not been chosen before.
1463 This fixes projects.maemo.org bug NB#56273 .
1465 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1467 * src/maemo/modest-main-window-ui.h:
1468 * src/modest-ui-actions.c:
1469 * src/modest-ui-actions.h:
1470 Connect the Tools/SMTP Servers menu item to
1471 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1472 SMTP servers dialog, as in the UI specification and saves changes when it
1473 is closed. This fixed projects.maemo.org bug NB#56305 .
1475 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1477 * src/maemo/modest-connection-specific-smtp-window.c:
1478 (modest_connection_specific_smtp_window_init):
1479 Use gtk_window_set_default_size() to make this window big enough, so
1480 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1482 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1484 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1485 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1486 (modest_connection_specific_smtp_edit_window_init),
1487 Do not try to connect to a combobox signal before the combobox exists.
1488 This fixes the cras in projects.maemo.org bug NB#56288 .
1489 (modest_connection_specific_smtp_edit_window_get_settings):
1490 Remove the server_account_name parameter which was being checked for NULL
1491 though it was not used.
1493 * src/maemo/modest-connection-specific-smtp-window.c:
1494 (modest_connection_specific_smtp_window_fill_with_connections),
1495 (on_button_edit), (modest_connection_specific_smtp_window_init):
1496 Correct the number of treemodel columns to prevent a warning.
1497 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1498 libconic does not work.
1500 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1502 * src/modest-tny-account.c:
1503 (modest_tny_account_new_from_server_account):
1504 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1505 SMTP when "None" was chosen by the user. However, with my SMTP server that
1506 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1509 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1511 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1512 to explain the memory management issue with the ID in the ModestPair.
1514 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1515 (add_sending_page), (modest_account_assistant_finalize):
1516 * src/gnome/modest-gnome-global-settings-dialog.c:
1517 (create_updating_page), (create_composing_page):
1518 * src/gnome/modest-msg-edit-window.c: (get_transports),
1519 (init_window), (modest_msg_edit_window_finalize),
1520 (modest_msg_edit_window_get_msg_data):
1521 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1522 * src/gnome/modest-transport-widget.c:
1523 (modest_transport_widget_finalize), (smtp_configuration):
1524 * src/maemo/modest-maemo-global-settings-dialog.c:
1525 (create_updating_page), (create_composing_page):
1526 * src/maemo/modest-msg-edit-window.c: (get_transports),
1527 (init_window), (modest_msg_edit_window_finalize),
1528 (modest_msg_edit_window_get_msg_data),
1529 (modest_msg_edit_window_free_msg_data):
1530 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1531 (modest_store_widget_finalize):
1532 * src/maemo/modest-transport-widget.c:
1533 (modest_transport_widget_finalize), (smtp_configuration):
1534 * src/modest-main.c: (send_mail):
1535 * src/widgets/modest-combo-box.h:
1536 * src/widgets/modest-global-settings-dialog-priv.h:
1537 * src/widgets/modest-global-settings-dialog.c:
1538 (modest_global_settings_dialog_finalize):
1539 * src/widgets/modest-msg-edit-window.h:
1540 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1541 as long as the combo box, to prevent use of freed memory for the ID.
1543 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1545 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1546 get_accounts(), to make this clearer. Do not check for the enabled gconf
1547 key, because we do not use this for server accounts (at least, not yet).
1548 This allows us to send email again.
1550 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/modest-platform.c:
1553 (on_modest_conf_update_interval_changed), (modest_platform_init):
1554 Only respond to this particular key change. All these strcmp()s cannot be
1557 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1559 * src/maemo/modest-maemo-global-settings-dialog.c:
1560 (current_connection): Prevent a crash in scratchbox when
1561 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1562 * src/maemo/modest-platform.c:
1563 (on_modest_conf_update_interval_changed), (modest_platform_init):
1564 Get the update interval from gconf and reset it when the gconf key changes.
1566 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1568 * src/modest-protocol-info.c:
1569 * src/modest-protocol-info.h: Adde enum-specific get functions,
1570 instead of using a ModestProtocolType enum parameter.
1572 * src/gnome/modest-account-assistant.c:
1573 * src/gnome/modest-store-widget.c:
1574 * src/gnome/modest-store-widget.h:
1575 * src/gnome/modest-transport-widget.c:
1576 * src/gnome/modest-transport-widget.h:
1577 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1578 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1579 * src/maemo/easysetup/modest-easysetup-wizard.c:
1580 * src/maemo/modest-account-settings-dialog.c:
1581 * src/maemo/modest-account-settings-dialog.h:
1582 * src/maemo/modest-store-widget.c:
1583 * src/maemo/modest-store-widget.h:
1584 * src/maemo/modest-transport-widget.c:
1585 * src/maemo/modest-transport-widget.h:
1586 * src/modest-account-mgr-helpers.c:
1587 * src/modest-account-mgr-helpers.h:
1588 * src/modest-account-mgr.c:
1589 * src/modest-account-mgr.h:
1590 * src/modest-tny-account.c:
1591 * src/modest-tny-folder.c:
1592 * src/widgets/modest-account-view.c:
1593 * src/widgets/modest-retrieve-combo-box.c:
1594 * src/widgets/modest-retrieve-combo-box.h:
1595 * src/widgets/modest-secureauth-combo-box.c:
1596 * src/widgets/modest-serversecurity-combo-box.c:
1597 * src/widgets/modest-serversecurity-combo-box.h:
1598 * tests/check_account-mgr.c:
1599 Use the specific functions, and use the re-renamed enum values for GNOME too.
1601 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1603 * src/modest-pair.h:
1604 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1605 so we can get the second based on the first.
1607 * src/maemo/modest-account-settings-dialog.h:
1608 * src/maemo/modest-account-settings-dialog.c:
1609 Added get_supported_secure_authentication_methods(), though it is mostly
1610 commented-out for now until the necessary API is committed to tinymail.
1611 (modest_account_settings_dialog_set_account_name),
1612 (save_configuration): Request the supported authentication methods from the
1613 server, so we can choose a working method.
1615 * src/modest-tny-account-store.h:
1616 * src/modest-tny-account-store.c:
1617 (modest_tny_account_store_get_session): Rename from
1618 tny_account_store_get_session().
1620 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1622 * src/modest-protocol-info.h: Split the ModestProtocol enum
1623 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1624 There was no need to have these unrelated values in one enum.
1626 * src/: many files: Adapted to changed enum. This makes the code a bit
1627 clearer, and the compiler could catch some errors.
1629 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1631 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1632 Show the detailed internal camel error message when an error happens
1633 during the configuration, so that our testers can give us more clues.
1634 For instance, in projects.maemo.org bug NB#56910 .
1636 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1638 * src/modest-tny-account.c:
1639 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1640 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1642 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1644 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1645 * src/maemo/modest-account-settings-dialog.c:
1646 (modest_account_settings_dialog_set_account_name),
1647 (save_configuration): For the incoming secure authentication checkbox,
1648 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1649 the UI specification. PLAIN does not seem to be supported for most IMAP
1650 servers anyway, and I am not sure what it would mean.
1651 However, we probably need to discover which of the secure-authentication
1652 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1653 * src/modest-account-mgr-helpers.c:
1654 (modest_account_mgr_get_server_account_data):
1656 * src/modest-tny-account.c:
1657 (modest_tny_account_new_from_server_account):
1658 Use tny_account_set_mech() to set secure-authentication methods,
1659 with some special-casing for IMAP, based on my observations of how
1662 * src/modest-account-mgr-helpers.h:
1663 * src/modest-account-mgr.c:
1664 * src/modest-defs.h: Comment that the URI is only used for local folders.
1666 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1668 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1669 parameter const, just to be neat.
1670 * src/modest-text-utils.c: (modest_text_utils_inline):
1671 End g_strconcat() with NULL, as its documentation says. This is almost
1672 certainly the cause of my crash at startup on the device. Interestingly,
1673 valgrind doesn't tell us about these errors.
1675 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1677 * scripts/build-packages: Added more precise comments about how to use
1678 this script, though I still get this error:
1679 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1680 error building tinymail
1682 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1684 * src/maemo/modest-main-window.c: (on_account_update):
1685 Very slight cleanup, hoping to make it simpler to discover what causes
1686 a crash here sometimes.
1688 * src/modest-tny-account.c:
1689 (modest_tny_account_new_from_server_account): Set the port. Added
1690 comments about the options and a TODO comment because I need to find out
1691 how to specify the secure authentication method.
1693 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1695 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1696 changed CFlags paths form modest to libmodest
1698 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1700 * src/modest-account-mgr-helpers.c:
1701 (modest_account_mgr_get_server_account_data),
1702 (modest_account_mgr_free_server_account_data):
1703 * src/modest-account-mgr-helpers.h:
1704 * src/modest-account-mgr.c:
1705 (modest_account_mgr_add_server_account):
1706 * src/modest-defs.h:
1707 * src/modest-tny-account.c:
1708 (modest_tny_account_new_from_server_account):
1709 Determine the options for tny_camel_account_add_option() here,
1710 based on the settings, rather than storing them directly in gconf.
1712 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1714 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1715 Show a more friendly error dialog now that we expect (from the tinymail
1716 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1718 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1720 * src/maemo/modest-main-window.c: (on_account_update): Check that
1721 account_name is not NULL, to prevent a crash at startup that I am
1722 seeing on the N800. I do wonder why it is NULL.
1724 * src/maemo/easysetup/modest-easysetup-wizard.c:
1725 (create_page_user_details):
1726 * src/maemo/modest-account-settings-dialog.c:
1727 (create_page_user_details), (create_page_outgoing):
1728 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1729 (modest_connection_specific_smtp_edit_window_init):
1730 * src/modest-ui-actions.c:
1731 (modest_ui_actions_on_password_requested):
1732 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1733 might do something useful with the on-screen keyboard.
1735 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1737 * src/maemo/modest-main-window.c: (on_account_update):
1738 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1739 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1741 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1743 * src/modest-tny-account-store.c: (on_account_changed):
1744 Correct the signature of this signal handler.
1746 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1748 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1749 Show a HildonNote instead of a GtkDialog for Maemo.
1751 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1753 * src/widgets/modest-account-view.h:
1754 * src/widgets/modest-account-view.c: (on_account_changed),
1755 (on_account_removed). Added a boolean flag, set/unset by
1756 modest_account_view_block_conf_updates(),
1757 modest_account_view_unblock_conf_updates() to prevent unnecessary
1758 updates, but this is not very useful because the gconf notifications are
1759 so delays (maybe only on Maemo Bora).
1760 So auto-updating is turned off, and these functions do an explicit
1761 update when necessary.
1762 However, something else is still doing too much work when adding/removing
1763 accounts, probably in another part of the application.
1765 * src/maemo/modest-account-view-window.c:
1766 (on_delete_button_clicked), (on_edit_button_clicked),
1767 (on_new_button_clicked): Use the new functions.
1769 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1771 * src/modest-account-mgr-helpers.c:
1772 (modest_account_mgr_set_first_account_as_default):
1773 Sort the list of names alphabetically-by-title, so we choose the first one
1775 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1776 alphabetically by the title.
1778 This fixes projects.maemo.org bug NB#56418 .
1780 * src/modest-account-mgr-priv.c:
1781 (_modest_account_mgr_account_from_key):
1782 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1783 avoid a valgrind error, and possible random behaviour.
1785 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1787 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1788 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1789 tinymail documentation to say that this can be expected.
1790 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1791 pretty, and should not happen, but I would prefer to know when it does.
1793 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1795 * configure.ac: When using the older hildon version, probably on Bora,
1796 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1798 * src/widgets/modest-attachment-view.c:
1799 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1802 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1804 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1805 Implemented the prototype. Can be tested with
1806 tests/dbus_api/test_open_message:
1808 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1810 * src/modest-tny-account-store.c:
1811 (modest_tny_account_store_instance_init), (get_password):
1812 * src/modest-ui-actions.c:
1813 (modest_ui_actions_on_password_requested):
1814 Do not store the password in gconf, because this function is called
1815 for non-remembered passwords. Actually use the cached (in the hash map)
1816 password instead of releasing it.
1817 The password will now not be remembered if it is asked via the protected
1818 password dialog, as per the UI spec.
1820 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1822 * src/modest-defs.h:
1823 * src/modest-account-mgr-helpers.h:
1824 * src/modest-account-mgr-helpers.c:
1825 Added modest_server_account_get_username_has_succeeded(),
1826 modest_server_account_set_username_has_succeeded().
1827 (modest_server_account_set_username),
1828 Reset the has-succeeded flag if the username changes.
1830 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1831 * src/maemo/modest-connection-specific-smtp-window.c:
1832 (modest_connection_specific_smtp_window_save_server_accounts):
1833 Use modest_server_account_set_username() instead of using
1834 modest_conf_set_string() directly, so that the has-succeeded flag is always
1837 * src/modest-ui-actions.c:
1838 (modest_ui_actions_on_password_requested): Dim the username entry if
1839 the username has ever worked, as per the UI spec.
1841 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1843 * src/modest-tny-account-store.c: (get_password):
1844 * src/modest-ui-actions.c:
1845 (modest_ui_actions_on_password_requested):
1846 Allow the username to be changed too, though there is more work to
1847 be done on exactly how this behaves.
1849 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1851 * src/modest-account-mgr-helpers.h:
1852 * src/modest-account-mgr-helpers.c:
1853 Added modest_account_mgr_get_display_name(),
1854 modest_server_account_get_username(),
1855 modest_server_account_set_username(),
1856 modest_server_account_set_password(),
1857 modest_server_account_get_hostname() functions so we do not need to
1858 use the conf API directly.
1860 * src/maemo/modest-main-window.c: (connect_signals):
1861 Actually connect ot the ModestAccountStore::request-password signal,
1862 so that we show the dialog when the password is requested by Tinymail,
1863 for isntance if it is empty.
1865 * src/modest-marshal.list:
1866 * src/modest-tny-account-store.c:
1867 (modest_tny_account_store_class_init), (get_password),
1868 (modest_tny_account_store_alert):
1869 * src/modest-tny-account-store.h:
1870 * src/modest-ui-actions.h:
1871 * src/modest-ui-actions.c:
1872 (modest_ui_actions_on_password_requested):
1873 Change the signal parameters, so it is obvious that we are providing
1874 the non human-readable server name, and receiving both the username
1875 and password, though changing of the username is not yet implemented.
1876 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1877 for the GNOME version.
1879 This should fix the projects.maemo.org bug NB#56209, though it does not
1880 work on Bora, because the gconf_client_get() for the password fails
1881 immediately after we save it with gconf_client_set().
1883 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1886 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1887 caused an undefined symbol error:
1888 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1890 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1892 * src/modest-tny-account-store.c:
1893 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1894 using a GError instead of a string message, so we can translate it in
1897 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1899 * src/maemo/modest-address-book.c:
1900 (modest_address_book_check_names):
1901 * src/maemo/modest-msg-view-window.c:
1902 (modest_msg_view_window_clipboard_owner_change):
1903 * src/modest-init.c: (modest_init_init_ui):
1904 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1905 (update_folders_cb), (modest_mail_operation_update_account):
1906 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1907 (modest_ui_actions_on_msg_attachment_clicked),
1908 (modest_ui_actions_on_msg_recpt_activated):
1909 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1910 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1911 (modest_msg_view_search_next):
1912 * src/widgets/modest-recpt-editor.c:
1913 (modest_recpt_editor_on_button_release_event),
1914 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1915 g_message(). At this point we should only be seeing interesting errors on
1916 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1918 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1920 (modest_wizard_dialog_force_title_update):
1921 * src/maemo/easysetup/modest-wizard-dialog.h:
1922 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1923 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1924 can update the title when appropriate. Otherwise the title is wrong if the
1925 pages are added after adding the notebook to the dialog.
1926 This must be a problem in HildonWizardDialog too.
1927 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1929 * src/maemo/easysetup/modest-easysetup-wizard.c:
1930 (create_subsequent_customsetup_pages),
1931 (create_subsequent_easysetup_pages):
1932 Call modest_wizard_dialog_force_title_update() so that the title is
1933 correct even with GTK+ < 2.10.
1934 This fixes projects.maemo.org bug NB#56145 .
1936 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1938 * src/maemo/modest-platform.c:
1939 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1940 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1943 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1945 * src/widgets/modest-window.h:
1946 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1947 and modest_window_save_state(), which invokes it.
1949 * src/widgets/modest-window-mgr.h:
1950 * src/widgets/modest-window-mgr.c:
1951 Added modest_window_mgr_save_state_for_all_windows(), which calls
1952 the save_state vfunc on all registered windows, if implemented.
1954 * src/gnome/modest-msg-edit-window.c:
1955 * src/gnome/modest-msg-view-window.c:
1956 * src/maemo/modest-msg-edit-window.c:
1957 * src/maemo/modest-msg-view-window.c:
1958 * src/maemo/modest-main-window.c:
1959 Specify the existing save_settings functions as implementations of
1960 ModestWindow::save_state_func().
1962 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1963 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1964 enabling hibernation, for instance.
1966 We may need to do the same thing for restoring settings.
1969 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1971 * src/widgets/modest-window-mgr.c:
1972 * src/widgets/modest-window-mgr.h:
1973 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1974 modest_window_mgr_get_hibernation_is_prevented().
1976 * src/maemo/modest-main-window.c:
1977 (on_hildon_program_is_topmost_notify): Prevent hibernation
1978 (possible when the application goes to the background in the WM),
1979 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1981 * src/maemo/easysetup/modest-easysetup-wizard.c:
1982 (modest_easysetup_wizard_dialog_init):
1983 * src/maemo/modest-account-settings-dialog.c:
1984 (modest_account_settings_dialog_init):
1985 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1986 (modest_connection_specific_smtp_edit_window_init):
1987 * src/maemo/modest-connection-specific-smtp-window.c:
1988 (modest_connection_specific_smtp_window_init):
1989 * src/maemo/modest-signature-editor-dialog.c:
1990 (modest_signature_editor_dialog_init):
1991 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1992 prevent hibernation while any of these account settings dialogs are open.
1994 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1996 * src/maemo/Makefile.am:
1997 * src/maemo/modest-osso-state-saving.c:
1998 * src/maemo/modest-osso-state-saving.h: Added
1999 modest_osso_load_state() and modest_osso_save_state() though they do
2000 nothing now. They should iterate through all the open windows and load/save
2002 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2003 save state when closing.
2005 * src/maemo/modest-main-window.c:
2006 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2007 Add a notification handler for the HildonProgram::is-topmost property,
2008 so we can allow hibernation when the application goes into the background.
2009 But we still need to detect when the accounts setup windows are open so
2010 we can stop hibernation when they are open.
2011 To do this, I also added the main window the HildonProgram. This might have
2012 other side-effects/benefits, and should maybe be done for other windows.
2014 * src/maemo/modest-osso-autosave-callbacks.h:
2015 * src/maemo/modest-osso-autosave-callbacks.c:
2016 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2017 though it does not do anything yet, and we might never need this to do
2018 anything. For instance, we already save drafts.
2020 * src/maemo/modest-platform.c: (modest_platform_init):
2021 Specify the libosso auto-save callback.
2023 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2025 * src/maemo/modest-platform.c:
2026 (modest_platform_set_update_interval):
2027 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2028 aparently stays valid between application instances, so we can use this
2029 to remove and reset it later. According to a maemo-developers email from
2032 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2034 * configure.ac: Depend on libalarm for Maemo.
2036 * src/dbus_api/modest-dbus-api.h:
2037 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2038 (on_send_receive), (modest_dbus_req_handler):
2039 Handle a SEND_RECEIVE D-Bus method.
2041 * libmodest-dbus-client/libmodest-dbus-client.c:
2042 (libmodest_dbus_client_send_and_receive):
2043 * libmodest-dbus-client/libmodest-dbus-client.h:
2044 Add C convenience functions for calling the new D-Bus method.
2046 * src/modest-platform.h:
2047 * src/gnome/modest-platform.c:
2048 * src/maemo/modest-platform.c:
2049 Added modest_platform_set_update_interval(), which uses the
2050 alarmd API on Maemo.
2051 (modest_platform_init),
2052 Call modest_platform_set_update_interval(), using a hard-coded
2053 interval for now (until the global settings dialog is implemented),
2054 though I am not sure that this makes sense yet.
2056 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2058 * src/dbus_api/modest-dbus-callbacks.c:
2059 (modest_osso_cb_hw_state_handler):
2060 * src/dbus_api/modest-dbus-callbacks.h:
2061 * src/maemo/modest-platform.c: (modest_platform_init):
2062 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2063 in case this has some effect on the ability for Maemo to ping the
2066 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2069 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2070 warning. It is probably a logic error, but I need to fix the build.
2072 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2074 * src/modest-account-mgr.h:
2075 * src/modest-account-mgr.c:
2076 (modest_account_mgr_account_names): Add a gboolean enabled_only
2077 parameter, so we can get lists of onlt the enabled accounts.
2079 (modest_account_mgr_add_account),,
2080 (modest_account_mgr_account_with_display_name_exists):
2081 * src/maemo/modest-msg-edit-window.c: (get_transports):
2082 * src/modest-account-mgr-helpers.c:
2083 (modest_account_mgr_set_first_account_as_default):
2084 * src/modest-init.c: (init_default_account_maybe):
2085 * src/modest-tny-account-store.c: (get_accounts):
2086 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2087 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2088 * tests/check_account-mgr.c: (START_TEST):
2089 Provide the extra parameter, as appropriate.
2091 * src/widgets/modest-account-view.c: (update_account_view):
2092 Do not show disabled accounts (meaning that there is no way to
2093 enable/disable accounts in the UI (the feature is not in our UI
2094 specification), so we can use this internally only to mark unfinished
2095 or temporary account data.
2097 * src/maemo/easysetup/modest-easysetup-wizard.c:
2098 (create_account): Add boolean enable parameter, so we can specify FALSE
2099 to create the temporary account.
2100 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2101 (on_before_next): When finishing, when there is a temporary account, just
2103 Also, use a timeout to delay the showing of the dialog until gconf is likely
2104 to return correct information, due to a maemo gconf bug that is fixed in
2105 osso 1.1, but not yet in Bora.
2106 However, the dialog stays on screen after it is destroyed.
2108 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2109 for invalid data when cancelling. Use a hildon note instead of a dialog
2110 to complain about invalid data. Do not show the account-saved note if the
2111 account is disabled (a temporary account that will not really be saved for use
2114 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2116 * src/modest-account-mgr-helpers.h:
2117 * src/modest-account-mgr-helpers.c:
2118 Added modest_account_mgr_unset_default_account(),
2119 Added modest_account_mgr_set_first_account_as_default().
2121 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2122 If it was the default account, unset the default account name.
2124 * src/maemo/modest-account-view-window.c:
2125 (on_delete_button_clicked): If it was the default account,
2126 set the first remaining account as the default instead.
2128 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2129 a NULL account or a NULL default account, to prevent a crash. This should
2130 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2133 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2135 * src/widgets/modest-recpt-editor.c:
2136 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2137 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2138 TODO comment for this. This fixes the build.
2140 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2141 be the best place for it. This will in future update all auto-update accounts,
2142 rather than just the current/default account, when that gconf key exists.
2143 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2144 if there are no accounts, before calling do_send_receive().
2145 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2147 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2148 * src/maemo/modest-main-window-ui.h:
2149 * src/maemo/modest-main-window.c: (on_connection_changed),
2150 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2151 directly, becaue the signal handler does more.
2153 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2155 * src/modest-account-mgr-helpers.c:
2156 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2157 for the case that the account does not exist.
2159 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2160 (equivalent to the modest account name) rather than the tinymail account name
2161 (equivalent to the modest account title - human readable) to get the account data.
2162 Check for null account data to prevent the crash, and add a TODO comment saying that
2163 this needs fixing because it is using the server account name instead of the account name.
2165 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2167 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2168 * src/maemo/modest-account-settings-dialog.c: (show_error),
2170 Use hildon_note_new_information() for informative and error messages,
2171 which seems to be expected for Maemo applications (no documentation that I know of
2172 says this). I am surprised that there is no distinction between info and error
2175 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2177 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2178 it is easy to find where this is used.
2180 * src/maemo/easysetup/modest-easysetup-wizard.c:
2181 (create_page_welcome), (create_page_account_details),
2182 (create_page_user_details), (create_page_complete_easysetup),
2183 (create_page_custom_incoming), (create_page_custom_outgoing),
2184 (create_page_complete_custom):
2185 * src/maemo/modest-account-settings-dialog.c:
2186 (create_page_account_details), (create_page_user_details),
2187 (create_page_incoming), (create_page_outgoing):
2188 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2189 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2190 (modest_connection_specific_smtp_edit_window_init):
2191 * src/maemo/modest-connection-specific-smtp-window.c:
2192 (modest_connection_specific_smtp_window_init):
2193 * src/maemo/modest-signature-editor-dialog.c:
2194 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2195 and scrolling policy as per the Email Application Layout Guide, if I have
2198 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2200 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2201 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2202 which were empty, because these vfuncs have been removed from TnyAccountStore.
2203 This fixes the build.
2205 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2207 * src/maemo/modest-main-window.c:
2208 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2209 showing/hiding it. Added TODO because it probably should not be NULL.
2210 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2211 because unnecessary g_warnings() make degugging difficult.
2213 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2215 * src/maemo/modest-msg-edit-window.c:
2216 (modest_msg_edit_window_select_color),
2217 (modest_msg_edit_window_select_background_color): 2 const corrections and
2218 moving 2 #endifs before closing brackets, to fix the build.
2220 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2222 * src/maemo/easysetup/modest-easysetup-wizard.h:
2223 * src/maemo/easysetup/modest-easysetup-wizard.c:
2224 (modest_easysetup_wizard_dialog_finalize),
2225 (on_button_edit_advanced_settings), (create_page_complete_custom),
2226 (on_response), (create_account):
2227 Implement the Advanced Settings edit button, by saving the account information,
2228 for the Advanded Settings dialog to use directly from gconf, and removing it
2229 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2230 Bug #5533 in the projects.maemo.org bugzilla.
2232 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2234 * src/maemo/modest-msg-view-window.c:
2235 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2236 when opening a message window.
2238 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2240 * src/maemo/easysetup/modest-easysetup-wizard.c:
2241 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2244 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2245 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2246 gconf settings. I probably added more checks than necessary, but that is safer.
2248 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2249 variable to fix the build, but this seems to be used when it is still NULL.
2251 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2253 * src/modest-platform.h:
2254 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2255 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2256 * src/modest-main.c: Implement this function so we can avoid using
2257 maemo-specific API from cross-platform code.
2259 * src/modest-tny-account-store.c:
2260 (get_smtp_specific_transport_account_for_open_connection):
2261 * src/modest-ui-actions.c: (check_for_connection),
2262 (modest_ui_actions_on_item_not_found):
2263 Use modest_platform_connect_and_wait() and put #idefs around other
2264 maemo-specific code, because only maemo currently has a way to
2265 identify connection names.
2267 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2269 * src/modest-tny-account-store.h:
2270 * src/modest-tny-account-store.c:
2271 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2272 the connection-specific SMTP server settings in the configuration.
2274 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2276 * src/maemo/modest-main-window.c: (on_connection_changed),
2278 * src/modest-main.c: (main), (start_ui), (send_mail):
2279 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2280 that is what is intended.
2282 * src/modest-ui-actions.c: (action_send), (action_receive),
2283 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2284 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2285 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2286 SMTP server is used when it is specified.
2288 (modest_ui_actions_on_send_receive):
2289 Check that a connection is open before proceeding.
2290 Receive and then send, instead of vice-versa, as per the specification.
2292 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2294 * src/modest-mail-operation.c:
2295 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2296 though I guess it should be something other than NULL.
2298 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2300 * src/maemo/easysetup/modest-easysetup-wizard.c:
2301 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2302 combo twice, to avoid an g_warning and to make it visible again.
2303 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2304 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2305 (already intended) dereference when detaching, because we then recreate the menu.
2306 But I am not sure why the warning was happening, and it is possible that this is a memory
2309 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2311 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2312 and uri_parse_mailto() utility functions.
2313 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2315 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2317 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2319 * src/dbus_api/modest-dbus-api.h:
2320 * src/dbus_api/modest-dbus-callbacks.c:
2321 Use an idle callback to execute the modest code in the application's own thread.
2322 Remove the helloworld example method.
2323 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2324 parsed, and the open-message method is not implemented because this is not yet implemented in
2326 * libmodest-dbus-client/libmodest-dbus-client.c:
2327 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2328 (libmodest_dbus_client_open_message):
2329 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2331 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2332 body without crashing.
2334 * tests/dbus_api/Makefile.am:
2335 * tests/dbus_api/test_mail_to.c:
2336 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2338 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2340 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2341 Added file to fix the build. Sorry.
2343 * src/dbus_api/Makefile.am:
2344 * src/dbus_api/modest-dbus-api.h:
2345 * src/dbus_api/modest-dbus-callbacks.h:
2346 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2347 (modest_dbus_req_handler):
2348 Put constants in a separate header so it can be reused by the
2349 client library, without duplication
2351 * libmodest-dbus-client/Makefile.am:
2352 * libmodest-dbus-client/libmodest-dbus-client.c:
2353 (libmodest_dbus_client_call_helloworld),
2354 (libmodfest_dbus_client_send_mail),
2355 (libmodfest_dbus_client_mailto),
2356 (libmodfest_dbus_client_open_message):
2357 * libmodest-dbus-client/libmodest-dbus-client.h:
2358 (Partly) Implement a send_mail D-Bus method.
2360 * tests/dbus_api/Makefile.am:
2361 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2362 the send_email D-Bus method.
2364 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2368 * libmodest-dbus-client/Makefile.am:
2369 * libmodest-dbus-client/libmodest-dbus-client.c:
2370 * libmodest-dbus-client/libmodest-dbus-client.h:
2371 * tests/dbus_api/Makefile.am:
2372 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2373 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2375 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2377 * src/maemo/easysetup/modest-easysetup-wizard.c:
2378 (create_page_account_details):
2379 * src/maemo/modest-account-settings-dialog.c:
2380 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2381 widgets, because this might not be the default in future versions of the Maemo GTK+.
2382 However, I can not not get capitalization to work even in a simple test case.
2384 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2386 * src/maemo/easysetup/modest-easysetup-wizard.c:
2387 (create_page_custom_incoming), (create_page_custom_outgoing):
2388 * src/maemo/modest-account-settings-dialog.c:
2389 (create_page_account_details), (create_page_incoming),
2390 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2391 instead of using gtk_check_button_with_label(), so they are aligned like the other
2392 widgets, as per the UI spec.
2394 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2396 * src/maemo/easysetup/modest-easysetup-wizard.c:
2397 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2398 * src/widgets/modest-validating-entry.c:
2399 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2400 Modest prefix instead of an EasySetup prefix.
2402 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2404 * src/widgets/modest-validating-entry.h:
2405 * src/widgets/modest-validating-entry.c: (on_insert_text),
2406 Added easysetup_validating_entry_set_max_func(), used to set a callback
2407 to call when the max number of characters is reached. GtkEntry has a max-length
2408 already but is silent about it.
2410 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2411 (create_page_account_details), (create_page_user_details),
2413 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2414 (create_page_account_details), (create_page_user_details),
2415 (create_page_outgoing):
2416 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2417 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2418 the UI spec, when the user tries to enter more than the max number of characters.
2420 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2422 * src/maemo/easysetup/modest-easysetup-wizard.c:
2423 (create_page_user_details), (create_page_custom_incoming),
2424 (create_page_custom_outgoing):
2425 * src/maemo/modest-account-settings-dialog.c:
2426 (create_page_user_details), (create_page_incoming),
2427 (create_page_outgoing):
2428 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2429 (modest_connection_specific_smtp_edit_window_init):
2430 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2431 not appropriate. Bad Maemo-specific defaults!.
2433 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2435 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2436 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2437 (modest_signature_editor_dialog_set_settings):
2438 Disable the label and textview when the checkbox is disabled, and use the
2439 specified (UI spec) default signature text.
2441 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2443 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2444 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2446 * src/modest-defs.h:
2447 * src/modest-account-mgr-helpers.h:
2448 * src/modest-account-mgr-helpers.c:
2449 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2451 * src/maemo/Makefile.am:
2452 * src/maemo/modest-signature-editor-dialog.c:
2453 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2456 * src/maemo/modest-account-settings-dialog.h:
2457 * src/maemo/modest-account-settings-dialog.c:
2458 (modest_account_settings_dialog_finalize), (on_button_signature),
2459 (save_configuration): Use the new dialog when the Edit button is pressed, and
2460 save the changes if necessary, as per the UI spec.
2462 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2464 * src/maemo/Makefile.am:
2465 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2466 based on maemo-develoers email from Dirk.
2468 * src/maemo/easysetup/modest-easysetup-wizard.c:
2469 (create_page_welcome), (create_page_account_details),
2470 (create_page_user_details), (create_page_complete_easysetup),
2471 (create_page_custom_incoming), (create_page_custom_outgoing),
2472 (create_page_complete_custom),
2473 (modest_easysetup_wizard_dialog_init):
2474 * src/maemo/modest-account-settings-dialog.c:
2475 (create_page_account_details), (create_page_user_details),
2476 (create_page_incoming), (create_page_outgoing),
2477 (modest_account_settings_dialog_init):
2478 * src/maemo/modest-connection-specific-smtp-window.c:
2479 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2481 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2483 * src/maemo/easysetup/modest-easysetup-wizard.c:
2484 (create_page_account_details), (create_page_custom_outgoing),
2485 (create_page_complete_custom):
2486 * src/maemo/modest-account-settings-dialog.c:
2487 (create_page_user_details), (create_page_incoming),
2488 (create_page_outgoing):
2489 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2490 (modest_connection_specific_smtp_edit_window_init):
2491 Use the correct (UI spec) port min/max, and use horizontal separators,
2494 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2496 * src/maemo/easysetup/modest-easysetup-wizard.c:
2497 (set_default_custom_servernames):
2498 * src/maemo/modest-account-settings-dialog.c:
2499 (create_page_incoming), (on_combo_outgoing_security_changed),
2500 (on_combo_incoming_security_changed), (create_page_outgoing),
2501 (modest_account_settings_dialog_set_account_name),
2502 (save_configuration):
2503 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2504 (on_combo_security_changed),
2505 (modest_connection_specific_smtp_edit_window_init),
2506 (modest_connection_specific_smtp_edit_window_set_connection),
2507 (modest_connection_specific_smtp_edit_window_get_settings):
2508 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2511 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2514 * src/maemo/easysetup/modest-easysetup-wizard.c:
2515 (create_page_custom_outgoing), (create_page_complete_custom):
2516 * src/maemo/modest-account-settings-dialog.c:
2517 (create_page_user_details), (create_page_outgoing):
2518 * src/maemo/modest-account-view-window.c: (button_box_new):
2519 Use changed logical IDs as per the most recent UI spec:
2520 mcen_bd_emailsetup_edit -> mcen_bd_edit
2521 mcen_bd_emailsetup_delete -> mcen_bd_delete
2522 mcen_bd_emailsetup_close -> mcen_bd_close
2524 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2528 * src/dbus_api/Makefile.am:
2529 * src/dbus_api/modest-dbus-callbacks.c:
2530 * src/dbus_api/modest-dbus-callbacks.h:
2531 * src/maemo/modest-platform.c: (modest_platform_init):
2532 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2534 * tests/Makefile.am:
2535 * tests/dbus_api/Makefile.am:
2536 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2538 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2540 * src/maemo/modest-account-settings-dialog.c:
2541 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2542 Removed unnecessary includes.
2544 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2546 * src/maemo/easysetup/modest-easysetup-wizard.c:
2547 * src/maemo/modest-account-settings-dialog.c:
2548 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2549 * src/widgets/Makefile.am:
2550 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2551 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2552 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2553 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2554 * src/widgets/modest-secureauth-combo-box.c:
2555 * src/widgets/modest-secureauth-combo-box.h:
2556 * src/widgets/modest-serversecurity-combo-box.c:
2557 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2558 made the GObject names more consistent with the rest of the Modest code.
2560 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2562 * src/maemo/easysetup/Makefile.am:
2563 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2564 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2565 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2566 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2567 * src/maemo/easysetup/modest-easysetup-wizard.c:
2568 * src/maemo/easysetup/modest-validating-entry.c:
2569 * src/maemo/easysetup/modest-validating-entry.h:
2570 * src/maemo/modest-account-settings-dialog.c:
2571 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2572 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2573 widgets/ because they are used outside of easysetup too. After checking in,
2574 svn will allow me to rename them too.
2576 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2578 * src/gnome/modest-msg-edit-window.c:
2579 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2580 linker error, to fix the build on the GNOME platform.
2581 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2582 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2583 ifdefed out to avoid a warning.
2585 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2587 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2588 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2589 some alternative for GTK+ 2.6.
2591 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2593 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2595 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2596 specified for EmailAccountsDialog in UI spec.
2598 * src/maemo/easysetup/modest-easysetup-wizard.c:
2599 * src/maemo/easysetup/modest-easysetup-wizard.h:
2600 * src/maemo/modest-account-settings-dialog.c:
2601 * src/maemo/modest-account-settings-dialog.h:
2602 Reuse a member window widget for the connection-specific SMTP server accounts,
2603 so we can tell it to create/save the accounts only if we actually save changes.
2605 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2606 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2607 (modest_connection_specific_smtp_edit_window_get_settings):
2608 Return a struct instance for temporarily remembering the entered data.
2610 * src/maemo/modest-connection-specific-smtp-window.h:
2611 * src/maemo/modest-connection-specific-smtp-window.c:
2612 (modest_connection_specific_smtp_window_finalize),
2613 (modest_connection_specific_smtp_window_fill_with_connections),
2615 (modest_connection_specific_smtp_window_save_server_accounts),
2616 (update_model_server_names): Do not actually save data until asked,
2617 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2619 (on_selection_changed),
2620 (modest_connection_specific_smtp_window_init): Disable the edit
2621 button when nothing is selected.
2623 * src/modest-account-mgr-helpers.c:
2624 * src/modest-account-mgr-helpers.h:
2625 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2628 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2630 * src/modest-account-mgr-helpers.h:
2631 * src/modest-account-mgr-helpers.c:
2632 (modest_account_mgr_get_unused_account_name),
2633 (modest_account_mgr_get_unused_account_display_name): Added these
2634 utility functions, to avoid code duplication.
2636 * src/maemo/easysetup/modest-easysetup-wizard.c:
2637 (create_page_account_details), (create_account):
2638 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2639 (on_combo_security_changed),
2640 (modest_connection_specific_smtp_edit_window_init),
2641 (modest_connection_specific_smtp_edit_window_save_settings):
2642 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2643 * src/maemo/modest-connection-specific-smtp-window.c:
2644 (modest_connection_specific_smtp_window_finalize),
2645 (modest_connection_specific_smtp_window_fill_with_connections),
2646 (on_button_edit), (modest_connection_specific_smtp_window_init):
2647 * src/maemo/modest-connection-specific-smtp-window.h:
2648 Implementing saving of connection-specific server accounts.
2650 But I need to refactor this so we can save the data for each
2651 possible connection-specific account and only actually create the server accounts
2652 when the easysetup finished, or the OK button is pressed on the account settings
2655 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2657 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2658 (on_combo_security_changed):
2659 (modest_connection_specific_smtp_edit_window_init):
2660 Auto-fill the port number as in the account settings.
2662 (modest_connection_specific_smtp_edit_window_set_connection):
2663 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2664 * src/maemo/modest-connection-specific-smtp-window.c:
2665 (fill_with_connections), (on_button_edit),
2666 (modest_connection_specific_smtp_window_init):
2667 Turn the edit window into a dialog to simplify the code, and
2668 set a WM hint as in a GtkDialog, because only a popup can be on top of
2669 another window in Maemo, and popups usually have no WM decoration.
2671 * src/modest-defs.h:
2672 * src/modest-account-mgr-helpers.c:
2673 (modest_account_mgr_set_connection_specific_smtp),
2674 (modest_account_mgr_remove_connection_specific_smtp),
2675 (modest_account_mgr_get_connection_specific_smtp):
2676 * src/modest-account-mgr-helpers.h: Some functions to write the
2677 connection-specific SMTP server information. Not yet used.
2680 * src/widgets/modest-folder-view.c: (text_cell_data):
2681 Fix a warning about an uninitialized variable.
2682 (on_configuration_key_changed): Put an #ifdef around the use
2683 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2685 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2687 * src/maemo/modest-account-settings-dialog.h:
2688 * src/maemo/modest-account-settings-dialog.c:
2689 Added connect_for_modified() utility function to mark the new modified boolean.
2691 (create_page_account_details), (create_page_user_details),
2692 (create_page_incoming), (create_page_outgoing), (on_response),
2693 (modest_account_settings_dialog_init),
2694 (modest_account_settings_dialog_set_account_name):
2695 Only warn about unsaved changes when there are actually unsaved changes.
2697 * src/modest-account-mgr-helpers.c:
2698 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2699 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2700 to get the data from there in future.
2702 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2704 * src/modest-defs.h:
2706 * src/modest-account-mgr-helpers.h:
2707 * src/modest-account-mgr-helpers.c:
2708 Store the security account setting in a single conf key instead of using
2709 the options list, so that the list is left for just the to-be-removed camel hack,
2710 and because gconf_client_set_list() is failing for some reason.
2712 * src/modest-account-mgr.c:
2713 (modest_account_mgr_add_server_account):
2714 * src/maemo/modest-account-settings-dialog.c:
2715 (modest_account_settings_dialog_set_account_name),
2716 (save_configuration): Use the renamed functions.
2719 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2721 * src/widgets/Makefile.am:
2722 * src/widgets/modest-limit-retrieve-combo-box.c:
2723 * src/widgets/modest-limit-retrieve-combo-box.h:
2724 * src/widgets/modest-retrieve-combo-box.c:
2725 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2726 the account settings dialog.
2728 * src/modest-defs.h:
2729 * src/modest-account-mgr-helpers.h:
2730 * src/modest-account-mgr-helpers.c:
2731 (modest_server_account_get_option_secure_auth),
2732 (modest_server_account_set_option_secure_auth):
2733 * src/modest-account-mgr.c:
2734 (modest_account_mgr_add_server_account):
2735 Use the existing AUTH_MECH conf key for the secure-auth setting,
2736 instead of putting it in the list options, because this was actually used already.
2738 * src/maemo/modest-account-settings-dialog.c:
2739 (create_page_account_details),
2740 (modest_account_settings_dialog_set_account_name),
2741 (save_configuration):
2742 * src/maemo/modest-account-settings-dialog.h:
2743 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2744 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2746 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2748 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2749 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2750 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2752 * src/modest-defs.h:
2753 * src/maemo/modest-account-settings-dialog.c:
2754 (create_page_incoming), (on_combo_outgoing_security_changed),
2755 (on_combo_incoming_security_changed), (create_page_outgoing),
2756 (modest_account_settings_dialog_set_account_name),
2757 (save_configuration): Load/Save the port number, and change it when the
2758 security combo changes, to suitable defaults.
2760 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2762 * src/modest-account-mgr.c:
2763 (modest_account_mgr_add_server_account): Set the security and secure-auth
2764 options, and add a comment saying that the other camel-specific options should be
2767 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2769 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2771 * src/modest-tny-account-store.c: (account_list_free),
2772 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2773 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2776 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2778 * src/modest-protocol-info.c:
2779 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2780 is required by our UI spec. Maybe something in our implementation will use this eventually.
2781 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2782 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2783 instead of the previous 0 placeholder.
2785 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2786 secure-auth settings.
2787 * src/modest-account-mgr-helpers.h:
2788 * src/modest-account-mgr-helpers.c:
2789 (modest_server_account_data_get_option_secure_auth),
2790 (modest_server_account_set_option_secure_auth),
2791 (modest_server_account_data_get_option_security),
2792 (modest_server_account_set_option_security): Added this API for getting and setting the security
2793 and secure-auth settings.
2795 * src/maemo/modest-account-settings-dialog.h:
2796 * src/maemo/modest-account-settings-dialog.c:
2797 (modest_account_settings_dialog_finalize), (check_data),
2798 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2799 about changing titles.
2800 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2801 (save_configuration): Save the security and secure-auth settings.
2803 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2804 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2806 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2808 * src/modest-defs.h:
2809 * src/modest-account-mgr.c:
2810 (modest_account_mgr_add_server_account):
2811 Added and used defines for the options key and value pair strings,
2812 that are used so far, though they do not seem to correspond to anything in our
2813 UI specs or ModestProtocol enum.
2815 * src/modest-account-mgr-helpers.h:
2816 * src/modest-account-mgr-helpers.c:
2817 (compare_option_strings_for_name),
2818 (modest_server_account_data_get_option_value),
2819 (modest_server_account_data_get_option_bool),
2820 (modest_account_mgr_get_server_account_option):
2821 Added helper functions for parsing the options GSList.
2823 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2825 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2826 display name is based on the supplied account name.
2827 * src/modest-account-mgr.c:
2828 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2829 with an inefficient, but good-enough, implementation.
2831 * src/maemo/easysetup/modest-easysetup-wizard.c:
2832 (create_page_account_details), (on_before_next), (create_account):
2833 Check for existing display names rather than (non-user-visible) account names, and just
2834 create and set a unique account name at the end.
2836 * src/maemo/modest-account-settings-dialog.c:
2837 (modest_account_settings_dialog_init),
2838 (modest_account_settings_dialog_set_account_name),
2839 (create_page_incoming): Show the display name, instead of the account name.
2840 (on_response): Do some (not all) extra checks, as in the UI spec.
2841 (save_configuration): Save the display name if it was changed.
2843 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2845 * po/en_GB.po: Added needed logical ID and translation.
2846 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2847 (init_view): Made the is-default column clicking work.
2849 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2852 * src/maemo/easysetup/Makefile.am:
2853 * src/maemo/easysetup/modest-easysetup-wizard.c:
2854 (modest_easysetup_wizard_dialog_init):
2855 * src/maemo/easysetup/provider-data-test.keyfile:
2856 * src/maemo/easysetup/provider-data.keyfile:
2857 Moved the provider data file to the new modest-providers-data package and used it from there.
2859 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2861 * src/modest-local-folder-info.c:
2862 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2863 N_() was already used on the static strings, but this just marks it for translation without
2864 using the translation.
2866 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2868 * src/maemo/modest-account-settings-dialog.c:
2869 (create_page_incoming),
2870 (modest_account_settings_dialog_set_account_name):
2871 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2872 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2873 I will do this if nobody else gets there first.
2875 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2877 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2878 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2879 save the security stuff.
2881 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2883 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2884 Set the email address and user fullname, which I now see must be
2887 * src/maemo/modest-account-settings-dialog.h:
2888 * src/maemo/modest-account-settings-dialog.c:
2890 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2891 leave-on-server and authentication.
2892 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2895 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2898 * src/maemo/modest-account-settings-dialog.c:
2899 * src/maemo/modest-account-settings-dialog.h:
2900 Most (but not all) of the widgets are now present as specified by the UI spec.
2901 No changes are yet saved, and some details are not properly shown yet.
2903 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2905 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2907 * src/maemo/Makefile.am:
2908 * src/maemo/modest-account-settings-dialog.c:
2909 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2910 an existing account. Doesn't do much yet.
2912 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2913 Open the accounts settings dialog when Edit is clicked.
2915 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2917 * src/maemo/easysetup/Makefile.am:
2918 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2920 * src/maemo/easysetup/modest-easysetup-wizard.c:
2921 (modest_easysetup_wizard_dialog_init):
2922 Try to get the source directory from the build system,
2923 instead of hard-coding "./" into the source code, when opening our local
2924 copies of the configuration files.
2925 But this still fails when opening the wizard from the Accounts window,
2926 maybe because the working directory seems to change at runtime.
2927 So the wizard will fail the second time unless you copy the files into their
2928 proper locations - see the stdout warnings for the paths.
2930 (create_page_account_details),(on_before_next):
2931 Check for existing non-server accounts instead of server accounts,
2932 so the default account name is useful again, and to prevent trying to
2935 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2936 Show the wizard when New is clicked.
2938 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2939 (init_view): Show the column headers, and show the columns that are
2940 specified in the UI specs. However, something in Maemo's GTK+ prevents
2941 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2942 change the default account. This is despite unsetting the special properties.
2944 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2946 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2947 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2948 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2949 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2950 to make that clearer.
2951 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2953 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2955 * src/maemo/modest-account-view-window.c:
2956 (modest_account_view_window_init),
2957 (modest_account_view_window_new):
2958 Use the same buttons as specified in the
2959 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2960 the existing widgets, which never had a chance of working.
2961 Put the ModestAccountView treeview in a scrolled window.
2962 Do not repeat the initialization in both _init() and _new().
2964 * src/widgets/modest-account-view.c: (update_account_view):
2965 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2966 this widget and window shows no accounts.
2968 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2970 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2972 * src/maemo/easysetup/modest-easysetup-wizard.c:
2973 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2974 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2975 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2978 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2979 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2980 accounts exist yet, as in the UI spec.
2982 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2984 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2986 * src/maemo/Makefile.am:
2987 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2988 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2989 New window for editing connection-specific smtp details.
2990 Not fully implemented.
2992 * src/maemo/modest-connection-specific-smtp-window.c:
2993 (modest_connection_specific_smtp_window_finalize) :
2994 unref the tree model.
2995 (on_button_edit): Show the edit window.
2997 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2999 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3002 * src/maemo/Makefile.am:
3003 * src/maemo/modest-connection-specific-smtp-window.c:
3004 * src/maemo/modest-connection-specific-smtp-window.h:
3005 New window for showing the list of connections, for connection-specific
3006 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3007 * src/maemo/easysetup/modest-easysetup-wizard.c:
3008 (create_page_custom_outgoing): Show the new window when the button is clicked.
3010 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3012 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3013 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3014 * src/maemo/modest-msg-edit-window.c:
3015 (modest_msg_edit_window_insert_image):
3016 * src/modest-conf.c: (modest_conf_key_escape):
3017 * src/modest-mail-operation.c:
3018 (modest_mail_operation_send_new_mail):
3019 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3020 (modest_ui_actions_on_new_account):
3021 * src/widgets/modest-attachment-view.c: (update_filename_request):
3022 * src/widgets/modest-mail-header-view.c:
3023 Corrected warnings that were breaking the build, by commenting out unused variables,
3024 and a function, and by including a header.
3026 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3028 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3029 so we can #ifdef around platform-specific code when necessary.
3030 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3031 to allow this to build for the GNOME platform too.
3033 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3035 * src/maemo/easysetup/modest-easysetup-wizard.c:
3036 Added util_increment_name() and used it in create_page_account_details()
3037 to make sure that the default account name is always a new name.
3039 (modest_easysetup_wizard_dialog_init),
3040 (set_default_custom_servernames): Some minor memory management fixes.
3042 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3046 * src/modest-runtime.c: (init_i18n): Restored the translation
3047 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3048 are defined in config.h, and the translations are installed.
3050 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3051 is defined for translation.
3053 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3055 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3057 * src/maemo/easysetup/modest-easysetup-wizard.c:
3058 (modest_easysetup_wizard_dialog_init):
3059 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3060 Use realistic paths (though they should use $prefix generically) to the
3061 mcc_mapping and provider-data.keyfile files which might work when they
3062 are installed by the future version of the operator-wizard package,
3063 and then fallback to paths in our source code, with an explanatory
3066 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3070 * src/maemo/Makefile.am:
3071 * src/maemo/easysetup/: Added files from the previously-exernal
3072 osso-modest-easysetup.
3073 * src/maemo/modest-main-window-ui.h:
3074 * src/modest-ui-actions.c:
3075 * src/modest-ui-actions.h:
3076 Added modest_ui_actions_on_new_account() as a signal handler for the
3077 New Account menu item. It shows the easysetup wizard.
3078 * po/en_GB.po: Added additional needed logical IDs and translations.
3080 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
3081 Apparently ChangeLog is not used for some vague Nokia legal reasons.