196a9fa01d6cba3aaf91083a8ea9178826bacc57
[modest] / src / modest-account-mgr.c
1 /* Copyright (c) 2006, Nokia Corporation
2  * All rights reserved.
3  *
4  * Redistribution and use in source and binary forms, with or without
5  * modification, are permitted provided that the following conditions are
6  * met:
7  *
8  * * Redistributions of source code must retain the above copyright
9  *   notice, this list of conditions and the following disclaimer.
10  * * Redistributions in binary form must reproduce the above copyright
11  *   notice, this list of conditions and the following disclaimer in the
12  *   documentation and/or other materials provided with the distribution.
13  * * Neither the name of the Nokia Corporation nor the names of its
14  *   contributors may be used to endorse or promote products derived from
15  *   this software without specific prior written permission.
16  *
17  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
18  * IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
19  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
20  * PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER
21  * OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
22  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
23  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
24  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
25  * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
26  * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
27  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28  */
29
30 #include <string.h>
31 #include <modest-marshal.h>
32 #include <modest-account-mgr.h>
33 #include <modest-account-mgr-priv.h>
34 #include <modest-account-mgr-helpers.h>
35
36 /* 'private'/'protected' functions */
37 static void modest_account_mgr_class_init (ModestAccountMgrClass * klass);
38 static void modest_account_mgr_init       (ModestAccountMgr * obj);
39 static void modest_account_mgr_finalize   (GObject * obj);
40
41 /* list my signals */
42 enum {
43         ACCOUNT_CHANGED_SIGNAL,
44         ACCOUNT_REMOVED_SIGNAL,
45         LAST_SIGNAL
46 };
47
48
49 /* globals */
50 static GObjectClass *parent_class = NULL;
51 static guint signals[LAST_SIGNAL] = {0};
52
53 static void
54 on_key_change (ModestConf *conf, const gchar *key, ModestConfEvent event, gpointer user_data)
55 {
56         ModestAccountMgr *self;
57         ModestAccountMgrPrivate *priv;
58
59         gchar *account;
60         gboolean is_account_key, is_server_account;
61         gboolean enabled;
62
63         self = MODEST_ACCOUNT_MGR (user_data);
64         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
65         
66         account = _modest_account_mgr_account_from_key (key, &is_account_key, &is_server_account);
67
68         /* if this is not an account-related key change, ignore */
69         if (!account)
70                 return;
71
72         /* account was removed -- emit this, even if the account was disabled */
73         if (is_account_key && event == MODEST_CONF_EVENT_KEY_UNSET) {
74                 g_signal_emit (G_OBJECT(self), signals[ACCOUNT_REMOVED_SIGNAL], 0,
75                                account, is_server_account);
76                 g_free (account);
77                 return;
78         }
79
80         /* is this account enabled? */
81         if (is_server_account)
82                 enabled = TRUE;
83         else 
84                 enabled = modest_account_mgr_account_get_enabled (self, account);
85
86         /* account was changed.
87          * and always notify when enabled/disabled changes
88          */
89         if (enabled || g_str_has_suffix (key, MODEST_ACCOUNT_ENABLED)) 
90                 g_signal_emit (G_OBJECT(self), signals[ACCOUNT_CHANGED_SIGNAL], 0,
91                                account, key, is_server_account);
92
93         g_free (account);
94 }
95
96
97 GType
98 modest_account_mgr_get_type (void)
99 {
100         static GType my_type = 0;
101
102         if (!my_type) {
103                 static const GTypeInfo my_info = {
104                         sizeof (ModestAccountMgrClass),
105                         NULL,   /* base init */
106                         NULL,   /* base finalize */
107                         (GClassInitFunc) modest_account_mgr_class_init,
108                         NULL,   /* class finalize */
109                         NULL,   /* class data */
110                         sizeof (ModestAccountMgr),
111                         1,      /* n_preallocs */
112                         (GInstanceInitFunc) modest_account_mgr_init,
113                         NULL
114                 };
115
116                 my_type = g_type_register_static (G_TYPE_OBJECT,
117                                                   "ModestAccountMgr",
118                                                   &my_info, 0);
119         }
120         return my_type;
121 }
122
123 static void
124 modest_account_mgr_class_init (ModestAccountMgrClass * klass)
125 {
126         GObjectClass *gobject_class;
127         gobject_class = (GObjectClass *) klass;
128
129         parent_class = g_type_class_peek_parent (klass);
130         gobject_class->finalize = modest_account_mgr_finalize;
131
132         g_type_class_add_private (gobject_class,
133                                   sizeof (ModestAccountMgrPrivate));
134
135         /* signal definitions */
136         signals[ACCOUNT_REMOVED_SIGNAL] =
137                 g_signal_new ("account_removed",
138                               G_TYPE_FROM_CLASS (klass),
139                               G_SIGNAL_RUN_FIRST,
140                               G_STRUCT_OFFSET(ModestAccountMgrClass,account_removed),
141                               NULL, NULL,
142                               modest_marshal_VOID__STRING_BOOLEAN,
143                               G_TYPE_NONE, 2, G_TYPE_STRING, G_TYPE_BOOLEAN);
144         signals[ACCOUNT_CHANGED_SIGNAL] =
145                 g_signal_new ("account_changed",
146                                G_TYPE_FROM_CLASS (klass),
147                               G_SIGNAL_RUN_FIRST,
148                               G_STRUCT_OFFSET(ModestAccountMgrClass,account_changed),
149                               NULL, NULL,
150                               modest_marshal_VOID__STRING_STRING_BOOLEAN,
151                               G_TYPE_NONE, 3, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_BOOLEAN);
152 }
153
154
155 static void
156 modest_account_mgr_init (ModestAccountMgr * obj)
157 {
158         ModestAccountMgrPrivate *priv =
159                 MODEST_ACCOUNT_MGR_GET_PRIVATE (obj);
160
161         priv->modest_conf = NULL;
162 }
163
164 static void
165 modest_account_mgr_finalize (GObject * obj)
166 {
167         ModestAccountMgrPrivate *priv =
168                 MODEST_ACCOUNT_MGR_GET_PRIVATE (obj);
169
170         if (priv->modest_conf) {
171                 g_object_unref (G_OBJECT(priv->modest_conf));
172                 priv->modest_conf = NULL;
173         }
174
175         G_OBJECT_CLASS(parent_class)->finalize (obj);
176 }
177
178 ModestAccountMgr *
179 modest_account_mgr_new (ModestConf * conf)
180 {
181         GObject *obj;
182         ModestAccountMgrPrivate *priv;
183
184         g_return_val_if_fail (conf, NULL);
185
186         obj = G_OBJECT (g_object_new (MODEST_TYPE_ACCOUNT_MGR, NULL));
187         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (obj);
188
189         g_object_ref (G_OBJECT(conf));
190         priv->modest_conf = conf;
191
192         g_signal_connect (G_OBJECT (conf), "key_changed",
193                           G_CALLBACK (on_key_change),
194                           obj);
195         
196         return MODEST_ACCOUNT_MGR (obj);
197 }
198
199
200 static const gchar *
201 null_means_empty (const gchar * str)
202 {
203         return str ? str : "";
204 }
205
206
207 gboolean
208 modest_account_mgr_add_account (ModestAccountMgr *self,
209                                 const gchar *name,
210                                 const gchar *store_account,
211                                 const gchar *transport_account,
212                                 GError **err)
213 {
214         ModestAccountMgrPrivate *priv;
215         gchar *key;
216         gboolean ok;
217
218         g_return_val_if_fail (self, FALSE);
219         g_return_val_if_fail (name, FALSE);
220         g_return_val_if_fail (strchr(name, '/') == NULL, FALSE);
221         
222         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
223         
224         /*
225          * we create the account by adding an account 'dir', with the name <name>,
226          * and in that the 'display_name' string key
227          */
228         key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_DISPLAY_NAME, FALSE);
229         if (modest_account_mgr_account_exists (self, key, FALSE, err)) {
230                 g_printerr ("modest: account already exists\n");
231                 g_free (key);
232                 return FALSE;
233         }
234         
235         ok = modest_conf_set_string (priv->modest_conf, key, name, err);
236         g_free (key);
237         if (!ok) {
238                 g_printerr ("modest: cannot set display name\n");
239                 return FALSE;
240         }
241         
242         if (store_account) {
243                 key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_STORE_ACCOUNT, FALSE);
244                 ok = modest_conf_set_string (priv->modest_conf, key, store_account, err);
245                 g_free (key);
246                 if (!ok) {
247                         g_printerr ("modest: failed to set store account '%s'\n",
248                                 store_account);
249                         return FALSE;
250                 }
251         }
252
253         if (transport_account) {
254                 key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_TRANSPORT_ACCOUNT, FALSE);
255                 ok = modest_conf_set_string (priv->modest_conf, key, transport_account, err);
256                 g_free (key);
257                 if (!ok) {
258                         g_printerr ("modest: failed to set transport account '%s'\n",
259                                 transport_account);
260                         return FALSE;
261                 }
262         }
263
264         modest_account_mgr_account_set_enabled (self, name, TRUE);
265         
266         return TRUE;
267 }
268
269
270
271
272 gboolean
273 modest_account_mgr_add_server_account (ModestAccountMgr * self,
274                                        const gchar * name, const gchar *hostname,
275                                        const gchar * username, const gchar * password,
276                                        ModestProtocol proto)
277 {
278         ModestAccountMgrPrivate *priv;
279         gchar *key;
280         ModestProtocolType proto_type;
281         
282         g_return_val_if_fail (self, FALSE);
283         g_return_val_if_fail (name, FALSE);
284         g_return_val_if_fail (strchr(name, '/') == NULL, FALSE);
285
286         proto_type = modest_protocol_info_get_protocol_type (proto);
287         g_return_val_if_fail (proto_type == MODEST_PROTOCOL_TYPE_TRANSPORT ||
288                               proto_type == MODEST_PROTOCOL_TYPE_STORE, FALSE);
289                               
290         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
291         
292         /* hostname */
293         key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_HOSTNAME, TRUE);
294         if (modest_conf_key_exists (priv->modest_conf, key, NULL)) {
295                 g_printerr ("modest: server account '%s' already exists", name);
296                 g_free (key);
297                 return FALSE;
298         }
299         
300         modest_conf_set_string (priv->modest_conf, key, null_means_empty(hostname), NULL);
301         g_free (key);
302
303         /* username */
304         key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_USERNAME, TRUE);
305         modest_conf_set_string (priv->modest_conf, key, null_means_empty (username), NULL);
306         g_free (key);
307
308         /* password */
309         key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_PASSWORD, TRUE);
310         modest_conf_set_string (priv->modest_conf, key, null_means_empty (password), NULL);
311         g_free (key);
312
313         /* proto */
314         key = _modest_account_mgr_get_account_keyname (name, MODEST_ACCOUNT_PROTO, TRUE);
315         modest_conf_set_string (priv->modest_conf, key,
316                                 modest_protocol_info_get_protocol_name(proto),
317                                 NULL);
318         g_free (key);
319         
320         return TRUE;
321 }
322
323
324
325 gboolean
326 modest_account_mgr_remove_account (ModestAccountMgr * self,
327                                    const gchar * name,
328                                    gboolean server_account,
329                                    GError ** err)
330 {
331         ModestAccountMgrPrivate *priv;
332         gchar *key;
333         gboolean retval;
334
335         g_return_val_if_fail (self, FALSE);
336         g_return_val_if_fail (name, FALSE);
337
338         if (!modest_account_mgr_account_exists (self, name, server_account, err)) {
339                 g_printerr ("modest: account '%s' does not exist\n", name);
340                 return FALSE;
341         }
342
343         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
344         key = _modest_account_mgr_get_account_keyname (name, NULL, server_account);
345
346         retval = modest_conf_remove_key (priv->modest_conf, key, NULL);
347
348         g_free (key);
349         return retval;
350 }
351
352
353
354 /* strip the first /n/ character from each element
355  * caller must make sure all elements are strings with
356  * length >= n, and also that data can be freed.
357  * change is in-place
358  */
359 static void
360 strip_prefix_from_elements (GSList * lst, guint n)
361 {
362         while (lst) {
363                 memmove (lst->data, lst->data + n,
364                          strlen(lst->data) - n + 1);
365                 lst = lst->next;
366         }
367 }
368
369
370 GSList*
371 modest_account_mgr_search_server_accounts (ModestAccountMgr * self,
372                                            const gchar * account_name,
373                                            ModestProtocolType type,
374                                            ModestProtocol proto)
375 {
376         GSList *accounts;
377         GSList *cursor;
378         ModestAccountMgrPrivate *priv;
379         gchar *key;
380         GError *err = NULL;
381         
382         g_return_val_if_fail (self, NULL);
383
384         if (proto != MODEST_PROTOCOL_UNKNOWN) {
385                 ModestProtocolType proto_type;
386                 proto_type = modest_protocol_info_get_protocol_type (proto);
387                 g_return_val_if_fail (proto_type == MODEST_PROTOCOL_TYPE_TRANSPORT ||
388                                       proto_type == MODEST_PROTOCOL_TYPE_STORE, NULL);
389         }
390         
391         key      = _modest_account_mgr_get_account_keyname (account_name, NULL, TRUE);
392         priv     = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
393         
394         /* get the list of all server accounts */
395         accounts = modest_conf_list_subkeys (priv->modest_conf, key, &err);
396         if (err) {
397                 g_error_free (err);
398                 g_printerr ("modest: failed to get subkeys for '%s'\n", key);
399                 return NULL;
400         }
401         
402         /* filter out the ones with the wrong protocol */
403         /* we could optimize for unknown proto / unknown type, but it will only
404          * make the code more complex */
405         cursor = accounts;
406         while (cursor) { 
407                 gchar *account   = _modest_account_mgr_account_from_key ((gchar*)cursor->data, NULL, NULL);
408                 gchar *acc_proto = modest_account_mgr_get_string (self, account, MODEST_ACCOUNT_PROTO,
409                                                                   TRUE, NULL);
410                 ModestProtocol     this_proto = modest_protocol_info_get_protocol (acc_proto);
411                 ModestProtocolType this_type  = modest_protocol_info_get_protocol_type (this_proto);
412
413                 if ((this_type  != MODEST_PROTOCOL_TYPE_UNKNOWN && this_type  != type) ||
414                     (this_proto != MODEST_PROTOCOL_UNKNOWN      && this_proto != proto)) {
415                         GSList *nxt = cursor->next;
416                         accounts = g_slist_delete_link (accounts, cursor);
417                         cursor = nxt;
418                 } else
419                         cursor = cursor->next;
420                 
421                 g_free (account);
422                 g_free (acc_proto);
423         }
424         
425         /* +1 because we must remove the ending '/' as well */
426         strip_prefix_from_elements (accounts, strlen(key)+1);
427         return accounts;        
428 }
429
430
431 GSList*
432 modest_account_mgr_account_names (ModestAccountMgr * self, GError ** err)
433 {
434         GSList *accounts;
435         ModestAccountMgrPrivate *priv;
436         const size_t prefix_len = strlen (MODEST_ACCOUNT_NAMESPACE "/");
437
438         g_return_val_if_fail (self, NULL);
439
440         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
441
442         accounts = modest_conf_list_subkeys (priv->modest_conf,
443                                              MODEST_ACCOUNT_NAMESPACE, err);
444         
445         strip_prefix_from_elements (accounts, prefix_len);
446         return accounts;
447 }
448
449
450
451 gchar *
452 modest_account_mgr_get_string (ModestAccountMgr *self, const gchar *name,
453                                const gchar *key, gboolean server_account, GError **err) {
454
455         ModestAccountMgrPrivate *priv;
456
457         gchar *keyname;
458         gchar *retval;
459
460         g_return_val_if_fail (self, NULL);
461         g_return_val_if_fail (name, NULL);
462         g_return_val_if_fail (key, NULL);
463
464         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
465         
466         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
467         retval = modest_conf_get_string (priv->modest_conf, keyname, err);
468         g_free (keyname);
469
470         return retval;
471 }
472
473
474 gint
475 modest_account_mgr_get_int (ModestAccountMgr *self, const gchar *name,
476                             const gchar *key, gboolean server_account, GError **err)
477 {
478         ModestAccountMgrPrivate *priv;
479
480         gchar *keyname;
481         gint retval;
482
483         g_return_val_if_fail (self, -1);
484         g_return_val_if_fail (name, -1);
485         g_return_val_if_fail (key, -1);
486
487         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
488
489         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
490         retval = modest_conf_get_int (priv->modest_conf, keyname, err);
491         g_free (keyname);
492
493         return retval;
494 }
495
496
497
498 gboolean
499 modest_account_mgr_get_bool (ModestAccountMgr * self, const gchar *account,
500                              const gchar * key, gboolean server_account, GError ** err)
501 {
502         ModestAccountMgrPrivate *priv;
503
504         gchar *keyname;
505         gboolean retval;
506
507         g_return_val_if_fail (self, FALSE);
508         g_return_val_if_fail (account, FALSE);
509         g_return_val_if_fail (key, FALSE);
510
511         keyname = _modest_account_mgr_get_account_keyname (account, key, server_account);
512         
513         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
514         retval = modest_conf_get_bool (priv->modest_conf, keyname, err);
515                 
516         g_free (keyname);
517
518         return retval;
519 }
520
521
522 gboolean
523 modest_account_mgr_set_string (ModestAccountMgr * self, const gchar * name,
524                                const gchar * key, const gchar * val,
525                                gboolean server_account, GError ** err)
526 {
527         ModestAccountMgrPrivate *priv;
528
529         gchar *keyname;
530         gboolean retval;
531
532         g_return_val_if_fail (self, FALSE);
533         g_return_val_if_fail (name, FALSE);
534         g_return_val_if_fail (key, FALSE);
535
536         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
537         
538         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
539
540         retval = modest_conf_set_string (priv->modest_conf, keyname, val,
541                                          err);
542
543         g_free (keyname);
544         return retval;
545 }
546
547
548 gboolean
549 modest_account_mgr_set_int (ModestAccountMgr * self, const gchar * name,
550                             const gchar * key, int val, gboolean server_account,
551                             GError ** err)
552 {
553         ModestAccountMgrPrivate *priv;
554
555         gchar *keyname;
556         gboolean retval;
557
558         g_return_val_if_fail (self, FALSE);
559         g_return_val_if_fail (name, FALSE);
560         g_return_val_if_fail (key, FALSE);
561
562         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
563         
564         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
565
566         retval = modest_conf_set_int (priv->modest_conf, keyname, val, err);
567
568         g_free (keyname);
569         return retval;
570 }
571
572
573
574 gboolean
575 modest_account_mgr_set_bool (ModestAccountMgr * self, const gchar * name,
576                              const gchar * key, gboolean val, gboolean server_account, 
577                              GError ** err)
578 {
579         ModestAccountMgrPrivate *priv;
580
581         gchar *keyname;
582         gboolean retval;
583
584         g_return_val_if_fail (self, FALSE);
585         g_return_val_if_fail (name, FALSE);
586         g_return_val_if_fail (key, FALSE);
587
588         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
589
590         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
591
592         retval = modest_conf_set_bool (priv->modest_conf, keyname, val, err);
593
594         g_free (keyname);
595         return retval;
596 }
597
598 void 
599 modest_account_mgr_set_list (ModestAccountMgr *self,
600                              const gchar *name,
601                              const gchar *key,
602                              GSList *val,
603                              ModestConfValueType list_type,
604                              gboolean server_account,
605                              GError **err)
606 {
607         ModestAccountMgrPrivate *priv;
608         gchar *keyname;
609         
610         g_return_if_fail (self);
611         g_return_if_fail (name);
612         g_return_if_fail (key);
613         g_return_if_fail (val);
614
615         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
616         
617         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
618         modest_conf_set_list (priv->modest_conf, keyname, val, list_type, err);
619         g_free (keyname);
620 }
621
622 gboolean
623 modest_account_mgr_account_exists (ModestAccountMgr * self, const gchar * name,
624                                    gboolean server_account, GError ** err)
625 {
626         ModestAccountMgrPrivate *priv;
627
628         gchar *keyname;
629         gboolean retval;
630
631         g_return_val_if_fail (self, FALSE);
632         g_return_val_if_fail (name, FALSE);
633
634         keyname = _modest_account_mgr_get_account_keyname (name, NULL, server_account);
635
636         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
637         retval = modest_conf_key_exists (priv->modest_conf, keyname, err);
638
639         g_free (keyname);
640         return retval;
641 }
642
643
644 GSList * 
645 modest_account_mgr_get_list (ModestAccountMgr *self,
646                              const gchar *name,
647                              const gchar *key,
648                              ModestConfValueType list_type,
649                              gboolean server_account,
650                              GError **err)
651 {
652         ModestAccountMgrPrivate *priv;
653
654         gchar *keyname;
655         GSList *retval;
656         
657         g_return_val_if_fail (self, NULL);
658         g_return_val_if_fail (name, NULL);
659         g_return_val_if_fail (key, NULL);
660
661         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
662         
663         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
664         retval = modest_conf_get_list (priv->modest_conf, keyname, list_type, err);
665         g_free (keyname);
666
667         return retval;
668 }
669
670
671 gboolean 
672 modest_account_mgr_unset (ModestAccountMgr *self,
673                           const gchar *name,
674                           const gchar *key,
675                           gboolean server_account,
676                           GError **err)
677 {
678         ModestAccountMgrPrivate *priv;
679
680         gchar *keyname;
681         gboolean retval;
682
683         g_return_val_if_fail (self, FALSE);
684         g_return_val_if_fail (name, FALSE);
685         g_return_val_if_fail (key, FALSE);
686
687         keyname = _modest_account_mgr_get_account_keyname (name, key, server_account);
688
689         priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
690         retval = modest_conf_remove_key (priv->modest_conf, keyname, err);
691
692         g_free (keyname);
693         return retval;
694 }